{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/comments/150843291","pull_request_review_id":76452560,"id":150843291,"diff_hunk":"@@ -182,7 +183,7 @@ Inexact equality comparison between polynomials: returns `true` if\n `norm(x-y,1) <= atol + rtol*max(norm(x,1), norm(y,1))`, where `x` and `y` are\n polynomials. For more details, see [`Base.isapprox`](@ref).\n \"\"\"\n-function isapprox(x::T, y::S; rtol::Real=rtoldefault(x,y), atol::Real=0,\n+function isapprox(x::T, y::S; rtol::Real=rtoldefault(x,y), atol::Real=0.0,","path":"src/other_functions.jl","position":46,"original_position":46,"commit_id":"fc11d4ae9164b155260bfc4a632ad9fb238a22e4","original_commit_id":"fc11d4ae9164b155260bfc4a632ad9fb238a22e4","user":{"login":"lbenet","id":5237744,"avatar_url":"https://avatars0.githubusercontent.com/u/5237744?v=4","gravatar_id":"","url":"https://api.github.com/users/lbenet","html_url":"https://github.com/lbenet","followers_url":"https://api.github.com/users/lbenet/followers","following_url":"https://api.github.com/users/lbenet/following{/other_user}","gists_url":"https://api.github.com/users/lbenet/gists{/gist_id}","starred_url":"https://api.github.com/users/lbenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbenet/subscriptions","organizations_url":"https://api.github.com/users/lbenet/orgs","repos_url":"https://api.github.com/users/lbenet/repos","events_url":"https://api.github.com/users/lbenet/events{/privacy}","received_events_url":"https://api.github.com/users/lbenet/received_events","type":"User","site_admin":false},"body":"`atol` is usually some sort of Float; I though like this I avoided a conversion. I am leaving it as it is, buty it may be changed eventually.","created_at":"2017-11-14T14:14:28Z","updated_at":"2017-11-14T14:14:28Z","html_url":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/135#discussion_r150843291","pull_request_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/135","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/comments/150843291"},"html":{"href":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/135#discussion_r150843291"},"pull_request":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/135"}},"in_reply_to_id":150709922},"pull_request":{"url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/135","id":150730797,"html_url":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/135","diff_url":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/135.diff","patch_url":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/135.patch","issue_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/135","number":135,"state":"open","locked":false,"title":"Change indexing to start from zero","user":{"login":"lbenet","id":5237744,"avatar_url":"https://avatars0.githubusercontent.com/u/5237744?v=4","gravatar_id":"","url":"https://api.github.com/users/lbenet","html_url":"https://github.com/lbenet","followers_url":"https://api.github.com/users/lbenet/followers","following_url":"https://api.github.com/users/lbenet/following{/other_user}","gists_url":"https://api.github.com/users/lbenet/gists{/gist_id}","starred_url":"https://api.github.com/users/lbenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbenet/subscriptions","organizations_url":"https://api.github.com/users/lbenet/orgs","repos_url":"https://api.github.com/users/lbenet/repos","events_url":"https://api.github.com/users/lbenet/events{/privacy}","received_events_url":"https://api.github.com/users/lbenet/received_events","type":"User","site_admin":false},"body":"Fixes issue #133, to start indexing from 0.","created_at":"2017-11-05T16:42:31Z","updated_at":"2017-11-14T14:14:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bc21ae11c426c262512165a622bcfa908fb96e1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/135/commits","review_comments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/135/comments","review_comment_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/135/comments","statuses_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/statuses/fc11d4ae9164b155260bfc4a632ad9fb238a22e4","head":{"label":"JuliaDiff:lb/zero_index","ref":"lb/zero_index","sha":"fc11d4ae9164b155260bfc4a632ad9fb238a22e4","user":{"login":"JuliaDiff","id":7750915,"avatar_url":"https://avatars0.githubusercontent.com/u/7750915?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiff","html_url":"https://github.com/JuliaDiff","followers_url":"https://api.github.com/users/JuliaDiff/followers","following_url":"https://api.github.com/users/JuliaDiff/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiff/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiff/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiff/orgs","repos_url":"https://api.github.com/users/JuliaDiff/repos","events_url":"https://api.github.com/users/JuliaDiff/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiff/received_events","type":"Organization","site_admin":false},"repo":{"id":17322687,"name":"TaylorSeries.jl","full_name":"JuliaDiff/TaylorSeries.jl","owner":{"login":"JuliaDiff","id":7750915,"avatar_url":"https://avatars0.githubusercontent.com/u/7750915?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiff","html_url":"https://github.com/JuliaDiff","followers_url":"https://api.github.com/users/JuliaDiff/followers","following_url":"https://api.github.com/users/JuliaDiff/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiff/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiff/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiff/orgs","repos_url":"https://api.github.com/users/JuliaDiff/repos","events_url":"https://api.github.com/users/JuliaDiff/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiff/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaDiff/TaylorSeries.jl","description":"A julia package for Taylor expansions in one or more independent variables.","fork":false,"url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl","forks_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/forks","keys_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/events","assignees_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/merges","archive_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/deployments","created_at":"2014-03-01T19:43:17Z","updated_at":"2017-11-07T15:08:52Z","pushed_at":"2017-11-11T00:50:21Z","git_url":"git://github.com/JuliaDiff/TaylorSeries.jl.git","ssh_url":"git@github.com:JuliaDiff/TaylorSeries.jl.git","clone_url":"https://github.com/JuliaDiff/TaylorSeries.jl.git","svn_url":"https://github.com/JuliaDiff/TaylorSeries.jl","homepage":"","size":2327,"stargazers_count":24,"watchers_count":24,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":23,"forks":16,"open_issues":23,"watchers":24,"default_branch":"master"}},"base":{"label":"JuliaDiff:master","ref":"master","sha":"88c73c473f9e258d9fceb6a3e8efa58a47959b4b","user":{"login":"JuliaDiff","id":7750915,"avatar_url":"https://avatars0.githubusercontent.com/u/7750915?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiff","html_url":"https://github.com/JuliaDiff","followers_url":"https://api.github.com/users/JuliaDiff/followers","following_url":"https://api.github.com/users/JuliaDiff/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiff/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiff/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiff/orgs","repos_url":"https://api.github.com/users/JuliaDiff/repos","events_url":"https://api.github.com/users/JuliaDiff/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiff/received_events","type":"Organization","site_admin":false},"repo":{"id":17322687,"name":"TaylorSeries.jl","full_name":"JuliaDiff/TaylorSeries.jl","owner":{"login":"JuliaDiff","id":7750915,"avatar_url":"https://avatars0.githubusercontent.com/u/7750915?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaDiff","html_url":"https://github.com/JuliaDiff","followers_url":"https://api.github.com/users/JuliaDiff/followers","following_url":"https://api.github.com/users/JuliaDiff/following{/other_user}","gists_url":"https://api.github.com/users/JuliaDiff/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaDiff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaDiff/subscriptions","organizations_url":"https://api.github.com/users/JuliaDiff/orgs","repos_url":"https://api.github.com/users/JuliaDiff/repos","events_url":"https://api.github.com/users/JuliaDiff/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaDiff/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaDiff/TaylorSeries.jl","description":"A julia package for Taylor expansions in one or more independent variables.","fork":false,"url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl","forks_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/forks","keys_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/teams","hooks_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/hooks","issue_events_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/events","assignees_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/tags","blobs_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/languages","stargazers_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/stargazers","contributors_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/contributors","subscribers_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/subscribers","subscription_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/subscription","commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/merges","archive_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/downloads","issues_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/labels{/name}","releases_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/deployments","created_at":"2014-03-01T19:43:17Z","updated_at":"2017-11-07T15:08:52Z","pushed_at":"2017-11-11T00:50:21Z","git_url":"git://github.com/JuliaDiff/TaylorSeries.jl.git","ssh_url":"git@github.com:JuliaDiff/TaylorSeries.jl.git","clone_url":"https://github.com/JuliaDiff/TaylorSeries.jl.git","svn_url":"https://github.com/JuliaDiff/TaylorSeries.jl","homepage":"","size":2327,"stargazers_count":24,"watchers_count":24,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":23,"forks":16,"open_issues":23,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/135"},"html":{"href":"https://github.com/JuliaDiff/TaylorSeries.jl/pull/135"},"issue":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/135"},"comments":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaDiff/TaylorSeries.jl/statuses/fc11d4ae9164b155260bfc4a632ad9fb238a22e4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lbenet"}}