{"action":"closed","issue":{"url":"https://api.github.com/repos/alphagov/asset-manager/issues/136","repository_url":"https://api.github.com/repos/alphagov/asset-manager","labels_url":"https://api.github.com/repos/alphagov/asset-manager/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/asset-manager/issues/136/comments","events_url":"https://api.github.com/repos/alphagov/asset-manager/issues/136/events","html_url":"https://github.com/alphagov/asset-manager/issues/136","id":250952472,"number":136,"title":"Move non-secret config to govuk-puppet","user":{"login":"chrisroos","id":6556,"avatar_url":"https://avatars2.githubusercontent.com/u/6556?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisroos","html_url":"https://github.com/chrisroos","followers_url":"https://api.github.com/users/chrisroos/followers","following_url":"https://api.github.com/users/chrisroos/following{/other_user}","gists_url":"https://api.github.com/users/chrisroos/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisroos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisroos/subscriptions","organizations_url":"https://api.github.com/users/chrisroos/orgs","repos_url":"https://api.github.com/users/chrisroos/repos","events_url":"https://api.github.com/users/chrisroos/events{/privacy}","received_events_url":"https://api.github.com/users/chrisroos/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"chrisroos","id":6556,"avatar_url":"https://avatars2.githubusercontent.com/u/6556?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisroos","html_url":"https://github.com/chrisroos","followers_url":"https://api.github.com/users/chrisroos/followers","following_url":"https://api.github.com/users/chrisroos/following{/other_user}","gists_url":"https://api.github.com/users/chrisroos/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisroos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisroos/subscriptions","organizations_url":"https://api.github.com/users/chrisroos/orgs","repos_url":"https://api.github.com/users/chrisroos/repos","events_url":"https://api.github.com/users/chrisroos/events{/privacy}","received_events_url":"https://api.github.com/users/chrisroos/received_events","type":"User","site_admin":false},"assignees":[{"login":"chrisroos","id":6556,"avatar_url":"https://avatars2.githubusercontent.com/u/6556?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisroos","html_url":"https://github.com/chrisroos","followers_url":"https://api.github.com/users/chrisroos/followers","following_url":"https://api.github.com/users/chrisroos/following{/other_user}","gists_url":"https://api.github.com/users/chrisroos/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisroos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisroos/subscriptions","organizations_url":"https://api.github.com/users/chrisroos/orgs","repos_url":"https://api.github.com/users/chrisroos/repos","events_url":"https://api.github.com/users/chrisroos/events{/privacy}","received_events_url":"https://api.github.com/users/chrisroos/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-08-17T13:56:02Z","updated_at":"2017-08-30T10:49:32Z","closed_at":"2017-08-30T10:49:32Z","author_association":"CONTRIBUTOR","body":"Some of our non-secret asset-manager configuration options (e.g. the `AWS_S3_BUCKET_NAME` environment variable) are currently set in govuk-secrets. This is unnecessary (because they're not secret) and makes them hard for us to change (because we don't have access to the secrets repo). We _think_ it's possible to move these config options to govuk-puppet which would allow us to change them when required.\r\n\r\n## Todo\r\n\r\n- [x] Ask someone to check that the values in my PR match those in govuk-secrets\r\n- [x] Merge and deploy my PR\r\n- [x] Ask someone to remove the equivalent values from govuk-secrets\r\n"}}
{"actor":{"display_login":"chrisroos"}}