{"action":"closed","number":39,"pull_request":{"url":"https://api.github.com/repos/m3db/m3x/pulls/39","id":100877694,"html_url":"https://github.com/m3db/m3x/pull/39","diff_url":"https://github.com/m3db/m3x/pull/39.diff","patch_url":"https://github.com/m3db/m3x/pull/39.patch","issue_url":"https://api.github.com/repos/m3db/m3x/issues/39","number":39,"state":"closed","locked":false,"title":"Track checked finalize events and use as the for marking traceback cycle end","user":{"login":"robskillington","id":339615,"avatar_url":"https://avatars.githubusercontent.com/u/339615?v=3","gravatar_id":"","url":"https://api.github.com/users/robskillington","html_url":"https://github.com/robskillington","followers_url":"https://api.github.com/users/robskillington/followers","following_url":"https://api.github.com/users/robskillington/following{/other_user}","gists_url":"https://api.github.com/users/robskillington/gists{/gist_id}","starred_url":"https://api.github.com/users/robskillington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robskillington/subscriptions","organizations_url":"https://api.github.com/users/robskillington/orgs","repos_url":"https://api.github.com/users/robskillington/repos","events_url":"https://api.github.com/users/robskillington/events{/privacy}","received_events_url":"https://api.github.com/users/robskillington/received_events","type":"User","site_admin":false},"body":"Before we were using a decref to ref zero as the traceback cycle end, however the true cycle end is when the owner finalizes the object (essentially calling it's destructor).  \r\n\r\nThis begins tracking it in the tracebacks and uses it as the cycle end instead of decref to ref zero.\r\n\r\ncc @kobolog @xichen2020","created_at":"2017-01-10T13:57:07Z","updated_at":"2017-01-10T15:02:04Z","closed_at":"2017-01-10T15:02:04Z","merged_at":"2017-01-10T15:02:04Z","merge_commit_sha":"0fc7c97353d49cd98d628db1415aa606320aea77","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3x/pulls/39/commits","review_comments_url":"https://api.github.com/repos/m3db/m3x/pulls/39/comments","review_comment_url":"https://api.github.com/repos/m3db/m3x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3x/issues/39/comments","statuses_url":"https://api.github.com/repos/m3db/m3x/statuses/0acd898292d3afd0a5fb6e746b68c9165ff89523","head":{"label":"m3db:r/use-finalize-as-traceback-cycle-end","ref":"r/use-finalize-as-traceback-cycle-end","sha":"0acd898292d3afd0a5fb6e746b68c9165ff89523","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":64251470,"name":"m3x","full_name":"m3db/m3x","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3x","description":"Common utility classes used across M3 components","fork":false,"url":"https://api.github.com/repos/m3db/m3x","forks_url":"https://api.github.com/repos/m3db/m3x/forks","keys_url":"https://api.github.com/repos/m3db/m3x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3x/teams","hooks_url":"https://api.github.com/repos/m3db/m3x/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3x/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3x/events","assignees_url":"https://api.github.com/repos/m3db/m3x/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3x/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3x/tags","blobs_url":"https://api.github.com/repos/m3db/m3x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3x/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3x/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3x/languages","stargazers_url":"https://api.github.com/repos/m3db/m3x/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3x/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3x/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3x/subscription","commits_url":"https://api.github.com/repos/m3db/m3x/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3x/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3x/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3x/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3x/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3x/merges","archive_url":"https://api.github.com/repos/m3db/m3x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3x/downloads","issues_url":"https://api.github.com/repos/m3db/m3x/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3x/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3x/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3x/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3x/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3x/deployments","created_at":"2016-07-26T20:16:52Z","updated_at":"2016-10-23T22:42:11Z","pushed_at":"2017-01-10T15:02:04Z","git_url":"git://github.com/m3db/m3x.git","ssh_url":"git@github.com:m3db/m3x.git","clone_url":"https://github.com/m3db/m3x.git","svn_url":"https://github.com/m3db/m3x","homepage":null,"size":119,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"4793bdfe6fb85eddbb8567229163c33533e34836","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":64251470,"name":"m3x","full_name":"m3db/m3x","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars.githubusercontent.com/u/19937171?v=3","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3x","description":"Common utility classes used across M3 components","fork":false,"url":"https://api.github.com/repos/m3db/m3x","forks_url":"https://api.github.com/repos/m3db/m3x/forks","keys_url":"https://api.github.com/repos/m3db/m3x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3x/teams","hooks_url":"https://api.github.com/repos/m3db/m3x/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3x/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3x/events","assignees_url":"https://api.github.com/repos/m3db/m3x/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3x/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3x/tags","blobs_url":"https://api.github.com/repos/m3db/m3x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3x/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3x/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3x/languages","stargazers_url":"https://api.github.com/repos/m3db/m3x/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3x/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3x/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3x/subscription","commits_url":"https://api.github.com/repos/m3db/m3x/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3x/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3x/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3x/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3x/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3x/merges","archive_url":"https://api.github.com/repos/m3db/m3x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3x/downloads","issues_url":"https://api.github.com/repos/m3db/m3x/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3x/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3x/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3x/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3x/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3x/deployments","created_at":"2016-07-26T20:16:52Z","updated_at":"2016-10-23T22:42:11Z","pushed_at":"2017-01-10T15:02:04Z","git_url":"git://github.com/m3db/m3x.git","ssh_url":"git@github.com:m3db/m3x.git","clone_url":"https://github.com/m3db/m3x.git","svn_url":"https://github.com/m3db/m3x","homepage":null,"size":119,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3x/pulls/39"},"html":{"href":"https://github.com/m3db/m3x/pull/39"},"issue":{"href":"https://api.github.com/repos/m3db/m3x/issues/39"},"comments":{"href":"https://api.github.com/repos/m3db/m3x/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3x/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3x/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3x/statuses/0acd898292d3afd0a5fb6e746b68c9165ff89523"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"robskillington","id":339615,"avatar_url":"https://avatars.githubusercontent.com/u/339615?v=3","gravatar_id":"","url":"https://api.github.com/users/robskillington","html_url":"https://github.com/robskillington","followers_url":"https://api.github.com/users/robskillington/followers","following_url":"https://api.github.com/users/robskillington/following{/other_user}","gists_url":"https://api.github.com/users/robskillington/gists{/gist_id}","starred_url":"https://api.github.com/users/robskillington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robskillington/subscriptions","organizations_url":"https://api.github.com/users/robskillington/orgs","repos_url":"https://api.github.com/users/robskillington/repos","events_url":"https://api.github.com/users/robskillington/events{/privacy}","received_events_url":"https://api.github.com/users/robskillington/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"robskillington"}}