{"action":"closed","number":187,"pull_request":{"url":"https://api.github.com/repos/iLCSoft/lcgeo/pulls/187","id":155867198,"html_url":"https://github.com/iLCSoft/lcgeo/pull/187","diff_url":"https://github.com/iLCSoft/lcgeo/pull/187.diff","patch_url":"https://github.com/iLCSoft/lcgeo/pull/187.patch","issue_url":"https://api.github.com/repos/iLCSoft/lcgeo/issues/187","number":187,"state":"closed","locked":false,"title":"Improve DDSim defaults","user":{"login":"petricm","id":8983816,"avatar_url":"https://avatars1.githubusercontent.com/u/8983816?v=4","gravatar_id":"","url":"https://api.github.com/users/petricm","html_url":"https://github.com/petricm","followers_url":"https://api.github.com/users/petricm/followers","following_url":"https://api.github.com/users/petricm/following{/other_user}","gists_url":"https://api.github.com/users/petricm/gists{/gist_id}","starred_url":"https://api.github.com/users/petricm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petricm/subscriptions","organizations_url":"https://api.github.com/users/petricm/orgs","repos_url":"https://api.github.com/users/petricm/repos","events_url":"https://api.github.com/users/petricm/events{/privacy}","received_events_url":"https://api.github.com/users/petricm/received_events","type":"User","site_admin":false},"body":"BEGINRELEASENOTES\r\n- Set DDSim defaults to Geant4 defaults and retain `largest_step = 10 * m` as recommended in the Geant4 manual (~ detector size). This improves simulation time for single muons approximately a factor 2 and for single pi+ for 25%\r\n\r\nENDRELEASENOTES\r\n\r\nI have made a comparison between what @gaede recommended in AIDASoft/DD4hep#266\r\n\r\n```py\r\nSIM.field.delta_chord = 1e-05\r\nSIM.field.delta_intersection = 1e-05\r\nSIM.field.delta_one_step = .5e-03*mm\r\nSIM.field.eps_max = 1e-04\r\nSIM.field.eps_min = 1e-05\r\nSIM.field.equation = \"Mag_UsualEqRhs\"\r\nSIM.field.largest_step = 10.*m\r\nSIM.field.min_chord_step = 1.e-2*mm\r\nSIM.field.stepper = \"HelixSimpleRunge\"\r\n```\r\n\r\nand the values in this PR. For simulating 10k single muon events I need 13m with the ILD config and 7m with the new defaults. ","created_at":"2017-12-01T13:55:34Z","updated_at":"2017-12-04T10:11:43Z","closed_at":"2017-12-04T10:11:43Z","merged_at":"2017-12-04T10:11:43Z","merge_commit_sha":"ef69a78ddfbea9eadd17b4c59283329ef61f5327","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/iLCSoft/lcgeo/pulls/187/commits","review_comments_url":"https://api.github.com/repos/iLCSoft/lcgeo/pulls/187/comments","review_comment_url":"https://api.github.com/repos/iLCSoft/lcgeo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iLCSoft/lcgeo/issues/187/comments","statuses_url":"https://api.github.com/repos/iLCSoft/lcgeo/statuses/50f629fa10c56ec83de1a997b0a39496e03e73e7","head":{"label":"petricm:defaults","ref":"defaults","sha":"50f629fa10c56ec83de1a997b0a39496e03e73e7","user":{"login":"petricm","id":8983816,"avatar_url":"https://avatars1.githubusercontent.com/u/8983816?v=4","gravatar_id":"","url":"https://api.github.com/users/petricm","html_url":"https://github.com/petricm","followers_url":"https://api.github.com/users/petricm/followers","following_url":"https://api.github.com/users/petricm/following{/other_user}","gists_url":"https://api.github.com/users/petricm/gists{/gist_id}","starred_url":"https://api.github.com/users/petricm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petricm/subscriptions","organizations_url":"https://api.github.com/users/petricm/orgs","repos_url":"https://api.github.com/users/petricm/repos","events_url":"https://api.github.com/users/petricm/events{/privacy}","received_events_url":"https://api.github.com/users/petricm/received_events","type":"User","site_admin":false},"repo":{"id":76953461,"name":"lcgeo","full_name":"petricm/lcgeo","owner":{"login":"petricm","id":8983816,"avatar_url":"https://avatars1.githubusercontent.com/u/8983816?v=4","gravatar_id":"","url":"https://api.github.com/users/petricm","html_url":"https://github.com/petricm","followers_url":"https://api.github.com/users/petricm/followers","following_url":"https://api.github.com/users/petricm/following{/other_user}","gists_url":"https://api.github.com/users/petricm/gists{/gist_id}","starred_url":"https://api.github.com/users/petricm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petricm/subscriptions","organizations_url":"https://api.github.com/users/petricm/orgs","repos_url":"https://api.github.com/users/petricm/repos","events_url":"https://api.github.com/users/petricm/events{/privacy}","received_events_url":"https://api.github.com/users/petricm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petricm/lcgeo","description":"DD4hep based geometry models for liner collider detectors","fork":true,"url":"https://api.github.com/repos/petricm/lcgeo","forks_url":"https://api.github.com/repos/petricm/lcgeo/forks","keys_url":"https://api.github.com/repos/petricm/lcgeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petricm/lcgeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petricm/lcgeo/teams","hooks_url":"https://api.github.com/repos/petricm/lcgeo/hooks","issue_events_url":"https://api.github.com/repos/petricm/lcgeo/issues/events{/number}","events_url":"https://api.github.com/repos/petricm/lcgeo/events","assignees_url":"https://api.github.com/repos/petricm/lcgeo/assignees{/user}","branches_url":"https://api.github.com/repos/petricm/lcgeo/branches{/branch}","tags_url":"https://api.github.com/repos/petricm/lcgeo/tags","blobs_url":"https://api.github.com/repos/petricm/lcgeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petricm/lcgeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petricm/lcgeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/petricm/lcgeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petricm/lcgeo/statuses/{sha}","languages_url":"https://api.github.com/repos/petricm/lcgeo/languages","stargazers_url":"https://api.github.com/repos/petricm/lcgeo/stargazers","contributors_url":"https://api.github.com/repos/petricm/lcgeo/contributors","subscribers_url":"https://api.github.com/repos/petricm/lcgeo/subscribers","subscription_url":"https://api.github.com/repos/petricm/lcgeo/subscription","commits_url":"https://api.github.com/repos/petricm/lcgeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/petricm/lcgeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/petricm/lcgeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/petricm/lcgeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/petricm/lcgeo/contents/{+path}","compare_url":"https://api.github.com/repos/petricm/lcgeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petricm/lcgeo/merges","archive_url":"https://api.github.com/repos/petricm/lcgeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petricm/lcgeo/downloads","issues_url":"https://api.github.com/repos/petricm/lcgeo/issues{/number}","pulls_url":"https://api.github.com/repos/petricm/lcgeo/pulls{/number}","milestones_url":"https://api.github.com/repos/petricm/lcgeo/milestones{/number}","notifications_url":"https://api.github.com/repos/petricm/lcgeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petricm/lcgeo/labels{/name}","releases_url":"https://api.github.com/repos/petricm/lcgeo/releases{/id}","deployments_url":"https://api.github.com/repos/petricm/lcgeo/deployments","created_at":"2016-12-20T12:09:52Z","updated_at":"2016-12-20T12:09:56Z","pushed_at":"2017-12-01T13:50:40Z","git_url":"git://github.com/petricm/lcgeo.git","ssh_url":"git@github.com:petricm/lcgeo.git","clone_url":"https://github.com/petricm/lcgeo.git","svn_url":"https://github.com/petricm/lcgeo","homepage":null,"size":26582,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iLCSoft:master","ref":"master","sha":"0b696de9ed7b93aa77fb7e1cd1f6962a9ae50e62","user":{"login":"iLCSoft","id":19611568,"avatar_url":"https://avatars3.githubusercontent.com/u/19611568?v=4","gravatar_id":"","url":"https://api.github.com/users/iLCSoft","html_url":"https://github.com/iLCSoft","followers_url":"https://api.github.com/users/iLCSoft/followers","following_url":"https://api.github.com/users/iLCSoft/following{/other_user}","gists_url":"https://api.github.com/users/iLCSoft/gists{/gist_id}","starred_url":"https://api.github.com/users/iLCSoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iLCSoft/subscriptions","organizations_url":"https://api.github.com/users/iLCSoft/orgs","repos_url":"https://api.github.com/users/iLCSoft/repos","events_url":"https://api.github.com/users/iLCSoft/events{/privacy}","received_events_url":"https://api.github.com/users/iLCSoft/received_events","type":"Organization","site_admin":false},"repo":{"id":60772160,"name":"lcgeo","full_name":"iLCSoft/lcgeo","owner":{"login":"iLCSoft","id":19611568,"avatar_url":"https://avatars3.githubusercontent.com/u/19611568?v=4","gravatar_id":"","url":"https://api.github.com/users/iLCSoft","html_url":"https://github.com/iLCSoft","followers_url":"https://api.github.com/users/iLCSoft/followers","following_url":"https://api.github.com/users/iLCSoft/following{/other_user}","gists_url":"https://api.github.com/users/iLCSoft/gists{/gist_id}","starred_url":"https://api.github.com/users/iLCSoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iLCSoft/subscriptions","organizations_url":"https://api.github.com/users/iLCSoft/orgs","repos_url":"https://api.github.com/users/iLCSoft/repos","events_url":"https://api.github.com/users/iLCSoft/events{/privacy}","received_events_url":"https://api.github.com/users/iLCSoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iLCSoft/lcgeo","description":"DD4hep based geometry models for liner collider detectors","fork":false,"url":"https://api.github.com/repos/iLCSoft/lcgeo","forks_url":"https://api.github.com/repos/iLCSoft/lcgeo/forks","keys_url":"https://api.github.com/repos/iLCSoft/lcgeo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iLCSoft/lcgeo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iLCSoft/lcgeo/teams","hooks_url":"https://api.github.com/repos/iLCSoft/lcgeo/hooks","issue_events_url":"https://api.github.com/repos/iLCSoft/lcgeo/issues/events{/number}","events_url":"https://api.github.com/repos/iLCSoft/lcgeo/events","assignees_url":"https://api.github.com/repos/iLCSoft/lcgeo/assignees{/user}","branches_url":"https://api.github.com/repos/iLCSoft/lcgeo/branches{/branch}","tags_url":"https://api.github.com/repos/iLCSoft/lcgeo/tags","blobs_url":"https://api.github.com/repos/iLCSoft/lcgeo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iLCSoft/lcgeo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iLCSoft/lcgeo/git/refs{/sha}","trees_url":"https://api.github.com/repos/iLCSoft/lcgeo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iLCSoft/lcgeo/statuses/{sha}","languages_url":"https://api.github.com/repos/iLCSoft/lcgeo/languages","stargazers_url":"https://api.github.com/repos/iLCSoft/lcgeo/stargazers","contributors_url":"https://api.github.com/repos/iLCSoft/lcgeo/contributors","subscribers_url":"https://api.github.com/repos/iLCSoft/lcgeo/subscribers","subscription_url":"https://api.github.com/repos/iLCSoft/lcgeo/subscription","commits_url":"https://api.github.com/repos/iLCSoft/lcgeo/commits{/sha}","git_commits_url":"https://api.github.com/repos/iLCSoft/lcgeo/git/commits{/sha}","comments_url":"https://api.github.com/repos/iLCSoft/lcgeo/comments{/number}","issue_comment_url":"https://api.github.com/repos/iLCSoft/lcgeo/issues/comments{/number}","contents_url":"https://api.github.com/repos/iLCSoft/lcgeo/contents/{+path}","compare_url":"https://api.github.com/repos/iLCSoft/lcgeo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iLCSoft/lcgeo/merges","archive_url":"https://api.github.com/repos/iLCSoft/lcgeo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iLCSoft/lcgeo/downloads","issues_url":"https://api.github.com/repos/iLCSoft/lcgeo/issues{/number}","pulls_url":"https://api.github.com/repos/iLCSoft/lcgeo/pulls{/number}","milestones_url":"https://api.github.com/repos/iLCSoft/lcgeo/milestones{/number}","notifications_url":"https://api.github.com/repos/iLCSoft/lcgeo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iLCSoft/lcgeo/labels{/name}","releases_url":"https://api.github.com/repos/iLCSoft/lcgeo/releases{/id}","deployments_url":"https://api.github.com/repos/iLCSoft/lcgeo/deployments","created_at":"2016-06-09T12:13:49Z","updated_at":"2017-11-06T23:32:16Z","pushed_at":"2017-12-04T10:11:43Z","git_url":"git://github.com/iLCSoft/lcgeo.git","ssh_url":"git@github.com:iLCSoft/lcgeo.git","clone_url":"https://github.com/iLCSoft/lcgeo.git","svn_url":"https://github.com/iLCSoft/lcgeo","homepage":null,"size":26411,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":24,"open_issues":1,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iLCSoft/lcgeo/pulls/187"},"html":{"href":"https://github.com/iLCSoft/lcgeo/pull/187"},"issue":{"href":"https://api.github.com/repos/iLCSoft/lcgeo/issues/187"},"comments":{"href":"https://api.github.com/repos/iLCSoft/lcgeo/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/iLCSoft/lcgeo/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/iLCSoft/lcgeo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iLCSoft/lcgeo/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/iLCSoft/lcgeo/statuses/50f629fa10c56ec83de1a997b0a39496e03e73e7"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"andresailer","id":2115797,"avatar_url":"https://avatars1.githubusercontent.com/u/2115797?v=4","gravatar_id":"","url":"https://api.github.com/users/andresailer","html_url":"https://github.com/andresailer","followers_url":"https://api.github.com/users/andresailer/followers","following_url":"https://api.github.com/users/andresailer/following{/other_user}","gists_url":"https://api.github.com/users/andresailer/gists{/gist_id}","starred_url":"https://api.github.com/users/andresailer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresailer/subscriptions","organizations_url":"https://api.github.com/users/andresailer/orgs","repos_url":"https://api.github.com/users/andresailer/repos","events_url":"https://api.github.com/users/andresailer/events{/privacy}","received_events_url":"https://api.github.com/users/andresailer/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"andresailer"}}