{"action":"created","issue":{"url":"https://api.github.com/repos/orientechnologies/orientdb/issues/7431","repository_url":"https://api.github.com/repos/orientechnologies/orientdb","labels_url":"https://api.github.com/repos/orientechnologies/orientdb/issues/7431/labels{/name}","comments_url":"https://api.github.com/repos/orientechnologies/orientdb/issues/7431/comments","events_url":"https://api.github.com/repos/orientechnologies/orientdb/issues/7431/events","html_url":"https://github.com/orientechnologies/orientdb/pull/7431","id":229830347,"number":7431,"title":"custom sql functions server plugin","user":{"login":"fabriziofortino","id":1469849,"avatar_url":"https://avatars3.githubusercontent.com/u/1469849?v=3","gravatar_id":"","url":"https://api.github.com/users/fabriziofortino","html_url":"https://github.com/fabriziofortino","followers_url":"https://api.github.com/users/fabriziofortino/followers","following_url":"https://api.github.com/users/fabriziofortino/following{/other_user}","gists_url":"https://api.github.com/users/fabriziofortino/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriziofortino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriziofortino/subscriptions","organizations_url":"https://api.github.com/users/fabriziofortino/orgs","repos_url":"https://api.github.com/users/fabriziofortino/repos","events_url":"https://api.github.com/users/fabriziofortino/events{/privacy}","received_events_url":"https://api.github.com/users/fabriziofortino/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"luigidellaquila","id":459289,"avatar_url":"https://avatars3.githubusercontent.com/u/459289?v=3","gravatar_id":"","url":"https://api.github.com/users/luigidellaquila","html_url":"https://github.com/luigidellaquila","followers_url":"https://api.github.com/users/luigidellaquila/followers","following_url":"https://api.github.com/users/luigidellaquila/following{/other_user}","gists_url":"https://api.github.com/users/luigidellaquila/gists{/gist_id}","starred_url":"https://api.github.com/users/luigidellaquila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigidellaquila/subscriptions","organizations_url":"https://api.github.com/users/luigidellaquila/orgs","repos_url":"https://api.github.com/users/luigidellaquila/repos","events_url":"https://api.github.com/users/luigidellaquila/events{/privacy}","received_events_url":"https://api.github.com/users/luigidellaquila/received_events","type":"User","site_admin":false},"assignees":[{"login":"luigidellaquila","id":459289,"avatar_url":"https://avatars3.githubusercontent.com/u/459289?v=3","gravatar_id":"","url":"https://api.github.com/users/luigidellaquila","html_url":"https://github.com/luigidellaquila","followers_url":"https://api.github.com/users/luigidellaquila/followers","following_url":"https://api.github.com/users/luigidellaquila/following{/other_user}","gists_url":"https://api.github.com/users/luigidellaquila/gists{/gist_id}","starred_url":"https://api.github.com/users/luigidellaquila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigidellaquila/subscriptions","organizations_url":"https://api.github.com/users/luigidellaquila/orgs","repos_url":"https://api.github.com/users/luigidellaquila/repos","events_url":"https://api.github.com/users/luigidellaquila/events{/privacy}","received_events_url":"https://api.github.com/users/luigidellaquila/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/orientechnologies/orientdb/milestones/116","html_url":"https://github.com/orientechnologies/orientdb/milestone/116","labels_url":"https://api.github.com/repos/orientechnologies/orientdb/milestones/116/labels","id":2463881,"number":116,"title":"3.0.0-M2","description":"","creator":{"login":"santo-it","id":14923389,"avatar_url":"https://avatars0.githubusercontent.com/u/14923389?v=3","gravatar_id":"","url":"https://api.github.com/users/santo-it","html_url":"https://github.com/santo-it","followers_url":"https://api.github.com/users/santo-it/followers","following_url":"https://api.github.com/users/santo-it/following{/other_user}","gists_url":"https://api.github.com/users/santo-it/gists{/gist_id}","starred_url":"https://api.github.com/users/santo-it/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/santo-it/subscriptions","organizations_url":"https://api.github.com/users/santo-it/orgs","repos_url":"https://api.github.com/users/santo-it/repos","events_url":"https://api.github.com/users/santo-it/events{/privacy}","received_events_url":"https://api.github.com/users/santo-it/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":6,"state":"open","created_at":"2017-04-18T12:40:03Z","updated_at":"2017-05-19T17:47:58Z","due_on":"2017-05-25T07:00:00Z","closed_at":null},"comments":2,"created_at":"2017-05-18T23:18:29Z","updated_at":"2017-05-22T13:05:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/orientechnologies/orientdb/pulls/7431","html_url":"https://github.com/orientechnologies/orientdb/pull/7431","diff_url":"https://github.com/orientechnologies/orientdb/pull/7431.diff","patch_url":"https://github.com/orientechnologies/orientdb/pull/7431.patch"},"body":"* server plugin to easily register custom sql functions (configured in an external json file)\r\n* custom ad hoc `OSQLFunctionFactory` to handle custom functions registration\r\n* basic `custom-sql-functions.json` with java.lang.Math registration (not hard coded anymore)\r\n* aligned tests"},"comment":{"url":"https://api.github.com/repos/orientechnologies/orientdb/issues/comments/303094292","html_url":"https://github.com/orientechnologies/orientdb/pull/7431#issuecomment-303094292","issue_url":"https://api.github.com/repos/orientechnologies/orientdb/issues/7431","id":303094292,"user":{"login":"luigidellaquila","id":459289,"avatar_url":"https://avatars3.githubusercontent.com/u/459289?v=3","gravatar_id":"","url":"https://api.github.com/users/luigidellaquila","html_url":"https://github.com/luigidellaquila","followers_url":"https://api.github.com/users/luigidellaquila/followers","following_url":"https://api.github.com/users/luigidellaquila/following{/other_user}","gists_url":"https://api.github.com/users/luigidellaquila/gists{/gist_id}","starred_url":"https://api.github.com/users/luigidellaquila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigidellaquila/subscriptions","organizations_url":"https://api.github.com/users/luigidellaquila/orgs","repos_url":"https://api.github.com/users/luigidellaquila/repos","events_url":"https://api.github.com/users/luigidellaquila/events{/privacy}","received_events_url":"https://api.github.com/users/luigidellaquila/received_events","type":"User","site_admin":false},"created_at":"2017-05-22T13:05:59Z","updated_at":"2017-05-22T13:05:59Z","body":"Thank you @fabriziofortino \r\n\r\nThe PR seems to be technically perfect. \r\nMy only concern is about the registration of math functions with the same mechanism, this will lead to a situation where a stand-alone server will have math functions by default, while in a plocal instance you will have to manually register them. This could be a bit confusing for the end user. \r\n\r\n@lvca @fabriziofortino wdyt? Is it worth manually register default (eg. math) functions and leave the user the ability to register only their custom functions with this mechanism?\r\n\r\nThanks\r\n\r\nLuigi\r\n"}}
{"actor":{"display_login":"luigidellaquila"}}