{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos/pulls/comments/113253624","pull_request_review_id":34625543,"id":113253624,"diff_hunk":"@@ -50,6 +48,8 @@ def zen_helper(self, config):\n         will be provided (must be done in correct order) and added to the info\n         JSON as 'temp_resources'\n         \"\"\"\n+        if config['zen_helper'] != 'true':\n+            return {}","path":"packages/dcos-launch/extra/launch/aws.py","position":48,"original_position":48,"commit_id":"7640ce0139267b8490661579020e38dad6da9edb","original_commit_id":"7640ce0139267b8490661579020e38dad6da9edb","user":{"login":"mellenburg","id":14269783,"avatar_url":"https://avatars1.githubusercontent.com/u/14269783?v=3","gravatar_id":"","url":"https://api.github.com/users/mellenburg","html_url":"https://github.com/mellenburg","followers_url":"https://api.github.com/users/mellenburg/followers","following_url":"https://api.github.com/users/mellenburg/following{/other_user}","gists_url":"https://api.github.com/users/mellenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/mellenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellenburg/subscriptions","organizations_url":"https://api.github.com/users/mellenburg/orgs","repos_url":"https://api.github.com/users/mellenburg/repos","events_url":"https://api.github.com/users/mellenburg/events{/privacy}","received_events_url":"https://api.github.com/users/mellenburg/received_events","type":"User","site_admin":false},"body":"I don't see why an error would have much pertinence here... The point of this utility is: \"If `key_helper: true` in the config YAML file then add a key. Otherwise, do nothing. Doing nothing is the intended default case.","created_at":"2017-04-25T17:03:23Z","updated_at":"2017-04-25T17:35:34Z","html_url":"https://github.com/dcos/dcos/pull/1462#discussion_r113253624","pull_request_url":"https://api.github.com/repos/dcos/dcos/pulls/1462","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments/113253624"},"html":{"href":"https://github.com/dcos/dcos/pull/1462#discussion_r113253624"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos/pulls/1462"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/1462","id":116335481,"html_url":"https://github.com/dcos/dcos/pull/1462","diff_url":"https://github.com/dcos/dcos/pull/1462.diff","patch_url":"https://github.com/dcos/dcos/pull/1462.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/1462","number":1462,"state":"open","locked":false,"title":"Add onprem support for dcos-launch","user":{"login":"mellenburg","id":14269783,"avatar_url":"https://avatars1.githubusercontent.com/u/14269783?v=3","gravatar_id":"","url":"https://api.github.com/users/mellenburg","html_url":"https://github.com/mellenburg","followers_url":"https://api.github.com/users/mellenburg/followers","following_url":"https://api.github.com/users/mellenburg/following{/other_user}","gists_url":"https://api.github.com/users/mellenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/mellenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellenburg/subscriptions","organizations_url":"https://api.github.com/users/mellenburg/orgs","repos_url":"https://api.github.com/users/mellenburg/repos","events_url":"https://api.github.com/users/mellenburg/events{/privacy}","received_events_url":"https://api.github.com/users/mellenburg/received_events","type":"User","site_admin":false},"body":"## High Level Description\r\n-Introduces onprem launcher support for AWS platform\r\n- Removes concept of \"bare clusters\". Initially, it was designed that a onprem lauch would be a compound launch of a \"bare cluster\" then an onprem cluster. However, it was much simpler to have the wait function drive the installation and make the creation always be the bare cluster\r\n- Introduces OnpremCluster: a simple abstraction for describing the topology of a cluster (supplants test_util/cluster.py)\r\n- Introduces Ssher: a simple client for binding a ssh key to a user (supplants ssh/tunnel.py)\r\n- Consolidates test command code into the launcher base class\r\n\r\n## Related Issues\r\nhttps://jira.mesosphere.com/browse/DCOS-13299\r\n## Checklist for all PR's\r\n\r\n  - [x] Included a test which will fail if code is reverted but test is not. If there is no test please explain here:\r\n  - [x] Read the [DC/OS contributing guidelines](https://github.com/dcos/dcos/blob/master/contributing.md)\r\n  - [x] Followed relevant code rules [Rules for Packages and Systemd](https://github.com/dcos/dcos/tree/master/docs)","created_at":"2017-04-18T14:05:29Z","updated_at":"2017-04-25T17:35:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18f2aa130f606b7a8071af1a59f5f5ff96e9fc8b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/1462/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/1462/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/1462/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/7640ce0139267b8490661579020e38dad6da9edb","head":{"label":"mellenburg:dcos-launch-onprem","ref":"dcos-launch-onprem","sha":"7640ce0139267b8490661579020e38dad6da9edb","user":{"login":"mellenburg","id":14269783,"avatar_url":"https://avatars1.githubusercontent.com/u/14269783?v=3","gravatar_id":"","url":"https://api.github.com/users/mellenburg","html_url":"https://github.com/mellenburg","followers_url":"https://api.github.com/users/mellenburg/followers","following_url":"https://api.github.com/users/mellenburg/following{/other_user}","gists_url":"https://api.github.com/users/mellenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/mellenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellenburg/subscriptions","organizations_url":"https://api.github.com/users/mellenburg/orgs","repos_url":"https://api.github.com/users/mellenburg/repos","events_url":"https://api.github.com/users/mellenburg/events{/privacy}","received_events_url":"https://api.github.com/users/mellenburg/received_events","type":"User","site_admin":false},"repo":{"id":56731971,"name":"dcos","full_name":"mellenburg/dcos","owner":{"login":"mellenburg","id":14269783,"avatar_url":"https://avatars1.githubusercontent.com/u/14269783?v=3","gravatar_id":"","url":"https://api.github.com/users/mellenburg","html_url":"https://github.com/mellenburg","followers_url":"https://api.github.com/users/mellenburg/followers","following_url":"https://api.github.com/users/mellenburg/following{/other_user}","gists_url":"https://api.github.com/users/mellenburg/gists{/gist_id}","starred_url":"https://api.github.com/users/mellenburg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mellenburg/subscriptions","organizations_url":"https://api.github.com/users/mellenburg/orgs","repos_url":"https://api.github.com/users/mellenburg/repos","events_url":"https://api.github.com/users/mellenburg/events{/privacy}","received_events_url":"https://api.github.com/users/mellenburg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mellenburg/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/mellenburg/dcos","forks_url":"https://api.github.com/repos/mellenburg/dcos/forks","keys_url":"https://api.github.com/repos/mellenburg/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mellenburg/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mellenburg/dcos/teams","hooks_url":"https://api.github.com/repos/mellenburg/dcos/hooks","issue_events_url":"https://api.github.com/repos/mellenburg/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/mellenburg/dcos/events","assignees_url":"https://api.github.com/repos/mellenburg/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/mellenburg/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/mellenburg/dcos/tags","blobs_url":"https://api.github.com/repos/mellenburg/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mellenburg/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mellenburg/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/mellenburg/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mellenburg/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/mellenburg/dcos/languages","stargazers_url":"https://api.github.com/repos/mellenburg/dcos/stargazers","contributors_url":"https://api.github.com/repos/mellenburg/dcos/contributors","subscribers_url":"https://api.github.com/repos/mellenburg/dcos/subscribers","subscription_url":"https://api.github.com/repos/mellenburg/dcos/subscription","commits_url":"https://api.github.com/repos/mellenburg/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/mellenburg/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/mellenburg/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/mellenburg/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/mellenburg/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/mellenburg/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mellenburg/dcos/merges","archive_url":"https://api.github.com/repos/mellenburg/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mellenburg/dcos/downloads","issues_url":"https://api.github.com/repos/mellenburg/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/mellenburg/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/mellenburg/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/mellenburg/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mellenburg/dcos/labels{/name}","releases_url":"https://api.github.com/repos/mellenburg/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/mellenburg/dcos/deployments","created_at":"2016-04-21T01:13:27Z","updated_at":"2016-10-26T01:11:32Z","pushed_at":"2017-04-25T16:41:30Z","git_url":"git://github.com/mellenburg/dcos.git","ssh_url":"git@github.com:mellenburg/dcos.git","clone_url":"https://github.com/mellenburg/dcos.git","svn_url":"https://github.com/mellenburg/dcos","homepage":"https://dcos.io","size":3910,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"c73e2c0c5156fd054af342673ca612664f3df114","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars2.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"name":"dcos","full_name":"dcos/dcos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars2.githubusercontent.com/u/17648048?v=3","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos","description":"DC/OS Build and Release tools","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2017-04-25T11:45:26Z","pushed_at":"2017-04-25T17:01:07Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":3786,"stargazers_count":1552,"watchers_count":1552,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":267,"mirror_url":null,"open_issues_count":67,"forks":267,"open_issues":67,"watchers":1552,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/1462"},"html":{"href":"https://github.com/dcos/dcos/pull/1462"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/1462"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/1462/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/1462/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/1462/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/7640ce0139267b8490661579020e38dad6da9edb"}}}}
{"actor":{"display_login":"mellenburg"}}