{"action":"created","issue":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/20328","repository_url":"https://api.github.com/repos/mantidproject/mantid","labels_url":"https://api.github.com/repos/mantidproject/mantid/issues/20328/labels{/name}","comments_url":"https://api.github.com/repos/mantidproject/mantid/issues/20328/comments","events_url":"https://api.github.com/repos/mantidproject/mantid/issues/20328/events","html_url":"https://github.com/mantidproject/mantid/pull/20328","id":252366206,"number":20328,"title":"Output string representation of optimal fit function after completion of fitting","user":{"login":"jmborr","id":1136006,"avatar_url":"https://avatars3.githubusercontent.com/u/1136006?v=4","gravatar_id":"","url":"https://api.github.com/users/jmborr","html_url":"https://github.com/jmborr","followers_url":"https://api.github.com/users/jmborr/followers","following_url":"https://api.github.com/users/jmborr/following{/other_user}","gists_url":"https://api.github.com/users/jmborr/gists{/gist_id}","starred_url":"https://api.github.com/users/jmborr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmborr/subscriptions","organizations_url":"https://api.github.com/users/jmborr/orgs","repos_url":"https://api.github.com/users/jmborr/repos","events_url":"https://api.github.com/users/jmborr/events{/privacy}","received_events_url":"https://api.github.com/users/jmborr/received_events","type":"User","site_admin":false},"labels":[{"id":178354911,"url":"https://api.github.com/repos/mantidproject/mantid/labels/Component:%20Fitting","name":"Component: Fitting","color":"009800","default":false}],"state":"open","locked":false,"assignee":{"login":"soininen","id":19147159,"avatar_url":"https://avatars3.githubusercontent.com/u/19147159?v=4","gravatar_id":"","url":"https://api.github.com/users/soininen","html_url":"https://github.com/soininen","followers_url":"https://api.github.com/users/soininen/followers","following_url":"https://api.github.com/users/soininen/following{/other_user}","gists_url":"https://api.github.com/users/soininen/gists{/gist_id}","starred_url":"https://api.github.com/users/soininen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soininen/subscriptions","organizations_url":"https://api.github.com/users/soininen/orgs","repos_url":"https://api.github.com/users/soininen/repos","events_url":"https://api.github.com/users/soininen/events{/privacy}","received_events_url":"https://api.github.com/users/soininen/received_events","type":"User","site_admin":false},"assignees":[{"login":"soininen","id":19147159,"avatar_url":"https://avatars3.githubusercontent.com/u/19147159?v=4","gravatar_id":"","url":"https://api.github.com/users/soininen","html_url":"https://github.com/soininen","followers_url":"https://api.github.com/users/soininen/followers","following_url":"https://api.github.com/users/soininen/following{/other_user}","gists_url":"https://api.github.com/users/soininen/gists{/gist_id}","starred_url":"https://api.github.com/users/soininen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soininen/subscriptions","organizations_url":"https://api.github.com/users/soininen/orgs","repos_url":"https://api.github.com/users/soininen/repos","events_url":"https://api.github.com/users/soininen/events{/privacy}","received_events_url":"https://api.github.com/users/soininen/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/mantidproject/mantid/milestones/62","html_url":"https://github.com/mantidproject/mantid/milestone/62","labels_url":"https://api.github.com/repos/mantidproject/mantid/milestones/62/labels","id":2064900,"number":62,"title":"Release 3.11","description":"Code Freeze:  15th Sept |\r\nBeta Test:  20th Sept-3rd\r\n","creator":{"login":"NickDraper","id":1017173,"avatar_url":"https://avatars1.githubusercontent.com/u/1017173?v=4","gravatar_id":"","url":"https://api.github.com/users/NickDraper","html_url":"https://github.com/NickDraper","followers_url":"https://api.github.com/users/NickDraper/followers","following_url":"https://api.github.com/users/NickDraper/following{/other_user}","gists_url":"https://api.github.com/users/NickDraper/gists{/gist_id}","starred_url":"https://api.github.com/users/NickDraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickDraper/subscriptions","organizations_url":"https://api.github.com/users/NickDraper/orgs","repos_url":"https://api.github.com/users/NickDraper/repos","events_url":"https://api.github.com/users/NickDraper/events{/privacy}","received_events_url":"https://api.github.com/users/NickDraper/received_events","type":"User","site_admin":false},"open_issues":277,"closed_issues":445,"state":"open","created_at":"2016-10-12T13:15:39Z","updated_at":"2017-09-07T13:31:37Z","due_on":"2017-10-09T07:00:00Z","closed_at":null},"comments":8,"created_at":"2017-08-23T17:57:12Z","updated_at":"2017-09-07T14:28:11Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mantidproject/mantid/pulls/20328","html_url":"https://github.com/mantidproject/mantid/pull/20328","diff_url":"https://github.com/mantidproject/mantid/pull/20328.diff","patch_url":"https://github.com/mantidproject/mantid/pull/20328.patch"},"body":"**To test:**\r\n\r\nDownload and unzip [test_files.zip](https://github.com/mantidproject/mantid/files/1246491/test_files.zip) under `/tmp` and run the script:\r\n\r\n```\r\nimport numpy as np\r\nfrom __future__ import print_function\r\n\r\nresolution_file = '/tmp/BASIS_59304_divided.dat'e\r\ndata_file = '/tmp/BASIS_59293_divided.dat'\r\nresolution = LoadDaveGrp(Filename=resolution_file, OutputWorkspace='resolution', IsMicroEV=True)\r\ndata = LoadDaveGrp(Filename=data_file, OutputWorkspace='data', IsMicroEV=True)\r\n\r\nfunction = '''(composite=Convolution,FixResolution=false,NumDeriv=true;\r\nname=TabulatedFunction,Workspace=resolution,WorkspaceIndex=0,Scaling=0.5,Shift=0,XScaling=1,ties=(XScaling=1);\r\n(name=DeltaFunction,Height=0.5,Centre=0,constraints=(0<Height<1),ties=(Centre=0);\r\nname=Lorentzian,Amplitude=0.5,PeakCentre=0,FWHM=0.02,constraints=(0.001<FWHM),ties=(PeakCentre=0);ties=(f1.Amplitude=1-f0.Height)));\r\nname=LinearBackground,A0=0,A1=0\r\n'''\r\n\r\nresults = Fit(Function=function, InputWorkspace=data, WorkspaceIndex=0, CreateOutput=True)\r\nprint(results.FunctionString)\r\n```\r\nThe printed function should be\r\n```\r\n(composite=Convolution,FixResolution=false,NumDeriv=true;name=TabulatedFunction,Workspace=resolution,WorkspaceIndex=0,X=(),Y=(),Scaling=1.09281,Shift=1.47731e-10,XScaling=1,ties=(XScaling=1);(name=DeltaFunction,Height=0.87475,Centre=0,constraints=(0<Height<1),ties=(Centre=0);name=Lorentzian,Amplitude=0.12525,PeakCentre=0,FWHM=0.00874458,constraints=(0.001<FWHM),ties=(PeakCentre=0);ties=(f1.Amplitude=1-f0.Height)));name=LinearBackground,A0=3.41084e-05,A1=6.46268e-05\r\n```\r\nFixes #20326\r\n[Release Notes](https://github.com/mantidproject/mantid/blob/1d049fc61cc0b58e75dfa10546811733107a01ca/docs/source/release/v3.11.0/framework.rst)\r\n\r\n---\r\n\r\n#### Reviewer ####\r\n\r\nPlease comment on the following ([full description](http://www.mantidproject.org/Individual_Ticket_Testing)):\r\n\r\n##### Code Review #####\r\n\r\n- [x] Is the code of an acceptable quality?\r\n- [x] Does the code conform to the [coding standards](http://www.mantidproject.org/Coding_Standards)?\r\n- [x] Are the unit tests small and test the class in isolation?\r\n- [x] If there are changes in the release notes then do they describe the changes appropriately?\r\n\r\n##### Functional Tests #####\r\n\r\n- [x] Do changes function as described? Add comments below that describe the tests performed?\r\n- [x] Do the changes handle unexpected situations, e.g. bad input?\r\n- [x] Has the relevant (user and developer) documentation been added/updated?\r\n\r\nDoes everything look good? Mark the review as **Approve**. A member of `@mantidproject/gatekeepers` will take care of it.\r\n"},"comment":{"url":"https://api.github.com/repos/mantidproject/mantid/issues/comments/327816640","html_url":"https://github.com/mantidproject/mantid/pull/20328#issuecomment-327816640","issue_url":"https://api.github.com/repos/mantidproject/mantid/issues/20328","id":327816640,"user":{"login":"mantid-roman","id":1132713,"avatar_url":"https://avatars2.githubusercontent.com/u/1132713?v=4","gravatar_id":"","url":"https://api.github.com/users/mantid-roman","html_url":"https://github.com/mantid-roman","followers_url":"https://api.github.com/users/mantid-roman/followers","following_url":"https://api.github.com/users/mantid-roman/following{/other_user}","gists_url":"https://api.github.com/users/mantid-roman/gists{/gist_id}","starred_url":"https://api.github.com/users/mantid-roman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mantid-roman/subscriptions","organizations_url":"https://api.github.com/users/mantid-roman/orgs","repos_url":"https://api.github.com/users/mantid-roman/repos","events_url":"https://api.github.com/users/mantid-roman/events{/privacy}","received_events_url":"https://api.github.com/users/mantid-roman/received_events","type":"User","site_admin":false},"created_at":"2017-09-07T14:28:10Z","updated_at":"2017-09-07T14:28:10Z","author_association":"MEMBER","body":"@jmborr Yes"}}
{"actor":{"display_login":"mantid-roman"}}