{"action":"closed","number":30,"pull_request":{"url":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/30","id":159424205,"html_url":"https://github.com/openzipkin/zipkin-go/pull/30","diff_url":"https://github.com/openzipkin/zipkin-go/pull/30.diff","patch_url":"https://github.com/openzipkin/zipkin-go/pull/30.patch","issue_url":"https://api.github.com/repos/openzipkin/zipkin-go/issues/30","number":30,"state":"closed","locked":false,"title":"improved endpoint handling allowing empty hostPort if unknown","user":{"login":"basvanbeek","id":7205296,"avatar_url":"https://avatars0.githubusercontent.com/u/7205296?v=4","gravatar_id":"","url":"https://api.github.com/users/basvanbeek","html_url":"https://github.com/basvanbeek","followers_url":"https://api.github.com/users/basvanbeek/followers","following_url":"https://api.github.com/users/basvanbeek/following{/other_user}","gists_url":"https://api.github.com/users/basvanbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/basvanbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvanbeek/subscriptions","organizations_url":"https://api.github.com/users/basvanbeek/orgs","repos_url":"https://api.github.com/users/basvanbeek/repos","events_url":"https://api.github.com/users/basvanbeek/events{/privacy}","received_events_url":"https://api.github.com/users/basvanbeek/received_events","type":"User","site_admin":false},"body":"Endpoints can end up being empty. we didn't properly handle NewEndpoint with empty hostPort in case host/port is unknown.","created_at":"2017-12-20T14:03:49Z","updated_at":"2017-12-21T14:25:42Z","closed_at":"2017-12-21T14:25:42Z","merged_at":"2017-12-21T14:25:42Z","merge_commit_sha":"29cbedda5f6747f7e0e02e5a56ffed1698ef716d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/30/commits","review_comments_url":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/30/comments","review_comment_url":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-go/issues/30/comments","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-go/statuses/efc308492950af8c2da4dc3bb7bc7278644b1d6c","head":{"label":"basvanbeek:endpoint","ref":"endpoint","sha":"efc308492950af8c2da4dc3bb7bc7278644b1d6c","user":{"login":"basvanbeek","id":7205296,"avatar_url":"https://avatars0.githubusercontent.com/u/7205296?v=4","gravatar_id":"","url":"https://api.github.com/users/basvanbeek","html_url":"https://github.com/basvanbeek","followers_url":"https://api.github.com/users/basvanbeek/followers","following_url":"https://api.github.com/users/basvanbeek/following{/other_user}","gists_url":"https://api.github.com/users/basvanbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/basvanbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvanbeek/subscriptions","organizations_url":"https://api.github.com/users/basvanbeek/orgs","repos_url":"https://api.github.com/users/basvanbeek/repos","events_url":"https://api.github.com/users/basvanbeek/events{/privacy}","received_events_url":"https://api.github.com/users/basvanbeek/received_events","type":"User","site_admin":false},"repo":{"id":108853174,"name":"zipkin-go","full_name":"basvanbeek/zipkin-go","owner":{"login":"basvanbeek","id":7205296,"avatar_url":"https://avatars0.githubusercontent.com/u/7205296?v=4","gravatar_id":"","url":"https://api.github.com/users/basvanbeek","html_url":"https://github.com/basvanbeek","followers_url":"https://api.github.com/users/basvanbeek/followers","following_url":"https://api.github.com/users/basvanbeek/following{/other_user}","gists_url":"https://api.github.com/users/basvanbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/basvanbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvanbeek/subscriptions","organizations_url":"https://api.github.com/users/basvanbeek/orgs","repos_url":"https://api.github.com/users/basvanbeek/repos","events_url":"https://api.github.com/users/basvanbeek/events{/privacy}","received_events_url":"https://api.github.com/users/basvanbeek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/basvanbeek/zipkin-go","description":"Zipkin tracer library for go","fork":true,"url":"https://api.github.com/repos/basvanbeek/zipkin-go","forks_url":"https://api.github.com/repos/basvanbeek/zipkin-go/forks","keys_url":"https://api.github.com/repos/basvanbeek/zipkin-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basvanbeek/zipkin-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basvanbeek/zipkin-go/teams","hooks_url":"https://api.github.com/repos/basvanbeek/zipkin-go/hooks","issue_events_url":"https://api.github.com/repos/basvanbeek/zipkin-go/issues/events{/number}","events_url":"https://api.github.com/repos/basvanbeek/zipkin-go/events","assignees_url":"https://api.github.com/repos/basvanbeek/zipkin-go/assignees{/user}","branches_url":"https://api.github.com/repos/basvanbeek/zipkin-go/branches{/branch}","tags_url":"https://api.github.com/repos/basvanbeek/zipkin-go/tags","blobs_url":"https://api.github.com/repos/basvanbeek/zipkin-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basvanbeek/zipkin-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basvanbeek/zipkin-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/basvanbeek/zipkin-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basvanbeek/zipkin-go/statuses/{sha}","languages_url":"https://api.github.com/repos/basvanbeek/zipkin-go/languages","stargazers_url":"https://api.github.com/repos/basvanbeek/zipkin-go/stargazers","contributors_url":"https://api.github.com/repos/basvanbeek/zipkin-go/contributors","subscribers_url":"https://api.github.com/repos/basvanbeek/zipkin-go/subscribers","subscription_url":"https://api.github.com/repos/basvanbeek/zipkin-go/subscription","commits_url":"https://api.github.com/repos/basvanbeek/zipkin-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/basvanbeek/zipkin-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/basvanbeek/zipkin-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/basvanbeek/zipkin-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/basvanbeek/zipkin-go/contents/{+path}","compare_url":"https://api.github.com/repos/basvanbeek/zipkin-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basvanbeek/zipkin-go/merges","archive_url":"https://api.github.com/repos/basvanbeek/zipkin-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basvanbeek/zipkin-go/downloads","issues_url":"https://api.github.com/repos/basvanbeek/zipkin-go/issues{/number}","pulls_url":"https://api.github.com/repos/basvanbeek/zipkin-go/pulls{/number}","milestones_url":"https://api.github.com/repos/basvanbeek/zipkin-go/milestones{/number}","notifications_url":"https://api.github.com/repos/basvanbeek/zipkin-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basvanbeek/zipkin-go/labels{/name}","releases_url":"https://api.github.com/repos/basvanbeek/zipkin-go/releases{/id}","deployments_url":"https://api.github.com/repos/basvanbeek/zipkin-go/deployments","created_at":"2017-10-30T13:15:16Z","updated_at":"2017-11-06T15:09:30Z","pushed_at":"2017-12-21T14:18:23Z","git_url":"git://github.com/basvanbeek/zipkin-go.git","ssh_url":"git@github.com:basvanbeek/zipkin-go.git","clone_url":"https://github.com/basvanbeek/zipkin-go.git","svn_url":"https://github.com/basvanbeek/zipkin-go","homepage":null,"size":120,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openzipkin:master","ref":"master","sha":"bc81f71e3579779f0dd4265dff460d04c1ac9537","user":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars3.githubusercontent.com/u/11860887?v=4","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"repo":{"id":69353600,"name":"zipkin-go","full_name":"openzipkin/zipkin-go","owner":{"login":"openzipkin","id":11860887,"avatar_url":"https://avatars3.githubusercontent.com/u/11860887?v=4","gravatar_id":"","url":"https://api.github.com/users/openzipkin","html_url":"https://github.com/openzipkin","followers_url":"https://api.github.com/users/openzipkin/followers","following_url":"https://api.github.com/users/openzipkin/following{/other_user}","gists_url":"https://api.github.com/users/openzipkin/gists{/gist_id}","starred_url":"https://api.github.com/users/openzipkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openzipkin/subscriptions","organizations_url":"https://api.github.com/users/openzipkin/orgs","repos_url":"https://api.github.com/users/openzipkin/repos","events_url":"https://api.github.com/users/openzipkin/events{/privacy}","received_events_url":"https://api.github.com/users/openzipkin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openzipkin/zipkin-go","description":"Zipkin tracer library for go","fork":false,"url":"https://api.github.com/repos/openzipkin/zipkin-go","forks_url":"https://api.github.com/repos/openzipkin/zipkin-go/forks","keys_url":"https://api.github.com/repos/openzipkin/zipkin-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openzipkin/zipkin-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openzipkin/zipkin-go/teams","hooks_url":"https://api.github.com/repos/openzipkin/zipkin-go/hooks","issue_events_url":"https://api.github.com/repos/openzipkin/zipkin-go/issues/events{/number}","events_url":"https://api.github.com/repos/openzipkin/zipkin-go/events","assignees_url":"https://api.github.com/repos/openzipkin/zipkin-go/assignees{/user}","branches_url":"https://api.github.com/repos/openzipkin/zipkin-go/branches{/branch}","tags_url":"https://api.github.com/repos/openzipkin/zipkin-go/tags","blobs_url":"https://api.github.com/repos/openzipkin/zipkin-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openzipkin/zipkin-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openzipkin/zipkin-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/openzipkin/zipkin-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openzipkin/zipkin-go/statuses/{sha}","languages_url":"https://api.github.com/repos/openzipkin/zipkin-go/languages","stargazers_url":"https://api.github.com/repos/openzipkin/zipkin-go/stargazers","contributors_url":"https://api.github.com/repos/openzipkin/zipkin-go/contributors","subscribers_url":"https://api.github.com/repos/openzipkin/zipkin-go/subscribers","subscription_url":"https://api.github.com/repos/openzipkin/zipkin-go/subscription","commits_url":"https://api.github.com/repos/openzipkin/zipkin-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/openzipkin/zipkin-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/openzipkin/zipkin-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/openzipkin/zipkin-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/openzipkin/zipkin-go/contents/{+path}","compare_url":"https://api.github.com/repos/openzipkin/zipkin-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openzipkin/zipkin-go/merges","archive_url":"https://api.github.com/repos/openzipkin/zipkin-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openzipkin/zipkin-go/downloads","issues_url":"https://api.github.com/repos/openzipkin/zipkin-go/issues{/number}","pulls_url":"https://api.github.com/repos/openzipkin/zipkin-go/pulls{/number}","milestones_url":"https://api.github.com/repos/openzipkin/zipkin-go/milestones{/number}","notifications_url":"https://api.github.com/repos/openzipkin/zipkin-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openzipkin/zipkin-go/labels{/name}","releases_url":"https://api.github.com/repos/openzipkin/zipkin-go/releases{/id}","deployments_url":"https://api.github.com/repos/openzipkin/zipkin-go/deployments","created_at":"2016-09-27T12:19:53Z","updated_at":"2017-12-20T14:42:50Z","pushed_at":"2017-12-21T14:25:42Z","git_url":"git://github.com/openzipkin/zipkin-go.git","ssh_url":"git@github.com:openzipkin/zipkin-go.git","clone_url":"https://github.com/openzipkin/zipkin-go.git","svn_url":"https://github.com/openzipkin/zipkin-go","homepage":null,"size":117,"stargazers_count":8,"watchers_count":8,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":2,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/30"},"html":{"href":"https://github.com/openzipkin/zipkin-go/pull/30"},"issue":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/issues/30"},"comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/issues/30/comments"},"review_comments":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/30/comments"},"review_comment":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/pulls/30/commits"},"statuses":{"href":"https://api.github.com/repos/openzipkin/zipkin-go/statuses/efc308492950af8c2da4dc3bb7bc7278644b1d6c"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"basvanbeek","id":7205296,"avatar_url":"https://avatars0.githubusercontent.com/u/7205296?v=4","gravatar_id":"","url":"https://api.github.com/users/basvanbeek","html_url":"https://github.com/basvanbeek","followers_url":"https://api.github.com/users/basvanbeek/followers","following_url":"https://api.github.com/users/basvanbeek/following{/other_user}","gists_url":"https://api.github.com/users/basvanbeek/gists{/gist_id}","starred_url":"https://api.github.com/users/basvanbeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basvanbeek/subscriptions","organizations_url":"https://api.github.com/users/basvanbeek/orgs","repos_url":"https://api.github.com/users/basvanbeek/repos","events_url":"https://api.github.com/users/basvanbeek/events{/privacy}","received_events_url":"https://api.github.com/users/basvanbeek/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":259,"deletions":61,"changed_files":17}}
{"actor":{"display_login":"basvanbeek"}}