{"action":"created","comment":{"url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/pulls/comments/153779146","pull_request_review_id":79836520,"id":153779146,"diff_hunk":"@@ -0,0 +1,97 @@\n+'use strict';\n+\n+var userDialog = document.querySelector('.setup');\n+var names = [","path":"js/setup.js","position":4,"original_position":4,"commit_id":"1cd050a9d90b3505b25d254a8adc45e0d3b70d25","original_commit_id":"1cd050a9d90b3505b25d254a8adc45e0d3b70d25","user":{"login":"Ulyanich-v","id":9572702,"avatar_url":"https://avatars0.githubusercontent.com/u/9572702?v=4","gravatar_id":"","url":"https://api.github.com/users/Ulyanich-v","html_url":"https://github.com/Ulyanich-v","followers_url":"https://api.github.com/users/Ulyanich-v/followers","following_url":"https://api.github.com/users/Ulyanich-v/following{/other_user}","gists_url":"https://api.github.com/users/Ulyanich-v/gists{/gist_id}","starred_url":"https://api.github.com/users/Ulyanich-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ulyanich-v/subscriptions","organizations_url":"https://api.github.com/users/Ulyanich-v/orgs","repos_url":"https://api.github.com/users/Ulyanich-v/repos","events_url":"https://api.github.com/users/Ulyanich-v/events{/privacy}","received_events_url":"https://api.github.com/users/Ulyanich-v/received_events","type":"User","site_admin":false},"body":"по критериям академии, все константы нужно именовать через капс (https://up.htmlacademy.ru/javascript/11/criteries#basic-7)\r\nи нужно выносить в самый верх кода) дом элементы не принято выносить в константы, потому что по факту из ДОМа по такому селектору могут разные элементы возвращаться, и это не считается константой / ","created_at":"2017-11-29T12:58:05Z","updated_at":"2017-11-29T13:04:41Z","html_url":"https://github.com/htmlacademy-javascript/220620-code-and-magick/pull/3#discussion_r153779146","pull_request_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/pulls/comments/153779146"},"html":{"href":"https://github.com/htmlacademy-javascript/220620-code-and-magick/pull/3#discussion_r153779146"},"pull_request":{"href":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/pulls/3","id":155188224,"html_url":"https://github.com/htmlacademy-javascript/220620-code-and-magick/pull/3","diff_url":"https://github.com/htmlacademy-javascript/220620-code-and-magick/pull/3.diff","patch_url":"https://github.com/htmlacademy-javascript/220620-code-and-magick/pull/3.patch","issue_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/issues/3","number":3,"state":"open","locked":false,"title":"Учебный проект: нас орда","user":{"login":"Safe-Mode","id":20503101,"avatar_url":"https://avatars0.githubusercontent.com/u/20503101?v=4","gravatar_id":"","url":"https://api.github.com/users/Safe-Mode","html_url":"https://github.com/Safe-Mode","followers_url":"https://api.github.com/users/Safe-Mode/followers","following_url":"https://api.github.com/users/Safe-Mode/following{/other_user}","gists_url":"https://api.github.com/users/Safe-Mode/gists{/gist_id}","starred_url":"https://api.github.com/users/Safe-Mode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Safe-Mode/subscriptions","organizations_url":"https://api.github.com/users/Safe-Mode/orgs","repos_url":"https://api.github.com/users/Safe-Mode/repos","events_url":"https://api.github.com/users/Safe-Mode/events{/privacy}","received_events_url":"https://api.github.com/users/Safe-Mode/received_events","type":"User","site_admin":false},"body":"\n\n---\n:mortar_board: [Учебный проект: нас орда](https://up.htmlacademy.ru/javascript/11/user/220620/tasks/9)\n\n:boom: https://htmlacademy-javascript.github.io/220620-code-and-magick/3/","created_at":"2017-11-28T21:30:44Z","updated_at":"2017-11-29T13:04:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb4b6421810c9352e991804064cdf4d494ec1c59","assignee":{"login":"Ulyanich-v","id":9572702,"avatar_url":"https://avatars0.githubusercontent.com/u/9572702?v=4","gravatar_id":"","url":"https://api.github.com/users/Ulyanich-v","html_url":"https://github.com/Ulyanich-v","followers_url":"https://api.github.com/users/Ulyanich-v/followers","following_url":"https://api.github.com/users/Ulyanich-v/following{/other_user}","gists_url":"https://api.github.com/users/Ulyanich-v/gists{/gist_id}","starred_url":"https://api.github.com/users/Ulyanich-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ulyanich-v/subscriptions","organizations_url":"https://api.github.com/users/Ulyanich-v/orgs","repos_url":"https://api.github.com/users/Ulyanich-v/repos","events_url":"https://api.github.com/users/Ulyanich-v/events{/privacy}","received_events_url":"https://api.github.com/users/Ulyanich-v/received_events","type":"User","site_admin":false},"assignees":[{"login":"Ulyanich-v","id":9572702,"avatar_url":"https://avatars0.githubusercontent.com/u/9572702?v=4","gravatar_id":"","url":"https://api.github.com/users/Ulyanich-v","html_url":"https://github.com/Ulyanich-v","followers_url":"https://api.github.com/users/Ulyanich-v/followers","following_url":"https://api.github.com/users/Ulyanich-v/following{/other_user}","gists_url":"https://api.github.com/users/Ulyanich-v/gists{/gist_id}","starred_url":"https://api.github.com/users/Ulyanich-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ulyanich-v/subscriptions","organizations_url":"https://api.github.com/users/Ulyanich-v/orgs","repos_url":"https://api.github.com/users/Ulyanich-v/repos","events_url":"https://api.github.com/users/Ulyanich-v/events{/privacy}","received_events_url":"https://api.github.com/users/Ulyanich-v/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/pulls/3/commits","review_comments_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/pulls/3/comments","review_comment_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/pulls/comments{/number}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/issues/3/comments","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/statuses/1cd050a9d90b3505b25d254a8adc45e0d3b70d25","head":{"label":"Safe-Mode:module3-task1","ref":"module3-task1","sha":"1cd050a9d90b3505b25d254a8adc45e0d3b70d25","user":{"login":"Safe-Mode","id":20503101,"avatar_url":"https://avatars0.githubusercontent.com/u/20503101?v=4","gravatar_id":"","url":"https://api.github.com/users/Safe-Mode","html_url":"https://github.com/Safe-Mode","followers_url":"https://api.github.com/users/Safe-Mode/followers","following_url":"https://api.github.com/users/Safe-Mode/following{/other_user}","gists_url":"https://api.github.com/users/Safe-Mode/gists{/gist_id}","starred_url":"https://api.github.com/users/Safe-Mode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Safe-Mode/subscriptions","organizations_url":"https://api.github.com/users/Safe-Mode/orgs","repos_url":"https://api.github.com/users/Safe-Mode/repos","events_url":"https://api.github.com/users/Safe-Mode/events{/privacy}","received_events_url":"https://api.github.com/users/Safe-Mode/received_events","type":"User","site_admin":false},"repo":{"id":110740344,"name":"220620-code-and-magick","full_name":"Safe-Mode/220620-code-and-magick","owner":{"login":"Safe-Mode","id":20503101,"avatar_url":"https://avatars0.githubusercontent.com/u/20503101?v=4","gravatar_id":"","url":"https://api.github.com/users/Safe-Mode","html_url":"https://github.com/Safe-Mode","followers_url":"https://api.github.com/users/Safe-Mode/followers","following_url":"https://api.github.com/users/Safe-Mode/following{/other_user}","gists_url":"https://api.github.com/users/Safe-Mode/gists{/gist_id}","starred_url":"https://api.github.com/users/Safe-Mode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Safe-Mode/subscriptions","organizations_url":"https://api.github.com/users/Safe-Mode/orgs","repos_url":"https://api.github.com/users/Safe-Mode/repos","events_url":"https://api.github.com/users/Safe-Mode/events{/privacy}","received_events_url":"https://api.github.com/users/Safe-Mode/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Safe-Mode/220620-code-and-magick","description":"Сергей Дмитриев","fork":true,"url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick","forks_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/forks","keys_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/teams","hooks_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/hooks","issue_events_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/issues/events{/number}","events_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/events","assignees_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/assignees{/user}","branches_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/branches{/branch}","tags_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/tags","blobs_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/git/refs{/sha}","trees_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/statuses/{sha}","languages_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/languages","stargazers_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/stargazers","contributors_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/contributors","subscribers_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/subscribers","subscription_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/subscription","commits_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/commits{/sha}","git_commits_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/git/commits{/sha}","comments_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/comments{/number}","issue_comment_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/issues/comments{/number}","contents_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/contents/{+path}","compare_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/merges","archive_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/downloads","issues_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/issues{/number}","pulls_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/pulls{/number}","milestones_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/milestones{/number}","notifications_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/labels{/name}","releases_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/releases{/id}","deployments_url":"https://api.github.com/repos/Safe-Mode/220620-code-and-magick/deployments","created_at":"2017-11-14T20:21:05Z","updated_at":"2017-11-14T20:21:06Z","pushed_at":"2017-11-28T21:29:28Z","git_url":"git://github.com/Safe-Mode/220620-code-and-magick.git","ssh_url":"git@github.com:Safe-Mode/220620-code-and-magick.git","clone_url":"https://github.com/Safe-Mode/220620-code-and-magick.git","svn_url":"https://github.com/Safe-Mode/220620-code-and-magick","homepage":null,"size":1088,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"htmlacademy-javascript:master","ref":"master","sha":"fa93e3bb1869179a2285f965a25b2698ee711448","user":{"login":"htmlacademy-javascript","id":14179712,"avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"repo":{"id":110740195,"name":"220620-code-and-magick","full_name":"htmlacademy-javascript/220620-code-and-magick","owner":{"login":"htmlacademy-javascript","id":14179712,"avatar_url":"https://avatars2.githubusercontent.com/u/14179712?v=4","gravatar_id":"","url":"https://api.github.com/users/htmlacademy-javascript","html_url":"https://github.com/htmlacademy-javascript","followers_url":"https://api.github.com/users/htmlacademy-javascript/followers","following_url":"https://api.github.com/users/htmlacademy-javascript/following{/other_user}","gists_url":"https://api.github.com/users/htmlacademy-javascript/gists{/gist_id}","starred_url":"https://api.github.com/users/htmlacademy-javascript/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htmlacademy-javascript/subscriptions","organizations_url":"https://api.github.com/users/htmlacademy-javascript/orgs","repos_url":"https://api.github.com/users/htmlacademy-javascript/repos","events_url":"https://api.github.com/users/htmlacademy-javascript/events{/privacy}","received_events_url":"https://api.github.com/users/htmlacademy-javascript/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/htmlacademy-javascript/220620-code-and-magick","description":"Сергей Дмитриев","fork":false,"url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick","forks_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/forks","keys_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/teams","hooks_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/hooks","issue_events_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/issues/events{/number}","events_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/events","assignees_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/assignees{/user}","branches_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/branches{/branch}","tags_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/tags","blobs_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/git/refs{/sha}","trees_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/statuses/{sha}","languages_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/languages","stargazers_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/stargazers","contributors_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/contributors","subscribers_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/subscribers","subscription_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/subscription","commits_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/commits{/sha}","git_commits_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/git/commits{/sha}","comments_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/comments{/number}","issue_comment_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/issues/comments{/number}","contents_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/contents/{+path}","compare_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/merges","archive_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/downloads","issues_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/issues{/number}","pulls_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/pulls{/number}","milestones_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/milestones{/number}","notifications_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/labels{/name}","releases_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/releases{/id}","deployments_url":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/deployments","created_at":"2017-11-14T20:19:27Z","updated_at":"2017-11-14T20:50:38Z","pushed_at":"2017-11-29T13:03:03Z","git_url":"git://github.com/htmlacademy-javascript/220620-code-and-magick.git","ssh_url":"git@github.com:htmlacademy-javascript/220620-code-and-magick.git","clone_url":"https://github.com/htmlacademy-javascript/220620-code-and-magick.git","svn_url":"https://github.com/htmlacademy-javascript/220620-code-and-magick","homepage":"https://github.com/Safe-Mode/220620-code-and-magick","size":1078,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/pulls/3"},"html":{"href":"https://github.com/htmlacademy-javascript/220620-code-and-magick/pull/3"},"issue":{"href":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/issues/3"},"comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/htmlacademy-javascript/220620-code-and-magick/statuses/1cd050a9d90b3505b25d254a8adc45e0d3b70d25"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Ulyanich-v"}}