{"action":"created","comment":{"url":"https://api.github.com/repos/dadoonet/fscrawler/pulls/comments/98534472","pull_request_review_id":19179156,"id":98534472,"diff_hunk":"@@ -525,6 +525,24 @@ public void test_filename_as_id() throws Exception {\n         }), equalTo(true));\n     }\n \n+    public void test_add_as_inner_object() throws Exception {","path":"src/test/java/fr/pilato/elasticsearch/crawler/fs/test/integration/FsCrawlerImplAllParametersIT.java","position":null,"original_position":16,"commit_id":"8a2aeb3255e31e35e9f4300950a0b87a1505db42","original_commit_id":"c21d8861075540512f10a1615d20171d728f3cd5","user":{"login":"babadofar","id":379628,"avatar_url":"https://avatars.githubusercontent.com/u/379628?v=3","gravatar_id":"","url":"https://api.github.com/users/babadofar","html_url":"https://github.com/babadofar","followers_url":"https://api.github.com/users/babadofar/followers","following_url":"https://api.github.com/users/babadofar/following{/other_user}","gists_url":"https://api.github.com/users/babadofar/gists{/gist_id}","starred_url":"https://api.github.com/users/babadofar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babadofar/subscriptions","organizations_url":"https://api.github.com/users/babadofar/orgs","repos_url":"https://api.github.com/users/babadofar/repos","events_url":"https://api.github.com/users/babadofar/events{/privacy}","received_events_url":"https://api.github.com/users/babadofar/received_events","type":"User","site_admin":false},"body":"No idea how I could believe that test worked. Should remember to stay off LSD while coding.","created_at":"2017-01-30T20:35:07Z","updated_at":"2017-01-30T20:35:07Z","html_url":"https://github.com/dadoonet/fscrawler/pull/241#discussion_r98534472","pull_request_url":"https://api.github.com/repos/dadoonet/fscrawler/pulls/241","_links":{"self":{"href":"https://api.github.com/repos/dadoonet/fscrawler/pulls/comments/98534472"},"html":{"href":"https://github.com/dadoonet/fscrawler/pull/241#discussion_r98534472"},"pull_request":{"href":"https://api.github.com/repos/dadoonet/fscrawler/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/dadoonet/fscrawler/pulls/241","id":90980879,"html_url":"https://github.com/dadoonet/fscrawler/pull/241","diff_url":"https://github.com/dadoonet/fscrawler/pull/241.diff","patch_url":"https://github.com/dadoonet/fscrawler/pull/241.patch","issue_url":"https://api.github.com/repos/dadoonet/fscrawler/issues/241","number":241,"state":"open","locked":false,"title":"Detect deletions for json and xml documents - adding metadata","user":{"login":"babadofar","id":379628,"avatar_url":"https://avatars.githubusercontent.com/u/379628?v=3","gravatar_id":"","url":"https://api.github.com/users/babadofar","html_url":"https://github.com/babadofar","followers_url":"https://api.github.com/users/babadofar/followers","following_url":"https://api.github.com/users/babadofar/following{/other_user}","gists_url":"https://api.github.com/users/babadofar/gists{/gist_id}","starred_url":"https://api.github.com/users/babadofar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babadofar/subscriptions","organizations_url":"https://api.github.com/users/babadofar/orgs","repos_url":"https://api.github.com/users/babadofar/repos","events_url":"https://api.github.com/users/babadofar/events{/privacy}","received_events_url":"https://api.github.com/users/babadofar/received_events","type":"User","site_admin":false},"body":"This works for me, the tests are also running. \r\nFixes #237 \r\n\r\nThis PR makes all content types have the same set of metadata, most importantly it adds info on file paths to json and xml documents allowing checking for deletions/updates. Perhaps there should be distinct indexing types, since there will be empty elements ( tika processed files will not have json_content, and json/xml files do not populate the meta object)\r\n\r\nThis is probably a breaking change, since it moves the source content of indexed json and xml documents into a sub element, aptly named \"json_content\". (sorry about that, xml) ","created_at":"2016-10-26T10:56:40Z","updated_at":"2017-01-30T20:35:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31a83703f425360051f7220d46a3317442b83577","assignee":{"login":"dadoonet","id":274222,"avatar_url":"https://avatars.githubusercontent.com/u/274222?v=3","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false},"assignees":[{"login":"dadoonet","id":274222,"avatar_url":"https://avatars.githubusercontent.com/u/274222?v=3","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dadoonet/fscrawler/pulls/241/commits","review_comments_url":"https://api.github.com/repos/dadoonet/fscrawler/pulls/241/comments","review_comment_url":"https://api.github.com/repos/dadoonet/fscrawler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dadoonet/fscrawler/issues/241/comments","statuses_url":"https://api.github.com/repos/dadoonet/fscrawler/statuses/8a2aeb3255e31e35e9f4300950a0b87a1505db42","head":{"label":"babadofar:jsondeletionsupport","ref":"jsondeletionsupport","sha":"8a2aeb3255e31e35e9f4300950a0b87a1505db42","user":{"login":"babadofar","id":379628,"avatar_url":"https://avatars.githubusercontent.com/u/379628?v=3","gravatar_id":"","url":"https://api.github.com/users/babadofar","html_url":"https://github.com/babadofar","followers_url":"https://api.github.com/users/babadofar/followers","following_url":"https://api.github.com/users/babadofar/following{/other_user}","gists_url":"https://api.github.com/users/babadofar/gists{/gist_id}","starred_url":"https://api.github.com/users/babadofar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babadofar/subscriptions","organizations_url":"https://api.github.com/users/babadofar/orgs","repos_url":"https://api.github.com/users/babadofar/repos","events_url":"https://api.github.com/users/babadofar/events{/privacy}","received_events_url":"https://api.github.com/users/babadofar/received_events","type":"User","site_admin":false},"repo":{"id":71567633,"name":"fscrawler","full_name":"babadofar/fscrawler","owner":{"login":"babadofar","id":379628,"avatar_url":"https://avatars.githubusercontent.com/u/379628?v=3","gravatar_id":"","url":"https://api.github.com/users/babadofar","html_url":"https://github.com/babadofar","followers_url":"https://api.github.com/users/babadofar/followers","following_url":"https://api.github.com/users/babadofar/following{/other_user}","gists_url":"https://api.github.com/users/babadofar/gists{/gist_id}","starred_url":"https://api.github.com/users/babadofar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babadofar/subscriptions","organizations_url":"https://api.github.com/users/babadofar/orgs","repos_url":"https://api.github.com/users/babadofar/repos","events_url":"https://api.github.com/users/babadofar/events{/privacy}","received_events_url":"https://api.github.com/users/babadofar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/babadofar/fscrawler","description":"Elasticsearch File System Crawler (FS Crawler)","fork":true,"url":"https://api.github.com/repos/babadofar/fscrawler","forks_url":"https://api.github.com/repos/babadofar/fscrawler/forks","keys_url":"https://api.github.com/repos/babadofar/fscrawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babadofar/fscrawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babadofar/fscrawler/teams","hooks_url":"https://api.github.com/repos/babadofar/fscrawler/hooks","issue_events_url":"https://api.github.com/repos/babadofar/fscrawler/issues/events{/number}","events_url":"https://api.github.com/repos/babadofar/fscrawler/events","assignees_url":"https://api.github.com/repos/babadofar/fscrawler/assignees{/user}","branches_url":"https://api.github.com/repos/babadofar/fscrawler/branches{/branch}","tags_url":"https://api.github.com/repos/babadofar/fscrawler/tags","blobs_url":"https://api.github.com/repos/babadofar/fscrawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babadofar/fscrawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babadofar/fscrawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/babadofar/fscrawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babadofar/fscrawler/statuses/{sha}","languages_url":"https://api.github.com/repos/babadofar/fscrawler/languages","stargazers_url":"https://api.github.com/repos/babadofar/fscrawler/stargazers","contributors_url":"https://api.github.com/repos/babadofar/fscrawler/contributors","subscribers_url":"https://api.github.com/repos/babadofar/fscrawler/subscribers","subscription_url":"https://api.github.com/repos/babadofar/fscrawler/subscription","commits_url":"https://api.github.com/repos/babadofar/fscrawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/babadofar/fscrawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/babadofar/fscrawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/babadofar/fscrawler/issues/comments{/number}","contents_url":"https://api.github.com/repos/babadofar/fscrawler/contents/{+path}","compare_url":"https://api.github.com/repos/babadofar/fscrawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babadofar/fscrawler/merges","archive_url":"https://api.github.com/repos/babadofar/fscrawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babadofar/fscrawler/downloads","issues_url":"https://api.github.com/repos/babadofar/fscrawler/issues{/number}","pulls_url":"https://api.github.com/repos/babadofar/fscrawler/pulls{/number}","milestones_url":"https://api.github.com/repos/babadofar/fscrawler/milestones{/number}","notifications_url":"https://api.github.com/repos/babadofar/fscrawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babadofar/fscrawler/labels{/name}","releases_url":"https://api.github.com/repos/babadofar/fscrawler/releases{/id}","deployments_url":"https://api.github.com/repos/babadofar/fscrawler/deployments","created_at":"2016-10-21T13:33:26Z","updated_at":"2016-10-21T13:33:27Z","pushed_at":"2017-01-30T20:34:23Z","git_url":"git://github.com/babadofar/fscrawler.git","ssh_url":"git@github.com:babadofar/fscrawler.git","clone_url":"https://github.com/babadofar/fscrawler.git","svn_url":"https://github.com/babadofar/fscrawler","homepage":"","size":5141,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dadoonet:master","ref":"master","sha":"ed138c7287099f28c866238e96c8ba68784a6018","user":{"login":"dadoonet","id":274222,"avatar_url":"https://avatars.githubusercontent.com/u/274222?v=3","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false},"repo":{"id":4600110,"name":"fscrawler","full_name":"dadoonet/fscrawler","owner":{"login":"dadoonet","id":274222,"avatar_url":"https://avatars.githubusercontent.com/u/274222?v=3","gravatar_id":"","url":"https://api.github.com/users/dadoonet","html_url":"https://github.com/dadoonet","followers_url":"https://api.github.com/users/dadoonet/followers","following_url":"https://api.github.com/users/dadoonet/following{/other_user}","gists_url":"https://api.github.com/users/dadoonet/gists{/gist_id}","starred_url":"https://api.github.com/users/dadoonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dadoonet/subscriptions","organizations_url":"https://api.github.com/users/dadoonet/orgs","repos_url":"https://api.github.com/users/dadoonet/repos","events_url":"https://api.github.com/users/dadoonet/events{/privacy}","received_events_url":"https://api.github.com/users/dadoonet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dadoonet/fscrawler","description":"Elasticsearch File System Crawler (FS Crawler)","fork":false,"url":"https://api.github.com/repos/dadoonet/fscrawler","forks_url":"https://api.github.com/repos/dadoonet/fscrawler/forks","keys_url":"https://api.github.com/repos/dadoonet/fscrawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dadoonet/fscrawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dadoonet/fscrawler/teams","hooks_url":"https://api.github.com/repos/dadoonet/fscrawler/hooks","issue_events_url":"https://api.github.com/repos/dadoonet/fscrawler/issues/events{/number}","events_url":"https://api.github.com/repos/dadoonet/fscrawler/events","assignees_url":"https://api.github.com/repos/dadoonet/fscrawler/assignees{/user}","branches_url":"https://api.github.com/repos/dadoonet/fscrawler/branches{/branch}","tags_url":"https://api.github.com/repos/dadoonet/fscrawler/tags","blobs_url":"https://api.github.com/repos/dadoonet/fscrawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dadoonet/fscrawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dadoonet/fscrawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/dadoonet/fscrawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dadoonet/fscrawler/statuses/{sha}","languages_url":"https://api.github.com/repos/dadoonet/fscrawler/languages","stargazers_url":"https://api.github.com/repos/dadoonet/fscrawler/stargazers","contributors_url":"https://api.github.com/repos/dadoonet/fscrawler/contributors","subscribers_url":"https://api.github.com/repos/dadoonet/fscrawler/subscribers","subscription_url":"https://api.github.com/repos/dadoonet/fscrawler/subscription","commits_url":"https://api.github.com/repos/dadoonet/fscrawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/dadoonet/fscrawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/dadoonet/fscrawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/dadoonet/fscrawler/issues/comments{/number}","contents_url":"https://api.github.com/repos/dadoonet/fscrawler/contents/{+path}","compare_url":"https://api.github.com/repos/dadoonet/fscrawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dadoonet/fscrawler/merges","archive_url":"https://api.github.com/repos/dadoonet/fscrawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dadoonet/fscrawler/downloads","issues_url":"https://api.github.com/repos/dadoonet/fscrawler/issues{/number}","pulls_url":"https://api.github.com/repos/dadoonet/fscrawler/pulls{/number}","milestones_url":"https://api.github.com/repos/dadoonet/fscrawler/milestones{/number}","notifications_url":"https://api.github.com/repos/dadoonet/fscrawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dadoonet/fscrawler/labels{/name}","releases_url":"https://api.github.com/repos/dadoonet/fscrawler/releases{/id}","deployments_url":"https://api.github.com/repos/dadoonet/fscrawler/deployments","created_at":"2012-06-08T17:23:03Z","updated_at":"2017-01-29T16:33:03Z","pushed_at":"2017-01-30T20:34:25Z","git_url":"git://github.com/dadoonet/fscrawler.git","ssh_url":"git@github.com:dadoonet/fscrawler.git","clone_url":"https://github.com/dadoonet/fscrawler.git","svn_url":"https://github.com/dadoonet/fscrawler","homepage":"","size":5079,"stargazers_count":242,"watchers_count":242,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":82,"mirror_url":null,"open_issues_count":18,"forks":82,"open_issues":18,"watchers":242,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dadoonet/fscrawler/pulls/241"},"html":{"href":"https://github.com/dadoonet/fscrawler/pull/241"},"issue":{"href":"https://api.github.com/repos/dadoonet/fscrawler/issues/241"},"comments":{"href":"https://api.github.com/repos/dadoonet/fscrawler/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/dadoonet/fscrawler/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/dadoonet/fscrawler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dadoonet/fscrawler/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/dadoonet/fscrawler/statuses/8a2aeb3255e31e35e9f4300950a0b87a1505db42"}}}}
{"actor":{"display_login":"babadofar"}}