{"action":"created","comment":{"url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/comments/105635138","pull_request_review_id":26522009,"id":105635138,"diff_hunk":"@@ -2292,6 +2269,36 @@ void janus_videoroom_incoming_rtp(janus_plugin_session *handle, int video, char\n \tif(!session || session->destroyed || !session->participant || session->participant_type != janus_videoroom_p_type_publisher)\n \t\treturn;\n \tjanus_videoroom_participant *participant = (janus_videoroom_participant *)session->participant;\n+\tif(participant->audio_active) {\n+\t\tint level = 0;\n+\t\tif(janus_rtp_header_extension_parse_audio_level(buf, len, participant->audio_level_extmap_id, &level) == 0) {\n+\t\t\t// JANUS_LOG(LOG_INFO, \"Audio level is %d\\n\", level);\n+\t\t\tparticipant->audio_dBov_sum = participant->audio_dBov_sum + level;\n+\t\t\tparticipant->audio_active_packets = participant->audio_active_packets + 1;\n+\t\t// 2 seconds of talking (100 packets) with average of ~25 dBow","path":"plugins/janus_videoroom.c","position":391,"original_position":391,"commit_id":"752a621feaaf4865a2132d71955bb849624b29b3","original_commit_id":"752a621feaaf4865a2132d71955bb849624b29b3","user":{"login":"lminiero","id":3684796,"avatar_url":"https://avatars2.githubusercontent.com/u/3684796?v=3","gravatar_id":"","url":"https://api.github.com/users/lminiero","html_url":"https://github.com/lminiero","followers_url":"https://api.github.com/users/lminiero/followers","following_url":"https://api.github.com/users/lminiero/following{/other_user}","gists_url":"https://api.github.com/users/lminiero/gists{/gist_id}","starred_url":"https://api.github.com/users/lminiero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lminiero/subscriptions","organizations_url":"https://api.github.com/users/lminiero/orgs","repos_url":"https://api.github.com/users/lminiero/repos","events_url":"https://api.github.com/users/lminiero/events{/privacy}","received_events_url":"https://api.github.com/users/lminiero/received_events","type":"User","site_admin":false},"body":"Wrong indentation. Besides, please use `/* Comment */` instead of `// Comment`.","created_at":"2017-03-13T11:01:43Z","updated_at":"2017-03-13T11:09:32Z","html_url":"https://github.com/meetecho/janus-gateway/pull/760#discussion_r105635138","pull_request_url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/760","_links":{"self":{"href":"https://api.github.com/repos/meetecho/janus-gateway/pulls/comments/105635138"},"html":{"href":"https://github.com/meetecho/janus-gateway/pull/760#discussion_r105635138"},"pull_request":{"href":"https://api.github.com/repos/meetecho/janus-gateway/pulls/760"}}},"pull_request":{"url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/760","id":103938922,"html_url":"https://github.com/meetecho/janus-gateway/pull/760","diff_url":"https://github.com/meetecho/janus-gateway/pull/760.diff","patch_url":"https://github.com/meetecho/janus-gateway/pull/760.patch","issue_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/760","number":760,"state":"open","locked":false,"title":"Added additional function to get dBov audio level so that average can …","user":{"login":"mirkobrankovic","id":3499206,"avatar_url":"https://avatars2.githubusercontent.com/u/3499206?v=3","gravatar_id":"","url":"https://api.github.com/users/mirkobrankovic","html_url":"https://github.com/mirkobrankovic","followers_url":"https://api.github.com/users/mirkobrankovic/followers","following_url":"https://api.github.com/users/mirkobrankovic/following{/other_user}","gists_url":"https://api.github.com/users/mirkobrankovic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirkobrankovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirkobrankovic/subscriptions","organizations_url":"https://api.github.com/users/mirkobrankovic/orgs","repos_url":"https://api.github.com/users/mirkobrankovic/repos","events_url":"https://api.github.com/users/mirkobrankovic/events{/privacy}","received_events_url":"https://api.github.com/users/mirkobrankovic/received_events","type":"User","site_admin":false},"body":"…be calculated for X amount of packets.\r\n\r\nThis can be done also, probably, by converting int janus_rtp_header_extension_parse_audio_level from into to void to return both v and level.\r\nvideoroom incoming_rtp modified to calculate average level of dBov but event to users is not working.","created_at":"2017-01-31T13:49:14Z","updated_at":"2017-03-13T11:09:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e876706e7a6146854a8df18a945886b154747e80","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/760/commits","review_comments_url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/760/comments","review_comment_url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/760/comments","statuses_url":"https://api.github.com/repos/meetecho/janus-gateway/statuses/752a621feaaf4865a2132d71955bb849624b29b3","head":{"label":"mirkobrankovic:videoroom-audiolevel-event","ref":"videoroom-audiolevel-event","sha":"752a621feaaf4865a2132d71955bb849624b29b3","user":{"login":"mirkobrankovic","id":3499206,"avatar_url":"https://avatars2.githubusercontent.com/u/3499206?v=3","gravatar_id":"","url":"https://api.github.com/users/mirkobrankovic","html_url":"https://github.com/mirkobrankovic","followers_url":"https://api.github.com/users/mirkobrankovic/followers","following_url":"https://api.github.com/users/mirkobrankovic/following{/other_user}","gists_url":"https://api.github.com/users/mirkobrankovic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirkobrankovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirkobrankovic/subscriptions","organizations_url":"https://api.github.com/users/mirkobrankovic/orgs","repos_url":"https://api.github.com/users/mirkobrankovic/repos","events_url":"https://api.github.com/users/mirkobrankovic/events{/privacy}","received_events_url":"https://api.github.com/users/mirkobrankovic/received_events","type":"User","site_admin":false},"repo":{"id":80524165,"name":"janus-gateway","full_name":"mirkobrankovic/janus-gateway","owner":{"login":"mirkobrankovic","id":3499206,"avatar_url":"https://avatars2.githubusercontent.com/u/3499206?v=3","gravatar_id":"","url":"https://api.github.com/users/mirkobrankovic","html_url":"https://github.com/mirkobrankovic","followers_url":"https://api.github.com/users/mirkobrankovic/followers","following_url":"https://api.github.com/users/mirkobrankovic/following{/other_user}","gists_url":"https://api.github.com/users/mirkobrankovic/gists{/gist_id}","starred_url":"https://api.github.com/users/mirkobrankovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirkobrankovic/subscriptions","organizations_url":"https://api.github.com/users/mirkobrankovic/orgs","repos_url":"https://api.github.com/users/mirkobrankovic/repos","events_url":"https://api.github.com/users/mirkobrankovic/events{/privacy}","received_events_url":"https://api.github.com/users/mirkobrankovic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mirkobrankovic/janus-gateway","description":"Janus WebRTC Gateway","fork":true,"url":"https://api.github.com/repos/mirkobrankovic/janus-gateway","forks_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/forks","keys_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/teams","hooks_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/hooks","issue_events_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/events","assignees_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/tags","blobs_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/languages","stargazers_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/stargazers","contributors_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/contributors","subscribers_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/subscribers","subscription_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/subscription","commits_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/merges","archive_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/downloads","issues_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/labels{/name}","releases_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/releases{/id}","deployments_url":"https://api.github.com/repos/mirkobrankovic/janus-gateway/deployments","created_at":"2017-01-31T13:47:14Z","updated_at":"2017-02-04T20:47:38Z","pushed_at":"2017-02-10T16:23:29Z","git_url":"git://github.com/mirkobrankovic/janus-gateway.git","ssh_url":"git@github.com:mirkobrankovic/janus-gateway.git","clone_url":"https://github.com/mirkobrankovic/janus-gateway.git","svn_url":"https://github.com/mirkobrankovic/janus-gateway","homepage":null,"size":15205,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"meetecho:master","ref":"master","sha":"fe81f5ca6acce69a908403d67a886aab95ee9f5d","user":{"login":"meetecho","id":4520545,"avatar_url":"https://avatars1.githubusercontent.com/u/4520545?v=3","gravatar_id":"","url":"https://api.github.com/users/meetecho","html_url":"https://github.com/meetecho","followers_url":"https://api.github.com/users/meetecho/followers","following_url":"https://api.github.com/users/meetecho/following{/other_user}","gists_url":"https://api.github.com/users/meetecho/gists{/gist_id}","starred_url":"https://api.github.com/users/meetecho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetecho/subscriptions","organizations_url":"https://api.github.com/users/meetecho/orgs","repos_url":"https://api.github.com/users/meetecho/repos","events_url":"https://api.github.com/users/meetecho/events{/privacy}","received_events_url":"https://api.github.com/users/meetecho/received_events","type":"Organization","site_admin":false},"repo":{"id":16734696,"name":"janus-gateway","full_name":"meetecho/janus-gateway","owner":{"login":"meetecho","id":4520545,"avatar_url":"https://avatars1.githubusercontent.com/u/4520545?v=3","gravatar_id":"","url":"https://api.github.com/users/meetecho","html_url":"https://github.com/meetecho","followers_url":"https://api.github.com/users/meetecho/followers","following_url":"https://api.github.com/users/meetecho/following{/other_user}","gists_url":"https://api.github.com/users/meetecho/gists{/gist_id}","starred_url":"https://api.github.com/users/meetecho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meetecho/subscriptions","organizations_url":"https://api.github.com/users/meetecho/orgs","repos_url":"https://api.github.com/users/meetecho/repos","events_url":"https://api.github.com/users/meetecho/events{/privacy}","received_events_url":"https://api.github.com/users/meetecho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meetecho/janus-gateway","description":"Janus WebRTC Gateway","fork":false,"url":"https://api.github.com/repos/meetecho/janus-gateway","forks_url":"https://api.github.com/repos/meetecho/janus-gateway/forks","keys_url":"https://api.github.com/repos/meetecho/janus-gateway/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meetecho/janus-gateway/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meetecho/janus-gateway/teams","hooks_url":"https://api.github.com/repos/meetecho/janus-gateway/hooks","issue_events_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/events{/number}","events_url":"https://api.github.com/repos/meetecho/janus-gateway/events","assignees_url":"https://api.github.com/repos/meetecho/janus-gateway/assignees{/user}","branches_url":"https://api.github.com/repos/meetecho/janus-gateway/branches{/branch}","tags_url":"https://api.github.com/repos/meetecho/janus-gateway/tags","blobs_url":"https://api.github.com/repos/meetecho/janus-gateway/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meetecho/janus-gateway/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meetecho/janus-gateway/git/refs{/sha}","trees_url":"https://api.github.com/repos/meetecho/janus-gateway/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meetecho/janus-gateway/statuses/{sha}","languages_url":"https://api.github.com/repos/meetecho/janus-gateway/languages","stargazers_url":"https://api.github.com/repos/meetecho/janus-gateway/stargazers","contributors_url":"https://api.github.com/repos/meetecho/janus-gateway/contributors","subscribers_url":"https://api.github.com/repos/meetecho/janus-gateway/subscribers","subscription_url":"https://api.github.com/repos/meetecho/janus-gateway/subscription","commits_url":"https://api.github.com/repos/meetecho/janus-gateway/commits{/sha}","git_commits_url":"https://api.github.com/repos/meetecho/janus-gateway/git/commits{/sha}","comments_url":"https://api.github.com/repos/meetecho/janus-gateway/comments{/number}","issue_comment_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/comments{/number}","contents_url":"https://api.github.com/repos/meetecho/janus-gateway/contents/{+path}","compare_url":"https://api.github.com/repos/meetecho/janus-gateway/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meetecho/janus-gateway/merges","archive_url":"https://api.github.com/repos/meetecho/janus-gateway/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meetecho/janus-gateway/downloads","issues_url":"https://api.github.com/repos/meetecho/janus-gateway/issues{/number}","pulls_url":"https://api.github.com/repos/meetecho/janus-gateway/pulls{/number}","milestones_url":"https://api.github.com/repos/meetecho/janus-gateway/milestones{/number}","notifications_url":"https://api.github.com/repos/meetecho/janus-gateway/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meetecho/janus-gateway/labels{/name}","releases_url":"https://api.github.com/repos/meetecho/janus-gateway/releases{/id}","deployments_url":"https://api.github.com/repos/meetecho/janus-gateway/deployments","created_at":"2014-02-11T15:14:39Z","updated_at":"2017-03-13T10:43:05Z","pushed_at":"2017-03-13T10:26:31Z","git_url":"git://github.com/meetecho/janus-gateway.git","ssh_url":"git@github.com:meetecho/janus-gateway.git","clone_url":"https://github.com/meetecho/janus-gateway.git","svn_url":"https://github.com/meetecho/janus-gateway","homepage":null,"size":15237,"stargazers_count":1061,"watchers_count":1061,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":405,"mirror_url":null,"open_issues_count":23,"forks":405,"open_issues":23,"watchers":1061,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meetecho/janus-gateway/pulls/760"},"html":{"href":"https://github.com/meetecho/janus-gateway/pull/760"},"issue":{"href":"https://api.github.com/repos/meetecho/janus-gateway/issues/760"},"comments":{"href":"https://api.github.com/repos/meetecho/janus-gateway/issues/760/comments"},"review_comments":{"href":"https://api.github.com/repos/meetecho/janus-gateway/pulls/760/comments"},"review_comment":{"href":"https://api.github.com/repos/meetecho/janus-gateway/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meetecho/janus-gateway/pulls/760/commits"},"statuses":{"href":"https://api.github.com/repos/meetecho/janus-gateway/statuses/752a621feaaf4865a2132d71955bb849624b29b3"}}}}
{"actor":{"display_login":"lminiero"}}