{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/141763996","pull_request_review_id":66030731,"id":141763996,"diff_hunk":"@@ -55,21 +55,20 @@ bool benchmark::State::KeepRunning()\n     else {\n         now = gettimedouble();\n         double elapsed = now - lastTime;\n-        double elapsedOne = elapsed * countMaskInv;\n+        double elapsedOne = elapsed / (countMask + 1);","path":"src/bench/bench.cpp","position":5,"original_position":5,"commit_id":"1789e4675b17f274fcb0761321e6fd249a102f40","original_commit_id":"0b1b9148cd77092d2851eeed5c8c6d5ce117452a","user":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars0.githubusercontent.com/u/649246?v=4","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"body":"I'm gonna leave this be, I think we need to re-write the bench crap anyway (there is a very massive difference between runs based on the number of iterations, in many of my tests, so all of this garbage needs to just be removed).","created_at":"2017-09-29T00:00:48Z","updated_at":"2017-09-29T00:00:48Z","html_url":"https://github.com/bitcoin/bitcoin/pull/11303#discussion_r141763996","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11303","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/141763996"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/11303#discussion_r141763996"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11303"}},"in_reply_to_id":138227579},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11303","id":140421245,"html_url":"https://github.com/bitcoin/bitcoin/pull/11303","diff_url":"https://github.com/bitcoin/bitcoin/pull/11303.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/11303.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11303","number":11303,"state":"open","locked":false,"title":"Fix estimatesmartfee rounding display issue","user":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars0.githubusercontent.com/u/649246?v=4","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"body":"This fixes an issue where estimatesmartfee which matches at the min relay fee will return 999 sat/byte instead of 1000 sat/byte due to a float rounding issue. I went ahead and made all float <-> int conversion outside of test/qt explicit (test only had one or two more, Qt had quite a few, including many in the Qt headers themselves) and added overloads to CFeeRate to force callers to do an explicit round themselves. Easy to test with -Wfloat-conversion.","created_at":"2017-09-11T19:54:55Z","updated_at":"2017-09-29T00:00:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"819fc4c8294d634369c8a80348bd241cc77a9823","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11303/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11303/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11303/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/1789e4675b17f274fcb0761321e6fd249a102f40","head":{"label":"TheBlueMatt:2017-09-estimatesmartfee-round","ref":"2017-09-estimatesmartfee-round","sha":"1789e4675b17f274fcb0761321e6fd249a102f40","user":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars0.githubusercontent.com/u/649246?v=4","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"repo":{"id":1443291,"name":"bitcoin","full_name":"TheBlueMatt/bitcoin","owner":{"login":"TheBlueMatt","id":649246,"avatar_url":"https://avatars0.githubusercontent.com/u/649246?v=4","gravatar_id":"","url":"https://api.github.com/users/TheBlueMatt","html_url":"https://github.com/TheBlueMatt","followers_url":"https://api.github.com/users/TheBlueMatt/followers","following_url":"https://api.github.com/users/TheBlueMatt/following{/other_user}","gists_url":"https://api.github.com/users/TheBlueMatt/gists{/gist_id}","starred_url":"https://api.github.com/users/TheBlueMatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheBlueMatt/subscriptions","organizations_url":"https://api.github.com/users/TheBlueMatt/orgs","repos_url":"https://api.github.com/users/TheBlueMatt/repos","events_url":"https://api.github.com/users/TheBlueMatt/events{/privacy}","received_events_url":"https://api.github.com/users/TheBlueMatt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TheBlueMatt/bitcoin","description":"Bitcoin (dont fork from here, fork from bitcoin/bitcoin)","fork":true,"url":"https://api.github.com/repos/TheBlueMatt/bitcoin","forks_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/forks","keys_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/teams","hooks_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/events","assignees_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/tags","blobs_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/languages","stargazers_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/subscription","commits_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/merges","archive_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/downloads","issues_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/TheBlueMatt/bitcoin/deployments","created_at":"2011-03-05T14:14:49Z","updated_at":"2017-09-12T02:56:12Z","pushed_at":"2017-09-27T21:06:06Z","git_url":"git://github.com/TheBlueMatt/bitcoin.git","ssh_url":"git@github.com:TheBlueMatt/bitcoin.git","clone_url":"https://github.com/TheBlueMatt/bitcoin.git","svn_url":"https://github.com/TheBlueMatt/bitcoin","homepage":"http://www.bitcoin.org/","size":85602,"stargazers_count":14,"watchers_count":14,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":14,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"1afc22a7667a7a5c66b4b5d7f50832356dd5ec12","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2017-09-28T21:44:37Z","pushed_at":"2017-09-28T23:34:30Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":87834,"stargazers_count":17028,"watchers_count":17028,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":10425,"mirror_url":null,"open_issues_count":800,"forks":10425,"open_issues":800,"watchers":17028,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11303"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/11303"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/11303"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/11303/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11303/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11303/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/1789e4675b17f274fcb0761321e6fd249a102f40"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TheBlueMatt"}}