{"action":"created","comment":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls/comments/109442219","pull_request_review_id":30543914,"id":109442219,"diff_hunk":"@@ -409,6 +404,87 @@ describe( 'BalloonPanelView', () => {\n \t\t\t} );\n \t\t} );\n \t} );\n+\n+\tdescribe( 'keepAttachedTo()', () => {\n+\t\tlet attachToSpy, target, limiter, notRelatedElement;\n+\n+\t\tbeforeEach( () => {\n+\t\t\tattachToSpy = testUtils.sinon.spy( view, 'attachTo' );\n+\t\t\tlimiter = document.createElement( 'div' );\n+\t\t\ttarget = document.createElement( 'div' );\n+\t\t\tnotRelatedElement = document.createElement( 'div' );\n+\n+\t\t\tdocument.body.appendChild( limiter );\n+\t\t\tdocument.body.appendChild( notRelatedElement );\n+\t\t} );\n+\n+\t\tafterEach( () => {\n+\t\t\tattachToSpy.restore();\n+\t\t\tlimiter.remove();\n+\t\t\tnotRelatedElement.remove();\n+\t\t} );\n+\n+\t\tit( 'should attach balloon to the target constantly when any of element containing target element is scrolled', () => {\n+\t\t\tview.keepAttachedTo( { target, limiter } );\n+\n+\t\t\texpect( attachToSpy.calledOnce ).to.true;\n+\t\t\texpect( attachToSpy.lastCall.args[ 0 ] ).to.deep.equal( { target, limiter } );\n+\n+\t\t\tdocument.dispatchEvent( new Event( 'scroll' ) );\n+\n+\t\t\texpect( attachToSpy.calledTwice ).to.true;\n+\t\t\texpect( attachToSpy.lastCall.args[ 0 ] ).to.deep.equal( { target, limiter } );\n+\n+\t\t\tlimiter.dispatchEvent( new Event( 'scroll' ) );\n+\n+\t\t\texpect( attachToSpy.calledThrice ).to.true;\n+\t\t\texpect( attachToSpy.lastCall.args[ 0 ] ).to.deep.equal( { target, limiter } );\n+\n+\t\t\tnotRelatedElement.dispatchEvent( new Event( 'scroll' ) );\n+\n+\t\t\t// Nothing's changed.\n+\t\t\texpect( attachToSpy.calledThrice ).to.true;\n+\t\t\texpect( attachToSpy.lastCall.args[ 0 ] ).to.deep.equal( { target, limiter } );\n+\t\t} );\n+\n+\t\tit( 'should stop attach when balloon is hidden', () => {","path":"tests/panel/balloon/balloonpanelview.js","position":null,"original_position":98,"commit_id":"8692e48c3e5e55e83746979ecae7665c1b4e1848","original_commit_id":"30904a738badc9de362097db33330f91b168ea39","user":{"login":"oskarwrobel","id":1057056,"avatar_url":"https://avatars1.githubusercontent.com/u/1057056?v=3","gravatar_id":"","url":"https://api.github.com/users/oskarwrobel","html_url":"https://github.com/oskarwrobel","followers_url":"https://api.github.com/users/oskarwrobel/followers","following_url":"https://api.github.com/users/oskarwrobel/following{/other_user}","gists_url":"https://api.github.com/users/oskarwrobel/gists{/gist_id}","starred_url":"https://api.github.com/users/oskarwrobel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskarwrobel/subscriptions","organizations_url":"https://api.github.com/users/oskarwrobel/orgs","repos_url":"https://api.github.com/users/oskarwrobel/repos","events_url":"https://api.github.com/users/oskarwrobel/events{/privacy}","received_events_url":"https://api.github.com/users/oskarwrobel/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-04-03T15:08:45Z","updated_at":"2017-04-03T15:08:45Z","html_url":"https://github.com/ckeditor/ckeditor5-ui/pull/172#discussion_r109442219","pull_request_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls/172","_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls/comments/109442219"},"html":{"href":"https://github.com/ckeditor/ckeditor5-ui/pull/172#discussion_r109442219"},"pull_request":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls/172"}}},"pull_request":{"url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls/172","id":111621413,"html_url":"https://github.com/ckeditor/ckeditor5-ui/pull/172","diff_url":"https://github.com/ckeditor/ckeditor5-ui/pull/172.diff","patch_url":"https://github.com/ckeditor/ckeditor5-ui/pull/172.patch","issue_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/issues/172","number":172,"state":"open","locked":false,"title":"Added `stickTo` method to the BalloonPanelView.","user":{"login":"oskarwrobel","id":1057056,"avatar_url":"https://avatars1.githubusercontent.com/u/1057056?v=3","gravatar_id":"","url":"https://api.github.com/users/oskarwrobel","html_url":"https://github.com/oskarwrobel","followers_url":"https://api.github.com/users/oskarwrobel/followers","following_url":"https://api.github.com/users/oskarwrobel/following{/other_user}","gists_url":"https://api.github.com/users/oskarwrobel/gists{/gist_id}","starred_url":"https://api.github.com/users/oskarwrobel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oskarwrobel/subscriptions","organizations_url":"https://api.github.com/users/oskarwrobel/orgs","repos_url":"https://api.github.com/users/oskarwrobel/repos","events_url":"https://api.github.com/users/oskarwrobel/events{/privacy}","received_events_url":"https://api.github.com/users/oskarwrobel/received_events","type":"User","site_admin":false},"body":"### Suggested merge commit message ([convention](https://github.com/ckeditor/ckeditor5-design/wiki/Git-commit-message-convention))\r\n\r\nFeature: Added `stickTo()` method to the `BalloonPanelView`. Closes #170.\r\n\r\n## Follow-ups:\r\n- #181 - Panel sticks out of the container element while scroll","created_at":"2017-03-20T18:34:16Z","updated_at":"2017-04-03T15:08:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aca03a6e32471f0fe66a7d73bfb7a3267e086bee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls/172/commits","review_comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls/172/comments","review_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/issues/172/comments","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/statuses/8692e48c3e5e55e83746979ecae7665c1b4e1848","head":{"label":"ckeditor:t/170","ref":"t/170","sha":"8692e48c3e5e55e83746979ecae7665c1b4e1848","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars1.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":53504666,"name":"ckeditor5-ui","full_name":"ckeditor/ckeditor5-ui","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars1.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-ui","description":"The UI framework of CKEditor 5.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-ui","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/deployments","created_at":"2016-03-09T14:37:07Z","updated_at":"2017-03-08T09:27:00Z","pushed_at":"2017-04-03T15:07:40Z","git_url":"git://github.com/ckeditor/ckeditor5-ui.git","ssh_url":"git@github.com:ckeditor/ckeditor5-ui.git","clone_url":"https://github.com/ckeditor/ckeditor5-ui.git","svn_url":"https://github.com/ckeditor/ckeditor5-ui","homepage":"https://ckeditor5.github.io","size":1259,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":42,"forks":0,"open_issues":42,"watchers":2,"default_branch":"master"}},"base":{"label":"ckeditor:master","ref":"master","sha":"ef0a7f83a145bd7f20274a4738d8d5c4cf92e523","user":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars1.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"repo":{"id":53504666,"name":"ckeditor5-ui","full_name":"ckeditor/ckeditor5-ui","owner":{"login":"ckeditor","id":825710,"avatar_url":"https://avatars1.githubusercontent.com/u/825710?v=3","gravatar_id":"","url":"https://api.github.com/users/ckeditor","html_url":"https://github.com/ckeditor","followers_url":"https://api.github.com/users/ckeditor/followers","following_url":"https://api.github.com/users/ckeditor/following{/other_user}","gists_url":"https://api.github.com/users/ckeditor/gists{/gist_id}","starred_url":"https://api.github.com/users/ckeditor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckeditor/subscriptions","organizations_url":"https://api.github.com/users/ckeditor/orgs","repos_url":"https://api.github.com/users/ckeditor/repos","events_url":"https://api.github.com/users/ckeditor/events{/privacy}","received_events_url":"https://api.github.com/users/ckeditor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ckeditor/ckeditor5-ui","description":"The UI framework of CKEditor 5.","fork":false,"url":"https://api.github.com/repos/ckeditor/ckeditor5-ui","forks_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/forks","keys_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/teams","hooks_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/hooks","issue_events_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/issues/events{/number}","events_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/events","assignees_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/assignees{/user}","branches_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/branches{/branch}","tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/tags","blobs_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/languages","stargazers_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/stargazers","contributors_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/contributors","subscribers_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/subscribers","subscription_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/subscription","commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/contents/{+path}","compare_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/merges","archive_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/downloads","issues_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/issues{/number}","pulls_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/labels{/name}","releases_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/releases{/id}","deployments_url":"https://api.github.com/repos/ckeditor/ckeditor5-ui/deployments","created_at":"2016-03-09T14:37:07Z","updated_at":"2017-03-08T09:27:00Z","pushed_at":"2017-04-03T15:07:40Z","git_url":"git://github.com/ckeditor/ckeditor5-ui.git","ssh_url":"git@github.com:ckeditor/ckeditor5-ui.git","clone_url":"https://github.com/ckeditor/ckeditor5-ui.git","svn_url":"https://github.com/ckeditor/ckeditor5-ui","homepage":"https://ckeditor5.github.io","size":1259,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":42,"forks":0,"open_issues":42,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls/172"},"html":{"href":"https://github.com/ckeditor/ckeditor5-ui/pull/172"},"issue":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui/issues/172"},"comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/ckeditor/ckeditor5-ui/statuses/8692e48c3e5e55e83746979ecae7665c1b4e1848"}}}}
{"actor":{"display_login":"oskarwrobel"}}