{"action":"created","comment":{"url":"https://api.github.com/repos/ruby-amqp/amqp/pulls/comments/158719777","pull_request_review_id":85568777,"id":158719777,"diff_hunk":"@@ -157,7 +158,7 @@ def initialize(*args, &block)\n \n       # EventMachine::Connection's and Adapter's constructors arity\n       # make it easier to use *args. MK.\n-      @settings                           = Settings.configure(args.first)\n+      @settings                           = AMQ::Settings.configure(args.first)","path":"lib/amqp/session.rb","position":22,"original_position":22,"commit_id":"03d0cd8f403daf8de3909aa306d62514af51b172","original_commit_id":"03d0cd8f403daf8de3909aa306d62514af51b172","user":{"login":"michaelklishin","id":1090,"avatar_url":"https://avatars3.githubusercontent.com/u/1090?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelklishin","html_url":"https://github.com/michaelklishin","followers_url":"https://api.github.com/users/michaelklishin/followers","following_url":"https://api.github.com/users/michaelklishin/following{/other_user}","gists_url":"https://api.github.com/users/michaelklishin/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelklishin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelklishin/subscriptions","organizations_url":"https://api.github.com/users/michaelklishin/orgs","repos_url":"https://api.github.com/users/michaelklishin/repos","events_url":"https://api.github.com/users/michaelklishin/events{/privacy}","received_events_url":"https://api.github.com/users/michaelklishin/received_events","type":"User","site_admin":false},"body":"This completely ignored `other_options` propagated by `AMQP.connect`, which breaks error handling and makes at least one test fail.","created_at":"2017-12-26T16:26:03Z","updated_at":"2017-12-26T16:26:03Z","html_url":"https://github.com/ruby-amqp/amqp/pull/237#discussion_r158719777","pull_request_url":"https://api.github.com/repos/ruby-amqp/amqp/pulls/237","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ruby-amqp/amqp/pulls/comments/158719777"},"html":{"href":"https://github.com/ruby-amqp/amqp/pull/237#discussion_r158719777"},"pull_request":{"href":"https://api.github.com/repos/ruby-amqp/amqp/pulls/237"}}},"pull_request":{"url":"https://api.github.com/repos/ruby-amqp/amqp/pulls/237","id":160141136,"html_url":"https://github.com/ruby-amqp/amqp/pull/237","diff_url":"https://github.com/ruby-amqp/amqp/pull/237.diff","patch_url":"https://github.com/ruby-amqp/amqp/pull/237.patch","issue_url":"https://api.github.com/repos/ruby-amqp/amqp/issues/237","number":237,"state":"open","locked":false,"title":" Adopt AMQ::Settings from amq-protocol gem","user":{"login":"Tensho","id":892721,"avatar_url":"https://avatars0.githubusercontent.com/u/892721?v=4","gravatar_id":"","url":"https://api.github.com/users/Tensho","html_url":"https://github.com/Tensho","followers_url":"https://api.github.com/users/Tensho/followers","following_url":"https://api.github.com/users/Tensho/following{/other_user}","gists_url":"https://api.github.com/users/Tensho/gists{/gist_id}","starred_url":"https://api.github.com/users/Tensho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tensho/subscriptions","organizations_url":"https://api.github.com/users/Tensho/orgs","repos_url":"https://api.github.com/users/Tensho/repos","events_url":"https://api.github.com/users/Tensho/events{/privacy}","received_events_url":"https://api.github.com/users/Tensho/received_events","type":"User","site_admin":false},"body":"Addresses ruby-amqp/amqp/issues/236\r\n\r\nActually `amqp` doesn't negotiate `chanel_max` and doesn't handle `connection_timeout`, so I added only `heartbeat` option after URI parsing.","created_at":"2017-12-26T15:32:32Z","updated_at":"2017-12-26T16:26:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3567e4aa5647e5716f1ec00ec0314f3ecbc60fc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ruby-amqp/amqp/pulls/237/commits","review_comments_url":"https://api.github.com/repos/ruby-amqp/amqp/pulls/237/comments","review_comment_url":"https://api.github.com/repos/ruby-amqp/amqp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ruby-amqp/amqp/issues/237/comments","statuses_url":"https://api.github.com/repos/ruby-amqp/amqp/statuses/03d0cd8f403daf8de3909aa306d62514af51b172","head":{"label":"Tensho:amq-settings","ref":"amq-settings","sha":"03d0cd8f403daf8de3909aa306d62514af51b172","user":{"login":"Tensho","id":892721,"avatar_url":"https://avatars0.githubusercontent.com/u/892721?v=4","gravatar_id":"","url":"https://api.github.com/users/Tensho","html_url":"https://github.com/Tensho","followers_url":"https://api.github.com/users/Tensho/followers","following_url":"https://api.github.com/users/Tensho/following{/other_user}","gists_url":"https://api.github.com/users/Tensho/gists{/gist_id}","starred_url":"https://api.github.com/users/Tensho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tensho/subscriptions","organizations_url":"https://api.github.com/users/Tensho/orgs","repos_url":"https://api.github.com/users/Tensho/repos","events_url":"https://api.github.com/users/Tensho/events{/privacy}","received_events_url":"https://api.github.com/users/Tensho/received_events","type":"User","site_admin":false},"repo":{"id":114878015,"name":"amqp","full_name":"Tensho/amqp","owner":{"login":"Tensho","id":892721,"avatar_url":"https://avatars0.githubusercontent.com/u/892721?v=4","gravatar_id":"","url":"https://api.github.com/users/Tensho","html_url":"https://github.com/Tensho","followers_url":"https://api.github.com/users/Tensho/followers","following_url":"https://api.github.com/users/Tensho/following{/other_user}","gists_url":"https://api.github.com/users/Tensho/gists{/gist_id}","starred_url":"https://api.github.com/users/Tensho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tensho/subscriptions","organizations_url":"https://api.github.com/users/Tensho/orgs","repos_url":"https://api.github.com/users/Tensho/repos","events_url":"https://api.github.com/users/Tensho/events{/privacy}","received_events_url":"https://api.github.com/users/Tensho/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Tensho/amqp","description":"EventMachine-based RabbitMQ client. Prefer Bunny: http://rubybunny.info. See documentation guides at http://rubyamqp.info.","fork":true,"url":"https://api.github.com/repos/Tensho/amqp","forks_url":"https://api.github.com/repos/Tensho/amqp/forks","keys_url":"https://api.github.com/repos/Tensho/amqp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Tensho/amqp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Tensho/amqp/teams","hooks_url":"https://api.github.com/repos/Tensho/amqp/hooks","issue_events_url":"https://api.github.com/repos/Tensho/amqp/issues/events{/number}","events_url":"https://api.github.com/repos/Tensho/amqp/events","assignees_url":"https://api.github.com/repos/Tensho/amqp/assignees{/user}","branches_url":"https://api.github.com/repos/Tensho/amqp/branches{/branch}","tags_url":"https://api.github.com/repos/Tensho/amqp/tags","blobs_url":"https://api.github.com/repos/Tensho/amqp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Tensho/amqp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Tensho/amqp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Tensho/amqp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Tensho/amqp/statuses/{sha}","languages_url":"https://api.github.com/repos/Tensho/amqp/languages","stargazers_url":"https://api.github.com/repos/Tensho/amqp/stargazers","contributors_url":"https://api.github.com/repos/Tensho/amqp/contributors","subscribers_url":"https://api.github.com/repos/Tensho/amqp/subscribers","subscription_url":"https://api.github.com/repos/Tensho/amqp/subscription","commits_url":"https://api.github.com/repos/Tensho/amqp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Tensho/amqp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Tensho/amqp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Tensho/amqp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Tensho/amqp/contents/{+path}","compare_url":"https://api.github.com/repos/Tensho/amqp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Tensho/amqp/merges","archive_url":"https://api.github.com/repos/Tensho/amqp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Tensho/amqp/downloads","issues_url":"https://api.github.com/repos/Tensho/amqp/issues{/number}","pulls_url":"https://api.github.com/repos/Tensho/amqp/pulls{/number}","milestones_url":"https://api.github.com/repos/Tensho/amqp/milestones{/number}","notifications_url":"https://api.github.com/repos/Tensho/amqp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Tensho/amqp/labels{/name}","releases_url":"https://api.github.com/repos/Tensho/amqp/releases{/id}","deployments_url":"https://api.github.com/repos/Tensho/amqp/deployments","created_at":"2017-12-20T11:11:07Z","updated_at":"2017-12-20T11:11:09Z","pushed_at":"2017-12-26T15:31:07Z","git_url":"git://github.com/Tensho/amqp.git","ssh_url":"git@github.com:Tensho/amqp.git","clone_url":"https://github.com/Tensho/amqp.git","svn_url":"https://github.com/Tensho/amqp","homepage":"http://rubyamqp.info","size":5993,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ruby-amqp:master","ref":"master","sha":"c46e834be632e0801c02e08554678fadf4d668d9","user":{"login":"ruby-amqp","id":551719,"avatar_url":"https://avatars0.githubusercontent.com/u/551719?v=4","gravatar_id":"","url":"https://api.github.com/users/ruby-amqp","html_url":"https://github.com/ruby-amqp","followers_url":"https://api.github.com/users/ruby-amqp/followers","following_url":"https://api.github.com/users/ruby-amqp/following{/other_user}","gists_url":"https://api.github.com/users/ruby-amqp/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby-amqp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby-amqp/subscriptions","organizations_url":"https://api.github.com/users/ruby-amqp/orgs","repos_url":"https://api.github.com/users/ruby-amqp/repos","events_url":"https://api.github.com/users/ruby-amqp/events{/privacy}","received_events_url":"https://api.github.com/users/ruby-amqp/received_events","type":"Organization","site_admin":false},"repo":{"id":1229146,"name":"amqp","full_name":"ruby-amqp/amqp","owner":{"login":"ruby-amqp","id":551719,"avatar_url":"https://avatars0.githubusercontent.com/u/551719?v=4","gravatar_id":"","url":"https://api.github.com/users/ruby-amqp","html_url":"https://github.com/ruby-amqp","followers_url":"https://api.github.com/users/ruby-amqp/followers","following_url":"https://api.github.com/users/ruby-amqp/following{/other_user}","gists_url":"https://api.github.com/users/ruby-amqp/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby-amqp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby-amqp/subscriptions","organizations_url":"https://api.github.com/users/ruby-amqp/orgs","repos_url":"https://api.github.com/users/ruby-amqp/repos","events_url":"https://api.github.com/users/ruby-amqp/events{/privacy}","received_events_url":"https://api.github.com/users/ruby-amqp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ruby-amqp/amqp","description":"EventMachine-based RabbitMQ client. Prefer Bunny: http://rubybunny.info. See documentation guides at http://rubyamqp.info.","fork":false,"url":"https://api.github.com/repos/ruby-amqp/amqp","forks_url":"https://api.github.com/repos/ruby-amqp/amqp/forks","keys_url":"https://api.github.com/repos/ruby-amqp/amqp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruby-amqp/amqp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruby-amqp/amqp/teams","hooks_url":"https://api.github.com/repos/ruby-amqp/amqp/hooks","issue_events_url":"https://api.github.com/repos/ruby-amqp/amqp/issues/events{/number}","events_url":"https://api.github.com/repos/ruby-amqp/amqp/events","assignees_url":"https://api.github.com/repos/ruby-amqp/amqp/assignees{/user}","branches_url":"https://api.github.com/repos/ruby-amqp/amqp/branches{/branch}","tags_url":"https://api.github.com/repos/ruby-amqp/amqp/tags","blobs_url":"https://api.github.com/repos/ruby-amqp/amqp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruby-amqp/amqp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruby-amqp/amqp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruby-amqp/amqp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruby-amqp/amqp/statuses/{sha}","languages_url":"https://api.github.com/repos/ruby-amqp/amqp/languages","stargazers_url":"https://api.github.com/repos/ruby-amqp/amqp/stargazers","contributors_url":"https://api.github.com/repos/ruby-amqp/amqp/contributors","subscribers_url":"https://api.github.com/repos/ruby-amqp/amqp/subscribers","subscription_url":"https://api.github.com/repos/ruby-amqp/amqp/subscription","commits_url":"https://api.github.com/repos/ruby-amqp/amqp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruby-amqp/amqp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruby-amqp/amqp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruby-amqp/amqp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruby-amqp/amqp/contents/{+path}","compare_url":"https://api.github.com/repos/ruby-amqp/amqp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruby-amqp/amqp/merges","archive_url":"https://api.github.com/repos/ruby-amqp/amqp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruby-amqp/amqp/downloads","issues_url":"https://api.github.com/repos/ruby-amqp/amqp/issues{/number}","pulls_url":"https://api.github.com/repos/ruby-amqp/amqp/pulls{/number}","milestones_url":"https://api.github.com/repos/ruby-amqp/amqp/milestones{/number}","notifications_url":"https://api.github.com/repos/ruby-amqp/amqp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruby-amqp/amqp/labels{/name}","releases_url":"https://api.github.com/repos/ruby-amqp/amqp/releases{/id}","deployments_url":"https://api.github.com/repos/ruby-amqp/amqp/deployments","created_at":"2011-01-07T10:14:40Z","updated_at":"2017-12-26T07:49:32Z","pushed_at":"2017-12-26T15:46:40Z","git_url":"git://github.com/ruby-amqp/amqp.git","ssh_url":"git@github.com:ruby-amqp/amqp.git","clone_url":"https://github.com/ruby-amqp/amqp.git","svn_url":"https://github.com/ruby-amqp/amqp","homepage":"http://rubyamqp.info","size":6004,"stargazers_count":602,"watchers_count":602,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":144,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":144,"open_issues":6,"watchers":602,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ruby-amqp/amqp/pulls/237"},"html":{"href":"https://github.com/ruby-amqp/amqp/pull/237"},"issue":{"href":"https://api.github.com/repos/ruby-amqp/amqp/issues/237"},"comments":{"href":"https://api.github.com/repos/ruby-amqp/amqp/issues/237/comments"},"review_comments":{"href":"https://api.github.com/repos/ruby-amqp/amqp/pulls/237/comments"},"review_comment":{"href":"https://api.github.com/repos/ruby-amqp/amqp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ruby-amqp/amqp/pulls/237/commits"},"statuses":{"href":"https://api.github.com/repos/ruby-amqp/amqp/statuses/03d0cd8f403daf8de3909aa306d62514af51b172"}},"author_association":"NONE"}}
{"actor":{"display_login":"michaelklishin"}}