{"action":"created","comment":{"url":"https://api.github.com/repos/Netflix/metacat/pulls/comments/140618047","pull_request_review_id":64722028,"id":140618047,"diff_hunk":"@@ -101,7 +100,7 @@ public Lookup get(final String name) {\n                 });\n         } catch (EmptyResultDataAccessException e) {\n             return null;\n-        } catch (DataAccessException e) {\n+        } catch (Exception e) {","path":"metacat-metadata-mysql/src/main/java/com/netflix/metacat/metadata/mysql/MySqlLookupService.java","position":84,"original_position":84,"commit_id":"e2c7600c65e9227698c743ad8e7e7d2125a17523","original_commit_id":"683ee12f719c0f69f35940ea99549f221aab6daf","user":{"login":"zhljen","id":7215091,"avatar_url":"https://avatars2.githubusercontent.com/u/7215091?v=4","gravatar_id":"","url":"https://api.github.com/users/zhljen","html_url":"https://github.com/zhljen","followers_url":"https://api.github.com/users/zhljen/followers","following_url":"https://api.github.com/users/zhljen/following{/other_user}","gists_url":"https://api.github.com/users/zhljen/gists{/gist_id}","starred_url":"https://api.github.com/users/zhljen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhljen/subscriptions","organizations_url":"https://api.github.com/users/zhljen/orgs","repos_url":"https://api.github.com/users/zhljen/repos","events_url":"https://api.github.com/users/zhljen/events{/privacy}","received_events_url":"https://api.github.com/users/zhljen/received_events","type":"User","site_admin":false},"body":"What's the exception here? If only the DataAccessException, should we be specific?","created_at":"2017-09-23T00:00:41Z","updated_at":"2017-09-23T00:21:27Z","html_url":"https://github.com/Netflix/metacat/pull/189#discussion_r140618047","pull_request_url":"https://api.github.com/repos/Netflix/metacat/pulls/189","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Netflix/metacat/pulls/comments/140618047"},"html":{"href":"https://github.com/Netflix/metacat/pull/189#discussion_r140618047"},"pull_request":{"href":"https://api.github.com/repos/Netflix/metacat/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/Netflix/metacat/pulls/189","id":142685823,"html_url":"https://github.com/Netflix/metacat/pull/189","diff_url":"https://github.com/Netflix/metacat/pull/189.diff","patch_url":"https://github.com/Netflix/metacat/pull/189.patch","issue_url":"https://api.github.com/repos/Netflix/metacat/issues/189","number":189,"state":"open","locked":false,"title":"Refactored the code around spring transaction semantics. ","user":{"login":"ajoymajumdar","id":17680456,"avatar_url":"https://avatars3.githubusercontent.com/u/17680456?v=4","gravatar_id":"","url":"https://api.github.com/users/ajoymajumdar","html_url":"https://github.com/ajoymajumdar","followers_url":"https://api.github.com/users/ajoymajumdar/followers","following_url":"https://api.github.com/users/ajoymajumdar/following{/other_user}","gists_url":"https://api.github.com/users/ajoymajumdar/gists{/gist_id}","starred_url":"https://api.github.com/users/ajoymajumdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajoymajumdar/subscriptions","organizations_url":"https://api.github.com/users/ajoymajumdar/orgs","repos_url":"https://api.github.com/users/ajoymajumdar/repos","events_url":"https://api.github.com/users/ajoymajumdar/events{/privacy}","received_events_url":"https://api.github.com/users/ajoymajumdar/received_events","type":"User","site_admin":false},"body":"1. Refactored the code around spring transaction semantics. Earlier we were using both - @Transactional and the TransactionTemplate.\r\n2. Modified the MetacatInitializationService to  start up on ContextRefreshEvent instead of being explicitly called from the constructor. This way it will start once all the spring context is initialized.","created_at":"2017-09-22T23:09:20Z","updated_at":"2017-09-23T00:21:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5852040e2730f4f339efe02b3e4305f669e7d599","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tgianos","id":7377597,"avatar_url":"https://avatars0.githubusercontent.com/u/7377597?v=4","gravatar_id":"","url":"https://api.github.com/users/tgianos","html_url":"https://github.com/tgianos","followers_url":"https://api.github.com/users/tgianos/followers","following_url":"https://api.github.com/users/tgianos/following{/other_user}","gists_url":"https://api.github.com/users/tgianos/gists{/gist_id}","starred_url":"https://api.github.com/users/tgianos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgianos/subscriptions","organizations_url":"https://api.github.com/users/tgianos/orgs","repos_url":"https://api.github.com/users/tgianos/repos","events_url":"https://api.github.com/users/tgianos/events{/privacy}","received_events_url":"https://api.github.com/users/tgianos/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Netflix/metacat/milestones/3","html_url":"https://github.com/Netflix/metacat/milestone/3","labels_url":"https://api.github.com/repos/Netflix/metacat/milestones/3/labels","id":2497981,"number":3,"title":"1.1.0","description":null,"creator":{"login":"tgianos","id":7377597,"avatar_url":"https://avatars0.githubusercontent.com/u/7377597?v=4","gravatar_id":"","url":"https://api.github.com/users/tgianos","html_url":"https://github.com/tgianos","followers_url":"https://api.github.com/users/tgianos/followers","following_url":"https://api.github.com/users/tgianos/following{/other_user}","gists_url":"https://api.github.com/users/tgianos/gists{/gist_id}","starred_url":"https://api.github.com/users/tgianos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgianos/subscriptions","organizations_url":"https://api.github.com/users/tgianos/orgs","repos_url":"https://api.github.com/users/tgianos/repos","events_url":"https://api.github.com/users/tgianos/events{/privacy}","received_events_url":"https://api.github.com/users/tgianos/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":56,"state":"open","created_at":"2017-05-03T16:50:29Z","updated_at":"2017-09-22T23:09:20Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Netflix/metacat/pulls/189/commits","review_comments_url":"https://api.github.com/repos/Netflix/metacat/pulls/189/comments","review_comment_url":"https://api.github.com/repos/Netflix/metacat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Netflix/metacat/issues/189/comments","statuses_url":"https://api.github.com/repos/Netflix/metacat/statuses/e2c7600c65e9227698c743ad8e7e7d2125a17523","head":{"label":"ajoymajumdar:master","ref":"master","sha":"e2c7600c65e9227698c743ad8e7e7d2125a17523","user":{"login":"ajoymajumdar","id":17680456,"avatar_url":"https://avatars3.githubusercontent.com/u/17680456?v=4","gravatar_id":"","url":"https://api.github.com/users/ajoymajumdar","html_url":"https://github.com/ajoymajumdar","followers_url":"https://api.github.com/users/ajoymajumdar/followers","following_url":"https://api.github.com/users/ajoymajumdar/following{/other_user}","gists_url":"https://api.github.com/users/ajoymajumdar/gists{/gist_id}","starred_url":"https://api.github.com/users/ajoymajumdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajoymajumdar/subscriptions","organizations_url":"https://api.github.com/users/ajoymajumdar/orgs","repos_url":"https://api.github.com/users/ajoymajumdar/repos","events_url":"https://api.github.com/users/ajoymajumdar/events{/privacy}","received_events_url":"https://api.github.com/users/ajoymajumdar/received_events","type":"User","site_admin":false},"repo":{"id":70099860,"name":"metacat","full_name":"ajoymajumdar/metacat","owner":{"login":"ajoymajumdar","id":17680456,"avatar_url":"https://avatars3.githubusercontent.com/u/17680456?v=4","gravatar_id":"","url":"https://api.github.com/users/ajoymajumdar","html_url":"https://github.com/ajoymajumdar","followers_url":"https://api.github.com/users/ajoymajumdar/followers","following_url":"https://api.github.com/users/ajoymajumdar/following{/other_user}","gists_url":"https://api.github.com/users/ajoymajumdar/gists{/gist_id}","starred_url":"https://api.github.com/users/ajoymajumdar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajoymajumdar/subscriptions","organizations_url":"https://api.github.com/users/ajoymajumdar/orgs","repos_url":"https://api.github.com/users/ajoymajumdar/repos","events_url":"https://api.github.com/users/ajoymajumdar/events{/privacy}","received_events_url":"https://api.github.com/users/ajoymajumdar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajoymajumdar/metacat","description":null,"fork":true,"url":"https://api.github.com/repos/ajoymajumdar/metacat","forks_url":"https://api.github.com/repos/ajoymajumdar/metacat/forks","keys_url":"https://api.github.com/repos/ajoymajumdar/metacat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajoymajumdar/metacat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajoymajumdar/metacat/teams","hooks_url":"https://api.github.com/repos/ajoymajumdar/metacat/hooks","issue_events_url":"https://api.github.com/repos/ajoymajumdar/metacat/issues/events{/number}","events_url":"https://api.github.com/repos/ajoymajumdar/metacat/events","assignees_url":"https://api.github.com/repos/ajoymajumdar/metacat/assignees{/user}","branches_url":"https://api.github.com/repos/ajoymajumdar/metacat/branches{/branch}","tags_url":"https://api.github.com/repos/ajoymajumdar/metacat/tags","blobs_url":"https://api.github.com/repos/ajoymajumdar/metacat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajoymajumdar/metacat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajoymajumdar/metacat/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajoymajumdar/metacat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajoymajumdar/metacat/statuses/{sha}","languages_url":"https://api.github.com/repos/ajoymajumdar/metacat/languages","stargazers_url":"https://api.github.com/repos/ajoymajumdar/metacat/stargazers","contributors_url":"https://api.github.com/repos/ajoymajumdar/metacat/contributors","subscribers_url":"https://api.github.com/repos/ajoymajumdar/metacat/subscribers","subscription_url":"https://api.github.com/repos/ajoymajumdar/metacat/subscription","commits_url":"https://api.github.com/repos/ajoymajumdar/metacat/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajoymajumdar/metacat/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajoymajumdar/metacat/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajoymajumdar/metacat/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajoymajumdar/metacat/contents/{+path}","compare_url":"https://api.github.com/repos/ajoymajumdar/metacat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajoymajumdar/metacat/merges","archive_url":"https://api.github.com/repos/ajoymajumdar/metacat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajoymajumdar/metacat/downloads","issues_url":"https://api.github.com/repos/ajoymajumdar/metacat/issues{/number}","pulls_url":"https://api.github.com/repos/ajoymajumdar/metacat/pulls{/number}","milestones_url":"https://api.github.com/repos/ajoymajumdar/metacat/milestones{/number}","notifications_url":"https://api.github.com/repos/ajoymajumdar/metacat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajoymajumdar/metacat/labels{/name}","releases_url":"https://api.github.com/repos/ajoymajumdar/metacat/releases{/id}","deployments_url":"https://api.github.com/repos/ajoymajumdar/metacat/deployments","created_at":"2016-10-05T21:12:02Z","updated_at":"2016-10-05T21:12:06Z","pushed_at":"2017-09-22T23:44:14Z","git_url":"git://github.com/ajoymajumdar/metacat.git","ssh_url":"git@github.com:ajoymajumdar/metacat.git","clone_url":"https://github.com/ajoymajumdar/metacat.git","svn_url":"https://github.com/ajoymajumdar/metacat","homepage":null,"size":4864,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Netflix:master","ref":"master","sha":"a625d3b2d7b0b4328fbbe2e9b399a926d40fb676","user":{"login":"Netflix","id":913567,"avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"repo":{"id":54284914,"name":"metacat","full_name":"Netflix/metacat","owner":{"login":"Netflix","id":913567,"avatar_url":"https://avatars3.githubusercontent.com/u/913567?v=4","gravatar_id":"","url":"https://api.github.com/users/Netflix","html_url":"https://github.com/Netflix","followers_url":"https://api.github.com/users/Netflix/followers","following_url":"https://api.github.com/users/Netflix/following{/other_user}","gists_url":"https://api.github.com/users/Netflix/gists{/gist_id}","starred_url":"https://api.github.com/users/Netflix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Netflix/subscriptions","organizations_url":"https://api.github.com/users/Netflix/orgs","repos_url":"https://api.github.com/users/Netflix/repos","events_url":"https://api.github.com/users/Netflix/events{/privacy}","received_events_url":"https://api.github.com/users/Netflix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Netflix/metacat","description":null,"fork":false,"url":"https://api.github.com/repos/Netflix/metacat","forks_url":"https://api.github.com/repos/Netflix/metacat/forks","keys_url":"https://api.github.com/repos/Netflix/metacat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Netflix/metacat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Netflix/metacat/teams","hooks_url":"https://api.github.com/repos/Netflix/metacat/hooks","issue_events_url":"https://api.github.com/repos/Netflix/metacat/issues/events{/number}","events_url":"https://api.github.com/repos/Netflix/metacat/events","assignees_url":"https://api.github.com/repos/Netflix/metacat/assignees{/user}","branches_url":"https://api.github.com/repos/Netflix/metacat/branches{/branch}","tags_url":"https://api.github.com/repos/Netflix/metacat/tags","blobs_url":"https://api.github.com/repos/Netflix/metacat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Netflix/metacat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Netflix/metacat/git/refs{/sha}","trees_url":"https://api.github.com/repos/Netflix/metacat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Netflix/metacat/statuses/{sha}","languages_url":"https://api.github.com/repos/Netflix/metacat/languages","stargazers_url":"https://api.github.com/repos/Netflix/metacat/stargazers","contributors_url":"https://api.github.com/repos/Netflix/metacat/contributors","subscribers_url":"https://api.github.com/repos/Netflix/metacat/subscribers","subscription_url":"https://api.github.com/repos/Netflix/metacat/subscription","commits_url":"https://api.github.com/repos/Netflix/metacat/commits{/sha}","git_commits_url":"https://api.github.com/repos/Netflix/metacat/git/commits{/sha}","comments_url":"https://api.github.com/repos/Netflix/metacat/comments{/number}","issue_comment_url":"https://api.github.com/repos/Netflix/metacat/issues/comments{/number}","contents_url":"https://api.github.com/repos/Netflix/metacat/contents/{+path}","compare_url":"https://api.github.com/repos/Netflix/metacat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Netflix/metacat/merges","archive_url":"https://api.github.com/repos/Netflix/metacat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Netflix/metacat/downloads","issues_url":"https://api.github.com/repos/Netflix/metacat/issues{/number}","pulls_url":"https://api.github.com/repos/Netflix/metacat/pulls{/number}","milestones_url":"https://api.github.com/repos/Netflix/metacat/milestones{/number}","notifications_url":"https://api.github.com/repos/Netflix/metacat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Netflix/metacat/labels{/name}","releases_url":"https://api.github.com/repos/Netflix/metacat/releases{/id}","deployments_url":"https://api.github.com/repos/Netflix/metacat/deployments","created_at":"2016-03-19T20:06:34Z","updated_at":"2017-09-12T14:06:02Z","pushed_at":"2017-09-22T23:44:15Z","git_url":"git://github.com/Netflix/metacat.git","ssh_url":"git@github.com:Netflix/metacat.git","clone_url":"https://github.com/Netflix/metacat.git","svn_url":"https://github.com/Netflix/metacat","homepage":null,"size":4840,"stargazers_count":79,"watchers_count":79,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":2,"forks":34,"open_issues":2,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Netflix/metacat/pulls/189"},"html":{"href":"https://github.com/Netflix/metacat/pull/189"},"issue":{"href":"https://api.github.com/repos/Netflix/metacat/issues/189"},"comments":{"href":"https://api.github.com/repos/Netflix/metacat/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/Netflix/metacat/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/Netflix/metacat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Netflix/metacat/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/Netflix/metacat/statuses/e2c7600c65e9227698c743ad8e7e7d2125a17523"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zhljen"}}