{"action":"created","comment":{"url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/comments/110844232","pull_request_review_id":32043863,"id":110844232,"diff_hunk":"@@ -0,0 +1,50 @@\n+<?php\n+\n+namespace Pim\\Bundle\\CatalogBundle\\tests\\integration\\PQB\\Sorter;\n+\n+use Pim\\Bundle\\CatalogBundle\\tests\\integration\\PQB\\AbstractProductQueryBuilderTestCase;\n+use Pim\\Component\\Catalog\\Query\\Sorter\\Directions;\n+\n+/**\n+ * @author    Damien Carcel (damien.carcel@akeneo.com)\n+ * @copyright 2017 Akeneo SAS (http://www.akeneo.com)\n+ * @license   http://opensource.org/licenses/osl-3.0.php Open Software License (OSL 3.0)\n+ */\n+class StatusSorterIntegration extends AbstractProductQueryBuilderTestCase\n+{\n+    /**\n+     * {@inheritdoc}\n+     */\n+    protected function setUp()\n+    {\n+        parent::setUp();\n+\n+        if (1 === self::$count || $this->getConfiguration()->isDatabasePurgedForEachTest()) {\n+            $this->createProduct('foo', ['enabled' => false]);\n+            $this->createProduct('bar', ['enabled' => true]);\n+            $this->createProduct('baz', ['enabled' => false]);\n+            $this->createProduct('foobar', ['enabled' => true]);","path":"src/Pim/Bundle/CatalogBundle/tests/integration/PQB/Sorter/StatusSorterIntegration.php","position":26,"original_position":26,"commit_id":"13d1f3e2e443a0cec5ee4283cad9e4dab3d51973","original_commit_id":"13d1f3e2e443a0cec5ee4283cad9e4dab3d51973","user":{"login":"SamirBoulil","id":1826473,"avatar_url":"https://avatars2.githubusercontent.com/u/1826473?v=3","gravatar_id":"","url":"https://api.github.com/users/SamirBoulil","html_url":"https://github.com/SamirBoulil","followers_url":"https://api.github.com/users/SamirBoulil/followers","following_url":"https://api.github.com/users/SamirBoulil/following{/other_user}","gists_url":"https://api.github.com/users/SamirBoulil/gists{/gist_id}","starred_url":"https://api.github.com/users/SamirBoulil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamirBoulil/subscriptions","organizations_url":"https://api.github.com/users/SamirBoulil/orgs","repos_url":"https://api.github.com/users/SamirBoulil/repos","events_url":"https://api.github.com/users/SamirBoulil/events{/privacy}","received_events_url":"https://api.github.com/users/SamirBoulil/received_events","type":"User","site_admin":false},"body":"Add one without an enabled value","created_at":"2017-04-11T08:41:26Z","updated_at":"2017-04-11T08:41:26Z","html_url":"https://github.com/jjanvier/pim-community-dev/pull/126#discussion_r110844232","pull_request_url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/126","_links":{"self":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/comments/110844232"},"html":{"href":"https://github.com/jjanvier/pim-community-dev/pull/126#discussion_r110844232"},"pull_request":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/126"}}},"pull_request":{"url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/126","id":115133611,"html_url":"https://github.com/jjanvier/pim-community-dev/pull/126","diff_url":"https://github.com/jjanvier/pim-community-dev/pull/126.diff","patch_url":"https://github.com/jjanvier/pim-community-dev/pull/126.patch","issue_url":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/126","number":126,"state":"open","locked":false,"title":"TIP-706: Add product status PQB sorter","user":{"login":"damien-carcel","id":5039018,"avatar_url":"https://avatars0.githubusercontent.com/u/5039018?v=3","gravatar_id":"","url":"https://api.github.com/users/damien-carcel","html_url":"https://github.com/damien-carcel","followers_url":"https://api.github.com/users/damien-carcel/followers","following_url":"https://api.github.com/users/damien-carcel/following{/other_user}","gists_url":"https://api.github.com/users/damien-carcel/gists{/gist_id}","starred_url":"https://api.github.com/users/damien-carcel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damien-carcel/subscriptions","organizations_url":"https://api.github.com/users/damien-carcel/orgs","repos_url":"https://api.github.com/users/damien-carcel/repos","events_url":"https://api.github.com/users/damien-carcel/events{/privacy}","received_events_url":"https://api.github.com/users/damien-carcel/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nThis PR adds a sorter on product status (enabled).\r\n\r\n## ES Sorter Checklist\r\n\r\n- [x] Add sorter integration tests for the field in the PQB\r\n- [ ] ~Add missing integration to the PimCatalogXIntegration tests for sort~ Not needed\r\n- [x] Add the sorter + specs\r\n- [x] Update the reference documentation\r\n\r\n## Definition Of Done\r\n\r\n| Q                                 | A\r\n| --------------------------------- | ---\r\n| Added Specs                       | -\r\n| Added Behats                      | -\r\n| Added integration tests           | OK\r\n| Changelog updated                 | -\r\n| Review and 2 GTM                  | Todo\r\n| Micro Demo to the PO (Story only) | -\r\n| Migration script                  | -\r\n| Tech Doc                          | -\r\n\r\n`Todo`: Pending / Work in progress\r\n`OK`: Done / Validated\r\n`-`: Not needed\r\n","created_at":"2017-04-10T15:55:00Z","updated_at":"2017-04-11T08:41:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fef40c3ea6d98551250fdefc5363e083da5631ff","assignee":{"login":"damien-carcel","id":5039018,"avatar_url":"https://avatars0.githubusercontent.com/u/5039018?v=3","gravatar_id":"","url":"https://api.github.com/users/damien-carcel","html_url":"https://github.com/damien-carcel","followers_url":"https://api.github.com/users/damien-carcel/followers","following_url":"https://api.github.com/users/damien-carcel/following{/other_user}","gists_url":"https://api.github.com/users/damien-carcel/gists{/gist_id}","starred_url":"https://api.github.com/users/damien-carcel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damien-carcel/subscriptions","organizations_url":"https://api.github.com/users/damien-carcel/orgs","repos_url":"https://api.github.com/users/damien-carcel/repos","events_url":"https://api.github.com/users/damien-carcel/events{/privacy}","received_events_url":"https://api.github.com/users/damien-carcel/received_events","type":"User","site_admin":false},"assignees":[{"login":"damien-carcel","id":5039018,"avatar_url":"https://avatars0.githubusercontent.com/u/5039018?v=3","gravatar_id":"","url":"https://api.github.com/users/damien-carcel","html_url":"https://github.com/damien-carcel","followers_url":"https://api.github.com/users/damien-carcel/followers","following_url":"https://api.github.com/users/damien-carcel/following{/other_user}","gists_url":"https://api.github.com/users/damien-carcel/gists{/gist_id}","starred_url":"https://api.github.com/users/damien-carcel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damien-carcel/subscriptions","organizations_url":"https://api.github.com/users/damien-carcel/orgs","repos_url":"https://api.github.com/users/damien-carcel/repos","events_url":"https://api.github.com/users/damien-carcel/events{/privacy}","received_events_url":"https://api.github.com/users/damien-carcel/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/126/commits","review_comments_url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/126/comments","review_comment_url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/126/comments","statuses_url":"https://api.github.com/repos/jjanvier/pim-community-dev/statuses/13d1f3e2e443a0cec5ee4283cad9e4dab3d51973","head":{"label":"damien-carcel:TIP-706-status-sorter","ref":"TIP-706-status-sorter","sha":"13d1f3e2e443a0cec5ee4283cad9e4dab3d51973","user":{"login":"damien-carcel","id":5039018,"avatar_url":"https://avatars0.githubusercontent.com/u/5039018?v=3","gravatar_id":"","url":"https://api.github.com/users/damien-carcel","html_url":"https://github.com/damien-carcel","followers_url":"https://api.github.com/users/damien-carcel/followers","following_url":"https://api.github.com/users/damien-carcel/following{/other_user}","gists_url":"https://api.github.com/users/damien-carcel/gists{/gist_id}","starred_url":"https://api.github.com/users/damien-carcel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damien-carcel/subscriptions","organizations_url":"https://api.github.com/users/damien-carcel/orgs","repos_url":"https://api.github.com/users/damien-carcel/repos","events_url":"https://api.github.com/users/damien-carcel/events{/privacy}","received_events_url":"https://api.github.com/users/damien-carcel/received_events","type":"User","site_admin":false},"repo":{"id":72995876,"name":"pim-community-dev","full_name":"damien-carcel/pim-community-dev","owner":{"login":"damien-carcel","id":5039018,"avatar_url":"https://avatars0.githubusercontent.com/u/5039018?v=3","gravatar_id":"","url":"https://api.github.com/users/damien-carcel","html_url":"https://github.com/damien-carcel","followers_url":"https://api.github.com/users/damien-carcel/followers","following_url":"https://api.github.com/users/damien-carcel/following{/other_user}","gists_url":"https://api.github.com/users/damien-carcel/gists{/gist_id}","starred_url":"https://api.github.com/users/damien-carcel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damien-carcel/subscriptions","organizations_url":"https://api.github.com/users/damien-carcel/orgs","repos_url":"https://api.github.com/users/damien-carcel/repos","events_url":"https://api.github.com/users/damien-carcel/events{/privacy}","received_events_url":"https://api.github.com/users/damien-carcel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/damien-carcel/pim-community-dev","description":"[Community Development Repository] The open source Product Information Management (PIM)","fork":true,"url":"https://api.github.com/repos/damien-carcel/pim-community-dev","forks_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/forks","keys_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/events","assignees_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/merges","archive_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/damien-carcel/pim-community-dev/deployments","created_at":"2016-11-06T14:26:54Z","updated_at":"2016-11-06T14:38:04Z","pushed_at":"2017-04-10T15:54:18Z","git_url":"git://github.com/damien-carcel/pim-community-dev.git","ssh_url":"git@github.com:damien-carcel/pim-community-dev.git","clone_url":"https://github.com/damien-carcel/pim-community-dev.git","svn_url":"https://github.com/damien-carcel/pim-community-dev","homepage":"http://www.akeneo.com","size":99419,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jjanvier:TIP-613-unified","ref":"TIP-613-unified","sha":"398a1430b9f53d81f56f5d22cd09f7c54ee27b05","user":{"login":"jjanvier","id":3691804,"avatar_url":"https://avatars0.githubusercontent.com/u/3691804?v=3","gravatar_id":"","url":"https://api.github.com/users/jjanvier","html_url":"https://github.com/jjanvier","followers_url":"https://api.github.com/users/jjanvier/followers","following_url":"https://api.github.com/users/jjanvier/following{/other_user}","gists_url":"https://api.github.com/users/jjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/jjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjanvier/subscriptions","organizations_url":"https://api.github.com/users/jjanvier/orgs","repos_url":"https://api.github.com/users/jjanvier/repos","events_url":"https://api.github.com/users/jjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/jjanvier/received_events","type":"User","site_admin":false},"repo":{"id":15071205,"name":"pim-community-dev","full_name":"jjanvier/pim-community-dev","owner":{"login":"jjanvier","id":3691804,"avatar_url":"https://avatars0.githubusercontent.com/u/3691804?v=3","gravatar_id":"","url":"https://api.github.com/users/jjanvier","html_url":"https://github.com/jjanvier","followers_url":"https://api.github.com/users/jjanvier/followers","following_url":"https://api.github.com/users/jjanvier/following{/other_user}","gists_url":"https://api.github.com/users/jjanvier/gists{/gist_id}","starred_url":"https://api.github.com/users/jjanvier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjanvier/subscriptions","organizations_url":"https://api.github.com/users/jjanvier/orgs","repos_url":"https://api.github.com/users/jjanvier/repos","events_url":"https://api.github.com/users/jjanvier/events{/privacy}","received_events_url":"https://api.github.com/users/jjanvier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjanvier/pim-community-dev","description":"PIM development repository","fork":true,"url":"https://api.github.com/repos/jjanvier/pim-community-dev","forks_url":"https://api.github.com/repos/jjanvier/pim-community-dev/forks","keys_url":"https://api.github.com/repos/jjanvier/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjanvier/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjanvier/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/jjanvier/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/jjanvier/pim-community-dev/events","assignees_url":"https://api.github.com/repos/jjanvier/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/jjanvier/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/jjanvier/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjanvier/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/jjanvier/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/jjanvier/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/jjanvier/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/jjanvier/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/jjanvier/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/jjanvier/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjanvier/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjanvier/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjanvier/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/jjanvier/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjanvier/pim-community-dev/merges","archive_url":"https://api.github.com/repos/jjanvier/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjanvier/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/jjanvier/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/jjanvier/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/jjanvier/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjanvier/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/jjanvier/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/jjanvier/pim-community-dev/deployments","created_at":"2013-12-10T08:27:21Z","updated_at":"2017-03-27T10:33:42Z","pushed_at":"2017-04-11T08:15:13Z","git_url":"git://github.com/jjanvier/pim-community-dev.git","ssh_url":"git@github.com:jjanvier/pim-community-dev.git","clone_url":"https://github.com/jjanvier/pim-community-dev.git","svn_url":"https://github.com/jjanvier/pim-community-dev","homepage":"http://akeneo.com","size":99425,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":20,"forks":0,"open_issues":20,"watchers":1,"default_branch":"TIP-613-unified"}},"_links":{"self":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/126"},"html":{"href":"https://github.com/jjanvier/pim-community-dev/pull/126"},"issue":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/126"},"comments":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/jjanvier/pim-community-dev/statuses/13d1f3e2e443a0cec5ee4283cad9e4dab3d51973"}}}}
{"actor":{"display_login":"SamirBoulil"}}