{"action":"created","issue":{"url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/121","repository_url":"https://api.github.com/repos/bitshares/bitshares-ui","labels_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/121/labels{/name}","comments_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/121/comments","events_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/121/events","html_url":"https://github.com/bitshares/bitshares-ui/issues/121","id":222329850,"number":121,"title":"Invoice.jsx needs update","user":{"login":"xeroc","id":117800,"avatar_url":"https://avatars3.githubusercontent.com/u/117800?v=3","gravatar_id":"","url":"https://api.github.com/users/xeroc","html_url":"https://github.com/xeroc","followers_url":"https://api.github.com/users/xeroc/followers","following_url":"https://api.github.com/users/xeroc/following{/other_user}","gists_url":"https://api.github.com/users/xeroc/gists{/gist_id}","starred_url":"https://api.github.com/users/xeroc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xeroc/subscriptions","organizations_url":"https://api.github.com/users/xeroc/orgs","repos_url":"https://api.github.com/users/xeroc/repos","events_url":"https://api.github.com/users/xeroc/events{/privacy}","received_events_url":"https://api.github.com/users/xeroc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-04-18T07:44:56Z","updated_at":"2017-06-23T20:02:52Z","closed_at":null,"body":"The invoice.jsx needs updating.\r\n\r\n* the \"pay\" button misses a label\r\n* the redirect to the callback as offer in the query string is not taken into account\r\n\r\nExample:\r\n    https://wallet.bitshares.eu/invoice/JLNHPVjqNdeaeXvP3A42vby858DvomCLVoMwbHNhrUFDvMBUHYabpXeZKCEhvKwKpvhSY9k3zvEJsmgqHywd8WVdj9bKyYrkKsA179o7mvHofS39rMYjNeCEWyrgqCDZcM9ZJuVk2S482rUa3tCFkTz3c9cBuuCVZVNYsaskQeLsdRntW2ZaejXrjshFKKqmTzTPotuXzAnEUSXuQ3RJCXet74PDWfNd44ynus4bDWtRTdXa2Vx8iUwVPzWhYaEKYxcsaZtMSSbfxfKL6yyvZU3CfC2sChxuLZhojgaUswpMkpinV6xDpwAicz5aHnpN4V4u7c4YQj9ZPVf5\r\n\r\nSee also: http://docs.bitshares.org/integration/merchants/merchant-protocol.html\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/comments/310760027","html_url":"https://github.com/bitshares/bitshares-ui/issues/121#issuecomment-310760027","issue_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/121","id":310760027,"user":{"login":"ProZachJ","id":2414138,"avatar_url":"https://avatars1.githubusercontent.com/u/2414138?v=3","gravatar_id":"","url":"https://api.github.com/users/ProZachJ","html_url":"https://github.com/ProZachJ","followers_url":"https://api.github.com/users/ProZachJ/followers","following_url":"https://api.github.com/users/ProZachJ/following{/other_user}","gists_url":"https://api.github.com/users/ProZachJ/gists{/gist_id}","starred_url":"https://api.github.com/users/ProZachJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProZachJ/subscriptions","organizations_url":"https://api.github.com/users/ProZachJ/orgs","repos_url":"https://api.github.com/users/ProZachJ/repos","events_url":"https://api.github.com/users/ProZachJ/events{/privacy}","received_events_url":"https://api.github.com/users/ProZachJ/received_events","type":"User","site_admin":false},"created_at":"2017-06-23T20:02:52Z","updated_at":"2017-06-23T20:02:52Z","body":"Tracing back why the callback is not being respected...\r\n\r\n`onBroadcastAndConfirm` does not appear to ever get called.\r\nhttps://github.com/bitshares/bitshares-ui/blob/bitshares/web/app/components/Transfer/Invoice.jsx#L74\r\n\r\nSimilarly in Transfer.jsx  `onTrxIncluded` doesn't appear to ever get called either.\r\nhttps://github.com/bitshares/bitshares-ui/blob/bitshares/web/app/components/Transfer/Transfer.jsx#L128\r\n\r\nI'm assuming that `onPayClick` is calling `TransactionConfirmationStore.listen` to register `onBroadcastAndConfirm` as a callback, but I'm unclear on where to find the implementation of `TransactionConfirmationStore.listen` I looked here: \r\n\r\nhttps://github.com/bitshares/bitshares-ui/blob/bitshares/web/app/stores/TransactionConfirmStore.js\r\n\r\nand here:\r\n\r\nhttps://github.com/bitshares/bitshares-ui/blob/bitshares/web/app/actions/TransactionConfirmActions.js\r\n\r\nMy best guess is the the `listen` method comes via reflection from bitsharesjs-ws?? Anyone know where I can peek into what it is supposed to be doing?"}}
{"actor":{"display_login":"ProZachJ"}}