{"push_id":1743735788,"size":48,"distinct_size":46,"ref":"refs/heads/update-refl-metadata","head":"a7c4a881cc9414a706dfc62d227615c7a1c6a72c","before":"888cb26ec5f8a661278a350c81d8b4d2b5df5126","commits":[{"sha":"d129f5b9ed638991541ce7edfcb5acfea67cb1c3","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Search for types by full namespace\n\nSome out-of-proc tests were failing on .NET Core because `System.Diagnostics.Process` is in its own assembly in .NET Core, but `GetTypeFromAssemblyUsingNamespace` always truncated the last element of the type name before searching for an assembly.\n\nFixing that by starting with the full specified type name and then continuing down the lop-off-last-element-and-try-again path.","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/d129f5b9ed638991541ce7edfcb5acfea67cb1c3"},{"sha":"479d82b9b6819746cc6f6570afc582b6e7cae0f1","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Capture logs in xunit for BuildManager_Tests","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/479d82b9b6819746cc6f6570afc582b6e7cae0f1"},{"sha":"37a03162ac9305b9779a96b7a0a80b4eb7da8006","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Modern invocation for OnLinkStatusChanged","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/37a03162ac9305b9779a96b7a0a80b4eb7da8006"},{"sha":"a76a178ac92503873005a1f6af822f5b2503b5e8","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Ignore setting EnableNodeReuse when it's disabled\n\nThis caused errors on some tests on .NET core--FEATURE_NODE_REUSE isn't available there, but the API could set it. Short-circuit the setting if the feature isn't available.","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/a76a178ac92503873005a1f6af822f5b2503b5e8"},{"sha":"4d5ad24d13c3ee9c67d3e66544979f42cd67117a","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Disable ShutdownNodesAfterParallelBuild for Core\n\nThis test identifies MSBuild worker process incorrectly. Fixing that and\nreenabling it is tracked by #1975.","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/4d5ad24d13c3ee9c67d3e66544979f42cd67117a"},{"sha":"fd50b05338befb2aa2ceba09d35d709987caa4e4","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Disable MsBuildForwardPropertiesFromChild tests\n\nThese tests are currently failing on .NET Core because of #1976.\nChanging to use the more-specific bug.","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/fd50b05338befb2aa2ceba09d35d709987caa4e4"},{"sha":"29c8e01d22eafc324774e37ef58fa40640dc3986","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Enable out-of-proc tests on .NET Core\n\nPartial fix for #933","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/29c8e01d22eafc324774e37ef58fa40640dc3986"},{"sha":"57bb996b9abce0ee2ba017251726d9192616958a","author":{"name":"Rainer Sigwald","email":"20757353435bfe65bb40c39b320327eb58f0ebb4@microsoft.com"},"message":"Test for GetTypeFromAssemblyUsingNamespace on Core\n\nExplicit regression test for d129f5b.","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/57bb996b9abce0ee2ba017251726d9192616958a"},{"sha":"28dc2d47dff389c8c4ee9f4b2e6921a85fd515bb","author":{"name":"Ankit Jain","email":"dea048ce545bea5ae889f9783e148fb3a5fc5dd3@xamarin.com"},"message":"Add a `baseDirectory` argument for LooksLikeUnixFilePath and ..\n\n.. MaybeAdjustFilePath. The former checks if the first segment of the\npath might be the name of an existent directory. This depends on the\nCWD, but in some cases we might need to check this in a different\ndirectory.\n\nFor example, project A initiates a build of project B, and while B is\nbeing evaluated the CWD may not have been updated, but the paths in B's\nproject file are relative to B. So, the checks should be done in B's\ndirectory.\n\nThis will be useful in an upcoming fix.","distinct":false,"url":"https://api.github.com/repos/radical/msbuild/commits/28dc2d47dff389c8c4ee9f4b2e6921a85fd515bb"},{"sha":"b93c1dd849d4af9eaeae5d72abc69fb75cc93b32","author":{"name":"Ankit Jain","email":"dea048ce545bea5ae889f9783e148fb3a5fc5dd3@xamarin.com"},"message":"Fix file path in item metadata, when CWD != project directory\n\nIf a project A has:\n\n    <Reference Include=\"foo\">\n        <HintPath>lib\\foo.dll</HintPath>\n    </Reference>\n\n.. we want to convert the HintPath metadata to unix style. And that\nhappens in Expander.ExpandInto* methods.\n\nBut if the solution is building A, then at evaluation time the CWD may not\nbe set to the project A's directory, which would cause the\n`LooksLikeUnixFilePath` test to fail for `lib\\foo.dll`, since `lib` does\nnot exist in the solution's directory. And Expander methods don't have\nthe context to know about this.\n\nSo, instead we do this conversion in LazyItemOperation and attempt to\nconvert the path, as if we were in that project A's directory.\n\n    #/abc/foo/foo.sln\n    abc/ $ msbuild foo/foo.sln\n\nOr basically any case where the CWD doesn't match project A's directory.\n\nThe test project fails in ResolveAssemblyReference with:\n\nwarning MSB3246: Resolved file has a bad image, no metadata, or is otherwise inaccessible. Could not find file \"/Users/ankit/Projects/tests/nuget-tests/ConsoleApp2/ConsoleApp2/lib\\fsharpFailsToEmbedResources.exe\"\n.. or ..\nwarning MSB3245: Could not resolve this reference. Could not locate the assembly \"fsharpFailsToEmbedResources, Version=1.0.0.0\". Check to make sure the assembly exists on disk. If this reference is required by your code, you may get compilation errors.\n\nFixes: https://bugzilla.xamarin.com/show_bug.cgi?id=55629","distinct":false,"url":"https://api.github.com/repos/radical/msbuild/commits/b93c1dd849d4af9eaeae5d72abc69fb75cc93b32"},{"sha":"c57e0bd2d9014280d2f006826a1de85b6a32d481","author":{"name":"Ankit Jain","email":"dd64cb36b65542e00037ff562e7e68e24af1f49f@gmail.com"},"message":"cibuild.sh: Add a --config parameter to choose Release/Debug (#2028)","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/c57e0bd2d9014280d2f006826a1de85b6a32d481"},{"sha":"e3723e906fe4a8bdd292c1b2b5a21ff38df5e9e1","author":{"name":"Andy Gerlicher","email":"183b50ea715be464c741bbcbf0cb5333676f825c@microsoft.com"},"message":"Use AssemblyName.Clone when possible. (#2016)\n\nAssemblyName.Clone() is not available in early versions of .NET Core.\r\nUntil we can upgrade MSBuild to use .NET Core 2.0, we can't call the\r\nClone method directly. This change will attempt to call .Clone using\r\nreflection and if not available fallback to the previous .NET Core\r\nbehavior.\r\n\r\nPotential fix for #2015 (when running on .NET Core 2.0).","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/e3723e906fe4a8bdd292c1b2b5a21ff38df5e9e1"},{"sha":"a21c94a37b24d6a8bf2e19f80e525af924a24267","author":{"name":"Andy Gerlicher","email":"183b50ea715be464c741bbcbf0cb5333676f825c@microsoft.com"},"message":"Bump version for 15.3 in preview branch","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/a21c94a37b24d6a8bf2e19f80e525af924a24267"},{"sha":"ec5b83027b823fb234b74f73390e85495ab84dbc","author":{"name":"Andy Gerlicher","email":"183b50ea715be464c741bbcbf0cb5333676f825c@microsoft.com"},"message":"Fix issue importing an SDK via Import element. (#2038)\n\n* This feature was regressed in #2002\r\n* Update unit tests to verify functionality\r\n* Update ProjectParser to parse SDK name/version values and construct an SdkReference object to be used by the evaluator.\r\n\r\nCloses #2034","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/ec5b83027b823fb234b74f73390e85495ab84dbc"},{"sha":"c3863ffb89b6ad03a6efdac4d68945e1ec72207e","author":{"name":"Ankit Jain","email":"dd64cb36b65542e00037ff562e7e68e24af1f49f@gmail.com"},"message":"[mono] Update bootstrap MSBuild.dll path in cibuild.sh (#2024)","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/c3863ffb89b6ad03a6efdac4d68945e1ec72207e"},{"sha":"549ba4c5aa1a98d6ff6cd09a8caa1450cafb050e","author":{"name":"Andy Gerlicher","email":"183b50ea715be464c741bbcbf0cb5333676f825c@microsoft.com"},"message":"Merge pull request #2025 from radical/fix-item-metadata-filepath\n\nFix file path in item metadata, when CWD != project directory","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/549ba4c5aa1a98d6ff6cd09a8caa1450cafb050e"},{"sha":"b99b9fae524bd9fc2477944c6fd7b7437a0db03f","author":{"name":"Mihai Codoban","email":"6f0014d2c83e6cc57245eb69659c97eb6147b06d@microsoft.com"},"message":"Project instance serialization (#2018)\n\nResolves #1726 \r\n\r\nFrom issue comments:\r\n\r\nPrevious to this change, when a build is requested on a ProjectInstance and an out of proc node is used, the out of proc node uses two ProjectInstance objects to recover the state. ProjectInstance1 is the deserialized one. Apparently serializing a ProjectInstance only keeps part of the state: global properties, properties, and items. Everything else (targets, using tasks, etc) is discarded. To recover the missing part of the state, the out of proc node Re-evaluates the entry project form disk into ProjectInstance2. It then merges the two by keeping the properties and items from ProjectInstance1 and everything else from ProjectInstance2.\r\n\r\nIf the properties and items from ProjectInstance1 influence what targets get loaded, and what imports get imported, and if the project files change while the build is running in a way that changes those properties and items, then weird stuff like this failure happens (target not found exception).\r\n\r\nThe fix is to change ProjectInstance to serialize the complete evaluated state, and the out of proc node to reuse it entirely without re-evaluation from disk.","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/b99b9fae524bd9fc2477944c6fd7b7437a0db03f"},{"sha":"0e8c695f7af207a6281c76de2369f91f9067da13","author":{"name":"Jeff Kluge","email":"1fb0b67ddb6632c6e78315608f3f7187af995d8b@microsoft.com"},"message":"Implement importing a list of files (#2014)\n\nAllows `<Import Project=\"import1.props;import2.props\" />` to work.  This also updates `Exists` so that this will work:\r\n\r\n```xml\r\n<Import Project=\"import1.props;import2.props\"\r\n   Condition=\"Exists('import1.props;import2.props')\" />\r\n```\r\n\r\nIt also works with properties:\r\n\r\n```xml\r\n<Project>\r\n\r\n  <PropertyGroup>\r\n    <Imports>import1.props</Imports>\r\n    <Imports>$(Imports);import2.props</Imports>\r\n  </PropertyGroup>\r\n\r\n  <Import Project=\"$(Imports)\" Condition=\" '$(Imports)' != '' And Exists($(Imports))\" />\r\n</Project>\r\n```\r\n**It does not work with items** because items are not available when evaluating `<Import />` elements.\r\n\r\nCloses #890","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/0e8c695f7af207a6281c76de2369f91f9067da13"},{"sha":"4019bd74431464450705b7cccebdb5b0f34a411c","author":{"name":"Mihai Codoban","email":"6f0014d2c83e6cc57245eb69659c97eb6147b06d@microsoft.com"},"message":"Remove ThreadPool usage from CompositeGlob (#2045)\n\nThreadPool threads are a scarce resource in Visual Studio, do not use them.","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/4019bd74431464450705b7cccebdb5b0f34a411c"},{"sha":"88d568c3be46d473f0dd23d5853b121f2a3c0f6b","author":{"name":"Matt Mitchell","email":"0262eae41c4828c272c16a0aa5246e9ca339a87b@microsoft.com"},"message":"Switch to branch specific CI job generation (#1930)\n\nChanges over to branch specific job generation where the netci.groovy file in each branch is processed to generate jobs for that branch.  This allows drift in process between branches over time.","distinct":true,"url":"https://api.github.com/repos/radical/msbuild/commits/88d568c3be46d473f0dd23d5853b121f2a3c0f6b"}]}
{"actor":{"display_login":"radical"}}