{"action":"opened","number":7,"pull_request":{"url":"https://api.github.com/repos/tyler-smith/go-bip32/pulls/7","id":142337818,"html_url":"https://github.com/tyler-smith/go-bip32/pull/7","diff_url":"https://github.com/tyler-smith/go-bip32/pull/7.diff","patch_url":"https://github.com/tyler-smith/go-bip32/pull/7.patch","issue_url":"https://api.github.com/repos/tyler-smith/go-bip32/issues/7","number":7,"state":"open","locked":false,"title":"Fix public parent key to public child key derivation","user":{"login":"bartekn","id":464938,"avatar_url":"https://avatars1.githubusercontent.com/u/464938?v=4","gravatar_id":"","url":"https://api.github.com/users/bartekn","html_url":"https://github.com/bartekn","followers_url":"https://api.github.com/users/bartekn/followers","following_url":"https://api.github.com/users/bartekn/following{/other_user}","gists_url":"https://api.github.com/users/bartekn/gists{/gist_id}","starred_url":"https://api.github.com/users/bartekn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartekn/subscriptions","organizations_url":"https://api.github.com/users/bartekn/orgs","repos_url":"https://api.github.com/users/bartekn/repos","events_url":"https://api.github.com/users/bartekn/events{/privacy}","received_events_url":"https://api.github.com/users/bartekn/received_events","type":"User","site_admin":false},"body":"Fixed multiple issues in [public parent key to public child key derivation](https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki#Public_parent_key_rarr_public_child_key) code.\r\n\r\n* `NewChildKey` function:\r\n  * For public parent -> public child derivation `data` variable was calculated like in \"private parent -> private child\" derivation (Data = ser<sub>P</sub>(point(k<sub>par</sub>) instead of Data = ser<sub>P</sub>(K<sub>par</sub>)).\r\n* `expandPublicKey` function:\r\n  * `X` variable was overwritten in `ySquared := X.Exp(X, big.NewInt(3), nil)`.\r\n[`func (*Int) Exp`](https://golang.org/pkg/math/big/#Int.Exp):\r\n    > Exp sets z = x**y mod |m| (i.e. the sign of m is ignored), and returns z.\r\n  * Removed `sqrt(n) = n^((q+1)/4) if q = 3 mod 4` calculations and switched to [`func (*Int) ModSqrt`](https://golang.org/pkg/math/big/#Int.ModSqrt) (it's using it [internally](https://golang.org/src/math/big/int.go?s=16897:16934#L712)).\r\n  * Finally fixed the code checking the sign of `sqrt(Y^2)`.","created_at":"2017-09-21T13:00:43Z","updated_at":"2017-09-21T13:00:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tyler-smith/go-bip32/pulls/7/commits","review_comments_url":"https://api.github.com/repos/tyler-smith/go-bip32/pulls/7/comments","review_comment_url":"https://api.github.com/repos/tyler-smith/go-bip32/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tyler-smith/go-bip32/issues/7/comments","statuses_url":"https://api.github.com/repos/tyler-smith/go-bip32/statuses/f2ce94af27e2dc98ce3fe31ab327c93083055938","head":{"label":"bartekn:public-parent-public-child","ref":"public-parent-public-child","sha":"f2ce94af27e2dc98ce3fe31ab327c93083055938","user":{"login":"bartekn","id":464938,"avatar_url":"https://avatars1.githubusercontent.com/u/464938?v=4","gravatar_id":"","url":"https://api.github.com/users/bartekn","html_url":"https://github.com/bartekn","followers_url":"https://api.github.com/users/bartekn/followers","following_url":"https://api.github.com/users/bartekn/following{/other_user}","gists_url":"https://api.github.com/users/bartekn/gists{/gist_id}","starred_url":"https://api.github.com/users/bartekn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartekn/subscriptions","organizations_url":"https://api.github.com/users/bartekn/orgs","repos_url":"https://api.github.com/users/bartekn/repos","events_url":"https://api.github.com/users/bartekn/events{/privacy}","received_events_url":"https://api.github.com/users/bartekn/received_events","type":"User","site_admin":false},"repo":{"id":104142869,"name":"go-bip32","full_name":"bartekn/go-bip32","owner":{"login":"bartekn","id":464938,"avatar_url":"https://avatars1.githubusercontent.com/u/464938?v=4","gravatar_id":"","url":"https://api.github.com/users/bartekn","html_url":"https://github.com/bartekn","followers_url":"https://api.github.com/users/bartekn/followers","following_url":"https://api.github.com/users/bartekn/following{/other_user}","gists_url":"https://api.github.com/users/bartekn/gists{/gist_id}","starred_url":"https://api.github.com/users/bartekn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartekn/subscriptions","organizations_url":"https://api.github.com/users/bartekn/orgs","repos_url":"https://api.github.com/users/bartekn/repos","events_url":"https://api.github.com/users/bartekn/events{/privacy}","received_events_url":"https://api.github.com/users/bartekn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bartekn/go-bip32","description":"Golang implementation of the BIP32 HD address spec","fork":true,"url":"https://api.github.com/repos/bartekn/go-bip32","forks_url":"https://api.github.com/repos/bartekn/go-bip32/forks","keys_url":"https://api.github.com/repos/bartekn/go-bip32/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bartekn/go-bip32/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bartekn/go-bip32/teams","hooks_url":"https://api.github.com/repos/bartekn/go-bip32/hooks","issue_events_url":"https://api.github.com/repos/bartekn/go-bip32/issues/events{/number}","events_url":"https://api.github.com/repos/bartekn/go-bip32/events","assignees_url":"https://api.github.com/repos/bartekn/go-bip32/assignees{/user}","branches_url":"https://api.github.com/repos/bartekn/go-bip32/branches{/branch}","tags_url":"https://api.github.com/repos/bartekn/go-bip32/tags","blobs_url":"https://api.github.com/repos/bartekn/go-bip32/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bartekn/go-bip32/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bartekn/go-bip32/git/refs{/sha}","trees_url":"https://api.github.com/repos/bartekn/go-bip32/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bartekn/go-bip32/statuses/{sha}","languages_url":"https://api.github.com/repos/bartekn/go-bip32/languages","stargazers_url":"https://api.github.com/repos/bartekn/go-bip32/stargazers","contributors_url":"https://api.github.com/repos/bartekn/go-bip32/contributors","subscribers_url":"https://api.github.com/repos/bartekn/go-bip32/subscribers","subscription_url":"https://api.github.com/repos/bartekn/go-bip32/subscription","commits_url":"https://api.github.com/repos/bartekn/go-bip32/commits{/sha}","git_commits_url":"https://api.github.com/repos/bartekn/go-bip32/git/commits{/sha}","comments_url":"https://api.github.com/repos/bartekn/go-bip32/comments{/number}","issue_comment_url":"https://api.github.com/repos/bartekn/go-bip32/issues/comments{/number}","contents_url":"https://api.github.com/repos/bartekn/go-bip32/contents/{+path}","compare_url":"https://api.github.com/repos/bartekn/go-bip32/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bartekn/go-bip32/merges","archive_url":"https://api.github.com/repos/bartekn/go-bip32/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bartekn/go-bip32/downloads","issues_url":"https://api.github.com/repos/bartekn/go-bip32/issues{/number}","pulls_url":"https://api.github.com/repos/bartekn/go-bip32/pulls{/number}","milestones_url":"https://api.github.com/repos/bartekn/go-bip32/milestones{/number}","notifications_url":"https://api.github.com/repos/bartekn/go-bip32/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bartekn/go-bip32/labels{/name}","releases_url":"https://api.github.com/repos/bartekn/go-bip32/releases{/id}","deployments_url":"https://api.github.com/repos/bartekn/go-bip32/deployments","created_at":"2017-09-20T00:05:06Z","updated_at":"2017-09-20T00:05:08Z","pushed_at":"2017-09-21T12:38:52Z","git_url":"git://github.com/bartekn/go-bip32.git","ssh_url":"git@github.com:bartekn/go-bip32.git","clone_url":"https://github.com/bartekn/go-bip32.git","svn_url":"https://github.com/bartekn/go-bip32","homepage":"","size":1570,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tyler-smith:master","ref":"master","sha":"93eb43abb0745799bf67c7efca9aa5198498b722","user":{"login":"tyler-smith","id":2145522,"avatar_url":"https://avatars0.githubusercontent.com/u/2145522?v=4","gravatar_id":"","url":"https://api.github.com/users/tyler-smith","html_url":"https://github.com/tyler-smith","followers_url":"https://api.github.com/users/tyler-smith/followers","following_url":"https://api.github.com/users/tyler-smith/following{/other_user}","gists_url":"https://api.github.com/users/tyler-smith/gists{/gist_id}","starred_url":"https://api.github.com/users/tyler-smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyler-smith/subscriptions","organizations_url":"https://api.github.com/users/tyler-smith/orgs","repos_url":"https://api.github.com/users/tyler-smith/repos","events_url":"https://api.github.com/users/tyler-smith/events{/privacy}","received_events_url":"https://api.github.com/users/tyler-smith/received_events","type":"User","site_admin":false},"repo":{"id":22456212,"name":"go-bip32","full_name":"tyler-smith/go-bip32","owner":{"login":"tyler-smith","id":2145522,"avatar_url":"https://avatars0.githubusercontent.com/u/2145522?v=4","gravatar_id":"","url":"https://api.github.com/users/tyler-smith","html_url":"https://github.com/tyler-smith","followers_url":"https://api.github.com/users/tyler-smith/followers","following_url":"https://api.github.com/users/tyler-smith/following{/other_user}","gists_url":"https://api.github.com/users/tyler-smith/gists{/gist_id}","starred_url":"https://api.github.com/users/tyler-smith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tyler-smith/subscriptions","organizations_url":"https://api.github.com/users/tyler-smith/orgs","repos_url":"https://api.github.com/users/tyler-smith/repos","events_url":"https://api.github.com/users/tyler-smith/events{/privacy}","received_events_url":"https://api.github.com/users/tyler-smith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tyler-smith/go-bip32","description":"Golang implementation of the BIP32 HD address spec","fork":false,"url":"https://api.github.com/repos/tyler-smith/go-bip32","forks_url":"https://api.github.com/repos/tyler-smith/go-bip32/forks","keys_url":"https://api.github.com/repos/tyler-smith/go-bip32/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tyler-smith/go-bip32/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tyler-smith/go-bip32/teams","hooks_url":"https://api.github.com/repos/tyler-smith/go-bip32/hooks","issue_events_url":"https://api.github.com/repos/tyler-smith/go-bip32/issues/events{/number}","events_url":"https://api.github.com/repos/tyler-smith/go-bip32/events","assignees_url":"https://api.github.com/repos/tyler-smith/go-bip32/assignees{/user}","branches_url":"https://api.github.com/repos/tyler-smith/go-bip32/branches{/branch}","tags_url":"https://api.github.com/repos/tyler-smith/go-bip32/tags","blobs_url":"https://api.github.com/repos/tyler-smith/go-bip32/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tyler-smith/go-bip32/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tyler-smith/go-bip32/git/refs{/sha}","trees_url":"https://api.github.com/repos/tyler-smith/go-bip32/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tyler-smith/go-bip32/statuses/{sha}","languages_url":"https://api.github.com/repos/tyler-smith/go-bip32/languages","stargazers_url":"https://api.github.com/repos/tyler-smith/go-bip32/stargazers","contributors_url":"https://api.github.com/repos/tyler-smith/go-bip32/contributors","subscribers_url":"https://api.github.com/repos/tyler-smith/go-bip32/subscribers","subscription_url":"https://api.github.com/repos/tyler-smith/go-bip32/subscription","commits_url":"https://api.github.com/repos/tyler-smith/go-bip32/commits{/sha}","git_commits_url":"https://api.github.com/repos/tyler-smith/go-bip32/git/commits{/sha}","comments_url":"https://api.github.com/repos/tyler-smith/go-bip32/comments{/number}","issue_comment_url":"https://api.github.com/repos/tyler-smith/go-bip32/issues/comments{/number}","contents_url":"https://api.github.com/repos/tyler-smith/go-bip32/contents/{+path}","compare_url":"https://api.github.com/repos/tyler-smith/go-bip32/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tyler-smith/go-bip32/merges","archive_url":"https://api.github.com/repos/tyler-smith/go-bip32/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tyler-smith/go-bip32/downloads","issues_url":"https://api.github.com/repos/tyler-smith/go-bip32/issues{/number}","pulls_url":"https://api.github.com/repos/tyler-smith/go-bip32/pulls{/number}","milestones_url":"https://api.github.com/repos/tyler-smith/go-bip32/milestones{/number}","notifications_url":"https://api.github.com/repos/tyler-smith/go-bip32/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tyler-smith/go-bip32/labels{/name}","releases_url":"https://api.github.com/repos/tyler-smith/go-bip32/releases{/id}","deployments_url":"https://api.github.com/repos/tyler-smith/go-bip32/deployments","created_at":"2014-07-31T04:18:32Z","updated_at":"2017-08-27T21:46:38Z","pushed_at":"2017-09-20T00:07:12Z","git_url":"git://github.com/tyler-smith/go-bip32.git","ssh_url":"git@github.com:tyler-smith/go-bip32.git","clone_url":"https://github.com/tyler-smith/go-bip32.git","svn_url":"https://github.com/tyler-smith/go-bip32","homepage":"","size":1574,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tyler-smith/go-bip32/pulls/7"},"html":{"href":"https://github.com/tyler-smith/go-bip32/pull/7"},"issue":{"href":"https://api.github.com/repos/tyler-smith/go-bip32/issues/7"},"comments":{"href":"https://api.github.com/repos/tyler-smith/go-bip32/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/tyler-smith/go-bip32/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/tyler-smith/go-bip32/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tyler-smith/go-bip32/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/tyler-smith/go-bip32/statuses/f2ce94af27e2dc98ce3fe31ab327c93083055938"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":66,"deletions":19,"changed_files":3}}
{"actor":{"display_login":"bartekn"}}