{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/127826362","pull_request_review_id":50448537,"id":127826362,"diff_hunk":"@@ -92,6 +92,7 @@ func NewCmdProcess(fullName string, f *clientcmd.Factory, in io.Reader, out, err\n \tcmd.Flags().StringArrayVarP(params, \"param\", \"p\", nil, \"Specify a key-value pair (eg. -p FOO=BAR) to set/override a parameter value in the template.\")\n \tcmd.Flags().StringArray(\"param-file\", []string{}, \"File containing template parameter values to set/override in the template.\")\n \tcmd.MarkFlagFilename(\"param-file\")\n+\tcmd.Flags().Bool(\"ignore-unknown-parameters\", false, \"If true, will not stop processing the template when a parameter is not valid.\")","path":"pkg/cmd/cli/cmd/process.go","position":4,"original_position":4,"commit_id":"e22ac23b0e3870627084c3e648b846e6da532225","original_commit_id":"e22ac23b0e3870627084c3e648b846e6da532225","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"same help text change here.\r\n","created_at":"2017-07-17T21:09:10Z","updated_at":"2017-07-17T21:09:56Z","html_url":"https://github.com/openshift/origin/pull/15230#discussion_r127826362","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/15230","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/127826362"},"html":{"href":"https://github.com/openshift/origin/pull/15230#discussion_r127826362"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/15230"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/15230","id":130766547,"html_url":"https://github.com/openshift/origin/pull/15230","diff_url":"https://github.com/openshift/origin/pull/15230.diff","patch_url":"https://github.com/openshift/origin/pull/15230.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/15230","number":15230,"state":"open","locked":false,"title":"add --ignore-unknown-parameters flag to new-app and process","user":{"login":"matthyx","id":20683409,"avatar_url":"https://avatars1.githubusercontent.com/u/20683409?v=4","gravatar_id":"","url":"https://api.github.com/users/matthyx","html_url":"https://github.com/matthyx","followers_url":"https://api.github.com/users/matthyx/followers","following_url":"https://api.github.com/users/matthyx/following{/other_user}","gists_url":"https://api.github.com/users/matthyx/gists{/gist_id}","starred_url":"https://api.github.com/users/matthyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthyx/subscriptions","organizations_url":"https://api.github.com/users/matthyx/orgs","repos_url":"https://api.github.com/users/matthyx/repos","events_url":"https://api.github.com/users/matthyx/events{/privacy}","received_events_url":"https://api.github.com/users/matthyx/received_events","type":"User","site_admin":false},"body":"'oc process' should be able to ignore invalid parameter names via a flag #12909","created_at":"2017-07-16T21:15:23Z","updated_at":"2017-07-17T21:09:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aea4552cfc93debcfea4d92faf51baf0ec9857fc","assignee":{"login":"bparees","id":4974046,"avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"assignees":[{"login":"bparees","id":4974046,"avatar_url":"https://avatars2.githubusercontent.com/u/4974046?v=4","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/15230/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/15230/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/15230/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/e22ac23b0e3870627084c3e648b846e6da532225","head":{"label":"matthyx:issue-12909","ref":"issue-12909","sha":"e22ac23b0e3870627084c3e648b846e6da532225","user":{"login":"matthyx","id":20683409,"avatar_url":"https://avatars1.githubusercontent.com/u/20683409?v=4","gravatar_id":"","url":"https://api.github.com/users/matthyx","html_url":"https://github.com/matthyx","followers_url":"https://api.github.com/users/matthyx/followers","following_url":"https://api.github.com/users/matthyx/following{/other_user}","gists_url":"https://api.github.com/users/matthyx/gists{/gist_id}","starred_url":"https://api.github.com/users/matthyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthyx/subscriptions","organizations_url":"https://api.github.com/users/matthyx/orgs","repos_url":"https://api.github.com/users/matthyx/repos","events_url":"https://api.github.com/users/matthyx/events{/privacy}","received_events_url":"https://api.github.com/users/matthyx/received_events","type":"User","site_admin":false},"repo":{"id":70885055,"name":"origin","full_name":"matthyx/origin","owner":{"login":"matthyx","id":20683409,"avatar_url":"https://avatars1.githubusercontent.com/u/20683409?v=4","gravatar_id":"","url":"https://api.github.com/users/matthyx","html_url":"https://github.com/matthyx","followers_url":"https://api.github.com/users/matthyx/followers","following_url":"https://api.github.com/users/matthyx/following{/other_user}","gists_url":"https://api.github.com/users/matthyx/gists{/gist_id}","starred_url":"https://api.github.com/users/matthyx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthyx/subscriptions","organizations_url":"https://api.github.com/users/matthyx/orgs","repos_url":"https://api.github.com/users/matthyx/repos","events_url":"https://api.github.com/users/matthyx/events{/privacy}","received_events_url":"https://api.github.com/users/matthyx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthyx/origin","description":"Enterprise-Ready Kubernetes for Developers","fork":true,"url":"https://api.github.com/repos/matthyx/origin","forks_url":"https://api.github.com/repos/matthyx/origin/forks","keys_url":"https://api.github.com/repos/matthyx/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthyx/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthyx/origin/teams","hooks_url":"https://api.github.com/repos/matthyx/origin/hooks","issue_events_url":"https://api.github.com/repos/matthyx/origin/issues/events{/number}","events_url":"https://api.github.com/repos/matthyx/origin/events","assignees_url":"https://api.github.com/repos/matthyx/origin/assignees{/user}","branches_url":"https://api.github.com/repos/matthyx/origin/branches{/branch}","tags_url":"https://api.github.com/repos/matthyx/origin/tags","blobs_url":"https://api.github.com/repos/matthyx/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthyx/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthyx/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthyx/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthyx/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/matthyx/origin/languages","stargazers_url":"https://api.github.com/repos/matthyx/origin/stargazers","contributors_url":"https://api.github.com/repos/matthyx/origin/contributors","subscribers_url":"https://api.github.com/repos/matthyx/origin/subscribers","subscription_url":"https://api.github.com/repos/matthyx/origin/subscription","commits_url":"https://api.github.com/repos/matthyx/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthyx/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthyx/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthyx/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthyx/origin/contents/{+path}","compare_url":"https://api.github.com/repos/matthyx/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthyx/origin/merges","archive_url":"https://api.github.com/repos/matthyx/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthyx/origin/downloads","issues_url":"https://api.github.com/repos/matthyx/origin/issues{/number}","pulls_url":"https://api.github.com/repos/matthyx/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/matthyx/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/matthyx/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthyx/origin/labels{/name}","releases_url":"https://api.github.com/repos/matthyx/origin/releases{/id}","deployments_url":"https://api.github.com/repos/matthyx/origin/deployments","created_at":"2016-10-14T07:25:58Z","updated_at":"2016-10-14T07:26:07Z","pushed_at":"2017-07-17T20:38:21Z","git_url":"git://github.com/matthyx/origin.git","ssh_url":"git@github.com:matthyx/origin.git","clone_url":"https://github.com/matthyx/origin.git","svn_url":"https://github.com/matthyx/origin","homepage":"http://www.openshift.org","size":701470,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"6c3acd2ffd33c09dbab41f3e5bc624c81c0110ce","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2017-07-17T15:49:36Z","pushed_at":"2017-07-17T20:57:06Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":712026,"stargazers_count":3079,"watchers_count":3079,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2051,"mirror_url":null,"open_issues_count":1309,"forks":2051,"open_issues":1309,"watchers":3079,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/15230"},"html":{"href":"https://github.com/openshift/origin/pull/15230"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/15230"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/15230/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/15230/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/15230/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/e22ac23b0e3870627084c3e648b846e6da532225"}}}}
{"actor":{"display_login":"bparees"}}