{"action":"opened","number":1301,"pull_request":{"url":"https://api.github.com/repos/google/blockly/pulls/1301","id":138984479,"html_url":"https://github.com/google/blockly/pull/1301","diff_url":"https://github.com/google/blockly/pull/1301.diff","patch_url":"https://github.com/google/blockly/pull/1301.patch","issue_url":"https://api.github.com/repos/google/blockly/issues/1301","number":1301,"state":"open","locked":false,"title":"Fix for Flyout labels causing Flyout scroll issues","user":{"login":"microsoftsam","id":16690124,"avatar_url":"https://avatars3.githubusercontent.com/u/16690124?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoftsam","html_url":"https://github.com/microsoftsam","followers_url":"https://api.github.com/users/microsoftsam/followers","following_url":"https://api.github.com/users/microsoftsam/following{/other_user}","gists_url":"https://api.github.com/users/microsoftsam/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoftsam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoftsam/subscriptions","organizations_url":"https://api.github.com/users/microsoftsam/orgs","repos_url":"https://api.github.com/users/microsoftsam/repos","events_url":"https://api.github.com/users/microsoftsam/events{/privacy}","received_events_url":"https://api.github.com/users/microsoftsam/received_events","type":"User","site_admin":false},"body":"Fixes #1195\r\n\r\nWhen creating Blocks, Flyout_Base creates a rect around each block and records a reference to it in backgroundButtons_\r\nIt uses the index of the block to set it in the array, so in the instance there is a FlyoutButton, that takes up an index, but doesn't create a rect and hence it's position in the array is undefined.\r\nie: Block, Block, FlyoutButton/Label, Block, Block creates this array:\r\nbackgroundButtons_ = [rect, rect, undefined, rect, rect].\r\n\r\nThe issue is the clearOldBlocks_ method in FlyoutBase iterates through the backgroundButtons_ array clearing each rect as it goes, until it reaches an undefined block. This means the last couple of rects are not cleared and remain in the workspace Canvas, causing scrolling issues listed above.\r\n\r\nSo fix for this is to update the clearOldBlocks_ method in Flyout base to iterate through all the elements, and only clear if the rect is defined.","created_at":"2017-09-01T22:39:18Z","updated_at":"2017-09-01T22:39:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/blockly/pulls/1301/commits","review_comments_url":"https://api.github.com/repos/google/blockly/pulls/1301/comments","review_comment_url":"https://api.github.com/repos/google/blockly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/blockly/issues/1301/comments","statuses_url":"https://api.github.com/repos/google/blockly/statuses/b7c0aedd44b25772028373feaf3d9be24e344e2e","head":{"label":"microsoftsam:develop_scrollbarfix","ref":"develop_scrollbarfix","sha":"b7c0aedd44b25772028373feaf3d9be24e344e2e","user":{"login":"microsoftsam","id":16690124,"avatar_url":"https://avatars3.githubusercontent.com/u/16690124?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoftsam","html_url":"https://github.com/microsoftsam","followers_url":"https://api.github.com/users/microsoftsam/followers","following_url":"https://api.github.com/users/microsoftsam/following{/other_user}","gists_url":"https://api.github.com/users/microsoftsam/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoftsam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoftsam/subscriptions","organizations_url":"https://api.github.com/users/microsoftsam/orgs","repos_url":"https://api.github.com/users/microsoftsam/repos","events_url":"https://api.github.com/users/microsoftsam/events{/privacy}","received_events_url":"https://api.github.com/users/microsoftsam/received_events","type":"User","site_admin":false},"repo":{"id":95860456,"name":"blockly","full_name":"microsoftsam/blockly","owner":{"login":"microsoftsam","id":16690124,"avatar_url":"https://avatars3.githubusercontent.com/u/16690124?v=4","gravatar_id":"","url":"https://api.github.com/users/microsoftsam","html_url":"https://github.com/microsoftsam","followers_url":"https://api.github.com/users/microsoftsam/followers","following_url":"https://api.github.com/users/microsoftsam/following{/other_user}","gists_url":"https://api.github.com/users/microsoftsam/gists{/gist_id}","starred_url":"https://api.github.com/users/microsoftsam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/microsoftsam/subscriptions","organizations_url":"https://api.github.com/users/microsoftsam/orgs","repos_url":"https://api.github.com/users/microsoftsam/repos","events_url":"https://api.github.com/users/microsoftsam/events{/privacy}","received_events_url":"https://api.github.com/users/microsoftsam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/microsoftsam/blockly","description":"The web-based visual programming editor.","fork":true,"url":"https://api.github.com/repos/microsoftsam/blockly","forks_url":"https://api.github.com/repos/microsoftsam/blockly/forks","keys_url":"https://api.github.com/repos/microsoftsam/blockly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/microsoftsam/blockly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/microsoftsam/blockly/teams","hooks_url":"https://api.github.com/repos/microsoftsam/blockly/hooks","issue_events_url":"https://api.github.com/repos/microsoftsam/blockly/issues/events{/number}","events_url":"https://api.github.com/repos/microsoftsam/blockly/events","assignees_url":"https://api.github.com/repos/microsoftsam/blockly/assignees{/user}","branches_url":"https://api.github.com/repos/microsoftsam/blockly/branches{/branch}","tags_url":"https://api.github.com/repos/microsoftsam/blockly/tags","blobs_url":"https://api.github.com/repos/microsoftsam/blockly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/microsoftsam/blockly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/microsoftsam/blockly/git/refs{/sha}","trees_url":"https://api.github.com/repos/microsoftsam/blockly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/microsoftsam/blockly/statuses/{sha}","languages_url":"https://api.github.com/repos/microsoftsam/blockly/languages","stargazers_url":"https://api.github.com/repos/microsoftsam/blockly/stargazers","contributors_url":"https://api.github.com/repos/microsoftsam/blockly/contributors","subscribers_url":"https://api.github.com/repos/microsoftsam/blockly/subscribers","subscription_url":"https://api.github.com/repos/microsoftsam/blockly/subscription","commits_url":"https://api.github.com/repos/microsoftsam/blockly/commits{/sha}","git_commits_url":"https://api.github.com/repos/microsoftsam/blockly/git/commits{/sha}","comments_url":"https://api.github.com/repos/microsoftsam/blockly/comments{/number}","issue_comment_url":"https://api.github.com/repos/microsoftsam/blockly/issues/comments{/number}","contents_url":"https://api.github.com/repos/microsoftsam/blockly/contents/{+path}","compare_url":"https://api.github.com/repos/microsoftsam/blockly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/microsoftsam/blockly/merges","archive_url":"https://api.github.com/repos/microsoftsam/blockly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/microsoftsam/blockly/downloads","issues_url":"https://api.github.com/repos/microsoftsam/blockly/issues{/number}","pulls_url":"https://api.github.com/repos/microsoftsam/blockly/pulls{/number}","milestones_url":"https://api.github.com/repos/microsoftsam/blockly/milestones{/number}","notifications_url":"https://api.github.com/repos/microsoftsam/blockly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/microsoftsam/blockly/labels{/name}","releases_url":"https://api.github.com/repos/microsoftsam/blockly/releases{/id}","deployments_url":"https://api.github.com/repos/microsoftsam/blockly/deployments","created_at":"2017-06-30T07:15:34Z","updated_at":"2017-06-30T07:15:37Z","pushed_at":"2017-09-01T22:38:00Z","git_url":"git://github.com/microsoftsam/blockly.git","ssh_url":"git@github.com:microsoftsam/blockly.git","clone_url":"https://github.com/microsoftsam/blockly.git","svn_url":"https://github.com/microsoftsam/blockly","homepage":"https://developers.google.com/blockly/","size":63339,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:develop","ref":"develop","sha":"55188733896062f64937d4b698be850579c4eee5","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":13872231,"name":"blockly","full_name":"google/blockly","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/blockly","description":"The web-based visual programming editor.","fork":false,"url":"https://api.github.com/repos/google/blockly","forks_url":"https://api.github.com/repos/google/blockly/forks","keys_url":"https://api.github.com/repos/google/blockly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/blockly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/blockly/teams","hooks_url":"https://api.github.com/repos/google/blockly/hooks","issue_events_url":"https://api.github.com/repos/google/blockly/issues/events{/number}","events_url":"https://api.github.com/repos/google/blockly/events","assignees_url":"https://api.github.com/repos/google/blockly/assignees{/user}","branches_url":"https://api.github.com/repos/google/blockly/branches{/branch}","tags_url":"https://api.github.com/repos/google/blockly/tags","blobs_url":"https://api.github.com/repos/google/blockly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/blockly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/blockly/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/blockly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/blockly/statuses/{sha}","languages_url":"https://api.github.com/repos/google/blockly/languages","stargazers_url":"https://api.github.com/repos/google/blockly/stargazers","contributors_url":"https://api.github.com/repos/google/blockly/contributors","subscribers_url":"https://api.github.com/repos/google/blockly/subscribers","subscription_url":"https://api.github.com/repos/google/blockly/subscription","commits_url":"https://api.github.com/repos/google/blockly/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/blockly/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/blockly/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/blockly/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/blockly/contents/{+path}","compare_url":"https://api.github.com/repos/google/blockly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/blockly/merges","archive_url":"https://api.github.com/repos/google/blockly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/blockly/downloads","issues_url":"https://api.github.com/repos/google/blockly/issues{/number}","pulls_url":"https://api.github.com/repos/google/blockly/pulls{/number}","milestones_url":"https://api.github.com/repos/google/blockly/milestones{/number}","notifications_url":"https://api.github.com/repos/google/blockly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/blockly/labels{/name}","releases_url":"https://api.github.com/repos/google/blockly/releases{/id}","deployments_url":"https://api.github.com/repos/google/blockly/deployments","created_at":"2013-10-25T21:13:33Z","updated_at":"2017-09-01T14:59:43Z","pushed_at":"2017-08-31T05:50:32Z","git_url":"git://github.com/google/blockly.git","ssh_url":"git@github.com:google/blockly.git","clone_url":"https://github.com/google/blockly.git","svn_url":"https://github.com/google/blockly","homepage":"https://developers.google.com/blockly/","size":65729,"stargazers_count":3690,"watchers_count":3690,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1286,"mirror_url":null,"open_issues_count":242,"forks":1286,"open_issues":242,"watchers":3690,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/blockly/pulls/1301"},"html":{"href":"https://github.com/google/blockly/pull/1301"},"issue":{"href":"https://api.github.com/repos/google/blockly/issues/1301"},"comments":{"href":"https://api.github.com/repos/google/blockly/issues/1301/comments"},"review_comments":{"href":"https://api.github.com/repos/google/blockly/pulls/1301/comments"},"review_comment":{"href":"https://api.github.com/repos/google/blockly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/blockly/pulls/1301/commits"},"statuses":{"href":"https://api.github.com/repos/google/blockly/statuses/b7c0aedd44b25772028373feaf3d9be24e344e2e"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"microsoftsam"}}