{"action":"created","issue":{"url":"https://api.github.com/repos/netsec-ethz/scion-coord/issues/51","repository_url":"https://api.github.com/repos/netsec-ethz/scion-coord","labels_url":"https://api.github.com/repos/netsec-ethz/scion-coord/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/netsec-ethz/scion-coord/issues/51/comments","events_url":"https://api.github.com/repos/netsec-ethz/scion-coord/issues/51/events","html_url":"https://github.com/netsec-ethz/scion-coord/pull/51","id":252609057,"number":51,"title":"Activation-Link resending","user":{"login":"chaehni","id":26694529,"avatar_url":"https://avatars3.githubusercontent.com/u/26694529?v=4","gravatar_id":"","url":"https://api.github.com/users/chaehni","html_url":"https://github.com/chaehni","followers_url":"https://api.github.com/users/chaehni/followers","following_url":"https://api.github.com/users/chaehni/following{/other_user}","gists_url":"https://api.github.com/users/chaehni/gists{/gist_id}","starred_url":"https://api.github.com/users/chaehni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaehni/subscriptions","organizations_url":"https://api.github.com/users/chaehni/orgs","repos_url":"https://api.github.com/users/chaehni/repos","events_url":"https://api.github.com/users/chaehni/events{/privacy}","received_events_url":"https://api.github.com/users/chaehni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-08-24T13:53:23Z","updated_at":"2017-09-06T06:16:49Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/netsec-ethz/scion-coord/pulls/51","html_url":"https://github.com/netsec-ethz/scion-coord/pull/51","diff_url":"https://github.com/netsec-ethz/scion-coord/pull/51.diff","patch_url":"https://github.com/netsec-ethz/scion-coord/pull/51.patch"},"body":"This PR adds functionality to resend the user activation link in case of loss.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/netsec-ethz/scion-coord/51)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/netsec-ethz/scion-coord/issues/comments/327385842","html_url":"https://github.com/netsec-ethz/scion-coord/pull/51#issuecomment-327385842","issue_url":"https://api.github.com/repos/netsec-ethz/scion-coord/issues/51","id":327385842,"user":{"login":"mlegner","id":5960634,"avatar_url":"https://avatars1.githubusercontent.com/u/5960634?v=4","gravatar_id":"","url":"https://api.github.com/users/mlegner","html_url":"https://github.com/mlegner","followers_url":"https://api.github.com/users/mlegner/followers","following_url":"https://api.github.com/users/mlegner/following{/other_user}","gists_url":"https://api.github.com/users/mlegner/gists{/gist_id}","starred_url":"https://api.github.com/users/mlegner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlegner/subscriptions","organizations_url":"https://api.github.com/users/mlegner/orgs","repos_url":"https://api.github.com/users/mlegner/repos","events_url":"https://api.github.com/users/mlegner/events{/privacy}","received_events_url":"https://api.github.com/users/mlegner/received_events","type":"User","site_admin":false},"created_at":"2017-09-06T06:16:48Z","updated_at":"2017-09-06T06:16:48Z","author_association":"COLLABORATOR","body":"The rate limiting is a really cool feature that worked well for me after some small issues with the govendor-installed packages (see below).\nAlso, I added a comment concerning the init function.\n\n---\n\nReview status: 0 of 7 files reviewed at latest revision, 2 unresolved discussions.\n\n---\n\n*[main.go, line 33 at r1](https://reviewable.io:443/reviews/netsec-ethz/scion-coord/51#-KtKlldCQrDGhAIcXAdL:-KtKlldCQrDGhAIcXAdM:brd41jc) ([raw file](https://github.com/netsec-ethz/scion-coord/blob/71c18e78c4a434e0deb0cf7e01f056f8a455a5b8/main.go#L33)):*\n> ```Go\n> )\n> \n> func init() {\n> ```\n\nThe problem with the init function is that it does not abort the program after an error. This was my original reason why to put these checks into the main function.\n\n---\n\n*[vendor/vendor.json, line 25 at r1](https://reviewable.io:443/reviews/netsec-ethz/scion-coord/51#-KtKkfHpO23H8rXhIZpZ:-KtKkfHrCauy28R4NpjL:b-1wp7sv) ([raw file](https://github.com/netsec-ethz/scion-coord/blob/71c18e78c4a434e0deb0cf7e01f056f8a455a5b8/vendor/vendor.json#L25)):*\n> ```JSON\n> \t\t{\n> \t\t\t\"checksumSHA1\": \"QlXKfAzQy+s0+dSHaSs/ASvu+Ik=\",\n> \t\t\t\"path\": \"github.com/didip/tollbooth/limiter\",\n> ```\n\nI had to install additional packages: \"github.com/didip/tollbooth\", \"github.com/patrickmn/go-cache\", \"golang.org/x/time/rate\". Maybe you had some of them installed globally?\nAlso, there is now a new version of tollbooth, where some function names are changed.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/netsec-ethz/scion-coord/51#-:-KtKp50HAMYufvmx7JMR:b-8wfbzy)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"mlegner"}}