{"action":"closed","number":158,"pull_request":{"url":"https://api.github.com/repos/kickstarter/ios-oss/pulls/158","id":120331288,"html_url":"https://github.com/kickstarter/ios-oss/pull/158","diff_url":"https://github.com/kickstarter/ios-oss/pull/158.diff","patch_url":"https://github.com/kickstarter/ios-oss/pull/158.patch","issue_url":"https://api.github.com/repos/kickstarter/ios-oss/issues/158","number":158,"state":"closed","locked":false,"title":"Make an allow list of deep linkable routes","user":{"login":"mbrandonw","id":135203,"avatar_url":"https://avatars2.githubusercontent.com/u/135203?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrandonw","html_url":"https://github.com/mbrandonw","followers_url":"https://api.github.com/users/mbrandonw/followers","following_url":"https://api.github.com/users/mbrandonw/following{/other_user}","gists_url":"https://api.github.com/users/mbrandonw/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrandonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrandonw/subscriptions","organizations_url":"https://api.github.com/users/mbrandonw/orgs","repos_url":"https://api.github.com/users/mbrandonw/repos","events_url":"https://api.github.com/users/mbrandonw/events{/privacy}","received_events_url":"https://api.github.com/users/mbrandonw/received_events","type":"User","site_admin":false},"body":"Right now our routing systems has a big ole list of URLs on Kickstarter that we want to recognize in a variety of situations, e.g. when inspecting requests in a web view, and when deep linking into the app.\r\n\r\nSometimes we want to use a different set of recognizable routes depending on the situation we are routing. In particular, when deep linking there is a smaller set of routes we want to recognize, and then anything we don't recognize can bump the user back to mobile safari.\r\n\r\nThat's what this PR does...\r\n\r\nThere are smarter ways to do this, and would love to try it out soon, but this will do the job and is well tested!","created_at":"2017-05-12T14:08:58Z","updated_at":"2017-05-18T13:49:23Z","closed_at":"2017-05-18T13:49:23Z","merged_at":"2017-05-18T13:49:23Z","merge_commit_sha":"141fa9c34fa585de21d2dc53e11d87b571c4ddc2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"stephencelis","id":658,"avatar_url":"https://avatars3.githubusercontent.com/u/658?v=3","gravatar_id":"","url":"https://api.github.com/users/stephencelis","html_url":"https://github.com/stephencelis","followers_url":"https://api.github.com/users/stephencelis/followers","following_url":"https://api.github.com/users/stephencelis/following{/other_user}","gists_url":"https://api.github.com/users/stephencelis/gists{/gist_id}","starred_url":"https://api.github.com/users/stephencelis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephencelis/subscriptions","organizations_url":"https://api.github.com/users/stephencelis/orgs","repos_url":"https://api.github.com/users/stephencelis/repos","events_url":"https://api.github.com/users/stephencelis/events{/privacy}","received_events_url":"https://api.github.com/users/stephencelis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kickstarter/ios-oss/pulls/158/commits","review_comments_url":"https://api.github.com/repos/kickstarter/ios-oss/pulls/158/comments","review_comment_url":"https://api.github.com/repos/kickstarter/ios-oss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kickstarter/ios-oss/issues/158/comments","statuses_url":"https://api.github.com/repos/kickstarter/ios-oss/statuses/39460cf3acbbef44976b50b8c96716b3c28d85a5","head":{"label":"kickstarter:skip-some-deep-links","ref":"skip-some-deep-links","sha":"39460cf3acbbef44976b50b8c96716b3c28d85a5","user":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars2.githubusercontent.com/u/120676?v=3","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"repo":{"id":75432091,"name":"ios-oss","full_name":"kickstarter/ios-oss","owner":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars2.githubusercontent.com/u/120676?v=3","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kickstarter/ios-oss","description":"Kickstarter for iOS. Bring new ideas to life, anywhere.","fork":false,"url":"https://api.github.com/repos/kickstarter/ios-oss","forks_url":"https://api.github.com/repos/kickstarter/ios-oss/forks","keys_url":"https://api.github.com/repos/kickstarter/ios-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kickstarter/ios-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kickstarter/ios-oss/teams","hooks_url":"https://api.github.com/repos/kickstarter/ios-oss/hooks","issue_events_url":"https://api.github.com/repos/kickstarter/ios-oss/issues/events{/number}","events_url":"https://api.github.com/repos/kickstarter/ios-oss/events","assignees_url":"https://api.github.com/repos/kickstarter/ios-oss/assignees{/user}","branches_url":"https://api.github.com/repos/kickstarter/ios-oss/branches{/branch}","tags_url":"https://api.github.com/repos/kickstarter/ios-oss/tags","blobs_url":"https://api.github.com/repos/kickstarter/ios-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kickstarter/ios-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kickstarter/ios-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/kickstarter/ios-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kickstarter/ios-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/kickstarter/ios-oss/languages","stargazers_url":"https://api.github.com/repos/kickstarter/ios-oss/stargazers","contributors_url":"https://api.github.com/repos/kickstarter/ios-oss/contributors","subscribers_url":"https://api.github.com/repos/kickstarter/ios-oss/subscribers","subscription_url":"https://api.github.com/repos/kickstarter/ios-oss/subscription","commits_url":"https://api.github.com/repos/kickstarter/ios-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/kickstarter/ios-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/kickstarter/ios-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/kickstarter/ios-oss/issues/comments{/number}","contents_url":"https://api.github.com/repos/kickstarter/ios-oss/contents/{+path}","compare_url":"https://api.github.com/repos/kickstarter/ios-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kickstarter/ios-oss/merges","archive_url":"https://api.github.com/repos/kickstarter/ios-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kickstarter/ios-oss/downloads","issues_url":"https://api.github.com/repos/kickstarter/ios-oss/issues{/number}","pulls_url":"https://api.github.com/repos/kickstarter/ios-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/kickstarter/ios-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/kickstarter/ios-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kickstarter/ios-oss/labels{/name}","releases_url":"https://api.github.com/repos/kickstarter/ios-oss/releases{/id}","deployments_url":"https://api.github.com/repos/kickstarter/ios-oss/deployments","created_at":"2016-12-02T21:24:40Z","updated_at":"2017-05-18T08:23:17Z","pushed_at":"2017-05-18T13:49:23Z","git_url":"git://github.com/kickstarter/ios-oss.git","ssh_url":"git@github.com:kickstarter/ios-oss.git","clone_url":"https://github.com/kickstarter/ios-oss.git","svn_url":"https://github.com/kickstarter/ios-oss","homepage":"https://www.kickstarter.com/mobile","size":426349,"stargazers_count":4666,"watchers_count":4666,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":609,"mirror_url":null,"open_issues_count":11,"forks":609,"open_issues":11,"watchers":4666,"default_branch":"master"}},"base":{"label":"kickstarter:master","ref":"master","sha":"3e112451a306c27319704e5a67d4edea7ed66014","user":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars2.githubusercontent.com/u/120676?v=3","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"repo":{"id":75432091,"name":"ios-oss","full_name":"kickstarter/ios-oss","owner":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars2.githubusercontent.com/u/120676?v=3","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kickstarter/ios-oss","description":"Kickstarter for iOS. Bring new ideas to life, anywhere.","fork":false,"url":"https://api.github.com/repos/kickstarter/ios-oss","forks_url":"https://api.github.com/repos/kickstarter/ios-oss/forks","keys_url":"https://api.github.com/repos/kickstarter/ios-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kickstarter/ios-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kickstarter/ios-oss/teams","hooks_url":"https://api.github.com/repos/kickstarter/ios-oss/hooks","issue_events_url":"https://api.github.com/repos/kickstarter/ios-oss/issues/events{/number}","events_url":"https://api.github.com/repos/kickstarter/ios-oss/events","assignees_url":"https://api.github.com/repos/kickstarter/ios-oss/assignees{/user}","branches_url":"https://api.github.com/repos/kickstarter/ios-oss/branches{/branch}","tags_url":"https://api.github.com/repos/kickstarter/ios-oss/tags","blobs_url":"https://api.github.com/repos/kickstarter/ios-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kickstarter/ios-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kickstarter/ios-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/kickstarter/ios-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kickstarter/ios-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/kickstarter/ios-oss/languages","stargazers_url":"https://api.github.com/repos/kickstarter/ios-oss/stargazers","contributors_url":"https://api.github.com/repos/kickstarter/ios-oss/contributors","subscribers_url":"https://api.github.com/repos/kickstarter/ios-oss/subscribers","subscription_url":"https://api.github.com/repos/kickstarter/ios-oss/subscription","commits_url":"https://api.github.com/repos/kickstarter/ios-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/kickstarter/ios-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/kickstarter/ios-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/kickstarter/ios-oss/issues/comments{/number}","contents_url":"https://api.github.com/repos/kickstarter/ios-oss/contents/{+path}","compare_url":"https://api.github.com/repos/kickstarter/ios-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kickstarter/ios-oss/merges","archive_url":"https://api.github.com/repos/kickstarter/ios-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kickstarter/ios-oss/downloads","issues_url":"https://api.github.com/repos/kickstarter/ios-oss/issues{/number}","pulls_url":"https://api.github.com/repos/kickstarter/ios-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/kickstarter/ios-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/kickstarter/ios-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kickstarter/ios-oss/labels{/name}","releases_url":"https://api.github.com/repos/kickstarter/ios-oss/releases{/id}","deployments_url":"https://api.github.com/repos/kickstarter/ios-oss/deployments","created_at":"2016-12-02T21:24:40Z","updated_at":"2017-05-18T08:23:17Z","pushed_at":"2017-05-18T13:49:23Z","git_url":"git://github.com/kickstarter/ios-oss.git","ssh_url":"git@github.com:kickstarter/ios-oss.git","clone_url":"https://github.com/kickstarter/ios-oss.git","svn_url":"https://github.com/kickstarter/ios-oss","homepage":"https://www.kickstarter.com/mobile","size":426349,"stargazers_count":4666,"watchers_count":4666,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":609,"mirror_url":null,"open_issues_count":11,"forks":609,"open_issues":11,"watchers":4666,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kickstarter/ios-oss/pulls/158"},"html":{"href":"https://github.com/kickstarter/ios-oss/pull/158"},"issue":{"href":"https://api.github.com/repos/kickstarter/ios-oss/issues/158"},"comments":{"href":"https://api.github.com/repos/kickstarter/ios-oss/issues/158/comments"},"review_comments":{"href":"https://api.github.com/repos/kickstarter/ios-oss/pulls/158/comments"},"review_comment":{"href":"https://api.github.com/repos/kickstarter/ios-oss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kickstarter/ios-oss/pulls/158/commits"},"statuses":{"href":"https://api.github.com/repos/kickstarter/ios-oss/statuses/39460cf3acbbef44976b50b8c96716b3c28d85a5"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mbrandonw","id":135203,"avatar_url":"https://avatars2.githubusercontent.com/u/135203?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrandonw","html_url":"https://github.com/mbrandonw","followers_url":"https://api.github.com/users/mbrandonw/followers","following_url":"https://api.github.com/users/mbrandonw/following{/other_user}","gists_url":"https://api.github.com/users/mbrandonw/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrandonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrandonw/subscriptions","organizations_url":"https://api.github.com/users/mbrandonw/orgs","repos_url":"https://api.github.com/users/mbrandonw/repos","events_url":"https://api.github.com/users/mbrandonw/events{/privacy}","received_events_url":"https://api.github.com/users/mbrandonw/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":5,"additions":52,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"mbrandonw"}}