{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/129940345","pull_request_review_id":52764834,"id":129940345,"diff_hunk":"@@ -18,6 +18,11 @@ package apiextensions\n \n import metav1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"\n \n+// TODO: This does not generate to protobuf because of the interface{} - fix protobuf\n+//   generation to support a meta type that can accept any valid JSON.\n+\n+// +protobuf=false","path":"staging/src/k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/types.go","position":7,"original_position":7,"commit_id":"b9c03c6334e7c396ad1450397de9256811d9a457","original_commit_id":"b9c03c6334e7c396ad1450397de9256811d9a457","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"these are the internal types. don't think we need this here. Only for the external ones.","created_at":"2017-07-27T19:43:19Z","updated_at":"2017-07-27T19:43:20Z","html_url":"https://github.com/kubernetes/kubernetes/pull/47263#discussion_r129940345","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47263","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/129940345"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/47263#discussion_r129940345"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47263"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47263","id":124933462,"html_url":"https://github.com/kubernetes/kubernetes/pull/47263","diff_url":"https://github.com/kubernetes/kubernetes/pull/47263.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/47263.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/47263","number":47263,"state":"open","locked":false,"title":"[WIP] apiextensions: validation for customresources","user":{"login":"nikhita","id":16105680,"avatar_url":"https://avatars1.githubusercontent.com/u/16105680?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhita","html_url":"https://github.com/nikhita","followers_url":"https://api.github.com/users/nikhita/followers","following_url":"https://api.github.com/users/nikhita/following{/other_user}","gists_url":"https://api.github.com/users/nikhita/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhita/subscriptions","organizations_url":"https://api.github.com/users/nikhita/orgs","repos_url":"https://api.github.com/users/nikhita/repos","events_url":"https://api.github.com/users/nikhita/events{/privacy}","received_events_url":"https://api.github.com/users/nikhita/received_events","type":"User","site_admin":false},"body":"- [x] Add types for validation of CustomResources\r\n- [x] Fix conversion-gen for recursive types (was going into an infinite recursion before).\r\n- [x] Fix defaulter-gen: kubernetes/gengo#61\r\n- [x] Convert to OpenAPI types\r\n- [x] Validate using go-openapi\r\n- [x] Add integration tests\r\n- [x] Fix deepcopy for round trip tests\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```\r\nNONE\r\n```\r\n\r\n/cc @sttts @deads2k ","created_at":"2017-06-09T19:19:27Z","updated_at":"2017-07-27T19:43:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"877c906f352fc2cf58928c0bbb320245e40d11e0","assignee":{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"assignees":[{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47263/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47263/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/47263/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b9c03c6334e7c396ad1450397de9256811d9a457","head":{"label":"nikhita:crd-01-validation-types","ref":"crd-01-validation-types","sha":"b9c03c6334e7c396ad1450397de9256811d9a457","user":{"login":"nikhita","id":16105680,"avatar_url":"https://avatars1.githubusercontent.com/u/16105680?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhita","html_url":"https://github.com/nikhita","followers_url":"https://api.github.com/users/nikhita/followers","following_url":"https://api.github.com/users/nikhita/following{/other_user}","gists_url":"https://api.github.com/users/nikhita/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhita/subscriptions","organizations_url":"https://api.github.com/users/nikhita/orgs","repos_url":"https://api.github.com/users/nikhita/repos","events_url":"https://api.github.com/users/nikhita/events{/privacy}","received_events_url":"https://api.github.com/users/nikhita/received_events","type":"User","site_admin":false},"repo":{"id":84678935,"name":"kubernetes","full_name":"nikhita/kubernetes","owner":{"login":"nikhita","id":16105680,"avatar_url":"https://avatars1.githubusercontent.com/u/16105680?v=4","gravatar_id":"","url":"https://api.github.com/users/nikhita","html_url":"https://github.com/nikhita","followers_url":"https://api.github.com/users/nikhita/followers","following_url":"https://api.github.com/users/nikhita/following{/other_user}","gists_url":"https://api.github.com/users/nikhita/gists{/gist_id}","starred_url":"https://api.github.com/users/nikhita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikhita/subscriptions","organizations_url":"https://api.github.com/users/nikhita/orgs","repos_url":"https://api.github.com/users/nikhita/repos","events_url":"https://api.github.com/users/nikhita/events{/privacy}","received_events_url":"https://api.github.com/users/nikhita/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikhita/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/nikhita/kubernetes","forks_url":"https://api.github.com/repos/nikhita/kubernetes/forks","keys_url":"https://api.github.com/repos/nikhita/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikhita/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikhita/kubernetes/teams","hooks_url":"https://api.github.com/repos/nikhita/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/nikhita/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/nikhita/kubernetes/events","assignees_url":"https://api.github.com/repos/nikhita/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/nikhita/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/nikhita/kubernetes/tags","blobs_url":"https://api.github.com/repos/nikhita/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikhita/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikhita/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikhita/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikhita/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/nikhita/kubernetes/languages","stargazers_url":"https://api.github.com/repos/nikhita/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/nikhita/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/nikhita/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/nikhita/kubernetes/subscription","commits_url":"https://api.github.com/repos/nikhita/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikhita/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikhita/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikhita/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikhita/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/nikhita/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikhita/kubernetes/merges","archive_url":"https://api.github.com/repos/nikhita/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikhita/kubernetes/downloads","issues_url":"https://api.github.com/repos/nikhita/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/nikhita/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/nikhita/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/nikhita/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikhita/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/nikhita/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/nikhita/kubernetes/deployments","created_at":"2017-03-11T20:49:10Z","updated_at":"2017-03-11T20:49:40Z","pushed_at":"2017-07-27T15:09:28Z","git_url":"git://github.com/nikhita/kubernetes.git","ssh_url":"git@github.com:nikhita/kubernetes.git","clone_url":"https://github.com/nikhita/kubernetes.git","svn_url":"https://github.com/nikhita/kubernetes","homepage":"http://kubernetes.io","size":450898,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3a0d8f8fea75140e4a38f5165a75e93bcd28c60c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-07-27T16:25:52Z","pushed_at":"2017-07-27T19:43:14Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":667910,"stargazers_count":25314,"watchers_count":25314,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9032,"mirror_url":null,"open_issues_count":5180,"forks":9032,"open_issues":5180,"watchers":25314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47263"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/47263"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/47263"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/47263/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47263/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47263/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b9c03c6334e7c396ad1450397de9256811d9a457"}}}}
{"actor":{"display_login":"sttts"}}