{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/98083013","pull_request_review_id":18714346,"id":98083013,"diff_hunk":"@@ -188,3 +181,124 @@ extern {\n \n     pub fn launchpad_vmo_from_file(filename: *const c_char) -> mx_handle_t;\n }\n+\n+// Errors\n+\n+#[allow(unused)] pub const ERR_INTERNAL: mx_status_t = -1;\n+\n+// ERR_NOT_SUPPORTED: The operation is not implemented, supported,","path":"src/libstd/sys/unix/process/magenta.rs","position":53,"original_position":53,"commit_id":"bbe419ff30a7a39289cb6f897522af5896afc1f9","original_commit_id":"bbe419ff30a7a39289cb6f897522af5896afc1f9","user":{"login":"solson","id":26806,"avatar_url":"https://avatars.githubusercontent.com/u/26806?v=3","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"body":"This and all the following comments that document these constants should use the triple slash `///` which rustdoc recognizes as a doc comment and uses in the generated HTML.","created_at":"2017-01-26T20:21:24Z","updated_at":"2017-01-26T20:23:41Z","html_url":"https://github.com/rust-lang/rust/pull/39277#discussion_r98083013","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/39277","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/98083013"},"html":{"href":"https://github.com/rust-lang/rust/pull/39277#discussion_r98083013"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/39277"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/39277","id":103005443,"html_url":"https://github.com/rust-lang/rust/pull/39277","diff_url":"https://github.com/rust-lang/rust/pull/39277.diff","patch_url":"https://github.com/rust-lang/rust/pull/39277.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/39277","number":39277,"state":"closed","locked":false,"title":"Update Fuchsia support for std::process. ","user":{"login":"tedsta","id":1218723,"avatar_url":"https://avatars.githubusercontent.com/u/1218723?v=3","gravatar_id":"","url":"https://api.github.com/users/tedsta","html_url":"https://github.com/tedsta","followers_url":"https://api.github.com/users/tedsta/followers","following_url":"https://api.github.com/users/tedsta/following{/other_user}","gists_url":"https://api.github.com/users/tedsta/gists{/gist_id}","starred_url":"https://api.github.com/users/tedsta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedsta/subscriptions","organizations_url":"https://api.github.com/users/tedsta/orgs","repos_url":"https://api.github.com/users/tedsta/repos","events_url":"https://api.github.com/users/tedsta/events{/privacy}","received_events_url":"https://api.github.com/users/tedsta/received_events","type":"User","site_admin":false},"body":"- Adds support for try_wait.\r\n- Miscellaneous updates to keep up with Magenta changes.\r\n\r\nI'll begin `sys/fuchsia` soon, just been bogged down with my actual job lately (I'm not on the Fuchsia team).","created_at":"2017-01-24T21:17:56Z","updated_at":"2017-01-26T20:23:41Z","closed_at":"2017-01-25T08:57:07Z","merged_at":"2017-01-25T08:57:07Z","merge_commit_sha":"bbe419ff30a7a39289cb6f897522af5896afc1f9","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/39277/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/39277/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/39277/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/bbe419ff30a7a39289cb6f897522af5896afc1f9","head":{"label":"tedsta:fuchsia_std_process","ref":"fuchsia_std_process","sha":"bbe419ff30a7a39289cb6f897522af5896afc1f9","user":{"login":"tedsta","id":1218723,"avatar_url":"https://avatars.githubusercontent.com/u/1218723?v=3","gravatar_id":"","url":"https://api.github.com/users/tedsta","html_url":"https://github.com/tedsta","followers_url":"https://api.github.com/users/tedsta/followers","following_url":"https://api.github.com/users/tedsta/following{/other_user}","gists_url":"https://api.github.com/users/tedsta/gists{/gist_id}","starred_url":"https://api.github.com/users/tedsta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedsta/subscriptions","organizations_url":"https://api.github.com/users/tedsta/orgs","repos_url":"https://api.github.com/users/tedsta/repos","events_url":"https://api.github.com/users/tedsta/events{/privacy}","received_events_url":"https://api.github.com/users/tedsta/received_events","type":"User","site_admin":false},"repo":{"id":73526248,"name":"rust","full_name":"tedsta/rust","owner":{"login":"tedsta","id":1218723,"avatar_url":"https://avatars.githubusercontent.com/u/1218723?v=3","gravatar_id":"","url":"https://api.github.com/users/tedsta","html_url":"https://github.com/tedsta","followers_url":"https://api.github.com/users/tedsta/followers","following_url":"https://api.github.com/users/tedsta/following{/other_user}","gists_url":"https://api.github.com/users/tedsta/gists{/gist_id}","starred_url":"https://api.github.com/users/tedsta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tedsta/subscriptions","organizations_url":"https://api.github.com/users/tedsta/orgs","repos_url":"https://api.github.com/users/tedsta/repos","events_url":"https://api.github.com/users/tedsta/events{/privacy}","received_events_url":"https://api.github.com/users/tedsta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tedsta/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/tedsta/rust","forks_url":"https://api.github.com/repos/tedsta/rust/forks","keys_url":"https://api.github.com/repos/tedsta/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tedsta/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tedsta/rust/teams","hooks_url":"https://api.github.com/repos/tedsta/rust/hooks","issue_events_url":"https://api.github.com/repos/tedsta/rust/issues/events{/number}","events_url":"https://api.github.com/repos/tedsta/rust/events","assignees_url":"https://api.github.com/repos/tedsta/rust/assignees{/user}","branches_url":"https://api.github.com/repos/tedsta/rust/branches{/branch}","tags_url":"https://api.github.com/repos/tedsta/rust/tags","blobs_url":"https://api.github.com/repos/tedsta/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tedsta/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tedsta/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/tedsta/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tedsta/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/tedsta/rust/languages","stargazers_url":"https://api.github.com/repos/tedsta/rust/stargazers","contributors_url":"https://api.github.com/repos/tedsta/rust/contributors","subscribers_url":"https://api.github.com/repos/tedsta/rust/subscribers","subscription_url":"https://api.github.com/repos/tedsta/rust/subscription","commits_url":"https://api.github.com/repos/tedsta/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/tedsta/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/tedsta/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/tedsta/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/tedsta/rust/contents/{+path}","compare_url":"https://api.github.com/repos/tedsta/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tedsta/rust/merges","archive_url":"https://api.github.com/repos/tedsta/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tedsta/rust/downloads","issues_url":"https://api.github.com/repos/tedsta/rust/issues{/number}","pulls_url":"https://api.github.com/repos/tedsta/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/tedsta/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/tedsta/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tedsta/rust/labels{/name}","releases_url":"https://api.github.com/repos/tedsta/rust/releases{/id}","deployments_url":"https://api.github.com/repos/tedsta/rust/deployments","created_at":"2016-11-12T02:18:41Z","updated_at":"2016-11-12T02:19:00Z","pushed_at":"2017-01-24T21:14:18Z","git_url":"git://github.com/tedsta/rust.git","ssh_url":"git@github.com:tedsta/rust.git","clone_url":"https://github.com/tedsta/rust.git","svn_url":"https://github.com/tedsta/rust","homepage":"https://www.rust-lang.org","size":323146,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"fe597dc9a9f325de9b2b11d69e190e1c22c4e7dc","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2017-01-26T20:18:11Z","pushed_at":"2017-01-26T20:11:00Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":324306,"stargazers_count":20126,"watchers_count":20126,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3818,"mirror_url":null,"open_issues_count":3048,"forks":3818,"open_issues":3048,"watchers":20126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/39277"},"html":{"href":"https://github.com/rust-lang/rust/pull/39277"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/39277"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/39277/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/39277/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/39277/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/bbe419ff30a7a39289cb6f897522af5896afc1f9"}}}}
{"actor":{"display_login":"solson"}}