{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls/comments/114701834","pull_request_review_id":36188975,"id":114701834,"diff_hunk":"@@ -641,11 +639,21 @@ sn_coap_hdr_s *sn_coap_protocol_parse(struct coap_s *handle, sn_nsdl_addr_s *src\n                 break;\n             }\n         }\n-\n+        /* Remove from the list if not an notification message.\n+         * Initial notification message is needed for sending rest of the blocks (GET request).\n+        */\n+        bool remove_from_the_list = false;\n         if (stored_blockwise_msg_temp_ptr) {","path":"source/sn_coap_protocol.c","position":25,"original_position":25,"commit_id":"71f891372dc17f99c76654c7c49ce7cf80482cfc","original_commit_id":"71f891372dc17f99c76654c7c49ce7cf80482cfc","user":{"login":"JaniSuonpera","id":24889889,"avatar_url":"https://avatars2.githubusercontent.com/u/24889889?v=3","gravatar_id":"","url":"https://api.github.com/users/JaniSuonpera","html_url":"https://github.com/JaniSuonpera","followers_url":"https://api.github.com/users/JaniSuonpera/followers","following_url":"https://api.github.com/users/JaniSuonpera/following{/other_user}","gists_url":"https://api.github.com/users/JaniSuonpera/gists{/gist_id}","starred_url":"https://api.github.com/users/JaniSuonpera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JaniSuonpera/subscriptions","organizations_url":"https://api.github.com/users/JaniSuonpera/orgs","repos_url":"https://api.github.com/users/JaniSuonpera/repos","events_url":"https://api.github.com/users/JaniSuonpera/events{/privacy}","received_events_url":"https://api.github.com/users/JaniSuonpera/received_events","type":"User","site_admin":false},"body":"This doable with one if\r\n`if (stored_blockwise_msg_temp_ptr  &&\r\nstored_blockwise_msg_temp_ptr->coap_msg_ptr && \r\n...\r\n`\r\n","created_at":"2017-05-04T05:27:20Z","updated_at":"2017-05-04T05:27:21Z","html_url":"https://github.com/ARMmbed/mbed-coap/pull/15#discussion_r114701834","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls/comments/114701834"},"html":{"href":"https://github.com/ARMmbed/mbed-coap/pull/15#discussion_r114701834"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls/15","id":118701736,"html_url":"https://github.com/ARMmbed/mbed-coap/pull/15","diff_url":"https://github.com/ARMmbed/mbed-coap/pull/15.diff","patch_url":"https://github.com/ARMmbed/mbed-coap/pull/15.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-coap/issues/15","number":15,"state":"open","locked":false,"title":"Fail to transmit whole resource value in notification message if it r…","user":{"login":"anttiylitokola","id":13655184,"avatar_url":"https://avatars0.githubusercontent.com/u/13655184?v=3","gravatar_id":"","url":"https://api.github.com/users/anttiylitokola","html_url":"https://github.com/anttiylitokola","followers_url":"https://api.github.com/users/anttiylitokola/followers","following_url":"https://api.github.com/users/anttiylitokola/following{/other_user}","gists_url":"https://api.github.com/users/anttiylitokola/gists{/gist_id}","starred_url":"https://api.github.com/users/anttiylitokola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anttiylitokola/subscriptions","organizations_url":"https://api.github.com/users/anttiylitokola/orgs","repos_url":"https://api.github.com/users/anttiylitokola/repos","events_url":"https://api.github.com/users/anttiylitokola/events{/privacy}","received_events_url":"https://api.github.com/users/anttiylitokola/received_events","type":"User","site_admin":false},"body":"…equires blockwise transfer\r\n\r\n - Fixes error reported in https://github.com/ARMmbed/mbed-client/issues/481","created_at":"2017-05-03T07:10:46Z","updated_at":"2017-05-04T05:27:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d29dcec533bd0c48ef302c6d50f940f9db7ea28c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls/15/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls/15/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-coap/issues/15/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-coap/statuses/71f891372dc17f99c76654c7c49ce7cf80482cfc","head":{"label":"ARMmbed:fix_obs_blockwise_transfer","ref":"fix_obs_blockwise_transfer","sha":"71f891372dc17f99c76654c7c49ce7cf80482cfc","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars0.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":81093702,"name":"mbed-coap","full_name":"ARMmbed/mbed-coap","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars0.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-coap","description":"CoAP C library - Builder and Parser for CoAP messages","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-coap","forks_url":"https://api.github.com/repos/ARMmbed/mbed-coap/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-coap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-coap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-coap/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-coap/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-coap/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-coap/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-coap/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-coap/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-coap/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-coap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-coap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-coap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-coap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-coap/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-coap/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-coap/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-coap/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-coap/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-coap/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-coap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-coap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-coap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-coap/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-coap/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-coap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-coap/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-coap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-coap/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-coap/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-coap/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-coap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-coap/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-coap/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-coap/deployments","created_at":"2017-02-06T14:09:42Z","updated_at":"2017-04-27T12:19:29Z","pushed_at":"2017-05-03T13:27:32Z","git_url":"git://github.com/ARMmbed/mbed-coap.git","ssh_url":"git@github.com:ARMmbed/mbed-coap.git","clone_url":"https://github.com/ARMmbed/mbed-coap.git","svn_url":"https://github.com/ARMmbed/mbed-coap","homepage":null,"size":4858,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"d9ef058ffece940f4bcc228d4d1beae0ba2c6719","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars0.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":81093702,"name":"mbed-coap","full_name":"ARMmbed/mbed-coap","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars0.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-coap","description":"CoAP C library - Builder and Parser for CoAP messages","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-coap","forks_url":"https://api.github.com/repos/ARMmbed/mbed-coap/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-coap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-coap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-coap/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-coap/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-coap/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-coap/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-coap/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-coap/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-coap/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-coap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-coap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-coap/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-coap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-coap/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-coap/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-coap/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-coap/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-coap/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-coap/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-coap/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-coap/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-coap/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-coap/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-coap/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-coap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-coap/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-coap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-coap/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-coap/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-coap/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-coap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-coap/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-coap/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-coap/deployments","created_at":"2017-02-06T14:09:42Z","updated_at":"2017-04-27T12:19:29Z","pushed_at":"2017-05-03T13:27:32Z","git_url":"git://github.com/ARMmbed/mbed-coap.git","ssh_url":"git@github.com:ARMmbed/mbed-coap.git","clone_url":"https://github.com/ARMmbed/mbed-coap.git","svn_url":"https://github.com/ARMmbed/mbed-coap","homepage":null,"size":4858,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls/15"},"html":{"href":"https://github.com/ARMmbed/mbed-coap/pull/15"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-coap/issues/15"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-coap/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-coap/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-coap/statuses/71f891372dc17f99c76654c7c49ce7cf80482cfc"}}}}
{"actor":{"display_login":"JaniSuonpera"}}