{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint/issues/8133","repository_url":"https://api.github.com/repos/eslint/eslint","labels_url":"https://api.github.com/repos/eslint/eslint/issues/8133/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/8133/comments","events_url":"https://api.github.com/repos/eslint/eslint/issues/8133/events","html_url":"https://github.com/eslint/eslint/pull/8133","id":209568021,"number":8133,"title":"Fix: ignore negative ranges in fixes (fixes #8116)","user":{"login":"alberto","id":72561,"avatar_url":"https://avatars.githubusercontent.com/u/72561?v=3","gravatar_id":"","url":"https://api.github.com/users/alberto","html_url":"https://github.com/alberto","followers_url":"https://api.github.com/users/alberto/followers","following_url":"https://api.github.com/users/alberto/following{/other_user}","gists_url":"https://api.github.com/users/alberto/gists{/gist_id}","starred_url":"https://api.github.com/users/alberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alberto/subscriptions","organizations_url":"https://api.github.com/users/alberto/orgs","repos_url":"https://api.github.com/users/alberto/repos","events_url":"https://api.github.com/users/alberto/events{/privacy}","received_events_url":"https://api.github.com/users/alberto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-02-22T20:16:09Z","updated_at":"2017-02-22T20:21:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/8133","html_url":"https://github.com/eslint/eslint/pull/8133","diff_url":"https://github.com/eslint/eslint/pull/8133.diff","patch_url":"https://github.com/eslint/eslint/pull/8133.patch"},"body":"**What is the purpose of this pull request? (put an \"X\" next to item)**\r\n\r\n[ ] Documentation update\r\n[X] Bug fix ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/bug-report.md))\r\n[ ] New rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-proposal.md))\r\n[ ] Changes an existing rule ([template](https://raw.githubusercontent.com/eslint/eslint/master/templates/rule-change-proposal.md))\r\n[ ] Add autofixing to a rule\r\n[ ] Add a CLI option\r\n[ ] Add something to the core\r\n[ ] Other, please explain:\r\n\r\n<!--\r\n    If the item you've checked above has a template, please paste the template questions below and answer them. (If this pull request is addressing an issue, you can just paste a link to the issue here instead.)\r\n-->\r\n\r\n<!--\r\n    Please ensure your pull request is ready:\r\n\r\n    - Read the pull request guide (http://eslint.org/docs/developer-guide/contributing/pull-requests)\r\n    - Include tests for this change\r\n    - Update documentation for this change (if appropriate)\r\n-->\r\n\r\n<!--\r\n    The following is required for all pull requests:\r\n-->\r\n\r\n**What changes did you make? (Give an overview)**\r\nIgnore fixes with negative ranges.\r\n\r\n**Is there anything you'd like reviewers to focus on?**\r\nI don't think https://github.com/eslint/eslint/pull/8117 is the sensible thing to do. I created a different PR to try to get this for the patch release. I'm sorry I couldn't review that sooner.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/eslint/eslint/issues/comments/281790965","html_url":"https://github.com/eslint/eslint/pull/8133#issuecomment-281790965","issue_url":"https://api.github.com/repos/eslint/eslint/issues/8133","id":281790965,"user":{"login":"alberto","id":72561,"avatar_url":"https://avatars.githubusercontent.com/u/72561?v=3","gravatar_id":"","url":"https://api.github.com/users/alberto","html_url":"https://github.com/alberto","followers_url":"https://api.github.com/users/alberto/followers","following_url":"https://api.github.com/users/alberto/following{/other_user}","gists_url":"https://api.github.com/users/alberto/gists{/gist_id}","starred_url":"https://api.github.com/users/alberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alberto/subscriptions","organizations_url":"https://api.github.com/users/alberto/orgs","repos_url":"https://api.github.com/users/alberto/repos","events_url":"https://api.github.com/users/alberto/events{/privacy}","received_events_url":"https://api.github.com/users/alberto/received_events","type":"User","site_admin":false},"created_at":"2017-02-22T20:21:53Z","updated_at":"2017-02-22T20:21:53Z","body":"@not-an-aardvark why do you think it would be a breaking change? rules doing negative ranges should be bugs imho. As I mentioned in your PR, it wasn't applying the correct fix with `padded-blocks`, it was still inserting the '\\n' at the wrong place."}}
{"actor":{"display_login":"alberto"}}