{"action":"created","comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/107706658","pull_request_review_id":28694419,"id":107706658,"diff_hunk":"@@ -0,0 +1,29 @@\n+#! /usr/bin/env expect -f\n+#\n+source [file join [file dirname $argv0] common.tcl]\n+\n+spawn /bin/bash\n+send \"PS1=':''/# '\\r\"\n+eexpect \":/# \"\n+\n+send \"$argv start --pid-file=server_pid --background\\r\"","path":"pkg/cli/interactive_tests/test_server_restart.tcl","position":9,"original_position":9,"commit_id":"9a768a45366c55d1a5baf612ed8cf44af1498f47","original_commit_id":"9a768a45366c55d1a5baf612ed8cf44af1498f47","user":{"login":"knz","id":642886,"avatar_url":"https://avatars0.githubusercontent.com/u/642886?v=3","gravatar_id":"","url":"https://api.github.com/users/knz","html_url":"https://github.com/knz","followers_url":"https://api.github.com/users/knz/followers","following_url":"https://api.github.com/users/knz/following{/other_user}","gists_url":"https://api.github.com/users/knz/gists{/gist_id}","starred_url":"https://api.github.com/users/knz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knz/subscriptions","organizations_url":"https://api.github.com/users/knz/orgs","repos_url":"https://api.github.com/users/knz/repos","events_url":"https://api.github.com/users/knz/events{/privacy}","received_events_url":"https://api.github.com/users/knz/received_events","type":"User","site_admin":false},"body":"`start_server $argv` does the same I believe and is shorter (no expect needed)","created_at":"2017-03-23T15:50:58Z","updated_at":"2017-03-23T15:52:36Z","html_url":"https://github.com/cockroachdb/cockroach/pull/14341#discussion_r107706658","pull_request_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/14341","_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments/107706658"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/14341#discussion_r107706658"},"pull_request":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/14341"}}},"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/14341","id":112269677,"html_url":"https://github.com/cockroachdb/cockroach/pull/14341","diff_url":"https://github.com/cockroachdb/cockroach/pull/14341.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/14341.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/14341","number":14341,"state":"open","locked":false,"title":"sql: delete leases synchronously when draining","user":{"login":"asubiotto","id":10560359,"avatar_url":"https://avatars1.githubusercontent.com/u/10560359?v=3","gravatar_id":"","url":"https://api.github.com/users/asubiotto","html_url":"https://github.com/asubiotto","followers_url":"https://api.github.com/users/asubiotto/followers","following_url":"https://api.github.com/users/asubiotto/following{/other_user}","gists_url":"https://api.github.com/users/asubiotto/gists{/gist_id}","starred_url":"https://api.github.com/users/asubiotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asubiotto/subscriptions","organizations_url":"https://api.github.com/users/asubiotto/orgs","repos_url":"https://api.github.com/users/asubiotto/repos","events_url":"https://api.github.com/users/asubiotto/events{/privacy}","received_events_url":"https://api.github.com/users/asubiotto/received_events","type":"User","site_admin":false},"body":"Fixes #14246\r\n\r\nReleasing leases asynchronously resulted in the node shutting down\r\nbefore the deletion could be serviced. Normal mode of operation remains\r\nunchanged.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/14341)\n<!-- Reviewable:end -->\n","created_at":"2017-03-23T15:42:45Z","updated_at":"2017-03-23T15:52:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0677548c2741d1cd7c5d9fc643a3515e152bd565","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/14341/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/14341/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/14341/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/9a768a45366c55d1a5baf612ed8cf44af1498f47","head":{"label":"asubiotto:fix-drop-hang","ref":"fix-drop-hang","sha":"9a768a45366c55d1a5baf612ed8cf44af1498f47","user":{"login":"asubiotto","id":10560359,"avatar_url":"https://avatars1.githubusercontent.com/u/10560359?v=3","gravatar_id":"","url":"https://api.github.com/users/asubiotto","html_url":"https://github.com/asubiotto","followers_url":"https://api.github.com/users/asubiotto/followers","following_url":"https://api.github.com/users/asubiotto/following{/other_user}","gists_url":"https://api.github.com/users/asubiotto/gists{/gist_id}","starred_url":"https://api.github.com/users/asubiotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asubiotto/subscriptions","organizations_url":"https://api.github.com/users/asubiotto/orgs","repos_url":"https://api.github.com/users/asubiotto/repos","events_url":"https://api.github.com/users/asubiotto/events{/privacy}","received_events_url":"https://api.github.com/users/asubiotto/received_events","type":"User","site_admin":false},"repo":{"id":53750588,"name":"cockroach","full_name":"asubiotto/cockroach","owner":{"login":"asubiotto","id":10560359,"avatar_url":"https://avatars1.githubusercontent.com/u/10560359?v=3","gravatar_id":"","url":"https://api.github.com/users/asubiotto","html_url":"https://github.com/asubiotto","followers_url":"https://api.github.com/users/asubiotto/followers","following_url":"https://api.github.com/users/asubiotto/following{/other_user}","gists_url":"https://api.github.com/users/asubiotto/gists{/gist_id}","starred_url":"https://api.github.com/users/asubiotto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asubiotto/subscriptions","organizations_url":"https://api.github.com/users/asubiotto/orgs","repos_url":"https://api.github.com/users/asubiotto/repos","events_url":"https://api.github.com/users/asubiotto/events{/privacy}","received_events_url":"https://api.github.com/users/asubiotto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asubiotto/cockroach","description":"A Scalable, Survivable, Strongly-Consistent SQL Database","fork":true,"url":"https://api.github.com/repos/asubiotto/cockroach","forks_url":"https://api.github.com/repos/asubiotto/cockroach/forks","keys_url":"https://api.github.com/repos/asubiotto/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asubiotto/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asubiotto/cockroach/teams","hooks_url":"https://api.github.com/repos/asubiotto/cockroach/hooks","issue_events_url":"https://api.github.com/repos/asubiotto/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/asubiotto/cockroach/events","assignees_url":"https://api.github.com/repos/asubiotto/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/asubiotto/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/asubiotto/cockroach/tags","blobs_url":"https://api.github.com/repos/asubiotto/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asubiotto/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asubiotto/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/asubiotto/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asubiotto/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/asubiotto/cockroach/languages","stargazers_url":"https://api.github.com/repos/asubiotto/cockroach/stargazers","contributors_url":"https://api.github.com/repos/asubiotto/cockroach/contributors","subscribers_url":"https://api.github.com/repos/asubiotto/cockroach/subscribers","subscription_url":"https://api.github.com/repos/asubiotto/cockroach/subscription","commits_url":"https://api.github.com/repos/asubiotto/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/asubiotto/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/asubiotto/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/asubiotto/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/asubiotto/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/asubiotto/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asubiotto/cockroach/merges","archive_url":"https://api.github.com/repos/asubiotto/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asubiotto/cockroach/downloads","issues_url":"https://api.github.com/repos/asubiotto/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/asubiotto/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/asubiotto/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/asubiotto/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asubiotto/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/asubiotto/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/asubiotto/cockroach/deployments","created_at":"2016-03-12T19:54:46Z","updated_at":"2016-03-12T19:54:49Z","pushed_at":"2017-03-23T15:40:24Z","git_url":"git://github.com/asubiotto/cockroach.git","ssh_url":"git@github.com:asubiotto/cockroach.git","clone_url":"https://github.com/asubiotto/cockroach.git","svn_url":"https://github.com/asubiotto/cockroach","homepage":"http://www.cockroachlabs.com","size":240940,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"3ae03f3edccf05d73dbd44d144546952ea178371","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars0.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars0.githubusercontent.com/u/6748139?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the scalable, survivable, strongly-consistent SQL database","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2017-03-23T10:27:32Z","pushed_at":"2017-03-23T15:43:01Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":453753,"stargazers_count":9047,"watchers_count":9047,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":899,"mirror_url":null,"open_issues_count":1041,"forks":899,"open_issues":1041,"watchers":9047,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/14341"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/14341"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/14341"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/14341/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/14341/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/14341/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/9a768a45366c55d1a5baf612ed8cf44af1498f47"}}}}
{"actor":{"display_login":"knz"}}