{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/102865567","pull_request_review_id":23635636,"id":102865567,"diff_hunk":"@@ -42,6 +42,7 @@ class PostActionsEllipsisMenuView extends Component {\n \n \t\tthis.props.setPreviewUrl( previewUrl );\n \t\tthis.props.setLayoutFocus( 'preview' );\n+\t\tthis.props.onClick();","path":"client/my-sites/post-type-list/post-actions-ellipsis-menu/view.jsx","position":4,"original_position":4,"commit_id":"617a7ca5acd91947bc4a9fdef4c26dcc76ede56b","original_commit_id":"8e5a1863a88dd3706061fcf8e6e887411a3b888b","user":{"login":"aduth","id":1779930,"avatar_url":"https://avatars.githubusercontent.com/u/1779930?v=3","gravatar_id":"","url":"https://api.github.com/users/aduth","html_url":"https://github.com/aduth","followers_url":"https://api.github.com/users/aduth/followers","following_url":"https://api.github.com/users/aduth/following{/other_user}","gists_url":"https://api.github.com/users/aduth/gists{/gist_id}","starred_url":"https://api.github.com/users/aduth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aduth/subscriptions","organizations_url":"https://api.github.com/users/aduth/orgs","repos_url":"https://api.github.com/users/aduth/repos","events_url":"https://api.github.com/users/aduth/events{/privacy}","received_events_url":"https://api.github.com/users/aduth/received_events","type":"User","site_admin":false},"body":">Because `PostActionsEllipsisMenuView` never does anything with the onClick prop it is being passed.\r\n\r\nOkay, took another look and this makes a little more sense; the `onClick` prop is passed to the `PopoverMenuItem` but I'm guessing it gets lost in the fact that the child of `PopoverMenu` is not the menu item directly, but rather `PostActionsEllipsisMenuView`.\r\n\r\n>Should I specify default props in `PostActionsEllipsisMenuView` then?\r\n\r\nYeah, that seems fine. Seems like it'll always be assigned anyways, but best to be safe.","created_at":"2017-02-24T02:05:07Z","updated_at":"2017-02-24T02:05:07Z","html_url":"https://github.com/Automattic/wp-calypso/pull/6894#discussion_r102865567","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6894","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/102865567"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/6894#discussion_r102865567"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6894"}}},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6894","id":78009372,"html_url":"https://github.com/Automattic/wp-calypso/pull/6894","diff_url":"https://github.com/Automattic/wp-calypso/pull/6894.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/6894.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6894","number":6894,"state":"open","locked":false,"title":"Posts: use CPT component to render drafts.","user":{"login":"mtias","id":548849,"avatar_url":"https://avatars.githubusercontent.com/u/548849?v=3","gravatar_id":"","url":"https://api.github.com/users/mtias","html_url":"https://github.com/mtias","followers_url":"https://api.github.com/users/mtias/followers","following_url":"https://api.github.com/users/mtias/following{/other_user}","gists_url":"https://api.github.com/users/mtias/gists{/gist_id}","starred_url":"https://api.github.com/users/mtias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtias/subscriptions","organizations_url":"https://api.github.com/users/mtias/orgs","repos_url":"https://api.github.com/users/mtias/repos","events_url":"https://api.github.com/users/mtias/events{/privacy}","received_events_url":"https://api.github.com/users/mtias/received_events","type":"User","site_admin":false},"body":"- Add \"mini\" prop to display an even more condensed post-item.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/548849/16958199/db29c55c-4ddf-11e6-94be-348f244ecc04.png)\r\n\r\ncc @aduth I think we should move the post.jsx component to its own folder (post-type-item).\r\n\r\nTest live: https://calypso.live/posts?branch=update/use-new-cpt-post-component-for-drafts\r\n","created_at":"2016-07-19T16:38:16Z","updated_at":"2017-02-24T02:05:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f243ab34d719065f43f556005776c3467439f491","assignee":{"login":"obenland","id":1398304,"avatar_url":"https://avatars.githubusercontent.com/u/1398304?v=3","gravatar_id":"","url":"https://api.github.com/users/obenland","html_url":"https://github.com/obenland","followers_url":"https://api.github.com/users/obenland/followers","following_url":"https://api.github.com/users/obenland/following{/other_user}","gists_url":"https://api.github.com/users/obenland/gists{/gist_id}","starred_url":"https://api.github.com/users/obenland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obenland/subscriptions","organizations_url":"https://api.github.com/users/obenland/orgs","repos_url":"https://api.github.com/users/obenland/repos","events_url":"https://api.github.com/users/obenland/events{/privacy}","received_events_url":"https://api.github.com/users/obenland/received_events","type":"User","site_admin":false},"assignees":[{"login":"obenland","id":1398304,"avatar_url":"https://avatars.githubusercontent.com/u/1398304?v=3","gravatar_id":"","url":"https://api.github.com/users/obenland","html_url":"https://github.com/obenland","followers_url":"https://api.github.com/users/obenland/followers","following_url":"https://api.github.com/users/obenland/following{/other_user}","gists_url":"https://api.github.com/users/obenland/gists{/gist_id}","starred_url":"https://api.github.com/users/obenland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obenland/subscriptions","organizations_url":"https://api.github.com/users/obenland/orgs","repos_url":"https://api.github.com/users/obenland/repos","events_url":"https://api.github.com/users/obenland/events{/privacy}","received_events_url":"https://api.github.com/users/obenland/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6894/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6894/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/6894/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/617a7ca5acd91947bc4a9fdef4c26dcc76ede56b","head":{"label":"Automattic:update/use-new-cpt-post-component-for-drafts","ref":"update/use-new-cpt-post-component-for-drafts","sha":"617a7ca5acd91947bc4a9fdef4c26dcc76ede56b","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-02-24T01:28:58Z","pushed_at":"2017-02-24T01:59:10Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":45579,"stargazers_count":8486,"watchers_count":8486,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1083,"mirror_url":null,"open_issues_count":1678,"forks":1083,"open_issues":1678,"watchers":8486,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"51a61bec2414dae90953e05fd7b8a92bf90b0baa","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars.githubusercontent.com/u/887802?v=3","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-02-24T01:28:58Z","pushed_at":"2017-02-24T01:59:10Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":45579,"stargazers_count":8486,"watchers_count":8486,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1083,"mirror_url":null,"open_issues_count":1678,"forks":1083,"open_issues":1678,"watchers":8486,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6894"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/6894"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/6894"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/6894/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6894/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/6894/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/617a7ca5acd91947bc4a9fdef4c26dcc76ede56b"}}}}
{"actor":{"display_login":"aduth"}}