{"action":"created","issue":{"url":"https://api.github.com/repos/FrancescoCioria/smooth-release/issues/57","repository_url":"https://api.github.com/repos/FrancescoCioria/smooth-release","labels_url":"https://api.github.com/repos/FrancescoCioria/smooth-release/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/FrancescoCioria/smooth-release/issues/57/comments","events_url":"https://api.github.com/repos/FrancescoCioria/smooth-release/issues/57/events","html_url":"https://github.com/FrancescoCioria/smooth-release/pull/57","id":198523141,"number":57,"title":"#53: Changelog is committed after the tag (closes #53)","user":{"login":"FrancescoCioria","id":4029499,"avatar_url":"https://avatars.githubusercontent.com/u/4029499?v=3","gravatar_id":"","url":"https://api.github.com/users/FrancescoCioria","html_url":"https://github.com/FrancescoCioria","followers_url":"https://api.github.com/users/FrancescoCioria/followers","following_url":"https://api.github.com/users/FrancescoCioria/following{/other_user}","gists_url":"https://api.github.com/users/FrancescoCioria/gists{/gist_id}","starred_url":"https://api.github.com/users/FrancescoCioria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrancescoCioria/subscriptions","organizations_url":"https://api.github.com/users/FrancescoCioria/orgs","repos_url":"https://api.github.com/users/FrancescoCioria/repos","events_url":"https://api.github.com/users/FrancescoCioria/events{/privacy}","received_events_url":"https://api.github.com/users/FrancescoCioria/received_events","type":"User","site_admin":false},"labels":[{"id":480179404,"url":"https://api.github.com/repos/FrancescoCioria/smooth-release/labels/in%20review","name":"in review","color":"333333","default":false}],"state":"closed","locked":false,"assignee":{"login":"dhinus","id":474311,"avatar_url":"https://avatars.githubusercontent.com/u/474311?v=3","gravatar_id":"","url":"https://api.github.com/users/dhinus","html_url":"https://github.com/dhinus","followers_url":"https://api.github.com/users/dhinus/followers","following_url":"https://api.github.com/users/dhinus/following{/other_user}","gists_url":"https://api.github.com/users/dhinus/gists{/gist_id}","starred_url":"https://api.github.com/users/dhinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhinus/subscriptions","organizations_url":"https://api.github.com/users/dhinus/orgs","repos_url":"https://api.github.com/users/dhinus/repos","events_url":"https://api.github.com/users/dhinus/events{/privacy}","received_events_url":"https://api.github.com/users/dhinus/received_events","type":"User","site_admin":false},"assignees":[{"login":"dhinus","id":474311,"avatar_url":"https://avatars.githubusercontent.com/u/474311?v=3","gravatar_id":"","url":"https://api.github.com/users/dhinus","html_url":"https://github.com/dhinus","followers_url":"https://api.github.com/users/dhinus/followers","following_url":"https://api.github.com/users/dhinus/following{/other_user}","gists_url":"https://api.github.com/users/dhinus/gists{/gist_id}","starred_url":"https://api.github.com/users/dhinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhinus/subscriptions","organizations_url":"https://api.github.com/users/dhinus/orgs","repos_url":"https://api.github.com/users/dhinus/repos","events_url":"https://api.github.com/users/dhinus/events{/privacy}","received_events_url":"https://api.github.com/users/dhinus/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-01-03T17:17:47Z","updated_at":"2017-02-01T17:12:03Z","closed_at":"2017-01-26T17:14:26Z","pull_request":{"url":"https://api.github.com/repos/FrancescoCioria/smooth-release/pulls/57","html_url":"https://github.com/FrancescoCioria/smooth-release/pull/57","diff_url":"https://github.com/FrancescoCioria/smooth-release/pull/57.diff","patch_url":"https://github.com/FrancescoCioria/smooth-release/pull/57.patch"},"body":"Issue #53\r\n\r\n## Test Plan\r\n\r\n### tests performed\r\n- `./smooth-release --changelog`\r\n  - correctly throws an error: \"Error: CHANGELOG.md hasn't changed\"\r\n- mock `commitAndPush` (prefix every command with `echo`)\r\n- run it with `{ hasIncreasedVersion: false, hasUpdatedChangelog: true }`\r\n  - commit message is \"Update CHANGELOG.md\"\r\n- run it with `{ hasIncreasedVersion: true, hasUpdatedChangelog: true }`\r\n  - commit message is \"6.0.0\"  (current version taken from `package.json`) ✅ \r\n- run it with `{ hasIncreasedVersion: true, hasUpdatedChangelog: false }`\r\n  - commit message is \"6.0.0\"  (current version taken from `package.json`) ✅ \r\n- mock only push steps, ensure \"version\" and \"changelog\" don't throw any error\r\n- run `./smooth-release --no-npm-publish --no-gh-release --no-validations`\r\n  - new commit \"7.0.0\" with updated package.json and CHANGELOG.md\r\n  - new tag \"v7.0.0\"\r\n\r\n### tests not performed (domain coverage)\r\nI didn't run a complete `./smooth-release`"},"comment":{"url":"https://api.github.com/repos/FrancescoCioria/smooth-release/issues/comments/276718222","html_url":"https://github.com/FrancescoCioria/smooth-release/pull/57#issuecomment-276718222","issue_url":"https://api.github.com/repos/FrancescoCioria/smooth-release/issues/57","id":276718222,"user":{"login":"dhinus","id":474311,"avatar_url":"https://avatars.githubusercontent.com/u/474311?v=3","gravatar_id":"","url":"https://api.github.com/users/dhinus","html_url":"https://github.com/dhinus","followers_url":"https://api.github.com/users/dhinus/followers","following_url":"https://api.github.com/users/dhinus/following{/other_user}","gists_url":"https://api.github.com/users/dhinus/gists{/gist_id}","starred_url":"https://api.github.com/users/dhinus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhinus/subscriptions","organizations_url":"https://api.github.com/users/dhinus/orgs","repos_url":"https://api.github.com/users/dhinus/repos","events_url":"https://api.github.com/users/dhinus/events{/privacy}","received_events_url":"https://api.github.com/users/dhinus/received_events","type":"User","site_admin":false},"created_at":"2017-02-01T17:12:03Z","updated_at":"2017-02-01T17:12:03Z","body":"@FrancescoCioria I had this problem again, and I _think_ it's related to the fact I was using `smooth-release minor` because it worked fine using `smooth-release 0.2.0`. I opened #68."}}
{"actor":{"display_login":"dhinus"}}