{"action":"created","issue":{"url":"https://api.github.com/repos/philsquared/Catch/issues/1025","repository_url":"https://api.github.com/repos/philsquared/Catch","labels_url":"https://api.github.com/repos/philsquared/Catch/issues/1025/labels{/name}","comments_url":"https://api.github.com/repos/philsquared/Catch/issues/1025/comments","events_url":"https://api.github.com/repos/philsquared/Catch/issues/1025/events","html_url":"https://github.com/philsquared/Catch/issues/1025","id":258514888,"number":1025,"title":"JUnit reporter skips writing results of some tests","user":{"login":"PeterSchuebel","id":6595442,"avatar_url":"https://avatars2.githubusercontent.com/u/6595442?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterSchuebel","html_url":"https://github.com/PeterSchuebel","followers_url":"https://api.github.com/users/PeterSchuebel/followers","following_url":"https://api.github.com/users/PeterSchuebel/following{/other_user}","gists_url":"https://api.github.com/users/PeterSchuebel/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterSchuebel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterSchuebel/subscriptions","organizations_url":"https://api.github.com/users/PeterSchuebel/orgs","repos_url":"https://api.github.com/users/PeterSchuebel/repos","events_url":"https://api.github.com/users/PeterSchuebel/events{/privacy}","received_events_url":"https://api.github.com/users/PeterSchuebel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-09-18T15:08:58Z","updated_at":"2017-09-19T13:35:46Z","closed_at":null,"author_association":"NONE","body":"## Description\r\nSince upgrading from v1.9.4 to v1.10.0 we noticed that the JUnit reporter produces much smaller XML files.\r\nA closer investigation showed that all the tests are still run (total runtime was roughly the same and number of tests was identical), but much fewer tests get reported in the output file. So we think it's an issue in the JUnit reporter, rather than in Catch itself.\r\nApart from upgrading Catch last Tuesday, nothing else had changed in our Test code or build system, so we think it is a recently introduced issue in Catch.\r\n\r\n### Steps to reproduce\r\nFurther investigation showed:\r\n* this affects TESTs that use SECTIONs and those that don't (shown as 'global' in output), so it's not related to previous bugs with the JUnit reporter\r\n* TESTs that don't get reported only used REQUIRE and CHECK macros.\r\n* adding the usage of a CHECK_THROWS(<expression>) macro to a TEST that was not reported caused it to get reported.\r\n\r\nA workaround I found is to add the '--success' parameter to the command line.  Then all tests get reported. We use this now in our CI server, but for every day command line usage it would be nice to have this looked at and fixed.\r\n\r\n### Extra information\r\n\r\nWe use the following code to include Catch:\r\n\r\n#define CATCH_CONFIG_CPP11_NULLPTR\r\n#define CATCH_CONFIG_CPP11_IS_ENUM\r\n#define CATCH_CONFIG_CPP11_TUPLE\r\n#define CATCH_CONFIG_CPP11_LONG_LONG\r\n#define CATCH_CONFIG_CPP11_OVERRIDE\r\n#define CATCH_CONFIG_CPP11_UNIQUE_PTR\r\n#define CATCH_CONFIG_CPP11_TYPE_TRAITS\r\n#define CATCH_CONFIG_CPP11_OR_GREATER\r\n#define CATCH_CONFIG_VARIADIC_MACROS\r\n#define CATCH_CONFIG_WINDOWS_SEH\r\n#define CATCH_CONFIG_COUNTER\r\n\r\n#define CLARA_CONFIG_CPP11_NULLPTR\r\n#define CLARA_CONFIG_CPP11_OVERRIDE\r\n#define CLARA_CONFIG_CPP11_UNIQUE_PTR\r\n#define CLARA_CONFIG_CPP11_OR_GREATER\r\n\r\n#pragma warning (push)\r\n#pragma warning (disable:4702) // unreachable code when trowing exceptions inside Catch macros, e.g. REQUIRE_THROWS_AS\r\n#include \"catch.hpp\"\r\n#pragma warning (pop)\r\n\r\n* Catch version: **v1.10.0**\r\n* Operating System: **Windows 10**\r\n* Compiler+version: **MSVC 2013 Update 4**\r\n"},"comment":{"url":"https://api.github.com/repos/philsquared/Catch/issues/comments/330540975","html_url":"https://github.com/philsquared/Catch/issues/1025#issuecomment-330540975","issue_url":"https://api.github.com/repos/philsquared/Catch/issues/1025","id":330540975,"user":{"login":"philsquared","id":92878,"avatar_url":"https://avatars2.githubusercontent.com/u/92878?v=4","gravatar_id":"","url":"https://api.github.com/users/philsquared","html_url":"https://github.com/philsquared","followers_url":"https://api.github.com/users/philsquared/followers","following_url":"https://api.github.com/users/philsquared/following{/other_user}","gists_url":"https://api.github.com/users/philsquared/gists{/gist_id}","starred_url":"https://api.github.com/users/philsquared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philsquared/subscriptions","organizations_url":"https://api.github.com/users/philsquared/orgs","repos_url":"https://api.github.com/users/philsquared/repos","events_url":"https://api.github.com/users/philsquared/events{/privacy}","received_events_url":"https://api.github.com/users/philsquared/received_events","type":"User","site_admin":false},"created_at":"2017-09-19T13:35:46Z","updated_at":"2017-09-19T13:35:46Z","author_association":"OWNER","body":"Thanks. I'll re-close.\r\nI forget what now, but I have a feeling VS2013 may not be enough (although it's possible whatever the issue was got fixed in a later update - not rechecked for a while)."}}
{"actor":{"display_login":"philsquared"}}