{"action":"created","issue":{"url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/issues/201","repository_url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell","labels_url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/issues/201/labels{/name}","comments_url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/issues/201/comments","events_url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/issues/201/events","html_url":"https://github.com/IfcOpenShell/IfcOpenShell/pull/201","id":218929359,"number":201,"title":"Fixes (?) to add_debug_variants","user":{"login":"aothms","id":1096535,"avatar_url":"https://avatars1.githubusercontent.com/u/1096535?v=3","gravatar_id":"","url":"https://api.github.com/users/aothms","html_url":"https://github.com/aothms","followers_url":"https://api.github.com/users/aothms/followers","following_url":"https://api.github.com/users/aothms/following{/other_user}","gists_url":"https://api.github.com/users/aothms/gists{/gist_id}","starred_url":"https://api.github.com/users/aothms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aothms/subscriptions","organizations_url":"https://api.github.com/users/aothms/orgs","repos_url":"https://api.github.com/users/aothms/repos","events_url":"https://api.github.com/users/aothms/events{/privacy}","received_events_url":"https://api.github.com/users/aothms/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-04-03T13:15:19Z","updated_at":"2017-05-11T14:15:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/pulls/201","html_url":"https://github.com/IfcOpenShell/IfcOpenShell/pull/201","diff_url":"https://github.com/IfcOpenShell/IfcOpenShell/pull/201.diff","patch_url":"https://github.com/IfcOpenShell/IfcOpenShell/pull/201.patch"},"body":"@Stinkfist0 I ran into this problem, that if CMake runs against debug libraries of OCCT, that already have a `_d` postfix, it would try to link to `TKerneldd.lib`, i.e. double d.\r\n\r\nPerhaps in this particular case, no release libs where available in the dir, so `FIND_LIBRARY(libTKernel NAMES TKernel TKerneld` can only return the `TKerneld.lib`.\r\n\r\nThen in [1] (which I believe was added by me after your `add_debug_variants()`) this `_d` is not accounted for.\r\n\r\nSomehow I ended making more changes than I anticipated, because I kept ending up with a structure like: `TKernel.lib GENERAL TKernel.lib DEBUG TKernel.lib`. So overcautiously I made sure `add_debug_variants()` does not append to a pre-existing list.\r\n\r\nDoes this look somewhat reasonable to you?\r\n\r\n[1]\r\n~~~\r\n# Use the found libTKernel as a template for all other OCC libraries\r\nforeach(lib ${OPENCASCADE_LIBRARY_NAMES})\r\n    string(REPLACE TKernel \"${lib}\" lib_path \"${libTKernel}\")\r\n    list(APPEND OPENCASCADE_LIBRARIES_RELEASE \"${lib_path}\")\r\nendforeach()\r\n~~~\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/issues/comments/300802683","html_url":"https://github.com/IfcOpenShell/IfcOpenShell/pull/201#issuecomment-300802683","issue_url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/issues/201","id":300802683,"user":{"login":"Stinkfist0","id":227876,"avatar_url":"https://avatars1.githubusercontent.com/u/227876?v=3","gravatar_id":"","url":"https://api.github.com/users/Stinkfist0","html_url":"https://github.com/Stinkfist0","followers_url":"https://api.github.com/users/Stinkfist0/followers","following_url":"https://api.github.com/users/Stinkfist0/following{/other_user}","gists_url":"https://api.github.com/users/Stinkfist0/gists{/gist_id}","starred_url":"https://api.github.com/users/Stinkfist0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stinkfist0/subscriptions","organizations_url":"https://api.github.com/users/Stinkfist0/orgs","repos_url":"https://api.github.com/users/Stinkfist0/repos","events_url":"https://api.github.com/users/Stinkfist0/events{/privacy}","received_events_url":"https://api.github.com/users/Stinkfist0/received_events","type":"User","site_admin":false},"created_at":"2017-05-11T14:15:26Z","updated_at":"2017-05-11T14:15:26Z","body":"OK, finally have the time to properly look into this. Should be done by tonight."}}
{"actor":{"display_login":"Stinkfist0"}}