{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/repo-plugins/issues/857","repository_url":"https://api.github.com/repos/xbmc/repo-plugins","labels_url":"https://api.github.com/repos/xbmc/repo-plugins/issues/857/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/repo-plugins/issues/857/comments","events_url":"https://api.github.com/repos/xbmc/repo-plugins/issues/857/events","html_url":"https://github.com/xbmc/repo-plugins/pull/857","id":200247170,"number":857,"title":"[plugin.video.ted-talks] 4.2.10","user":{"login":"moreginger","id":1387874,"avatar_url":"https://avatars.githubusercontent.com/u/1387874?v=3","gravatar_id":"","url":"https://api.github.com/users/moreginger","html_url":"https://github.com/moreginger","followers_url":"https://api.github.com/users/moreginger/followers","following_url":"https://api.github.com/users/moreginger/following{/other_user}","gists_url":"https://api.github.com/users/moreginger/gists{/gist_id}","starred_url":"https://api.github.com/users/moreginger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moreginger/subscriptions","organizations_url":"https://api.github.com/users/moreginger/orgs","repos_url":"https://api.github.com/users/moreginger/repos","events_url":"https://api.github.com/users/moreginger/events{/privacy}","received_events_url":"https://api.github.com/users/moreginger/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-01-12T00:28:03Z","updated_at":"2017-01-13T20:45:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/repo-plugins/pulls/857","html_url":"https://github.com/xbmc/repo-plugins/pull/857","diff_url":"https://github.com/xbmc/repo-plugins/pull/857.diff","patch_url":"https://github.com/xbmc/repo-plugins/pull/857.patch"},"body":"### Description\r\nAncient plugin for TED talks, initial import and minor tweaks\r\n.\r\n### Checklist:\r\n- [X] My code follows the [add-on rules](http://kodi.wiki/view/Add-on_rules) and [piracy stance](http://kodi.wiki/view/Official:Forum_rules#Piracy_Policy) of this project.\r\n\r\nThere is no fanart yet. I'll give it some thought.\r\n\r\n- [X] I have read the [CONTRIBUTING](https://github.com/xbmc/repo-plugins/blob/master/CONTRIBUTING.md) document\r\n- [X] Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0\r\n\r\nAdditional information :\r\n- Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.\r\n- [add-on development](http://kodi.wiki/view/Add-on_development) wiki page.\r\n- Kodi [pydocs](http://kodi.wiki/view/PyDocs) provide information about the Python API\r\n- [PEP8](https://www.python.org/dev/peps/pep-0008/) codingstyle which is considered best practice but not mandatory.\r\n- This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at [Codacy](https://www.codacy.com/app/Kodi/repo-plugins/dashboard). You can create your own account as well to continuously monitor your python coding before submitting to repo.\r\n- Development questions can be asked in the [add-on development](http://forum.kodi.tv/forumdisplay.php?fid=26) section on the Kodi forum.\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/repo-plugins/issues/comments/272543556","html_url":"https://github.com/xbmc/repo-plugins/pull/857#issuecomment-272543556","issue_url":"https://api.github.com/repos/xbmc/repo-plugins/issues/857","id":272543556,"user":{"login":"moreginger","id":1387874,"avatar_url":"https://avatars.githubusercontent.com/u/1387874?v=3","gravatar_id":"","url":"https://api.github.com/users/moreginger","html_url":"https://github.com/moreginger","followers_url":"https://api.github.com/users/moreginger/followers","following_url":"https://api.github.com/users/moreginger/following{/other_user}","gists_url":"https://api.github.com/users/moreginger/gists{/gist_id}","starred_url":"https://api.github.com/users/moreginger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moreginger/subscriptions","organizations_url":"https://api.github.com/users/moreginger/orgs","repos_url":"https://api.github.com/users/moreginger/repos","events_url":"https://api.github.com/users/moreginger/events{/privacy}","received_events_url":"https://api.github.com/users/moreginger/received_events","type":"User","site_admin":false},"created_at":"2017-01-13T20:45:42Z","updated_at":"2017-01-13T20:45:42Z","body":"Thanks @MartijnKaijser. I must say that strings.po / Transifex is quite baffling:\r\n* Every addon I've looked at in the master repo has language/English/strings.po. I assume this is historical?\r\n* The syntax of the file seems totally mad and this merits explanation e.g. [here](http://kodi.wiki/view/language_support#Layout_of_the_strings.po_file). `msg*id*` = the text, `msgctxt` (message comment text?) = the id, `msgtxt` = empty string. What on earth happened?\r\n** Ooookay. Now that I can log into Transifex I think what's going on is that `msgtxt` is the intended text, and `msgid` is used as a fallback I think. Possibly `msgid` has an id purpose within Transifex or XBMC additionally. Whereas we're definitely (ab)using `msgctxt` as the id for `getLocalizedString`. Yuck. Can we update the language_support page to explain this a bit?"}}
{"actor":{"display_login":"moreginger"}}