{"action":"created","comment":{"url":"https://api.github.com/repos/NetSys/bess/pulls/comments/108489107","pull_request_review_id":29523432,"id":108489107,"diff_hunk":"@@ -235,6 +235,16 @@ pb_error_t PMDPort::Init(const bess::pb::PMDPortArg &arg) {\n   }\n   rte_eth_promiscuous_enable(ret_port_id);\n \n+  for (i = 0; i < num_txq; i++) {","path":"core/drivers/pmd.cc","position":4,"original_position":4,"commit_id":"ba36e8cf6511d534b6cb616438bd343a0e37a0d7","original_commit_id":"ba36e8cf6511d534b6cb616438bd343a0e37a0d7","user":{"login":"sangjinhan","id":1916976,"avatar_url":"https://avatars1.githubusercontent.com/u/1916976?v=3","gravatar_id":"","url":"https://api.github.com/users/sangjinhan","html_url":"https://github.com/sangjinhan","followers_url":"https://api.github.com/users/sangjinhan/followers","following_url":"https://api.github.com/users/sangjinhan/following{/other_user}","gists_url":"https://api.github.com/users/sangjinhan/gists{/gist_id}","starred_url":"https://api.github.com/users/sangjinhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sangjinhan/subscriptions","organizations_url":"https://api.github.com/users/sangjinhan/orgs","repos_url":"https://api.github.com/users/sangjinhan/repos","events_url":"https://api.github.com/users/sangjinhan/events{/privacy}","received_events_url":"https://api.github.com/users/sangjinhan/received_events","type":"User","site_admin":false},"body":"Sure thing!","created_at":"2017-03-28T17:47:47Z","updated_at":"2017-03-28T17:47:47Z","html_url":"https://github.com/NetSys/bess/pull/356#discussion_r108489107","pull_request_url":"https://api.github.com/repos/NetSys/bess/pulls/356","_links":{"self":{"href":"https://api.github.com/repos/NetSys/bess/pulls/comments/108489107"},"html":{"href":"https://github.com/NetSys/bess/pull/356#discussion_r108489107"},"pull_request":{"href":"https://api.github.com/repos/NetSys/bess/pulls/356"}}},"pull_request":{"url":"https://api.github.com/repos/NetSys/bess/pulls/356","id":112895724,"html_url":"https://github.com/NetSys/bess/pull/356","diff_url":"https://github.com/NetSys/bess/pull/356.diff","patch_url":"https://github.com/NetSys/bess/pull/356.patch","issue_url":"https://api.github.com/repos/NetSys/bess/issues/356","number":356,"state":"open","locked":false,"title":"Call rte_eth_tx_queue_setup first","user":{"login":"sangjinhan","id":1916976,"avatar_url":"https://avatars1.githubusercontent.com/u/1916976?v=3","gravatar_id":"","url":"https://api.github.com/users/sangjinhan","html_url":"https://github.com/sangjinhan","followers_url":"https://api.github.com/users/sangjinhan/followers","following_url":"https://api.github.com/users/sangjinhan/following{/other_user}","gists_url":"https://api.github.com/users/sangjinhan/gists{/gist_id}","starred_url":"https://api.github.com/users/sangjinhan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sangjinhan/subscriptions","organizations_url":"https://api.github.com/users/sangjinhan/orgs","repos_url":"https://api.github.com/users/sangjinhan/repos","events_url":"https://api.github.com/users/sangjinhan/events{/privacy}","received_events_url":"https://api.github.com/users/sangjinhan/received_events","type":"User","site_admin":false},"body":"For some mysterious bug in the DPDK virtio code, the PMD driver running in a VM crashes in `rte_eth_rx_burst()`, if a virtio device was earlier initialized with `rte_eth_rx_queue_setup()` called first. This PR reverses the order, invoking `rte_eth_tx_queue_setup()` first then `rte_eth_rx_queue_setup()`.\r\n\r\n!@*&^($*&^","created_at":"2017-03-28T06:04:20Z","updated_at":"2017-03-28T17:47:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c9de829a02eb8a6bd649104d4d2a6adee43e0d0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/NetSys/bess/pulls/356/commits","review_comments_url":"https://api.github.com/repos/NetSys/bess/pulls/356/comments","review_comment_url":"https://api.github.com/repos/NetSys/bess/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NetSys/bess/issues/356/comments","statuses_url":"https://api.github.com/repos/NetSys/bess/statuses/ba36e8cf6511d534b6cb616438bd343a0e37a0d7","head":{"label":"NetSys:init_tx_first","ref":"init_tx_first","sha":"ba36e8cf6511d534b6cb616438bd343a0e37a0d7","user":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars3.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"repo":{"id":41328795,"name":"bess","full_name":"NetSys/bess","owner":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars3.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetSys/bess","description":"BESS: Berkeley Extensible Software Switch","fork":false,"url":"https://api.github.com/repos/NetSys/bess","forks_url":"https://api.github.com/repos/NetSys/bess/forks","keys_url":"https://api.github.com/repos/NetSys/bess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetSys/bess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetSys/bess/teams","hooks_url":"https://api.github.com/repos/NetSys/bess/hooks","issue_events_url":"https://api.github.com/repos/NetSys/bess/issues/events{/number}","events_url":"https://api.github.com/repos/NetSys/bess/events","assignees_url":"https://api.github.com/repos/NetSys/bess/assignees{/user}","branches_url":"https://api.github.com/repos/NetSys/bess/branches{/branch}","tags_url":"https://api.github.com/repos/NetSys/bess/tags","blobs_url":"https://api.github.com/repos/NetSys/bess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetSys/bess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetSys/bess/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetSys/bess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetSys/bess/statuses/{sha}","languages_url":"https://api.github.com/repos/NetSys/bess/languages","stargazers_url":"https://api.github.com/repos/NetSys/bess/stargazers","contributors_url":"https://api.github.com/repos/NetSys/bess/contributors","subscribers_url":"https://api.github.com/repos/NetSys/bess/subscribers","subscription_url":"https://api.github.com/repos/NetSys/bess/subscription","commits_url":"https://api.github.com/repos/NetSys/bess/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetSys/bess/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetSys/bess/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetSys/bess/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetSys/bess/contents/{+path}","compare_url":"https://api.github.com/repos/NetSys/bess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetSys/bess/merges","archive_url":"https://api.github.com/repos/NetSys/bess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetSys/bess/downloads","issues_url":"https://api.github.com/repos/NetSys/bess/issues{/number}","pulls_url":"https://api.github.com/repos/NetSys/bess/pulls{/number}","milestones_url":"https://api.github.com/repos/NetSys/bess/milestones{/number}","notifications_url":"https://api.github.com/repos/NetSys/bess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetSys/bess/labels{/name}","releases_url":"https://api.github.com/repos/NetSys/bess/releases{/id}","deployments_url":"https://api.github.com/repos/NetSys/bess/deployments","created_at":"2015-08-24T21:51:31Z","updated_at":"2017-03-21T17:50:55Z","pushed_at":"2017-03-28T06:04:21Z","git_url":"git://github.com/NetSys/bess.git","ssh_url":"git@github.com:NetSys/bess.git","clone_url":"https://github.com/NetSys/bess.git","svn_url":"https://github.com/NetSys/bess","homepage":"","size":5134,"stargazers_count":55,"watchers_count":55,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":6,"forks":36,"open_issues":6,"watchers":55,"default_branch":"master"}},"base":{"label":"NetSys:master","ref":"master","sha":"f462c2b9d19bf53a6bd041d9aeda9a2dee1405c7","user":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars3.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"repo":{"id":41328795,"name":"bess","full_name":"NetSys/bess","owner":{"login":"NetSys","id":3665805,"avatar_url":"https://avatars3.githubusercontent.com/u/3665805?v=3","gravatar_id":"","url":"https://api.github.com/users/NetSys","html_url":"https://github.com/NetSys","followers_url":"https://api.github.com/users/NetSys/followers","following_url":"https://api.github.com/users/NetSys/following{/other_user}","gists_url":"https://api.github.com/users/NetSys/gists{/gist_id}","starred_url":"https://api.github.com/users/NetSys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NetSys/subscriptions","organizations_url":"https://api.github.com/users/NetSys/orgs","repos_url":"https://api.github.com/users/NetSys/repos","events_url":"https://api.github.com/users/NetSys/events{/privacy}","received_events_url":"https://api.github.com/users/NetSys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NetSys/bess","description":"BESS: Berkeley Extensible Software Switch","fork":false,"url":"https://api.github.com/repos/NetSys/bess","forks_url":"https://api.github.com/repos/NetSys/bess/forks","keys_url":"https://api.github.com/repos/NetSys/bess/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NetSys/bess/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NetSys/bess/teams","hooks_url":"https://api.github.com/repos/NetSys/bess/hooks","issue_events_url":"https://api.github.com/repos/NetSys/bess/issues/events{/number}","events_url":"https://api.github.com/repos/NetSys/bess/events","assignees_url":"https://api.github.com/repos/NetSys/bess/assignees{/user}","branches_url":"https://api.github.com/repos/NetSys/bess/branches{/branch}","tags_url":"https://api.github.com/repos/NetSys/bess/tags","blobs_url":"https://api.github.com/repos/NetSys/bess/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NetSys/bess/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NetSys/bess/git/refs{/sha}","trees_url":"https://api.github.com/repos/NetSys/bess/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NetSys/bess/statuses/{sha}","languages_url":"https://api.github.com/repos/NetSys/bess/languages","stargazers_url":"https://api.github.com/repos/NetSys/bess/stargazers","contributors_url":"https://api.github.com/repos/NetSys/bess/contributors","subscribers_url":"https://api.github.com/repos/NetSys/bess/subscribers","subscription_url":"https://api.github.com/repos/NetSys/bess/subscription","commits_url":"https://api.github.com/repos/NetSys/bess/commits{/sha}","git_commits_url":"https://api.github.com/repos/NetSys/bess/git/commits{/sha}","comments_url":"https://api.github.com/repos/NetSys/bess/comments{/number}","issue_comment_url":"https://api.github.com/repos/NetSys/bess/issues/comments{/number}","contents_url":"https://api.github.com/repos/NetSys/bess/contents/{+path}","compare_url":"https://api.github.com/repos/NetSys/bess/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NetSys/bess/merges","archive_url":"https://api.github.com/repos/NetSys/bess/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NetSys/bess/downloads","issues_url":"https://api.github.com/repos/NetSys/bess/issues{/number}","pulls_url":"https://api.github.com/repos/NetSys/bess/pulls{/number}","milestones_url":"https://api.github.com/repos/NetSys/bess/milestones{/number}","notifications_url":"https://api.github.com/repos/NetSys/bess/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NetSys/bess/labels{/name}","releases_url":"https://api.github.com/repos/NetSys/bess/releases{/id}","deployments_url":"https://api.github.com/repos/NetSys/bess/deployments","created_at":"2015-08-24T21:51:31Z","updated_at":"2017-03-21T17:50:55Z","pushed_at":"2017-03-28T06:04:21Z","git_url":"git://github.com/NetSys/bess.git","ssh_url":"git@github.com:NetSys/bess.git","clone_url":"https://github.com/NetSys/bess.git","svn_url":"https://github.com/NetSys/bess","homepage":"","size":5134,"stargazers_count":55,"watchers_count":55,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":6,"forks":36,"open_issues":6,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NetSys/bess/pulls/356"},"html":{"href":"https://github.com/NetSys/bess/pull/356"},"issue":{"href":"https://api.github.com/repos/NetSys/bess/issues/356"},"comments":{"href":"https://api.github.com/repos/NetSys/bess/issues/356/comments"},"review_comments":{"href":"https://api.github.com/repos/NetSys/bess/pulls/356/comments"},"review_comment":{"href":"https://api.github.com/repos/NetSys/bess/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NetSys/bess/pulls/356/commits"},"statuses":{"href":"https://api.github.com/repos/NetSys/bess/statuses/ba36e8cf6511d534b6cb616438bd343a0e37a0d7"}}}}
{"actor":{"display_login":"sangjinhan"}}