{"action":"created","issue":{"url":"https://api.github.com/repos/zulip/zulip/issues/5213","repository_url":"https://api.github.com/repos/zulip/zulip","labels_url":"https://api.github.com/repos/zulip/zulip/issues/5213/labels{/name}","comments_url":"https://api.github.com/repos/zulip/zulip/issues/5213/comments","events_url":"https://api.github.com/repos/zulip/zulip/issues/5213/events","html_url":"https://github.com/zulip/zulip/pull/5213","id":233430436,"number":5213,"title":"Fixes the the file_input reset and bug in file attachment.","user":{"login":"tejaskasetty","id":19589196,"avatar_url":"https://avatars2.githubusercontent.com/u/19589196?v=3","gravatar_id":"","url":"https://api.github.com/users/tejaskasetty","html_url":"https://github.com/tejaskasetty","followers_url":"https://api.github.com/users/tejaskasetty/followers","following_url":"https://api.github.com/users/tejaskasetty/following{/other_user}","gists_url":"https://api.github.com/users/tejaskasetty/gists{/gist_id}","starred_url":"https://api.github.com/users/tejaskasetty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejaskasetty/subscriptions","organizations_url":"https://api.github.com/users/tejaskasetty/orgs","repos_url":"https://api.github.com/users/tejaskasetty/repos","events_url":"https://api.github.com/users/tejaskasetty/events{/privacy}","received_events_url":"https://api.github.com/users/tejaskasetty/received_events","type":"User","site_admin":false},"labels":[{"id":561830510,"url":"https://api.github.com/repos/zulip/zulip/labels/reviewed","name":"reviewed","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-06-04T12:25:26Z","updated_at":"2017-06-07T08:40:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/zulip/zulip/pulls/5213","html_url":"https://github.com/zulip/zulip/pull/5213","diff_url":"https://github.com/zulip/zulip/pull/5213.diff","patch_url":"https://github.com/zulip/zulip/pull/5213.patch"},"body":"The file_input was not getting reset after each file attach. This lead to failure in attaching\r\nthe same files consecutively. Or cases when we attach a file, delete the attachment markdown and then attach the same file again. Its used to fail because of above reason. Now its fixed.\r\n\r\nThe function ```clear_out_file_list``` used to reset the input element of type file is fixed."},"comment":{"url":"https://api.github.com/repos/zulip/zulip/issues/comments/306729691","html_url":"https://github.com/zulip/zulip/pull/5213#issuecomment-306729691","issue_url":"https://api.github.com/repos/zulip/zulip/issues/5213","id":306729691,"user":{"login":"tejaskasetty","id":19589196,"avatar_url":"https://avatars2.githubusercontent.com/u/19589196?v=3","gravatar_id":"","url":"https://api.github.com/users/tejaskasetty","html_url":"https://github.com/tejaskasetty","followers_url":"https://api.github.com/users/tejaskasetty/followers","following_url":"https://api.github.com/users/tejaskasetty/following{/other_user}","gists_url":"https://api.github.com/users/tejaskasetty/gists{/gist_id}","starred_url":"https://api.github.com/users/tejaskasetty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejaskasetty/subscriptions","organizations_url":"https://api.github.com/users/tejaskasetty/orgs","repos_url":"https://api.github.com/users/tejaskasetty/repos","events_url":"https://api.github.com/users/tejaskasetty/events{/privacy}","received_events_url":"https://api.github.com/users/tejaskasetty/received_events","type":"User","site_admin":false},"created_at":"2017-06-07T08:40:21Z","updated_at":"2017-06-07T08:40:21Z","body":"@timabbott I checked out his solution. There seems to be a problem. In IE resetting or changing the value of the input element using jquery or JS doesn't work because they are read-only. We have to replace the input element. That fix might work on Chrome and Firefox and even in Microsoft Edge but not on IE. If we are considering Edge and anything after that, then his solution is more elegant."}}
{"actor":{"display_login":"tejaskasetty"}}