{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/EntityFramework/issues/7543","repository_url":"https://api.github.com/repos/aspnet/EntityFramework","labels_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/7543/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/7543/comments","events_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/7543/events","html_url":"https://github.com/aspnet/EntityFramework/pull/7543","id":205077240,"number":7543,"title":"Group By and Outer Apply and Query Optimizations and, and...","user":{"login":"tuespetre","id":4853540,"avatar_url":"https://avatars.githubusercontent.com/u/4853540?v=3","gravatar_id":"","url":"https://api.github.com/users/tuespetre","html_url":"https://github.com/tuespetre","followers_url":"https://api.github.com/users/tuespetre/followers","following_url":"https://api.github.com/users/tuespetre/following{/other_user}","gists_url":"https://api.github.com/users/tuespetre/gists{/gist_id}","starred_url":"https://api.github.com/users/tuespetre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuespetre/subscriptions","organizations_url":"https://api.github.com/users/tuespetre/orgs","repos_url":"https://api.github.com/users/tuespetre/repos","events_url":"https://api.github.com/users/tuespetre/events{/privacy}","received_events_url":"https://api.github.com/users/tuespetre/received_events","type":"User","site_admin":false},"labels":[{"id":198207563,"url":"https://api.github.com/repos/aspnet/EntityFramework/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false},{"id":263393752,"url":"https://api.github.com/repos/aspnet/EntityFramework/labels/needs-review","name":"needs-review","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-02-03T05:45:44Z","updated_at":"2017-02-04T05:59:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aspnet/EntityFramework/pulls/7543","html_url":"https://github.com/aspnet/EntityFramework/pull/7543","diff_url":"https://github.com/aspnet/EntityFramework/pull/7543.diff","patch_url":"https://github.com/aspnet/EntityFramework/pull/7543.patch"},"body":"Okay, please don't be mad at me -- I'm feeling kind 👨‍🍳 of scrambled after my deep dive into this. It's a pretty big PR and touches a lot of things. I didn't plan on it being this way but as I was working on my initial goal (getting `GROUP BY` to work) I ended up breaking some things, and in order to fix them, other things broke, and I had to fix them, ad nauseum. \r\n\r\nNow I've finally got the tests all passing (save for one SQLite oddity, but I will cover that in a sec) and successfully rebased onto the last month's worth of commits.\r\n\r\nThe gist of what I've done:\r\n\r\n- Added `GROUP BY` support\r\n- Added `LEFT JOIN LATERAL`/`OUTER APPLY` support\r\n- Optimized generated queries to avoid materialization whenever possible, resulting in much smaller SQL statements, less data over the wire, etc.\r\n\r\nNow, there are several points I know still need to be covered:\r\n\r\n- [x] Complex `GroupBy` keys\r\n- [ ] Plenty more tests for `GROUP BY`\r\n- [ ] I'm suspicious of some of the test SQL output changes surrounding discriminator columns and would like to double-check\r\n- [ ] I think the whole `QueryFlattener` class and its factory could disappear, it's only used for one call now\r\n\r\n...I just thought that for as long as this has already taken, and for as large of a changeset as this is, I would get some kind of ball rolling here."},"comment":{"url":"https://api.github.com/repos/aspnet/EntityFramework/issues/comments/277421740","html_url":"https://github.com/aspnet/EntityFramework/pull/7543#issuecomment-277421740","issue_url":"https://api.github.com/repos/aspnet/EntityFramework/issues/7543","id":277421740,"user":{"login":"smitpatel","id":1528107,"avatar_url":"https://avatars.githubusercontent.com/u/1528107?v=3","gravatar_id":"","url":"https://api.github.com/users/smitpatel","html_url":"https://github.com/smitpatel","followers_url":"https://api.github.com/users/smitpatel/followers","following_url":"https://api.github.com/users/smitpatel/following{/other_user}","gists_url":"https://api.github.com/users/smitpatel/gists{/gist_id}","starred_url":"https://api.github.com/users/smitpatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smitpatel/subscriptions","organizations_url":"https://api.github.com/users/smitpatel/orgs","repos_url":"https://api.github.com/users/smitpatel/repos","events_url":"https://api.github.com/users/smitpatel/events{/privacy}","received_events_url":"https://api.github.com/users/smitpatel/received_events","type":"User","site_admin":false},"created_at":"2017-02-04T05:59:02Z","updated_at":"2017-02-04T05:59:02Z","body":"@tuespetre - If fix for certain issues are isolated and not required/related to group by translation then please create different PR. Multiple unrelated changes in same PR makes it harder to review."}}
{"actor":{"display_login":"smitpatel"}}