{"action":"created","comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/139434040","pull_request_review_id":63362982,"id":139434040,"diff_hunk":"@@ -582,13 +582,17 @@ namespace TARCOGArgs {\n \t\t\t\t\tif ( thick( i ) < SlatThick( i ) ) thick( i ) = SlatThick( i );\n \t\t\t\t} else if ( ( ThermalMod == THERM_MOD_ISO15099 ) || ( ThermalMod == THERM_MOD_CSM ) ) {\n \t\t\t\t\tthick( i ) = SlatThick( i );\n+\t\t\t\t\tdouble slatAngRad = SlatAngle( i ) * 2.0 * DataGlobals::Pi / 360.0;","path":"src/EnergyPlus/TARCOGArgs.cc","position":27,"original_position":27,"commit_id":"d76c6f0dce2a93593deef94aeb66bad27407fd83","original_commit_id":"a7a099f36b58a3210268d94edbe8100f592d2fae","user":{"login":"Myoldmopar","id":849824,"avatar_url":"https://avatars0.githubusercontent.com/u/849824?v=4","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"body":"@vidanovic This line still needs a Real64 instead of double.","created_at":"2017-09-18T14:13:19Z","updated_at":"2017-09-18T14:21:40Z","html_url":"https://github.com/NREL/EnergyPlus/pull/6245#discussion_r139434040","pull_request_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6245","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments/139434040"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/6245#discussion_r139434040"},"pull_request":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6245"}},"in_reply_to_id":138968861},"pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6245","id":135852564,"html_url":"https://github.com/NREL/EnergyPlus/pull/6245","diff_url":"https://github.com/NREL/EnergyPlus/pull/6245.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/6245.patch","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6245","number":6245,"state":"open","locked":false,"title":"Improved Airflow Calculations for BSDF window types","user":{"login":"vidanovic","id":5805892,"avatar_url":"https://avatars2.githubusercontent.com/u/5805892?v=4","gravatar_id":"","url":"https://api.github.com/users/vidanovic","html_url":"https://github.com/vidanovic","followers_url":"https://api.github.com/users/vidanovic/followers","following_url":"https://api.github.com/users/vidanovic/following{/other_user}","gists_url":"https://api.github.com/users/vidanovic/gists{/gist_id}","starred_url":"https://api.github.com/users/vidanovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vidanovic/subscriptions","organizations_url":"https://api.github.com/users/vidanovic/orgs","repos_url":"https://api.github.com/users/vidanovic/repos","events_url":"https://api.github.com/users/vidanovic/events{/privacy}","received_events_url":"https://api.github.com/users/vidanovic/received_events","type":"User","site_admin":false},"body":"Pull request overview\r\n---------------------\r\nThis version of EnergyPlus introduces improved version of airflow calculations for BSDF window type. It also include several bugfixes.\r\n- Bugfix: Update to frame calculations (correct inside surface temperature passed to frame)\r\n- Effective emissivity calculations for interior shade used incorrect surface emissivity value.\r\n- Homogeneous diffuse shade is now recognized as shade for thermal calculations.\r\n- Edge to center of glass ratio is now taken into account.\r\n\r\nDepending on shading construction and surface properties, results can be significantly different from previous version (especially in cases when front and back surface emissivity of shading layer is different.\r\n\r\n### Work Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [x] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [x] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n   - Defect: \r\n      - Frame Edge to Center of Glass Ratio is now taken into account (BSDF only). \r\n      - Other Shading Device type is now included for airflow calculations.\r\n   - Refactoring: No refactoring performed\r\n   - NewFeature: \r\n      - Update to effective surface temperature and emissivity equations for innermost layer (BSDF only)\r\n      - IR surface exchange algorithm now perform multiple iterations over window surfaces (this is still pending to be implemented and it is not clear why was not implemented in first place, so will need discussion with EnergyPlus team.\r\n   - Performance: No performance change\r\n   - DoNoPublish: /\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [x] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [x] CI status: all green or justified\r\n - [x] Performance: CI Linux results include performance check -- verify this\r\n - [x] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - [x] Documentation changes in place\r\n - [x] Changed docs build successfully\r\n","created_at":"2017-08-15T17:43:16Z","updated_at":"2017-09-18T14:21:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8ea4fd725ba9cd9831fe05e259582a5a91f3ad0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"DeadParrot","id":993517,"avatar_url":"https://avatars3.githubusercontent.com/u/993517?v=4","gravatar_id":"","url":"https://api.github.com/users/DeadParrot","html_url":"https://github.com/DeadParrot","followers_url":"https://api.github.com/users/DeadParrot/followers","following_url":"https://api.github.com/users/DeadParrot/following{/other_user}","gists_url":"https://api.github.com/users/DeadParrot/gists{/gist_id}","starred_url":"https://api.github.com/users/DeadParrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeadParrot/subscriptions","organizations_url":"https://api.github.com/users/DeadParrot/orgs","repos_url":"https://api.github.com/users/DeadParrot/repos","events_url":"https://api.github.com/users/DeadParrot/events{/privacy}","received_events_url":"https://api.github.com/users/DeadParrot/received_events","type":"User","site_admin":false},{"login":"JasonGlazer","id":2582150,"avatar_url":"https://avatars0.githubusercontent.com/u/2582150?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonGlazer","html_url":"https://github.com/JasonGlazer","followers_url":"https://api.github.com/users/JasonGlazer/followers","following_url":"https://api.github.com/users/JasonGlazer/following{/other_user}","gists_url":"https://api.github.com/users/JasonGlazer/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonGlazer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonGlazer/subscriptions","organizations_url":"https://api.github.com/users/JasonGlazer/orgs","repos_url":"https://api.github.com/users/JasonGlazer/repos","events_url":"https://api.github.com/users/JasonGlazer/events{/privacy}","received_events_url":"https://api.github.com/users/JasonGlazer/received_events","type":"User","site_admin":false},{"login":"hongtz68","id":5821736,"avatar_url":"https://avatars1.githubusercontent.com/u/5821736?v=4","gravatar_id":"","url":"https://api.github.com/users/hongtz68","html_url":"https://github.com/hongtz68","followers_url":"https://api.github.com/users/hongtz68/followers","following_url":"https://api.github.com/users/hongtz68/following{/other_user}","gists_url":"https://api.github.com/users/hongtz68/gists{/gist_id}","starred_url":"https://api.github.com/users/hongtz68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hongtz68/subscriptions","organizations_url":"https://api.github.com/users/hongtz68/orgs","repos_url":"https://api.github.com/users/hongtz68/repos","events_url":"https://api.github.com/users/hongtz68/events{/privacy}","received_events_url":"https://api.github.com/users/hongtz68/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/6","html_url":"https://github.com/NREL/EnergyPlus/milestone/6","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/6/labels","id":2280311,"number":6,"title":"EnergyPlus 8.8.0","description":"The EnergyPlus 8.8.0 public release at the end of FY17Q4.","creator":{"login":"mjwitte","id":4991075,"avatar_url":"https://avatars2.githubusercontent.com/u/4991075?v=4","gravatar_id":"","url":"https://api.github.com/users/mjwitte","html_url":"https://github.com/mjwitte","followers_url":"https://api.github.com/users/mjwitte/followers","following_url":"https://api.github.com/users/mjwitte/following{/other_user}","gists_url":"https://api.github.com/users/mjwitte/gists{/gist_id}","starred_url":"https://api.github.com/users/mjwitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjwitte/subscriptions","organizations_url":"https://api.github.com/users/mjwitte/orgs","repos_url":"https://api.github.com/users/mjwitte/repos","events_url":"https://api.github.com/users/mjwitte/events{/privacy}","received_events_url":"https://api.github.com/users/mjwitte/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":75,"state":"open","created_at":"2017-01-26T16:05:24Z","updated_at":"2017-09-15T12:42:52Z","due_on":"2017-09-30T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6245/commits","review_comments_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6245/comments","review_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6245/comments","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/d76c6f0dce2a93593deef94aeb66bad27407fd83","head":{"label":"NREL:149092157-AERC_updates_to_BSDF","ref":"149092157-AERC_updates_to_BSDF","sha":"d76c6f0dce2a93593deef94aeb66bad27407fd83","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2017-09-11T02:03:35Z","pushed_at":"2017-09-18T03:46:08Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":330628,"stargazers_count":171,"watchers_count":171,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":112,"mirror_url":null,"open_issues_count":481,"forks":112,"open_issues":481,"watchers":171,"default_branch":"develop"}},"base":{"label":"NREL:develop","ref":"develop","sha":"f4f8b9e466f16ebbb0a72b67b3a3b5677cdcab83","user":{"login":"NREL","id":1906800,"avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":14620185,"name":"EnergyPlus","full_name":"NREL/EnergyPlus","owner":{"login":"NREL","id":1906800,"avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NREL/EnergyPlus","description":"EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.","fork":false,"url":"https://api.github.com/repos/NREL/EnergyPlus","forks_url":"https://api.github.com/repos/NREL/EnergyPlus/forks","keys_url":"https://api.github.com/repos/NREL/EnergyPlus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/EnergyPlus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/EnergyPlus/teams","hooks_url":"https://api.github.com/repos/NREL/EnergyPlus/hooks","issue_events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/EnergyPlus/events","assignees_url":"https://api.github.com/repos/NREL/EnergyPlus/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/EnergyPlus/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/EnergyPlus/tags","blobs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/EnergyPlus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/EnergyPlus/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/EnergyPlus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/EnergyPlus/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/EnergyPlus/languages","stargazers_url":"https://api.github.com/repos/NREL/EnergyPlus/stargazers","contributors_url":"https://api.github.com/repos/NREL/EnergyPlus/contributors","subscribers_url":"https://api.github.com/repos/NREL/EnergyPlus/subscribers","subscription_url":"https://api.github.com/repos/NREL/EnergyPlus/subscription","commits_url":"https://api.github.com/repos/NREL/EnergyPlus/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/EnergyPlus/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/EnergyPlus/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/EnergyPlus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/EnergyPlus/merges","archive_url":"https://api.github.com/repos/NREL/EnergyPlus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/EnergyPlus/downloads","issues_url":"https://api.github.com/repos/NREL/EnergyPlus/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/EnergyPlus/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/EnergyPlus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/labels{/name}","releases_url":"https://api.github.com/repos/NREL/EnergyPlus/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/EnergyPlus/deployments","created_at":"2013-11-22T14:47:34Z","updated_at":"2017-09-11T02:03:35Z","pushed_at":"2017-09-18T03:46:08Z","git_url":"git://github.com/NREL/EnergyPlus.git","ssh_url":"git@github.com:NREL/EnergyPlus.git","clone_url":"https://github.com/NREL/EnergyPlus.git","svn_url":"https://github.com/NREL/EnergyPlus","homepage":"https://energyplus.net","size":330628,"stargazers_count":171,"watchers_count":171,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":112,"mirror_url":null,"open_issues_count":481,"forks":112,"open_issues":481,"watchers":171,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6245"},"html":{"href":"https://github.com/NREL/EnergyPlus/pull/6245"},"issue":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/6245"},"comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/issues/6245/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6245/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6245/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/EnergyPlus/statuses/d76c6f0dce2a93593deef94aeb66bad27407fd83"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Myoldmopar"}}