{"action":"created","comment":{"url":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls/comments/140660444","pull_request_review_id":64766314,"id":140660444,"diff_hunk":"@@ -57,15 +57,19 @@ extension ProjectSpec {\n         return buildSettings\n     }\n \n-    // combines all levels of a target's settings\n+    // combines all levels of a target's settings: target, target config, project, project config\n     public func getCombinedBuildSettings(basePath: Path, target: Target, config: Config, includeProject: Bool) -> BuildSettings {\n         var buildSettings: BuildSettings = [:]\n         if includeProject {\n+            if let configFilePath = configFiles[config.name] {\n+                if let configFile = try? XCConfig(path: basePath + configFilePath) {\n+                    buildSettings += configFile.flattenedBuildSettings()","path":"Sources/XcodeGenKit/SettingsBuilder.swift","position":11,"original_position":11,"commit_id":"c34136bbd7dfdef06cd096f3c2aa6d2f55ce5e90","original_commit_id":"c34136bbd7dfdef06cd096f3c2aa6d2f55ce5e90","user":{"login":"yonaskolb","id":2393781,"avatar_url":"https://avatars2.githubusercontent.com/u/2393781?v=4","gravatar_id":"","url":"https://api.github.com/users/yonaskolb","html_url":"https://github.com/yonaskolb","followers_url":"https://api.github.com/users/yonaskolb/followers","following_url":"https://api.github.com/users/yonaskolb/following{/other_user}","gists_url":"https://api.github.com/users/yonaskolb/gists{/gist_id}","starred_url":"https://api.github.com/users/yonaskolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonaskolb/subscriptions","organizations_url":"https://api.github.com/users/yonaskolb/orgs","repos_url":"https://api.github.com/users/yonaskolb/repos","events_url":"https://api.github.com/users/yonaskolb/events{/privacy}","received_events_url":"https://api.github.com/users/yonaskolb/received_events","type":"User","site_admin":false},"body":"That's because include is a list not just a string. I should change this though to allow a simple string for a single value, just like a target's sources:\r\n```\r\ninclude: [included.yml] #works, using json style\r\ninclude:\r\n  - included.yml #works, using yaml style\r\ninclude: included.yml #does work (yet, will change)\r\n```","created_at":"2017-09-24T16:08:10Z","updated_at":"2017-09-24T16:08:11Z","html_url":"https://github.com/yonaskolb/XcodeGen/pull/64#discussion_r140660444","pull_request_url":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls/64","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls/comments/140660444"},"html":{"href":"https://github.com/yonaskolb/XcodeGen/pull/64#discussion_r140660444"},"pull_request":{"href":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls/64"}},"in_reply_to_id":140643730},"pull_request":{"url":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls/64","id":142729013,"html_url":"https://github.com/yonaskolb/XcodeGen/pull/64","diff_url":"https://github.com/yonaskolb/XcodeGen/pull/64.diff","patch_url":"https://github.com/yonaskolb/XcodeGen/pull/64.patch","issue_url":"https://api.github.com/repos/yonaskolb/XcodeGen/issues/64","number":64,"state":"open","locked":false,"title":"XCConfig files","user":{"login":"yonaskolb","id":2393781,"avatar_url":"https://avatars2.githubusercontent.com/u/2393781?v=4","gravatar_id":"","url":"https://api.github.com/users/yonaskolb","html_url":"https://github.com/yonaskolb","followers_url":"https://api.github.com/users/yonaskolb/followers","following_url":"https://api.github.com/users/yonaskolb/following{/other_user}","gists_url":"https://api.github.com/users/yonaskolb/gists{/gist_id}","starred_url":"https://api.github.com/users/yonaskolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonaskolb/subscriptions","organizations_url":"https://api.github.com/users/yonaskolb/orgs","repos_url":"https://api.github.com/users/yonaskolb/repos","events_url":"https://api.github.com/users/yonaskolb/events{/privacy}","received_events_url":"https://api.github.com/users/yonaskolb/received_events","type":"User","site_admin":false},"body":"Fixes #59 \r\n\r\n- [x] fix target `configFiles`\r\n- [x] add project `configFiles`\r\n- [x] read xcconfig files while doing build setting lookups\r\n- [x] add `groups` to project for including non build files (like configs that don't exist in any target sources)\r\n- [x] documentation","created_at":"2017-09-23T20:51:57Z","updated_at":"2017-09-24T16:08:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f4b73ff66d6e60e5a9022b2db918c7d86758dc4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pepibumur","id":663605,"avatar_url":"https://avatars3.githubusercontent.com/u/663605?v=4","gravatar_id":"","url":"https://api.github.com/users/pepibumur","html_url":"https://github.com/pepibumur","followers_url":"https://api.github.com/users/pepibumur/followers","following_url":"https://api.github.com/users/pepibumur/following{/other_user}","gists_url":"https://api.github.com/users/pepibumur/gists{/gist_id}","starred_url":"https://api.github.com/users/pepibumur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepibumur/subscriptions","organizations_url":"https://api.github.com/users/pepibumur/orgs","repos_url":"https://api.github.com/users/pepibumur/repos","events_url":"https://api.github.com/users/pepibumur/events{/privacy}","received_events_url":"https://api.github.com/users/pepibumur/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls/64/commits","review_comments_url":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls/64/comments","review_comment_url":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yonaskolb/XcodeGen/issues/64/comments","statuses_url":"https://api.github.com/repos/yonaskolb/XcodeGen/statuses/c34136bbd7dfdef06cd096f3c2aa6d2f55ce5e90","head":{"label":"yonaskolb:xcconfig","ref":"xcconfig","sha":"c34136bbd7dfdef06cd096f3c2aa6d2f55ce5e90","user":{"login":"yonaskolb","id":2393781,"avatar_url":"https://avatars2.githubusercontent.com/u/2393781?v=4","gravatar_id":"","url":"https://api.github.com/users/yonaskolb","html_url":"https://github.com/yonaskolb","followers_url":"https://api.github.com/users/yonaskolb/followers","following_url":"https://api.github.com/users/yonaskolb/following{/other_user}","gists_url":"https://api.github.com/users/yonaskolb/gists{/gist_id}","starred_url":"https://api.github.com/users/yonaskolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonaskolb/subscriptions","organizations_url":"https://api.github.com/users/yonaskolb/orgs","repos_url":"https://api.github.com/users/yonaskolb/repos","events_url":"https://api.github.com/users/yonaskolb/events{/privacy}","received_events_url":"https://api.github.com/users/yonaskolb/received_events","type":"User","site_admin":false},"repo":{"id":97716052,"name":"XcodeGen","full_name":"yonaskolb/XcodeGen","owner":{"login":"yonaskolb","id":2393781,"avatar_url":"https://avatars2.githubusercontent.com/u/2393781?v=4","gravatar_id":"","url":"https://api.github.com/users/yonaskolb","html_url":"https://github.com/yonaskolb","followers_url":"https://api.github.com/users/yonaskolb/followers","following_url":"https://api.github.com/users/yonaskolb/following{/other_user}","gists_url":"https://api.github.com/users/yonaskolb/gists{/gist_id}","starred_url":"https://api.github.com/users/yonaskolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonaskolb/subscriptions","organizations_url":"https://api.github.com/users/yonaskolb/orgs","repos_url":"https://api.github.com/users/yonaskolb/repos","events_url":"https://api.github.com/users/yonaskolb/events{/privacy}","received_events_url":"https://api.github.com/users/yonaskolb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yonaskolb/XcodeGen","description":"Swift command line tool that generates your Xcode project from a simple spec and your folder structure","fork":false,"url":"https://api.github.com/repos/yonaskolb/XcodeGen","forks_url":"https://api.github.com/repos/yonaskolb/XcodeGen/forks","keys_url":"https://api.github.com/repos/yonaskolb/XcodeGen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yonaskolb/XcodeGen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yonaskolb/XcodeGen/teams","hooks_url":"https://api.github.com/repos/yonaskolb/XcodeGen/hooks","issue_events_url":"https://api.github.com/repos/yonaskolb/XcodeGen/issues/events{/number}","events_url":"https://api.github.com/repos/yonaskolb/XcodeGen/events","assignees_url":"https://api.github.com/repos/yonaskolb/XcodeGen/assignees{/user}","branches_url":"https://api.github.com/repos/yonaskolb/XcodeGen/branches{/branch}","tags_url":"https://api.github.com/repos/yonaskolb/XcodeGen/tags","blobs_url":"https://api.github.com/repos/yonaskolb/XcodeGen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yonaskolb/XcodeGen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yonaskolb/XcodeGen/git/refs{/sha}","trees_url":"https://api.github.com/repos/yonaskolb/XcodeGen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yonaskolb/XcodeGen/statuses/{sha}","languages_url":"https://api.github.com/repos/yonaskolb/XcodeGen/languages","stargazers_url":"https://api.github.com/repos/yonaskolb/XcodeGen/stargazers","contributors_url":"https://api.github.com/repos/yonaskolb/XcodeGen/contributors","subscribers_url":"https://api.github.com/repos/yonaskolb/XcodeGen/subscribers","subscription_url":"https://api.github.com/repos/yonaskolb/XcodeGen/subscription","commits_url":"https://api.github.com/repos/yonaskolb/XcodeGen/commits{/sha}","git_commits_url":"https://api.github.com/repos/yonaskolb/XcodeGen/git/commits{/sha}","comments_url":"https://api.github.com/repos/yonaskolb/XcodeGen/comments{/number}","issue_comment_url":"https://api.github.com/repos/yonaskolb/XcodeGen/issues/comments{/number}","contents_url":"https://api.github.com/repos/yonaskolb/XcodeGen/contents/{+path}","compare_url":"https://api.github.com/repos/yonaskolb/XcodeGen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yonaskolb/XcodeGen/merges","archive_url":"https://api.github.com/repos/yonaskolb/XcodeGen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yonaskolb/XcodeGen/downloads","issues_url":"https://api.github.com/repos/yonaskolb/XcodeGen/issues{/number}","pulls_url":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls{/number}","milestones_url":"https://api.github.com/repos/yonaskolb/XcodeGen/milestones{/number}","notifications_url":"https://api.github.com/repos/yonaskolb/XcodeGen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yonaskolb/XcodeGen/labels{/name}","releases_url":"https://api.github.com/repos/yonaskolb/XcodeGen/releases{/id}","deployments_url":"https://api.github.com/repos/yonaskolb/XcodeGen/deployments","created_at":"2017-07-19T12:56:04Z","updated_at":"2017-09-22T08:24:12Z","pushed_at":"2017-09-23T20:59:03Z","git_url":"git://github.com/yonaskolb/XcodeGen.git","ssh_url":"git@github.com:yonaskolb/XcodeGen.git","clone_url":"https://github.com/yonaskolb/XcodeGen.git","svn_url":"https://github.com/yonaskolb/XcodeGen","homepage":"","size":3033,"stargazers_count":252,"watchers_count":252,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":19,"forks":9,"open_issues":19,"watchers":252,"default_branch":"master"}},"base":{"label":"yonaskolb:master","ref":"master","sha":"a20885e6b45cbefaed0bdee42b1e63089e131a85","user":{"login":"yonaskolb","id":2393781,"avatar_url":"https://avatars2.githubusercontent.com/u/2393781?v=4","gravatar_id":"","url":"https://api.github.com/users/yonaskolb","html_url":"https://github.com/yonaskolb","followers_url":"https://api.github.com/users/yonaskolb/followers","following_url":"https://api.github.com/users/yonaskolb/following{/other_user}","gists_url":"https://api.github.com/users/yonaskolb/gists{/gist_id}","starred_url":"https://api.github.com/users/yonaskolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonaskolb/subscriptions","organizations_url":"https://api.github.com/users/yonaskolb/orgs","repos_url":"https://api.github.com/users/yonaskolb/repos","events_url":"https://api.github.com/users/yonaskolb/events{/privacy}","received_events_url":"https://api.github.com/users/yonaskolb/received_events","type":"User","site_admin":false},"repo":{"id":97716052,"name":"XcodeGen","full_name":"yonaskolb/XcodeGen","owner":{"login":"yonaskolb","id":2393781,"avatar_url":"https://avatars2.githubusercontent.com/u/2393781?v=4","gravatar_id":"","url":"https://api.github.com/users/yonaskolb","html_url":"https://github.com/yonaskolb","followers_url":"https://api.github.com/users/yonaskolb/followers","following_url":"https://api.github.com/users/yonaskolb/following{/other_user}","gists_url":"https://api.github.com/users/yonaskolb/gists{/gist_id}","starred_url":"https://api.github.com/users/yonaskolb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonaskolb/subscriptions","organizations_url":"https://api.github.com/users/yonaskolb/orgs","repos_url":"https://api.github.com/users/yonaskolb/repos","events_url":"https://api.github.com/users/yonaskolb/events{/privacy}","received_events_url":"https://api.github.com/users/yonaskolb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yonaskolb/XcodeGen","description":"Swift command line tool that generates your Xcode project from a simple spec and your folder structure","fork":false,"url":"https://api.github.com/repos/yonaskolb/XcodeGen","forks_url":"https://api.github.com/repos/yonaskolb/XcodeGen/forks","keys_url":"https://api.github.com/repos/yonaskolb/XcodeGen/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yonaskolb/XcodeGen/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yonaskolb/XcodeGen/teams","hooks_url":"https://api.github.com/repos/yonaskolb/XcodeGen/hooks","issue_events_url":"https://api.github.com/repos/yonaskolb/XcodeGen/issues/events{/number}","events_url":"https://api.github.com/repos/yonaskolb/XcodeGen/events","assignees_url":"https://api.github.com/repos/yonaskolb/XcodeGen/assignees{/user}","branches_url":"https://api.github.com/repos/yonaskolb/XcodeGen/branches{/branch}","tags_url":"https://api.github.com/repos/yonaskolb/XcodeGen/tags","blobs_url":"https://api.github.com/repos/yonaskolb/XcodeGen/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yonaskolb/XcodeGen/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yonaskolb/XcodeGen/git/refs{/sha}","trees_url":"https://api.github.com/repos/yonaskolb/XcodeGen/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yonaskolb/XcodeGen/statuses/{sha}","languages_url":"https://api.github.com/repos/yonaskolb/XcodeGen/languages","stargazers_url":"https://api.github.com/repos/yonaskolb/XcodeGen/stargazers","contributors_url":"https://api.github.com/repos/yonaskolb/XcodeGen/contributors","subscribers_url":"https://api.github.com/repos/yonaskolb/XcodeGen/subscribers","subscription_url":"https://api.github.com/repos/yonaskolb/XcodeGen/subscription","commits_url":"https://api.github.com/repos/yonaskolb/XcodeGen/commits{/sha}","git_commits_url":"https://api.github.com/repos/yonaskolb/XcodeGen/git/commits{/sha}","comments_url":"https://api.github.com/repos/yonaskolb/XcodeGen/comments{/number}","issue_comment_url":"https://api.github.com/repos/yonaskolb/XcodeGen/issues/comments{/number}","contents_url":"https://api.github.com/repos/yonaskolb/XcodeGen/contents/{+path}","compare_url":"https://api.github.com/repos/yonaskolb/XcodeGen/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yonaskolb/XcodeGen/merges","archive_url":"https://api.github.com/repos/yonaskolb/XcodeGen/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yonaskolb/XcodeGen/downloads","issues_url":"https://api.github.com/repos/yonaskolb/XcodeGen/issues{/number}","pulls_url":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls{/number}","milestones_url":"https://api.github.com/repos/yonaskolb/XcodeGen/milestones{/number}","notifications_url":"https://api.github.com/repos/yonaskolb/XcodeGen/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yonaskolb/XcodeGen/labels{/name}","releases_url":"https://api.github.com/repos/yonaskolb/XcodeGen/releases{/id}","deployments_url":"https://api.github.com/repos/yonaskolb/XcodeGen/deployments","created_at":"2017-07-19T12:56:04Z","updated_at":"2017-09-22T08:24:12Z","pushed_at":"2017-09-23T20:59:03Z","git_url":"git://github.com/yonaskolb/XcodeGen.git","ssh_url":"git@github.com:yonaskolb/XcodeGen.git","clone_url":"https://github.com/yonaskolb/XcodeGen.git","svn_url":"https://github.com/yonaskolb/XcodeGen","homepage":"","size":3033,"stargazers_count":252,"watchers_count":252,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":19,"forks":9,"open_issues":19,"watchers":252,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls/64"},"html":{"href":"https://github.com/yonaskolb/XcodeGen/pull/64"},"issue":{"href":"https://api.github.com/repos/yonaskolb/XcodeGen/issues/64"},"comments":{"href":"https://api.github.com/repos/yonaskolb/XcodeGen/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yonaskolb/XcodeGen/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/yonaskolb/XcodeGen/statuses/c34136bbd7dfdef06cd096f3c2aa6d2f55ce5e90"}},"author_association":"OWNER"}}
{"actor":{"display_login":"yonaskolb"}}