{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/126498446","pull_request_review_id":48988327,"id":126498446,"diff_hunk":"@@ -6,12 +6,12 @@\n \n \n html {\n-    font-size: 100%;\n+    font-size: 18px;","path":"media/css/pebbles/base/elements/_document.scss","position":5,"original_position":5,"commit_id":"60b6b138f67593b5de77c1b946d3b98c53bcc34c","original_commit_id":"60b6b138f67593b5de77c1b946d3b98c53bcc34c","user":{"login":"alexgibson","id":400117,"avatar_url":"https://avatars3.githubusercontent.com/u/400117?v=3","gravatar_id":"","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"body":"Yeah I was a little wary of doing this as well, but I think your suggestion sounds sensible. I'll play with it and see how it looks.","created_at":"2017-07-10T18:18:54Z","updated_at":"2017-07-10T18:18:54Z","html_url":"https://github.com/mozilla/bedrock/pull/4945#discussion_r126498446","pull_request_url":"https://api.github.com/repos/mozilla/bedrock/pulls/4945","_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments/126498446"},"html":{"href":"https://github.com/mozilla/bedrock/pull/4945#discussion_r126498446"},"pull_request":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/4945"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/bedrock/pulls/4945","id":129177736,"html_url":"https://github.com/mozilla/bedrock/pull/4945","diff_url":"https://github.com/mozilla/bedrock/pull/4945.diff","patch_url":"https://github.com/mozilla/bedrock/pull/4945.patch","issue_url":"https://api.github.com/repos/mozilla/bedrock/issues/4945","number":4945,"state":"open","locked":false,"title":"[fix bug 1369144] Adjust Fx Hub headers & sub-headers","user":{"login":"alexgibson","id":400117,"avatar_url":"https://avatars3.githubusercontent.com/u/400117?v=3","gravatar_id":"","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"body":"## Description\r\n- Updates headings in Pebbles to fit the [new typographic scale](http://craigcook.github.io/etc/typescale/).\r\n- Changes all labels to sentance case\r\n- Updates product headings to incorporate the word \"Browser\".\r\n- Moves header CSS to a shared component.\r\n- Updates nav and subnav CSS to accommodate RTL.\r\n\r\nNote: I've lowered the base size of Zilla from 20px to 18px for the body copy on all hub pages. If we stuck exactly to the scale linked above, the base size should be 16px. For the regular Zilla weight however, 18px *looks* the same size as 16px in Open Sans. Zilla at 16px looks around 14px, and feels just too small. The two just aren't well balanced enough imho :/\r\n\r\n## Bugzilla link\r\nhttps://bugzilla.mozilla.org/show_bug.cgi?id=1369144\r\nhttps://bugzilla.mozilla.org/show_bug.cgi?id=1375636\r\n\r\n## Testing\r\nhttps://bedrock-demo-agibson.us-west.moz.works/en-US/firefox/\r\n\r\nThis change effects hub pages mainly, although the heading size changes do effect all Pebbles pages, so a cursory check of all existing pages is worthwhile. Impact should be minimal as it's only font size changes.","created_at":"2017-07-06T12:50:59Z","updated_at":"2017-07-10T18:18:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e36e6e18fd71ca3997cc6e37d9e651c16502e561","assignee":{"login":"craigcook","id":205591,"avatar_url":"https://avatars2.githubusercontent.com/u/205591?v=3","gravatar_id":"","url":"https://api.github.com/users/craigcook","html_url":"https://github.com/craigcook","followers_url":"https://api.github.com/users/craigcook/followers","following_url":"https://api.github.com/users/craigcook/following{/other_user}","gists_url":"https://api.github.com/users/craigcook/gists{/gist_id}","starred_url":"https://api.github.com/users/craigcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigcook/subscriptions","organizations_url":"https://api.github.com/users/craigcook/orgs","repos_url":"https://api.github.com/users/craigcook/repos","events_url":"https://api.github.com/users/craigcook/events{/privacy}","received_events_url":"https://api.github.com/users/craigcook/received_events","type":"User","site_admin":false},"assignees":[{"login":"craigcook","id":205591,"avatar_url":"https://avatars2.githubusercontent.com/u/205591?v=3","gravatar_id":"","url":"https://api.github.com/users/craigcook","html_url":"https://github.com/craigcook","followers_url":"https://api.github.com/users/craigcook/followers","following_url":"https://api.github.com/users/craigcook/following{/other_user}","gists_url":"https://api.github.com/users/craigcook/gists{/gist_id}","starred_url":"https://api.github.com/users/craigcook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigcook/subscriptions","organizations_url":"https://api.github.com/users/craigcook/orgs","repos_url":"https://api.github.com/users/craigcook/repos","events_url":"https://api.github.com/users/craigcook/events{/privacy}","received_events_url":"https://api.github.com/users/craigcook/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/bedrock/pulls/4945/commits","review_comments_url":"https://api.github.com/repos/mozilla/bedrock/pulls/4945/comments","review_comment_url":"https://api.github.com/repos/mozilla/bedrock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/bedrock/issues/4945/comments","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/60b6b138f67593b5de77c1b946d3b98c53bcc34c","head":{"label":"alexgibson:bug-1369144-fx-header-updates","ref":"bug-1369144-fx-header-updates","sha":"60b6b138f67593b5de77c1b946d3b98c53bcc34c","user":{"login":"alexgibson","id":400117,"avatar_url":"https://avatars3.githubusercontent.com/u/400117?v=3","gravatar_id":"","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"repo":{"id":9545146,"name":"bedrock","full_name":"alexgibson/bedrock","owner":{"login":"alexgibson","id":400117,"avatar_url":"https://avatars3.githubusercontent.com/u/400117?v=3","gravatar_id":"","url":"https://api.github.com/users/alexgibson","html_url":"https://github.com/alexgibson","followers_url":"https://api.github.com/users/alexgibson/followers","following_url":"https://api.github.com/users/alexgibson/following{/other_user}","gists_url":"https://api.github.com/users/alexgibson/gists{/gist_id}","starred_url":"https://api.github.com/users/alexgibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexgibson/subscriptions","organizations_url":"https://api.github.com/users/alexgibson/orgs","repos_url":"https://api.github.com/users/alexgibson/repos","events_url":"https://api.github.com/users/alexgibson/events{/privacy}","received_events_url":"https://api.github.com/users/alexgibson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexgibson/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":true,"url":"https://api.github.com/repos/alexgibson/bedrock","forks_url":"https://api.github.com/repos/alexgibson/bedrock/forks","keys_url":"https://api.github.com/repos/alexgibson/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexgibson/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexgibson/bedrock/teams","hooks_url":"https://api.github.com/repos/alexgibson/bedrock/hooks","issue_events_url":"https://api.github.com/repos/alexgibson/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/alexgibson/bedrock/events","assignees_url":"https://api.github.com/repos/alexgibson/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/alexgibson/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/alexgibson/bedrock/tags","blobs_url":"https://api.github.com/repos/alexgibson/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexgibson/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexgibson/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexgibson/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexgibson/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/alexgibson/bedrock/languages","stargazers_url":"https://api.github.com/repos/alexgibson/bedrock/stargazers","contributors_url":"https://api.github.com/repos/alexgibson/bedrock/contributors","subscribers_url":"https://api.github.com/repos/alexgibson/bedrock/subscribers","subscription_url":"https://api.github.com/repos/alexgibson/bedrock/subscription","commits_url":"https://api.github.com/repos/alexgibson/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexgibson/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexgibson/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexgibson/bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexgibson/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/alexgibson/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexgibson/bedrock/merges","archive_url":"https://api.github.com/repos/alexgibson/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexgibson/bedrock/downloads","issues_url":"https://api.github.com/repos/alexgibson/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/alexgibson/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/alexgibson/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/alexgibson/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexgibson/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/alexgibson/bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/alexgibson/bedrock/deployments","created_at":"2013-04-19T12:36:05Z","updated_at":"2015-05-08T13:28:28Z","pushed_at":"2017-07-10T15:04:19Z","git_url":"git://github.com/alexgibson/bedrock.git","ssh_url":"git@github.com:alexgibson/bedrock.git","clone_url":"https://github.com/alexgibson/bedrock.git","svn_url":"https://github.com/alexgibson/bedrock","homepage":"http://mozilla.org","size":404917,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"2c8b9e10a33eec8fdf5714980a1dff60dc01d44e","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":1616665,"name":"bedrock","full_name":"mozilla/bedrock","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars1.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/bedrock","description":"Making mozilla.org awesome, one pebble at a time","fork":false,"url":"https://api.github.com/repos/mozilla/bedrock","forks_url":"https://api.github.com/repos/mozilla/bedrock/forks","keys_url":"https://api.github.com/repos/mozilla/bedrock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/bedrock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/bedrock/teams","hooks_url":"https://api.github.com/repos/mozilla/bedrock/hooks","issue_events_url":"https://api.github.com/repos/mozilla/bedrock/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/bedrock/events","assignees_url":"https://api.github.com/repos/mozilla/bedrock/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/bedrock/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/bedrock/tags","blobs_url":"https://api.github.com/repos/mozilla/bedrock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/bedrock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/bedrock/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/bedrock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/bedrock/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/bedrock/languages","stargazers_url":"https://api.github.com/repos/mozilla/bedrock/stargazers","contributors_url":"https://api.github.com/repos/mozilla/bedrock/contributors","subscribers_url":"https://api.github.com/repos/mozilla/bedrock/subscribers","subscription_url":"https://api.github.com/repos/mozilla/bedrock/subscription","commits_url":"https://api.github.com/repos/mozilla/bedrock/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/bedrock/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/bedrock/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/bedrock/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/bedrock/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/bedrock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/bedrock/merges","archive_url":"https://api.github.com/repos/mozilla/bedrock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/bedrock/downloads","issues_url":"https://api.github.com/repos/mozilla/bedrock/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/bedrock/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/bedrock/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/bedrock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/bedrock/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/bedrock/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/bedrock/deployments","created_at":"2011-04-14T22:57:57Z","updated_at":"2017-07-09T05:02:57Z","pushed_at":"2017-07-10T16:15:30Z","git_url":"git://github.com/mozilla/bedrock.git","ssh_url":"git@github.com:mozilla/bedrock.git","clone_url":"https://github.com/mozilla/bedrock.git","svn_url":"https://github.com/mozilla/bedrock","homepage":"https://www.mozilla.org","size":402037,"stargazers_count":400,"watchers_count":400,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":515,"mirror_url":null,"open_issues_count":13,"forks":515,"open_issues":13,"watchers":400,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/4945"},"html":{"href":"https://github.com/mozilla/bedrock/pull/4945"},"issue":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/4945"},"comments":{"href":"https://api.github.com/repos/mozilla/bedrock/issues/4945/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/4945/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/bedrock/pulls/4945/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/bedrock/statuses/60b6b138f67593b5de77c1b946d3b98c53bcc34c"}}}}
{"actor":{"display_login":"alexgibson"}}