{"action":"created","comment":{"url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/pulls/comments/142369400","pull_request_review_id":66718644,"id":142369400,"diff_hunk":"@@ -1,5 +1,7 @@\n FactoryGirl.define do\n   factory :inspection do\n+    person\n+    item","path":"spec/factories/inspection.rb","position":4,"original_position":4,"commit_id":"5a79b308e20f1a7c671219a8e36246c06aea3643","original_commit_id":"5a79b308e20f1a7c671219a8e36246c06aea3643","user":{"login":"kgf","id":2431417,"avatar_url":"https://avatars1.githubusercontent.com/u/2431417?v=4","gravatar_id":"","url":"https://api.github.com/users/kgf","html_url":"https://github.com/kgf","followers_url":"https://api.github.com/users/kgf/followers","following_url":"https://api.github.com/users/kgf/following{/other_user}","gists_url":"https://api.github.com/users/kgf/gists{/gist_id}","starred_url":"https://api.github.com/users/kgf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgf/subscriptions","organizations_url":"https://api.github.com/users/kgf/orgs","repos_url":"https://api.github.com/users/kgf/repos","events_url":"https://api.github.com/users/kgf/events{/privacy}","received_events_url":"https://api.github.com/users/kgf/received_events","type":"User","site_admin":false},"body":"I would prefer not to use this style. I have found it results in cascading lines of objects bring created. Imagine if the person factory then has a reference to an event, that then has take and assignments and so on. I prefer to either create them explicitly in the spec, or stub them.\r\nThanks for your help","created_at":"2017-10-03T10:52:20Z","updated_at":"2017-10-03T10:52:21Z","html_url":"https://github.com/ReadyResponder/ReadyResponder/pull/490#discussion_r142369400","pull_request_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/pulls/490","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ReadyResponder/ReadyResponder/pulls/comments/142369400"},"html":{"href":"https://github.com/ReadyResponder/ReadyResponder/pull/490#discussion_r142369400"},"pull_request":{"href":"https://api.github.com/repos/ReadyResponder/ReadyResponder/pulls/490"}}},"pull_request":{"url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/pulls/490","id":144332384,"html_url":"https://github.com/ReadyResponder/ReadyResponder/pull/490","diff_url":"https://github.com/ReadyResponder/ReadyResponder/pull/490.diff","patch_url":"https://github.com/ReadyResponder/ReadyResponder/pull/490.patch","issue_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/issues/490","number":490,"state":"open","locked":false,"title":"Add Inspector Option to Inspection Forms","user":{"login":"ChanChar","id":8755434,"avatar_url":"https://avatars1.githubusercontent.com/u/8755434?v=4","gravatar_id":"","url":"https://api.github.com/users/ChanChar","html_url":"https://github.com/ChanChar","followers_url":"https://api.github.com/users/ChanChar/followers","following_url":"https://api.github.com/users/ChanChar/following{/other_user}","gists_url":"https://api.github.com/users/ChanChar/gists{/gist_id}","starred_url":"https://api.github.com/users/ChanChar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChanChar/subscriptions","organizations_url":"https://api.github.com/users/ChanChar/orgs","repos_url":"https://api.github.com/users/ChanChar/repos","events_url":"https://api.github.com/users/ChanChar/events{/privacy}","received_events_url":"https://api.github.com/users/ChanChar/received_events","type":"User","site_admin":false},"body":"Resolves https://github.com/ReadyResponder/ReadyResponder/issues/480\r\n\r\nChanges:\r\n\r\n  * Adds `inspector` field to any inspection forms\r\n  * Fix seeds entry for `Grant`\r\n  * Add inspection controller specs\r\n  * Update `inspection` factory to build associations\r\n  * Adds `login_manager` spec helper method\r\n\r\nExamples\r\n\r\n<img width=\"933\" alt=\"screenshot 2017-10-02 19 36 01\" src=\"https://user-images.githubusercontent.com/8755434/31109500-19d3b31e-a7b5-11e7-82db-f2ed39308870.png\">\r\n<img width=\"1331\" alt=\"screenshot 2017-10-02 21 22 30\" src=\"https://user-images.githubusercontent.com/8755434/31109917-f26e7f9a-a7b7-11e7-92bb-0b3e61464753.png\">\r\n","created_at":"2017-10-03T04:03:26Z","updated_at":"2017-10-03T10:52:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccf0f965b9ec0bc0292b75863b25ae86b8373e41","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/pulls/490/commits","review_comments_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/pulls/490/comments","review_comment_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/issues/490/comments","statuses_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/statuses/5a79b308e20f1a7c671219a8e36246c06aea3643","head":{"label":"ChanChar:cl/add-inspector-to-inspection-forms","ref":"cl/add-inspector-to-inspection-forms","sha":"5a79b308e20f1a7c671219a8e36246c06aea3643","user":{"login":"ChanChar","id":8755434,"avatar_url":"https://avatars1.githubusercontent.com/u/8755434?v=4","gravatar_id":"","url":"https://api.github.com/users/ChanChar","html_url":"https://github.com/ChanChar","followers_url":"https://api.github.com/users/ChanChar/followers","following_url":"https://api.github.com/users/ChanChar/following{/other_user}","gists_url":"https://api.github.com/users/ChanChar/gists{/gist_id}","starred_url":"https://api.github.com/users/ChanChar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChanChar/subscriptions","organizations_url":"https://api.github.com/users/ChanChar/orgs","repos_url":"https://api.github.com/users/ChanChar/repos","events_url":"https://api.github.com/users/ChanChar/events{/privacy}","received_events_url":"https://api.github.com/users/ChanChar/received_events","type":"User","site_admin":false},"repo":{"id":105495220,"name":"ReadyResponder","full_name":"ChanChar/ReadyResponder","owner":{"login":"ChanChar","id":8755434,"avatar_url":"https://avatars1.githubusercontent.com/u/8755434?v=4","gravatar_id":"","url":"https://api.github.com/users/ChanChar","html_url":"https://github.com/ChanChar","followers_url":"https://api.github.com/users/ChanChar/followers","following_url":"https://api.github.com/users/ChanChar/following{/other_user}","gists_url":"https://api.github.com/users/ChanChar/gists{/gist_id}","starred_url":"https://api.github.com/users/ChanChar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChanChar/subscriptions","organizations_url":"https://api.github.com/users/ChanChar/orgs","repos_url":"https://api.github.com/users/ChanChar/repos","events_url":"https://api.github.com/users/ChanChar/events{/privacy}","received_events_url":"https://api.github.com/users/ChanChar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ChanChar/ReadyResponder","description":"Local Incident Management System - This is used for tracking resources for Local Emergency Management","fork":true,"url":"https://api.github.com/repos/ChanChar/ReadyResponder","forks_url":"https://api.github.com/repos/ChanChar/ReadyResponder/forks","keys_url":"https://api.github.com/repos/ChanChar/ReadyResponder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChanChar/ReadyResponder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChanChar/ReadyResponder/teams","hooks_url":"https://api.github.com/repos/ChanChar/ReadyResponder/hooks","issue_events_url":"https://api.github.com/repos/ChanChar/ReadyResponder/issues/events{/number}","events_url":"https://api.github.com/repos/ChanChar/ReadyResponder/events","assignees_url":"https://api.github.com/repos/ChanChar/ReadyResponder/assignees{/user}","branches_url":"https://api.github.com/repos/ChanChar/ReadyResponder/branches{/branch}","tags_url":"https://api.github.com/repos/ChanChar/ReadyResponder/tags","blobs_url":"https://api.github.com/repos/ChanChar/ReadyResponder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChanChar/ReadyResponder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChanChar/ReadyResponder/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChanChar/ReadyResponder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChanChar/ReadyResponder/statuses/{sha}","languages_url":"https://api.github.com/repos/ChanChar/ReadyResponder/languages","stargazers_url":"https://api.github.com/repos/ChanChar/ReadyResponder/stargazers","contributors_url":"https://api.github.com/repos/ChanChar/ReadyResponder/contributors","subscribers_url":"https://api.github.com/repos/ChanChar/ReadyResponder/subscribers","subscription_url":"https://api.github.com/repos/ChanChar/ReadyResponder/subscription","commits_url":"https://api.github.com/repos/ChanChar/ReadyResponder/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChanChar/ReadyResponder/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChanChar/ReadyResponder/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChanChar/ReadyResponder/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChanChar/ReadyResponder/contents/{+path}","compare_url":"https://api.github.com/repos/ChanChar/ReadyResponder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChanChar/ReadyResponder/merges","archive_url":"https://api.github.com/repos/ChanChar/ReadyResponder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChanChar/ReadyResponder/downloads","issues_url":"https://api.github.com/repos/ChanChar/ReadyResponder/issues{/number}","pulls_url":"https://api.github.com/repos/ChanChar/ReadyResponder/pulls{/number}","milestones_url":"https://api.github.com/repos/ChanChar/ReadyResponder/milestones{/number}","notifications_url":"https://api.github.com/repos/ChanChar/ReadyResponder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChanChar/ReadyResponder/labels{/name}","releases_url":"https://api.github.com/repos/ChanChar/ReadyResponder/releases{/id}","deployments_url":"https://api.github.com/repos/ChanChar/ReadyResponder/deployments","created_at":"2017-10-02T03:38:51Z","updated_at":"2017-10-02T03:38:53Z","pushed_at":"2017-10-03T05:32:45Z","git_url":"git://github.com/ChanChar/ReadyResponder.git","ssh_url":"git@github.com:ChanChar/ReadyResponder.git","clone_url":"https://github.com/ChanChar/ReadyResponder.git","svn_url":"https://github.com/ChanChar/ReadyResponder","homepage":"","size":4343,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"ReadyResponder:development","ref":"development","sha":"2ac41b2cd18b1906f875a6761067aae321768bed","user":{"login":"ReadyResponder","id":20895980,"avatar_url":"https://avatars2.githubusercontent.com/u/20895980?v=4","gravatar_id":"","url":"https://api.github.com/users/ReadyResponder","html_url":"https://github.com/ReadyResponder","followers_url":"https://api.github.com/users/ReadyResponder/followers","following_url":"https://api.github.com/users/ReadyResponder/following{/other_user}","gists_url":"https://api.github.com/users/ReadyResponder/gists{/gist_id}","starred_url":"https://api.github.com/users/ReadyResponder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReadyResponder/subscriptions","organizations_url":"https://api.github.com/users/ReadyResponder/orgs","repos_url":"https://api.github.com/users/ReadyResponder/repos","events_url":"https://api.github.com/users/ReadyResponder/events{/privacy}","received_events_url":"https://api.github.com/users/ReadyResponder/received_events","type":"Organization","site_admin":false},"repo":{"id":10175290,"name":"ReadyResponder","full_name":"ReadyResponder/ReadyResponder","owner":{"login":"ReadyResponder","id":20895980,"avatar_url":"https://avatars2.githubusercontent.com/u/20895980?v=4","gravatar_id":"","url":"https://api.github.com/users/ReadyResponder","html_url":"https://github.com/ReadyResponder","followers_url":"https://api.github.com/users/ReadyResponder/followers","following_url":"https://api.github.com/users/ReadyResponder/following{/other_user}","gists_url":"https://api.github.com/users/ReadyResponder/gists{/gist_id}","starred_url":"https://api.github.com/users/ReadyResponder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReadyResponder/subscriptions","organizations_url":"https://api.github.com/users/ReadyResponder/orgs","repos_url":"https://api.github.com/users/ReadyResponder/repos","events_url":"https://api.github.com/users/ReadyResponder/events{/privacy}","received_events_url":"https://api.github.com/users/ReadyResponder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReadyResponder/ReadyResponder","description":"Local Incident Management System - This is used for tracking resources for Local Emergency Management","fork":false,"url":"https://api.github.com/repos/ReadyResponder/ReadyResponder","forks_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/forks","keys_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/teams","hooks_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/hooks","issue_events_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/issues/events{/number}","events_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/events","assignees_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/assignees{/user}","branches_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/branches{/branch}","tags_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/tags","blobs_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/statuses/{sha}","languages_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/languages","stargazers_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/stargazers","contributors_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/contributors","subscribers_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/subscribers","subscription_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/subscription","commits_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/contents/{+path}","compare_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/merges","archive_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/downloads","issues_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/issues{/number}","pulls_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/pulls{/number}","milestones_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/milestones{/number}","notifications_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/labels{/name}","releases_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/releases{/id}","deployments_url":"https://api.github.com/repos/ReadyResponder/ReadyResponder/deployments","created_at":"2013-05-20T15:06:15Z","updated_at":"2017-10-02T16:43:05Z","pushed_at":"2017-10-03T05:33:35Z","git_url":"git://github.com/ReadyResponder/ReadyResponder.git","ssh_url":"git@github.com:ReadyResponder/ReadyResponder.git","clone_url":"https://github.com/ReadyResponder/ReadyResponder.git","svn_url":"https://github.com/ReadyResponder/ReadyResponder","homepage":"","size":4369,"stargazers_count":51,"watchers_count":51,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":51,"forks":88,"open_issues":51,"watchers":51,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ReadyResponder/ReadyResponder/pulls/490"},"html":{"href":"https://github.com/ReadyResponder/ReadyResponder/pull/490"},"issue":{"href":"https://api.github.com/repos/ReadyResponder/ReadyResponder/issues/490"},"comments":{"href":"https://api.github.com/repos/ReadyResponder/ReadyResponder/issues/490/comments"},"review_comments":{"href":"https://api.github.com/repos/ReadyResponder/ReadyResponder/pulls/490/comments"},"review_comment":{"href":"https://api.github.com/repos/ReadyResponder/ReadyResponder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReadyResponder/ReadyResponder/pulls/490/commits"},"statuses":{"href":"https://api.github.com/repos/ReadyResponder/ReadyResponder/statuses/5a79b308e20f1a7c671219a8e36246c06aea3643"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kgf"}}