{"action":"created","issue":{"url":"https://api.github.com/repos/thecodeteam/rexray/issues/1129","repository_url":"https://api.github.com/repos/thecodeteam/rexray","labels_url":"https://api.github.com/repos/thecodeteam/rexray/issues/1129/labels{/name}","comments_url":"https://api.github.com/repos/thecodeteam/rexray/issues/1129/comments","events_url":"https://api.github.com/repos/thecodeteam/rexray/issues/1129/events","html_url":"https://github.com/thecodeteam/rexray/pull/1129","id":282239816,"number":1129,"title":"Don't use client provided NextDevice for AzureUD","user":{"login":"codenrhoden","id":1627176,"avatar_url":"https://avatars3.githubusercontent.com/u/1627176?v=4","gravatar_id":"","url":"https://api.github.com/users/codenrhoden","html_url":"https://github.com/codenrhoden","followers_url":"https://api.github.com/users/codenrhoden/followers","following_url":"https://api.github.com/users/codenrhoden/following{/other_user}","gists_url":"https://api.github.com/users/codenrhoden/gists{/gist_id}","starred_url":"https://api.github.com/users/codenrhoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codenrhoden/subscriptions","organizations_url":"https://api.github.com/users/codenrhoden/orgs","repos_url":"https://api.github.com/users/codenrhoden/repos","events_url":"https://api.github.com/users/codenrhoden/events{/privacy}","received_events_url":"https://api.github.com/users/codenrhoden/received_events","type":"User","site_admin":false},"labels":[{"id":566869462,"url":"https://api.github.com/repos/thecodeteam/rexray/labels/azure","name":"azure","color":"d93f0b","default":false},{"id":733113253,"url":"https://api.github.com/repos/thecodeteam/rexray/labels/bugfix","name":"bugfix","color":"afffed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/thecodeteam/rexray/milestones/28","html_url":"https://github.com/thecodeteam/rexray/milestone/28","labels_url":"https://api.github.com/repos/thecodeteam/rexray/milestones/28/labels","id":2975740,"number":28,"title":"2017.12-2","description":"","creator":{"login":"codenrhoden","id":1627176,"avatar_url":"https://avatars3.githubusercontent.com/u/1627176?v=4","gravatar_id":"","url":"https://api.github.com/users/codenrhoden","html_url":"https://github.com/codenrhoden","followers_url":"https://api.github.com/users/codenrhoden/followers","following_url":"https://api.github.com/users/codenrhoden/following{/other_user}","gists_url":"https://api.github.com/users/codenrhoden/gists{/gist_id}","starred_url":"https://api.github.com/users/codenrhoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codenrhoden/subscriptions","organizations_url":"https://api.github.com/users/codenrhoden/orgs","repos_url":"https://api.github.com/users/codenrhoden/repos","events_url":"https://api.github.com/users/codenrhoden/events{/privacy}","received_events_url":"https://api.github.com/users/codenrhoden/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":5,"state":"open","created_at":"2017-12-12T23:05:13Z","updated_at":"2017-12-14T21:13:17Z","due_on":"2017-12-19T08:00:00Z","closed_at":null},"comments":0,"created_at":"2017-12-14T21:10:30Z","updated_at":"2017-12-14T21:50:19Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/thecodeteam/rexray/pulls/1129","html_url":"https://github.com/thecodeteam/rexray/pull/1129","diff_url":"https://github.com/thecodeteam/rexray/pull/1129.diff","patch_url":"https://github.com/thecodeteam/rexray/pull/1129.patch"},"body":"The AzureUD driver was implemented using NextDevices, which allows a\r\nclient to specify what the next device (e.g. /dev/sdc) on the node is\r\nwhere a block volume should be attached. The Controller code was not\r\nusing this in anyway, and always returning said device as the attach\r\ntoken.\r\n\r\nThe Controller *was* querying the VM via the cloud provider API and\r\ndeterming the next available device from that. These two sources are not\r\nalways consistent.\r\n\r\nInstead, always use the next device info as it is determined from the\r\ncloud provider's API, which is actually using LUNs.\r\n\r\nFixes #1122 \r\nReplaces #1125"},"comment":{"url":"https://api.github.com/repos/thecodeteam/rexray/issues/comments/351846617","html_url":"https://github.com/thecodeteam/rexray/pull/1129#issuecomment-351846617","issue_url":"https://api.github.com/repos/thecodeteam/rexray/issues/1129","id":351846617,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-12-14T21:50:19Z","updated_at":"2017-12-14T21:50:19Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/thecodeteam/rexray/pull/1129?src=pr&el=h1) Report\n> Merging [#1129](https://codecov.io/gh/thecodeteam/rexray/pull/1129?src=pr&el=desc) into [master](https://codecov.io/gh/thecodeteam/rexray/commit/6900fb09c6a9aaf4e15fd1894b934fd32c1a3137?src=pr&el=desc) will **decrease** coverage by `0.29%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/thecodeteam/rexray/pull/1129/graphs/tree.svg?height=150&src=pr&token=B6rKkK2fBl&width=650)](https://codecov.io/gh/thecodeteam/rexray/pull/1129?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff            @@\n##           master    #1129     +/-   ##\n=========================================\n- Coverage   34.54%   34.25%   -0.3%     \n=========================================\n  Files          36       36             \n  Lines        2362     2362             \n=========================================\n- Hits          816      809      -7     \n- Misses       1442     1450      +8     \n+ Partials      104      103      -1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/thecodeteam/rexray/pull/1129?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [...storage/drivers/storage/vfs/storage/vfs\\_storage.go](https://codecov.io/gh/thecodeteam/rexray/pull/1129/diff?src=pr&el=tree#diff-bGlic3RvcmFnZS9kcml2ZXJzL3N0b3JhZ2UvdmZzL3N0b3JhZ2UvdmZzX3N0b3JhZ2UuZ28=) | `39.54% <0%> (-2.62%)` | :arrow_down: |\n| [libstorage/api/types/types\\_localdevices.go](https://codecov.io/gh/thecodeteam/rexray/pull/1129/diff?src=pr&el=tree#diff-bGlic3RvcmFnZS9hcGkvdHlwZXMvdHlwZXNfbG9jYWxkZXZpY2VzLmdv) | `85.96% <0%> (+1.75%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/thecodeteam/rexray/pull/1129?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/thecodeteam/rexray/pull/1129?src=pr&el=footer). Last update [6900fb0...2212d29](https://codecov.io/gh/thecodeteam/rexray/pull/1129?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}