{"action":"created","issue":{"url":"https://api.github.com/repos/twbs/bootstrap/issues/24660","repository_url":"https://api.github.com/repos/twbs/bootstrap","labels_url":"https://api.github.com/repos/twbs/bootstrap/issues/24660/labels{/name}","comments_url":"https://api.github.com/repos/twbs/bootstrap/issues/24660/comments","events_url":"https://api.github.com/repos/twbs/bootstrap/issues/24660/events","html_url":"https://github.com/twbs/bootstrap/pull/24660","id":270959277,"number":24660,"title":"WIP: Simplifies and improves table backgrounds","user":{"login":"andresgalante","id":1832037,"avatar_url":"https://avatars1.githubusercontent.com/u/1832037?v=4","gravatar_id":"","url":"https://api.github.com/users/andresgalante","html_url":"https://github.com/andresgalante","followers_url":"https://api.github.com/users/andresgalante/followers","following_url":"https://api.github.com/users/andresgalante/following{/other_user}","gists_url":"https://api.github.com/users/andresgalante/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgalante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgalante/subscriptions","organizations_url":"https://api.github.com/users/andresgalante/orgs","repos_url":"https://api.github.com/users/andresgalante/repos","events_url":"https://api.github.com/users/andresgalante/events{/privacy}","received_events_url":"https://api.github.com/users/andresgalante/received_events","type":"User","site_admin":false},"labels":[{"id":210556,"url":"https://api.github.com/repos/twbs/bootstrap/labels/css","name":"css","color":"563d7c","default":false},{"id":250176882,"url":"https://api.github.com/repos/twbs/bootstrap/labels/v4","name":"v4","color":"563d7c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-11-03T12:16:25Z","updated_at":"2017-11-06T22:13:01Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/twbs/bootstrap/pulls/24660","html_url":"https://github.com/twbs/bootstrap/pull/24660","diff_url":"https://github.com/twbs/bootstrap/pull/24660.diff","patch_url":"https://github.com/twbs/bootstrap/pull/24660.patch"},"body":"This PR is needs more clean up and better organization, but bare with me.\r\n\r\nThe way we use selectors for background on tables doesn't allow to have a different colors within a row, for example:\r\n```html\r\n    <tr class=\"table-danger\">\r\n        <th scope=\"row\">9</th>\r\n        <td>Column content</td>\r\n        <td class=\"table-warning\">Column content</td>\r\n        <td>Column content</td>\r\n      </tr>\r\n```\r\nIt also doesn't allow to mark something as active like this:\r\n```html\r\n      <tr class=\"table-danger\">\r\n        <th scope=\"row\">9</th>\r\n        <td>Column content</td>\r\n        <td class=\"table-active\">Column content</td>\r\n        <td>Column content</td>\r\n      </tr>\r\n```\r\nor to mark something as active within an active row like this:\r\n```html\r\n      <tr class=\"table-active\">\r\n        <th scope=\"row\">9</th>\r\n        <td>Column content</td>\r\n        <td class=\"table-active\">Column content</td>\r\n        <td>Column content</td>\r\n      </tr>\r\n```\r\n... and it produces issues like the one described on #24529\r\n\r\nBy simplifying the selectors it resolves it and I don't see conflicts with nested tables or `.table-striped`. I tried to digg up the history of this selector but I couldn't find the root.\r\n\r\n@mdo @XhmikosR Can you please point me out what I am missing so I can continue with this PR?\r\n\r\nThanks a lot!\r\n\r\nThis is a WIP but when it's done it will close #24529"},"comment":{"url":"https://api.github.com/repos/twbs/bootstrap/issues/comments/342305451","html_url":"https://github.com/twbs/bootstrap/pull/24660#issuecomment-342305451","issue_url":"https://api.github.com/repos/twbs/bootstrap/issues/24660","id":342305451,"user":{"login":"mdo","id":98681,"avatar_url":"https://avatars3.githubusercontent.com/u/98681?v=4","gravatar_id":"","url":"https://api.github.com/users/mdo","html_url":"https://github.com/mdo","followers_url":"https://api.github.com/users/mdo/followers","following_url":"https://api.github.com/users/mdo/following{/other_user}","gists_url":"https://api.github.com/users/mdo/gists{/gist_id}","starred_url":"https://api.github.com/users/mdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdo/subscriptions","organizations_url":"https://api.github.com/users/mdo/orgs","repos_url":"https://api.github.com/users/mdo/repos","events_url":"https://api.github.com/users/mdo/events{/privacy}","received_events_url":"https://api.github.com/users/mdo/received_events","type":"User","site_admin":true},"created_at":"2017-11-06T22:13:01Z","updated_at":"2017-11-06T22:13:01Z","author_association":"OWNER","body":"Ah, just read the deleted comment again—these don't work with `.table-striped` now.\r\n\r\n<img width=\"871\" alt=\"screen shot 2017-11-06 at 2 02 47 pm\" src=\"https://user-images.githubusercontent.com/98681/32466595-49416d8c-c2fc-11e7-9825-a78fd7e0d03e.png\">"}}
{"actor":{"display_login":"mdo"}}