{"action":"closed","number":869,"pull_request":{"url":"https://api.github.com/repos/Samsung/iotjs/pulls/869","id":122283525,"html_url":"https://github.com/Samsung/iotjs/pull/869","diff_url":"https://github.com/Samsung/iotjs/pull/869.diff","patch_url":"https://github.com/Samsung/iotjs/pull/869.patch","issue_url":"https://api.github.com/repos/Samsung/iotjs/issues/869","number":869,"state":"closed","locked":false,"title":"Rename test_promise.js to test_iotjs_promise.js","user":{"login":"galpeter","id":12067856,"avatar_url":"https://avatars2.githubusercontent.com/u/12067856?v=3","gravatar_id":"","url":"https://api.github.com/users/galpeter","html_url":"https://github.com/galpeter","followers_url":"https://api.github.com/users/galpeter/followers","following_url":"https://api.github.com/users/galpeter/following{/other_user}","gists_url":"https://api.github.com/users/galpeter/gists{/gist_id}","starred_url":"https://api.github.com/users/galpeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galpeter/subscriptions","organizations_url":"https://api.github.com/users/galpeter/orgs","repos_url":"https://api.github.com/users/galpeter/repos","events_url":"https://api.github.com/users/galpeter/events{/privacy}","received_events_url":"https://api.github.com/users/galpeter/received_events","type":"User","site_admin":false},"body":"As per #743 the test_promise.js name for the test\r\nwould expect that the iotjs would be built with\r\npromise iotjs(!) module. However the promise is\r\nnot an iotjs feature but it is provided by the\r\nunderlying JS engine JerryScript. Thus the test\r\nrunner incorrectly returns the reason for skipping\r\nthe test, stating that is not supported by the\r\niotjs build but that is the incorrect message.\r\n\r\nBy renaming the testcase to test_iotjs_promise.js\r\nthe correct skip reason is displayed and will\r\nmake it easier in the future to enable the test case.\r\n\r\nIoT.js-DCO-1.0-Signed-off-by: Peter Gal pgal.u-szeged@partner.samsung.com","created_at":"2017-05-24T17:34:24Z","updated_at":"2017-06-01T04:23:13Z","closed_at":"2017-06-01T04:23:13Z","merged_at":"2017-06-01T04:23:13Z","merge_commit_sha":"2a19b28d50bcc903588ae1e1bfba224ee571257e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/iotjs/pulls/869/commits","review_comments_url":"https://api.github.com/repos/Samsung/iotjs/pulls/869/comments","review_comment_url":"https://api.github.com/repos/Samsung/iotjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/iotjs/issues/869/comments","statuses_url":"https://api.github.com/repos/Samsung/iotjs/statuses/6a33cecb0d10fc25ea2508e80467312e0f7bdf3a","head":{"label":"galpeter:testfix-promise","ref":"testfix-promise","sha":"6a33cecb0d10fc25ea2508e80467312e0f7bdf3a","user":{"login":"galpeter","id":12067856,"avatar_url":"https://avatars2.githubusercontent.com/u/12067856?v=3","gravatar_id":"","url":"https://api.github.com/users/galpeter","html_url":"https://github.com/galpeter","followers_url":"https://api.github.com/users/galpeter/followers","following_url":"https://api.github.com/users/galpeter/following{/other_user}","gists_url":"https://api.github.com/users/galpeter/gists{/gist_id}","starred_url":"https://api.github.com/users/galpeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galpeter/subscriptions","organizations_url":"https://api.github.com/users/galpeter/orgs","repos_url":"https://api.github.com/users/galpeter/repos","events_url":"https://api.github.com/users/galpeter/events{/privacy}","received_events_url":"https://api.github.com/users/galpeter/received_events","type":"User","site_admin":false},"repo":{"id":42716946,"name":"iotjs","full_name":"galpeter/iotjs","owner":{"login":"galpeter","id":12067856,"avatar_url":"https://avatars2.githubusercontent.com/u/12067856?v=3","gravatar_id":"","url":"https://api.github.com/users/galpeter","html_url":"https://github.com/galpeter","followers_url":"https://api.github.com/users/galpeter/followers","following_url":"https://api.github.com/users/galpeter/following{/other_user}","gists_url":"https://api.github.com/users/galpeter/gists{/gist_id}","starred_url":"https://api.github.com/users/galpeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galpeter/subscriptions","organizations_url":"https://api.github.com/users/galpeter/orgs","repos_url":"https://api.github.com/users/galpeter/repos","events_url":"https://api.github.com/users/galpeter/events{/privacy}","received_events_url":"https://api.github.com/users/galpeter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/galpeter/iotjs","description":"Platform for Internet of Things with JavaScript http://www.iotjs.net ","fork":true,"url":"https://api.github.com/repos/galpeter/iotjs","forks_url":"https://api.github.com/repos/galpeter/iotjs/forks","keys_url":"https://api.github.com/repos/galpeter/iotjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galpeter/iotjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galpeter/iotjs/teams","hooks_url":"https://api.github.com/repos/galpeter/iotjs/hooks","issue_events_url":"https://api.github.com/repos/galpeter/iotjs/issues/events{/number}","events_url":"https://api.github.com/repos/galpeter/iotjs/events","assignees_url":"https://api.github.com/repos/galpeter/iotjs/assignees{/user}","branches_url":"https://api.github.com/repos/galpeter/iotjs/branches{/branch}","tags_url":"https://api.github.com/repos/galpeter/iotjs/tags","blobs_url":"https://api.github.com/repos/galpeter/iotjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galpeter/iotjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galpeter/iotjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/galpeter/iotjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galpeter/iotjs/statuses/{sha}","languages_url":"https://api.github.com/repos/galpeter/iotjs/languages","stargazers_url":"https://api.github.com/repos/galpeter/iotjs/stargazers","contributors_url":"https://api.github.com/repos/galpeter/iotjs/contributors","subscribers_url":"https://api.github.com/repos/galpeter/iotjs/subscribers","subscription_url":"https://api.github.com/repos/galpeter/iotjs/subscription","commits_url":"https://api.github.com/repos/galpeter/iotjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/galpeter/iotjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/galpeter/iotjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/galpeter/iotjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/galpeter/iotjs/contents/{+path}","compare_url":"https://api.github.com/repos/galpeter/iotjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galpeter/iotjs/merges","archive_url":"https://api.github.com/repos/galpeter/iotjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galpeter/iotjs/downloads","issues_url":"https://api.github.com/repos/galpeter/iotjs/issues{/number}","pulls_url":"https://api.github.com/repos/galpeter/iotjs/pulls{/number}","milestones_url":"https://api.github.com/repos/galpeter/iotjs/milestones{/number}","notifications_url":"https://api.github.com/repos/galpeter/iotjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galpeter/iotjs/labels{/name}","releases_url":"https://api.github.com/repos/galpeter/iotjs/releases{/id}","deployments_url":"https://api.github.com/repos/galpeter/iotjs/deployments","created_at":"2015-09-18T11:12:33Z","updated_at":"2017-01-10T17:13:57Z","pushed_at":"2017-05-31T10:57:47Z","git_url":"git://github.com/galpeter/iotjs.git","ssh_url":"git@github.com:galpeter/iotjs.git","clone_url":"https://github.com/galpeter/iotjs.git","svn_url":"https://github.com/galpeter/iotjs","homepage":"","size":2923,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"3ffdbc47fbed139b06e0e46cc63f062e910e4787","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars0.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":33589470,"name":"iotjs","full_name":"Samsung/iotjs","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars0.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/iotjs","description":"Platform for Internet of Things with JavaScript http://www.iotjs.net ","fork":false,"url":"https://api.github.com/repos/Samsung/iotjs","forks_url":"https://api.github.com/repos/Samsung/iotjs/forks","keys_url":"https://api.github.com/repos/Samsung/iotjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/iotjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/iotjs/teams","hooks_url":"https://api.github.com/repos/Samsung/iotjs/hooks","issue_events_url":"https://api.github.com/repos/Samsung/iotjs/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/iotjs/events","assignees_url":"https://api.github.com/repos/Samsung/iotjs/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/iotjs/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/iotjs/tags","blobs_url":"https://api.github.com/repos/Samsung/iotjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/iotjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/iotjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/iotjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/iotjs/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/iotjs/languages","stargazers_url":"https://api.github.com/repos/Samsung/iotjs/stargazers","contributors_url":"https://api.github.com/repos/Samsung/iotjs/contributors","subscribers_url":"https://api.github.com/repos/Samsung/iotjs/subscribers","subscription_url":"https://api.github.com/repos/Samsung/iotjs/subscription","commits_url":"https://api.github.com/repos/Samsung/iotjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/iotjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/iotjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/iotjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/iotjs/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/iotjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/iotjs/merges","archive_url":"https://api.github.com/repos/Samsung/iotjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/iotjs/downloads","issues_url":"https://api.github.com/repos/Samsung/iotjs/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/iotjs/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/iotjs/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/iotjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/iotjs/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/iotjs/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/iotjs/deployments","created_at":"2015-04-08T06:41:39Z","updated_at":"2017-05-30T09:57:37Z","pushed_at":"2017-06-01T04:23:13Z","git_url":"git://github.com/Samsung/iotjs.git","ssh_url":"git@github.com:Samsung/iotjs.git","clone_url":"https://github.com/Samsung/iotjs.git","svn_url":"https://github.com/Samsung/iotjs","homepage":"","size":62379,"stargazers_count":1305,"watchers_count":1305,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":232,"mirror_url":null,"open_issues_count":47,"forks":232,"open_issues":47,"watchers":1305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/iotjs/pulls/869"},"html":{"href":"https://github.com/Samsung/iotjs/pull/869"},"issue":{"href":"https://api.github.com/repos/Samsung/iotjs/issues/869"},"comments":{"href":"https://api.github.com/repos/Samsung/iotjs/issues/869/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/iotjs/pulls/869/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/iotjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/iotjs/pulls/869/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/iotjs/statuses/6a33cecb0d10fc25ea2508e80467312e0f7bdf3a"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"yichoi","id":3222276,"avatar_url":"https://avatars2.githubusercontent.com/u/3222276?v=3","gravatar_id":"","url":"https://api.github.com/users/yichoi","html_url":"https://github.com/yichoi","followers_url":"https://api.github.com/users/yichoi/followers","following_url":"https://api.github.com/users/yichoi/following{/other_user}","gists_url":"https://api.github.com/users/yichoi/gists{/gist_id}","starred_url":"https://api.github.com/users/yichoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yichoi/subscriptions","organizations_url":"https://api.github.com/users/yichoi/orgs","repos_url":"https://api.github.com/users/yichoi/repos","events_url":"https://api.github.com/users/yichoi/events{/privacy}","received_events_url":"https://api.github.com/users/yichoi/received_events","type":"User","site_admin":false},"comments":6,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":6,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"yichoi"}}