{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/121782934","pull_request_review_id":43839539,"id":121782934,"diff_hunk":"@@ -192,7 +192,7 @@ public static function menuItemList($name, $selected = null, $attribs = null, $c\n \t\t\t'select.genericlist', $options, $name,\n \t\t\tarray(\n \t\t\t\t'id' => isset($config['id']) ? $config['id'] : 'assetgroups_' . (++$count),\n-\t\t\t\t'list.attr' => (is_null($attribs) ? 'class=\"inputbox\" size=\"1\"' : $attribs),\n+\t\t\t\t'list.attr' => ($attribs === null ? 'class=\"inputbox\" size=\"1\"' : $attribs),","path":"libraries/cms/html/menu.php","position":5,"original_position":5,"commit_id":"cb5ee9390fc5f45bebd2fc57a5e82e4b9d1e295b","original_commit_id":"cb5ee9390fc5f45bebd2fc57a5e82e4b9d1e295b","user":{"login":"Quy","id":368084,"avatar_url":"https://avatars1.githubusercontent.com/u/368084?v=3","gravatar_id":"","url":"https://api.github.com/users/Quy","html_url":"https://github.com/Quy","followers_url":"https://api.github.com/users/Quy/followers","following_url":"https://api.github.com/users/Quy/following{/other_user}","gists_url":"https://api.github.com/users/Quy/gists{/gist_id}","starred_url":"https://api.github.com/users/Quy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quy/subscriptions","organizations_url":"https://api.github.com/users/Quy/orgs","repos_url":"https://api.github.com/users/Quy/repos","events_url":"https://api.github.com/users/Quy/events{/privacy}","received_events_url":"https://api.github.com/users/Quy/received_events","type":"User","site_admin":false},"body":"More reported and I am done for now. :wink:","created_at":"2017-06-13T20:06:35Z","updated_at":"2017-06-13T20:06:35Z","html_url":"https://github.com/joomla/joomla-cms/pull/12171#discussion_r121782934","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12171","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/121782934"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/12171#discussion_r121782934"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12171"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12171","id":86654512,"html_url":"https://github.com/joomla/joomla-cms/pull/12171","diff_url":"https://github.com/joomla/joomla-cms/pull/12171.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/12171.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12171","number":12171,"state":"open","locked":false,"title":"Performance optimizations #1","user":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars1.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"body":"**[UPDATED (5.1.2017) - see second paragraph]**\r\nThose are some performance optimizations for the libraries/cms folder. If you like those, there are plenty more where those came from.\r\nSince I don't know if you guys are open to these kinds of PR's. I am awaiting the developments of my open PR's before I do more.\r\n\r\n**[Update 5.1.2017]**\r\nIn order to lighten this PR up, I have introduced 6 sub-PRs, which are easier to digest and mostly with very specific changes. In order to continue with this one, those ones should be tested/reviewed/merged first. After that, I can resolve the conflicts and there should finally be only a few changes left.\r\n\r\n- [x] 1) Simplify some ternary operations using elvis operator and remove unnecessary parentheses in libraries/cms #13234\r\n- [x] 2) Replace unnecessary double quotes in libraries/cms #13235\r\n- [x] 3) Remove one-time-use variables in libraries/cms #13236\r\n- [x] 4) Various changes in libraries/cms #13238\r\n- [x] 5) Type safe comparison of strings only, in libraries/cms #13275\r\n- [x] 6) Type safe comparison in libraries/cms - second iteration #13276","created_at":"2016-09-25T16:18:28Z","updated_at":"2017-06-13T20:06:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"508cc19ff31a8f5c357ceb5b18171ea118c94965","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12171/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/12171/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/12171/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/cb5ee9390fc5f45bebd2fc57a5e82e4b9d1e295b","head":{"label":"frankmayer:Performance_1","ref":"Performance_1","sha":"cb5ee9390fc5f45bebd2fc57a5e82e4b9d1e295b","user":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars1.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"repo":{"id":69169032,"name":"joomla-cms","full_name":"frankmayer/joomla-cms","owner":{"login":"frankmayer","id":825497,"avatar_url":"https://avatars1.githubusercontent.com/u/825497?v=3","gravatar_id":"","url":"https://api.github.com/users/frankmayer","html_url":"https://github.com/frankmayer","followers_url":"https://api.github.com/users/frankmayer/followers","following_url":"https://api.github.com/users/frankmayer/following{/other_user}","gists_url":"https://api.github.com/users/frankmayer/gists{/gist_id}","starred_url":"https://api.github.com/users/frankmayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankmayer/subscriptions","organizations_url":"https://api.github.com/users/frankmayer/orgs","repos_url":"https://api.github.com/users/frankmayer/repos","events_url":"https://api.github.com/users/frankmayer/events{/privacy}","received_events_url":"https://api.github.com/users/frankmayer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frankmayer/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/frankmayer/joomla-cms","forks_url":"https://api.github.com/repos/frankmayer/joomla-cms/forks","keys_url":"https://api.github.com/repos/frankmayer/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frankmayer/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frankmayer/joomla-cms/teams","hooks_url":"https://api.github.com/repos/frankmayer/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/frankmayer/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/frankmayer/joomla-cms/events","assignees_url":"https://api.github.com/repos/frankmayer/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/frankmayer/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/frankmayer/joomla-cms/tags","blobs_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frankmayer/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/frankmayer/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/frankmayer/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/frankmayer/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/frankmayer/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/frankmayer/joomla-cms/subscription","commits_url":"https://api.github.com/repos/frankmayer/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/frankmayer/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/frankmayer/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/frankmayer/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/frankmayer/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/frankmayer/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frankmayer/joomla-cms/merges","archive_url":"https://api.github.com/repos/frankmayer/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frankmayer/joomla-cms/downloads","issues_url":"https://api.github.com/repos/frankmayer/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/frankmayer/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/frankmayer/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/frankmayer/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frankmayer/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/frankmayer/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/frankmayer/joomla-cms/deployments","created_at":"2016-09-25T14:24:41Z","updated_at":"2016-09-25T14:24:55Z","pushed_at":"2017-06-13T19:46:43Z","git_url":"git://github.com/frankmayer/joomla-cms.git","ssh_url":"git@github.com:frankmayer/joomla-cms.git","clone_url":"https://github.com/frankmayer/joomla-cms.git","svn_url":"https://github.com/frankmayer/joomla-cms","homepage":"https://www.joomla.org","size":178342,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"5aa724ad7a650de795df50af9e05da11c0810e46","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2017-06-13T15:53:31Z","pushed_at":"2017-06-13T19:57:37Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":197230,"stargazers_count":2402,"watchers_count":2402,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2494,"mirror_url":null,"open_issues_count":805,"forks":2494,"open_issues":805,"watchers":2402,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12171"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/12171"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/12171"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/12171/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12171/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/12171/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/cb5ee9390fc5f45bebd2fc57a5e82e4b9d1e295b"}}}}
{"actor":{"display_login":"Quy"}}