{"action":"closed","number":2997,"pull_request":{"url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/2997","id":135885275,"html_url":"https://github.com/department-of-veterans-affairs/caseflow/pull/2997","diff_url":"https://github.com/department-of-veterans-affairs/caseflow/pull/2997.diff","patch_url":"https://github.com/department-of-veterans-affairs/caseflow/pull/2997.patch","issue_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/2997","number":2997,"state":"closed","locked":false,"title":"Fix PDF hang on eFolder integration ","user":{"login":"mdbenjam","id":3885236,"avatar_url":"https://avatars1.githubusercontent.com/u/3885236?v=4","gravatar_id":"","url":"https://api.github.com/users/mdbenjam","html_url":"https://github.com/mdbenjam","followers_url":"https://api.github.com/users/mdbenjam/followers","following_url":"https://api.github.com/users/mdbenjam/following{/other_user}","gists_url":"https://api.github.com/users/mdbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/mdbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdbenjam/subscriptions","organizations_url":"https://api.github.com/users/mdbenjam/orgs","repos_url":"https://api.github.com/users/mdbenjam/repos","events_url":"https://api.github.com/users/mdbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/mdbenjam/received_events","type":"User","site_admin":false},"body":"Connects: #2960 \r\n\r\nCurrently when we turn on the eFolder integration, EVERYTHING HANGS when switching PDFs. After some digging we found that lodash's omit function accepts keys to omit, or paths to omit (where a path is defined with `.`). The idea being that you can deep omit into a nested object.\r\n\r\nThis worked fine with our old pdf urls since they were local and didn't contain the part of the URL with `.`. But when we move to eFolder we needed an absolute url which started with `efolder.` This matched the regex they use to determine if we are specifying a path, which triggered a deep clone of the object. Deep cloning this particular object takes a long time since the PDF objects are really big!\r\n\r\nThis was a breaking change introduced last year: https://github.com/lodash/lodash/pull/2794\r\n\r\n**Test Plan**\r\n- [ ] Monkey patched in UAT, verified that switching PDFs was fast.\r\n- [ ] Added a breakpoint in the cleanupPdf code locally to ensure it was still being called.","created_at":"2017-08-15T20:32:52Z","updated_at":"2017-08-16T17:00:48Z","closed_at":"2017-08-16T17:00:47Z","merged_at":"2017-08-16T17:00:47Z","merge_commit_sha":"eb2746528dee055547045af02677da79da2c7439","assignee":{"login":"amprokop","id":3781835,"avatar_url":"https://avatars0.githubusercontent.com/u/3781835?v=4","gravatar_id":"","url":"https://api.github.com/users/amprokop","html_url":"https://github.com/amprokop","followers_url":"https://api.github.com/users/amprokop/followers","following_url":"https://api.github.com/users/amprokop/following{/other_user}","gists_url":"https://api.github.com/users/amprokop/gists{/gist_id}","starred_url":"https://api.github.com/users/amprokop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amprokop/subscriptions","organizations_url":"https://api.github.com/users/amprokop/orgs","repos_url":"https://api.github.com/users/amprokop/repos","events_url":"https://api.github.com/users/amprokop/events{/privacy}","received_events_url":"https://api.github.com/users/amprokop/received_events","type":"User","site_admin":false},"assignees":[{"login":"amprokop","id":3781835,"avatar_url":"https://avatars0.githubusercontent.com/u/3781835?v=4","gravatar_id":"","url":"https://api.github.com/users/amprokop","html_url":"https://github.com/amprokop","followers_url":"https://api.github.com/users/amprokop/followers","following_url":"https://api.github.com/users/amprokop/following{/other_user}","gists_url":"https://api.github.com/users/amprokop/gists{/gist_id}","starred_url":"https://api.github.com/users/amprokop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amprokop/subscriptions","organizations_url":"https://api.github.com/users/amprokop/orgs","repos_url":"https://api.github.com/users/amprokop/repos","events_url":"https://api.github.com/users/amprokop/events{/privacy}","received_events_url":"https://api.github.com/users/amprokop/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/2997/commits","review_comments_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/2997/comments","review_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/2997/comments","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/statuses/81418962b8ea01925cbc959ab49ebaeee94d10df","head":{"label":"department-of-veterans-affairs:mdbenjam-fix-hang","ref":"mdbenjam-fix-hang","sha":"81418962b8ea01925cbc959ab49ebaeee94d10df","user":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":51449239,"name":"caseflow","full_name":"department-of-veterans-affairs/caseflow","owner":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/caseflow","description":"Caseflow is a web application that enables the tracking and processing of appealed claims at the Board of Veterans' Appeals.","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/deployments","created_at":"2016-02-10T15:20:50Z","updated_at":"2017-07-25T23:59:32Z","pushed_at":"2017-08-16T17:00:47Z","git_url":"git://github.com/department-of-veterans-affairs/caseflow.git","ssh_url":"git@github.com:department-of-veterans-affairs/caseflow.git","clone_url":"https://github.com/department-of-veterans-affairs/caseflow.git","svn_url":"https://github.com/department-of-veterans-affairs/caseflow","homepage":"","size":32029,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":443,"forks":17,"open_issues":443,"watchers":27,"default_branch":"master"}},"base":{"label":"department-of-veterans-affairs:master","ref":"master","sha":"caa318be5b7d20771eb05d59e05c9d362fa2c6d9","user":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"repo":{"id":51449239,"name":"caseflow","full_name":"department-of-veterans-affairs/caseflow","owner":{"login":"department-of-veterans-affairs","id":5421563,"avatar_url":"https://avatars1.githubusercontent.com/u/5421563?v=4","gravatar_id":"","url":"https://api.github.com/users/department-of-veterans-affairs","html_url":"https://github.com/department-of-veterans-affairs","followers_url":"https://api.github.com/users/department-of-veterans-affairs/followers","following_url":"https://api.github.com/users/department-of-veterans-affairs/following{/other_user}","gists_url":"https://api.github.com/users/department-of-veterans-affairs/gists{/gist_id}","starred_url":"https://api.github.com/users/department-of-veterans-affairs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/department-of-veterans-affairs/subscriptions","organizations_url":"https://api.github.com/users/department-of-veterans-affairs/orgs","repos_url":"https://api.github.com/users/department-of-veterans-affairs/repos","events_url":"https://api.github.com/users/department-of-veterans-affairs/events{/privacy}","received_events_url":"https://api.github.com/users/department-of-veterans-affairs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/department-of-veterans-affairs/caseflow","description":"Caseflow is a web application that enables the tracking and processing of appealed claims at the Board of Veterans' Appeals.","fork":false,"url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow","forks_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/forks","keys_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/teams","hooks_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/hooks","issue_events_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/events{/number}","events_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/events","assignees_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/assignees{/user}","branches_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/branches{/branch}","tags_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/tags","blobs_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/statuses/{sha}","languages_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/languages","stargazers_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/stargazers","contributors_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/contributors","subscribers_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/subscribers","subscription_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/subscription","commits_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/contents/{+path}","compare_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/merges","archive_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/downloads","issues_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues{/number}","pulls_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls{/number}","milestones_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/milestones{/number}","notifications_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/labels{/name}","releases_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/releases{/id}","deployments_url":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/deployments","created_at":"2016-02-10T15:20:50Z","updated_at":"2017-07-25T23:59:32Z","pushed_at":"2017-08-16T17:00:47Z","git_url":"git://github.com/department-of-veterans-affairs/caseflow.git","ssh_url":"git@github.com:department-of-veterans-affairs/caseflow.git","clone_url":"https://github.com/department-of-veterans-affairs/caseflow.git","svn_url":"https://github.com/department-of-veterans-affairs/caseflow","homepage":"","size":32029,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":443,"forks":17,"open_issues":443,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/2997"},"html":{"href":"https://github.com/department-of-veterans-affairs/caseflow/pull/2997"},"issue":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/2997"},"comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/issues/2997/comments"},"review_comments":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/2997/comments"},"review_comment":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/pulls/2997/commits"},"statuses":{"href":"https://api.github.com/repos/department-of-veterans-affairs/caseflow/statuses/81418962b8ea01925cbc959ab49ebaeee94d10df"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mdbenjam","id":3885236,"avatar_url":"https://avatars1.githubusercontent.com/u/3885236?v=4","gravatar_id":"","url":"https://api.github.com/users/mdbenjam","html_url":"https://github.com/mdbenjam","followers_url":"https://api.github.com/users/mdbenjam/followers","following_url":"https://api.github.com/users/mdbenjam/following{/other_user}","gists_url":"https://api.github.com/users/mdbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/mdbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdbenjam/subscriptions","organizations_url":"https://api.github.com/users/mdbenjam/orgs","repos_url":"https://api.github.com/users/mdbenjam/repos","events_url":"https://api.github.com/users/mdbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/mdbenjam/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":5,"additions":6,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"mdbenjam"}}