{"action":"closed","number":18317,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/18317","id":125920744,"html_url":"https://github.com/apache/spark/pull/18317","diff_url":"https://github.com/apache/spark/pull/18317.diff","patch_url":"https://github.com/apache/spark/pull/18317.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/18317","number":18317,"state":"closed","locked":false,"title":"[SPARK-21113][CORE] Read ahead input stream to amortize disk IO cost …","user":{"login":"sitalkedia","id":11507549,"avatar_url":"https://avatars2.githubusercontent.com/u/11507549?v=4","gravatar_id":"","url":"https://api.github.com/users/sitalkedia","html_url":"https://github.com/sitalkedia","followers_url":"https://api.github.com/users/sitalkedia/followers","following_url":"https://api.github.com/users/sitalkedia/following{/other_user}","gists_url":"https://api.github.com/users/sitalkedia/gists{/gist_id}","starred_url":"https://api.github.com/users/sitalkedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitalkedia/subscriptions","organizations_url":"https://api.github.com/users/sitalkedia/orgs","repos_url":"https://api.github.com/users/sitalkedia/repos","events_url":"https://api.github.com/users/sitalkedia/events{/privacy}","received_events_url":"https://api.github.com/users/sitalkedia/received_events","type":"User","site_admin":false},"body":"Profiling some of our big jobs, we see that around 30% of the time is being spent in reading the spill files from disk. In order to amortize the disk IO cost, the idea is to implement a read ahead input stream which asynchronously reads ahead from the underlying input stream when specified amount of data has been read from the current buffer. It does it by maintaining two buffer - active buffer and read ahead buffer. The active buffer contains data which should be returned when a read() call is issued. The read-ahead buffer is used to asynchronously read from the underlying input stream and once the active buffer is exhausted, we flip the two buffers so that we can start reading from the read ahead buffer without being blocked in disk I/O.\r\n\r\n## How was this patch tested?\r\n\r\nTested by running a job on the cluster and could see up to 8% CPU improvement. \r\n","created_at":"2017-06-15T21:56:14Z","updated_at":"2017-09-18T06:17:48Z","closed_at":"2017-09-18T06:17:48Z","merged_at":null,"merge_commit_sha":"de1f100a52106d4a62e32ec35b6f0d1a302c436f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/18317/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/18317/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/18317/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/884c9d76f30531f3737d2eacca25d3d02cc4ceaa","head":{"label":"sitalkedia:read_ahead_buffer","ref":"read_ahead_buffer","sha":"884c9d76f30531f3737d2eacca25d3d02cc4ceaa","user":{"login":"sitalkedia","id":11507549,"avatar_url":"https://avatars2.githubusercontent.com/u/11507549?v=4","gravatar_id":"","url":"https://api.github.com/users/sitalkedia","html_url":"https://github.com/sitalkedia","followers_url":"https://api.github.com/users/sitalkedia/followers","following_url":"https://api.github.com/users/sitalkedia/following{/other_user}","gists_url":"https://api.github.com/users/sitalkedia/gists{/gist_id}","starred_url":"https://api.github.com/users/sitalkedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitalkedia/subscriptions","organizations_url":"https://api.github.com/users/sitalkedia/orgs","repos_url":"https://api.github.com/users/sitalkedia/repos","events_url":"https://api.github.com/users/sitalkedia/events{/privacy}","received_events_url":"https://api.github.com/users/sitalkedia/received_events","type":"User","site_admin":false},"repo":{"id":51496876,"name":"spark","full_name":"sitalkedia/spark","owner":{"login":"sitalkedia","id":11507549,"avatar_url":"https://avatars2.githubusercontent.com/u/11507549?v=4","gravatar_id":"","url":"https://api.github.com/users/sitalkedia","html_url":"https://github.com/sitalkedia","followers_url":"https://api.github.com/users/sitalkedia/followers","following_url":"https://api.github.com/users/sitalkedia/following{/other_user}","gists_url":"https://api.github.com/users/sitalkedia/gists{/gist_id}","starred_url":"https://api.github.com/users/sitalkedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sitalkedia/subscriptions","organizations_url":"https://api.github.com/users/sitalkedia/orgs","repos_url":"https://api.github.com/users/sitalkedia/repos","events_url":"https://api.github.com/users/sitalkedia/events{/privacy}","received_events_url":"https://api.github.com/users/sitalkedia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sitalkedia/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/sitalkedia/spark","forks_url":"https://api.github.com/repos/sitalkedia/spark/forks","keys_url":"https://api.github.com/repos/sitalkedia/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sitalkedia/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sitalkedia/spark/teams","hooks_url":"https://api.github.com/repos/sitalkedia/spark/hooks","issue_events_url":"https://api.github.com/repos/sitalkedia/spark/issues/events{/number}","events_url":"https://api.github.com/repos/sitalkedia/spark/events","assignees_url":"https://api.github.com/repos/sitalkedia/spark/assignees{/user}","branches_url":"https://api.github.com/repos/sitalkedia/spark/branches{/branch}","tags_url":"https://api.github.com/repos/sitalkedia/spark/tags","blobs_url":"https://api.github.com/repos/sitalkedia/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sitalkedia/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sitalkedia/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/sitalkedia/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sitalkedia/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/sitalkedia/spark/languages","stargazers_url":"https://api.github.com/repos/sitalkedia/spark/stargazers","contributors_url":"https://api.github.com/repos/sitalkedia/spark/contributors","subscribers_url":"https://api.github.com/repos/sitalkedia/spark/subscribers","subscription_url":"https://api.github.com/repos/sitalkedia/spark/subscription","commits_url":"https://api.github.com/repos/sitalkedia/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/sitalkedia/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/sitalkedia/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/sitalkedia/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/sitalkedia/spark/contents/{+path}","compare_url":"https://api.github.com/repos/sitalkedia/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sitalkedia/spark/merges","archive_url":"https://api.github.com/repos/sitalkedia/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sitalkedia/spark/downloads","issues_url":"https://api.github.com/repos/sitalkedia/spark/issues{/number}","pulls_url":"https://api.github.com/repos/sitalkedia/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/sitalkedia/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/sitalkedia/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sitalkedia/spark/labels{/name}","releases_url":"https://api.github.com/repos/sitalkedia/spark/releases{/id}","deployments_url":"https://api.github.com/repos/sitalkedia/spark/deployments","created_at":"2016-02-11T05:53:19Z","updated_at":"2016-02-11T05:53:45Z","pushed_at":"2017-09-13T23:30:10Z","git_url":"git://github.com/sitalkedia/spark.git","ssh_url":"git@github.com:sitalkedia/spark.git","clone_url":"https://github.com/sitalkedia/spark.git","svn_url":"https://github.com/sitalkedia/spark","homepage":null,"size":251284,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a18d637112b97d2caaca0a8324bdd99086664b24","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-09-18T06:07:46Z","pushed_at":"2017-09-18T06:15:29Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":262679,"stargazers_count":14340,"watchers_count":14340,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13423,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":387,"forks":13423,"open_issues":387,"watchers":14340,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/18317"},"html":{"href":"https://github.com/apache/spark/pull/18317"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/18317"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/18317/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/18317/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/18317/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/884c9d76f30531f3737d2eacca25d3d02cc4ceaa"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":36,"review_comments":94,"maintainer_can_modify":false,"commits":21,"additions":495,"deletions":13,"changed_files":5}}
{"actor":{"display_login":"asfgit"}}