{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/heron/pulls/comments/118111493","pull_request_review_id":39874049,"id":118111493,"diff_hunk":"@@ -244,6 +244,18 @@ protected String formatJavaOpts(String javaOpts) {\n     auroraProperties.put(AuroraField.METRICSCACHEMGR_CLASSPATH,\n         Context.metricsCacheManagerClassPath(config));\n \n+    boolean isStatefulEnabled = TopologyUtils.getConfigWithDefault(\n+        topology.getTopologyConfig().getKvsList(),\n+        com.twitter.heron.api.Config.TOPOLOGY_STATEFUL_ENABLED, false);\n+    auroraProperties.put(AuroraField.IS_STATEFUL_ENABLED, Boolean.toString(isStatefulEnabled));\n+\n+    String completeCkptmgrProcessClassPath = String.format(\"%s:%s:%s\",\n+        Context.ckptmgrClassPath(config),\n+        Context.statefulStoragesClassPath(config),\n+        Context.statefulStorageCustomClassPath(config));\n+    auroraProperties.put(AuroraField.CKPTMGR_CLASSPATH, completeCkptmgrProcessClassPath);\n+    auroraProperties.put(AuroraField.STATEFUL_YAML, Context.statefulFile(config));","path":"heron/schedulers/src/java/com/twitter/heron/scheduler/aurora/AuroraScheduler.java","position":14,"original_position":14,"commit_id":"b1d54c4744a178dc57e5322b2270bc3d6572abda","original_commit_id":"b1d54c4744a178dc57e5322b2270bc3d6572abda","user":{"login":"nlu90","id":16407807,"avatar_url":"https://avatars3.githubusercontent.com/u/16407807?v=3","gravatar_id":"","url":"https://api.github.com/users/nlu90","html_url":"https://github.com/nlu90","followers_url":"https://api.github.com/users/nlu90/followers","following_url":"https://api.github.com/users/nlu90/following{/other_user}","gists_url":"https://api.github.com/users/nlu90/gists{/gist_id}","starred_url":"https://api.github.com/users/nlu90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlu90/subscriptions","organizations_url":"https://api.github.com/users/nlu90/orgs","repos_url":"https://api.github.com/users/nlu90/repos","events_url":"https://api.github.com/users/nlu90/events{/privacy}","received_events_url":"https://api.github.com/users/nlu90/received_events","type":"User","site_admin":false},"body":"For both.\r\n\r\nFor ckptmgr, it specifies the network opts and the storage class name\r\n\r\nFor stateful storage implementation, it specifies the config based on the implementation.","created_at":"2017-05-23T21:29:07Z","updated_at":"2017-05-23T21:29:08Z","html_url":"https://github.com/twitter/heron/pull/1885#discussion_r118111493","pull_request_url":"https://api.github.com/repos/twitter/heron/pulls/1885","_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments/118111493"},"html":{"href":"https://github.com/twitter/heron/pull/1885#discussion_r118111493"},"pull_request":{"href":"https://api.github.com/repos/twitter/heron/pulls/1885"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/heron/pulls/1885","id":121865616,"html_url":"https://github.com/twitter/heron/pull/1885","diff_url":"https://github.com/twitter/heron/pull/1885.diff","patch_url":"https://github.com/twitter/heron/pull/1885.patch","issue_url":"https://api.github.com/repos/twitter/heron/issues/1885","number":1885,"state":"open","locked":false,"title":"start ckptmgr in heron_executor if topology is stateful","user":{"login":"nlu90","id":16407807,"avatar_url":"https://avatars3.githubusercontent.com/u/16407807?v=3","gravatar_id":"","url":"https://api.github.com/users/nlu90","html_url":"https://github.com/nlu90","followers_url":"https://api.github.com/users/nlu90/followers","following_url":"https://api.github.com/users/nlu90/following{/other_user}","gists_url":"https://api.github.com/users/nlu90/gists{/gist_id}","starred_url":"https://api.github.com/users/nlu90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlu90/subscriptions","organizations_url":"https://api.github.com/users/nlu90/orgs","repos_url":"https://api.github.com/users/nlu90/repos","events_url":"https://api.github.com/users/nlu90/events{/privacy}","received_events_url":"https://api.github.com/users/nlu90/received_events","type":"User","site_admin":false},"body":"This PR updates the heron_executor to start ckptmgr if the topology is stateful enabled. \r\nIt also updates the schedulers to generate the new heron_executor cmd. \r\n\r\nEach scheduler is updated in a separate commit. For `LocalScheduler`, `Mesos Scheduler`, `Slurm Scheduler` and `YarnScheduler`, they share the util method in `SchedulerUtils` to generate the correct command. So they don't need special updates.\r\n\r\nAll unit test passed and local scheduler is tested.\r\n\r\n","created_at":"2017-05-22T21:07:01Z","updated_at":"2017-05-23T21:29:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d58f4ae949b35aa0f81e7f8473bdcbc8df0a4fc3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"maosongfu","id":3028698,"avatar_url":"https://avatars1.githubusercontent.com/u/3028698?v=3","gravatar_id":"","url":"https://api.github.com/users/maosongfu","html_url":"https://github.com/maosongfu","followers_url":"https://api.github.com/users/maosongfu/followers","following_url":"https://api.github.com/users/maosongfu/following{/other_user}","gists_url":"https://api.github.com/users/maosongfu/gists{/gist_id}","starred_url":"https://api.github.com/users/maosongfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maosongfu/subscriptions","organizations_url":"https://api.github.com/users/maosongfu/orgs","repos_url":"https://api.github.com/users/maosongfu/repos","events_url":"https://api.github.com/users/maosongfu/events{/privacy}","received_events_url":"https://api.github.com/users/maosongfu/received_events","type":"User","site_admin":false},{"login":"ashvina","id":10034060,"avatar_url":"https://avatars2.githubusercontent.com/u/10034060?v=3","gravatar_id":"","url":"https://api.github.com/users/ashvina","html_url":"https://github.com/ashvina","followers_url":"https://api.github.com/users/ashvina/followers","following_url":"https://api.github.com/users/ashvina/following{/other_user}","gists_url":"https://api.github.com/users/ashvina/gists{/gist_id}","starred_url":"https://api.github.com/users/ashvina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashvina/subscriptions","organizations_url":"https://api.github.com/users/ashvina/orgs","repos_url":"https://api.github.com/users/ashvina/repos","events_url":"https://api.github.com/users/ashvina/events{/privacy}","received_events_url":"https://api.github.com/users/ashvina/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/twitter/heron/pulls/1885/commits","review_comments_url":"https://api.github.com/repos/twitter/heron/pulls/1885/comments","review_comment_url":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/heron/issues/1885/comments","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/b1d54c4744a178dc57e5322b2270bc3d6572abda","head":{"label":"nlu90:neng/ext1_start_ckptmgr","ref":"neng/ext1_start_ckptmgr","sha":"b1d54c4744a178dc57e5322b2270bc3d6572abda","user":{"login":"nlu90","id":16407807,"avatar_url":"https://avatars3.githubusercontent.com/u/16407807?v=3","gravatar_id":"","url":"https://api.github.com/users/nlu90","html_url":"https://github.com/nlu90","followers_url":"https://api.github.com/users/nlu90/followers","following_url":"https://api.github.com/users/nlu90/following{/other_user}","gists_url":"https://api.github.com/users/nlu90/gists{/gist_id}","starred_url":"https://api.github.com/users/nlu90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlu90/subscriptions","organizations_url":"https://api.github.com/users/nlu90/orgs","repos_url":"https://api.github.com/users/nlu90/repos","events_url":"https://api.github.com/users/nlu90/events{/privacy}","received_events_url":"https://api.github.com/users/nlu90/received_events","type":"User","site_admin":false},"repo":{"id":59691090,"name":"heron","full_name":"nlu90/heron","owner":{"login":"nlu90","id":16407807,"avatar_url":"https://avatars3.githubusercontent.com/u/16407807?v=3","gravatar_id":"","url":"https://api.github.com/users/nlu90","html_url":"https://github.com/nlu90","followers_url":"https://api.github.com/users/nlu90/followers","following_url":"https://api.github.com/users/nlu90/following{/other_user}","gists_url":"https://api.github.com/users/nlu90/gists{/gist_id}","starred_url":"https://api.github.com/users/nlu90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlu90/subscriptions","organizations_url":"https://api.github.com/users/nlu90/orgs","repos_url":"https://api.github.com/users/nlu90/repos","events_url":"https://api.github.com/users/nlu90/events{/privacy}","received_events_url":"https://api.github.com/users/nlu90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nlu90/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":true,"url":"https://api.github.com/repos/nlu90/heron","forks_url":"https://api.github.com/repos/nlu90/heron/forks","keys_url":"https://api.github.com/repos/nlu90/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nlu90/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nlu90/heron/teams","hooks_url":"https://api.github.com/repos/nlu90/heron/hooks","issue_events_url":"https://api.github.com/repos/nlu90/heron/issues/events{/number}","events_url":"https://api.github.com/repos/nlu90/heron/events","assignees_url":"https://api.github.com/repos/nlu90/heron/assignees{/user}","branches_url":"https://api.github.com/repos/nlu90/heron/branches{/branch}","tags_url":"https://api.github.com/repos/nlu90/heron/tags","blobs_url":"https://api.github.com/repos/nlu90/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nlu90/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nlu90/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/nlu90/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nlu90/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/nlu90/heron/languages","stargazers_url":"https://api.github.com/repos/nlu90/heron/stargazers","contributors_url":"https://api.github.com/repos/nlu90/heron/contributors","subscribers_url":"https://api.github.com/repos/nlu90/heron/subscribers","subscription_url":"https://api.github.com/repos/nlu90/heron/subscription","commits_url":"https://api.github.com/repos/nlu90/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/nlu90/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/nlu90/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/nlu90/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/nlu90/heron/contents/{+path}","compare_url":"https://api.github.com/repos/nlu90/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nlu90/heron/merges","archive_url":"https://api.github.com/repos/nlu90/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nlu90/heron/downloads","issues_url":"https://api.github.com/repos/nlu90/heron/issues{/number}","pulls_url":"https://api.github.com/repos/nlu90/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/nlu90/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/nlu90/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nlu90/heron/labels{/name}","releases_url":"https://api.github.com/repos/nlu90/heron/releases{/id}","deployments_url":"https://api.github.com/repos/nlu90/heron/deployments","created_at":"2016-05-25T19:19:26Z","updated_at":"2016-05-25T19:19:29Z","pushed_at":"2017-05-23T18:17:08Z","git_url":"git://github.com/nlu90/heron.git","ssh_url":"git@github.com:nlu90/heron.git","clone_url":"https://github.com/nlu90/heron.git","svn_url":"https://github.com/nlu90/heron","homepage":"http://heronstreaming.io","size":111161,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"053c77c74cc9f912539388de8dfc6a1d09da0a3c","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars2.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":43158694,"name":"heron","full_name":"twitter/heron","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars2.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":false,"url":"https://api.github.com/repos/twitter/heron","forks_url":"https://api.github.com/repos/twitter/heron/forks","keys_url":"https://api.github.com/repos/twitter/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/heron/teams","hooks_url":"https://api.github.com/repos/twitter/heron/hooks","issue_events_url":"https://api.github.com/repos/twitter/heron/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/heron/events","assignees_url":"https://api.github.com/repos/twitter/heron/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/heron/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/heron/tags","blobs_url":"https://api.github.com/repos/twitter/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/heron/languages","stargazers_url":"https://api.github.com/repos/twitter/heron/stargazers","contributors_url":"https://api.github.com/repos/twitter/heron/contributors","subscribers_url":"https://api.github.com/repos/twitter/heron/subscribers","subscription_url":"https://api.github.com/repos/twitter/heron/subscription","commits_url":"https://api.github.com/repos/twitter/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/heron/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/heron/merges","archive_url":"https://api.github.com/repos/twitter/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/heron/downloads","issues_url":"https://api.github.com/repos/twitter/heron/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/heron/labels{/name}","releases_url":"https://api.github.com/repos/twitter/heron/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/heron/deployments","created_at":"2015-09-25T16:09:24Z","updated_at":"2017-05-23T14:42:00Z","pushed_at":"2017-05-23T21:01:01Z","git_url":"git://github.com/twitter/heron.git","ssh_url":"git@github.com:twitter/heron.git","clone_url":"https://github.com/twitter/heron.git","svn_url":"https://github.com/twitter/heron","homepage":"http://heronstreaming.io","size":130567,"stargazers_count":2713,"watchers_count":2713,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":475,"mirror_url":null,"open_issues_count":263,"forks":475,"open_issues":263,"watchers":2713,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/1885"},"html":{"href":"https://github.com/twitter/heron/pull/1885"},"issue":{"href":"https://api.github.com/repos/twitter/heron/issues/1885"},"comments":{"href":"https://api.github.com/repos/twitter/heron/issues/1885/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/heron/pulls/1885/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/heron/pulls/1885/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/heron/statuses/b1d54c4744a178dc57e5322b2270bc3d6572abda"}}}}
{"actor":{"display_login":"nlu90"}}