{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node-report/pulls/comments/100629629","pull_request_review_id":21347790,"id":100629629,"diff_hunk":"@@ -18,7 +18,9 @@\n     \"Richard Chamberlain <richard_chamberlain@uk.ibm.com> (https://github.com/rnchamberlain)\"\n   ],\n   \"scripts\": {\n-    \"test\": \"tap test/test*.js\"\n+    \"test\": \"npm run lint && npm run tap\",\n+    \"tap\": \"tap --timeout 10 test/test*.js\",\n+    \"lint\": \"python cpplint.py **/*.cc **/*.h\"","path":"package.json","position":7,"original_position":7,"commit_id":"5bd83f0ef4d35e3839637edf8067683b22383793","original_commit_id":"5bd83f0ef4d35e3839637edf8067683b22383793","user":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"body":"Sorry, just realized, this should be:\r\n\r\n```\r\n   \"test\": \"tap --timeout 10 test/test*.js\",\r\n   \"pretest\": \"python cpplint.py **/*.cc **/*.h\"\r\n```\r\n\r\nAnd the tap timeout change is unrelated to this PR, shouldn't it be a different PR?","created_at":"2017-02-10T21:39:35Z","updated_at":"2017-02-10T21:39:41Z","html_url":"https://github.com/nodejs/node-report/pull/47#discussion_r100629629","pull_request_url":"https://api.github.com/repos/nodejs/node-report/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node-report/pulls/comments/100629629"},"html":{"href":"https://github.com/nodejs/node-report/pull/47#discussion_r100629629"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node-report/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node-report/pulls/47","id":103144688,"html_url":"https://github.com/nodejs/node-report/pull/47","diff_url":"https://github.com/nodejs/node-report/pull/47.diff","patch_url":"https://github.com/nodejs/node-report/pull/47.patch","issue_url":"https://api.github.com/repos/nodejs/node-report/issues/47","number":47,"state":"open","locked":false,"title":"linter: add cpplint","user":{"login":"gdams","id":20224954,"avatar_url":"https://avatars.githubusercontent.com/u/20224954?v=3","gravatar_id":"","url":"https://api.github.com/users/gdams","html_url":"https://github.com/gdams","followers_url":"https://api.github.com/users/gdams/followers","following_url":"https://api.github.com/users/gdams/following{/other_user}","gists_url":"https://api.github.com/users/gdams/gists{/gist_id}","starred_url":"https://api.github.com/users/gdams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdams/subscriptions","organizations_url":"https://api.github.com/users/gdams/orgs","repos_url":"https://api.github.com/users/gdams/repos","events_url":"https://api.github.com/users/gdams/events{/privacy}","received_events_url":"https://api.github.com/users/gdams/received_events","type":"User","site_admin":false},"body":"This PR adds cpplint to linter all the c/c++ files. It can be run from\r\n`npm test` or directly from `npm run lint`. There are still a few linter errors which I have included below:\r\n```\r\n\r\n ✗ src/module.cc\r\n   3: Include the directory when naming .h files\r\n   16: Using C-style cast.  Use static_cast<int>(...) instead\r\n   266: Using C-style cast.  Use static_cast<int>(...) instead\r\n ✗ src/node_report.cc\r\n   2: Include the directory when naming .h files\r\n   15: Include the directory when naming .h files\r\n   16: Include the directory when naming .h files\r\n   365: Using C-style cast.  Use reinterpret_cast<char ***>(...) instead\r\n   589: Using C-style cast.  Use reinterpret_cast<LPBYTE *>(...) instead\r\n   1038: Storage class (static, extern, typedef, etc) should be first.\r\n   1096: Using C-style cast.  Use reinterpret_cast<FILE*>(...) instead\r\n   1120: Using C-style cast.  Use reinterpret_cast<char*>(...) instead\r\n   1129: Using C-style cast.  Use reinterpret_cast<char*>(...) instead\r\n   1138: Using C-style cast.  Use reinterpret_cast<ld_info*>(...) instead\r\n   1164: Using C-style cast.  Use reinterpret_cast<HMODULE*>(...) instead\r\n   364: Add #include <string> for string\r\n ✗ src/node_report.h\r\n   5: Include the directory when naming .h files\r\n   7: Found C system header after other header. Should be: node_report.h, c system, c++ system, other.\r\n   8: Found C system header after other header. Should be: node_report.h, c system, c++ system, other.\r\n   10: Found C system header after other header. Should be: node_report.h, c system, c++ system, other.\r\n```","created_at":"2017-01-25T15:45:28Z","updated_at":"2017-02-10T21:39:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd675491ce4ae99c86144c0181e2f70ccb07f5d5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node-report/pulls/47/commits","review_comments_url":"https://api.github.com/repos/nodejs/node-report/pulls/47/comments","review_comment_url":"https://api.github.com/repos/nodejs/node-report/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node-report/issues/47/comments","statuses_url":"https://api.github.com/repos/nodejs/node-report/statuses/5bd83f0ef4d35e3839637edf8067683b22383793","head":{"label":"gdams:cpplint","ref":"cpplint","sha":"5bd83f0ef4d35e3839637edf8067683b22383793","user":{"login":"gdams","id":20224954,"avatar_url":"https://avatars.githubusercontent.com/u/20224954?v=3","gravatar_id":"","url":"https://api.github.com/users/gdams","html_url":"https://github.com/gdams","followers_url":"https://api.github.com/users/gdams/followers","following_url":"https://api.github.com/users/gdams/following{/other_user}","gists_url":"https://api.github.com/users/gdams/gists{/gist_id}","starred_url":"https://api.github.com/users/gdams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdams/subscriptions","organizations_url":"https://api.github.com/users/gdams/orgs","repos_url":"https://api.github.com/users/gdams/repos","events_url":"https://api.github.com/users/gdams/events{/privacy}","received_events_url":"https://api.github.com/users/gdams/received_events","type":"User","site_admin":false},"repo":{"id":78762524,"name":"nodereport","full_name":"gdams/nodereport","owner":{"login":"gdams","id":20224954,"avatar_url":"https://avatars.githubusercontent.com/u/20224954?v=3","gravatar_id":"","url":"https://api.github.com/users/gdams","html_url":"https://github.com/gdams","followers_url":"https://api.github.com/users/gdams/followers","following_url":"https://api.github.com/users/gdams/following{/other_user}","gists_url":"https://api.github.com/users/gdams/gists{/gist_id}","starred_url":"https://api.github.com/users/gdams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdams/subscriptions","organizations_url":"https://api.github.com/users/gdams/orgs","repos_url":"https://api.github.com/users/gdams/repos","events_url":"https://api.github.com/users/gdams/events{/privacy}","received_events_url":"https://api.github.com/users/gdams/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdams/nodereport","description":"Delivers a human-readable diagnostic summary, written to file.","fork":true,"url":"https://api.github.com/repos/gdams/nodereport","forks_url":"https://api.github.com/repos/gdams/nodereport/forks","keys_url":"https://api.github.com/repos/gdams/nodereport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdams/nodereport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdams/nodereport/teams","hooks_url":"https://api.github.com/repos/gdams/nodereport/hooks","issue_events_url":"https://api.github.com/repos/gdams/nodereport/issues/events{/number}","events_url":"https://api.github.com/repos/gdams/nodereport/events","assignees_url":"https://api.github.com/repos/gdams/nodereport/assignees{/user}","branches_url":"https://api.github.com/repos/gdams/nodereport/branches{/branch}","tags_url":"https://api.github.com/repos/gdams/nodereport/tags","blobs_url":"https://api.github.com/repos/gdams/nodereport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdams/nodereport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdams/nodereport/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdams/nodereport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdams/nodereport/statuses/{sha}","languages_url":"https://api.github.com/repos/gdams/nodereport/languages","stargazers_url":"https://api.github.com/repos/gdams/nodereport/stargazers","contributors_url":"https://api.github.com/repos/gdams/nodereport/contributors","subscribers_url":"https://api.github.com/repos/gdams/nodereport/subscribers","subscription_url":"https://api.github.com/repos/gdams/nodereport/subscription","commits_url":"https://api.github.com/repos/gdams/nodereport/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdams/nodereport/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdams/nodereport/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdams/nodereport/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdams/nodereport/contents/{+path}","compare_url":"https://api.github.com/repos/gdams/nodereport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdams/nodereport/merges","archive_url":"https://api.github.com/repos/gdams/nodereport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdams/nodereport/downloads","issues_url":"https://api.github.com/repos/gdams/nodereport/issues{/number}","pulls_url":"https://api.github.com/repos/gdams/nodereport/pulls{/number}","milestones_url":"https://api.github.com/repos/gdams/nodereport/milestones{/number}","notifications_url":"https://api.github.com/repos/gdams/nodereport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdams/nodereport/labels{/name}","releases_url":"https://api.github.com/repos/gdams/nodereport/releases{/id}","deployments_url":"https://api.github.com/repos/gdams/nodereport/deployments","created_at":"2017-01-12T16:07:04Z","updated_at":"2017-01-12T16:07:07Z","pushed_at":"2017-02-09T22:44:26Z","git_url":"git://github.com/gdams/nodereport.git","ssh_url":"git@github.com:gdams/nodereport.git","clone_url":"https://github.com/gdams/nodereport.git","svn_url":"https://github.com/gdams/nodereport","homepage":"https://www.npmjs.com/package/nodereport","size":167,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"e5bca0730d64d880747f0780c0ef52160693cf6a","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":65297067,"name":"node-report","full_name":"nodejs/node-report","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node-report","description":"Delivers a human-readable diagnostic summary, written to file.","fork":false,"url":"https://api.github.com/repos/nodejs/node-report","forks_url":"https://api.github.com/repos/nodejs/node-report/forks","keys_url":"https://api.github.com/repos/nodejs/node-report/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node-report/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node-report/teams","hooks_url":"https://api.github.com/repos/nodejs/node-report/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node-report/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node-report/events","assignees_url":"https://api.github.com/repos/nodejs/node-report/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node-report/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node-report/tags","blobs_url":"https://api.github.com/repos/nodejs/node-report/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node-report/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node-report/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node-report/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node-report/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node-report/languages","stargazers_url":"https://api.github.com/repos/nodejs/node-report/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node-report/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node-report/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node-report/subscription","commits_url":"https://api.github.com/repos/nodejs/node-report/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node-report/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node-report/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node-report/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node-report/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node-report/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node-report/merges","archive_url":"https://api.github.com/repos/nodejs/node-report/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node-report/downloads","issues_url":"https://api.github.com/repos/nodejs/node-report/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node-report/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node-report/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node-report/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node-report/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node-report/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node-report/deployments","created_at":"2016-08-09T13:25:33Z","updated_at":"2017-02-08T04:52:10Z","pushed_at":"2017-02-10T19:01:43Z","git_url":"git://github.com/nodejs/node-report.git","ssh_url":"git@github.com:nodejs/node-report.git","clone_url":"https://github.com/nodejs/node-report.git","svn_url":"https://github.com/nodejs/node-report","homepage":"https://www.npmjs.com/package/nodereport","size":117,"stargazers_count":39,"watchers_count":39,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":18,"forks":9,"open_issues":18,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node-report/pulls/47"},"html":{"href":"https://github.com/nodejs/node-report/pull/47"},"issue":{"href":"https://api.github.com/repos/nodejs/node-report/issues/47"},"comments":{"href":"https://api.github.com/repos/nodejs/node-report/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node-report/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node-report/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node-report/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node-report/statuses/5bd83f0ef4d35e3839637edf8067683b22383793"}}}}
{"actor":{"display_login":"sam-github"}}