{"action":"created","issue":{"url":"https://api.github.com/repos/NathanWalker/angular-seed-advanced/issues/382","repository_url":"https://api.github.com/repos/NathanWalker/angular-seed-advanced","labels_url":"https://api.github.com/repos/NathanWalker/angular-seed-advanced/issues/382/labels{/name}","comments_url":"https://api.github.com/repos/NathanWalker/angular-seed-advanced/issues/382/comments","events_url":"https://api.github.com/repos/NathanWalker/angular-seed-advanced/issues/382/events","html_url":"https://github.com/NathanWalker/angular-seed-advanced/issues/382","id":214763487,"number":382,"title":"Adding dependencies for electron help","user":{"login":"mikezoss","id":26464539,"avatar_url":"https://avatars2.githubusercontent.com/u/26464539?v=4","gravatar_id":"","url":"https://api.github.com/users/mikezoss","html_url":"https://github.com/mikezoss","followers_url":"https://api.github.com/users/mikezoss/followers","following_url":"https://api.github.com/users/mikezoss/following{/other_user}","gists_url":"https://api.github.com/users/mikezoss/gists{/gist_id}","starred_url":"https://api.github.com/users/mikezoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikezoss/subscriptions","organizations_url":"https://api.github.com/users/mikezoss/orgs","repos_url":"https://api.github.com/users/mikezoss/repos","events_url":"https://api.github.com/users/mikezoss/events{/privacy}","received_events_url":"https://api.github.com/users/mikezoss/received_events","type":"User","site_admin":false},"labels":[{"id":568554553,"url":"https://api.github.com/repos/NathanWalker/angular-seed-advanced/labels/electron","name":"electron","color":"c5def5","default":false},{"id":317295323,"url":"https://api.github.com/repos/NathanWalker/angular-seed-advanced/labels/help%20wanted","name":"help wanted","color":"159818","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-03-16T16:30:34Z","updated_at":"2017-10-20T12:23:32Z","closed_at":null,"author_association":"NONE","body":"**I'm submitting a ...**\r\n```\r\n[X] bug report\r\n```\r\n\r\n**Current behavior**\r\nI'm following these guides:\r\n- https://github.com/NathanWalker/angular-seed-advanced/issues/352\r\n- https://github.com/NathanWalker/angular-seed-advanced/issues/258\r\n\r\n**Expected behavior**\r\nI need \"glob.js\" (https://github.com/isaacs/node-glob) in my `home.component.ts` for electron. I'm on Windows 10 x64 and everytime the task (`npm run start.livesync.desktop.windows`) copy `node_modules` in `dist>dev` but it doesn't work. Can you try and fix this bug?\r\n\r\nAn extract of my **project.config.ts**:\r\n\r\n```typescript\r\n...\r\n\r\n    // Add `NPM` third-party libraries to be injected/bundled.\r\n    this.NPM_DEPENDENCIES = [\r\n      ...this.NPM_DEPENDENCIES,\r\n      // {src: 'jquery/dist/jquery.min.js', inject: 'libs'},\r\n    ];\r\n\r\n    // Add `local` third-party libraries to be injected/bundled.\r\n    this.APP_ASSETS = [\r\n      ...this.APP_ASSETS,\r\n      // {src: `${this.APP_SRC}/your-path-to-lib/libs/jquery-ui.js`, inject: true, vendor: false}\r\n      // {src: `${this.CSS_SRC}/path-to-lib/test-lib.css`, inject: true, vendor: false},\r\n    ];\r\n\r\n    // Add packages (e.g. ng2-translate)\r\n    // ng2-translate is already added with the advanced seed - here for example only\r\n    let additionalPackages: ExtendPackages[] = [\r\n      {\r\n        name: 'electron',\r\n        path: `${this.APP_BASE}node_modules/electron/index.js`\r\n      },\r\n      {\r\n        name: 'gojs',\r\n        path: `${this.APP_BASE}node_modules/gojs/release/go.js`\r\n      },\r\n      {\r\n        name: 'glob',\r\n        path: 'node_modules/glob/glob.js'\r\n      }\r\n    ];\r\n\r\n    this.DESKTOP_PACKAGES = [\r\n      ...this.DESKTOP_PACKAGES,\r\n      ...additionalPackages,\r\n    ];\r\n\r\n    this.addPackagesBundles(additionalPackages);\r\n\r\n    /* Add to or override NPM module configurations: */\r\n    // this.mergeObject(this.PLUGIN_CONFIGS['browser-sync'], { ghostMode: false });\r\n\r\n    // if (this.TARGET_DESKTOP) {\r\n    this.SYSTEM_CONFIG_DEV.map = {\r\n      fs: '@node/fs',\r\n      path: '@node/path'\r\n    };\r\n    // }\r\n  }\r\n...\r\n```\r\n\r\nAs you can see I'm already using `fs` and `path` from Node and `electron`. Is this necessary in my **project.config.ts**?\r\n\r\nI'm on Windows 10 x64, NodeJS 7.7.3, NPM 4.4.1.\r\n\r\n**Angular Seed Version:** `efb2fce`"},"comment":{"url":"https://api.github.com/repos/NathanWalker/angular-seed-advanced/issues/comments/338191539","html_url":"https://github.com/NathanWalker/angular-seed-advanced/issues/382#issuecomment-338191539","issue_url":"https://api.github.com/repos/NathanWalker/angular-seed-advanced/issues/382","id":338191539,"user":{"login":"rybaczewa","id":10841850,"avatar_url":"https://avatars1.githubusercontent.com/u/10841850?v=4","gravatar_id":"","url":"https://api.github.com/users/rybaczewa","html_url":"https://github.com/rybaczewa","followers_url":"https://api.github.com/users/rybaczewa/followers","following_url":"https://api.github.com/users/rybaczewa/following{/other_user}","gists_url":"https://api.github.com/users/rybaczewa/gists{/gist_id}","starred_url":"https://api.github.com/users/rybaczewa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rybaczewa/subscriptions","organizations_url":"https://api.github.com/users/rybaczewa/orgs","repos_url":"https://api.github.com/users/rybaczewa/repos","events_url":"https://api.github.com/users/rybaczewa/events{/privacy}","received_events_url":"https://api.github.com/users/rybaczewa/received_events","type":"User","site_admin":false},"created_at":"2017-10-20T12:23:32Z","updated_at":"2017-10-20T12:23:32Z","author_association":"NONE","body":"Is there a way for desktop packages to be included together with their dependencies? Passing every single dependency to `DESKTOP_PACKAGES` is impossible with bigger packages and all of their dependencies."}}
{"actor":{"display_login":"rybaczewa"}}