{"action":"created","comment":{"url":"https://api.github.com/repos/istio/api/pulls/comments/122331121","pull_request_review_id":44420010,"id":122331121,"diff_hunk":"@@ -0,0 +1,322 @@\n+// Copyright 2017 Istio Authors","path":"config/v1/service.proto","position":1,"original_position":1,"commit_id":"10b5977ec4f52681d87bfb3befa836fca8421bc2","original_commit_id":"10b5977ec4f52681d87bfb3befa836fca8421bc2","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars1.githubusercontent.com/u/800375?v=3","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"body":"done.","created_at":"2017-06-15T22:51:45Z","updated_at":"2017-06-15T22:54:45Z","html_url":"https://github.com/istio/api/pull/122#discussion_r122331121","pull_request_url":"https://api.github.com/repos/istio/api/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/istio/api/pulls/comments/122331121"},"html":{"href":"https://github.com/istio/api/pull/122#discussion_r122331121"},"pull_request":{"href":"https://api.github.com/repos/istio/api/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/istio/api/pulls/122","id":125152119,"html_url":"https://github.com/istio/api/pull/122","diff_url":"https://github.com/istio/api/pull/122.diff","patch_url":"https://github.com/istio/api/pull/122.patch","issue_url":"https://api.github.com/repos/istio/api/issues/122","number":122,"state":"open","locked":false,"title":"Defining the Galley API.","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars1.githubusercontent.com/u/800375?v=3","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"body":"This PR proposes an abstract config API service loosely based on the Kubernetes API server.\r\nIt adds a streaming watch to satisfy istio use cases efficiently, Stream watcher API follows etcdv3 watch API.","created_at":"2017-06-12T14:38:23Z","updated_at":"2017-06-15T22:54:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"925aa1393097188cd1528c5a8b40b4a93248b32d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ldemailly","id":3664595,"avatar_url":"https://avatars1.githubusercontent.com/u/3664595?v=3","gravatar_id":"","url":"https://api.github.com/users/ldemailly","html_url":"https://github.com/ldemailly","followers_url":"https://api.github.com/users/ldemailly/followers","following_url":"https://api.github.com/users/ldemailly/following{/other_user}","gists_url":"https://api.github.com/users/ldemailly/gists{/gist_id}","starred_url":"https://api.github.com/users/ldemailly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldemailly/subscriptions","organizations_url":"https://api.github.com/users/ldemailly/orgs","repos_url":"https://api.github.com/users/ldemailly/repos","events_url":"https://api.github.com/users/ldemailly/events{/privacy}","received_events_url":"https://api.github.com/users/ldemailly/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/api/pulls/122/commits","review_comments_url":"https://api.github.com/repos/istio/api/pulls/122/comments","review_comment_url":"https://api.github.com/repos/istio/api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/api/issues/122/comments","statuses_url":"https://api.github.com/repos/istio/api/statuses/10b5977ec4f52681d87bfb3befa836fca8421bc2","head":{"label":"mandarjog:config_api_service","ref":"config_api_service","sha":"10b5977ec4f52681d87bfb3befa836fca8421bc2","user":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars1.githubusercontent.com/u/800375?v=3","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"repo":{"id":76586532,"name":"istioapi","full_name":"mandarjog/istioapi","owner":{"login":"mandarjog","id":800375,"avatar_url":"https://avatars1.githubusercontent.com/u/800375?v=3","gravatar_id":"","url":"https://api.github.com/users/mandarjog","html_url":"https://github.com/mandarjog","followers_url":"https://api.github.com/users/mandarjog/followers","following_url":"https://api.github.com/users/mandarjog/following{/other_user}","gists_url":"https://api.github.com/users/mandarjog/gists{/gist_id}","starred_url":"https://api.github.com/users/mandarjog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mandarjog/subscriptions","organizations_url":"https://api.github.com/users/mandarjog/orgs","repos_url":"https://api.github.com/users/mandarjog/repos","events_url":"https://api.github.com/users/mandarjog/events{/privacy}","received_events_url":"https://api.github.com/users/mandarjog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mandarjog/istioapi","description":"API, Config Definitions and Standard Vocabulary definitions for the istio project","fork":true,"url":"https://api.github.com/repos/mandarjog/istioapi","forks_url":"https://api.github.com/repos/mandarjog/istioapi/forks","keys_url":"https://api.github.com/repos/mandarjog/istioapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mandarjog/istioapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mandarjog/istioapi/teams","hooks_url":"https://api.github.com/repos/mandarjog/istioapi/hooks","issue_events_url":"https://api.github.com/repos/mandarjog/istioapi/issues/events{/number}","events_url":"https://api.github.com/repos/mandarjog/istioapi/events","assignees_url":"https://api.github.com/repos/mandarjog/istioapi/assignees{/user}","branches_url":"https://api.github.com/repos/mandarjog/istioapi/branches{/branch}","tags_url":"https://api.github.com/repos/mandarjog/istioapi/tags","blobs_url":"https://api.github.com/repos/mandarjog/istioapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mandarjog/istioapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mandarjog/istioapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/mandarjog/istioapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mandarjog/istioapi/statuses/{sha}","languages_url":"https://api.github.com/repos/mandarjog/istioapi/languages","stargazers_url":"https://api.github.com/repos/mandarjog/istioapi/stargazers","contributors_url":"https://api.github.com/repos/mandarjog/istioapi/contributors","subscribers_url":"https://api.github.com/repos/mandarjog/istioapi/subscribers","subscription_url":"https://api.github.com/repos/mandarjog/istioapi/subscription","commits_url":"https://api.github.com/repos/mandarjog/istioapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/mandarjog/istioapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/mandarjog/istioapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/mandarjog/istioapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/mandarjog/istioapi/contents/{+path}","compare_url":"https://api.github.com/repos/mandarjog/istioapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mandarjog/istioapi/merges","archive_url":"https://api.github.com/repos/mandarjog/istioapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mandarjog/istioapi/downloads","issues_url":"https://api.github.com/repos/mandarjog/istioapi/issues{/number}","pulls_url":"https://api.github.com/repos/mandarjog/istioapi/pulls{/number}","milestones_url":"https://api.github.com/repos/mandarjog/istioapi/milestones{/number}","notifications_url":"https://api.github.com/repos/mandarjog/istioapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mandarjog/istioapi/labels{/name}","releases_url":"https://api.github.com/repos/mandarjog/istioapi/releases{/id}","deployments_url":"https://api.github.com/repos/mandarjog/istioapi/deployments","created_at":"2016-12-15T18:49:06Z","updated_at":"2016-12-19T17:39:45Z","pushed_at":"2017-06-15T01:08:22Z","git_url":"git://github.com/mandarjog/istioapi.git","ssh_url":"git@github.com:mandarjog/istioapi.git","clone_url":"https://github.com/mandarjog/istioapi.git","svn_url":"https://github.com/mandarjog/istioapi","homepage":null,"size":166,"stargazers_count":0,"watchers_count":0,"language":"Protocol Buffer","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"4c6ad2918c66f3bf200fb51f65ac57c4ed2e1b55","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":76586412,"name":"api","full_name":"istio/api","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/api","description":"API, config definitions and standard vocabulary definitions for the Istio project","fork":false,"url":"https://api.github.com/repos/istio/api","forks_url":"https://api.github.com/repos/istio/api/forks","keys_url":"https://api.github.com/repos/istio/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/api/teams","hooks_url":"https://api.github.com/repos/istio/api/hooks","issue_events_url":"https://api.github.com/repos/istio/api/issues/events{/number}","events_url":"https://api.github.com/repos/istio/api/events","assignees_url":"https://api.github.com/repos/istio/api/assignees{/user}","branches_url":"https://api.github.com/repos/istio/api/branches{/branch}","tags_url":"https://api.github.com/repos/istio/api/tags","blobs_url":"https://api.github.com/repos/istio/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/api/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/api/languages","stargazers_url":"https://api.github.com/repos/istio/api/stargazers","contributors_url":"https://api.github.com/repos/istio/api/contributors","subscribers_url":"https://api.github.com/repos/istio/api/subscribers","subscription_url":"https://api.github.com/repos/istio/api/subscription","commits_url":"https://api.github.com/repos/istio/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/api/contents/{+path}","compare_url":"https://api.github.com/repos/istio/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/api/merges","archive_url":"https://api.github.com/repos/istio/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/api/downloads","issues_url":"https://api.github.com/repos/istio/api/issues{/number}","pulls_url":"https://api.github.com/repos/istio/api/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/api/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/api/labels{/name}","releases_url":"https://api.github.com/repos/istio/api/releases{/id}","deployments_url":"https://api.github.com/repos/istio/api/deployments","created_at":"2016-12-15T18:47:13Z","updated_at":"2017-06-03T17:38:50Z","pushed_at":"2017-06-15T01:08:24Z","git_url":"git://github.com/istio/api.git","ssh_url":"git@github.com:istio/api.git","clone_url":"https://github.com/istio/api.git","svn_url":"https://github.com/istio/api","homepage":"","size":152,"stargazers_count":16,"watchers_count":16,"language":"Protocol Buffer","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":12,"forks":26,"open_issues":12,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/api/pulls/122"},"html":{"href":"https://github.com/istio/api/pull/122"},"issue":{"href":"https://api.github.com/repos/istio/api/issues/122"},"comments":{"href":"https://api.github.com/repos/istio/api/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/api/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/api/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/istio/api/statuses/10b5977ec4f52681d87bfb3befa836fca8421bc2"}}}}
{"actor":{"display_login":"mandarjog"}}