{"action":"created","comment":{"url":"https://api.github.com/repos/Workiva/over_react/pulls/comments/132758672","pull_request_review_id":55877558,"id":132758672,"diff_hunk":"@@ -280,6 +280,43 @@ react.Component getDartComponent(/* [1] */ instance) {\n     return null;\n   }\n \n+  // Split out into a separate function since the DDC doesn't support","path":"lib/src/util/react_wrappers.dart","position":4,"original_position":4,"commit_id":"473b04360d2347fc9f68f18c1bd22ca527fea436","original_commit_id":"473b04360d2347fc9f68f18c1bd22ca527fea436","user":{"login":"jacehensley-wf","id":12398382,"avatar_url":"https://avatars3.githubusercontent.com/u/12398382?v=4","gravatar_id":"","url":"https://api.github.com/users/jacehensley-wf","html_url":"https://github.com/jacehensley-wf","followers_url":"https://api.github.com/users/jacehensley-wf/followers","following_url":"https://api.github.com/users/jacehensley-wf/following{/other_user}","gists_url":"https://api.github.com/users/jacehensley-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/jacehensley-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacehensley-wf/subscriptions","organizations_url":"https://api.github.com/users/jacehensley-wf/orgs","repos_url":"https://api.github.com/users/jacehensley-wf/repos","events_url":"https://api.github.com/users/jacehensley-wf/events{/privacy}","received_events_url":"https://api.github.com/users/jacehensley-wf/received_events","type":"User","site_admin":false},"body":"Booo","created_at":"2017-08-11T18:45:08Z","updated_at":"2017-08-11T18:45:50Z","html_url":"https://github.com/Workiva/over_react/pull/105#discussion_r132758672","pull_request_url":"https://api.github.com/repos/Workiva/over_react/pulls/105","_links":{"self":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/comments/132758672"},"html":{"href":"https://github.com/Workiva/over_react/pull/105#discussion_r132758672"},"pull_request":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/Workiva/over_react/pulls/105","id":135389971,"html_url":"https://github.com/Workiva/over_react/pull/105","diff_url":"https://github.com/Workiva/over_react/pull/105.diff","patch_url":"https://github.com/Workiva/over_react/pull/105.patch","issue_url":"https://api.github.com/repos/Workiva/over_react/issues/105","number":105,"state":"open","locked":false,"title":"UIP-2629 getDartComponent warning for ReactElements","user":{"login":"greglittlefield-wf","id":1713967,"avatar_url":"https://avatars0.githubusercontent.com/u/1713967?v=4","gravatar_id":"","url":"https://api.github.com/users/greglittlefield-wf","html_url":"https://github.com/greglittlefield-wf","followers_url":"https://api.github.com/users/greglittlefield-wf/followers","following_url":"https://api.github.com/users/greglittlefield-wf/following{/other_user}","gists_url":"https://api.github.com/users/greglittlefield-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/greglittlefield-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglittlefield-wf/subscriptions","organizations_url":"https://api.github.com/users/greglittlefield-wf/orgs","repos_url":"https://api.github.com/users/greglittlefield-wf/repos","events_url":"https://api.github.com/users/greglittlefield-wf/events{/privacy}","received_events_url":"https://api.github.com/users/greglittlefield-wf/received_events","type":"User","site_admin":false},"body":"# Ultimate problem:\r\nThe soon to be released react-dart 4.0 will no longer support retrieving Dart components via `getDartComponent` from `ReactElements` (pre-mounted VDOM instances) in order to avoid memory leaks.\r\n\r\nWe should have a warning in place for when this occurs so that consumers will:\r\n- be able to identify problematic usages that need to be updated\r\n- be able to tell why things are breaking if they don't fix them in time:\r\n\r\n\r\n# How it was fixed:\r\n- Add error message that prints when a ReactElement is passed into `getDartComponent`\r\n        <img width=\"791\" alt=\"screen shot 2017-08-11 at 11 09 13 am\" src=\"https://user-images.githubusercontent.com/1713967/29226081-8b15dc68-7e85-11e7-8321-6ecc1d2ebd40.png\">\r\n- Add tests\r\n\r\n#### Boy-scouted:\r\n- Fixes to selection range tests that were failing in Chrome\r\n- [UIP-2322](https://jira.atl.workiva.net/browse/UIP-2322) Fixes to selection range logic in Firefox\r\n\r\n# Testing suggestions:\r\nVerify that tests pass in all platforms:\r\n- Dart VM\r\n    - `ddev test -p content-shell`\r\n    - `ddev test -p dartium`\r\n- dart2js\r\n    - `ddev test -p chrome`\r\n    - `ddev test -p firefox`\r\n        - Watch out for unrelated failing `getActiveElement` test in master\r\n- DDC\r\n    - `ddev test -p chrome --web-compiler=dartdevc test/*_test.dart -x no-ddc`\r\n        - Watch out for unrelated intermittently-failing `getActiveElement` test in master\r\n        - Watch out for unrelated failing `ObjectDisposedException` test in master\r\n\r\n# Potential areas of regression:\r\n- `getDartComponent`\r\n- `setSelectionRange/`getSelectionRange`\r\n\r\n---\r\n\r\n> __FYA:__ @greglittlefield-wf @aaronlademann-wf @jacehensley-wf @clairesarsam-wf @joelleibow-wf\r\n","created_at":"2017-08-11T18:12:47Z","updated_at":"2017-08-11T18:45:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5effab01c59d99abb963808a891bbcb2b5c38733","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Workiva/over_react/pulls/105/commits","review_comments_url":"https://api.github.com/repos/Workiva/over_react/pulls/105/comments","review_comment_url":"https://api.github.com/repos/Workiva/over_react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Workiva/over_react/issues/105/comments","statuses_url":"https://api.github.com/repos/Workiva/over_react/statuses/473b04360d2347fc9f68f18c1bd22ca527fea436","head":{"label":"greglittlefield-wf:getDartComponent-warning","ref":"getDartComponent-warning","sha":"473b04360d2347fc9f68f18c1bd22ca527fea436","user":{"login":"greglittlefield-wf","id":1713967,"avatar_url":"https://avatars0.githubusercontent.com/u/1713967?v=4","gravatar_id":"","url":"https://api.github.com/users/greglittlefield-wf","html_url":"https://github.com/greglittlefield-wf","followers_url":"https://api.github.com/users/greglittlefield-wf/followers","following_url":"https://api.github.com/users/greglittlefield-wf/following{/other_user}","gists_url":"https://api.github.com/users/greglittlefield-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/greglittlefield-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglittlefield-wf/subscriptions","organizations_url":"https://api.github.com/users/greglittlefield-wf/orgs","repos_url":"https://api.github.com/users/greglittlefield-wf/repos","events_url":"https://api.github.com/users/greglittlefield-wf/events{/privacy}","received_events_url":"https://api.github.com/users/greglittlefield-wf/received_events","type":"User","site_admin":false},"repo":{"id":72448708,"name":"over_react","full_name":"greglittlefield-wf/over_react","owner":{"login":"greglittlefield-wf","id":1713967,"avatar_url":"https://avatars0.githubusercontent.com/u/1713967?v=4","gravatar_id":"","url":"https://api.github.com/users/greglittlefield-wf","html_url":"https://github.com/greglittlefield-wf","followers_url":"https://api.github.com/users/greglittlefield-wf/followers","following_url":"https://api.github.com/users/greglittlefield-wf/following{/other_user}","gists_url":"https://api.github.com/users/greglittlefield-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/greglittlefield-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglittlefield-wf/subscriptions","organizations_url":"https://api.github.com/users/greglittlefield-wf/orgs","repos_url":"https://api.github.com/users/greglittlefield-wf/repos","events_url":"https://api.github.com/users/greglittlefield-wf/events{/privacy}","received_events_url":"https://api.github.com/users/greglittlefield-wf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/greglittlefield-wf/over_react","description":"A library for building statically-typed React UI components using Dart.","fork":true,"url":"https://api.github.com/repos/greglittlefield-wf/over_react","forks_url":"https://api.github.com/repos/greglittlefield-wf/over_react/forks","keys_url":"https://api.github.com/repos/greglittlefield-wf/over_react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greglittlefield-wf/over_react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greglittlefield-wf/over_react/teams","hooks_url":"https://api.github.com/repos/greglittlefield-wf/over_react/hooks","issue_events_url":"https://api.github.com/repos/greglittlefield-wf/over_react/issues/events{/number}","events_url":"https://api.github.com/repos/greglittlefield-wf/over_react/events","assignees_url":"https://api.github.com/repos/greglittlefield-wf/over_react/assignees{/user}","branches_url":"https://api.github.com/repos/greglittlefield-wf/over_react/branches{/branch}","tags_url":"https://api.github.com/repos/greglittlefield-wf/over_react/tags","blobs_url":"https://api.github.com/repos/greglittlefield-wf/over_react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greglittlefield-wf/over_react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greglittlefield-wf/over_react/git/refs{/sha}","trees_url":"https://api.github.com/repos/greglittlefield-wf/over_react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greglittlefield-wf/over_react/statuses/{sha}","languages_url":"https://api.github.com/repos/greglittlefield-wf/over_react/languages","stargazers_url":"https://api.github.com/repos/greglittlefield-wf/over_react/stargazers","contributors_url":"https://api.github.com/repos/greglittlefield-wf/over_react/contributors","subscribers_url":"https://api.github.com/repos/greglittlefield-wf/over_react/subscribers","subscription_url":"https://api.github.com/repos/greglittlefield-wf/over_react/subscription","commits_url":"https://api.github.com/repos/greglittlefield-wf/over_react/commits{/sha}","git_commits_url":"https://api.github.com/repos/greglittlefield-wf/over_react/git/commits{/sha}","comments_url":"https://api.github.com/repos/greglittlefield-wf/over_react/comments{/number}","issue_comment_url":"https://api.github.com/repos/greglittlefield-wf/over_react/issues/comments{/number}","contents_url":"https://api.github.com/repos/greglittlefield-wf/over_react/contents/{+path}","compare_url":"https://api.github.com/repos/greglittlefield-wf/over_react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greglittlefield-wf/over_react/merges","archive_url":"https://api.github.com/repos/greglittlefield-wf/over_react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greglittlefield-wf/over_react/downloads","issues_url":"https://api.github.com/repos/greglittlefield-wf/over_react/issues{/number}","pulls_url":"https://api.github.com/repos/greglittlefield-wf/over_react/pulls{/number}","milestones_url":"https://api.github.com/repos/greglittlefield-wf/over_react/milestones{/number}","notifications_url":"https://api.github.com/repos/greglittlefield-wf/over_react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greglittlefield-wf/over_react/labels{/name}","releases_url":"https://api.github.com/repos/greglittlefield-wf/over_react/releases{/id}","deployments_url":"https://api.github.com/repos/greglittlefield-wf/over_react/deployments","created_at":"2016-10-31T15:13:38Z","updated_at":"2016-10-31T15:13:39Z","pushed_at":"2017-08-11T18:19:58Z","git_url":"git://github.com/greglittlefield-wf/over_react.git","ssh_url":"git@github.com:greglittlefield-wf/over_react.git","clone_url":"https://github.com/greglittlefield-wf/over_react.git","svn_url":"https://github.com/greglittlefield-wf/over_react","homepage":"","size":7329,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Workiva:master","ref":"master","sha":"df59869895e65f33f1eeddc2adbb3ae1c92615dd","user":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":70642157,"name":"over_react","full_name":"Workiva/over_react","owner":{"login":"Workiva","id":1087529,"avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Workiva/over_react","description":"A library for building statically-typed React UI components using Dart.","fork":false,"url":"https://api.github.com/repos/Workiva/over_react","forks_url":"https://api.github.com/repos/Workiva/over_react/forks","keys_url":"https://api.github.com/repos/Workiva/over_react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/over_react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/over_react/teams","hooks_url":"https://api.github.com/repos/Workiva/over_react/hooks","issue_events_url":"https://api.github.com/repos/Workiva/over_react/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/over_react/events","assignees_url":"https://api.github.com/repos/Workiva/over_react/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/over_react/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/over_react/tags","blobs_url":"https://api.github.com/repos/Workiva/over_react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/over_react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/over_react/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/over_react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/over_react/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/over_react/languages","stargazers_url":"https://api.github.com/repos/Workiva/over_react/stargazers","contributors_url":"https://api.github.com/repos/Workiva/over_react/contributors","subscribers_url":"https://api.github.com/repos/Workiva/over_react/subscribers","subscription_url":"https://api.github.com/repos/Workiva/over_react/subscription","commits_url":"https://api.github.com/repos/Workiva/over_react/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/over_react/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/over_react/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/over_react/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/over_react/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/over_react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/over_react/merges","archive_url":"https://api.github.com/repos/Workiva/over_react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/over_react/downloads","issues_url":"https://api.github.com/repos/Workiva/over_react/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/over_react/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/over_react/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/over_react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/over_react/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/over_react/releases{/id}","deployments_url":"https://api.github.com/repos/Workiva/over_react/deployments","created_at":"2016-10-11T22:56:57Z","updated_at":"2017-08-09T15:05:35Z","pushed_at":"2017-08-11T18:18:10Z","git_url":"git://github.com/Workiva/over_react.git","ssh_url":"git@github.com:Workiva/over_react.git","clone_url":"https://github.com/Workiva/over_react.git","svn_url":"https://github.com/Workiva/over_react","homepage":"","size":7955,"stargazers_count":84,"watchers_count":84,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":9,"forks":22,"open_issues":9,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/105"},"html":{"href":"https://github.com/Workiva/over_react/pull/105"},"issue":{"href":"https://api.github.com/repos/Workiva/over_react/issues/105"},"comments":{"href":"https://api.github.com/repos/Workiva/over_react/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Workiva/over_react/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/Workiva/over_react/statuses/473b04360d2347fc9f68f18c1bd22ca527fea436"}}}}
{"actor":{"display_login":"jacehensley-wf"}}