{"action":"created","issue":{"url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/1715","repository_url":"https://api.github.com/repos/intellij-rust/intellij-rust","labels_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/1715/labels{/name}","comments_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/1715/comments","events_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/1715/events","html_url":"https://github.com/intellij-rust/intellij-rust/issues/1715","id":256549823,"number":1715,"title":"Don't warn about conventions when implementing traits","user":{"login":"jkcclemens","id":955250,"avatar_url":"https://avatars0.githubusercontent.com/u/955250?v=4","gravatar_id":"","url":"https://api.github.com/users/jkcclemens","html_url":"https://github.com/jkcclemens","followers_url":"https://api.github.com/users/jkcclemens/followers","following_url":"https://api.github.com/users/jkcclemens/following{/other_user}","gists_url":"https://api.github.com/users/jkcclemens/gists{/gist_id}","starred_url":"https://api.github.com/users/jkcclemens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkcclemens/subscriptions","organizations_url":"https://api.github.com/users/jkcclemens/orgs","repos_url":"https://api.github.com/users/jkcclemens/repos","events_url":"https://api.github.com/users/jkcclemens/events{/privacy}","received_events_url":"https://api.github.com/users/jkcclemens/received_events","type":"User","site_admin":false},"labels":[{"id":596293851,"url":"https://api.github.com/repos/intellij-rust/intellij-rust/labels/E-easy","name":"E-easy","color":"0e8a16","default":false},{"id":279706113,"url":"https://api.github.com/repos/intellij-rust/intellij-rust/labels/up%20for%20grab","name":"up for grab","color":"207de5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-10T23:40:49Z","updated_at":"2017-09-20T11:44:04Z","closed_at":null,"author_association":"NONE","body":"If `SomeTrait` is in a crate I don't control, I can't fix its bad conventions, so don't warn me about them when I implement it.\r\n\r\n```rust\r\nextern crate not_my_crate;\r\n\r\nuse not_my_crate::SomeTrait;\r\n\r\nstruct MyStruct;\r\n\r\nimpl SomeTrait for MyStruct {\r\n  // This will warn as follows\r\n  // methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name\r\n  // This isn't my choice; don't warn me about it\r\n  fn as_i64(self) -> i64 {\r\n    unimplemented!();\r\n  }\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/comments/330826678","html_url":"https://github.com/intellij-rust/intellij-rust/issues/1715#issuecomment-330826678","issue_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/1715","id":330826678,"user":{"login":"matklad","id":1711539,"avatar_url":"https://avatars3.githubusercontent.com/u/1711539?v=4","gravatar_id":"","url":"https://api.github.com/users/matklad","html_url":"https://github.com/matklad","followers_url":"https://api.github.com/users/matklad/followers","following_url":"https://api.github.com/users/matklad/following{/other_user}","gists_url":"https://api.github.com/users/matklad/gists{/gist_id}","starred_url":"https://api.github.com/users/matklad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matklad/subscriptions","organizations_url":"https://api.github.com/users/matklad/orgs","repos_url":"https://api.github.com/users/matklad/repos","events_url":"https://api.github.com/users/matklad/events{/privacy}","received_events_url":"https://api.github.com/users/matklad/received_events","type":"User","site_admin":false},"created_at":"2017-09-20T11:44:04Z","updated_at":"2017-09-20T11:44:04Z","author_association":"OWNER","body":"The relevant code is `src/main/kotlin/org/rust/ide/inspections/RsNamingInspection.kt`"}}
{"actor":{"display_login":"matklad"}}