{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/data-prep/pulls/comments/120330166","pull_request_review_id":42282464,"id":120330166,"diff_hunk":"@@ -12,84 +12,52 @@\n   ============================================================================*/\n \n .dataset-parameters {\n-\tbackground: $dark-gray;\n-\n \t.dataset-parameters-title {\n-\t\tborder-bottom: 1px solid $white;\n-\t\tcolor: $white;\n \t\tfont-weight: bold;\n-\t\tpadding: 10px;\n \t}\n \n-\t.param {\n+\t.params {\n \t\tdisplay: flex;\n \t\tflex-direction: column;\n-\t\tjustify-content: flex-start;\n-\t\talign-items: stretch;\n \n-\t\t.param-row {\n+\t\t.params-row {\n \t\t\tdisplay: flex;\n-\t\t\tflex-direction: row;\n-\t\t\tflex-wrap: wrap;\n-\t\t\talign-items: center;\n \n-\t\t\t.param-row-item {\n-\t\t\t\tdisplay: flex;\n-\t\t\t\tflex-direction: row;\n-\t\t\t\tflex-wrap: wrap;\n-\t\t\t\talign-items: center;\n-\t\t\t\tflex-basis: 300px;\n-\t\t\t\tflex-grow: 1;\n+\t\t\t.form-group {\n+\t\t\t\tflex-basis: 50%;","path":"dataprep-webapp/src/app/components/dataset/parameters/_dataset-parameters.scss","position":35,"original_position":35,"commit_id":"09de9c18a95230c40601917516320e984377a902","original_commit_id":"7802d5924d5551f969f18e981dc9c6bd576ef379","user":{"login":"ncomont","id":26482371,"avatar_url":"https://avatars1.githubusercontent.com/u/26482371?v=3","gravatar_id":"","url":"https://api.github.com/users/ncomont","html_url":"https://github.com/ncomont","followers_url":"https://api.github.com/users/ncomont/followers","following_url":"https://api.github.com/users/ncomont/following{/other_user}","gists_url":"https://api.github.com/users/ncomont/gists{/gist_id}","starred_url":"https://api.github.com/users/ncomont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncomont/subscriptions","organizations_url":"https://api.github.com/users/ncomont/orgs","repos_url":"https://api.github.com/users/ncomont/repos","events_url":"https://api.github.com/users/ncomont/events{/privacy}","received_events_url":"https://api.github.com/users/ncomont/received_events","type":"User","site_admin":false},"body":"good catch, thanks","created_at":"2017-06-06T11:35:18Z","updated_at":"2017-06-06T11:35:18Z","html_url":"https://github.com/Talend/data-prep/pull/641#discussion_r120330166","pull_request_url":"https://api.github.com/repos/Talend/data-prep/pulls/641","_links":{"self":{"href":"https://api.github.com/repos/Talend/data-prep/pulls/comments/120330166"},"html":{"href":"https://github.com/Talend/data-prep/pull/641#discussion_r120330166"},"pull_request":{"href":"https://api.github.com/repos/Talend/data-prep/pulls/641"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/data-prep/pulls/641","id":123074538,"html_url":"https://github.com/Talend/data-prep/pull/641","diff_url":"https://github.com/Talend/data-prep/pull/641.diff","patch_url":"https://github.com/Talend/data-prep/pull/641.patch","issue_url":"https://api.github.com/repos/Talend/data-prep/issues/641","number":641,"state":"open","locked":false,"title":"chores(TDP-3541): dataset parameters panel improvements","user":{"login":"ncomont","id":26482371,"avatar_url":"https://avatars1.githubusercontent.com/u/26482371?v=3","gravatar_id":"","url":"https://api.github.com/users/ncomont","html_url":"https://github.com/ncomont","followers_url":"https://api.github.com/users/ncomont/followers","following_url":"https://api.github.com/users/ncomont/following{/other_user}","gists_url":"https://api.github.com/users/ncomont/gists{/gist_id}","starred_url":"https://api.github.com/users/ncomont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncomont/subscriptions","organizations_url":"https://api.github.com/users/ncomont/orgs","repos_url":"https://api.github.com/users/ncomont/repos","events_url":"https://api.github.com/users/ncomont/events{/privacy}","received_events_url":"https://api.github.com/users/ncomont/received_events","type":"User","site_admin":false},"body":"**Link to the JIRA issue**\r\nhttps://jira.talendforge.org/browse/TDP-3541\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The commit(s) message(s) follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md#commit-message-format)\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n- [ ] The code coverage on new code is > 75 % for backend and > 95% for frontend\r\n- [x] The new code does not introduce new technical issues (sonar / eslint)\r\n- [x] Functional tests have been performed\r\n- [ ] Docker configuration files for config-std or config-cloud profiles are impacted\r\n\r\n**Please check the browsers you've tested on**\r\n- [x] Chrome, Firefox, Safari, Edge, IE11\r\n- [ ] No, that's bad, this PR should not be merged !\r\n- [ ] No, and no need to (backend changes only)\r\n\r\n**(Optional) What is the current behavior?**\r\n(Additional information to the Jira)\r\n\r\n\r\n**(Optional) What is the new behavior?**\r\n(Additional information to the Jira)\r\n\r\n\r\n**(Optional) Other information**:\r\n","created_at":"2017-05-30T15:12:40Z","updated_at":"2017-06-06T11:35:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"257bca7e18b568a158928e816821f7756250b392","assignee":null,"assignees":[],"requested_reviewers":[{"login":"charlesnguyen","id":13314851,"avatar_url":"https://avatars3.githubusercontent.com/u/13314851?v=3","gravatar_id":"","url":"https://api.github.com/users/charlesnguyen","html_url":"https://github.com/charlesnguyen","followers_url":"https://api.github.com/users/charlesnguyen/followers","following_url":"https://api.github.com/users/charlesnguyen/following{/other_user}","gists_url":"https://api.github.com/users/charlesnguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesnguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesnguyen/subscriptions","organizations_url":"https://api.github.com/users/charlesnguyen/orgs","repos_url":"https://api.github.com/users/charlesnguyen/repos","events_url":"https://api.github.com/users/charlesnguyen/events{/privacy}","received_events_url":"https://api.github.com/users/charlesnguyen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/data-prep/pulls/641/commits","review_comments_url":"https://api.github.com/repos/Talend/data-prep/pulls/641/comments","review_comment_url":"https://api.github.com/repos/Talend/data-prep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/data-prep/issues/641/comments","statuses_url":"https://api.github.com/repos/Talend/data-prep/statuses/09de9c18a95230c40601917516320e984377a902","head":{"label":"Talend:ncomont/TDP-3541-dataset-parameters-panel-improvements","ref":"ncomont/TDP-3541-dataset-parameters-panel-improvements","sha":"09de9c18a95230c40601917516320e984377a902","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars1.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":26644682,"name":"data-prep","full_name":"Talend/data-prep","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars1.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/data-prep","description":"OS code of Data-prep project","fork":false,"url":"https://api.github.com/repos/Talend/data-prep","forks_url":"https://api.github.com/repos/Talend/data-prep/forks","keys_url":"https://api.github.com/repos/Talend/data-prep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/data-prep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/data-prep/teams","hooks_url":"https://api.github.com/repos/Talend/data-prep/hooks","issue_events_url":"https://api.github.com/repos/Talend/data-prep/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/data-prep/events","assignees_url":"https://api.github.com/repos/Talend/data-prep/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/data-prep/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/data-prep/tags","blobs_url":"https://api.github.com/repos/Talend/data-prep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/data-prep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/data-prep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/data-prep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/data-prep/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/data-prep/languages","stargazers_url":"https://api.github.com/repos/Talend/data-prep/stargazers","contributors_url":"https://api.github.com/repos/Talend/data-prep/contributors","subscribers_url":"https://api.github.com/repos/Talend/data-prep/subscribers","subscription_url":"https://api.github.com/repos/Talend/data-prep/subscription","commits_url":"https://api.github.com/repos/Talend/data-prep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/data-prep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/data-prep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/data-prep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/data-prep/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/data-prep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/data-prep/merges","archive_url":"https://api.github.com/repos/Talend/data-prep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/data-prep/downloads","issues_url":"https://api.github.com/repos/Talend/data-prep/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/data-prep/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/data-prep/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/data-prep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/data-prep/labels{/name}","releases_url":"https://api.github.com/repos/Talend/data-prep/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/data-prep/deployments","created_at":"2014-11-14T15:32:38Z","updated_at":"2017-04-20T18:26:29Z","pushed_at":"2017-06-06T11:34:28Z","git_url":"git://github.com/Talend/data-prep.git","ssh_url":"git@github.com:Talend/data-prep.git","clone_url":"https://github.com/Talend/data-prep.git","svn_url":"https://github.com/Talend/data-prep","homepage":"","size":54024,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":12,"forks":19,"open_issues":12,"watchers":28,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"05f1d8e6a31d53ba1a0efbec5f59dbcc404e3676","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars1.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":26644682,"name":"data-prep","full_name":"Talend/data-prep","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars1.githubusercontent.com/u/459687?v=3","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/data-prep","description":"OS code of Data-prep project","fork":false,"url":"https://api.github.com/repos/Talend/data-prep","forks_url":"https://api.github.com/repos/Talend/data-prep/forks","keys_url":"https://api.github.com/repos/Talend/data-prep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/data-prep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/data-prep/teams","hooks_url":"https://api.github.com/repos/Talend/data-prep/hooks","issue_events_url":"https://api.github.com/repos/Talend/data-prep/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/data-prep/events","assignees_url":"https://api.github.com/repos/Talend/data-prep/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/data-prep/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/data-prep/tags","blobs_url":"https://api.github.com/repos/Talend/data-prep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/data-prep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/data-prep/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/data-prep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/data-prep/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/data-prep/languages","stargazers_url":"https://api.github.com/repos/Talend/data-prep/stargazers","contributors_url":"https://api.github.com/repos/Talend/data-prep/contributors","subscribers_url":"https://api.github.com/repos/Talend/data-prep/subscribers","subscription_url":"https://api.github.com/repos/Talend/data-prep/subscription","commits_url":"https://api.github.com/repos/Talend/data-prep/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/data-prep/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/data-prep/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/data-prep/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/data-prep/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/data-prep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/data-prep/merges","archive_url":"https://api.github.com/repos/Talend/data-prep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/data-prep/downloads","issues_url":"https://api.github.com/repos/Talend/data-prep/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/data-prep/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/data-prep/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/data-prep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/data-prep/labels{/name}","releases_url":"https://api.github.com/repos/Talend/data-prep/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/data-prep/deployments","created_at":"2014-11-14T15:32:38Z","updated_at":"2017-04-20T18:26:29Z","pushed_at":"2017-06-06T11:34:28Z","git_url":"git://github.com/Talend/data-prep.git","ssh_url":"git@github.com:Talend/data-prep.git","clone_url":"https://github.com/Talend/data-prep.git","svn_url":"https://github.com/Talend/data-prep","homepage":"","size":54024,"stargazers_count":28,"watchers_count":28,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":12,"forks":19,"open_issues":12,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/data-prep/pulls/641"},"html":{"href":"https://github.com/Talend/data-prep/pull/641"},"issue":{"href":"https://api.github.com/repos/Talend/data-prep/issues/641"},"comments":{"href":"https://api.github.com/repos/Talend/data-prep/issues/641/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/data-prep/pulls/641/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/data-prep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/data-prep/pulls/641/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/data-prep/statuses/09de9c18a95230c40601917516320e984377a902"}}}}
{"actor":{"display_login":"ncomont"}}