{"action":"created","issue":{"url":"https://api.github.com/repos/solidusio/solidus/issues/2109","repository_url":"https://api.github.com/repos/solidusio/solidus","labels_url":"https://api.github.com/repos/solidusio/solidus/issues/2109/labels{/name}","comments_url":"https://api.github.com/repos/solidusio/solidus/issues/2109/comments","events_url":"https://api.github.com/repos/solidusio/solidus/issues/2109/events","html_url":"https://github.com/solidusio/solidus/pull/2109","id":245196199,"number":2109,"title":"Inline Table Editing","user":{"login":"graygilmore","id":836758,"avatar_url":"https://avatars1.githubusercontent.com/u/836758?v=4","gravatar_id":"","url":"https://api.github.com/users/graygilmore","html_url":"https://github.com/graygilmore","followers_url":"https://api.github.com/users/graygilmore/followers","following_url":"https://api.github.com/users/graygilmore/following{/other_user}","gists_url":"https://api.github.com/users/graygilmore/gists{/gist_id}","starred_url":"https://api.github.com/users/graygilmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graygilmore/subscriptions","organizations_url":"https://api.github.com/users/graygilmore/orgs","repos_url":"https://api.github.com/users/graygilmore/repos","events_url":"https://api.github.com/users/graygilmore/events{/privacy}","received_events_url":"https://api.github.com/users/graygilmore/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-07-24T20:16:21Z","updated_at":"2017-07-28T18:52:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solidusio/solidus/pulls/2109","html_url":"https://github.com/solidusio/solidus/pull/2109","diff_url":"https://github.com/solidusio/solidus/pull/2109.diff","patch_url":"https://github.com/solidusio/solidus/pull/2109.patch"},"body":"This PR does a few different things:\r\n\r\n1. Refactors the inline editable table row JS to handle a few different scenarios of editing (like removing the save/cancel buttons if no fields have changed).\r\n2. Only apply our custom form styling to elements that aren't already using Bootstrap classes (e.g. `form-control`)\r\n  - A note about this change: this is likely something that we'll want to do throughout the admin so we do not have selector specificity collisions. https://github.com/graygilmore/solidus/commit/8777e5f78ec6c92899a89190d5b03e62ea1f0026\r\n3. Add an API endpoint for updating tax categories and implement the inline editable table to the index page as another example implementation (the first being the product images table)\r\n\r\nThis PR addresses but does not complete https://github.com/solidusio/solidus/issues/2042. There are quite a few more tables to go which I will be opening up later PRs for.\r\n\r\n## TODO\r\n\r\n- [x] fix spec failures\r\n- [ ] remove skip auth\r\n- [ ] fix checkbox reset\r\n- [ ] ~~investigate moving this functionality to Backbone~~"},"comment":{"url":"https://api.github.com/repos/solidusio/solidus/issues/comments/318734657","html_url":"https://github.com/solidusio/solidus/pull/2109#issuecomment-318734657","issue_url":"https://api.github.com/repos/solidusio/solidus/issues/2109","id":318734657,"user":{"login":"graygilmore","id":836758,"avatar_url":"https://avatars1.githubusercontent.com/u/836758?v=4","gravatar_id":"","url":"https://api.github.com/users/graygilmore","html_url":"https://github.com/graygilmore","followers_url":"https://api.github.com/users/graygilmore/followers","following_url":"https://api.github.com/users/graygilmore/following{/other_user}","gists_url":"https://api.github.com/users/graygilmore/gists{/gist_id}","starred_url":"https://api.github.com/users/graygilmore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graygilmore/subscriptions","organizations_url":"https://api.github.com/users/graygilmore/orgs","repos_url":"https://api.github.com/users/graygilmore/repos","events_url":"https://api.github.com/users/graygilmore/events{/privacy}","received_events_url":"https://api.github.com/users/graygilmore/received_events","type":"User","site_admin":false},"created_at":"2017-07-28T18:52:51Z","updated_at":"2017-07-28T18:52:51Z","body":"@Mandily is this the direction you want to see us heading? I know you've referenced other implementations where the admin is able to edit multiple items in the table and then save them all at once. Before we continue down this path I think it's important to make sure we're spending time on something that we actually want!"}}
{"actor":{"display_login":"graygilmore"}}