{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin-web-console/issues/2083","repository_url":"https://api.github.com/repos/openshift/origin-web-console","labels_url":"https://api.github.com/repos/openshift/origin-web-console/issues/2083/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/2083/comments","events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/2083/events","html_url":"https://github.com/openshift/origin-web-console/pull/2083","id":257922384,"number":2083,"title":"Update e2e test dependency updates & get them running on Mac","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"labels":[{"id":711584038,"url":"https://api.github.com/repos/openshift/origin-web-console/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":62,"created_at":"2017-09-15T04:09:27Z","updated_at":"2017-10-17T15:28:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/2083","html_url":"https://github.com/openshift/origin-web-console/pull/2083","diff_url":"https://github.com/openshift/origin-web-console/pull/2083.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/2083.patch"},"body":"https://trello.com/c/w3vdwj85\r\n\r\nfix #2200\r\n\r\nBased off of #2068, though not really dependent.  Related to #1473, a previous attempt at getting our e2e tests running.\r\n\r\nDepends on #2268 for junit additions.\r\n\r\nNOTE: this PR currently contains a backup of `node_modules/protractor` in `test/package_backups/protractor`, which accounts for many of the listed files changed (166!)\r\n\r\nTODO:\r\n- [x] Update dependencies \r\n- [x] Update `.conf.js` files \r\n- [x] Eliminate special Mac conf if possible\r\n- [x] Create helpers for testing non-angular pages (login page) - `helpers/nonAngular.js`\r\n- [x] Get e2e tests running locally in Chrome\r\n-  ~Get e2e tests running locally in Firefox~\r\n-  ~Get e2e tests running in PhantomJS or Nightmare~ \r\n- [x] Get e2e tests running in CI in headless Chrome\r\n- [x] Fix tests broken since updates\r\n\r\nISSUES:\r\n- ~Accepting certs does not work in Firefox~ (now using chrome)\r\n- ~Need to run `grunt serve` once in order to accept certs~ (not with chrome)\r\n- ~Webdriver manager is a huge hassle due to a dependence on Github's API, which is aggressively rate-limited when non-authenticated. It attempts to use the API to detect a good Selenium server to download.  `npm install` works fine outside of the office, but in office the rate-limit is always exceeded (IP address specific I suppose).  This is a known issue, links in comments below.~ (appears to have resolved on its own, unfortunately I think these dependencies can change under us)\r\n\r\nFirefox ESR download links for testing locally (match jenkins):\r\n- [FF 52.4 (latest & broken)](https://download.mozilla.org/?product=firefox-52.4.0esr-SSL&os=osx&lang=en-US)\r\n- [FF 52.3 (latest working for our tests)](https://download.mozilla.org/?product=firefox-52.3.0esr-SSL&os=osx&lang=en-US)\r\n(this PR/branch will not work with these verisons of FF, but our current setup with Protractor 1.x should work)\r\n\r\nFor reference, [Downgrade of FF in Jenkins PR](https://github.com/openshift/aos-cd-jobs/pull/704)\r\nFor reference, [jenkins config file](https://github.com/openshift/aos-cd-jobs/blob/master/sjb/config/test_cases/test_branch_origin_web_console.yml#L13)\r\n\r\n@spadgett "},"comment":{"url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments/337270068","html_url":"https://github.com/openshift/origin-web-console/pull/2083#issuecomment-337270068","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/2083","id":337270068,"user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"created_at":"2017-10-17T15:28:06Z","updated_at":"2017-10-17T15:28:06Z","author_association":"CONTRIBUTOR","body":"/test\r\n\r\nfor flakes."}}
{"actor":{"display_login":"benjaminapetersen"}}