{"action":"created","comment":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/129114204","pull_request_review_id":51854308,"id":129114204,"diff_hunk":"@@ -0,0 +1,62 @@\n+#! /usr/bin/env python\n+\n+import subprocess\n+import sys\n+import os\n+\n+if len(sys.argv)!=2:\n+  print 'usage: sub_test COMPILER'\n+  sys.exit(0)\n+\n+# Find the base installation\n+compiler=sys.argv[1]\n+if not os.access(compiler,os.R_OK|os.X_OK):\n+  Fatal('Cannot execute compiler \\''+compiler+'\\'')\n+\n+# find current directory\n+\n+def run(source, exe_name, compopts, expect): \n+  p = subprocess.Popen([compiler, source] + compopts,\n+                       stdout=subprocess.PIPE)\n+  myoutput = p.communicate()[0]\n+  sys.stdout.write(myoutput)\n+  if p.returncode != 0:\n+    sys.stdout.write(\"[Error matching compiler output for %s (%s)]\\n\"%(source, exe_name))\n+    sys.exit(1)\n+  else:\n+    sys.stdout.write(\"[Success compiling %s (%s)]\\n\"%(source, exe_name))\n+\n+  returncode = -1\n+  myoutput = \"\"\n+\n+  if os.access(exe_name,os.R_OK|os.X_OK):\n+\n+    numlocales = \"0\"\n+    if \"NUMLOCALES\" in os.environ:\n+      numlocales = os.environ['NUMLOCALES']\n+\n+    if numlocales == \"0\":\n+      p = subprocess.Popen([\"./%s\" % exe_name], stdout=subprocess.PIPE)\n+    else:\n+      p = subprocess.Popen([\"./%s\" % exe_name, \"-nl%s\" % numlocales],\n+          stdout=subprocess.PIPE)\n+\n+    myoutput = p.communicate()[0]\n+    returncode = p.returncode\n+\n+  myoutput = myoutput.strip()\n+  if returncode == 0 and myoutput == expect:\n+    sys.stdout.write(\"[Success matching program output for %s (%s)]\\n\"%(source, exe_name))\n+  else:\n+    sys.stdout.write(\"[Error matching program output for %s (%s)]\\n\"%(source, exe_name))\n+\n+  if os.access(exe_name, os.F_OK):\n+    os.remove(exe_name)\n+  if os.access(exe_name + \"_real\", os.F_OK):\n+    os.remove(exe_name + \"_real\")\n+\n+\n+run(\"test-default-binary-name.chpl\", \"test-default-binary-name\", [], \"Hello\")\n+run(\"test-default-binary-name.chpl\", \"test_exe\", [\"-o\", \"test_exe\"], \"Hello\")","path":"test/compflags/ferguson/default-binary-name/sub_test","position":60,"original_position":60,"commit_id":"bf859b3da99e99863ef51dee9781d995305fe9b0","original_commit_id":"bf859b3da99e99863ef51dee9781d995305fe9b0","user":{"login":"daviditen","id":7740834,"avatar_url":"https://avatars0.githubusercontent.com/u/7740834?v=4","gravatar_id":"","url":"https://api.github.com/users/daviditen","html_url":"https://github.com/daviditen","followers_url":"https://api.github.com/users/daviditen/followers","following_url":"https://api.github.com/users/daviditen/following{/other_user}","gists_url":"https://api.github.com/users/daviditen/gists{/gist_id}","starred_url":"https://api.github.com/users/daviditen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviditen/subscriptions","organizations_url":"https://api.github.com/users/daviditen/orgs","repos_url":"https://api.github.com/users/daviditen/repos","events_url":"https://api.github.com/users/daviditen/events{/privacy}","received_events_url":"https://api.github.com/users/daviditen/received_events","type":"User","site_admin":false},"body":"Could you add another test that sets CHPL_EXE_NAME to \"test_exe\" to show that setting it through the environment variable still works as expected?","created_at":"2017-07-24T18:19:17Z","updated_at":"2017-07-24T18:19:17Z","html_url":"https://github.com/chapel-lang/chapel/pull/6811#discussion_r129114204","pull_request_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/6811","_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments/129114204"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/6811#discussion_r129114204"},"pull_request":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/6811"}}},"pull_request":{"url":"https://api.github.com/repos/chapel-lang/chapel/pulls/6811","id":132055768,"html_url":"https://github.com/chapel-lang/chapel/pull/6811","diff_url":"https://github.com/chapel-lang/chapel/pull/6811.diff","patch_url":"https://github.com/chapel-lang/chapel/pull/6811.patch","issue_url":"https://api.github.com/repos/chapel-lang/chapel/issues/6811","number":6811,"state":"open","locked":false,"title":"Default executable name based on main module name not a.out","user":{"login":"mppf","id":3653132,"avatar_url":"https://avatars3.githubusercontent.com/u/3653132?v=4","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"body":"Closes #6283.\r\n\r\nFollowing the proposal in that issue, the default executable name is now based upon the main module (which is typically the name of the .chpl file supplied on the command line).\r\n\r\nAdds a custom sub_test-based test to check that this works correctly. The normal sub_test script always supplies a `-o` argument and that is why a custom script is used to test this feature.\r\n\r\nVerified new test passes with quickstart+GASNet.\r\nPassed full local testing.","created_at":"2017-07-24T13:54:32Z","updated_at":"2017-07-24T18:19:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f2589bca20d951a528cbc272e6cd7641474226f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/6811/commits","review_comments_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/6811/comments","review_comment_url":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/issues/6811/comments","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/bf859b3da99e99863ef51dee9781d995305fe9b0","head":{"label":"mppf:no-a.out","ref":"no-a.out","sha":"bf859b3da99e99863ef51dee9781d995305fe9b0","user":{"login":"mppf","id":3653132,"avatar_url":"https://avatars3.githubusercontent.com/u/3653132?v=4","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"repo":{"id":22106313,"name":"chapel","full_name":"mppf/chapel","owner":{"login":"mppf","id":3653132,"avatar_url":"https://avatars3.githubusercontent.com/u/3653132?v=4","gravatar_id":"","url":"https://api.github.com/users/mppf","html_url":"https://github.com/mppf","followers_url":"https://api.github.com/users/mppf/followers","following_url":"https://api.github.com/users/mppf/following{/other_user}","gists_url":"https://api.github.com/users/mppf/gists{/gist_id}","starred_url":"https://api.github.com/users/mppf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mppf/subscriptions","organizations_url":"https://api.github.com/users/mppf/orgs","repos_url":"https://api.github.com/users/mppf/repos","events_url":"https://api.github.com/users/mppf/events{/privacy}","received_events_url":"https://api.github.com/users/mppf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mppf/chapel","description":"a Productive Parallel Programming Language","fork":true,"url":"https://api.github.com/repos/mppf/chapel","forks_url":"https://api.github.com/repos/mppf/chapel/forks","keys_url":"https://api.github.com/repos/mppf/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mppf/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mppf/chapel/teams","hooks_url":"https://api.github.com/repos/mppf/chapel/hooks","issue_events_url":"https://api.github.com/repos/mppf/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/mppf/chapel/events","assignees_url":"https://api.github.com/repos/mppf/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/mppf/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/mppf/chapel/tags","blobs_url":"https://api.github.com/repos/mppf/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mppf/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mppf/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/mppf/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mppf/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/mppf/chapel/languages","stargazers_url":"https://api.github.com/repos/mppf/chapel/stargazers","contributors_url":"https://api.github.com/repos/mppf/chapel/contributors","subscribers_url":"https://api.github.com/repos/mppf/chapel/subscribers","subscription_url":"https://api.github.com/repos/mppf/chapel/subscription","commits_url":"https://api.github.com/repos/mppf/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/mppf/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/mppf/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/mppf/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/mppf/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/mppf/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mppf/chapel/merges","archive_url":"https://api.github.com/repos/mppf/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mppf/chapel/downloads","issues_url":"https://api.github.com/repos/mppf/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/mppf/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/mppf/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/mppf/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mppf/chapel/labels{/name}","releases_url":"https://api.github.com/repos/mppf/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/mppf/chapel/deployments","created_at":"2014-07-22T14:05:45Z","updated_at":"2016-01-11T15:01:10Z","pushed_at":"2017-07-24T18:05:48Z","git_url":"git://github.com/mppf/chapel.git","ssh_url":"git@github.com:mppf/chapel.git","clone_url":"https://github.com/mppf/chapel.git","svn_url":"https://github.com/mppf/chapel","homepage":"http://chapel.cray.com/","size":412398,"stargazers_count":1,"watchers_count":1,"language":"Chapel","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"chapel-lang:master","ref":"master","sha":"b53c90eb6959e72dcf889b58ca2e8e30e34d8d0e","user":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars2.githubusercontent.com/u/7597261?v=4","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":21663285,"name":"chapel","full_name":"chapel-lang/chapel","owner":{"login":"chapel-lang","id":7597261,"avatar_url":"https://avatars2.githubusercontent.com/u/7597261?v=4","gravatar_id":"","url":"https://api.github.com/users/chapel-lang","html_url":"https://github.com/chapel-lang","followers_url":"https://api.github.com/users/chapel-lang/followers","following_url":"https://api.github.com/users/chapel-lang/following{/other_user}","gists_url":"https://api.github.com/users/chapel-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/chapel-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chapel-lang/subscriptions","organizations_url":"https://api.github.com/users/chapel-lang/orgs","repos_url":"https://api.github.com/users/chapel-lang/repos","events_url":"https://api.github.com/users/chapel-lang/events{/privacy}","received_events_url":"https://api.github.com/users/chapel-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chapel-lang/chapel","description":"a Productive Parallel Programming Language","fork":false,"url":"https://api.github.com/repos/chapel-lang/chapel","forks_url":"https://api.github.com/repos/chapel-lang/chapel/forks","keys_url":"https://api.github.com/repos/chapel-lang/chapel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chapel-lang/chapel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chapel-lang/chapel/teams","hooks_url":"https://api.github.com/repos/chapel-lang/chapel/hooks","issue_events_url":"https://api.github.com/repos/chapel-lang/chapel/issues/events{/number}","events_url":"https://api.github.com/repos/chapel-lang/chapel/events","assignees_url":"https://api.github.com/repos/chapel-lang/chapel/assignees{/user}","branches_url":"https://api.github.com/repos/chapel-lang/chapel/branches{/branch}","tags_url":"https://api.github.com/repos/chapel-lang/chapel/tags","blobs_url":"https://api.github.com/repos/chapel-lang/chapel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chapel-lang/chapel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chapel-lang/chapel/git/refs{/sha}","trees_url":"https://api.github.com/repos/chapel-lang/chapel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chapel-lang/chapel/statuses/{sha}","languages_url":"https://api.github.com/repos/chapel-lang/chapel/languages","stargazers_url":"https://api.github.com/repos/chapel-lang/chapel/stargazers","contributors_url":"https://api.github.com/repos/chapel-lang/chapel/contributors","subscribers_url":"https://api.github.com/repos/chapel-lang/chapel/subscribers","subscription_url":"https://api.github.com/repos/chapel-lang/chapel/subscription","commits_url":"https://api.github.com/repos/chapel-lang/chapel/commits{/sha}","git_commits_url":"https://api.github.com/repos/chapel-lang/chapel/git/commits{/sha}","comments_url":"https://api.github.com/repos/chapel-lang/chapel/comments{/number}","issue_comment_url":"https://api.github.com/repos/chapel-lang/chapel/issues/comments{/number}","contents_url":"https://api.github.com/repos/chapel-lang/chapel/contents/{+path}","compare_url":"https://api.github.com/repos/chapel-lang/chapel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chapel-lang/chapel/merges","archive_url":"https://api.github.com/repos/chapel-lang/chapel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chapel-lang/chapel/downloads","issues_url":"https://api.github.com/repos/chapel-lang/chapel/issues{/number}","pulls_url":"https://api.github.com/repos/chapel-lang/chapel/pulls{/number}","milestones_url":"https://api.github.com/repos/chapel-lang/chapel/milestones{/number}","notifications_url":"https://api.github.com/repos/chapel-lang/chapel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chapel-lang/chapel/labels{/name}","releases_url":"https://api.github.com/repos/chapel-lang/chapel/releases{/id}","deployments_url":"https://api.github.com/repos/chapel-lang/chapel/deployments","created_at":"2014-07-09T18:15:54Z","updated_at":"2017-07-22T10:47:46Z","pushed_at":"2017-07-24T18:05:50Z","git_url":"git://github.com/chapel-lang/chapel.git","ssh_url":"git@github.com:chapel-lang/chapel.git","clone_url":"https://github.com/chapel-lang/chapel.git","svn_url":"https://github.com/chapel-lang/chapel","homepage":"http://chapel.cray.com/","size":417962,"stargazers_count":478,"watchers_count":478,"language":"Chapel","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":368,"forks":145,"open_issues":368,"watchers":478,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/6811"},"html":{"href":"https://github.com/chapel-lang/chapel/pull/6811"},"issue":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/6811"},"comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/issues/6811/comments"},"review_comments":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/6811/comments"},"review_comment":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chapel-lang/chapel/pulls/6811/commits"},"statuses":{"href":"https://api.github.com/repos/chapel-lang/chapel/statuses/bf859b3da99e99863ef51dee9781d995305fe9b0"}}}}
{"actor":{"display_login":"daviditen"}}