{"action":"created","comment":{"url":"https://api.github.com/repos/benvanik/xenia/pulls/comments/140645963","pull_request_review_id":64752258,"id":140645963,"diff_hunk":"@@ -995,6 +1030,34 @@ bool VulkanCommandProcessor::IssueCopy() {\n   int32_t dest_max_y = int32_t(\n       (std::max(std::max(dest_points[1], dest_points[3]), dest_points[5])));\n \n+  // Search recently used window scissor sizes for the actual dimensions of\n+  // this copy (instead of the rounded-out tile size we currently have)","path":"src/xenia/gpu/vulkan/vulkan_command_processor.cc","position":47,"original_position":47,"commit_id":"2748e94e23339920e529ce5005e88873e38f7354","original_commit_id":"2748e94e23339920e529ce5005e88873e38f7354","user":{"login":"sabretooth","id":463457,"avatar_url":"https://avatars0.githubusercontent.com/u/463457?v=4","gravatar_id":"","url":"https://api.github.com/users/sabretooth","html_url":"https://github.com/sabretooth","followers_url":"https://api.github.com/users/sabretooth/followers","following_url":"https://api.github.com/users/sabretooth/following{/other_user}","gists_url":"https://api.github.com/users/sabretooth/gists{/gist_id}","starred_url":"https://api.github.com/users/sabretooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabretooth/subscriptions","organizations_url":"https://api.github.com/users/sabretooth/orgs","repos_url":"https://api.github.com/users/sabretooth/repos","events_url":"https://api.github.com/users/sabretooth/events{/privacy}","received_events_url":"https://api.github.com/users/sabretooth/received_events","type":"User","site_admin":false},"body":"The RB_COPY_* registers don't contain the true image width, just the surface pitch (which is too large). The RB_COPY_DEST_PITCH register does contain the true height, so I should use that. Still, I've not found a register that contains the true width.\r\n\r\nMy understanding is that the copy command doesn't actually need the true (pixel-accurate) width because the GPU stores the texture in a padded/aligned format anyway, rounding up to the next block size, and that the cropping from surface pitch to actual width is handled at texture fetch time.","created_at":"2017-09-24T02:53:15Z","updated_at":"2017-09-24T02:53:15Z","html_url":"https://github.com/benvanik/xenia/pull/789#discussion_r140645963","pull_request_url":"https://api.github.com/repos/benvanik/xenia/pulls/789","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/benvanik/xenia/pulls/comments/140645963"},"html":{"href":"https://github.com/benvanik/xenia/pull/789#discussion_r140645963"},"pull_request":{"href":"https://api.github.com/repos/benvanik/xenia/pulls/789"}},"in_reply_to_id":140645743},"pull_request":{"url":"https://api.github.com/repos/benvanik/xenia/pulls/789","id":141976932,"html_url":"https://github.com/benvanik/xenia/pull/789","diff_url":"https://github.com/benvanik/xenia/pull/789.diff","patch_url":"https://github.com/benvanik/xenia/pull/789.patch","issue_url":"https://api.github.com/repos/benvanik/xenia/issues/789","number":789,"state":"open","locked":false,"title":"Rendering and emulation fixes for Geometry Wars RE2","user":{"login":"sabretooth","id":463457,"avatar_url":"https://avatars0.githubusercontent.com/u/463457?v=4","gravatar_id":"","url":"https://api.github.com/users/sabretooth","html_url":"https://github.com/sabretooth","followers_url":"https://api.github.com/users/sabretooth/followers","following_url":"https://api.github.com/users/sabretooth/following{/other_user}","gists_url":"https://api.github.com/users/sabretooth/gists{/gist_id}","starred_url":"https://api.github.com/users/sabretooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabretooth/subscriptions","organizations_url":"https://api.github.com/users/sabretooth/orgs","repos_url":"https://api.github.com/users/sabretooth/repos","events_url":"https://api.github.com/users/sabretooth/events{/privacy}","received_events_url":"https://api.github.com/users/sabretooth/received_events","type":"User","site_admin":false},"body":"A couple of minor changes (2e4413e and d82f37a) to get the game booting, and then rendering fixes. \r\n\r\nCommit b34350e9 (TextureCache: Remove distinction between resolve textures and regular textures) broke all of the render-to-texture effects in this game (and presumably others), so reimplement that feature in e1d576d.\r\n\r\nThis game uses a depth-only render pass with a fullscreen quad at z=0 to zero out relevant EDRAM tiles prior to color rendering. The EDRAM tile store isn't emulated well enough for this to work yet, but a quick hack in a2ab3b3 gets the game rendering with correct clearing.\r\n\r\nAfter applying these changes, the game boots and renders (nearly) correctly with all visual effects applied. There are still a couple of issues: some (mainly UI) elements are the wrong color, there are missing audio channels in the menu background music, and the whole audio mix runs about 500ms behind gameplay.\r\n","created_at":"2017-09-19T23:07:01Z","updated_at":"2017-09-24T02:53:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"87f4bca7a530be6d4ce333436606399b5437ff92","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/benvanik/xenia/pulls/789/commits","review_comments_url":"https://api.github.com/repos/benvanik/xenia/pulls/789/comments","review_comment_url":"https://api.github.com/repos/benvanik/xenia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/benvanik/xenia/issues/789/comments","statuses_url":"https://api.github.com/repos/benvanik/xenia/statuses/2748e94e23339920e529ce5005e88873e38f7354","head":{"label":"sabretooth:gwre2-fixes","ref":"gwre2-fixes","sha":"2748e94e23339920e529ce5005e88873e38f7354","user":{"login":"sabretooth","id":463457,"avatar_url":"https://avatars0.githubusercontent.com/u/463457?v=4","gravatar_id":"","url":"https://api.github.com/users/sabretooth","html_url":"https://github.com/sabretooth","followers_url":"https://api.github.com/users/sabretooth/followers","following_url":"https://api.github.com/users/sabretooth/following{/other_user}","gists_url":"https://api.github.com/users/sabretooth/gists{/gist_id}","starred_url":"https://api.github.com/users/sabretooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabretooth/subscriptions","organizations_url":"https://api.github.com/users/sabretooth/orgs","repos_url":"https://api.github.com/users/sabretooth/repos","events_url":"https://api.github.com/users/sabretooth/events{/privacy}","received_events_url":"https://api.github.com/users/sabretooth/received_events","type":"User","site_admin":false},"repo":{"id":45872349,"name":"xenia","full_name":"sabretooth/xenia","owner":{"login":"sabretooth","id":463457,"avatar_url":"https://avatars0.githubusercontent.com/u/463457?v=4","gravatar_id":"","url":"https://api.github.com/users/sabretooth","html_url":"https://github.com/sabretooth","followers_url":"https://api.github.com/users/sabretooth/followers","following_url":"https://api.github.com/users/sabretooth/following{/other_user}","gists_url":"https://api.github.com/users/sabretooth/gists{/gist_id}","starred_url":"https://api.github.com/users/sabretooth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sabretooth/subscriptions","organizations_url":"https://api.github.com/users/sabretooth/orgs","repos_url":"https://api.github.com/users/sabretooth/repos","events_url":"https://api.github.com/users/sabretooth/events{/privacy}","received_events_url":"https://api.github.com/users/sabretooth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sabretooth/xenia","description":"Xbox 360 Emulator Research Project ","fork":true,"url":"https://api.github.com/repos/sabretooth/xenia","forks_url":"https://api.github.com/repos/sabretooth/xenia/forks","keys_url":"https://api.github.com/repos/sabretooth/xenia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sabretooth/xenia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sabretooth/xenia/teams","hooks_url":"https://api.github.com/repos/sabretooth/xenia/hooks","issue_events_url":"https://api.github.com/repos/sabretooth/xenia/issues/events{/number}","events_url":"https://api.github.com/repos/sabretooth/xenia/events","assignees_url":"https://api.github.com/repos/sabretooth/xenia/assignees{/user}","branches_url":"https://api.github.com/repos/sabretooth/xenia/branches{/branch}","tags_url":"https://api.github.com/repos/sabretooth/xenia/tags","blobs_url":"https://api.github.com/repos/sabretooth/xenia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sabretooth/xenia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sabretooth/xenia/git/refs{/sha}","trees_url":"https://api.github.com/repos/sabretooth/xenia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sabretooth/xenia/statuses/{sha}","languages_url":"https://api.github.com/repos/sabretooth/xenia/languages","stargazers_url":"https://api.github.com/repos/sabretooth/xenia/stargazers","contributors_url":"https://api.github.com/repos/sabretooth/xenia/contributors","subscribers_url":"https://api.github.com/repos/sabretooth/xenia/subscribers","subscription_url":"https://api.github.com/repos/sabretooth/xenia/subscription","commits_url":"https://api.github.com/repos/sabretooth/xenia/commits{/sha}","git_commits_url":"https://api.github.com/repos/sabretooth/xenia/git/commits{/sha}","comments_url":"https://api.github.com/repos/sabretooth/xenia/comments{/number}","issue_comment_url":"https://api.github.com/repos/sabretooth/xenia/issues/comments{/number}","contents_url":"https://api.github.com/repos/sabretooth/xenia/contents/{+path}","compare_url":"https://api.github.com/repos/sabretooth/xenia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sabretooth/xenia/merges","archive_url":"https://api.github.com/repos/sabretooth/xenia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sabretooth/xenia/downloads","issues_url":"https://api.github.com/repos/sabretooth/xenia/issues{/number}","pulls_url":"https://api.github.com/repos/sabretooth/xenia/pulls{/number}","milestones_url":"https://api.github.com/repos/sabretooth/xenia/milestones{/number}","notifications_url":"https://api.github.com/repos/sabretooth/xenia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sabretooth/xenia/labels{/name}","releases_url":"https://api.github.com/repos/sabretooth/xenia/releases{/id}","deployments_url":"https://api.github.com/repos/sabretooth/xenia/deployments","created_at":"2015-11-09T22:55:23Z","updated_at":"2016-12-28T08:15:14Z","pushed_at":"2017-09-24T02:26:15Z","git_url":"git://github.com/sabretooth/xenia.git","ssh_url":"git@github.com:sabretooth/xenia.git","clone_url":"https://github.com/sabretooth/xenia.git","svn_url":"https://github.com/sabretooth/xenia","homepage":"http://xenia.jp","size":19943,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"benvanik:master","ref":"master","sha":"d35ee68d678935f230a4461099fca8523ede5aa5","user":{"login":"benvanik","id":75337,"avatar_url":"https://avatars0.githubusercontent.com/u/75337?v=4","gravatar_id":"","url":"https://api.github.com/users/benvanik","html_url":"https://github.com/benvanik","followers_url":"https://api.github.com/users/benvanik/followers","following_url":"https://api.github.com/users/benvanik/following{/other_user}","gists_url":"https://api.github.com/users/benvanik/gists{/gist_id}","starred_url":"https://api.github.com/users/benvanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benvanik/subscriptions","organizations_url":"https://api.github.com/users/benvanik/orgs","repos_url":"https://api.github.com/users/benvanik/repos","events_url":"https://api.github.com/users/benvanik/events{/privacy}","received_events_url":"https://api.github.com/users/benvanik/received_events","type":"User","site_admin":false},"repo":{"id":7550637,"name":"xenia","full_name":"benvanik/xenia","owner":{"login":"benvanik","id":75337,"avatar_url":"https://avatars0.githubusercontent.com/u/75337?v=4","gravatar_id":"","url":"https://api.github.com/users/benvanik","html_url":"https://github.com/benvanik","followers_url":"https://api.github.com/users/benvanik/followers","following_url":"https://api.github.com/users/benvanik/following{/other_user}","gists_url":"https://api.github.com/users/benvanik/gists{/gist_id}","starred_url":"https://api.github.com/users/benvanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benvanik/subscriptions","organizations_url":"https://api.github.com/users/benvanik/orgs","repos_url":"https://api.github.com/users/benvanik/repos","events_url":"https://api.github.com/users/benvanik/events{/privacy}","received_events_url":"https://api.github.com/users/benvanik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benvanik/xenia","description":"Xbox 360 Emulator Research Project ","fork":false,"url":"https://api.github.com/repos/benvanik/xenia","forks_url":"https://api.github.com/repos/benvanik/xenia/forks","keys_url":"https://api.github.com/repos/benvanik/xenia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benvanik/xenia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benvanik/xenia/teams","hooks_url":"https://api.github.com/repos/benvanik/xenia/hooks","issue_events_url":"https://api.github.com/repos/benvanik/xenia/issues/events{/number}","events_url":"https://api.github.com/repos/benvanik/xenia/events","assignees_url":"https://api.github.com/repos/benvanik/xenia/assignees{/user}","branches_url":"https://api.github.com/repos/benvanik/xenia/branches{/branch}","tags_url":"https://api.github.com/repos/benvanik/xenia/tags","blobs_url":"https://api.github.com/repos/benvanik/xenia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benvanik/xenia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benvanik/xenia/git/refs{/sha}","trees_url":"https://api.github.com/repos/benvanik/xenia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benvanik/xenia/statuses/{sha}","languages_url":"https://api.github.com/repos/benvanik/xenia/languages","stargazers_url":"https://api.github.com/repos/benvanik/xenia/stargazers","contributors_url":"https://api.github.com/repos/benvanik/xenia/contributors","subscribers_url":"https://api.github.com/repos/benvanik/xenia/subscribers","subscription_url":"https://api.github.com/repos/benvanik/xenia/subscription","commits_url":"https://api.github.com/repos/benvanik/xenia/commits{/sha}","git_commits_url":"https://api.github.com/repos/benvanik/xenia/git/commits{/sha}","comments_url":"https://api.github.com/repos/benvanik/xenia/comments{/number}","issue_comment_url":"https://api.github.com/repos/benvanik/xenia/issues/comments{/number}","contents_url":"https://api.github.com/repos/benvanik/xenia/contents/{+path}","compare_url":"https://api.github.com/repos/benvanik/xenia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benvanik/xenia/merges","archive_url":"https://api.github.com/repos/benvanik/xenia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benvanik/xenia/downloads","issues_url":"https://api.github.com/repos/benvanik/xenia/issues{/number}","pulls_url":"https://api.github.com/repos/benvanik/xenia/pulls{/number}","milestones_url":"https://api.github.com/repos/benvanik/xenia/milestones{/number}","notifications_url":"https://api.github.com/repos/benvanik/xenia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benvanik/xenia/labels{/name}","releases_url":"https://api.github.com/repos/benvanik/xenia/releases{/id}","deployments_url":"https://api.github.com/repos/benvanik/xenia/deployments","created_at":"2013-01-10T23:20:45Z","updated_at":"2017-09-22T21:52:24Z","pushed_at":"2017-09-24T02:26:17Z","git_url":"git://github.com/benvanik/xenia.git","ssh_url":"git@github.com:benvanik/xenia.git","clone_url":"https://github.com/benvanik/xenia.git","svn_url":"https://github.com/benvanik/xenia","homepage":"http://xenia.jp","size":19891,"stargazers_count":2698,"watchers_count":2698,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":355,"mirror_url":null,"open_issues_count":124,"forks":355,"open_issues":124,"watchers":2698,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/benvanik/xenia/pulls/789"},"html":{"href":"https://github.com/benvanik/xenia/pull/789"},"issue":{"href":"https://api.github.com/repos/benvanik/xenia/issues/789"},"comments":{"href":"https://api.github.com/repos/benvanik/xenia/issues/789/comments"},"review_comments":{"href":"https://api.github.com/repos/benvanik/xenia/pulls/789/comments"},"review_comment":{"href":"https://api.github.com/repos/benvanik/xenia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/benvanik/xenia/pulls/789/commits"},"statuses":{"href":"https://api.github.com/repos/benvanik/xenia/statuses/2748e94e23339920e529ce5005e88873e38f7354"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sabretooth"}}