{"action":"created","comment":{"url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments/129811773","pull_request_review_id":52622256,"id":129811773,"diff_hunk":"@@ -355,23 +355,25 @@ def self.initialize_ldap_con(user_name, password)\n     nil\n   end\n \n+  def self.ldap_port\n+    return CONFIG['ldap_port'] if CONFIG['ldap_port']\n+\n+    CONFIG['ldap_ssl'] == :on ? 636 : 389\n+  end\n+\n   def self.try_ldap_con(server, user_name, password)\n     # implicitly turn array into string\n     user_name = [user_name].flatten.join('')\n \n     Rails.logger.debug(\"Connecting to #{server} as '#{user_name}'\")\n+    port = ldap_port\n+\n     begin\n-      if CONFIG.has_key?('ldap_ssl') && CONFIG['ldap_ssl'] == :on\n-        port = CONFIG.has_key?('ldap_port') ? CONFIG['ldap_port'] : 636\n-        conn = LDAP::SSLConn.new(server, port)\n+      if CONFIG['ldap_ssl'] == :on || CONFIG['ldap_start_tls'] == :on","path":"src/api/app/models/user_ldap_strategy.rb","position":null,"original_position":21,"commit_id":"5f04af253ce88c658a3e7db33d7a6476facf244d","original_commit_id":"ee697a1238d187e84b7ece23bd98e0f97e5da961","user":{"login":"bgeuken","id":968949,"avatar_url":"https://avatars2.githubusercontent.com/u/968949?v=4","gravatar_id":"","url":"https://api.github.com/users/bgeuken","html_url":"https://github.com/bgeuken","followers_url":"https://api.github.com/users/bgeuken/followers","following_url":"https://api.github.com/users/bgeuken/following{/other_user}","gists_url":"https://api.github.com/users/bgeuken/gists{/gist_id}","starred_url":"https://api.github.com/users/bgeuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgeuken/subscriptions","organizations_url":"https://api.github.com/users/bgeuken/orgs","repos_url":"https://api.github.com/users/bgeuken/repos","events_url":"https://api.github.com/users/bgeuken/events{/privacy}","received_events_url":"https://api.github.com/users/bgeuken/received_events","type":"User","site_admin":false},"body":"This now fails with rubocop complaining about Style/IfInsideElse. I change it back again.\r\n\r\n","created_at":"2017-07-27T10:59:05Z","updated_at":"2017-07-27T10:59:05Z","html_url":"https://github.com/openSUSE/open-build-service/pull/3453#discussion_r129811773","pull_request_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/3453","_links":{"self":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments/129811773"},"html":{"href":"https://github.com/openSUSE/open-build-service/pull/3453#discussion_r129811773"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/3453"}}},"pull_request":{"url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/3453","id":132605349,"html_url":"https://github.com/openSUSE/open-build-service/pull/3453","diff_url":"https://github.com/openSUSE/open-build-service/pull/3453.diff","patch_url":"https://github.com/openSUSE/open-build-service/pull/3453.patch","issue_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/3453","number":3453,"state":"open","locked":false,"title":"Ldap con tests","user":{"login":"bgeuken","id":968949,"avatar_url":"https://avatars2.githubusercontent.com/u/968949?v=4","gravatar_id":"","url":"https://api.github.com/users/bgeuken","html_url":"https://github.com/bgeuken","followers_url":"https://api.github.com/users/bgeuken/followers","following_url":"https://api.github.com/users/bgeuken/following{/other_user}","gists_url":"https://api.github.com/users/bgeuken/gists{/gist_id}","starred_url":"https://api.github.com/users/bgeuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgeuken/subscriptions","organizations_url":"https://api.github.com/users/bgeuken/orgs","repos_url":"https://api.github.com/users/bgeuken/repos","events_url":"https://api.github.com/users/bgeuken/events{/privacy}","received_events_url":"https://api.github.com/users/bgeuken/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-26T20:22:37Z","updated_at":"2017-07-27T10:59:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ba88c37021a98b0a40721a776429a28d75e1b28","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/3453/commits","review_comments_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/3453/comments","review_comment_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/3453/comments","statuses_url":"https://api.github.com/repos/openSUSE/open-build-service/statuses/5f04af253ce88c658a3e7db33d7a6476facf244d","head":{"label":"bgeuken:ldap_con_tests","ref":"ldap_con_tests","sha":"5f04af253ce88c658a3e7db33d7a6476facf244d","user":{"login":"bgeuken","id":968949,"avatar_url":"https://avatars2.githubusercontent.com/u/968949?v=4","gravatar_id":"","url":"https://api.github.com/users/bgeuken","html_url":"https://github.com/bgeuken","followers_url":"https://api.github.com/users/bgeuken/followers","following_url":"https://api.github.com/users/bgeuken/following{/other_user}","gists_url":"https://api.github.com/users/bgeuken/gists{/gist_id}","starred_url":"https://api.github.com/users/bgeuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgeuken/subscriptions","organizations_url":"https://api.github.com/users/bgeuken/orgs","repos_url":"https://api.github.com/users/bgeuken/repos","events_url":"https://api.github.com/users/bgeuken/events{/privacy}","received_events_url":"https://api.github.com/users/bgeuken/received_events","type":"User","site_admin":false},"repo":{"id":10003040,"name":"open-build-service","full_name":"bgeuken/open-build-service","owner":{"login":"bgeuken","id":968949,"avatar_url":"https://avatars2.githubusercontent.com/u/968949?v=4","gravatar_id":"","url":"https://api.github.com/users/bgeuken","html_url":"https://github.com/bgeuken","followers_url":"https://api.github.com/users/bgeuken/followers","following_url":"https://api.github.com/users/bgeuken/following{/other_user}","gists_url":"https://api.github.com/users/bgeuken/gists{/gist_id}","starred_url":"https://api.github.com/users/bgeuken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgeuken/subscriptions","organizations_url":"https://api.github.com/users/bgeuken/orgs","repos_url":"https://api.github.com/users/bgeuken/repos","events_url":"https://api.github.com/users/bgeuken/events{/privacy}","received_events_url":"https://api.github.com/users/bgeuken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgeuken/open-build-service","description":"A generic system to build and distribute packages from sources in an automatic, consistent and reproducible way. Release your software for a wide range of operating systems and hardware architectures.","fork":true,"url":"https://api.github.com/repos/bgeuken/open-build-service","forks_url":"https://api.github.com/repos/bgeuken/open-build-service/forks","keys_url":"https://api.github.com/repos/bgeuken/open-build-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgeuken/open-build-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgeuken/open-build-service/teams","hooks_url":"https://api.github.com/repos/bgeuken/open-build-service/hooks","issue_events_url":"https://api.github.com/repos/bgeuken/open-build-service/issues/events{/number}","events_url":"https://api.github.com/repos/bgeuken/open-build-service/events","assignees_url":"https://api.github.com/repos/bgeuken/open-build-service/assignees{/user}","branches_url":"https://api.github.com/repos/bgeuken/open-build-service/branches{/branch}","tags_url":"https://api.github.com/repos/bgeuken/open-build-service/tags","blobs_url":"https://api.github.com/repos/bgeuken/open-build-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgeuken/open-build-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgeuken/open-build-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgeuken/open-build-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgeuken/open-build-service/statuses/{sha}","languages_url":"https://api.github.com/repos/bgeuken/open-build-service/languages","stargazers_url":"https://api.github.com/repos/bgeuken/open-build-service/stargazers","contributors_url":"https://api.github.com/repos/bgeuken/open-build-service/contributors","subscribers_url":"https://api.github.com/repos/bgeuken/open-build-service/subscribers","subscription_url":"https://api.github.com/repos/bgeuken/open-build-service/subscription","commits_url":"https://api.github.com/repos/bgeuken/open-build-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgeuken/open-build-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgeuken/open-build-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgeuken/open-build-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgeuken/open-build-service/contents/{+path}","compare_url":"https://api.github.com/repos/bgeuken/open-build-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgeuken/open-build-service/merges","archive_url":"https://api.github.com/repos/bgeuken/open-build-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgeuken/open-build-service/downloads","issues_url":"https://api.github.com/repos/bgeuken/open-build-service/issues{/number}","pulls_url":"https://api.github.com/repos/bgeuken/open-build-service/pulls{/number}","milestones_url":"https://api.github.com/repos/bgeuken/open-build-service/milestones{/number}","notifications_url":"https://api.github.com/repos/bgeuken/open-build-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgeuken/open-build-service/labels{/name}","releases_url":"https://api.github.com/repos/bgeuken/open-build-service/releases{/id}","deployments_url":"https://api.github.com/repos/bgeuken/open-build-service/deployments","created_at":"2013-05-11T17:48:20Z","updated_at":"2015-07-22T13:02:48Z","pushed_at":"2017-07-27T10:33:23Z","git_url":"git://github.com/bgeuken/open-build-service.git","ssh_url":"git@github.com:bgeuken/open-build-service.git","clone_url":"https://github.com/bgeuken/open-build-service.git","svn_url":"https://github.com/bgeuken/open-build-service","homepage":"http://openbuildservice.org/","size":52169,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openSUSE:master","ref":"master","sha":"b3e7c175da2775011d158fa760d5f3074700df6f","user":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars2.githubusercontent.com/u/623819?v=4","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":2046192,"name":"open-build-service","full_name":"openSUSE/open-build-service","owner":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars2.githubusercontent.com/u/623819?v=4","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/open-build-service","description":"A generic system to build and distribute packages from sources in an automatic, consistent and reproducible way. Release your software for a wide range of operating systems and hardware architectures.","fork":false,"url":"https://api.github.com/repos/openSUSE/open-build-service","forks_url":"https://api.github.com/repos/openSUSE/open-build-service/forks","keys_url":"https://api.github.com/repos/openSUSE/open-build-service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/open-build-service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/open-build-service/teams","hooks_url":"https://api.github.com/repos/openSUSE/open-build-service/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/open-build-service/events","assignees_url":"https://api.github.com/repos/openSUSE/open-build-service/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/open-build-service/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/open-build-service/tags","blobs_url":"https://api.github.com/repos/openSUSE/open-build-service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/open-build-service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/open-build-service/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/open-build-service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/open-build-service/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/open-build-service/languages","stargazers_url":"https://api.github.com/repos/openSUSE/open-build-service/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/open-build-service/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/open-build-service/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/open-build-service/subscription","commits_url":"https://api.github.com/repos/openSUSE/open-build-service/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/open-build-service/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/open-build-service/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/open-build-service/issues/comments{/number}","contents_url":"https://api.github.com/repos/openSUSE/open-build-service/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/open-build-service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/open-build-service/merges","archive_url":"https://api.github.com/repos/openSUSE/open-build-service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/open-build-service/downloads","issues_url":"https://api.github.com/repos/openSUSE/open-build-service/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/open-build-service/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/open-build-service/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/open-build-service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/open-build-service/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/open-build-service/releases{/id}","deployments_url":"https://api.github.com/repos/openSUSE/open-build-service/deployments","created_at":"2011-07-14T06:52:57Z","updated_at":"2017-07-27T00:01:44Z","pushed_at":"2017-07-27T10:34:14Z","git_url":"git://github.com/openSUSE/open-build-service.git","ssh_url":"git@github.com:openSUSE/open-build-service.git","clone_url":"https://github.com/openSUSE/open-build-service.git","svn_url":"https://github.com/openSUSE/open-build-service","homepage":"http://openbuildservice.org/","size":52379,"stargazers_count":277,"watchers_count":277,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":188,"mirror_url":null,"open_issues_count":398,"forks":188,"open_issues":398,"watchers":277,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/3453"},"html":{"href":"https://github.com/openSUSE/open-build-service/pull/3453"},"issue":{"href":"https://api.github.com/repos/openSUSE/open-build-service/issues/3453"},"comments":{"href":"https://api.github.com/repos/openSUSE/open-build-service/issues/3453/comments"},"review_comments":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/3453/comments"},"review_comment":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openSUSE/open-build-service/pulls/3453/commits"},"statuses":{"href":"https://api.github.com/repos/openSUSE/open-build-service/statuses/5f04af253ce88c658a3e7db33d7a6476facf244d"}}}}
{"actor":{"display_login":"bgeuken"}}