{"action":"created","comment":{"url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls/comments/107746645","pull_request_review_id":28732532,"id":107746645,"diff_hunk":"@@ -0,0 +1,25 @@\n+from usaspending_api.awards.serializers import FinancialAccountsByAwardsSerializer","path":"usaspending_api/accounts/views/common.py","position":1,"original_position":1,"commit_id":"5b5f292bfb5990d2df33fb853bbb14b2dd0a2d7e","original_commit_id":"5b5f292bfb5990d2df33fb853bbb14b2dd0a2d7e","user":{"login":"bsweger","id":540544,"avatar_url":"https://avatars1.githubusercontent.com/u/540544?v=3","gravatar_id":"","url":"https://api.github.com/users/bsweger","html_url":"https://github.com/bsweger","followers_url":"https://api.github.com/users/bsweger/followers","following_url":"https://api.github.com/users/bsweger/following{/other_user}","gists_url":"https://api.github.com/users/bsweger/gists{/gist_id}","starred_url":"https://api.github.com/users/bsweger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsweger/subscriptions","organizations_url":"https://api.github.com/users/bsweger/orgs","repos_url":"https://api.github.com/users/bsweger/repos","events_url":"https://api.github.com/users/bsweger/events{/privacy}","received_events_url":"https://api.github.com/users/bsweger/received_events","type":"User","site_admin":false},"body":"Poor File C data, we never know where to put it. I figured out that one reason it's hard to find this in the code base is that the model for it lives in the `awards` application and the view for it lives in the `accounts` application. \r\n\r\nIf we had to pick one, I'd go with `accounts`, like you have it here (because that data ultimately can only come from an agency DATA Act submission and not from current USAspending info). Just marking your cards that the next time we have a chance, we might want to move the model over to `accounts` so they can live together.\r\n\r\nLastly, since this data is keyed by TAS, what do you think about moving this single view into `tas.py` and getting rid of `common.py`?","created_at":"2017-03-23T18:21:00Z","updated_at":"2017-03-23T18:54:29Z","html_url":"https://github.com/fedspendingtransparency/usaspending-api/pull/217#discussion_r107746645","pull_request_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls/comments/107746645"},"html":{"href":"https://github.com/fedspendingtransparency/usaspending-api/pull/217#discussion_r107746645"},"pull_request":{"href":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls/217","id":112299334,"html_url":"https://github.com/fedspendingtransparency/usaspending-api/pull/217","diff_url":"https://github.com/fedspendingtransparency/usaspending-api/pull/217.diff","patch_url":"https://github.com/fedspendingtransparency/usaspending-api/pull/217.patch","issue_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/issues/217","number":217,"state":"open","locked":false,"title":"Federal account endpoints","user":{"login":"afrasier","id":6662582,"avatar_url":"https://avatars1.githubusercontent.com/u/6662582?v=3","gravatar_id":"","url":"https://api.github.com/users/afrasier","html_url":"https://github.com/afrasier","followers_url":"https://api.github.com/users/afrasier/followers","following_url":"https://api.github.com/users/afrasier/following{/other_user}","gists_url":"https://api.github.com/users/afrasier/gists{/gist_id}","starred_url":"https://api.github.com/users/afrasier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afrasier/subscriptions","organizations_url":"https://api.github.com/users/afrasier/orgs","repos_url":"https://api.github.com/users/afrasier/repos","events_url":"https://api.github.com/users/afrasier/events{/privacy}","received_events_url":"https://api.github.com/users/afrasier/received_events","type":"User","site_admin":false},"body":"Changes:\r\n\r\n* Added `/federal_accounts/` which will list/retrieve federal account objects\r\n* Added `/federal_accounts/autocomplete` to support autocomplete on federal accounts\r\n* Moved `/accounts/tas/` (And related endpoints `. . balances/` `. . categories/` and `totals`) to `/tas/` ( shout outs to @mab6bf @kevinli-work )\r\n  - `/accounts/tas/` -> `/tas/`\r\n  - `/accounts/tas/autocomplete/` -> `/tas/autocomplete`\r\n  - `/accounts/tas/balances/` -> `/tas/balances/`\r\n  - `/accounts/tas/balances/total/` -> `/tas/balances/total`\r\n  - `/accounts/tas/categories/` -> `/tas/categories/`\r\n  - `/accounts/tas/categories/total` -> `/tas/categories/total`\r\n* Updated documentation for the new endpoints, and refactored endpoint paths\r\n* Added tests for new endpoints, updated tests for refactored endpoints\r\n* Refactored `/accounts/views.py` into 3 files `common.py`, `tas.py`, `federal.py` under the `/accounts/views/` folder\r\n* Refactored urls in `/accounts/urls.py` to `urls.py`, `urls_federal.py` and `urls_tas.py`","created_at":"2017-03-23T17:48:18Z","updated_at":"2017-03-23T18:54:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c11107c96345f3b97593d423c9ad0cba3edaaad0","assignee":{"login":"catherinedevlin","id":208054,"avatar_url":"https://avatars3.githubusercontent.com/u/208054?v=3","gravatar_id":"","url":"https://api.github.com/users/catherinedevlin","html_url":"https://github.com/catherinedevlin","followers_url":"https://api.github.com/users/catherinedevlin/followers","following_url":"https://api.github.com/users/catherinedevlin/following{/other_user}","gists_url":"https://api.github.com/users/catherinedevlin/gists{/gist_id}","starred_url":"https://api.github.com/users/catherinedevlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catherinedevlin/subscriptions","organizations_url":"https://api.github.com/users/catherinedevlin/orgs","repos_url":"https://api.github.com/users/catherinedevlin/repos","events_url":"https://api.github.com/users/catherinedevlin/events{/privacy}","received_events_url":"https://api.github.com/users/catherinedevlin/received_events","type":"User","site_admin":false},"assignees":[{"login":"catherinedevlin","id":208054,"avatar_url":"https://avatars3.githubusercontent.com/u/208054?v=3","gravatar_id":"","url":"https://api.github.com/users/catherinedevlin","html_url":"https://github.com/catherinedevlin","followers_url":"https://api.github.com/users/catherinedevlin/followers","following_url":"https://api.github.com/users/catherinedevlin/following{/other_user}","gists_url":"https://api.github.com/users/catherinedevlin/gists{/gist_id}","starred_url":"https://api.github.com/users/catherinedevlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catherinedevlin/subscriptions","organizations_url":"https://api.github.com/users/catherinedevlin/orgs","repos_url":"https://api.github.com/users/catherinedevlin/repos","events_url":"https://api.github.com/users/catherinedevlin/events{/privacy}","received_events_url":"https://api.github.com/users/catherinedevlin/received_events","type":"User","site_admin":false},{"login":"bsweger","id":540544,"avatar_url":"https://avatars1.githubusercontent.com/u/540544?v=3","gravatar_id":"","url":"https://api.github.com/users/bsweger","html_url":"https://github.com/bsweger","followers_url":"https://api.github.com/users/bsweger/followers","following_url":"https://api.github.com/users/bsweger/following{/other_user}","gists_url":"https://api.github.com/users/bsweger/gists{/gist_id}","starred_url":"https://api.github.com/users/bsweger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsweger/subscriptions","organizations_url":"https://api.github.com/users/bsweger/orgs","repos_url":"https://api.github.com/users/bsweger/repos","events_url":"https://api.github.com/users/bsweger/events{/privacy}","received_events_url":"https://api.github.com/users/bsweger/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls/217/commits","review_comments_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls/217/comments","review_comment_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/issues/217/comments","statuses_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/statuses/5b5f292bfb5990d2df33fb853bbb14b2dd0a2d7e","head":{"label":"fedspendingtransparency:federal-account-endpoints","ref":"federal-account-endpoints","sha":"5b5f292bfb5990d2df33fb853bbb14b2dd0a2d7e","user":{"login":"fedspendingtransparency","id":8397762,"avatar_url":"https://avatars3.githubusercontent.com/u/8397762?v=3","gravatar_id":"","url":"https://api.github.com/users/fedspendingtransparency","html_url":"https://github.com/fedspendingtransparency","followers_url":"https://api.github.com/users/fedspendingtransparency/followers","following_url":"https://api.github.com/users/fedspendingtransparency/following{/other_user}","gists_url":"https://api.github.com/users/fedspendingtransparency/gists{/gist_id}","starred_url":"https://api.github.com/users/fedspendingtransparency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedspendingtransparency/subscriptions","organizations_url":"https://api.github.com/users/fedspendingtransparency/orgs","repos_url":"https://api.github.com/users/fedspendingtransparency/repos","events_url":"https://api.github.com/users/fedspendingtransparency/events{/privacy}","received_events_url":"https://api.github.com/users/fedspendingtransparency/received_events","type":"Organization","site_admin":false},"repo":{"id":65394827,"name":"usaspending-api","full_name":"fedspendingtransparency/usaspending-api","owner":{"login":"fedspendingtransparency","id":8397762,"avatar_url":"https://avatars3.githubusercontent.com/u/8397762?v=3","gravatar_id":"","url":"https://api.github.com/users/fedspendingtransparency","html_url":"https://github.com/fedspendingtransparency","followers_url":"https://api.github.com/users/fedspendingtransparency/followers","following_url":"https://api.github.com/users/fedspendingtransparency/following{/other_user}","gists_url":"https://api.github.com/users/fedspendingtransparency/gists{/gist_id}","starred_url":"https://api.github.com/users/fedspendingtransparency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedspendingtransparency/subscriptions","organizations_url":"https://api.github.com/users/fedspendingtransparency/orgs","repos_url":"https://api.github.com/users/fedspendingtransparency/repos","events_url":"https://api.github.com/users/fedspendingtransparency/events{/privacy}","received_events_url":"https://api.github.com/users/fedspendingtransparency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fedspendingtransparency/usaspending-api","description":"An API for U.S. federal spending data","fork":false,"url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api","forks_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/forks","keys_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/teams","hooks_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/hooks","issue_events_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/issues/events{/number}","events_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/events","assignees_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/assignees{/user}","branches_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/branches{/branch}","tags_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/tags","blobs_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/statuses/{sha}","languages_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/languages","stargazers_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/stargazers","contributors_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/contributors","subscribers_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/subscribers","subscription_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/subscription","commits_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/contents/{+path}","compare_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/merges","archive_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/downloads","issues_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/issues{/number}","pulls_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls{/number}","milestones_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/milestones{/number}","notifications_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/labels{/name}","releases_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/releases{/id}","deployments_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/deployments","created_at":"2016-08-10T15:39:45Z","updated_at":"2017-03-23T16:54:31Z","pushed_at":"2017-03-23T17:48:18Z","git_url":"git://github.com/fedspendingtransparency/usaspending-api.git","ssh_url":"git@github.com:fedspendingtransparency/usaspending-api.git","clone_url":"https://github.com/fedspendingtransparency/usaspending-api.git","svn_url":"https://github.com/fedspendingtransparency/usaspending-api","homepage":"","size":10112,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":3,"forks":9,"open_issues":3,"watchers":7,"default_branch":"dev"}},"base":{"label":"fedspendingtransparency:dev","ref":"dev","sha":"846038137ee87411962bbc5f5b36d7e6d9b6e118","user":{"login":"fedspendingtransparency","id":8397762,"avatar_url":"https://avatars3.githubusercontent.com/u/8397762?v=3","gravatar_id":"","url":"https://api.github.com/users/fedspendingtransparency","html_url":"https://github.com/fedspendingtransparency","followers_url":"https://api.github.com/users/fedspendingtransparency/followers","following_url":"https://api.github.com/users/fedspendingtransparency/following{/other_user}","gists_url":"https://api.github.com/users/fedspendingtransparency/gists{/gist_id}","starred_url":"https://api.github.com/users/fedspendingtransparency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedspendingtransparency/subscriptions","organizations_url":"https://api.github.com/users/fedspendingtransparency/orgs","repos_url":"https://api.github.com/users/fedspendingtransparency/repos","events_url":"https://api.github.com/users/fedspendingtransparency/events{/privacy}","received_events_url":"https://api.github.com/users/fedspendingtransparency/received_events","type":"Organization","site_admin":false},"repo":{"id":65394827,"name":"usaspending-api","full_name":"fedspendingtransparency/usaspending-api","owner":{"login":"fedspendingtransparency","id":8397762,"avatar_url":"https://avatars3.githubusercontent.com/u/8397762?v=3","gravatar_id":"","url":"https://api.github.com/users/fedspendingtransparency","html_url":"https://github.com/fedspendingtransparency","followers_url":"https://api.github.com/users/fedspendingtransparency/followers","following_url":"https://api.github.com/users/fedspendingtransparency/following{/other_user}","gists_url":"https://api.github.com/users/fedspendingtransparency/gists{/gist_id}","starred_url":"https://api.github.com/users/fedspendingtransparency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedspendingtransparency/subscriptions","organizations_url":"https://api.github.com/users/fedspendingtransparency/orgs","repos_url":"https://api.github.com/users/fedspendingtransparency/repos","events_url":"https://api.github.com/users/fedspendingtransparency/events{/privacy}","received_events_url":"https://api.github.com/users/fedspendingtransparency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fedspendingtransparency/usaspending-api","description":"An API for U.S. federal spending data","fork":false,"url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api","forks_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/forks","keys_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/teams","hooks_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/hooks","issue_events_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/issues/events{/number}","events_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/events","assignees_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/assignees{/user}","branches_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/branches{/branch}","tags_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/tags","blobs_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/statuses/{sha}","languages_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/languages","stargazers_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/stargazers","contributors_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/contributors","subscribers_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/subscribers","subscription_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/subscription","commits_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/contents/{+path}","compare_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/merges","archive_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/downloads","issues_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/issues{/number}","pulls_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls{/number}","milestones_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/milestones{/number}","notifications_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/labels{/name}","releases_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/releases{/id}","deployments_url":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/deployments","created_at":"2016-08-10T15:39:45Z","updated_at":"2017-03-23T16:54:31Z","pushed_at":"2017-03-23T17:48:18Z","git_url":"git://github.com/fedspendingtransparency/usaspending-api.git","ssh_url":"git@github.com:fedspendingtransparency/usaspending-api.git","clone_url":"https://github.com/fedspendingtransparency/usaspending-api.git","svn_url":"https://github.com/fedspendingtransparency/usaspending-api","homepage":"","size":10112,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":3,"forks":9,"open_issues":3,"watchers":7,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls/217"},"html":{"href":"https://github.com/fedspendingtransparency/usaspending-api/pull/217"},"issue":{"href":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/issues/217"},"comments":{"href":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/fedspendingtransparency/usaspending-api/statuses/5b5f292bfb5990d2df33fb853bbb14b2dd0a2d7e"}}}}
{"actor":{"display_login":"bsweger"}}