{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43637","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43637/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43637/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43637/events","html_url":"https://github.com/kubernetes/kubernetes/pull/43637","id":216896560,"number":43637,"title":"Move e2e fromManifest funcs to manifest package","user":{"login":"wongma7","id":13111288,"avatar_url":"https://avatars3.githubusercontent.com/u/13111288?v=3","gravatar_id":"","url":"https://api.github.com/users/wongma7","html_url":"https://github.com/wongma7","followers_url":"https://api.github.com/users/wongma7/followers","following_url":"https://api.github.com/users/wongma7/following{/other_user}","gists_url":"https://api.github.com/users/wongma7/gists{/gist_id}","starred_url":"https://api.github.com/users/wongma7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongma7/subscriptions","organizations_url":"https://api.github.com/users/wongma7/orgs","repos_url":"https://api.github.com/users/wongma7/repos","events_url":"https://api.github.com/users/wongma7/events{/privacy}","received_events_url":"https://api.github.com/users/wongma7/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":483069764,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"erictune","id":8105590,"avatar_url":"https://avatars0.githubusercontent.com/u/8105590?v=3","gravatar_id":"","url":"https://api.github.com/users/erictune","html_url":"https://github.com/erictune","followers_url":"https://api.github.com/users/erictune/followers","following_url":"https://api.github.com/users/erictune/following{/other_user}","gists_url":"https://api.github.com/users/erictune/gists{/gist_id}","starred_url":"https://api.github.com/users/erictune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erictune/subscriptions","organizations_url":"https://api.github.com/users/erictune/orgs","repos_url":"https://api.github.com/users/erictune/repos","events_url":"https://api.github.com/users/erictune/events{/privacy}","received_events_url":"https://api.github.com/users/erictune/received_events","type":"User","site_admin":false},"assignees":[{"login":"spiffxp","id":49258,"avatar_url":"https://avatars1.githubusercontent.com/u/49258?v=3","gravatar_id":"","url":"https://api.github.com/users/spiffxp","html_url":"https://github.com/spiffxp","followers_url":"https://api.github.com/users/spiffxp/followers","following_url":"https://api.github.com/users/spiffxp/following{/other_user}","gists_url":"https://api.github.com/users/spiffxp/gists{/gist_id}","starred_url":"https://api.github.com/users/spiffxp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spiffxp/subscriptions","organizations_url":"https://api.github.com/users/spiffxp/orgs","repos_url":"https://api.github.com/users/spiffxp/repos","events_url":"https://api.github.com/users/spiffxp/events{/privacy}","received_events_url":"https://api.github.com/users/spiffxp/received_events","type":"User","site_admin":false},{"login":"erictune","id":8105590,"avatar_url":"https://avatars0.githubusercontent.com/u/8105590?v=3","gravatar_id":"","url":"https://api.github.com/users/erictune","html_url":"https://github.com/erictune","followers_url":"https://api.github.com/users/erictune/followers","following_url":"https://api.github.com/users/erictune/following{/other_user}","gists_url":"https://api.github.com/users/erictune/gists{/gist_id}","starred_url":"https://api.github.com/users/erictune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erictune/subscriptions","organizations_url":"https://api.github.com/users/erictune/orgs","repos_url":"https://api.github.com/users/erictune/repos","events_url":"https://api.github.com/users/erictune/events{/privacy}","received_events_url":"https://api.github.com/users/erictune/received_events","type":"User","site_admin":false}],"milestone":null,"comments":19,"created_at":"2017-03-24T20:28:39Z","updated_at":"2017-06-08T20:43:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/43637","html_url":"https://github.com/kubernetes/kubernetes/pull/43637","diff_url":"https://github.com/kubernetes/kubernetes/pull/43637.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/43637.patch"},"body":"fixes https://github.com/kubernetes/kubernetes/issues/37007 again\r\n\r\nThe goal here is to remove e2e/framework's dependence on e2e/generated so that external projects can import e2e/framework without issue. I reorganize & try to make all the 'fromManifest' funcs consistent (to all use generated, return err) to prevent any reintroduction of generated into framework\r\n\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/307221689","html_url":"https://github.com/kubernetes/kubernetes/pull/43637#issuecomment-307221689","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/43637","id":307221689,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars3.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2017-06-08T20:43:12Z","updated_at":"2017-06-08T20:43:12Z","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/43637#issuecomment-289155986\" title=\"Approved\">mikedanese</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/43637#issuecomment-307219107\" title=\"LGTM\">spiffxp</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/43637#\" title=\"Author self-approved\">wongma7</a>*\nWe suggest the following additional approver: **spxtr**\n\nAssign the PR to them by writing `/assign @spxtr` in a comment when ready.\n\nAssociated issue: *37007*\n\nThe full list of commands accepted by this bot can be found [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n\n<details open>\nNeeds approval from an approver in each of these OWNERS Files:\n\n- **[hack/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/hack/OWNERS)**\n- ~~[test/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/test/OWNERS)~~ [mikedanese,spiffxp]\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"spxtr\"]} -->"}}
{"actor":{"display_login":"k8s-merge-robot"}}