{"action":"created","comment":{"url":"https://api.github.com/repos/luigirizzo/netmap/pulls/comments/134119261","pull_request_review_id":57375691,"id":134119261,"diff_hunk":"@@ -267,6 +267,17 @@ COMMON PROBLEMS\n   In emulated netmap mode (i.e. with unpatched drivers) VLAN tags are never\n   visible by the netmap application.\n \n+* if you are using e1000 with netmap, you verify the result of the patch from\n+  final-patches/vanilla--e1000--20620--31200 that was applied on\n+  e1000/e1000_main.c. It was observed that when using older kernel version\n+  netmap hook that needs to be applied on e1000_clean_rx_irq is actually \n+  applied on e1000_clean_jumbo_rx_irq. As a result it will end up in packets\n+  going directly from NIC Rx Rings to Host stack.\n+","path":"LINUX/README","position":null,"original_position":10,"commit_id":"8ded2fce7b4001cd882b0a5d53a610f3c03c860b","original_commit_id":"7c3175170513006f4fea4361269782cc3e050ded","user":{"login":"krishnasrk","id":24965065,"avatar_url":"https://avatars0.githubusercontent.com/u/24965065?v=4","gravatar_id":"","url":"https://api.github.com/users/krishnasrk","html_url":"https://github.com/krishnasrk","followers_url":"https://api.github.com/users/krishnasrk/followers","following_url":"https://api.github.com/users/krishnasrk/following{/other_user}","gists_url":"https://api.github.com/users/krishnasrk/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnasrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnasrk/subscriptions","organizations_url":"https://api.github.com/users/krishnasrk/orgs","repos_url":"https://api.github.com/users/krishnasrk/repos","events_url":"https://api.github.com/users/krishnasrk/events{/privacy}","received_events_url":"https://api.github.com/users/krishnasrk/received_events","type":"User","site_admin":false},"body":"Yes make sense done.","created_at":"2017-08-20T15:52:05Z","updated_at":"2017-08-20T15:52:05Z","html_url":"https://github.com/luigirizzo/netmap/pull/350#discussion_r134119261","pull_request_url":"https://api.github.com/repos/luigirizzo/netmap/pulls/350","_links":{"self":{"href":"https://api.github.com/repos/luigirizzo/netmap/pulls/comments/134119261"},"html":{"href":"https://github.com/luigirizzo/netmap/pull/350#discussion_r134119261"},"pull_request":{"href":"https://api.github.com/repos/luigirizzo/netmap/pulls/350"}}},"pull_request":{"url":"https://api.github.com/repos/luigirizzo/netmap/pulls/350","id":136631442,"html_url":"https://github.com/luigirizzo/netmap/pull/350","diff_url":"https://github.com/luigirizzo/netmap/pull/350.diff","patch_url":"https://github.com/luigirizzo/netmap/pull/350.patch","issue_url":"https://api.github.com/repos/luigirizzo/netmap/issues/350","number":350,"state":"open","locked":false,"title":"Updated the README about e1000 patch issue seen in 3.10 kernel version","user":{"login":"krishnasrk","id":24965065,"avatar_url":"https://avatars0.githubusercontent.com/u/24965065?v=4","gravatar_id":"","url":"https://api.github.com/users/krishnasrk","html_url":"https://github.com/krishnasrk","followers_url":"https://api.github.com/users/krishnasrk/followers","following_url":"https://api.github.com/users/krishnasrk/following{/other_user}","gists_url":"https://api.github.com/users/krishnasrk/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnasrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnasrk/subscriptions","organizations_url":"https://api.github.com/users/krishnasrk/orgs","repos_url":"https://api.github.com/users/krishnasrk/repos","events_url":"https://api.github.com/users/krishnasrk/events{/privacy}","received_events_url":"https://api.github.com/users/krishnasrk/received_events","type":"User","site_admin":false},"body":"Problem statement\r\n==============\r\npatch final-patches/vanilla--e1000--20620--31200 is getting wrongly applied with 3.10 kernel version that is used for CentOS 7.3\r\n\r\nOverview of changes\r\n================\r\nUpdated the LINUX/README,  \"COMMON PROBLEMS\" section to alert the user of e1000 with netmap about the patch.\r\n","created_at":"2017-08-20T05:25:06Z","updated_at":"2017-08-20T15:52:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"377dc4283731ec82e5e50b55307481f6ab48f81e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/luigirizzo/netmap/pulls/350/commits","review_comments_url":"https://api.github.com/repos/luigirizzo/netmap/pulls/350/comments","review_comment_url":"https://api.github.com/repos/luigirizzo/netmap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/luigirizzo/netmap/issues/350/comments","statuses_url":"https://api.github.com/repos/luigirizzo/netmap/statuses/8ded2fce7b4001cd882b0a5d53a610f3c03c860b","head":{"label":"krishnasrk:docnotes/update_about_e1000_patch","ref":"docnotes/update_about_e1000_patch","sha":"8ded2fce7b4001cd882b0a5d53a610f3c03c860b","user":{"login":"krishnasrk","id":24965065,"avatar_url":"https://avatars0.githubusercontent.com/u/24965065?v=4","gravatar_id":"","url":"https://api.github.com/users/krishnasrk","html_url":"https://github.com/krishnasrk","followers_url":"https://api.github.com/users/krishnasrk/followers","following_url":"https://api.github.com/users/krishnasrk/following{/other_user}","gists_url":"https://api.github.com/users/krishnasrk/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnasrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnasrk/subscriptions","organizations_url":"https://api.github.com/users/krishnasrk/orgs","repos_url":"https://api.github.com/users/krishnasrk/repos","events_url":"https://api.github.com/users/krishnasrk/events{/privacy}","received_events_url":"https://api.github.com/users/krishnasrk/received_events","type":"User","site_admin":false},"repo":{"id":100840199,"name":"netmap","full_name":"krishnasrk/netmap","owner":{"login":"krishnasrk","id":24965065,"avatar_url":"https://avatars0.githubusercontent.com/u/24965065?v=4","gravatar_id":"","url":"https://api.github.com/users/krishnasrk","html_url":"https://github.com/krishnasrk","followers_url":"https://api.github.com/users/krishnasrk/followers","following_url":"https://api.github.com/users/krishnasrk/following{/other_user}","gists_url":"https://api.github.com/users/krishnasrk/gists{/gist_id}","starred_url":"https://api.github.com/users/krishnasrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krishnasrk/subscriptions","organizations_url":"https://api.github.com/users/krishnasrk/orgs","repos_url":"https://api.github.com/users/krishnasrk/repos","events_url":"https://api.github.com/users/krishnasrk/events{/privacy}","received_events_url":"https://api.github.com/users/krishnasrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/krishnasrk/netmap","description":"Automatically exported from code.google.com/p/netmap","fork":true,"url":"https://api.github.com/repos/krishnasrk/netmap","forks_url":"https://api.github.com/repos/krishnasrk/netmap/forks","keys_url":"https://api.github.com/repos/krishnasrk/netmap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krishnasrk/netmap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krishnasrk/netmap/teams","hooks_url":"https://api.github.com/repos/krishnasrk/netmap/hooks","issue_events_url":"https://api.github.com/repos/krishnasrk/netmap/issues/events{/number}","events_url":"https://api.github.com/repos/krishnasrk/netmap/events","assignees_url":"https://api.github.com/repos/krishnasrk/netmap/assignees{/user}","branches_url":"https://api.github.com/repos/krishnasrk/netmap/branches{/branch}","tags_url":"https://api.github.com/repos/krishnasrk/netmap/tags","blobs_url":"https://api.github.com/repos/krishnasrk/netmap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krishnasrk/netmap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krishnasrk/netmap/git/refs{/sha}","trees_url":"https://api.github.com/repos/krishnasrk/netmap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krishnasrk/netmap/statuses/{sha}","languages_url":"https://api.github.com/repos/krishnasrk/netmap/languages","stargazers_url":"https://api.github.com/repos/krishnasrk/netmap/stargazers","contributors_url":"https://api.github.com/repos/krishnasrk/netmap/contributors","subscribers_url":"https://api.github.com/repos/krishnasrk/netmap/subscribers","subscription_url":"https://api.github.com/repos/krishnasrk/netmap/subscription","commits_url":"https://api.github.com/repos/krishnasrk/netmap/commits{/sha}","git_commits_url":"https://api.github.com/repos/krishnasrk/netmap/git/commits{/sha}","comments_url":"https://api.github.com/repos/krishnasrk/netmap/comments{/number}","issue_comment_url":"https://api.github.com/repos/krishnasrk/netmap/issues/comments{/number}","contents_url":"https://api.github.com/repos/krishnasrk/netmap/contents/{+path}","compare_url":"https://api.github.com/repos/krishnasrk/netmap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krishnasrk/netmap/merges","archive_url":"https://api.github.com/repos/krishnasrk/netmap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krishnasrk/netmap/downloads","issues_url":"https://api.github.com/repos/krishnasrk/netmap/issues{/number}","pulls_url":"https://api.github.com/repos/krishnasrk/netmap/pulls{/number}","milestones_url":"https://api.github.com/repos/krishnasrk/netmap/milestones{/number}","notifications_url":"https://api.github.com/repos/krishnasrk/netmap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krishnasrk/netmap/labels{/name}","releases_url":"https://api.github.com/repos/krishnasrk/netmap/releases{/id}","deployments_url":"https://api.github.com/repos/krishnasrk/netmap/deployments","created_at":"2017-08-20T05:18:40Z","updated_at":"2017-08-20T05:18:42Z","pushed_at":"2017-08-20T15:50:10Z","git_url":"git://github.com/krishnasrk/netmap.git","ssh_url":"git@github.com:krishnasrk/netmap.git","clone_url":"https://github.com/krishnasrk/netmap.git","svn_url":"https://github.com/krishnasrk/netmap","homepage":null,"size":9315,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"luigirizzo:master","ref":"master","sha":"3c3ab5faa2ab9c89db09cd8339d0e96a1a78c41a","user":{"login":"luigirizzo","id":5787603,"avatar_url":"https://avatars3.githubusercontent.com/u/5787603?v=4","gravatar_id":"","url":"https://api.github.com/users/luigirizzo","html_url":"https://github.com/luigirizzo","followers_url":"https://api.github.com/users/luigirizzo/followers","following_url":"https://api.github.com/users/luigirizzo/following{/other_user}","gists_url":"https://api.github.com/users/luigirizzo/gists{/gist_id}","starred_url":"https://api.github.com/users/luigirizzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigirizzo/subscriptions","organizations_url":"https://api.github.com/users/luigirizzo/orgs","repos_url":"https://api.github.com/users/luigirizzo/repos","events_url":"https://api.github.com/users/luigirizzo/events{/privacy}","received_events_url":"https://api.github.com/users/luigirizzo/received_events","type":"User","site_admin":false},"repo":{"id":33124686,"name":"netmap","full_name":"luigirizzo/netmap","owner":{"login":"luigirizzo","id":5787603,"avatar_url":"https://avatars3.githubusercontent.com/u/5787603?v=4","gravatar_id":"","url":"https://api.github.com/users/luigirizzo","html_url":"https://github.com/luigirizzo","followers_url":"https://api.github.com/users/luigirizzo/followers","following_url":"https://api.github.com/users/luigirizzo/following{/other_user}","gists_url":"https://api.github.com/users/luigirizzo/gists{/gist_id}","starred_url":"https://api.github.com/users/luigirizzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luigirizzo/subscriptions","organizations_url":"https://api.github.com/users/luigirizzo/orgs","repos_url":"https://api.github.com/users/luigirizzo/repos","events_url":"https://api.github.com/users/luigirizzo/events{/privacy}","received_events_url":"https://api.github.com/users/luigirizzo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/luigirizzo/netmap","description":"Automatically exported from code.google.com/p/netmap","fork":false,"url":"https://api.github.com/repos/luigirizzo/netmap","forks_url":"https://api.github.com/repos/luigirizzo/netmap/forks","keys_url":"https://api.github.com/repos/luigirizzo/netmap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luigirizzo/netmap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luigirizzo/netmap/teams","hooks_url":"https://api.github.com/repos/luigirizzo/netmap/hooks","issue_events_url":"https://api.github.com/repos/luigirizzo/netmap/issues/events{/number}","events_url":"https://api.github.com/repos/luigirizzo/netmap/events","assignees_url":"https://api.github.com/repos/luigirizzo/netmap/assignees{/user}","branches_url":"https://api.github.com/repos/luigirizzo/netmap/branches{/branch}","tags_url":"https://api.github.com/repos/luigirizzo/netmap/tags","blobs_url":"https://api.github.com/repos/luigirizzo/netmap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luigirizzo/netmap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luigirizzo/netmap/git/refs{/sha}","trees_url":"https://api.github.com/repos/luigirizzo/netmap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luigirizzo/netmap/statuses/{sha}","languages_url":"https://api.github.com/repos/luigirizzo/netmap/languages","stargazers_url":"https://api.github.com/repos/luigirizzo/netmap/stargazers","contributors_url":"https://api.github.com/repos/luigirizzo/netmap/contributors","subscribers_url":"https://api.github.com/repos/luigirizzo/netmap/subscribers","subscription_url":"https://api.github.com/repos/luigirizzo/netmap/subscription","commits_url":"https://api.github.com/repos/luigirizzo/netmap/commits{/sha}","git_commits_url":"https://api.github.com/repos/luigirizzo/netmap/git/commits{/sha}","comments_url":"https://api.github.com/repos/luigirizzo/netmap/comments{/number}","issue_comment_url":"https://api.github.com/repos/luigirizzo/netmap/issues/comments{/number}","contents_url":"https://api.github.com/repos/luigirizzo/netmap/contents/{+path}","compare_url":"https://api.github.com/repos/luigirizzo/netmap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luigirizzo/netmap/merges","archive_url":"https://api.github.com/repos/luigirizzo/netmap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luigirizzo/netmap/downloads","issues_url":"https://api.github.com/repos/luigirizzo/netmap/issues{/number}","pulls_url":"https://api.github.com/repos/luigirizzo/netmap/pulls{/number}","milestones_url":"https://api.github.com/repos/luigirizzo/netmap/milestones{/number}","notifications_url":"https://api.github.com/repos/luigirizzo/netmap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luigirizzo/netmap/labels{/name}","releases_url":"https://api.github.com/repos/luigirizzo/netmap/releases{/id}","deployments_url":"https://api.github.com/repos/luigirizzo/netmap/deployments","created_at":"2015-03-30T13:29:05Z","updated_at":"2017-08-20T05:41:19Z","pushed_at":"2017-08-20T15:50:11Z","git_url":"git://github.com/luigirizzo/netmap.git","ssh_url":"git@github.com:luigirizzo/netmap.git","clone_url":"https://github.com/luigirizzo/netmap.git","svn_url":"https://github.com/luigirizzo/netmap","homepage":null,"size":9301,"stargazers_count":680,"watchers_count":680,"language":"C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":221,"mirror_url":null,"open_issues_count":53,"forks":221,"open_issues":53,"watchers":680,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/luigirizzo/netmap/pulls/350"},"html":{"href":"https://github.com/luigirizzo/netmap/pull/350"},"issue":{"href":"https://api.github.com/repos/luigirizzo/netmap/issues/350"},"comments":{"href":"https://api.github.com/repos/luigirizzo/netmap/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/luigirizzo/netmap/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/luigirizzo/netmap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/luigirizzo/netmap/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/luigirizzo/netmap/statuses/8ded2fce7b4001cd882b0a5d53a610f3c03c860b"}}}}
{"actor":{"display_login":"krishnasrk"}}