{"action":"created","issue":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/668","repository_url":"https://api.github.com/repos/mesosphere/dcos-commons","labels_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/668/labels{/name}","comments_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/668/comments","events_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/668/events","html_url":"https://github.com/mesosphere/dcos-commons/pull/668","id":212651963,"number":668,"title":"Add seeds endpoint to cassandra scheduler","user":{"login":"mrbrowning","id":3465239,"avatar_url":"https://avatars3.githubusercontent.com/u/3465239?v=3","gravatar_id":"","url":"https://api.github.com/users/mrbrowning","html_url":"https://github.com/mrbrowning","followers_url":"https://api.github.com/users/mrbrowning/followers","following_url":"https://api.github.com/users/mrbrowning/following{/other_user}","gists_url":"https://api.github.com/users/mrbrowning/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbrowning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbrowning/subscriptions","organizations_url":"https://api.github.com/users/mrbrowning/orgs","repos_url":"https://api.github.com/users/mrbrowning/repos","events_url":"https://api.github.com/users/mrbrowning/events{/privacy}","received_events_url":"https://api.github.com/users/mrbrowning/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nickbp","id":35933,"avatar_url":"https://avatars1.githubusercontent.com/u/35933?v=3","gravatar_id":"","url":"https://api.github.com/users/nickbp","html_url":"https://github.com/nickbp","followers_url":"https://api.github.com/users/nickbp/followers","following_url":"https://api.github.com/users/nickbp/following{/other_user}","gists_url":"https://api.github.com/users/nickbp/gists{/gist_id}","starred_url":"https://api.github.com/users/nickbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickbp/subscriptions","organizations_url":"https://api.github.com/users/nickbp/orgs","repos_url":"https://api.github.com/users/nickbp/repos","events_url":"https://api.github.com/users/nickbp/events{/privacy}","received_events_url":"https://api.github.com/users/nickbp/received_events","type":"User","site_admin":false},"assignees":[{"login":"nickbp","id":35933,"avatar_url":"https://avatars1.githubusercontent.com/u/35933?v=3","gravatar_id":"","url":"https://api.github.com/users/nickbp","html_url":"https://github.com/nickbp","followers_url":"https://api.github.com/users/nickbp/followers","following_url":"https://api.github.com/users/nickbp/following{/other_user}","gists_url":"https://api.github.com/users/nickbp/gists{/gist_id}","starred_url":"https://api.github.com/users/nickbp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickbp/subscriptions","organizations_url":"https://api.github.com/users/nickbp/orgs","repos_url":"https://api.github.com/users/nickbp/repos","events_url":"https://api.github.com/users/nickbp/events{/privacy}","received_events_url":"https://api.github.com/users/nickbp/received_events","type":"User","site_admin":false},{"login":"mohitsoni","id":102390,"avatar_url":"https://avatars2.githubusercontent.com/u/102390?v=3","gravatar_id":"","url":"https://api.github.com/users/mohitsoni","html_url":"https://github.com/mohitsoni","followers_url":"https://api.github.com/users/mohitsoni/followers","following_url":"https://api.github.com/users/mohitsoni/following{/other_user}","gists_url":"https://api.github.com/users/mohitsoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mohitsoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohitsoni/subscriptions","organizations_url":"https://api.github.com/users/mohitsoni/orgs","repos_url":"https://api.github.com/users/mohitsoni/repos","events_url":"https://api.github.com/users/mohitsoni/events{/privacy}","received_events_url":"https://api.github.com/users/mohitsoni/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-03-08T06:41:09Z","updated_at":"2017-03-24T23:09:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/pulls/668","html_url":"https://github.com/mesosphere/dcos-commons/pull/668","diff_url":"https://github.com/mesosphere/dcos-commons/pull/668.diff","patch_url":"https://github.com/mesosphere/dcos-commons/pull/668.patch"},"body":"This adds an endpoint at `/v1/seeds` that accepts `GET` requests, as well as endpoints at `/v1/seeds/<datacenter` that accept `PUT` requests for each remote datacenter configured, for the retrieval/update of local and remote seeds, respectively. Missing pieces right now are just the plumbing through of configuration options for number of seeds and remote datacenter names/URLs to the `SeedsResource` setup in `CassandraService`. I have tentative work for this in the upcoming PR for the seed provider itself, but this work raised the question of how to get that config to the `SeedsResource`, since `DefaultScheduler` doesn't expose it. Rather than do a bunch of plumbing to expose the `ConfigStore` outside of `DefaultScheduler`, I'm thinking that the most reasonable option involves accessing these configuration options directly via environment variables or Java system properties passed as flags to the command, but I'm curious what opinions on that are."},"comment":{"url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/comments/289164158","html_url":"https://github.com/mesosphere/dcos-commons/pull/668#issuecomment-289164158","issue_url":"https://api.github.com/repos/mesosphere/dcos-commons/issues/668","id":289164158,"user":{"login":"mrbrowning","id":3465239,"avatar_url":"https://avatars3.githubusercontent.com/u/3465239?v=3","gravatar_id":"","url":"https://api.github.com/users/mrbrowning","html_url":"https://github.com/mrbrowning","followers_url":"https://api.github.com/users/mrbrowning/followers","following_url":"https://api.github.com/users/mrbrowning/following{/other_user}","gists_url":"https://api.github.com/users/mrbrowning/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbrowning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbrowning/subscriptions","organizations_url":"https://api.github.com/users/mrbrowning/orgs","repos_url":"https://api.github.com/users/mrbrowning/repos","events_url":"https://api.github.com/users/mrbrowning/events{/privacy}","received_events_url":"https://api.github.com/users/mrbrowning/received_events","type":"User","site_admin":false},"created_at":"2017-03-24T23:09:43Z","updated_at":"2017-03-24T23:09:43Z","body":"Fixed underlying Cassandra config bug in #762 , but master was broken last time due to a bad merge."}}
{"actor":{"display_login":"mrbrowning"}}