{"action":"created","comment":{"url":"https://api.github.com/repos/scipy/scipy/pulls/comments/158097615","pull_request_review_id":84852126,"id":158097615,"diff_hunk":"@@ -661,6 +661,24 @@ def cb(xk, **kwargs):\n class BaseTestLinprogIP(LinprogCommonTests):\n     method = \"interior-point\"\n \n+    def test_bounds_equal_but_infeasible(self):\n+        c = [-4, 1]\n+        A_ub = [[7, -2], [0, 1], [2, -2]]\n+        b_ub = [14, 0, 3]\n+        bounds = [(2, 2), (0, None)]\n+        res = linprog(c=c, A_ub=A_ub, b_ub=b_ub, bounds=bounds,\n+                      method=self.method)\n+        _assert_infeasible(res)\n+\n+    def test_bounds_equal_but_infeasible2(self):","path":"scipy/optimize/tests/test_linprog.py","position":13,"original_position":13,"commit_id":"91eb0d6a2bdea1232e70ac4a13d1e236b24ba900","original_commit_id":"91eb0d6a2bdea1232e70ac4a13d1e236b24ba900","user":{"login":"tylerjereddy","id":7903078,"avatar_url":"https://avatars0.githubusercontent.com/u/7903078?v=4","gravatar_id":"","url":"https://api.github.com/users/tylerjereddy","html_url":"https://github.com/tylerjereddy","followers_url":"https://api.github.com/users/tylerjereddy/followers","following_url":"https://api.github.com/users/tylerjereddy/following{/other_user}","gists_url":"https://api.github.com/users/tylerjereddy/gists{/gist_id}","starred_url":"https://api.github.com/users/tylerjereddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylerjereddy/subscriptions","organizations_url":"https://api.github.com/users/tylerjereddy/orgs","repos_url":"https://api.github.com/users/tylerjereddy/repos","events_url":"https://api.github.com/users/tylerjereddy/events{/privacy}","received_events_url":"https://api.github.com/users/tylerjereddy/received_events","type":"User","site_admin":false},"body":"There's probably some potential to reduce code duplication via a parametrized pytest approach since the input data is the same for both tests with the exception of the argument specifications (i.e., `A_eq` vs. `A_ub`). I'm not sure it would be that much cleaner though since you'd likely need to specify the default `None` argument for i.e., `A_eq` when using `A_ub`, but just a thought given the test similarities.\r\n\r\nA pytest fixture might be another option or something that could be used in combination so the parametrization isn't too bulky.","created_at":"2017-12-20T18:17:25Z","updated_at":"2017-12-20T18:18:43Z","html_url":"https://github.com/scipy/scipy/pull/8237#discussion_r158097615","pull_request_url":"https://api.github.com/repos/scipy/scipy/pulls/8237","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments/158097615"},"html":{"href":"https://github.com/scipy/scipy/pull/8237#discussion_r158097615"},"pull_request":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8237"}}},"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/8237","id":159308052,"html_url":"https://github.com/scipy/scipy/pull/8237","diff_url":"https://github.com/scipy/scipy/pull/8237.diff","patch_url":"https://github.com/scipy/scipy/pull/8237.patch","issue_url":"https://api.github.com/repos/scipy/scipy/issues/8237","number":8237,"state":"open","locked":false,"title":"BUG: optimize: fix bug when variables fixed by bounds are inconsistent with constraints","user":{"login":"mdhaber","id":6570539,"avatar_url":"https://avatars1.githubusercontent.com/u/6570539?v=4","gravatar_id":"","url":"https://api.github.com/users/mdhaber","html_url":"https://github.com/mdhaber","followers_url":"https://api.github.com/users/mdhaber/followers","following_url":"https://api.github.com/users/mdhaber/following{/other_user}","gists_url":"https://api.github.com/users/mdhaber/gists{/gist_id}","starred_url":"https://api.github.com/users/mdhaber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdhaber/subscriptions","organizations_url":"https://api.github.com/users/mdhaber/orgs","repos_url":"https://api.github.com/users/mdhaber/repos","events_url":"https://api.github.com/users/mdhaber/events{/privacy}","received_events_url":"https://api.github.com/users/mdhaber/received_events","type":"User","site_admin":false},"body":"Fixes #8234","created_at":"2017-12-20T00:58:26Z","updated_at":"2017-12-20T18:18:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3a8f1b147f51fcc5a9ab883cc6ebce71cfb40fe","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/scipy/scipy/pulls/8237/commits","review_comments_url":"https://api.github.com/repos/scipy/scipy/pulls/8237/comments","review_comment_url":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/8237/comments","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/91eb0d6a2bdea1232e70ac4a13d1e236b24ba900","head":{"label":"mdhaber:bug8234","ref":"bug8234","sha":"91eb0d6a2bdea1232e70ac4a13d1e236b24ba900","user":{"login":"mdhaber","id":6570539,"avatar_url":"https://avatars1.githubusercontent.com/u/6570539?v=4","gravatar_id":"","url":"https://api.github.com/users/mdhaber","html_url":"https://github.com/mdhaber","followers_url":"https://api.github.com/users/mdhaber/followers","following_url":"https://api.github.com/users/mdhaber/following{/other_user}","gists_url":"https://api.github.com/users/mdhaber/gists{/gist_id}","starred_url":"https://api.github.com/users/mdhaber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdhaber/subscriptions","organizations_url":"https://api.github.com/users/mdhaber/orgs","repos_url":"https://api.github.com/users/mdhaber/repos","events_url":"https://api.github.com/users/mdhaber/events{/privacy}","received_events_url":"https://api.github.com/users/mdhaber/received_events","type":"User","site_admin":false},"repo":{"id":82009890,"name":"scipy","full_name":"mdhaber/scipy","owner":{"login":"mdhaber","id":6570539,"avatar_url":"https://avatars1.githubusercontent.com/u/6570539?v=4","gravatar_id":"","url":"https://api.github.com/users/mdhaber","html_url":"https://github.com/mdhaber","followers_url":"https://api.github.com/users/mdhaber/followers","following_url":"https://api.github.com/users/mdhaber/following{/other_user}","gists_url":"https://api.github.com/users/mdhaber/gists{/gist_id}","starred_url":"https://api.github.com/users/mdhaber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdhaber/subscriptions","organizations_url":"https://api.github.com/users/mdhaber/orgs","repos_url":"https://api.github.com/users/mdhaber/repos","events_url":"https://api.github.com/users/mdhaber/events{/privacy}","received_events_url":"https://api.github.com/users/mdhaber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdhaber/scipy","description":"Scipy library main repository","fork":true,"url":"https://api.github.com/repos/mdhaber/scipy","forks_url":"https://api.github.com/repos/mdhaber/scipy/forks","keys_url":"https://api.github.com/repos/mdhaber/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdhaber/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdhaber/scipy/teams","hooks_url":"https://api.github.com/repos/mdhaber/scipy/hooks","issue_events_url":"https://api.github.com/repos/mdhaber/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/mdhaber/scipy/events","assignees_url":"https://api.github.com/repos/mdhaber/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/mdhaber/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/mdhaber/scipy/tags","blobs_url":"https://api.github.com/repos/mdhaber/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdhaber/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdhaber/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdhaber/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdhaber/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/mdhaber/scipy/languages","stargazers_url":"https://api.github.com/repos/mdhaber/scipy/stargazers","contributors_url":"https://api.github.com/repos/mdhaber/scipy/contributors","subscribers_url":"https://api.github.com/repos/mdhaber/scipy/subscribers","subscription_url":"https://api.github.com/repos/mdhaber/scipy/subscription","commits_url":"https://api.github.com/repos/mdhaber/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdhaber/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdhaber/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdhaber/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdhaber/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/mdhaber/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdhaber/scipy/merges","archive_url":"https://api.github.com/repos/mdhaber/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdhaber/scipy/downloads","issues_url":"https://api.github.com/repos/mdhaber/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/mdhaber/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/mdhaber/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/mdhaber/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdhaber/scipy/labels{/name}","releases_url":"https://api.github.com/repos/mdhaber/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/mdhaber/scipy/deployments","created_at":"2017-02-15T02:06:14Z","updated_at":"2017-02-15T02:06:25Z","pushed_at":"2017-12-20T00:52:31Z","git_url":"git://github.com/mdhaber/scipy.git","ssh_url":"git@github.com:mdhaber/scipy.git","clone_url":"https://github.com/mdhaber/scipy.git","svn_url":"https://github.com/mdhaber/scipy","homepage":"http://scipy.org/scipylib/","size":75303,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scipy:master","ref":"master","sha":"e6279ce7616436e5ebefd84d0a2bfae03a82b4ff","user":{"login":"scipy","id":288277,"avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"repo":{"id":1460385,"name":"scipy","full_name":"scipy/scipy","owner":{"login":"scipy","id":288277,"avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scipy/scipy","description":"Scipy library main repository","fork":false,"url":"https://api.github.com/repos/scipy/scipy","forks_url":"https://api.github.com/repos/scipy/scipy/forks","keys_url":"https://api.github.com/repos/scipy/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scipy/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scipy/scipy/teams","hooks_url":"https://api.github.com/repos/scipy/scipy/hooks","issue_events_url":"https://api.github.com/repos/scipy/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/scipy/scipy/events","assignees_url":"https://api.github.com/repos/scipy/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/scipy/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/scipy/scipy/tags","blobs_url":"https://api.github.com/repos/scipy/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scipy/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scipy/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scipy/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/scipy/scipy/languages","stargazers_url":"https://api.github.com/repos/scipy/scipy/stargazers","contributors_url":"https://api.github.com/repos/scipy/scipy/contributors","subscribers_url":"https://api.github.com/repos/scipy/scipy/subscribers","subscription_url":"https://api.github.com/repos/scipy/scipy/subscription","commits_url":"https://api.github.com/repos/scipy/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scipy/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scipy/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scipy/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scipy/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/scipy/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scipy/scipy/merges","archive_url":"https://api.github.com/repos/scipy/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scipy/scipy/downloads","issues_url":"https://api.github.com/repos/scipy/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/scipy/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/scipy/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/scipy/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scipy/scipy/labels{/name}","releases_url":"https://api.github.com/repos/scipy/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/scipy/scipy/deployments","created_at":"2011-03-09T18:52:03Z","updated_at":"2017-12-20T11:13:12Z","pushed_at":"2017-12-20T10:35:20Z","git_url":"git://github.com/scipy/scipy.git","ssh_url":"git@github.com:scipy/scipy.git","clone_url":"https://github.com/scipy/scipy.git","svn_url":"https://github.com/scipy/scipy","homepage":"http://scipy.org/scipylib/","size":77458,"stargazers_count":3896,"watchers_count":3896,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2111,"mirror_url":null,"archived":false,"open_issues_count":1164,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2111,"open_issues":1164,"watchers":3896,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8237"},"html":{"href":"https://github.com/scipy/scipy/pull/8237"},"issue":{"href":"https://api.github.com/repos/scipy/scipy/issues/8237"},"comments":{"href":"https://api.github.com/repos/scipy/scipy/issues/8237/comments"},"review_comments":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8237/comments"},"review_comment":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8237/commits"},"statuses":{"href":"https://api.github.com/repos/scipy/scipy/statuses/91eb0d6a2bdea1232e70ac4a13d1e236b24ba900"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tylerjereddy"}}