{"action":"created","issue":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9457","repository_url":"https://api.github.com/repos/scikit-learn/scikit-learn","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9457/labels{/name}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9457/comments","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9457/events","html_url":"https://github.com/scikit-learn/scikit-learn/pull/9457","id":246037408,"number":9457,"title":"[MRG] `MLPRegressor` quits fitting too soon due to `self._no_improvement_count`","user":{"login":"nnadeau","id":6395915,"avatar_url":"https://avatars2.githubusercontent.com/u/6395915?v=4","gravatar_id":"","url":"https://api.github.com/users/nnadeau","html_url":"https://github.com/nnadeau","followers_url":"https://api.github.com/users/nnadeau/followers","following_url":"https://api.github.com/users/nnadeau/following{/other_user}","gists_url":"https://api.github.com/users/nnadeau/gists{/gist_id}","starred_url":"https://api.github.com/users/nnadeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnadeau/subscriptions","organizations_url":"https://api.github.com/users/nnadeau/orgs","repos_url":"https://api.github.com/users/nnadeau/repos","events_url":"https://api.github.com/users/nnadeau/events{/privacy}","received_events_url":"https://api.github.com/users/nnadeau/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2017-07-27T13:21:26Z","updated_at":"2017-10-19T15:19:09Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/9457","html_url":"https://github.com/scikit-learn/scikit-learn/pull/9457","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/9457.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/9457.patch"},"body":"#### Reference Issue\r\n- Fixes #9456 \r\n\r\n#### What does this implement/fix? Explain your changes.\r\n- The ability to set/tune the limit of `self._no_improvement_count`.\r\n- The ability to ignore `self._no_improvement_count` by setting `self.no_improvement_limit` to `np.inf`.\r\n- `MLPRegressor` will not quit fitting unexpectedly early due to local minima or fluctuations.\r\n\r\n\r\n#### Any other comments?\r\n- ~~`self.no_improvement_limit` was not set as an `__init__` argument since this might cause unknown feature breaks.~~\r\n- A magic number was removed from the code.\r\n- Thanks for the awesome package and hard work! :)"},"comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments/337941663","html_url":"https://github.com/scikit-learn/scikit-learn/pull/9457#issuecomment-337941663","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/9457","id":337941663,"user":{"login":"nnadeau","id":6395915,"avatar_url":"https://avatars2.githubusercontent.com/u/6395915?v=4","gravatar_id":"","url":"https://api.github.com/users/nnadeau","html_url":"https://github.com/nnadeau","followers_url":"https://api.github.com/users/nnadeau/followers","following_url":"https://api.github.com/users/nnadeau/following{/other_user}","gists_url":"https://api.github.com/users/nnadeau/gists{/gist_id}","starred_url":"https://api.github.com/users/nnadeau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nnadeau/subscriptions","organizations_url":"https://api.github.com/users/nnadeau/orgs","repos_url":"https://api.github.com/users/nnadeau/repos","events_url":"https://api.github.com/users/nnadeau/events{/privacy}","received_events_url":"https://api.github.com/users/nnadeau/received_events","type":"User","site_admin":false},"created_at":"2017-10-19T15:19:09Z","updated_at":"2017-10-19T15:19:09Z","author_association":"NONE","body":"@TomDLT see https://github.com/scikit-learn/scikit-learn/pull/9457/commits/e60701ad0cb43034def7864e8806186d0bfb5bd6 for revert back to `n_iter_no_change=2`"}}
{"actor":{"display_login":"nnadeau"}}