{"action":"created","issue":{"url":"https://api.github.com/repos/publiclab/plots2/issues/1861","repository_url":"https://api.github.com/repos/publiclab/plots2","labels_url":"https://api.github.com/repos/publiclab/plots2/issues/1861/labels{/name}","comments_url":"https://api.github.com/repos/publiclab/plots2/issues/1861/comments","events_url":"https://api.github.com/repos/publiclab/plots2/issues/1861/events","html_url":"https://github.com/publiclab/plots2/pull/1861","id":280886392,"number":1861,"title":"Performance test (Original Issue #1801)","user":{"login":"bellvat","id":26703702,"avatar_url":"https://avatars0.githubusercontent.com/u/26703702?v=4","gravatar_id":"","url":"https://api.github.com/users/bellvat","html_url":"https://github.com/bellvat","followers_url":"https://api.github.com/users/bellvat/followers","following_url":"https://api.github.com/users/bellvat/following{/other_user}","gists_url":"https://api.github.com/users/bellvat/gists{/gist_id}","starred_url":"https://api.github.com/users/bellvat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bellvat/subscriptions","organizations_url":"https://api.github.com/users/bellvat/orgs","repos_url":"https://api.github.com/users/bellvat/repos","events_url":"https://api.github.com/users/bellvat/events{/privacy}","received_events_url":"https://api.github.com/users/bellvat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2017-12-11T03:52:15Z","updated_at":"2017-12-12T13:02:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/publiclab/plots2/pulls/1861","html_url":"https://github.com/publiclab/plots2/pull/1861","diff_url":"https://github.com/publiclab/plots2/pull/1861.diff","patch_url":"https://github.com/publiclab/plots2/pull/1861.patch"},"body":"* [ ] all tests pass -- `rake test:all` **Please see \"Issue\" below**\r\n* [x] code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)\r\n* [x] pull request is descriptively named with #number reference back to original issue\r\n\r\n\r\nI have made the following changes -- fixes #1801 :\r\n1. Added perftest gem\r\n2. Added ruby prof gem\r\n3. Uncommented code in browsing_test.rb, and changed syntax of line 9 to: \r\n `  test \"browsers\" do `\r\n4. I have not make changes to the Rakefile yet. \r\n\r\n**Issue:** When I ran `$ bundle exec rake test:benchmark`, which should give us the performance statistics, I kept getting this error:\r\n![screen shot 2017-12-08 at 3 39 52 pm](https://user-images.githubusercontent.com/26703702/33789543-1a128c4e-dc2e-11e7-8788-cde2dfd25273.png)\r\n\r\n1. I tried to debug this by changing my ruby version, as I read in some posts that it might be that Rails 4.1.6 may not be compatible with Ruby 2.4. I am not as familiar with how rbenv works, and although I was able to install a different version of ruby, I was not able to get rails to work with that version.\r\n2. The same error message came up when I tried running `rails s' to try and start the server\r\n\r\nAny guidance would be appreciated! \r\n\r\nThanks for your help!\r\n"},"comment":{"url":"https://api.github.com/repos/publiclab/plots2/issues/comments/351044807","html_url":"https://github.com/publiclab/plots2/pull/1861#issuecomment-351044807","issue_url":"https://api.github.com/repos/publiclab/plots2/issues/1861","id":351044807,"user":{"login":"bellvat","id":26703702,"avatar_url":"https://avatars0.githubusercontent.com/u/26703702?v=4","gravatar_id":"","url":"https://api.github.com/users/bellvat","html_url":"https://github.com/bellvat","followers_url":"https://api.github.com/users/bellvat/followers","following_url":"https://api.github.com/users/bellvat/following{/other_user}","gists_url":"https://api.github.com/users/bellvat/gists{/gist_id}","starred_url":"https://api.github.com/users/bellvat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bellvat/subscriptions","organizations_url":"https://api.github.com/users/bellvat/orgs","repos_url":"https://api.github.com/users/bellvat/repos","events_url":"https://api.github.com/users/bellvat/events{/privacy}","received_events_url":"https://api.github.com/users/bellvat/received_events","type":"User","site_admin":false},"created_at":"2017-12-12T13:02:10Z","updated_at":"2017-12-12T13:02:10Z","author_association":"NONE","body":"@ryzokuken Sure. \r\nJust to confirm, I would add `:branch => 'master'` to the end of the ruby-prof line in the Gemfile, then run `bundle update`, correct?"}}
{"actor":{"display_login":"bellvat"}}