{"action":"created","comment":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/148698662","pull_request_review_id":73983925,"id":148698662,"diff_hunk":"@@ -41,9 +41,8 @@ void fmt_class_string<logs::level>::format(std::string& out, u64 arg)\n \t\tcase logs::level::warning: return \"Warning\";\n \t\tcase logs::level::notice: return \"Notice\";\n \t\tcase logs::level::trace: return \"Trace\";\n+\t\tcase logs::level::_uninit: return unknown;\n \t\t}\n-","path":"Utilities/Log.cpp","position":null,"original_position":6,"commit_id":"78ee868a15f84def31a049a6571b8c64bc42d5f0","original_commit_id":"7b220da35f9cf51f0bfb5d8d5a0383334b6a98c6","user":{"login":"hcorion","id":9814000,"avatar_url":"https://avatars3.githubusercontent.com/u/9814000?v=4","gravatar_id":"","url":"https://api.github.com/users/hcorion","html_url":"https://github.com/hcorion","followers_url":"https://api.github.com/users/hcorion/followers","following_url":"https://api.github.com/users/hcorion/following{/other_user}","gists_url":"https://api.github.com/users/hcorion/gists{/gist_id}","starred_url":"https://api.github.com/users/hcorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcorion/subscriptions","organizations_url":"https://api.github.com/users/hcorion/orgs","repos_url":"https://api.github.com/users/hcorion/repos","events_url":"https://api.github.com/users/hcorion/events{/privacy}","received_events_url":"https://api.github.com/users/hcorion/received_events","type":"User","site_admin":false},"body":"Addresed","created_at":"2017-11-03T01:38:59Z","updated_at":"2017-11-03T01:38:59Z","html_url":"https://github.com/RPCS3/rpcs3/pull/3692#discussion_r148698662","pull_request_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/3692","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments/148698662"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/3692#discussion_r148698662"},"pull_request":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/3692"}},"in_reply_to_id":148696456},"pull_request":{"url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/3692","id":150213646,"html_url":"https://github.com/RPCS3/rpcs3/pull/3692","diff_url":"https://github.com/RPCS3/rpcs3/pull/3692.diff","patch_url":"https://github.com/RPCS3/rpcs3/pull/3692.patch","issue_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/3692","number":3692,"state":"open","locked":false,"title":"Silence some warnings","user":{"login":"hcorion","id":9814000,"avatar_url":"https://avatars3.githubusercontent.com/u/9814000?v=4","gravatar_id":"","url":"https://api.github.com/users/hcorion","html_url":"https://github.com/hcorion","followers_url":"https://api.github.com/users/hcorion/followers","following_url":"https://api.github.com/users/hcorion/following{/other_user}","gists_url":"https://api.github.com/users/hcorion/gists{/gist_id}","starred_url":"https://api.github.com/users/hcorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcorion/subscriptions","organizations_url":"https://api.github.com/users/hcorion/orgs","repos_url":"https://api.github.com/users/hcorion/repos","events_url":"https://api.github.com/users/hcorion/events{/privacy}","received_events_url":"https://api.github.com/users/hcorion/received_events","type":"User","site_admin":false},"body":"This touches all different parts of the code base, so I'm requesting review from @Nekotekina and @kd-11 , as some assumptions I made may be incorrect, and some of the errors may provide wrong/not enough information.","created_at":"2017-11-02T06:34:08Z","updated_at":"2017-11-03T01:38:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ab89a46ac5b112bc42feae54effda6d7a42e816","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/3692/commits","review_comments_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/3692/comments","review_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/3692/comments","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/78ee868a15f84def31a049a6571b8c64bc42d5f0","head":{"label":"hcorion:silence-warnings","ref":"silence-warnings","sha":"78ee868a15f84def31a049a6571b8c64bc42d5f0","user":{"login":"hcorion","id":9814000,"avatar_url":"https://avatars3.githubusercontent.com/u/9814000?v=4","gravatar_id":"","url":"https://api.github.com/users/hcorion","html_url":"https://github.com/hcorion","followers_url":"https://api.github.com/users/hcorion/followers","following_url":"https://api.github.com/users/hcorion/following{/other_user}","gists_url":"https://api.github.com/users/hcorion/gists{/gist_id}","starred_url":"https://api.github.com/users/hcorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcorion/subscriptions","organizations_url":"https://api.github.com/users/hcorion/orgs","repos_url":"https://api.github.com/users/hcorion/repos","events_url":"https://api.github.com/users/hcorion/events{/privacy}","received_events_url":"https://api.github.com/users/hcorion/received_events","type":"User","site_admin":false},"repo":{"id":87264795,"name":"rpcs3","full_name":"hcorion/rpcs3","owner":{"login":"hcorion","id":9814000,"avatar_url":"https://avatars3.githubusercontent.com/u/9814000?v=4","gravatar_id":"","url":"https://api.github.com/users/hcorion","html_url":"https://github.com/hcorion","followers_url":"https://api.github.com/users/hcorion/followers","following_url":"https://api.github.com/users/hcorion/following{/other_user}","gists_url":"https://api.github.com/users/hcorion/gists{/gist_id}","starred_url":"https://api.github.com/users/hcorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcorion/subscriptions","organizations_url":"https://api.github.com/users/hcorion/orgs","repos_url":"https://api.github.com/users/hcorion/repos","events_url":"https://api.github.com/users/hcorion/events{/privacy}","received_events_url":"https://api.github.com/users/hcorion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hcorion/rpcs3","description":"PS3 emulator/debugger","fork":true,"url":"https://api.github.com/repos/hcorion/rpcs3","forks_url":"https://api.github.com/repos/hcorion/rpcs3/forks","keys_url":"https://api.github.com/repos/hcorion/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hcorion/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hcorion/rpcs3/teams","hooks_url":"https://api.github.com/repos/hcorion/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/hcorion/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/hcorion/rpcs3/events","assignees_url":"https://api.github.com/repos/hcorion/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/hcorion/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/hcorion/rpcs3/tags","blobs_url":"https://api.github.com/repos/hcorion/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hcorion/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hcorion/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/hcorion/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hcorion/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/hcorion/rpcs3/languages","stargazers_url":"https://api.github.com/repos/hcorion/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/hcorion/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/hcorion/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/hcorion/rpcs3/subscription","commits_url":"https://api.github.com/repos/hcorion/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/hcorion/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/hcorion/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/hcorion/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/hcorion/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/hcorion/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hcorion/rpcs3/merges","archive_url":"https://api.github.com/repos/hcorion/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hcorion/rpcs3/downloads","issues_url":"https://api.github.com/repos/hcorion/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/hcorion/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/hcorion/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/hcorion/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hcorion/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/hcorion/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/hcorion/rpcs3/deployments","created_at":"2017-04-05T04:09:22Z","updated_at":"2017-08-22T15:45:20Z","pushed_at":"2017-11-03T01:36:04Z","git_url":"git://github.com/hcorion/rpcs3.git","ssh_url":"git@github.com:hcorion/rpcs3.git","clone_url":"https://github.com/hcorion/rpcs3.git","svn_url":"https://github.com/hcorion/rpcs3","homepage":"https://rpcs3.net/","size":44746,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"RPCS3:master","ref":"master","sha":"30bba09fed0c2e52ea2e08d62087da15ffeebeae","user":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars3.githubusercontent.com/u/8070735?v=4","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"repo":{"id":6520784,"name":"rpcs3","full_name":"RPCS3/rpcs3","owner":{"login":"RPCS3","id":8070735,"avatar_url":"https://avatars3.githubusercontent.com/u/8070735?v=4","gravatar_id":"","url":"https://api.github.com/users/RPCS3","html_url":"https://github.com/RPCS3","followers_url":"https://api.github.com/users/RPCS3/followers","following_url":"https://api.github.com/users/RPCS3/following{/other_user}","gists_url":"https://api.github.com/users/RPCS3/gists{/gist_id}","starred_url":"https://api.github.com/users/RPCS3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RPCS3/subscriptions","organizations_url":"https://api.github.com/users/RPCS3/orgs","repos_url":"https://api.github.com/users/RPCS3/repos","events_url":"https://api.github.com/users/RPCS3/events{/privacy}","received_events_url":"https://api.github.com/users/RPCS3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RPCS3/rpcs3","description":"PS3 emulator/debugger","fork":false,"url":"https://api.github.com/repos/RPCS3/rpcs3","forks_url":"https://api.github.com/repos/RPCS3/rpcs3/forks","keys_url":"https://api.github.com/repos/RPCS3/rpcs3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RPCS3/rpcs3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RPCS3/rpcs3/teams","hooks_url":"https://api.github.com/repos/RPCS3/rpcs3/hooks","issue_events_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/events{/number}","events_url":"https://api.github.com/repos/RPCS3/rpcs3/events","assignees_url":"https://api.github.com/repos/RPCS3/rpcs3/assignees{/user}","branches_url":"https://api.github.com/repos/RPCS3/rpcs3/branches{/branch}","tags_url":"https://api.github.com/repos/RPCS3/rpcs3/tags","blobs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RPCS3/rpcs3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RPCS3/rpcs3/git/refs{/sha}","trees_url":"https://api.github.com/repos/RPCS3/rpcs3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RPCS3/rpcs3/statuses/{sha}","languages_url":"https://api.github.com/repos/RPCS3/rpcs3/languages","stargazers_url":"https://api.github.com/repos/RPCS3/rpcs3/stargazers","contributors_url":"https://api.github.com/repos/RPCS3/rpcs3/contributors","subscribers_url":"https://api.github.com/repos/RPCS3/rpcs3/subscribers","subscription_url":"https://api.github.com/repos/RPCS3/rpcs3/subscription","commits_url":"https://api.github.com/repos/RPCS3/rpcs3/commits{/sha}","git_commits_url":"https://api.github.com/repos/RPCS3/rpcs3/git/commits{/sha}","comments_url":"https://api.github.com/repos/RPCS3/rpcs3/comments{/number}","issue_comment_url":"https://api.github.com/repos/RPCS3/rpcs3/issues/comments{/number}","contents_url":"https://api.github.com/repos/RPCS3/rpcs3/contents/{+path}","compare_url":"https://api.github.com/repos/RPCS3/rpcs3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RPCS3/rpcs3/merges","archive_url":"https://api.github.com/repos/RPCS3/rpcs3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RPCS3/rpcs3/downloads","issues_url":"https://api.github.com/repos/RPCS3/rpcs3/issues{/number}","pulls_url":"https://api.github.com/repos/RPCS3/rpcs3/pulls{/number}","milestones_url":"https://api.github.com/repos/RPCS3/rpcs3/milestones{/number}","notifications_url":"https://api.github.com/repos/RPCS3/rpcs3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RPCS3/rpcs3/labels{/name}","releases_url":"https://api.github.com/repos/RPCS3/rpcs3/releases{/id}","deployments_url":"https://api.github.com/repos/RPCS3/rpcs3/deployments","created_at":"2012-11-03T15:16:18Z","updated_at":"2017-11-03T00:24:19Z","pushed_at":"2017-11-03T01:36:06Z","git_url":"git://github.com/RPCS3/rpcs3.git","ssh_url":"git@github.com:RPCS3/rpcs3.git","clone_url":"https://github.com/RPCS3/rpcs3.git","svn_url":"https://github.com/RPCS3/rpcs3","homepage":"https://rpcs3.net/","size":44466,"stargazers_count":3967,"watchers_count":3967,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":730,"mirror_url":null,"archived":false,"open_issues_count":256,"forks":730,"open_issues":256,"watchers":3967,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/3692"},"html":{"href":"https://github.com/RPCS3/rpcs3/pull/3692"},"issue":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/3692"},"comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/issues/3692/comments"},"review_comments":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/3692/comments"},"review_comment":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RPCS3/rpcs3/pulls/3692/commits"},"statuses":{"href":"https://api.github.com/repos/RPCS3/rpcs3/statuses/78ee868a15f84def31a049a6571b8c64bc42d5f0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hcorion"}}