{"action":"closed","number":1932,"pull_request":{"url":"https://api.github.com/repos/awesomeWM/awesome/pulls/1932","id":131350632,"html_url":"https://github.com/awesomeWM/awesome/pull/1932","diff_url":"https://github.com/awesomeWM/awesome/pull/1932.diff","patch_url":"https://github.com/awesomeWM/awesome/pull/1932.patch","issue_url":"https://api.github.com/repos/awesomeWM/awesome/issues/1932","number":1932,"state":"closed","locked":false,"title":"Fix awful.widget.calendar_popup documentation","user":{"login":"mqus","id":8398165,"avatar_url":"https://avatars2.githubusercontent.com/u/8398165?v=4","gravatar_id":"","url":"https://api.github.com/users/mqus","html_url":"https://github.com/mqus","followers_url":"https://api.github.com/users/mqus/followers","following_url":"https://api.github.com/users/mqus/following{/other_user}","gists_url":"https://api.github.com/users/mqus/gists{/gist_id}","starred_url":"https://api.github.com/users/mqus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqus/subscriptions","organizations_url":"https://api.github.com/users/mqus/orgs","repos_url":"https://api.github.com/users/mqus/repos","events_url":"https://api.github.com/users/mqus/events{/privacy}","received_events_url":"https://api.github.com/users/mqus/received_events","type":"User","site_admin":false},"body":"There were multiple things which stood out to me, as I was trying to setup a simple calendar popup for the default textclock in my rc.lua:\r\n1. The functions in https://awesomewm.org/doc/api/classes/awful.widget.calendar_popup.html#Functions were not named correctly (calendar vs calendar_popup) which (naturally) produced an error when used as awful.widget.calendar.month() .\r\n2. The example for calendar_popup.month() was obviously missing a line (where does the month_calendar come from?) . Resolved by copying the line from the attach-example\r\n3. The same examples also only refer to the function as calendar.month() which should be changed to awful.widget.calendar_popup.month()\r\n","created_at":"2017-07-19T15:26:16Z","updated_at":"2017-07-19T15:43:22Z","closed_at":"2017-07-19T15:43:22Z","merged_at":"2017-07-19T15:43:22Z","merge_commit_sha":"81398f3d0a7e7feccc341b1b731f12f9c023ecc1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/awesomeWM/awesome/milestones/1","html_url":"https://github.com/awesomeWM/awesome/milestone/1","labels_url":"https://api.github.com/repos/awesomeWM/awesome/milestones/1/labels","id":1069592,"number":1,"title":"next: pull requests to be merged soon","description":"Pending pull requests to be merged soon.","creator":{"login":"blueyed","id":9766,"avatar_url":"https://avatars1.githubusercontent.com/u/9766?v=4","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":609,"state":"open","created_at":"2015-04-15T22:58:10Z","updated_at":"2017-07-19T15:43:22Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/1932/commits","review_comments_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/1932/comments","review_comment_url":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/issues/1932/comments","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/bd5f0dd3fc1fbda607756aecf470904ec17b0468","head":{"label":"mqus:patch-1","ref":"patch-1","sha":"bd5f0dd3fc1fbda607756aecf470904ec17b0468","user":{"login":"mqus","id":8398165,"avatar_url":"https://avatars2.githubusercontent.com/u/8398165?v=4","gravatar_id":"","url":"https://api.github.com/users/mqus","html_url":"https://github.com/mqus","followers_url":"https://api.github.com/users/mqus/followers","following_url":"https://api.github.com/users/mqus/following{/other_user}","gists_url":"https://api.github.com/users/mqus/gists{/gist_id}","starred_url":"https://api.github.com/users/mqus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqus/subscriptions","organizations_url":"https://api.github.com/users/mqus/orgs","repos_url":"https://api.github.com/users/mqus/repos","events_url":"https://api.github.com/users/mqus/events{/privacy}","received_events_url":"https://api.github.com/users/mqus/received_events","type":"User","site_admin":false},"repo":{"id":97730513,"name":"awesome","full_name":"mqus/awesome","owner":{"login":"mqus","id":8398165,"avatar_url":"https://avatars2.githubusercontent.com/u/8398165?v=4","gravatar_id":"","url":"https://api.github.com/users/mqus","html_url":"https://github.com/mqus","followers_url":"https://api.github.com/users/mqus/followers","following_url":"https://api.github.com/users/mqus/following{/other_user}","gists_url":"https://api.github.com/users/mqus/gists{/gist_id}","starred_url":"https://api.github.com/users/mqus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mqus/subscriptions","organizations_url":"https://api.github.com/users/mqus/orgs","repos_url":"https://api.github.com/users/mqus/repos","events_url":"https://api.github.com/users/mqus/events{/privacy}","received_events_url":"https://api.github.com/users/mqus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mqus/awesome","description":"awesome window manager","fork":true,"url":"https://api.github.com/repos/mqus/awesome","forks_url":"https://api.github.com/repos/mqus/awesome/forks","keys_url":"https://api.github.com/repos/mqus/awesome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mqus/awesome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mqus/awesome/teams","hooks_url":"https://api.github.com/repos/mqus/awesome/hooks","issue_events_url":"https://api.github.com/repos/mqus/awesome/issues/events{/number}","events_url":"https://api.github.com/repos/mqus/awesome/events","assignees_url":"https://api.github.com/repos/mqus/awesome/assignees{/user}","branches_url":"https://api.github.com/repos/mqus/awesome/branches{/branch}","tags_url":"https://api.github.com/repos/mqus/awesome/tags","blobs_url":"https://api.github.com/repos/mqus/awesome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mqus/awesome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mqus/awesome/git/refs{/sha}","trees_url":"https://api.github.com/repos/mqus/awesome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mqus/awesome/statuses/{sha}","languages_url":"https://api.github.com/repos/mqus/awesome/languages","stargazers_url":"https://api.github.com/repos/mqus/awesome/stargazers","contributors_url":"https://api.github.com/repos/mqus/awesome/contributors","subscribers_url":"https://api.github.com/repos/mqus/awesome/subscribers","subscription_url":"https://api.github.com/repos/mqus/awesome/subscription","commits_url":"https://api.github.com/repos/mqus/awesome/commits{/sha}","git_commits_url":"https://api.github.com/repos/mqus/awesome/git/commits{/sha}","comments_url":"https://api.github.com/repos/mqus/awesome/comments{/number}","issue_comment_url":"https://api.github.com/repos/mqus/awesome/issues/comments{/number}","contents_url":"https://api.github.com/repos/mqus/awesome/contents/{+path}","compare_url":"https://api.github.com/repos/mqus/awesome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mqus/awesome/merges","archive_url":"https://api.github.com/repos/mqus/awesome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mqus/awesome/downloads","issues_url":"https://api.github.com/repos/mqus/awesome/issues{/number}","pulls_url":"https://api.github.com/repos/mqus/awesome/pulls{/number}","milestones_url":"https://api.github.com/repos/mqus/awesome/milestones{/number}","notifications_url":"https://api.github.com/repos/mqus/awesome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mqus/awesome/labels{/name}","releases_url":"https://api.github.com/repos/mqus/awesome/releases{/id}","deployments_url":"https://api.github.com/repos/mqus/awesome/deployments","created_at":"2017-07-19T15:09:40Z","updated_at":"2017-07-19T15:09:43Z","pushed_at":"2017-07-19T15:22:32Z","git_url":"git://github.com/mqus/awesome.git","ssh_url":"git@github.com:mqus/awesome.git","clone_url":"https://github.com/mqus/awesome.git","svn_url":"https://github.com/mqus/awesome","homepage":"https://awesomewm.org/","size":13226,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awesomeWM:master","ref":"master","sha":"cb10a3fe45cae31d2304a03e9a55debac7340ec1","user":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars3.githubusercontent.com/u/6843364?v=4","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"repo":{"id":17378009,"name":"awesome","full_name":"awesomeWM/awesome","owner":{"login":"awesomeWM","id":6843364,"avatar_url":"https://avatars3.githubusercontent.com/u/6843364?v=4","gravatar_id":"","url":"https://api.github.com/users/awesomeWM","html_url":"https://github.com/awesomeWM","followers_url":"https://api.github.com/users/awesomeWM/followers","following_url":"https://api.github.com/users/awesomeWM/following{/other_user}","gists_url":"https://api.github.com/users/awesomeWM/gists{/gist_id}","starred_url":"https://api.github.com/users/awesomeWM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesomeWM/subscriptions","organizations_url":"https://api.github.com/users/awesomeWM/orgs","repos_url":"https://api.github.com/users/awesomeWM/repos","events_url":"https://api.github.com/users/awesomeWM/events{/privacy}","received_events_url":"https://api.github.com/users/awesomeWM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awesomeWM/awesome","description":"awesome window manager","fork":false,"url":"https://api.github.com/repos/awesomeWM/awesome","forks_url":"https://api.github.com/repos/awesomeWM/awesome/forks","keys_url":"https://api.github.com/repos/awesomeWM/awesome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awesomeWM/awesome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awesomeWM/awesome/teams","hooks_url":"https://api.github.com/repos/awesomeWM/awesome/hooks","issue_events_url":"https://api.github.com/repos/awesomeWM/awesome/issues/events{/number}","events_url":"https://api.github.com/repos/awesomeWM/awesome/events","assignees_url":"https://api.github.com/repos/awesomeWM/awesome/assignees{/user}","branches_url":"https://api.github.com/repos/awesomeWM/awesome/branches{/branch}","tags_url":"https://api.github.com/repos/awesomeWM/awesome/tags","blobs_url":"https://api.github.com/repos/awesomeWM/awesome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awesomeWM/awesome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awesomeWM/awesome/git/refs{/sha}","trees_url":"https://api.github.com/repos/awesomeWM/awesome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awesomeWM/awesome/statuses/{sha}","languages_url":"https://api.github.com/repos/awesomeWM/awesome/languages","stargazers_url":"https://api.github.com/repos/awesomeWM/awesome/stargazers","contributors_url":"https://api.github.com/repos/awesomeWM/awesome/contributors","subscribers_url":"https://api.github.com/repos/awesomeWM/awesome/subscribers","subscription_url":"https://api.github.com/repos/awesomeWM/awesome/subscription","commits_url":"https://api.github.com/repos/awesomeWM/awesome/commits{/sha}","git_commits_url":"https://api.github.com/repos/awesomeWM/awesome/git/commits{/sha}","comments_url":"https://api.github.com/repos/awesomeWM/awesome/comments{/number}","issue_comment_url":"https://api.github.com/repos/awesomeWM/awesome/issues/comments{/number}","contents_url":"https://api.github.com/repos/awesomeWM/awesome/contents/{+path}","compare_url":"https://api.github.com/repos/awesomeWM/awesome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awesomeWM/awesome/merges","archive_url":"https://api.github.com/repos/awesomeWM/awesome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awesomeWM/awesome/downloads","issues_url":"https://api.github.com/repos/awesomeWM/awesome/issues{/number}","pulls_url":"https://api.github.com/repos/awesomeWM/awesome/pulls{/number}","milestones_url":"https://api.github.com/repos/awesomeWM/awesome/milestones{/number}","notifications_url":"https://api.github.com/repos/awesomeWM/awesome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awesomeWM/awesome/labels{/name}","releases_url":"https://api.github.com/repos/awesomeWM/awesome/releases{/id}","deployments_url":"https://api.github.com/repos/awesomeWM/awesome/deployments","created_at":"2014-03-03T19:56:16Z","updated_at":"2017-07-17T15:41:52Z","pushed_at":"2017-07-19T15:43:22Z","git_url":"git://github.com/awesomeWM/awesome.git","ssh_url":"git@github.com:awesomeWM/awesome.git","clone_url":"https://github.com/awesomeWM/awesome.git","svn_url":"https://github.com/awesomeWM/awesome","homepage":"https://awesomewm.org/","size":13226,"stargazers_count":1427,"watchers_count":1427,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":225,"mirror_url":null,"open_issues_count":180,"forks":225,"open_issues":180,"watchers":1427,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/1932"},"html":{"href":"https://github.com/awesomeWM/awesome/pull/1932"},"issue":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/1932"},"comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/issues/1932/comments"},"review_comments":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/1932/comments"},"review_comment":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awesomeWM/awesome/pulls/1932/commits"},"statuses":{"href":"https://api.github.com/repos/awesomeWM/awesome/statuses/bd5f0dd3fc1fbda607756aecf470904ec17b0468"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Elv13","id":340384,"avatar_url":"https://avatars0.githubusercontent.com/u/340384?v=4","gravatar_id":"","url":"https://api.github.com/users/Elv13","html_url":"https://github.com/Elv13","followers_url":"https://api.github.com/users/Elv13/followers","following_url":"https://api.github.com/users/Elv13/following{/other_user}","gists_url":"https://api.github.com/users/Elv13/gists{/gist_id}","starred_url":"https://api.github.com/users/Elv13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Elv13/subscriptions","organizations_url":"https://api.github.com/users/Elv13/orgs","repos_url":"https://api.github.com/users/Elv13/repos","events_url":"https://api.github.com/users/Elv13/events{/privacy}","received_events_url":"https://api.github.com/users/Elv13/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"Elv13"}}