{"action":"created","comment":{"url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/comments/153803739","pull_request_review_id":79865801,"id":153803739,"diff_hunk":"@@ -8,6 +8,9 @@ set -euo pipefail\n \n DESTDIR=${topsrcdir}/insttree\n \n+# Chown everything to writable, due to\n+# https://bugzilla.redhat.com/show_bug.cgi?id=517575\n+if test -d ${DESTDIR}; then chmod -R u+w ${DESTDIR}/; fi","path":"tests/vmcheck/install.sh","position":6,"original_position":6,"commit_id":"e68ffdb3d5ee910ad98efe63b355a2335a0c373c","original_commit_id":"e68ffdb3d5ee910ad98efe63b355a2335a0c373c","user":{"login":"jlebon","id":11934099,"avatar_url":"https://avatars3.githubusercontent.com/u/11934099?v=4","gravatar_id":"","url":"https://api.github.com/users/jlebon","html_url":"https://github.com/jlebon","followers_url":"https://api.github.com/users/jlebon/followers","following_url":"https://api.github.com/users/jlebon/following{/other_user}","gists_url":"https://api.github.com/users/jlebon/gists{/gist_id}","starred_url":"https://api.github.com/users/jlebon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlebon/subscriptions","organizations_url":"https://api.github.com/users/jlebon/orgs","repos_url":"https://api.github.com/users/jlebon/repos","events_url":"https://api.github.com/users/jlebon/events{/privacy}","received_events_url":"https://api.github.com/users/jlebon/received_events","type":"User","site_admin":false},"body":"We don't need this, right? We're wiping it out right under it.","created_at":"2017-11-29T14:36:11Z","updated_at":"2017-11-29T14:36:32Z","html_url":"https://github.com/projectatomic/rpm-ostree/pull/1115#discussion_r153803739","pull_request_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1115","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/comments/153803739"},"html":{"href":"https://github.com/projectatomic/rpm-ostree/pull/1115#discussion_r153803739"},"pull_request":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1115"}}},"pull_request":{"url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1115","id":155195716,"html_url":"https://github.com/projectatomic/rpm-ostree/pull/1115","diff_url":"https://github.com/projectatomic/rpm-ostree/pull/1115.diff","patch_url":"https://github.com/projectatomic/rpm-ostree/pull/1115.patch","issue_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/1115","number":1115,"state":"open","locked":false,"title":"tests: Correctly error out if some part of install.sh fails","user":{"login":"cgwalters","id":244096,"avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"body":"It took me way, way, way too long to debug that my dev container somehow missing\r\n`ostree-grub2` caused the script to fail early, but we'd still continue trying\r\nto sync, leading to us not actually changing the installed `rpm-ostree` binary,\r\nleading to test suite failures.\r\n\r\nAlso add the chmod hammer at the top so we can delete even if we fail after\r\ndoing an rsync.\r\n","created_at":"2017-11-28T22:05:25Z","updated_at":"2017-11-29T14:36:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a506ea5e148e9f97a307eb4006829843459bca6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1115/commits","review_comments_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1115/comments","review_comment_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/1115/comments","statuses_url":"https://api.github.com/repos/projectatomic/rpm-ostree/statuses/e68ffdb3d5ee910ad98efe63b355a2335a0c373c","head":{"label":"cgwalters:tests-handle-overlay-failure","ref":"tests-handle-overlay-failure","sha":"e68ffdb3d5ee910ad98efe63b355a2335a0c373c","user":{"login":"cgwalters","id":244096,"avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"repo":{"id":26416044,"name":"rpm-ostree","full_name":"cgwalters/rpm-ostree","owner":{"login":"cgwalters","id":244096,"avatar_url":"https://avatars0.githubusercontent.com/u/244096?v=4","gravatar_id":"","url":"https://api.github.com/users/cgwalters","html_url":"https://github.com/cgwalters","followers_url":"https://api.github.com/users/cgwalters/followers","following_url":"https://api.github.com/users/cgwalters/following{/other_user}","gists_url":"https://api.github.com/users/cgwalters/gists{/gist_id}","starred_url":"https://api.github.com/users/cgwalters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgwalters/subscriptions","organizations_url":"https://api.github.com/users/cgwalters/orgs","repos_url":"https://api.github.com/users/cgwalters/repos","events_url":"https://api.github.com/users/cgwalters/events{/privacy}","received_events_url":"https://api.github.com/users/cgwalters/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cgwalters/rpm-ostree","description":"Store RPMs in OSTree repository","fork":true,"url":"https://api.github.com/repos/cgwalters/rpm-ostree","forks_url":"https://api.github.com/repos/cgwalters/rpm-ostree/forks","keys_url":"https://api.github.com/repos/cgwalters/rpm-ostree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cgwalters/rpm-ostree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cgwalters/rpm-ostree/teams","hooks_url":"https://api.github.com/repos/cgwalters/rpm-ostree/hooks","issue_events_url":"https://api.github.com/repos/cgwalters/rpm-ostree/issues/events{/number}","events_url":"https://api.github.com/repos/cgwalters/rpm-ostree/events","assignees_url":"https://api.github.com/repos/cgwalters/rpm-ostree/assignees{/user}","branches_url":"https://api.github.com/repos/cgwalters/rpm-ostree/branches{/branch}","tags_url":"https://api.github.com/repos/cgwalters/rpm-ostree/tags","blobs_url":"https://api.github.com/repos/cgwalters/rpm-ostree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cgwalters/rpm-ostree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cgwalters/rpm-ostree/git/refs{/sha}","trees_url":"https://api.github.com/repos/cgwalters/rpm-ostree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cgwalters/rpm-ostree/statuses/{sha}","languages_url":"https://api.github.com/repos/cgwalters/rpm-ostree/languages","stargazers_url":"https://api.github.com/repos/cgwalters/rpm-ostree/stargazers","contributors_url":"https://api.github.com/repos/cgwalters/rpm-ostree/contributors","subscribers_url":"https://api.github.com/repos/cgwalters/rpm-ostree/subscribers","subscription_url":"https://api.github.com/repos/cgwalters/rpm-ostree/subscription","commits_url":"https://api.github.com/repos/cgwalters/rpm-ostree/commits{/sha}","git_commits_url":"https://api.github.com/repos/cgwalters/rpm-ostree/git/commits{/sha}","comments_url":"https://api.github.com/repos/cgwalters/rpm-ostree/comments{/number}","issue_comment_url":"https://api.github.com/repos/cgwalters/rpm-ostree/issues/comments{/number}","contents_url":"https://api.github.com/repos/cgwalters/rpm-ostree/contents/{+path}","compare_url":"https://api.github.com/repos/cgwalters/rpm-ostree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cgwalters/rpm-ostree/merges","archive_url":"https://api.github.com/repos/cgwalters/rpm-ostree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cgwalters/rpm-ostree/downloads","issues_url":"https://api.github.com/repos/cgwalters/rpm-ostree/issues{/number}","pulls_url":"https://api.github.com/repos/cgwalters/rpm-ostree/pulls{/number}","milestones_url":"https://api.github.com/repos/cgwalters/rpm-ostree/milestones{/number}","notifications_url":"https://api.github.com/repos/cgwalters/rpm-ostree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cgwalters/rpm-ostree/labels{/name}","releases_url":"https://api.github.com/repos/cgwalters/rpm-ostree/releases{/id}","deployments_url":"https://api.github.com/repos/cgwalters/rpm-ostree/deployments","created_at":"2014-11-10T01:32:34Z","updated_at":"2015-02-04T18:58:49Z","pushed_at":"2017-11-29T03:20:33Z","git_url":"git://github.com/cgwalters/rpm-ostree.git","ssh_url":"git@github.com:cgwalters/rpm-ostree.git","clone_url":"https://github.com/cgwalters/rpm-ostree.git","svn_url":"https://github.com/cgwalters/rpm-ostree","homepage":null,"size":6059,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectatomic:master","ref":"master","sha":"2ef240d40173e98b473858b51958ac40694bf971","user":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"repo":{"id":15369584,"name":"rpm-ostree","full_name":"projectatomic/rpm-ostree","owner":{"login":"projectatomic","id":6852258,"avatar_url":"https://avatars1.githubusercontent.com/u/6852258?v=4","gravatar_id":"","url":"https://api.github.com/users/projectatomic","html_url":"https://github.com/projectatomic","followers_url":"https://api.github.com/users/projectatomic/followers","following_url":"https://api.github.com/users/projectatomic/following{/other_user}","gists_url":"https://api.github.com/users/projectatomic/gists{/gist_id}","starred_url":"https://api.github.com/users/projectatomic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectatomic/subscriptions","organizations_url":"https://api.github.com/users/projectatomic/orgs","repos_url":"https://api.github.com/users/projectatomic/repos","events_url":"https://api.github.com/users/projectatomic/events{/privacy}","received_events_url":"https://api.github.com/users/projectatomic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectatomic/rpm-ostree","description":"Hybrid image/package system with atomic upgrades and package layering","fork":false,"url":"https://api.github.com/repos/projectatomic/rpm-ostree","forks_url":"https://api.github.com/repos/projectatomic/rpm-ostree/forks","keys_url":"https://api.github.com/repos/projectatomic/rpm-ostree/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectatomic/rpm-ostree/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectatomic/rpm-ostree/teams","hooks_url":"https://api.github.com/repos/projectatomic/rpm-ostree/hooks","issue_events_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/events{/number}","events_url":"https://api.github.com/repos/projectatomic/rpm-ostree/events","assignees_url":"https://api.github.com/repos/projectatomic/rpm-ostree/assignees{/user}","branches_url":"https://api.github.com/repos/projectatomic/rpm-ostree/branches{/branch}","tags_url":"https://api.github.com/repos/projectatomic/rpm-ostree/tags","blobs_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectatomic/rpm-ostree/statuses/{sha}","languages_url":"https://api.github.com/repos/projectatomic/rpm-ostree/languages","stargazers_url":"https://api.github.com/repos/projectatomic/rpm-ostree/stargazers","contributors_url":"https://api.github.com/repos/projectatomic/rpm-ostree/contributors","subscribers_url":"https://api.github.com/repos/projectatomic/rpm-ostree/subscribers","subscription_url":"https://api.github.com/repos/projectatomic/rpm-ostree/subscription","commits_url":"https://api.github.com/repos/projectatomic/rpm-ostree/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectatomic/rpm-ostree/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectatomic/rpm-ostree/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectatomic/rpm-ostree/contents/{+path}","compare_url":"https://api.github.com/repos/projectatomic/rpm-ostree/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectatomic/rpm-ostree/merges","archive_url":"https://api.github.com/repos/projectatomic/rpm-ostree/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectatomic/rpm-ostree/downloads","issues_url":"https://api.github.com/repos/projectatomic/rpm-ostree/issues{/number}","pulls_url":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls{/number}","milestones_url":"https://api.github.com/repos/projectatomic/rpm-ostree/milestones{/number}","notifications_url":"https://api.github.com/repos/projectatomic/rpm-ostree/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectatomic/rpm-ostree/labels{/name}","releases_url":"https://api.github.com/repos/projectatomic/rpm-ostree/releases{/id}","deployments_url":"https://api.github.com/repos/projectatomic/rpm-ostree/deployments","created_at":"2013-12-22T03:16:38Z","updated_at":"2017-11-24T20:37:38Z","pushed_at":"2017-11-29T03:20:34Z","git_url":"git://github.com/projectatomic/rpm-ostree.git","ssh_url":"git@github.com:projectatomic/rpm-ostree.git","clone_url":"https://github.com/projectatomic/rpm-ostree.git","svn_url":"https://github.com/projectatomic/rpm-ostree","homepage":"","size":5419,"stargazers_count":172,"watchers_count":172,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":146,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":70,"open_issues":146,"watchers":172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1115"},"html":{"href":"https://github.com/projectatomic/rpm-ostree/pull/1115"},"issue":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/1115"},"comments":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/issues/1115/comments"},"review_comments":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1115/comments"},"review_comment":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/pulls/1115/commits"},"statuses":{"href":"https://api.github.com/repos/projectatomic/rpm-ostree/statuses/e68ffdb3d5ee910ad98efe63b355a2335a0c373c"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jlebon"}}