{"action":"created","comment":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/118438586","pull_request_review_id":40229500,"id":118438586,"diff_hunk":"@@ -194,6 +194,19 @@ bool ResetGlobalPropertiesRequest::ResetHelpPromt(\n   }\n   smart_objects::SmartObject so_help_prompt =\n       smart_objects::SmartObject(smart_objects::SmartType_Array);\n+\n+  const std::vector<std::string>& help_prompt_default =\n+      application_manager_.get_settings().help_prompt();\n+\n+  for (uint32_t i = 0; i < help_prompt_default.size(); ++i) {","path":"src/components/application_manager/src/commands/mobile/reset_global_properties_request.cc","position":8,"original_position":8,"commit_id":"e2d58037f159abb87a6e017a640ebb0458d7f77c","original_commit_id":"e2d58037f159abb87a6e017a640ebb0458d7f77c","user":{"login":"AByzhynar","id":6764851,"avatar_url":"https://avatars2.githubusercontent.com/u/6764851?v=3","gravatar_id":"","url":"https://api.github.com/users/AByzhynar","html_url":"https://github.com/AByzhynar","followers_url":"https://api.github.com/users/AByzhynar/followers","following_url":"https://api.github.com/users/AByzhynar/following{/other_user}","gists_url":"https://api.github.com/users/AByzhynar/gists{/gist_id}","starred_url":"https://api.github.com/users/AByzhynar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AByzhynar/subscriptions","organizations_url":"https://api.github.com/users/AByzhynar/orgs","repos_url":"https://api.github.com/users/AByzhynar/repos","events_url":"https://api.github.com/users/AByzhynar/events{/privacy}","received_events_url":"https://api.github.com/users/AByzhynar/received_events","type":"User","site_admin":false},"body":"@AKalinich-Luxoft Don't compare different types even both of them unsigned. Type sizes can be different.","created_at":"2017-05-25T08:11:57Z","updated_at":"2017-05-25T08:17:07Z","html_url":"https://github.com/smartdevicelink/sdl_core/pull/1555#discussion_r118438586","pull_request_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1555","_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments/118438586"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/1555#discussion_r118438586"},"pull_request":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1555"}}},"pull_request":{"url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1555","id":122190957,"html_url":"https://github.com/smartdevicelink/sdl_core/pull/1555","diff_url":"https://github.com/smartdevicelink/sdl_core/pull/1555.diff","patch_url":"https://github.com/smartdevicelink/sdl_core/pull/1555.patch","issue_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1555","number":1555,"state":"open","locked":false,"title":"Fix ResetGlobalProperties help prompt parameter","user":{"login":"AKalinich-Luxoft","id":5848997,"avatar_url":"https://avatars0.githubusercontent.com/u/5848997?v=3","gravatar_id":"","url":"https://api.github.com/users/AKalinich-Luxoft","html_url":"https://github.com/AKalinich-Luxoft","followers_url":"https://api.github.com/users/AKalinich-Luxoft/followers","following_url":"https://api.github.com/users/AKalinich-Luxoft/following{/other_user}","gists_url":"https://api.github.com/users/AKalinich-Luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/AKalinich-Luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AKalinich-Luxoft/subscriptions","organizations_url":"https://api.github.com/users/AKalinich-Luxoft/orgs","repos_url":"https://api.github.com/users/AKalinich-Luxoft/repos","events_url":"https://api.github.com/users/AKalinich-Luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/AKalinich-Luxoft/received_events","type":"User","site_admin":false},"body":"Fixed `ResetGlobalProperties` help prompt request parameter reset to default value. \r\nThe root cause of this defect is that SDL does not get default help prompt value from Application Manager settings and does not assign it to app's help prompt. It just assigns an empty map.\r\n\r\nIn this pull request:\r\n- Added missed `help_prompt()` function to `ApplicationManagerSettings` interface\r\n- Added related mock method to `MockApplicationManagerSettings` class\r\n- Updated `ResetGlobalPropertiesRequest::ResetHelpPromt()` function logic to work as expected\r\n- Updated related unit tests","created_at":"2017-05-24T10:08:55Z","updated_at":"2017-05-25T08:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d76774167274f3330a3b108d9cab9476d43f1c9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1555/commits","review_comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1555/comments","review_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1555/comments","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/e2d58037f159abb87a6e017a640ebb0458d7f77c","head":{"label":"AKalinich-Luxoft:fix/fix_reset_global_properties_help_prompt","ref":"fix/fix_reset_global_properties_help_prompt","sha":"e2d58037f159abb87a6e017a640ebb0458d7f77c","user":{"login":"AKalinich-Luxoft","id":5848997,"avatar_url":"https://avatars0.githubusercontent.com/u/5848997?v=3","gravatar_id":"","url":"https://api.github.com/users/AKalinich-Luxoft","html_url":"https://github.com/AKalinich-Luxoft","followers_url":"https://api.github.com/users/AKalinich-Luxoft/followers","following_url":"https://api.github.com/users/AKalinich-Luxoft/following{/other_user}","gists_url":"https://api.github.com/users/AKalinich-Luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/AKalinich-Luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AKalinich-Luxoft/subscriptions","organizations_url":"https://api.github.com/users/AKalinich-Luxoft/orgs","repos_url":"https://api.github.com/users/AKalinich-Luxoft/repos","events_url":"https://api.github.com/users/AKalinich-Luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/AKalinich-Luxoft/received_events","type":"User","site_admin":false},"repo":{"id":92272405,"name":"sdl_core","full_name":"AKalinich-Luxoft/sdl_core","owner":{"login":"AKalinich-Luxoft","id":5848997,"avatar_url":"https://avatars0.githubusercontent.com/u/5848997?v=3","gravatar_id":"","url":"https://api.github.com/users/AKalinich-Luxoft","html_url":"https://github.com/AKalinich-Luxoft","followers_url":"https://api.github.com/users/AKalinich-Luxoft/followers","following_url":"https://api.github.com/users/AKalinich-Luxoft/following{/other_user}","gists_url":"https://api.github.com/users/AKalinich-Luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/AKalinich-Luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AKalinich-Luxoft/subscriptions","organizations_url":"https://api.github.com/users/AKalinich-Luxoft/orgs","repos_url":"https://api.github.com/users/AKalinich-Luxoft/repos","events_url":"https://api.github.com/users/AKalinich-Luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/AKalinich-Luxoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AKalinich-Luxoft/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":true,"url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core","forks_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/forks","keys_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/teams","hooks_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/events","assignees_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/tags","blobs_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/languages","stargazers_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/subscription","commits_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/merges","archive_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/downloads","issues_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/AKalinich-Luxoft/sdl_core/deployments","created_at":"2017-05-24T09:05:16Z","updated_at":"2017-05-24T09:05:27Z","pushed_at":"2017-05-24T12:27:54Z","git_url":"git://github.com/AKalinich-Luxoft/sdl_core.git","ssh_url":"git@github.com:AKalinich-Luxoft/sdl_core.git","clone_url":"https://github.com/AKalinich-Luxoft/sdl_core.git","svn_url":"https://github.com/AKalinich-Luxoft/sdl_core","homepage":"","size":305757,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"smartdevicelink:develop","ref":"develop","sha":"09e4eac5a4f176eba8f98dbb9525f07acccd330f","user":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars0.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"repo":{"id":24724170,"name":"sdl_core","full_name":"smartdevicelink/sdl_core","owner":{"login":"smartdevicelink","id":8671397,"avatar_url":"https://avatars0.githubusercontent.com/u/8671397?v=3","gravatar_id":"","url":"https://api.github.com/users/smartdevicelink","html_url":"https://github.com/smartdevicelink","followers_url":"https://api.github.com/users/smartdevicelink/followers","following_url":"https://api.github.com/users/smartdevicelink/following{/other_user}","gists_url":"https://api.github.com/users/smartdevicelink/gists{/gist_id}","starred_url":"https://api.github.com/users/smartdevicelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartdevicelink/subscriptions","organizations_url":"https://api.github.com/users/smartdevicelink/orgs","repos_url":"https://api.github.com/users/smartdevicelink/repos","events_url":"https://api.github.com/users/smartdevicelink/events{/privacy}","received_events_url":"https://api.github.com/users/smartdevicelink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/smartdevicelink/sdl_core","description":"SmartDeviceLink In-Vehicle Software and Sample HMI","fork":false,"url":"https://api.github.com/repos/smartdevicelink/sdl_core","forks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/forks","keys_url":"https://api.github.com/repos/smartdevicelink/sdl_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartdevicelink/sdl_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartdevicelink/sdl_core/teams","hooks_url":"https://api.github.com/repos/smartdevicelink/sdl_core/hooks","issue_events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/events{/number}","events_url":"https://api.github.com/repos/smartdevicelink/sdl_core/events","assignees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/assignees{/user}","branches_url":"https://api.github.com/repos/smartdevicelink/sdl_core/branches{/branch}","tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/tags","blobs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/{sha}","languages_url":"https://api.github.com/repos/smartdevicelink/sdl_core/languages","stargazers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/stargazers","contributors_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contributors","subscribers_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscribers","subscription_url":"https://api.github.com/repos/smartdevicelink/sdl_core/subscription","commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartdevicelink/sdl_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartdevicelink/sdl_core/contents/{+path}","compare_url":"https://api.github.com/repos/smartdevicelink/sdl_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartdevicelink/sdl_core/merges","archive_url":"https://api.github.com/repos/smartdevicelink/sdl_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartdevicelink/sdl_core/downloads","issues_url":"https://api.github.com/repos/smartdevicelink/sdl_core/issues{/number}","pulls_url":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls{/number}","milestones_url":"https://api.github.com/repos/smartdevicelink/sdl_core/milestones{/number}","notifications_url":"https://api.github.com/repos/smartdevicelink/sdl_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartdevicelink/sdl_core/labels{/name}","releases_url":"https://api.github.com/repos/smartdevicelink/sdl_core/releases{/id}","deployments_url":"https://api.github.com/repos/smartdevicelink/sdl_core/deployments","created_at":"2014-10-02T15:16:26Z","updated_at":"2017-05-25T06:48:49Z","pushed_at":"2017-05-25T07:16:23Z","git_url":"git://github.com/smartdevicelink/sdl_core.git","ssh_url":"git@github.com:smartdevicelink/sdl_core.git","clone_url":"https://github.com/smartdevicelink/sdl_core.git","svn_url":"https://github.com/smartdevicelink/sdl_core","homepage":"","size":305755,"stargazers_count":118,"watchers_count":118,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":258,"forks":136,"open_issues":258,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1555"},"html":{"href":"https://github.com/smartdevicelink/sdl_core/pull/1555"},"issue":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1555"},"comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/issues/1555/comments"},"review_comments":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1555/comments"},"review_comment":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/pulls/1555/commits"},"statuses":{"href":"https://api.github.com/repos/smartdevicelink/sdl_core/statuses/e2d58037f159abb87a6e017a640ebb0458d7f77c"}}}}
{"actor":{"display_login":"AByzhynar"}}