{"action":"created","issue":{"url":"https://api.github.com/repos/yireo/Yireo_GoogleTagManager2/issues/25","repository_url":"https://api.github.com/repos/yireo/Yireo_GoogleTagManager2","labels_url":"https://api.github.com/repos/yireo/Yireo_GoogleTagManager2/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/yireo/Yireo_GoogleTagManager2/issues/25/comments","events_url":"https://api.github.com/repos/yireo/Yireo_GoogleTagManager2/issues/25/events","html_url":"https://github.com/yireo/Yireo_GoogleTagManager2/issues/25","id":256759504,"number":25,"title":"Does loading via text/x-magento-init have any negative impact","user":{"login":"amenk","id":1087128,"avatar_url":"https://avatars0.githubusercontent.com/u/1087128?v=4","gravatar_id":"","url":"https://api.github.com/users/amenk","html_url":"https://github.com/amenk","followers_url":"https://api.github.com/users/amenk/followers","following_url":"https://api.github.com/users/amenk/following{/other_user}","gists_url":"https://api.github.com/users/amenk/gists{/gist_id}","starred_url":"https://api.github.com/users/amenk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amenk/subscriptions","organizations_url":"https://api.github.com/users/amenk/orgs","repos_url":"https://api.github.com/users/amenk/repos","events_url":"https://api.github.com/users/amenk/events{/privacy}","received_events_url":"https://api.github.com/users/amenk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-11T16:14:15Z","updated_at":"2017-09-11T16:30:11Z","closed_at":null,"author_association":"NONE","body":"Google recommends to load the tag manager as soon as possible after the `<body>` tag and to include also some code in the head tag. This does not seem to be the case in this module.\r\n\r\nIs this intentional?"},"comment":{"url":"https://api.github.com/repos/yireo/Yireo_GoogleTagManager2/issues/comments/328584197","html_url":"https://github.com/yireo/Yireo_GoogleTagManager2/issues/25#issuecomment-328584197","issue_url":"https://api.github.com/repos/yireo/Yireo_GoogleTagManager2/issues/25","id":328584197,"user":{"login":"jissereitsma","id":7670482,"avatar_url":"https://avatars0.githubusercontent.com/u/7670482?v=4","gravatar_id":"","url":"https://api.github.com/users/jissereitsma","html_url":"https://github.com/jissereitsma","followers_url":"https://api.github.com/users/jissereitsma/followers","following_url":"https://api.github.com/users/jissereitsma/following{/other_user}","gists_url":"https://api.github.com/users/jissereitsma/gists{/gist_id}","starred_url":"https://api.github.com/users/jissereitsma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jissereitsma/subscriptions","organizations_url":"https://api.github.com/users/jissereitsma/orgs","repos_url":"https://api.github.com/users/jissereitsma/repos","events_url":"https://api.github.com/users/jissereitsma/events{/privacy}","received_events_url":"https://api.github.com/users/jissereitsma/received_events","type":"User","site_admin":false},"created_at":"2017-09-11T16:30:11Z","updated_at":"2017-09-11T16:30:11Z","author_association":"COLLABORATOR","body":"I can't dive into the specifics of how Magento works internally, so I assume you are a frontend developer that understands the Magento JavaScript system inside out and therefore I can jump to the technical conclusion right away. First of all, `text/x-magento-init` is not rendered as JavaScript because it is not identified as a JavaScript script. What Google thinks of this is not something that applies to our extension, but to Magento 2 in general, so therefore I will refer to the Magento forums for this. This extension complies 100% with the Magento standards, so this definitely justifies the approach."}}
{"actor":{"display_login":"jissereitsma"}}