{"action":"closed","number":3,"pull_request":{"url":"https://api.github.com/repos/maxhoffmann/translations/pulls/3","id":59968234,"html_url":"https://github.com/maxhoffmann/translations/pull/3","diff_url":"https://github.com/maxhoffmann/translations/pull/3.diff","patch_url":"https://github.com/maxhoffmann/translations/pull/3.patch","issue_url":"https://api.github.com/repos/maxhoffmann/translations/issues/3","number":3,"state":"closed","locked":false,"title":"[RFR] Allow `null` as a valid value for translation","user":{"login":"HugoGiraudel","id":1889710,"avatar_url":"https://avatars3.githubusercontent.com/u/1889710?v=4","gravatar_id":"","url":"https://api.github.com/users/HugoGiraudel","html_url":"https://github.com/HugoGiraudel","followers_url":"https://api.github.com/users/HugoGiraudel/followers","following_url":"https://api.github.com/users/HugoGiraudel/following{/other_user}","gists_url":"https://api.github.com/users/HugoGiraudel/gists{/gist_id}","starred_url":"https://api.github.com/users/HugoGiraudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HugoGiraudel/subscriptions","organizations_url":"https://api.github.com/users/HugoGiraudel/orgs","repos_url":"https://api.github.com/users/HugoGiraudel/repos","events_url":"https://api.github.com/users/HugoGiraudel/events{/privacy}","received_events_url":"https://api.github.com/users/HugoGiraudel/received_events","type":"User","site_admin":false},"body":"There is no good reason to prevent a translation to be `null`. When deliberately wanting to define a translation to be incomplete (empty), `null` is a perfectly reasonable value.\n\nThis PR intends to fix that.\n\nWhen (if?) you merge, could you please bump a new version on npm? Thanks.\n","created_at":"2016-02-19T16:00:08Z","updated_at":"2017-08-04T12:02:20Z","closed_at":"2017-08-04T12:02:20Z","merged_at":null,"merge_commit_sha":"eeed720eabb444dc138b7a7a1f46f2745dcad1d6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/maxhoffmann/translations/pulls/3/commits","review_comments_url":"https://api.github.com/repos/maxhoffmann/translations/pulls/3/comments","review_comment_url":"https://api.github.com/repos/maxhoffmann/translations/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maxhoffmann/translations/issues/3/comments","statuses_url":"https://api.github.com/repos/maxhoffmann/translations/statuses/901dcd3ab99e897f14bd9d7401c20d91eafa41d0","head":{"label":"HugoGiraudel:patch-2","ref":"patch-2","sha":"901dcd3ab99e897f14bd9d7401c20d91eafa41d0","user":{"login":"HugoGiraudel","id":1889710,"avatar_url":"https://avatars3.githubusercontent.com/u/1889710?v=4","gravatar_id":"","url":"https://api.github.com/users/HugoGiraudel","html_url":"https://github.com/HugoGiraudel","followers_url":"https://api.github.com/users/HugoGiraudel/followers","following_url":"https://api.github.com/users/HugoGiraudel/following{/other_user}","gists_url":"https://api.github.com/users/HugoGiraudel/gists{/gist_id}","starred_url":"https://api.github.com/users/HugoGiraudel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HugoGiraudel/subscriptions","organizations_url":"https://api.github.com/users/HugoGiraudel/orgs","repos_url":"https://api.github.com/users/HugoGiraudel/repos","events_url":"https://api.github.com/users/HugoGiraudel/events{/privacy}","received_events_url":"https://api.github.com/users/HugoGiraudel/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"maxhoffmann:master","ref":"master","sha":"4f332add0128eac4733219f5f85b2280fa472954","user":{"login":"maxhoffmann","id":1227441,"avatar_url":"https://avatars0.githubusercontent.com/u/1227441?v=4","gravatar_id":"","url":"https://api.github.com/users/maxhoffmann","html_url":"https://github.com/maxhoffmann","followers_url":"https://api.github.com/users/maxhoffmann/followers","following_url":"https://api.github.com/users/maxhoffmann/following{/other_user}","gists_url":"https://api.github.com/users/maxhoffmann/gists{/gist_id}","starred_url":"https://api.github.com/users/maxhoffmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxhoffmann/subscriptions","organizations_url":"https://api.github.com/users/maxhoffmann/orgs","repos_url":"https://api.github.com/users/maxhoffmann/repos","events_url":"https://api.github.com/users/maxhoffmann/events{/privacy}","received_events_url":"https://api.github.com/users/maxhoffmann/received_events","type":"User","site_admin":false},"repo":{"id":29267906,"name":"translations","full_name":"maxhoffmann/translations","owner":{"login":"maxhoffmann","id":1227441,"avatar_url":"https://avatars0.githubusercontent.com/u/1227441?v=4","gravatar_id":"","url":"https://api.github.com/users/maxhoffmann","html_url":"https://github.com/maxhoffmann","followers_url":"https://api.github.com/users/maxhoffmann/followers","following_url":"https://api.github.com/users/maxhoffmann/following{/other_user}","gists_url":"https://api.github.com/users/maxhoffmann/gists{/gist_id}","starred_url":"https://api.github.com/users/maxhoffmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxhoffmann/subscriptions","organizations_url":"https://api.github.com/users/maxhoffmann/orgs","repos_url":"https://api.github.com/users/maxhoffmann/repos","events_url":"https://api.github.com/users/maxhoffmann/events{/privacy}","received_events_url":"https://api.github.com/users/maxhoffmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxhoffmann/translations","description":":earth_africa: translations api for node.js, browsers and the command line","fork":false,"url":"https://api.github.com/repos/maxhoffmann/translations","forks_url":"https://api.github.com/repos/maxhoffmann/translations/forks","keys_url":"https://api.github.com/repos/maxhoffmann/translations/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxhoffmann/translations/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxhoffmann/translations/teams","hooks_url":"https://api.github.com/repos/maxhoffmann/translations/hooks","issue_events_url":"https://api.github.com/repos/maxhoffmann/translations/issues/events{/number}","events_url":"https://api.github.com/repos/maxhoffmann/translations/events","assignees_url":"https://api.github.com/repos/maxhoffmann/translations/assignees{/user}","branches_url":"https://api.github.com/repos/maxhoffmann/translations/branches{/branch}","tags_url":"https://api.github.com/repos/maxhoffmann/translations/tags","blobs_url":"https://api.github.com/repos/maxhoffmann/translations/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxhoffmann/translations/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxhoffmann/translations/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxhoffmann/translations/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxhoffmann/translations/statuses/{sha}","languages_url":"https://api.github.com/repos/maxhoffmann/translations/languages","stargazers_url":"https://api.github.com/repos/maxhoffmann/translations/stargazers","contributors_url":"https://api.github.com/repos/maxhoffmann/translations/contributors","subscribers_url":"https://api.github.com/repos/maxhoffmann/translations/subscribers","subscription_url":"https://api.github.com/repos/maxhoffmann/translations/subscription","commits_url":"https://api.github.com/repos/maxhoffmann/translations/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxhoffmann/translations/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxhoffmann/translations/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxhoffmann/translations/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxhoffmann/translations/contents/{+path}","compare_url":"https://api.github.com/repos/maxhoffmann/translations/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxhoffmann/translations/merges","archive_url":"https://api.github.com/repos/maxhoffmann/translations/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxhoffmann/translations/downloads","issues_url":"https://api.github.com/repos/maxhoffmann/translations/issues{/number}","pulls_url":"https://api.github.com/repos/maxhoffmann/translations/pulls{/number}","milestones_url":"https://api.github.com/repos/maxhoffmann/translations/milestones{/number}","notifications_url":"https://api.github.com/repos/maxhoffmann/translations/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxhoffmann/translations/labels{/name}","releases_url":"https://api.github.com/repos/maxhoffmann/translations/releases{/id}","deployments_url":"https://api.github.com/repos/maxhoffmann/translations/deployments","created_at":"2015-01-14T21:57:39Z","updated_at":"2015-12-24T22:36:02Z","pushed_at":"2016-02-19T16:00:08Z","git_url":"git://github.com/maxhoffmann/translations.git","ssh_url":"git@github.com:maxhoffmann/translations.git","clone_url":"https://github.com/maxhoffmann/translations.git","svn_url":"https://github.com/maxhoffmann/translations","homepage":"","size":25,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maxhoffmann/translations/pulls/3"},"html":{"href":"https://github.com/maxhoffmann/translations/pull/3"},"issue":{"href":"https://api.github.com/repos/maxhoffmann/translations/issues/3"},"comments":{"href":"https://api.github.com/repos/maxhoffmann/translations/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/maxhoffmann/translations/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/maxhoffmann/translations/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maxhoffmann/translations/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/maxhoffmann/translations/statuses/901dcd3ab99e897f14bd9d7401c20d91eafa41d0"}},"merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"HugoGiraudel"}}