{"action":"closed","number":9299,"pull_request":{"url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/9299","id":105763804,"html_url":"https://github.com/hrydgard/ppsspp/pull/9299","diff_url":"https://github.com/hrydgard/ppsspp/pull/9299.diff","patch_url":"https://github.com/hrydgard/ppsspp/pull/9299.patch","issue_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/9299","number":9299,"state":"closed","locked":false,"title":"Fix fake mipmap issue related #5350","user":{"login":"xebra","id":1607422,"avatar_url":"https://avatars.githubusercontent.com/u/1607422?v=3","gravatar_id":"","url":"https://api.github.com/users/xebra","html_url":"https://github.com/xebra","followers_url":"https://api.github.com/users/xebra/followers","following_url":"https://api.github.com/users/xebra/following{/other_user}","gists_url":"https://api.github.com/users/xebra/gists{/gist_id}","starred_url":"https://api.github.com/users/xebra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xebra/subscriptions","organizations_url":"https://api.github.com/users/xebra/orgs","repos_url":"https://api.github.com/users/xebra/repos","events_url":"https://api.github.com/users/xebra/events{/privacy}","received_events_url":"https://api.github.com/users/xebra/received_events","type":"User","site_admin":false},"body":"I fixed fake mipmap issue about #5350, it is based ghost(@exhalatio?)'s codes.\r\nThis seems may be hacky, and using 3D texture is better solution.\r\nHowever this issue needs to fix immediately. So I hope to fix this without any problem and I tested with some games. I think this codes working fine but it may need more testing.\r\n\r\nTactics Ogre - Graphics OK\r\nGran Turismo - Graphics & FPS60 OK\r\nOutrun 2006 - Graphics OK\r\n\r\nAlso, GE_TEXLEVEL_MODE_CONST returns only integer values. I guess it's not \"lod bias\", it's \"mipmap number\". GE_TEXLEVEL_MODE_AUTO returns floating point number.\r\nResearched in Gran Turismo\r\n![-2](https://cloud.githubusercontent.com/assets/1607422/22856507/03e849b6-f0d6-11e6-8c3c-4a3b24c23e85.jpg)\r\n\r\nThis is my guess.\r\nGE_TEXLEVEL_MODE_AUTO\r\nAutoselect mipmap from \"lod bias\" by gpu(graphics API).\r\nGE_TEXLEVEL_MODE_CONST\r\nSelect mipmap directly from \"mipmap number(lod bias)\" by a hand.\r\n\r\nSo, we may need to fix this codes \r\n\r\n\r\n```\r\n\t\t\t\tswitch (mode) {\r\n\t\t\t\tcase GE_TEXLEVEL_MODE_AUTO:\r\n\t\t\t\t\t// TODO\r\n\t\t\t\t\tbreak;\r\n\t\t\t\tcase GE_TEXLEVEL_MODE_CONST:\r\n\t\t\t\t\t// Sigh, LOD_BIAS is not even in ES 3.0..\r\n#ifndef USING_GLES2\r\n\t\t\t\t\tglTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_LOD_BIAS, lodBias);\r\n#endif\r\n\t\t\t\t\tbreak;\r\n\t\t\t\tcase GE_TEXLEVEL_MODE_SLOPE:\r\n\t\t\t\t\t// TODO\r\n\t\t\t\t\tbreak;\r\n\t\t\t\t}\r\n```\r\n\r\nto\r\n\r\n```\r\n\t\t\t\tswitch (mode) {\r\n\t\t\t\tcase GE_TEXLEVEL_MODE_AUTO:\r\n\t\t\t\t\t// Sigh, LOD_BIAS is not even in ES 3.0..\r\n#ifndef USING_GLES2\r\n\t\t\t\t\tglTexParameterf(GL_TEXTURE_2D, GL_TEXTURE_LOD_BIAS, lodBias);\r\n#endif\r\n\t\t\t\t\tbreak;\r\n\t\t\t\tcase GE_TEXLEVEL_MODE_CONST:\r\n\r\n\t\t\t\t\tbreak;\r\n\t\t\t\tcase GE_TEXLEVEL_MODE_SLOPE:\r\n\t\t\t\t\t// TODO\r\n\t\t\t\t\tbreak;\r\n\t\t\t\t}\r\n```","created_at":"2017-02-11T19:05:35Z","updated_at":"2017-02-14T20:34:56Z","closed_at":"2017-02-14T20:34:56Z","merged_at":"2017-02-14T20:34:56Z","merge_commit_sha":"bbd74d9efe5b5cbc42e51f4c0c2222c5d9a82cba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/9299/commits","review_comments_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/9299/comments","review_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/9299/comments","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/e2f9dc8f2826bec7e683e17c9de6d8b0bfb2ccf6","head":{"label":"xebra:fake_mipmap","ref":"fake_mipmap","sha":"e2f9dc8f2826bec7e683e17c9de6d8b0bfb2ccf6","user":{"login":"xebra","id":1607422,"avatar_url":"https://avatars.githubusercontent.com/u/1607422?v=3","gravatar_id":"","url":"https://api.github.com/users/xebra","html_url":"https://github.com/xebra","followers_url":"https://api.github.com/users/xebra/followers","following_url":"https://api.github.com/users/xebra/following{/other_user}","gists_url":"https://api.github.com/users/xebra/gists{/gist_id}","starred_url":"https://api.github.com/users/xebra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xebra/subscriptions","organizations_url":"https://api.github.com/users/xebra/orgs","repos_url":"https://api.github.com/users/xebra/repos","events_url":"https://api.github.com/users/xebra/events{/privacy}","received_events_url":"https://api.github.com/users/xebra/received_events","type":"User","site_admin":false},"repo":{"id":79877076,"name":"ppsspp","full_name":"xebra/ppsspp","owner":{"login":"xebra","id":1607422,"avatar_url":"https://avatars.githubusercontent.com/u/1607422?v=3","gravatar_id":"","url":"https://api.github.com/users/xebra","html_url":"https://github.com/xebra","followers_url":"https://api.github.com/users/xebra/followers","following_url":"https://api.github.com/users/xebra/following{/other_user}","gists_url":"https://api.github.com/users/xebra/gists{/gist_id}","starred_url":"https://api.github.com/users/xebra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xebra/subscriptions","organizations_url":"https://api.github.com/users/xebra/orgs","repos_url":"https://api.github.com/users/xebra/repos","events_url":"https://api.github.com/users/xebra/events{/privacy}","received_events_url":"https://api.github.com/users/xebra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xebra/ppsspp","description":"A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us in #ppsspp on freenode (IRC) or just send pull requests / issues. For discussion use the forums on ppsspp.org.","fork":true,"url":"https://api.github.com/repos/xebra/ppsspp","forks_url":"https://api.github.com/repos/xebra/ppsspp/forks","keys_url":"https://api.github.com/repos/xebra/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xebra/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xebra/ppsspp/teams","hooks_url":"https://api.github.com/repos/xebra/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/xebra/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/xebra/ppsspp/events","assignees_url":"https://api.github.com/repos/xebra/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/xebra/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/xebra/ppsspp/tags","blobs_url":"https://api.github.com/repos/xebra/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xebra/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xebra/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/xebra/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xebra/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/xebra/ppsspp/languages","stargazers_url":"https://api.github.com/repos/xebra/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/xebra/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/xebra/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/xebra/ppsspp/subscription","commits_url":"https://api.github.com/repos/xebra/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/xebra/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/xebra/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/xebra/ppsspp/issues/comments{/number}","contents_url":"https://api.github.com/repos/xebra/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/xebra/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xebra/ppsspp/merges","archive_url":"https://api.github.com/repos/xebra/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xebra/ppsspp/downloads","issues_url":"https://api.github.com/repos/xebra/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/xebra/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/xebra/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/xebra/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xebra/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/xebra/ppsspp/releases{/id}","deployments_url":"https://api.github.com/repos/xebra/ppsspp/deployments","created_at":"2017-01-24T04:06:00Z","updated_at":"2017-01-24T04:06:09Z","pushed_at":"2017-02-14T16:04:33Z","git_url":"git://github.com/xebra/ppsspp.git","ssh_url":"git@github.com:xebra/ppsspp.git","clone_url":"https://github.com/xebra/ppsspp.git","svn_url":"https://github.com/xebra/ppsspp","homepage":"http://www.ppsspp.org","size":97601,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hrydgard:master","ref":"master","sha":"cbf24a9d7863ae6c6826d1e2f4eaf7eafa1b4816","user":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"repo":{"id":6486826,"name":"ppsspp","full_name":"hrydgard/ppsspp","owner":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hrydgard/ppsspp","description":"A PSP emulator for Android, Windows, Mac and Linux, written in C++. Want to contribute? Join us in #ppsspp on freenode (IRC) or just send pull requests / issues. For discussion use the forums on ppsspp.org.","fork":false,"url":"https://api.github.com/repos/hrydgard/ppsspp","forks_url":"https://api.github.com/repos/hrydgard/ppsspp/forks","keys_url":"https://api.github.com/repos/hrydgard/ppsspp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hrydgard/ppsspp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hrydgard/ppsspp/teams","hooks_url":"https://api.github.com/repos/hrydgard/ppsspp/hooks","issue_events_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/events{/number}","events_url":"https://api.github.com/repos/hrydgard/ppsspp/events","assignees_url":"https://api.github.com/repos/hrydgard/ppsspp/assignees{/user}","branches_url":"https://api.github.com/repos/hrydgard/ppsspp/branches{/branch}","tags_url":"https://api.github.com/repos/hrydgard/ppsspp/tags","blobs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hrydgard/ppsspp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hrydgard/ppsspp/git/refs{/sha}","trees_url":"https://api.github.com/repos/hrydgard/ppsspp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hrydgard/ppsspp/statuses/{sha}","languages_url":"https://api.github.com/repos/hrydgard/ppsspp/languages","stargazers_url":"https://api.github.com/repos/hrydgard/ppsspp/stargazers","contributors_url":"https://api.github.com/repos/hrydgard/ppsspp/contributors","subscribers_url":"https://api.github.com/repos/hrydgard/ppsspp/subscribers","subscription_url":"https://api.github.com/repos/hrydgard/ppsspp/subscription","commits_url":"https://api.github.com/repos/hrydgard/ppsspp/commits{/sha}","git_commits_url":"https://api.github.com/repos/hrydgard/ppsspp/git/commits{/sha}","comments_url":"https://api.github.com/repos/hrydgard/ppsspp/comments{/number}","issue_comment_url":"https://api.github.com/repos/hrydgard/ppsspp/issues/comments{/number}","contents_url":"https://api.github.com/repos/hrydgard/ppsspp/contents/{+path}","compare_url":"https://api.github.com/repos/hrydgard/ppsspp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hrydgard/ppsspp/merges","archive_url":"https://api.github.com/repos/hrydgard/ppsspp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hrydgard/ppsspp/downloads","issues_url":"https://api.github.com/repos/hrydgard/ppsspp/issues{/number}","pulls_url":"https://api.github.com/repos/hrydgard/ppsspp/pulls{/number}","milestones_url":"https://api.github.com/repos/hrydgard/ppsspp/milestones{/number}","notifications_url":"https://api.github.com/repos/hrydgard/ppsspp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hrydgard/ppsspp/labels{/name}","releases_url":"https://api.github.com/repos/hrydgard/ppsspp/releases{/id}","deployments_url":"https://api.github.com/repos/hrydgard/ppsspp/deployments","created_at":"2012-11-01T08:41:48Z","updated_at":"2017-02-13T20:17:26Z","pushed_at":"2017-02-14T20:34:56Z","git_url":"git://github.com/hrydgard/ppsspp.git","ssh_url":"git@github.com:hrydgard/ppsspp.git","clone_url":"https://github.com/hrydgard/ppsspp.git","svn_url":"https://github.com/hrydgard/ppsspp","homepage":"http://www.ppsspp.org","size":97549,"stargazers_count":2706,"watchers_count":2706,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1005,"mirror_url":null,"open_issues_count":657,"forks":1005,"open_issues":657,"watchers":2706,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/9299"},"html":{"href":"https://github.com/hrydgard/ppsspp/pull/9299"},"issue":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/9299"},"comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/issues/9299/comments"},"review_comments":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/9299/comments"},"review_comment":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hrydgard/ppsspp/pulls/9299/commits"},"statuses":{"href":"https://api.github.com/repos/hrydgard/ppsspp/statuses/e2f9dc8f2826bec7e683e17c9de6d8b0bfb2ccf6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"hrydgard","id":130929,"avatar_url":"https://avatars.githubusercontent.com/u/130929?v=3","gravatar_id":"","url":"https://api.github.com/users/hrydgard","html_url":"https://github.com/hrydgard","followers_url":"https://api.github.com/users/hrydgard/followers","following_url":"https://api.github.com/users/hrydgard/following{/other_user}","gists_url":"https://api.github.com/users/hrydgard/gists{/gist_id}","starred_url":"https://api.github.com/users/hrydgard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hrydgard/subscriptions","organizations_url":"https://api.github.com/users/hrydgard/orgs","repos_url":"https://api.github.com/users/hrydgard/repos","events_url":"https://api.github.com/users/hrydgard/events{/privacy}","received_events_url":"https://api.github.com/users/hrydgard/received_events","type":"User","site_admin":false},"comments":8,"review_comments":4,"maintainer_can_modify":false,"commits":4,"additions":90,"deletions":25,"changed_files":13}}
{"actor":{"display_login":"hrydgard"}}