{"action":"created","issue":{"url":"https://api.github.com/repos/apache/storm/issues/2117","repository_url":"https://api.github.com/repos/apache/storm","labels_url":"https://api.github.com/repos/apache/storm/issues/2117/labels{/name}","comments_url":"https://api.github.com/repos/apache/storm/issues/2117/comments","events_url":"https://api.github.com/repos/apache/storm/issues/2117/events","html_url":"https://github.com/apache/storm/pull/2117","id":228828250,"number":2117,"title":"STORM-2515: Fix most checkstyle violations in storm-kafka-client","user":{"login":"srdo","id":4324588,"avatar_url":"https://avatars2.githubusercontent.com/u/4324588?v=3","gravatar_id":"","url":"https://api.github.com/users/srdo","html_url":"https://github.com/srdo","followers_url":"https://api.github.com/users/srdo/followers","following_url":"https://api.github.com/users/srdo/following{/other_user}","gists_url":"https://api.github.com/users/srdo/gists{/gist_id}","starred_url":"https://api.github.com/users/srdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srdo/subscriptions","organizations_url":"https://api.github.com/users/srdo/orgs","repos_url":"https://api.github.com/users/srdo/repos","events_url":"https://api.github.com/users/srdo/events{/privacy}","received_events_url":"https://api.github.com/users/srdo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-05-15T20:03:09Z","updated_at":"2017-06-06T15:38:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/storm/pulls/2117","html_url":"https://github.com/apache/storm/pull/2117","diff_url":"https://github.com/apache/storm/pull/2117.diff","patch_url":"https://github.com/apache/storm/pull/2117.patch"},"body":"Most of the remaining violations are a couple of methods missing javadocs in the Trident code, which I don't feel familiar enough with Trident to write. The last couple are because there's a method in KafkaSpoutConfig that contains the SSL abbreviation. The rules only allow 2 capital letters in an abbreviation. Renaming is a breaking change, but maybe this isn't an issue for 2.0?\r\n\r\nI also added a commit making a few other changes I thought made sense. The KafkaSpoutMessageId.getMetadata method was including the TopicPartition 3 times. The found variable in OffsetManager.findNextCommitOffset can be replaced with a null check of nextCommitMsg. They are in a separate commit for now, so this is easier to review."},"comment":{"url":"https://api.github.com/repos/apache/storm/issues/comments/306526224","html_url":"https://github.com/apache/storm/pull/2117#issuecomment-306526224","issue_url":"https://api.github.com/repos/apache/storm/issues/2117","id":306526224,"user":{"login":"srdo","id":4324588,"avatar_url":"https://avatars2.githubusercontent.com/u/4324588?v=3","gravatar_id":"","url":"https://api.github.com/users/srdo","html_url":"https://github.com/srdo","followers_url":"https://api.github.com/users/srdo/followers","following_url":"https://api.github.com/users/srdo/following{/other_user}","gists_url":"https://api.github.com/users/srdo/gists{/gist_id}","starred_url":"https://api.github.com/users/srdo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srdo/subscriptions","organizations_url":"https://api.github.com/users/srdo/orgs","repos_url":"https://api.github.com/users/srdo/repos","events_url":"https://api.github.com/users/srdo/events{/privacy}","received_events_url":"https://api.github.com/users/srdo/received_events","type":"User","site_admin":false},"created_at":"2017-06-06T15:38:04Z","updated_at":"2017-06-06T15:38:04Z","body":"@erikdw That sounds good to me. I'd like to get all the changes done in one PR (plus two for 1.x, 1.0.x) if possible, so we don't have to deal with this again later. Will probably take a look at it sometime this week.\r\n\r\nIt makes sense to wait to allow suppression until we need it IMO. We can always add it later if we need it. "}}
{"actor":{"display_login":"srdo"}}