{"action":"created","issue":{"url":"https://api.github.com/repos/biolab/orange3/issues/1977","repository_url":"https://api.github.com/repos/biolab/orange3","labels_url":"https://api.github.com/repos/biolab/orange3/issues/1977/labels{/name}","comments_url":"https://api.github.com/repos/biolab/orange3/issues/1977/comments","events_url":"https://api.github.com/repos/biolab/orange3/issues/1977/events","html_url":"https://github.com/biolab/orange3/pull/1977","id":203858005,"number":1977,"title":"[FIX] Fitter: Fix infinite recursion in __getattr__","user":{"login":"pavlin-policar","id":5758119,"avatar_url":"https://avatars.githubusercontent.com/u/5758119?v=3","gravatar_id":"","url":"https://api.github.com/users/pavlin-policar","html_url":"https://github.com/pavlin-policar","followers_url":"https://api.github.com/users/pavlin-policar/followers","following_url":"https://api.github.com/users/pavlin-policar/following{/other_user}","gists_url":"https://api.github.com/users/pavlin-policar/gists{/gist_id}","starred_url":"https://api.github.com/users/pavlin-policar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pavlin-policar/subscriptions","organizations_url":"https://api.github.com/users/pavlin-policar/orgs","repos_url":"https://api.github.com/users/pavlin-policar/repos","events_url":"https://api.github.com/users/pavlin-policar/events{/privacy}","received_events_url":"https://api.github.com/users/pavlin-policar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-01-29T08:34:08Z","updated_at":"2017-02-20T09:55:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/biolab/orange3/pulls/1977","html_url":"https://github.com/biolab/orange3/pull/1977","diff_url":"https://github.com/biolab/orange3/pull/1977.diff","patch_url":"https://github.com/biolab/orange3/pull/1977.patch"},"body":"##### Issue\r\nRunning fitters on large enough datasets through the test and score widget and setting it to cross validation would result in a stack overflow error.\r\n\r\nI am not particularly sure why this happened, my theory is that when test and score receives a large enough dataset, it runs cross validation in parallel, and that the learner attributes were probably accessed statically and failing.\r\n\r\nUnfortunately, I have no idea what caused this and how exactly it was called, so I don't really know how to test against this. But since I will most likely change this in the near future, I wouldn't spend too much time on this.\r\n\r\n##### Description of changes\r\nNo longer rely on `self.kwargs` being on the object, but raise attribute error by explicitly getting `kwargs` with `__getattribute__`.\r\n\r\n##### Includes\r\n- [X] Code changes\r\n- [ ] Tests\r\n- [ ] Documentation\r\n"},"comment":{"url":"https://api.github.com/repos/biolab/orange3/issues/comments/281034552","html_url":"https://github.com/biolab/orange3/pull/1977#issuecomment-281034552","issue_url":"https://api.github.com/repos/biolab/orange3/issues/1977","id":281034552,"user":{"login":"ajdapretnar","id":12524972,"avatar_url":"https://avatars.githubusercontent.com/u/12524972?v=3","gravatar_id":"","url":"https://api.github.com/users/ajdapretnar","html_url":"https://github.com/ajdapretnar","followers_url":"https://api.github.com/users/ajdapretnar/followers","following_url":"https://api.github.com/users/ajdapretnar/following{/other_user}","gists_url":"https://api.github.com/users/ajdapretnar/gists{/gist_id}","starred_url":"https://api.github.com/users/ajdapretnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajdapretnar/subscriptions","organizations_url":"https://api.github.com/users/ajdapretnar/orgs","repos_url":"https://api.github.com/users/ajdapretnar/repos","events_url":"https://api.github.com/users/ajdapretnar/events{/privacy}","received_events_url":"https://api.github.com/users/ajdapretnar/received_events","type":"User","site_admin":false},"created_at":"2017-02-20T09:55:01Z","updated_at":"2017-02-20T09:55:01Z","body":"This fixes the issue I had when training a classification tree on [employee attrition data](https://www.ibm.com/communities/analytics/watson-analytics-blog/hr-employee-attrition/)."}}
{"actor":{"display_login":"ajdapretnar"}}