{"action":"created","comment":{"url":"https://api.github.com/repos/scalacenter/scalafix/pulls/comments/121483950","pull_request_review_id":43516286,"id":121483950,"diff_hunk":"@@ -58,14 +82,27 @@ case class ExplicitReturnTypes(mirror: Mirror)\n         typ <- defnType(defn)\n       } yield ctx.addRight(replace, s\": ${typ.treeSyntax}\")\n     }.to[Seq]\n+\n+    def checkModsScope(mods: Seq[Mod]): Boolean =\n+      ctx.config.explicitReturnTypes.memberVisibility\n+        .contains(visibility(mods))\n+\n+    def checkDefnScope(defn: Defn): Boolean =","path":"scalafix-core/src/main/scala/scalafix/rewrite/ExplicitReturnTypes.scala","position":77,"original_position":77,"commit_id":"d49d74bbbb7eeece82e70af0df6f8b3ecf76d3f4","original_commit_id":"d49d74bbbb7eeece82e70af0df6f8b3ecf76d3f4","user":{"login":"taisukeoe","id":1506707,"avatar_url":"https://avatars1.githubusercontent.com/u/1506707?v=3","gravatar_id":"","url":"https://api.github.com/users/taisukeoe","html_url":"https://github.com/taisukeoe","followers_url":"https://api.github.com/users/taisukeoe/followers","following_url":"https://api.github.com/users/taisukeoe/following{/other_user}","gists_url":"https://api.github.com/users/taisukeoe/gists{/gist_id}","starred_url":"https://api.github.com/users/taisukeoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taisukeoe/subscriptions","organizations_url":"https://api.github.com/users/taisukeoe/orgs","repos_url":"https://api.github.com/users/taisukeoe/repos","events_url":"https://api.github.com/users/taisukeoe/events{/privacy}","received_events_url":"https://api.github.com/users/taisukeoe/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2017-06-12T18:02:22Z","updated_at":"2017-06-12T18:02:22Z","html_url":"https://github.com/scalacenter/scalafix/pull/211#discussion_r121483950","pull_request_url":"https://api.github.com/repos/scalacenter/scalafix/pulls/211","_links":{"self":{"href":"https://api.github.com/repos/scalacenter/scalafix/pulls/comments/121483950"},"html":{"href":"https://github.com/scalacenter/scalafix/pull/211#discussion_r121483950"},"pull_request":{"href":"https://api.github.com/repos/scalacenter/scalafix/pulls/211"}}},"pull_request":{"url":"https://api.github.com/repos/scalacenter/scalafix/pulls/211","id":125012429,"html_url":"https://github.com/scalacenter/scalafix/pull/211","diff_url":"https://github.com/scalacenter/scalafix/pull/211.diff","patch_url":"https://github.com/scalacenter/scalafix/pull/211.patch","issue_url":"https://api.github.com/repos/scalacenter/scalafix/issues/211","number":211,"state":"open","locked":false,"title":"Fix #158, fix ExplicitReturnType for non-implicits","user":{"login":"taisukeoe","id":1506707,"avatar_url":"https://avatars1.githubusercontent.com/u/1506707?v=3","gravatar_id":"","url":"https://api.github.com/users/taisukeoe","html_url":"https://github.com/taisukeoe","followers_url":"https://api.github.com/users/taisukeoe/followers","following_url":"https://api.github.com/users/taisukeoe/following{/other_user}","gists_url":"https://api.github.com/users/taisukeoe/gists{/gist_id}","starred_url":"https://api.github.com/users/taisukeoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taisukeoe/subscriptions","organizations_url":"https://api.github.com/users/taisukeoe/orgs","repos_url":"https://api.github.com/users/taisukeoe/repos","events_url":"https://api.github.com/users/taisukeoe/events{/privacy}","received_events_url":"https://api.github.com/users/taisukeoe/received_events","type":"User","site_admin":false},"body":"This fixes #158 to add ExplicitReturnType with respecting configuration.\r\n\r\nATM memberKind and memberVisibility configuration supports are implemented in \"AND\" basis.\r\n\r\nFor example if you specify `[Val, Def]` for memberKind and `[Protected]` for memberVisibility, only `protected val` and `protected def`s are rewritten.\r\nI believe it should be so, but please feel free to let me know if it's different from what you expect.\r\n\r\nAnd I'm so sorry for making issue reference a bit dirty.","created_at":"2017-06-11T03:46:27Z","updated_at":"2017-06-12T18:02:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce589de59a29628ba8de6a76177eb72501efaf2b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/scalacenter/scalafix/pulls/211/commits","review_comments_url":"https://api.github.com/repos/scalacenter/scalafix/pulls/211/comments","review_comment_url":"https://api.github.com/repos/scalacenter/scalafix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scalacenter/scalafix/issues/211/comments","statuses_url":"https://api.github.com/repos/scalacenter/scalafix/statuses/d49d74bbbb7eeece82e70af0df6f8b3ecf76d3f4","head":{"label":"taisukeoe:158-return-type","ref":"158-return-type","sha":"d49d74bbbb7eeece82e70af0df6f8b3ecf76d3f4","user":{"login":"taisukeoe","id":1506707,"avatar_url":"https://avatars1.githubusercontent.com/u/1506707?v=3","gravatar_id":"","url":"https://api.github.com/users/taisukeoe","html_url":"https://github.com/taisukeoe","followers_url":"https://api.github.com/users/taisukeoe/followers","following_url":"https://api.github.com/users/taisukeoe/following{/other_user}","gists_url":"https://api.github.com/users/taisukeoe/gists{/gist_id}","starred_url":"https://api.github.com/users/taisukeoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taisukeoe/subscriptions","organizations_url":"https://api.github.com/users/taisukeoe/orgs","repos_url":"https://api.github.com/users/taisukeoe/repos","events_url":"https://api.github.com/users/taisukeoe/events{/privacy}","received_events_url":"https://api.github.com/users/taisukeoe/received_events","type":"User","site_admin":false},"repo":{"id":92939264,"name":"scalafix","full_name":"taisukeoe/scalafix","owner":{"login":"taisukeoe","id":1506707,"avatar_url":"https://avatars1.githubusercontent.com/u/1506707?v=3","gravatar_id":"","url":"https://api.github.com/users/taisukeoe","html_url":"https://github.com/taisukeoe","followers_url":"https://api.github.com/users/taisukeoe/followers","following_url":"https://api.github.com/users/taisukeoe/following{/other_user}","gists_url":"https://api.github.com/users/taisukeoe/gists{/gist_id}","starred_url":"https://api.github.com/users/taisukeoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taisukeoe/subscriptions","organizations_url":"https://api.github.com/users/taisukeoe/orgs","repos_url":"https://api.github.com/users/taisukeoe/repos","events_url":"https://api.github.com/users/taisukeoe/events{/privacy}","received_events_url":"https://api.github.com/users/taisukeoe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taisukeoe/scalafix","description":"Refactoring library and tool for Scala","fork":true,"url":"https://api.github.com/repos/taisukeoe/scalafix","forks_url":"https://api.github.com/repos/taisukeoe/scalafix/forks","keys_url":"https://api.github.com/repos/taisukeoe/scalafix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taisukeoe/scalafix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taisukeoe/scalafix/teams","hooks_url":"https://api.github.com/repos/taisukeoe/scalafix/hooks","issue_events_url":"https://api.github.com/repos/taisukeoe/scalafix/issues/events{/number}","events_url":"https://api.github.com/repos/taisukeoe/scalafix/events","assignees_url":"https://api.github.com/repos/taisukeoe/scalafix/assignees{/user}","branches_url":"https://api.github.com/repos/taisukeoe/scalafix/branches{/branch}","tags_url":"https://api.github.com/repos/taisukeoe/scalafix/tags","blobs_url":"https://api.github.com/repos/taisukeoe/scalafix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taisukeoe/scalafix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taisukeoe/scalafix/git/refs{/sha}","trees_url":"https://api.github.com/repos/taisukeoe/scalafix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taisukeoe/scalafix/statuses/{sha}","languages_url":"https://api.github.com/repos/taisukeoe/scalafix/languages","stargazers_url":"https://api.github.com/repos/taisukeoe/scalafix/stargazers","contributors_url":"https://api.github.com/repos/taisukeoe/scalafix/contributors","subscribers_url":"https://api.github.com/repos/taisukeoe/scalafix/subscribers","subscription_url":"https://api.github.com/repos/taisukeoe/scalafix/subscription","commits_url":"https://api.github.com/repos/taisukeoe/scalafix/commits{/sha}","git_commits_url":"https://api.github.com/repos/taisukeoe/scalafix/git/commits{/sha}","comments_url":"https://api.github.com/repos/taisukeoe/scalafix/comments{/number}","issue_comment_url":"https://api.github.com/repos/taisukeoe/scalafix/issues/comments{/number}","contents_url":"https://api.github.com/repos/taisukeoe/scalafix/contents/{+path}","compare_url":"https://api.github.com/repos/taisukeoe/scalafix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taisukeoe/scalafix/merges","archive_url":"https://api.github.com/repos/taisukeoe/scalafix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taisukeoe/scalafix/downloads","issues_url":"https://api.github.com/repos/taisukeoe/scalafix/issues{/number}","pulls_url":"https://api.github.com/repos/taisukeoe/scalafix/pulls{/number}","milestones_url":"https://api.github.com/repos/taisukeoe/scalafix/milestones{/number}","notifications_url":"https://api.github.com/repos/taisukeoe/scalafix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taisukeoe/scalafix/labels{/name}","releases_url":"https://api.github.com/repos/taisukeoe/scalafix/releases{/id}","deployments_url":"https://api.github.com/repos/taisukeoe/scalafix/deployments","created_at":"2017-05-31T11:27:30Z","updated_at":"2017-05-31T11:27:31Z","pushed_at":"2017-06-12T02:27:47Z","git_url":"git://github.com/taisukeoe/scalafix.git","ssh_url":"git@github.com:taisukeoe/scalafix.git","clone_url":"https://github.com/taisukeoe/scalafix.git","svn_url":"https://github.com/taisukeoe/scalafix","homepage":"https://scalacenter.github.io/scalafix/","size":1884,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scalacenter:master","ref":"master","sha":"179fa4191914182055b7d614c1aace63bca580d9","user":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars1.githubusercontent.com/u/16118980?v=3","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"repo":{"id":65199839,"name":"scalafix","full_name":"scalacenter/scalafix","owner":{"login":"scalacenter","id":16118980,"avatar_url":"https://avatars1.githubusercontent.com/u/16118980?v=3","gravatar_id":"","url":"https://api.github.com/users/scalacenter","html_url":"https://github.com/scalacenter","followers_url":"https://api.github.com/users/scalacenter/followers","following_url":"https://api.github.com/users/scalacenter/following{/other_user}","gists_url":"https://api.github.com/users/scalacenter/gists{/gist_id}","starred_url":"https://api.github.com/users/scalacenter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scalacenter/subscriptions","organizations_url":"https://api.github.com/users/scalacenter/orgs","repos_url":"https://api.github.com/users/scalacenter/repos","events_url":"https://api.github.com/users/scalacenter/events{/privacy}","received_events_url":"https://api.github.com/users/scalacenter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scalacenter/scalafix","description":"Refactoring library and tool for Scala","fork":false,"url":"https://api.github.com/repos/scalacenter/scalafix","forks_url":"https://api.github.com/repos/scalacenter/scalafix/forks","keys_url":"https://api.github.com/repos/scalacenter/scalafix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scalacenter/scalafix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scalacenter/scalafix/teams","hooks_url":"https://api.github.com/repos/scalacenter/scalafix/hooks","issue_events_url":"https://api.github.com/repos/scalacenter/scalafix/issues/events{/number}","events_url":"https://api.github.com/repos/scalacenter/scalafix/events","assignees_url":"https://api.github.com/repos/scalacenter/scalafix/assignees{/user}","branches_url":"https://api.github.com/repos/scalacenter/scalafix/branches{/branch}","tags_url":"https://api.github.com/repos/scalacenter/scalafix/tags","blobs_url":"https://api.github.com/repos/scalacenter/scalafix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scalacenter/scalafix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scalacenter/scalafix/git/refs{/sha}","trees_url":"https://api.github.com/repos/scalacenter/scalafix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scalacenter/scalafix/statuses/{sha}","languages_url":"https://api.github.com/repos/scalacenter/scalafix/languages","stargazers_url":"https://api.github.com/repos/scalacenter/scalafix/stargazers","contributors_url":"https://api.github.com/repos/scalacenter/scalafix/contributors","subscribers_url":"https://api.github.com/repos/scalacenter/scalafix/subscribers","subscription_url":"https://api.github.com/repos/scalacenter/scalafix/subscription","commits_url":"https://api.github.com/repos/scalacenter/scalafix/commits{/sha}","git_commits_url":"https://api.github.com/repos/scalacenter/scalafix/git/commits{/sha}","comments_url":"https://api.github.com/repos/scalacenter/scalafix/comments{/number}","issue_comment_url":"https://api.github.com/repos/scalacenter/scalafix/issues/comments{/number}","contents_url":"https://api.github.com/repos/scalacenter/scalafix/contents/{+path}","compare_url":"https://api.github.com/repos/scalacenter/scalafix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scalacenter/scalafix/merges","archive_url":"https://api.github.com/repos/scalacenter/scalafix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scalacenter/scalafix/downloads","issues_url":"https://api.github.com/repos/scalacenter/scalafix/issues{/number}","pulls_url":"https://api.github.com/repos/scalacenter/scalafix/pulls{/number}","milestones_url":"https://api.github.com/repos/scalacenter/scalafix/milestones{/number}","notifications_url":"https://api.github.com/repos/scalacenter/scalafix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scalacenter/scalafix/labels{/name}","releases_url":"https://api.github.com/repos/scalacenter/scalafix/releases{/id}","deployments_url":"https://api.github.com/repos/scalacenter/scalafix/deployments","created_at":"2016-08-08T11:45:19Z","updated_at":"2017-06-12T17:23:39Z","pushed_at":"2017-06-12T11:28:08Z","git_url":"git://github.com/scalacenter/scalafix.git","ssh_url":"git@github.com:scalacenter/scalafix.git","clone_url":"https://github.com/scalacenter/scalafix.git","svn_url":"https://github.com/scalacenter/scalafix","homepage":"https://scalacenter.github.io/scalafix/","size":1940,"stargazers_count":98,"watchers_count":98,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":31,"forks":27,"open_issues":31,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scalacenter/scalafix/pulls/211"},"html":{"href":"https://github.com/scalacenter/scalafix/pull/211"},"issue":{"href":"https://api.github.com/repos/scalacenter/scalafix/issues/211"},"comments":{"href":"https://api.github.com/repos/scalacenter/scalafix/issues/211/comments"},"review_comments":{"href":"https://api.github.com/repos/scalacenter/scalafix/pulls/211/comments"},"review_comment":{"href":"https://api.github.com/repos/scalacenter/scalafix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scalacenter/scalafix/pulls/211/commits"},"statuses":{"href":"https://api.github.com/repos/scalacenter/scalafix/statuses/d49d74bbbb7eeece82e70af0df6f8b3ecf76d3f4"}}}}
{"actor":{"display_login":"taisukeoe"}}