{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/115429286","pull_request_review_id":36963688,"id":115429286,"diff_hunk":"@@ -29,13 +28,16 @@\n #define GET_MAX_LUN             (0xFE)\n #define BO_MASS_STORAGE_RESET   (0xFF)\n \n-USBHostMSD::USBHostMSD(const char * rootdir) : FATFileSystem(rootdir)\n+USBHostMSD::USBHostMSD()\n {\n     host = USBHost::getHostInst();\n-    init();\n+    /*  register an object in FAT */\n+\n+    init_usb();\n }\n \n-void USBHostMSD::init() {\n+void USBHostMSD::init_usb()","path":"features/unsupported/USBHost/USBHostMSD/USBHostMSD.cpp","position":23,"original_position":23,"commit_id":"d0df7fbf41b03d3888f9a1b57935481d55a5cf8a","original_commit_id":"d0df7fbf41b03d3888f9a1b57935481d55a5cf8a","user":{"login":"jamike","id":18681034,"avatar_url":"https://avatars2.githubusercontent.com/u/18681034?v=3","gravatar_id":"","url":"https://api.github.com/users/jamike","html_url":"https://github.com/jamike","followers_url":"https://api.github.com/users/jamike/followers","following_url":"https://api.github.com/users/jamike/following{/other_user}","gists_url":"https://api.github.com/users/jamike/gists{/gist_id}","starred_url":"https://api.github.com/users/jamike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamike/subscriptions","organizations_url":"https://api.github.com/users/jamike/orgs","repos_url":"https://api.github.com/users/jamike/repos","events_url":"https://api.github.com/users/jamike/events{/privacy}","received_events_url":"https://api.github.com/users/jamike/received_events","type":"User","site_admin":false},"body":"As USBhostMSD inherits from BlockDevice and block device as a virtual method init.\r\nIt is better to rename the method relative to USB init , as init_usb . Also this method is protected so the renaming does not modify the behaviour for the user of this class.","created_at":"2017-05-09T08:03:15Z","updated_at":"2017-05-09T08:03:15Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/4230#discussion_r115429286","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4230","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/115429286"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/4230#discussion_r115429286"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4230"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4230","id":117716313,"html_url":"https://github.com/ARMmbed/mbed-os/pull/4230","diff_url":"https://github.com/ARMmbed/mbed-os/pull/4230.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/4230.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4230","number":4230,"state":"open","locked":false,"title":"Usb host msd block device","user":{"login":"jamike","id":18681034,"avatar_url":"https://avatars2.githubusercontent.com/u/18681034?v=3","gravatar_id":"","url":"https://api.github.com/users/jamike","html_url":"https://github.com/jamike","followers_url":"https://api.github.com/users/jamike/followers","following_url":"https://api.github.com/users/jamike/following{/other_user}","gists_url":"https://api.github.com/users/jamike/gists{/gist_id}","starred_url":"https://api.github.com/users/jamike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamike/subscriptions","organizations_url":"https://api.github.com/users/jamike/orgs","repos_url":"https://api.github.com/users/jamike/repos","events_url":"https://api.github.com/users/jamike/events{/privacy}","received_events_url":"https://api.github.com/users/jamike/received_events","type":"User","site_admin":false},"body":"## Description\r\nSince BlockDevice has been introduced USBHostMSD is no more supported.\r\nWith this patch USBhostMSD inherits from BlockDevice , and can be used with  FATFileSystem class.\r\n## Status\r\nREADY\r\n\r\n\r\n","created_at":"2017-04-26T13:37:09Z","updated_at":"2017-05-09T08:03:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ff06990193ad3f67dd972059bd945246f44d7b7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4230/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4230/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4230/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/d0df7fbf41b03d3888f9a1b57935481d55a5cf8a","head":{"label":"jamike:USBHostMSD_BockDevice","ref":"USBHostMSD_BockDevice","sha":"d0df7fbf41b03d3888f9a1b57935481d55a5cf8a","user":{"login":"jamike","id":18681034,"avatar_url":"https://avatars2.githubusercontent.com/u/18681034?v=3","gravatar_id":"","url":"https://api.github.com/users/jamike","html_url":"https://github.com/jamike","followers_url":"https://api.github.com/users/jamike/followers","following_url":"https://api.github.com/users/jamike/following{/other_user}","gists_url":"https://api.github.com/users/jamike/gists{/gist_id}","starred_url":"https://api.github.com/users/jamike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamike/subscriptions","organizations_url":"https://api.github.com/users/jamike/orgs","repos_url":"https://api.github.com/users/jamike/repos","events_url":"https://api.github.com/users/jamike/events{/privacy}","received_events_url":"https://api.github.com/users/jamike/received_events","type":"User","site_admin":false},"repo":{"id":60279690,"name":"mbed","full_name":"jamike/mbed","owner":{"login":"jamike","id":18681034,"avatar_url":"https://avatars2.githubusercontent.com/u/18681034?v=3","gravatar_id":"","url":"https://api.github.com/users/jamike","html_url":"https://github.com/jamike","followers_url":"https://api.github.com/users/jamike/followers","following_url":"https://api.github.com/users/jamike/following{/other_user}","gists_url":"https://api.github.com/users/jamike/gists{/gist_id}","starred_url":"https://api.github.com/users/jamike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamike/subscriptions","organizations_url":"https://api.github.com/users/jamike/orgs","repos_url":"https://api.github.com/users/jamike/repos","events_url":"https://api.github.com/users/jamike/events{/privacy}","received_events_url":"https://api.github.com/users/jamike/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jamike/mbed","description":"mbed libraries and tools (Classic). For mbed OS, look here: https://www.mbed.com/en/development/software/mbed-os/","fork":true,"url":"https://api.github.com/repos/jamike/mbed","forks_url":"https://api.github.com/repos/jamike/mbed/forks","keys_url":"https://api.github.com/repos/jamike/mbed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jamike/mbed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jamike/mbed/teams","hooks_url":"https://api.github.com/repos/jamike/mbed/hooks","issue_events_url":"https://api.github.com/repos/jamike/mbed/issues/events{/number}","events_url":"https://api.github.com/repos/jamike/mbed/events","assignees_url":"https://api.github.com/repos/jamike/mbed/assignees{/user}","branches_url":"https://api.github.com/repos/jamike/mbed/branches{/branch}","tags_url":"https://api.github.com/repos/jamike/mbed/tags","blobs_url":"https://api.github.com/repos/jamike/mbed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jamike/mbed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jamike/mbed/git/refs{/sha}","trees_url":"https://api.github.com/repos/jamike/mbed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jamike/mbed/statuses/{sha}","languages_url":"https://api.github.com/repos/jamike/mbed/languages","stargazers_url":"https://api.github.com/repos/jamike/mbed/stargazers","contributors_url":"https://api.github.com/repos/jamike/mbed/contributors","subscribers_url":"https://api.github.com/repos/jamike/mbed/subscribers","subscription_url":"https://api.github.com/repos/jamike/mbed/subscription","commits_url":"https://api.github.com/repos/jamike/mbed/commits{/sha}","git_commits_url":"https://api.github.com/repos/jamike/mbed/git/commits{/sha}","comments_url":"https://api.github.com/repos/jamike/mbed/comments{/number}","issue_comment_url":"https://api.github.com/repos/jamike/mbed/issues/comments{/number}","contents_url":"https://api.github.com/repos/jamike/mbed/contents/{+path}","compare_url":"https://api.github.com/repos/jamike/mbed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jamike/mbed/merges","archive_url":"https://api.github.com/repos/jamike/mbed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jamike/mbed/downloads","issues_url":"https://api.github.com/repos/jamike/mbed/issues{/number}","pulls_url":"https://api.github.com/repos/jamike/mbed/pulls{/number}","milestones_url":"https://api.github.com/repos/jamike/mbed/milestones{/number}","notifications_url":"https://api.github.com/repos/jamike/mbed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jamike/mbed/labels{/name}","releases_url":"https://api.github.com/repos/jamike/mbed/releases{/id}","deployments_url":"https://api.github.com/repos/jamike/mbed/deployments","created_at":"2016-06-02T16:26:10Z","updated_at":"2016-06-02T16:27:07Z","pushed_at":"2017-05-04T09:07:42Z","git_url":"git://github.com/jamike/mbed.git","ssh_url":"git@github.com:jamike/mbed.git","clone_url":"https://github.com/jamike/mbed.git","svn_url":"https://github.com/jamike/mbed","homepage":"","size":122239,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"0c2af2652312bd65d8dbd8fc15cfd079d5e688b1","user":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars0.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"name":"mbed-os","full_name":"ARMmbed/mbed-os","owner":{"login":"ARMmbed","id":8916057,"avatar_url":"https://avatars0.githubusercontent.com/u/8916057?v=3","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARMmbed/mbed-os","description":"ARM mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2017-05-09T07:52:48Z","pushed_at":"2017-05-09T01:24:51Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":122653,"stargazers_count":1024,"watchers_count":1024,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":970,"mirror_url":null,"open_issues_count":428,"forks":970,"open_issues":428,"watchers":1024,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4230"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/4230"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4230"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/4230/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4230/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/4230/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/d0df7fbf41b03d3888f9a1b57935481d55a5cf8a"}}}}
{"actor":{"display_login":"jamike"}}