{"action":"closed","number":9535,"pull_request":{"url":"https://api.github.com/repos/fastlane/fastlane/pulls/9535","id":126601563,"html_url":"https://github.com/fastlane/fastlane/pull/9535","diff_url":"https://github.com/fastlane/fastlane/pull/9535.diff","patch_url":"https://github.com/fastlane/fastlane/pull/9535.patch","issue_url":"https://api.github.com/repos/fastlane/fastlane/issues/9535","number":9535,"state":"closed","locked":false,"title":"Duplicate swiftlint custom executable parameter, so it doesn't get corrupted","user":{"login":"nap-sam-dean","id":3427602,"avatar_url":"https://avatars2.githubusercontent.com/u/3427602?v=3","gravatar_id":"","url":"https://api.github.com/users/nap-sam-dean","html_url":"https://github.com/nap-sam-dean","followers_url":"https://api.github.com/users/nap-sam-dean/followers","following_url":"https://api.github.com/users/nap-sam-dean/following{/other_user}","gists_url":"https://api.github.com/users/nap-sam-dean/gists{/gist_id}","starred_url":"https://api.github.com/users/nap-sam-dean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nap-sam-dean/subscriptions","organizations_url":"https://api.github.com/users/nap-sam-dean/orgs","repos_url":"https://api.github.com/users/nap-sam-dean/repos","events_url":"https://api.github.com/users/nap-sam-dean/events{/privacy}","received_events_url":"https://api.github.com/users/nap-sam-dean/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for contributing to _fastlane_! Before you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] -->\r\n\r\n### Checklist\r\n- [x] I've run `bundle exec rspec` from the root directory to see all new and existing tests pass\r\n- [x] I've followed the _fastlane_ code style and run `bundle exec rubocop -a` to ensure the code style is valid\r\n- [x] I've read the [Contribution Guidelines](https://github.com/fastlane/fastlane/blob/master/CONTRIBUTING.md)\r\n- [x] I've updated the documentation if necessary.\r\n\r\n### Motivation and Context\r\n\r\nThis allows us to use the --strict parameter (and others) with a custom swiftlint executable (i.e. if it's installed as a cocoapod)\r\n\r\nIt fixes issue #9533\r\n\r\n### Description\r\n\r\nDuplicate the executable parameter when constructing the command so it doesn't get corrupted. This prevents further version checks from failing.\r\n","created_at":"2017-06-20T18:38:48Z","updated_at":"2017-06-23T17:58:03Z","closed_at":"2017-06-23T17:58:03Z","merged_at":"2017-06-23T17:58:03Z","merge_commit_sha":"b6e1aa20b4f29f95f65c7968fee404380a509b9d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastlane/fastlane/pulls/9535/commits","review_comments_url":"https://api.github.com/repos/fastlane/fastlane/pulls/9535/comments","review_comment_url":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastlane/fastlane/issues/9535/comments","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/203ab980f207993d6bcb16f8c6e7c2b90b30ea46","head":{"label":"net-a-porter-mobile:swiftlint-missing-parameters","ref":"swiftlint-missing-parameters","sha":"203ab980f207993d6bcb16f8c6e7c2b90b30ea46","user":{"login":"net-a-porter-mobile","id":3427626,"avatar_url":"https://avatars1.githubusercontent.com/u/3427626?v=3","gravatar_id":"","url":"https://api.github.com/users/net-a-porter-mobile","html_url":"https://github.com/net-a-porter-mobile","followers_url":"https://api.github.com/users/net-a-porter-mobile/followers","following_url":"https://api.github.com/users/net-a-porter-mobile/following{/other_user}","gists_url":"https://api.github.com/users/net-a-porter-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/net-a-porter-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/net-a-porter-mobile/subscriptions","organizations_url":"https://api.github.com/users/net-a-porter-mobile/orgs","repos_url":"https://api.github.com/users/net-a-porter-mobile/repos","events_url":"https://api.github.com/users/net-a-porter-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/net-a-porter-mobile/received_events","type":"Organization","site_admin":false},"repo":{"id":94917542,"name":"fastlane","full_name":"net-a-porter-mobile/fastlane","owner":{"login":"net-a-porter-mobile","id":3427626,"avatar_url":"https://avatars1.githubusercontent.com/u/3427626?v=3","gravatar_id":"","url":"https://api.github.com/users/net-a-porter-mobile","html_url":"https://github.com/net-a-porter-mobile","followers_url":"https://api.github.com/users/net-a-porter-mobile/followers","following_url":"https://api.github.com/users/net-a-porter-mobile/following{/other_user}","gists_url":"https://api.github.com/users/net-a-porter-mobile/gists{/gist_id}","starred_url":"https://api.github.com/users/net-a-porter-mobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/net-a-porter-mobile/subscriptions","organizations_url":"https://api.github.com/users/net-a-porter-mobile/orgs","repos_url":"https://api.github.com/users/net-a-porter-mobile/repos","events_url":"https://api.github.com/users/net-a-porter-mobile/events{/privacy}","received_events_url":"https://api.github.com/users/net-a-porter-mobile/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/net-a-porter-mobile/fastlane","description":"🚀 The easiest way to automate building and releasing your iOS and Android apps","fork":true,"url":"https://api.github.com/repos/net-a-porter-mobile/fastlane","forks_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/forks","keys_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/teams","hooks_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/hooks","issue_events_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/events","assignees_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/tags","blobs_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/languages","stargazers_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/stargazers","contributors_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/contributors","subscribers_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/subscribers","subscription_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/subscription","commits_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/merges","archive_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/downloads","issues_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/net-a-porter-mobile/fastlane/deployments","created_at":"2017-06-20T17:27:20Z","updated_at":"2017-06-20T17:27:34Z","pushed_at":"2017-06-22T11:59:29Z","git_url":"git://github.com/net-a-porter-mobile/fastlane.git","ssh_url":"git@github.com:net-a-porter-mobile/fastlane.git","clone_url":"https://github.com/net-a-porter-mobile/fastlane.git","svn_url":"https://github.com/net-a-porter-mobile/fastlane","homepage":"https://fastlane.tools","size":56904,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastlane:master","ref":"master","sha":"9bafd7e9e4b230df5fa557ecede02b30fb09c72b","user":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars1.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"repo":{"id":27442967,"name":"fastlane","full_name":"fastlane/fastlane","owner":{"login":"fastlane","id":11098337,"avatar_url":"https://avatars1.githubusercontent.com/u/11098337?v=3","gravatar_id":"","url":"https://api.github.com/users/fastlane","html_url":"https://github.com/fastlane","followers_url":"https://api.github.com/users/fastlane/followers","following_url":"https://api.github.com/users/fastlane/following{/other_user}","gists_url":"https://api.github.com/users/fastlane/gists{/gist_id}","starred_url":"https://api.github.com/users/fastlane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastlane/subscriptions","organizations_url":"https://api.github.com/users/fastlane/orgs","repos_url":"https://api.github.com/users/fastlane/repos","events_url":"https://api.github.com/users/fastlane/events{/privacy}","received_events_url":"https://api.github.com/users/fastlane/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastlane/fastlane","description":"🚀 The easiest way to automate building and releasing your iOS and Android apps","fork":false,"url":"https://api.github.com/repos/fastlane/fastlane","forks_url":"https://api.github.com/repos/fastlane/fastlane/forks","keys_url":"https://api.github.com/repos/fastlane/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastlane/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastlane/fastlane/teams","hooks_url":"https://api.github.com/repos/fastlane/fastlane/hooks","issue_events_url":"https://api.github.com/repos/fastlane/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/fastlane/fastlane/events","assignees_url":"https://api.github.com/repos/fastlane/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/fastlane/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/fastlane/fastlane/tags","blobs_url":"https://api.github.com/repos/fastlane/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastlane/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastlane/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastlane/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastlane/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/fastlane/fastlane/languages","stargazers_url":"https://api.github.com/repos/fastlane/fastlane/stargazers","contributors_url":"https://api.github.com/repos/fastlane/fastlane/contributors","subscribers_url":"https://api.github.com/repos/fastlane/fastlane/subscribers","subscription_url":"https://api.github.com/repos/fastlane/fastlane/subscription","commits_url":"https://api.github.com/repos/fastlane/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastlane/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastlane/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastlane/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastlane/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/fastlane/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastlane/fastlane/merges","archive_url":"https://api.github.com/repos/fastlane/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastlane/fastlane/downloads","issues_url":"https://api.github.com/repos/fastlane/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/fastlane/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/fastlane/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/fastlane/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastlane/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/fastlane/fastlane/releases{/id}","deployments_url":"https://api.github.com/repos/fastlane/fastlane/deployments","created_at":"2014-12-02T17:00:38Z","updated_at":"2017-06-23T17:43:42Z","pushed_at":"2017-06-23T17:58:03Z","git_url":"git://github.com/fastlane/fastlane.git","ssh_url":"git@github.com:fastlane/fastlane.git","clone_url":"https://github.com/fastlane/fastlane.git","svn_url":"https://github.com/fastlane/fastlane","homepage":"https://fastlane.tools","size":57233,"stargazers_count":16586,"watchers_count":16586,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2548,"mirror_url":null,"open_issues_count":303,"forks":2548,"open_issues":303,"watchers":16586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/9535"},"html":{"href":"https://github.com/fastlane/fastlane/pull/9535"},"issue":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/9535"},"comments":{"href":"https://api.github.com/repos/fastlane/fastlane/issues/9535/comments"},"review_comments":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/9535/comments"},"review_comment":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastlane/fastlane/pulls/9535/commits"},"statuses":{"href":"https://api.github.com/repos/fastlane/fastlane/statuses/203ab980f207993d6bcb16f8c6e7c2b90b30ea46"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mpirri","id":1190389,"avatar_url":"https://avatars0.githubusercontent.com/u/1190389?v=3","gravatar_id":"","url":"https://api.github.com/users/mpirri","html_url":"https://github.com/mpirri","followers_url":"https://api.github.com/users/mpirri/followers","following_url":"https://api.github.com/users/mpirri/following{/other_user}","gists_url":"https://api.github.com/users/mpirri/gists{/gist_id}","starred_url":"https://api.github.com/users/mpirri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpirri/subscriptions","organizations_url":"https://api.github.com/users/mpirri/orgs","repos_url":"https://api.github.com/users/mpirri/repos","events_url":"https://api.github.com/users/mpirri/events{/privacy}","received_events_url":"https://api.github.com/users/mpirri/received_events","type":"User","site_admin":false},"comments":1,"review_comments":3,"maintainer_can_modify":false,"commits":2,"additions":22,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"mpirri"}}