{"action":"created","comment":{"url":"https://api.github.com/repos/koreader/koreader/pulls/comments/143026889","pull_request_review_id":67478273,"id":143026889,"diff_hunk":"@@ -568,9 +568,14 @@ function ReaderFooter:onPageUpdate(pageno)\n     self:updateFooterPage()\n end\n \n-function ReaderFooter:onPosUpdate(pos)\n+function ReaderFooter:onPosUpdate(pos, pageno)\n     self.position = pos\n     self.doc_height = self.view.document.info.doc_height\n+    if pageno then\n+        self.pageno = pageno\n+        self.pages = self.view.document:getPageCount()\n+        self.ui.doc_settings:saveSetting(\"doc_pages\", self.pages) -- for Book information","path":"frontend/apps/reader/modules/readerfooter.lua","position":11,"original_position":11,"commit_id":"ac489f4587476120c0e14455b0723375593447d0","original_commit_id":"ac489f4587476120c0e14455b0723375593447d0","user":{"login":"robert00s","id":22982594,"avatar_url":"https://avatars2.githubusercontent.com/u/22982594?v=4","gravatar_id":"","url":"https://api.github.com/users/robert00s","html_url":"https://github.com/robert00s","followers_url":"https://api.github.com/users/robert00s/followers","following_url":"https://api.github.com/users/robert00s/following{/other_user}","gists_url":"https://api.github.com/users/robert00s/gists{/gist_id}","starred_url":"https://api.github.com/users/robert00s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert00s/subscriptions","organizations_url":"https://api.github.com/users/robert00s/orgs","repos_url":"https://api.github.com/users/robert00s/repos","events_url":"https://api.github.com/users/robert00s/events{/privacy}","received_events_url":"https://api.github.com/users/robert00s/received_events","type":"User","site_admin":false},"body":"Do we need save doc_pages every time when we change book position?","created_at":"2017-10-05T18:55:30Z","updated_at":"2017-10-05T18:55:30Z","html_url":"https://github.com/koreader/koreader/pull/3304#discussion_r143026889","pull_request_url":"https://api.github.com/repos/koreader/koreader/pulls/3304","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/koreader/koreader/pulls/comments/143026889"},"html":{"href":"https://github.com/koreader/koreader/pull/3304#discussion_r143026889"},"pull_request":{"href":"https://api.github.com/repos/koreader/koreader/pulls/3304"}}},"pull_request":{"url":"https://api.github.com/repos/koreader/koreader/pulls/3304","id":144988163,"html_url":"https://github.com/koreader/koreader/pull/3304","diff_url":"https://github.com/koreader/koreader/pull/3304.diff","patch_url":"https://github.com/koreader/koreader/pull/3304.patch","issue_url":"https://api.github.com/repos/koreader/koreader/issues/3304","number":3304,"state":"open","locked":false,"title":"Fix footer, stats, TOC position with cre in scroll mode","user":{"login":"poire-z","id":24273478,"avatar_url":"https://avatars0.githubusercontent.com/u/24273478?v=4","gravatar_id":"","url":"https://api.github.com/users/poire-z","html_url":"https://github.com/poire-z","followers_url":"https://api.github.com/users/poire-z/followers","following_url":"https://api.github.com/users/poire-z/following{/other_user}","gists_url":"https://api.github.com/users/poire-z/gists{/gist_id}","starred_url":"https://api.github.com/users/poire-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poire-z/subscriptions","organizations_url":"https://api.github.com/users/poire-z/orgs","repos_url":"https://api.github.com/users/poire-z/repos","events_url":"https://api.github.com/users/poire-z/events{/privacy}","received_events_url":"https://api.github.com/users/poire-z/received_events","type":"User","site_admin":false},"body":"This gives the page position to these modules even in scroll mode. Closes #3282\r\n\r\nAlso, in readerrolling: don't query battery/charging status when crengine does not need it (used only when it shows its top progress bar).","created_at":"2017-10-05T18:29:55Z","updated_at":"2017-10-05T18:55:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83c96728eacbaacde8ce1a6df12d430b2a035405","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/koreader/koreader/pulls/3304/commits","review_comments_url":"https://api.github.com/repos/koreader/koreader/pulls/3304/comments","review_comment_url":"https://api.github.com/repos/koreader/koreader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/koreader/koreader/issues/3304/comments","statuses_url":"https://api.github.com/repos/koreader/koreader/statuses/ac489f4587476120c0e14455b0723375593447d0","head":{"label":"poire-z:scrollWithPage","ref":"scrollWithPage","sha":"ac489f4587476120c0e14455b0723375593447d0","user":{"login":"poire-z","id":24273478,"avatar_url":"https://avatars0.githubusercontent.com/u/24273478?v=4","gravatar_id":"","url":"https://api.github.com/users/poire-z","html_url":"https://github.com/poire-z","followers_url":"https://api.github.com/users/poire-z/followers","following_url":"https://api.github.com/users/poire-z/following{/other_user}","gists_url":"https://api.github.com/users/poire-z/gists{/gist_id}","starred_url":"https://api.github.com/users/poire-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poire-z/subscriptions","organizations_url":"https://api.github.com/users/poire-z/orgs","repos_url":"https://api.github.com/users/poire-z/repos","events_url":"https://api.github.com/users/poire-z/events{/privacy}","received_events_url":"https://api.github.com/users/poire-z/received_events","type":"User","site_admin":false},"repo":{"id":75196141,"name":"koreader","full_name":"poire-z/koreader","owner":{"login":"poire-z","id":24273478,"avatar_url":"https://avatars0.githubusercontent.com/u/24273478?v=4","gravatar_id":"","url":"https://api.github.com/users/poire-z","html_url":"https://github.com/poire-z","followers_url":"https://api.github.com/users/poire-z/followers","following_url":"https://api.github.com/users/poire-z/following{/other_user}","gists_url":"https://api.github.com/users/poire-z/gists{/gist_id}","starred_url":"https://api.github.com/users/poire-z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poire-z/subscriptions","organizations_url":"https://api.github.com/users/poire-z/orgs","repos_url":"https://api.github.com/users/poire-z/repos","events_url":"https://api.github.com/users/poire-z/events{/privacy}","received_events_url":"https://api.github.com/users/poire-z/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/poire-z/koreader","description":"An ebook reader application supporting PDF, DjVu, EPUB, FB2 and many more formats, running on Kindle, Kobo, PocketBook, Ubuntu Touch and Android devices","fork":true,"url":"https://api.github.com/repos/poire-z/koreader","forks_url":"https://api.github.com/repos/poire-z/koreader/forks","keys_url":"https://api.github.com/repos/poire-z/koreader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poire-z/koreader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poire-z/koreader/teams","hooks_url":"https://api.github.com/repos/poire-z/koreader/hooks","issue_events_url":"https://api.github.com/repos/poire-z/koreader/issues/events{/number}","events_url":"https://api.github.com/repos/poire-z/koreader/events","assignees_url":"https://api.github.com/repos/poire-z/koreader/assignees{/user}","branches_url":"https://api.github.com/repos/poire-z/koreader/branches{/branch}","tags_url":"https://api.github.com/repos/poire-z/koreader/tags","blobs_url":"https://api.github.com/repos/poire-z/koreader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poire-z/koreader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poire-z/koreader/git/refs{/sha}","trees_url":"https://api.github.com/repos/poire-z/koreader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poire-z/koreader/statuses/{sha}","languages_url":"https://api.github.com/repos/poire-z/koreader/languages","stargazers_url":"https://api.github.com/repos/poire-z/koreader/stargazers","contributors_url":"https://api.github.com/repos/poire-z/koreader/contributors","subscribers_url":"https://api.github.com/repos/poire-z/koreader/subscribers","subscription_url":"https://api.github.com/repos/poire-z/koreader/subscription","commits_url":"https://api.github.com/repos/poire-z/koreader/commits{/sha}","git_commits_url":"https://api.github.com/repos/poire-z/koreader/git/commits{/sha}","comments_url":"https://api.github.com/repos/poire-z/koreader/comments{/number}","issue_comment_url":"https://api.github.com/repos/poire-z/koreader/issues/comments{/number}","contents_url":"https://api.github.com/repos/poire-z/koreader/contents/{+path}","compare_url":"https://api.github.com/repos/poire-z/koreader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poire-z/koreader/merges","archive_url":"https://api.github.com/repos/poire-z/koreader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poire-z/koreader/downloads","issues_url":"https://api.github.com/repos/poire-z/koreader/issues{/number}","pulls_url":"https://api.github.com/repos/poire-z/koreader/pulls{/number}","milestones_url":"https://api.github.com/repos/poire-z/koreader/milestones{/number}","notifications_url":"https://api.github.com/repos/poire-z/koreader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poire-z/koreader/labels{/name}","releases_url":"https://api.github.com/repos/poire-z/koreader/releases{/id}","deployments_url":"https://api.github.com/repos/poire-z/koreader/deployments","created_at":"2016-11-30T14:44:50Z","updated_at":"2016-11-30T14:44:52Z","pushed_at":"2017-10-05T18:24:07Z","git_url":"git://github.com/poire-z/koreader.git","ssh_url":"git@github.com:poire-z/koreader.git","clone_url":"https://github.com/poire-z/koreader.git","svn_url":"https://github.com/poire-z/koreader","homepage":"","size":36793,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"koreader:master","ref":"master","sha":"ac7119c4330075d4aa6275e58fb703dddc6d0b7a","user":{"login":"koreader","id":3957564,"avatar_url":"https://avatars0.githubusercontent.com/u/3957564?v=4","gravatar_id":"","url":"https://api.github.com/users/koreader","html_url":"https://github.com/koreader","followers_url":"https://api.github.com/users/koreader/followers","following_url":"https://api.github.com/users/koreader/following{/other_user}","gists_url":"https://api.github.com/users/koreader/gists{/gist_id}","starred_url":"https://api.github.com/users/koreader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koreader/subscriptions","organizations_url":"https://api.github.com/users/koreader/orgs","repos_url":"https://api.github.com/users/koreader/repos","events_url":"https://api.github.com/users/koreader/events{/privacy}","received_events_url":"https://api.github.com/users/koreader/received_events","type":"Organization","site_admin":false},"repo":{"id":8986217,"name":"koreader","full_name":"koreader/koreader","owner":{"login":"koreader","id":3957564,"avatar_url":"https://avatars0.githubusercontent.com/u/3957564?v=4","gravatar_id":"","url":"https://api.github.com/users/koreader","html_url":"https://github.com/koreader","followers_url":"https://api.github.com/users/koreader/followers","following_url":"https://api.github.com/users/koreader/following{/other_user}","gists_url":"https://api.github.com/users/koreader/gists{/gist_id}","starred_url":"https://api.github.com/users/koreader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/koreader/subscriptions","organizations_url":"https://api.github.com/users/koreader/orgs","repos_url":"https://api.github.com/users/koreader/repos","events_url":"https://api.github.com/users/koreader/events{/privacy}","received_events_url":"https://api.github.com/users/koreader/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/koreader/koreader","description":"An ebook reader application supporting PDF, DjVu, EPUB, FB2 and many more formats, running on Kindle, Kobo, PocketBook, Ubuntu Touch and Android devices","fork":false,"url":"https://api.github.com/repos/koreader/koreader","forks_url":"https://api.github.com/repos/koreader/koreader/forks","keys_url":"https://api.github.com/repos/koreader/koreader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/koreader/koreader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/koreader/koreader/teams","hooks_url":"https://api.github.com/repos/koreader/koreader/hooks","issue_events_url":"https://api.github.com/repos/koreader/koreader/issues/events{/number}","events_url":"https://api.github.com/repos/koreader/koreader/events","assignees_url":"https://api.github.com/repos/koreader/koreader/assignees{/user}","branches_url":"https://api.github.com/repos/koreader/koreader/branches{/branch}","tags_url":"https://api.github.com/repos/koreader/koreader/tags","blobs_url":"https://api.github.com/repos/koreader/koreader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/koreader/koreader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/koreader/koreader/git/refs{/sha}","trees_url":"https://api.github.com/repos/koreader/koreader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/koreader/koreader/statuses/{sha}","languages_url":"https://api.github.com/repos/koreader/koreader/languages","stargazers_url":"https://api.github.com/repos/koreader/koreader/stargazers","contributors_url":"https://api.github.com/repos/koreader/koreader/contributors","subscribers_url":"https://api.github.com/repos/koreader/koreader/subscribers","subscription_url":"https://api.github.com/repos/koreader/koreader/subscription","commits_url":"https://api.github.com/repos/koreader/koreader/commits{/sha}","git_commits_url":"https://api.github.com/repos/koreader/koreader/git/commits{/sha}","comments_url":"https://api.github.com/repos/koreader/koreader/comments{/number}","issue_comment_url":"https://api.github.com/repos/koreader/koreader/issues/comments{/number}","contents_url":"https://api.github.com/repos/koreader/koreader/contents/{+path}","compare_url":"https://api.github.com/repos/koreader/koreader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/koreader/koreader/merges","archive_url":"https://api.github.com/repos/koreader/koreader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/koreader/koreader/downloads","issues_url":"https://api.github.com/repos/koreader/koreader/issues{/number}","pulls_url":"https://api.github.com/repos/koreader/koreader/pulls{/number}","milestones_url":"https://api.github.com/repos/koreader/koreader/milestones{/number}","notifications_url":"https://api.github.com/repos/koreader/koreader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/koreader/koreader/labels{/name}","releases_url":"https://api.github.com/repos/koreader/koreader/releases{/id}","deployments_url":"https://api.github.com/repos/koreader/koreader/deployments","created_at":"2013-03-24T13:09:42Z","updated_at":"2017-10-04T21:41:10Z","pushed_at":"2017-10-05T18:29:56Z","git_url":"git://github.com/koreader/koreader.git","ssh_url":"git@github.com:koreader/koreader.git","clone_url":"https://github.com/koreader/koreader.git","svn_url":"https://github.com/koreader/koreader","homepage":"http://koreader.rocks/","size":36794,"stargazers_count":3247,"watchers_count":3247,"language":"Lua","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":471,"mirror_url":null,"open_issues_count":354,"forks":471,"open_issues":354,"watchers":3247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/koreader/koreader/pulls/3304"},"html":{"href":"https://github.com/koreader/koreader/pull/3304"},"issue":{"href":"https://api.github.com/repos/koreader/koreader/issues/3304"},"comments":{"href":"https://api.github.com/repos/koreader/koreader/issues/3304/comments"},"review_comments":{"href":"https://api.github.com/repos/koreader/koreader/pulls/3304/comments"},"review_comment":{"href":"https://api.github.com/repos/koreader/koreader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/koreader/koreader/pulls/3304/commits"},"statuses":{"href":"https://api.github.com/repos/koreader/koreader/statuses/ac489f4587476120c0e14455b0723375593447d0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robert00s"}}