{"action":"created","comment":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/122069068","pull_request_review_id":44152975,"id":122069068,"diff_hunk":"@@ -187,14 +217,48 @@ private[qscript] final class XmlStructuralPlanner[F[_]: Monad: MonadPlanErr: Pro\n       }\n     })\n \n-  // qscript:children-named($src as element()?, $name as xs:QName?) as item()*\n-  lazy val childrenNamed: F[FunctionDecl2] =\n-    ejs.declare[F](\"children-named\") map (_(\n+  // ejson:children-named-encoded($src as element()?, $field as xs:string?) as item()*\n+  lazy val childrenNamedEncoded: F[FunctionDecl2] =","path":"marklogic/src/main/scala/quasar/physical/marklogic/qscript/XmlStructuralPlanner.scala","position":112,"original_position":112,"commit_id":"cc0e48d079d87b7d759d0fa4be1e0557e84f38ee","original_commit_id":"cc0e48d079d87b7d759d0fa4be1e0557e84f38ee","user":{"login":"wemrysi","id":32185,"avatar_url":"https://avatars0.githubusercontent.com/u/32185?v=3","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false},"body":"I think we could convert this into an expression instead of a function.","created_at":"2017-06-14T21:25:46Z","updated_at":"2017-06-14T21:43:44Z","html_url":"https://github.com/quasar-analytics/quasar/pull/2275#discussion_r122069068","pull_request_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2275","_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments/122069068"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/2275#discussion_r122069068"},"pull_request":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2275"}}},"pull_request":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2275","id":123620885,"html_url":"https://github.com/quasar-analytics/quasar/pull/2275","diff_url":"https://github.com/quasar-analytics/quasar/pull/2275.diff","patch_url":"https://github.com/quasar-analytics/quasar/pull/2275.patch","issue_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/2275","number":2275,"state":"open","locked":false,"title":"Support non-QName's in XmlStructuralPlanner","user":{"login":"jsantos17","id":677310,"avatar_url":"https://avatars3.githubusercontent.com/u/677310?v=3","gravatar_id":"","url":"https://api.github.com/users/jsantos17","html_url":"https://github.com/jsantos17","followers_url":"https://api.github.com/users/jsantos17/followers","following_url":"https://api.github.com/users/jsantos17/following{/other_user}","gists_url":"https://api.github.com/users/jsantos17/gists{/gist_id}","starred_url":"https://api.github.com/users/jsantos17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsantos17/subscriptions","organizations_url":"https://api.github.com/users/jsantos17/orgs","repos_url":"https://api.github.com/users/jsantos17/repos","events_url":"https://api.github.com/users/jsantos17/events{/privacy}","received_events_url":"https://api.github.com/users/jsantos17/received_events","type":"User","site_admin":false},"body":"Fixes #1642 ","created_at":"2017-06-02T00:32:42Z","updated_at":"2017-06-14T21:43:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d0bada902d0d1341462e7fff960266b4a1ffe31","assignee":{"login":"wemrysi","id":32185,"avatar_url":"https://avatars0.githubusercontent.com/u/32185?v=3","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false},"assignees":[{"login":"wemrysi","id":32185,"avatar_url":"https://avatars0.githubusercontent.com/u/32185?v=3","gravatar_id":"","url":"https://api.github.com/users/wemrysi","html_url":"https://github.com/wemrysi","followers_url":"https://api.github.com/users/wemrysi/followers","following_url":"https://api.github.com/users/wemrysi/following{/other_user}","gists_url":"https://api.github.com/users/wemrysi/gists{/gist_id}","starred_url":"https://api.github.com/users/wemrysi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wemrysi/subscriptions","organizations_url":"https://api.github.com/users/wemrysi/orgs","repos_url":"https://api.github.com/users/wemrysi/repos","events_url":"https://api.github.com/users/wemrysi/events{/privacy}","received_events_url":"https://api.github.com/users/wemrysi/received_events","type":"User","site_admin":false},{"login":"jsantos17","id":677310,"avatar_url":"https://avatars3.githubusercontent.com/u/677310?v=3","gravatar_id":"","url":"https://api.github.com/users/jsantos17","html_url":"https://github.com/jsantos17","followers_url":"https://api.github.com/users/jsantos17/followers","following_url":"https://api.github.com/users/jsantos17/following{/other_user}","gists_url":"https://api.github.com/users/jsantos17/gists{/gist_id}","starred_url":"https://api.github.com/users/jsantos17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsantos17/subscriptions","organizations_url":"https://api.github.com/users/jsantos17/orgs","repos_url":"https://api.github.com/users/jsantos17/repos","events_url":"https://api.github.com/users/jsantos17/events{/privacy}","received_events_url":"https://api.github.com/users/jsantos17/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2275/commits","review_comments_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2275/comments","review_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/2275/comments","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/cc0e48d079d87b7d759d0fa4be1e0557e84f38ee","head":{"label":"jsantos17:1760-xml-planner-non-qname","ref":"1760-xml-planner-non-qname","sha":"cc0e48d079d87b7d759d0fa4be1e0557e84f38ee","user":{"login":"jsantos17","id":677310,"avatar_url":"https://avatars3.githubusercontent.com/u/677310?v=3","gravatar_id":"","url":"https://api.github.com/users/jsantos17","html_url":"https://github.com/jsantos17","followers_url":"https://api.github.com/users/jsantos17/followers","following_url":"https://api.github.com/users/jsantos17/following{/other_user}","gists_url":"https://api.github.com/users/jsantos17/gists{/gist_id}","starred_url":"https://api.github.com/users/jsantos17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsantos17/subscriptions","organizations_url":"https://api.github.com/users/jsantos17/orgs","repos_url":"https://api.github.com/users/jsantos17/repos","events_url":"https://api.github.com/users/jsantos17/events{/privacy}","received_events_url":"https://api.github.com/users/jsantos17/received_events","type":"User","site_admin":false},"repo":{"id":90794178,"name":"quasar","full_name":"jsantos17/quasar","owner":{"login":"jsantos17","id":677310,"avatar_url":"https://avatars3.githubusercontent.com/u/677310?v=3","gravatar_id":"","url":"https://api.github.com/users/jsantos17","html_url":"https://github.com/jsantos17","followers_url":"https://api.github.com/users/jsantos17/followers","following_url":"https://api.github.com/users/jsantos17/following{/other_user}","gists_url":"https://api.github.com/users/jsantos17/gists{/gist_id}","starred_url":"https://api.github.com/users/jsantos17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsantos17/subscriptions","organizations_url":"https://api.github.com/users/jsantos17/orgs","repos_url":"https://api.github.com/users/jsantos17/repos","events_url":"https://api.github.com/users/jsantos17/events{/privacy}","received_events_url":"https://api.github.com/users/jsantos17/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsantos17/quasar","description":"Quasar Analytics is a general-purpose compiler for translating data processing and analytics over semi-structured data into efficient plans that run 100% in the target infrastructure.","fork":true,"url":"https://api.github.com/repos/jsantos17/quasar","forks_url":"https://api.github.com/repos/jsantos17/quasar/forks","keys_url":"https://api.github.com/repos/jsantos17/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsantos17/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsantos17/quasar/teams","hooks_url":"https://api.github.com/repos/jsantos17/quasar/hooks","issue_events_url":"https://api.github.com/repos/jsantos17/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/jsantos17/quasar/events","assignees_url":"https://api.github.com/repos/jsantos17/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/jsantos17/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/jsantos17/quasar/tags","blobs_url":"https://api.github.com/repos/jsantos17/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsantos17/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsantos17/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsantos17/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsantos17/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/jsantos17/quasar/languages","stargazers_url":"https://api.github.com/repos/jsantos17/quasar/stargazers","contributors_url":"https://api.github.com/repos/jsantos17/quasar/contributors","subscribers_url":"https://api.github.com/repos/jsantos17/quasar/subscribers","subscription_url":"https://api.github.com/repos/jsantos17/quasar/subscription","commits_url":"https://api.github.com/repos/jsantos17/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsantos17/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsantos17/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsantos17/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsantos17/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/jsantos17/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsantos17/quasar/merges","archive_url":"https://api.github.com/repos/jsantos17/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsantos17/quasar/downloads","issues_url":"https://api.github.com/repos/jsantos17/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/jsantos17/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/jsantos17/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/jsantos17/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsantos17/quasar/labels{/name}","releases_url":"https://api.github.com/repos/jsantos17/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/jsantos17/quasar/deployments","created_at":"2017-05-09T21:38:21Z","updated_at":"2017-05-09T21:38:27Z","pushed_at":"2017-06-14T20:46:40Z","git_url":"git://github.com/jsantos17/quasar.git","ssh_url":"git@github.com:jsantos17/quasar.git","clone_url":"https://github.com/jsantos17/quasar.git","svn_url":"https://github.com/jsantos17/quasar","homepage":"http://quasar-analytics.org","size":57989,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quasar-analytics:master","ref":"master","sha":"d695c0c5d19072da9f5c8e08bfbc923db4d84e8f","user":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars2.githubusercontent.com/u/15095906?v=3","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"repo":{"id":16515058,"name":"quasar","full_name":"quasar-analytics/quasar","owner":{"login":"quasar-analytics","id":15095906,"avatar_url":"https://avatars2.githubusercontent.com/u/15095906?v=3","gravatar_id":"","url":"https://api.github.com/users/quasar-analytics","html_url":"https://github.com/quasar-analytics","followers_url":"https://api.github.com/users/quasar-analytics/followers","following_url":"https://api.github.com/users/quasar-analytics/following{/other_user}","gists_url":"https://api.github.com/users/quasar-analytics/gists{/gist_id}","starred_url":"https://api.github.com/users/quasar-analytics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quasar-analytics/subscriptions","organizations_url":"https://api.github.com/users/quasar-analytics/orgs","repos_url":"https://api.github.com/users/quasar-analytics/repos","events_url":"https://api.github.com/users/quasar-analytics/events{/privacy}","received_events_url":"https://api.github.com/users/quasar-analytics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/quasar-analytics/quasar","description":"Quasar Analytics is a general-purpose compiler for translating data processing and analytics over semi-structured data into efficient plans that run 100% in the target infrastructure.","fork":false,"url":"https://api.github.com/repos/quasar-analytics/quasar","forks_url":"https://api.github.com/repos/quasar-analytics/quasar/forks","keys_url":"https://api.github.com/repos/quasar-analytics/quasar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quasar-analytics/quasar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quasar-analytics/quasar/teams","hooks_url":"https://api.github.com/repos/quasar-analytics/quasar/hooks","issue_events_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/events{/number}","events_url":"https://api.github.com/repos/quasar-analytics/quasar/events","assignees_url":"https://api.github.com/repos/quasar-analytics/quasar/assignees{/user}","branches_url":"https://api.github.com/repos/quasar-analytics/quasar/branches{/branch}","tags_url":"https://api.github.com/repos/quasar-analytics/quasar/tags","blobs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quasar-analytics/quasar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quasar-analytics/quasar/git/refs{/sha}","trees_url":"https://api.github.com/repos/quasar-analytics/quasar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quasar-analytics/quasar/statuses/{sha}","languages_url":"https://api.github.com/repos/quasar-analytics/quasar/languages","stargazers_url":"https://api.github.com/repos/quasar-analytics/quasar/stargazers","contributors_url":"https://api.github.com/repos/quasar-analytics/quasar/contributors","subscribers_url":"https://api.github.com/repos/quasar-analytics/quasar/subscribers","subscription_url":"https://api.github.com/repos/quasar-analytics/quasar/subscription","commits_url":"https://api.github.com/repos/quasar-analytics/quasar/commits{/sha}","git_commits_url":"https://api.github.com/repos/quasar-analytics/quasar/git/commits{/sha}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/comments{/number}","issue_comment_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/comments{/number}","contents_url":"https://api.github.com/repos/quasar-analytics/quasar/contents/{+path}","compare_url":"https://api.github.com/repos/quasar-analytics/quasar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quasar-analytics/quasar/merges","archive_url":"https://api.github.com/repos/quasar-analytics/quasar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quasar-analytics/quasar/downloads","issues_url":"https://api.github.com/repos/quasar-analytics/quasar/issues{/number}","pulls_url":"https://api.github.com/repos/quasar-analytics/quasar/pulls{/number}","milestones_url":"https://api.github.com/repos/quasar-analytics/quasar/milestones{/number}","notifications_url":"https://api.github.com/repos/quasar-analytics/quasar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quasar-analytics/quasar/labels{/name}","releases_url":"https://api.github.com/repos/quasar-analytics/quasar/releases{/id}","deployments_url":"https://api.github.com/repos/quasar-analytics/quasar/deployments","created_at":"2014-02-04T15:01:27Z","updated_at":"2017-06-13T12:19:27Z","pushed_at":"2017-06-14T21:32:03Z","git_url":"git://github.com/quasar-analytics/quasar.git","ssh_url":"git@github.com:quasar-analytics/quasar.git","clone_url":"https://github.com/quasar-analytics/quasar.git","svn_url":"https://github.com/quasar-analytics/quasar","homepage":"http://quasar-analytics.org","size":57951,"stargazers_count":501,"watchers_count":501,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":265,"forks":70,"open_issues":265,"watchers":501,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2275"},"html":{"href":"https://github.com/quasar-analytics/quasar/pull/2275"},"issue":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/2275"},"comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/issues/2275/comments"},"review_comments":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2275/comments"},"review_comment":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quasar-analytics/quasar/pulls/2275/commits"},"statuses":{"href":"https://api.github.com/repos/quasar-analytics/quasar/statuses/cc0e48d079d87b7d759d0fa4be1e0557e84f38ee"}}}}
{"actor":{"display_login":"wemrysi"}}