{"action":"created","comment":{"url":"https://api.github.com/repos/stojanovic/scottyjs/pulls/comments/134697366","pull_request_review_id":58015089,"id":134697366,"diff_hunk":"@@ -0,0 +1,39 @@\n+'use strict'\n+\n+const AWS = require('aws-sdk')\n+const r53 = new AWS.Route53()\n+\n+function createRoute(endpoint, zoneId, domain, r53lib) {\n+  r53lib = r53lib || r53\n+\n+  if (!endpoint || !zoneId || !domain)\n+    return Promise.reject('cloudfront endpoint, zoneId and dns domain are required')\n+\n+  const params = {\n+    ChangeBatch: {\n+      Changes: [\n+        {\n+          Action: 'UPSERT',\n+          ResourceRecordSet: {\n+            Name: `${domain}`,\n+            Type: 'A',\n+            TTL: 600,\n+            ResourceRecords: [\n+              {\n+                Value: `${endpoint}`\n+              }\n+            ]\n+          }\n+        }\n+      ],\n+      Comment: 'scotty dns upsert'\n+    },\n+    HostedZoneId: `${zoneId}`","path":"lib/create-route.js","position":31,"original_position":31,"commit_id":"ec3811a4072dffaabb3673786dcbb03fbf7dc099","original_commit_id":"ec3811a4072dffaabb3673786dcbb03fbf7dc099","user":{"login":"simalexan","id":1564065,"avatar_url":"https://avatars2.githubusercontent.com/u/1564065?v=4","gravatar_id":"","url":"https://api.github.com/users/simalexan","html_url":"https://github.com/simalexan","followers_url":"https://api.github.com/users/simalexan/followers","following_url":"https://api.github.com/users/simalexan/following{/other_user}","gists_url":"https://api.github.com/users/simalexan/gists{/gist_id}","starred_url":"https://api.github.com/users/simalexan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simalexan/subscriptions","organizations_url":"https://api.github.com/users/simalexan/orgs","repos_url":"https://api.github.com/users/simalexan/repos","events_url":"https://api.github.com/users/simalexan/events{/privacy}","received_events_url":"https://api.github.com/users/simalexan/received_events","type":"User","site_admin":false},"body":"also here there is no need for string wrapping","created_at":"2017-08-23T09:11:12Z","updated_at":"2017-08-23T09:16:25Z","html_url":"https://github.com/stojanovic/scottyjs/pull/12#discussion_r134697366","pull_request_url":"https://api.github.com/repos/stojanovic/scottyjs/pulls/12","_links":{"self":{"href":"https://api.github.com/repos/stojanovic/scottyjs/pulls/comments/134697366"},"html":{"href":"https://github.com/stojanovic/scottyjs/pull/12#discussion_r134697366"},"pull_request":{"href":"https://api.github.com/repos/stojanovic/scottyjs/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/stojanovic/scottyjs/pulls/12","id":137154631,"html_url":"https://github.com/stojanovic/scottyjs/pull/12","diff_url":"https://github.com/stojanovic/scottyjs/pull/12.diff","patch_url":"https://github.com/stojanovic/scottyjs/pull/12.patch","issue_url":"https://api.github.com/repos/stojanovic/scottyjs/issues/12","number":12,"state":"open","locked":false,"title":"basic route53 setup","user":{"login":"ckaatz-here","id":5434498,"avatar_url":"https://avatars2.githubusercontent.com/u/5434498?v=4","gravatar_id":"","url":"https://api.github.com/users/ckaatz-here","html_url":"https://github.com/ckaatz-here","followers_url":"https://api.github.com/users/ckaatz-here/followers","following_url":"https://api.github.com/users/ckaatz-here/following{/other_user}","gists_url":"https://api.github.com/users/ckaatz-here/gists{/gist_id}","starred_url":"https://api.github.com/users/ckaatz-here/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckaatz-here/subscriptions","organizations_url":"https://api.github.com/users/ckaatz-here/orgs","repos_url":"https://api.github.com/users/ckaatz-here/repos","events_url":"https://api.github.com/users/ckaatz-here/events{/privacy}","received_events_url":"https://api.github.com/users/ckaatz-here/received_events","type":"User","site_admin":false},"body":"- refactored calling of scotty itself\r\n- catch CI bailing when copy to clipboard fails\r\n- add basic route53 domain pointing capability","created_at":"2017-08-23T08:08:36Z","updated_at":"2017-08-23T09:16:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a7855f2ae884a98bcd02613780dfc9d7e3e517a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/stojanovic/scottyjs/pulls/12/commits","review_comments_url":"https://api.github.com/repos/stojanovic/scottyjs/pulls/12/comments","review_comment_url":"https://api.github.com/repos/stojanovic/scottyjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stojanovic/scottyjs/issues/12/comments","statuses_url":"https://api.github.com/repos/stojanovic/scottyjs/statuses/ec3811a4072dffaabb3673786dcbb03fbf7dc099","head":{"label":"ckaatz-here:master","ref":"master","sha":"ec3811a4072dffaabb3673786dcbb03fbf7dc099","user":{"login":"ckaatz-here","id":5434498,"avatar_url":"https://avatars2.githubusercontent.com/u/5434498?v=4","gravatar_id":"","url":"https://api.github.com/users/ckaatz-here","html_url":"https://github.com/ckaatz-here","followers_url":"https://api.github.com/users/ckaatz-here/followers","following_url":"https://api.github.com/users/ckaatz-here/following{/other_user}","gists_url":"https://api.github.com/users/ckaatz-here/gists{/gist_id}","starred_url":"https://api.github.com/users/ckaatz-here/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckaatz-here/subscriptions","organizations_url":"https://api.github.com/users/ckaatz-here/orgs","repos_url":"https://api.github.com/users/ckaatz-here/repos","events_url":"https://api.github.com/users/ckaatz-here/events{/privacy}","received_events_url":"https://api.github.com/users/ckaatz-here/received_events","type":"User","site_admin":false},"repo":{"id":100853036,"name":"scottyjs","full_name":"ckaatz-here/scottyjs","owner":{"login":"ckaatz-here","id":5434498,"avatar_url":"https://avatars2.githubusercontent.com/u/5434498?v=4","gravatar_id":"","url":"https://api.github.com/users/ckaatz-here","html_url":"https://github.com/ckaatz-here","followers_url":"https://api.github.com/users/ckaatz-here/followers","following_url":"https://api.github.com/users/ckaatz-here/following{/other_user}","gists_url":"https://api.github.com/users/ckaatz-here/gists{/gist_id}","starred_url":"https://api.github.com/users/ckaatz-here/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckaatz-here/subscriptions","organizations_url":"https://api.github.com/users/ckaatz-here/orgs","repos_url":"https://api.github.com/users/ckaatz-here/repos","events_url":"https://api.github.com/users/ckaatz-here/events{/privacy}","received_events_url":"https://api.github.com/users/ckaatz-here/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ckaatz-here/scottyjs","description":"Deploy static websites and single page apps to AWS S3 and CloudFront with a single command","fork":true,"url":"https://api.github.com/repos/ckaatz-here/scottyjs","forks_url":"https://api.github.com/repos/ckaatz-here/scottyjs/forks","keys_url":"https://api.github.com/repos/ckaatz-here/scottyjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ckaatz-here/scottyjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ckaatz-here/scottyjs/teams","hooks_url":"https://api.github.com/repos/ckaatz-here/scottyjs/hooks","issue_events_url":"https://api.github.com/repos/ckaatz-here/scottyjs/issues/events{/number}","events_url":"https://api.github.com/repos/ckaatz-here/scottyjs/events","assignees_url":"https://api.github.com/repos/ckaatz-here/scottyjs/assignees{/user}","branches_url":"https://api.github.com/repos/ckaatz-here/scottyjs/branches{/branch}","tags_url":"https://api.github.com/repos/ckaatz-here/scottyjs/tags","blobs_url":"https://api.github.com/repos/ckaatz-here/scottyjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ckaatz-here/scottyjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ckaatz-here/scottyjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ckaatz-here/scottyjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ckaatz-here/scottyjs/statuses/{sha}","languages_url":"https://api.github.com/repos/ckaatz-here/scottyjs/languages","stargazers_url":"https://api.github.com/repos/ckaatz-here/scottyjs/stargazers","contributors_url":"https://api.github.com/repos/ckaatz-here/scottyjs/contributors","subscribers_url":"https://api.github.com/repos/ckaatz-here/scottyjs/subscribers","subscription_url":"https://api.github.com/repos/ckaatz-here/scottyjs/subscription","commits_url":"https://api.github.com/repos/ckaatz-here/scottyjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ckaatz-here/scottyjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ckaatz-here/scottyjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ckaatz-here/scottyjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ckaatz-here/scottyjs/contents/{+path}","compare_url":"https://api.github.com/repos/ckaatz-here/scottyjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ckaatz-here/scottyjs/merges","archive_url":"https://api.github.com/repos/ckaatz-here/scottyjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ckaatz-here/scottyjs/downloads","issues_url":"https://api.github.com/repos/ckaatz-here/scottyjs/issues{/number}","pulls_url":"https://api.github.com/repos/ckaatz-here/scottyjs/pulls{/number}","milestones_url":"https://api.github.com/repos/ckaatz-here/scottyjs/milestones{/number}","notifications_url":"https://api.github.com/repos/ckaatz-here/scottyjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ckaatz-here/scottyjs/labels{/name}","releases_url":"https://api.github.com/repos/ckaatz-here/scottyjs/releases{/id}","deployments_url":"https://api.github.com/repos/ckaatz-here/scottyjs/deployments","created_at":"2017-08-20T10:07:26Z","updated_at":"2017-08-20T10:07:27Z","pushed_at":"2017-08-23T08:19:17Z","git_url":"git://github.com/ckaatz-here/scottyjs.git","ssh_url":"git@github.com:ckaatz-here/scottyjs.git","clone_url":"https://github.com/ckaatz-here/scottyjs.git","svn_url":"https://github.com/ckaatz-here/scottyjs","homepage":"http://medium.com/@slobodan/single-command-deployment-for-single-page-apps-29941d62ef97","size":6551,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stojanovic:master","ref":"master","sha":"75829641576ffa0b69c803425606679d96793918","user":{"login":"stojanovic","id":613478,"avatar_url":"https://avatars2.githubusercontent.com/u/613478?v=4","gravatar_id":"","url":"https://api.github.com/users/stojanovic","html_url":"https://github.com/stojanovic","followers_url":"https://api.github.com/users/stojanovic/followers","following_url":"https://api.github.com/users/stojanovic/following{/other_user}","gists_url":"https://api.github.com/users/stojanovic/gists{/gist_id}","starred_url":"https://api.github.com/users/stojanovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stojanovic/subscriptions","organizations_url":"https://api.github.com/users/stojanovic/orgs","repos_url":"https://api.github.com/users/stojanovic/repos","events_url":"https://api.github.com/users/stojanovic/events{/privacy}","received_events_url":"https://api.github.com/users/stojanovic/received_events","type":"User","site_admin":false},"repo":{"id":99826556,"name":"scottyjs","full_name":"stojanovic/scottyjs","owner":{"login":"stojanovic","id":613478,"avatar_url":"https://avatars2.githubusercontent.com/u/613478?v=4","gravatar_id":"","url":"https://api.github.com/users/stojanovic","html_url":"https://github.com/stojanovic","followers_url":"https://api.github.com/users/stojanovic/followers","following_url":"https://api.github.com/users/stojanovic/following{/other_user}","gists_url":"https://api.github.com/users/stojanovic/gists{/gist_id}","starred_url":"https://api.github.com/users/stojanovic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stojanovic/subscriptions","organizations_url":"https://api.github.com/users/stojanovic/orgs","repos_url":"https://api.github.com/users/stojanovic/repos","events_url":"https://api.github.com/users/stojanovic/events{/privacy}","received_events_url":"https://api.github.com/users/stojanovic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stojanovic/scottyjs","description":"Deploy static websites and single page apps to AWS S3 and CloudFront with a single command","fork":false,"url":"https://api.github.com/repos/stojanovic/scottyjs","forks_url":"https://api.github.com/repos/stojanovic/scottyjs/forks","keys_url":"https://api.github.com/repos/stojanovic/scottyjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stojanovic/scottyjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stojanovic/scottyjs/teams","hooks_url":"https://api.github.com/repos/stojanovic/scottyjs/hooks","issue_events_url":"https://api.github.com/repos/stojanovic/scottyjs/issues/events{/number}","events_url":"https://api.github.com/repos/stojanovic/scottyjs/events","assignees_url":"https://api.github.com/repos/stojanovic/scottyjs/assignees{/user}","branches_url":"https://api.github.com/repos/stojanovic/scottyjs/branches{/branch}","tags_url":"https://api.github.com/repos/stojanovic/scottyjs/tags","blobs_url":"https://api.github.com/repos/stojanovic/scottyjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stojanovic/scottyjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stojanovic/scottyjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/stojanovic/scottyjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stojanovic/scottyjs/statuses/{sha}","languages_url":"https://api.github.com/repos/stojanovic/scottyjs/languages","stargazers_url":"https://api.github.com/repos/stojanovic/scottyjs/stargazers","contributors_url":"https://api.github.com/repos/stojanovic/scottyjs/contributors","subscribers_url":"https://api.github.com/repos/stojanovic/scottyjs/subscribers","subscription_url":"https://api.github.com/repos/stojanovic/scottyjs/subscription","commits_url":"https://api.github.com/repos/stojanovic/scottyjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/stojanovic/scottyjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/stojanovic/scottyjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/stojanovic/scottyjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/stojanovic/scottyjs/contents/{+path}","compare_url":"https://api.github.com/repos/stojanovic/scottyjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stojanovic/scottyjs/merges","archive_url":"https://api.github.com/repos/stojanovic/scottyjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stojanovic/scottyjs/downloads","issues_url":"https://api.github.com/repos/stojanovic/scottyjs/issues{/number}","pulls_url":"https://api.github.com/repos/stojanovic/scottyjs/pulls{/number}","milestones_url":"https://api.github.com/repos/stojanovic/scottyjs/milestones{/number}","notifications_url":"https://api.github.com/repos/stojanovic/scottyjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stojanovic/scottyjs/labels{/name}","releases_url":"https://api.github.com/repos/stojanovic/scottyjs/releases{/id}","deployments_url":"https://api.github.com/repos/stojanovic/scottyjs/deployments","created_at":"2017-08-09T15:54:30Z","updated_at":"2017-08-23T07:16:33Z","pushed_at":"2017-08-23T08:19:18Z","git_url":"git://github.com/stojanovic/scottyjs.git","ssh_url":"git@github.com:stojanovic/scottyjs.git","clone_url":"https://github.com/stojanovic/scottyjs.git","svn_url":"https://github.com/stojanovic/scottyjs","homepage":"http://medium.com/@slobodan/single-command-deployment-for-single-page-apps-29941d62ef97","size":6545,"stargazers_count":278,"watchers_count":278,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":2,"forks":14,"open_issues":2,"watchers":278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stojanovic/scottyjs/pulls/12"},"html":{"href":"https://github.com/stojanovic/scottyjs/pull/12"},"issue":{"href":"https://api.github.com/repos/stojanovic/scottyjs/issues/12"},"comments":{"href":"https://api.github.com/repos/stojanovic/scottyjs/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/stojanovic/scottyjs/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/stojanovic/scottyjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stojanovic/scottyjs/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/stojanovic/scottyjs/statuses/ec3811a4072dffaabb3673786dcbb03fbf7dc099"}}}}
{"actor":{"display_login":"simalexan"}}