{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/46555","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/46555/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/46555/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/46555/events","html_url":"https://github.com/rust-lang/rust/issues/46555","id":280056527,"number":46555,"title":"incr.comp.: Load dep-graph in the background","user":{"login":"michaelwoerister","id":1825894,"avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"labels":[{"id":307747675,"url":"https://api.github.com/repos/rust-lang/rust/labels/A-incr-comp","name":"A-incr-comp","color":"d7e012","default":false},{"id":234902,"url":"https://api.github.com/repos/rust-lang/rust/labels/C-enhancement","name":"C-enhancement","color":"f5f1fd","default":false},{"id":693665681,"url":"https://api.github.com/repos/rust-lang/rust/labels/WG-compiler-incr","name":"WG-compiler-incr","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-12-07T09:22:39Z","updated_at":"2017-12-07T10:41:15Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"The dependency graph is loaded at the earliest point possibly during the compilation session (after the crate disambiguator has been set):\r\nhttps://github.com/rust-lang/rust/blob/bd7021fd57ad595711aaaaba03e0a058cf931056/src/librustc_driver/driver.rs#L654\r\n\r\nHowever, it is only needed for the first time a few passes later:\r\nhttps://github.com/rust-lang/rust/blob/bd7021fd57ad595711aaaaba03e0a058cf931056/src/librustc_driver/driver.rs#L890\r\n\r\nThis was intentional so that we have to possibility to load and decode it the graph on a background thread. One way to implement this is to make `rustc_incremental::load_dep_graph()` start a new thread and return the `thread::JoinHandle` and then only join that thread right before the dep-graph is actually needed."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/349929904","html_url":"https://github.com/rust-lang/rust/issues/46555#issuecomment-349929904","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/46555","id":349929904,"user":{"login":"michaelwoerister","id":1825894,"avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"created_at":"2017-12-07T10:41:15Z","updated_at":"2017-12-07T10:41:15Z","author_association":"CONTRIBUTOR","body":"@Yoric Cool, thank you!"}}
{"actor":{"display_login":"michaelwoerister"}}