{"action":"created","issue":{"url":"https://api.github.com/repos/samsung-cnct/kraken/issues/182","repository_url":"https://api.github.com/repos/samsung-cnct/kraken","labels_url":"https://api.github.com/repos/samsung-cnct/kraken/issues/182/labels{/name}","comments_url":"https://api.github.com/repos/samsung-cnct/kraken/issues/182/comments","events_url":"https://api.github.com/repos/samsung-cnct/kraken/issues/182/events","html_url":"https://github.com/samsung-cnct/kraken/pull/182","id":261420768,"number":182,"title":"[Refactor] Extract k8s version and provider from config file","user":{"login":"alejandroEsc","id":20777618,"avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"labels":[{"id":613967970,"url":"https://api.github.com/repos/samsung-cnct/kraken/labels/DO%20NOT%20MERGE","name":"DO NOT MERGE","color":"ff3f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-09-28T18:43:12Z","updated_at":"2017-10-03T03:23:21Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/samsung-cnct/kraken/pulls/182","html_url":"https://github.com/samsung-cnct/kraken/pull/182","diff_url":"https://github.com/samsung-cnct/kraken/pull/182.diff","patch_url":"https://github.com/samsung-cnct/kraken/pull/182.patch"},"body":"**What this PR does / why we need it**: In the long term some of this may be deprecated, but for now we need to extract k8s version and provider information from a config file that defines a k8s cluster. We already take in a configuration file, why not extract those values.\r\n\r\nIf accepted this code will allow us to remove some code from kraken-lib and make less container queries that run ansible\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**: I moved one string output, about which config file being generated to a verbosity option. This cleans outputs of testing and it probably belongs as something in the verbose output anyway.\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/samsung-cnct/kraken/issues/comments/333727958","html_url":"https://github.com/samsung-cnct/kraken/pull/182#issuecomment-333727958","issue_url":"https://api.github.com/repos/samsung-cnct/kraken/issues/182","id":333727958,"user":{"login":"alejandroEsc","id":20777618,"avatar_url":"https://avatars0.githubusercontent.com/u/20777618?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandroEsc","html_url":"https://github.com/alejandroEsc","followers_url":"https://api.github.com/users/alejandroEsc/followers","following_url":"https://api.github.com/users/alejandroEsc/following{/other_user}","gists_url":"https://api.github.com/users/alejandroEsc/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandroEsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandroEsc/subscriptions","organizations_url":"https://api.github.com/users/alejandroEsc/orgs","repos_url":"https://api.github.com/users/alejandroEsc/repos","events_url":"https://api.github.com/users/alejandroEsc/events{/privacy}","received_events_url":"https://api.github.com/users/alejandroEsc/received_events","type":"User","site_admin":false},"created_at":"2017-10-03T03:23:21Z","updated_at":"2017-10-03T03:23:21Z","author_association":"CONTRIBUTOR","body":"@coffeepac I think the level of interactions involved is more prone to prone errors than having one stop shop where these bugs can be rectified. Parsing errors, specially in this case can be diminished via tests. However, we dont test the scripts nearly as well as we should if at all. Picking and choosing roles is also subject to errors etc.. \r\n\r\nIf you propose now that we open the kraken-config project I would gladly drop this. but if not then i would suggest we simplify code, enforce testing, limit the number of things we do parse (here 3) and move on to the next stage when ready.\r\n\r\nUltimately its your call. "}}
{"actor":{"display_login":"alejandroEsc"}}