{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/128954050","pull_request_review_id":51677994,"id":128954050,"diff_hunk":"@@ -127,7 +127,10 @@ abstract class DragGestureRecognizer extends OneSequenceGestureRecognizer {\n     if (event is PointerMoveEvent) {\n       final VelocityTracker tracker = _velocityTrackers[event.pointer];\n       assert(tracker != null);\n-      tracker.addPosition(event.timeStamp, event.position);\n+      // PointerMoveEvent from platform's gesture up events are positionally redundant\n+      // vs the last PointerMoveEvent. Do not use in velocity calculation.\n+      if (event.sourceEventType != PointerChange.up)\n+        tracker.addPosition(event.timeStamp, event.position);","path":"packages/flutter/lib/src/gestures/monodrag.dart","position":8,"original_position":8,"commit_id":"819c24c37e6bc9d1e09bd63f0c50d0e610d6e9a9","original_commit_id":"819c24c37e6bc9d1e09bd63f0c50d0e610d6e9a9","user":{"login":"xster","id":156888,"avatar_url":"https://avatars2.githubusercontent.com/u/156888?v=4","gravatar_id":"","url":"https://api.github.com/users/xster","html_url":"https://github.com/xster","followers_url":"https://api.github.com/users/xster/followers","following_url":"https://api.github.com/users/xster/following{/other_user}","gists_url":"https://api.github.com/users/xster/gists{/gist_id}","starred_url":"https://api.github.com/users/xster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xster/subscriptions","organizations_url":"https://api.github.com/users/xster/orgs","repos_url":"https://api.github.com/users/xster/repos","events_url":"https://api.github.com/users/xster/events{/privacy}","received_events_url":"https://api.github.com/users/xster/received_events","type":"User","site_admin":false},"body":"1. The OS only sends gesture updates every 16ms as far as I can tell. \r\n2. It seems to always do +/- 10 pixels. Android always gives the exact same positions to the pixel. \r\n3. touchesMoved 0,0; touchesMoved 1,1; touchesMoved 1,1; touchesEnded 1,1 (if we omit the touchesStarted part). That gets transformed into PointerMoveEvent 0,0; PointerMoveEvent 1,1; PointerMoveEvent 1,1; PointerMoveEvent 1,1 for iOS in the framework. ","created_at":"2017-07-24T05:55:21Z","updated_at":"2017-07-24T05:55:21Z","html_url":"https://github.com/flutter/flutter/pull/11345#discussion_r128954050","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/11345","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/128954050"},"html":{"href":"https://github.com/flutter/flutter/pull/11345#discussion_r128954050"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11345"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/11345","id":131849072,"html_url":"https://github.com/flutter/flutter/pull/11345","diff_url":"https://github.com/flutter/flutter/pull/11345.diff","patch_url":"https://github.com/flutter/flutter/pull/11345.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/11345","number":11345,"state":"open","locked":false,"title":"Fix iOS last up event velocity calculation","user":{"login":"xster","id":156888,"avatar_url":"https://avatars2.githubusercontent.com/u/156888?v=4","gravatar_id":"","url":"https://api.github.com/users/xster","html_url":"https://github.com/xster","followers_url":"https://api.github.com/users/xster/followers","following_url":"https://api.github.com/users/xster/following{/other_user}","gists_url":"https://api.github.com/users/xster/gists{/gist_id}","starred_url":"https://api.github.com/users/xster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xster/subscriptions","organizations_url":"https://api.github.com/users/xster/orgs","repos_url":"https://api.github.com/users/xster/repos","events_url":"https://api.github.com/users/xster/events{/privacy}","received_events_url":"https://api.github.com/users/xster/received_events","type":"User","site_admin":false},"body":"Before\r\n![giphy-downsized-large 1](https://user-images.githubusercontent.com/156888/28480350-3bd2e5c2-6e2e-11e7-8066-e32aab059d07.gif)\r\n\r\nAfter\r\n![giphy-downsized-large](https://user-images.githubusercontent.com/156888/28480362-455251b4-6e2e-11e7-8c5c-425ddf37c8a2.gif)\r\n\r\nRemove the last gesture up event that got synthesized as a move event in the gesture converter from iOS velocity calculation. Doesn't affect Android.\r\n\r\nMake the original platform's gesture event type accessible in the PointerEvent.\r\n\r\nDoesn't make iOS scrolling perfectly match the platform's yet but fixes the most noticeable momentum loss problem that makes scrolling ~1/3 incorrect. \r\n\r\n#10977","created_at":"2017-07-21T20:07:08Z","updated_at":"2017-07-24T05:55:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"820b447160f2436269974edae66f8ac64dcf395b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"HansMuller","id":1377460,"avatar_url":"https://avatars2.githubusercontent.com/u/1377460?v=4","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/11345/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/11345/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/11345/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/819c24c37e6bc9d1e09bd63f0c50d0e610d6e9a9","head":{"label":"xster:scroll-flick","ref":"scroll-flick","sha":"819c24c37e6bc9d1e09bd63f0c50d0e610d6e9a9","user":{"login":"xster","id":156888,"avatar_url":"https://avatars2.githubusercontent.com/u/156888?v=4","gravatar_id":"","url":"https://api.github.com/users/xster","html_url":"https://github.com/xster","followers_url":"https://api.github.com/users/xster/followers","following_url":"https://api.github.com/users/xster/following{/other_user}","gists_url":"https://api.github.com/users/xster/gists{/gist_id}","starred_url":"https://api.github.com/users/xster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xster/subscriptions","organizations_url":"https://api.github.com/users/xster/orgs","repos_url":"https://api.github.com/users/xster/repos","events_url":"https://api.github.com/users/xster/events{/privacy}","received_events_url":"https://api.github.com/users/xster/received_events","type":"User","site_admin":false},"repo":{"id":79845855,"name":"flutter","full_name":"xster/flutter","owner":{"login":"xster","id":156888,"avatar_url":"https://avatars2.githubusercontent.com/u/156888?v=4","gravatar_id":"","url":"https://api.github.com/users/xster","html_url":"https://github.com/xster","followers_url":"https://api.github.com/users/xster/followers","following_url":"https://api.github.com/users/xster/following{/other_user}","gists_url":"https://api.github.com/users/xster/gists{/gist_id}","starred_url":"https://api.github.com/users/xster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xster/subscriptions","organizations_url":"https://api.github.com/users/xster/orgs","repos_url":"https://api.github.com/users/xster/repos","events_url":"https://api.github.com/users/xster/events{/privacy}","received_events_url":"https://api.github.com/users/xster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xster/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/xster/flutter","forks_url":"https://api.github.com/repos/xster/flutter/forks","keys_url":"https://api.github.com/repos/xster/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xster/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xster/flutter/teams","hooks_url":"https://api.github.com/repos/xster/flutter/hooks","issue_events_url":"https://api.github.com/repos/xster/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/xster/flutter/events","assignees_url":"https://api.github.com/repos/xster/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/xster/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/xster/flutter/tags","blobs_url":"https://api.github.com/repos/xster/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xster/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xster/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/xster/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xster/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/xster/flutter/languages","stargazers_url":"https://api.github.com/repos/xster/flutter/stargazers","contributors_url":"https://api.github.com/repos/xster/flutter/contributors","subscribers_url":"https://api.github.com/repos/xster/flutter/subscribers","subscription_url":"https://api.github.com/repos/xster/flutter/subscription","commits_url":"https://api.github.com/repos/xster/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/xster/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/xster/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/xster/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/xster/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/xster/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xster/flutter/merges","archive_url":"https://api.github.com/repos/xster/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xster/flutter/downloads","issues_url":"https://api.github.com/repos/xster/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/xster/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/xster/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/xster/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xster/flutter/labels{/name}","releases_url":"https://api.github.com/repos/xster/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/xster/flutter/deployments","created_at":"2017-01-23T20:41:37Z","updated_at":"2017-01-23T20:41:42Z","pushed_at":"2017-07-24T05:50:55Z","git_url":"git://github.com/xster/flutter.git","ssh_url":"git@github.com:xster/flutter.git","clone_url":"https://github.com/xster/flutter.git","svn_url":"https://github.com/xster/flutter","homepage":"https://flutter.io","size":28523,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"c0e9809653471386439c9ed74a48d1ddc78eefd2","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2017-07-24T02:13:43Z","pushed_at":"2017-07-24T05:53:40Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":28534,"stargazers_count":5626,"watchers_count":5626,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":562,"mirror_url":null,"open_issues_count":1708,"forks":562,"open_issues":1708,"watchers":5626,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11345"},"html":{"href":"https://github.com/flutter/flutter/pull/11345"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/11345"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/11345/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11345/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11345/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/819c24c37e6bc9d1e09bd63f0c50d0e610d6e9a9"}}}}
{"actor":{"display_login":"xster"}}