{"comment":{"url":"https://api.github.com/repos/sematext/docker-spm-client/comments/25204318","html_url":"https://github.com/sematext/docker-spm-client/commit/883b6f99dc8e5afa4b23adafddd09f0e85ce3096#commitcomment-25204318","id":25204318,"user":{"login":"komljen","id":2872288,"avatar_url":"https://avatars3.githubusercontent.com/u/2872288?v=4","gravatar_id":"","url":"https://api.github.com/users/komljen","html_url":"https://github.com/komljen","followers_url":"https://api.github.com/users/komljen/followers","following_url":"https://api.github.com/users/komljen/following{/other_user}","gists_url":"https://api.github.com/users/komljen/gists{/gist_id}","starred_url":"https://api.github.com/users/komljen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/komljen/subscriptions","organizations_url":"https://api.github.com/users/komljen/orgs","repos_url":"https://api.github.com/users/komljen/repos","events_url":"https://api.github.com/users/komljen/events{/privacy}","received_events_url":"https://api.github.com/users/komljen/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"883b6f99dc8e5afa4b23adafddd09f0e85ce3096","created_at":"2017-10-26T09:47:56Z","updated_at":"2017-10-26T09:47:56Z","author_association":"CONTRIBUTOR","body":"When I posted a container names a month ago in engineering channel we had a discussion to use descriptive names for containers, so I also changed some properties according to that:\r\n\r\n```\r\nspm-reports -> metrics-api\r\nspm-receiver -> metrics-receiver\r\nspm-tracing-receiver -> trace-receiver\r\nspm-afs -> metrics-afs\r\nspm-alerts -> alerts\r\nspm-reports-renderer -> metrics-renderer\r\nlogsene-reports -> logs-api\r\nlogsene-consumer -> logs-consumer\r\nlogsene-ip-receiver -> logs-ip-receiver\r\nlogsene-token-receiver -> logs-token-receiver\r\nlogsene-jobs -> logs-jobs\r\nlogsene-reports-renderer -> logs-renderer\r\nsua-reports -> management-api\r\nsua-event-receiver -> event-receiver\r\n```\r\n\r\nThis also meant some config changes, etc. It is not hard for me to change those variables, it is literally a 15 min job, but then we are losing some consistency in k8s. It is one env file and a few configs.\r\n\r\nSo, we just need to decide in which direction to go. k8s change is faster if we are ok with old variable names. "}}
{"actor":{"display_login":"komljen"}}