{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/151401223","pull_request_review_id":77100822,"id":151401223,"diff_hunk":"@@ -19,6 +19,11 @@\n RIOTBASE = os.environ['RIOTBASE'] or \\\n            os.path.abspath(os.path.join(os.path.dirname(__file__), \"..\", \"..\", \"..\"))\n \n+\n+MAKE_TERM_START_WAIT = os.environ.get('TESTRUNNER_START_WAIT') or 3\n+MAKE_TERM_START_WAIT = int(MAKE_TERM_START_WAIT)","path":"dist/tools/testrunner/testrunner.py","position":null,"original_position":6,"commit_id":"ca69cea527002e2a3e492c901c5447fc3f77846a","original_commit_id":"17f70708e35c5284b219f23e938bb30ae9e2566c","user":{"login":"miri64","id":675644,"avatar_url":"https://avatars1.githubusercontent.com/u/675644?v=4","gravatar_id":"","url":"https://api.github.com/users/miri64","html_url":"https://github.com/miri64","followers_url":"https://api.github.com/users/miri64/followers","following_url":"https://api.github.com/users/miri64/following{/other_user}","gists_url":"https://api.github.com/users/miri64/gists{/gist_id}","starred_url":"https://api.github.com/users/miri64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miri64/subscriptions","organizations_url":"https://api.github.com/users/miri64/orgs","repos_url":"https://api.github.com/users/miri64/repos","events_url":"https://api.github.com/users/miri64/events{/privacy}","received_events_url":"https://api.github.com/users/miri64/received_events","type":"User","site_admin":false},"body":"> Hey, the line given is wrong, it should be MAKE_TERM_START_WAIT = int(os.environ.get('MAKE_TERM_START_WAIT', 3))\r\n\r\n@cladmi already addressed that in https://github.com/RIOT-OS/RIOT/pull/8053#discussion_r151383773:\r\n\r\n> And I cannot apply int directly to os.environ.get in case its None or empty string.","created_at":"2017-11-16T12:36:00Z","updated_at":"2017-11-16T12:36:00Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/8053#discussion_r151401223","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8053","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/151401223"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8053#discussion_r151401223"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8053"}},"in_reply_to_id":151382630},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8053","id":153009937,"html_url":"https://github.com/RIOT-OS/RIOT/pull/8053","diff_url":"https://github.com/RIOT-OS/RIOT/pull/8053.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/8053.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8053","number":8053,"state":"open","locked":false,"title":"dist/tools/testrunner: Make started wait time configurable","user":{"login":"cladmi","id":241401,"avatar_url":"https://avatars3.githubusercontent.com/u/241401?v=4","gravatar_id":"","url":"https://api.github.com/users/cladmi","html_url":"https://github.com/cladmi","followers_url":"https://api.github.com/users/cladmi/followers","following_url":"https://api.github.com/users/cladmi/following{/other_user}","gists_url":"https://api.github.com/users/cladmi/gists{/gist_id}","starred_url":"https://api.github.com/users/cladmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cladmi/subscriptions","organizations_url":"https://api.github.com/users/cladmi/orgs","repos_url":"https://api.github.com/users/cladmi/repos","events_url":"https://api.github.com/users/cladmi/events{/privacy}","received_events_url":"https://api.github.com/users/cladmi/received_events","type":"User","site_admin":false},"body":"The wait before board is started is 3 by default but can be overwritten by\r\nsetting 'TESTRUNNER_START_WAIT' environment variable.\r\n\r\nThis could help when the default 3 seconds does not fit like https://github.com/RIOT-OS/RIOT/pull/7992#issuecomment-344884708","created_at":"2017-11-16T10:59:58Z","updated_at":"2017-11-16T12:36:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0250d5a61ee273b1236eb0bbdcd0c476cfb43cb6","assignee":{"login":"smlng","id":10532675,"avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false},"assignees":[{"login":"smlng","id":10532675,"avatar_url":"https://avatars1.githubusercontent.com/u/10532675?v=4","gravatar_id":"","url":"https://api.github.com/users/smlng","html_url":"https://github.com/smlng","followers_url":"https://api.github.com/users/smlng/followers","following_url":"https://api.github.com/users/smlng/following{/other_user}","gists_url":"https://api.github.com/users/smlng/gists{/gist_id}","starred_url":"https://api.github.com/users/smlng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smlng/subscriptions","organizations_url":"https://api.github.com/users/smlng/orgs","repos_url":"https://api.github.com/users/smlng/repos","events_url":"https://api.github.com/users/smlng/events{/privacy}","received_events_url":"https://api.github.com/users/smlng/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8053/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8053/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8053/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/ca69cea527002e2a3e492c901c5447fc3f77846a","head":{"label":"cladmi:pr/testrunner/make_start_delay_configurable","ref":"pr/testrunner/make_start_delay_configurable","sha":"ca69cea527002e2a3e492c901c5447fc3f77846a","user":{"login":"cladmi","id":241401,"avatar_url":"https://avatars3.githubusercontent.com/u/241401?v=4","gravatar_id":"","url":"https://api.github.com/users/cladmi","html_url":"https://github.com/cladmi","followers_url":"https://api.github.com/users/cladmi/followers","following_url":"https://api.github.com/users/cladmi/following{/other_user}","gists_url":"https://api.github.com/users/cladmi/gists{/gist_id}","starred_url":"https://api.github.com/users/cladmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cladmi/subscriptions","organizations_url":"https://api.github.com/users/cladmi/orgs","repos_url":"https://api.github.com/users/cladmi/repos","events_url":"https://api.github.com/users/cladmi/events{/privacy}","received_events_url":"https://api.github.com/users/cladmi/received_events","type":"User","site_admin":false},"repo":{"id":29687838,"name":"RIOT","full_name":"cladmi/RIOT","owner":{"login":"cladmi","id":241401,"avatar_url":"https://avatars3.githubusercontent.com/u/241401?v=4","gravatar_id":"","url":"https://api.github.com/users/cladmi","html_url":"https://github.com/cladmi","followers_url":"https://api.github.com/users/cladmi/followers","following_url":"https://api.github.com/users/cladmi/following{/other_user}","gists_url":"https://api.github.com/users/cladmi/gists{/gist_id}","starred_url":"https://api.github.com/users/cladmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cladmi/subscriptions","organizations_url":"https://api.github.com/users/cladmi/orgs","repos_url":"https://api.github.com/users/cladmi/repos","events_url":"https://api.github.com/users/cladmi/events{/privacy}","received_events_url":"https://api.github.com/users/cladmi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cladmi/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/cladmi/RIOT","forks_url":"https://api.github.com/repos/cladmi/RIOT/forks","keys_url":"https://api.github.com/repos/cladmi/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cladmi/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cladmi/RIOT/teams","hooks_url":"https://api.github.com/repos/cladmi/RIOT/hooks","issue_events_url":"https://api.github.com/repos/cladmi/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/cladmi/RIOT/events","assignees_url":"https://api.github.com/repos/cladmi/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/cladmi/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/cladmi/RIOT/tags","blobs_url":"https://api.github.com/repos/cladmi/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cladmi/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cladmi/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/cladmi/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cladmi/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/cladmi/RIOT/languages","stargazers_url":"https://api.github.com/repos/cladmi/RIOT/stargazers","contributors_url":"https://api.github.com/repos/cladmi/RIOT/contributors","subscribers_url":"https://api.github.com/repos/cladmi/RIOT/subscribers","subscription_url":"https://api.github.com/repos/cladmi/RIOT/subscription","commits_url":"https://api.github.com/repos/cladmi/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/cladmi/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/cladmi/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/cladmi/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/cladmi/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/cladmi/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cladmi/RIOT/merges","archive_url":"https://api.github.com/repos/cladmi/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cladmi/RIOT/downloads","issues_url":"https://api.github.com/repos/cladmi/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/cladmi/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/cladmi/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/cladmi/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cladmi/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/cladmi/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/cladmi/RIOT/deployments","created_at":"2015-01-22T16:23:34Z","updated_at":"2017-09-04T13:06:24Z","pushed_at":"2017-11-16T12:21:33Z","git_url":"git://github.com/cladmi/RIOT.git","ssh_url":"git@github.com:cladmi/RIOT.git","clone_url":"https://github.com/cladmi/RIOT.git","svn_url":"https://github.com/cladmi/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":44844,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"e0946af76868a2c97e194dfdd5954b2603daf58f","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars2.githubusercontent.com/u/3079480?v=4","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","deployments_url":"https://api.github.com/repos/RIOT-OS/RIOT/deployments","created_at":"2012-12-29T20:38:40Z","updated_at":"2017-11-16T01:52:20Z","pushed_at":"2017-11-16T12:24:32Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":45159,"stargazers_count":1486,"watchers_count":1486,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":883,"mirror_url":null,"archived":false,"open_issues_count":680,"forks":883,"open_issues":680,"watchers":1486,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8053"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/8053"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8053"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8053/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8053/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8053/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/ca69cea527002e2a3e492c901c5447fc3f77846a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"miri64"}}