{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/115877436","pull_request_review_id":37455493,"id":115877436,"diff_hunk":"@@ -525,6 +525,7 @@ ParserResult<Expr> Parser::parseExprUnary(Diag<> Message, bool isExprBasic) {\n ParserResult<Expr> Parser::parseExprKeyPath() {\n   // Consume '\\'.\n   SourceLoc backslashLoc = consumeToken(tok::backslash);\n+  llvm::SaveAndRestore<SourceLoc> slashLoc(SwiftKeyPathSlashLoc, backslashLoc);","path":"lib/Parse/ParseExpr.cpp","position":4,"original_position":4,"commit_id":"db4b44105cbaea2a2690023afd36423c0567ce1a","original_commit_id":"db4b44105cbaea2a2690023afd36423c0567ce1a","user":{"login":"nkcsgexi","id":2191945,"avatar_url":"https://avatars3.githubusercontent.com/u/2191945?v=3","gravatar_id":"","url":"https://api.github.com/users/nkcsgexi","html_url":"https://github.com/nkcsgexi","followers_url":"https://api.github.com/users/nkcsgexi/followers","following_url":"https://api.github.com/users/nkcsgexi/following{/other_user}","gists_url":"https://api.github.com/users/nkcsgexi/gists{/gist_id}","starred_url":"https://api.github.com/users/nkcsgexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkcsgexi/subscriptions","organizations_url":"https://api.github.com/users/nkcsgexi/orgs","repos_url":"https://api.github.com/users/nkcsgexi/repos","events_url":"https://api.github.com/users/nkcsgexi/events{/privacy}","received_events_url":"https://api.github.com/users/nkcsgexi/received_events","type":"User","site_admin":false},"body":"This basically to save SwiftKeyPathSlashLoc in the parser context so parseExprPostfixSuffix can use it to create an instance of KeyPathExpr.","created_at":"2017-05-10T23:38:55Z","updated_at":"2017-05-10T23:38:55Z","html_url":"https://github.com/apple/swift/pull/9467#discussion_r115877436","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/9467","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/115877436"},"html":{"href":"https://github.com/apple/swift/pull/9467#discussion_r115877436"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/9467"}}},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/9467","id":119956301,"html_url":"https://github.com/apple/swift/pull/9467","diff_url":"https://github.com/apple/swift/pull/9467.diff","patch_url":"https://github.com/apple/swift/pull/9467.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/9467","number":9467,"state":"open","locked":false,"title":"[CodeCompletion] Provide basic code completion support for Swift KeyPath. rdar://31768743","user":{"login":"nkcsgexi","id":2191945,"avatar_url":"https://avatars3.githubusercontent.com/u/2191945?v=3","gravatar_id":"","url":"https://api.github.com/users/nkcsgexi","html_url":"https://github.com/nkcsgexi","followers_url":"https://api.github.com/users/nkcsgexi/followers","following_url":"https://api.github.com/users/nkcsgexi/following{/other_user}","gists_url":"https://api.github.com/users/nkcsgexi/gists{/gist_id}","starred_url":"https://api.github.com/users/nkcsgexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkcsgexi/subscriptions","organizations_url":"https://api.github.com/users/nkcsgexi/orgs","repos_url":"https://api.github.com/users/nkcsgexi/repos","events_url":"https://api.github.com/users/nkcsgexi/events{/privacy}","received_events_url":"https://api.github.com/users/nkcsgexi/received_events","type":"User","site_admin":false},"body":"This patch starts libIDE support for code completing keyPath expression; after each `.` in key path component, code completion provides type-sensitive member properties and subscripts. This patch doesn't implement code completion for contextual-inferred keyPath root type like `\\.property.[0]`.","created_at":"2017-05-10T19:07:25Z","updated_at":"2017-05-10T23:38:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54bb3cc6b98d4156652affffcebd9f4f964906bf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/9467/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/9467/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/9467/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/db4b44105cbaea2a2690023afd36423c0567ce1a","head":{"label":"nkcsgexi:code-complete-key-path","ref":"code-complete-key-path","sha":"db4b44105cbaea2a2690023afd36423c0567ce1a","user":{"login":"nkcsgexi","id":2191945,"avatar_url":"https://avatars3.githubusercontent.com/u/2191945?v=3","gravatar_id":"","url":"https://api.github.com/users/nkcsgexi","html_url":"https://github.com/nkcsgexi","followers_url":"https://api.github.com/users/nkcsgexi/followers","following_url":"https://api.github.com/users/nkcsgexi/following{/other_user}","gists_url":"https://api.github.com/users/nkcsgexi/gists{/gist_id}","starred_url":"https://api.github.com/users/nkcsgexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkcsgexi/subscriptions","organizations_url":"https://api.github.com/users/nkcsgexi/orgs","repos_url":"https://api.github.com/users/nkcsgexi/repos","events_url":"https://api.github.com/users/nkcsgexi/events{/privacy}","received_events_url":"https://api.github.com/users/nkcsgexi/received_events","type":"User","site_admin":false},"repo":{"id":86523088,"name":"swift","full_name":"nkcsgexi/swift","owner":{"login":"nkcsgexi","id":2191945,"avatar_url":"https://avatars3.githubusercontent.com/u/2191945?v=3","gravatar_id":"","url":"https://api.github.com/users/nkcsgexi","html_url":"https://github.com/nkcsgexi","followers_url":"https://api.github.com/users/nkcsgexi/followers","following_url":"https://api.github.com/users/nkcsgexi/following{/other_user}","gists_url":"https://api.github.com/users/nkcsgexi/gists{/gist_id}","starred_url":"https://api.github.com/users/nkcsgexi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkcsgexi/subscriptions","organizations_url":"https://api.github.com/users/nkcsgexi/orgs","repos_url":"https://api.github.com/users/nkcsgexi/repos","events_url":"https://api.github.com/users/nkcsgexi/events{/privacy}","received_events_url":"https://api.github.com/users/nkcsgexi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nkcsgexi/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/nkcsgexi/swift","forks_url":"https://api.github.com/repos/nkcsgexi/swift/forks","keys_url":"https://api.github.com/repos/nkcsgexi/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nkcsgexi/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nkcsgexi/swift/teams","hooks_url":"https://api.github.com/repos/nkcsgexi/swift/hooks","issue_events_url":"https://api.github.com/repos/nkcsgexi/swift/issues/events{/number}","events_url":"https://api.github.com/repos/nkcsgexi/swift/events","assignees_url":"https://api.github.com/repos/nkcsgexi/swift/assignees{/user}","branches_url":"https://api.github.com/repos/nkcsgexi/swift/branches{/branch}","tags_url":"https://api.github.com/repos/nkcsgexi/swift/tags","blobs_url":"https://api.github.com/repos/nkcsgexi/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nkcsgexi/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nkcsgexi/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/nkcsgexi/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nkcsgexi/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/nkcsgexi/swift/languages","stargazers_url":"https://api.github.com/repos/nkcsgexi/swift/stargazers","contributors_url":"https://api.github.com/repos/nkcsgexi/swift/contributors","subscribers_url":"https://api.github.com/repos/nkcsgexi/swift/subscribers","subscription_url":"https://api.github.com/repos/nkcsgexi/swift/subscription","commits_url":"https://api.github.com/repos/nkcsgexi/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/nkcsgexi/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/nkcsgexi/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/nkcsgexi/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/nkcsgexi/swift/contents/{+path}","compare_url":"https://api.github.com/repos/nkcsgexi/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nkcsgexi/swift/merges","archive_url":"https://api.github.com/repos/nkcsgexi/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nkcsgexi/swift/downloads","issues_url":"https://api.github.com/repos/nkcsgexi/swift/issues{/number}","pulls_url":"https://api.github.com/repos/nkcsgexi/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/nkcsgexi/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/nkcsgexi/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nkcsgexi/swift/labels{/name}","releases_url":"https://api.github.com/repos/nkcsgexi/swift/releases{/id}","deployments_url":"https://api.github.com/repos/nkcsgexi/swift/deployments","created_at":"2017-03-29T01:08:59Z","updated_at":"2017-03-29T01:09:23Z","pushed_at":"2017-05-10T23:23:03Z","git_url":"git://github.com/nkcsgexi/swift.git","ssh_url":"git@github.com:nkcsgexi/swift.git","clone_url":"https://github.com/nkcsgexi/swift.git","svn_url":"https://github.com/nkcsgexi/swift","homepage":"https://swift.org/","size":196240,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"5bd3428a8b28e9cbf39fe28c628a7ccd849ccf07","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars3.githubusercontent.com/u/10639145?v=3","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2017-05-10T20:51:39Z","pushed_at":"2017-05-10T23:37:35Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":198215,"stargazers_count":38296,"watchers_count":38296,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5707,"mirror_url":null,"open_issues_count":189,"forks":5707,"open_issues":189,"watchers":38296,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/9467"},"html":{"href":"https://github.com/apple/swift/pull/9467"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/9467"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/9467/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/9467/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/9467/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/db4b44105cbaea2a2690023afd36423c0567ce1a"}}}}
{"actor":{"display_login":"nkcsgexi"}}