{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/comments/151091870","pull_request_review_id":76720634,"id":151091870,"diff_hunk":"@@ -147,6 +147,13 @@\n   public final double routerLatencyToleranceQuantile;\n \n   /**\n+   * The version to use for new BlobIds.\n+   */\n+  @Config(\"router.blobid.current.version\")\n+  @Default(\"2\")","path":"ambry-api/src/main/java/com.github.ambry/config/RouterConfig.java","position":7,"original_position":7,"commit_id":"590b6c561c227a288ac81c6f96b481336b7553a8","original_commit_id":"590b6c561c227a288ac81c6f96b481336b7553a8","user":{"login":"cgtz","id":3821381,"avatar_url":"https://avatars2.githubusercontent.com/u/3821381?v=4","gravatar_id":"","url":"https://api.github.com/users/cgtz","html_url":"https://github.com/cgtz","followers_url":"https://api.github.com/users/cgtz/followers","following_url":"https://api.github.com/users/cgtz/following{/other_user}","gists_url":"https://api.github.com/users/cgtz/gists{/gist_id}","starred_url":"https://api.github.com/users/cgtz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgtz/subscriptions","organizations_url":"https://api.github.com/users/cgtz/orgs","repos_url":"https://api.github.com/users/cgtz/repos","events_url":"https://api.github.com/users/cgtz/events{/privacy}","received_events_url":"https://api.github.com/users/cgtz/received_events","type":"User","site_admin":false},"body":"Consider just making the default value a static final field in this config class. That would get rid of the need for CommonTestUtils.","created_at":"2017-11-15T10:47:06Z","updated_at":"2017-11-15T10:47:33Z","html_url":"https://github.com/linkedin/ambry/pull/803#discussion_r151091870","pull_request_url":"https://api.github.com/repos/linkedin/ambry/pulls/803","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments/151091870"},"html":{"href":"https://github.com/linkedin/ambry/pull/803#discussion_r151091870"},"pull_request":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/803"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/803","id":152094585,"html_url":"https://github.com/linkedin/ambry/pull/803","diff_url":"https://github.com/linkedin/ambry/pull/803.diff","patch_url":"https://github.com/linkedin/ambry/pull/803.patch","issue_url":"https://api.github.com/repos/linkedin/ambry/issues/803","number":803,"state":"open","locked":false,"title":"Introduce BlobId V3 and the idea of native and crafted ids","user":{"login":"pnarayanan","id":1454915,"avatar_url":"https://avatars2.githubusercontent.com/u/1454915?v=4","gravatar_id":"","url":"https://api.github.com/users/pnarayanan","html_url":"https://github.com/pnarayanan","followers_url":"https://api.github.com/users/pnarayanan/followers","following_url":"https://api.github.com/users/pnarayanan/following{/other_user}","gists_url":"https://api.github.com/users/pnarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/pnarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnarayanan/subscriptions","organizations_url":"https://api.github.com/users/pnarayanan/orgs","repos_url":"https://api.github.com/users/pnarayanan/repos","events_url":"https://api.github.com/users/pnarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/pnarayanan/received_events","type":"User","site_admin":false},"body":"Introduce V3 of the BlobId.\r\n\r\nIntroduce a type for blobs. For V3:\r\n  - 'Native' blobs are those that are created by the router in the\r\n    context of a PUT operation.\r\n  - 'Crafted' blobs are those that are V3 blobs crafted outside of\r\n    the router, such as say, converted V2 or V1 ids.\r\n\r\nTake the current active blob id version from a config setting in\r\nRouterConfig to make enabling new versions easy.\r\n\r\nTests pass with the config value set to 2 as well as 3.","created_at":"2017-11-12T08:38:22Z","updated_at":"2017-11-15T10:47:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfd3d5decb1951651adfa0b228715832180536ce","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/ambry/pulls/803/commits","review_comments_url":"https://api.github.com/repos/linkedin/ambry/pulls/803/comments","review_comment_url":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/803/comments","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/590b6c561c227a288ac81c6f96b481336b7553a8","head":{"label":"pnarayanan:BlobIdV3","ref":"BlobIdV3","sha":"590b6c561c227a288ac81c6f96b481336b7553a8","user":{"login":"pnarayanan","id":1454915,"avatar_url":"https://avatars2.githubusercontent.com/u/1454915?v=4","gravatar_id":"","url":"https://api.github.com/users/pnarayanan","html_url":"https://github.com/pnarayanan","followers_url":"https://api.github.com/users/pnarayanan/followers","following_url":"https://api.github.com/users/pnarayanan/following{/other_user}","gists_url":"https://api.github.com/users/pnarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/pnarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnarayanan/subscriptions","organizations_url":"https://api.github.com/users/pnarayanan/orgs","repos_url":"https://api.github.com/users/pnarayanan/repos","events_url":"https://api.github.com/users/pnarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/pnarayanan/received_events","type":"User","site_admin":false},"repo":{"id":25383889,"name":"ambry","full_name":"pnarayanan/ambry","owner":{"login":"pnarayanan","id":1454915,"avatar_url":"https://avatars2.githubusercontent.com/u/1454915?v=4","gravatar_id":"","url":"https://api.github.com/users/pnarayanan","html_url":"https://github.com/pnarayanan","followers_url":"https://api.github.com/users/pnarayanan/followers","following_url":"https://api.github.com/users/pnarayanan/following{/other_user}","gists_url":"https://api.github.com/users/pnarayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/pnarayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnarayanan/subscriptions","organizations_url":"https://api.github.com/users/pnarayanan/orgs","repos_url":"https://api.github.com/users/pnarayanan/repos","events_url":"https://api.github.com/users/pnarayanan/events{/privacy}","received_events_url":"https://api.github.com/users/pnarayanan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pnarayanan/ambry","description":"Immutable blob store","fork":true,"url":"https://api.github.com/repos/pnarayanan/ambry","forks_url":"https://api.github.com/repos/pnarayanan/ambry/forks","keys_url":"https://api.github.com/repos/pnarayanan/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pnarayanan/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pnarayanan/ambry/teams","hooks_url":"https://api.github.com/repos/pnarayanan/ambry/hooks","issue_events_url":"https://api.github.com/repos/pnarayanan/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/pnarayanan/ambry/events","assignees_url":"https://api.github.com/repos/pnarayanan/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/pnarayanan/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/pnarayanan/ambry/tags","blobs_url":"https://api.github.com/repos/pnarayanan/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pnarayanan/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pnarayanan/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/pnarayanan/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pnarayanan/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/pnarayanan/ambry/languages","stargazers_url":"https://api.github.com/repos/pnarayanan/ambry/stargazers","contributors_url":"https://api.github.com/repos/pnarayanan/ambry/contributors","subscribers_url":"https://api.github.com/repos/pnarayanan/ambry/subscribers","subscription_url":"https://api.github.com/repos/pnarayanan/ambry/subscription","commits_url":"https://api.github.com/repos/pnarayanan/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/pnarayanan/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/pnarayanan/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/pnarayanan/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/pnarayanan/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/pnarayanan/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pnarayanan/ambry/merges","archive_url":"https://api.github.com/repos/pnarayanan/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pnarayanan/ambry/downloads","issues_url":"https://api.github.com/repos/pnarayanan/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/pnarayanan/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/pnarayanan/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/pnarayanan/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pnarayanan/ambry/labels{/name}","releases_url":"https://api.github.com/repos/pnarayanan/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/pnarayanan/ambry/deployments","created_at":"2014-10-18T01:44:12Z","updated_at":"2016-11-04T00:08:34Z","pushed_at":"2017-11-12T08:37:45Z","git_url":"git://github.com/pnarayanan/ambry.git","ssh_url":"git@github.com:pnarayanan/ambry.git","clone_url":"https://github.com/pnarayanan/ambry.git","svn_url":"https://github.com/pnarayanan/ambry","homepage":null,"size":11362,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"9ef1084af0fb67a07a5acacf649c7f8ec48f92dc","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":13870893,"name":"ambry","full_name":"linkedin/ambry","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars3.githubusercontent.com/u/357098?v=4","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/ambry","description":"Distributed object store","fork":false,"url":"https://api.github.com/repos/linkedin/ambry","forks_url":"https://api.github.com/repos/linkedin/ambry/forks","keys_url":"https://api.github.com/repos/linkedin/ambry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/ambry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/ambry/teams","hooks_url":"https://api.github.com/repos/linkedin/ambry/hooks","issue_events_url":"https://api.github.com/repos/linkedin/ambry/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/ambry/events","assignees_url":"https://api.github.com/repos/linkedin/ambry/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/ambry/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/ambry/tags","blobs_url":"https://api.github.com/repos/linkedin/ambry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/ambry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/ambry/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/ambry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/ambry/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/ambry/languages","stargazers_url":"https://api.github.com/repos/linkedin/ambry/stargazers","contributors_url":"https://api.github.com/repos/linkedin/ambry/contributors","subscribers_url":"https://api.github.com/repos/linkedin/ambry/subscribers","subscription_url":"https://api.github.com/repos/linkedin/ambry/subscription","commits_url":"https://api.github.com/repos/linkedin/ambry/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/ambry/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/ambry/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/ambry/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/ambry/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/ambry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/ambry/merges","archive_url":"https://api.github.com/repos/linkedin/ambry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/ambry/downloads","issues_url":"https://api.github.com/repos/linkedin/ambry/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/ambry/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/ambry/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/ambry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/ambry/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/ambry/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/ambry/deployments","created_at":"2013-10-25T20:04:54Z","updated_at":"2017-11-13T09:26:20Z","pushed_at":"2017-11-15T07:53:55Z","git_url":"git://github.com/linkedin/ambry.git","ssh_url":"git@github.com:linkedin/ambry.git","clone_url":"https://github.com/linkedin/ambry.git","svn_url":"https://github.com/linkedin/ambry","homepage":"https://github.com/linkedin/ambry/wiki","size":11222,"stargazers_count":961,"watchers_count":961,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":173,"mirror_url":null,"archived":false,"open_issues_count":76,"forks":173,"open_issues":76,"watchers":961,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/803"},"html":{"href":"https://github.com/linkedin/ambry/pull/803"},"issue":{"href":"https://api.github.com/repos/linkedin/ambry/issues/803"},"comments":{"href":"https://api.github.com/repos/linkedin/ambry/issues/803/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/803/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/ambry/pulls/803/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/ambry/statuses/590b6c561c227a288ac81c6f96b481336b7553a8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cgtz"}}