{"action":"opened","number":814,"pull_request":{"url":"https://api.github.com/repos/ethereum/pyethereum/pulls/814","id":146852214,"html_url":"https://github.com/ethereum/pyethereum/pull/814","diff_url":"https://github.com/ethereum/pyethereum/pull/814.diff","patch_url":"https://github.com/ethereum/pyethereum/pull/814.patch","issue_url":"https://api.github.com/repos/ethereum/pyethereum/issues/814","number":814,"state":"open","locked":false,"title":"Python3 compatibility","user":{"login":"hwwhww","id":9263930,"avatar_url":"https://avatars3.githubusercontent.com/u/9263930?v=4","gravatar_id":"","url":"https://api.github.com/users/hwwhww","html_url":"https://github.com/hwwhww","followers_url":"https://api.github.com/users/hwwhww/followers","following_url":"https://api.github.com/users/hwwhww/following{/other_user}","gists_url":"https://api.github.com/users/hwwhww/gists{/gist_id}","starred_url":"https://api.github.com/users/hwwhww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwwhww/subscriptions","organizations_url":"https://api.github.com/users/hwwhww/orgs","repos_url":"https://api.github.com/users/hwwhww/repos","events_url":"https://api.github.com/users/hwwhww/events{/privacy}","received_events_url":"https://api.github.com/users/hwwhww/received_events","type":"User","site_admin":false},"body":"\r\n### - What I did\r\n1. Improve python3 compatibility\r\n2. An adjustment of https://github.com/ethereum/pyethereum/commit/91342a0430119d3884ac7d6bf4078fcf38e401fa because I found `pyethapp` can’t run on the old code, hope @joeykrug could help to check if this patch works for your case too.\r\n\r\n### - How I did it\r\n1. Using `to_string(data)` instead most `str(data)` function. Note that `to_string(data)` returns `bytes` for both Python2 and Python3.\r\n2. Added the missing `b` before binary string\r\n3. Modified the assertion of state.block_number and state.prev_headers[0].number\r\n\r\n### - Cute Animal Picture\r\n![bear2](https://user-images.githubusercontent.com/9263930/31627584-62fc0f14-b273-11e7-8304-6b2561938954.jpg)\r\n","created_at":"2017-10-16T18:13:55Z","updated_at":"2017-10-16T18:13:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/pyethereum/pulls/814/commits","review_comments_url":"https://api.github.com/repos/ethereum/pyethereum/pulls/814/comments","review_comment_url":"https://api.github.com/repos/ethereum/pyethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/pyethereum/issues/814/comments","statuses_url":"https://api.github.com/repos/ethereum/pyethereum/statuses/de758bf16ccbf5d60796818498fe263342db2853","head":{"label":"hwwhww:py3_compatible3","ref":"py3_compatible3","sha":"de758bf16ccbf5d60796818498fe263342db2853","user":{"login":"hwwhww","id":9263930,"avatar_url":"https://avatars3.githubusercontent.com/u/9263930?v=4","gravatar_id":"","url":"https://api.github.com/users/hwwhww","html_url":"https://github.com/hwwhww","followers_url":"https://api.github.com/users/hwwhww/followers","following_url":"https://api.github.com/users/hwwhww/following{/other_user}","gists_url":"https://api.github.com/users/hwwhww/gists{/gist_id}","starred_url":"https://api.github.com/users/hwwhww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwwhww/subscriptions","organizations_url":"https://api.github.com/users/hwwhww/orgs","repos_url":"https://api.github.com/users/hwwhww/repos","events_url":"https://api.github.com/users/hwwhww/events{/privacy}","received_events_url":"https://api.github.com/users/hwwhww/received_events","type":"User","site_admin":false},"repo":{"id":95019892,"name":"pyethereum","full_name":"hwwhww/pyethereum","owner":{"login":"hwwhww","id":9263930,"avatar_url":"https://avatars3.githubusercontent.com/u/9263930?v=4","gravatar_id":"","url":"https://api.github.com/users/hwwhww","html_url":"https://github.com/hwwhww","followers_url":"https://api.github.com/users/hwwhww/followers","following_url":"https://api.github.com/users/hwwhww/following{/other_user}","gists_url":"https://api.github.com/users/hwwhww/gists{/gist_id}","starred_url":"https://api.github.com/users/hwwhww/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwwhww/subscriptions","organizations_url":"https://api.github.com/users/hwwhww/orgs","repos_url":"https://api.github.com/users/hwwhww/repos","events_url":"https://api.github.com/users/hwwhww/events{/privacy}","received_events_url":"https://api.github.com/users/hwwhww/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hwwhww/pyethereum","description":"Next generation cryptocurrency network","fork":true,"url":"https://api.github.com/repos/hwwhww/pyethereum","forks_url":"https://api.github.com/repos/hwwhww/pyethereum/forks","keys_url":"https://api.github.com/repos/hwwhww/pyethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hwwhww/pyethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hwwhww/pyethereum/teams","hooks_url":"https://api.github.com/repos/hwwhww/pyethereum/hooks","issue_events_url":"https://api.github.com/repos/hwwhww/pyethereum/issues/events{/number}","events_url":"https://api.github.com/repos/hwwhww/pyethereum/events","assignees_url":"https://api.github.com/repos/hwwhww/pyethereum/assignees{/user}","branches_url":"https://api.github.com/repos/hwwhww/pyethereum/branches{/branch}","tags_url":"https://api.github.com/repos/hwwhww/pyethereum/tags","blobs_url":"https://api.github.com/repos/hwwhww/pyethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hwwhww/pyethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hwwhww/pyethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/hwwhww/pyethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hwwhww/pyethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/hwwhww/pyethereum/languages","stargazers_url":"https://api.github.com/repos/hwwhww/pyethereum/stargazers","contributors_url":"https://api.github.com/repos/hwwhww/pyethereum/contributors","subscribers_url":"https://api.github.com/repos/hwwhww/pyethereum/subscribers","subscription_url":"https://api.github.com/repos/hwwhww/pyethereum/subscription","commits_url":"https://api.github.com/repos/hwwhww/pyethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/hwwhww/pyethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/hwwhww/pyethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/hwwhww/pyethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/hwwhww/pyethereum/contents/{+path}","compare_url":"https://api.github.com/repos/hwwhww/pyethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hwwhww/pyethereum/merges","archive_url":"https://api.github.com/repos/hwwhww/pyethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hwwhww/pyethereum/downloads","issues_url":"https://api.github.com/repos/hwwhww/pyethereum/issues{/number}","pulls_url":"https://api.github.com/repos/hwwhww/pyethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/hwwhww/pyethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/hwwhww/pyethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hwwhww/pyethereum/labels{/name}","releases_url":"https://api.github.com/repos/hwwhww/pyethereum/releases{/id}","deployments_url":"https://api.github.com/repos/hwwhww/pyethereum/deployments","created_at":"2017-06-21T15:41:08Z","updated_at":"2017-06-21T15:41:11Z","pushed_at":"2017-10-16T17:56:01Z","git_url":"git://github.com/hwwhww/pyethereum.git","ssh_url":"git@github.com:hwwhww/pyethereum.git","clone_url":"https://github.com/hwwhww/pyethereum.git","svn_url":"https://github.com/hwwhww/pyethereum","homepage":null,"size":5402,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"321a11427b9757fe678c3f8f115cf18c01173b0c","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15409820,"name":"pyethereum","full_name":"ethereum/pyethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/pyethereum","description":"Next generation cryptocurrency network","fork":false,"url":"https://api.github.com/repos/ethereum/pyethereum","forks_url":"https://api.github.com/repos/ethereum/pyethereum/forks","keys_url":"https://api.github.com/repos/ethereum/pyethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/pyethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/pyethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/pyethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/pyethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/pyethereum/events","assignees_url":"https://api.github.com/repos/ethereum/pyethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/pyethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/pyethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/pyethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/pyethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/pyethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/pyethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/pyethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/pyethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/pyethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/pyethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/pyethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/pyethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/pyethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/pyethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/pyethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/pyethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/pyethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/pyethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/pyethereum/merges","archive_url":"https://api.github.com/repos/ethereum/pyethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/pyethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/pyethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/pyethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/pyethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/pyethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/pyethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/pyethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/pyethereum/deployments","created_at":"2013-12-24T02:40:05Z","updated_at":"2017-10-16T02:41:20Z","pushed_at":"2017-10-15T21:34:34Z","git_url":"git://github.com/ethereum/pyethereum.git","ssh_url":"git@github.com:ethereum/pyethereum.git","clone_url":"https://github.com/ethereum/pyethereum.git","svn_url":"https://github.com/ethereum/pyethereum","homepage":null,"size":5427,"stargazers_count":1532,"watchers_count":1532,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":473,"mirror_url":null,"open_issues_count":76,"forks":473,"open_issues":76,"watchers":1532,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/pyethereum/pulls/814"},"html":{"href":"https://github.com/ethereum/pyethereum/pull/814"},"issue":{"href":"https://api.github.com/repos/ethereum/pyethereum/issues/814"},"comments":{"href":"https://api.github.com/repos/ethereum/pyethereum/issues/814/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/pyethereum/pulls/814/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/pyethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/pyethereum/pulls/814/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/pyethereum/statuses/de758bf16ccbf5d60796818498fe263342db2853"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":89,"deletions":73,"changed_files":14}}
{"actor":{"display_login":"hwwhww"}}