{"action":"created","comment":{"url":"https://api.github.com/repos/girder/girder/pulls/comments/140067529","pull_request_review_id":64080557,"id":140067529,"diff_hunk":"@@ -17,7 +17,54 @@ var ConfigView = View.extend({\n             this._saveSettings([{\n                 key: 'homepage.markdown',\n                 value: this.editor.val()\n+            },\n+            {\n+                key: 'homepage.header',\n+                value: this.$('#g-homepage-header').val()\n+            },\n+            {\n+                key: 'homepage.subheader',\n+                value: this.$('#g-homepage-subheader').val()\n+            },\n+            {\n+                key: 'homepage.welcome_text',\n+                value: this.welcomeText.val()\n+            },\n+            {\n+                key: 'homepage.logo',\n+                value: this.logoUrl\n             }]);\n+        },\n+\n+        'change #g-homepage-logo': function (event) {\n+            var reader = new FileReader();\n+            reader.onload = () => {\n+                this.$('.g-preview-logo').attr({\n+                    'src': reader.result,\n+                    'width': '50px'\n+                });\n+                this.logoUrl = reader.result;\n+            };\n+\n+            reader.readAsDataURL(event.target.files[0]);\n+            this.$('.g-preview-logo').removeClass('hidden');\n+            /* Clear the value of the hidden file input to avoid 'Chrome'\n+            to not triger the change event when the same image is set,\n+            this line fix a bug */\n+            this.$('#g-homepage-logo').val(null);\n+        },\n+\n+        'click #g-homepage-default-logo-btn': function (event) {\n+            this.$('.g-preview-logo').attr({\n+                'src': require('girder/assets/Girder_Mark.png'),","path":"plugins/homepage/web_client/views/ConfigView.js","position":43,"original_position":43,"commit_id":"27958780a510e30171b0b16ab41c80c8c8a66cae","original_commit_id":"27958780a510e30171b0b16ab41c80c8c8a66cae","user":{"login":"brianhelba","id":1282879,"avatar_url":"https://avatars1.githubusercontent.com/u/1282879?v=4","gravatar_id":"","url":"https://api.github.com/users/brianhelba","html_url":"https://github.com/brianhelba","followers_url":"https://api.github.com/users/brianhelba/followers","following_url":"https://api.github.com/users/brianhelba/following{/other_user}","gists_url":"https://api.github.com/users/brianhelba/gists{/gist_id}","starred_url":"https://api.github.com/users/brianhelba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianhelba/subscriptions","organizations_url":"https://api.github.com/users/brianhelba/orgs","repos_url":"https://api.github.com/users/brianhelba/repos","events_url":"https://api.github.com/users/brianhelba/events{/privacy}","received_events_url":"https://api.github.com/users/brianhelba/received_events","type":"User","site_admin":false},"body":"Let's not call `require` twice like this. It's harmless, but slow.","created_at":"2017-09-20T19:22:35Z","updated_at":"2017-09-20T19:24:20Z","html_url":"https://github.com/girder/girder/pull/2328#discussion_r140067529","pull_request_url":"https://api.github.com/repos/girder/girder/pulls/2328","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/girder/girder/pulls/comments/140067529"},"html":{"href":"https://github.com/girder/girder/pull/2328#discussion_r140067529"},"pull_request":{"href":"https://api.github.com/repos/girder/girder/pulls/2328"}}},"pull_request":{"url":"https://api.github.com/repos/girder/girder/pulls/2328","id":139420693,"html_url":"https://github.com/girder/girder/pull/2328","diff_url":"https://github.com/girder/girder/pull/2328.diff","patch_url":"https://github.com/girder/girder/pull/2328.patch","issue_url":"https://api.github.com/repos/girder/girder/issues/2328","number":2328,"state":"open","locked":false,"title":"Add custom settings in Homepage plugin for the Front Page","user":{"login":"Pierre-Assemat","id":29961430,"avatar_url":"https://avatars1.githubusercontent.com/u/29961430?v=4","gravatar_id":"","url":"https://api.github.com/users/Pierre-Assemat","html_url":"https://github.com/Pierre-Assemat","followers_url":"https://api.github.com/users/Pierre-Assemat/followers","following_url":"https://api.github.com/users/Pierre-Assemat/following{/other_user}","gists_url":"https://api.github.com/users/Pierre-Assemat/gists{/gist_id}","starred_url":"https://api.github.com/users/Pierre-Assemat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pierre-Assemat/subscriptions","organizations_url":"https://api.github.com/users/Pierre-Assemat/orgs","repos_url":"https://api.github.com/users/Pierre-Assemat/repos","events_url":"https://api.github.com/users/Pierre-Assemat/events{/privacy}","received_events_url":"https://api.github.com/users/Pierre-Assemat/received_events","type":"User","site_admin":false},"body":"These settings are :\r\n- header\r\n- subheading --> subheader\r\n- welcome text\r\n\r\nThis PR has the same goal of https://github.com/girder/girder/pull/2318 but without using the webroot to pass the settings, in this changes only the homepage plugin is touch\r\n","created_at":"2017-09-05T21:03:35Z","updated_at":"2017-09-20T19:24:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2143a367c19006b2b1a10848ef72fd6a25324fad","assignee":{"login":"Pierre-Assemat","id":29961430,"avatar_url":"https://avatars1.githubusercontent.com/u/29961430?v=4","gravatar_id":"","url":"https://api.github.com/users/Pierre-Assemat","html_url":"https://github.com/Pierre-Assemat","followers_url":"https://api.github.com/users/Pierre-Assemat/followers","following_url":"https://api.github.com/users/Pierre-Assemat/following{/other_user}","gists_url":"https://api.github.com/users/Pierre-Assemat/gists{/gist_id}","starred_url":"https://api.github.com/users/Pierre-Assemat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pierre-Assemat/subscriptions","organizations_url":"https://api.github.com/users/Pierre-Assemat/orgs","repos_url":"https://api.github.com/users/Pierre-Assemat/repos","events_url":"https://api.github.com/users/Pierre-Assemat/events{/privacy}","received_events_url":"https://api.github.com/users/Pierre-Assemat/received_events","type":"User","site_admin":false},"assignees":[{"login":"Pierre-Assemat","id":29961430,"avatar_url":"https://avatars1.githubusercontent.com/u/29961430?v=4","gravatar_id":"","url":"https://api.github.com/users/Pierre-Assemat","html_url":"https://github.com/Pierre-Assemat","followers_url":"https://api.github.com/users/Pierre-Assemat/followers","following_url":"https://api.github.com/users/Pierre-Assemat/following{/other_user}","gists_url":"https://api.github.com/users/Pierre-Assemat/gists{/gist_id}","starred_url":"https://api.github.com/users/Pierre-Assemat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pierre-Assemat/subscriptions","organizations_url":"https://api.github.com/users/Pierre-Assemat/orgs","repos_url":"https://api.github.com/users/Pierre-Assemat/repos","events_url":"https://api.github.com/users/Pierre-Assemat/events{/privacy}","received_events_url":"https://api.github.com/users/Pierre-Assemat/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"zachmullen","id":555959,"avatar_url":"https://avatars1.githubusercontent.com/u/555959?v=4","gravatar_id":"","url":"https://api.github.com/users/zachmullen","html_url":"https://github.com/zachmullen","followers_url":"https://api.github.com/users/zachmullen/followers","following_url":"https://api.github.com/users/zachmullen/following{/other_user}","gists_url":"https://api.github.com/users/zachmullen/gists{/gist_id}","starred_url":"https://api.github.com/users/zachmullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zachmullen/subscriptions","organizations_url":"https://api.github.com/users/zachmullen/orgs","repos_url":"https://api.github.com/users/zachmullen/repos","events_url":"https://api.github.com/users/zachmullen/events{/privacy}","received_events_url":"https://api.github.com/users/zachmullen/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/girder/girder/pulls/2328/commits","review_comments_url":"https://api.github.com/repos/girder/girder/pulls/2328/comments","review_comment_url":"https://api.github.com/repos/girder/girder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/girder/girder/issues/2328/comments","statuses_url":"https://api.github.com/repos/girder/girder/statuses/27958780a510e30171b0b16ab41c80c8c8a66cae","head":{"label":"girder:add-setting-homepage-plugin","ref":"add-setting-homepage-plugin","sha":"27958780a510e30171b0b16ab41c80c8c8a66cae","user":{"login":"girder","id":5150517,"avatar_url":"https://avatars2.githubusercontent.com/u/5150517?v=4","gravatar_id":"","url":"https://api.github.com/users/girder","html_url":"https://github.com/girder","followers_url":"https://api.github.com/users/girder/followers","following_url":"https://api.github.com/users/girder/following{/other_user}","gists_url":"https://api.github.com/users/girder/gists{/gist_id}","starred_url":"https://api.github.com/users/girder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girder/subscriptions","organizations_url":"https://api.github.com/users/girder/orgs","repos_url":"https://api.github.com/users/girder/repos","events_url":"https://api.github.com/users/girder/events{/privacy}","received_events_url":"https://api.github.com/users/girder/received_events","type":"Organization","site_admin":false},"repo":{"id":11854950,"name":"girder","full_name":"girder/girder","owner":{"login":"girder","id":5150517,"avatar_url":"https://avatars2.githubusercontent.com/u/5150517?v=4","gravatar_id":"","url":"https://api.github.com/users/girder","html_url":"https://github.com/girder","followers_url":"https://api.github.com/users/girder/followers","following_url":"https://api.github.com/users/girder/following{/other_user}","gists_url":"https://api.github.com/users/girder/gists{/gist_id}","starred_url":"https://api.github.com/users/girder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girder/subscriptions","organizations_url":"https://api.github.com/users/girder/orgs","repos_url":"https://api.github.com/users/girder/repos","events_url":"https://api.github.com/users/girder/events{/privacy}","received_events_url":"https://api.github.com/users/girder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/girder/girder","description":"A data management platform for the web, developed by Kitware","fork":false,"url":"https://api.github.com/repos/girder/girder","forks_url":"https://api.github.com/repos/girder/girder/forks","keys_url":"https://api.github.com/repos/girder/girder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/girder/girder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/girder/girder/teams","hooks_url":"https://api.github.com/repos/girder/girder/hooks","issue_events_url":"https://api.github.com/repos/girder/girder/issues/events{/number}","events_url":"https://api.github.com/repos/girder/girder/events","assignees_url":"https://api.github.com/repos/girder/girder/assignees{/user}","branches_url":"https://api.github.com/repos/girder/girder/branches{/branch}","tags_url":"https://api.github.com/repos/girder/girder/tags","blobs_url":"https://api.github.com/repos/girder/girder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/girder/girder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/girder/girder/git/refs{/sha}","trees_url":"https://api.github.com/repos/girder/girder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/girder/girder/statuses/{sha}","languages_url":"https://api.github.com/repos/girder/girder/languages","stargazers_url":"https://api.github.com/repos/girder/girder/stargazers","contributors_url":"https://api.github.com/repos/girder/girder/contributors","subscribers_url":"https://api.github.com/repos/girder/girder/subscribers","subscription_url":"https://api.github.com/repos/girder/girder/subscription","commits_url":"https://api.github.com/repos/girder/girder/commits{/sha}","git_commits_url":"https://api.github.com/repos/girder/girder/git/commits{/sha}","comments_url":"https://api.github.com/repos/girder/girder/comments{/number}","issue_comment_url":"https://api.github.com/repos/girder/girder/issues/comments{/number}","contents_url":"https://api.github.com/repos/girder/girder/contents/{+path}","compare_url":"https://api.github.com/repos/girder/girder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/girder/girder/merges","archive_url":"https://api.github.com/repos/girder/girder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/girder/girder/downloads","issues_url":"https://api.github.com/repos/girder/girder/issues{/number}","pulls_url":"https://api.github.com/repos/girder/girder/pulls{/number}","milestones_url":"https://api.github.com/repos/girder/girder/milestones{/number}","notifications_url":"https://api.github.com/repos/girder/girder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/girder/girder/labels{/name}","releases_url":"https://api.github.com/repos/girder/girder/releases{/id}","deployments_url":"https://api.github.com/repos/girder/girder/deployments","created_at":"2013-08-02T23:55:54Z","updated_at":"2017-09-20T07:56:54Z","pushed_at":"2017-09-20T17:17:43Z","git_url":"git://github.com/girder/girder.git","ssh_url":"git@github.com:girder/girder.git","clone_url":"https://github.com/girder/girder.git","svn_url":"https://github.com/girder/girder","homepage":"http://girder.readthedocs.io","size":14091,"stargazers_count":146,"watchers_count":146,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":245,"forks":71,"open_issues":245,"watchers":146,"default_branch":"master"}},"base":{"label":"girder:master","ref":"master","sha":"d4f1625beb77a5d74542970279e205cc822fda55","user":{"login":"girder","id":5150517,"avatar_url":"https://avatars2.githubusercontent.com/u/5150517?v=4","gravatar_id":"","url":"https://api.github.com/users/girder","html_url":"https://github.com/girder","followers_url":"https://api.github.com/users/girder/followers","following_url":"https://api.github.com/users/girder/following{/other_user}","gists_url":"https://api.github.com/users/girder/gists{/gist_id}","starred_url":"https://api.github.com/users/girder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girder/subscriptions","organizations_url":"https://api.github.com/users/girder/orgs","repos_url":"https://api.github.com/users/girder/repos","events_url":"https://api.github.com/users/girder/events{/privacy}","received_events_url":"https://api.github.com/users/girder/received_events","type":"Organization","site_admin":false},"repo":{"id":11854950,"name":"girder","full_name":"girder/girder","owner":{"login":"girder","id":5150517,"avatar_url":"https://avatars2.githubusercontent.com/u/5150517?v=4","gravatar_id":"","url":"https://api.github.com/users/girder","html_url":"https://github.com/girder","followers_url":"https://api.github.com/users/girder/followers","following_url":"https://api.github.com/users/girder/following{/other_user}","gists_url":"https://api.github.com/users/girder/gists{/gist_id}","starred_url":"https://api.github.com/users/girder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girder/subscriptions","organizations_url":"https://api.github.com/users/girder/orgs","repos_url":"https://api.github.com/users/girder/repos","events_url":"https://api.github.com/users/girder/events{/privacy}","received_events_url":"https://api.github.com/users/girder/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/girder/girder","description":"A data management platform for the web, developed by Kitware","fork":false,"url":"https://api.github.com/repos/girder/girder","forks_url":"https://api.github.com/repos/girder/girder/forks","keys_url":"https://api.github.com/repos/girder/girder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/girder/girder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/girder/girder/teams","hooks_url":"https://api.github.com/repos/girder/girder/hooks","issue_events_url":"https://api.github.com/repos/girder/girder/issues/events{/number}","events_url":"https://api.github.com/repos/girder/girder/events","assignees_url":"https://api.github.com/repos/girder/girder/assignees{/user}","branches_url":"https://api.github.com/repos/girder/girder/branches{/branch}","tags_url":"https://api.github.com/repos/girder/girder/tags","blobs_url":"https://api.github.com/repos/girder/girder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/girder/girder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/girder/girder/git/refs{/sha}","trees_url":"https://api.github.com/repos/girder/girder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/girder/girder/statuses/{sha}","languages_url":"https://api.github.com/repos/girder/girder/languages","stargazers_url":"https://api.github.com/repos/girder/girder/stargazers","contributors_url":"https://api.github.com/repos/girder/girder/contributors","subscribers_url":"https://api.github.com/repos/girder/girder/subscribers","subscription_url":"https://api.github.com/repos/girder/girder/subscription","commits_url":"https://api.github.com/repos/girder/girder/commits{/sha}","git_commits_url":"https://api.github.com/repos/girder/girder/git/commits{/sha}","comments_url":"https://api.github.com/repos/girder/girder/comments{/number}","issue_comment_url":"https://api.github.com/repos/girder/girder/issues/comments{/number}","contents_url":"https://api.github.com/repos/girder/girder/contents/{+path}","compare_url":"https://api.github.com/repos/girder/girder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/girder/girder/merges","archive_url":"https://api.github.com/repos/girder/girder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/girder/girder/downloads","issues_url":"https://api.github.com/repos/girder/girder/issues{/number}","pulls_url":"https://api.github.com/repos/girder/girder/pulls{/number}","milestones_url":"https://api.github.com/repos/girder/girder/milestones{/number}","notifications_url":"https://api.github.com/repos/girder/girder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/girder/girder/labels{/name}","releases_url":"https://api.github.com/repos/girder/girder/releases{/id}","deployments_url":"https://api.github.com/repos/girder/girder/deployments","created_at":"2013-08-02T23:55:54Z","updated_at":"2017-09-20T07:56:54Z","pushed_at":"2017-09-20T17:17:43Z","git_url":"git://github.com/girder/girder.git","ssh_url":"git@github.com:girder/girder.git","clone_url":"https://github.com/girder/girder.git","svn_url":"https://github.com/girder/girder","homepage":"http://girder.readthedocs.io","size":14091,"stargazers_count":146,"watchers_count":146,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":245,"forks":71,"open_issues":245,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/girder/girder/pulls/2328"},"html":{"href":"https://github.com/girder/girder/pull/2328"},"issue":{"href":"https://api.github.com/repos/girder/girder/issues/2328"},"comments":{"href":"https://api.github.com/repos/girder/girder/issues/2328/comments"},"review_comments":{"href":"https://api.github.com/repos/girder/girder/pulls/2328/comments"},"review_comment":{"href":"https://api.github.com/repos/girder/girder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/girder/girder/pulls/2328/commits"},"statuses":{"href":"https://api.github.com/repos/girder/girder/statuses/27958780a510e30171b0b16ab41c80c8c8a66cae"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"brianhelba"}}