{"action":"created","comment":{"url":"https://api.github.com/repos/robotology/yarp/pulls/comments/151365398","pull_request_review_id":77059248,"id":151365398,"diff_hunk":"@@ -298,44 +297,42 @@ void ImageStorage::_set_ipl_header(int x, int y, int pixel_type, int quantum,\n     int origin = topIsLow?IPL_ORIGIN_TL:IPL_ORIGIN_BL;\n     int implemented_yet = 1;\n     // used to allocate the ipl header.\n+#define iplCreateImageHeaderMono   pImage = iplCreateImageHeader( 1, 0, IPL_DEPTH_8U,  (char *)\"GRAY\", (char *)\"GRAY\", IPL_DATA_ORDER_PIXEL, origin, quantum, x, y, nullptr, nullptr, nullptr, nullptr)\n+#define iplCreateImageHeaderMono16 pImage = iplCreateImageHeader( 1, 0, IPL_DEPTH_16U, (char *)\"GRAY\", (char *)\"GRAY\", IPL_DATA_ORDER_PIXEL, origin, quantum, x, y, nullptr, nullptr, nullptr, nullptr)","path":"src/libYARP_sig/src/Image.cpp","position":61,"original_position":61,"commit_id":"c9155c3f3188b282bc23fea749cdae299cdebf02","original_commit_id":"c9155c3f3188b282bc23fea749cdae299cdebf02","user":{"login":"barbalberto","id":4061020,"avatar_url":"https://avatars2.githubusercontent.com/u/4061020?v=4","gravatar_id":"","url":"https://api.github.com/users/barbalberto","html_url":"https://github.com/barbalberto","followers_url":"https://api.github.com/users/barbalberto/followers","following_url":"https://api.github.com/users/barbalberto/following{/other_user}","gists_url":"https://api.github.com/users/barbalberto/gists{/gist_id}","starred_url":"https://api.github.com/users/barbalberto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barbalberto/subscriptions","organizations_url":"https://api.github.com/users/barbalberto/orgs","repos_url":"https://api.github.com/users/barbalberto/repos","events_url":"https://api.github.com/users/barbalberto/events{/privacy}","received_events_url":"https://api.github.com/users/barbalberto/received_events","type":"User","site_admin":false},"body":"I do agree with @drdanz, defines shall not have to be used to simply _rename_ things. That's a bad practise and does not help readability, please stop doing it. Let the code speak for itself","created_at":"2017-11-16T09:51:48Z","updated_at":"2017-11-16T09:51:48Z","html_url":"https://github.com/robotology/yarp/pull/1426#discussion_r151365398","pull_request_url":"https://api.github.com/repos/robotology/yarp/pulls/1426","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/robotology/yarp/pulls/comments/151365398"},"html":{"href":"https://github.com/robotology/yarp/pull/1426#discussion_r151365398"},"pull_request":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1426"}},"in_reply_to_id":150459900},"pull_request":{"url":"https://api.github.com/repos/robotology/yarp/pulls/1426","id":148473431,"html_url":"https://github.com/robotology/yarp/pull/1426","diff_url":"https://github.com/robotology/yarp/pull/1426.diff","patch_url":"https://github.com/robotology/yarp/pull/1426.patch","issue_url":"https://api.github.com/repos/robotology/yarp/issues/1426","number":1426,"state":"open","locked":false,"title":"pixelsize bug fix","user":{"login":"aerydna","id":7593650,"avatar_url":"https://avatars1.githubusercontent.com/u/7593650?v=4","gravatar_id":"","url":"https://api.github.com/users/aerydna","html_url":"https://github.com/aerydna","followers_url":"https://api.github.com/users/aerydna/followers","following_url":"https://api.github.com/users/aerydna/following{/other_user}","gists_url":"https://api.github.com/users/aerydna/gists{/gist_id}","starred_url":"https://api.github.com/users/aerydna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerydna/subscriptions","organizations_url":"https://api.github.com/users/aerydna/orgs","repos_url":"https://api.github.com/users/aerydna/repos","events_url":"https://api.github.com/users/aerydna/events{/privacy}","received_events_url":"https://api.github.com/users/aerydna/received_events","type":"User","site_admin":false},"body":"fixes #1408\r\n\r\nbasically the pixelSize is a datum dependent on the pixel code and have to be always deduced from it, not set manually. we should deprecate the `setPixelSize` method ","created_at":"2017-10-24T18:12:36Z","updated_at":"2017-11-16T09:51:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a3b018f95afd8a07a176df16868c007c3673a8b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/robotology/yarp/pulls/1426/commits","review_comments_url":"https://api.github.com/repos/robotology/yarp/pulls/1426/comments","review_comment_url":"https://api.github.com/repos/robotology/yarp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robotology/yarp/issues/1426/comments","statuses_url":"https://api.github.com/repos/robotology/yarp/statuses/c9155c3f3188b282bc23fea749cdae299cdebf02","head":{"label":"aerydna:pixelsizeFix","ref":"pixelsizeFix","sha":"c9155c3f3188b282bc23fea749cdae299cdebf02","user":{"login":"aerydna","id":7593650,"avatar_url":"https://avatars1.githubusercontent.com/u/7593650?v=4","gravatar_id":"","url":"https://api.github.com/users/aerydna","html_url":"https://github.com/aerydna","followers_url":"https://api.github.com/users/aerydna/followers","following_url":"https://api.github.com/users/aerydna/following{/other_user}","gists_url":"https://api.github.com/users/aerydna/gists{/gist_id}","starred_url":"https://api.github.com/users/aerydna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerydna/subscriptions","organizations_url":"https://api.github.com/users/aerydna/orgs","repos_url":"https://api.github.com/users/aerydna/repos","events_url":"https://api.github.com/users/aerydna/events{/privacy}","received_events_url":"https://api.github.com/users/aerydna/received_events","type":"User","site_admin":false},"repo":{"id":74032353,"name":"yarp","full_name":"aerydna/yarp","owner":{"login":"aerydna","id":7593650,"avatar_url":"https://avatars1.githubusercontent.com/u/7593650?v=4","gravatar_id":"","url":"https://api.github.com/users/aerydna","html_url":"https://github.com/aerydna","followers_url":"https://api.github.com/users/aerydna/followers","following_url":"https://api.github.com/users/aerydna/following{/other_user}","gists_url":"https://api.github.com/users/aerydna/gists{/gist_id}","starred_url":"https://api.github.com/users/aerydna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerydna/subscriptions","organizations_url":"https://api.github.com/users/aerydna/orgs","repos_url":"https://api.github.com/users/aerydna/repos","events_url":"https://api.github.com/users/aerydna/events{/privacy}","received_events_url":"https://api.github.com/users/aerydna/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aerydna/yarp","description":"YARP - Yet Another Robot Platform","fork":true,"url":"https://api.github.com/repos/aerydna/yarp","forks_url":"https://api.github.com/repos/aerydna/yarp/forks","keys_url":"https://api.github.com/repos/aerydna/yarp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerydna/yarp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerydna/yarp/teams","hooks_url":"https://api.github.com/repos/aerydna/yarp/hooks","issue_events_url":"https://api.github.com/repos/aerydna/yarp/issues/events{/number}","events_url":"https://api.github.com/repos/aerydna/yarp/events","assignees_url":"https://api.github.com/repos/aerydna/yarp/assignees{/user}","branches_url":"https://api.github.com/repos/aerydna/yarp/branches{/branch}","tags_url":"https://api.github.com/repos/aerydna/yarp/tags","blobs_url":"https://api.github.com/repos/aerydna/yarp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerydna/yarp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerydna/yarp/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerydna/yarp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerydna/yarp/statuses/{sha}","languages_url":"https://api.github.com/repos/aerydna/yarp/languages","stargazers_url":"https://api.github.com/repos/aerydna/yarp/stargazers","contributors_url":"https://api.github.com/repos/aerydna/yarp/contributors","subscribers_url":"https://api.github.com/repos/aerydna/yarp/subscribers","subscription_url":"https://api.github.com/repos/aerydna/yarp/subscription","commits_url":"https://api.github.com/repos/aerydna/yarp/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerydna/yarp/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerydna/yarp/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerydna/yarp/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerydna/yarp/contents/{+path}","compare_url":"https://api.github.com/repos/aerydna/yarp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerydna/yarp/merges","archive_url":"https://api.github.com/repos/aerydna/yarp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerydna/yarp/downloads","issues_url":"https://api.github.com/repos/aerydna/yarp/issues{/number}","pulls_url":"https://api.github.com/repos/aerydna/yarp/pulls{/number}","milestones_url":"https://api.github.com/repos/aerydna/yarp/milestones{/number}","notifications_url":"https://api.github.com/repos/aerydna/yarp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerydna/yarp/labels{/name}","releases_url":"https://api.github.com/repos/aerydna/yarp/releases{/id}","deployments_url":"https://api.github.com/repos/aerydna/yarp/deployments","created_at":"2016-11-17T14:02:02Z","updated_at":"2016-11-17T14:02:09Z","pushed_at":"2017-11-14T09:45:42Z","git_url":"git://github.com/aerydna/yarp.git","ssh_url":"git@github.com:aerydna/yarp.git","clone_url":"https://github.com/aerydna/yarp.git","svn_url":"https://github.com/aerydna/yarp","homepage":"http://www.yarp.it","size":62735,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"robotology:devel","ref":"devel","sha":"f3aad3ec18b862fee6d500c5e67de30c563a8ed7","user":{"login":"robotology","id":1587191,"avatar_url":"https://avatars2.githubusercontent.com/u/1587191?v=4","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"repo":{"id":9517720,"name":"yarp","full_name":"robotology/yarp","owner":{"login":"robotology","id":1587191,"avatar_url":"https://avatars2.githubusercontent.com/u/1587191?v=4","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotology/yarp","description":"YARP - Yet Another Robot Platform","fork":false,"url":"https://api.github.com/repos/robotology/yarp","forks_url":"https://api.github.com/repos/robotology/yarp/forks","keys_url":"https://api.github.com/repos/robotology/yarp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotology/yarp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotology/yarp/teams","hooks_url":"https://api.github.com/repos/robotology/yarp/hooks","issue_events_url":"https://api.github.com/repos/robotology/yarp/issues/events{/number}","events_url":"https://api.github.com/repos/robotology/yarp/events","assignees_url":"https://api.github.com/repos/robotology/yarp/assignees{/user}","branches_url":"https://api.github.com/repos/robotology/yarp/branches{/branch}","tags_url":"https://api.github.com/repos/robotology/yarp/tags","blobs_url":"https://api.github.com/repos/robotology/yarp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotology/yarp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotology/yarp/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotology/yarp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotology/yarp/statuses/{sha}","languages_url":"https://api.github.com/repos/robotology/yarp/languages","stargazers_url":"https://api.github.com/repos/robotology/yarp/stargazers","contributors_url":"https://api.github.com/repos/robotology/yarp/contributors","subscribers_url":"https://api.github.com/repos/robotology/yarp/subscribers","subscription_url":"https://api.github.com/repos/robotology/yarp/subscription","commits_url":"https://api.github.com/repos/robotology/yarp/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotology/yarp/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotology/yarp/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotology/yarp/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotology/yarp/contents/{+path}","compare_url":"https://api.github.com/repos/robotology/yarp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotology/yarp/merges","archive_url":"https://api.github.com/repos/robotology/yarp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotology/yarp/downloads","issues_url":"https://api.github.com/repos/robotology/yarp/issues{/number}","pulls_url":"https://api.github.com/repos/robotology/yarp/pulls{/number}","milestones_url":"https://api.github.com/repos/robotology/yarp/milestones{/number}","notifications_url":"https://api.github.com/repos/robotology/yarp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotology/yarp/labels{/name}","releases_url":"https://api.github.com/repos/robotology/yarp/releases{/id}","deployments_url":"https://api.github.com/repos/robotology/yarp/deployments","created_at":"2013-04-18T09:13:24Z","updated_at":"2017-11-15T16:32:01Z","pushed_at":"2017-11-14T09:45:43Z","git_url":"git://github.com/robotology/yarp.git","ssh_url":"git@github.com:robotology/yarp.git","clone_url":"https://github.com/robotology/yarp.git","svn_url":"https://github.com/robotology/yarp","homepage":"http://www.yarp.it","size":62724,"stargazers_count":159,"watchers_count":159,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":180,"forks":87,"open_issues":180,"watchers":159,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1426"},"html":{"href":"https://github.com/robotology/yarp/pull/1426"},"issue":{"href":"https://api.github.com/repos/robotology/yarp/issues/1426"},"comments":{"href":"https://api.github.com/repos/robotology/yarp/issues/1426/comments"},"review_comments":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1426/comments"},"review_comment":{"href":"https://api.github.com/repos/robotology/yarp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robotology/yarp/pulls/1426/commits"},"statuses":{"href":"https://api.github.com/repos/robotology/yarp/statuses/c9155c3f3188b282bc23fea749cdae299cdebf02"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"barbalberto"}}