{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/pulls/comments/138960144","pull_request_review_id":62824490,"id":138960144,"diff_hunk":"@@ -0,0 +1,37 @@\n+\"\"\"Contains a convenient wrapper over `subprocess.check_output`.\"\"\"\n+from subprocess import PIPE, Popen\n+\n+\n+class CallError(Exception):\n+    \"\"\"Represents a call error.\"\"\"\n+    pass\n+\n+\n+def _call(args, **kwargs):\n+    proc = Popen(args, stdout=PIPE, stderr=PIPE, **kwargs)\n+    stdoutdata, stderrdata = proc.communicate()\n+    return (proc.returncode, stdoutdata.decode('utf-8'),\n+            stderrdata.decode('utf-8'))\n+\n+\n+def check_output(args, **kwargs):\n+    \"\"\"A convenient version of `subprocess.check_output`.","path":"server/tasks/_check_output.py","position":18,"original_position":18,"commit_id":"b27d55fbc3bb42da9df20316ad272596adcc0683","original_commit_id":"b27d55fbc3bb42da9df20316ad272596adcc0683","user":{"login":"vchudnov-g","id":5422149,"avatar_url":"https://avatars3.githubusercontent.com/u/5422149?v=4","gravatar_id":"","url":"https://api.github.com/users/vchudnov-g","html_url":"https://github.com/vchudnov-g","followers_url":"https://api.github.com/users/vchudnov-g/followers","following_url":"https://api.github.com/users/vchudnov-g/following{/other_user}","gists_url":"https://api.github.com/users/vchudnov-g/gists{/gist_id}","starred_url":"https://api.github.com/users/vchudnov-g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vchudnov-g/subscriptions","organizations_url":"https://api.github.com/users/vchudnov-g/orgs","repos_url":"https://api.github.com/users/vchudnov-g/repos","events_url":"https://api.github.com/users/vchudnov-g/events{/privacy}","received_events_url":"https://api.github.com/users/vchudnov-g/received_events","type":"User","site_admin":false},"body":"Suggested enhancement for readability:\r\nSplit `args[0]` on spaces and replace it with the resulting list. This allows  common invocations like `check_output([\"dosomething myarg yourarg\"])`\r\n\r\nFor situations where the arguments may themselves contain spaces, this still allows the current usage: `check_output([\"dosomething myarg\"] [\"your arg\"])`\r\n","created_at":"2017-09-14T17:31:27Z","updated_at":"2017-09-14T17:31:47Z","html_url":"https://github.com/googleapis/discovery-artifact-manager/pull/62#discussion_r138960144","pull_request_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/pulls/62","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/discovery-artifact-manager/pulls/comments/138960144"},"html":{"href":"https://github.com/googleapis/discovery-artifact-manager/pull/62#discussion_r138960144"},"pull_request":{"href":"https://api.github.com/repos/googleapis/discovery-artifact-manager/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/pulls/62","id":140663241,"html_url":"https://github.com/googleapis/discovery-artifact-manager/pull/62","diff_url":"https://github.com/googleapis/discovery-artifact-manager/pull/62.diff","patch_url":"https://github.com/googleapis/discovery-artifact-manager/pull/62.patch","issue_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/issues/62","number":62,"state":"open","locked":false,"title":"Add _check_output module","user":{"login":"saicheems","id":2468087,"avatar_url":"https://avatars2.githubusercontent.com/u/2468087?v=4","gravatar_id":"","url":"https://api.github.com/users/saicheems","html_url":"https://github.com/saicheems","followers_url":"https://api.github.com/users/saicheems/followers","following_url":"https://api.github.com/users/saicheems/following{/other_user}","gists_url":"https://api.github.com/users/saicheems/gists{/gist_id}","starred_url":"https://api.github.com/users/saicheems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saicheems/subscriptions","organizations_url":"https://api.github.com/users/saicheems/orgs","repos_url":"https://api.github.com/users/saicheems/repos","events_url":"https://api.github.com/users/saicheems/events{/privacy}","received_events_url":"https://api.github.com/users/saicheems/received_events","type":"User","site_admin":false},"body":"Contains a convenient wrapper over `subprocess.check_output` which\r\nraises a nice exception containing stdout and stderr information on\r\nfailure.","created_at":"2017-09-12T19:26:17Z","updated_at":"2017-09-14T17:31:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6cf4177556aadc6b93434a865d0b6231da1f9e0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/pulls/62/commits","review_comments_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/pulls/62/comments","review_comment_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/issues/62/comments","statuses_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/statuses/b27d55fbc3bb42da9df20316ad272596adcc0683","head":{"label":"saicheems:server3","ref":"server3","sha":"b27d55fbc3bb42da9df20316ad272596adcc0683","user":{"login":"saicheems","id":2468087,"avatar_url":"https://avatars2.githubusercontent.com/u/2468087?v=4","gravatar_id":"","url":"https://api.github.com/users/saicheems","html_url":"https://github.com/saicheems","followers_url":"https://api.github.com/users/saicheems/followers","following_url":"https://api.github.com/users/saicheems/following{/other_user}","gists_url":"https://api.github.com/users/saicheems/gists{/gist_id}","starred_url":"https://api.github.com/users/saicheems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saicheems/subscriptions","organizations_url":"https://api.github.com/users/saicheems/orgs","repos_url":"https://api.github.com/users/saicheems/repos","events_url":"https://api.github.com/users/saicheems/events{/privacy}","received_events_url":"https://api.github.com/users/saicheems/received_events","type":"User","site_admin":false},"repo":{"id":88122808,"name":"discovery-artifact-manager","full_name":"saicheems/discovery-artifact-manager","owner":{"login":"saicheems","id":2468087,"avatar_url":"https://avatars2.githubusercontent.com/u/2468087?v=4","gravatar_id":"","url":"https://api.github.com/users/saicheems","html_url":"https://github.com/saicheems","followers_url":"https://api.github.com/users/saicheems/followers","following_url":"https://api.github.com/users/saicheems/following{/other_user}","gists_url":"https://api.github.com/users/saicheems/gists{/gist_id}","starred_url":"https://api.github.com/users/saicheems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saicheems/subscriptions","organizations_url":"https://api.github.com/users/saicheems/orgs","repos_url":"https://api.github.com/users/saicheems/repos","events_url":"https://api.github.com/users/saicheems/events{/privacy}","received_events_url":"https://api.github.com/users/saicheems/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/saicheems/discovery-artifact-manager","description":null,"fork":true,"url":"https://api.github.com/repos/saicheems/discovery-artifact-manager","forks_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/forks","keys_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/teams","hooks_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/hooks","issue_events_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/issues/events{/number}","events_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/events","assignees_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/assignees{/user}","branches_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/branches{/branch}","tags_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/tags","blobs_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/languages","stargazers_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/stargazers","contributors_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/contributors","subscribers_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/subscribers","subscription_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/subscription","commits_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/contents/{+path}","compare_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/merges","archive_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/downloads","issues_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/issues{/number}","pulls_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/labels{/name}","releases_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/releases{/id}","deployments_url":"https://api.github.com/repos/saicheems/discovery-artifact-manager/deployments","created_at":"2017-04-13T03:49:39Z","updated_at":"2017-04-13T03:49:56Z","pushed_at":"2017-09-13T22:07:00Z","git_url":"git://github.com/saicheems/discovery-artifact-manager.git","ssh_url":"git@github.com:saicheems/discovery-artifact-manager.git","clone_url":"https://github.com/saicheems/discovery-artifact-manager.git","svn_url":"https://github.com/saicheems/discovery-artifact-manager","homepage":null,"size":71224,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"3291a6aa2dbdb98bf4fa2595510d714f2e322990","user":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":72768841,"name":"discovery-artifact-manager","full_name":"googleapis/discovery-artifact-manager","owner":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleapis/discovery-artifact-manager","description":null,"fork":false,"url":"https://api.github.com/repos/googleapis/discovery-artifact-manager","forks_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/forks","keys_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/teams","hooks_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/hooks","issue_events_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/events","assignees_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/tags","blobs_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/languages","stargazers_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/stargazers","contributors_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/contributors","subscribers_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/subscribers","subscription_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/subscription","commits_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/merges","archive_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/downloads","issues_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/discovery-artifact-manager/deployments","created_at":"2016-11-03T17:17:02Z","updated_at":"2017-07-25T11:19:15Z","pushed_at":"2017-09-14T17:00:25Z","git_url":"git://github.com/googleapis/discovery-artifact-manager.git","ssh_url":"git@github.com:googleapis/discovery-artifact-manager.git","clone_url":"https://github.com/googleapis/discovery-artifact-manager.git","svn_url":"https://github.com/googleapis/discovery-artifact-manager","homepage":null,"size":42835,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/discovery-artifact-manager/pulls/62"},"html":{"href":"https://github.com/googleapis/discovery-artifact-manager/pull/62"},"issue":{"href":"https://api.github.com/repos/googleapis/discovery-artifact-manager/issues/62"},"comments":{"href":"https://api.github.com/repos/googleapis/discovery-artifact-manager/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/discovery-artifact-manager/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/discovery-artifact-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/discovery-artifact-manager/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/discovery-artifact-manager/statuses/b27d55fbc3bb42da9df20316ad272596adcc0683"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vchudnov-g"}}