{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4596","repository_url":"https://api.github.com/repos/dolphin-emu/dolphin","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4596/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4596/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4596/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/4596","id":198399302,"number":4596,"title":"AVIDump: Updates to avoid deprecation warnings","user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars.githubusercontent.com/u/594093?v=3","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-01-03T01:52:48Z","updated_at":"2017-01-21T18:17:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/4596","html_url":"https://github.com/dolphin-emu/dolphin/pull/4596","diff_url":"https://github.com/dolphin-emu/dolphin/pull/4596.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/4596.patch"},"body":"On current master, compiling with FFmpeg 3.2.1 on macOS results in a lot of warnings like:\r\n\r\n```\r\n/Users/michaelmaltese/Downloads/dolphin/Source/Core/VideoCommon/AVIDump.cpp:224:51: warning: 'codec' is deprecated [-Wdeprecated-declarations]\r\n  s_scaled_frame->pts = (pts_in_ticks * s_stream->codec->time_base.den) / state.ticks_per_second;\r\n                                                  ^\r\n/usr/local/Cellar/ffmpeg/3.2.1/include/libavformat/avformat.h:893:21: note: 'codec' has been explicitly marked deprecated here\r\n    AVCodecContext *codec;\r\n                    ^\r\n/Users/michaelmaltese/Downloads/dolphin/Source/Core/VideoCommon/AVIDump.cpp:229:45: warning: 'codec' is deprecated [-Wdeprecated-declarations]\r\n    error = avcodec_encode_video2(s_stream->codec, &pkt, s_scaled_frame, &got_packet);\r\n                                            ^\r\n/usr/local/Cellar/ffmpeg/3.2.1/include/libavformat/avformat.h:893:21: note: 'codec' has been explicitly marked deprecated here\r\n    AVCodecContext *codec;\r\n```\r\n\r\nThis commit batch fixes the warnings, and should still be compatible with older versions of FFmpeg."},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/274278431","html_url":"https://github.com/dolphin-emu/dolphin/pull/4596#issuecomment-274278431","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/4596","id":274278431,"user":{"login":"ligfx","id":594093,"avatar_url":"https://avatars.githubusercontent.com/u/594093?v=3","gravatar_id":"","url":"https://api.github.com/users/ligfx","html_url":"https://github.com/ligfx","followers_url":"https://api.github.com/users/ligfx/followers","following_url":"https://api.github.com/users/ligfx/following{/other_user}","gists_url":"https://api.github.com/users/ligfx/gists{/gist_id}","starred_url":"https://api.github.com/users/ligfx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligfx/subscriptions","organizations_url":"https://api.github.com/users/ligfx/orgs","repos_url":"https://api.github.com/users/ligfx/repos","events_url":"https://api.github.com/users/ligfx/events{/privacy}","received_events_url":"https://api.github.com/users/ligfx/received_events","type":"User","site_admin":false},"created_at":"2017-01-21T18:17:26Z","updated_at":"2017-01-21T18:17:26Z","body":"Just for reference, before the previous synchronization, FifoCI results were:\r\n\r\n> FifoCI detected that this change impacts graphical rendering. Here are the behavior differences detected by the system:\r\n>\r\n> fifa-street on sw-lin-mesa: diff\r\nfortune-street on sw-lin-mesa: diff\r\nfortune-street-fog on sw-lin-mesa: diff\r\nluigi-shadows on sw-lin-mesa: diff\r\nmilotic-texture on sw-lin-mesa: diff\r\nmonkeyball-fuse on sw-lin-mesa: diff\r\nnfsu-purplerect on sw-lin-mesa: diff\r\nnfsu-reflections on sw-lin-mesa: diff\r\nsadx-ui on sw-lin-mesa: diff\r\nsoa-black on sw-lin-mesa: diff\r\nsuper-sluggers-white-out on sw-lin-mesa: diff\r\nzww-water on sw-lin-mesa: diff"}}
{"actor":{"display_login":"ligfx"}}