{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/pulls/2","id":152058835,"html_url":"https://github.com/hiulit/es-fun-facts-splashscreens/pull/2","diff_url":"https://github.com/hiulit/es-fun-facts-splashscreens/pull/2.diff","patch_url":"https://github.com/hiulit/es-fun-facts-splashscreens/pull/2.patch","issue_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/issues/2","number":2,"state":"closed","locked":false,"title":"2nd revision","user":{"login":"meleu","id":8508804,"avatar_url":"https://avatars0.githubusercontent.com/u/8508804?v=4","gravatar_id":"","url":"https://api.github.com/users/meleu","html_url":"https://github.com/meleu","followers_url":"https://api.github.com/users/meleu/followers","following_url":"https://api.github.com/users/meleu/following{/other_user}","gists_url":"https://api.github.com/users/meleu/gists{/gist_id}","starred_url":"https://api.github.com/users/meleu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meleu/subscriptions","organizations_url":"https://api.github.com/users/meleu/orgs","repos_url":"https://api.github.com/users/meleu/repos","events_url":"https://api.github.com/users/meleu/events{/privacy}","received_events_url":"https://api.github.com/users/meleu/received_events","type":"User","site_admin":false},"body":"Again: **THIS CODE WASN'T TESTED!** Test it before merging.\r\n\r\n- renamed `ES_DIR` to `ES_THEMES_DIR` and added a trailing `/themes` to its content.\r\n\r\n- renamed `get_theme_font()` to `get_font()`.\r\n\r\n- moved all logic to get the font to `get_font()`. Included your suggestion to `find` ttf files. ;-)\r\n\r\n- removed `DEFAULT_FONT`. The same goal is achieved by getting the font of carbon theme.\r\n\r\n- tweaked the `get_current_theme()` to be a sed oneliner. By the way, I was wrong [on my comment about your RegEx](https://retropie.org.uk/forum/post/117357). You need to match `^.*` to achieve your goal. Then your regex is perfect. ;)","created_at":"2017-11-11T14:16:58Z","updated_at":"2017-11-11T14:21:24Z","closed_at":"2017-11-11T14:21:24Z","merged_at":null,"merge_commit_sha":"24a3b35d22c1aa0e857e45ad4a60e9e8f15a27c6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/pulls/2/commits","review_comments_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/pulls/2/comments","review_comment_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/issues/2/comments","statuses_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/statuses/f2ea440de2d1bb8dd99a572b8bfc8a417bbcae5f","head":{"label":"meleu:patch-2","ref":"patch-2","sha":"f2ea440de2d1bb8dd99a572b8bfc8a417bbcae5f","user":{"login":"meleu","id":8508804,"avatar_url":"https://avatars0.githubusercontent.com/u/8508804?v=4","gravatar_id":"","url":"https://api.github.com/users/meleu","html_url":"https://github.com/meleu","followers_url":"https://api.github.com/users/meleu/followers","following_url":"https://api.github.com/users/meleu/following{/other_user}","gists_url":"https://api.github.com/users/meleu/gists{/gist_id}","starred_url":"https://api.github.com/users/meleu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meleu/subscriptions","organizations_url":"https://api.github.com/users/meleu/orgs","repos_url":"https://api.github.com/users/meleu/repos","events_url":"https://api.github.com/users/meleu/events{/privacy}","received_events_url":"https://api.github.com/users/meleu/received_events","type":"User","site_admin":false},"repo":{"id":110247074,"name":"es-fun-facts-splashscreens","full_name":"meleu/es-fun-facts-splashscreens","owner":{"login":"meleu","id":8508804,"avatar_url":"https://avatars0.githubusercontent.com/u/8508804?v=4","gravatar_id":"","url":"https://api.github.com/users/meleu","html_url":"https://github.com/meleu","followers_url":"https://api.github.com/users/meleu/followers","following_url":"https://api.github.com/users/meleu/following{/other_user}","gists_url":"https://api.github.com/users/meleu/gists{/gist_id}","starred_url":"https://api.github.com/users/meleu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meleu/subscriptions","organizations_url":"https://api.github.com/users/meleu/orgs","repos_url":"https://api.github.com/users/meleu/repos","events_url":"https://api.github.com/users/meleu/events{/privacy}","received_events_url":"https://api.github.com/users/meleu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meleu/es-fun-facts-splashscreens","description":null,"fork":true,"url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens","forks_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/forks","keys_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/teams","hooks_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/hooks","issue_events_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/issues/events{/number}","events_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/events","assignees_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/assignees{/user}","branches_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/branches{/branch}","tags_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/tags","blobs_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/git/refs{/sha}","trees_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/statuses/{sha}","languages_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/languages","stargazers_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/stargazers","contributors_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/contributors","subscribers_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/subscribers","subscription_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/subscription","commits_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/commits{/sha}","git_commits_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/git/commits{/sha}","comments_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/comments{/number}","issue_comment_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/issues/comments{/number}","contents_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/contents/{+path}","compare_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/merges","archive_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/downloads","issues_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/issues{/number}","pulls_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/pulls{/number}","milestones_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/milestones{/number}","notifications_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/labels{/name}","releases_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/releases{/id}","deployments_url":"https://api.github.com/repos/meleu/es-fun-facts-splashscreens/deployments","created_at":"2017-11-10T12:57:04Z","updated_at":"2017-11-10T12:57:06Z","pushed_at":"2017-11-11T14:14:29Z","git_url":"git://github.com/meleu/es-fun-facts-splashscreens.git","ssh_url":"git@github.com:meleu/es-fun-facts-splashscreens.git","clone_url":"https://github.com/meleu/es-fun-facts-splashscreens.git","svn_url":"https://github.com/meleu/es-fun-facts-splashscreens","homepage":null,"size":23,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hiulit:master","ref":"master","sha":"e68203e3030cc1f7a4f90a33c5603f16c375cf8e","user":{"login":"hiulit","id":481475,"avatar_url":"https://avatars0.githubusercontent.com/u/481475?v=4","gravatar_id":"","url":"https://api.github.com/users/hiulit","html_url":"https://github.com/hiulit","followers_url":"https://api.github.com/users/hiulit/followers","following_url":"https://api.github.com/users/hiulit/following{/other_user}","gists_url":"https://api.github.com/users/hiulit/gists{/gist_id}","starred_url":"https://api.github.com/users/hiulit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiulit/subscriptions","organizations_url":"https://api.github.com/users/hiulit/orgs","repos_url":"https://api.github.com/users/hiulit/repos","events_url":"https://api.github.com/users/hiulit/events{/privacy}","received_events_url":"https://api.github.com/users/hiulit/received_events","type":"User","site_admin":false},"repo":{"id":109998994,"name":"es-fun-facts-splashscreens","full_name":"hiulit/es-fun-facts-splashscreens","owner":{"login":"hiulit","id":481475,"avatar_url":"https://avatars0.githubusercontent.com/u/481475?v=4","gravatar_id":"","url":"https://api.github.com/users/hiulit","html_url":"https://github.com/hiulit","followers_url":"https://api.github.com/users/hiulit/followers","following_url":"https://api.github.com/users/hiulit/following{/other_user}","gists_url":"https://api.github.com/users/hiulit/gists{/gist_id}","starred_url":"https://api.github.com/users/hiulit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiulit/subscriptions","organizations_url":"https://api.github.com/users/hiulit/orgs","repos_url":"https://api.github.com/users/hiulit/repos","events_url":"https://api.github.com/users/hiulit/events{/privacy}","received_events_url":"https://api.github.com/users/hiulit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hiulit/es-fun-facts-splashscreens","description":null,"fork":false,"url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens","forks_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/forks","keys_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/teams","hooks_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/hooks","issue_events_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/issues/events{/number}","events_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/events","assignees_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/assignees{/user}","branches_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/branches{/branch}","tags_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/tags","blobs_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/git/refs{/sha}","trees_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/statuses/{sha}","languages_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/languages","stargazers_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/stargazers","contributors_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/contributors","subscribers_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/subscribers","subscription_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/subscription","commits_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/commits{/sha}","git_commits_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/git/commits{/sha}","comments_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/comments{/number}","issue_comment_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/issues/comments{/number}","contents_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/contents/{+path}","compare_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/merges","archive_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/downloads","issues_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/issues{/number}","pulls_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/pulls{/number}","milestones_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/milestones{/number}","notifications_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/labels{/name}","releases_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/releases{/id}","deployments_url":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/deployments","created_at":"2017-11-08T16:11:50Z","updated_at":"2017-11-08T16:13:34Z","pushed_at":"2017-11-11T14:16:58Z","git_url":"git://github.com/hiulit/es-fun-facts-splashscreens.git","ssh_url":"git@github.com:hiulit/es-fun-facts-splashscreens.git","clone_url":"https://github.com/hiulit/es-fun-facts-splashscreens.git","svn_url":"https://github.com/hiulit/es-fun-facts-splashscreens","homepage":null,"size":24,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/pulls/2"},"html":{"href":"https://github.com/hiulit/es-fun-facts-splashscreens/pull/2"},"issue":{"href":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/issues/2"},"comments":{"href":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/hiulit/es-fun-facts-splashscreens/statuses/f2ea440de2d1bb8dd99a572b8bfc8a417bbcae5f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":25,"deletions":22,"changed_files":1}}
{"actor":{"display_login":"meleu"}}