{"action":"opened","number":16459,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/16459","id":123833450,"html_url":"https://github.com/joomla/joomla-cms/pull/16459","diff_url":"https://github.com/joomla/joomla-cms/pull/16459.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/16459.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/16459","number":16459,"state":"open","locked":false,"title":"modal_menu: Displaying the correct placeholder from the option","user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars0.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue https://github.com/joomla/joomla-cms/issues/16421\r\n\r\n### Summary of Changes\r\nAdding conditionals to display the default placeholder with null value defined in the field Option\r\n\r\n### Testing Instructions\r\nEdit an item which contains a choice for a menu item field using the `modal_menu` type.\r\n\r\n1. Creating a `Menu Item Alias`. Choosing the menu item to alias to.\r\n2. Creating a `Create Article` menu item. Choosing the menu item `Submission Redirect` in Options.\r\n3. Creating a `Login Form` menu item. Choosing the `Menu Item Login Redirect` and `Menu Item Logout Redirect` in the Options.\r\n4. Creating a `Logout` menu item. Choosing the `Logout Redirection Page` in the Options.\r\n5. Editing the Site `Login Form` module. Choosing the `Login Redirection Page` and the `Logout Redirection Page`.\r\n6. Editing the Site `Menu` module. Choosing the `Base Item`.\r\n\r\nThe xml code for the `Menu` module is for example\r\n```\r\n\t\t\t\t<field\r\n\t\t\t\t\tname=\"base\"\r\n\t\t\t\t\ttype=\"modal_menu\"\r\n\t\t\t\t\tlabel=\"MOD_MENU_FIELD_ACTIVE_LABEL\"\r\n\t\t\t\t\tdescription=\"MOD_MENU_FIELD_ACTIVE_DESC\"\r\n\t\t\t\t\tselect=\"true\"\r\n\t\t\t\t\tnew=\"true\"\r\n\t\t\t\t\tedit=\"true\"\r\n\t\t\t\t\tclear=\"true\"\r\n\t\t\t\t\t>\r\n\t\t\t\t\t<option value=\"\">JCURRENT</option>\r\n\t\t\t\t</field>\r\n```\r\n\r\nIn each case, select a menu item in the modal. Then `Clear` that menu item.\r\n\r\n\r\n### Expected result for the placeholder value\r\n1. `Select a Menu Item`\r\n2. `Default`\r\n3. `Default` for both\r\n4. `Default`\r\n5. `Default` for both\r\n6. `Current`\r\n\r\n\r\n### Actual result\r\nAll have `Select a Menu Item`\r\n\r\n\r\nPatch and test again. Do not forget to choose a menu item and Clear to confirm that the correct value is displayed.\r\n\r\nHere is an example —after patch— concerning the original issue with `Menu` module.\r\n\r\n![menumodalfield](https://cloud.githubusercontent.com/assets/869724/26751661/f444a976-483e-11e7-9bf6-3c7af0c96951.gif)\r\n\r\n@epidote\r\n\r\n","created_at":"2017-06-03T07:32:26Z","updated_at":"2017-06-03T07:32:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/16459/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/16459/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/16459/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/113c3740c02d9b18725b7568e37a26901825f6e9","head":{"label":"infograf768:menu_modal_option","ref":"menu_modal_option","sha":"113c3740c02d9b18725b7568e37a26901825f6e9","user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars0.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"repo":{"id":3025712,"name":"joomla-cms","full_name":"infograf768/joomla-cms","owner":{"login":"infograf768","id":869724,"avatar_url":"https://avatars0.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/infograf768/joomla-cms","description":"Fork of the Joomla! CMS","fork":true,"url":"https://api.github.com/repos/infograf768/joomla-cms","forks_url":"https://api.github.com/repos/infograf768/joomla-cms/forks","keys_url":"https://api.github.com/repos/infograf768/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infograf768/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infograf768/joomla-cms/teams","hooks_url":"https://api.github.com/repos/infograf768/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/infograf768/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/infograf768/joomla-cms/events","assignees_url":"https://api.github.com/repos/infograf768/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/infograf768/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/infograf768/joomla-cms/tags","blobs_url":"https://api.github.com/repos/infograf768/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infograf768/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infograf768/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/infograf768/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infograf768/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/infograf768/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/infograf768/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/infograf768/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/infograf768/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/infograf768/joomla-cms/subscription","commits_url":"https://api.github.com/repos/infograf768/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/infograf768/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/infograf768/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/infograf768/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/infograf768/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/infograf768/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infograf768/joomla-cms/merges","archive_url":"https://api.github.com/repos/infograf768/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infograf768/joomla-cms/downloads","issues_url":"https://api.github.com/repos/infograf768/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/infograf768/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/infograf768/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/infograf768/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infograf768/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/infograf768/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/infograf768/joomla-cms/deployments","created_at":"2011-12-21T08:55:33Z","updated_at":"2016-02-15T02:03:35Z","pushed_at":"2017-06-03T06:51:25Z","git_url":"git://github.com/infograf768/joomla-cms.git","ssh_url":"git@github.com:infograf768/joomla-cms.git","clone_url":"https://github.com/infograf768/joomla-cms.git","svn_url":"https://github.com/infograf768/joomla-cms","homepage":"http://joomla.org","size":181259,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"joomla:staging","ref":"staging","sha":"3f15a2dfcd5149cbd1b769cf6854871d89827bc9","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2017-06-02T17:01:56Z","pushed_at":"2017-06-03T07:22:09Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":195244,"stargazers_count":2388,"watchers_count":2388,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2491,"mirror_url":null,"open_issues_count":814,"forks":2491,"open_issues":814,"watchers":2388,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/16459"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/16459"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/16459"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/16459/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/16459/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/16459/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/113c3740c02d9b18725b7568e37a26901825f6e9"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":29,"deletions":6,"changed_files":1}}
{"actor":{"display_login":"infograf768"}}