{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/17","id":150313999,"html_url":"https://github.com/LedgerHQ/ledger-vault-front/pull/17","diff_url":"https://github.com/LedgerHQ/ledger-vault-front/pull/17.diff","patch_url":"https://github.com/LedgerHQ/ledger-vault-front/pull/17.patch","issue_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/17","number":17,"state":"closed","locked":false,"title":"notification system draft","user":{"login":"flocks","id":944835,"avatar_url":"https://avatars2.githubusercontent.com/u/944835?v=4","gravatar_id":"","url":"https://api.github.com/users/flocks","html_url":"https://github.com/flocks","followers_url":"https://api.github.com/users/flocks/followers","following_url":"https://api.github.com/users/flocks/following{/other_user}","gists_url":"https://api.github.com/users/flocks/gists{/gist_id}","starred_url":"https://api.github.com/users/flocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flocks/subscriptions","organizations_url":"https://api.github.com/users/flocks/orgs","repos_url":"https://api.github.com/users/flocks/repos","events_url":"https://api.github.com/users/flocks/events{/privacy}","received_events_url":"https://api.github.com/users/flocks/received_events","type":"User","site_admin":false},"body":"[DO NOT MERGE]\r\n\r\nThis is a draft of our generic notification ( alerts ) system.  The `data` store dispatch the `api-spec` object alongside with the `DATA_FETCH` event.  The `alerts` store listen to `DATA_FETCH` and check if the HTTP method is PUT/POST/DELETE ( because we obviously don't want a notification for every single GET request ). Based on the request type and the resource, it provides a title/message to the AlertsContainer component.\r\n\r\nWhat do you think of this approach ?","created_at":"2017-11-02T14:56:16Z","updated_at":"2017-11-03T10:54:25Z","closed_at":"2017-11-03T10:54:25Z","merged_at":"2017-11-03T10:54:25Z","merge_commit_sha":"27f4dc7fea8bf22c8e29336e733e060fdad710c2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/17/commits","review_comments_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/17/comments","review_comment_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/17/comments","statuses_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/statuses/2217a8775756e4f7f08a4b0680415253a2bd2046","head":{"label":"LedgerHQ:feature_notif_system","ref":"feature_notif_system","sha":"2217a8775756e4f7f08a4b0680415253a2bd2046","user":{"login":"LedgerHQ","id":9784193,"avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":92170617,"name":"ledger-vault-front","full_name":"LedgerHQ/ledger-vault-front","owner":{"login":"LedgerHQ","id":9784193,"avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LedgerHQ/ledger-vault-front","description":null,"fork":false,"url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front","forks_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/forks","keys_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/teams","hooks_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/hooks","issue_events_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/events{/number}","events_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/events","assignees_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/assignees{/user}","branches_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/branches{/branch}","tags_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/tags","blobs_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/refs{/sha}","trees_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/statuses/{sha}","languages_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/languages","stargazers_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/stargazers","contributors_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/contributors","subscribers_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/subscribers","subscription_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/subscription","commits_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/commits{/sha}","git_commits_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/commits{/sha}","comments_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/comments{/number}","issue_comment_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/comments{/number}","contents_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/contents/{+path}","compare_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/merges","archive_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/downloads","issues_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues{/number}","pulls_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls{/number}","milestones_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/milestones{/number}","notifications_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/labels{/name}","releases_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/releases{/id}","deployments_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/deployments","created_at":"2017-05-23T12:31:49Z","updated_at":"2017-10-25T15:53:45Z","pushed_at":"2017-11-03T10:54:25Z","git_url":"git://github.com/LedgerHQ/ledger-vault-front.git","ssh_url":"git@github.com:LedgerHQ/ledger-vault-front.git","clone_url":"https://github.com/LedgerHQ/ledger-vault-front.git","svn_url":"https://github.com/LedgerHQ/ledger-vault-front","homepage":null,"size":1577,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"LedgerHQ:develop","ref":"develop","sha":"cae38fac0ef93cb343af68ab99286cbfd284b2ee","user":{"login":"LedgerHQ","id":9784193,"avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"repo":{"id":92170617,"name":"ledger-vault-front","full_name":"LedgerHQ/ledger-vault-front","owner":{"login":"LedgerHQ","id":9784193,"avatar_url":"https://avatars1.githubusercontent.com/u/9784193?v=4","gravatar_id":"","url":"https://api.github.com/users/LedgerHQ","html_url":"https://github.com/LedgerHQ","followers_url":"https://api.github.com/users/LedgerHQ/followers","following_url":"https://api.github.com/users/LedgerHQ/following{/other_user}","gists_url":"https://api.github.com/users/LedgerHQ/gists{/gist_id}","starred_url":"https://api.github.com/users/LedgerHQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LedgerHQ/subscriptions","organizations_url":"https://api.github.com/users/LedgerHQ/orgs","repos_url":"https://api.github.com/users/LedgerHQ/repos","events_url":"https://api.github.com/users/LedgerHQ/events{/privacy}","received_events_url":"https://api.github.com/users/LedgerHQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LedgerHQ/ledger-vault-front","description":null,"fork":false,"url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front","forks_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/forks","keys_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/teams","hooks_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/hooks","issue_events_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/events{/number}","events_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/events","assignees_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/assignees{/user}","branches_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/branches{/branch}","tags_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/tags","blobs_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/refs{/sha}","trees_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/statuses/{sha}","languages_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/languages","stargazers_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/stargazers","contributors_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/contributors","subscribers_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/subscribers","subscription_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/subscription","commits_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/commits{/sha}","git_commits_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/git/commits{/sha}","comments_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/comments{/number}","issue_comment_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/comments{/number}","contents_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/contents/{+path}","compare_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/merges","archive_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/downloads","issues_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues{/number}","pulls_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls{/number}","milestones_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/milestones{/number}","notifications_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/labels{/name}","releases_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/releases{/id}","deployments_url":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/deployments","created_at":"2017-05-23T12:31:49Z","updated_at":"2017-10-25T15:53:45Z","pushed_at":"2017-11-03T10:54:25Z","git_url":"git://github.com/LedgerHQ/ledger-vault-front.git","ssh_url":"git@github.com:LedgerHQ/ledger-vault-front.git","clone_url":"https://github.com/LedgerHQ/ledger-vault-front.git","svn_url":"https://github.com/LedgerHQ/ledger-vault-front","homepage":null,"size":1577,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/17"},"html":{"href":"https://github.com/LedgerHQ/ledger-vault-front/pull/17"},"issue":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/17"},"comments":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/LedgerHQ/ledger-vault-front/statuses/2217a8775756e4f7f08a4b0680415253a2bd2046"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"flocks","id":944835,"avatar_url":"https://avatars2.githubusercontent.com/u/944835?v=4","gravatar_id":"","url":"https://api.github.com/users/flocks","html_url":"https://github.com/flocks","followers_url":"https://api.github.com/users/flocks/followers","following_url":"https://api.github.com/users/flocks/following{/other_user}","gists_url":"https://api.github.com/users/flocks/gists{/gist_id}","starred_url":"https://api.github.com/users/flocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flocks/subscriptions","organizations_url":"https://api.github.com/users/flocks/orgs","repos_url":"https://api.github.com/users/flocks/repos","events_url":"https://api.github.com/users/flocks/events{/privacy}","received_events_url":"https://api.github.com/users/flocks/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":92,"deletions":176,"changed_files":5}}
{"actor":{"display_login":"flocks"}}