{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/660","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/660/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/660/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/660/events","html_url":"https://github.com/WordPress/gutenberg/pull/660","id":226260170,"number":660,"title":"Try position sticky for undocking toolbars","user":{"login":"jasmussen","id":1204802,"avatar_url":"https://avatars0.githubusercontent.com/u/1204802?v=3","gravatar_id":"","url":"https://api.github.com/users/jasmussen","html_url":"https://github.com/jasmussen","followers_url":"https://api.github.com/users/jasmussen/followers","following_url":"https://api.github.com/users/jasmussen/following{/other_user}","gists_url":"https://api.github.com/users/jasmussen/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmussen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmussen/subscriptions","organizations_url":"https://api.github.com/users/jasmussen/orgs","repos_url":"https://api.github.com/users/jasmussen/repos","events_url":"https://api.github.com/users/jasmussen/events{/privacy}","received_events_url":"https://api.github.com/users/jasmussen/received_events","type":"User","site_admin":false},"labels":[{"id":531680825,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"c5def5","default":false},{"id":531680828,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Type]%20Question","name":"[Type] Question","color":"cc317c","default":false}],"state":"open","locked":false,"assignee":{"login":"jasmussen","id":1204802,"avatar_url":"https://avatars0.githubusercontent.com/u/1204802?v=3","gravatar_id":"","url":"https://api.github.com/users/jasmussen","html_url":"https://github.com/jasmussen","followers_url":"https://api.github.com/users/jasmussen/followers","following_url":"https://api.github.com/users/jasmussen/following{/other_user}","gists_url":"https://api.github.com/users/jasmussen/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmussen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmussen/subscriptions","organizations_url":"https://api.github.com/users/jasmussen/orgs","repos_url":"https://api.github.com/users/jasmussen/repos","events_url":"https://api.github.com/users/jasmussen/events{/privacy}","received_events_url":"https://api.github.com/users/jasmussen/received_events","type":"User","site_admin":false},"assignees":[{"login":"jasmussen","id":1204802,"avatar_url":"https://avatars0.githubusercontent.com/u/1204802?v=3","gravatar_id":"","url":"https://api.github.com/users/jasmussen","html_url":"https://github.com/jasmussen","followers_url":"https://api.github.com/users/jasmussen/followers","following_url":"https://api.github.com/users/jasmussen/following{/other_user}","gists_url":"https://api.github.com/users/jasmussen/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmussen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmussen/subscriptions","organizations_url":"https://api.github.com/users/jasmussen/orgs","repos_url":"https://api.github.com/users/jasmussen/repos","events_url":"https://api.github.com/users/jasmussen/events{/privacy}","received_events_url":"https://api.github.com/users/jasmussen/received_events","type":"User","site_admin":false}],"milestone":null,"comments":12,"created_at":"2017-05-04T12:09:22Z","updated_at":"2017-05-09T21:10:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/660","html_url":"https://github.com/WordPress/gutenberg/pull/660","diff_url":"https://github.com/WordPress/gutenberg/pull/660.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/660.patch"},"body":"This should be seen as a progressive enhancement.\r\n\r\nPosition sticky allows us to have relatively positioned toolbars right until the content starts scrolling out of view, at which point it starts behaving as position: fixed. This is exactly what we want for very long editor blocks. There's no reason we can't try this and get a feel for it.\r\n\r\nNote: because `position: sticky;` is still experimental, there are some quirks. Like `position: fixed;`, it doesn't work if a parent container has a `transform` applied. In addition, it doesn't work if a parent has `overflow: hidden;`, which incidentally means if we want this we'll need a different approach to full-width images (which I volunteer to fix in that case).\r\n\r\nThis is not yet fully polished, but please have a look and a test and a feel, and let's discuss.\r\n\r\nVideo:\r\n\r\nhttps://cloudup.com/che4XEHEKk9"},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/300302680","html_url":"https://github.com/WordPress/gutenberg/pull/660#issuecomment-300302680","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/660","id":300302680,"user":{"login":"jasmussen","id":1204802,"avatar_url":"https://avatars0.githubusercontent.com/u/1204802?v=3","gravatar_id":"","url":"https://api.github.com/users/jasmussen","html_url":"https://github.com/jasmussen","followers_url":"https://api.github.com/users/jasmussen/followers","following_url":"https://api.github.com/users/jasmussen/following{/other_user}","gists_url":"https://api.github.com/users/jasmussen/gists{/gist_id}","starred_url":"https://api.github.com/users/jasmussen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasmussen/subscriptions","organizations_url":"https://api.github.com/users/jasmussen/orgs","repos_url":"https://api.github.com/users/jasmussen/repos","events_url":"https://api.github.com/users/jasmussen/events{/privacy}","received_events_url":"https://api.github.com/users/jasmussen/received_events","type":"User","site_admin":false},"created_at":"2017-05-09T21:10:58Z","updated_at":"2017-05-09T21:10:58Z","body":"Removed the layout stylesheet as it's now empty. \r\n\r\n> The sticky effect only goes about 2/3 down the block\r\n> The sticky effect only works for the first text block, but not adjacent ones\r\n\r\nThose were both the same issue, and resulting from Ella's tip here: https://github.com/WordPress/gutenberg/pull/660#issuecomment-300005304 —  basically we are adding a bottom margin to the block, so when you only see n pixels of the block, it stops being fixed position. I reduced this to 50px, and open to removing it entirely, though I do like it.\r\n\r\nI also rebased. Good for a final look?\r\n\r\nThanks for the review!"}}
{"actor":{"display_login":"jasmussen"}}