{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/139650958","pull_request_review_id":63611563,"id":139650958,"diff_hunk":"@@ -99,6 +99,10 @@ static struct args trusty_context_switch(uint32_t security_state, uint64_t r0,\n \tret.r1 = r1;\n \tret.r0 = r0;\n \n+#if CTX_INCLUDE_FPREGS","path":"services/spd/trusty/trusty.c","position":4,"original_position":4,"commit_id":"9c8c91ee9244da607ea294d910b0c41e190860d6","original_commit_id":"9c8c91ee9244da607ea294d910b0c41e190860d6","user":{"login":"danh-arm","id":5684642,"avatar_url":"https://avatars0.githubusercontent.com/u/5684642?v=4","gravatar_id":"","url":"https://api.github.com/users/danh-arm","html_url":"https://github.com/danh-arm","followers_url":"https://api.github.com/users/danh-arm/followers","following_url":"https://api.github.com/users/danh-arm/following{/other_user}","gists_url":"https://api.github.com/users/danh-arm/gists{/gist_id}","starred_url":"https://api.github.com/users/danh-arm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danh-arm/subscriptions","organizations_url":"https://api.github.com/users/danh-arm/orgs","repos_url":"https://api.github.com/users/danh-arm/repos","events_url":"https://api.github.com/users/danh-arm/events{/privacy}","received_events_url":"https://api.github.com/users/danh-arm/received_events","type":"User","site_admin":false},"body":"Looks good, although It might be nice to add a comment here to say FP&SIMD state should be preserved by the SMC caller in the CPU suspend/resume case.","created_at":"2017-09-19T10:16:58Z","updated_at":"2017-09-19T10:17:09Z","html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1100#discussion_r139650958","pull_request_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1100","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments/139650958"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1100#discussion_r139650958"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1100"}}},"pull_request":{"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1100","id":141435682,"html_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1100","diff_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1100.diff","patch_url":"https://github.com/ARM-software/arm-trusted-firmware/pull/1100.patch","issue_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1100","number":1100,"state":"open","locked":false,"title":"trusty: save/restore FPU registers in world switch","user":{"login":"ajs-sun","id":10276995,"avatar_url":"https://avatars3.githubusercontent.com/u/10276995?v=4","gravatar_id":"","url":"https://api.github.com/users/ajs-sun","html_url":"https://github.com/ajs-sun","followers_url":"https://api.github.com/users/ajs-sun/followers","following_url":"https://api.github.com/users/ajs-sun/following{/other_user}","gists_url":"https://api.github.com/users/ajs-sun/gists{/gist_id}","starred_url":"https://api.github.com/users/ajs-sun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajs-sun/subscriptions","organizations_url":"https://api.github.com/users/ajs-sun/orgs","repos_url":"https://api.github.com/users/ajs-sun/repos","events_url":"https://api.github.com/users/ajs-sun/events{/privacy}","received_events_url":"https://api.github.com/users/ajs-sun/received_events","type":"User","site_admin":false},"body":"Currently, Trusty OS/LK implemented FPU context switch in internal\r\nthread switch but does not implement the proper mechanism for world\r\nswitch. This commit just simply saves/restores FPU registes in world\r\nswitch to prevent FPU context from being currupted when Trusty OS uses\r\nVFP in its applications.\r\n\r\nIt should be noted that the macro *CTX_INCLUDE_FPREGS* must be defined\r\nin trusty.mk if Trusty OS uses VFP\r\n\r\nSigned-off-by: goodbach <goodbach@gmail.com>","created_at":"2017-09-16T06:41:14Z","updated_at":"2017-09-19T10:17:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e74ffaf52a98cf7b3c9d685ab3021c592bf69fb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1100/commits","review_comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1100/comments","review_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1100/comments","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/9c8c91ee9244da607ea294d910b0c41e190860d6","head":{"label":"ajs-sun:master","ref":"master","sha":"9c8c91ee9244da607ea294d910b0c41e190860d6","user":{"login":"ajs-sun","id":10276995,"avatar_url":"https://avatars3.githubusercontent.com/u/10276995?v=4","gravatar_id":"","url":"https://api.github.com/users/ajs-sun","html_url":"https://github.com/ajs-sun","followers_url":"https://api.github.com/users/ajs-sun/followers","following_url":"https://api.github.com/users/ajs-sun/following{/other_user}","gists_url":"https://api.github.com/users/ajs-sun/gists{/gist_id}","starred_url":"https://api.github.com/users/ajs-sun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajs-sun/subscriptions","organizations_url":"https://api.github.com/users/ajs-sun/orgs","repos_url":"https://api.github.com/users/ajs-sun/repos","events_url":"https://api.github.com/users/ajs-sun/events{/privacy}","received_events_url":"https://api.github.com/users/ajs-sun/received_events","type":"User","site_admin":false},"repo":{"id":103727038,"name":"arm-trusted-firmware","full_name":"ajs-sun/arm-trusted-firmware","owner":{"login":"ajs-sun","id":10276995,"avatar_url":"https://avatars3.githubusercontent.com/u/10276995?v=4","gravatar_id":"","url":"https://api.github.com/users/ajs-sun","html_url":"https://github.com/ajs-sun","followers_url":"https://api.github.com/users/ajs-sun/followers","following_url":"https://api.github.com/users/ajs-sun/following{/other_user}","gists_url":"https://api.github.com/users/ajs-sun/gists{/gist_id}","starred_url":"https://api.github.com/users/ajs-sun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajs-sun/subscriptions","organizations_url":"https://api.github.com/users/ajs-sun/orgs","repos_url":"https://api.github.com/users/ajs-sun/repos","events_url":"https://api.github.com/users/ajs-sun/events{/privacy}","received_events_url":"https://api.github.com/users/ajs-sun/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajs-sun/arm-trusted-firmware","description":"ARM Trusted Firmware","fork":true,"url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware","forks_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/ajs-sun/arm-trusted-firmware/deployments","created_at":"2017-09-16T05:17:35Z","updated_at":"2017-09-16T05:17:39Z","pushed_at":"2017-09-19T08:53:25Z","git_url":"git://github.com/ajs-sun/arm-trusted-firmware.git","ssh_url":"git@github.com:ajs-sun/arm-trusted-firmware.git","clone_url":"https://github.com/ajs-sun/arm-trusted-firmware.git","svn_url":"https://github.com/ajs-sun/arm-trusted-firmware","homepage":null,"size":11453,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:integration","ref":"integration","sha":"b4f4a2f06ce4da2b7856abb71ad38e726aa7ec68","user":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":13740589,"name":"arm-trusted-firmware","full_name":"ARM-software/arm-trusted-firmware","owner":{"login":"ARM-software","id":5690313,"avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ARM-software/arm-trusted-firmware","description":"ARM Trusted Firmware","fork":false,"url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware","forks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/deployments","created_at":"2013-10-21T11:39:00Z","updated_at":"2017-09-17T05:17:13Z","pushed_at":"2017-09-19T09:24:58Z","git_url":"git://github.com/ARM-software/arm-trusted-firmware.git","ssh_url":"git@github.com:ARM-software/arm-trusted-firmware.git","clone_url":"https://github.com/ARM-software/arm-trusted-firmware.git","svn_url":"https://github.com/ARM-software/arm-trusted-firmware","homepage":null,"size":11458,"stargazers_count":394,"watchers_count":394,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":336,"mirror_url":null,"open_issues_count":9,"forks":336,"open_issues":9,"watchers":394,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1100"},"html":{"href":"https://github.com/ARM-software/arm-trusted-firmware/pull/1100"},"issue":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1100"},"comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/issues/1100/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1100/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/pulls/1100/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/arm-trusted-firmware/statuses/9c8c91ee9244da607ea294d910b0c41e190860d6"}},"author_association":"NONE"}}
{"actor":{"display_login":"danh-arm"}}