{"action":"created","issue":{"url":"https://api.github.com/repos/18F/calc/issues/1235","repository_url":"https://api.github.com/repos/18F/calc","labels_url":"https://api.github.com/repos/18F/calc/issues/1235/labels{/name}","comments_url":"https://api.github.com/repos/18F/calc/issues/1235/comments","events_url":"https://api.github.com/repos/18F/calc/issues/1235/events","html_url":"https://github.com/18F/calc/pull/1235","id":200217275,"number":1235,"title":"Use airbnb-eslint-config and fix identified errors","user":{"login":"jseppi","id":697848,"avatar_url":"https://avatars.githubusercontent.com/u/697848?v=3","gravatar_id":"","url":"https://api.github.com/users/jseppi","html_url":"https://github.com/jseppi","followers_url":"https://api.github.com/users/jseppi/followers","following_url":"https://api.github.com/users/jseppi/following{/other_user}","gists_url":"https://api.github.com/users/jseppi/gists{/gist_id}","starred_url":"https://api.github.com/users/jseppi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseppi/subscriptions","organizations_url":"https://api.github.com/users/jseppi/orgs","repos_url":"https://api.github.com/users/jseppi/repos","events_url":"https://api.github.com/users/jseppi/events{/privacy}","received_events_url":"https://api.github.com/users/jseppi/received_events","type":"User","site_admin":false},"labels":[{"id":500809952,"url":"https://api.github.com/repos/18F/calc/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"jseppi","id":697848,"avatar_url":"https://avatars.githubusercontent.com/u/697848?v=3","gravatar_id":"","url":"https://api.github.com/users/jseppi","html_url":"https://github.com/jseppi","followers_url":"https://api.github.com/users/jseppi/followers","following_url":"https://api.github.com/users/jseppi/following{/other_user}","gists_url":"https://api.github.com/users/jseppi/gists{/gist_id}","starred_url":"https://api.github.com/users/jseppi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseppi/subscriptions","organizations_url":"https://api.github.com/users/jseppi/orgs","repos_url":"https://api.github.com/users/jseppi/repos","events_url":"https://api.github.com/users/jseppi/events{/privacy}","received_events_url":"https://api.github.com/users/jseppi/received_events","type":"User","site_admin":false},"assignees":[{"login":"jseppi","id":697848,"avatar_url":"https://avatars.githubusercontent.com/u/697848?v=3","gravatar_id":"","url":"https://api.github.com/users/jseppi","html_url":"https://github.com/jseppi","followers_url":"https://api.github.com/users/jseppi/followers","following_url":"https://api.github.com/users/jseppi/following{/other_user}","gists_url":"https://api.github.com/users/jseppi/gists{/gist_id}","starred_url":"https://api.github.com/users/jseppi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseppi/subscriptions","organizations_url":"https://api.github.com/users/jseppi/orgs","repos_url":"https://api.github.com/users/jseppi/repos","events_url":"https://api.github.com/users/jseppi/events{/privacy}","received_events_url":"https://api.github.com/users/jseppi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2017-01-11T21:47:56Z","updated_at":"2017-01-12T22:45:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/18F/calc/pulls/1235","html_url":"https://github.com/18F/calc/pull/1235","diff_url":"https://github.com/18F/calc/pull/1235.diff","patch_url":"https://github.com/18F/calc/pull/1235.patch"},"body":"While I would prefer to not have any deviances from the default airbnb config, I did add a few to our `.eslintrc`. We can revisit them in other issues/PRs, but they are pretty minor things:\r\n\r\nDeviances from the default config:\r\n- **comma-dangle#functions** - I don't get why you'd want dangling commas in function param lists\r\n- **no-plusplus** -- ehhhhh, I find `++` and `--` very understandable\r\n- **import/no-named-as-default** - this rule doesn't really work with Redux, and the author suggests disabling it in that case: https://github.com/benmosher/eslint-plugin-import/issues/544#issuecomment-244976007\r\n- **react/forbid-prop-types** - this is a documentation thing, not something that would negatively impact code, according to its own documentation: https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-prop-types.md#when-not-to-use. We can revisit later if desired."},"comment":{"url":"https://api.github.com/repos/18F/calc/issues/comments/272308123","html_url":"https://github.com/18F/calc/pull/1235#issuecomment-272308123","issue_url":"https://api.github.com/repos/18F/calc/issues/1235","id":272308123,"user":{"login":"jseppi","id":697848,"avatar_url":"https://avatars.githubusercontent.com/u/697848?v=3","gravatar_id":"","url":"https://api.github.com/users/jseppi","html_url":"https://github.com/jseppi","followers_url":"https://api.github.com/users/jseppi/followers","following_url":"https://api.github.com/users/jseppi/following{/other_user}","gists_url":"https://api.github.com/users/jseppi/gists{/gist_id}","starred_url":"https://api.github.com/users/jseppi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseppi/subscriptions","organizations_url":"https://api.github.com/users/jseppi/orgs","repos_url":"https://api.github.com/users/jseppi/repos","events_url":"https://api.github.com/users/jseppi/events{/privacy}","received_events_url":"https://api.github.com/users/jseppi/received_events","type":"User","site_admin":false},"created_at":"2017-01-12T22:45:51Z","updated_at":"2017-01-12T22:45:51Z","body":"Alrighty, @toolness, ready for review! Sorry it's such a large diff. Most changes were automatic via `eslint --fix`."}}
{"actor":{"display_login":"jseppi"}}