{"action":"created","comment":{"url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments/126285808","pull_request_review_id":48759860,"id":126285808,"diff_hunk":"@@ -27,6 +27,12 @@\n  */\n public abstract class AbstractEventStreamEvent implements org.xwiki.observation.event.Event\n {\n+    /**\n+     * Used to provide a key to a property in the current execution context that avoids stepping into a loop when\n+     * triggering new events.\n+     */\n+    public static final String EVENT_LOOP_CONTEXT_LOCK_PROPERTY = \"eventLoopContextLockProperty\";","path":"xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/main/java/org/xwiki/eventstream/events/AbstractEventStreamEvent.java","position":8,"original_position":8,"commit_id":"ad4eae2b1db08e487f33c44c82333132a310f44e","original_commit_id":"f652d59bf02027324a2962ef597c99622b062705","user":{"login":"tmortagne","id":89175,"avatar_url":"https://avatars2.githubusercontent.com/u/89175?v=3","gravatar_id":"","url":"https://api.github.com/users/tmortagne","html_url":"https://github.com/tmortagne","followers_url":"https://api.github.com/users/tmortagne/followers","following_url":"https://api.github.com/users/tmortagne/following{/other_user}","gists_url":"https://api.github.com/users/tmortagne/gists{/gist_id}","starred_url":"https://api.github.com/users/tmortagne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmortagne/subscriptions","organizations_url":"https://api.github.com/users/tmortagne/orgs","repos_url":"https://api.github.com/users/tmortagne/repos","events_url":"https://api.github.com/users/tmortagne/events{/privacy}","received_events_url":"https://api.github.com/users/tmortagne/received_events","type":"User","site_admin":false},"body":"bq.  Also, it would mean that we’re using internal properties of the Event Stream from the Activity Stream module.\r\n\r\nThis is not really an issue IMO. You are talking about two things located in the same module right now. But nobody else is supposed to used that property since you did what was required to protect against cycles already. Making an internal tool public is easy but the opposite is very hard so without any use case in mind you should start internal.","created_at":"2017-07-08T16:44:53Z","updated_at":"2017-07-08T16:44:53Z","html_url":"https://github.com/xwiki/xwiki-platform/pull/593#discussion_r126285808","pull_request_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/593","_links":{"self":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments/126285808"},"html":{"href":"https://github.com/xwiki/xwiki-platform/pull/593#discussion_r126285808"},"pull_request":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/593"}}},"pull_request":{"url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/593","id":129423740,"html_url":"https://github.com/xwiki/xwiki-platform/pull/593","diff_url":"https://github.com/xwiki/xwiki-platform/pull/593.diff","patch_url":"https://github.com/xwiki/xwiki-platform/pull/593.patch","issue_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues/593","number":593,"state":"open","locked":false,"title":"XWIKI-14507: Allow actions in the event stream to be observed","user":{"login":"aubincleme","id":5938943,"avatar_url":"https://avatars1.githubusercontent.com/u/5938943?v=3","gravatar_id":"","url":"https://api.github.com/users/aubincleme","html_url":"https://github.com/aubincleme","followers_url":"https://api.github.com/users/aubincleme/followers","following_url":"https://api.github.com/users/aubincleme/following{/other_user}","gists_url":"https://api.github.com/users/aubincleme/gists{/gist_id}","starred_url":"https://api.github.com/users/aubincleme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aubincleme/subscriptions","organizations_url":"https://api.github.com/users/aubincleme/orgs","repos_url":"https://api.github.com/users/aubincleme/repos","events_url":"https://api.github.com/users/aubincleme/events{/privacy}","received_events_url":"https://api.github.com/users/aubincleme/received_events","type":"User","site_admin":false},"body":"* Add new semaphore on EventStreamEvents","created_at":"2017-07-07T14:59:14Z","updated_at":"2017-07-08T16:44:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b3a1ec04841d7d68d20a3ad1284239933efa3bd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/593/commits","review_comments_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/593/comments","review_comment_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues/593/comments","statuses_url":"https://api.github.com/repos/xwiki/xwiki-platform/statuses/ad4eae2b1db08e487f33c44c82333132a310f44e","head":{"label":"aubincleme:xwiki-14507","ref":"xwiki-14507","sha":"ad4eae2b1db08e487f33c44c82333132a310f44e","user":{"login":"aubincleme","id":5938943,"avatar_url":"https://avatars1.githubusercontent.com/u/5938943?v=3","gravatar_id":"","url":"https://api.github.com/users/aubincleme","html_url":"https://github.com/aubincleme","followers_url":"https://api.github.com/users/aubincleme/followers","following_url":"https://api.github.com/users/aubincleme/following{/other_user}","gists_url":"https://api.github.com/users/aubincleme/gists{/gist_id}","starred_url":"https://api.github.com/users/aubincleme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aubincleme/subscriptions","organizations_url":"https://api.github.com/users/aubincleme/orgs","repos_url":"https://api.github.com/users/aubincleme/repos","events_url":"https://api.github.com/users/aubincleme/events{/privacy}","received_events_url":"https://api.github.com/users/aubincleme/received_events","type":"User","site_admin":false},"repo":{"id":89955475,"name":"xwiki-platform","full_name":"aubincleme/xwiki-platform","owner":{"login":"aubincleme","id":5938943,"avatar_url":"https://avatars1.githubusercontent.com/u/5938943?v=3","gravatar_id":"","url":"https://api.github.com/users/aubincleme","html_url":"https://github.com/aubincleme","followers_url":"https://api.github.com/users/aubincleme/followers","following_url":"https://api.github.com/users/aubincleme/following{/other_user}","gists_url":"https://api.github.com/users/aubincleme/gists{/gist_id}","starred_url":"https://api.github.com/users/aubincleme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aubincleme/subscriptions","organizations_url":"https://api.github.com/users/aubincleme/orgs","repos_url":"https://api.github.com/users/aubincleme/repos","events_url":"https://api.github.com/users/aubincleme/events{/privacy}","received_events_url":"https://api.github.com/users/aubincleme/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aubincleme/xwiki-platform","description":"The XWiki platform","fork":true,"url":"https://api.github.com/repos/aubincleme/xwiki-platform","forks_url":"https://api.github.com/repos/aubincleme/xwiki-platform/forks","keys_url":"https://api.github.com/repos/aubincleme/xwiki-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aubincleme/xwiki-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aubincleme/xwiki-platform/teams","hooks_url":"https://api.github.com/repos/aubincleme/xwiki-platform/hooks","issue_events_url":"https://api.github.com/repos/aubincleme/xwiki-platform/issues/events{/number}","events_url":"https://api.github.com/repos/aubincleme/xwiki-platform/events","assignees_url":"https://api.github.com/repos/aubincleme/xwiki-platform/assignees{/user}","branches_url":"https://api.github.com/repos/aubincleme/xwiki-platform/branches{/branch}","tags_url":"https://api.github.com/repos/aubincleme/xwiki-platform/tags","blobs_url":"https://api.github.com/repos/aubincleme/xwiki-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aubincleme/xwiki-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aubincleme/xwiki-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/aubincleme/xwiki-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aubincleme/xwiki-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/aubincleme/xwiki-platform/languages","stargazers_url":"https://api.github.com/repos/aubincleme/xwiki-platform/stargazers","contributors_url":"https://api.github.com/repos/aubincleme/xwiki-platform/contributors","subscribers_url":"https://api.github.com/repos/aubincleme/xwiki-platform/subscribers","subscription_url":"https://api.github.com/repos/aubincleme/xwiki-platform/subscription","commits_url":"https://api.github.com/repos/aubincleme/xwiki-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/aubincleme/xwiki-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/aubincleme/xwiki-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/aubincleme/xwiki-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/aubincleme/xwiki-platform/contents/{+path}","compare_url":"https://api.github.com/repos/aubincleme/xwiki-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aubincleme/xwiki-platform/merges","archive_url":"https://api.github.com/repos/aubincleme/xwiki-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aubincleme/xwiki-platform/downloads","issues_url":"https://api.github.com/repos/aubincleme/xwiki-platform/issues{/number}","pulls_url":"https://api.github.com/repos/aubincleme/xwiki-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/aubincleme/xwiki-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/aubincleme/xwiki-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aubincleme/xwiki-platform/labels{/name}","releases_url":"https://api.github.com/repos/aubincleme/xwiki-platform/releases{/id}","deployments_url":"https://api.github.com/repos/aubincleme/xwiki-platform/deployments","created_at":"2017-05-01T19:27:15Z","updated_at":"2017-05-01T19:27:44Z","pushed_at":"2017-07-07T20:24:16Z","git_url":"git://github.com/aubincleme/xwiki-platform.git","ssh_url":"git@github.com:aubincleme/xwiki-platform.git","clone_url":"https://github.com/aubincleme/xwiki-platform.git","svn_url":"https://github.com/aubincleme/xwiki-platform","homepage":"http://platform.xwiki.org/","size":308075,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xwiki:master","ref":"master","sha":"608b7bf62baa364d9123e7fb9e413154b30bd647","user":{"login":"xwiki","id":488445,"avatar_url":"https://avatars2.githubusercontent.com/u/488445?v=3","gravatar_id":"","url":"https://api.github.com/users/xwiki","html_url":"https://github.com/xwiki","followers_url":"https://api.github.com/users/xwiki/followers","following_url":"https://api.github.com/users/xwiki/following{/other_user}","gists_url":"https://api.github.com/users/xwiki/gists{/gist_id}","starred_url":"https://api.github.com/users/xwiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwiki/subscriptions","organizations_url":"https://api.github.com/users/xwiki/orgs","repos_url":"https://api.github.com/users/xwiki/repos","events_url":"https://api.github.com/users/xwiki/events{/privacy}","received_events_url":"https://api.github.com/users/xwiki/received_events","type":"Organization","site_admin":false},"repo":{"id":1463490,"name":"xwiki-platform","full_name":"xwiki/xwiki-platform","owner":{"login":"xwiki","id":488445,"avatar_url":"https://avatars2.githubusercontent.com/u/488445?v=3","gravatar_id":"","url":"https://api.github.com/users/xwiki","html_url":"https://github.com/xwiki","followers_url":"https://api.github.com/users/xwiki/followers","following_url":"https://api.github.com/users/xwiki/following{/other_user}","gists_url":"https://api.github.com/users/xwiki/gists{/gist_id}","starred_url":"https://api.github.com/users/xwiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwiki/subscriptions","organizations_url":"https://api.github.com/users/xwiki/orgs","repos_url":"https://api.github.com/users/xwiki/repos","events_url":"https://api.github.com/users/xwiki/events{/privacy}","received_events_url":"https://api.github.com/users/xwiki/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xwiki/xwiki-platform","description":"The XWiki platform","fork":false,"url":"https://api.github.com/repos/xwiki/xwiki-platform","forks_url":"https://api.github.com/repos/xwiki/xwiki-platform/forks","keys_url":"https://api.github.com/repos/xwiki/xwiki-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwiki/xwiki-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwiki/xwiki-platform/teams","hooks_url":"https://api.github.com/repos/xwiki/xwiki-platform/hooks","issue_events_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues/events{/number}","events_url":"https://api.github.com/repos/xwiki/xwiki-platform/events","assignees_url":"https://api.github.com/repos/xwiki/xwiki-platform/assignees{/user}","branches_url":"https://api.github.com/repos/xwiki/xwiki-platform/branches{/branch}","tags_url":"https://api.github.com/repos/xwiki/xwiki-platform/tags","blobs_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwiki/xwiki-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/xwiki/xwiki-platform/languages","stargazers_url":"https://api.github.com/repos/xwiki/xwiki-platform/stargazers","contributors_url":"https://api.github.com/repos/xwiki/xwiki-platform/contributors","subscribers_url":"https://api.github.com/repos/xwiki/xwiki-platform/subscribers","subscription_url":"https://api.github.com/repos/xwiki/xwiki-platform/subscription","commits_url":"https://api.github.com/repos/xwiki/xwiki-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwiki/xwiki-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwiki/xwiki-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwiki/xwiki-platform/contents/{+path}","compare_url":"https://api.github.com/repos/xwiki/xwiki-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwiki/xwiki-platform/merges","archive_url":"https://api.github.com/repos/xwiki/xwiki-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwiki/xwiki-platform/downloads","issues_url":"https://api.github.com/repos/xwiki/xwiki-platform/issues{/number}","pulls_url":"https://api.github.com/repos/xwiki/xwiki-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/xwiki/xwiki-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/xwiki/xwiki-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwiki/xwiki-platform/labels{/name}","releases_url":"https://api.github.com/repos/xwiki/xwiki-platform/releases{/id}","deployments_url":"https://api.github.com/repos/xwiki/xwiki-platform/deployments","created_at":"2011-03-10T13:26:41Z","updated_at":"2017-07-06T08:06:39Z","pushed_at":"2017-07-08T06:57:33Z","git_url":"git://github.com/xwiki/xwiki-platform.git","ssh_url":"git@github.com:xwiki/xwiki-platform.git","clone_url":"https://github.com/xwiki/xwiki-platform.git","svn_url":"https://github.com/xwiki/xwiki-platform","homepage":"http://platform.xwiki.org/","size":309023,"stargazers_count":241,"watchers_count":241,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":219,"mirror_url":null,"open_issues_count":36,"forks":219,"open_issues":36,"watchers":241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/593"},"html":{"href":"https://github.com/xwiki/xwiki-platform/pull/593"},"issue":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/issues/593"},"comments":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/issues/593/comments"},"review_comments":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/593/comments"},"review_comment":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/pulls/593/commits"},"statuses":{"href":"https://api.github.com/repos/xwiki/xwiki-platform/statuses/ad4eae2b1db08e487f33c44c82333132a310f44e"}}}}
{"actor":{"display_login":"tmortagne"}}