{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/25576","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/25576/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/25576/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/25576/events","html_url":"https://github.com/Microsoft/vscode/pull/25576","id":224913978,"number":25576,"title":"[WIP] Use WSL PHP for validation","user":{"login":"codeguy","id":31677,"avatar_url":"https://avatars0.githubusercontent.com/u/31677?v=3","gravatar_id":"","url":"https://api.github.com/users/codeguy","html_url":"https://github.com/codeguy","followers_url":"https://api.github.com/users/codeguy/followers","following_url":"https://api.github.com/users/codeguy/following{/other_user}","gists_url":"https://api.github.com/users/codeguy/gists{/gist_id}","starred_url":"https://api.github.com/users/codeguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeguy/subscriptions","organizations_url":"https://api.github.com/users/codeguy/orgs","repos_url":"https://api.github.com/users/codeguy/repos","events_url":"https://api.github.com/users/codeguy/events{/privacy}","received_events_url":"https://api.github.com/users/codeguy/received_events","type":"User","site_admin":false},"labels":[{"id":287229833,"url":"https://api.github.com/repos/Microsoft/vscode/labels/cla-signed","name":"cla-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-04-27T21:09:38Z","updated_at":"2017-04-28T00:45:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode/pulls/25576","html_url":"https://github.com/Microsoft/vscode/pull/25576","diff_url":"https://github.com/Microsoft/vscode/pull/25576.diff","patch_url":"https://github.com/Microsoft/vscode/pull/25576.patch"},"body":"Related to #22391 \r\n\r\nWORK IN PROGRESS. DO NOT MERGE YET.\r\n\r\nI am having an issue fetching the standard output from the spawned validator process. What I am doing is spawning a cmd.exe process, and that spawns a bash.exe process who in turn runs \"php -l -n -f /path/to/file/to/validate.php\". However, this callback is never called:\r\n\r\nhttps://github.com/codeguy/vscode/blob/feature-wsl-php-validator/extensions/php/src/features/validationProvider.ts#L284-L287\r\n\r\nI have not hooked up custom configuration settings yet. I am simply forcing VSCode to use WSL php for validation with these temporary lines:\r\n\r\nhttps://github.com/codeguy/vscode/blob/feature-wsl-php-validator/extensions/php/src/features/validationProvider.ts#L252-L265\r\n\r\nDo you have any thoughts why I am not getting any stdout?\r\n\r\nI have seen this issue with WSL:\r\n\r\n<del>https://github.com/cpdt/slinky/issues/11</del>\r\n\r\nCorrect issue to reference is https://github.com/Microsoft/BashOnWindows/issues/2\r\n\r\nBut that was apparently resolved with latest code pushed out with Creators Update.\r\n\r\nThoughts?\r\n\r\nWasn't sure which branch to send PR against, so using master for now. I can always re-submit.\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/297877301","html_url":"https://github.com/Microsoft/vscode/pull/25576#issuecomment-297877301","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/25576","id":297877301,"user":{"login":"codeguy","id":31677,"avatar_url":"https://avatars0.githubusercontent.com/u/31677?v=3","gravatar_id":"","url":"https://api.github.com/users/codeguy","html_url":"https://github.com/codeguy","followers_url":"https://api.github.com/users/codeguy/followers","following_url":"https://api.github.com/users/codeguy/following{/other_user}","gists_url":"https://api.github.com/users/codeguy/gists{/gist_id}","starred_url":"https://api.github.com/users/codeguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeguy/subscriptions","organizations_url":"https://api.github.com/users/codeguy/orgs","repos_url":"https://api.github.com/users/codeguy/repos","events_url":"https://api.github.com/users/codeguy/events{/privacy}","received_events_url":"https://api.github.com/users/codeguy/received_events","type":"User","site_admin":false},"created_at":"2017-04-28T00:45:26Z","updated_at":"2017-04-28T00:45:26Z","body":"Found a solution!!! I'll hook up custom VSCode php.validate.* settings tomorrow and squash commits.\r\n![woot](https://cloud.githubusercontent.com/assets/31677/25509930/6ee7e3f4-2b8a-11e7-88a5-b4690c079f0a.gif)\r\n\r\n"}}
{"actor":{"display_login":"codeguy"}}