{"action":"created","issue":{"url":"https://api.github.com/repos/gradle/gradle/issues/3018","repository_url":"https://api.github.com/repos/gradle/gradle","labels_url":"https://api.github.com/repos/gradle/gradle/issues/3018/labels{/name}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/3018/comments","events_url":"https://api.github.com/repos/gradle/gradle/issues/3018/events","html_url":"https://github.com/gradle/gradle/pull/3018","id":260408809,"number":3018,"title":"Fix #2999: runPlayBinary needs to be adapted for Play 2.6","user":{"login":"marcospereira","id":4576,"avatar_url":"https://avatars0.githubusercontent.com/u/4576?v=4","gravatar_id":"","url":"https://api.github.com/users/marcospereira","html_url":"https://github.com/marcospereira","followers_url":"https://api.github.com/users/marcospereira/followers","following_url":"https://api.github.com/users/marcospereira/following{/other_user}","gists_url":"https://api.github.com/users/marcospereira/gists{/gist_id}","starred_url":"https://api.github.com/users/marcospereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcospereira/subscriptions","organizations_url":"https://api.github.com/users/marcospereira/orgs","repos_url":"https://api.github.com/users/marcospereira/repos","events_url":"https://api.github.com/users/marcospereira/events{/privacy}","received_events_url":"https://api.github.com/users/marcospereira/received_events","type":"User","site_admin":false},"labels":[{"id":460356753,"url":"https://api.github.com/repos/gradle/gradle/labels/a:feature","name":"a:feature","color":"0e8a16","default":false},{"id":281178176,"url":"https://api.github.com/repos/gradle/gradle/labels/cla:yes","name":"cla:yes","color":"0e8a16","default":false},{"id":478384995,"url":"https://api.github.com/repos/gradle/gradle/labels/from:contributor","name":"from:contributor","color":"0052cc","default":false},{"id":281288606,"url":"https://api.github.com/repos/gradle/gradle/labels/in:play","name":"in:play","color":"d4c5f9","default":false},{"id":460361544,"url":"https://api.github.com/repos/gradle/gradle/labels/waiting-for:gradle-team","name":"waiting-for:gradle-team","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-09-25T20:43:48Z","updated_at":"2017-10-27T18:08:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/3018","html_url":"https://github.com/gradle/gradle/pull/3018","diff_url":"https://github.com/gradle/gradle/pull/3018.diff","patch_url":"https://github.com/gradle/gradle/pull/3018.patch"},"body":"### Context\r\n\r\nThis fixes two things in Play 2.6 support:\r\n\r\n1. Support for Scala 2.12 (which also should be the default when selecting Play 2.6)\r\n2. `runPlayBinary` is broken for Play 2.6 and needs to be changed. That is because `play.core.server.DevServerStart#mainDevHttpMode` has a new signature.\r\n\r\nSee issues #2991 and #2999.\r\n\r\n### Contributor Checklist\r\n\r\n- [x] [Review Contribution Guidelines](https://github.com/gradle/gradle/blob/master/.github/CONTRIBUTING.md)\r\n- [x] [Sign Gradle CLA](http://gradle.org/contributor-license-agreement/)\r\n- [x] Check [\"Allow edit from maintainers\" option](https://help.github.com/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork/) in pull request so that additional changes can be pushed by Gradle team\r\n- [ ] Provide integration tests (under `<subproject>/src/integTest`) to verify changes from a user perspective\r\n- [x] Provide unit tests (under `<subproject>/src/test`) to verify logic\r\n- [x] Update User Guide, DSL Reference, and Javadoc for public-facing changes\r\n- [x] Ensure that tests pass locally: `./gradlew <changed-subproject>:check`\r\n\r\nSome points here:\r\n\r\n1. I was able to run the tests locally using `./gradlew platformPlay:check`, but ran into the following error the first time: https://gist.github.com/marcospereira/14ea17771ac9ba336e12367c9e79c04d. Not sure if this is relevant to you guys.\r\n2. I'm not sure about how to add integration tests for the fix in `runPlayBinary`. Could you please guide me here?\r\n\r\n### Gradle Core Team Checklist\r\n- [ ] Verify design and implementation \r\n- [ ] Verify test coverage and CI build status\r\n- [ ] Verify documentation\r\n- [ ] Recognize contributor in release notes\r\n"},"comment":{"url":"https://api.github.com/repos/gradle/gradle/issues/comments/340044618","html_url":"https://github.com/gradle/gradle/pull/3018#issuecomment-340044618","issue_url":"https://api.github.com/repos/gradle/gradle/issues/3018","id":340044618,"user":{"login":"marcospereira","id":4576,"avatar_url":"https://avatars0.githubusercontent.com/u/4576?v=4","gravatar_id":"","url":"https://api.github.com/users/marcospereira","html_url":"https://github.com/marcospereira","followers_url":"https://api.github.com/users/marcospereira/followers","following_url":"https://api.github.com/users/marcospereira/following{/other_user}","gists_url":"https://api.github.com/users/marcospereira/gists{/gist_id}","starred_url":"https://api.github.com/users/marcospereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcospereira/subscriptions","organizations_url":"https://api.github.com/users/marcospereira/orgs","repos_url":"https://api.github.com/users/marcospereira/repos","events_url":"https://api.github.com/users/marcospereira/events{/privacy}","received_events_url":"https://api.github.com/users/marcospereira/received_events","type":"User","site_admin":false},"created_at":"2017-10-27T18:08:58Z","updated_at":"2017-10-27T18:08:58Z","author_association":"NONE","body":"Also, there is no test to validate the use of additional imports added using the following syntax:\r\n\r\n```gradle\r\nsources {\r\n    withType(TwirlSourceSet) {\r\n        addUserTemplateFormat(\"unused\", \"views.formats.unused.UnusedFormat\", \"my.pkg._\")\r\n    }\r\n}\r\n```\r\n\r\nSee [TwirlCompileIntegrationTest.groovy](https://github.com/gradle/gradle/blob/767f60875866591ee5b2b46244ed6bb1f8bda3b8/subprojects/platform-play/src/integTest/groovy/org/gradle/play/tasks/TwirlCompileIntegrationTest.groovy).\r\n\r\n@blindpirate you may be better equipped to fix this than I am. :-)"}}
{"actor":{"display_login":"marcospereira"}}