{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/156572218","pull_request_review_id":83056753,"id":156572218,"diff_hunk":"@@ -442,6 +464,11 @@ struct Task {\n  */\n Task *Task_alloc(TaskSpec *spec,\n                  int64_t task_spec_size,\n+                 int state,\n+                 DBClientID local_scheduler_id,\n+                 const std::vector<ObjectID> execution_dependencies);","path":"src/common/task.h","position":77,"original_position":77,"commit_id":"37e7697727468e660794a9fa742aad227f069b77","original_commit_id":"37e7697727468e660794a9fa742aad227f069b77","user":{"login":"robertnishihara","id":249517,"avatar_url":"https://avatars3.githubusercontent.com/u/249517?v=4","gravatar_id":"","url":"https://api.github.com/users/robertnishihara","html_url":"https://github.com/robertnishihara","followers_url":"https://api.github.com/users/robertnishihara/followers","following_url":"https://api.github.com/users/robertnishihara/following{/other_user}","gists_url":"https://api.github.com/users/robertnishihara/gists{/gist_id}","starred_url":"https://api.github.com/users/robertnishihara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertnishihara/subscriptions","organizations_url":"https://api.github.com/users/robertnishihara/orgs","repos_url":"https://api.github.com/users/robertnishihara/repos","events_url":"https://api.github.com/users/robertnishihara/events{/privacy}","received_events_url":"https://api.github.com/users/robertnishihara/received_events","type":"User","site_admin":false},"body":"const ref?","created_at":"2017-12-13T06:19:38Z","updated_at":"2017-12-13T06:30:08Z","html_url":"https://github.com/ray-project/ray/pull/1281#discussion_r156572218","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/1281","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/156572218"},"html":{"href":"https://github.com/ray-project/ray/pull/1281#discussion_r156572218"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/1281"}}},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/1281","id":155751510,"html_url":"https://github.com/ray-project/ray/pull/1281","diff_url":"https://github.com/ray-project/ray/pull/1281.diff","patch_url":"https://github.com/ray-project/ray/pull/1281.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/1281","number":1281,"state":"open","locked":false,"title":"Convert actor dummy objects to task execution edges.","user":{"login":"stephanie-wang","id":2560516,"avatar_url":"https://avatars2.githubusercontent.com/u/2560516?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanie-wang","html_url":"https://github.com/stephanie-wang","followers_url":"https://api.github.com/users/stephanie-wang/followers","following_url":"https://api.github.com/users/stephanie-wang/following{/other_user}","gists_url":"https://api.github.com/users/stephanie-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanie-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanie-wang/subscriptions","organizations_url":"https://api.github.com/users/stephanie-wang/orgs","repos_url":"https://api.github.com/users/stephanie-wang/repos","events_url":"https://api.github.com/users/stephanie-wang/events{/privacy}","received_events_url":"https://api.github.com/users/stephanie-wang/received_events","type":"User","site_admin":false},"body":"This PR converts the actor \"dummy\" objects, which were used to indicate actor execution order rather than data dependencies explicitly specified by the user, into a separate, mutable field in the task spec.\r\n\r\n## What do these changes do?\r\n\r\nThis replaces all instances of the `TaskSpec` with the new `TaskExecutionSpec`, which comprises the immutable `TaskSpec` and an additional vector of execution dependencies. Execution dependencies are currently only used by actors, to determine what tasks should have executed on the actor before the new task can be scheduled. Currently, these execution dependencies are never changed in the GCS task table, but in the future, they may be used for deterministic actor replay by recording the exact order of initial execution.\r\n","created_at":"2017-12-01T00:03:09Z","updated_at":"2017-12-13T06:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65e57c27c9280e6680c96e281981fc8b421e6a4f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/1281/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/1281/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/1281/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/37e7697727468e660794a9fa742aad227f069b77","head":{"label":"stephanie-wang:actor-nondeterminism","ref":"actor-nondeterminism","sha":"37e7697727468e660794a9fa742aad227f069b77","user":{"login":"stephanie-wang","id":2560516,"avatar_url":"https://avatars2.githubusercontent.com/u/2560516?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanie-wang","html_url":"https://github.com/stephanie-wang","followers_url":"https://api.github.com/users/stephanie-wang/followers","following_url":"https://api.github.com/users/stephanie-wang/following{/other_user}","gists_url":"https://api.github.com/users/stephanie-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanie-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanie-wang/subscriptions","organizations_url":"https://api.github.com/users/stephanie-wang/orgs","repos_url":"https://api.github.com/users/stephanie-wang/repos","events_url":"https://api.github.com/users/stephanie-wang/events{/privacy}","received_events_url":"https://api.github.com/users/stephanie-wang/received_events","type":"User","site_admin":false},"repo":{"id":77302388,"name":"ray","full_name":"stephanie-wang/ray","owner":{"login":"stephanie-wang","id":2560516,"avatar_url":"https://avatars2.githubusercontent.com/u/2560516?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanie-wang","html_url":"https://github.com/stephanie-wang","followers_url":"https://api.github.com/users/stephanie-wang/followers","following_url":"https://api.github.com/users/stephanie-wang/following{/other_user}","gists_url":"https://api.github.com/users/stephanie-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanie-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanie-wang/subscriptions","organizations_url":"https://api.github.com/users/stephanie-wang/orgs","repos_url":"https://api.github.com/users/stephanie-wang/repos","events_url":"https://api.github.com/users/stephanie-wang/events{/privacy}","received_events_url":"https://api.github.com/users/stephanie-wang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephanie-wang/ray","description":"An experimental distributed execution engine","fork":true,"url":"https://api.github.com/repos/stephanie-wang/ray","forks_url":"https://api.github.com/repos/stephanie-wang/ray/forks","keys_url":"https://api.github.com/repos/stephanie-wang/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephanie-wang/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephanie-wang/ray/teams","hooks_url":"https://api.github.com/repos/stephanie-wang/ray/hooks","issue_events_url":"https://api.github.com/repos/stephanie-wang/ray/issues/events{/number}","events_url":"https://api.github.com/repos/stephanie-wang/ray/events","assignees_url":"https://api.github.com/repos/stephanie-wang/ray/assignees{/user}","branches_url":"https://api.github.com/repos/stephanie-wang/ray/branches{/branch}","tags_url":"https://api.github.com/repos/stephanie-wang/ray/tags","blobs_url":"https://api.github.com/repos/stephanie-wang/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephanie-wang/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephanie-wang/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephanie-wang/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephanie-wang/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/stephanie-wang/ray/languages","stargazers_url":"https://api.github.com/repos/stephanie-wang/ray/stargazers","contributors_url":"https://api.github.com/repos/stephanie-wang/ray/contributors","subscribers_url":"https://api.github.com/repos/stephanie-wang/ray/subscribers","subscription_url":"https://api.github.com/repos/stephanie-wang/ray/subscription","commits_url":"https://api.github.com/repos/stephanie-wang/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephanie-wang/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephanie-wang/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephanie-wang/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephanie-wang/ray/contents/{+path}","compare_url":"https://api.github.com/repos/stephanie-wang/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephanie-wang/ray/merges","archive_url":"https://api.github.com/repos/stephanie-wang/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephanie-wang/ray/downloads","issues_url":"https://api.github.com/repos/stephanie-wang/ray/issues{/number}","pulls_url":"https://api.github.com/repos/stephanie-wang/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/stephanie-wang/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/stephanie-wang/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephanie-wang/ray/labels{/name}","releases_url":"https://api.github.com/repos/stephanie-wang/ray/releases{/id}","deployments_url":"https://api.github.com/repos/stephanie-wang/ray/deployments","created_at":"2016-12-24T22:37:23Z","updated_at":"2017-08-23T20:31:07Z","pushed_at":"2017-12-12T02:23:43Z","git_url":"git://github.com/stephanie-wang/ray.git","ssh_url":"git@github.com:stephanie-wang/ray.git","clone_url":"https://github.com/stephanie-wang/ray.git","svn_url":"https://github.com/stephanie-wang/ray","homepage":"","size":10094,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"20d6b74aa6c034fdf35422e6805e2283c672e03f","user":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"name":"ray","full_name":"ray-project/ray","owner":{"login":"ray-project","id":22125274,"avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-project/ray","description":"A high-performance distributed execution engine","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2017-12-13T03:41:08Z","pushed_at":"2017-12-13T04:32:30Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"","size":7262,"stargazers_count":866,"watchers_count":866,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":163,"mirror_url":null,"archived":false,"open_issues_count":199,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":163,"open_issues":199,"watchers":866,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/1281"},"html":{"href":"https://github.com/ray-project/ray/pull/1281"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/1281"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/1281/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/1281/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/1281/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/37e7697727468e660794a9fa742aad227f069b77"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robertnishihara"}}