{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/134115990","pull_request_review_id":57372738,"id":134115990,"diff_hunk":"@@ -113,15 +113,15 @@ FontEngine::~FontEngine()\n /******************************************************************************/\n void FontEngine::cleanCache()\n {\n-\tfor ( unsigned int i = 0; i < FM_MaxMode; i++) {\n+\tfor (auto &i : m_font_cache) {\n \n \t\tfor (std::map<unsigned int, irr::gui::IGUIFont*>::iterator iter\n-\t\t\t\t= m_font_cache[i].begin();\n-\t\t\t\titer != m_font_cache[i].end(); ++iter) {\n+\t\t\t\t= i.begin();\n+\t\t\t\titer != i.end(); ++iter) {","path":"src/fontengine.cpp","position":22,"original_position":22,"commit_id":"831c1cb411bea18586153ed996037d01db869388","original_commit_id":"831c1cb411bea18586153ed996037d01db869388","user":{"login":"SmallJoker","id":1497498,"avatar_url":"https://avatars1.githubusercontent.com/u/1497498?v=4","gravatar_id":"","url":"https://api.github.com/users/SmallJoker","html_url":"https://github.com/SmallJoker","followers_url":"https://api.github.com/users/SmallJoker/followers","following_url":"https://api.github.com/users/SmallJoker/following{/other_user}","gists_url":"https://api.github.com/users/SmallJoker/gists{/gist_id}","starred_url":"https://api.github.com/users/SmallJoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmallJoker/subscriptions","organizations_url":"https://api.github.com/users/SmallJoker/orgs","repos_url":"https://api.github.com/users/SmallJoker/repos","events_url":"https://api.github.com/users/SmallJoker/events{/privacy}","received_events_url":"https://api.github.com/users/SmallJoker/received_events","type":"User","site_admin":false},"body":"Range based for possible","created_at":"2017-08-20T13:49:00Z","updated_at":"2017-08-20T13:49:00Z","html_url":"https://github.com/minetest/minetest/pull/6290#discussion_r134115990","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/6290","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/134115990"},"html":{"href":"https://github.com/minetest/minetest/pull/6290#discussion_r134115990"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/6290"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/6290","id":136641447,"html_url":"https://github.com/minetest/minetest/pull/6290","diff_url":"https://github.com/minetest/minetest/pull/6290.diff","patch_url":"https://github.com/minetest/minetest/pull/6290.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/6290","number":6290,"state":"open","locked":false,"title":"Modernize code: very last fixes","user":{"login":"nerzhul","id":119752,"avatar_url":"https://avatars0.githubusercontent.com/u/119752?v=4","gravatar_id":"","url":"https://api.github.com/users/nerzhul","html_url":"https://github.com/nerzhul","followers_url":"https://api.github.com/users/nerzhul/followers","following_url":"https://api.github.com/users/nerzhul/following{/other_user}","gists_url":"https://api.github.com/users/nerzhul/gists{/gist_id}","starred_url":"https://api.github.com/users/nerzhul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerzhul/subscriptions","organizations_url":"https://api.github.com/users/nerzhul/orgs","repos_url":"https://api.github.com/users/nerzhul/repos","events_url":"https://api.github.com/users/nerzhul/events{/privacy}","received_events_url":"https://api.github.com/users/nerzhul/received_events","type":"User","site_admin":false},"body":"It's the very last fixes","created_at":"2017-08-20T12:30:35Z","updated_at":"2017-08-20T13:49:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82df26d47ba795e054e48741edeae036a99056ff","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/6290/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/6290/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/6290/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/831c1cb411bea18586153ed996037d01db869388","head":{"label":"nerzhul:modernize_lastlast","ref":"modernize_lastlast","sha":"831c1cb411bea18586153ed996037d01db869388","user":{"login":"nerzhul","id":119752,"avatar_url":"https://avatars0.githubusercontent.com/u/119752?v=4","gravatar_id":"","url":"https://api.github.com/users/nerzhul","html_url":"https://github.com/nerzhul","followers_url":"https://api.github.com/users/nerzhul/followers","following_url":"https://api.github.com/users/nerzhul/following{/other_user}","gists_url":"https://api.github.com/users/nerzhul/gists{/gist_id}","starred_url":"https://api.github.com/users/nerzhul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerzhul/subscriptions","organizations_url":"https://api.github.com/users/nerzhul/orgs","repos_url":"https://api.github.com/users/nerzhul/repos","events_url":"https://api.github.com/users/nerzhul/events{/privacy}","received_events_url":"https://api.github.com/users/nerzhul/received_events","type":"User","site_admin":false},"repo":{"id":29129586,"name":"minetest","full_name":"nerzhul/minetest","owner":{"login":"nerzhul","id":119752,"avatar_url":"https://avatars0.githubusercontent.com/u/119752?v=4","gravatar_id":"","url":"https://api.github.com/users/nerzhul","html_url":"https://github.com/nerzhul","followers_url":"https://api.github.com/users/nerzhul/followers","following_url":"https://api.github.com/users/nerzhul/following{/other_user}","gists_url":"https://api.github.com/users/nerzhul/gists{/gist_id}","starred_url":"https://api.github.com/users/nerzhul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerzhul/subscriptions","organizations_url":"https://api.github.com/users/nerzhul/orgs","repos_url":"https://api.github.com/users/nerzhul/repos","events_url":"https://api.github.com/users/nerzhul/events{/privacy}","received_events_url":"https://api.github.com/users/nerzhul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nerzhul/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/nerzhul/minetest","forks_url":"https://api.github.com/repos/nerzhul/minetest/forks","keys_url":"https://api.github.com/repos/nerzhul/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nerzhul/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nerzhul/minetest/teams","hooks_url":"https://api.github.com/repos/nerzhul/minetest/hooks","issue_events_url":"https://api.github.com/repos/nerzhul/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/nerzhul/minetest/events","assignees_url":"https://api.github.com/repos/nerzhul/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/nerzhul/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/nerzhul/minetest/tags","blobs_url":"https://api.github.com/repos/nerzhul/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nerzhul/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nerzhul/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/nerzhul/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nerzhul/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/nerzhul/minetest/languages","stargazers_url":"https://api.github.com/repos/nerzhul/minetest/stargazers","contributors_url":"https://api.github.com/repos/nerzhul/minetest/contributors","subscribers_url":"https://api.github.com/repos/nerzhul/minetest/subscribers","subscription_url":"https://api.github.com/repos/nerzhul/minetest/subscription","commits_url":"https://api.github.com/repos/nerzhul/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/nerzhul/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/nerzhul/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/nerzhul/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/nerzhul/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/nerzhul/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nerzhul/minetest/merges","archive_url":"https://api.github.com/repos/nerzhul/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nerzhul/minetest/downloads","issues_url":"https://api.github.com/repos/nerzhul/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/nerzhul/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/nerzhul/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/nerzhul/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nerzhul/minetest/labels{/name}","releases_url":"https://api.github.com/repos/nerzhul/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/nerzhul/minetest/deployments","created_at":"2015-01-12T10:05:26Z","updated_at":"2017-01-01T13:50:51Z","pushed_at":"2017-08-20T12:30:15Z","git_url":"git://github.com/nerzhul/minetest.git","ssh_url":"git@github.com:nerzhul/minetest.git","clone_url":"https://github.com/nerzhul/minetest.git","svn_url":"https://github.com/nerzhul/minetest","homepage":"http://minetest.net/","size":50684,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"1c1c97cbd1d7913ac12bf550ec02c97f843a0fd3","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars1.githubusercontent.com/u/2624745?v=4","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","deployments_url":"https://api.github.com/repos/minetest/minetest/deployments","created_at":"2011-08-07T13:48:36Z","updated_at":"2017-08-20T04:40:32Z","pushed_at":"2017-08-20T12:54:28Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":50626,"stargazers_count":2715,"watchers_count":2715,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":816,"mirror_url":null,"open_issues_count":1034,"forks":816,"open_issues":1034,"watchers":2715,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/6290"},"html":{"href":"https://github.com/minetest/minetest/pull/6290"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/6290"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/6290/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/6290/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/6290/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/831c1cb411bea18586153ed996037d01db869388"}}}}
{"actor":{"display_login":"SmallJoker"}}