{"action":"created","issue":{"url":"https://api.github.com/repos/byu-oit/ios-byuSuite/issues/193","repository_url":"https://api.github.com/repos/byu-oit/ios-byuSuite","labels_url":"https://api.github.com/repos/byu-oit/ios-byuSuite/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/byu-oit/ios-byuSuite/issues/193/comments","events_url":"https://api.github.com/repos/byu-oit/ios-byuSuite/issues/193/events","html_url":"https://github.com/byu-oit/ios-byuSuite/pull/193","id":238624785,"number":193,"title":"Hotfix/cannon commons","user":{"login":"ecbrady","id":12305705,"avatar_url":"https://avatars0.githubusercontent.com/u/12305705?v=3","gravatar_id":"","url":"https://api.github.com/users/ecbrady","html_url":"https://github.com/ecbrady","followers_url":"https://api.github.com/users/ecbrady/followers","following_url":"https://api.github.com/users/ecbrady/following{/other_user}","gists_url":"https://api.github.com/users/ecbrady/gists{/gist_id}","starred_url":"https://api.github.com/users/ecbrady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecbrady/subscriptions","organizations_url":"https://api.github.com/users/ecbrady/orgs","repos_url":"https://api.github.com/users/ecbrady/repos","events_url":"https://api.github.com/users/ecbrady/events{/privacy}","received_events_url":"https://api.github.com/users/ecbrady/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-06-26T18:09:29Z","updated_at":"2017-06-28T16:12:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/byu-oit/ios-byuSuite/pulls/193","html_url":"https://github.com/byu-oit/ios-byuSuite/pull/193","diff_url":"https://github.com/byu-oit/ios-byuSuite/pull/193.diff","patch_url":"https://github.com/byu-oit/ios-byuSuite/pull/193.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/byu-oit/ios-byusuite/193)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/byu-oit/ios-byuSuite/issues/comments/311709691","html_url":"https://github.com/byu-oit/ios-byuSuite/pull/193#issuecomment-311709691","issue_url":"https://api.github.com/repos/byu-oit/ios-byuSuite/issues/193","id":311709691,"user":{"login":"romrell4","id":15692420,"avatar_url":"https://avatars3.githubusercontent.com/u/15692420?v=3","gravatar_id":"","url":"https://api.github.com/users/romrell4","html_url":"https://github.com/romrell4","followers_url":"https://api.github.com/users/romrell4/followers","following_url":"https://api.github.com/users/romrell4/following{/other_user}","gists_url":"https://api.github.com/users/romrell4/gists{/gist_id}","starred_url":"https://api.github.com/users/romrell4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romrell4/subscriptions","organizations_url":"https://api.github.com/users/romrell4/orgs","repos_url":"https://api.github.com/users/romrell4/repos","events_url":"https://api.github.com/users/romrell4/events{/privacy}","received_events_url":"https://api.github.com/users/romrell4/received_events","type":"User","site_admin":false},"created_at":"2017-06-28T16:12:15Z","updated_at":"2017-06-28T16:12:15Z","body":"\n\n\n\nReviewed 13 of 13 files at r2.\nReview status: 35 of 36 files reviewed at latest revision, 19 unresolved discussions.\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.swift, line 32 at r1](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/193#-Kn_zas5V4rJ_AWQtP66:-KnjNFfcBtNhp65f2lRK:bjl65gj) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/78cd199c82fd4ef2dcc2ae211ae94b7201c92473/byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.swift#L32)):*\n<details><summary><i>Previously, ecbrady (Erik Brady) wrote…</i></summary><blockquote>\n\nIf I make it public then I can use it in the LegalVC when we use the same key. Is that okay?\n</blockquote></details>\n\nAbsolutely. Just make it explicitly \"public\" so that nobody wonders if it was supposed to be private\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.swift, line 83 at r1](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/193#-Kna-bb8PghDBQPAbCsd:-KnjO1TqQ-o9PJIi-oVV:b-yf4pv9) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/78cd199c82fd4ef2dcc2ae211ae94b7201c92473/byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.swift#L83)):*\n<details><summary><i>Previously, ecbrady (Erik Brady) wrote…</i></summary><blockquote>\n\nYeah it's only with TableData.  I'll look at using it if I can rewrite this with TableData\n</blockquote></details>\n\nGreat. Look into it :)\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.swift, line 96 at r1](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/193#-Kna-mzbeFcmoHcYgq_k:-KnjO7cwABhFDMHCzUz1:b-b3xt11) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/78cd199c82fd4ef2dcc2ae211ae94b7201c92473/byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.swift#L96)):*\n<details><summary><i>Previously, ecbrady (Erik Brady) wrote…</i></summary><blockquote>\n\nEvery time they change the date it'll reload. We added this when I was working on this months ago because it would cause issues if they clicked on a meal during the data load because it was passing the old data with the new date which causes conflicting data to be passed to the service to load the menus. \n</blockquote></details>\n\nGood call. Put a comment here about that\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.swift, line 107 at r1](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/193#-Kna0CKFAMpLNRGafZBQ:-KnjOBF6Tn8BvEeiTjj7:b2ryorg) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/78cd199c82fd4ef2dcc2ae211ae94b7201c92473/byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.swift#L107)):*\n<details><summary><i>Previously, ecbrady (Erik Brady) wrote…</i></summary><blockquote>\n\nI don't think so. Because we're not sorting them alphabetically but ordering them in Breakfast, Lunch, Dinner sequence.\n</blockquote></details>\n\nIs meals just a list of strings? Or are they objects? If they're objects, we can make the object comparable and make the B, F, D ordering work\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.swift, line 118 at r1](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/193#-Kna0LQCIpwFi9KjIiTV:-KnjOQdD5qlWLb-TVCe0:bebx5tl) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/78cd199c82fd4ef2dcc2ae211ae94b7201c92473/byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.swift#L118)):*\n<details><summary><i>Previously, ecbrady (Erik Brady) wrote…</i></summary><blockquote>\n\nI simply duplicated what was being done in the original objective-c code. The only difference is Swift no longer allows old c loops so I had to redo it with forin loops. But it's doing the exact same thing.\n</blockquote></details>\n\nSo is this ONLY sorting into Breakfast, Lunch, and Dinner? If so, I think we can come up with a much simpler way of doing it\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.swift, line 63 at r2](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/193#-KnjNfTq5PAH4teU0XAZ:-KnjNfTq5PAH4teU0XA_:b9jap66) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/1c3cab7679ecb6a2f4346a2b7637d4e4ed3bf8c4/byuSuite/Apps/CannonCommons/controller/CannonCommonsDatePickerViewController.swift#L63)):*\n> ```Swift\n>     \n>     func tableView(_ tableView: UITableView, titleForHeaderInSection section: Int) -> String? {\n>         let title = \" \\(dayFormatter.string(from: datePicker.date))\"\n> ```\n\nWe really gotta figure out how we can make this default. Maybe we'll make the ByuViewController implement the viewForHeader and call this or something... Do you have any ideas to make the formatting consistent between all of our view controllers without adding a space or two every time?\n\nIf not, I think we use two spaces in most of the app. If that's so, add a space to this one\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsFilterViewController.swift, line 38 at r1](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/193#-Kna1IP1N_9hO-e50QCm:-KnjOrHA0dt1IroYsUZr:b-wokmaz) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/78cd199c82fd4ef2dcc2ae211ae94b7201c92473/byuSuite/Apps/CannonCommons/controller/CannonCommonsFilterViewController.swift#L38)):*\n<details><summary><i>Previously, ecbrady (Erik Brady) wrote…</i></summary><blockquote>\n\nNo. We tried but then you had me put it on TableData instead of as an extension.\n</blockquote></details>\n\nThat's right. Can we do that? It would be a really easy extension. We could even use it in the TableData extension that we wrote\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsFullMenuViewController.swift, line 102 at r2](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/193#-KnjPV32lY0aZ5BekkDM:-KnjPV32lY0aZ5BekkDN:bc6oah5) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/1c3cab7679ecb6a2f4346a2b7637d4e4ed3bf8c4/byuSuite/Apps/CannonCommons/controller/CannonCommonsFullMenuViewController.swift#L102)):*\n> ```Swift\n>         allergenFilteredMenu.removeAll()\n>         //Check each station in the menu\n>         for (key, station) in menu {\n> ```\n\nRename station to recipes\n\n---\n\n*[byuSuite/Apps/CannonCommons/controller/CannonCommonsMenuViewController.swift, line 19 at r1](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/193#-KnakTWhz_pi8b259GYb:-KnjPg5EIoC-s09Jqbne:bfjqnzy) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/78cd199c82fd4ef2dcc2ae211ae94b7201c92473/byuSuite/Apps/CannonCommons/controller/CannonCommonsMenuViewController.swift#L19)):*\n<details><summary><i>Previously, ecbrady (Erik Brady) wrote…</i></summary><blockquote>\n\nI use ! because the view cannot be opened without first setting recipes in the prepareForSegue and by using ! I won't have to force unwrap recipes each time I use it and I can use less code since I won't need to add all the if lets. \n</blockquote></details>\n\nThat makes sense. However, you wouldn't have to force unwrap if you use () either. Is there another benefit of ! over () that I'm not aware of?\n\n---\n\n*[byuSuite/Apps/CannonCommons/model/CannonCommonsAllergenFilter.swift, line 9 at r2](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/193#-KnjS-NdS-xmAZXJioq6:-KnjS-NdS-xmAZXJioq7:b-1hj4hy) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/1c3cab7679ecb6a2f4346a2b7637d4e4ed3bf8c4/byuSuite/Apps/CannonCommons/model/CannonCommonsAllergenFilter.swift#L9)):*\n> ```Swift\n> //\n> \n> let ALLERGEN_FILTER_NOTIFICATION = NSNotification.Name(\"AllergenFilterUpdated\")\n> ```\n\nLet's make this explicitly public\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/193)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"romrell4"}}