{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls/comments/140642599","pull_request_review_id":64748839,"id":140642599,"diff_hunk":"@@ -186,9 +186,6 @@ public String getInstrumentationKey() {\n      * @throws IllegalArgumentException when the new value is null or empty\n      */\n     public void setInstrumentationKey(String key) {\n-        if (!Sanitizer.isUUID(key)) {","path":"core/src/main/java/com/microsoft/applicationinsights/TelemetryConfiguration.java","position":28,"original_position":4,"commit_id":"ef1e99e28e3d7cb7e66a2185cd694a9e244925aa","original_commit_id":"2722eb9e03ff9f151eb9b94c68d057e549ff7ef1","user":{"login":"dhaval24","id":16353121,"avatar_url":"https://avatars0.githubusercontent.com/u/16353121?v=4","gravatar_id":"","url":"https://api.github.com/users/dhaval24","html_url":"https://github.com/dhaval24","followers_url":"https://api.github.com/users/dhaval24/followers","following_url":"https://api.github.com/users/dhaval24/following{/other_user}","gists_url":"https://api.github.com/users/dhaval24/gists{/gist_id}","starred_url":"https://api.github.com/users/dhaval24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhaval24/subscriptions","organizations_url":"https://api.github.com/users/dhaval24/orgs","repos_url":"https://api.github.com/users/dhaval24/repos","events_url":"https://api.github.com/users/dhaval24/events{/privacy}","received_events_url":"https://api.github.com/users/dhaval24/received_events","type":"User","site_admin":false},"body":"@Dmitry-Matveev I have removed unused imports from most of the places, removed obsolete and replaced with Depricated at maximum locations and added couple of test cases which logically cover maximum scenarios. Please review.","created_at":"2017-09-23T21:56:14Z","updated_at":"2017-09-23T21:56:14Z","html_url":"https://github.com/Microsoft/ApplicationInsights-Java/pull/431#discussion_r140642599","pull_request_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls/431","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls/comments/140642599"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-Java/pull/431#discussion_r140642599"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls/431"}},"in_reply_to_id":140624296},"pull_request":{"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls/431","id":142213259,"html_url":"https://github.com/Microsoft/ApplicationInsights-Java/pull/431","diff_url":"https://github.com/Microsoft/ApplicationInsights-Java/pull/431.diff","patch_url":"https://github.com/Microsoft/ApplicationInsights-Java/pull/431.patch","issue_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/issues/431","number":431,"state":"open","locked":false,"title":"Reorganize sanitization logic (Please review carefully)","user":{"login":"dhaval24","id":16353121,"avatar_url":"https://avatars0.githubusercontent.com/u/16353121?v=4","gravatar_id":"","url":"https://api.github.com/users/dhaval24","html_url":"https://github.com/dhaval24","followers_url":"https://api.github.com/users/dhaval24/followers","following_url":"https://api.github.com/users/dhaval24/following{/other_user}","gists_url":"https://api.github.com/users/dhaval24/gists{/gist_id}","starred_url":"https://api.github.com/users/dhaval24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhaval24/subscriptions","organizations_url":"https://api.github.com/users/dhaval24/orgs","repos_url":"https://api.github.com/users/dhaval24/repos","events_url":"https://api.github.com/users/dhaval24/events{/privacy}","received_events_url":"https://api.github.com/users/dhaval24/received_events","type":"User","site_admin":false},"body":"Fix #429 #426 \r\n.\r\nThis pull request moves all the sanitization logic to JsonTelemetryDataSerialiazer, updates bond definitions to generate write methods with limits according to our new schema. \r\n\r\nThis pull request also obsoletes many classes in SchemaV2 package which are now no longer in use.\r\nObsoletes most of the methods of Sanitizer class, disables the pre-sanitization in track() method of TelemetryClient and obsoletes sanitize() method in Telemetry interface and all the classes which implement it.\r\n\r\nThis pull requests also adds getter and setter for OperationParentId. \r\n\r\nThere are many tests also which are updated to incorporate these changes. New tests have been added to JsonTelemetryDataSerializerTest class to check serialization and length limits.\r\n\r\nNote: There are lot of changes please review it carefully before we can merge this! I would suggest create a local build from this branch and test on your Java applications if possible. Also provide advice on if there is need for writing more test cases. \r\n\r\nFor significant contributions please make sure you have completed the following items:\r\n\r\n- [x] Changes in public surface reviewed\r\n- [x] CHANGELOG.md updated\r\n","created_at":"2017-09-20T22:01:14Z","updated_at":"2017-09-23T21:56:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c27b484db3fe942cad77fed937da9f94b13a6f7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"grlima","id":13428707,"avatar_url":"https://avatars1.githubusercontent.com/u/13428707?v=4","gravatar_id":"","url":"https://api.github.com/users/grlima","html_url":"https://github.com/grlima","followers_url":"https://api.github.com/users/grlima/followers","following_url":"https://api.github.com/users/grlima/following{/other_user}","gists_url":"https://api.github.com/users/grlima/gists{/gist_id}","starred_url":"https://api.github.com/users/grlima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grlima/subscriptions","organizations_url":"https://api.github.com/users/grlima/orgs","repos_url":"https://api.github.com/users/grlima/repos","events_url":"https://api.github.com/users/grlima/events{/privacy}","received_events_url":"https://api.github.com/users/grlima/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls/431/commits","review_comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls/431/comments","review_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/issues/431/comments","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/statuses/ef1e99e28e3d7cb7e66a2185cd694a9e244925aa","head":{"label":"Microsoft:reorganizeSanitizationLogic","ref":"reorganizeSanitizationLogic","sha":"ef1e99e28e3d7cb7e66a2185cd694a9e244925aa","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27460436,"name":"ApplicationInsights-Java","full_name":"Microsoft/ApplicationInsights-Java","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-Java","description":"Application Insights SDK for Java","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/deployments","created_at":"2014-12-03T00:13:22Z","updated_at":"2017-09-11T17:31:58Z","pushed_at":"2017-09-23T21:53:42Z","git_url":"git://github.com/Microsoft/ApplicationInsights-Java.git","ssh_url":"git@github.com:Microsoft/ApplicationInsights-Java.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-Java.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-Java","homepage":"http://aka.ms/applicationinsights","size":3013,"stargazers_count":40,"watchers_count":40,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":60,"forks":33,"open_issues":60,"watchers":40,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"cbdef0c9260694d6f37705e73c7d0d16c3610034","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":27460436,"name":"ApplicationInsights-Java","full_name":"Microsoft/ApplicationInsights-Java","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/ApplicationInsights-Java","description":"Application Insights SDK for Java","fork":false,"url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java","forks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/forks","keys_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/teams","hooks_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/events","assignees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/tags","blobs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/languages","stargazers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/subscription","commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/merges","archive_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/downloads","issues_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/deployments","created_at":"2014-12-03T00:13:22Z","updated_at":"2017-09-11T17:31:58Z","pushed_at":"2017-09-23T21:53:42Z","git_url":"git://github.com/Microsoft/ApplicationInsights-Java.git","ssh_url":"git@github.com:Microsoft/ApplicationInsights-Java.git","clone_url":"https://github.com/Microsoft/ApplicationInsights-Java.git","svn_url":"https://github.com/Microsoft/ApplicationInsights-Java","homepage":"http://aka.ms/applicationinsights","size":3013,"stargazers_count":40,"watchers_count":40,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":60,"forks":33,"open_issues":60,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls/431"},"html":{"href":"https://github.com/Microsoft/ApplicationInsights-Java/pull/431"},"issue":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/issues/431"},"comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/issues/431/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls/431/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/pulls/431/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/ApplicationInsights-Java/statuses/ef1e99e28e3d7cb7e66a2185cd694a9e244925aa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dhaval24"}}