{"action":"closed","issue":{"url":"https://api.github.com/repos/mozilla/rr/issues/1941","repository_url":"https://api.github.com/repos/mozilla/rr","labels_url":"https://api.github.com/repos/mozilla/rr/issues/1941/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/rr/issues/1941/comments","events_url":"https://api.github.com/repos/mozilla/rr/issues/1941/events","html_url":"https://github.com/mozilla/rr/issues/1941","id":202674902,"number":1941,"title":"`Task::did_waitpid` does not normalize registers when it should","user":{"login":"rocallahan","id":296135,"avatar_url":"https://avatars.githubusercontent.com/u/296135?v=3","gravatar_id":"","url":"https://api.github.com/users/rocallahan","html_url":"https://github.com/rocallahan","followers_url":"https://api.github.com/users/rocallahan/followers","following_url":"https://api.github.com/users/rocallahan/following{/other_user}","gists_url":"https://api.github.com/users/rocallahan/gists{/gist_id}","starred_url":"https://api.github.com/users/rocallahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rocallahan/subscriptions","organizations_url":"https://api.github.com/users/rocallahan/orgs","repos_url":"https://api.github.com/users/rocallahan/repos","events_url":"https://api.github.com/users/rocallahan/events{/privacy}","received_events_url":"https://api.github.com/users/rocallahan/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-01-23T22:52:42Z","updated_at":"2017-01-23T23:27:44Z","closed_at":"2017-01-23T23:27:44Z","body":"@Keno commit 70de61ab24985b465d4c530ed3043bf87cd255ca changed `Task::did_waitpid` so that `fixup_syscall_registers` is only called for syscalls through the rr-page. This is incorrect because under some conditions (which I haven't puzzled out) RCX is not set to -1 during replay while it is during recording. I consistently get divergence due to this issue ... while replaying a recording of rr doing a replay using some rather complicated binary instrumentation stuff, so it's not easy to reduce the testcase."}}
{"actor":{"display_login":"rocallahan"}}