{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/5765","repository_url":"https://api.github.com/repos/puppetlabs/puppet","labels_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5765/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5765/comments","events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5765/events","html_url":"https://github.com/puppetlabs/puppet/pull/5765","id":217383076,"number":5765,"title":"(docs) Clarify the behavior of the group resource type's _membership attributes","user":{"login":"nfagerlund","id":484309,"avatar_url":"https://avatars0.githubusercontent.com/u/484309?v=3","gravatar_id":"","url":"https://api.github.com/users/nfagerlund","html_url":"https://github.com/nfagerlund","followers_url":"https://api.github.com/users/nfagerlund/followers","following_url":"https://api.github.com/users/nfagerlund/following{/other_user}","gists_url":"https://api.github.com/users/nfagerlund/gists{/gist_id}","starred_url":"https://api.github.com/users/nfagerlund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nfagerlund/subscriptions","organizations_url":"https://api.github.com/users/nfagerlund/orgs","repos_url":"https://api.github.com/users/nfagerlund/repos","events_url":"https://api.github.com/users/nfagerlund/events{/privacy}","received_events_url":"https://api.github.com/users/nfagerlund/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-03-27T21:37:42Z","updated_at":"2017-03-28T18:45:08Z","closed_at":"2017-03-28T18:44:07Z","pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/5765","html_url":"https://github.com/puppetlabs/puppet/pull/5765","diff_url":"https://github.com/puppetlabs/puppet/pull/5765.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/5765.patch"},"body":"When this PR is merged, **please close [DOCUMENT-356](https://tickets.puppetlabs.com/browse/DOCUMENT-356).**\r\n\r\nFor the record, I investigated the two group providers that use auth_membership. \r\n\r\nDirectoryService: `true` purges.\r\n\r\n``` ruby\r\n      remove_unwanted_members(current_members, value) if @resource[:auth_membership] and not current_members.nil?\r\n```\r\n\r\nWindows ADSI: `true` purges.\r\n\r\n``` ruby\r\n    group.set_members(members, @resource[:auth_membership])\r\n# ...\r\n    def set_members(desired_members, inclusive = true)\r\n      # ...\r\n      if inclusive\r\n        if desired_hash.empty?\r\n          members_to_remove = current_hash.values\r\n        else\r\n          members_to_remove = (current_hash.keys - desired_hash.keys).map { |sid| current_hash[sid] }\r\n        end\r\n\r\n        remove_member_sids(*members_to_remove)\r\n      end\r\n```"},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/289866589","html_url":"https://github.com/puppetlabs/puppet/pull/5765#issuecomment-289866589","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/5765","id":289866589,"user":{"login":"MosesMendoza","id":819133,"avatar_url":"https://avatars2.githubusercontent.com/u/819133?v=3","gravatar_id":"","url":"https://api.github.com/users/MosesMendoza","html_url":"https://github.com/MosesMendoza","followers_url":"https://api.github.com/users/MosesMendoza/followers","following_url":"https://api.github.com/users/MosesMendoza/following{/other_user}","gists_url":"https://api.github.com/users/MosesMendoza/gists{/gist_id}","starred_url":"https://api.github.com/users/MosesMendoza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MosesMendoza/subscriptions","organizations_url":"https://api.github.com/users/MosesMendoza/orgs","repos_url":"https://api.github.com/users/MosesMendoza/repos","events_url":"https://api.github.com/users/MosesMendoza/events{/privacy}","received_events_url":"https://api.github.com/users/MosesMendoza/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T18:45:08Z","updated_at":"2017-03-28T18:45:08Z","body":"DOCUMENT-356 resolved"}}
{"actor":{"display_login":"MosesMendoza"}}