{"action":"created","issue":{"url":"https://api.github.com/repos/python-trio/trio/issues/349","repository_url":"https://api.github.com/repos/python-trio/trio","labels_url":"https://api.github.com/repos/python-trio/trio/issues/349/labels{/name}","comments_url":"https://api.github.com/repos/python-trio/trio/issues/349/comments","events_url":"https://api.github.com/repos/python-trio/trio/issues/349/events","html_url":"https://github.com/python-trio/trio/pull/349","id":273285258,"number":349,"title":"Make measure_backlog more robust against weird errors","user":{"login":"njsmith","id":609896,"avatar_url":"https://avatars0.githubusercontent.com/u/609896?v=4","gravatar_id":"","url":"https://api.github.com/users/njsmith","html_url":"https://github.com/njsmith","followers_url":"https://api.github.com/users/njsmith/followers","following_url":"https://api.github.com/users/njsmith/following{/other_user}","gists_url":"https://api.github.com/users/njsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/njsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njsmith/subscriptions","organizations_url":"https://api.github.com/users/njsmith/orgs","repos_url":"https://api.github.com/users/njsmith/repos","events_url":"https://api.github.com/users/njsmith/events{/privacy}","received_events_url":"https://api.github.com/users/njsmith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-11-13T01:21:41Z","updated_at":"2017-11-13T04:31:29Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/python-trio/trio/pulls/349","html_url":"https://github.com/python-trio/trio/pull/349","diff_url":"https://github.com/python-trio/trio/pull/349.diff","patch_url":"https://github.com/python-trio/trio/pull/349.patch"},"body":"@nmalaguti is reporting that on a particular VPS they have access to,\nsometimes, the test_open_tcp_listeners_backlog test is blowing up with\nEMFILE and breaking other tests. It seems to involve the kernel\nswitching to using syn cookies, and then suddenly infinitely many\nconnection attempts can appear to succeed.\n\nA real fix would be to make the test robust against syncookies, but\nI'm not yet sure how to do that. In the mean time this at least should\nmake the test more robustly clean up after itself, so that this causes\na well-defined failure without shrapnel flying out to hit other tests."},"comment":{"url":"https://api.github.com/repos/python-trio/trio/issues/comments/343809390","html_url":"https://github.com/python-trio/trio/pull/349#issuecomment-343809390","issue_url":"https://api.github.com/repos/python-trio/trio/issues/349","id":343809390,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-11-13T04:31:29Z","updated_at":"2017-11-13T04:31:29Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=h1) Report\n> Merging [#349](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=desc) into [master](https://codecov.io/gh/python-trio/trio/commit/389f1e1e01b410756e2833cffb992fd1ff856ae5?src=pr&el=desc) will **decrease** coverage by `1.38%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/python-trio/trio/pull/349/graphs/tree.svg?height=150&token=Lhvc0OnSCw&width=650&src=pr)](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #349      +/-   ##\n==========================================\n- Coverage   99.24%   97.86%   -1.39%     \n==========================================\n  Files          87       87              \n  Lines       10397    10397              \n  Branches      730      730              \n==========================================\n- Hits        10319    10175     -144     \n- Misses         61      194     +133     \n- Partials       17       28      +11\n```\n\n\n| [Impacted Files](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [trio/tests/test\\_highlevel\\_open\\_tcp\\_listeners.py](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=tree#diff-dHJpby90ZXN0cy90ZXN0X2hpZ2hsZXZlbF9vcGVuX3RjcF9saXN0ZW5lcnMucHk=) | `100% <100%> (ø)` | :arrow_up: |\n| [trio/\\_core/\\_io\\_epoll.py](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=tree#diff-dHJpby9fY29yZS9faW9fZXBvbGwucHk=) | `0% <0%> (-100%)` | :arrow_down: |\n| [trio/\\_core/tests/test\\_epoll.py](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=tree#diff-dHJpby9fY29yZS90ZXN0cy90ZXN0X2Vwb2xsLnB5) | `27.77% <0%> (-72.23%)` | :arrow_down: |\n| [trio/\\_core/tests/tutil.py](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=tree#diff-dHJpby9fY29yZS90ZXN0cy90dXRpbC5weQ==) | `90.9% <0%> (-9.1%)` | :arrow_down: |\n| [trio/\\_util.py](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=tree#diff-dHJpby9fdXRpbC5weQ==) | `87% <0%> (-6%)` | :arrow_down: |\n| [trio/\\_core/\\_multierror.py](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=tree#diff-dHJpby9fY29yZS9fbXVsdGllcnJvci5weQ==) | `96.4% <0%> (-3.6%)` | :arrow_down: |\n| [trio/\\_deprecate.py](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=tree#diff-dHJpby9fZGVwcmVjYXRlLnB5) | `97.26% <0%> (-2.74%)` | :arrow_down: |\n| [trio/\\_socket.py](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=tree#diff-dHJpby9fc29ja2V0LnB5) | `97.66% <0%> (-2.34%)` | :arrow_down: |\n| [trio/\\_core/tests/test\\_result.py](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=tree#diff-dHJpby9fY29yZS90ZXN0cy90ZXN0X3Jlc3VsdC5weQ==) | `97.91% <0%> (-2.09%)` | :arrow_down: |\n| [trio/tests/test\\_socket.py](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=tree#diff-dHJpby90ZXN0cy90ZXN0X3NvY2tldC5weQ==) | `98.43% <0%> (-1.57%)` | :arrow_down: |\n| ... and [4 more](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=footer). Last update [389f1e1...80357fc](https://codecov.io/gh/python-trio/trio/pull/349?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}