{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/16118","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/16118/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/16118/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/16118/events","html_url":"https://github.com/nodejs/node/pull/16118","id":264111741,"number":16118,"title":"test: reduce run time for string_decoder benchmark","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"labels":[{"id":191708559,"url":"https://api.github.com/repos/nodejs/node/labels/benchmark","name":"benchmark","color":"009800","default":false},{"id":637807400,"url":"https://api.github.com/repos/nodejs/node/labels/CI%20/%20flaky%20test","name":"CI / flaky test","color":"ffff00","default":false},{"id":191697916,"url":"https://api.github.com/repos/nodejs/node/labels/string_decoder","name":"string_decoder","color":"fbca04","default":false},{"id":176240519,"url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-10-10T06:23:47Z","updated_at":"2017-10-10T14:44:18Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/16118","html_url":"https://github.com/nodejs/node/pull/16118","diff_url":"https://github.com/nodejs/node/pull/16118.diff","patch_url":"https://github.com/nodejs/node/pull/16118.patch"},"body":"test-benchmark-string_decoder was timing out in CI. Reduce the run time\r\nby sending appropriate options such that each benchmark file only runs\r\none combination of options.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ntest benchmark string_decoder"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/335496300","html_url":"https://github.com/nodejs/node/pull/16118#issuecomment-335496300","issue_url":"https://api.github.com/repos/nodejs/node/issues/16118","id":335496300,"user":{"login":"Trott","id":718899,"avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"created_at":"2017-10-10T14:44:18Z","updated_at":"2017-10-10T14:44:18Z","author_association":"OWNER","body":"CI again (infra failures from before): https://ci.nodejs.org/job/node-test-commit/12989/"}}
{"actor":{"display_login":"Trott"}}