{"action":"created","comment":{"url":"https://api.github.com/repos/apprenda/kismatic/pulls/comments/158340840","pull_request_review_id":85138349,"id":158340840,"diff_hunk":"@@ -1,68 +1,68 @@\n hash: f1e1c7515c49bc69417f943bf7c8dc863edf1b0936bd768db5284244e97ca0d5\n-updated: 2017-07-25T11:20:54.761474195-04:00","path":"glide.lock","position":2,"original_position":2,"commit_id":"5a50879172025c3825b2a861350ea030acf6efaf","original_commit_id":"5a50879172025c3825b2a861350ea030acf6efaf","user":{"login":"emmetthitz","id":6633471,"avatar_url":"https://avatars2.githubusercontent.com/u/6633471?v=4","gravatar_id":"","url":"https://api.github.com/users/emmetthitz","html_url":"https://github.com/emmetthitz","followers_url":"https://api.github.com/users/emmetthitz/followers","following_url":"https://api.github.com/users/emmetthitz/following{/other_user}","gists_url":"https://api.github.com/users/emmetthitz/gists{/gist_id}","starred_url":"https://api.github.com/users/emmetthitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emmetthitz/subscriptions","organizations_url":"https://api.github.com/users/emmetthitz/orgs","repos_url":"https://api.github.com/users/emmetthitz/repos","events_url":"https://api.github.com/users/emmetthitz/events{/privacy}","received_events_url":"https://api.github.com/users/emmetthitz/received_events","type":"User","site_admin":false},"body":"Yeah. I think so. If the import gets removed, a `glide update` should axe it.","created_at":"2017-12-21T18:01:58Z","updated_at":"2017-12-21T18:01:58Z","html_url":"https://github.com/apprenda/kismatic/pull/864#discussion_r158340840","pull_request_url":"https://api.github.com/repos/apprenda/kismatic/pulls/864","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/comments/158340840"},"html":{"href":"https://github.com/apprenda/kismatic/pull/864#discussion_r158340840"},"pull_request":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/864"}},"in_reply_to_id":158339690},"pull_request":{"url":"https://api.github.com/repos/apprenda/kismatic/pulls/864","id":147027615,"html_url":"https://github.com/apprenda/kismatic/pull/864","diff_url":"https://github.com/apprenda/kismatic/pull/864.diff","patch_url":"https://github.com/apprenda/kismatic/pull/864.patch","issue_url":"https://api.github.com/repos/apprenda/kismatic/issues/864","number":864,"state":"open","locked":false,"title":"Use RBAC","user":{"login":"dkoshkin","id":4969231,"avatar_url":"https://avatars1.githubusercontent.com/u/4969231?v=4","gravatar_id":"","url":"https://api.github.com/users/dkoshkin","html_url":"https://github.com/dkoshkin","followers_url":"https://api.github.com/users/dkoshkin/followers","following_url":"https://api.github.com/users/dkoshkin/following{/other_user}","gists_url":"https://api.github.com/users/dkoshkin/gists{/gist_id}","starred_url":"https://api.github.com/users/dkoshkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkoshkin/subscriptions","organizations_url":"https://api.github.com/users/dkoshkin/orgs","repos_url":"https://api.github.com/users/dkoshkin/repos","events_url":"https://api.github.com/users/dkoshkin/events{/privacy}","received_events_url":"https://api.github.com/users/dkoshkin/received_events","type":"User","site_admin":false},"body":"Fixes #771, fixes https://github.com/apprenda/kismatic/issues/778, fixes #989 \r\n\r\nRemoving ABAC needs to be a 2 step process.\r\n1st - Modify any addons to use RBAC, this guarantees that during upgrades components will function during the process.\r\n2nd - Remove ABAC in the next minor release\r\n\r\nFor any new installs only `ABAC` will not be enabled.\r\n\r\n~A big TODO is how to deploy the kubernetes dashboard. The newest version allows to use token based auth.~\r\nThe installer will now generate a new kubeconfig file with a token having admin access.\r\n```\r\n➜  out git:(use-rbac) ✗ ./kismatic dashboard\r\nError generating a kubeconfig file, you may still use the dashboard with your own ServiceAccount token\r\n\r\nOpening kubernetes dashboard in default browser...\r\nStarting to serve on 127.0.0.1:8001\r\n\r\n➜  out git:(use-rbac) ✗ ./kismatic dashboard\r\nOpening kubernetes dashboard in default browser...\r\nUse the kubeconfig in \"generated/dashboard-admin-kubeconfig\"\r\nStarting to serve on 127.0.0.1:8001\r\n\r\n```","created_at":"2017-10-17T12:44:08Z","updated_at":"2017-12-21T18:01:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a7c48ca839d973b3293bf103727187d3801cb2f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apprenda/kismatic/pulls/864/commits","review_comments_url":"https://api.github.com/repos/apprenda/kismatic/pulls/864/comments","review_comment_url":"https://api.github.com/repos/apprenda/kismatic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apprenda/kismatic/issues/864/comments","statuses_url":"https://api.github.com/repos/apprenda/kismatic/statuses/5a50879172025c3825b2a861350ea030acf6efaf","head":{"label":"apprenda:use-rbac","ref":"use-rbac","sha":"5a50879172025c3825b2a861350ea030acf6efaf","user":{"login":"apprenda","id":6901411,"avatar_url":"https://avatars2.githubusercontent.com/u/6901411?v=4","gravatar_id":"","url":"https://api.github.com/users/apprenda","html_url":"https://github.com/apprenda","followers_url":"https://api.github.com/users/apprenda/followers","following_url":"https://api.github.com/users/apprenda/following{/other_user}","gists_url":"https://api.github.com/users/apprenda/gists{/gist_id}","starred_url":"https://api.github.com/users/apprenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apprenda/subscriptions","organizations_url":"https://api.github.com/users/apprenda/orgs","repos_url":"https://api.github.com/users/apprenda/repos","events_url":"https://api.github.com/users/apprenda/events{/privacy}","received_events_url":"https://api.github.com/users/apprenda/received_events","type":"Organization","site_admin":false},"repo":{"id":64937285,"name":"kismatic","full_name":"apprenda/kismatic","owner":{"login":"apprenda","id":6901411,"avatar_url":"https://avatars2.githubusercontent.com/u/6901411?v=4","gravatar_id":"","url":"https://api.github.com/users/apprenda","html_url":"https://github.com/apprenda","followers_url":"https://api.github.com/users/apprenda/followers","following_url":"https://api.github.com/users/apprenda/following{/other_user}","gists_url":"https://api.github.com/users/apprenda/gists{/gist_id}","starred_url":"https://api.github.com/users/apprenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apprenda/subscriptions","organizations_url":"https://api.github.com/users/apprenda/orgs","repos_url":"https://api.github.com/users/apprenda/repos","events_url":"https://api.github.com/users/apprenda/events{/privacy}","received_events_url":"https://api.github.com/users/apprenda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apprenda/kismatic","description":"Kismatic Enterprise Toolkit: Fully-Automated, Production-Grade Kubernetes Operations","fork":false,"url":"https://api.github.com/repos/apprenda/kismatic","forks_url":"https://api.github.com/repos/apprenda/kismatic/forks","keys_url":"https://api.github.com/repos/apprenda/kismatic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apprenda/kismatic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apprenda/kismatic/teams","hooks_url":"https://api.github.com/repos/apprenda/kismatic/hooks","issue_events_url":"https://api.github.com/repos/apprenda/kismatic/issues/events{/number}","events_url":"https://api.github.com/repos/apprenda/kismatic/events","assignees_url":"https://api.github.com/repos/apprenda/kismatic/assignees{/user}","branches_url":"https://api.github.com/repos/apprenda/kismatic/branches{/branch}","tags_url":"https://api.github.com/repos/apprenda/kismatic/tags","blobs_url":"https://api.github.com/repos/apprenda/kismatic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apprenda/kismatic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apprenda/kismatic/git/refs{/sha}","trees_url":"https://api.github.com/repos/apprenda/kismatic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apprenda/kismatic/statuses/{sha}","languages_url":"https://api.github.com/repos/apprenda/kismatic/languages","stargazers_url":"https://api.github.com/repos/apprenda/kismatic/stargazers","contributors_url":"https://api.github.com/repos/apprenda/kismatic/contributors","subscribers_url":"https://api.github.com/repos/apprenda/kismatic/subscribers","subscription_url":"https://api.github.com/repos/apprenda/kismatic/subscription","commits_url":"https://api.github.com/repos/apprenda/kismatic/commits{/sha}","git_commits_url":"https://api.github.com/repos/apprenda/kismatic/git/commits{/sha}","comments_url":"https://api.github.com/repos/apprenda/kismatic/comments{/number}","issue_comment_url":"https://api.github.com/repos/apprenda/kismatic/issues/comments{/number}","contents_url":"https://api.github.com/repos/apprenda/kismatic/contents/{+path}","compare_url":"https://api.github.com/repos/apprenda/kismatic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apprenda/kismatic/merges","archive_url":"https://api.github.com/repos/apprenda/kismatic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apprenda/kismatic/downloads","issues_url":"https://api.github.com/repos/apprenda/kismatic/issues{/number}","pulls_url":"https://api.github.com/repos/apprenda/kismatic/pulls{/number}","milestones_url":"https://api.github.com/repos/apprenda/kismatic/milestones{/number}","notifications_url":"https://api.github.com/repos/apprenda/kismatic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apprenda/kismatic/labels{/name}","releases_url":"https://api.github.com/repos/apprenda/kismatic/releases{/id}","deployments_url":"https://api.github.com/repos/apprenda/kismatic/deployments","created_at":"2016-08-04T13:33:36Z","updated_at":"2017-12-19T17:58:41Z","pushed_at":"2017-12-21T16:04:17Z","git_url":"git://github.com/apprenda/kismatic.git","ssh_url":"git@github.com:apprenda/kismatic.git","clone_url":"https://github.com/apprenda/kismatic.git","svn_url":"https://github.com/apprenda/kismatic","homepage":"","size":7197,"stargazers_count":590,"watchers_count":590,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":97,"open_issues":74,"watchers":590,"default_branch":"master"}},"base":{"label":"apprenda:ket-1.7.0","ref":"ket-1.7.0","sha":"22df9185e0639a7125ad86f20c58f9f1a4123c05","user":{"login":"apprenda","id":6901411,"avatar_url":"https://avatars2.githubusercontent.com/u/6901411?v=4","gravatar_id":"","url":"https://api.github.com/users/apprenda","html_url":"https://github.com/apprenda","followers_url":"https://api.github.com/users/apprenda/followers","following_url":"https://api.github.com/users/apprenda/following{/other_user}","gists_url":"https://api.github.com/users/apprenda/gists{/gist_id}","starred_url":"https://api.github.com/users/apprenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apprenda/subscriptions","organizations_url":"https://api.github.com/users/apprenda/orgs","repos_url":"https://api.github.com/users/apprenda/repos","events_url":"https://api.github.com/users/apprenda/events{/privacy}","received_events_url":"https://api.github.com/users/apprenda/received_events","type":"Organization","site_admin":false},"repo":{"id":64937285,"name":"kismatic","full_name":"apprenda/kismatic","owner":{"login":"apprenda","id":6901411,"avatar_url":"https://avatars2.githubusercontent.com/u/6901411?v=4","gravatar_id":"","url":"https://api.github.com/users/apprenda","html_url":"https://github.com/apprenda","followers_url":"https://api.github.com/users/apprenda/followers","following_url":"https://api.github.com/users/apprenda/following{/other_user}","gists_url":"https://api.github.com/users/apprenda/gists{/gist_id}","starred_url":"https://api.github.com/users/apprenda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apprenda/subscriptions","organizations_url":"https://api.github.com/users/apprenda/orgs","repos_url":"https://api.github.com/users/apprenda/repos","events_url":"https://api.github.com/users/apprenda/events{/privacy}","received_events_url":"https://api.github.com/users/apprenda/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apprenda/kismatic","description":"Kismatic Enterprise Toolkit: Fully-Automated, Production-Grade Kubernetes Operations","fork":false,"url":"https://api.github.com/repos/apprenda/kismatic","forks_url":"https://api.github.com/repos/apprenda/kismatic/forks","keys_url":"https://api.github.com/repos/apprenda/kismatic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apprenda/kismatic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apprenda/kismatic/teams","hooks_url":"https://api.github.com/repos/apprenda/kismatic/hooks","issue_events_url":"https://api.github.com/repos/apprenda/kismatic/issues/events{/number}","events_url":"https://api.github.com/repos/apprenda/kismatic/events","assignees_url":"https://api.github.com/repos/apprenda/kismatic/assignees{/user}","branches_url":"https://api.github.com/repos/apprenda/kismatic/branches{/branch}","tags_url":"https://api.github.com/repos/apprenda/kismatic/tags","blobs_url":"https://api.github.com/repos/apprenda/kismatic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apprenda/kismatic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apprenda/kismatic/git/refs{/sha}","trees_url":"https://api.github.com/repos/apprenda/kismatic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apprenda/kismatic/statuses/{sha}","languages_url":"https://api.github.com/repos/apprenda/kismatic/languages","stargazers_url":"https://api.github.com/repos/apprenda/kismatic/stargazers","contributors_url":"https://api.github.com/repos/apprenda/kismatic/contributors","subscribers_url":"https://api.github.com/repos/apprenda/kismatic/subscribers","subscription_url":"https://api.github.com/repos/apprenda/kismatic/subscription","commits_url":"https://api.github.com/repos/apprenda/kismatic/commits{/sha}","git_commits_url":"https://api.github.com/repos/apprenda/kismatic/git/commits{/sha}","comments_url":"https://api.github.com/repos/apprenda/kismatic/comments{/number}","issue_comment_url":"https://api.github.com/repos/apprenda/kismatic/issues/comments{/number}","contents_url":"https://api.github.com/repos/apprenda/kismatic/contents/{+path}","compare_url":"https://api.github.com/repos/apprenda/kismatic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apprenda/kismatic/merges","archive_url":"https://api.github.com/repos/apprenda/kismatic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apprenda/kismatic/downloads","issues_url":"https://api.github.com/repos/apprenda/kismatic/issues{/number}","pulls_url":"https://api.github.com/repos/apprenda/kismatic/pulls{/number}","milestones_url":"https://api.github.com/repos/apprenda/kismatic/milestones{/number}","notifications_url":"https://api.github.com/repos/apprenda/kismatic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apprenda/kismatic/labels{/name}","releases_url":"https://api.github.com/repos/apprenda/kismatic/releases{/id}","deployments_url":"https://api.github.com/repos/apprenda/kismatic/deployments","created_at":"2016-08-04T13:33:36Z","updated_at":"2017-12-19T17:58:41Z","pushed_at":"2017-12-21T16:04:17Z","git_url":"git://github.com/apprenda/kismatic.git","ssh_url":"git@github.com:apprenda/kismatic.git","clone_url":"https://github.com/apprenda/kismatic.git","svn_url":"https://github.com/apprenda/kismatic","homepage":"","size":7197,"stargazers_count":590,"watchers_count":590,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":74,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":97,"open_issues":74,"watchers":590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/864"},"html":{"href":"https://github.com/apprenda/kismatic/pull/864"},"issue":{"href":"https://api.github.com/repos/apprenda/kismatic/issues/864"},"comments":{"href":"https://api.github.com/repos/apprenda/kismatic/issues/864/comments"},"review_comments":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/864/comments"},"review_comment":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apprenda/kismatic/pulls/864/commits"},"statuses":{"href":"https://api.github.com/repos/apprenda/kismatic/statuses/5a50879172025c3825b2a861350ea030acf6efaf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"emmetthitz"}}