{"action":"created","comment":{"url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls/comments/109304545","pull_request_review_id":30400285,"id":109304545,"diff_hunk":"@@ -1,82 +1,70 @@\n package nl.tudelft.jpacman.board;\n \n-import static org.junit.Assert.assertEquals;\n-import static org.mockito.Mockito.mock;\n+import org.junit.jupiter.api.DynamicTest;\n+import org.junit.jupiter.api.Test;\n+import org.junit.jupiter.api.TestFactory;\n+\n+import java.util.Arrays;\n \n-import org.junit.Before;\n-import org.junit.Test;\n+import static org.assertj.core.api.Assertions.assertThat;\n+import static org.junit.jupiter.api.DynamicTest.dynamicTest;\n+import static org.mockito.Mockito.mock;\n \n /**\n  * Test various aspects of board.\n- * \n+ *\n  * @author Jeroen Roosen \n  */\n public class BoardTest {\n \n-\tprivate Board board;\n-\t\n-\tprivate final Square x0y0 = mock(Square.class);\n-\tprivate final Square x0y1 = mock(Square.class);\n-\tprivate final Square x0y2 = mock(Square.class);\n-\tprivate final Square x1y0 = mock(Square.class);\n-\tprivate final Square x1y1 = mock(Square.class);\n-\tprivate final Square x1y2 = mock(Square.class);\n-\t\n-\tprivate static final int MAX_WIDTH = 2;\n-\tprivate static final int MAX_HEIGHT = 3;\n-\t\n-\t/**\n-\t * Setup a board that can be used for testing.\n-\t */\n-\t@Before\n-\tpublic void setUp() {\n-\t\tSquare[][] grid = new Square[MAX_WIDTH][MAX_HEIGHT];\n-\t\tgrid[0][0] = x0y0;\n-\t\tgrid[0][1] = x0y1;\n-\t\tgrid[0][2] = x0y2;\n-\t\tgrid[1][0] = x1y0;\n-\t\tgrid[1][1] = x1y1;\n-\t\tgrid[1][2] = x1y2;\n-\t\tboard = new Board(grid);\n-\t}\n-\t\n-\t/**\n-\t * Verifies the board has the correct width.\n-\t */\n-\t@Test\n-\tpublic void verifyWidth() {\n-\t\tassertEquals(MAX_WIDTH, board.getWidth());\n-\t}\n-\t\n-\t/**\n-\t * Verifies the board has the correct height.\n-\t */\n-\t@Test\n-\tpublic void verifyHeight() {\n-\t\tassertEquals(MAX_HEIGHT, board.getHeight());\n-\t}\n-\t\n-\t/**\n-\t * Verifies the square at x0y0 is indeed the right square.\n-\t */\n-\t@Test\n-\tpublic void verifyX0Y0() {\n-\t\tassertEquals(x0y0, board.squareAt(0, 0));\n-\t}\n-\t\n-\t/**\n-\t * Verifies the square at x1y2 is indeed the right square.\n-\t */\n-\t@Test\n-\tpublic void verifyX1Y2() {\n-\t\tassertEquals(x1y2, board.squareAt(1, 2));\n-\t}\n-\t\n-\t/**\n-\t * Verifies the square at x0y1 is indeed the right square.\n-\t */\n-\t@Test\n-\tpublic void verifyX0Y1() {\n-\t\tassertEquals(x0y1, board.squareAt(0, 1));\n-\t}\n+    private static final int MAX_WIDTH = 2;\n+    private static final int MAX_HEIGHT = 3;\n+\n+    private final Square[][] grid = {\n+            { mock(Square.class), mock(Square.class), mock(Square.class) },\n+            { mock(Square.class), mock(Square.class), mock(Square.class) },\n+    };\n+    private final Board board = new Board(grid);\n+\n+    /**\n+     * Verifies the board has the correct width.\n+     */\n+    @Test\n+    public void verifyWidth() {\n+        assertThat(board.getWidth()).isEqualTo(MAX_WIDTH);\n+    }\n+\n+    /**\n+     * Verifies the board has the correct height.\n+     */\n+    @Test\n+    public void verifyHeight() {\n+        assertThat(board.getHeight()).isEqualTo(MAX_HEIGHT);\n+    }\n+\n+    /**\n+     * Test at various places that the board returns the correct square.\n+     * @return Tests for the various places.\n+     */\n+    @TestFactory\n+    public Iterable<DynamicTest> verifySquares() {","path":"src/test/java/nl/tudelft/jpacman/board/BoardTest.java","position":121,"original_position":121,"commit_id":"09c731676c489f26fe8deccfdcf4c232d81f3d16","original_commit_id":"09c731676c489f26fe8deccfdcf4c232d81f3d16","user":{"login":"LiamClark","id":5991375,"avatar_url":"https://avatars0.githubusercontent.com/u/5991375?v=3","gravatar_id":"","url":"https://api.github.com/users/LiamClark","html_url":"https://github.com/LiamClark","followers_url":"https://api.github.com/users/LiamClark/followers","following_url":"https://api.github.com/users/LiamClark/following{/other_user}","gists_url":"https://api.github.com/users/LiamClark/gists{/gist_id}","starred_url":"https://api.github.com/users/LiamClark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LiamClark/subscriptions","organizations_url":"https://api.github.com/users/LiamClark/orgs","repos_url":"https://api.github.com/users/LiamClark/repos","events_url":"https://api.github.com/users/LiamClark/events{/privacy}","received_events_url":"https://api.github.com/users/LiamClark/received_events","type":"User","site_admin":false},"body":"This could use the new parameterized support in m4","created_at":"2017-04-02T09:31:13Z","updated_at":"2017-04-02T09:31:13Z","html_url":"https://github.com/SERG-Delft/jpacman-framework/pull/99#discussion_r109304545","pull_request_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls/99","_links":{"self":{"href":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls/comments/109304545"},"html":{"href":"https://github.com/SERG-Delft/jpacman-framework/pull/99#discussion_r109304545"},"pull_request":{"href":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls/99","id":113777605,"html_url":"https://github.com/SERG-Delft/jpacman-framework/pull/99","diff_url":"https://github.com/SERG-Delft/jpacman-framework/pull/99.diff","patch_url":"https://github.com/SERG-Delft/jpacman-framework/pull/99.patch","issue_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/issues/99","number":99,"state":"open","locked":false,"title":"WIP: Move to JUnit 5","user":{"login":"avandeursen","id":220701,"avatar_url":"https://avatars1.githubusercontent.com/u/220701?v=3","gravatar_id":"","url":"https://api.github.com/users/avandeursen","html_url":"https://github.com/avandeursen","followers_url":"https://api.github.com/users/avandeursen/followers","following_url":"https://api.github.com/users/avandeursen/following{/other_user}","gists_url":"https://api.github.com/users/avandeursen/gists{/gist_id}","starred_url":"https://api.github.com/users/avandeursen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/avandeursen/subscriptions","organizations_url":"https://api.github.com/users/avandeursen/orgs","repos_url":"https://api.github.com/users/avandeursen/repos","events_url":"https://api.github.com/users/avandeursen/events{/privacy}","received_events_url":"https://api.github.com/users/avandeursen/received_events","type":"User","site_admin":false},"body":"Experimental branch with JUnit 5 version of JPacman.\r\n\r\nThis move also implies a systematic adoption of AssertJ (and dropping of hamcrest).\r\n\r\nAll seems to working fine -- still exploring the impact on some of the exercises.\r\n\r\nFeedback welcome.\r\n\r\n(Do not merge yet).","created_at":"2017-04-01T12:31:54Z","updated_at":"2017-04-02T09:31:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54cf14c730aa7db22a68ec2aaf16edddf278e6af","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls/99/commits","review_comments_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls/99/comments","review_comment_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/issues/99/comments","statuses_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/statuses/09c731676c489f26fe8deccfdcf4c232d81f3d16","head":{"label":"SERG-Delft:junit5","ref":"junit5","sha":"09c731676c489f26fe8deccfdcf4c232d81f3d16","user":{"login":"SERG-Delft","id":1215887,"avatar_url":"https://avatars0.githubusercontent.com/u/1215887?v=3","gravatar_id":"","url":"https://api.github.com/users/SERG-Delft","html_url":"https://github.com/SERG-Delft","followers_url":"https://api.github.com/users/SERG-Delft/followers","following_url":"https://api.github.com/users/SERG-Delft/following{/other_user}","gists_url":"https://api.github.com/users/SERG-Delft/gists{/gist_id}","starred_url":"https://api.github.com/users/SERG-Delft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SERG-Delft/subscriptions","organizations_url":"https://api.github.com/users/SERG-Delft/orgs","repos_url":"https://api.github.com/users/SERG-Delft/repos","events_url":"https://api.github.com/users/SERG-Delft/events{/privacy}","received_events_url":"https://api.github.com/users/SERG-Delft/received_events","type":"Organization","site_admin":false},"repo":{"id":14206508,"name":"jpacman-framework","full_name":"SERG-Delft/jpacman-framework","owner":{"login":"SERG-Delft","id":1215887,"avatar_url":"https://avatars0.githubusercontent.com/u/1215887?v=3","gravatar_id":"","url":"https://api.github.com/users/SERG-Delft","html_url":"https://github.com/SERG-Delft","followers_url":"https://api.github.com/users/SERG-Delft/followers","following_url":"https://api.github.com/users/SERG-Delft/following{/other_user}","gists_url":"https://api.github.com/users/SERG-Delft/gists{/gist_id}","starred_url":"https://api.github.com/users/SERG-Delft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SERG-Delft/subscriptions","organizations_url":"https://api.github.com/users/SERG-Delft/orgs","repos_url":"https://api.github.com/users/SERG-Delft/repos","events_url":"https://api.github.com/users/SERG-Delft/events{/privacy}","received_events_url":"https://api.github.com/users/SERG-Delft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SERG-Delft/jpacman-framework","description":"Pacman-inspired game, for teaching testing purposes.","fork":false,"url":"https://api.github.com/repos/SERG-Delft/jpacman-framework","forks_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/forks","keys_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/teams","hooks_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/hooks","issue_events_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/issues/events{/number}","events_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/events","assignees_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/assignees{/user}","branches_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/branches{/branch}","tags_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/tags","blobs_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/languages","stargazers_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/stargazers","contributors_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/contributors","subscribers_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/subscribers","subscription_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/subscription","commits_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/contents/{+path}","compare_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/merges","archive_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/downloads","issues_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/issues{/number}","pulls_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/labels{/name}","releases_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/releases{/id}","deployments_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/deployments","created_at":"2013-11-07T14:56:09Z","updated_at":"2017-03-21T16:41:50Z","pushed_at":"2017-04-01T12:34:14Z","git_url":"git://github.com/SERG-Delft/jpacman-framework.git","ssh_url":"git@github.com:SERG-Delft/jpacman-framework.git","clone_url":"https://github.com/SERG-Delft/jpacman-framework.git","svn_url":"https://github.com/SERG-Delft/jpacman-framework","homepage":"","size":264,"stargazers_count":32,"watchers_count":32,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":11,"forks":76,"open_issues":11,"watchers":32,"default_branch":"master"}},"base":{"label":"SERG-Delft:master","ref":"master","sha":"ffbbaf7689d0eb1050f2558dfa398511069a0148","user":{"login":"SERG-Delft","id":1215887,"avatar_url":"https://avatars0.githubusercontent.com/u/1215887?v=3","gravatar_id":"","url":"https://api.github.com/users/SERG-Delft","html_url":"https://github.com/SERG-Delft","followers_url":"https://api.github.com/users/SERG-Delft/followers","following_url":"https://api.github.com/users/SERG-Delft/following{/other_user}","gists_url":"https://api.github.com/users/SERG-Delft/gists{/gist_id}","starred_url":"https://api.github.com/users/SERG-Delft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SERG-Delft/subscriptions","organizations_url":"https://api.github.com/users/SERG-Delft/orgs","repos_url":"https://api.github.com/users/SERG-Delft/repos","events_url":"https://api.github.com/users/SERG-Delft/events{/privacy}","received_events_url":"https://api.github.com/users/SERG-Delft/received_events","type":"Organization","site_admin":false},"repo":{"id":14206508,"name":"jpacman-framework","full_name":"SERG-Delft/jpacman-framework","owner":{"login":"SERG-Delft","id":1215887,"avatar_url":"https://avatars0.githubusercontent.com/u/1215887?v=3","gravatar_id":"","url":"https://api.github.com/users/SERG-Delft","html_url":"https://github.com/SERG-Delft","followers_url":"https://api.github.com/users/SERG-Delft/followers","following_url":"https://api.github.com/users/SERG-Delft/following{/other_user}","gists_url":"https://api.github.com/users/SERG-Delft/gists{/gist_id}","starred_url":"https://api.github.com/users/SERG-Delft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SERG-Delft/subscriptions","organizations_url":"https://api.github.com/users/SERG-Delft/orgs","repos_url":"https://api.github.com/users/SERG-Delft/repos","events_url":"https://api.github.com/users/SERG-Delft/events{/privacy}","received_events_url":"https://api.github.com/users/SERG-Delft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SERG-Delft/jpacman-framework","description":"Pacman-inspired game, for teaching testing purposes.","fork":false,"url":"https://api.github.com/repos/SERG-Delft/jpacman-framework","forks_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/forks","keys_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/teams","hooks_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/hooks","issue_events_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/issues/events{/number}","events_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/events","assignees_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/assignees{/user}","branches_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/branches{/branch}","tags_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/tags","blobs_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/languages","stargazers_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/stargazers","contributors_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/contributors","subscribers_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/subscribers","subscription_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/subscription","commits_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/contents/{+path}","compare_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/merges","archive_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/downloads","issues_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/issues{/number}","pulls_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/labels{/name}","releases_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/releases{/id}","deployments_url":"https://api.github.com/repos/SERG-Delft/jpacman-framework/deployments","created_at":"2013-11-07T14:56:09Z","updated_at":"2017-03-21T16:41:50Z","pushed_at":"2017-04-01T12:34:14Z","git_url":"git://github.com/SERG-Delft/jpacman-framework.git","ssh_url":"git@github.com:SERG-Delft/jpacman-framework.git","clone_url":"https://github.com/SERG-Delft/jpacman-framework.git","svn_url":"https://github.com/SERG-Delft/jpacman-framework","homepage":"","size":264,"stargazers_count":32,"watchers_count":32,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"open_issues_count":11,"forks":76,"open_issues":11,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls/99"},"html":{"href":"https://github.com/SERG-Delft/jpacman-framework/pull/99"},"issue":{"href":"https://api.github.com/repos/SERG-Delft/jpacman-framework/issues/99"},"comments":{"href":"https://api.github.com/repos/SERG-Delft/jpacman-framework/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SERG-Delft/jpacman-framework/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/SERG-Delft/jpacman-framework/statuses/09c731676c489f26fe8deccfdcf4c232d81f3d16"}}}}
{"actor":{"display_login":"LiamClark"}}