{"action":"created","comment":{"url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/pulls/comments/149525336","pull_request_review_id":74933650,"id":149525336,"diff_hunk":"@@ -26,25 +25,30 @@ class FulfillerIdentityProxy {\n     return new Promise((resolve, reject) => {\n       self.xray.captureAsyncFunc('FulfillerIdentity.getFulfillerById', function (subsegment) {\n         self.authenticator.getAuthorization().then((authorization) => {\n+          const axiosInstance = axios.create({","path":"src/fulfiller_identity_proxy.js","position":13,"original_position":13,"commit_id":"e59420cece46c90de5e9bac391ff22df6d42c95b","original_commit_id":"e59420cece46c90de5e9bac391ff22df6d42c95b","user":{"login":"istanishev","id":11559492,"avatar_url":"https://avatars0.githubusercontent.com/u/11559492?v=4","gravatar_id":"","url":"https://api.github.com/users/istanishev","html_url":"https://github.com/istanishev","followers_url":"https://api.github.com/users/istanishev/followers","following_url":"https://api.github.com/users/istanishev/following{/other_user}","gists_url":"https://api.github.com/users/istanishev/gists{/gist_id}","starred_url":"https://api.github.com/users/istanishev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istanishev/subscriptions","organizations_url":"https://api.github.com/users/istanishev/orgs","repos_url":"https://api.github.com/users/istanishev/repos","events_url":"https://api.github.com/users/istanishev/events{/privacy}","received_events_url":"https://api.github.com/users/istanishev/received_events","type":"User","site_admin":false},"body":"If we are going to create an instance, can we \"cache\" it by creating it globally? Do we need a dedicated instance or we can just use the default one?","created_at":"2017-11-07T22:35:11Z","updated_at":"2017-11-07T22:37:21Z","html_url":"https://github.com/Cimpress/cimpress-fulfiller-identity/pull/12#discussion_r149525336","pull_request_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/pulls/12","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/pulls/comments/149525336"},"html":{"href":"https://github.com/Cimpress/cimpress-fulfiller-identity/pull/12#discussion_r149525336"},"pull_request":{"href":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/pulls/12","id":151230393,"html_url":"https://github.com/Cimpress/cimpress-fulfiller-identity/pull/12","diff_url":"https://github.com/Cimpress/cimpress-fulfiller-identity/pull/12.diff","patch_url":"https://github.com/Cimpress/cimpress-fulfiller-identity/pull/12.patch","issue_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/issues/12","number":12,"state":"open","locked":false,"title":"Convert to axios move xray","user":{"login":"tirianmal","id":2238066,"avatar_url":"https://avatars2.githubusercontent.com/u/2238066?v=4","gravatar_id":"","url":"https://api.github.com/users/tirianmal","html_url":"https://github.com/tirianmal","followers_url":"https://api.github.com/users/tirianmal/followers","following_url":"https://api.github.com/users/tirianmal/following{/other_user}","gists_url":"https://api.github.com/users/tirianmal/gists{/gist_id}","starred_url":"https://api.github.com/users/tirianmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tirianmal/subscriptions","organizations_url":"https://api.github.com/users/tirianmal/orgs","repos_url":"https://api.github.com/users/tirianmal/repos","events_url":"https://api.github.com/users/tirianmal/events{/privacy}","received_events_url":"https://api.github.com/users/tirianmal/received_events","type":"User","site_admin":false},"body":"I've incorporated Ivan's changes plus converted to axios. It passes existing tests.\r\n","created_at":"2017-11-07T21:21:03Z","updated_at":"2017-11-07T22:37:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5a1527b025c74373704f3e0c568499fbfbe24a3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/pulls/12/commits","review_comments_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/pulls/12/comments","review_comment_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/issues/12/comments","statuses_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/statuses/e59420cece46c90de5e9bac391ff22df6d42c95b","head":{"label":"tirianmal:convert-to-axios-move-xray","ref":"convert-to-axios-move-xray","sha":"e59420cece46c90de5e9bac391ff22df6d42c95b","user":{"login":"tirianmal","id":2238066,"avatar_url":"https://avatars2.githubusercontent.com/u/2238066?v=4","gravatar_id":"","url":"https://api.github.com/users/tirianmal","html_url":"https://github.com/tirianmal","followers_url":"https://api.github.com/users/tirianmal/followers","following_url":"https://api.github.com/users/tirianmal/following{/other_user}","gists_url":"https://api.github.com/users/tirianmal/gists{/gist_id}","starred_url":"https://api.github.com/users/tirianmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tirianmal/subscriptions","organizations_url":"https://api.github.com/users/tirianmal/orgs","repos_url":"https://api.github.com/users/tirianmal/repos","events_url":"https://api.github.com/users/tirianmal/events{/privacy}","received_events_url":"https://api.github.com/users/tirianmal/received_events","type":"User","site_admin":false},"repo":{"id":109877770,"name":"cimpress-fulfiller-identity","full_name":"tirianmal/cimpress-fulfiller-identity","owner":{"login":"tirianmal","id":2238066,"avatar_url":"https://avatars2.githubusercontent.com/u/2238066?v=4","gravatar_id":"","url":"https://api.github.com/users/tirianmal","html_url":"https://github.com/tirianmal","followers_url":"https://api.github.com/users/tirianmal/followers","following_url":"https://api.github.com/users/tirianmal/following{/other_user}","gists_url":"https://api.github.com/users/tirianmal/gists{/gist_id}","starred_url":"https://api.github.com/users/tirianmal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tirianmal/subscriptions","organizations_url":"https://api.github.com/users/tirianmal/orgs","repos_url":"https://api.github.com/users/tirianmal/repos","events_url":"https://api.github.com/users/tirianmal/events{/privacy}","received_events_url":"https://api.github.com/users/tirianmal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tirianmal/cimpress-fulfiller-identity","description":"Thin client library for Cimpress' Fulfiller Identity service","fork":true,"url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity","forks_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/forks","keys_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/teams","hooks_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/hooks","issue_events_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/issues/events{/number}","events_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/events","assignees_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/assignees{/user}","branches_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/branches{/branch}","tags_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/tags","blobs_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/statuses/{sha}","languages_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/languages","stargazers_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/stargazers","contributors_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/contributors","subscribers_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/subscribers","subscription_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/subscription","commits_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/issues/comments{/number}","contents_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/contents/{+path}","compare_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/merges","archive_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/downloads","issues_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/issues{/number}","pulls_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/pulls{/number}","milestones_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/milestones{/number}","notifications_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/labels{/name}","releases_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/releases{/id}","deployments_url":"https://api.github.com/repos/tirianmal/cimpress-fulfiller-identity/deployments","created_at":"2017-11-07T18:59:02Z","updated_at":"2017-11-07T18:59:04Z","pushed_at":"2017-11-07T21:19:16Z","git_url":"git://github.com/tirianmal/cimpress-fulfiller-identity.git","ssh_url":"git@github.com:tirianmal/cimpress-fulfiller-identity.git","clone_url":"https://github.com/tirianmal/cimpress-fulfiller-identity.git","svn_url":"https://github.com/tirianmal/cimpress-fulfiller-identity","homepage":null,"size":43,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Cimpress:master","ref":"master","sha":"fdcc98ecaa2538b9926537cd732d8eb8b71fc25a","user":{"login":"Cimpress","id":30873508,"avatar_url":"https://avatars0.githubusercontent.com/u/30873508?v=4","gravatar_id":"","url":"https://api.github.com/users/Cimpress","html_url":"https://github.com/Cimpress","followers_url":"https://api.github.com/users/Cimpress/followers","following_url":"https://api.github.com/users/Cimpress/following{/other_user}","gists_url":"https://api.github.com/users/Cimpress/gists{/gist_id}","starred_url":"https://api.github.com/users/Cimpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cimpress/subscriptions","organizations_url":"https://api.github.com/users/Cimpress/orgs","repos_url":"https://api.github.com/users/Cimpress/repos","events_url":"https://api.github.com/users/Cimpress/events{/privacy}","received_events_url":"https://api.github.com/users/Cimpress/received_events","type":"Organization","site_admin":false},"repo":{"id":94767419,"name":"cimpress-fulfiller-identity","full_name":"Cimpress/cimpress-fulfiller-identity","owner":{"login":"Cimpress","id":30873508,"avatar_url":"https://avatars0.githubusercontent.com/u/30873508?v=4","gravatar_id":"","url":"https://api.github.com/users/Cimpress","html_url":"https://github.com/Cimpress","followers_url":"https://api.github.com/users/Cimpress/followers","following_url":"https://api.github.com/users/Cimpress/following{/other_user}","gists_url":"https://api.github.com/users/Cimpress/gists{/gist_id}","starred_url":"https://api.github.com/users/Cimpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cimpress/subscriptions","organizations_url":"https://api.github.com/users/Cimpress/orgs","repos_url":"https://api.github.com/users/Cimpress/repos","events_url":"https://api.github.com/users/Cimpress/events{/privacy}","received_events_url":"https://api.github.com/users/Cimpress/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cimpress/cimpress-fulfiller-identity","description":"Thin client library for Cimpress' Fulfiller Identity service","fork":false,"url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity","forks_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/forks","keys_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/teams","hooks_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/hooks","issue_events_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/issues/events{/number}","events_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/events","assignees_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/assignees{/user}","branches_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/branches{/branch}","tags_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/tags","blobs_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/statuses/{sha}","languages_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/languages","stargazers_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/stargazers","contributors_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/contributors","subscribers_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/subscribers","subscription_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/subscription","commits_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/contents/{+path}","compare_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/merges","archive_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/downloads","issues_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/issues{/number}","pulls_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/pulls{/number}","milestones_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/milestones{/number}","notifications_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/labels{/name}","releases_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/releases{/id}","deployments_url":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/deployments","created_at":"2017-06-19T10:58:13Z","updated_at":"2017-10-27T15:21:51Z","pushed_at":"2017-11-07T21:21:04Z","git_url":"git://github.com/Cimpress/cimpress-fulfiller-identity.git","ssh_url":"git@github.com:Cimpress/cimpress-fulfiller-identity.git","clone_url":"https://github.com/Cimpress/cimpress-fulfiller-identity.git","svn_url":"https://github.com/Cimpress/cimpress-fulfiller-identity","homepage":null,"size":39,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/pulls/12"},"html":{"href":"https://github.com/Cimpress/cimpress-fulfiller-identity/pull/12"},"issue":{"href":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/issues/12"},"comments":{"href":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/Cimpress/cimpress-fulfiller-identity/statuses/e59420cece46c90de5e9bac391ff22df6d42c95b"}},"author_association":"NONE"}}
{"actor":{"display_login":"istanishev"}}