{"action":"closed","number":43887,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/43887","id":135832526,"html_url":"https://github.com/rust-lang/rust/pull/43887","diff_url":"https://github.com/rust-lang/rust/pull/43887.diff","patch_url":"https://github.com/rust-lang/rust/pull/43887.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/43887","number":43887,"state":"closed","locked":false,"title":"Store fewer NodeIds in crate metadata.","user":{"login":"michaelwoerister","id":1825894,"avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"body":"The first commit just replaces `NodeId` with `DefId` in `resolve_lifetime::Region`, so we don't run into problems when stable-hashing `TypeParameterDef` values from other crates.\r\n\r\n~~The second commit is more interesting. It adds the `ReScopeAnon` variant to `ty::RegionKind`, which is semantically equivalent to `ReScope`. The only difference is that it does not contain a `CodeExtent` field. All `ReScope` occurrences are then replaced with `ReScopeAnon` upon metadata export. This way we don't end up with `NodeIds` from other crates in various things imported from metadata. `ReScopeAnon` can still be tested for equality.~~ This is fixed in a better way by @eddyb in #44171.\r\n\r\nr? @eddyb \r\ncc @rust-lang/compiler ","created_at":"2017-08-15T15:57:46Z","updated_at":"2017-09-06T10:29:30Z","closed_at":"2017-09-06T10:29:30Z","merged_at":null,"merge_commit_sha":"b921fc84eff88357789fcc57e3457391aa8c0362","assignee":{"login":"eddyb","id":77424,"avatar_url":"https://avatars2.githubusercontent.com/u/77424?v=4","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false},"assignees":[{"login":"eddyb","id":77424,"avatar_url":"https://avatars2.githubusercontent.com/u/77424?v=4","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/43887/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/43887/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/43887/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/773736ce4a5eff649fd9a26957378171f0ed9613","head":{"label":"michaelwoerister:node-id-be-gone","ref":"node-id-be-gone","sha":"773736ce4a5eff649fd9a26957378171f0ed9613","user":{"login":"michaelwoerister","id":1825894,"avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"repo":{"id":9431220,"name":"rust","full_name":"michaelwoerister/rust","owner":{"login":"michaelwoerister","id":1825894,"avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelwoerister/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/michaelwoerister/rust","forks_url":"https://api.github.com/repos/michaelwoerister/rust/forks","keys_url":"https://api.github.com/repos/michaelwoerister/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelwoerister/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelwoerister/rust/teams","hooks_url":"https://api.github.com/repos/michaelwoerister/rust/hooks","issue_events_url":"https://api.github.com/repos/michaelwoerister/rust/issues/events{/number}","events_url":"https://api.github.com/repos/michaelwoerister/rust/events","assignees_url":"https://api.github.com/repos/michaelwoerister/rust/assignees{/user}","branches_url":"https://api.github.com/repos/michaelwoerister/rust/branches{/branch}","tags_url":"https://api.github.com/repos/michaelwoerister/rust/tags","blobs_url":"https://api.github.com/repos/michaelwoerister/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelwoerister/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelwoerister/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelwoerister/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelwoerister/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelwoerister/rust/languages","stargazers_url":"https://api.github.com/repos/michaelwoerister/rust/stargazers","contributors_url":"https://api.github.com/repos/michaelwoerister/rust/contributors","subscribers_url":"https://api.github.com/repos/michaelwoerister/rust/subscribers","subscription_url":"https://api.github.com/repos/michaelwoerister/rust/subscription","commits_url":"https://api.github.com/repos/michaelwoerister/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelwoerister/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelwoerister/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelwoerister/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelwoerister/rust/contents/{+path}","compare_url":"https://api.github.com/repos/michaelwoerister/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelwoerister/rust/merges","archive_url":"https://api.github.com/repos/michaelwoerister/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelwoerister/rust/downloads","issues_url":"https://api.github.com/repos/michaelwoerister/rust/issues{/number}","pulls_url":"https://api.github.com/repos/michaelwoerister/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelwoerister/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelwoerister/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelwoerister/rust/labels{/name}","releases_url":"https://api.github.com/repos/michaelwoerister/rust/releases{/id}","deployments_url":"https://api.github.com/repos/michaelwoerister/rust/deployments","created_at":"2013-04-14T15:57:02Z","updated_at":"2016-11-01T13:32:57Z","pushed_at":"2017-09-06T10:12:56Z","git_url":"git://github.com/michaelwoerister/rust.git","ssh_url":"git@github.com:michaelwoerister/rust.git","clone_url":"https://github.com/michaelwoerister/rust.git","svn_url":"https://github.com/michaelwoerister/rust","homepage":"http://www.rust-lang.org","size":321434,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"a36d93d38390ae92342fe7199c13e513b2c527fb","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2017-09-06T10:07:54Z","pushed_at":"2017-09-06T10:28:51Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":323818,"stargazers_count":23333,"watchers_count":23333,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4274,"mirror_url":null,"open_issues_count":2830,"forks":4274,"open_issues":2830,"watchers":23333,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/43887"},"html":{"href":"https://github.com/rust-lang/rust/pull/43887"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/43887"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/43887/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/43887/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/43887/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/773736ce4a5eff649fd9a26957378171f0ed9613"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":44,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":48,"deletions":27,"changed_files":4}}
{"actor":{"display_login":"michaelwoerister"}}