{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/135321957","pull_request_review_id":58726231,"id":135321957,"diff_hunk":"@@ -57,6 +60,12 @@ do\n             exit_with_error \"--buildConfig can be Debug, Checked or Release\" true\n         fi\n         ;;\n+    --ryujit)\n+        if [[ \"$__buildConfig\" != \"Release\" ]]; then\n+            exit_with_error \"--ryujit is only avalable for Release by now\" true\n+        fi","path":"tests/scripts/arm32_ci_test.sh","position":19,"original_position":19,"commit_id":"d5d4abaae84bdfd2db8fca216908f64798d86cec","original_commit_id":"d5d4abaae84bdfd2db8fca216908f64798d86cec","user":{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars3.githubusercontent.com/u/10901265?v=4","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false},"body":"Is this test required? It seems like this script should accept `--ryujit` unconditionally, and it's the job of the caller to only pass it for tests that will succeed.","created_at":"2017-08-25T18:16:46Z","updated_at":"2017-08-25T18:27:43Z","html_url":"https://github.com/dotnet/coreclr/pull/13585#discussion_r135321957","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/13585","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/135321957"},"html":{"href":"https://github.com/dotnet/coreclr/pull/13585#discussion_r135321957"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/13585"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/13585","id":137610369,"html_url":"https://github.com/dotnet/coreclr/pull/13585","diff_url":"https://github.com/dotnet/coreclr/pull/13585.diff","patch_url":"https://github.com/dotnet/coreclr/pull/13585.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/13585","number":13585,"state":"open","locked":false,"title":"[RyuJIT/ARM32] Enable CI for ryujit in arm Release leg","user":{"login":"hqueue","id":9247907,"avatar_url":"https://avatars1.githubusercontent.com/u/9247907?v=4","gravatar_id":"","url":"https://api.github.com/users/hqueue","html_url":"https://github.com/hqueue","followers_url":"https://api.github.com/users/hqueue/followers","following_url":"https://api.github.com/users/hqueue/following{/other_user}","gists_url":"https://api.github.com/users/hqueue/gists{/gist_id}","starred_url":"https://api.github.com/users/hqueue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqueue/subscriptions","organizations_url":"https://api.github.com/users/hqueue/orgs","repos_url":"https://api.github.com/users/hqueue/repos","events_url":"https://api.github.com/users/hqueue/events{/privacy}","received_events_url":"https://api.github.com/users/hqueue/received_events","type":"User","site_admin":false},"body":"Enable CI for ryujit in arm `Release` leg in addition to default legacy backend.\r\n\r\n\r\nAs by now, all Pri2 test is passed for arm `Release`(https://github.com/dotnet/coreclr/issues/8496#issuecomment-324839327), I think it's time to add CI for ryujit in arm `Release`.\r\n\r\n/cc: @dotnet/arm32-contrib \r\n","created_at":"2017-08-25T06:51:59Z","updated_at":"2017-08-25T18:27:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad89270b215db5e27fceb948707902589ea53434","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/13585/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/13585/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/13585/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/d5d4abaae84bdfd2db8fca216908f64798d86cec","head":{"label":"hqueue:arm/ryujit/enable_ci","ref":"arm/ryujit/enable_ci","sha":"d5d4abaae84bdfd2db8fca216908f64798d86cec","user":{"login":"hqueue","id":9247907,"avatar_url":"https://avatars1.githubusercontent.com/u/9247907?v=4","gravatar_id":"","url":"https://api.github.com/users/hqueue","html_url":"https://github.com/hqueue","followers_url":"https://api.github.com/users/hqueue/followers","following_url":"https://api.github.com/users/hqueue/following{/other_user}","gists_url":"https://api.github.com/users/hqueue/gists{/gist_id}","starred_url":"https://api.github.com/users/hqueue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqueue/subscriptions","organizations_url":"https://api.github.com/users/hqueue/orgs","repos_url":"https://api.github.com/users/hqueue/repos","events_url":"https://api.github.com/users/hqueue/events{/privacy}","received_events_url":"https://api.github.com/users/hqueue/received_events","type":"User","site_admin":false},"repo":{"id":55405428,"name":"coreclr","full_name":"hqueue/coreclr","owner":{"login":"hqueue","id":9247907,"avatar_url":"https://avatars1.githubusercontent.com/u/9247907?v=4","gravatar_id":"","url":"https://api.github.com/users/hqueue","html_url":"https://github.com/hqueue","followers_url":"https://api.github.com/users/hqueue/followers","following_url":"https://api.github.com/users/hqueue/following{/other_user}","gists_url":"https://api.github.com/users/hqueue/gists{/gist_id}","starred_url":"https://api.github.com/users/hqueue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hqueue/subscriptions","organizations_url":"https://api.github.com/users/hqueue/orgs","repos_url":"https://api.github.com/users/hqueue/repos","events_url":"https://api.github.com/users/hqueue/events{/privacy}","received_events_url":"https://api.github.com/users/hqueue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hqueue/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/hqueue/coreclr","forks_url":"https://api.github.com/repos/hqueue/coreclr/forks","keys_url":"https://api.github.com/repos/hqueue/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hqueue/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hqueue/coreclr/teams","hooks_url":"https://api.github.com/repos/hqueue/coreclr/hooks","issue_events_url":"https://api.github.com/repos/hqueue/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/hqueue/coreclr/events","assignees_url":"https://api.github.com/repos/hqueue/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/hqueue/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/hqueue/coreclr/tags","blobs_url":"https://api.github.com/repos/hqueue/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hqueue/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hqueue/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/hqueue/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hqueue/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/hqueue/coreclr/languages","stargazers_url":"https://api.github.com/repos/hqueue/coreclr/stargazers","contributors_url":"https://api.github.com/repos/hqueue/coreclr/contributors","subscribers_url":"https://api.github.com/repos/hqueue/coreclr/subscribers","subscription_url":"https://api.github.com/repos/hqueue/coreclr/subscription","commits_url":"https://api.github.com/repos/hqueue/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/hqueue/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/hqueue/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/hqueue/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/hqueue/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/hqueue/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hqueue/coreclr/merges","archive_url":"https://api.github.com/repos/hqueue/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hqueue/coreclr/downloads","issues_url":"https://api.github.com/repos/hqueue/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/hqueue/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/hqueue/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/hqueue/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hqueue/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/hqueue/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/hqueue/coreclr/deployments","created_at":"2016-04-04T11:20:02Z","updated_at":"2016-04-04T11:21:13Z","pushed_at":"2017-08-25T08:56:42Z","git_url":"git://github.com/hqueue/coreclr.git","ssh_url":"git@github.com:hqueue/coreclr.git","clone_url":"https://github.com/hqueue/coreclr.git","svn_url":"https://github.com/hqueue/coreclr","homepage":"http://dotnet.github.io/","size":174372,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"e9e3a69fe00d5e75ed09971b346f3529beba36f6","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2017-08-25T18:09:38Z","pushed_at":"2017-08-25T18:10:52Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":176096,"stargazers_count":8040,"watchers_count":8040,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2041,"mirror_url":null,"open_issues_count":1404,"forks":2041,"open_issues":1404,"watchers":8040,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/13585"},"html":{"href":"https://github.com/dotnet/coreclr/pull/13585"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/13585"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/13585/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/13585/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/13585/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/d5d4abaae84bdfd2db8fca216908f64798d86cec"}}}}
{"actor":{"display_login":"BruceForstall"}}