{"action":"created","issue":{"url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant/issues/218","repository_url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant","labels_url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant/issues/218/labels{/name}","comments_url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant/issues/218/comments","events_url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant/issues/218/events","html_url":"https://github.com/upgrades-migrations/preupgrade-assistant/pull/218","id":206024441,"number":218,"title":"Update return code behavior","user":{"login":"bocekm","id":9884110,"avatar_url":"https://avatars1.githubusercontent.com/u/9884110?v=4","gravatar_id":"","url":"https://api.github.com/users/bocekm","html_url":"https://github.com/bocekm","followers_url":"https://api.github.com/users/bocekm/followers","following_url":"https://api.github.com/users/bocekm/following{/other_user}","gists_url":"https://api.github.com/users/bocekm/gists{/gist_id}","starred_url":"https://api.github.com/users/bocekm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocekm/subscriptions","organizations_url":"https://api.github.com/users/bocekm/orgs","repos_url":"https://api.github.com/users/bocekm/repos","events_url":"https://api.github.com/users/bocekm/events{/privacy}","received_events_url":"https://api.github.com/users/bocekm/received_events","type":"User","site_admin":false},"labels":[{"id":464667404,"url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant/labels/affects_modules","name":"affects_modules","color":"d97f0b","default":false},{"id":96239690,"url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant/labels/bug","name":"bug","color":"fc2929","default":true},{"id":673453186,"url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant/labels/needs_verify","name":"needs_verify","color":"bfdadc","default":false},{"id":552504690,"url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant/labels/qa_ack","name":"qa_ack","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant/milestones/9","html_url":"https://github.com/upgrades-migrations/preupgrade-assistant/milestone/9","labels_url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant/milestones/9/labels","id":2794729,"number":9,"title":"el69toel75b0","description":"RHEL 6.9 -> 7.5 GA (batch 0)","creator":{"login":"bocekm","id":9884110,"avatar_url":"https://avatars1.githubusercontent.com/u/9884110?v=4","gravatar_id":"","url":"https://api.github.com/users/bocekm","html_url":"https://github.com/bocekm","followers_url":"https://api.github.com/users/bocekm/followers","following_url":"https://api.github.com/users/bocekm/following{/other_user}","gists_url":"https://api.github.com/users/bocekm/gists{/gist_id}","starred_url":"https://api.github.com/users/bocekm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bocekm/subscriptions","organizations_url":"https://api.github.com/users/bocekm/orgs","repos_url":"https://api.github.com/users/bocekm/repos","events_url":"https://api.github.com/users/bocekm/events{/privacy}","received_events_url":"https://api.github.com/users/bocekm/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":2,"state":"open","created_at":"2017-09-26T13:11:06Z","updated_at":"2017-11-10T15:45:47Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2017-02-07T21:40:50Z","updated_at":"2017-11-16T18:41:18Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant/pulls/218","html_url":"https://github.com/upgrades-migrations/preupgrade-assistant/pull/218","diff_url":"https://github.com/upgrades-migrations/preupgrade-assistant/pull/218.diff","patch_url":"https://github.com/upgrades-migrations/preupgrade-assistant/pull/218.patch"},"body":"**Update Preupgrade Assistant to return code per table in: https://github.com/upgrades-migrations/preupgrade-assistant/pull/218#issuecomment-318444997**\r\n- With this update Preupgrade Assistant terminates with INTERNAL_EXCEPTION when it detects unknown module result\r\n- A module can report an inplace risk **only** when the result of the module is **\"fail\"**\r\n\r\n**Cleanup**\r\n\r\n- **Remove**:\r\n  - clearly dead code\r\n  - unused settings.ERROR_RETURN_VALUES\r\n  - superfluous settins.ORDERED_LIST\r\n  - preupg_diff part of the test XMLs so the inplace_risks tests work as expected (and update preupg_diff tests to still provide value)\r\n\r\n- **Rename**:\r\nPer rhbz#[1414359](https://bugzilla.redhat.com/show_bug.cgi?id=1414359):\r\n  - settings.ReturnValues->PreupgReturnCodes\r\n  - settings.ModuleValues->ResultBasedReturnCodes"},"comment":{"url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant/issues/comments/345018010","html_url":"https://github.com/upgrades-migrations/preupgrade-assistant/pull/218#issuecomment-345018010","issue_url":"https://api.github.com/repos/upgrades-migrations/preupgrade-assistant/issues/218","id":345018010,"user":{"login":"AloisMahdal","id":217935,"avatar_url":"https://avatars1.githubusercontent.com/u/217935?v=4","gravatar_id":"","url":"https://api.github.com/users/AloisMahdal","html_url":"https://github.com/AloisMahdal","followers_url":"https://api.github.com/users/AloisMahdal/followers","following_url":"https://api.github.com/users/AloisMahdal/following{/other_user}","gists_url":"https://api.github.com/users/AloisMahdal/gists{/gist_id}","starred_url":"https://api.github.com/users/AloisMahdal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AloisMahdal/subscriptions","organizations_url":"https://api.github.com/users/AloisMahdal/orgs","repos_url":"https://api.github.com/users/AloisMahdal/repos","events_url":"https://api.github.com/users/AloisMahdal/events{/privacy}","received_events_url":"https://api.github.com/users/AloisMahdal/received_events","type":"User","site_admin":false},"created_at":"2017-11-16T18:41:18Z","updated_at":"2017-11-16T18:41:18Z","author_association":"COLLABORATOR","body":"`qa_ack`: Update downstream tests: IIUC *api/mseverity* and *preupg/result-files*."}}
{"actor":{"display_login":"AloisMahdal"}}