{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/tslint/pulls/comments/153585268","pull_request_review_id":79612802,"id":153585268,"diff_hunk":"@@ -107,6 +107,6 @@ export abstract class ScopeAwareRuleWalker<T> extends RuleWalker {\n     }\n \n     protected isScopeBoundary(node: ts.Node): boolean {\n-        return isScopeBoundary(node);\n+        return isScopeBoundary(node); // tslint:disable-line:deprecation","path":"src/language/walker/scopeAwareRuleWalker.ts","position":5,"original_position":5,"commit_id":"d37a51d29485bd3329b8c37332a1a89de2ce0645","original_commit_id":"25d009881554f2b17aa99ba07dccdb2ee210a118","user":{"login":"ajafff","id":11968040,"avatar_url":"https://avatars0.githubusercontent.com/u/11968040?v=4","gravatar_id":"","url":"https://api.github.com/users/ajafff","html_url":"https://github.com/ajafff","followers_url":"https://api.github.com/users/ajafff/followers","following_url":"https://api.github.com/users/ajafff/following{/other_user}","gists_url":"https://api.github.com/users/ajafff/gists{/gist_id}","starred_url":"https://api.github.com/users/ajafff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajafff/subscriptions","organizations_url":"https://api.github.com/users/ajafff/orgs","repos_url":"https://api.github.com/users/ajafff/repos","events_url":"https://api.github.com/users/ajafff/events{/privacy}","received_events_url":"https://api.github.com/users/ajafff/received_events","type":"User","site_admin":false},"body":"There are some differences between the two that _could_ break some custom rules. Since this is deprecated, I don't think we need to replace all deprecated utils.","created_at":"2017-11-28T18:42:29Z","updated_at":"2017-11-28T18:42:30Z","html_url":"https://github.com/palantir/tslint/pull/3476#discussion_r153585268","pull_request_url":"https://api.github.com/repos/palantir/tslint/pulls/3476","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments/153585268"},"html":{"href":"https://github.com/palantir/tslint/pull/3476#discussion_r153585268"},"pull_request":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3476"}},"in_reply_to_id":153556121},"pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/3476","id":152075716,"html_url":"https://github.com/palantir/tslint/pull/3476","diff_url":"https://github.com/palantir/tslint/pull/3476.diff","patch_url":"https://github.com/palantir/tslint/pull/3476.patch","issue_url":"https://api.github.com/repos/palantir/tslint/issues/3476","number":3476,"state":"open","locked":false,"title":"deprecate utils","user":{"login":"ajafff","id":11968040,"avatar_url":"https://avatars0.githubusercontent.com/u/11968040?v=4","gravatar_id":"","url":"https://api.github.com/users/ajafff","html_url":"https://github.com/ajafff","followers_url":"https://api.github.com/users/ajafff/followers","following_url":"https://api.github.com/users/ajafff/following{/other_user}","gists_url":"https://api.github.com/users/ajafff/gists{/gist_id}","starred_url":"https://api.github.com/users/ajafff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajafff/subscriptions","organizations_url":"https://api.github.com/users/ajafff/orgs","repos_url":"https://api.github.com/users/ajafff/repos","events_url":"https://api.github.com/users/ajafff/events{/privacy}","received_events_url":"https://api.github.com/users/ajafff/received_events","type":"User","site_admin":false},"body":"Deprecate most of the utility functions in `src/language/utils.ts`. Some of them are no longer used.\r\nThe other deprecated functions can be easily replaced by functions from `tsutils`. \r\nI think we should get rid of these functions to avoid maintaining them. For example `forEachToken` (with `skipTrivia` false) and `forEachComment` will no longer function correctly with the newly added `JsxFragment`.\r\n\r\n[deprecation] several utility functions have been deprecated\r\n\r\nI'm in favor of making the remaining utilities in `src/utils.ts` and `src/language/utils.ts` internal in the next major version. Most of them are not meant to be exposed as public API. WDYT?","created_at":"2017-11-11T21:21:51Z","updated_at":"2017-11-28T18:42:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b3e73b3ee7cd0159b5fb3048b5ef51a414242b9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/tslint/pulls/3476/commits","review_comments_url":"https://api.github.com/repos/palantir/tslint/pulls/3476/comments","review_comment_url":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/3476/comments","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/d37a51d29485bd3329b8c37332a1a89de2ce0645","head":{"label":"ajafff:deprecate-utils","ref":"deprecate-utils","sha":"d37a51d29485bd3329b8c37332a1a89de2ce0645","user":{"login":"ajafff","id":11968040,"avatar_url":"https://avatars0.githubusercontent.com/u/11968040?v=4","gravatar_id":"","url":"https://api.github.com/users/ajafff","html_url":"https://github.com/ajafff","followers_url":"https://api.github.com/users/ajafff/followers","following_url":"https://api.github.com/users/ajafff/following{/other_user}","gists_url":"https://api.github.com/users/ajafff/gists{/gist_id}","starred_url":"https://api.github.com/users/ajafff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajafff/subscriptions","organizations_url":"https://api.github.com/users/ajafff/orgs","repos_url":"https://api.github.com/users/ajafff/repos","events_url":"https://api.github.com/users/ajafff/events{/privacy}","received_events_url":"https://api.github.com/users/ajafff/received_events","type":"User","site_admin":false},"repo":{"id":74204153,"name":"tslint","full_name":"ajafff/tslint","owner":{"login":"ajafff","id":11968040,"avatar_url":"https://avatars0.githubusercontent.com/u/11968040?v=4","gravatar_id":"","url":"https://api.github.com/users/ajafff","html_url":"https://github.com/ajafff","followers_url":"https://api.github.com/users/ajafff/followers","following_url":"https://api.github.com/users/ajafff/following{/other_user}","gists_url":"https://api.github.com/users/ajafff/gists{/gist_id}","starred_url":"https://api.github.com/users/ajafff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajafff/subscriptions","organizations_url":"https://api.github.com/users/ajafff/orgs","repos_url":"https://api.github.com/users/ajafff/repos","events_url":"https://api.github.com/users/ajafff/events{/privacy}","received_events_url":"https://api.github.com/users/ajafff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajafff/tslint","description":"An extensible linter for the TypeScript language.","fork":true,"url":"https://api.github.com/repos/ajafff/tslint","forks_url":"https://api.github.com/repos/ajafff/tslint/forks","keys_url":"https://api.github.com/repos/ajafff/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajafff/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajafff/tslint/teams","hooks_url":"https://api.github.com/repos/ajafff/tslint/hooks","issue_events_url":"https://api.github.com/repos/ajafff/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/ajafff/tslint/events","assignees_url":"https://api.github.com/repos/ajafff/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/ajafff/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/ajafff/tslint/tags","blobs_url":"https://api.github.com/repos/ajafff/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajafff/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajafff/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajafff/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajafff/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/ajafff/tslint/languages","stargazers_url":"https://api.github.com/repos/ajafff/tslint/stargazers","contributors_url":"https://api.github.com/repos/ajafff/tslint/contributors","subscribers_url":"https://api.github.com/repos/ajafff/tslint/subscribers","subscription_url":"https://api.github.com/repos/ajafff/tslint/subscription","commits_url":"https://api.github.com/repos/ajafff/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajafff/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajafff/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajafff/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajafff/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/ajafff/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajafff/tslint/merges","archive_url":"https://api.github.com/repos/ajafff/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajafff/tslint/downloads","issues_url":"https://api.github.com/repos/ajafff/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/ajafff/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/ajafff/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/ajafff/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajafff/tslint/labels{/name}","releases_url":"https://api.github.com/repos/ajafff/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/ajafff/tslint/deployments","created_at":"2016-11-19T11:22:46Z","updated_at":"2016-11-19T11:22:49Z","pushed_at":"2017-11-28T18:41:01Z","git_url":"git://github.com/ajafff/tslint.git","ssh_url":"git@github.com:ajafff/tslint.git","clone_url":"https://github.com/ajafff/tslint.git","svn_url":"https://github.com/ajafff/tslint","homepage":"http://palantir.github.io/tslint/","size":14012,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"0b83cbea4f27e828846a6fd8bf6911bb0c3930f5","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":11672345,"name":"tslint","full_name":"palantir/tslint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/tslint","description":":vertical_traffic_light: An extensible linter for the TypeScript language","fork":false,"url":"https://api.github.com/repos/palantir/tslint","forks_url":"https://api.github.com/repos/palantir/tslint/forks","keys_url":"https://api.github.com/repos/palantir/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/tslint/teams","hooks_url":"https://api.github.com/repos/palantir/tslint/hooks","issue_events_url":"https://api.github.com/repos/palantir/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/tslint/events","assignees_url":"https://api.github.com/repos/palantir/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/tslint/tags","blobs_url":"https://api.github.com/repos/palantir/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/tslint/languages","stargazers_url":"https://api.github.com/repos/palantir/tslint/stargazers","contributors_url":"https://api.github.com/repos/palantir/tslint/contributors","subscribers_url":"https://api.github.com/repos/palantir/tslint/subscribers","subscription_url":"https://api.github.com/repos/palantir/tslint/subscription","commits_url":"https://api.github.com/repos/palantir/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/tslint/merges","archive_url":"https://api.github.com/repos/palantir/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/tslint/downloads","issues_url":"https://api.github.com/repos/palantir/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/tslint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/tslint/deployments","created_at":"2013-07-25T22:19:18Z","updated_at":"2017-11-28T16:43:10Z","pushed_at":"2017-11-28T18:41:03Z","git_url":"git://github.com/palantir/tslint.git","ssh_url":"git@github.com:palantir/tslint.git","clone_url":"https://github.com/palantir/tslint.git","svn_url":"https://github.com/palantir/tslint","homepage":"http://palantir.github.io/tslint/","size":13612,"stargazers_count":2614,"watchers_count":2614,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":517,"mirror_url":null,"archived":false,"open_issues_count":455,"forks":517,"open_issues":455,"watchers":2614,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3476"},"html":{"href":"https://github.com/palantir/tslint/pull/3476"},"issue":{"href":"https://api.github.com/repos/palantir/tslint/issues/3476"},"comments":{"href":"https://api.github.com/repos/palantir/tslint/issues/3476/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3476/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3476/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/tslint/statuses/d37a51d29485bd3329b8c37332a1a89de2ce0645"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ajafff"}}