{"action":"closed","number":2737,"pull_request":{"url":"https://api.github.com/repos/danielgindi/Charts/pulls/2737","id":136652045,"html_url":"https://github.com/danielgindi/Charts/pull/2737","diff_url":"https://github.com/danielgindi/Charts/pull/2737.diff","patch_url":"https://github.com/danielgindi/Charts/pull/2737.patch","issue_url":"https://api.github.com/repos/danielgindi/Charts/issues/2737","number":2737,"state":"closed","locked":false,"title":"Minor changes to improve clarity and reduce amount of code","user":{"login":"jjatie","id":19879272,"avatar_url":"https://avatars1.githubusercontent.com/u/19879272?v=4","gravatar_id":"","url":"https://api.github.com/users/jjatie","html_url":"https://github.com/jjatie","followers_url":"https://api.github.com/users/jjatie/followers","following_url":"https://api.github.com/users/jjatie/following{/other_user}","gists_url":"https://api.github.com/users/jjatie/gists{/gist_id}","starred_url":"https://api.github.com/users/jjatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjatie/subscriptions","organizations_url":"https://api.github.com/users/jjatie/orgs","repos_url":"https://api.github.com/users/jjatie/repos","events_url":"https://api.github.com/users/jjatie/events{/privacy}","received_events_url":"https://api.github.com/users/jjatie/received_events","type":"User","site_admin":false},"body":"Making use of `defer` where appropriate (e.g. `CGContext().saveGState()` / `CGContext().restoreGState()`)\r\nUsing replaced `if` where really meaning `guard`, and `if case` with `switch` where appropriate. Much less nesting as a result.\r\nMaking use of `Swift.min` and `Swift.max`\r\nChanged some `Double` to `CGFloat` where it makes sense to. This also reduces typecasting.\r\nRefined `for` loops, in some cases replacing them with `map`, `filter`, and/or `reduce`","created_at":"2017-08-20T17:53:22Z","updated_at":"2017-11-06T21:35:21Z","closed_at":"2017-11-06T21:35:21Z","merged_at":null,"merge_commit_sha":"25f7ef7e2f94e86702c4e759c09e009a2264a2ba","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/danielgindi/Charts/pulls/2737/commits","review_comments_url":"https://api.github.com/repos/danielgindi/Charts/pulls/2737/comments","review_comment_url":"https://api.github.com/repos/danielgindi/Charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/danielgindi/Charts/issues/2737/comments","statuses_url":"https://api.github.com/repos/danielgindi/Charts/statuses/56b4530f13dd3702a7cf1c3f0ed623439e07c943","head":{"label":"jjatie:clarity_refactor","ref":"clarity_refactor","sha":"56b4530f13dd3702a7cf1c3f0ed623439e07c943","user":{"login":"jjatie","id":19879272,"avatar_url":"https://avatars1.githubusercontent.com/u/19879272?v=4","gravatar_id":"","url":"https://api.github.com/users/jjatie","html_url":"https://github.com/jjatie","followers_url":"https://api.github.com/users/jjatie/followers","following_url":"https://api.github.com/users/jjatie/following{/other_user}","gists_url":"https://api.github.com/users/jjatie/gists{/gist_id}","starred_url":"https://api.github.com/users/jjatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjatie/subscriptions","organizations_url":"https://api.github.com/users/jjatie/orgs","repos_url":"https://api.github.com/users/jjatie/repos","events_url":"https://api.github.com/users/jjatie/events{/privacy}","received_events_url":"https://api.github.com/users/jjatie/received_events","type":"User","site_admin":false},"repo":{"id":97912599,"name":"Charts","full_name":"jjatie/Charts","owner":{"login":"jjatie","id":19879272,"avatar_url":"https://avatars1.githubusercontent.com/u/19879272?v=4","gravatar_id":"","url":"https://api.github.com/users/jjatie","html_url":"https://github.com/jjatie","followers_url":"https://api.github.com/users/jjatie/followers","following_url":"https://api.github.com/users/jjatie/following{/other_user}","gists_url":"https://api.github.com/users/jjatie/gists{/gist_id}","starred_url":"https://api.github.com/users/jjatie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjatie/subscriptions","organizations_url":"https://api.github.com/users/jjatie/orgs","repos_url":"https://api.github.com/users/jjatie/repos","events_url":"https://api.github.com/users/jjatie/events{/privacy}","received_events_url":"https://api.github.com/users/jjatie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jjatie/Charts","description":"Beautiful charts for iOS/tvOS/OSX! The Apple side of the crossplatform MPAndroidChart.","fork":true,"url":"https://api.github.com/repos/jjatie/Charts","forks_url":"https://api.github.com/repos/jjatie/Charts/forks","keys_url":"https://api.github.com/repos/jjatie/Charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jjatie/Charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jjatie/Charts/teams","hooks_url":"https://api.github.com/repos/jjatie/Charts/hooks","issue_events_url":"https://api.github.com/repos/jjatie/Charts/issues/events{/number}","events_url":"https://api.github.com/repos/jjatie/Charts/events","assignees_url":"https://api.github.com/repos/jjatie/Charts/assignees{/user}","branches_url":"https://api.github.com/repos/jjatie/Charts/branches{/branch}","tags_url":"https://api.github.com/repos/jjatie/Charts/tags","blobs_url":"https://api.github.com/repos/jjatie/Charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jjatie/Charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jjatie/Charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/jjatie/Charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jjatie/Charts/statuses/{sha}","languages_url":"https://api.github.com/repos/jjatie/Charts/languages","stargazers_url":"https://api.github.com/repos/jjatie/Charts/stargazers","contributors_url":"https://api.github.com/repos/jjatie/Charts/contributors","subscribers_url":"https://api.github.com/repos/jjatie/Charts/subscribers","subscription_url":"https://api.github.com/repos/jjatie/Charts/subscription","commits_url":"https://api.github.com/repos/jjatie/Charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/jjatie/Charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/jjatie/Charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/jjatie/Charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/jjatie/Charts/contents/{+path}","compare_url":"https://api.github.com/repos/jjatie/Charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jjatie/Charts/merges","archive_url":"https://api.github.com/repos/jjatie/Charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jjatie/Charts/downloads","issues_url":"https://api.github.com/repos/jjatie/Charts/issues{/number}","pulls_url":"https://api.github.com/repos/jjatie/Charts/pulls{/number}","milestones_url":"https://api.github.com/repos/jjatie/Charts/milestones{/number}","notifications_url":"https://api.github.com/repos/jjatie/Charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jjatie/Charts/labels{/name}","releases_url":"https://api.github.com/repos/jjatie/Charts/releases{/id}","deployments_url":"https://api.github.com/repos/jjatie/Charts/deployments","created_at":"2017-07-21T06:15:15Z","updated_at":"2017-09-01T18:11:56Z","pushed_at":"2017-11-06T19:22:16Z","git_url":"git://github.com/jjatie/Charts.git","ssh_url":"git@github.com:jjatie/Charts.git","clone_url":"https://github.com/jjatie/Charts.git","svn_url":"https://github.com/jjatie/Charts","homepage":"","size":151894,"stargazers_count":2,"watchers_count":2,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"danielgindi:master","ref":"master","sha":"3c083f32ec7399b7c43647fa305752e370c7e800","user":{"login":"danielgindi","id":366926,"avatar_url":"https://avatars1.githubusercontent.com/u/366926?v=4","gravatar_id":"","url":"https://api.github.com/users/danielgindi","html_url":"https://github.com/danielgindi","followers_url":"https://api.github.com/users/danielgindi/followers","following_url":"https://api.github.com/users/danielgindi/following{/other_user}","gists_url":"https://api.github.com/users/danielgindi/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgindi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgindi/subscriptions","organizations_url":"https://api.github.com/users/danielgindi/orgs","repos_url":"https://api.github.com/users/danielgindi/repos","events_url":"https://api.github.com/users/danielgindi/events{/privacy}","received_events_url":"https://api.github.com/users/danielgindi/received_events","type":"User","site_admin":false},"repo":{"id":32578467,"name":"Charts","full_name":"danielgindi/Charts","owner":{"login":"danielgindi","id":366926,"avatar_url":"https://avatars1.githubusercontent.com/u/366926?v=4","gravatar_id":"","url":"https://api.github.com/users/danielgindi","html_url":"https://github.com/danielgindi","followers_url":"https://api.github.com/users/danielgindi/followers","following_url":"https://api.github.com/users/danielgindi/following{/other_user}","gists_url":"https://api.github.com/users/danielgindi/gists{/gist_id}","starred_url":"https://api.github.com/users/danielgindi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielgindi/subscriptions","organizations_url":"https://api.github.com/users/danielgindi/orgs","repos_url":"https://api.github.com/users/danielgindi/repos","events_url":"https://api.github.com/users/danielgindi/events{/privacy}","received_events_url":"https://api.github.com/users/danielgindi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danielgindi/Charts","description":"Beautiful charts for iOS/tvOS/OSX! The Apple side of the crossplatform MPAndroidChart.","fork":false,"url":"https://api.github.com/repos/danielgindi/Charts","forks_url":"https://api.github.com/repos/danielgindi/Charts/forks","keys_url":"https://api.github.com/repos/danielgindi/Charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danielgindi/Charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danielgindi/Charts/teams","hooks_url":"https://api.github.com/repos/danielgindi/Charts/hooks","issue_events_url":"https://api.github.com/repos/danielgindi/Charts/issues/events{/number}","events_url":"https://api.github.com/repos/danielgindi/Charts/events","assignees_url":"https://api.github.com/repos/danielgindi/Charts/assignees{/user}","branches_url":"https://api.github.com/repos/danielgindi/Charts/branches{/branch}","tags_url":"https://api.github.com/repos/danielgindi/Charts/tags","blobs_url":"https://api.github.com/repos/danielgindi/Charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danielgindi/Charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danielgindi/Charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/danielgindi/Charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danielgindi/Charts/statuses/{sha}","languages_url":"https://api.github.com/repos/danielgindi/Charts/languages","stargazers_url":"https://api.github.com/repos/danielgindi/Charts/stargazers","contributors_url":"https://api.github.com/repos/danielgindi/Charts/contributors","subscribers_url":"https://api.github.com/repos/danielgindi/Charts/subscribers","subscription_url":"https://api.github.com/repos/danielgindi/Charts/subscription","commits_url":"https://api.github.com/repos/danielgindi/Charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/danielgindi/Charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/danielgindi/Charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/danielgindi/Charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/danielgindi/Charts/contents/{+path}","compare_url":"https://api.github.com/repos/danielgindi/Charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danielgindi/Charts/merges","archive_url":"https://api.github.com/repos/danielgindi/Charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danielgindi/Charts/downloads","issues_url":"https://api.github.com/repos/danielgindi/Charts/issues{/number}","pulls_url":"https://api.github.com/repos/danielgindi/Charts/pulls{/number}","milestones_url":"https://api.github.com/repos/danielgindi/Charts/milestones{/number}","notifications_url":"https://api.github.com/repos/danielgindi/Charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danielgindi/Charts/labels{/name}","releases_url":"https://api.github.com/repos/danielgindi/Charts/releases{/id}","deployments_url":"https://api.github.com/repos/danielgindi/Charts/deployments","created_at":"2015-03-20T10:49:12Z","updated_at":"2017-11-06T20:11:39Z","pushed_at":"2017-11-06T20:27:51Z","git_url":"git://github.com/danielgindi/Charts.git","ssh_url":"git@github.com:danielgindi/Charts.git","clone_url":"https://github.com/danielgindi/Charts.git","svn_url":"https://github.com/danielgindi/Charts","homepage":"","size":151711,"stargazers_count":16269,"watchers_count":16269,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3053,"mirror_url":null,"archived":false,"open_issues_count":355,"forks":3053,"open_issues":355,"watchers":16269,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/danielgindi/Charts/pulls/2737"},"html":{"href":"https://github.com/danielgindi/Charts/pull/2737"},"issue":{"href":"https://api.github.com/repos/danielgindi/Charts/issues/2737"},"comments":{"href":"https://api.github.com/repos/danielgindi/Charts/issues/2737/comments"},"review_comments":{"href":"https://api.github.com/repos/danielgindi/Charts/pulls/2737/comments"},"review_comment":{"href":"https://api.github.com/repos/danielgindi/Charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/danielgindi/Charts/pulls/2737/commits"},"statuses":{"href":"https://api.github.com/repos/danielgindi/Charts/statuses/56b4530f13dd3702a7cf1c3f0ed623439e07c943"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":1642,"deletions":2879,"changed_files":54}}
{"actor":{"display_login":"jjatie"}}