{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/148793726","pull_request_review_id":74093189,"id":148793726,"diff_hunk":"@@ -82,16 +65,53 @@\n \t\t<config-description-ref uri=\"thing-type:tradfri:device\" />\n \t</thing-type>\n \n-\t<!-- note that this isn't yet supported by the code as we do not receive any data from the gateway for it -->\n+\t<thing-type id=\"0107\">\n+\t\t<supported-bridge-type-refs>\n+\t\t\t<bridge-type-ref id=\"gateway\" />\n+\t\t</supported-bridge-type-refs>\n+\n+\t\t<label>Occupancy Sensor Unit</label>","path":"extensions/binding/org.eclipse.smarthome.binding.tradfri/ESH-INF/thing/thing-types.xml","position":null,"original_position":36,"commit_id":"ac26b3170b4deeed42f76912da4b5d3d556ff0c7","original_commit_id":"f0d01953c9ce6c72380ece5bfad8da104eb1af11","user":{"login":"cweitkamp","id":5131747,"avatar_url":"https://avatars0.githubusercontent.com/u/5131747?v=4","gravatar_id":"","url":"https://api.github.com/users/cweitkamp","html_url":"https://github.com/cweitkamp","followers_url":"https://api.github.com/users/cweitkamp/followers","following_url":"https://api.github.com/users/cweitkamp/following{/other_user}","gists_url":"https://api.github.com/users/cweitkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/cweitkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cweitkamp/subscriptions","organizations_url":"https://api.github.com/users/cweitkamp/orgs","repos_url":"https://api.github.com/users/cweitkamp/repos","events_url":"https://api.github.com/users/cweitkamp/events{/privacy}","received_events_url":"https://api.github.com/users/cweitkamp/received_events","type":"User","site_admin":false},"body":"Oh, yes. Done.","created_at":"2017-11-03T14:18:34Z","updated_at":"2017-11-03T14:18:34Z","html_url":"https://github.com/eclipse/smarthome/pull/4373#discussion_r148793726","pull_request_url":"https://api.github.com/repos/eclipse/smarthome/pulls/4373","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/148793726"},"html":{"href":"https://github.com/eclipse/smarthome/pull/4373#discussion_r148793726"},"pull_request":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/4373"}},"in_reply_to_id":148778499},"pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/4373","id":144645795,"html_url":"https://github.com/eclipse/smarthome/pull/4373","diff_url":"https://github.com/eclipse/smarthome/pull/4373.diff","patch_url":"https://github.com/eclipse/smarthome/pull/4373.patch","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/4373","number":4373,"state":"open","locked":false,"title":"[Tradfri] Added support for remote controller and motion sensor devices","user":{"login":"cweitkamp","id":5131747,"avatar_url":"https://avatars0.githubusercontent.com/u/5131747?v=4","gravatar_id":"","url":"https://api.github.com/users/cweitkamp","html_url":"https://github.com/cweitkamp","followers_url":"https://api.github.com/users/cweitkamp/followers","following_url":"https://api.github.com/users/cweitkamp/following{/other_user}","gists_url":"https://api.github.com/users/cweitkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/cweitkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cweitkamp/subscriptions","organizations_url":"https://api.github.com/users/cweitkamp/orgs","repos_url":"https://api.github.com/users/cweitkamp/repos","events_url":"https://api.github.com/users/cweitkamp/events{/privacy}","received_events_url":"https://api.github.com/users/cweitkamp/received_events","type":"User","site_admin":false},"body":"The TRÅDFRI controller and sensor devices currently cannot be observed directly using the coap protocol. We assume that they are communicating directly with the bulbs or lamps without routing their commands through the gateway. This makes it nearly impossible to trigger events or redirect any kind of information to ESH/OH2. Except using workarounds like defining TRÅDFRI groups (see PR #3799).\r\n\r\nMy approach adds the possibility to include those devices using the binding to the users environment and retrieve read-only data like `presence status` or `battery level`. I am happy to hear any feedback.\r\n\r\n- [x] Moved config classes to internal package\r\n- [x] Added support for remote controller and motion sensor devices (read-only, battery level and battery low channels)\r\n- [x] Implement an `abstract TradfriThingHandler` for `TradfriControllerHandler`, `TradfriLightHandler` and `TradfriSensorHandler`\r\n- [x] Extract classes `ControllerData`, `LightData` and `SensorData` from handlers, move to own package (e.g. `o.e.s.b.tradfri.internal.model`) and implement a reusable `abstract TradfriData` class\r\n- [x] Documentation\r\n- [x] Unit Tests\r\n- [x] Find a person who owns a TRÅDFRI dimmer\r\n\r\nSigned-off-by: Christoph Weitkamp <github@christophweitkamp.de>","created_at":"2017-10-04T11:36:52Z","updated_at":"2017-11-03T14:18:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43abb93272a7be072394875778b3acfcc1afb905","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/smarthome/pulls/4373/commits","review_comments_url":"https://api.github.com/repos/eclipse/smarthome/pulls/4373/comments","review_comment_url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/4373/comments","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/ac26b3170b4deeed42f76912da4b5d3d556ff0c7","head":{"label":"cweitkamp:feature-tradfri-remote-control","ref":"feature-tradfri-remote-control","sha":"ac26b3170b4deeed42f76912da4b5d3d556ff0c7","user":{"login":"cweitkamp","id":5131747,"avatar_url":"https://avatars0.githubusercontent.com/u/5131747?v=4","gravatar_id":"","url":"https://api.github.com/users/cweitkamp","html_url":"https://github.com/cweitkamp","followers_url":"https://api.github.com/users/cweitkamp/followers","following_url":"https://api.github.com/users/cweitkamp/following{/other_user}","gists_url":"https://api.github.com/users/cweitkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/cweitkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cweitkamp/subscriptions","organizations_url":"https://api.github.com/users/cweitkamp/orgs","repos_url":"https://api.github.com/users/cweitkamp/repos","events_url":"https://api.github.com/users/cweitkamp/events{/privacy}","received_events_url":"https://api.github.com/users/cweitkamp/received_events","type":"User","site_admin":false},"repo":{"id":89064110,"name":"smarthome","full_name":"cweitkamp/smarthome","owner":{"login":"cweitkamp","id":5131747,"avatar_url":"https://avatars0.githubusercontent.com/u/5131747?v=4","gravatar_id":"","url":"https://api.github.com/users/cweitkamp","html_url":"https://github.com/cweitkamp","followers_url":"https://api.github.com/users/cweitkamp/followers","following_url":"https://api.github.com/users/cweitkamp/following{/other_user}","gists_url":"https://api.github.com/users/cweitkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/cweitkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cweitkamp/subscriptions","organizations_url":"https://api.github.com/users/cweitkamp/orgs","repos_url":"https://api.github.com/users/cweitkamp/repos","events_url":"https://api.github.com/users/cweitkamp/events{/privacy}","received_events_url":"https://api.github.com/users/cweitkamp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cweitkamp/smarthome","description":"Eclipse SmartHome™ project","fork":true,"url":"https://api.github.com/repos/cweitkamp/smarthome","forks_url":"https://api.github.com/repos/cweitkamp/smarthome/forks","keys_url":"https://api.github.com/repos/cweitkamp/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cweitkamp/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cweitkamp/smarthome/teams","hooks_url":"https://api.github.com/repos/cweitkamp/smarthome/hooks","issue_events_url":"https://api.github.com/repos/cweitkamp/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/cweitkamp/smarthome/events","assignees_url":"https://api.github.com/repos/cweitkamp/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/cweitkamp/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/cweitkamp/smarthome/tags","blobs_url":"https://api.github.com/repos/cweitkamp/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cweitkamp/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cweitkamp/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/cweitkamp/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cweitkamp/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/cweitkamp/smarthome/languages","stargazers_url":"https://api.github.com/repos/cweitkamp/smarthome/stargazers","contributors_url":"https://api.github.com/repos/cweitkamp/smarthome/contributors","subscribers_url":"https://api.github.com/repos/cweitkamp/smarthome/subscribers","subscription_url":"https://api.github.com/repos/cweitkamp/smarthome/subscription","commits_url":"https://api.github.com/repos/cweitkamp/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/cweitkamp/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/cweitkamp/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/cweitkamp/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/cweitkamp/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/cweitkamp/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cweitkamp/smarthome/merges","archive_url":"https://api.github.com/repos/cweitkamp/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cweitkamp/smarthome/downloads","issues_url":"https://api.github.com/repos/cweitkamp/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/cweitkamp/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/cweitkamp/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/cweitkamp/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cweitkamp/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/cweitkamp/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/cweitkamp/smarthome/deployments","created_at":"2017-04-22T11:13:07Z","updated_at":"2017-04-22T11:13:16Z","pushed_at":"2017-11-03T14:17:49Z","git_url":"git://github.com/cweitkamp/smarthome.git","ssh_url":"git@github.com:cweitkamp/smarthome.git","clone_url":"https://github.com/cweitkamp/smarthome.git","svn_url":"https://github.com/cweitkamp/smarthome","homepage":"https://www.eclipse.org/smarthome/","size":33413,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"913af795fa290647152d08eccec336629dd9f2da","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15778981,"name":"smarthome","full_name":"eclipse/smarthome","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/smarthome","description":"Eclipse SmartHome™ project","fork":false,"url":"https://api.github.com/repos/eclipse/smarthome","forks_url":"https://api.github.com/repos/eclipse/smarthome/forks","keys_url":"https://api.github.com/repos/eclipse/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/smarthome/teams","hooks_url":"https://api.github.com/repos/eclipse/smarthome/hooks","issue_events_url":"https://api.github.com/repos/eclipse/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/smarthome/events","assignees_url":"https://api.github.com/repos/eclipse/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/smarthome/tags","blobs_url":"https://api.github.com/repos/eclipse/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/smarthome/languages","stargazers_url":"https://api.github.com/repos/eclipse/smarthome/stargazers","contributors_url":"https://api.github.com/repos/eclipse/smarthome/contributors","subscribers_url":"https://api.github.com/repos/eclipse/smarthome/subscribers","subscription_url":"https://api.github.com/repos/eclipse/smarthome/subscription","commits_url":"https://api.github.com/repos/eclipse/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/smarthome/merges","archive_url":"https://api.github.com/repos/eclipse/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/smarthome/downloads","issues_url":"https://api.github.com/repos/eclipse/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/smarthome/deployments","created_at":"2014-01-09T20:47:19Z","updated_at":"2017-11-01T21:38:03Z","pushed_at":"2017-11-03T14:17:51Z","git_url":"git://github.com/eclipse/smarthome.git","ssh_url":"git@github.com:eclipse/smarthome.git","clone_url":"https://github.com/eclipse/smarthome.git","svn_url":"https://github.com/eclipse/smarthome","homepage":"https://www.eclipse.org/smarthome/","size":38111,"stargazers_count":574,"watchers_count":574,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":576,"mirror_url":null,"archived":false,"open_issues_count":343,"forks":576,"open_issues":343,"watchers":574,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/4373"},"html":{"href":"https://github.com/eclipse/smarthome/pull/4373"},"issue":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/4373"},"comments":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/4373/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/4373/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/4373/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/smarthome/statuses/ac26b3170b4deeed42f76912da4b5d3d556ff0c7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cweitkamp"}}