{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/151960437","pull_request_review_id":77747341,"id":151960437,"diff_hunk":"@@ -38,6 +38,11 @@ import (\n type SecureServingOptions struct {\n \tBindAddress net.IP\n \tBindPort    int\n+\t// BindNetwork is the type of network to bind to - defaults to \"tcp\", accepts \"tcp\",\n+\t// \"tcp4\", and \"tcp6\".\n+\tBindNetwork string\n+\t// Listener is the secure server network listener.","path":"staging/src/k8s.io/apiserver/pkg/server/options/serving.go","position":7,"original_position":7,"commit_id":"c2e28ab43ce3514778b9b4f5f1c8cbb1620d731a","original_commit_id":"c2e28ab43ce3514778b9b4f5f1c8cbb1620d731a","user":{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"body":"this still needs docs that either BindAddress+BindPort+BindNetwork are set **or** Listener.","created_at":"2017-11-20T11:01:09Z","updated_at":"2017-11-20T11:01:09Z","html_url":"https://github.com/kubernetes/kubernetes/pull/55859#discussion_r151960437","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55859","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/151960437"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/55859#discussion_r151960437"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55859"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55859","id":152988533,"html_url":"https://github.com/kubernetes/kubernetes/pull/55859","diff_url":"https://github.com/kubernetes/kubernetes/pull/55859.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/55859.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/55859","number":55859,"state":"open","locked":false,"title":"apiserver:  pass a listener into genericapiserver bootstrapping ","user":{"login":"hzxuzhonghu","id":13374016,"avatar_url":"https://avatars3.githubusercontent.com/u/13374016?v=4","gravatar_id":"","url":"https://api.github.com/users/hzxuzhonghu","html_url":"https://github.com/hzxuzhonghu","followers_url":"https://api.github.com/users/hzxuzhonghu/followers","following_url":"https://api.github.com/users/hzxuzhonghu/following{/other_user}","gists_url":"https://api.github.com/users/hzxuzhonghu/gists{/gist_id}","starred_url":"https://api.github.com/users/hzxuzhonghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzxuzhonghu/subscriptions","organizations_url":"https://api.github.com/users/hzxuzhonghu/orgs","repos_url":"https://api.github.com/users/hzxuzhonghu/repos","events_url":"https://api.github.com/users/hzxuzhonghu/events{/privacy}","received_events_url":"https://api.github.com/users/hzxuzhonghu/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n>At the moment we pass a port via the options into the config. A zero port does not work because the loopback clients created during apiserver initialization need to know the port before. Passing a listener into the server instead would allow us to use a zero port beforehand and bootstrapping order should be fine.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #55784\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\npass tcp listener to genericapiserver config\r\n```\r\n","created_at":"2017-11-16T09:24:35Z","updated_at":"2017-11-20T11:01:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fbf15aab9cd0ac75c6e4c3eaad6823c355a2a1c","assignee":{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},"assignees":[{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55859/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55859/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/55859/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c2e28ab43ce3514778b9b4f5f1c8cbb1620d731a","head":{"label":"hzxuzhonghu:listener-genericapiserver","ref":"listener-genericapiserver","sha":"c2e28ab43ce3514778b9b4f5f1c8cbb1620d731a","user":{"login":"hzxuzhonghu","id":13374016,"avatar_url":"https://avatars3.githubusercontent.com/u/13374016?v=4","gravatar_id":"","url":"https://api.github.com/users/hzxuzhonghu","html_url":"https://github.com/hzxuzhonghu","followers_url":"https://api.github.com/users/hzxuzhonghu/followers","following_url":"https://api.github.com/users/hzxuzhonghu/following{/other_user}","gists_url":"https://api.github.com/users/hzxuzhonghu/gists{/gist_id}","starred_url":"https://api.github.com/users/hzxuzhonghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzxuzhonghu/subscriptions","organizations_url":"https://api.github.com/users/hzxuzhonghu/orgs","repos_url":"https://api.github.com/users/hzxuzhonghu/repos","events_url":"https://api.github.com/users/hzxuzhonghu/events{/privacy}","received_events_url":"https://api.github.com/users/hzxuzhonghu/received_events","type":"User","site_admin":false},"repo":{"id":99755290,"name":"kubernetes","full_name":"hzxuzhonghu/kubernetes","owner":{"login":"hzxuzhonghu","id":13374016,"avatar_url":"https://avatars3.githubusercontent.com/u/13374016?v=4","gravatar_id":"","url":"https://api.github.com/users/hzxuzhonghu","html_url":"https://github.com/hzxuzhonghu","followers_url":"https://api.github.com/users/hzxuzhonghu/followers","following_url":"https://api.github.com/users/hzxuzhonghu/following{/other_user}","gists_url":"https://api.github.com/users/hzxuzhonghu/gists{/gist_id}","starred_url":"https://api.github.com/users/hzxuzhonghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzxuzhonghu/subscriptions","organizations_url":"https://api.github.com/users/hzxuzhonghu/orgs","repos_url":"https://api.github.com/users/hzxuzhonghu/repos","events_url":"https://api.github.com/users/hzxuzhonghu/events{/privacy}","received_events_url":"https://api.github.com/users/hzxuzhonghu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hzxuzhonghu/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/hzxuzhonghu/kubernetes","forks_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/forks","keys_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/teams","hooks_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/events","assignees_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/tags","blobs_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/languages","stargazers_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/subscription","commits_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/merges","archive_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/downloads","issues_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/hzxuzhonghu/kubernetes/deployments","created_at":"2017-08-09T02:12:15Z","updated_at":"2017-08-09T02:12:55Z","pushed_at":"2017-11-20T10:53:30Z","git_url":"git://github.com/hzxuzhonghu/kubernetes.git","ssh_url":"git@github.com:hzxuzhonghu/kubernetes.git","clone_url":"https://github.com/hzxuzhonghu/kubernetes.git","svn_url":"https://github.com/hzxuzhonghu/kubernetes","homepage":"http://kubernetes.io","size":522667,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"54a4de04c04ed74ec4157e1c538244e785fd282a","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-11-20T10:20:51Z","pushed_at":"2017-11-20T10:57:10Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":745749,"stargazers_count":29074,"watchers_count":29074,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10401,"mirror_url":null,"archived":false,"open_issues_count":5531,"forks":10401,"open_issues":5531,"watchers":29074,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55859"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/55859"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/55859"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/55859/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55859/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55859/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/c2e28ab43ce3514778b9b4f5f1c8cbb1620d731a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sttts"}}