{"action":"closed","issue":{"url":"https://api.github.com/repos/gjb2048/moodle-theme_essential/issues/842","repository_url":"https://api.github.com/repos/gjb2048/moodle-theme_essential","labels_url":"https://api.github.com/repos/gjb2048/moodle-theme_essential/issues/842/labels{/name}","comments_url":"https://api.github.com/repos/gjb2048/moodle-theme_essential/issues/842/comments","events_url":"https://api.github.com/repos/gjb2048/moodle-theme_essential/issues/842/events","html_url":"https://github.com/gjb2048/moodle-theme_essential/issues/842","id":251166257,"number":842,"title":"Would it be possible to change a private to a protected?","user":{"login":"Tazoeur","id":14344138,"avatar_url":"https://avatars3.githubusercontent.com/u/14344138?v=4","gravatar_id":"","url":"https://api.github.com/users/Tazoeur","html_url":"https://github.com/Tazoeur","followers_url":"https://api.github.com/users/Tazoeur/followers","following_url":"https://api.github.com/users/Tazoeur/following{/other_user}","gists_url":"https://api.github.com/users/Tazoeur/gists{/gist_id}","starred_url":"https://api.github.com/users/Tazoeur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tazoeur/subscriptions","organizations_url":"https://api.github.com/users/Tazoeur/orgs","repos_url":"https://api.github.com/users/Tazoeur/repos","events_url":"https://api.github.com/users/Tazoeur/events{/privacy}","received_events_url":"https://api.github.com/users/Tazoeur/received_events","type":"User","site_admin":false},"labels":[{"id":111176480,"url":"https://api.github.com/repos/gjb2048/moodle-theme_essential/labels/Enhancement","name":"Enhancement","color":"84b6eb","default":false}],"state":"closed","locked":false,"assignee":{"login":"gjb2048","id":1058419,"avatar_url":"https://avatars2.githubusercontent.com/u/1058419?v=4","gravatar_id":"","url":"https://api.github.com/users/gjb2048","html_url":"https://github.com/gjb2048","followers_url":"https://api.github.com/users/gjb2048/followers","following_url":"https://api.github.com/users/gjb2048/following{/other_user}","gists_url":"https://api.github.com/users/gjb2048/gists{/gist_id}","starred_url":"https://api.github.com/users/gjb2048/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjb2048/subscriptions","organizations_url":"https://api.github.com/users/gjb2048/orgs","repos_url":"https://api.github.com/users/gjb2048/repos","events_url":"https://api.github.com/users/gjb2048/events{/privacy}","received_events_url":"https://api.github.com/users/gjb2048/received_events","type":"User","site_admin":false},"assignees":[{"login":"gjb2048","id":1058419,"avatar_url":"https://avatars2.githubusercontent.com/u/1058419?v=4","gravatar_id":"","url":"https://api.github.com/users/gjb2048","html_url":"https://github.com/gjb2048","followers_url":"https://api.github.com/users/gjb2048/followers","following_url":"https://api.github.com/users/gjb2048/following{/other_user}","gists_url":"https://api.github.com/users/gjb2048/gists{/gist_id}","starred_url":"https://api.github.com/users/gjb2048/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gjb2048/subscriptions","organizations_url":"https://api.github.com/users/gjb2048/orgs","repos_url":"https://api.github.com/users/gjb2048/repos","events_url":"https://api.github.com/users/gjb2048/events{/privacy}","received_events_url":"https://api.github.com/users/gjb2048/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-08-18T07:48:03Z","updated_at":"2017-08-24T16:59:04Z","closed_at":"2017-08-24T16:59:04Z","body":"Hi,\r\nFirst of all, I'd like to thank you for the great work you do on this theme plugin.\r\n\r\nI am currently overriding the function custom_menu_user() by extending your \\theme_essential\\output\\core_renderer.\r\n\r\nThe problem I have is that the private function getfontawesomemarkup() is used in the custom_menu_user() function.\r\n\r\nI can bypass the problem by copy/pasting the function getfontawesomemarkup() inside my renderer but If you could change the visibility of this function from private to protected, it will make things easier and IMHO improve the usability of this class.\r\n\r\nRegards,\r\nGuillaume"}}
{"actor":{"display_login":"gjb2048"}}