{"action":"created","comment":{"url":"https://api.github.com/repos/lasp-lang/partisan/pulls/comments/98335679","pull_request_review_id":18977676,"id":98335679,"diff_hunk":"@@ -29,11 +29,36 @@\n          get/2]).\n \n init() ->\n-    %% Generate a random peer port.\n-    rand_compat:seed(erlang:phash2([node()]),\n-                     erlang:monotonic_time(),\n-                     erlang:unique_integer()),\n-    RandomPeerPort = rand_compat:uniform(1000) + 10000,\n+    %% override Erlang env configuration with OS var configurations if set\n+    IPAddress = case os:getenv(\"IP\", \"false\") of\n+                    \"false\" ->\n+                        ?PEER_IP;\n+                    IP ->\n+                        {ok, ParsedIP} = inet_parse:address(IP),\n+                        application:set_env(partisan, peer_ip, ParsedIP),","path":"src/partisan_config.erl","position":15,"original_position":15,"commit_id":"b7449bd589d3898646bf7bc206355141b5a5d1c1","original_commit_id":"b7449bd589d3898646bf7bc206355141b5a5d1c1","user":{"login":"tsloughter","id":36227,"avatar_url":"https://avatars.githubusercontent.com/u/36227?v=3","gravatar_id":"","url":"https://api.github.com/users/tsloughter","html_url":"https://github.com/tsloughter","followers_url":"https://api.github.com/users/tsloughter/followers","following_url":"https://api.github.com/users/tsloughter/following{/other_user}","gists_url":"https://api.github.com/users/tsloughter/gists{/gist_id}","starred_url":"https://api.github.com/users/tsloughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsloughter/subscriptions","organizations_url":"https://api.github.com/users/tsloughter/orgs","repos_url":"https://api.github.com/users/tsloughter/repos","events_url":"https://api.github.com/users/tsloughter/events{/privacy}","received_events_url":"https://api.github.com/users/tsloughter/received_events","type":"User","site_admin":false},"body":"Yea. It definitely shouldn't break lasp, my hope is it will allow me to remove parts from lasp which I'll send in a PR once this is merged.","created_at":"2017-01-28T17:47:30Z","updated_at":"2017-01-28T17:47:30Z","html_url":"https://github.com/lasp-lang/partisan/pull/24#discussion_r98335679","pull_request_url":"https://api.github.com/repos/lasp-lang/partisan/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/lasp-lang/partisan/pulls/comments/98335679"},"html":{"href":"https://github.com/lasp-lang/partisan/pull/24#discussion_r98335679"},"pull_request":{"href":"https://api.github.com/repos/lasp-lang/partisan/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/lasp-lang/partisan/pulls/24","id":103568324,"html_url":"https://github.com/lasp-lang/partisan/pull/24","diff_url":"https://github.com/lasp-lang/partisan/pull/24.diff","patch_url":"https://github.com/lasp-lang/partisan/pull/24.patch","issue_url":"https://api.github.com/repos/lasp-lang/partisan/issues/24","number":24,"state":"open","locked":false,"title":"support OS var configuration of ip, port and peer service","user":{"login":"tsloughter","id":36227,"avatar_url":"https://avatars.githubusercontent.com/u/36227?v=3","gravatar_id":"","url":"https://api.github.com/users/tsloughter","html_url":"https://github.com/tsloughter","followers_url":"https://api.github.com/users/tsloughter/followers","following_url":"https://api.github.com/users/tsloughter/following{/other_user}","gists_url":"https://api.github.com/users/tsloughter/gists{/gist_id}","starred_url":"https://api.github.com/users/tsloughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsloughter/subscriptions","organizations_url":"https://api.github.com/users/tsloughter/orgs","repos_url":"https://api.github.com/users/tsloughter/repos","events_url":"https://api.github.com/users/tsloughter/events{/privacy}","received_events_url":"https://api.github.com/users/tsloughter/received_events","type":"User","site_admin":false},"body":"These changes I think will allow lasp to not require partisan as an included application because you can set ip, port and peer service through the OS vars as is done in lasp itself currently.\r\n\r\nI have a separate PR coming for lasp if this is merged.","created_at":"2017-01-27T21:17:44Z","updated_at":"2017-01-28T17:47:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"963e67e234d8727b6c5b33f326a68f2067aee2fa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lasp-lang/partisan/pulls/24/commits","review_comments_url":"https://api.github.com/repos/lasp-lang/partisan/pulls/24/comments","review_comment_url":"https://api.github.com/repos/lasp-lang/partisan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lasp-lang/partisan/issues/24/comments","statuses_url":"https://api.github.com/repos/lasp-lang/partisan/statuses/b7449bd589d3898646bf7bc206355141b5a5d1c1","head":{"label":"tsloughter:master","ref":"master","sha":"b7449bd589d3898646bf7bc206355141b5a5d1c1","user":{"login":"tsloughter","id":36227,"avatar_url":"https://avatars.githubusercontent.com/u/36227?v=3","gravatar_id":"","url":"https://api.github.com/users/tsloughter","html_url":"https://github.com/tsloughter","followers_url":"https://api.github.com/users/tsloughter/followers","following_url":"https://api.github.com/users/tsloughter/following{/other_user}","gists_url":"https://api.github.com/users/tsloughter/gists{/gist_id}","starred_url":"https://api.github.com/users/tsloughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsloughter/subscriptions","organizations_url":"https://api.github.com/users/tsloughter/orgs","repos_url":"https://api.github.com/users/tsloughter/repos","events_url":"https://api.github.com/users/tsloughter/events{/privacy}","received_events_url":"https://api.github.com/users/tsloughter/received_events","type":"User","site_admin":false},"repo":{"id":77963272,"name":"partisan","full_name":"tsloughter/partisan","owner":{"login":"tsloughter","id":36227,"avatar_url":"https://avatars.githubusercontent.com/u/36227?v=3","gravatar_id":"","url":"https://api.github.com/users/tsloughter","html_url":"https://github.com/tsloughter","followers_url":"https://api.github.com/users/tsloughter/followers","following_url":"https://api.github.com/users/tsloughter/following{/other_user}","gists_url":"https://api.github.com/users/tsloughter/gists{/gist_id}","starred_url":"https://api.github.com/users/tsloughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsloughter/subscriptions","organizations_url":"https://api.github.com/users/tsloughter/orgs","repos_url":"https://api.github.com/users/tsloughter/repos","events_url":"https://api.github.com/users/tsloughter/events{/privacy}","received_events_url":"https://api.github.com/users/tsloughter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsloughter/partisan","description":"Prototype scalable peer service for Lasp.","fork":true,"url":"https://api.github.com/repos/tsloughter/partisan","forks_url":"https://api.github.com/repos/tsloughter/partisan/forks","keys_url":"https://api.github.com/repos/tsloughter/partisan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsloughter/partisan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsloughter/partisan/teams","hooks_url":"https://api.github.com/repos/tsloughter/partisan/hooks","issue_events_url":"https://api.github.com/repos/tsloughter/partisan/issues/events{/number}","events_url":"https://api.github.com/repos/tsloughter/partisan/events","assignees_url":"https://api.github.com/repos/tsloughter/partisan/assignees{/user}","branches_url":"https://api.github.com/repos/tsloughter/partisan/branches{/branch}","tags_url":"https://api.github.com/repos/tsloughter/partisan/tags","blobs_url":"https://api.github.com/repos/tsloughter/partisan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsloughter/partisan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsloughter/partisan/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsloughter/partisan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsloughter/partisan/statuses/{sha}","languages_url":"https://api.github.com/repos/tsloughter/partisan/languages","stargazers_url":"https://api.github.com/repos/tsloughter/partisan/stargazers","contributors_url":"https://api.github.com/repos/tsloughter/partisan/contributors","subscribers_url":"https://api.github.com/repos/tsloughter/partisan/subscribers","subscription_url":"https://api.github.com/repos/tsloughter/partisan/subscription","commits_url":"https://api.github.com/repos/tsloughter/partisan/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsloughter/partisan/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsloughter/partisan/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsloughter/partisan/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsloughter/partisan/contents/{+path}","compare_url":"https://api.github.com/repos/tsloughter/partisan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsloughter/partisan/merges","archive_url":"https://api.github.com/repos/tsloughter/partisan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsloughter/partisan/downloads","issues_url":"https://api.github.com/repos/tsloughter/partisan/issues{/number}","pulls_url":"https://api.github.com/repos/tsloughter/partisan/pulls{/number}","milestones_url":"https://api.github.com/repos/tsloughter/partisan/milestones{/number}","notifications_url":"https://api.github.com/repos/tsloughter/partisan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsloughter/partisan/labels{/name}","releases_url":"https://api.github.com/repos/tsloughter/partisan/releases{/id}","deployments_url":"https://api.github.com/repos/tsloughter/partisan/deployments","created_at":"2017-01-03T23:50:47Z","updated_at":"2017-01-03T23:50:49Z","pushed_at":"2017-01-27T21:16:16Z","git_url":"git://github.com/tsloughter/partisan.git","ssh_url":"git@github.com:tsloughter/partisan.git","clone_url":"https://github.com/tsloughter/partisan.git","svn_url":"https://github.com/tsloughter/partisan","homepage":"https://lasp-lang.org","size":1755,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lasp-lang:master","ref":"master","sha":"d40ceffc351c72119457891b1f915da79e90f427","user":{"login":"lasp-lang","id":12764735,"avatar_url":"https://avatars.githubusercontent.com/u/12764735?v=3","gravatar_id":"","url":"https://api.github.com/users/lasp-lang","html_url":"https://github.com/lasp-lang","followers_url":"https://api.github.com/users/lasp-lang/followers","following_url":"https://api.github.com/users/lasp-lang/following{/other_user}","gists_url":"https://api.github.com/users/lasp-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/lasp-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasp-lang/subscriptions","organizations_url":"https://api.github.com/users/lasp-lang/orgs","repos_url":"https://api.github.com/users/lasp-lang/repos","events_url":"https://api.github.com/users/lasp-lang/events{/privacy}","received_events_url":"https://api.github.com/users/lasp-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":57875192,"name":"partisan","full_name":"lasp-lang/partisan","owner":{"login":"lasp-lang","id":12764735,"avatar_url":"https://avatars.githubusercontent.com/u/12764735?v=3","gravatar_id":"","url":"https://api.github.com/users/lasp-lang","html_url":"https://github.com/lasp-lang","followers_url":"https://api.github.com/users/lasp-lang/followers","following_url":"https://api.github.com/users/lasp-lang/following{/other_user}","gists_url":"https://api.github.com/users/lasp-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/lasp-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasp-lang/subscriptions","organizations_url":"https://api.github.com/users/lasp-lang/orgs","repos_url":"https://api.github.com/users/lasp-lang/repos","events_url":"https://api.github.com/users/lasp-lang/events{/privacy}","received_events_url":"https://api.github.com/users/lasp-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lasp-lang/partisan","description":"Prototype scalable peer service for Lasp.","fork":false,"url":"https://api.github.com/repos/lasp-lang/partisan","forks_url":"https://api.github.com/repos/lasp-lang/partisan/forks","keys_url":"https://api.github.com/repos/lasp-lang/partisan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lasp-lang/partisan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lasp-lang/partisan/teams","hooks_url":"https://api.github.com/repos/lasp-lang/partisan/hooks","issue_events_url":"https://api.github.com/repos/lasp-lang/partisan/issues/events{/number}","events_url":"https://api.github.com/repos/lasp-lang/partisan/events","assignees_url":"https://api.github.com/repos/lasp-lang/partisan/assignees{/user}","branches_url":"https://api.github.com/repos/lasp-lang/partisan/branches{/branch}","tags_url":"https://api.github.com/repos/lasp-lang/partisan/tags","blobs_url":"https://api.github.com/repos/lasp-lang/partisan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lasp-lang/partisan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lasp-lang/partisan/git/refs{/sha}","trees_url":"https://api.github.com/repos/lasp-lang/partisan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lasp-lang/partisan/statuses/{sha}","languages_url":"https://api.github.com/repos/lasp-lang/partisan/languages","stargazers_url":"https://api.github.com/repos/lasp-lang/partisan/stargazers","contributors_url":"https://api.github.com/repos/lasp-lang/partisan/contributors","subscribers_url":"https://api.github.com/repos/lasp-lang/partisan/subscribers","subscription_url":"https://api.github.com/repos/lasp-lang/partisan/subscription","commits_url":"https://api.github.com/repos/lasp-lang/partisan/commits{/sha}","git_commits_url":"https://api.github.com/repos/lasp-lang/partisan/git/commits{/sha}","comments_url":"https://api.github.com/repos/lasp-lang/partisan/comments{/number}","issue_comment_url":"https://api.github.com/repos/lasp-lang/partisan/issues/comments{/number}","contents_url":"https://api.github.com/repos/lasp-lang/partisan/contents/{+path}","compare_url":"https://api.github.com/repos/lasp-lang/partisan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lasp-lang/partisan/merges","archive_url":"https://api.github.com/repos/lasp-lang/partisan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lasp-lang/partisan/downloads","issues_url":"https://api.github.com/repos/lasp-lang/partisan/issues{/number}","pulls_url":"https://api.github.com/repos/lasp-lang/partisan/pulls{/number}","milestones_url":"https://api.github.com/repos/lasp-lang/partisan/milestones{/number}","notifications_url":"https://api.github.com/repos/lasp-lang/partisan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lasp-lang/partisan/labels{/name}","releases_url":"https://api.github.com/repos/lasp-lang/partisan/releases{/id}","deployments_url":"https://api.github.com/repos/lasp-lang/partisan/deployments","created_at":"2016-05-02T08:33:07Z","updated_at":"2016-12-16T10:48:21Z","pushed_at":"2017-01-27T21:17:45Z","git_url":"git://github.com/lasp-lang/partisan.git","ssh_url":"git@github.com:lasp-lang/partisan.git","clone_url":"https://github.com/lasp-lang/partisan.git","svn_url":"https://github.com/lasp-lang/partisan","homepage":"https://lasp-lang.org","size":1754,"stargazers_count":13,"watchers_count":13,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lasp-lang/partisan/pulls/24"},"html":{"href":"https://github.com/lasp-lang/partisan/pull/24"},"issue":{"href":"https://api.github.com/repos/lasp-lang/partisan/issues/24"},"comments":{"href":"https://api.github.com/repos/lasp-lang/partisan/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/lasp-lang/partisan/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/lasp-lang/partisan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lasp-lang/partisan/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/lasp-lang/partisan/statuses/b7449bd589d3898646bf7bc206355141b5a5d1c1"}}}}
{"actor":{"display_login":"tsloughter"}}