{"action":"closed","number":1166,"pull_request":{"url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1166","id":126863638,"html_url":"https://github.com/coreos/tectonic-installer/pull/1166","diff_url":"https://github.com/coreos/tectonic-installer/pull/1166.diff","patch_url":"https://github.com/coreos/tectonic-installer/pull/1166.patch","issue_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/1166","number":1166,"state":"closed","locked":false,"title":"modules/aws/etcd/nodes.tf: change hardcoded value of IOPS to 100","user":{"login":"Quentin-M","id":1332289,"avatar_url":"https://avatars2.githubusercontent.com/u/1332289?v=3","gravatar_id":"","url":"https://api.github.com/users/Quentin-M","html_url":"https://github.com/Quentin-M","followers_url":"https://api.github.com/users/Quentin-M/followers","following_url":"https://api.github.com/users/Quentin-M/following{/other_user}","gists_url":"https://api.github.com/users/Quentin-M/gists{/gist_id}","starred_url":"https://api.github.com/users/Quentin-M/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quentin-M/subscriptions","organizations_url":"https://api.github.com/users/Quentin-M/orgs","repos_url":"https://api.github.com/users/Quentin-M/repos","events_url":"https://api.github.com/users/Quentin-M/events{/privacy}","received_events_url":"https://api.github.com/users/Quentin-M/received_events","type":"User","site_admin":false},"body":"This is to prevent Terraform from destroying/re-creating the etcd nodes right away\r\nafter a deployment where root_volume_type is not io1.\r\n\r\nI am tempted to add ``lifecycle { ignore_changes = [ \"*\" ] }``.\r\n\r\nFixes #1035\r\nAlso created https://github.com/coreos/tectonic-installer/issues/1167 for future ref","created_at":"2017-06-21T21:21:32Z","updated_at":"2017-06-23T22:06:09Z","closed_at":"2017-06-23T22:06:09Z","merged_at":"2017-06-23T22:06:08Z","merge_commit_sha":"863151fac0b9c5a1d8b3dbbba30c84b9fdc96505","assignee":null,"assignees":[],"requested_reviewers":[{"login":"s-urbaniak","id":375856,"avatar_url":"https://avatars2.githubusercontent.com/u/375856?v=3","gravatar_id":"","url":"https://api.github.com/users/s-urbaniak","html_url":"https://github.com/s-urbaniak","followers_url":"https://api.github.com/users/s-urbaniak/followers","following_url":"https://api.github.com/users/s-urbaniak/following{/other_user}","gists_url":"https://api.github.com/users/s-urbaniak/gists{/gist_id}","starred_url":"https://api.github.com/users/s-urbaniak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-urbaniak/subscriptions","organizations_url":"https://api.github.com/users/s-urbaniak/orgs","repos_url":"https://api.github.com/users/s-urbaniak/repos","events_url":"https://api.github.com/users/s-urbaniak/events{/privacy}","received_events_url":"https://api.github.com/users/s-urbaniak/received_events","type":"User","site_admin":false},{"login":"squat","id":20484159,"avatar_url":"https://avatars2.githubusercontent.com/u/20484159?v=3","gravatar_id":"","url":"https://api.github.com/users/squat","html_url":"https://github.com/squat","followers_url":"https://api.github.com/users/squat/followers","following_url":"https://api.github.com/users/squat/following{/other_user}","gists_url":"https://api.github.com/users/squat/gists{/gist_id}","starred_url":"https://api.github.com/users/squat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squat/subscriptions","organizations_url":"https://api.github.com/users/squat/orgs","repos_url":"https://api.github.com/users/squat/repos","events_url":"https://api.github.com/users/squat/events{/privacy}","received_events_url":"https://api.github.com/users/squat/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1166/commits","review_comments_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1166/comments","review_comment_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/1166/comments","statuses_url":"https://api.github.com/repos/coreos/tectonic-installer/statuses/93d485d9eddafe1e70bacf39407d313ab4d6d684","head":{"label":"Quentin-M:etcd_iops","ref":"etcd_iops","sha":"93d485d9eddafe1e70bacf39407d313ab4d6d684","user":{"login":"Quentin-M","id":1332289,"avatar_url":"https://avatars2.githubusercontent.com/u/1332289?v=3","gravatar_id":"","url":"https://api.github.com/users/Quentin-M","html_url":"https://github.com/Quentin-M","followers_url":"https://api.github.com/users/Quentin-M/followers","following_url":"https://api.github.com/users/Quentin-M/following{/other_user}","gists_url":"https://api.github.com/users/Quentin-M/gists{/gist_id}","starred_url":"https://api.github.com/users/Quentin-M/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quentin-M/subscriptions","organizations_url":"https://api.github.com/users/Quentin-M/orgs","repos_url":"https://api.github.com/users/Quentin-M/repos","events_url":"https://api.github.com/users/Quentin-M/events{/privacy}","received_events_url":"https://api.github.com/users/Quentin-M/received_events","type":"User","site_admin":false},"repo":{"id":85979256,"name":"tectonic-installer","full_name":"Quentin-M/tectonic-installer","owner":{"login":"Quentin-M","id":1332289,"avatar_url":"https://avatars2.githubusercontent.com/u/1332289?v=3","gravatar_id":"","url":"https://api.github.com/users/Quentin-M","html_url":"https://github.com/Quentin-M","followers_url":"https://api.github.com/users/Quentin-M/followers","following_url":"https://api.github.com/users/Quentin-M/following{/other_user}","gists_url":"https://api.github.com/users/Quentin-M/gists{/gist_id}","starred_url":"https://api.github.com/users/Quentin-M/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quentin-M/subscriptions","organizations_url":"https://api.github.com/users/Quentin-M/orgs","repos_url":"https://api.github.com/users/Quentin-M/repos","events_url":"https://api.github.com/users/Quentin-M/events{/privacy}","received_events_url":"https://api.github.com/users/Quentin-M/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Quentin-M/tectonic-installer","description":"Install a Kubernetes cluster the CoreOS Tectonic Way: HA, self-hosted, RBAC, etcd Operator, and more","fork":true,"url":"https://api.github.com/repos/Quentin-M/tectonic-installer","forks_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/forks","keys_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/teams","hooks_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/hooks","issue_events_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/issues/events{/number}","events_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/events","assignees_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/assignees{/user}","branches_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/branches{/branch}","tags_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/tags","blobs_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/languages","stargazers_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/stargazers","contributors_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/contributors","subscribers_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/subscribers","subscription_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/subscription","commits_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/contents/{+path}","compare_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/merges","archive_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/downloads","issues_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/issues{/number}","pulls_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/labels{/name}","releases_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/releases{/id}","deployments_url":"https://api.github.com/repos/Quentin-M/tectonic-installer/deployments","created_at":"2017-03-23T17:39:15Z","updated_at":"2017-03-23T17:39:16Z","pushed_at":"2017-06-22T21:56:42Z","git_url":"git://github.com/Quentin-M/tectonic-installer.git","ssh_url":"git@github.com:Quentin-M/tectonic-installer.git","clone_url":"https://github.com/Quentin-M/tectonic-installer.git","svn_url":"https://github.com/Quentin-M/tectonic-installer","homepage":"","size":24882,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"305f907a9a15560c8d87af813d6efc949b03b8f8","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars0.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":81620471,"name":"tectonic-installer","full_name":"coreos/tectonic-installer","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars0.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/tectonic-installer","description":"Install a Kubernetes cluster the CoreOS Tectonic Way: HA, self-hosted, RBAC, etcd Operator, and more","fork":false,"url":"https://api.github.com/repos/coreos/tectonic-installer","forks_url":"https://api.github.com/repos/coreos/tectonic-installer/forks","keys_url":"https://api.github.com/repos/coreos/tectonic-installer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/tectonic-installer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/tectonic-installer/teams","hooks_url":"https://api.github.com/repos/coreos/tectonic-installer/hooks","issue_events_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/tectonic-installer/events","assignees_url":"https://api.github.com/repos/coreos/tectonic-installer/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/tectonic-installer/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/tectonic-installer/tags","blobs_url":"https://api.github.com/repos/coreos/tectonic-installer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/tectonic-installer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/tectonic-installer/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/tectonic-installer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/tectonic-installer/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/tectonic-installer/languages","stargazers_url":"https://api.github.com/repos/coreos/tectonic-installer/stargazers","contributors_url":"https://api.github.com/repos/coreos/tectonic-installer/contributors","subscribers_url":"https://api.github.com/repos/coreos/tectonic-installer/subscribers","subscription_url":"https://api.github.com/repos/coreos/tectonic-installer/subscription","commits_url":"https://api.github.com/repos/coreos/tectonic-installer/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/tectonic-installer/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/tectonic-installer/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/tectonic-installer/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/tectonic-installer/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/tectonic-installer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/tectonic-installer/merges","archive_url":"https://api.github.com/repos/coreos/tectonic-installer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/tectonic-installer/downloads","issues_url":"https://api.github.com/repos/coreos/tectonic-installer/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/tectonic-installer/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/tectonic-installer/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/tectonic-installer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/tectonic-installer/labels{/name}","releases_url":"https://api.github.com/repos/coreos/tectonic-installer/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/tectonic-installer/deployments","created_at":"2017-02-11T00:52:23Z","updated_at":"2017-06-23T13:26:10Z","pushed_at":"2017-06-23T22:06:08Z","git_url":"git://github.com/coreos/tectonic-installer.git","ssh_url":"git@github.com:coreos/tectonic-installer.git","clone_url":"https://github.com/coreos/tectonic-installer.git","svn_url":"https://github.com/coreos/tectonic-installer","homepage":"","size":23814,"stargazers_count":189,"watchers_count":189,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":234,"forks":121,"open_issues":234,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1166"},"html":{"href":"https://github.com/coreos/tectonic-installer/pull/1166"},"issue":{"href":"https://api.github.com/repos/coreos/tectonic-installer/issues/1166"},"comments":{"href":"https://api.github.com/repos/coreos/tectonic-installer/issues/1166/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1166/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/tectonic-installer/pulls/1166/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/tectonic-installer/statuses/93d485d9eddafe1e70bacf39407d313ab4d6d684"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Quentin-M","id":1332289,"avatar_url":"https://avatars2.githubusercontent.com/u/1332289?v=3","gravatar_id":"","url":"https://api.github.com/users/Quentin-M","html_url":"https://github.com/Quentin-M","followers_url":"https://api.github.com/users/Quentin-M/followers","following_url":"https://api.github.com/users/Quentin-M/following{/other_user}","gists_url":"https://api.github.com/users/Quentin-M/gists{/gist_id}","starred_url":"https://api.github.com/users/Quentin-M/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quentin-M/subscriptions","organizations_url":"https://api.github.com/users/Quentin-M/orgs","repos_url":"https://api.github.com/users/Quentin-M/repos","events_url":"https://api.github.com/users/Quentin-M/events{/privacy}","received_events_url":"https://api.github.com/users/Quentin-M/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"Quentin-M"}}