{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/ferrall/finQED/pulls/4","id":158807012,"html_url":"https://github.com/ferrall/finQED/pull/4","diff_url":"https://github.com/ferrall/finQED/pull/4.diff","patch_url":"https://github.com/ferrall/finQED/pull/4.patch","issue_url":"https://api.github.com/repos/ferrall/finQED/issues/4","number":4,"state":"closed","locked":false,"title":"Correct the duration-modified function and add a bonds portfolio test in to bonds test.","user":{"login":"lusifeng","id":33636084,"avatar_url":"https://avatars1.githubusercontent.com/u/33636084?v=4","gravatar_id":"","url":"https://api.github.com/users/lusifeng","html_url":"https://github.com/lusifeng","followers_url":"https://api.github.com/users/lusifeng/followers","following_url":"https://api.github.com/users/lusifeng/following{/other_user}","gists_url":"https://api.github.com/users/lusifeng/gists{/gist_id}","starred_url":"https://api.github.com/users/lusifeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lusifeng/subscriptions","organizations_url":"https://api.github.com/users/lusifeng/orgs","repos_url":"https://api.github.com/users/lusifeng/repos","events_url":"https://api.github.com/users/lusifeng/events{/privacy}","received_events_url":"https://api.github.com/users/lusifeng/received_events","type":"User","site_admin":false},"body":"First of all, I found  the function that used to calculate duration-modified was not correct. The value of duration-modified is equal to duration dividend by 1+y instead of y.\r\n\r\nSecond, I add a test which is used to calculate how to build a portfolio in order to pay a specific return at the time of maturity despite of the changing in y(yield_to_maturity). The user can change the basic information of every bond and my test will calculate how much  should the\r\nuser buy from each bonds in order to reach his goal.\r\na.I write a new function that input the duration of bonds and portfolio ， then output the the ratio of each bonds.\r\nb.I changed the bonds test file, add a sub-menu for the two test.\r\nc.add the function to the head file.\r\nd.recompile finQED.ox , replace the old file. ","created_at":"2017-12-17T22:25:33Z","updated_at":"2017-12-20T16:16:50Z","closed_at":"2017-12-20T16:16:50Z","merged_at":"2017-12-20T16:16:50Z","merge_commit_sha":"256035f1eebf63c616e72f4b8b12f85dd0d26202","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ferrall/finQED/pulls/4/commits","review_comments_url":"https://api.github.com/repos/ferrall/finQED/pulls/4/comments","review_comment_url":"https://api.github.com/repos/ferrall/finQED/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ferrall/finQED/issues/4/comments","statuses_url":"https://api.github.com/repos/ferrall/finQED/statuses/256035f1eebf63c616e72f4b8b12f85dd0d26202","head":{"label":"lusifeng:development","ref":"development","sha":"256035f1eebf63c616e72f4b8b12f85dd0d26202","user":{"login":"lusifeng","id":33636084,"avatar_url":"https://avatars1.githubusercontent.com/u/33636084?v=4","gravatar_id":"","url":"https://api.github.com/users/lusifeng","html_url":"https://github.com/lusifeng","followers_url":"https://api.github.com/users/lusifeng/followers","following_url":"https://api.github.com/users/lusifeng/following{/other_user}","gists_url":"https://api.github.com/users/lusifeng/gists{/gist_id}","starred_url":"https://api.github.com/users/lusifeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lusifeng/subscriptions","organizations_url":"https://api.github.com/users/lusifeng/orgs","repos_url":"https://api.github.com/users/lusifeng/repos","events_url":"https://api.github.com/users/lusifeng/events{/privacy}","received_events_url":"https://api.github.com/users/lusifeng/received_events","type":"User","site_admin":false},"repo":{"id":111456231,"name":"finQED","full_name":"lusifeng/finQED","owner":{"login":"lusifeng","id":33636084,"avatar_url":"https://avatars1.githubusercontent.com/u/33636084?v=4","gravatar_id":"","url":"https://api.github.com/users/lusifeng","html_url":"https://github.com/lusifeng","followers_url":"https://api.github.com/users/lusifeng/followers","following_url":"https://api.github.com/users/lusifeng/following{/other_user}","gists_url":"https://api.github.com/users/lusifeng/gists{/gist_id}","starred_url":"https://api.github.com/users/lusifeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lusifeng/subscriptions","organizations_url":"https://api.github.com/users/lusifeng/orgs","repos_url":"https://api.github.com/users/lusifeng/repos","events_url":"https://api.github.com/users/lusifeng/events{/privacy}","received_events_url":"https://api.github.com/users/lusifeng/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lusifeng/finQED","description":"Econ354 Project to Update & Expand Financial Numerical Recipes in Ox written by Bernt Arne Ødegaard","fork":true,"url":"https://api.github.com/repos/lusifeng/finQED","forks_url":"https://api.github.com/repos/lusifeng/finQED/forks","keys_url":"https://api.github.com/repos/lusifeng/finQED/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lusifeng/finQED/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lusifeng/finQED/teams","hooks_url":"https://api.github.com/repos/lusifeng/finQED/hooks","issue_events_url":"https://api.github.com/repos/lusifeng/finQED/issues/events{/number}","events_url":"https://api.github.com/repos/lusifeng/finQED/events","assignees_url":"https://api.github.com/repos/lusifeng/finQED/assignees{/user}","branches_url":"https://api.github.com/repos/lusifeng/finQED/branches{/branch}","tags_url":"https://api.github.com/repos/lusifeng/finQED/tags","blobs_url":"https://api.github.com/repos/lusifeng/finQED/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lusifeng/finQED/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lusifeng/finQED/git/refs{/sha}","trees_url":"https://api.github.com/repos/lusifeng/finQED/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lusifeng/finQED/statuses/{sha}","languages_url":"https://api.github.com/repos/lusifeng/finQED/languages","stargazers_url":"https://api.github.com/repos/lusifeng/finQED/stargazers","contributors_url":"https://api.github.com/repos/lusifeng/finQED/contributors","subscribers_url":"https://api.github.com/repos/lusifeng/finQED/subscribers","subscription_url":"https://api.github.com/repos/lusifeng/finQED/subscription","commits_url":"https://api.github.com/repos/lusifeng/finQED/commits{/sha}","git_commits_url":"https://api.github.com/repos/lusifeng/finQED/git/commits{/sha}","comments_url":"https://api.github.com/repos/lusifeng/finQED/comments{/number}","issue_comment_url":"https://api.github.com/repos/lusifeng/finQED/issues/comments{/number}","contents_url":"https://api.github.com/repos/lusifeng/finQED/contents/{+path}","compare_url":"https://api.github.com/repos/lusifeng/finQED/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lusifeng/finQED/merges","archive_url":"https://api.github.com/repos/lusifeng/finQED/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lusifeng/finQED/downloads","issues_url":"https://api.github.com/repos/lusifeng/finQED/issues{/number}","pulls_url":"https://api.github.com/repos/lusifeng/finQED/pulls{/number}","milestones_url":"https://api.github.com/repos/lusifeng/finQED/milestones{/number}","notifications_url":"https://api.github.com/repos/lusifeng/finQED/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lusifeng/finQED/labels{/name}","releases_url":"https://api.github.com/repos/lusifeng/finQED/releases{/id}","deployments_url":"https://api.github.com/repos/lusifeng/finQED/deployments","created_at":"2017-11-20T19:54:42Z","updated_at":"2017-11-20T19:54:44Z","pushed_at":"2017-12-17T20:05:18Z","git_url":"git://github.com/lusifeng/finQED.git","ssh_url":"git@github.com:lusifeng/finQED.git","clone_url":"https://github.com/lusifeng/finQED.git","svn_url":"https://github.com/lusifeng/finQED","homepage":"","size":126,"stargazers_count":0,"watchers_count":0,"language":"Ox","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ferrall:development","ref":"development","sha":"582c2cca67db65bea911a8e32501b7f47042bfee","user":{"login":"ferrall","id":7659684,"avatar_url":"https://avatars0.githubusercontent.com/u/7659684?v=4","gravatar_id":"","url":"https://api.github.com/users/ferrall","html_url":"https://github.com/ferrall","followers_url":"https://api.github.com/users/ferrall/followers","following_url":"https://api.github.com/users/ferrall/following{/other_user}","gists_url":"https://api.github.com/users/ferrall/gists{/gist_id}","starred_url":"https://api.github.com/users/ferrall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferrall/subscriptions","organizations_url":"https://api.github.com/users/ferrall/orgs","repos_url":"https://api.github.com/users/ferrall/repos","events_url":"https://api.github.com/users/ferrall/events{/privacy}","received_events_url":"https://api.github.com/users/ferrall/received_events","type":"User","site_admin":false},"repo":{"id":109850391,"name":"finQED","full_name":"ferrall/finQED","owner":{"login":"ferrall","id":7659684,"avatar_url":"https://avatars0.githubusercontent.com/u/7659684?v=4","gravatar_id":"","url":"https://api.github.com/users/ferrall","html_url":"https://github.com/ferrall","followers_url":"https://api.github.com/users/ferrall/followers","following_url":"https://api.github.com/users/ferrall/following{/other_user}","gists_url":"https://api.github.com/users/ferrall/gists{/gist_id}","starred_url":"https://api.github.com/users/ferrall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferrall/subscriptions","organizations_url":"https://api.github.com/users/ferrall/orgs","repos_url":"https://api.github.com/users/ferrall/repos","events_url":"https://api.github.com/users/ferrall/events{/privacy}","received_events_url":"https://api.github.com/users/ferrall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferrall/finQED","description":"Econ354 Project to Update & Expand Financial Numerical Recipes in Ox written by Bernt Arne Ødegaard","fork":false,"url":"https://api.github.com/repos/ferrall/finQED","forks_url":"https://api.github.com/repos/ferrall/finQED/forks","keys_url":"https://api.github.com/repos/ferrall/finQED/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferrall/finQED/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferrall/finQED/teams","hooks_url":"https://api.github.com/repos/ferrall/finQED/hooks","issue_events_url":"https://api.github.com/repos/ferrall/finQED/issues/events{/number}","events_url":"https://api.github.com/repos/ferrall/finQED/events","assignees_url":"https://api.github.com/repos/ferrall/finQED/assignees{/user}","branches_url":"https://api.github.com/repos/ferrall/finQED/branches{/branch}","tags_url":"https://api.github.com/repos/ferrall/finQED/tags","blobs_url":"https://api.github.com/repos/ferrall/finQED/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferrall/finQED/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferrall/finQED/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferrall/finQED/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferrall/finQED/statuses/{sha}","languages_url":"https://api.github.com/repos/ferrall/finQED/languages","stargazers_url":"https://api.github.com/repos/ferrall/finQED/stargazers","contributors_url":"https://api.github.com/repos/ferrall/finQED/contributors","subscribers_url":"https://api.github.com/repos/ferrall/finQED/subscribers","subscription_url":"https://api.github.com/repos/ferrall/finQED/subscription","commits_url":"https://api.github.com/repos/ferrall/finQED/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferrall/finQED/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferrall/finQED/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferrall/finQED/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferrall/finQED/contents/{+path}","compare_url":"https://api.github.com/repos/ferrall/finQED/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferrall/finQED/merges","archive_url":"https://api.github.com/repos/ferrall/finQED/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferrall/finQED/downloads","issues_url":"https://api.github.com/repos/ferrall/finQED/issues{/number}","pulls_url":"https://api.github.com/repos/ferrall/finQED/pulls{/number}","milestones_url":"https://api.github.com/repos/ferrall/finQED/milestones{/number}","notifications_url":"https://api.github.com/repos/ferrall/finQED/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferrall/finQED/labels{/name}","releases_url":"https://api.github.com/repos/ferrall/finQED/releases{/id}","deployments_url":"https://api.github.com/repos/ferrall/finQED/deployments","created_at":"2017-11-07T15:00:16Z","updated_at":"2017-11-07T16:17:49Z","pushed_at":"2017-12-20T16:16:50Z","git_url":"git://github.com/ferrall/finQED.git","ssh_url":"git@github.com:ferrall/finQED.git","clone_url":"https://github.com/ferrall/finQED.git","svn_url":"https://github.com/ferrall/finQED","homepage":"","size":265,"stargazers_count":0,"watchers_count":0,"language":"Ox","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":9,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ferrall/finQED/pulls/4"},"html":{"href":"https://github.com/ferrall/finQED/pull/4"},"issue":{"href":"https://api.github.com/repos/ferrall/finQED/issues/4"},"comments":{"href":"https://api.github.com/repos/ferrall/finQED/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/ferrall/finQED/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/ferrall/finQED/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ferrall/finQED/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/ferrall/finQED/statuses/256035f1eebf63c616e72f4b8b12f85dd0d26202"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ferrall","id":7659684,"avatar_url":"https://avatars0.githubusercontent.com/u/7659684?v=4","gravatar_id":"","url":"https://api.github.com/users/ferrall","html_url":"https://github.com/ferrall","followers_url":"https://api.github.com/users/ferrall/followers","following_url":"https://api.github.com/users/ferrall/following{/other_user}","gists_url":"https://api.github.com/users/ferrall/gists{/gist_id}","starred_url":"https://api.github.com/users/ferrall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferrall/subscriptions","organizations_url":"https://api.github.com/users/ferrall/orgs","repos_url":"https://api.github.com/users/ferrall/repos","events_url":"https://api.github.com/users/ferrall/events{/privacy}","received_events_url":"https://api.github.com/users/ferrall/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":56,"deletions":4,"changed_files":9}}
{"actor":{"display_login":"ferrall"}}