{"action":"created","comment":{"url":"https://api.github.com/repos/Vizzuality/i2i/pulls/comments/110104153","pull_request_review_id":31250405,"id":110104153,"diff_hunk":"@@ -24,6 +24,11 @@\n         showTitle: false,\n         // Title of the modal – mandatory for accessibility\n         title: 'Untitled modal',\n+        // Allows the modal container have scroll\n+        allowScroll: false,","path":"app/assets/javascripts/components/shared/modal.js","position":5,"original_position":5,"commit_id":"a7083a30aabcf08e7910c58f0284cfb23a3c9832","original_commit_id":"a7083a30aabcf08e7910c58f0284cfb23a3c9832","user":{"login":"clementprdhomme","id":6073968,"avatar_url":"https://avatars2.githubusercontent.com/u/6073968?v=3","gravatar_id":"","url":"https://api.github.com/users/clementprdhomme","html_url":"https://github.com/clementprdhomme","followers_url":"https://api.github.com/users/clementprdhomme/followers","following_url":"https://api.github.com/users/clementprdhomme/following{/other_user}","gists_url":"https://api.github.com/users/clementprdhomme/gists{/gist_id}","starred_url":"https://api.github.com/users/clementprdhomme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clementprdhomme/subscriptions","organizations_url":"https://api.github.com/users/clementprdhomme/orgs","repos_url":"https://api.github.com/users/clementprdhomme/repos","events_url":"https://api.github.com/users/clementprdhomme/events{/privacy}","received_events_url":"https://api.github.com/users/clementprdhomme/received_events","type":"User","site_admin":false},"body":"By default, the scroll is always available so there's no reason to \"allow\" it. It already is.\r\n\r\nAlso, the rest of the modals didn't have any issue. We're just letting the user scrolls if they want. Moreover, disabling the scroll as you're doing makes mobile devices scroll to top, so it's more an inconvenient than a solution.","created_at":"2017-04-06T08:25:31Z","updated_at":"2017-04-06T08:25:32Z","html_url":"https://github.com/Vizzuality/i2i/pull/94#discussion_r110104153","pull_request_url":"https://api.github.com/repos/Vizzuality/i2i/pulls/94","_links":{"self":{"href":"https://api.github.com/repos/Vizzuality/i2i/pulls/comments/110104153"},"html":{"href":"https://github.com/Vizzuality/i2i/pull/94#discussion_r110104153"},"pull_request":{"href":"https://api.github.com/repos/Vizzuality/i2i/pulls/94"}}},"pull_request":{"url":"https://api.github.com/repos/Vizzuality/i2i/pulls/94","id":113981144,"html_url":"https://github.com/Vizzuality/i2i/pull/94","diff_url":"https://github.com/Vizzuality/i2i/pull/94.diff","patch_url":"https://github.com/Vizzuality/i2i/pull/94.patch","issue_url":"https://api.github.com/repos/Vizzuality/i2i/issues/94","number":94,"state":"open","locked":false,"title":"Save widget","user":{"login":"andresgnlez","id":999124,"avatar_url":"https://avatars1.githubusercontent.com/u/999124?v=3","gravatar_id":"","url":"https://api.github.com/users/andresgnlez","html_url":"https://github.com/andresgnlez","followers_url":"https://api.github.com/users/andresgnlez/followers","following_url":"https://api.github.com/users/andresgnlez/following{/other_user}","gists_url":"https://api.github.com/users/andresgnlez/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgnlez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgnlez/subscriptions","organizations_url":"https://api.github.com/users/andresgnlez/orgs","repos_url":"https://api.github.com/users/andresgnlez/repos","events_url":"https://api.github.com/users/andresgnlez/events{/privacy}","received_events_url":"https://api.github.com/users/andresgnlez/received_events","type":"User","site_admin":false},"body":"Pivotal task: https://www.pivotaltracker.com/story/show/141225215\r\n\r\nModal buttons distribution are pending on design (https://www.pivotaltracker.com/story/show/143021909)\r\n\r\nNOTES:\r\n\r\n- `print` function depends on the embed widget (the plan is to take a screenshot of this)\r\n- `download` function will be developed later because of complexity.\r\n-  Inside `share`, we will need to provide a real URL for share the widget and embed one.\r\n\r\nThese points are writte down in Pivotal: https://www.pivotaltracker.com/story/show/143164293","created_at":"2017-04-03T17:24:09Z","updated_at":"2017-04-06T08:25:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5150d6e2c639e2071178392782bf75b499f238fb","assignee":{"login":"clementprdhomme","id":6073968,"avatar_url":"https://avatars2.githubusercontent.com/u/6073968?v=3","gravatar_id":"","url":"https://api.github.com/users/clementprdhomme","html_url":"https://github.com/clementprdhomme","followers_url":"https://api.github.com/users/clementprdhomme/followers","following_url":"https://api.github.com/users/clementprdhomme/following{/other_user}","gists_url":"https://api.github.com/users/clementprdhomme/gists{/gist_id}","starred_url":"https://api.github.com/users/clementprdhomme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clementprdhomme/subscriptions","organizations_url":"https://api.github.com/users/clementprdhomme/orgs","repos_url":"https://api.github.com/users/clementprdhomme/repos","events_url":"https://api.github.com/users/clementprdhomme/events{/privacy}","received_events_url":"https://api.github.com/users/clementprdhomme/received_events","type":"User","site_admin":false},"assignees":[{"login":"clementprdhomme","id":6073968,"avatar_url":"https://avatars2.githubusercontent.com/u/6073968?v=3","gravatar_id":"","url":"https://api.github.com/users/clementprdhomme","html_url":"https://github.com/clementprdhomme","followers_url":"https://api.github.com/users/clementprdhomme/followers","following_url":"https://api.github.com/users/clementprdhomme/following{/other_user}","gists_url":"https://api.github.com/users/clementprdhomme/gists{/gist_id}","starred_url":"https://api.github.com/users/clementprdhomme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clementprdhomme/subscriptions","organizations_url":"https://api.github.com/users/clementprdhomme/orgs","repos_url":"https://api.github.com/users/clementprdhomme/repos","events_url":"https://api.github.com/users/clementprdhomme/events{/privacy}","received_events_url":"https://api.github.com/users/clementprdhomme/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Vizzuality/i2i/pulls/94/commits","review_comments_url":"https://api.github.com/repos/Vizzuality/i2i/pulls/94/comments","review_comment_url":"https://api.github.com/repos/Vizzuality/i2i/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vizzuality/i2i/issues/94/comments","statuses_url":"https://api.github.com/repos/Vizzuality/i2i/statuses/a7083a30aabcf08e7910c58f0284cfb23a3c9832","head":{"label":"Vizzuality:feature/save-widget","ref":"feature/save-widget","sha":"a7083a30aabcf08e7910c58f0284cfb23a3c9832","user":{"login":"Vizzuality","id":305994,"avatar_url":"https://avatars0.githubusercontent.com/u/305994?v=3","gravatar_id":"","url":"https://api.github.com/users/Vizzuality","html_url":"https://github.com/Vizzuality","followers_url":"https://api.github.com/users/Vizzuality/followers","following_url":"https://api.github.com/users/Vizzuality/following{/other_user}","gists_url":"https://api.github.com/users/Vizzuality/gists{/gist_id}","starred_url":"https://api.github.com/users/Vizzuality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vizzuality/subscriptions","organizations_url":"https://api.github.com/users/Vizzuality/orgs","repos_url":"https://api.github.com/users/Vizzuality/repos","events_url":"https://api.github.com/users/Vizzuality/events{/privacy}","received_events_url":"https://api.github.com/users/Vizzuality/received_events","type":"Organization","site_admin":false},"repo":{"id":79551113,"name":"i2i","full_name":"Vizzuality/i2i","owner":{"login":"Vizzuality","id":305994,"avatar_url":"https://avatars0.githubusercontent.com/u/305994?v=3","gravatar_id":"","url":"https://api.github.com/users/Vizzuality","html_url":"https://github.com/Vizzuality","followers_url":"https://api.github.com/users/Vizzuality/followers","following_url":"https://api.github.com/users/Vizzuality/following{/other_user}","gists_url":"https://api.github.com/users/Vizzuality/gists{/gist_id}","starred_url":"https://api.github.com/users/Vizzuality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vizzuality/subscriptions","organizations_url":"https://api.github.com/users/Vizzuality/orgs","repos_url":"https://api.github.com/users/Vizzuality/repos","events_url":"https://api.github.com/users/Vizzuality/events{/privacy}","received_events_url":"https://api.github.com/users/Vizzuality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vizzuality/i2i","description":"Insight 2 Impact","fork":false,"url":"https://api.github.com/repos/Vizzuality/i2i","forks_url":"https://api.github.com/repos/Vizzuality/i2i/forks","keys_url":"https://api.github.com/repos/Vizzuality/i2i/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vizzuality/i2i/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vizzuality/i2i/teams","hooks_url":"https://api.github.com/repos/Vizzuality/i2i/hooks","issue_events_url":"https://api.github.com/repos/Vizzuality/i2i/issues/events{/number}","events_url":"https://api.github.com/repos/Vizzuality/i2i/events","assignees_url":"https://api.github.com/repos/Vizzuality/i2i/assignees{/user}","branches_url":"https://api.github.com/repos/Vizzuality/i2i/branches{/branch}","tags_url":"https://api.github.com/repos/Vizzuality/i2i/tags","blobs_url":"https://api.github.com/repos/Vizzuality/i2i/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vizzuality/i2i/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vizzuality/i2i/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vizzuality/i2i/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vizzuality/i2i/statuses/{sha}","languages_url":"https://api.github.com/repos/Vizzuality/i2i/languages","stargazers_url":"https://api.github.com/repos/Vizzuality/i2i/stargazers","contributors_url":"https://api.github.com/repos/Vizzuality/i2i/contributors","subscribers_url":"https://api.github.com/repos/Vizzuality/i2i/subscribers","subscription_url":"https://api.github.com/repos/Vizzuality/i2i/subscription","commits_url":"https://api.github.com/repos/Vizzuality/i2i/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vizzuality/i2i/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vizzuality/i2i/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vizzuality/i2i/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vizzuality/i2i/contents/{+path}","compare_url":"https://api.github.com/repos/Vizzuality/i2i/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vizzuality/i2i/merges","archive_url":"https://api.github.com/repos/Vizzuality/i2i/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vizzuality/i2i/downloads","issues_url":"https://api.github.com/repos/Vizzuality/i2i/issues{/number}","pulls_url":"https://api.github.com/repos/Vizzuality/i2i/pulls{/number}","milestones_url":"https://api.github.com/repos/Vizzuality/i2i/milestones{/number}","notifications_url":"https://api.github.com/repos/Vizzuality/i2i/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vizzuality/i2i/labels{/name}","releases_url":"https://api.github.com/repos/Vizzuality/i2i/releases{/id}","deployments_url":"https://api.github.com/repos/Vizzuality/i2i/deployments","created_at":"2017-01-20T10:49:30Z","updated_at":"2017-03-27T15:20:48Z","pushed_at":"2017-04-05T21:51:26Z","git_url":"git://github.com/Vizzuality/i2i.git","ssh_url":"git@github.com:Vizzuality/i2i.git","clone_url":"https://github.com/Vizzuality/i2i.git","svn_url":"https://github.com/Vizzuality/i2i","homepage":null,"size":10410,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"Vizzuality:develop","ref":"develop","sha":"b2bfdb53ee7b103444f31a13eacbb2af1f408199","user":{"login":"Vizzuality","id":305994,"avatar_url":"https://avatars0.githubusercontent.com/u/305994?v=3","gravatar_id":"","url":"https://api.github.com/users/Vizzuality","html_url":"https://github.com/Vizzuality","followers_url":"https://api.github.com/users/Vizzuality/followers","following_url":"https://api.github.com/users/Vizzuality/following{/other_user}","gists_url":"https://api.github.com/users/Vizzuality/gists{/gist_id}","starred_url":"https://api.github.com/users/Vizzuality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vizzuality/subscriptions","organizations_url":"https://api.github.com/users/Vizzuality/orgs","repos_url":"https://api.github.com/users/Vizzuality/repos","events_url":"https://api.github.com/users/Vizzuality/events{/privacy}","received_events_url":"https://api.github.com/users/Vizzuality/received_events","type":"Organization","site_admin":false},"repo":{"id":79551113,"name":"i2i","full_name":"Vizzuality/i2i","owner":{"login":"Vizzuality","id":305994,"avatar_url":"https://avatars0.githubusercontent.com/u/305994?v=3","gravatar_id":"","url":"https://api.github.com/users/Vizzuality","html_url":"https://github.com/Vizzuality","followers_url":"https://api.github.com/users/Vizzuality/followers","following_url":"https://api.github.com/users/Vizzuality/following{/other_user}","gists_url":"https://api.github.com/users/Vizzuality/gists{/gist_id}","starred_url":"https://api.github.com/users/Vizzuality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vizzuality/subscriptions","organizations_url":"https://api.github.com/users/Vizzuality/orgs","repos_url":"https://api.github.com/users/Vizzuality/repos","events_url":"https://api.github.com/users/Vizzuality/events{/privacy}","received_events_url":"https://api.github.com/users/Vizzuality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Vizzuality/i2i","description":"Insight 2 Impact","fork":false,"url":"https://api.github.com/repos/Vizzuality/i2i","forks_url":"https://api.github.com/repos/Vizzuality/i2i/forks","keys_url":"https://api.github.com/repos/Vizzuality/i2i/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vizzuality/i2i/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vizzuality/i2i/teams","hooks_url":"https://api.github.com/repos/Vizzuality/i2i/hooks","issue_events_url":"https://api.github.com/repos/Vizzuality/i2i/issues/events{/number}","events_url":"https://api.github.com/repos/Vizzuality/i2i/events","assignees_url":"https://api.github.com/repos/Vizzuality/i2i/assignees{/user}","branches_url":"https://api.github.com/repos/Vizzuality/i2i/branches{/branch}","tags_url":"https://api.github.com/repos/Vizzuality/i2i/tags","blobs_url":"https://api.github.com/repos/Vizzuality/i2i/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vizzuality/i2i/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vizzuality/i2i/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vizzuality/i2i/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vizzuality/i2i/statuses/{sha}","languages_url":"https://api.github.com/repos/Vizzuality/i2i/languages","stargazers_url":"https://api.github.com/repos/Vizzuality/i2i/stargazers","contributors_url":"https://api.github.com/repos/Vizzuality/i2i/contributors","subscribers_url":"https://api.github.com/repos/Vizzuality/i2i/subscribers","subscription_url":"https://api.github.com/repos/Vizzuality/i2i/subscription","commits_url":"https://api.github.com/repos/Vizzuality/i2i/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vizzuality/i2i/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vizzuality/i2i/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vizzuality/i2i/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vizzuality/i2i/contents/{+path}","compare_url":"https://api.github.com/repos/Vizzuality/i2i/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vizzuality/i2i/merges","archive_url":"https://api.github.com/repos/Vizzuality/i2i/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vizzuality/i2i/downloads","issues_url":"https://api.github.com/repos/Vizzuality/i2i/issues{/number}","pulls_url":"https://api.github.com/repos/Vizzuality/i2i/pulls{/number}","milestones_url":"https://api.github.com/repos/Vizzuality/i2i/milestones{/number}","notifications_url":"https://api.github.com/repos/Vizzuality/i2i/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vizzuality/i2i/labels{/name}","releases_url":"https://api.github.com/repos/Vizzuality/i2i/releases{/id}","deployments_url":"https://api.github.com/repos/Vizzuality/i2i/deployments","created_at":"2017-01-20T10:49:30Z","updated_at":"2017-03-27T15:20:48Z","pushed_at":"2017-04-05T21:51:26Z","git_url":"git://github.com/Vizzuality/i2i.git","ssh_url":"git@github.com:Vizzuality/i2i.git","clone_url":"https://github.com/Vizzuality/i2i.git","svn_url":"https://github.com/Vizzuality/i2i","homepage":null,"size":10410,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Vizzuality/i2i/pulls/94"},"html":{"href":"https://github.com/Vizzuality/i2i/pull/94"},"issue":{"href":"https://api.github.com/repos/Vizzuality/i2i/issues/94"},"comments":{"href":"https://api.github.com/repos/Vizzuality/i2i/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/Vizzuality/i2i/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/Vizzuality/i2i/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vizzuality/i2i/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/Vizzuality/i2i/statuses/a7083a30aabcf08e7910c58f0284cfb23a3c9832"}}}}
{"actor":{"display_login":"clementprdhomme"}}