{"action":"created","issue":{"url":"https://api.github.com/repos/gramps-project/gramps/issues/384","repository_url":"https://api.github.com/repos/gramps-project/gramps","labels_url":"https://api.github.com/repos/gramps-project/gramps/issues/384/labels{/name}","comments_url":"https://api.github.com/repos/gramps-project/gramps/issues/384/comments","events_url":"https://api.github.com/repos/gramps-project/gramps/issues/384/events","html_url":"https://github.com/gramps-project/gramps/pull/384","id":226028567,"number":384,"title":"Bug 9738; Fix People selector for speed; option of Tree or List view","user":{"login":"prculley","id":18122203,"avatar_url":"https://avatars1.githubusercontent.com/u/18122203?v=3","gravatar_id":"","url":"https://api.github.com/users/prculley","html_url":"https://github.com/prculley","followers_url":"https://api.github.com/users/prculley/followers","following_url":"https://api.github.com/users/prculley/following{/other_user}","gists_url":"https://api.github.com/users/prculley/gists{/gist_id}","starred_url":"https://api.github.com/users/prculley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prculley/subscriptions","organizations_url":"https://api.github.com/users/prculley/orgs","repos_url":"https://api.github.com/users/prculley/repos","events_url":"https://api.github.com/users/prculley/events{/privacy}","received_events_url":"https://api.github.com/users/prculley/received_events","type":"User","site_admin":false},"labels":[{"id":163706671,"url":"https://api.github.com/repos/gramps-project/gramps/labels/bug","name":"bug","color":"fc2929","default":true},{"id":163706673,"url":"https://api.github.com/repos/gramps-project/gramps/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-05-03T15:38:55Z","updated_at":"2017-05-09T20:39:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gramps-project/gramps/pulls/384","html_url":"https://github.com/gramps-project/gramps/pull/384","diff_url":"https://github.com/gramps-project/gramps/pull/384.diff","patch_url":"https://github.com/gramps-project/gramps/pull/384.patch"},"body":"This PR is another potential fix for https://gramps-project.org/bugs/view.php?id=9738 and https://gramps-project.org/bugs/view.php?id=9880 (https://github.com/gramps-project/gramps/pull/337 also tries to fix this another way, but it is not complete and the author is not responding).  See also the email thread on this topic at http://gramps.1791082.n4.nabble.com/Unable-to-collapse-places-and-people-td4679691.html\r\n\r\nPrior to v4.2.4 Person selector (used to select person for family or relationship view etc.) brought up the dialog with a collapsed tree mode.\r\nbug8785 was submitted requesting that selectors were opened with a fully expanded tree view, this was implemented for v4.2.4.  Since that time another patch changed the behavior for place selectors, this PR should not effect this.\r\n\r\nSince that time it has become evident that with large trees that the fully expanded tree view has (rather severe) performance problems with large trees.\r\n\r\nThis PR adds an edit/preference option on the 'Display' tab\r\n   'When choosing from existing people, use List view (Tree view if off)' default off.\r\nIt also has a tooltip 'Tree view with large trees will slow down the dialog.'\r\nIt also reverts the baseselector to the previous (before 4.2.4) state of collapsed tree as the default.\r\nI added back the code removed in https://github.com/gramps-project/gramps/commit/10629b16b8c3945efb68cd763691b2bef4088180 which allowed a tree to expand on a specific person, although I was unable to find anywhere that used this feature.  Perhaps it was used in an addon.\r\n\r\nI like the List view instead of expanded Tree; on my machine with 16000 persons, List view opened in 0.9 sec, the collapsed tree opened in 2.7 sec, the current code expanded tree took 8.5 sec.\r\n\r\nIf a user never changes the preference, he gets the behavior like before 4.2.4.  If he does change the new preference, his person selectors open in list view, which, in my opinion, are faster, and use less screen real estate than the expanded tree view.\r\n\r\nIf this is accepted, I will prepare a similar patch for the 4.2 branch..."},"comment":{"url":"https://api.github.com/repos/gramps-project/gramps/issues/comments/300294359","html_url":"https://github.com/gramps-project/gramps/pull/384#issuecomment-300294359","issue_url":"https://api.github.com/repos/gramps-project/gramps/issues/384","id":300294359,"user":{"login":"Nick-Hall","id":9042510,"avatar_url":"https://avatars2.githubusercontent.com/u/9042510?v=3","gravatar_id":"","url":"https://api.github.com/users/Nick-Hall","html_url":"https://github.com/Nick-Hall","followers_url":"https://api.github.com/users/Nick-Hall/followers","following_url":"https://api.github.com/users/Nick-Hall/following{/other_user}","gists_url":"https://api.github.com/users/Nick-Hall/gists{/gist_id}","starred_url":"https://api.github.com/users/Nick-Hall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nick-Hall/subscriptions","organizations_url":"https://api.github.com/users/Nick-Hall/orgs","repos_url":"https://api.github.com/users/Nick-Hall/repos","events_url":"https://api.github.com/users/Nick-Hall/events{/privacy}","received_events_url":"https://api.github.com/users/Nick-Hall/received_events","type":"User","site_admin":false},"created_at":"2017-05-09T20:39:27Z","updated_at":"2017-05-09T20:39:27Z","body":"@Paul-Franklin This PR is more like a new feature.  I don't like it as a bug fix.  The original collapsed tree is probably what users with large databases want."}}
{"actor":{"display_login":"Nick-Hall"}}