{"action":"created","comment":{"url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls/comments/146099929","pull_request_review_id":71002118,"id":146099929,"diff_hunk":"@@ -50,11 +50,13 @@ private String encodeAccount(String account) {\n \n         char[] letters = account.toCharArray();\n         String result = \"\";\n-        for (char letter : letters)\n-            for (int i = 0; i < chars.length(); i++)\n+        for (char letter : letters) {","path":"src/main/java/nl/hsac/fitnesse/util/iban/FRIbanGenerator.java","position":null,"original_position":6,"commit_id":"94271353f2ba54dd4b355ac2d153f6201098102c","original_commit_id":"c61e0958321968faf5957fde04e791e08e26b5d8","user":{"login":"keetron","id":8872839,"avatar_url":"https://avatars2.githubusercontent.com/u/8872839?v=4","gravatar_id":"","url":"https://api.github.com/users/keetron","html_url":"https://github.com/keetron","followers_url":"https://api.github.com/users/keetron/followers","following_url":"https://api.github.com/users/keetron/following{/other_user}","gists_url":"https://api.github.com/users/keetron/gists{/gist_id}","starred_url":"https://api.github.com/users/keetron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keetron/subscriptions","organizations_url":"https://api.github.com/users/keetron/orgs","repos_url":"https://api.github.com/users/keetron/repos","events_url":"https://api.github.com/users/keetron/events{/privacy}","received_events_url":"https://api.github.com/users/keetron/received_events","type":"User","site_admin":false},"body":"The loop refactor was something intellij suggested and I blindly followed. Braces are indeed good for readability.","created_at":"2017-10-21T08:18:44Z","updated_at":"2017-10-21T08:22:10Z","html_url":"https://github.com/fhoeben/hsac-fitnesse-plugin/pull/24#discussion_r146099929","pull_request_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls/24","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls/comments/146099929"},"html":{"href":"https://github.com/fhoeben/hsac-fitnesse-plugin/pull/24#discussion_r146099929"},"pull_request":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls/24","id":147899332,"html_url":"https://github.com/fhoeben/hsac-fitnesse-plugin/pull/24","diff_url":"https://github.com/fhoeben/hsac-fitnesse-plugin/pull/24.diff","patch_url":"https://github.com/fhoeben/hsac-fitnesse-plugin/pull/24.patch","issue_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/issues/24","number":24,"state":"open","locked":false,"title":"French random IBAN improved","user":{"login":"fhoeben","id":5467859,"avatar_url":"https://avatars1.githubusercontent.com/u/5467859?v=4","gravatar_id":"","url":"https://api.github.com/users/fhoeben","html_url":"https://github.com/fhoeben","followers_url":"https://api.github.com/users/fhoeben/followers","following_url":"https://api.github.com/users/fhoeben/following{/other_user}","gists_url":"https://api.github.com/users/fhoeben/gists{/gist_id}","starred_url":"https://api.github.com/users/fhoeben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhoeben/subscriptions","organizations_url":"https://api.github.com/users/fhoeben/orgs","repos_url":"https://api.github.com/users/fhoeben/repos","events_url":"https://api.github.com/users/fhoeben/events{/privacy}","received_events_url":"https://api.github.com/users/fhoeben/received_events","type":"User","site_admin":false},"body":"To address #23 .\r\n\r\n@keetron what do you think of this approach?","created_at":"2017-10-20T21:29:02Z","updated_at":"2017-10-21T08:22:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84a3cd74921061f0c3efae0fe811157312ccc17f","assignee":{"login":"fhoeben","id":5467859,"avatar_url":"https://avatars1.githubusercontent.com/u/5467859?v=4","gravatar_id":"","url":"https://api.github.com/users/fhoeben","html_url":"https://github.com/fhoeben","followers_url":"https://api.github.com/users/fhoeben/followers","following_url":"https://api.github.com/users/fhoeben/following{/other_user}","gists_url":"https://api.github.com/users/fhoeben/gists{/gist_id}","starred_url":"https://api.github.com/users/fhoeben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhoeben/subscriptions","organizations_url":"https://api.github.com/users/fhoeben/orgs","repos_url":"https://api.github.com/users/fhoeben/repos","events_url":"https://api.github.com/users/fhoeben/events{/privacy}","received_events_url":"https://api.github.com/users/fhoeben/received_events","type":"User","site_admin":false},"assignees":[{"login":"fhoeben","id":5467859,"avatar_url":"https://avatars1.githubusercontent.com/u/5467859?v=4","gravatar_id":"","url":"https://api.github.com/users/fhoeben","html_url":"https://github.com/fhoeben","followers_url":"https://api.github.com/users/fhoeben/followers","following_url":"https://api.github.com/users/fhoeben/following{/other_user}","gists_url":"https://api.github.com/users/fhoeben/gists{/gist_id}","starred_url":"https://api.github.com/users/fhoeben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhoeben/subscriptions","organizations_url":"https://api.github.com/users/fhoeben/orgs","repos_url":"https://api.github.com/users/fhoeben/repos","events_url":"https://api.github.com/users/fhoeben/events{/privacy}","received_events_url":"https://api.github.com/users/fhoeben/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls/24/commits","review_comments_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls/24/comments","review_comment_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/issues/24/comments","statuses_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/statuses/94271353f2ba54dd4b355ac2d153f6201098102c","head":{"label":"fhoeben:fr-iban","ref":"fr-iban","sha":"94271353f2ba54dd4b355ac2d153f6201098102c","user":{"login":"fhoeben","id":5467859,"avatar_url":"https://avatars1.githubusercontent.com/u/5467859?v=4","gravatar_id":"","url":"https://api.github.com/users/fhoeben","html_url":"https://github.com/fhoeben","followers_url":"https://api.github.com/users/fhoeben/followers","following_url":"https://api.github.com/users/fhoeben/following{/other_user}","gists_url":"https://api.github.com/users/fhoeben/gists{/gist_id}","starred_url":"https://api.github.com/users/fhoeben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhoeben/subscriptions","organizations_url":"https://api.github.com/users/fhoeben/orgs","repos_url":"https://api.github.com/users/fhoeben/repos","events_url":"https://api.github.com/users/fhoeben/events{/privacy}","received_events_url":"https://api.github.com/users/fhoeben/received_events","type":"User","site_admin":false},"repo":{"id":19587182,"name":"hsac-fitnesse-plugin","full_name":"fhoeben/hsac-fitnesse-plugin","owner":{"login":"fhoeben","id":5467859,"avatar_url":"https://avatars1.githubusercontent.com/u/5467859?v=4","gravatar_id":"","url":"https://api.github.com/users/fhoeben","html_url":"https://github.com/fhoeben","followers_url":"https://api.github.com/users/fhoeben/followers","following_url":"https://api.github.com/users/fhoeben/following{/other_user}","gists_url":"https://api.github.com/users/fhoeben/gists{/gist_id}","starred_url":"https://api.github.com/users/fhoeben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhoeben/subscriptions","organizations_url":"https://api.github.com/users/fhoeben/orgs","repos_url":"https://api.github.com/users/fhoeben/repos","events_url":"https://api.github.com/users/fhoeben/events{/privacy}","received_events_url":"https://api.github.com/users/fhoeben/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fhoeben/hsac-fitnesse-plugin","description":"Plugin to add some additional features to a FitNesse wiki.","fork":false,"url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin","forks_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/forks","keys_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/teams","hooks_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/hooks","issue_events_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/events","assignees_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/tags","blobs_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/languages","stargazers_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/stargazers","contributors_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/contributors","subscribers_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/subscribers","subscription_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/subscription","commits_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/merges","archive_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/downloads","issues_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/labels{/name}","releases_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/deployments","created_at":"2014-05-08T20:06:20Z","updated_at":"2017-06-10T15:05:11Z","pushed_at":"2017-10-21T08:16:41Z","git_url":"git://github.com/fhoeben/hsac-fitnesse-plugin.git","ssh_url":"git@github.com:fhoeben/hsac-fitnesse-plugin.git","clone_url":"https://github.com/fhoeben/hsac-fitnesse-plugin.git","svn_url":"https://github.com/fhoeben/hsac-fitnesse-plugin","homepage":"","size":301,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":9,"default_branch":"master"}},"base":{"label":"fhoeben:master","ref":"master","sha":"1af55622a174538fd00d8bb9188ce27cef2e3b26","user":{"login":"fhoeben","id":5467859,"avatar_url":"https://avatars1.githubusercontent.com/u/5467859?v=4","gravatar_id":"","url":"https://api.github.com/users/fhoeben","html_url":"https://github.com/fhoeben","followers_url":"https://api.github.com/users/fhoeben/followers","following_url":"https://api.github.com/users/fhoeben/following{/other_user}","gists_url":"https://api.github.com/users/fhoeben/gists{/gist_id}","starred_url":"https://api.github.com/users/fhoeben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhoeben/subscriptions","organizations_url":"https://api.github.com/users/fhoeben/orgs","repos_url":"https://api.github.com/users/fhoeben/repos","events_url":"https://api.github.com/users/fhoeben/events{/privacy}","received_events_url":"https://api.github.com/users/fhoeben/received_events","type":"User","site_admin":false},"repo":{"id":19587182,"name":"hsac-fitnesse-plugin","full_name":"fhoeben/hsac-fitnesse-plugin","owner":{"login":"fhoeben","id":5467859,"avatar_url":"https://avatars1.githubusercontent.com/u/5467859?v=4","gravatar_id":"","url":"https://api.github.com/users/fhoeben","html_url":"https://github.com/fhoeben","followers_url":"https://api.github.com/users/fhoeben/followers","following_url":"https://api.github.com/users/fhoeben/following{/other_user}","gists_url":"https://api.github.com/users/fhoeben/gists{/gist_id}","starred_url":"https://api.github.com/users/fhoeben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhoeben/subscriptions","organizations_url":"https://api.github.com/users/fhoeben/orgs","repos_url":"https://api.github.com/users/fhoeben/repos","events_url":"https://api.github.com/users/fhoeben/events{/privacy}","received_events_url":"https://api.github.com/users/fhoeben/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fhoeben/hsac-fitnesse-plugin","description":"Plugin to add some additional features to a FitNesse wiki.","fork":false,"url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin","forks_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/forks","keys_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/teams","hooks_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/hooks","issue_events_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/events","assignees_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/tags","blobs_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/languages","stargazers_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/stargazers","contributors_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/contributors","subscribers_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/subscribers","subscription_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/subscription","commits_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/merges","archive_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/downloads","issues_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/labels{/name}","releases_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/deployments","created_at":"2014-05-08T20:06:20Z","updated_at":"2017-06-10T15:05:11Z","pushed_at":"2017-10-21T08:16:41Z","git_url":"git://github.com/fhoeben/hsac-fitnesse-plugin.git","ssh_url":"git@github.com:fhoeben/hsac-fitnesse-plugin.git","clone_url":"https://github.com/fhoeben/hsac-fitnesse-plugin.git","svn_url":"https://github.com/fhoeben/hsac-fitnesse-plugin","homepage":"","size":301,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":7,"open_issues":4,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls/24"},"html":{"href":"https://github.com/fhoeben/hsac-fitnesse-plugin/pull/24"},"issue":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/issues/24"},"comments":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/fhoeben/hsac-fitnesse-plugin/statuses/94271353f2ba54dd4b355ac2d153f6201098102c"}},"author_association":"OWNER"}}
{"actor":{"display_login":"keetron"}}