{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint/issues/5298","repository_url":"https://api.github.com/repos/eslint/eslint","labels_url":"https://api.github.com/repos/eslint/eslint/issues/5298/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/5298/comments","events_url":"https://api.github.com/repos/eslint/eslint/issues/5298/events","html_url":"https://github.com/eslint/eslint/issues/5298","id":133895892,"number":5298,"title":"Unexpected error when running commit checker.","user":{"login":"afahim","id":1330465,"avatar_url":"https://avatars3.githubusercontent.com/u/1330465?v=4","gravatar_id":"","url":"https://api.github.com/users/afahim","html_url":"https://github.com/afahim","followers_url":"https://api.github.com/users/afahim/followers","following_url":"https://api.github.com/users/afahim/following{/other_user}","gists_url":"https://api.github.com/users/afahim/gists{/gist_id}","starred_url":"https://api.github.com/users/afahim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afahim/subscriptions","organizations_url":"https://api.github.com/users/afahim/orgs","repos_url":"https://api.github.com/users/afahim/repos","events_url":"https://api.github.com/users/afahim/events{/privacy}","received_events_url":"https://api.github.com/users/afahim/received_events","type":"User","site_admin":false},"labels":[{"id":45711352,"url":"https://api.github.com/repos/eslint/eslint/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":255319420,"url":"https://api.github.com/repos/eslint/eslint/labels/evaluating","name":"evaluating","color":"fef2c0","default":false},{"id":72921852,"url":"https://api.github.com/repos/eslint/eslint/labels/infrastructure","name":"infrastructure","color":"666666","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2016-02-16T06:22:58Z","updated_at":"2017-09-06T16:13:39Z","closed_at":"2016-04-21T19:00:47Z","author_association":"CONTRIBUTOR","body":"**What version are you using?**\n\n2.1.0\n\n**What did you do?**\n\nAdded a commit, then checked out a new branch (for renaming purposes). Rebased from upstream. Ran `npm run check-commit`\n\n**What happened?**\n\nGot an error saying  `More than one commit found, please squash.`\n\n**What did you expect to happen?**\n\nSince I only added one commit, I didn't expect to see this message. My local master wasn't up to date. Reading the `checkGitCommit` function, I realized thats where the disparity was,. Solution was to delete my local master, so that this check ran instead\n\nhttps://github.com/eslint/eslint/blob/ec803b268ade7b9093ac127083ca69c2ad7a2b47/Makefile.js#L871\n\nI think this check assumes local master is up to date, which isn't always true imo (since one can rebase later, etc). Instead I think the check should run against `upstream/master`.\n"},"comment":{"url":"https://api.github.com/repos/eslint/eslint/issues/comments/327535077","html_url":"https://github.com/eslint/eslint/issues/5298#issuecomment-327535077","issue_url":"https://api.github.com/repos/eslint/eslint/issues/5298","id":327535077,"user":{"login":"not-an-aardvark","id":11638619,"avatar_url":"https://avatars2.githubusercontent.com/u/11638619?v=4","gravatar_id":"","url":"https://api.github.com/users/not-an-aardvark","html_url":"https://github.com/not-an-aardvark","followers_url":"https://api.github.com/users/not-an-aardvark/followers","following_url":"https://api.github.com/users/not-an-aardvark/following{/other_user}","gists_url":"https://api.github.com/users/not-an-aardvark/gists{/gist_id}","starred_url":"https://api.github.com/users/not-an-aardvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-an-aardvark/subscriptions","organizations_url":"https://api.github.com/users/not-an-aardvark/orgs","repos_url":"https://api.github.com/users/not-an-aardvark/repos","events_url":"https://api.github.com/users/not-an-aardvark/events{/privacy}","received_events_url":"https://api.github.com/users/not-an-aardvark/received_events","type":"User","site_admin":false},"created_at":"2017-09-06T16:13:39Z","updated_at":"2017-09-06T16:13:39Z","author_association":"OWNER","body":"We don't actually require commits to be squashed anymore, so maybe we should just remove that check."}}
{"actor":{"display_login":"not-an-aardvark"}}