{"action":"created","issue":{"url":"https://api.github.com/repos/intermine/intermine/issues/1649","repository_url":"https://api.github.com/repos/intermine/intermine","labels_url":"https://api.github.com/repos/intermine/intermine/issues/1649/labels{/name}","comments_url":"https://api.github.com/repos/intermine/intermine/issues/1649/comments","events_url":"https://api.github.com/repos/intermine/intermine/issues/1649/events","html_url":"https://github.com/intermine/intermine/pull/1649","id":247935463,"number":1649,"title":"cache the list of valid global templates","user":{"login":"julie-sullivan","id":1663057,"avatar_url":"https://avatars2.githubusercontent.com/u/1663057?v=4","gravatar_id":"","url":"https://api.github.com/users/julie-sullivan","html_url":"https://github.com/julie-sullivan","followers_url":"https://api.github.com/users/julie-sullivan/followers","following_url":"https://api.github.com/users/julie-sullivan/following{/other_user}","gists_url":"https://api.github.com/users/julie-sullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/julie-sullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julie-sullivan/subscriptions","organizations_url":"https://api.github.com/users/julie-sullivan/orgs","repos_url":"https://api.github.com/users/julie-sullivan/repos","events_url":"https://api.github.com/users/julie-sullivan/events{/privacy}","received_events_url":"https://api.github.com/users/julie-sullivan/received_events","type":"User","site_admin":false},"labels":[{"id":8223558,"url":"https://api.github.com/repos/intermine/intermine/labels/bug","name":"bug","color":"fc2929","default":true},{"id":17258115,"url":"https://api.github.com/repos/intermine/intermine/labels/please-test","name":"please-test","color":"0b02e1","default":false}],"state":"open","locked":false,"assignee":{"login":"julie-sullivan","id":1663057,"avatar_url":"https://avatars2.githubusercontent.com/u/1663057?v=4","gravatar_id":"","url":"https://api.github.com/users/julie-sullivan","html_url":"https://github.com/julie-sullivan","followers_url":"https://api.github.com/users/julie-sullivan/followers","following_url":"https://api.github.com/users/julie-sullivan/following{/other_user}","gists_url":"https://api.github.com/users/julie-sullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/julie-sullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julie-sullivan/subscriptions","organizations_url":"https://api.github.com/users/julie-sullivan/orgs","repos_url":"https://api.github.com/users/julie-sullivan/repos","events_url":"https://api.github.com/users/julie-sullivan/events{/privacy}","received_events_url":"https://api.github.com/users/julie-sullivan/received_events","type":"User","site_admin":false},"assignees":[{"login":"julie-sullivan","id":1663057,"avatar_url":"https://avatars2.githubusercontent.com/u/1663057?v=4","gravatar_id":"","url":"https://api.github.com/users/julie-sullivan","html_url":"https://github.com/julie-sullivan","followers_url":"https://api.github.com/users/julie-sullivan/followers","following_url":"https://api.github.com/users/julie-sullivan/following{/other_user}","gists_url":"https://api.github.com/users/julie-sullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/julie-sullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julie-sullivan/subscriptions","organizations_url":"https://api.github.com/users/julie-sullivan/orgs","repos_url":"https://api.github.com/users/julie-sullivan/repos","events_url":"https://api.github.com/users/julie-sullivan/events{/privacy}","received_events_url":"https://api.github.com/users/julie-sullivan/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/intermine/intermine/milestones/39","html_url":"https://github.com/intermine/intermine/milestone/39","labels_url":"https://api.github.com/repos/intermine/intermine/milestones/39/labels","id":2649394,"number":39,"title":"InterMine 1.8.4","description":"Web services needed by Blue Genes.","creator":{"login":"julie-sullivan","id":1663057,"avatar_url":"https://avatars2.githubusercontent.com/u/1663057?v=4","gravatar_id":"","url":"https://api.github.com/users/julie-sullivan","html_url":"https://github.com/julie-sullivan","followers_url":"https://api.github.com/users/julie-sullivan/followers","following_url":"https://api.github.com/users/julie-sullivan/following{/other_user}","gists_url":"https://api.github.com/users/julie-sullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/julie-sullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julie-sullivan/subscriptions","organizations_url":"https://api.github.com/users/julie-sullivan/orgs","repos_url":"https://api.github.com/users/julie-sullivan/repos","events_url":"https://api.github.com/users/julie-sullivan/events{/privacy}","received_events_url":"https://api.github.com/users/julie-sullivan/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":23,"state":"open","created_at":"2017-07-19T08:52:46Z","updated_at":"2017-08-08T15:24:28Z","due_on":"2017-08-14T07:00:00Z","closed_at":null},"comments":11,"created_at":"2017-08-04T08:19:37Z","updated_at":"2017-08-09T08:03:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/intermine/intermine/pulls/1649","html_url":"https://github.com/intermine/intermine/pull/1649","diff_url":"https://github.com/intermine/intermine/pull/1649.diff","patch_url":"https://github.com/intermine/intermine/pull/1649.patch"},"body":" Refs #1648 \r\n"},"comment":{"url":"https://api.github.com/repos/intermine/intermine/issues/comments/321183742","html_url":"https://github.com/intermine/intermine/pull/1649#issuecomment-321183742","issue_url":"https://api.github.com/repos/intermine/intermine/issues/1649","id":321183742,"user":{"login":"julie-sullivan","id":1663057,"avatar_url":"https://avatars2.githubusercontent.com/u/1663057?v=4","gravatar_id":"","url":"https://api.github.com/users/julie-sullivan","html_url":"https://github.com/julie-sullivan","followers_url":"https://api.github.com/users/julie-sullivan/followers","following_url":"https://api.github.com/users/julie-sullivan/following{/other_user}","gists_url":"https://api.github.com/users/julie-sullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/julie-sullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julie-sullivan/subscriptions","organizations_url":"https://api.github.com/users/julie-sullivan/orgs","repos_url":"https://api.github.com/users/julie-sullivan/repos","events_url":"https://api.github.com/users/julie-sullivan/events{/privacy}","received_events_url":"https://api.github.com/users/julie-sullivan/received_events","type":"User","site_admin":false},"created_at":"2017-08-09T08:03:22Z","updated_at":"2017-08-09T08:03:22Z","body":"You are right, most certainly. That's the \"correct\" way. But is it worth it compared to threading issues we might encounter? Which is what caused this mess in the first place.\r\n\r\nWorst case scenario (for the code as-is in this branch right now):\r\n\r\n1. Rachel removes the `im:public` tag from a template.\r\n2. Simultaneously you request a list of templates. You get the bad template in your request.\r\n3. the next request will find the `globalValidTemplateCache` empty and get the correctly tagged templates without the bad template Rachel just decommissioned.\r\n\r\nWorst case scenario (for synchronised method):\r\n\r\n1. Rachel removes the `im:public` tag from a template.\r\n2. Simultaneously you request a list of templates. \r\n3. Site dies because of some weird race condition. \r\n\r\nWhat are your thoughts?"}}
{"actor":{"display_login":"julie-sullivan"}}