{"action":"opened","number":270,"pull_request":{"url":"https://api.github.com/repos/PYPIT/PYPIT/pulls/270","id":149909845,"html_url":"https://github.com/PYPIT/PYPIT/pull/270","diff_url":"https://github.com/PYPIT/PYPIT/pull/270.diff","patch_url":"https://github.com/PYPIT/PYPIT/pull/270.patch","issue_url":"https://api.github.com/repos/PYPIT/PYPIT/issues/270","number":270,"state":"open","locked":false,"title":"Detect lines fix","user":{"login":"rcooke-ast","id":12585758,"avatar_url":"https://avatars2.githubusercontent.com/u/12585758?v=4","gravatar_id":"","url":"https://api.github.com/users/rcooke-ast","html_url":"https://github.com/rcooke-ast","followers_url":"https://api.github.com/users/rcooke-ast/followers","following_url":"https://api.github.com/users/rcooke-ast/following{/other_user}","gists_url":"https://api.github.com/users/rcooke-ast/gists{/gist_id}","starred_url":"https://api.github.com/users/rcooke-ast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcooke-ast/subscriptions","organizations_url":"https://api.github.com/users/rcooke-ast/orgs","repos_url":"https://api.github.com/users/rcooke-ast/repos","events_url":"https://api.github.com/users/rcooke-ast/events{/privacy}","received_events_url":"https://api.github.com/users/rcooke-ast/received_events","type":"User","site_admin":false},"body":"This PR makes improvements to the previous detect_lines algorithm, and removes some cython code. The development suite passes. The test suite does not pass. I have fixed one of the bugs in the test suite. The remaining errors are not related to this PR (the problem is with `collate` in linetools, and the `test_npeaks` function in `test_objfind.py`).\r\n\r\nNote, you will need to reinstall your PYPIT installation once this PR is merged to the master branch.","created_at":"2017-10-31T21:15:00Z","updated_at":"2017-10-31T21:15:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/PYPIT/PYPIT/pulls/270/commits","review_comments_url":"https://api.github.com/repos/PYPIT/PYPIT/pulls/270/comments","review_comment_url":"https://api.github.com/repos/PYPIT/PYPIT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PYPIT/PYPIT/issues/270/comments","statuses_url":"https://api.github.com/repos/PYPIT/PYPIT/statuses/2498f8f7612a2c18738feb58d916334904c781b5","head":{"label":"PYPIT:detect_lines_fix","ref":"detect_lines_fix","sha":"2498f8f7612a2c18738feb58d916334904c781b5","user":{"login":"PYPIT","id":13422981,"avatar_url":"https://avatars1.githubusercontent.com/u/13422981?v=4","gravatar_id":"","url":"https://api.github.com/users/PYPIT","html_url":"https://github.com/PYPIT","followers_url":"https://api.github.com/users/PYPIT/followers","following_url":"https://api.github.com/users/PYPIT/following{/other_user}","gists_url":"https://api.github.com/users/PYPIT/gists{/gist_id}","starred_url":"https://api.github.com/users/PYPIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PYPIT/subscriptions","organizations_url":"https://api.github.com/users/PYPIT/orgs","repos_url":"https://api.github.com/users/PYPIT/repos","events_url":"https://api.github.com/users/PYPIT/events{/privacy}","received_events_url":"https://api.github.com/users/PYPIT/received_events","type":"Organization","site_admin":false},"repo":{"id":36958428,"name":"PYPIT","full_name":"PYPIT/PYPIT","owner":{"login":"PYPIT","id":13422981,"avatar_url":"https://avatars1.githubusercontent.com/u/13422981?v=4","gravatar_id":"","url":"https://api.github.com/users/PYPIT","html_url":"https://github.com/PYPIT","followers_url":"https://api.github.com/users/PYPIT/followers","following_url":"https://api.github.com/users/PYPIT/following{/other_user}","gists_url":"https://api.github.com/users/PYPIT/gists{/gist_id}","starred_url":"https://api.github.com/users/PYPIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PYPIT/subscriptions","organizations_url":"https://api.github.com/users/PYPIT/orgs","repos_url":"https://api.github.com/users/PYPIT/repos","events_url":"https://api.github.com/users/PYPIT/events{/privacy}","received_events_url":"https://api.github.com/users/PYPIT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PYPIT/PYPIT","description":"The Python Spectroscopic Data Reduction Pipeline","fork":false,"url":"https://api.github.com/repos/PYPIT/PYPIT","forks_url":"https://api.github.com/repos/PYPIT/PYPIT/forks","keys_url":"https://api.github.com/repos/PYPIT/PYPIT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PYPIT/PYPIT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PYPIT/PYPIT/teams","hooks_url":"https://api.github.com/repos/PYPIT/PYPIT/hooks","issue_events_url":"https://api.github.com/repos/PYPIT/PYPIT/issues/events{/number}","events_url":"https://api.github.com/repos/PYPIT/PYPIT/events","assignees_url":"https://api.github.com/repos/PYPIT/PYPIT/assignees{/user}","branches_url":"https://api.github.com/repos/PYPIT/PYPIT/branches{/branch}","tags_url":"https://api.github.com/repos/PYPIT/PYPIT/tags","blobs_url":"https://api.github.com/repos/PYPIT/PYPIT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PYPIT/PYPIT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PYPIT/PYPIT/git/refs{/sha}","trees_url":"https://api.github.com/repos/PYPIT/PYPIT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PYPIT/PYPIT/statuses/{sha}","languages_url":"https://api.github.com/repos/PYPIT/PYPIT/languages","stargazers_url":"https://api.github.com/repos/PYPIT/PYPIT/stargazers","contributors_url":"https://api.github.com/repos/PYPIT/PYPIT/contributors","subscribers_url":"https://api.github.com/repos/PYPIT/PYPIT/subscribers","subscription_url":"https://api.github.com/repos/PYPIT/PYPIT/subscription","commits_url":"https://api.github.com/repos/PYPIT/PYPIT/commits{/sha}","git_commits_url":"https://api.github.com/repos/PYPIT/PYPIT/git/commits{/sha}","comments_url":"https://api.github.com/repos/PYPIT/PYPIT/comments{/number}","issue_comment_url":"https://api.github.com/repos/PYPIT/PYPIT/issues/comments{/number}","contents_url":"https://api.github.com/repos/PYPIT/PYPIT/contents/{+path}","compare_url":"https://api.github.com/repos/PYPIT/PYPIT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PYPIT/PYPIT/merges","archive_url":"https://api.github.com/repos/PYPIT/PYPIT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PYPIT/PYPIT/downloads","issues_url":"https://api.github.com/repos/PYPIT/PYPIT/issues{/number}","pulls_url":"https://api.github.com/repos/PYPIT/PYPIT/pulls{/number}","milestones_url":"https://api.github.com/repos/PYPIT/PYPIT/milestones{/number}","notifications_url":"https://api.github.com/repos/PYPIT/PYPIT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PYPIT/PYPIT/labels{/name}","releases_url":"https://api.github.com/repos/PYPIT/PYPIT/releases{/id}","deployments_url":"https://api.github.com/repos/PYPIT/PYPIT/deployments","created_at":"2015-06-05T22:25:37Z","updated_at":"2017-07-11T23:50:04Z","pushed_at":"2017-10-31T21:07:18Z","git_url":"git://github.com/PYPIT/PYPIT.git","ssh_url":"git@github.com:PYPIT/PYPIT.git","clone_url":"https://github.com/PYPIT/PYPIT.git","svn_url":"https://github.com/PYPIT/PYPIT","homepage":null,"size":25767,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":49,"forks":9,"open_issues":49,"watchers":7,"default_branch":"master"}},"base":{"label":"PYPIT:master","ref":"master","sha":"93dda04c0dbbdfc869eef5bd3f7c233d514664eb","user":{"login":"PYPIT","id":13422981,"avatar_url":"https://avatars1.githubusercontent.com/u/13422981?v=4","gravatar_id":"","url":"https://api.github.com/users/PYPIT","html_url":"https://github.com/PYPIT","followers_url":"https://api.github.com/users/PYPIT/followers","following_url":"https://api.github.com/users/PYPIT/following{/other_user}","gists_url":"https://api.github.com/users/PYPIT/gists{/gist_id}","starred_url":"https://api.github.com/users/PYPIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PYPIT/subscriptions","organizations_url":"https://api.github.com/users/PYPIT/orgs","repos_url":"https://api.github.com/users/PYPIT/repos","events_url":"https://api.github.com/users/PYPIT/events{/privacy}","received_events_url":"https://api.github.com/users/PYPIT/received_events","type":"Organization","site_admin":false},"repo":{"id":36958428,"name":"PYPIT","full_name":"PYPIT/PYPIT","owner":{"login":"PYPIT","id":13422981,"avatar_url":"https://avatars1.githubusercontent.com/u/13422981?v=4","gravatar_id":"","url":"https://api.github.com/users/PYPIT","html_url":"https://github.com/PYPIT","followers_url":"https://api.github.com/users/PYPIT/followers","following_url":"https://api.github.com/users/PYPIT/following{/other_user}","gists_url":"https://api.github.com/users/PYPIT/gists{/gist_id}","starred_url":"https://api.github.com/users/PYPIT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PYPIT/subscriptions","organizations_url":"https://api.github.com/users/PYPIT/orgs","repos_url":"https://api.github.com/users/PYPIT/repos","events_url":"https://api.github.com/users/PYPIT/events{/privacy}","received_events_url":"https://api.github.com/users/PYPIT/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PYPIT/PYPIT","description":"The Python Spectroscopic Data Reduction Pipeline","fork":false,"url":"https://api.github.com/repos/PYPIT/PYPIT","forks_url":"https://api.github.com/repos/PYPIT/PYPIT/forks","keys_url":"https://api.github.com/repos/PYPIT/PYPIT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PYPIT/PYPIT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PYPIT/PYPIT/teams","hooks_url":"https://api.github.com/repos/PYPIT/PYPIT/hooks","issue_events_url":"https://api.github.com/repos/PYPIT/PYPIT/issues/events{/number}","events_url":"https://api.github.com/repos/PYPIT/PYPIT/events","assignees_url":"https://api.github.com/repos/PYPIT/PYPIT/assignees{/user}","branches_url":"https://api.github.com/repos/PYPIT/PYPIT/branches{/branch}","tags_url":"https://api.github.com/repos/PYPIT/PYPIT/tags","blobs_url":"https://api.github.com/repos/PYPIT/PYPIT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PYPIT/PYPIT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PYPIT/PYPIT/git/refs{/sha}","trees_url":"https://api.github.com/repos/PYPIT/PYPIT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PYPIT/PYPIT/statuses/{sha}","languages_url":"https://api.github.com/repos/PYPIT/PYPIT/languages","stargazers_url":"https://api.github.com/repos/PYPIT/PYPIT/stargazers","contributors_url":"https://api.github.com/repos/PYPIT/PYPIT/contributors","subscribers_url":"https://api.github.com/repos/PYPIT/PYPIT/subscribers","subscription_url":"https://api.github.com/repos/PYPIT/PYPIT/subscription","commits_url":"https://api.github.com/repos/PYPIT/PYPIT/commits{/sha}","git_commits_url":"https://api.github.com/repos/PYPIT/PYPIT/git/commits{/sha}","comments_url":"https://api.github.com/repos/PYPIT/PYPIT/comments{/number}","issue_comment_url":"https://api.github.com/repos/PYPIT/PYPIT/issues/comments{/number}","contents_url":"https://api.github.com/repos/PYPIT/PYPIT/contents/{+path}","compare_url":"https://api.github.com/repos/PYPIT/PYPIT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PYPIT/PYPIT/merges","archive_url":"https://api.github.com/repos/PYPIT/PYPIT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PYPIT/PYPIT/downloads","issues_url":"https://api.github.com/repos/PYPIT/PYPIT/issues{/number}","pulls_url":"https://api.github.com/repos/PYPIT/PYPIT/pulls{/number}","milestones_url":"https://api.github.com/repos/PYPIT/PYPIT/milestones{/number}","notifications_url":"https://api.github.com/repos/PYPIT/PYPIT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PYPIT/PYPIT/labels{/name}","releases_url":"https://api.github.com/repos/PYPIT/PYPIT/releases{/id}","deployments_url":"https://api.github.com/repos/PYPIT/PYPIT/deployments","created_at":"2015-06-05T22:25:37Z","updated_at":"2017-07-11T23:50:04Z","pushed_at":"2017-10-31T21:07:18Z","git_url":"git://github.com/PYPIT/PYPIT.git","ssh_url":"git@github.com:PYPIT/PYPIT.git","clone_url":"https://github.com/PYPIT/PYPIT.git","svn_url":"https://github.com/PYPIT/PYPIT","homepage":null,"size":25767,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":49,"forks":9,"open_issues":49,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PYPIT/PYPIT/pulls/270"},"html":{"href":"https://github.com/PYPIT/PYPIT/pull/270"},"issue":{"href":"https://api.github.com/repos/PYPIT/PYPIT/issues/270"},"comments":{"href":"https://api.github.com/repos/PYPIT/PYPIT/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/PYPIT/PYPIT/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/PYPIT/PYPIT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PYPIT/PYPIT/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/PYPIT/PYPIT/statuses/2498f8f7612a2c18738feb58d916334904c781b5"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":13,"deletions":109,"changed_files":4}}
{"actor":{"display_login":"rcooke-ast"}}