{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/pulls/comments/119439537","pull_request_review_id":41319487,"id":119439537,"diff_hunk":"@@ -66,6 +66,19 @@\n     return (this.stateObj.attributes.supported_features & 128) !== 0;\n   });\n \n+  addGetter('isTiltOnly', function () {\n+    var stateObj = this.stateObj;\n+    var tiltClasses = [\n+      window.hassUtil.featureClassNames(stateObj, this.tiltFeatureClassNames),\n+    ];\n+    var tiltClassString = tiltClasses.join(' ').trim();\n+    var openClasses = [\n+      window.hassUtil.featureClassNames(stateObj, this.openFeatureClassNames),\n+    ];\n+    var openClassString = openClasses.join(' ').trim();","path":"src/util/cover-model.html","position":13,"original_position":13,"commit_id":"0790ad98aabcd6591cf6816d87d0b3ee9814b5fd","original_commit_id":"0790ad98aabcd6591cf6816d87d0b3ee9814b5fd","user":{"login":"armills","id":1386547,"avatar_url":"https://avatars1.githubusercontent.com/u/1386547?v=3","gravatar_id":"","url":"https://api.github.com/users/armills","html_url":"https://github.com/armills","followers_url":"https://api.github.com/users/armills/followers","following_url":"https://api.github.com/users/armills/following{/other_user}","gists_url":"https://api.github.com/users/armills/gists{/gist_id}","starred_url":"https://api.github.com/users/armills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armills/subscriptions","organizations_url":"https://api.github.com/users/armills/orgs","repos_url":"https://api.github.com/users/armills/repos","events_url":"https://api.github.com/users/armills/events{/privacy}","received_events_url":"https://api.github.com/users/armills/received_events","type":"User","site_admin":false},"body":"This is pretty clever, but I think we should only be doing integer or logical checking here rather than generating these strings, joining them, and looking for an empty string.  I'm thinking something along these lines.\r\n\r\n```javascript\r\nvar supportsCover = this.supportsOpen || this.supportsClose || this.supportsStop;\r\nvar supportsTilt = this.supportsOpenTilt || this.supportsCloseTilt || this.supportsStopTilt;\r\nreturn supportsTilt && !supportsCover;\r\n```\r\nor\r\n```javascript\r\nvar supportsCover = this.stateObj.attributes.supported_features & 11; //where 11 is in a constant somewhere\r\n```","created_at":"2017-05-31T18:39:25Z","updated_at":"2017-05-31T18:39:26Z","html_url":"https://github.com/home-assistant/home-assistant-polymer/pull/298#discussion_r119439537","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/pulls/298","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant-polymer/pulls/comments/119439537"},"html":{"href":"https://github.com/home-assistant/home-assistant-polymer/pull/298#discussion_r119439537"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant-polymer/pulls/298"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/pulls/298","id":123185141,"html_url":"https://github.com/home-assistant/home-assistant-polymer/pull/298","diff_url":"https://github.com/home-assistant/home-assistant-polymer/pull/298.diff","patch_url":"https://github.com/home-assistant/home-assistant-polymer/pull/298.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/issues/298","number":298,"state":"open","locked":false,"title":"Control modification for cover","user":{"login":"cribbstechnologies","id":1634941,"avatar_url":"https://avatars1.githubusercontent.com/u/1634941?v=3","gravatar_id":"","url":"https://api.github.com/users/cribbstechnologies","html_url":"https://github.com/cribbstechnologies","followers_url":"https://api.github.com/users/cribbstechnologies/followers","following_url":"https://api.github.com/users/cribbstechnologies/following{/other_user}","gists_url":"https://api.github.com/users/cribbstechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/cribbstechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cribbstechnologies/subscriptions","organizations_url":"https://api.github.com/users/cribbstechnologies/orgs","repos_url":"https://api.github.com/users/cribbstechnologies/repos","events_url":"https://api.github.com/users/cribbstechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/cribbstechnologies/received_events","type":"User","site_admin":false},"body":"Modifying cover card to have up/down and/or tilt controls on the face of the card. \r\n\r\nRelies on https://github.com/home-assistant/home-assistant/pull/7841","created_at":"2017-05-31T03:14:54Z","updated_at":"2017-05-31T18:39:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4435e82a781ce5ba3fac201f48b8f12f3a3aff2b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/pulls/298/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/pulls/298/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/issues/298/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/statuses/0790ad98aabcd6591cf6816d87d0b3ee9814b5fd","head":{"label":"cribbstechnologies:master","ref":"master","sha":"0790ad98aabcd6591cf6816d87d0b3ee9814b5fd","user":{"login":"cribbstechnologies","id":1634941,"avatar_url":"https://avatars1.githubusercontent.com/u/1634941?v=3","gravatar_id":"","url":"https://api.github.com/users/cribbstechnologies","html_url":"https://github.com/cribbstechnologies","followers_url":"https://api.github.com/users/cribbstechnologies/followers","following_url":"https://api.github.com/users/cribbstechnologies/following{/other_user}","gists_url":"https://api.github.com/users/cribbstechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/cribbstechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cribbstechnologies/subscriptions","organizations_url":"https://api.github.com/users/cribbstechnologies/orgs","repos_url":"https://api.github.com/users/cribbstechnologies/repos","events_url":"https://api.github.com/users/cribbstechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/cribbstechnologies/received_events","type":"User","site_admin":false},"repo":{"id":90544571,"name":"home-assistant-polymer","full_name":"cribbstechnologies/home-assistant-polymer","owner":{"login":"cribbstechnologies","id":1634941,"avatar_url":"https://avatars1.githubusercontent.com/u/1634941?v=3","gravatar_id":"","url":"https://api.github.com/users/cribbstechnologies","html_url":"https://github.com/cribbstechnologies","followers_url":"https://api.github.com/users/cribbstechnologies/followers","following_url":"https://api.github.com/users/cribbstechnologies/following{/other_user}","gists_url":"https://api.github.com/users/cribbstechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/cribbstechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cribbstechnologies/subscriptions","organizations_url":"https://api.github.com/users/cribbstechnologies/orgs","repos_url":"https://api.github.com/users/cribbstechnologies/repos","events_url":"https://api.github.com/users/cribbstechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/cribbstechnologies/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cribbstechnologies/home-assistant-polymer","description":":lollipop: Polymer frontend for Home Assistant","fork":true,"url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer","forks_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/forks","keys_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/teams","hooks_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/hooks","issue_events_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/issues/events{/number}","events_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/events","assignees_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/assignees{/user}","branches_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/branches{/branch}","tags_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/tags","blobs_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/git/refs{/sha}","trees_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/statuses/{sha}","languages_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/languages","stargazers_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/stargazers","contributors_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/contributors","subscribers_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/subscribers","subscription_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/subscription","commits_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/commits{/sha}","git_commits_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/git/commits{/sha}","comments_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/comments{/number}","issue_comment_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/issues/comments{/number}","contents_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/contents/{+path}","compare_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/merges","archive_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/downloads","issues_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/issues{/number}","pulls_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/pulls{/number}","milestones_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/milestones{/number}","notifications_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/labels{/name}","releases_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/releases{/id}","deployments_url":"https://api.github.com/repos/cribbstechnologies/home-assistant-polymer/deployments","created_at":"2017-05-07T16:01:52Z","updated_at":"2017-05-07T16:01:54Z","pushed_at":"2017-05-31T17:20:09Z","git_url":"git://github.com/cribbstechnologies/home-assistant-polymer.git","ssh_url":"git@github.com:cribbstechnologies/home-assistant-polymer.git","clone_url":"https://github.com/cribbstechnologies/home-assistant-polymer.git","svn_url":"https://github.com/cribbstechnologies/home-assistant-polymer","homepage":"https://home-assistant.io","size":1864,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"home-assistant:master","ref":"master","sha":"7fbc5df9a08ced3da3ed62bebe2cf6ebda12be75","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars0.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":38982731,"name":"home-assistant-polymer","full_name":"home-assistant/home-assistant-polymer","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars0.githubusercontent.com/u/13844975?v=3","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant-polymer","description":":lollipop: Polymer frontend for Home Assistant","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant-polymer","forks_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant-polymer/deployments","created_at":"2015-07-12T23:58:06Z","updated_at":"2017-05-18T15:28:52Z","pushed_at":"2017-05-31T17:20:11Z","git_url":"git://github.com/home-assistant/home-assistant-polymer.git","ssh_url":"git@github.com:home-assistant/home-assistant-polymer.git","clone_url":"https://github.com/home-assistant/home-assistant-polymer.git","svn_url":"https://github.com/home-assistant/home-assistant-polymer","homepage":"https://home-assistant.io","size":1841,"stargazers_count":126,"watchers_count":126,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":136,"mirror_url":null,"open_issues_count":29,"forks":136,"open_issues":29,"watchers":126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant-polymer/pulls/298"},"html":{"href":"https://github.com/home-assistant/home-assistant-polymer/pull/298"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant-polymer/issues/298"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant-polymer/issues/298/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant-polymer/pulls/298/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant-polymer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant-polymer/pulls/298/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant-polymer/statuses/0790ad98aabcd6591cf6816d87d0b3ee9814b5fd"}}}}
{"actor":{"display_login":"armills"}}