{"push_id":2205102546,"size":1,"distinct_size":1,"ref":"refs/heads/Enhance_addUpdaterInclusionControlToQMakeProjectFile","head":"cfb598f785404f436862a90747878963c1f90982","before":"c3b9b35152fa03fb406cda6968d4c52cfd82e93a","commits":[{"sha":"cfb598f785404f436862a90747878963c1f90982","author":{"name":"Stephen Lyons","email":"dee5bfa43a4ecb078e2a89d41fd868ef66c4b98a@virginmedia.com"},"message":"Revise: lua code reformatter matters and add missing CMake \"make install\"\n\n* Include lua code reformatter git submodule in all cases\n* Add Lua Code Formatter files to qmake *nix \"make install\"\n* Provide \"make install\" action for CMake builds on *nix.\n\nIt isn't obvious but we use a modified (for lua 5.1 amongst other things)\nlua_code_formatter (\"lcf\") lua module which we hold in our own Github repo.\nThis is compiled on-demand within:\n(void) TLuaInterpreter::initIndenterGlobals()\nand we must ensure our specified branch's source code is present at\nrun-time.\n\nWithout this an \"[ ERROR ]\" message appears on profile loading because the\nfiles are not included in the shared read-only file-set for a \"proper\"\n*nix installation.\n\nNote - the CMake build does not yet include the unix \"make install\"\ncapability.\n\nAlso had to rename lua_code_formatter to lcf so that the lua module can be\nloaded. Closes Issue #1471 .\n\nRenamed loading messages to \"lua code formatter\" to better match\n\"Format all\" invoking context menu action in edbee widget.\n\nI did encounter one issue in that the compiled with CMake project system,\nthe binary mudlet did not have an idea where the non-default Qt libraries\nwhich it was compiled against (in a /opt/Qt/5.8/gcc_64/lib location) was\nnot found at run-time and it failed to run (because my system Qt\ninstallation is not new enough to have the required Qt5Gamepad library)\nunless it had a LD_LIBRARY_PATH environmental variable set to\n\"/opt/Qt/5.8/gcc_64/lib\" before it is run. I think this is not unexpected\nand does not represent an actual failing, but is something to remember in\nwhen \"install\"-ing mudlet in a *nix system {it won't be am issue for\npackager because it will be using and compiled against the system provided\nlibraries in that situation}.\n\nSigned-off-by: Stephen Lyons <slysven@virginmedia.com>","distinct":true,"url":"https://api.github.com/repos/SlySven/Mudlet/commits/cfb598f785404f436862a90747878963c1f90982"}]}
{"actor":{"display_login":"SlySven"}}