{"action":"created","issue":{"url":"https://api.github.com/repos/minishift/minishift/issues/526","repository_url":"https://api.github.com/repos/minishift/minishift","labels_url":"https://api.github.com/repos/minishift/minishift/issues/526/labels{/name}","comments_url":"https://api.github.com/repos/minishift/minishift/issues/526/comments","events_url":"https://api.github.com/repos/minishift/minishift/issues/526/events","html_url":"https://github.com/minishift/minishift/pull/526","id":212632533,"number":526,"title":"Feedback for #480 Mount CIFS shares","user":{"login":"gbraad","id":1894,"avatar_url":"https://avatars3.githubusercontent.com/u/1894?v=3","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-08T04:07:27Z","updated_at":"2017-03-08T08:55:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/minishift/minishift/pulls/526","html_url":"https://github.com/minishift/minishift/pull/526","diff_url":"https://github.com/minishift/minishift/pull/526.diff","patch_url":"https://github.com/minishift/minishift/pull/526.patch"},"body":"Not to be merged! Related to #480 \r\n\r\nSharing for feedback/sync related to sshfs and config\r\nI do read the instance config, but do not write it yet.\r\nI have a type variable, but do not enforce it just yet in code.\r\nThis also means, the mount code for cifs is generally named and not moved into a separate file just yet.\r\n\r\nStill a lot of duplication to be removed as a refactor, so do not look at newlines/whitelines, missing boilerplate, docs, but functionality...\r\n\r\n```\r\n    \"HostFolders\": [\r\n        {\r\n            \"Name\": \"Users\",\r\n            \"Type\": \"cifs\",\r\n            \"Options\": {\r\n                \"password\": \"********\",\r\n                \"domain\": \"RHGBWIN10\",\r\n                \"uncpath\": \"//RHGBWIN10/Users\",\r\n                \"username\": \"gbraad@redhat.com\"\r\n            }\r\n        },\r\n        {\r\n            \"Name\": \"unreachable\",\r\n            \"Type\": \"cifs\",\r\n            \"Options\": {\r\n                \"domain\": \"\",\r\n                \"password\": \"********\",\r\n                \"uncpath\": \"//unreachable/disks\",\r\n                \"username\": \"root\"\r\n            }\r\n        },\r\n        {\r\n            \"Name\": \"Disks\",\r\n            \"Type\": \"cifs\",\r\n            \"Options\": {\r\n                \"domain\": \"\",\r\n                \"password\": \"********\",\r\n                \"uncpath\": \"//10.0.21.33/disks\",\r\n                \"username\": \"root\"\r\n            }\r\n        }\r\n    ],\r\n```"},"comment":{"url":"https://api.github.com/repos/minishift/minishift/issues/comments/284983980","html_url":"https://github.com/minishift/minishift/pull/526#issuecomment-284983980","issue_url":"https://api.github.com/repos/minishift/minishift/issues/526","id":284983980,"user":{"login":"hferentschik","id":296354,"avatar_url":"https://avatars3.githubusercontent.com/u/296354?v=3","gravatar_id":"","url":"https://api.github.com/users/hferentschik","html_url":"https://github.com/hferentschik","followers_url":"https://api.github.com/users/hferentschik/followers","following_url":"https://api.github.com/users/hferentschik/following{/other_user}","gists_url":"https://api.github.com/users/hferentschik/gists{/gist_id}","starred_url":"https://api.github.com/users/hferentschik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hferentschik/subscriptions","organizations_url":"https://api.github.com/users/hferentschik/orgs","repos_url":"https://api.github.com/users/hferentschik/repos","events_url":"https://api.github.com/users/hferentschik/events{/privacy}","received_events_url":"https://api.github.com/users/hferentschik/received_events","type":"User","site_admin":false},"created_at":"2017-03-08T08:55:21Z","updated_at":"2017-03-08T08:55:21Z","body":"Looking at the example config, I assume you are defining three different host folders. I am wondering where the target path is in the config. _Name_ is just an identifier, right? And _uncpath_ is the share to mount. Where is the target path on the VM? Or do you not see this as part of this config? Other than that, the config is pretty much what I expected after our recent discussions. \r\n\r\nLooking at the rest of the code now ..."}}
{"actor":{"display_login":"hferentschik"}}