{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/154802137","pull_request_review_id":81020522,"id":154802137,"diff_hunk":"@@ -47,8 +48,9 @@ const server = http.createServer(function(req, res) {\n });\n \n server.listen(0, common.mustCall(function() {\n-  let count = 0;\n-  for (let n = 1; n <= 2; n++) {\n+  const runCount = 2;","path":"test/parallel/test-http-response-multiheaders.js","position":null,"original_position":14,"commit_id":"afacc3e0f081fb8e29fe667abd0ee9720fafb36f","original_commit_id":"6e9f719391e3bc6d592b19aa00651d450b4385b7","user":{"login":"maclover7","id":3020626,"avatar_url":"https://avatars1.githubusercontent.com/u/3020626?v=4","gravatar_id":"","url":"https://api.github.com/users/maclover7","html_url":"https://github.com/maclover7","followers_url":"https://api.github.com/users/maclover7/followers","following_url":"https://api.github.com/users/maclover7/following{/other_user}","gists_url":"https://api.github.com/users/maclover7/gists{/gist_id}","starred_url":"https://api.github.com/users/maclover7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maclover7/subscriptions","organizations_url":"https://api.github.com/users/maclover7/orgs","repos_url":"https://api.github.com/users/maclover7/repos","events_url":"https://api.github.com/users/maclover7/events{/privacy}","received_events_url":"https://api.github.com/users/maclover7/received_events","type":"User","site_admin":false},"body":"@LEQADA Yep -- if no errors show up then all good. You can also see the linter CI job passing at https://ci.nodejs.org/job/node-test-linter/14156/","created_at":"2017-12-04T23:04:00Z","updated_at":"2017-12-04T23:04:00Z","html_url":"https://github.com/nodejs/node/pull/17419#discussion_r154802137","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/17419","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/154802137"},"html":{"href":"https://github.com/nodejs/node/pull/17419#discussion_r154802137"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/17419"}},"in_reply_to_id":154797822},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/17419","id":155936128,"html_url":"https://github.com/nodejs/node/pull/17419","diff_url":"https://github.com/nodejs/node/pull/17419.diff","patch_url":"https://github.com/nodejs/node/pull/17419.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/17419","number":17419,"state":"open","locked":false,"title":"refac: refactor test-http-response-multiheaders.js test to use countdown","user":{"login":"LEQADA","id":9251453,"avatar_url":"https://avatars2.githubusercontent.com/u/9251453?v=4","gravatar_id":"","url":"https://api.github.com/users/LEQADA","html_url":"https://github.com/LEQADA","followers_url":"https://api.github.com/users/LEQADA/followers","following_url":"https://api.github.com/users/LEQADA/following{/other_user}","gists_url":"https://api.github.com/users/LEQADA/gists{/gist_id}","starred_url":"https://api.github.com/users/LEQADA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LEQADA/subscriptions","organizations_url":"https://api.github.com/users/LEQADA/orgs","repos_url":"https://api.github.com/users/LEQADA/repos","events_url":"https://api.github.com/users/LEQADA/events{/privacy}","received_events_url":"https://api.github.com/users/LEQADA/received_events","type":"User","site_admin":false},"body":"Refs https://github.com/nodejs/node/issues/17169 to fix `test/parallel/test-http-response-multiheaders.js`\r\n\r\n##### Checklist\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)","created_at":"2017-12-01T19:16:31Z","updated_at":"2017-12-04T23:04:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcd6dd77f294fc05e1d428b5903a55c478f32a69","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/17419/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/17419/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/17419/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/afacc3e0f081fb8e29fe667abd0ee9720fafb36f","head":{"label":"LEQADA:use-countdown-test-http-response-multiheaders","ref":"use-countdown-test-http-response-multiheaders","sha":"afacc3e0f081fb8e29fe667abd0ee9720fafb36f","user":{"login":"LEQADA","id":9251453,"avatar_url":"https://avatars2.githubusercontent.com/u/9251453?v=4","gravatar_id":"","url":"https://api.github.com/users/LEQADA","html_url":"https://github.com/LEQADA","followers_url":"https://api.github.com/users/LEQADA/followers","following_url":"https://api.github.com/users/LEQADA/following{/other_user}","gists_url":"https://api.github.com/users/LEQADA/gists{/gist_id}","starred_url":"https://api.github.com/users/LEQADA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LEQADA/subscriptions","organizations_url":"https://api.github.com/users/LEQADA/orgs","repos_url":"https://api.github.com/users/LEQADA/repos","events_url":"https://api.github.com/users/LEQADA/events{/privacy}","received_events_url":"https://api.github.com/users/LEQADA/received_events","type":"User","site_admin":false},"repo":{"id":112771208,"name":"node","full_name":"LEQADA/node","owner":{"login":"LEQADA","id":9251453,"avatar_url":"https://avatars2.githubusercontent.com/u/9251453?v=4","gravatar_id":"","url":"https://api.github.com/users/LEQADA","html_url":"https://github.com/LEQADA","followers_url":"https://api.github.com/users/LEQADA/followers","following_url":"https://api.github.com/users/LEQADA/following{/other_user}","gists_url":"https://api.github.com/users/LEQADA/gists{/gist_id}","starred_url":"https://api.github.com/users/LEQADA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LEQADA/subscriptions","organizations_url":"https://api.github.com/users/LEQADA/orgs","repos_url":"https://api.github.com/users/LEQADA/repos","events_url":"https://api.github.com/users/LEQADA/events{/privacy}","received_events_url":"https://api.github.com/users/LEQADA/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LEQADA/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/LEQADA/node","forks_url":"https://api.github.com/repos/LEQADA/node/forks","keys_url":"https://api.github.com/repos/LEQADA/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LEQADA/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LEQADA/node/teams","hooks_url":"https://api.github.com/repos/LEQADA/node/hooks","issue_events_url":"https://api.github.com/repos/LEQADA/node/issues/events{/number}","events_url":"https://api.github.com/repos/LEQADA/node/events","assignees_url":"https://api.github.com/repos/LEQADA/node/assignees{/user}","branches_url":"https://api.github.com/repos/LEQADA/node/branches{/branch}","tags_url":"https://api.github.com/repos/LEQADA/node/tags","blobs_url":"https://api.github.com/repos/LEQADA/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LEQADA/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LEQADA/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/LEQADA/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LEQADA/node/statuses/{sha}","languages_url":"https://api.github.com/repos/LEQADA/node/languages","stargazers_url":"https://api.github.com/repos/LEQADA/node/stargazers","contributors_url":"https://api.github.com/repos/LEQADA/node/contributors","subscribers_url":"https://api.github.com/repos/LEQADA/node/subscribers","subscription_url":"https://api.github.com/repos/LEQADA/node/subscription","commits_url":"https://api.github.com/repos/LEQADA/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/LEQADA/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/LEQADA/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/LEQADA/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/LEQADA/node/contents/{+path}","compare_url":"https://api.github.com/repos/LEQADA/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LEQADA/node/merges","archive_url":"https://api.github.com/repos/LEQADA/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LEQADA/node/downloads","issues_url":"https://api.github.com/repos/LEQADA/node/issues{/number}","pulls_url":"https://api.github.com/repos/LEQADA/node/pulls{/number}","milestones_url":"https://api.github.com/repos/LEQADA/node/milestones{/number}","notifications_url":"https://api.github.com/repos/LEQADA/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LEQADA/node/labels{/name}","releases_url":"https://api.github.com/repos/LEQADA/node/releases{/id}","deployments_url":"https://api.github.com/repos/LEQADA/node/deployments","created_at":"2017-12-01T18:05:28Z","updated_at":"2017-12-01T18:05:52Z","pushed_at":"2017-12-04T22:46:21Z","git_url":"git://github.com/LEQADA/node.git","ssh_url":"git@github.com:LEQADA/node.git","clone_url":"https://github.com/LEQADA/node.git","svn_url":"https://github.com/LEQADA/node","homepage":"https://nodejs.org","size":333534,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"eb19c6b39f5494eef501494b701aeb592f59a2aa","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-12-04T22:13:53Z","pushed_at":"2017-12-04T22:57:32Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":333720,"stargazers_count":43108,"watchers_count":43108,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9005,"mirror_url":null,"archived":false,"open_issues_count":791,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9005,"open_issues":791,"watchers":43108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/17419"},"html":{"href":"https://github.com/nodejs/node/pull/17419"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/17419"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/17419/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/17419/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/17419/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/afacc3e0f081fb8e29fe667abd0ee9720fafb36f"}},"author_association":"NONE"}}
{"actor":{"display_login":"maclover7"}}