{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments/152293277","pull_request_review_id":78132086,"id":152293277,"diff_hunk":"@@ -102,16 +102,18 @@ const (\n \tvarNotificationServiceURL   = \"notification.serviceurl\"\n )\n \n-// ConfigurationData encapsulates the Viper configuration object which stores the configuration data in-memory.\n-type ConfigurationData struct {\n+// Registry encapsulates the Viper configuration registry which stores the\n+// configuration data in-memory.\n+type Registry struct {\n \tv               *viper.Viper\n \ttokenPublicKey  *rsa.PublicKey\n \ttokenPrivateKey *rsa.PrivateKey\n }\n \n-// NewConfigurationData creates a configuration reader object using a configurable configuration file path\n-func NewConfigurationData(configFilePath string) (*ConfigurationData, error) {\n-\tc := ConfigurationData{\n+// NewRegistry creates a configuration reader object using a configurable\n+// configuration file path.\n+func NewRegistry(configFilePath string) (*Registry, error) {","path":"configuration/configuration.go","position":28,"original_position":28,"commit_id":"eff75ca25342ceaa35e66a7caebf97a23aa18a2b","original_commit_id":"eff75ca25342ceaa35e66a7caebf97a23aa18a2b","user":{"login":"kwk","id":193408,"avatar_url":"https://avatars3.githubusercontent.com/u/193408?v=4","gravatar_id":"","url":"https://api.github.com/users/kwk","html_url":"https://github.com/kwk","followers_url":"https://api.github.com/users/kwk/followers","following_url":"https://api.github.com/users/kwk/following{/other_user}","gists_url":"https://api.github.com/users/kwk/gists{/gist_id}","starred_url":"https://api.github.com/users/kwk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwk/subscriptions","organizations_url":"https://api.github.com/users/kwk/orgs","repos_url":"https://api.github.com/users/kwk/repos","events_url":"https://api.github.com/users/kwk/events{/privacy}","received_events_url":"https://api.github.com/users/kwk/received_events","type":"User","site_admin":false},"body":"As long as there's nothing else that has a `NewXXX` function in the `configuration` package, then yes.","created_at":"2017-11-21T14:39:05Z","updated_at":"2017-11-21T14:39:05Z","html_url":"https://github.com/fabric8-services/fabric8-wit/pull/1778#discussion_r152293277","pull_request_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1778","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments/152293277"},"html":{"href":"https://github.com/fabric8-services/fabric8-wit/pull/1778#discussion_r152293277"},"pull_request":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1778"}},"in_reply_to_id":152291488},"pull_request":{"url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1778","id":153898118,"html_url":"https://github.com/fabric8-services/fabric8-wit/pull/1778","diff_url":"https://github.com/fabric8-services/fabric8-wit/pull/1778.diff","patch_url":"https://github.com/fabric8-services/fabric8-wit/pull/1778.patch","issue_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/1778","number":1778,"state":"open","locked":false,"title":"WIP: Added a few things suggested by golint","user":{"login":"kwk","id":193408,"avatar_url":"https://avatars3.githubusercontent.com/u/193408?v=4","gravatar_id":"","url":"https://api.github.com/users/kwk","html_url":"https://github.com/kwk","followers_url":"https://api.github.com/users/kwk/followers","following_url":"https://api.github.com/users/kwk/following{/other_user}","gists_url":"https://api.github.com/users/kwk/gists{/gist_id}","starred_url":"https://api.github.com/users/kwk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwk/subscriptions","organizations_url":"https://api.github.com/users/kwk/orgs","repos_url":"https://api.github.com/users/kwk/repos","events_url":"https://api.github.com/users/kwk/events{/privacy}","received_events_url":"https://api.github.com/users/kwk/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-21T14:01:57Z","updated_at":"2017-11-21T14:39:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d703e7781a74e406c53628ddc65c8891c8ae7ea","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sbose78","id":545280,"avatar_url":"https://avatars3.githubusercontent.com/u/545280?v=4","gravatar_id":"","url":"https://api.github.com/users/sbose78","html_url":"https://github.com/sbose78","followers_url":"https://api.github.com/users/sbose78/followers","following_url":"https://api.github.com/users/sbose78/following{/other_user}","gists_url":"https://api.github.com/users/sbose78/gists{/gist_id}","starred_url":"https://api.github.com/users/sbose78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbose78/subscriptions","organizations_url":"https://api.github.com/users/sbose78/orgs","repos_url":"https://api.github.com/users/sbose78/repos","events_url":"https://api.github.com/users/sbose78/events{/privacy}","received_events_url":"https://api.github.com/users/sbose78/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1778/commits","review_comments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1778/comments","review_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/1778/comments","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/statuses/eff75ca25342ceaa35e66a7caebf97a23aa18a2b","head":{"label":"kwk:golint","ref":"golint","sha":"eff75ca25342ceaa35e66a7caebf97a23aa18a2b","user":{"login":"kwk","id":193408,"avatar_url":"https://avatars3.githubusercontent.com/u/193408?v=4","gravatar_id":"","url":"https://api.github.com/users/kwk","html_url":"https://github.com/kwk","followers_url":"https://api.github.com/users/kwk/followers","following_url":"https://api.github.com/users/kwk/following{/other_user}","gists_url":"https://api.github.com/users/kwk/gists{/gist_id}","starred_url":"https://api.github.com/users/kwk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwk/subscriptions","organizations_url":"https://api.github.com/users/kwk/orgs","repos_url":"https://api.github.com/users/kwk/repos","events_url":"https://api.github.com/users/kwk/events{/privacy}","received_events_url":"https://api.github.com/users/kwk/received_events","type":"User","site_admin":false},"repo":{"id":61216531,"name":"fabric8-wit","full_name":"kwk/fabric8-wit","owner":{"login":"kwk","id":193408,"avatar_url":"https://avatars3.githubusercontent.com/u/193408?v=4","gravatar_id":"","url":"https://api.github.com/users/kwk","html_url":"https://github.com/kwk","followers_url":"https://api.github.com/users/kwk/followers","following_url":"https://api.github.com/users/kwk/following{/other_user}","gists_url":"https://api.github.com/users/kwk/gists{/gist_id}","starred_url":"https://api.github.com/users/kwk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwk/subscriptions","organizations_url":"https://api.github.com/users/kwk/orgs","repos_url":"https://api.github.com/users/kwk/repos","events_url":"https://api.github.com/users/kwk/events{/privacy}","received_events_url":"https://api.github.com/users/kwk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwk/fabric8-wit","description":null,"fork":true,"url":"https://api.github.com/repos/kwk/fabric8-wit","forks_url":"https://api.github.com/repos/kwk/fabric8-wit/forks","keys_url":"https://api.github.com/repos/kwk/fabric8-wit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwk/fabric8-wit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwk/fabric8-wit/teams","hooks_url":"https://api.github.com/repos/kwk/fabric8-wit/hooks","issue_events_url":"https://api.github.com/repos/kwk/fabric8-wit/issues/events{/number}","events_url":"https://api.github.com/repos/kwk/fabric8-wit/events","assignees_url":"https://api.github.com/repos/kwk/fabric8-wit/assignees{/user}","branches_url":"https://api.github.com/repos/kwk/fabric8-wit/branches{/branch}","tags_url":"https://api.github.com/repos/kwk/fabric8-wit/tags","blobs_url":"https://api.github.com/repos/kwk/fabric8-wit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwk/fabric8-wit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwk/fabric8-wit/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwk/fabric8-wit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwk/fabric8-wit/statuses/{sha}","languages_url":"https://api.github.com/repos/kwk/fabric8-wit/languages","stargazers_url":"https://api.github.com/repos/kwk/fabric8-wit/stargazers","contributors_url":"https://api.github.com/repos/kwk/fabric8-wit/contributors","subscribers_url":"https://api.github.com/repos/kwk/fabric8-wit/subscribers","subscription_url":"https://api.github.com/repos/kwk/fabric8-wit/subscription","commits_url":"https://api.github.com/repos/kwk/fabric8-wit/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwk/fabric8-wit/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwk/fabric8-wit/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwk/fabric8-wit/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwk/fabric8-wit/contents/{+path}","compare_url":"https://api.github.com/repos/kwk/fabric8-wit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwk/fabric8-wit/merges","archive_url":"https://api.github.com/repos/kwk/fabric8-wit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwk/fabric8-wit/downloads","issues_url":"https://api.github.com/repos/kwk/fabric8-wit/issues{/number}","pulls_url":"https://api.github.com/repos/kwk/fabric8-wit/pulls{/number}","milestones_url":"https://api.github.com/repos/kwk/fabric8-wit/milestones{/number}","notifications_url":"https://api.github.com/repos/kwk/fabric8-wit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwk/fabric8-wit/labels{/name}","releases_url":"https://api.github.com/repos/kwk/fabric8-wit/releases{/id}","deployments_url":"https://api.github.com/repos/kwk/fabric8-wit/deployments","created_at":"2016-06-15T14:55:29Z","updated_at":"2017-07-04T12:50:31Z","pushed_at":"2017-11-21T14:11:08Z","git_url":"git://github.com/kwk/fabric8-wit.git","ssh_url":"git@github.com:kwk/fabric8-wit.git","clone_url":"https://github.com/kwk/fabric8-wit.git","svn_url":"https://github.com/kwk/fabric8-wit","homepage":null,"size":7086,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-services:master","ref":"master","sha":"a19c64247fe11009574334aa0e2b7f5113c7b695","user":{"login":"fabric8-services","id":29751612,"avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"repo":{"id":54260706,"name":"fabric8-wit","full_name":"fabric8-services/fabric8-wit","owner":{"login":"fabric8-services","id":29751612,"avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-services/fabric8-wit","description":null,"fork":false,"url":"https://api.github.com/repos/fabric8-services/fabric8-wit","forks_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/forks","keys_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/teams","hooks_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/hooks","issue_events_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/events","assignees_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/tags","blobs_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/languages","stargazers_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/stargazers","contributors_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/contributors","subscribers_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/subscribers","subscription_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/subscription","commits_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/merges","archive_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/downloads","issues_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-services/fabric8-wit/deployments","created_at":"2016-03-19T10:42:15Z","updated_at":"2017-11-15T13:19:58Z","pushed_at":"2017-11-21T14:11:10Z","git_url":"git://github.com/fabric8-services/fabric8-wit.git","ssh_url":"git@github.com:fabric8-services/fabric8-wit.git","clone_url":"https://github.com/fabric8-services/fabric8-wit.git","svn_url":"https://github.com/fabric8-services/fabric8-wit","homepage":"http://devdoc.almighty.io/","size":10601,"stargazers_count":32,"watchers_count":32,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":137,"forks":58,"open_issues":137,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1778"},"html":{"href":"https://github.com/fabric8-services/fabric8-wit/pull/1778"},"issue":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/1778"},"comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/issues/1778/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1778/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/pulls/1778/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-services/fabric8-wit/statuses/eff75ca25342ceaa35e66a7caebf97a23aa18a2b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kwk"}}