{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/pay-products-ui/issues/26","repository_url":"https://api.github.com/repos/alphagov/pay-products-ui","labels_url":"https://api.github.com/repos/alphagov/pay-products-ui/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/pay-products-ui/issues/26/comments","events_url":"https://api.github.com/repos/alphagov/pay-products-ui/issues/26/events","html_url":"https://github.com/alphagov/pay-products-ui/pull/26","id":277832501,"number":26,"title":"PP-2990 Nunjucks migration","user":{"login":"jonheslop","id":440503,"avatar_url":"https://avatars2.githubusercontent.com/u/440503?v=4","gravatar_id":"","url":"https://api.github.com/users/jonheslop","html_url":"https://github.com/jonheslop","followers_url":"https://api.github.com/users/jonheslop/followers","following_url":"https://api.github.com/users/jonheslop/following{/other_user}","gists_url":"https://api.github.com/users/jonheslop/gists{/gist_id}","starred_url":"https://api.github.com/users/jonheslop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonheslop/subscriptions","organizations_url":"https://api.github.com/users/jonheslop/orgs","repos_url":"https://api.github.com/users/jonheslop/repos","events_url":"https://api.github.com/users/jonheslop/events{/privacy}","received_events_url":"https://api.github.com/users/jonheslop/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-29T17:02:08Z","updated_at":"2017-11-30T16:23:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/alphagov/pay-products-ui/pulls/26","html_url":"https://github.com/alphagov/pay-products-ui/pull/26","diff_url":"https://github.com/alphagov/pay-products-ui/pull/26.diff","patch_url":"https://github.com/alphagov/pay-products-ui/pull/26.patch"},"body":"## What \r\n\r\n@DanailMinchev and I have migrated from Mustache to [Nunjucks](https://mozilla.github.io/nunjucks/) because Mustache is no longer maintained or used by the Node.js community, Nunjucks on the other hand is widely used. It’s also used widely within GDS (and also shares it's syntax with [Jinja2](http://jinja.pocoo.org/) which Python projects use)\r\n\r\n## How\r\n- 🙅 0397a2d In our first commit we stripped out the Mustache template engine \r\n- 🙌 5d4e7d6 then we added in the Nunjucks npm module and the config to server.js\r\n- 💅 d2be97a  #next we renamed all `*.html` to `*.njk` and then converted the syntax\r\n- 🍪 af9087f _Bonus:_ we noticed the cookies message was showing blank, so we added in Pay’s standard cookie message (using Nunjucks of course 🙄)"},"comment":{"url":"https://api.github.com/repos/alphagov/pay-products-ui/issues/comments/348240506","html_url":"https://github.com/alphagov/pay-products-ui/pull/26#issuecomment-348240506","issue_url":"https://api.github.com/repos/alphagov/pay-products-ui/issues/26","id":348240506,"user":{"login":"DanailMinchev","id":7883702,"avatar_url":"https://avatars1.githubusercontent.com/u/7883702?v=4","gravatar_id":"","url":"https://api.github.com/users/DanailMinchev","html_url":"https://github.com/DanailMinchev","followers_url":"https://api.github.com/users/DanailMinchev/followers","following_url":"https://api.github.com/users/DanailMinchev/following{/other_user}","gists_url":"https://api.github.com/users/DanailMinchev/gists{/gist_id}","starred_url":"https://api.github.com/users/DanailMinchev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanailMinchev/subscriptions","organizations_url":"https://api.github.com/users/DanailMinchev/orgs","repos_url":"https://api.github.com/users/DanailMinchev/repos","events_url":"https://api.github.com/users/DanailMinchev/events{/privacy}","received_events_url":"https://api.github.com/users/DanailMinchev/received_events","type":"User","site_admin":false},"created_at":"2017-11-30T16:23:57Z","updated_at":"2017-11-30T16:23:57Z","author_association":"MEMBER","body":"@heathd @maxcbc @brid @nickcolley Thanks for the review!\r\nWe addressed the comments.\r\n\r\n@nickcolley about the performance impact of this change:\r\nCurrently, we are not measuring the performance impact of this change. We have performance tests which exercise our frontend application, so we'll complete the migration of frontend and then we can measure the performance difference.\r\nThere are also other reasons to migrate to Nunjucks:\r\n- Nunjucks has a more active community, Hogan.js was last updated 3-4 years ago\r\n- GOV.UK frontend is moving to use Nunjucks, and the GDS frontend community are adopting it as their standard (https://github.com/alphagov/govuk-frontend)\r\n"}}
{"actor":{"display_login":"DanailMinchev"}}