{"action":"created","issue":{"url":"https://api.github.com/repos/lagadic/visp_cao_editor/issues/16","repository_url":"https://api.github.com/repos/lagadic/visp_cao_editor","labels_url":"https://api.github.com/repos/lagadic/visp_cao_editor/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/lagadic/visp_cao_editor/issues/16/comments","events_url":"https://api.github.com/repos/lagadic/visp_cao_editor/issues/16/events","html_url":"https://github.com/lagadic/visp_cao_editor/pull/16","id":235653945,"number":16,"title":"blender export plugin version 2","user":{"login":"vikasTmz","id":11690674,"avatar_url":"https://avatars2.githubusercontent.com/u/11690674?v=3","gravatar_id":"","url":"https://api.github.com/users/vikasTmz","html_url":"https://github.com/vikasTmz","followers_url":"https://api.github.com/users/vikasTmz/followers","following_url":"https://api.github.com/users/vikasTmz/following{/other_user}","gists_url":"https://api.github.com/users/vikasTmz/gists{/gist_id}","starred_url":"https://api.github.com/users/vikasTmz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikasTmz/subscriptions","organizations_url":"https://api.github.com/users/vikasTmz/orgs","repos_url":"https://api.github.com/users/vikasTmz/repos","events_url":"https://api.github.com/users/vikasTmz/events{/privacy}","received_events_url":"https://api.github.com/users/vikasTmz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-06-13T18:49:06Z","updated_at":"2017-06-15T17:12:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lagadic/visp_cao_editor/pulls/16","html_url":"https://github.com/lagadic/visp_cao_editor/pull/16","diff_url":"https://github.com/lagadic/visp_cao_editor/pull/16.diff","patch_url":"https://github.com/lagadic/visp_cao_editor/pull/16.patch"},"body":"Covers all new features raised in Issues: #3,#4,#5,#6,#7,#8,#11,#12 and #13.\r\nThe `tree view` UI implemented does not match the one implemented under scene hierarchy in blender since there doesn't exist a module for it, but has all the functionalities. `UIList` was used instead.\r\n\r\n**Usage**:\r\n\r\n- Same process as the plugin in previous PR.\r\n- **Addition**: If `vertices/edges` are to given when `Type == \"3D Faces\" || \"3D Lines\"`, then select the necessary `vertices` from the object in the scene and click `Get Vertices`. This displays the list of selected `vertices`. \r\n- In the scene these selected `vertices` are separated and a new `mesh` is created. A `face` is then constructed for this `mesh`.\r\nNote: The `vertices` are **not editable** in the display panel. Use `undo` to revert any changes.\r\n- Enable/Disable the primitives from the `tree view` before exporting. All are enabled by default.\r\n- To edit a primitive:\r\n               1. Select it from the `tree view` and click `Select List Item`.\r\n               2. The properties can be edited in the `ViSP CAD Properties Panel`.\r\n\r\n**TODO**:\r\n\r\n- Error handling."},"comment":{"url":"https://api.github.com/repos/lagadic/visp_cao_editor/issues/comments/308808153","html_url":"https://github.com/lagadic/visp_cao_editor/pull/16#issuecomment-308808153","issue_url":"https://api.github.com/repos/lagadic/visp_cao_editor/issues/16","id":308808153,"user":{"login":"s-trinh","id":8035162,"avatar_url":"https://avatars1.githubusercontent.com/u/8035162?v=3","gravatar_id":"","url":"https://api.github.com/users/s-trinh","html_url":"https://github.com/s-trinh","followers_url":"https://api.github.com/users/s-trinh/followers","following_url":"https://api.github.com/users/s-trinh/following{/other_user}","gists_url":"https://api.github.com/users/s-trinh/gists{/gist_id}","starred_url":"https://api.github.com/users/s-trinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-trinh/subscriptions","organizations_url":"https://api.github.com/users/s-trinh/orgs","repos_url":"https://api.github.com/users/s-trinh/repos","events_url":"https://api.github.com/users/s-trinh/events{/privacy}","received_events_url":"https://api.github.com/users/s-trinh/received_events","type":"User","site_admin":false},"created_at":"2017-06-15T17:12:19Z","updated_at":"2017-06-15T17:12:19Z","body":"**cc** @fspindle Can you take a look and correct me or add something I could have missed?\r\n\r\nSome errors we encountered:\r\n- when we want to clear the list of face primitives, we get the following error message when clicking on \"Clear List\":\r\n![error_clear_list](https://user-images.githubusercontent.com/8035162/27189689-6dcb7b64-51f2-11e7-8e24-b70aa8edc202.png)\r\n- we get an error when we want to remove (\"minus\" button) a primitive from a list: \r\n![error_remove_from_list](https://user-images.githubusercontent.com/8035162/27189926-288747d0-51f3-11e7-8622-a45d31a66c48.png)\r\n- we did not manage to export 3D lines (select 2 points, Get Vertices, Add Properties) (3D Faces from lines work but this feature is less important than the possibility to model single 3D lines)\r\n\r\n---\r\n\r\nImprovements / new features suggestion:\r\n- remove optional buttons in the user interface (if possible):\r\n  - \"Enable For Export\" checkbox button looks not useful, especially if we have the feature to enable or disable individual primitive later\r\n  - this contextual menu should be removed (right click on an object in a list):\r\n![contextual_menu](https://user-images.githubusercontent.com/8035162/27190336-71aeba50-51f4-11e7-8ee7-19bcdbb690dd.png)\r\n  - if possible, customize the menu to add the following options: enable or disable this primitive, remove this primitive from the list\r\n  - if possible, remove these buttons and replaced them by a scroll bar:\r\n![buttons_navigation](https://user-images.githubusercontent.com/8035162/27190498-ec101f8c-51f4-11e7-915b-50354f851d80.png)\r\n- is it possible to add some tooltips to a button in Blender?\r\n- not very important, at the export, is it possible to write first the points for 3D lines, then for 3D faces, 3D cylinders and for 3D circles? This way, the order matches the primitive order in the tutorial and we get increasing point indexes to model each primitive type\r\n\r\n---\r\n\r\nCircle modeling improvement:\r\n- add the possibility to model a circle when the center of the circle is not accessible\r\n- UI design suggestion:\r\n![circle_modelling_ui](https://user-images.githubusercontent.com/8035162/27191597-8ccdf3d8-51f8-11e7-9c81-bb47663b560c.png)\r\n  - rename Point1 (and also for Point2 and 3 if you find a better wording, these points are used only to calculate the normal of the circle for visibility and do not need to be on the circumference of the circle) to something more meaningful\r\n  - add a tooltip or a way to say that \"Calculate radius\" needs 2 points\r\n  - add another button to calculate the center of a circle + the radius when the user select 3 points on the circle circumference (e.g. when the center of the circle is not accessible), pressing this button should update the center coordinate fields and the radius field\r\n\r\n---\r\n\r\nCylinder modeling improvement:\r\n- similar to the circle case, add the possibility to model a cylinder when the two points at the extremity of the axis of the revolution of the cylinder are not accessible\r\n- UI design suggestion:\r\n![cylinder_modelling_ui](https://user-images.githubusercontent.com/8035162/27192318-2ec6faac-51fb-11e7-9d06-a98d5a5a611e.png)\r\n  - rename Point 1 and Point 2 to something more meaningful (e.g. axis revolution point 1 and 2?)\r\n  - add a tooltip or a way to say that \"Calculate Radius\" needs two points\r\n  - add a button to calculate the axis revolution point 1 and the cylinder radius from 3 points on the cylinder circumference (e.g. when the center of the \"circles\" of the cylinder are not accessible)\r\n  - add a button to calculate the axis revolution point 2 from 2 points (or 3 points for more precision?) on the cylinder circumference\r\n\r\nWhat is the purpose of the button \"load previous property\"? It looks a little bit confusing."}}
{"actor":{"display_login":"s-trinh"}}