{"action":"created","comment":{"url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls/comments/109819438","pull_request_review_id":30944749,"id":109819438,"diff_hunk":"@@ -120,3 +121,22 @@ def runTest(self):\n \n     def tearDown(self):\n         del self.o\n+\n+\n+class TestValidateDestinationTableConnection(unittest.TestCase):\n+    def test_raises_error_on_table_not_existing(self):\n+        try:\n+            result = validate_destination_table_connection('localhost', 'foo', 'bar', 'baz')\n+            print(result)\n+            self.fail()","path":"healthcareai/tests/test_deploy_supervised_model_class.py","position":89,"original_position":89,"commit_id":"9a33e540a9bb1f30cec9d2f9fb605be453cd62a2","original_commit_id":"9a33e540a9bb1f30cec9d2f9fb605be453cd62a2","user":{"login":"levithatcher","id":2396979,"avatar_url":"https://avatars0.githubusercontent.com/u/2396979?v=3","gravatar_id":"","url":"https://api.github.com/users/levithatcher","html_url":"https://github.com/levithatcher","followers_url":"https://api.github.com/users/levithatcher/followers","following_url":"https://api.github.com/users/levithatcher/following{/other_user}","gists_url":"https://api.github.com/users/levithatcher/gists{/gist_id}","starred_url":"https://api.github.com/users/levithatcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/levithatcher/subscriptions","organizations_url":"https://api.github.com/users/levithatcher/orgs","repos_url":"https://api.github.com/users/levithatcher/repos","events_url":"https://api.github.com/users/levithatcher/events{/privacy}","received_events_url":"https://api.github.com/users/levithatcher/received_events","type":"User","site_admin":false},"body":"Interesting and logical. Would you mind adding a comment above self.fail() so the logic doesn't have to be sorted out whenever someone finds it?","created_at":"2017-04-05T02:26:49Z","updated_at":"2017-04-05T02:28:38Z","html_url":"https://github.com/HealthCatalystSLC/healthcareai-py/pull/187#discussion_r109819438","pull_request_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls/comments/109819438"},"html":{"href":"https://github.com/HealthCatalystSLC/healthcareai-py/pull/187#discussion_r109819438"},"pull_request":{"href":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls/187","id":114046224,"html_url":"https://github.com/HealthCatalystSLC/healthcareai-py/pull/187","diff_url":"https://github.com/HealthCatalystSLC/healthcareai-py/pull/187.diff","patch_url":"https://github.com/HealthCatalystSLC/healthcareai-py/pull/187.patch","issue_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/issues/187","number":187,"state":"open","locked":false,"title":"extract db write validation and unittest","user":{"login":"Aylr","id":928247,"avatar_url":"https://avatars2.githubusercontent.com/u/928247?v=3","gravatar_id":"","url":"https://api.github.com/users/Aylr","html_url":"https://github.com/Aylr","followers_url":"https://api.github.com/users/Aylr/followers","following_url":"https://api.github.com/users/Aylr/following{/other_user}","gists_url":"https://api.github.com/users/Aylr/gists{/gist_id}","starred_url":"https://api.github.com/users/Aylr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aylr/subscriptions","organizations_url":"https://api.github.com/users/Aylr/orgs","repos_url":"https://api.github.com/users/Aylr/repos","events_url":"https://api.github.com/users/Aylr/events{/privacy}","received_events_url":"https://api.github.com/users/Aylr/received_events","type":"User","site_admin":false},"body":"* added healthcareaiError\r\n* made the db table validation a method\r\n* renamed a bunch of variables for clarity\r\n* ... which required updating the docs and examples\r\n* moved column name logic to instance variable\r\n* turns out we had an extra dataframe copy laying around (creating but never using the instance variable)\r\n* wrote a few tests for the extracted function","created_at":"2017-04-03T23:50:56Z","updated_at":"2017-04-05T02:28:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"891e7acbe9563604cf59c0098e933c04f6087215","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls/187/commits","review_comments_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls/187/comments","review_comment_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/issues/187/comments","statuses_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/statuses/9a33e540a9bb1f30cec9d2f9fb605be453cd62a2","head":{"label":"HealthCatalystSLC:157","ref":"157","sha":"9a33e540a9bb1f30cec9d2f9fb605be453cd62a2","user":{"login":"HealthCatalystSLC","id":20213538,"avatar_url":"https://avatars1.githubusercontent.com/u/20213538?v=3","gravatar_id":"","url":"https://api.github.com/users/HealthCatalystSLC","html_url":"https://github.com/HealthCatalystSLC","followers_url":"https://api.github.com/users/HealthCatalystSLC/followers","following_url":"https://api.github.com/users/HealthCatalystSLC/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalystSLC/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalystSLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalystSLC/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalystSLC/orgs","repos_url":"https://api.github.com/users/HealthCatalystSLC/repos","events_url":"https://api.github.com/users/HealthCatalystSLC/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalystSLC/received_events","type":"Organization","site_admin":false},"repo":{"id":62257385,"name":"healthcareai-py","full_name":"HealthCatalystSLC/healthcareai-py","owner":{"login":"HealthCatalystSLC","id":20213538,"avatar_url":"https://avatars1.githubusercontent.com/u/20213538?v=3","gravatar_id":"","url":"https://api.github.com/users/HealthCatalystSLC","html_url":"https://github.com/HealthCatalystSLC","followers_url":"https://api.github.com/users/HealthCatalystSLC/followers","following_url":"https://api.github.com/users/HealthCatalystSLC/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalystSLC/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalystSLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalystSLC/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalystSLC/orgs","repos_url":"https://api.github.com/users/HealthCatalystSLC/repos","events_url":"https://api.github.com/users/HealthCatalystSLC/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalystSLC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HealthCatalystSLC/healthcareai-py","description":"Python tools for healthcare machine learning","fork":false,"url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py","forks_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/forks","keys_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/teams","hooks_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/hooks","issue_events_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/issues/events{/number}","events_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/events","assignees_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/assignees{/user}","branches_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/branches{/branch}","tags_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/tags","blobs_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/statuses/{sha}","languages_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/languages","stargazers_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/stargazers","contributors_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/contributors","subscribers_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/subscribers","subscription_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/subscription","commits_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/contents/{+path}","compare_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/merges","archive_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/downloads","issues_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/issues{/number}","pulls_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls{/number}","milestones_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/milestones{/number}","notifications_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/labels{/name}","releases_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/releases{/id}","deployments_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/deployments","created_at":"2016-06-29T20:57:31Z","updated_at":"2017-04-03T08:02:41Z","pushed_at":"2017-04-04T19:20:08Z","git_url":"git://github.com/HealthCatalystSLC/healthcareai-py.git","ssh_url":"git@github.com:HealthCatalystSLC/healthcareai-py.git","clone_url":"https://github.com/HealthCatalystSLC/healthcareai-py.git","svn_url":"https://github.com/HealthCatalystSLC/healthcareai-py","homepage":"http://healthcare.ai","size":3723,"stargazers_count":28,"watchers_count":28,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":95,"forks":16,"open_issues":95,"watchers":28,"default_branch":"master"}},"base":{"label":"HealthCatalystSLC:85","ref":"85","sha":"505a186cb786dce6ca5eedec0a01c99652a441e0","user":{"login":"HealthCatalystSLC","id":20213538,"avatar_url":"https://avatars1.githubusercontent.com/u/20213538?v=3","gravatar_id":"","url":"https://api.github.com/users/HealthCatalystSLC","html_url":"https://github.com/HealthCatalystSLC","followers_url":"https://api.github.com/users/HealthCatalystSLC/followers","following_url":"https://api.github.com/users/HealthCatalystSLC/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalystSLC/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalystSLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalystSLC/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalystSLC/orgs","repos_url":"https://api.github.com/users/HealthCatalystSLC/repos","events_url":"https://api.github.com/users/HealthCatalystSLC/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalystSLC/received_events","type":"Organization","site_admin":false},"repo":{"id":62257385,"name":"healthcareai-py","full_name":"HealthCatalystSLC/healthcareai-py","owner":{"login":"HealthCatalystSLC","id":20213538,"avatar_url":"https://avatars1.githubusercontent.com/u/20213538?v=3","gravatar_id":"","url":"https://api.github.com/users/HealthCatalystSLC","html_url":"https://github.com/HealthCatalystSLC","followers_url":"https://api.github.com/users/HealthCatalystSLC/followers","following_url":"https://api.github.com/users/HealthCatalystSLC/following{/other_user}","gists_url":"https://api.github.com/users/HealthCatalystSLC/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthCatalystSLC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthCatalystSLC/subscriptions","organizations_url":"https://api.github.com/users/HealthCatalystSLC/orgs","repos_url":"https://api.github.com/users/HealthCatalystSLC/repos","events_url":"https://api.github.com/users/HealthCatalystSLC/events{/privacy}","received_events_url":"https://api.github.com/users/HealthCatalystSLC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HealthCatalystSLC/healthcareai-py","description":"Python tools for healthcare machine learning","fork":false,"url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py","forks_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/forks","keys_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/teams","hooks_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/hooks","issue_events_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/issues/events{/number}","events_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/events","assignees_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/assignees{/user}","branches_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/branches{/branch}","tags_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/tags","blobs_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/statuses/{sha}","languages_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/languages","stargazers_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/stargazers","contributors_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/contributors","subscribers_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/subscribers","subscription_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/subscription","commits_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/contents/{+path}","compare_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/merges","archive_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/downloads","issues_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/issues{/number}","pulls_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls{/number}","milestones_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/milestones{/number}","notifications_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/labels{/name}","releases_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/releases{/id}","deployments_url":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/deployments","created_at":"2016-06-29T20:57:31Z","updated_at":"2017-04-03T08:02:41Z","pushed_at":"2017-04-04T19:20:08Z","git_url":"git://github.com/HealthCatalystSLC/healthcareai-py.git","ssh_url":"git@github.com:HealthCatalystSLC/healthcareai-py.git","clone_url":"https://github.com/HealthCatalystSLC/healthcareai-py.git","svn_url":"https://github.com/HealthCatalystSLC/healthcareai-py","homepage":"http://healthcare.ai","size":3723,"stargazers_count":28,"watchers_count":28,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":95,"forks":16,"open_issues":95,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls/187"},"html":{"href":"https://github.com/HealthCatalystSLC/healthcareai-py/pull/187"},"issue":{"href":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/issues/187"},"comments":{"href":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/HealthCatalystSLC/healthcareai-py/statuses/9a33e540a9bb1f30cec9d2f9fb605be453cd62a2"}}}}
{"actor":{"display_login":"levithatcher"}}