{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/21489","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/21489/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/21489/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/21489/events","html_url":"https://github.com/cms-sw/cmssw/pull/21489","id":277904567,"number":21489,"title":"Geant4 sensitive detectors cleanup 1","user":{"login":"civanch","id":4955118,"avatar_url":"https://avatars0.githubusercontent.com/u/4955118?v=4","gravatar_id":"","url":"https://api.github.com/users/civanch","html_url":"https://github.com/civanch","followers_url":"https://api.github.com/users/civanch/followers","following_url":"https://api.github.com/users/civanch/following{/other_user}","gists_url":"https://api.github.com/users/civanch/gists{/gist_id}","starred_url":"https://api.github.com/users/civanch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civanch/subscriptions","organizations_url":"https://api.github.com/users/civanch/orgs","repos_url":"https://api.github.com/users/civanch/repos","events_url":"https://api.github.com/users/civanch/events{/privacy}","received_events_url":"https://api.github.com/users/civanch/received_events","type":"User","site_admin":false},"labels":[{"id":673935056,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-pending","name":"code-checks-pending","color":"fbca04","default":false},{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820523,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":56131152,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false},{"id":530655448,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/upgrade-pending","name":"upgrade-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/72","html_url":"https://github.com/cms-sw/cmssw/milestone/72","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/72/labels","id":2866777,"number":72,"title":"CMSSW_10_0_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":218,"closed_issues":248,"state":"open","created_at":"2017-10-26T08:15:09Z","updated_at":"2017-11-30T11:14:53Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2017-11-29T20:59:34Z","updated_at":"2017-11-30T11:40:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/21489","html_url":"https://github.com/cms-sw/cmssw/pull/21489","diff_url":"https://github.com/cms-sw/cmssw/pull/21489.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/21489.patch"},"body":"Geant4 sensitive detectors were developed at different time by different developers, it turn out that there are a lot of duplicated code, variable shadowing, many protected members in base and derived classes. There is a possibility to make code faster and be more clean but any such change requires editions in many files. This is a first clean-up, which includes:\r\n  1) use of const pointers and references were possible\r\n  2) removal of all protected members from the base class\r\n  3) implement common intialisation in the base class\r\n  4) substitute remaining auto_ptr by std::unique_ptr\r\nNo change of algorithms, so expected unchanged results."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/348164313","html_url":"https://github.com/cms-sw/cmssw/pull/21489#issuecomment-348164313","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/21489","id":348164313,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2017-11-30T11:40:06Z","updated_at":"2017-11-30T11:40:06Z","author_association":"CONTRIBUTOR","body":"The code-checks are being triggered in jenkins."}}
{"actor":{"display_login":"cmsbuild"}}