{"action":"created","comment":{"url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/comments/154543237","pull_request_review_id":80720310,"id":154543237,"diff_hunk":"@@ -48,7 +48,7 @@\n Route::get('servicio/activo/{id}', 'ServicioController@finalizarActivo')->name('servicio.finalizarActivo');\n route::get('servicio/finalizado', 'ServicioController@finalizado')->name('servicio.finalizado');\n Route::get('servicio/estadistica', 'ServicioController@estadistica')->name('servicio.estadistica');\n-Route::get('servicio/{mes}/{anio}/tabla', 'ServicioController@tabla')->name('servicio.tabla');\n+Route::get('servicio/{monthSince}/{yearSince}/{monthUntil}/{yearUntil}/tabla', 'ServicioController@tabla')->name('servicio.tabla');","path":"routes/web.php","position":5,"original_position":5,"commit_id":"389fc7e2975aba7424f4128a04277f680907f4ba","original_commit_id":"a4ffbe99fc3002614cfcb0c79eaca64925d4e94b","user":{"login":"ignaciojonas","id":874682,"avatar_url":"https://avatars3.githubusercontent.com/u/874682?v=4","gravatar_id":"","url":"https://api.github.com/users/ignaciojonas","html_url":"https://github.com/ignaciojonas","followers_url":"https://api.github.com/users/ignaciojonas/followers","following_url":"https://api.github.com/users/ignaciojonas/following{/other_user}","gists_url":"https://api.github.com/users/ignaciojonas/gists{/gist_id}","starred_url":"https://api.github.com/users/ignaciojonas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ignaciojonas/subscriptions","organizations_url":"https://api.github.com/users/ignaciojonas/orgs","repos_url":"https://api.github.com/users/ignaciojonas/repos","events_url":"https://api.github.com/users/ignaciojonas/events{/privacy}","received_events_url":"https://api.github.com/users/ignaciojonas/received_events","type":"User","site_admin":false},"body":"Mas vale dejalo así, creo un ticket aparte para cambiarlo, porque no tenes la maquina para probalo.","created_at":"2017-12-04T00:34:59Z","updated_at":"2017-12-04T00:34:59Z","html_url":"https://github.com/Unicen-Tupar/bomberos/pull/229#discussion_r154543237","pull_request_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/229","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/comments/154543237"},"html":{"href":"https://github.com/Unicen-Tupar/bomberos/pull/229#discussion_r154543237"},"pull_request":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/229"}},"in_reply_to_id":154525969},"pull_request":{"url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/229","id":155750249,"html_url":"https://github.com/Unicen-Tupar/bomberos/pull/229","diff_url":"https://github.com/Unicen-Tupar/bomberos/pull/229.diff","patch_url":"https://github.com/Unicen-Tupar/bomberos/pull/229.patch","issue_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues/229","number":229,"state":"open","locked":false,"title":"Issues #174 y #183","user":{"login":"JerePrz94","id":18037653,"avatar_url":"https://avatars3.githubusercontent.com/u/18037653?v=4","gravatar_id":"","url":"https://api.github.com/users/JerePrz94","html_url":"https://github.com/JerePrz94","followers_url":"https://api.github.com/users/JerePrz94/followers","following_url":"https://api.github.com/users/JerePrz94/following{/other_user}","gists_url":"https://api.github.com/users/JerePrz94/gists{/gist_id}","starred_url":"https://api.github.com/users/JerePrz94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JerePrz94/subscriptions","organizations_url":"https://api.github.com/users/JerePrz94/orgs","repos_url":"https://api.github.com/users/JerePrz94/repos","events_url":"https://api.github.com/users/JerePrz94/events{/privacy}","received_events_url":"https://api.github.com/users/JerePrz94/received_events","type":"User","site_admin":false},"body":"Ya mergeado:\r\n- Creacion del scope \"fechaAlarma\" del controller (estaba tirado pelado en el controller)\r\n- Unit Test del scope creado\r\n\r\nAgregado:\r\n- Browser Test:\r\n                         - Controla que sin servicios la tabla se cargue con 0.\r\n                         - Controla que con servicios la tabla se cargue con valores y haga su calculo.\r\n                         - lo actualice para que testee por periodo\r\n- Scope Periodo:\r\n                        - Hice para que filtre dentro de un rango de periodo mes año\r\n- Route:\r\n                       - modifique la ruta para que funcione por periodo.\r\n- Vista:\r\n                      - modifique la vista para que tenga los imputs para que el usuario pueda definir el periodo\r\n                      - modifique para que en ves de decir \"estadisticas de \"mes\" \"año\", diga estadisticas \r\n                         periodo desde \"mes\" \"año\" hasta \"mes\" \"año\" \r\n","created_at":"2017-11-30T23:54:40Z","updated_at":"2017-12-04T00:34:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fe7f1361a95463a6065ffc87df87f957d599d12","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/229/commits","review_comments_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/229/comments","review_comment_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues/229/comments","statuses_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/statuses/389fc7e2975aba7424f4128a04277f680907f4ba","head":{"label":"JerePrz94:master","ref":"master","sha":"389fc7e2975aba7424f4128a04277f680907f4ba","user":{"login":"JerePrz94","id":18037653,"avatar_url":"https://avatars3.githubusercontent.com/u/18037653?v=4","gravatar_id":"","url":"https://api.github.com/users/JerePrz94","html_url":"https://github.com/JerePrz94","followers_url":"https://api.github.com/users/JerePrz94/followers","following_url":"https://api.github.com/users/JerePrz94/following{/other_user}","gists_url":"https://api.github.com/users/JerePrz94/gists{/gist_id}","starred_url":"https://api.github.com/users/JerePrz94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JerePrz94/subscriptions","organizations_url":"https://api.github.com/users/JerePrz94/orgs","repos_url":"https://api.github.com/users/JerePrz94/repos","events_url":"https://api.github.com/users/JerePrz94/events{/privacy}","received_events_url":"https://api.github.com/users/JerePrz94/received_events","type":"User","site_admin":false},"repo":{"id":105078754,"name":"bomberos","full_name":"JerePrz94/bomberos","owner":{"login":"JerePrz94","id":18037653,"avatar_url":"https://avatars3.githubusercontent.com/u/18037653?v=4","gravatar_id":"","url":"https://api.github.com/users/JerePrz94","html_url":"https://github.com/JerePrz94","followers_url":"https://api.github.com/users/JerePrz94/followers","following_url":"https://api.github.com/users/JerePrz94/following{/other_user}","gists_url":"https://api.github.com/users/JerePrz94/gists{/gist_id}","starred_url":"https://api.github.com/users/JerePrz94/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JerePrz94/subscriptions","organizations_url":"https://api.github.com/users/JerePrz94/orgs","repos_url":"https://api.github.com/users/JerePrz94/repos","events_url":"https://api.github.com/users/JerePrz94/events{/privacy}","received_events_url":"https://api.github.com/users/JerePrz94/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JerePrz94/bomberos","description":null,"fork":true,"url":"https://api.github.com/repos/JerePrz94/bomberos","forks_url":"https://api.github.com/repos/JerePrz94/bomberos/forks","keys_url":"https://api.github.com/repos/JerePrz94/bomberos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JerePrz94/bomberos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JerePrz94/bomberos/teams","hooks_url":"https://api.github.com/repos/JerePrz94/bomberos/hooks","issue_events_url":"https://api.github.com/repos/JerePrz94/bomberos/issues/events{/number}","events_url":"https://api.github.com/repos/JerePrz94/bomberos/events","assignees_url":"https://api.github.com/repos/JerePrz94/bomberos/assignees{/user}","branches_url":"https://api.github.com/repos/JerePrz94/bomberos/branches{/branch}","tags_url":"https://api.github.com/repos/JerePrz94/bomberos/tags","blobs_url":"https://api.github.com/repos/JerePrz94/bomberos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JerePrz94/bomberos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JerePrz94/bomberos/git/refs{/sha}","trees_url":"https://api.github.com/repos/JerePrz94/bomberos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JerePrz94/bomberos/statuses/{sha}","languages_url":"https://api.github.com/repos/JerePrz94/bomberos/languages","stargazers_url":"https://api.github.com/repos/JerePrz94/bomberos/stargazers","contributors_url":"https://api.github.com/repos/JerePrz94/bomberos/contributors","subscribers_url":"https://api.github.com/repos/JerePrz94/bomberos/subscribers","subscription_url":"https://api.github.com/repos/JerePrz94/bomberos/subscription","commits_url":"https://api.github.com/repos/JerePrz94/bomberos/commits{/sha}","git_commits_url":"https://api.github.com/repos/JerePrz94/bomberos/git/commits{/sha}","comments_url":"https://api.github.com/repos/JerePrz94/bomberos/comments{/number}","issue_comment_url":"https://api.github.com/repos/JerePrz94/bomberos/issues/comments{/number}","contents_url":"https://api.github.com/repos/JerePrz94/bomberos/contents/{+path}","compare_url":"https://api.github.com/repos/JerePrz94/bomberos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JerePrz94/bomberos/merges","archive_url":"https://api.github.com/repos/JerePrz94/bomberos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JerePrz94/bomberos/downloads","issues_url":"https://api.github.com/repos/JerePrz94/bomberos/issues{/number}","pulls_url":"https://api.github.com/repos/JerePrz94/bomberos/pulls{/number}","milestones_url":"https://api.github.com/repos/JerePrz94/bomberos/milestones{/number}","notifications_url":"https://api.github.com/repos/JerePrz94/bomberos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JerePrz94/bomberos/labels{/name}","releases_url":"https://api.github.com/repos/JerePrz94/bomberos/releases{/id}","deployments_url":"https://api.github.com/repos/JerePrz94/bomberos/deployments","created_at":"2017-09-27T23:13:05Z","updated_at":"2017-09-27T23:13:07Z","pushed_at":"2017-12-03T17:18:38Z","git_url":"git://github.com/JerePrz94/bomberos.git","ssh_url":"git@github.com:JerePrz94/bomberos.git","clone_url":"https://github.com/JerePrz94/bomberos.git","svn_url":"https://github.com/JerePrz94/bomberos","homepage":null,"size":9315,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Unicen-Tupar:master","ref":"master","sha":"5b61cdd54cecf10e3a3a990a5b20d0e29dfd36b6","user":{"login":"Unicen-Tupar","id":4358026,"avatar_url":"https://avatars3.githubusercontent.com/u/4358026?v=4","gravatar_id":"","url":"https://api.github.com/users/Unicen-Tupar","html_url":"https://github.com/Unicen-Tupar","followers_url":"https://api.github.com/users/Unicen-Tupar/followers","following_url":"https://api.github.com/users/Unicen-Tupar/following{/other_user}","gists_url":"https://api.github.com/users/Unicen-Tupar/gists{/gist_id}","starred_url":"https://api.github.com/users/Unicen-Tupar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unicen-Tupar/subscriptions","organizations_url":"https://api.github.com/users/Unicen-Tupar/orgs","repos_url":"https://api.github.com/users/Unicen-Tupar/repos","events_url":"https://api.github.com/users/Unicen-Tupar/events{/privacy}","received_events_url":"https://api.github.com/users/Unicen-Tupar/received_events","type":"Organization","site_admin":false},"repo":{"id":59577512,"name":"bomberos","full_name":"Unicen-Tupar/bomberos","owner":{"login":"Unicen-Tupar","id":4358026,"avatar_url":"https://avatars3.githubusercontent.com/u/4358026?v=4","gravatar_id":"","url":"https://api.github.com/users/Unicen-Tupar","html_url":"https://github.com/Unicen-Tupar","followers_url":"https://api.github.com/users/Unicen-Tupar/followers","following_url":"https://api.github.com/users/Unicen-Tupar/following{/other_user}","gists_url":"https://api.github.com/users/Unicen-Tupar/gists{/gist_id}","starred_url":"https://api.github.com/users/Unicen-Tupar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unicen-Tupar/subscriptions","organizations_url":"https://api.github.com/users/Unicen-Tupar/orgs","repos_url":"https://api.github.com/users/Unicen-Tupar/repos","events_url":"https://api.github.com/users/Unicen-Tupar/events{/privacy}","received_events_url":"https://api.github.com/users/Unicen-Tupar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unicen-Tupar/bomberos","description":null,"fork":false,"url":"https://api.github.com/repos/Unicen-Tupar/bomberos","forks_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/forks","keys_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/teams","hooks_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/hooks","issue_events_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues/events{/number}","events_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/events","assignees_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/assignees{/user}","branches_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/branches{/branch}","tags_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/tags","blobs_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/statuses/{sha}","languages_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/languages","stargazers_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/stargazers","contributors_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/contributors","subscribers_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/subscribers","subscription_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/subscription","commits_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/contents/{+path}","compare_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/merges","archive_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/downloads","issues_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues{/number}","pulls_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls{/number}","milestones_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/milestones{/number}","notifications_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/labels{/name}","releases_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/releases{/id}","deployments_url":"https://api.github.com/repos/Unicen-Tupar/bomberos/deployments","created_at":"2016-05-24T13:53:15Z","updated_at":"2017-09-05T21:15:28Z","pushed_at":"2017-12-04T00:31:16Z","git_url":"git://github.com/Unicen-Tupar/bomberos.git","ssh_url":"git@github.com:Unicen-Tupar/bomberos.git","clone_url":"https://github.com/Unicen-Tupar/bomberos.git","svn_url":"https://github.com/Unicen-Tupar/bomberos","homepage":null,"size":9297,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":29,"license":null,"forks":8,"open_issues":29,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/229"},"html":{"href":"https://github.com/Unicen-Tupar/bomberos/pull/229"},"issue":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues/229"},"comments":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/issues/229/comments"},"review_comments":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/229/comments"},"review_comment":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/pulls/229/commits"},"statuses":{"href":"https://api.github.com/repos/Unicen-Tupar/bomberos/statuses/389fc7e2975aba7424f4128a04277f680907f4ba"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ignaciojonas"}}