{"action":"created","comment":{"url":"https://api.github.com/repos/frappe/erpnext/pulls/comments/125272800","pull_request_review_id":47646476,"id":125272800,"diff_hunk":"@@ -733,10 +733,8 @@ def get_opening_accounts(company):\n \taccounts = frappe.db.sql_list(\"\"\"select\n \t\t\tname from tabAccount\n \t\twhere\n-\t\t\tis_group=0 and\n-\t\t\treport_type='Balance Sheet' and\n-\t\t\tifnull(warehouse, '') = '' and\n-\t\t\tcompany=%s\n+\t\t\tis_group=0 and report_type='Balance Sheet' and company=%s and\n+\t\t\tname not in(select distinct account from tabWarehouse where account is not null)","path":"erpnext/accounts/doctype/journal_entry/journal_entry.py","position":null,"original_position":9,"commit_id":"ae29282d203479b37df6b58d27569915ad6ba7db","original_commit_id":"5ded192ec9d2a44aa11fdf13a53c89513b1c8226","user":{"login":"rohitwaghchaure","id":8780500,"avatar_url":"https://avatars3.githubusercontent.com/u/8780500?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitwaghchaure","html_url":"https://github.com/rohitwaghchaure","followers_url":"https://api.github.com/users/rohitwaghchaure/followers","following_url":"https://api.github.com/users/rohitwaghchaure/following{/other_user}","gists_url":"https://api.github.com/users/rohitwaghchaure/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitwaghchaure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitwaghchaure/subscriptions","organizations_url":"https://api.github.com/users/rohitwaghchaure/orgs","repos_url":"https://api.github.com/users/rohitwaghchaure/repos","events_url":"https://api.github.com/users/rohitwaghchaure/events{/privacy}","received_events_url":"https://api.github.com/users/rohitwaghchaure/received_events","type":"User","site_admin":false},"body":"Fixed!","created_at":"2017-07-03T12:02:31Z","updated_at":"2017-07-03T12:02:31Z","html_url":"https://github.com/frappe/erpnext/pull/9585#discussion_r125272800","pull_request_url":"https://api.github.com/repos/frappe/erpnext/pulls/9585","_links":{"self":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/comments/125272800"},"html":{"href":"https://github.com/frappe/erpnext/pull/9585#discussion_r125272800"},"pull_request":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/9585"}}},"pull_request":{"url":"https://api.github.com/repos/frappe/erpnext/pulls/9585","id":128596680,"html_url":"https://github.com/frappe/erpnext/pull/9585","diff_url":"https://github.com/frappe/erpnext/pull/9585.diff","patch_url":"https://github.com/frappe/erpnext/pull/9585.patch","issue_url":"https://api.github.com/repos/frappe/erpnext/issues/9585","number":9585,"state":"open","locked":false,"title":"[Fix] Opening Entry, Unknown column 'warehouse' in 'where clause'","user":{"login":"rohitwaghchaure","id":8780500,"avatar_url":"https://avatars3.githubusercontent.com/u/8780500?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitwaghchaure","html_url":"https://github.com/rohitwaghchaure","followers_url":"https://api.github.com/users/rohitwaghchaure/followers","following_url":"https://api.github.com/users/rohitwaghchaure/following{/other_user}","gists_url":"https://api.github.com/users/rohitwaghchaure/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitwaghchaure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitwaghchaure/subscriptions","organizations_url":"https://api.github.com/users/rohitwaghchaure/orgs","repos_url":"https://api.github.com/users/rohitwaghchaure/repos","events_url":"https://api.github.com/users/rohitwaghchaure/events{/privacy}","received_events_url":"https://api.github.com/users/rohitwaghchaure/received_events","type":"User","site_admin":false},"body":"**Issue**\r\n\r\n![78c469b12919dff986bee09c3d8c4cc5e3c9ee42](https://user-images.githubusercontent.com/8780500/27788672-2765277e-6007-11e7-8705-c9ea8c332879.png)\r\n\r\n","created_at":"2017-07-03T10:18:05Z","updated_at":"2017-07-03T12:02:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55a3458a6fcfba58e0b8bd07dca8a54393cfe244","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/frappe/erpnext/milestones/53","html_url":"https://github.com/frappe/erpnext/milestone/53","labels_url":"https://api.github.com/repos/frappe/erpnext/milestones/53/labels","id":2617809,"number":53,"title":"2017-07-04","description":"","creator":{"login":"nabinhait","id":836784,"avatar_url":"https://avatars1.githubusercontent.com/u/836784?v=3","gravatar_id":"","url":"https://api.github.com/users/nabinhait","html_url":"https://github.com/nabinhait","followers_url":"https://api.github.com/users/nabinhait/followers","following_url":"https://api.github.com/users/nabinhait/following{/other_user}","gists_url":"https://api.github.com/users/nabinhait/gists{/gist_id}","starred_url":"https://api.github.com/users/nabinhait/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nabinhait/subscriptions","organizations_url":"https://api.github.com/users/nabinhait/orgs","repos_url":"https://api.github.com/users/nabinhait/repos","events_url":"https://api.github.com/users/nabinhait/events{/privacy}","received_events_url":"https://api.github.com/users/nabinhait/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":0,"state":"open","created_at":"2017-07-03T07:39:42Z","updated_at":"2017-07-03T11:34:13Z","due_on":"2017-07-04T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/frappe/erpnext/pulls/9585/commits","review_comments_url":"https://api.github.com/repos/frappe/erpnext/pulls/9585/comments","review_comment_url":"https://api.github.com/repos/frappe/erpnext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frappe/erpnext/issues/9585/comments","statuses_url":"https://api.github.com/repos/frappe/erpnext/statuses/ae29282d203479b37df6b58d27569915ad6ba7db","head":{"label":"rohitwaghchaure:opening_entry_issue","ref":"opening_entry_issue","sha":"ae29282d203479b37df6b58d27569915ad6ba7db","user":{"login":"rohitwaghchaure","id":8780500,"avatar_url":"https://avatars3.githubusercontent.com/u/8780500?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitwaghchaure","html_url":"https://github.com/rohitwaghchaure","followers_url":"https://api.github.com/users/rohitwaghchaure/followers","following_url":"https://api.github.com/users/rohitwaghchaure/following{/other_user}","gists_url":"https://api.github.com/users/rohitwaghchaure/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitwaghchaure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitwaghchaure/subscriptions","organizations_url":"https://api.github.com/users/rohitwaghchaure/orgs","repos_url":"https://api.github.com/users/rohitwaghchaure/repos","events_url":"https://api.github.com/users/rohitwaghchaure/events{/privacy}","received_events_url":"https://api.github.com/users/rohitwaghchaure/received_events","type":"User","site_admin":false},"repo":{"id":52080333,"name":"erpnext_develop","full_name":"rohitwaghchaure/erpnext_develop","owner":{"login":"rohitwaghchaure","id":8780500,"avatar_url":"https://avatars3.githubusercontent.com/u/8780500?v=3","gravatar_id":"","url":"https://api.github.com/users/rohitwaghchaure","html_url":"https://github.com/rohitwaghchaure","followers_url":"https://api.github.com/users/rohitwaghchaure/followers","following_url":"https://api.github.com/users/rohitwaghchaure/following{/other_user}","gists_url":"https://api.github.com/users/rohitwaghchaure/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitwaghchaure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitwaghchaure/subscriptions","organizations_url":"https://api.github.com/users/rohitwaghchaure/orgs","repos_url":"https://api.github.com/users/rohitwaghchaure/repos","events_url":"https://api.github.com/users/rohitwaghchaure/events{/privacy}","received_events_url":"https://api.github.com/users/rohitwaghchaure/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rohitwaghchaure/erpnext_develop","description":"Open Source ERP built for the Web. Uses Python, MariaDB.","fork":true,"url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop","forks_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/forks","keys_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/teams","hooks_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/hooks","issue_events_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/issues/events{/number}","events_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/events","assignees_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/assignees{/user}","branches_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/branches{/branch}","tags_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/tags","blobs_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/git/refs{/sha}","trees_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/statuses/{sha}","languages_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/languages","stargazers_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/stargazers","contributors_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/contributors","subscribers_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/subscribers","subscription_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/subscription","commits_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/commits{/sha}","git_commits_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/git/commits{/sha}","comments_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/comments{/number}","issue_comment_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/issues/comments{/number}","contents_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/contents/{+path}","compare_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/merges","archive_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/downloads","issues_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/issues{/number}","pulls_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/pulls{/number}","milestones_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/milestones{/number}","notifications_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/labels{/name}","releases_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/releases{/id}","deployments_url":"https://api.github.com/repos/rohitwaghchaure/erpnext_develop/deployments","created_at":"2016-02-19T10:24:57Z","updated_at":"2017-03-14T07:57:05Z","pushed_at":"2017-07-03T12:01:42Z","git_url":"git://github.com/rohitwaghchaure/erpnext_develop.git","ssh_url":"git@github.com:rohitwaghchaure/erpnext_develop.git","clone_url":"https://github.com/rohitwaghchaure/erpnext_develop.git","svn_url":"https://github.com/rohitwaghchaure/erpnext_develop","homepage":"http://erpnext.com","size":352188,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"frappe:hotfix","ref":"hotfix","sha":"ea92682cfdc79ccd66d15c386d71eb3ea351a5ac","user":{"login":"frappe","id":836974,"avatar_url":"https://avatars1.githubusercontent.com/u/836974?v=3","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"repo":{"id":1864233,"name":"erpnext","full_name":"frappe/erpnext","owner":{"login":"frappe","id":836974,"avatar_url":"https://avatars1.githubusercontent.com/u/836974?v=3","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frappe/erpnext","description":"Business Made Simple","fork":false,"url":"https://api.github.com/repos/frappe/erpnext","forks_url":"https://api.github.com/repos/frappe/erpnext/forks","keys_url":"https://api.github.com/repos/frappe/erpnext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frappe/erpnext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frappe/erpnext/teams","hooks_url":"https://api.github.com/repos/frappe/erpnext/hooks","issue_events_url":"https://api.github.com/repos/frappe/erpnext/issues/events{/number}","events_url":"https://api.github.com/repos/frappe/erpnext/events","assignees_url":"https://api.github.com/repos/frappe/erpnext/assignees{/user}","branches_url":"https://api.github.com/repos/frappe/erpnext/branches{/branch}","tags_url":"https://api.github.com/repos/frappe/erpnext/tags","blobs_url":"https://api.github.com/repos/frappe/erpnext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frappe/erpnext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frappe/erpnext/git/refs{/sha}","trees_url":"https://api.github.com/repos/frappe/erpnext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frappe/erpnext/statuses/{sha}","languages_url":"https://api.github.com/repos/frappe/erpnext/languages","stargazers_url":"https://api.github.com/repos/frappe/erpnext/stargazers","contributors_url":"https://api.github.com/repos/frappe/erpnext/contributors","subscribers_url":"https://api.github.com/repos/frappe/erpnext/subscribers","subscription_url":"https://api.github.com/repos/frappe/erpnext/subscription","commits_url":"https://api.github.com/repos/frappe/erpnext/commits{/sha}","git_commits_url":"https://api.github.com/repos/frappe/erpnext/git/commits{/sha}","comments_url":"https://api.github.com/repos/frappe/erpnext/comments{/number}","issue_comment_url":"https://api.github.com/repos/frappe/erpnext/issues/comments{/number}","contents_url":"https://api.github.com/repos/frappe/erpnext/contents/{+path}","compare_url":"https://api.github.com/repos/frappe/erpnext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frappe/erpnext/merges","archive_url":"https://api.github.com/repos/frappe/erpnext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frappe/erpnext/downloads","issues_url":"https://api.github.com/repos/frappe/erpnext/issues{/number}","pulls_url":"https://api.github.com/repos/frappe/erpnext/pulls{/number}","milestones_url":"https://api.github.com/repos/frappe/erpnext/milestones{/number}","notifications_url":"https://api.github.com/repos/frappe/erpnext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frappe/erpnext/labels{/name}","releases_url":"https://api.github.com/repos/frappe/erpnext/releases{/id}","deployments_url":"https://api.github.com/repos/frappe/erpnext/deployments","created_at":"2011-06-08T08:20:56Z","updated_at":"2017-07-03T10:31:38Z","pushed_at":"2017-07-03T12:01:44Z","git_url":"git://github.com/frappe/erpnext.git","ssh_url":"git@github.com:frappe/erpnext.git","clone_url":"https://github.com/frappe/erpnext.git","svn_url":"https://github.com/frappe/erpnext","homepage":"http://erpnext.com","size":358460,"stargazers_count":2152,"watchers_count":2152,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1176,"mirror_url":null,"open_issues_count":977,"forks":1176,"open_issues":977,"watchers":2152,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/9585"},"html":{"href":"https://github.com/frappe/erpnext/pull/9585"},"issue":{"href":"https://api.github.com/repos/frappe/erpnext/issues/9585"},"comments":{"href":"https://api.github.com/repos/frappe/erpnext/issues/9585/comments"},"review_comments":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/9585/comments"},"review_comment":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frappe/erpnext/pulls/9585/commits"},"statuses":{"href":"https://api.github.com/repos/frappe/erpnext/statuses/ae29282d203479b37df6b58d27569915ad6ba7db"}}}}
{"actor":{"display_login":"rohitwaghchaure"}}