{"action":"created","issue":{"url":"https://api.github.com/repos/quicwg/base-drafts/issues/718","repository_url":"https://api.github.com/repos/quicwg/base-drafts","labels_url":"https://api.github.com/repos/quicwg/base-drafts/issues/718/labels{/name}","comments_url":"https://api.github.com/repos/quicwg/base-drafts/issues/718/comments","events_url":"https://api.github.com/repos/quicwg/base-drafts/issues/718/events","html_url":"https://github.com/quicwg/base-drafts/issues/718","id":249203920,"number":718,"title":"Retain use of SETTINGS_ENABLE_PUSH","user":{"login":"janaiyengar","id":11067604,"avatar_url":"https://avatars2.githubusercontent.com/u/11067604?v=4","gravatar_id":"","url":"https://api.github.com/users/janaiyengar","html_url":"https://github.com/janaiyengar","followers_url":"https://api.github.com/users/janaiyengar/followers","following_url":"https://api.github.com/users/janaiyengar/following{/other_user}","gists_url":"https://api.github.com/users/janaiyengar/gists{/gist_id}","starred_url":"https://api.github.com/users/janaiyengar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janaiyengar/subscriptions","organizations_url":"https://api.github.com/users/janaiyengar/orgs","repos_url":"https://api.github.com/users/janaiyengar/repos","events_url":"https://api.github.com/users/janaiyengar/events{/privacy}","received_events_url":"https://api.github.com/users/janaiyengar/received_events","type":"User","site_admin":false},"labels":[{"id":481871627,"url":"https://api.github.com/repos/quicwg/base-drafts/labels/-http","name":"-http","color":"fbca04","default":false},{"id":481871361,"url":"https://api.github.com/repos/quicwg/base-drafts/labels/design","name":"design","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-10T01:02:24Z","updated_at":"2017-08-10T01:20:12Z","closed_at":null,"body":"When pushing, the server currently only pushes after it's heard a MAX_PUSH_ID from the client. It might be useful to retain HTTP/2's SETTINGS_ENABLE_PUSH boolean that indicates push is disabled by the client. Without this boolean, the server has to wait forever to push but can't because it didn't hear anything from the client \"yet\", and the only way it knows that the client has disabled push is basically silence... which seems not great. (Tertiary point: it might be useful for various debugging/logging purposes to have an explicit disabling.)"},"comment":{"url":"https://api.github.com/repos/quicwg/base-drafts/issues/comments/321423883","html_url":"https://github.com/quicwg/base-drafts/issues/718#issuecomment-321423883","issue_url":"https://api.github.com/repos/quicwg/base-drafts/issues/718","id":321423883,"user":{"login":"martinthomson","id":67641,"avatar_url":"https://avatars1.githubusercontent.com/u/67641?v=4","gravatar_id":"","url":"https://api.github.com/users/martinthomson","html_url":"https://github.com/martinthomson","followers_url":"https://api.github.com/users/martinthomson/followers","following_url":"https://api.github.com/users/martinthomson/following{/other_user}","gists_url":"https://api.github.com/users/martinthomson/gists{/gist_id}","starred_url":"https://api.github.com/users/martinthomson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinthomson/subscriptions","organizations_url":"https://api.github.com/users/martinthomson/orgs","repos_url":"https://api.github.com/users/martinthomson/repos","events_url":"https://api.github.com/users/martinthomson/events{/privacy}","received_events_url":"https://api.github.com/users/martinthomson/received_events","type":"User","site_admin":false},"created_at":"2017-08-10T01:20:12Z","updated_at":"2017-08-10T01:20:12Z","body":"It's true, this changes the default stance of a server.  In the event that a MAX_PUSH_ID (#711) isn't received, the server simply can't use server push.  If the client really does support push, this error is going to be rare (the packet containing the MAX_PUSH_ID is lost or delayed and the request is still in a position to be understood and responded to).  The only consequence is lost opportunity, the protocol still functions.\r\n\r\nWe have a similar problem with SETTINGS.  SETTINGS establishes the header table size, so there is a lost (compression) opportunity if it is lost or reordered.\r\n\r\nEither way, I think that we'll find out just how much of a problem this is when we get some experience with this.  It might be premature to decide right now."}}
{"actor":{"display_login":"martinthomson"}}