{"push_id":1949784511,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"29da01e0a023eea4bbbfd69dd5d854db721233e6","before":"682e8e6e01cd9c96378692656649094ad44c35a7","commits":[{"sha":"29da01e0a023eea4bbbfd69dd5d854db721233e6","author":{"name":"David Feuer","email":"8305b15341fd76fae9653bfc7b5d21ba8e9aae2e@gmail.com"},"message":"Make parsed AST dump output lazily\n\nPreviously, `showAstData` produced a `String`. That `String` would\nthen be converted to a `Doc` using `text` to implement\n`-ddump-parsed-ast`. But rendering `text` calculates the length\nof the `String` before doing anything else. Since the AST can be\nvery large, this was bad: the whole dump string (potentially hundreds\nof millions of `Char`s) was accumulated in memory.\n\nNow, `showAstData` produces a `Doc` directly, which seems to work\na lot better. As an extra bonus, the code is simpler and cleaner.\nThe formatting has changed a bit, as the previous ad hoc approach\ndidn't really match the pretty printer too well. If someone cares\nenough to request adjustments, we can surely make them.\n\nReviewers: austin, bgamari, mpickering, alanz\n\nReviewed By: bgamari\n\nSubscribers: mpickering, rwbarton, thomie\n\nGHC Trac Issues: #14161\n\nDifferential Revision: https://phabricator.haskell.org/D3894","distinct":true,"url":"https://api.github.com/repos/ghc/ghc/commits/29da01e0a023eea4bbbfd69dd5d854db721233e6"}]}
{"actor":{"display_login":"ghc-mirror"}}