{"action":"created","comment":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/99494154","pull_request_review_id":20173620,"id":99494154,"diff_hunk":"@@ -36,7 +36,8 @@ POSSIBILITY OF SUCH DAMAGE.\n \n unit_test_t _g_unit_tests[1024];\n int _g_num_unit_tests = 0;\n-int _g_test_failures = 0;\n+int _g_test_failures = 0; // flushed at start of every unit\n+int _g_test_total_failures = 0;","path":"test/test.cpp","position":6,"original_position":6,"commit_id":"2de8d9f0e4a397625a4a8df522571b95f7bfbfc5","original_commit_id":"2de8d9f0e4a397625a4a8df522571b95f7bfbfc5","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"body":"did this used to return incorrect return code from the test process? if the last test passed, would it shadow previous failures?\r\nIs there a good reason to clear ``_g_test_failures`` each turn through the loop? I suppose there needs to be some way to tell whether a test had failures or not. an alternative way would be to copy this counter at the beginning of the test and then compare at the end. I think that would be a bit nicer, as it would require one less global variable.","created_at":"2017-02-05T17:11:30Z","updated_at":"2017-02-05T17:11:30Z","html_url":"https://github.com/arvidn/libtorrent/pull/1651#discussion_r99494154","pull_request_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1651","_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments/99494154"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1651#discussion_r99494154"},"pull_request":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1651"}}},"pull_request":{"url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1651","id":104210938,"html_url":"https://github.com/arvidn/libtorrent/pull/1651","diff_url":"https://github.com/arvidn/libtorrent/pull/1651.diff","patch_url":"https://github.com/arvidn/libtorrent/pull/1651.patch","issue_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1651","number":1651,"state":"open","locked":false,"title":"fix web_seed redirects","user":{"login":"ajax16384","id":340593,"avatar_url":"https://avatars.githubusercontent.com/u/340593?v=3","gravatar_id":"","url":"https://api.github.com/users/ajax16384","html_url":"https://github.com/ajax16384","followers_url":"https://api.github.com/users/ajax16384/followers","following_url":"https://api.github.com/users/ajax16384/following{/other_user}","gists_url":"https://api.github.com/users/ajax16384/gists{/gist_id}","starred_url":"https://api.github.com/users/ajax16384/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajax16384/subscriptions","organizations_url":"https://api.github.com/users/ajax16384/orgs","repos_url":"https://api.github.com/users/ajax16384/repos","events_url":"https://api.github.com/users/ajax16384/events{/privacy}","received_events_url":"https://api.github.com/users/ajax16384/received_events","type":"User","site_admin":false},"body":"- make all redirects ephemeral (to avoid resume serialization)\r\n- remove dup slash for redirects in proxy mode","created_at":"2017-02-01T20:04:59Z","updated_at":"2017-02-05T17:11:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0ae0619934f717cb9939945604598f447b8283e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1651/commits","review_comments_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/1651/comments","review_comment_url":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/issues/1651/comments","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/2de8d9f0e4a397625a4a8df522571b95f7bfbfc5","head":{"label":"ajax16384:fix_web_seed_redirect","ref":"fix_web_seed_redirect","sha":"2de8d9f0e4a397625a4a8df522571b95f7bfbfc5","user":{"login":"ajax16384","id":340593,"avatar_url":"https://avatars.githubusercontent.com/u/340593?v=3","gravatar_id":"","url":"https://api.github.com/users/ajax16384","html_url":"https://github.com/ajax16384","followers_url":"https://api.github.com/users/ajax16384/followers","following_url":"https://api.github.com/users/ajax16384/following{/other_user}","gists_url":"https://api.github.com/users/ajax16384/gists{/gist_id}","starred_url":"https://api.github.com/users/ajax16384/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajax16384/subscriptions","organizations_url":"https://api.github.com/users/ajax16384/orgs","repos_url":"https://api.github.com/users/ajax16384/repos","events_url":"https://api.github.com/users/ajax16384/events{/privacy}","received_events_url":"https://api.github.com/users/ajax16384/received_events","type":"User","site_admin":false},"repo":{"id":56388586,"name":"libtorrent","full_name":"ajax16384/libtorrent","owner":{"login":"ajax16384","id":340593,"avatar_url":"https://avatars.githubusercontent.com/u/340593?v=3","gravatar_id":"","url":"https://api.github.com/users/ajax16384","html_url":"https://github.com/ajax16384","followers_url":"https://api.github.com/users/ajax16384/followers","following_url":"https://api.github.com/users/ajax16384/following{/other_user}","gists_url":"https://api.github.com/users/ajax16384/gists{/gist_id}","starred_url":"https://api.github.com/users/ajax16384/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajax16384/subscriptions","organizations_url":"https://api.github.com/users/ajax16384/orgs","repos_url":"https://api.github.com/users/ajax16384/repos","events_url":"https://api.github.com/users/ajax16384/events{/privacy}","received_events_url":"https://api.github.com/users/ajax16384/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajax16384/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":true,"url":"https://api.github.com/repos/ajax16384/libtorrent","forks_url":"https://api.github.com/repos/ajax16384/libtorrent/forks","keys_url":"https://api.github.com/repos/ajax16384/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajax16384/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajax16384/libtorrent/teams","hooks_url":"https://api.github.com/repos/ajax16384/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/ajax16384/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/ajax16384/libtorrent/events","assignees_url":"https://api.github.com/repos/ajax16384/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/ajax16384/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/ajax16384/libtorrent/tags","blobs_url":"https://api.github.com/repos/ajax16384/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajax16384/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajax16384/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajax16384/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajax16384/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/ajax16384/libtorrent/languages","stargazers_url":"https://api.github.com/repos/ajax16384/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/ajax16384/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/ajax16384/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/ajax16384/libtorrent/subscription","commits_url":"https://api.github.com/repos/ajax16384/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajax16384/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajax16384/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajax16384/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajax16384/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/ajax16384/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajax16384/libtorrent/merges","archive_url":"https://api.github.com/repos/ajax16384/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajax16384/libtorrent/downloads","issues_url":"https://api.github.com/repos/ajax16384/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/ajax16384/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/ajax16384/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/ajax16384/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajax16384/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/ajax16384/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/ajax16384/libtorrent/deployments","created_at":"2016-04-16T14:40:08Z","updated_at":"2016-04-16T14:40:11Z","pushed_at":"2017-02-05T13:34:22Z","git_url":"git://github.com/ajax16384/libtorrent.git","ssh_url":"git@github.com:ajax16384/libtorrent.git","clone_url":"https://github.com/ajax16384/libtorrent.git","svn_url":"https://github.com/ajax16384/libtorrent","homepage":"http://libtorrent.org","size":50236,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arvidn:master","ref":"master","sha":"c8e488b094a6649ea85866e3b12cdf8229e2dd13","user":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"repo":{"id":36781769,"name":"libtorrent","full_name":"arvidn/libtorrent","owner":{"login":"arvidn","id":661450,"avatar_url":"https://avatars.githubusercontent.com/u/661450?v=3","gravatar_id":"","url":"https://api.github.com/users/arvidn","html_url":"https://github.com/arvidn","followers_url":"https://api.github.com/users/arvidn/followers","following_url":"https://api.github.com/users/arvidn/following{/other_user}","gists_url":"https://api.github.com/users/arvidn/gists{/gist_id}","starred_url":"https://api.github.com/users/arvidn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arvidn/subscriptions","organizations_url":"https://api.github.com/users/arvidn/orgs","repos_url":"https://api.github.com/users/arvidn/repos","events_url":"https://api.github.com/users/arvidn/events{/privacy}","received_events_url":"https://api.github.com/users/arvidn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arvidn/libtorrent","description":"an efficient feature complete C++ bittorrent implementation","fork":false,"url":"https://api.github.com/repos/arvidn/libtorrent","forks_url":"https://api.github.com/repos/arvidn/libtorrent/forks","keys_url":"https://api.github.com/repos/arvidn/libtorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arvidn/libtorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arvidn/libtorrent/teams","hooks_url":"https://api.github.com/repos/arvidn/libtorrent/hooks","issue_events_url":"https://api.github.com/repos/arvidn/libtorrent/issues/events{/number}","events_url":"https://api.github.com/repos/arvidn/libtorrent/events","assignees_url":"https://api.github.com/repos/arvidn/libtorrent/assignees{/user}","branches_url":"https://api.github.com/repos/arvidn/libtorrent/branches{/branch}","tags_url":"https://api.github.com/repos/arvidn/libtorrent/tags","blobs_url":"https://api.github.com/repos/arvidn/libtorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arvidn/libtorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arvidn/libtorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arvidn/libtorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arvidn/libtorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/arvidn/libtorrent/languages","stargazers_url":"https://api.github.com/repos/arvidn/libtorrent/stargazers","contributors_url":"https://api.github.com/repos/arvidn/libtorrent/contributors","subscribers_url":"https://api.github.com/repos/arvidn/libtorrent/subscribers","subscription_url":"https://api.github.com/repos/arvidn/libtorrent/subscription","commits_url":"https://api.github.com/repos/arvidn/libtorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arvidn/libtorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arvidn/libtorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arvidn/libtorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arvidn/libtorrent/contents/{+path}","compare_url":"https://api.github.com/repos/arvidn/libtorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arvidn/libtorrent/merges","archive_url":"https://api.github.com/repos/arvidn/libtorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arvidn/libtorrent/downloads","issues_url":"https://api.github.com/repos/arvidn/libtorrent/issues{/number}","pulls_url":"https://api.github.com/repos/arvidn/libtorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/arvidn/libtorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/arvidn/libtorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arvidn/libtorrent/labels{/name}","releases_url":"https://api.github.com/repos/arvidn/libtorrent/releases{/id}","deployments_url":"https://api.github.com/repos/arvidn/libtorrent/deployments","created_at":"2015-06-03T05:22:03Z","updated_at":"2017-02-05T16:11:20Z","pushed_at":"2017-02-05T16:45:24Z","git_url":"git://github.com/arvidn/libtorrent.git","ssh_url":"git@github.com:arvidn/libtorrent.git","clone_url":"https://github.com/arvidn/libtorrent.git","svn_url":"https://github.com/arvidn/libtorrent","homepage":"http://libtorrent.org","size":67098,"stargazers_count":671,"watchers_count":671,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":217,"mirror_url":null,"open_issues_count":93,"forks":217,"open_issues":93,"watchers":671,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1651"},"html":{"href":"https://github.com/arvidn/libtorrent/pull/1651"},"issue":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1651"},"comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/issues/1651/comments"},"review_comments":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1651/comments"},"review_comment":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arvidn/libtorrent/pulls/1651/commits"},"statuses":{"href":"https://api.github.com/repos/arvidn/libtorrent/statuses/2de8d9f0e4a397625a4a8df522571b95f7bfbfc5"}}}}
{"actor":{"display_login":"arvidn"}}