{"action":"created","comment":{"url":"https://api.github.com/repos/mrocklin/streamz/pulls/comments/141881044","pull_request_review_id":66167138,"id":141881044,"diff_hunk":"@@ -457,22 +459,27 @@ def update(self, x, who=None):\n \n \n class filter(Stream):\n-    def __init__(self, predicate, child):\n+    def __init__(self, predicate, child, **kwargs):\n         self.predicate = predicate\n+        # this is one of a few stream specific kwargs\n+        stream_name = kwargs.pop('stream_name', None)\n \n-        Stream.__init__(self, child)\n+        Stream.__init__(self, child, stream_name=stream_name)","path":"streamz/core.py","position":25,"original_position":25,"commit_id":"0e70ab353702927b7303555ae10986208e094c0b","original_commit_id":"0e70ab353702927b7303555ae10986208e094c0b","user":{"login":"mrocklin","id":306380,"avatar_url":"https://avatars3.githubusercontent.com/u/306380?v=4","gravatar_id":"","url":"https://api.github.com/users/mrocklin","html_url":"https://github.com/mrocklin","followers_url":"https://api.github.com/users/mrocklin/followers","following_url":"https://api.github.com/users/mrocklin/following{/other_user}","gists_url":"https://api.github.com/users/mrocklin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrocklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrocklin/subscriptions","organizations_url":"https://api.github.com/users/mrocklin/orgs","repos_url":"https://api.github.com/users/mrocklin/repos","events_url":"https://api.github.com/users/mrocklin/events{/privacy}","received_events_url":"https://api.github.com/users/mrocklin/received_events","type":"User","site_admin":false},"body":"(which would be a good case to test for)","created_at":"2017-09-29T14:23:20Z","updated_at":"2017-09-29T14:23:57Z","html_url":"https://github.com/mrocklin/streamz/pull/64#discussion_r141881044","pull_request_url":"https://api.github.com/repos/mrocklin/streamz/pulls/64","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mrocklin/streamz/pulls/comments/141881044"},"html":{"href":"https://github.com/mrocklin/streamz/pull/64#discussion_r141881044"},"pull_request":{"href":"https://api.github.com/repos/mrocklin/streamz/pulls/64"}},"in_reply_to_id":141880793},"pull_request":{"url":"https://api.github.com/repos/mrocklin/streamz/pulls/64","id":142882033,"html_url":"https://github.com/mrocklin/streamz/pull/64","diff_url":"https://github.com/mrocklin/streamz/pull/64.diff","patch_url":"https://github.com/mrocklin/streamz/pull/64.patch","issue_url":"https://api.github.com/repos/mrocklin/streamz/issues/64","number":64,"state":"open","locked":false,"title":"Stream name","user":{"login":"ordirules","id":705366,"avatar_url":"https://avatars2.githubusercontent.com/u/705366?v=4","gravatar_id":"","url":"https://api.github.com/users/ordirules","html_url":"https://github.com/ordirules","followers_url":"https://api.github.com/users/ordirules/followers","following_url":"https://api.github.com/users/ordirules/following{/other_user}","gists_url":"https://api.github.com/users/ordirules/gists{/gist_id}","starred_url":"https://api.github.com/users/ordirules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordirules/subscriptions","organizations_url":"https://api.github.com/users/ordirules/orgs","repos_url":"https://api.github.com/users/ordirules/repos","events_url":"https://api.github.com/users/ordirules/events{/privacy}","received_events_url":"https://api.github.com/users/ordirules/received_events","type":"User","site_admin":false},"body":"we're not passing the names properly. this is just a placeholder. Probably we should define a list of stream only strings and pass these through. One issue is anyone subclassing `__init__` has to be aware of this.\r\nIf someone has a better idea let me know. I can look into this later.\r\nThis is will affect #59 .\r\n\r\nex:\r\n```python\r\ns = Stream()\r\ns2 = s.map(lambda x : x + 1, stream_name=\"Foo\")\r\n# etc...\r\n```","created_at":"2017-09-25T13:26:15Z","updated_at":"2017-09-29T14:23:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17cbdf098fd15f93ff19eb85b8f1dd420776a591","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrocklin/streamz/pulls/64/commits","review_comments_url":"https://api.github.com/repos/mrocklin/streamz/pulls/64/comments","review_comment_url":"https://api.github.com/repos/mrocklin/streamz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrocklin/streamz/issues/64/comments","statuses_url":"https://api.github.com/repos/mrocklin/streamz/statuses/0e70ab353702927b7303555ae10986208e094c0b","head":{"label":"ordirules:stream_name","ref":"stream_name","sha":"0e70ab353702927b7303555ae10986208e094c0b","user":{"login":"ordirules","id":705366,"avatar_url":"https://avatars2.githubusercontent.com/u/705366?v=4","gravatar_id":"","url":"https://api.github.com/users/ordirules","html_url":"https://github.com/ordirules","followers_url":"https://api.github.com/users/ordirules/followers","following_url":"https://api.github.com/users/ordirules/following{/other_user}","gists_url":"https://api.github.com/users/ordirules/gists{/gist_id}","starred_url":"https://api.github.com/users/ordirules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordirules/subscriptions","organizations_url":"https://api.github.com/users/ordirules/orgs","repos_url":"https://api.github.com/users/ordirules/repos","events_url":"https://api.github.com/users/ordirules/events{/privacy}","received_events_url":"https://api.github.com/users/ordirules/received_events","type":"User","site_admin":false},"repo":{"id":88682660,"name":"streamz","full_name":"ordirules/streamz","owner":{"login":"ordirules","id":705366,"avatar_url":"https://avatars2.githubusercontent.com/u/705366?v=4","gravatar_id":"","url":"https://api.github.com/users/ordirules","html_url":"https://github.com/ordirules","followers_url":"https://api.github.com/users/ordirules/followers","following_url":"https://api.github.com/users/ordirules/following{/other_user}","gists_url":"https://api.github.com/users/ordirules/gists{/gist_id}","starred_url":"https://api.github.com/users/ordirules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordirules/subscriptions","organizations_url":"https://api.github.com/users/ordirules/orgs","repos_url":"https://api.github.com/users/ordirules/repos","events_url":"https://api.github.com/users/ordirules/events{/privacy}","received_events_url":"https://api.github.com/users/ordirules/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ordirules/streamz","description":"Playing around with building computational streams","fork":true,"url":"https://api.github.com/repos/ordirules/streamz","forks_url":"https://api.github.com/repos/ordirules/streamz/forks","keys_url":"https://api.github.com/repos/ordirules/streamz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ordirules/streamz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ordirules/streamz/teams","hooks_url":"https://api.github.com/repos/ordirules/streamz/hooks","issue_events_url":"https://api.github.com/repos/ordirules/streamz/issues/events{/number}","events_url":"https://api.github.com/repos/ordirules/streamz/events","assignees_url":"https://api.github.com/repos/ordirules/streamz/assignees{/user}","branches_url":"https://api.github.com/repos/ordirules/streamz/branches{/branch}","tags_url":"https://api.github.com/repos/ordirules/streamz/tags","blobs_url":"https://api.github.com/repos/ordirules/streamz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ordirules/streamz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ordirules/streamz/git/refs{/sha}","trees_url":"https://api.github.com/repos/ordirules/streamz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ordirules/streamz/statuses/{sha}","languages_url":"https://api.github.com/repos/ordirules/streamz/languages","stargazers_url":"https://api.github.com/repos/ordirules/streamz/stargazers","contributors_url":"https://api.github.com/repos/ordirules/streamz/contributors","subscribers_url":"https://api.github.com/repos/ordirules/streamz/subscribers","subscription_url":"https://api.github.com/repos/ordirules/streamz/subscription","commits_url":"https://api.github.com/repos/ordirules/streamz/commits{/sha}","git_commits_url":"https://api.github.com/repos/ordirules/streamz/git/commits{/sha}","comments_url":"https://api.github.com/repos/ordirules/streamz/comments{/number}","issue_comment_url":"https://api.github.com/repos/ordirules/streamz/issues/comments{/number}","contents_url":"https://api.github.com/repos/ordirules/streamz/contents/{+path}","compare_url":"https://api.github.com/repos/ordirules/streamz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ordirules/streamz/merges","archive_url":"https://api.github.com/repos/ordirules/streamz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ordirules/streamz/downloads","issues_url":"https://api.github.com/repos/ordirules/streamz/issues{/number}","pulls_url":"https://api.github.com/repos/ordirules/streamz/pulls{/number}","milestones_url":"https://api.github.com/repos/ordirules/streamz/milestones{/number}","notifications_url":"https://api.github.com/repos/ordirules/streamz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ordirules/streamz/labels{/name}","releases_url":"https://api.github.com/repos/ordirules/streamz/releases{/id}","deployments_url":"https://api.github.com/repos/ordirules/streamz/deployments","created_at":"2017-04-19T00:29:25Z","updated_at":"2017-09-21T18:36:01Z","pushed_at":"2017-09-29T14:21:19Z","git_url":"git://github.com/ordirules/streamz.git","ssh_url":"git@github.com:ordirules/streamz.git","clone_url":"https://github.com/ordirules/streamz.git","svn_url":"https://github.com/ordirules/streamz","homepage":null,"size":295,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"mrocklin:master","ref":"master","sha":"a9bdc6c509a6f77c6df7a6a59dbeaea22a79c8a4","user":{"login":"mrocklin","id":306380,"avatar_url":"https://avatars3.githubusercontent.com/u/306380?v=4","gravatar_id":"","url":"https://api.github.com/users/mrocklin","html_url":"https://github.com/mrocklin","followers_url":"https://api.github.com/users/mrocklin/followers","following_url":"https://api.github.com/users/mrocklin/following{/other_user}","gists_url":"https://api.github.com/users/mrocklin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrocklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrocklin/subscriptions","organizations_url":"https://api.github.com/users/mrocklin/orgs","repos_url":"https://api.github.com/users/mrocklin/repos","events_url":"https://api.github.com/users/mrocklin/events{/privacy}","received_events_url":"https://api.github.com/users/mrocklin/received_events","type":"User","site_admin":false},"repo":{"id":87238184,"name":"streamz","full_name":"mrocklin/streamz","owner":{"login":"mrocklin","id":306380,"avatar_url":"https://avatars3.githubusercontent.com/u/306380?v=4","gravatar_id":"","url":"https://api.github.com/users/mrocklin","html_url":"https://github.com/mrocklin","followers_url":"https://api.github.com/users/mrocklin/followers","following_url":"https://api.github.com/users/mrocklin/following{/other_user}","gists_url":"https://api.github.com/users/mrocklin/gists{/gist_id}","starred_url":"https://api.github.com/users/mrocklin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrocklin/subscriptions","organizations_url":"https://api.github.com/users/mrocklin/orgs","repos_url":"https://api.github.com/users/mrocklin/repos","events_url":"https://api.github.com/users/mrocklin/events{/privacy}","received_events_url":"https://api.github.com/users/mrocklin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrocklin/streamz","description":"Playing around with building computational streams","fork":false,"url":"https://api.github.com/repos/mrocklin/streamz","forks_url":"https://api.github.com/repos/mrocklin/streamz/forks","keys_url":"https://api.github.com/repos/mrocklin/streamz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrocklin/streamz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrocklin/streamz/teams","hooks_url":"https://api.github.com/repos/mrocklin/streamz/hooks","issue_events_url":"https://api.github.com/repos/mrocklin/streamz/issues/events{/number}","events_url":"https://api.github.com/repos/mrocklin/streamz/events","assignees_url":"https://api.github.com/repos/mrocklin/streamz/assignees{/user}","branches_url":"https://api.github.com/repos/mrocklin/streamz/branches{/branch}","tags_url":"https://api.github.com/repos/mrocklin/streamz/tags","blobs_url":"https://api.github.com/repos/mrocklin/streamz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrocklin/streamz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrocklin/streamz/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrocklin/streamz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrocklin/streamz/statuses/{sha}","languages_url":"https://api.github.com/repos/mrocklin/streamz/languages","stargazers_url":"https://api.github.com/repos/mrocklin/streamz/stargazers","contributors_url":"https://api.github.com/repos/mrocklin/streamz/contributors","subscribers_url":"https://api.github.com/repos/mrocklin/streamz/subscribers","subscription_url":"https://api.github.com/repos/mrocklin/streamz/subscription","commits_url":"https://api.github.com/repos/mrocklin/streamz/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrocklin/streamz/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrocklin/streamz/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrocklin/streamz/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrocklin/streamz/contents/{+path}","compare_url":"https://api.github.com/repos/mrocklin/streamz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrocklin/streamz/merges","archive_url":"https://api.github.com/repos/mrocklin/streamz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrocklin/streamz/downloads","issues_url":"https://api.github.com/repos/mrocklin/streamz/issues{/number}","pulls_url":"https://api.github.com/repos/mrocklin/streamz/pulls{/number}","milestones_url":"https://api.github.com/repos/mrocklin/streamz/milestones{/number}","notifications_url":"https://api.github.com/repos/mrocklin/streamz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrocklin/streamz/labels{/name}","releases_url":"https://api.github.com/repos/mrocklin/streamz/releases{/id}","deployments_url":"https://api.github.com/repos/mrocklin/streamz/deployments","created_at":"2017-04-04T21:45:49Z","updated_at":"2017-08-17T09:33:06Z","pushed_at":"2017-09-29T14:21:20Z","git_url":"git://github.com/mrocklin/streamz.git","ssh_url":"git@github.com:mrocklin/streamz.git","clone_url":"https://github.com/mrocklin/streamz.git","svn_url":"https://github.com/mrocklin/streamz","homepage":null,"size":260,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":26,"forks":8,"open_issues":26,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrocklin/streamz/pulls/64"},"html":{"href":"https://github.com/mrocklin/streamz/pull/64"},"issue":{"href":"https://api.github.com/repos/mrocklin/streamz/issues/64"},"comments":{"href":"https://api.github.com/repos/mrocklin/streamz/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/mrocklin/streamz/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/mrocklin/streamz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrocklin/streamz/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/mrocklin/streamz/statuses/0e70ab353702927b7303555ae10986208e094c0b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mrocklin"}}