{"push_id":2075813127,"size":14,"distinct_size":4,"ref":"refs/heads/routing-final-cltv","head":"e46c9a8e6531e1e4937d706ca623fdf63d96c639","before":"99a693bc2349519c1a5cdcb0b0e816ff785439f6","commits":[{"sha":"c3bed51b2d626449384af955fd9bba70f87cf496","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"test_lightningd.py: make HSM seeds constant for tests.\n\nMakes it easier to compare before/after failures.  Ideally, we should\nrun under Travis both with this option and with the seed based on the\nentire tmp path (which is still reproducible with determination, but\nnot fixed every run like this is).\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":false,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/c3bed51b2d626449384af955fd9bba70f87cf496"},{"sha":"ffaa15c7dab91e22e279e63a6061570245fc7b2b","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"hsm: remove unique_id.\n\nIt was only for error messages, so replace it with pubkey.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":false,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/ffaa15c7dab91e22e279e63a6061570245fc7b2b"},{"sha":"48cedef756b60970262f2530f066881005a78808","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"peer_control: remove unique_id field.\n\nIt's now completely useless.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":false,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/48cedef756b60970262f2530f066881005a78808"},{"sha":"79962b3588f29463b71bd652be12d473117235a1","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"lightningd: return transaction from fundchannel RPC.\n\nLets tests figure out the short channel name, for example.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":false,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/79962b3588f29463b71bd652be12d473117235a1"},{"sha":"c2dd0cb295a4c52699f03b96a615b0e488164962","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"test_lightningd.py: return short channel id from fund_channel helper.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":false,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/c2dd0cb295a4c52699f03b96a615b0e488164962"},{"sha":"7e022b522cb9c23c9f2a4d43831d29302c0988d7","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"gossipd: don't try to handle padding inside fromwire_ipaddr.\n\nIt makes it impossible to embed an ipaddr in another structure, since we\nalways try to skip over any zeroes, which may swallow a following field.\n\nDo the skip specially for the case where we're parsing routing messages:\nwe never use padding for our own internal messages anyway.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":false,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/7e022b522cb9c23c9f2a4d43831d29302c0988d7"},{"sha":"7f389439563fa5aba260cc690ebb2908dab25644","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"options: show the default network setting in --help.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":false,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/7f389439563fa5aba260cc690ebb2908dab25644"},{"sha":"66a0c55322800925aead845e42a19ea996f31ccd","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"test_lightning.py: fix float insanity with values.\n\nWhen is 0.01 != 0.01?  When there are floats involved!  Jenkins hit an\nerror once, I have no idea why.\n\nThis works around the following intermittant error:\n\nERROR: test_closing_negotiation_reconnect (__main__.LightningDTests)\n----------------------------------------------------------------------\nTraceback (most recent call last):\nFile \"tests/test_lightningd.py\", line 1601, in test_closing_negotiation_reconnect\nself.fund_channel(l1, l2, 10**6)\nFile \"tests/test_lightningd.py\", line 241, in fund_channel\nraise ValueError(\"Can't find {} payment in {}\".format(amount, tx))\nValueError: Can't find 1000000 payment in 02000000000101b0b27be92916faee59f197c263e1ae7b44c0e59acdf2c385c55b5b04670ac026010000001716001401fad90abcd66697e2592164722de4a95ebee165ffffffff02651d0f0000000000160014c2ccab171c2a5be9dab52ec41b825863024c546640420f00000000002200205b8cd3b914cf67cdd8fa6273c930353dd36476734fbd962102c2df53b90880cd02473044022017bd19a0ee85532f67a280c71ed02d1321f08975334bd281527478022265225702202ec448bf9c0890a31a26f0ef4f03d298c8ec16b277faff09a70ddd335df44b6e012103d745445c9362665f22e0d96e9e766f273f3260dea39c8a76bfa05dd2684ddccf00000000\n\nFor testing, that tx decodes to:\n{\n  \"txid\": \"0165e92be762b352b665b76b9872d5189e1b2a8faf4918ab3cca7cd5d4b6a5fa\",\n  \"hash\": \"8af9a36c79ee5243468c5cbed1c80f10238fba405f0ad957a0c2cfc46fb632f5\",\n  \"version\": 2,\n  \"size\": 257,\n  \"vsize\": 176,\n  \"locktime\": 0,\n  \"vin\": [\n    {\n      \"txid\": \"26c00a67045b5bc585c3f2cd9ae5c0447baee163c297f159eefa1629e97bb2b0\",\n      \"vout\": 1,\n      \"scriptSig\": {\n        \"asm\": \"001401fad90abcd66697e2592164722de4a95ebee165\",\n        \"hex\": \"16001401fad90abcd66697e2592164722de4a95ebee165\"\n      },\n      \"txinwitness\": [\n        \"3044022017bd19a0ee85532f67a280c71ed02d1321f08975334bd281527478022265225702202ec448bf9c0890a31a26f0ef4f03d298c8ec16b277faff09a70ddd335df44b6e01\",\n        \"03d745445c9362665f22e0d96e9e766f273f3260dea39c8a76bfa05dd2684ddccf\"\n      ],\n      \"sequence\": 4294967295\n    }\n  ],\n  \"vout\": [\n    {\n      \"value\": 0.00990565,\n      \"n\": 0,\n      \"scriptPubKey\": {\n        \"asm\": \"0 c2ccab171c2a5be9dab52ec41b825863024c5466\",\n        \"hex\": \"0014c2ccab171c2a5be9dab52ec41b825863024c5466\",\n        \"type\": \"witness_v0_keyhash\"\n      }\n    },\n    {\n      \"value\": 0.01000000,\n      \"n\": 1,\n      \"scriptPubKey\": {\n        \"asm\": \"0 5b8cd3b914cf67cdd8fa6273c930353dd36476734fbd962102c2df53b90880cd\",\n        \"hex\": \"00205b8cd3b914cf67cdd8fa6273c930353dd36476734fbd962102c2df53b90880cd\",\n        \"type\": \"witness_v0_scripthash\"\n      }\n    }\n  ]\n}\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":false,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/66a0c55322800925aead845e42a19ea996f31ccd"},{"sha":"ebdecebb1a89f7dcd8daa53c57ec58af32f7c40d","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"channeld: send channel_announce and initial update to master, not gossipd.\n\nThere is a race we see sometimes under valgrind on Travis which shows\ngossipd receiving the node_announce from master before it reads the\nchannel_announce from channeld, and thus fails.  The simplest solution\nis to send the channel_announce and channel_update to master as well,\nso it can ensure it sends them to gossipd in order\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":false,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/ebdecebb1a89f7dcd8daa53c57ec58af32f7c40d"},{"sha":"b6a2b8c58be9730261f1cfca143185b056559ebd","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"Add --rgb and --alias options.\n\nAnd derive random ones from nodeid if they don't choose.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":false,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/b6a2b8c58be9730261f1cfca143185b056559ebd"},{"sha":"52b2c40e9d818ead13936185f717c9cf3bb1d14e","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"gossipd: route correctly using final CLTV value.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/52b2c40e9d818ead13936185f717c9cf3bb1d14e"},{"sha":"992caf69b0c751c87b94210e15a931bcfd6cae04","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"lightningd: split ctlv_expiry and final_cltv.\n\nThese need to be different for testing the example in BOLT 11.\n\nWe also use the cltv_final instead of deadline_blocks in the final hop:\nvarious tests assumed 5 was OK, so we tweak utils.py.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/992caf69b0c751c87b94210e15a931bcfd6cae04"},{"sha":"f3f6fa58c515b03bcf72687e13765acf2b5603b6","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"lightningd: Allow in excess of ctlv_expiry.\n\nWe add a test which both overpays and over-sets the delta on the\nintermediate and final nodes.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/f3f6fa58c515b03bcf72687e13765acf2b5603b6"},{"sha":"e46c9a8e6531e1e4937d706ca623fdf63d96c639","author":{"name":"Rusty Russell","email":"69f5932eb9977dcad4aeec4104f9f99d5dd1ae66@rustcorp.com.au"},"message":"lightningd: check for excessive HTLC locktimes.\n\nSigned-off-by: Rusty Russell <rusty@rustcorp.com.au>","distinct":true,"url":"https://api.github.com/repos/rustyrussell/lightning/commits/e46c9a8e6531e1e4937d706ca623fdf63d96c639"}]}
{"actor":{"display_login":"rustyrussell"}}