{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio-go/pulls/comments/151011310","pull_request_review_id":76650414,"id":151011310,"diff_hunk":"@@ -255,13 +266,19 @@ func isQuickMode() bool {\n \treturn os.Getenv(\"MODE\") == \"quick\"\n }\n \n+func getFuncName() string {\n+\tpc, _, _, _ := runtime.Caller(1)\n+\treturn strings.TrimPrefix(runtime.FuncForPC(pc).Name(), \"main.\")\n+}\n+\n // Tests bucket re-create errors.\n func testMakeBucketError() {\n \tregion := \"eu-central-1\"\n \n \t// initialize logging params\n \tstartTime := time.Now()\n-\tfunction := \"MakeBucket(bucketName, region)\"\n+\ttestName := getFuncName()\n+\tfunction := []string{\"MakeBucket(bucketName, region)\"}","path":"functional_tests.go","position":104,"original_position":104,"commit_id":"7088ee59656c81cc00a26e7a3da9d867e6038692","original_commit_id":"7088ee59656c81cc00a26e7a3da9d867e6038692","user":{"login":"ebozduman","id":24552332,"avatar_url":"https://avatars0.githubusercontent.com/u/24552332?v=4","gravatar_id":"","url":"https://api.github.com/users/ebozduman","html_url":"https://github.com/ebozduman","followers_url":"https://api.github.com/users/ebozduman/followers","following_url":"https://api.github.com/users/ebozduman/following{/other_user}","gists_url":"https://api.github.com/users/ebozduman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebozduman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebozduman/subscriptions","organizations_url":"https://api.github.com/users/ebozduman/orgs","repos_url":"https://api.github.com/users/ebozduman/repos","events_url":"https://api.github.com/users/ebozduman/events{/privacy}","received_events_url":"https://api.github.com/users/ebozduman/received_events","type":"User","site_admin":false},"body":"Success example:\r\n```\r\ngo build functional_tests.go;go run functional_tests.go | jq\r\n{\r\n  \"args\": {\r\n    \"bucketName\": \"minio-go-test-hx5t3l96fruilwyi\"\r\n  },\r\n  \"duration\": 2119,\r\n  \"function\": [\r\n    \"MakeBucket(bucketName, region)\",\r\n    \"BucketExists(bucketName)\",\r\n    \"GetBucketPolicy(bucketName, objectPrefix)\",\r\n    \"SetBucketPolicy(bucketName, objectPrefix, bucketPolicy)\",\r\n    \"ListBuckets()\",\r\n    \"PutObject(bucketName, objectName, reader, contentType)\",\r\n    \"ListObjects(bucketName, objectName, isRecursive, doneCh)\",\r\n    \"ListObjectsV2(bucketName, objectName, isRecursive, doneCh)\",\r\n    \"ListIncompleteUploads(bucketName, objectName, isRecursive, doneCh)\",\r\n    \"GetObject(bucketName, objectName)\",\r\n    \"FGetObject(bucketName, objectName, fileName)\",\r\n    \"PresignedHeadObject(bucketName, objectName, expires, reqParams)\",\r\n    \"PresignedGetObject(bucketName, objectName, expires, reqParams)\",\r\n    \"PresignedPutObject(bucketName, objectName, expires)\",\r\n    \"RemoveObject(bucketName, objectName)\",\r\n    \"RemoveBucket(bucketName)\"\r\n  ],\r\n  \"name\": \"minio-go: testFunctional\",\r\n  \"status\": \"PASS\"\r\n}\r\n{\r\n  \"args\": {\r\n    \"bucketName\": \"minio-go-test-04ihrp4hwhtm2dst\",\r\n    \"objectName\": \"minio-go-test-04ihrp4hwhtm2dstunique-presigned\"\r\n  },\r\n  \"duration\": 634,\r\n  \"function\": [\r\n    \"MakeBucket(bucketName, region)\",\r\n    \"BucketExists(bucketName)\",\r\n    \"SetBucketPolicy(bucketName, objectPrefix, bucketPolicy)\",\r\n    \"ListBuckets()\",\r\n    \"ListObjects(bucketName, objectName, isRecursive, doneCh)\",\r\n    \"ListIncompleteUploads(bucketName, objectName, isRecursive, doneCh)\",\r\n    \"GetObject(bucketName, objectName)\",\r\n    \"FGetObject(bucketName, objectName, fileName)\",\r\n    \"PresignedHeadObject(bucketName, objectName, expires, reqParams)\",\r\n    \"PresignedGetObject(bucketName, objectName, expires, reqParams)\",\r\n    \"PresignedPutObject(bucketName, objectName, expires)\"\r\n  ],\r\n  \"name\": \"minio-go: testFunctionalV2\",\r\n  \"status\": \"PASS\"\r\n}\r\n```\r\n\r\nFailure example (induced an error just before SetBucketPolicy api execution):\r\n```\r\n$ go build functional_tests.go;go run functional_tests.go | jq\r\n{\r\n  \"args\": {\r\n    \"bucketName\": \"minio-go-test-eomoglxiubs5s9h9\",\r\n    \"bucketPolicy\": \"readonly\",\r\n    \"objectPrefix\": \"\"\r\n  },\r\n  \"duration\": 169,\r\n  \"error\": \"BOOM!\",\r\n  \"function\": [\r\n    \"SetBucketPolicy(bucketName, objectPrefix, bucketPolicy)\"\r\n  ],\r\n  \"message\": \"SetBucketPolicy failed\",\r\n  \"name\": \"minio-go: testFunctional\",\r\n  \"status\": \"FAIL\"\r\n}\r\n```","created_at":"2017-11-15T01:14:45Z","updated_at":"2017-11-15T01:14:45Z","html_url":"https://github.com/minio/minio-go/pull/865#discussion_r151011310","pull_request_url":"https://api.github.com/repos/minio/minio-go/pulls/865","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/minio/minio-go/pulls/comments/151011310"},"html":{"href":"https://github.com/minio/minio-go/pull/865#discussion_r151011310"},"pull_request":{"href":"https://api.github.com/repos/minio/minio-go/pulls/865"}},"in_reply_to_id":150495572},"pull_request":{"url":"https://api.github.com/repos/minio/minio-go/pulls/865","id":151279497,"html_url":"https://github.com/minio/minio-go/pull/865","diff_url":"https://github.com/minio/minio-go/pull/865.diff","patch_url":"https://github.com/minio/minio-go/pull/865.patch","issue_url":"https://api.github.com/repos/minio/minio-go/issues/865","number":865,"state":"open","locked":false,"title":"Fixes log format issues","user":{"login":"ebozduman","id":24552332,"avatar_url":"https://avatars0.githubusercontent.com/u/24552332?v=4","gravatar_id":"","url":"https://api.github.com/users/ebozduman","html_url":"https://github.com/ebozduman","followers_url":"https://api.github.com/users/ebozduman/followers","following_url":"https://api.github.com/users/ebozduman/following{/other_user}","gists_url":"https://api.github.com/users/ebozduman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebozduman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebozduman/subscriptions","organizations_url":"https://api.github.com/users/ebozduman/orgs","repos_url":"https://api.github.com/users/ebozduman/repos","events_url":"https://api.github.com/users/ebozduman/events{/privacy}","received_events_url":"https://api.github.com/users/ebozduman/received_events","type":"User","site_admin":false},"body":"Fixes Issue #833","created_at":"2017-11-08T02:33:26Z","updated_at":"2017-11-15T01:14:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67d0a9354ed7280b71ac1006458cc348aa30756c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio-go/pulls/865/commits","review_comments_url":"https://api.github.com/repos/minio/minio-go/pulls/865/comments","review_comment_url":"https://api.github.com/repos/minio/minio-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio-go/issues/865/comments","statuses_url":"https://api.github.com/repos/minio/minio-go/statuses/7088ee59656c81cc00a26e7a3da9d867e6038692","head":{"label":"ebozduman:log_format","ref":"log_format","sha":"7088ee59656c81cc00a26e7a3da9d867e6038692","user":{"login":"ebozduman","id":24552332,"avatar_url":"https://avatars0.githubusercontent.com/u/24552332?v=4","gravatar_id":"","url":"https://api.github.com/users/ebozduman","html_url":"https://github.com/ebozduman","followers_url":"https://api.github.com/users/ebozduman/followers","following_url":"https://api.github.com/users/ebozduman/following{/other_user}","gists_url":"https://api.github.com/users/ebozduman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebozduman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebozduman/subscriptions","organizations_url":"https://api.github.com/users/ebozduman/orgs","repos_url":"https://api.github.com/users/ebozduman/repos","events_url":"https://api.github.com/users/ebozduman/events{/privacy}","received_events_url":"https://api.github.com/users/ebozduman/received_events","type":"User","site_admin":false},"repo":{"id":104280772,"name":"minio-go","full_name":"ebozduman/minio-go","owner":{"login":"ebozduman","id":24552332,"avatar_url":"https://avatars0.githubusercontent.com/u/24552332?v=4","gravatar_id":"","url":"https://api.github.com/users/ebozduman","html_url":"https://github.com/ebozduman","followers_url":"https://api.github.com/users/ebozduman/followers","following_url":"https://api.github.com/users/ebozduman/following{/other_user}","gists_url":"https://api.github.com/users/ebozduman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebozduman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebozduman/subscriptions","organizations_url":"https://api.github.com/users/ebozduman/orgs","repos_url":"https://api.github.com/users/ebozduman/repos","events_url":"https://api.github.com/users/ebozduman/events{/privacy}","received_events_url":"https://api.github.com/users/ebozduman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ebozduman/minio-go","description":"Minio Go Library for Amazon S3 compatible cloud storage","fork":true,"url":"https://api.github.com/repos/ebozduman/minio-go","forks_url":"https://api.github.com/repos/ebozduman/minio-go/forks","keys_url":"https://api.github.com/repos/ebozduman/minio-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebozduman/minio-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebozduman/minio-go/teams","hooks_url":"https://api.github.com/repos/ebozduman/minio-go/hooks","issue_events_url":"https://api.github.com/repos/ebozduman/minio-go/issues/events{/number}","events_url":"https://api.github.com/repos/ebozduman/minio-go/events","assignees_url":"https://api.github.com/repos/ebozduman/minio-go/assignees{/user}","branches_url":"https://api.github.com/repos/ebozduman/minio-go/branches{/branch}","tags_url":"https://api.github.com/repos/ebozduman/minio-go/tags","blobs_url":"https://api.github.com/repos/ebozduman/minio-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebozduman/minio-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebozduman/minio-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebozduman/minio-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebozduman/minio-go/statuses/{sha}","languages_url":"https://api.github.com/repos/ebozduman/minio-go/languages","stargazers_url":"https://api.github.com/repos/ebozduman/minio-go/stargazers","contributors_url":"https://api.github.com/repos/ebozduman/minio-go/contributors","subscribers_url":"https://api.github.com/repos/ebozduman/minio-go/subscribers","subscription_url":"https://api.github.com/repos/ebozduman/minio-go/subscription","commits_url":"https://api.github.com/repos/ebozduman/minio-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebozduman/minio-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebozduman/minio-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebozduman/minio-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebozduman/minio-go/contents/{+path}","compare_url":"https://api.github.com/repos/ebozduman/minio-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebozduman/minio-go/merges","archive_url":"https://api.github.com/repos/ebozduman/minio-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebozduman/minio-go/downloads","issues_url":"https://api.github.com/repos/ebozduman/minio-go/issues{/number}","pulls_url":"https://api.github.com/repos/ebozduman/minio-go/pulls{/number}","milestones_url":"https://api.github.com/repos/ebozduman/minio-go/milestones{/number}","notifications_url":"https://api.github.com/repos/ebozduman/minio-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebozduman/minio-go/labels{/name}","releases_url":"https://api.github.com/repos/ebozduman/minio-go/releases{/id}","deployments_url":"https://api.github.com/repos/ebozduman/minio-go/deployments","created_at":"2017-09-21T00:14:21Z","updated_at":"2017-09-21T00:14:23Z","pushed_at":"2017-11-10T19:43:43Z","git_url":"git://github.com/ebozduman/minio-go.git","ssh_url":"git@github.com:ebozduman/minio-go.git","clone_url":"https://github.com/ebozduman/minio-go.git","svn_url":"https://github.com/ebozduman/minio-go","homepage":"http://minio.io/downloads/#minio-sdk","size":4491,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"91b19873dc91d7b785ce896f7e42d5c8f075ec9d","user":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":34933072,"name":"minio-go","full_name":"minio/minio-go","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio-go","description":"Minio Client SDK for Go","fork":false,"url":"https://api.github.com/repos/minio/minio-go","forks_url":"https://api.github.com/repos/minio/minio-go/forks","keys_url":"https://api.github.com/repos/minio/minio-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio-go/teams","hooks_url":"https://api.github.com/repos/minio/minio-go/hooks","issue_events_url":"https://api.github.com/repos/minio/minio-go/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio-go/events","assignees_url":"https://api.github.com/repos/minio/minio-go/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio-go/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio-go/tags","blobs_url":"https://api.github.com/repos/minio/minio-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio-go/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio-go/languages","stargazers_url":"https://api.github.com/repos/minio/minio-go/stargazers","contributors_url":"https://api.github.com/repos/minio/minio-go/contributors","subscribers_url":"https://api.github.com/repos/minio/minio-go/subscribers","subscription_url":"https://api.github.com/repos/minio/minio-go/subscription","commits_url":"https://api.github.com/repos/minio/minio-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio-go/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio-go/merges","archive_url":"https://api.github.com/repos/minio/minio-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio-go/downloads","issues_url":"https://api.github.com/repos/minio/minio-go/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio-go/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio-go/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio-go/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio-go/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio-go/deployments","created_at":"2015-05-02T02:36:46Z","updated_at":"2017-11-10T22:14:02Z","pushed_at":"2017-11-15T01:10:33Z","git_url":"git://github.com/minio/minio-go.git","ssh_url":"git@github.com:minio/minio-go.git","clone_url":"https://github.com/minio/minio-go.git","svn_url":"https://github.com/minio/minio-go","homepage":"https://minio.io/downloads.html#download-sdk-go","size":4492,"stargazers_count":382,"watchers_count":382,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"archived":false,"open_issues_count":14,"forks":121,"open_issues":14,"watchers":382,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio-go/pulls/865"},"html":{"href":"https://github.com/minio/minio-go/pull/865"},"issue":{"href":"https://api.github.com/repos/minio/minio-go/issues/865"},"comments":{"href":"https://api.github.com/repos/minio/minio-go/issues/865/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio-go/pulls/865/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio-go/pulls/865/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio-go/statuses/7088ee59656c81cc00a26e7a3da9d867e6038692"}},"author_association":"NONE"}}
{"actor":{"display_login":"ebozduman"}}