{"action":"created","issue":{"url":"https://api.github.com/repos/hardbyte/python-can/issues/140","repository_url":"https://api.github.com/repos/hardbyte/python-can","labels_url":"https://api.github.com/repos/hardbyte/python-can/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/hardbyte/python-can/issues/140/comments","events_url":"https://api.github.com/repos/hardbyte/python-can/issues/140/events","html_url":"https://github.com/hardbyte/python-can/pull/140","id":205851667,"number":140,"title":"Fix listener test","user":{"login":"hardbyte","id":855189,"avatar_url":"https://avatars.githubusercontent.com/u/855189?v=3","gravatar_id":"","url":"https://api.github.com/users/hardbyte","html_url":"https://github.com/hardbyte","followers_url":"https://api.github.com/users/hardbyte/followers","following_url":"https://api.github.com/users/hardbyte/following{/other_user}","gists_url":"https://api.github.com/users/hardbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/hardbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardbyte/subscriptions","organizations_url":"https://api.github.com/users/hardbyte/orgs","repos_url":"https://api.github.com/users/hardbyte/repos","events_url":"https://api.github.com/users/hardbyte/events{/privacy}","received_events_url":"https://api.github.com/users/hardbyte/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-02-07T10:52:08Z","updated_at":"2017-02-08T22:19:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hardbyte/python-can/pulls/140","html_url":"https://github.com/hardbyte/python-can/pull/140","diff_url":"https://github.com/hardbyte/python-can/pull/140.diff","patch_url":"https://github.com/hardbyte/python-can/pull/140.patch"},"body":"Instead of waiting an arbitrary amount of time, actually use the blocking queue.get timeout that we are waiting for."},"comment":{"url":"https://api.github.com/repos/hardbyte/python-can/issues/comments/278480468","html_url":"https://github.com/hardbyte/python-can/pull/140#issuecomment-278480468","issue_url":"https://api.github.com/repos/hardbyte/python-can/issues/140","id":278480468,"user":{"login":"hardbyte","id":855189,"avatar_url":"https://avatars.githubusercontent.com/u/855189?v=3","gravatar_id":"","url":"https://api.github.com/users/hardbyte","html_url":"https://github.com/hardbyte","followers_url":"https://api.github.com/users/hardbyte/followers","following_url":"https://api.github.com/users/hardbyte/following{/other_user}","gists_url":"https://api.github.com/users/hardbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/hardbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardbyte/subscriptions","organizations_url":"https://api.github.com/users/hardbyte/orgs","repos_url":"https://api.github.com/users/hardbyte/repos","events_url":"https://api.github.com/users/hardbyte/events{/privacy}","received_events_url":"https://api.github.com/users/hardbyte/received_events","type":"User","site_admin":false},"created_at":"2017-02-08T22:19:07Z","updated_at":"2017-02-08T22:19:07Z","body":"Thanks for the clarification. I'm on board - this has issues I didn't notice.\r\n\r\nMy biggest concern is your second point. That second blocking `get_message` has to be the last thing in the inner loop to avoid receiving a message that it would drop.\r\n\r\nThe other points regarding shutdown behavior I'd like to think on a bit longer. I'm not convinced there is a problem with the current approach - and I don't want to introduce an issue where we continue receiving and writing messages after we've been explicitly told to stop.\r\n"}}
{"actor":{"display_login":"hardbyte"}}