{"action":"created","comment":{"url":"https://api.github.com/repos/artsy/reaction/pulls/comments/149802524","pull_request_review_id":75256276,"id":149802524,"diff_hunk":"@@ -60,12 +76,22 @@ class VideoComponent extends React.Component<VideoProps, VideoState> {\n         hidden: true\n       }\n     }\n+    this.playVideo = this.playVideo.bind(this)\n+ \n+  }\n \n+  trackVideoClick() {\n+    const trackParams = {\n+      action: \"Click\",\n+      label: \"Play video\",\n+    }\n+    this.props.tracking.trackEvent(trackParams)\n   }\n \n-  playVideo = () => {\n+  playVideo() {","path":"src/Components/Publishing/Sections/Video.tsx","position":null,"original_position":60,"commit_id":"f1447d90ce9649a80ff2685c41f64d6e4861cbb6","original_commit_id":"baba14fb40b902f000d946930734d04ba5d39550","user":{"login":"craigspaeth","id":555859,"avatar_url":"https://avatars1.githubusercontent.com/u/555859?v=4","gravatar_id":"","url":"https://api.github.com/users/craigspaeth","html_url":"https://github.com/craigspaeth","followers_url":"https://api.github.com/users/craigspaeth/followers","following_url":"https://api.github.com/users/craigspaeth/following{/other_user}","gists_url":"https://api.github.com/users/craigspaeth/gists{/gist_id}","starred_url":"https://api.github.com/users/craigspaeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigspaeth/subscriptions","organizations_url":"https://api.github.com/users/craigspaeth/orgs","repos_url":"https://api.github.com/users/craigspaeth/repos","events_url":"https://api.github.com/users/craigspaeth/events{/privacy}","received_events_url":"https://api.github.com/users/craigspaeth/received_events","type":"User","site_admin":false},"body":"Seeing as the data is static here, this is probably better served as a decorator...\r\n\r\n````javascript\r\n@track({ action: \"Click\", label: \"Play video\" })\r\nplayVideo() {\r\n  ...\r\n}\r\n````\r\n\r\nthat's what makes it \"declarative\" as the lib authors say 🤷‍♂️ ","created_at":"2017-11-08T21:31:23Z","updated_at":"2017-11-08T21:32:27Z","html_url":"https://github.com/artsy/reaction/pull/374#discussion_r149802524","pull_request_url":"https://api.github.com/repos/artsy/reaction/pulls/374","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/artsy/reaction/pulls/comments/149802524"},"html":{"href":"https://github.com/artsy/reaction/pull/374#discussion_r149802524"},"pull_request":{"href":"https://api.github.com/repos/artsy/reaction/pulls/374"}}},"pull_request":{"url":"https://api.github.com/repos/artsy/reaction/pulls/374","id":151496609,"html_url":"https://github.com/artsy/reaction/pull/374","diff_url":"https://github.com/artsy/reaction/pull/374.diff","patch_url":"https://github.com/artsy/reaction/pull/374.patch","issue_url":"https://api.github.com/repos/artsy/reaction/issues/374","number":374,"state":"open","locked":false,"title":"@craigspaeth => Video accepts custom tracking params","user":{"login":"eessex","id":1497424,"avatar_url":"https://avatars3.githubusercontent.com/u/1497424?v=4","gravatar_id":"","url":"https://api.github.com/users/eessex","html_url":"https://github.com/eessex","followers_url":"https://api.github.com/users/eessex/followers","following_url":"https://api.github.com/users/eessex/following{/other_user}","gists_url":"https://api.github.com/users/eessex/gists{/gist_id}","starred_url":"https://api.github.com/users/eessex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eessex/subscriptions","organizations_url":"https://api.github.com/users/eessex/orgs","repos_url":"https://api.github.com/users/eessex/repos","events_url":"https://api.github.com/users/eessex/events{/privacy}","received_events_url":"https://api.github.com/users/eessex/received_events","type":"User","site_admin":false},"body":"Pairing w @kanaabe \r\n\r\n- Adds entity_type and enitity_id to Article root tracking event\r\n- Adds event for video play to Video component, accepts custom trackingData as a prop or defaults to Article's track event data.","created_at":"2017-11-08T21:12:08Z","updated_at":"2017-11-08T21:32:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50e23ef524691b41515a33319737d640dfd0c08d","assignee":{"login":"craigspaeth","id":555859,"avatar_url":"https://avatars1.githubusercontent.com/u/555859?v=4","gravatar_id":"","url":"https://api.github.com/users/craigspaeth","html_url":"https://github.com/craigspaeth","followers_url":"https://api.github.com/users/craigspaeth/followers","following_url":"https://api.github.com/users/craigspaeth/following{/other_user}","gists_url":"https://api.github.com/users/craigspaeth/gists{/gist_id}","starred_url":"https://api.github.com/users/craigspaeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigspaeth/subscriptions","organizations_url":"https://api.github.com/users/craigspaeth/orgs","repos_url":"https://api.github.com/users/craigspaeth/repos","events_url":"https://api.github.com/users/craigspaeth/events{/privacy}","received_events_url":"https://api.github.com/users/craigspaeth/received_events","type":"User","site_admin":false},"assignees":[{"login":"craigspaeth","id":555859,"avatar_url":"https://avatars1.githubusercontent.com/u/555859?v=4","gravatar_id":"","url":"https://api.github.com/users/craigspaeth","html_url":"https://github.com/craigspaeth","followers_url":"https://api.github.com/users/craigspaeth/followers","following_url":"https://api.github.com/users/craigspaeth/following{/other_user}","gists_url":"https://api.github.com/users/craigspaeth/gists{/gist_id}","starred_url":"https://api.github.com/users/craigspaeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigspaeth/subscriptions","organizations_url":"https://api.github.com/users/craigspaeth/orgs","repos_url":"https://api.github.com/users/craigspaeth/repos","events_url":"https://api.github.com/users/craigspaeth/events{/privacy}","received_events_url":"https://api.github.com/users/craigspaeth/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/artsy/reaction/pulls/374/commits","review_comments_url":"https://api.github.com/repos/artsy/reaction/pulls/374/comments","review_comment_url":"https://api.github.com/repos/artsy/reaction/pulls/comments{/number}","comments_url":"https://api.github.com/repos/artsy/reaction/issues/374/comments","statuses_url":"https://api.github.com/repos/artsy/reaction/statuses/f1447d90ce9649a80ff2685c41f64d6e4861cbb6","head":{"label":"eessex:gucci-tracking","ref":"gucci-tracking","sha":"f1447d90ce9649a80ff2685c41f64d6e4861cbb6","user":{"login":"eessex","id":1497424,"avatar_url":"https://avatars3.githubusercontent.com/u/1497424?v=4","gravatar_id":"","url":"https://api.github.com/users/eessex","html_url":"https://github.com/eessex","followers_url":"https://api.github.com/users/eessex/followers","following_url":"https://api.github.com/users/eessex/following{/other_user}","gists_url":"https://api.github.com/users/eessex/gists{/gist_id}","starred_url":"https://api.github.com/users/eessex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eessex/subscriptions","organizations_url":"https://api.github.com/users/eessex/orgs","repos_url":"https://api.github.com/users/eessex/repos","events_url":"https://api.github.com/users/eessex/events{/privacy}","received_events_url":"https://api.github.com/users/eessex/received_events","type":"User","site_admin":false},"repo":{"id":94907425,"name":"reaction","full_name":"eessex/reaction","owner":{"login":"eessex","id":1497424,"avatar_url":"https://avatars3.githubusercontent.com/u/1497424?v=4","gravatar_id":"","url":"https://api.github.com/users/eessex","html_url":"https://github.com/eessex","followers_url":"https://api.github.com/users/eessex/followers","following_url":"https://api.github.com/users/eessex/following{/other_user}","gists_url":"https://api.github.com/users/eessex/gists{/gist_id}","starred_url":"https://api.github.com/users/eessex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eessex/subscriptions","organizations_url":"https://api.github.com/users/eessex/orgs","repos_url":"https://api.github.com/users/eessex/repos","events_url":"https://api.github.com/users/eessex/events{/privacy}","received_events_url":"https://api.github.com/users/eessex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eessex/reaction","description":"Force’s React Components","fork":true,"url":"https://api.github.com/repos/eessex/reaction","forks_url":"https://api.github.com/repos/eessex/reaction/forks","keys_url":"https://api.github.com/repos/eessex/reaction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eessex/reaction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eessex/reaction/teams","hooks_url":"https://api.github.com/repos/eessex/reaction/hooks","issue_events_url":"https://api.github.com/repos/eessex/reaction/issues/events{/number}","events_url":"https://api.github.com/repos/eessex/reaction/events","assignees_url":"https://api.github.com/repos/eessex/reaction/assignees{/user}","branches_url":"https://api.github.com/repos/eessex/reaction/branches{/branch}","tags_url":"https://api.github.com/repos/eessex/reaction/tags","blobs_url":"https://api.github.com/repos/eessex/reaction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eessex/reaction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eessex/reaction/git/refs{/sha}","trees_url":"https://api.github.com/repos/eessex/reaction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eessex/reaction/statuses/{sha}","languages_url":"https://api.github.com/repos/eessex/reaction/languages","stargazers_url":"https://api.github.com/repos/eessex/reaction/stargazers","contributors_url":"https://api.github.com/repos/eessex/reaction/contributors","subscribers_url":"https://api.github.com/repos/eessex/reaction/subscribers","subscription_url":"https://api.github.com/repos/eessex/reaction/subscription","commits_url":"https://api.github.com/repos/eessex/reaction/commits{/sha}","git_commits_url":"https://api.github.com/repos/eessex/reaction/git/commits{/sha}","comments_url":"https://api.github.com/repos/eessex/reaction/comments{/number}","issue_comment_url":"https://api.github.com/repos/eessex/reaction/issues/comments{/number}","contents_url":"https://api.github.com/repos/eessex/reaction/contents/{+path}","compare_url":"https://api.github.com/repos/eessex/reaction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eessex/reaction/merges","archive_url":"https://api.github.com/repos/eessex/reaction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eessex/reaction/downloads","issues_url":"https://api.github.com/repos/eessex/reaction/issues{/number}","pulls_url":"https://api.github.com/repos/eessex/reaction/pulls{/number}","milestones_url":"https://api.github.com/repos/eessex/reaction/milestones{/number}","notifications_url":"https://api.github.com/repos/eessex/reaction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eessex/reaction/labels{/name}","releases_url":"https://api.github.com/repos/eessex/reaction/releases{/id}","deployments_url":"https://api.github.com/repos/eessex/reaction/deployments","created_at":"2017-06-20T15:35:46Z","updated_at":"2017-07-20T14:37:32Z","pushed_at":"2017-11-08T21:30:46Z","git_url":"git://github.com/eessex/reaction.git","ssh_url":"git@github.com:eessex/reaction.git","clone_url":"https://github.com/eessex/reaction.git","svn_url":"https://github.com/eessex/reaction","homepage":"https://artsy.github.io/reaction-force","size":8646,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"artsy:master","ref":"master","sha":"0a1641aa9acce9e98151749e11e030d1f28b5a3c","user":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"repo":{"id":81253735,"name":"reaction","full_name":"artsy/reaction","owner":{"login":"artsy","id":546231,"avatar_url":"https://avatars3.githubusercontent.com/u/546231?v=4","gravatar_id":"","url":"https://api.github.com/users/artsy","html_url":"https://github.com/artsy","followers_url":"https://api.github.com/users/artsy/followers","following_url":"https://api.github.com/users/artsy/following{/other_user}","gists_url":"https://api.github.com/users/artsy/gists{/gist_id}","starred_url":"https://api.github.com/users/artsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artsy/subscriptions","organizations_url":"https://api.github.com/users/artsy/orgs","repos_url":"https://api.github.com/users/artsy/repos","events_url":"https://api.github.com/users/artsy/events{/privacy}","received_events_url":"https://api.github.com/users/artsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artsy/reaction","description":"Artsy’s React Components","fork":false,"url":"https://api.github.com/repos/artsy/reaction","forks_url":"https://api.github.com/repos/artsy/reaction/forks","keys_url":"https://api.github.com/repos/artsy/reaction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artsy/reaction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artsy/reaction/teams","hooks_url":"https://api.github.com/repos/artsy/reaction/hooks","issue_events_url":"https://api.github.com/repos/artsy/reaction/issues/events{/number}","events_url":"https://api.github.com/repos/artsy/reaction/events","assignees_url":"https://api.github.com/repos/artsy/reaction/assignees{/user}","branches_url":"https://api.github.com/repos/artsy/reaction/branches{/branch}","tags_url":"https://api.github.com/repos/artsy/reaction/tags","blobs_url":"https://api.github.com/repos/artsy/reaction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artsy/reaction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artsy/reaction/git/refs{/sha}","trees_url":"https://api.github.com/repos/artsy/reaction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artsy/reaction/statuses/{sha}","languages_url":"https://api.github.com/repos/artsy/reaction/languages","stargazers_url":"https://api.github.com/repos/artsy/reaction/stargazers","contributors_url":"https://api.github.com/repos/artsy/reaction/contributors","subscribers_url":"https://api.github.com/repos/artsy/reaction/subscribers","subscription_url":"https://api.github.com/repos/artsy/reaction/subscription","commits_url":"https://api.github.com/repos/artsy/reaction/commits{/sha}","git_commits_url":"https://api.github.com/repos/artsy/reaction/git/commits{/sha}","comments_url":"https://api.github.com/repos/artsy/reaction/comments{/number}","issue_comment_url":"https://api.github.com/repos/artsy/reaction/issues/comments{/number}","contents_url":"https://api.github.com/repos/artsy/reaction/contents/{+path}","compare_url":"https://api.github.com/repos/artsy/reaction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artsy/reaction/merges","archive_url":"https://api.github.com/repos/artsy/reaction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artsy/reaction/downloads","issues_url":"https://api.github.com/repos/artsy/reaction/issues{/number}","pulls_url":"https://api.github.com/repos/artsy/reaction/pulls{/number}","milestones_url":"https://api.github.com/repos/artsy/reaction/milestones{/number}","notifications_url":"https://api.github.com/repos/artsy/reaction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artsy/reaction/labels{/name}","releases_url":"https://api.github.com/repos/artsy/reaction/releases{/id}","deployments_url":"https://api.github.com/repos/artsy/reaction/deployments","created_at":"2017-02-07T21:00:51Z","updated_at":"2017-11-02T21:01:08Z","pushed_at":"2017-11-08T21:30:47Z","git_url":"git://github.com/artsy/reaction.git","ssh_url":"git@github.com:artsy/reaction.git","clone_url":"https://github.com/artsy/reaction.git","svn_url":"https://github.com/artsy/reaction","homepage":"https://artsy.github.io/reaction","size":8107,"stargazers_count":31,"watchers_count":31,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":16,"forks":13,"open_issues":16,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/artsy/reaction/pulls/374"},"html":{"href":"https://github.com/artsy/reaction/pull/374"},"issue":{"href":"https://api.github.com/repos/artsy/reaction/issues/374"},"comments":{"href":"https://api.github.com/repos/artsy/reaction/issues/374/comments"},"review_comments":{"href":"https://api.github.com/repos/artsy/reaction/pulls/374/comments"},"review_comment":{"href":"https://api.github.com/repos/artsy/reaction/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/artsy/reaction/pulls/374/commits"},"statuses":{"href":"https://api.github.com/repos/artsy/reaction/statuses/f1447d90ce9649a80ff2685c41f64d6e4861cbb6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"craigspaeth"}}