{"action":"created","comment":{"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments/110641593","pull_request_review_id":31771371,"id":110641593,"diff_hunk":"@@ -87,6 +87,12 @@ public MockProjectBuilder ProjectBuilder(string name, string filename, ProjectPr\n             return result;\n         }\n \n+        public MockProjectBuilder ProjectBuilder(string name, string filename, string projectId, ProjectProtection protection)\n+        {\n+            var result = new MockProjectBuilder(name, filename, projectId, protection, () => _vbe.Object, this);\n+            return result;","path":"RubberduckTests/Mocks/MockVbeBuilder.cs","position":7,"original_position":7,"commit_id":"860a62d2dc6674360d80983ef975742961741470","original_commit_id":"860a62d2dc6674360d80983ef975742961741470","user":{"login":"Vogel612","id":7288995,"avatar_url":"https://avatars0.githubusercontent.com/u/7288995?v=3","gravatar_id":"","url":"https://api.github.com/users/Vogel612","html_url":"https://github.com/Vogel612","followers_url":"https://api.github.com/users/Vogel612/followers","following_url":"https://api.github.com/users/Vogel612/following{/other_user}","gists_url":"https://api.github.com/users/Vogel612/gists{/gist_id}","starred_url":"https://api.github.com/users/Vogel612/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vogel612/subscriptions","organizations_url":"https://api.github.com/users/Vogel612/orgs","repos_url":"https://api.github.com/users/Vogel612/repos","events_url":"https://api.github.com/users/Vogel612/events{/privacy}","received_events_url":"https://api.github.com/users/Vogel612/received_events","type":"User","site_admin":false},"body":"instant return :)","created_at":"2017-04-10T12:29:20Z","updated_at":"2017-04-10T12:29:29Z","html_url":"https://github.com/rubberduck-vba/Rubberduck/pull/2953#discussion_r110641593","pull_request_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/2953","_links":{"self":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments/110641593"},"html":{"href":"https://github.com/rubberduck-vba/Rubberduck/pull/2953#discussion_r110641593"},"pull_request":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/2953"}}},"pull_request":{"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/2953","id":114997483,"html_url":"https://github.com/rubberduck-vba/Rubberduck/pull/2953","diff_url":"https://github.com/rubberduck-vba/Rubberduck/pull/2953.diff","patch_url":"https://github.com/rubberduck-vba/Rubberduck/pull/2953.patch","issue_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/2953","number":2953,"state":"open","locked":false,"title":"Extract class on ParseCoordinator","user":{"login":"MDoerner","id":22868956,"avatar_url":"https://avatars2.githubusercontent.com/u/22868956?v=3","gravatar_id":"","url":"https://api.github.com/users/MDoerner","html_url":"https://github.com/MDoerner","followers_url":"https://api.github.com/users/MDoerner/followers","following_url":"https://api.github.com/users/MDoerner/following{/other_user}","gists_url":"https://api.github.com/users/MDoerner/gists{/gist_id}","starred_url":"https://api.github.com/users/MDoerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDoerner/subscriptions","organizations_url":"https://api.github.com/users/MDoerner/orgs","repos_url":"https://api.github.com/users/MDoerner/repos","events_url":"https://api.github.com/users/MDoerner/events{/privacy}","received_events_url":"https://api.github.com/users/MDoerner/received_events","type":"User","site_admin":false},"body":"The `ParseCoordinator` did know about the details of doing a lot of different things and had the responsibility to do them all. So I went and split it into a bunch of runners and managers. Now, the `ParseCoordinator` only manages what is run on which modules, sets the pre-run parser states and triggers evaluating the overall parser state after the parsing stages.\r\n\r\nEach parsing stage with a concurrent implementation got split into an interface, an abstract base class implementing the interface and containing the base logic of executing the corresponding parsing stage, a concurrent subclass for the production run, and a synchronous subclass for the tests.\r\n\r\nTo simplify the comunication between the `ParseCoordinator`, the runners and managers, and the `RubberduckParserState` I introduced overloads to several methods on the `RubberduckParserState` that directly take a QMN instead of taking an `IVBComponent` and then newing up a QMN from it. \r\n\r\nFor some reason, the changes did not only untangle the `ParseCoordinator`, but also increased the performance. (For my test project, the overall runtime decreased by about 35%.)\r\n\r\nPlease feel free to comment on anything in this PR. I would appreciate it.\r\n\r\nPS:\r\n\r\nShould I replace the traditional guard clauses in the runners with precondition contracts?","created_at":"2017-04-09T19:03:26Z","updated_at":"2017-04-10T12:29:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ece7d357f61a76ddb535074a26fa9b083b04dd36","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/2953/commits","review_comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/2953/comments","review_comment_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/2953/comments","statuses_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/860a62d2dc6674360d80983ef975742961741470","head":{"label":"MDoerner:ExtractClassOnParseCoordinator","ref":"ExtractClassOnParseCoordinator","sha":"860a62d2dc6674360d80983ef975742961741470","user":{"login":"MDoerner","id":22868956,"avatar_url":"https://avatars2.githubusercontent.com/u/22868956?v=3","gravatar_id":"","url":"https://api.github.com/users/MDoerner","html_url":"https://github.com/MDoerner","followers_url":"https://api.github.com/users/MDoerner/followers","following_url":"https://api.github.com/users/MDoerner/following{/other_user}","gists_url":"https://api.github.com/users/MDoerner/gists{/gist_id}","starred_url":"https://api.github.com/users/MDoerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDoerner/subscriptions","organizations_url":"https://api.github.com/users/MDoerner/orgs","repos_url":"https://api.github.com/users/MDoerner/repos","events_url":"https://api.github.com/users/MDoerner/events{/privacy}","received_events_url":"https://api.github.com/users/MDoerner/received_events","type":"User","site_admin":false},"repo":{"id":72988410,"name":"Rubberduck","full_name":"MDoerner/Rubberduck","owner":{"login":"MDoerner","id":22868956,"avatar_url":"https://avatars2.githubusercontent.com/u/22868956?v=3","gravatar_id":"","url":"https://api.github.com/users/MDoerner","html_url":"https://github.com/MDoerner","followers_url":"https://api.github.com/users/MDoerner/followers","following_url":"https://api.github.com/users/MDoerner/following{/other_user}","gists_url":"https://api.github.com/users/MDoerner/gists{/gist_id}","starred_url":"https://api.github.com/users/MDoerner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MDoerner/subscriptions","organizations_url":"https://api.github.com/users/MDoerner/orgs","repos_url":"https://api.github.com/users/MDoerner/repos","events_url":"https://api.github.com/users/MDoerner/events{/privacy}","received_events_url":"https://api.github.com/users/MDoerner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MDoerner/Rubberduck","description":"Every programmer needs a rubberduck. COM add-in for the VBA IDE (VBE).","fork":true,"url":"https://api.github.com/repos/MDoerner/Rubberduck","forks_url":"https://api.github.com/repos/MDoerner/Rubberduck/forks","keys_url":"https://api.github.com/repos/MDoerner/Rubberduck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MDoerner/Rubberduck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MDoerner/Rubberduck/teams","hooks_url":"https://api.github.com/repos/MDoerner/Rubberduck/hooks","issue_events_url":"https://api.github.com/repos/MDoerner/Rubberduck/issues/events{/number}","events_url":"https://api.github.com/repos/MDoerner/Rubberduck/events","assignees_url":"https://api.github.com/repos/MDoerner/Rubberduck/assignees{/user}","branches_url":"https://api.github.com/repos/MDoerner/Rubberduck/branches{/branch}","tags_url":"https://api.github.com/repos/MDoerner/Rubberduck/tags","blobs_url":"https://api.github.com/repos/MDoerner/Rubberduck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MDoerner/Rubberduck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MDoerner/Rubberduck/git/refs{/sha}","trees_url":"https://api.github.com/repos/MDoerner/Rubberduck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MDoerner/Rubberduck/statuses/{sha}","languages_url":"https://api.github.com/repos/MDoerner/Rubberduck/languages","stargazers_url":"https://api.github.com/repos/MDoerner/Rubberduck/stargazers","contributors_url":"https://api.github.com/repos/MDoerner/Rubberduck/contributors","subscribers_url":"https://api.github.com/repos/MDoerner/Rubberduck/subscribers","subscription_url":"https://api.github.com/repos/MDoerner/Rubberduck/subscription","commits_url":"https://api.github.com/repos/MDoerner/Rubberduck/commits{/sha}","git_commits_url":"https://api.github.com/repos/MDoerner/Rubberduck/git/commits{/sha}","comments_url":"https://api.github.com/repos/MDoerner/Rubberduck/comments{/number}","issue_comment_url":"https://api.github.com/repos/MDoerner/Rubberduck/issues/comments{/number}","contents_url":"https://api.github.com/repos/MDoerner/Rubberduck/contents/{+path}","compare_url":"https://api.github.com/repos/MDoerner/Rubberduck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MDoerner/Rubberduck/merges","archive_url":"https://api.github.com/repos/MDoerner/Rubberduck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MDoerner/Rubberduck/downloads","issues_url":"https://api.github.com/repos/MDoerner/Rubberduck/issues{/number}","pulls_url":"https://api.github.com/repos/MDoerner/Rubberduck/pulls{/number}","milestones_url":"https://api.github.com/repos/MDoerner/Rubberduck/milestones{/number}","notifications_url":"https://api.github.com/repos/MDoerner/Rubberduck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MDoerner/Rubberduck/labels{/name}","releases_url":"https://api.github.com/repos/MDoerner/Rubberduck/releases{/id}","deployments_url":"https://api.github.com/repos/MDoerner/Rubberduck/deployments","created_at":"2016-11-06T12:14:03Z","updated_at":"2016-11-06T12:14:07Z","pushed_at":"2017-04-10T02:00:30Z","git_url":"git://github.com/MDoerner/Rubberduck.git","ssh_url":"git@github.com:MDoerner/Rubberduck.git","clone_url":"https://github.com/MDoerner/Rubberduck.git","svn_url":"https://github.com/MDoerner/Rubberduck","homepage":"","size":36107,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"rubberduck-vba:next","ref":"next","sha":"08fcaafd4f0e4a30799ee58e5efdfad0f9d51d3c","user":{"login":"rubberduck-vba","id":12832254,"avatar_url":"https://avatars3.githubusercontent.com/u/12832254?v=3","gravatar_id":"","url":"https://api.github.com/users/rubberduck-vba","html_url":"https://github.com/rubberduck-vba","followers_url":"https://api.github.com/users/rubberduck-vba/followers","following_url":"https://api.github.com/users/rubberduck-vba/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck-vba/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck-vba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck-vba/subscriptions","organizations_url":"https://api.github.com/users/rubberduck-vba/orgs","repos_url":"https://api.github.com/users/rubberduck-vba/repos","events_url":"https://api.github.com/users/rubberduck-vba/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck-vba/received_events","type":"Organization","site_admin":false},"repo":{"id":25800128,"name":"Rubberduck","full_name":"rubberduck-vba/Rubberduck","owner":{"login":"rubberduck-vba","id":12832254,"avatar_url":"https://avatars3.githubusercontent.com/u/12832254?v=3","gravatar_id":"","url":"https://api.github.com/users/rubberduck-vba","html_url":"https://github.com/rubberduck-vba","followers_url":"https://api.github.com/users/rubberduck-vba/followers","following_url":"https://api.github.com/users/rubberduck-vba/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck-vba/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck-vba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck-vba/subscriptions","organizations_url":"https://api.github.com/users/rubberduck-vba/orgs","repos_url":"https://api.github.com/users/rubberduck-vba/repos","events_url":"https://api.github.com/users/rubberduck-vba/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck-vba/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubberduck-vba/Rubberduck","description":"Every programmer needs a rubberduck. COM add-in for the VBA IDE (VBE).","fork":false,"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck","forks_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/forks","keys_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/teams","hooks_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/hooks","issue_events_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/events{/number}","events_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/events","assignees_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/assignees{/user}","branches_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/branches{/branch}","tags_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/tags","blobs_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/{sha}","languages_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/languages","stargazers_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/stargazers","contributors_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/contributors","subscribers_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/subscribers","subscription_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/subscription","commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/contents/{+path}","compare_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/merges","archive_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/downloads","issues_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues{/number}","pulls_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls{/number}","milestones_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/milestones{/number}","notifications_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/labels{/name}","releases_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/releases{/id}","deployments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/deployments","created_at":"2014-10-27T02:35:11Z","updated_at":"2017-04-10T03:45:39Z","pushed_at":"2017-04-10T04:25:50Z","git_url":"git://github.com/rubberduck-vba/Rubberduck.git","ssh_url":"git@github.com:rubberduck-vba/Rubberduck.git","clone_url":"https://github.com/rubberduck-vba/Rubberduck.git","svn_url":"https://github.com/rubberduck-vba/Rubberduck","homepage":"","size":36037,"stargazers_count":341,"watchers_count":341,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":98,"mirror_url":null,"open_issues_count":430,"forks":98,"open_issues":430,"watchers":341,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/2953"},"html":{"href":"https://github.com/rubberduck-vba/Rubberduck/pull/2953"},"issue":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/2953"},"comments":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/2953/comments"},"review_comments":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/2953/comments"},"review_comment":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/2953/commits"},"statuses":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/860a62d2dc6674360d80983ef975742961741470"}}}}
{"actor":{"display_login":"Vogel612"}}