{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/115330340","pull_request_review_id":36860548,"id":115330340,"diff_hunk":"@@ -147,6 +149,9 @@ public boolean onTouch(View v, MotionEvent event)\n \t\t\t\t{\n \t\t\t\t\tNativeLibrary.onGamePadEvent(NativeLibrary.TouchScreenDevice, button.getId(), ButtonState.RELEASED);\n \t\t\t\t}\n+\n+\t\t\t\tbutton.setPressedState(false);\n+\t\t\t\tinvalidate();","path":"Source/Android/app/src/main/java/org/dolphinemu/dolphinemu/overlay/InputOverlay.java","position":16,"original_position":16,"commit_id":"72e424b507008b0ac02792c7b2896a05a6e8b076","original_commit_id":"72e424b507008b0ac02792c7b2896a05a6e8b076","user":{"login":"mahdihijazi","id":836892,"avatar_url":"https://avatars1.githubusercontent.com/u/836892?v=3","gravatar_id":"","url":"https://api.github.com/users/mahdihijazi","html_url":"https://github.com/mahdihijazi","followers_url":"https://api.github.com/users/mahdihijazi/followers","following_url":"https://api.github.com/users/mahdihijazi/following{/other_user}","gists_url":"https://api.github.com/users/mahdihijazi/gists{/gist_id}","starred_url":"https://api.github.com/users/mahdihijazi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahdihijazi/subscriptions","organizations_url":"https://api.github.com/users/mahdihijazi/orgs","repos_url":"https://api.github.com/users/mahdihijazi/repos","events_url":"https://api.github.com/users/mahdihijazi/events{/privacy}","received_events_url":"https://api.github.com/users/mahdihijazi/received_events","type":"User","site_admin":false},"body":"if user press down a button and start moving outside the boundaries of that button and release the touch, that button will stuck at pressed state unless the user pressed it again. This will release all pressed button regardless of where the release even happened.","created_at":"2017-05-08T19:18:38Z","updated_at":"2017-05-08T19:18:39Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/5393#discussion_r115330340","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5393","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/115330340"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/5393#discussion_r115330340"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5393"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5393","id":119348400,"html_url":"https://github.com/dolphin-emu/dolphin/pull/5393","diff_url":"https://github.com/dolphin-emu/dolphin/pull/5393.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/5393.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5393","number":5393,"state":"open","locked":false,"title":"Android: Add pressed state to the on-screen controllers","user":{"login":"mahdihijazi","id":836892,"avatar_url":"https://avatars1.githubusercontent.com/u/836892?v=3","gravatar_id":"","url":"https://api.github.com/users/mahdihijazi","html_url":"https://github.com/mahdihijazi","followers_url":"https://api.github.com/users/mahdihijazi/followers","following_url":"https://api.github.com/users/mahdihijazi/following{/other_user}","gists_url":"https://api.github.com/users/mahdihijazi/gists{/gist_id}","starred_url":"https://api.github.com/users/mahdihijazi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahdihijazi/subscriptions","organizations_url":"https://api.github.com/users/mahdihijazi/orgs","repos_url":"https://api.github.com/users/mahdihijazi/repos","events_url":"https://api.github.com/users/mahdihijazi/events{/privacy}","received_events_url":"https://api.github.com/users/mahdihijazi/received_events","type":"User","site_admin":false},"body":"Now the buttons will be shown in different color to indicate a press event\r\n\r\nDpad and Joystick are missing from this PR , since the resources are not\r\nthere yet.","created_at":"2017-05-07T18:11:12Z","updated_at":"2017-05-08T19:18:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81fba2ba89af168961cb2b1be22b999597a6d6a2","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5393/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5393/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5393/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/72e424b507008b0ac02792c7b2896a05a6e8b076","head":{"label":"mahdihijazi:controls_states","ref":"controls_states","sha":"72e424b507008b0ac02792c7b2896a05a6e8b076","user":{"login":"mahdihijazi","id":836892,"avatar_url":"https://avatars1.githubusercontent.com/u/836892?v=3","gravatar_id":"","url":"https://api.github.com/users/mahdihijazi","html_url":"https://github.com/mahdihijazi","followers_url":"https://api.github.com/users/mahdihijazi/followers","following_url":"https://api.github.com/users/mahdihijazi/following{/other_user}","gists_url":"https://api.github.com/users/mahdihijazi/gists{/gist_id}","starred_url":"https://api.github.com/users/mahdihijazi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahdihijazi/subscriptions","organizations_url":"https://api.github.com/users/mahdihijazi/orgs","repos_url":"https://api.github.com/users/mahdihijazi/repos","events_url":"https://api.github.com/users/mahdihijazi/events{/privacy}","received_events_url":"https://api.github.com/users/mahdihijazi/received_events","type":"User","site_admin":false},"repo":{"id":85333613,"name":"dolphin","full_name":"mahdihijazi/dolphin","owner":{"login":"mahdihijazi","id":836892,"avatar_url":"https://avatars1.githubusercontent.com/u/836892?v=3","gravatar_id":"","url":"https://api.github.com/users/mahdihijazi","html_url":"https://github.com/mahdihijazi","followers_url":"https://api.github.com/users/mahdihijazi/followers","following_url":"https://api.github.com/users/mahdihijazi/following{/other_user}","gists_url":"https://api.github.com/users/mahdihijazi/gists{/gist_id}","starred_url":"https://api.github.com/users/mahdihijazi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahdihijazi/subscriptions","organizations_url":"https://api.github.com/users/mahdihijazi/orgs","repos_url":"https://api.github.com/users/mahdihijazi/repos","events_url":"https://api.github.com/users/mahdihijazi/events{/privacy}","received_events_url":"https://api.github.com/users/mahdihijazi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mahdihijazi/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/mahdihijazi/dolphin","forks_url":"https://api.github.com/repos/mahdihijazi/dolphin/forks","keys_url":"https://api.github.com/repos/mahdihijazi/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mahdihijazi/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mahdihijazi/dolphin/teams","hooks_url":"https://api.github.com/repos/mahdihijazi/dolphin/hooks","issue_events_url":"https://api.github.com/repos/mahdihijazi/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/mahdihijazi/dolphin/events","assignees_url":"https://api.github.com/repos/mahdihijazi/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/mahdihijazi/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/mahdihijazi/dolphin/tags","blobs_url":"https://api.github.com/repos/mahdihijazi/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mahdihijazi/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mahdihijazi/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mahdihijazi/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mahdihijazi/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/mahdihijazi/dolphin/languages","stargazers_url":"https://api.github.com/repos/mahdihijazi/dolphin/stargazers","contributors_url":"https://api.github.com/repos/mahdihijazi/dolphin/contributors","subscribers_url":"https://api.github.com/repos/mahdihijazi/dolphin/subscribers","subscription_url":"https://api.github.com/repos/mahdihijazi/dolphin/subscription","commits_url":"https://api.github.com/repos/mahdihijazi/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mahdihijazi/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mahdihijazi/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mahdihijazi/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mahdihijazi/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/mahdihijazi/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mahdihijazi/dolphin/merges","archive_url":"https://api.github.com/repos/mahdihijazi/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mahdihijazi/dolphin/downloads","issues_url":"https://api.github.com/repos/mahdihijazi/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/mahdihijazi/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/mahdihijazi/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/mahdihijazi/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mahdihijazi/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/mahdihijazi/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/mahdihijazi/dolphin/deployments","created_at":"2017-03-17T16:38:19Z","updated_at":"2017-03-17T16:38:46Z","pushed_at":"2017-05-07T18:10:36Z","git_url":"git://github.com/mahdihijazi/dolphin.git","ssh_url":"git@github.com:mahdihijazi/dolphin.git","clone_url":"https://github.com/mahdihijazi/dolphin.git","svn_url":"https://github.com/mahdihijazi/dolphin","homepage":"https://dolphin-emu.org/","size":298529,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"59dab8b15c1315a981ff0be33dbd1e570b3c1885","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars1.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars1.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2017-05-08T05:54:16Z","pushed_at":"2017-05-08T18:25:58Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":336020,"stargazers_count":3296,"watchers_count":3296,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":861,"mirror_url":null,"open_issues_count":156,"forks":861,"open_issues":156,"watchers":3296,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5393"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/5393"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5393"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5393/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5393/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5393/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/72e424b507008b0ac02792c7b2896a05a6e8b076"}}}}
{"actor":{"display_login":"mahdihijazi"}}