{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/darrynten/sage-one-php/pulls/22","id":129654548,"html_url":"https://github.com/darrynten/sage-one-php/pull/22","diff_url":"https://github.com/darrynten/sage-one-php/pull/22.diff","patch_url":"https://github.com/darrynten/sage-one-php/pull/22.patch","issue_url":"https://api.github.com/repos/darrynten/sage-one-php/issues/22","number":22,"state":"closed","locked":false,"title":"Moved validation to helper class","user":{"login":"darrynten","id":3657251,"avatar_url":"https://avatars2.githubusercontent.com/u/3657251?v=3","gravatar_id":"","url":"https://api.github.com/users/darrynten","html_url":"https://github.com/darrynten","followers_url":"https://api.github.com/users/darrynten/followers","following_url":"https://api.github.com/users/darrynten/following{/other_user}","gists_url":"https://api.github.com/users/darrynten/gists{/gist_id}","starred_url":"https://api.github.com/users/darrynten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrynten/subscriptions","organizations_url":"https://api.github.com/users/darrynten/orgs","repos_url":"https://api.github.com/users/darrynten/repos","events_url":"https://api.github.com/users/darrynten/events{/privacy}","received_events_url":"https://api.github.com/users/darrynten/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\n| Q                 | A\r\n| ----------------- | ---\r\n| Bugfix?           | no\r\n| New feature?      | no\r\n| Breaking Changes? | no\r\n| Refactor?  | yes\r\n| Fixed issues      | #20 \r\n\r\n## The problem\r\n\r\nThe BaseClass was getting too big\r\n\r\n## How I resolved it\r\n\r\n- Moved validation utility checks to their own helper class, and call them statically\r\n- Added `ValidationException` class\r\n- Moved validation messages into own array\r\n- Updated tests\r\n\r\n","created_at":"2017-07-10T11:13:10Z","updated_at":"2017-07-10T11:15:47Z","closed_at":"2017-07-10T11:15:47Z","merged_at":"2017-07-10T11:15:47Z","merge_commit_sha":"65c2de083e13c63fe151a3f5e785d3cf61ddaaa3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"make-it-git","id":28646072,"avatar_url":"https://avatars1.githubusercontent.com/u/28646072?v=3","gravatar_id":"","url":"https://api.github.com/users/make-it-git","html_url":"https://github.com/make-it-git","followers_url":"https://api.github.com/users/make-it-git/followers","following_url":"https://api.github.com/users/make-it-git/following{/other_user}","gists_url":"https://api.github.com/users/make-it-git/gists{/gist_id}","starred_url":"https://api.github.com/users/make-it-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/make-it-git/subscriptions","organizations_url":"https://api.github.com/users/make-it-git/orgs","repos_url":"https://api.github.com/users/make-it-git/repos","events_url":"https://api.github.com/users/make-it-git/events{/privacy}","received_events_url":"https://api.github.com/users/make-it-git/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/darrynten/sage-one-php/pulls/22/commits","review_comments_url":"https://api.github.com/repos/darrynten/sage-one-php/pulls/22/comments","review_comment_url":"https://api.github.com/repos/darrynten/sage-one-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/darrynten/sage-one-php/issues/22/comments","statuses_url":"https://api.github.com/repos/darrynten/sage-one-php/statuses/9c6079e7fc4773aebb6619fc63ba0161ed8b9d92","head":{"label":"darrynten:ref-base-model","ref":"ref-base-model","sha":"9c6079e7fc4773aebb6619fc63ba0161ed8b9d92","user":{"login":"darrynten","id":3657251,"avatar_url":"https://avatars2.githubusercontent.com/u/3657251?v=3","gravatar_id":"","url":"https://api.github.com/users/darrynten","html_url":"https://github.com/darrynten","followers_url":"https://api.github.com/users/darrynten/followers","following_url":"https://api.github.com/users/darrynten/following{/other_user}","gists_url":"https://api.github.com/users/darrynten/gists{/gist_id}","starred_url":"https://api.github.com/users/darrynten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrynten/subscriptions","organizations_url":"https://api.github.com/users/darrynten/orgs","repos_url":"https://api.github.com/users/darrynten/repos","events_url":"https://api.github.com/users/darrynten/events{/privacy}","received_events_url":"https://api.github.com/users/darrynten/received_events","type":"User","site_admin":false},"repo":{"id":95722049,"name":"sage-one-php","full_name":"darrynten/sage-one-php","owner":{"login":"darrynten","id":3657251,"avatar_url":"https://avatars2.githubusercontent.com/u/3657251?v=3","gravatar_id":"","url":"https://api.github.com/users/darrynten","html_url":"https://github.com/darrynten","followers_url":"https://api.github.com/users/darrynten/followers","following_url":"https://api.github.com/users/darrynten/following{/other_user}","gists_url":"https://api.github.com/users/darrynten/gists{/gist_id}","starred_url":"https://api.github.com/users/darrynten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrynten/subscriptions","organizations_url":"https://api.github.com/users/darrynten/orgs","repos_url":"https://api.github.com/users/darrynten/repos","events_url":"https://api.github.com/users/darrynten/events{/privacy}","received_events_url":"https://api.github.com/users/darrynten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darrynten/sage-one-php","description":"SageOne PHP Client","fork":false,"url":"https://api.github.com/repos/darrynten/sage-one-php","forks_url":"https://api.github.com/repos/darrynten/sage-one-php/forks","keys_url":"https://api.github.com/repos/darrynten/sage-one-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darrynten/sage-one-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darrynten/sage-one-php/teams","hooks_url":"https://api.github.com/repos/darrynten/sage-one-php/hooks","issue_events_url":"https://api.github.com/repos/darrynten/sage-one-php/issues/events{/number}","events_url":"https://api.github.com/repos/darrynten/sage-one-php/events","assignees_url":"https://api.github.com/repos/darrynten/sage-one-php/assignees{/user}","branches_url":"https://api.github.com/repos/darrynten/sage-one-php/branches{/branch}","tags_url":"https://api.github.com/repos/darrynten/sage-one-php/tags","blobs_url":"https://api.github.com/repos/darrynten/sage-one-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darrynten/sage-one-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darrynten/sage-one-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/darrynten/sage-one-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darrynten/sage-one-php/statuses/{sha}","languages_url":"https://api.github.com/repos/darrynten/sage-one-php/languages","stargazers_url":"https://api.github.com/repos/darrynten/sage-one-php/stargazers","contributors_url":"https://api.github.com/repos/darrynten/sage-one-php/contributors","subscribers_url":"https://api.github.com/repos/darrynten/sage-one-php/subscribers","subscription_url":"https://api.github.com/repos/darrynten/sage-one-php/subscription","commits_url":"https://api.github.com/repos/darrynten/sage-one-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/darrynten/sage-one-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/darrynten/sage-one-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/darrynten/sage-one-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/darrynten/sage-one-php/contents/{+path}","compare_url":"https://api.github.com/repos/darrynten/sage-one-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darrynten/sage-one-php/merges","archive_url":"https://api.github.com/repos/darrynten/sage-one-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darrynten/sage-one-php/downloads","issues_url":"https://api.github.com/repos/darrynten/sage-one-php/issues{/number}","pulls_url":"https://api.github.com/repos/darrynten/sage-one-php/pulls{/number}","milestones_url":"https://api.github.com/repos/darrynten/sage-one-php/milestones{/number}","notifications_url":"https://api.github.com/repos/darrynten/sage-one-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darrynten/sage-one-php/labels{/name}","releases_url":"https://api.github.com/repos/darrynten/sage-one-php/releases{/id}","deployments_url":"https://api.github.com/repos/darrynten/sage-one-php/deployments","created_at":"2017-06-29T00:14:15Z","updated_at":"2017-07-07T14:31:30Z","pushed_at":"2017-07-10T11:15:47Z","git_url":"git://github.com/darrynten/sage-one-php.git","ssh_url":"git@github.com:darrynten/sage-one-php.git","clone_url":"https://github.com/darrynten/sage-one-php.git","svn_url":"https://github.com/darrynten/sage-one-php","homepage":null,"size":155,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":2,"default_branch":"dev"}},"base":{"label":"darrynten:remove-field-duplicates","ref":"remove-field-duplicates","sha":"fea3887fd79d15613eb538de88135ec0935aca9a","user":{"login":"darrynten","id":3657251,"avatar_url":"https://avatars2.githubusercontent.com/u/3657251?v=3","gravatar_id":"","url":"https://api.github.com/users/darrynten","html_url":"https://github.com/darrynten","followers_url":"https://api.github.com/users/darrynten/followers","following_url":"https://api.github.com/users/darrynten/following{/other_user}","gists_url":"https://api.github.com/users/darrynten/gists{/gist_id}","starred_url":"https://api.github.com/users/darrynten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrynten/subscriptions","organizations_url":"https://api.github.com/users/darrynten/orgs","repos_url":"https://api.github.com/users/darrynten/repos","events_url":"https://api.github.com/users/darrynten/events{/privacy}","received_events_url":"https://api.github.com/users/darrynten/received_events","type":"User","site_admin":false},"repo":{"id":95722049,"name":"sage-one-php","full_name":"darrynten/sage-one-php","owner":{"login":"darrynten","id":3657251,"avatar_url":"https://avatars2.githubusercontent.com/u/3657251?v=3","gravatar_id":"","url":"https://api.github.com/users/darrynten","html_url":"https://github.com/darrynten","followers_url":"https://api.github.com/users/darrynten/followers","following_url":"https://api.github.com/users/darrynten/following{/other_user}","gists_url":"https://api.github.com/users/darrynten/gists{/gist_id}","starred_url":"https://api.github.com/users/darrynten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrynten/subscriptions","organizations_url":"https://api.github.com/users/darrynten/orgs","repos_url":"https://api.github.com/users/darrynten/repos","events_url":"https://api.github.com/users/darrynten/events{/privacy}","received_events_url":"https://api.github.com/users/darrynten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darrynten/sage-one-php","description":"SageOne PHP Client","fork":false,"url":"https://api.github.com/repos/darrynten/sage-one-php","forks_url":"https://api.github.com/repos/darrynten/sage-one-php/forks","keys_url":"https://api.github.com/repos/darrynten/sage-one-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darrynten/sage-one-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darrynten/sage-one-php/teams","hooks_url":"https://api.github.com/repos/darrynten/sage-one-php/hooks","issue_events_url":"https://api.github.com/repos/darrynten/sage-one-php/issues/events{/number}","events_url":"https://api.github.com/repos/darrynten/sage-one-php/events","assignees_url":"https://api.github.com/repos/darrynten/sage-one-php/assignees{/user}","branches_url":"https://api.github.com/repos/darrynten/sage-one-php/branches{/branch}","tags_url":"https://api.github.com/repos/darrynten/sage-one-php/tags","blobs_url":"https://api.github.com/repos/darrynten/sage-one-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darrynten/sage-one-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darrynten/sage-one-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/darrynten/sage-one-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darrynten/sage-one-php/statuses/{sha}","languages_url":"https://api.github.com/repos/darrynten/sage-one-php/languages","stargazers_url":"https://api.github.com/repos/darrynten/sage-one-php/stargazers","contributors_url":"https://api.github.com/repos/darrynten/sage-one-php/contributors","subscribers_url":"https://api.github.com/repos/darrynten/sage-one-php/subscribers","subscription_url":"https://api.github.com/repos/darrynten/sage-one-php/subscription","commits_url":"https://api.github.com/repos/darrynten/sage-one-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/darrynten/sage-one-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/darrynten/sage-one-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/darrynten/sage-one-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/darrynten/sage-one-php/contents/{+path}","compare_url":"https://api.github.com/repos/darrynten/sage-one-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darrynten/sage-one-php/merges","archive_url":"https://api.github.com/repos/darrynten/sage-one-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darrynten/sage-one-php/downloads","issues_url":"https://api.github.com/repos/darrynten/sage-one-php/issues{/number}","pulls_url":"https://api.github.com/repos/darrynten/sage-one-php/pulls{/number}","milestones_url":"https://api.github.com/repos/darrynten/sage-one-php/milestones{/number}","notifications_url":"https://api.github.com/repos/darrynten/sage-one-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darrynten/sage-one-php/labels{/name}","releases_url":"https://api.github.com/repos/darrynten/sage-one-php/releases{/id}","deployments_url":"https://api.github.com/repos/darrynten/sage-one-php/deployments","created_at":"2017-06-29T00:14:15Z","updated_at":"2017-07-07T14:31:30Z","pushed_at":"2017-07-10T11:15:47Z","git_url":"git://github.com/darrynten/sage-one-php.git","ssh_url":"git@github.com:darrynten/sage-one-php.git","clone_url":"https://github.com/darrynten/sage-one-php.git","svn_url":"https://github.com/darrynten/sage-one-php","homepage":null,"size":155,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/darrynten/sage-one-php/pulls/22"},"html":{"href":"https://github.com/darrynten/sage-one-php/pull/22"},"issue":{"href":"https://api.github.com/repos/darrynten/sage-one-php/issues/22"},"comments":{"href":"https://api.github.com/repos/darrynten/sage-one-php/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/darrynten/sage-one-php/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/darrynten/sage-one-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/darrynten/sage-one-php/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/darrynten/sage-one-php/statuses/9c6079e7fc4773aebb6619fc63ba0161ed8b9d92"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"make-it-git","id":28646072,"avatar_url":"https://avatars1.githubusercontent.com/u/28646072?v=3","gravatar_id":"","url":"https://api.github.com/users/make-it-git","html_url":"https://github.com/make-it-git","followers_url":"https://api.github.com/users/make-it-git/followers","following_url":"https://api.github.com/users/make-it-git/following{/other_user}","gists_url":"https://api.github.com/users/make-it-git/gists{/gist_id}","starred_url":"https://api.github.com/users/make-it-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/make-it-git/subscriptions","organizations_url":"https://api.github.com/users/make-it-git/orgs","repos_url":"https://api.github.com/users/make-it-git/repos","events_url":"https://api.github.com/users/make-it-git/events{/privacy}","received_events_url":"https://api.github.com/users/make-it-git/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":189,"deletions":131,"changed_files":6}}
{"actor":{"display_login":"make-it-git"}}