{"action":"created","issue":{"url":"https://api.github.com/repos/moby/moby/issues/33781","repository_url":"https://api.github.com/repos/moby/moby","labels_url":"https://api.github.com/repos/moby/moby/issues/33781/labels{/name}","comments_url":"https://api.github.com/repos/moby/moby/issues/33781/comments","events_url":"https://api.github.com/repos/moby/moby/issues/33781/events","html_url":"https://github.com/moby/moby/pull/33781","id":237887868,"number":33781,"title":"Prevent a goroutine leak when healthcheck gets stopped","user":{"login":"mlaventure","id":16065150,"avatar_url":"https://avatars2.githubusercontent.com/u/16065150?v=3","gravatar_id":"","url":"https://api.github.com/users/mlaventure","html_url":"https://github.com/mlaventure","followers_url":"https://api.github.com/users/mlaventure/followers","following_url":"https://api.github.com/users/mlaventure/following{/other_user}","gists_url":"https://api.github.com/users/mlaventure/gists{/gist_id}","starred_url":"https://api.github.com/users/mlaventure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlaventure/subscriptions","organizations_url":"https://api.github.com/users/mlaventure/orgs","repos_url":"https://api.github.com/users/mlaventure/repos","events_url":"https://api.github.com/users/mlaventure/events{/privacy}","received_events_url":"https://api.github.com/users/mlaventure/received_events","type":"User","site_admin":false},"labels":[{"id":175374554,"url":"https://api.github.com/repos/moby/moby/labels/status/0-triage","name":"status/0-triage","color":"EEEEEE","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-06-22T15:38:40Z","updated_at":"2017-06-22T17:08:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/moby/moby/pulls/33781","html_url":"https://github.com/moby/moby/pull/33781","diff_url":"https://github.com/moby/moby/pull/33781.diff","patch_url":"https://github.com/moby/moby/pull/33781.patch"},"body":"Signed-off-by: Kenfe-Mickael Laventure <mickael.laventure@gmail.com>\r\n\r\n--- \r\n\r\nping @talex5 I couldn't understand why we don't want to wait for the probe to exit here, so I just put it in a go routine. However, the code is waiting if the context is cancelled a few lines below, can the same be done here?\r\n\r\n**- What I did**\r\n\r\nPrevent a go routine leak when a probe has been started and we're asked to stop healthchecks\r\n\r\n**- How I did it**\r\n\r\nStarted a goroutine that will wait on the channel\r\n\r\n**- How to verify it**\r\n\r\n**- Description for the changelog**\r\n\r\nFix a case were healthcheck could leak a goroutine\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n\r\n:dog: \r\n"},"comment":{"url":"https://api.github.com/repos/moby/moby/issues/comments/310442901","html_url":"https://github.com/moby/moby/pull/33781#issuecomment-310442901","issue_url":"https://api.github.com/repos/moby/moby/issues/33781","id":310442901,"user":{"login":"mlaventure","id":16065150,"avatar_url":"https://avatars2.githubusercontent.com/u/16065150?v=3","gravatar_id":"","url":"https://api.github.com/users/mlaventure","html_url":"https://github.com/mlaventure","followers_url":"https://api.github.com/users/mlaventure/followers","following_url":"https://api.github.com/users/mlaventure/following{/other_user}","gists_url":"https://api.github.com/users/mlaventure/gists{/gist_id}","starred_url":"https://api.github.com/users/mlaventure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlaventure/subscriptions","organizations_url":"https://api.github.com/users/mlaventure/orgs","repos_url":"https://api.github.com/users/mlaventure/repos","events_url":"https://api.github.com/users/mlaventure/events{/privacy}","received_events_url":"https://api.github.com/users/mlaventure/received_events","type":"User","site_admin":false},"created_at":"2017-06-22T17:08:30Z","updated_at":"2017-06-22T17:08:30Z","body":"That'd you work too, yes. But I'd like to know why we don't want to wait\nhere\n\nOn Thu, Jun 22, 2017, 9:42 AM Aaron Lehmann <notifications@github.com>\nwrote:\n\n> Started a goroutine that will wait on the channel\n>\n> What about changing the channel to a buffered channel?\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/moby/moby/pull/33781#issuecomment-310435829>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/APUifqykCO66eSXFurFYCeFR-SanXV_6ks5sGplngaJpZM4OCeh5>\n> .\n>\n-- \n\nSent from my phone.\n"}}
{"actor":{"display_login":"mlaventure"}}