{"action":"created","comment":{"url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments/115426720","pull_request_review_id":36959950,"id":115426720,"diff_hunk":"@@ -0,0 +1,89 @@\n+#!/bin/bash\n+\n+#  This file is part of cc-oci-runtime.\n+#\n+#  Copyright (C) 2017 Intel Corporation\n+#\n+#  This program is free software; you can redistribute it and/or\n+#  modify it under the terms of the GNU General Public License\n+#  as published by the Free Software Foundation; either version 2\n+#  of the License, or (at your option) any later version.\n+#\n+#  This program is distributed in the hope that it will be useful,\n+#  but WITHOUT ANY WARRANTY; without even the implied warranty of\n+#  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+#  GNU General Public License for more details.\n+#\n+#  You should have received a copy of the GNU General Public License\n+#  along with this program; if not, write to the Free Software\n+#  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.\n+#\n+# Description:\n+#  Measures Proportional Set Size memory while running an\n+#  inter (docker<->docker) 1Gbps network bandwidth using nuttcp\n+\n+set -e\n+\n+SCRIPT_PATH=$(dirname \"$(readlink -f \"$0\")\")\n+\n+source \"${SCRIPT_PATH}/../../lib/test-common.bash\"\n+\n+# Currently default nuttcp has a bug\n+# see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745051\n+# Image name\n+image=gabyct/nuttcp\n+# This is required in order to reduce standard deviation\n+total_time=6\n+# This time (seconds) is required when\n+# server and client are more stable, we need to\n+# have server and client running for sometime and we\n+# need to avoid to measure at the beginning of the running\n+middle_time=3\n+\n+# Rate limit (speed at which transmitter send data, megabytes)\n+rate_limit=10000\n+\n+function setup {\n+\truntime_docker\n+\tkill_processes_before_start\n+}\n+\n+# This script will perform all the measurements using a local setup\n+\n+function start_client_server {\n+\tsetup\n+\ttotal_memory=$(mktemp)\n+\tserver_name=\"nuttcp-server\"\n+\tclient_name=\"nuttcp-client\"\n+\n+\tserver_command=\"/root/nuttcp -S\"\n+\t$DOCKER_EXE run -tid --name=${server_name} ${image} bash > /dev/null\n+        server_address=$($DOCKER_EXE inspect --format \"{{.NetworkSettings.IPAddress}}\" ${server_name})","path":"tests/metrics/network/network-metrics-memory-1g.sh.in","position":61,"original_position":61,"commit_id":"836917d71013870ded18dea207af53763cc57cf7","original_commit_id":"836917d71013870ded18dea207af53763cc57cf7","user":{"login":"jodh-intel","id":20315601,"avatar_url":"https://avatars2.githubusercontent.com/u/20315601?v=3","gravatar_id":"","url":"https://api.github.com/users/jodh-intel","html_url":"https://github.com/jodh-intel","followers_url":"https://api.github.com/users/jodh-intel/followers","following_url":"https://api.github.com/users/jodh-intel/following{/other_user}","gists_url":"https://api.github.com/users/jodh-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/jodh-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodh-intel/subscriptions","organizations_url":"https://api.github.com/users/jodh-intel/orgs","repos_url":"https://api.github.com/users/jodh-intel/repos","events_url":"https://api.github.com/users/jodh-intel/events{/privacy}","received_events_url":"https://api.github.com/users/jodh-intel/received_events","type":"User","site_admin":false},"body":"We seem to be getting quite a collection of these tests now (good), but they all \"look\" very similar. I wonder if there is any opportunity to refactor them into some shared functions (which could live in `test-common.bash`) then the tests themselves could become small stubs that call the shared functions. What do you think?\r\n\r\n@grahamwhaley - do you have any thoughts on this?","created_at":"2017-05-09T07:49:07Z","updated_at":"2017-05-09T07:49:19Z","html_url":"https://github.com/01org/cc-oci-runtime/pull/891#discussion_r115426720","pull_request_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/891","_links":{"self":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments/115426720"},"html":{"href":"https://github.com/01org/cc-oci-runtime/pull/891#discussion_r115426720"},"pull_request":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/891"}}},"pull_request":{"url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/891","id":119483705,"html_url":"https://github.com/01org/cc-oci-runtime/pull/891","diff_url":"https://github.com/01org/cc-oci-runtime/pull/891.diff","patch_url":"https://github.com/01org/cc-oci-runtime/pull/891.patch","issue_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/891","number":891,"state":"open","locked":false,"title":"Metrics: PSS memory for a particular load level","user":{"login":"GabyCT","id":20359065,"avatar_url":"https://avatars2.githubusercontent.com/u/20359065?v=3","gravatar_id":"","url":"https://api.github.com/users/GabyCT","html_url":"https://github.com/GabyCT","followers_url":"https://api.github.com/users/GabyCT/followers","following_url":"https://api.github.com/users/GabyCT/following{/other_user}","gists_url":"https://api.github.com/users/GabyCT/gists{/gist_id}","starred_url":"https://api.github.com/users/GabyCT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabyCT/subscriptions","organizations_url":"https://api.github.com/users/GabyCT/orgs","repos_url":"https://api.github.com/users/GabyCT/repos","events_url":"https://api.github.com/users/GabyCT/events{/privacy}","received_events_url":"https://api.github.com/users/GabyCT/received_events","type":"User","site_admin":false},"body":"Proportional Set Size (PSS) memory while running a nuttcp 1 Gbps\r\nbandwidth. The PSS measurement is taken by using smem.\r\n\r\nSigned-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>","created_at":"2017-05-08T16:21:05Z","updated_at":"2017-05-09T07:49:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23952e16c9fc183f9e77de4070773ec04d2766fa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/891/commits","review_comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/891/comments","review_comment_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/891/comments","statuses_url":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/836917d71013870ded18dea207af53763cc57cf7","head":{"label":"GabyCT:topic/1g","ref":"topic/1g","sha":"836917d71013870ded18dea207af53763cc57cf7","user":{"login":"GabyCT","id":20359065,"avatar_url":"https://avatars2.githubusercontent.com/u/20359065?v=3","gravatar_id":"","url":"https://api.github.com/users/GabyCT","html_url":"https://github.com/GabyCT","followers_url":"https://api.github.com/users/GabyCT/followers","following_url":"https://api.github.com/users/GabyCT/following{/other_user}","gists_url":"https://api.github.com/users/GabyCT/gists{/gist_id}","starred_url":"https://api.github.com/users/GabyCT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabyCT/subscriptions","organizations_url":"https://api.github.com/users/GabyCT/orgs","repos_url":"https://api.github.com/users/GabyCT/repos","events_url":"https://api.github.com/users/GabyCT/events{/privacy}","received_events_url":"https://api.github.com/users/GabyCT/received_events","type":"User","site_admin":false},"repo":{"id":66868394,"name":"cc-oci-runtime","full_name":"GabyCT/cc-oci-runtime","owner":{"login":"GabyCT","id":20359065,"avatar_url":"https://avatars2.githubusercontent.com/u/20359065?v=3","gravatar_id":"","url":"https://api.github.com/users/GabyCT","html_url":"https://github.com/GabyCT","followers_url":"https://api.github.com/users/GabyCT/followers","following_url":"https://api.github.com/users/GabyCT/following{/other_user}","gists_url":"https://api.github.com/users/GabyCT/gists{/gist_id}","starred_url":"https://api.github.com/users/GabyCT/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GabyCT/subscriptions","organizations_url":"https://api.github.com/users/GabyCT/orgs","repos_url":"https://api.github.com/users/GabyCT/repos","events_url":"https://api.github.com/users/GabyCT/events{/privacy}","received_events_url":"https://api.github.com/users/GabyCT/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GabyCT/cc-oci-runtime","description":"OCI (Open Containers Initiative) compatible runtime for Intel® Architecture","fork":true,"url":"https://api.github.com/repos/GabyCT/cc-oci-runtime","forks_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/forks","keys_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/teams","hooks_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/hooks","issue_events_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/events","assignees_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/tags","blobs_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/languages","stargazers_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/stargazers","contributors_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/contributors","subscribers_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/subscribers","subscription_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/subscription","commits_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/merges","archive_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/downloads","issues_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/labels{/name}","releases_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/GabyCT/cc-oci-runtime/deployments","created_at":"2016-08-29T18:13:28Z","updated_at":"2016-08-29T18:13:29Z","pushed_at":"2017-05-08T16:20:20Z","git_url":"git://github.com/GabyCT/cc-oci-runtime.git","ssh_url":"git@github.com:GabyCT/cc-oci-runtime.git","clone_url":"https://github.com/GabyCT/cc-oci-runtime.git","svn_url":"https://github.com/GabyCT/cc-oci-runtime","homepage":"","size":2727,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:master","ref":"master","sha":"a1005b98c4839c99a53e0657088793067f1bb5ad","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars2.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":62701840,"name":"cc-oci-runtime","full_name":"01org/cc-oci-runtime","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars2.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/cc-oci-runtime","description":"OCI (Open Containers Initiative) compatible runtime for Intel® Architecture","fork":false,"url":"https://api.github.com/repos/01org/cc-oci-runtime","forks_url":"https://api.github.com/repos/01org/cc-oci-runtime/forks","keys_url":"https://api.github.com/repos/01org/cc-oci-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/cc-oci-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/cc-oci-runtime/teams","hooks_url":"https://api.github.com/repos/01org/cc-oci-runtime/hooks","issue_events_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/01org/cc-oci-runtime/events","assignees_url":"https://api.github.com/repos/01org/cc-oci-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/01org/cc-oci-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/01org/cc-oci-runtime/tags","blobs_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/cc-oci-runtime/languages","stargazers_url":"https://api.github.com/repos/01org/cc-oci-runtime/stargazers","contributors_url":"https://api.github.com/repos/01org/cc-oci-runtime/contributors","subscribers_url":"https://api.github.com/repos/01org/cc-oci-runtime/subscribers","subscription_url":"https://api.github.com/repos/01org/cc-oci-runtime/subscription","commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/cc-oci-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/cc-oci-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/cc-oci-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/01org/cc-oci-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/cc-oci-runtime/merges","archive_url":"https://api.github.com/repos/01org/cc-oci-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/cc-oci-runtime/downloads","issues_url":"https://api.github.com/repos/01org/cc-oci-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/01org/cc-oci-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/cc-oci-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/cc-oci-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/cc-oci-runtime/labels{/name}","releases_url":"https://api.github.com/repos/01org/cc-oci-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/01org/cc-oci-runtime/deployments","created_at":"2016-07-06T07:48:26Z","updated_at":"2017-05-08T23:31:12Z","pushed_at":"2017-05-09T03:37:19Z","git_url":"git://github.com/01org/cc-oci-runtime.git","ssh_url":"git@github.com:01org/cc-oci-runtime.git","clone_url":"https://github.com/01org/cc-oci-runtime.git","svn_url":"https://github.com/01org/cc-oci-runtime","homepage":"","size":2764,"stargazers_count":379,"watchers_count":379,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":100,"forks":42,"open_issues":100,"watchers":379,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/891"},"html":{"href":"https://github.com/01org/cc-oci-runtime/pull/891"},"issue":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/issues/891"},"comments":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/issues/891/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/891/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/pulls/891/commits"},"statuses":{"href":"https://api.github.com/repos/01org/cc-oci-runtime/statuses/836917d71013870ded18dea207af53763cc57cf7"}}}}
{"actor":{"display_login":"jodh-intel"}}