{"action":"created","issue":{"url":"https://api.github.com/repos/python/cpython/issues/3626","repository_url":"https://api.github.com/repos/python/cpython","labels_url":"https://api.github.com/repos/python/cpython/issues/3626/labels{/name}","comments_url":"https://api.github.com/repos/python/cpython/issues/3626/comments","events_url":"https://api.github.com/repos/python/cpython/issues/3626/events","html_url":"https://github.com/python/cpython/pull/3626","id":258298868,"number":3626,"title":"bpo-31351: Fix RC 0 in ensurepip when pip fails","user":{"login":"iafilatov","id":5930446,"avatar_url":"https://avatars3.githubusercontent.com/u/5930446?v=4","gravatar_id":"","url":"https://api.github.com/users/iafilatov","html_url":"https://github.com/iafilatov","followers_url":"https://api.github.com/users/iafilatov/followers","following_url":"https://api.github.com/users/iafilatov/following{/other_user}","gists_url":"https://api.github.com/users/iafilatov/gists{/gist_id}","starred_url":"https://api.github.com/users/iafilatov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iafilatov/subscriptions","organizations_url":"https://api.github.com/users/iafilatov/orgs","repos_url":"https://api.github.com/users/iafilatov/repos","events_url":"https://api.github.com/users/iafilatov/events{/privacy}","received_events_url":"https://api.github.com/users/iafilatov/received_events","type":"User","site_admin":false},"labels":[{"id":666980059,"url":"https://api.github.com/repos/python/cpython/labels/awaiting%20merge","name":"awaiting merge","color":"fbca04","default":false},{"id":536945472,"url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":536945792,"url":"https://api.github.com/repos/python/cpython/labels/needs%20backport%20to%202.7","name":"needs backport to 2.7","color":"c2e0c6","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-09-17T12:14:18Z","updated_at":"2017-09-21T10:07:57Z","closed_at":"2017-09-21T10:07:46Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/3626","html_url":"https://github.com/python/cpython/pull/3626","diff_url":"https://github.com/python/cpython/pull/3626.diff","patch_url":"https://github.com/python/cpython/pull/3626.patch"},"body":"ensurepip discards pip's return code which leads to broken venvs. Make sure EC is propagated to that scripts that run ensurepip in a separate process (e.g. `python -m ensurepip`) can detect failure.\r\n\r\nI decided to keep the return value of the public version of `bootstrap()` unmodified although I'm not sure it's correct because it leaves no way to check if pip has succeeded or not (and I doubt there's a lot of code that relies on `bootstrap()` returning `None`). \r\n\r\n<!-- issue-number: bpo-31351 -->\r\nhttps://bugs.python.org/issue31351\r\n<!-- /issue-number -->\r\n"},"comment":{"url":"https://api.github.com/repos/python/cpython/issues/comments/331112973","html_url":"https://github.com/python/cpython/pull/3626#issuecomment-331112973","issue_url":"https://api.github.com/repos/python/cpython/issues/3626","id":331112973,"user":{"login":"bedevere-bot","id":28579281,"avatar_url":"https://avatars0.githubusercontent.com/u/28579281?v=4","gravatar_id":"","url":"https://api.github.com/users/bedevere-bot","html_url":"https://github.com/bedevere-bot","followers_url":"https://api.github.com/users/bedevere-bot/followers","following_url":"https://api.github.com/users/bedevere-bot/following{/other_user}","gists_url":"https://api.github.com/users/bedevere-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/bedevere-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bedevere-bot/subscriptions","organizations_url":"https://api.github.com/users/bedevere-bot/orgs","repos_url":"https://api.github.com/users/bedevere-bot/repos","events_url":"https://api.github.com/users/bedevere-bot/events{/privacy}","received_events_url":"https://api.github.com/users/bedevere-bot/received_events","type":"User","site_admin":false},"created_at":"2017-09-21T10:07:57Z","updated_at":"2017-09-21T10:07:57Z","author_association":"NONE","body":"[GH-3683](https://github.com/python/cpython/pull/3683) is a backport of this pull request to the [3.6 branch](https://github.com/python/cpython/tree/3.6)."}}
{"actor":{"display_login":"bedevere-bot"}}