{"action":"opened","number":24,"pull_request":{"url":"https://api.github.com/repos/micschk/silverstripe-liveseo/pulls/24","id":136505313,"html_url":"https://github.com/micschk/silverstripe-liveseo/pull/24","diff_url":"https://github.com/micschk/silverstripe-liveseo/pull/24.diff","patch_url":"https://github.com/micschk/silverstripe-liveseo/pull/24.patch","issue_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/issues/24","number":24,"state":"open","locked":false,"title":"Change CSS and JS dependencies to allow autoloading","user":{"login":"mlewis-everley","id":687143,"avatar_url":"https://avatars3.githubusercontent.com/u/687143?v=4","gravatar_id":"","url":"https://api.github.com/users/mlewis-everley","html_url":"https://github.com/mlewis-everley","followers_url":"https://api.github.com/users/mlewis-everley/followers","following_url":"https://api.github.com/users/mlewis-everley/following{/other_user}","gists_url":"https://api.github.com/users/mlewis-everley/gists{/gist_id}","starred_url":"https://api.github.com/users/mlewis-everley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlewis-everley/subscriptions","organizations_url":"https://api.github.com/users/mlewis-everley/orgs","repos_url":"https://api.github.com/users/mlewis-everley/repos","events_url":"https://api.github.com/users/mlewis-everley/events{/privacy}","received_events_url":"https://api.github.com/users/mlewis-everley/received_events","type":"User","site_admin":false},"body":"At the moment I very often have to refresh the page in the CMS to get the Javascript to load. This appears to be dues to the fact that the JS is loaded as \"customscript\" or \"javascripttemplate\" (so written into the page).\r\n\r\nThese changes move the JS libs to being required by LeftAndMain (and so they will be included by default and added to combined files) or in the case of GoogleSuggestField move to using a standard Requirements::javascript call (which causes the JS to be loaded via ajax).\r\n\r\nI have tested these changes on a vanilla SilverStripe install and everything works as expected (both on SiteTree objects and on custom DataObjects) with no refreshing required.","created_at":"2017-08-18T15:25:29Z","updated_at":"2017-08-18T15:25:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/pulls/24/commits","review_comments_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/pulls/24/comments","review_comment_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/issues/24/comments","statuses_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/statuses/1d18d95bee97bafa6f4ccc2d805150422fd62310","head":{"label":"mlewis-everley:autoloading","ref":"autoloading","sha":"1d18d95bee97bafa6f4ccc2d805150422fd62310","user":{"login":"mlewis-everley","id":687143,"avatar_url":"https://avatars3.githubusercontent.com/u/687143?v=4","gravatar_id":"","url":"https://api.github.com/users/mlewis-everley","html_url":"https://github.com/mlewis-everley","followers_url":"https://api.github.com/users/mlewis-everley/followers","following_url":"https://api.github.com/users/mlewis-everley/following{/other_user}","gists_url":"https://api.github.com/users/mlewis-everley/gists{/gist_id}","starred_url":"https://api.github.com/users/mlewis-everley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlewis-everley/subscriptions","organizations_url":"https://api.github.com/users/mlewis-everley/orgs","repos_url":"https://api.github.com/users/mlewis-everley/repos","events_url":"https://api.github.com/users/mlewis-everley/events{/privacy}","received_events_url":"https://api.github.com/users/mlewis-everley/received_events","type":"User","site_admin":false},"repo":{"id":81443067,"name":"silverstripe-liveseo","full_name":"mlewis-everley/silverstripe-liveseo","owner":{"login":"mlewis-everley","id":687143,"avatar_url":"https://avatars3.githubusercontent.com/u/687143?v=4","gravatar_id":"","url":"https://api.github.com/users/mlewis-everley","html_url":"https://github.com/mlewis-everley","followers_url":"https://api.github.com/users/mlewis-everley/followers","following_url":"https://api.github.com/users/mlewis-everley/following{/other_user}","gists_url":"https://api.github.com/users/mlewis-everley/gists{/gist_id}","starred_url":"https://api.github.com/users/mlewis-everley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlewis-everley/subscriptions","organizations_url":"https://api.github.com/users/mlewis-everley/orgs","repos_url":"https://api.github.com/users/mlewis-everley/repos","events_url":"https://api.github.com/users/mlewis-everley/events{/privacy}","received_events_url":"https://api.github.com/users/mlewis-everley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mlewis-everley/silverstripe-liveseo","description":"Silverstripe SEO Module","fork":true,"url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo","forks_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/forks","keys_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/teams","hooks_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/hooks","issue_events_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/issues/events{/number}","events_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/events","assignees_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/assignees{/user}","branches_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/branches{/branch}","tags_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/tags","blobs_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/statuses/{sha}","languages_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/languages","stargazers_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/stargazers","contributors_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/contributors","subscribers_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/subscribers","subscription_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/subscription","commits_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/contents/{+path}","compare_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/merges","archive_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/downloads","issues_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/issues{/number}","pulls_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/pulls{/number}","milestones_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/milestones{/number}","notifications_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/labels{/name}","releases_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/releases{/id}","deployments_url":"https://api.github.com/repos/mlewis-everley/silverstripe-liveseo/deployments","created_at":"2017-02-09T11:25:02Z","updated_at":"2017-02-09T11:25:04Z","pushed_at":"2017-08-18T15:12:00Z","git_url":"git://github.com/mlewis-everley/silverstripe-liveseo.git","ssh_url":"git@github.com:mlewis-everley/silverstripe-liveseo.git","clone_url":"https://github.com/mlewis-everley/silverstripe-liveseo.git","svn_url":"https://github.com/mlewis-everley/silverstripe-liveseo","homepage":null,"size":1408,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"micschk:master","ref":"master","sha":"ae10d41cc933e8582c0ddfc5af716087035de474","user":{"login":"micschk","id":1005986,"avatar_url":"https://avatars1.githubusercontent.com/u/1005986?v=4","gravatar_id":"","url":"https://api.github.com/users/micschk","html_url":"https://github.com/micschk","followers_url":"https://api.github.com/users/micschk/followers","following_url":"https://api.github.com/users/micschk/following{/other_user}","gists_url":"https://api.github.com/users/micschk/gists{/gist_id}","starred_url":"https://api.github.com/users/micschk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micschk/subscriptions","organizations_url":"https://api.github.com/users/micschk/orgs","repos_url":"https://api.github.com/users/micschk/repos","events_url":"https://api.github.com/users/micschk/events{/privacy}","received_events_url":"https://api.github.com/users/micschk/received_events","type":"User","site_admin":false},"repo":{"id":28666460,"name":"silverstripe-liveseo","full_name":"micschk/silverstripe-liveseo","owner":{"login":"micschk","id":1005986,"avatar_url":"https://avatars1.githubusercontent.com/u/1005986?v=4","gravatar_id":"","url":"https://api.github.com/users/micschk","html_url":"https://github.com/micschk","followers_url":"https://api.github.com/users/micschk/followers","following_url":"https://api.github.com/users/micschk/following{/other_user}","gists_url":"https://api.github.com/users/micschk/gists{/gist_id}","starred_url":"https://api.github.com/users/micschk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micschk/subscriptions","organizations_url":"https://api.github.com/users/micschk/orgs","repos_url":"https://api.github.com/users/micschk/repos","events_url":"https://api.github.com/users/micschk/events{/privacy}","received_events_url":"https://api.github.com/users/micschk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/micschk/silverstripe-liveseo","description":"Silverstripe SEO Module","fork":true,"url":"https://api.github.com/repos/micschk/silverstripe-liveseo","forks_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/forks","keys_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/teams","hooks_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/hooks","issue_events_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/issues/events{/number}","events_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/events","assignees_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/assignees{/user}","branches_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/branches{/branch}","tags_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/tags","blobs_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/git/refs{/sha}","trees_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/statuses/{sha}","languages_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/languages","stargazers_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/stargazers","contributors_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/contributors","subscribers_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/subscribers","subscription_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/subscription","commits_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/commits{/sha}","git_commits_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/git/commits{/sha}","comments_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/comments{/number}","issue_comment_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/issues/comments{/number}","contents_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/contents/{+path}","compare_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/merges","archive_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/downloads","issues_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/issues{/number}","pulls_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/pulls{/number}","milestones_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/milestones{/number}","notifications_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/labels{/name}","releases_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/releases{/id}","deployments_url":"https://api.github.com/repos/micschk/silverstripe-liveseo/deployments","created_at":"2014-12-31T13:23:52Z","updated_at":"2016-11-30T14:57:28Z","pushed_at":"2017-06-14T04:02:09Z","git_url":"git://github.com/micschk/silverstripe-liveseo.git","ssh_url":"git@github.com:micschk/silverstripe-liveseo.git","clone_url":"https://github.com/micschk/silverstripe-liveseo.git","svn_url":"https://github.com/micschk/silverstripe-liveseo","homepage":null,"size":1413,"stargazers_count":16,"watchers_count":16,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":6,"forks":3,"open_issues":6,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micschk/silverstripe-liveseo/pulls/24"},"html":{"href":"https://github.com/micschk/silverstripe-liveseo/pull/24"},"issue":{"href":"https://api.github.com/repos/micschk/silverstripe-liveseo/issues/24"},"comments":{"href":"https://api.github.com/repos/micschk/silverstripe-liveseo/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/micschk/silverstripe-liveseo/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/micschk/silverstripe-liveseo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micschk/silverstripe-liveseo/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/micschk/silverstripe-liveseo/statuses/1d18d95bee97bafa6f4ccc2d805150422fd62310"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":55,"deletions":60,"changed_files":7}}
{"actor":{"display_login":"mlewis-everley"}}