{"action":"created","comment":{"url":"https://api.github.com/repos/vividvilla/csvtotable/pulls/comments/147368211","pull_request_review_id":72454534,"id":147368211,"diff_hunk":"@@ -13,13 +13,15 @@\n \n \t<script src=\"js/jquery.min.js\" type=\"text/javascript\"></script>\n \t<script src=\"js/jquery.dataTables.min.js\" type=\"text/javascript\"></script>\n+\t<script src=\"js/echarts.min.js\" type=\"text/javascript\"></script>","path":"csvtotable/templates/template.j2","position":4,"original_position":4,"commit_id":"81f299f9a460a71799353bf29d3d6096e2adf247","original_commit_id":"81f299f9a460a71799353bf29d3d6096e2adf247","user":{"login":"vividvilla","id":715529,"avatar_url":"https://avatars0.githubusercontent.com/u/715529?v=4","gravatar_id":"","url":"https://api.github.com/users/vividvilla","html_url":"https://github.com/vividvilla","followers_url":"https://api.github.com/users/vividvilla/followers","following_url":"https://api.github.com/users/vividvilla/following{/other_user}","gists_url":"https://api.github.com/users/vividvilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vividvilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vividvilla/subscriptions","organizations_url":"https://api.github.com/users/vividvilla/orgs","repos_url":"https://api.github.com/users/vividvilla/repos","events_url":"https://api.github.com/users/vividvilla/events{/privacy}","received_events_url":"https://api.github.com/users/vividvilla/received_events","type":"User","site_admin":false},"body":"Since the included JS is around 600kb its better if this is conditional based on export options enabled.","created_at":"2017-10-27T09:50:36Z","updated_at":"2017-10-27T09:52:38Z","html_url":"https://github.com/vividvilla/csvtotable/pull/24#discussion_r147368211","pull_request_url":"https://api.github.com/repos/vividvilla/csvtotable/pulls/24","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/vividvilla/csvtotable/pulls/comments/147368211"},"html":{"href":"https://github.com/vividvilla/csvtotable/pull/24#discussion_r147368211"},"pull_request":{"href":"https://api.github.com/repos/vividvilla/csvtotable/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/vividvilla/csvtotable/pulls/24","id":140946880,"html_url":"https://github.com/vividvilla/csvtotable/pull/24","diff_url":"https://github.com/vividvilla/csvtotable/pull/24.diff","patch_url":"https://github.com/vividvilla/csvtotable/pull/24.patch","issue_url":"https://api.github.com/repos/vividvilla/csvtotable/issues/24","number":24,"state":"open","locked":false,"title":":sparkles: add chart button for candlestick, line and bar chart.","user":{"login":"chfw","id":4280312,"avatar_url":"https://avatars0.githubusercontent.com/u/4280312?v=4","gravatar_id":"","url":"https://api.github.com/users/chfw","html_url":"https://github.com/chfw","followers_url":"https://api.github.com/users/chfw/followers","following_url":"https://api.github.com/users/chfw/following{/other_user}","gists_url":"https://api.github.com/users/chfw/gists{/gist_id}","starred_url":"https://api.github.com/users/chfw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chfw/subscriptions","organizations_url":"https://api.github.com/users/chfw/orgs","repos_url":"https://api.github.com/users/chfw/repos","events_url":"https://api.github.com/users/chfw/events{/privacy}","received_events_url":"https://api.github.com/users/chfw/received_events","type":"User","site_admin":false},"body":"1. candlestick, line and bar chart for value groups (open, close, high, low), volume, and adjacent close value respectively\r\n2. switch between table and chart\r\n3. download chart as png image\r\n\r\n![out](https://user-images.githubusercontent.com/4280312/30404140-006c035e-98dd-11e7-9cfd-1fcf3e405e2f.gif)\r\n\r\n\r\nLicense wise: echarts.js is under Baidu's BSD 3 clause license. buttons.charts.min.js is under my BSD 3 clause license. In short, free to use in open source or commercial applications.","created_at":"2017-09-13T22:45:02Z","updated_at":"2017-10-27T09:52:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73a022ffce92d00a9bd570f65b335b7acf097667","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/vividvilla/csvtotable/pulls/24/commits","review_comments_url":"https://api.github.com/repos/vividvilla/csvtotable/pulls/24/comments","review_comment_url":"https://api.github.com/repos/vividvilla/csvtotable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vividvilla/csvtotable/issues/24/comments","statuses_url":"https://api.github.com/repos/vividvilla/csvtotable/statuses/81f299f9a460a71799353bf29d3d6096e2adf247","head":{"label":"chfw:master","ref":"master","sha":"81f299f9a460a71799353bf29d3d6096e2adf247","user":{"login":"chfw","id":4280312,"avatar_url":"https://avatars0.githubusercontent.com/u/4280312?v=4","gravatar_id":"","url":"https://api.github.com/users/chfw","html_url":"https://github.com/chfw","followers_url":"https://api.github.com/users/chfw/followers","following_url":"https://api.github.com/users/chfw/following{/other_user}","gists_url":"https://api.github.com/users/chfw/gists{/gist_id}","starred_url":"https://api.github.com/users/chfw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chfw/subscriptions","organizations_url":"https://api.github.com/users/chfw/orgs","repos_url":"https://api.github.com/users/chfw/repos","events_url":"https://api.github.com/users/chfw/events{/privacy}","received_events_url":"https://api.github.com/users/chfw/received_events","type":"User","site_admin":false},"repo":{"id":103433300,"name":"csvtotable","full_name":"chfw/csvtotable","owner":{"login":"chfw","id":4280312,"avatar_url":"https://avatars0.githubusercontent.com/u/4280312?v=4","gravatar_id":"","url":"https://api.github.com/users/chfw","html_url":"https://github.com/chfw","followers_url":"https://api.github.com/users/chfw/followers","following_url":"https://api.github.com/users/chfw/following{/other_user}","gists_url":"https://api.github.com/users/chfw/gists{/gist_id}","starred_url":"https://api.github.com/users/chfw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chfw/subscriptions","organizations_url":"https://api.github.com/users/chfw/orgs","repos_url":"https://api.github.com/users/chfw/repos","events_url":"https://api.github.com/users/chfw/events{/privacy}","received_events_url":"https://api.github.com/users/chfw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chfw/csvtotable","description":"Simple command-line utility to convert CSV files to searchable and sortable HTML table.","fork":true,"url":"https://api.github.com/repos/chfw/csvtotable","forks_url":"https://api.github.com/repos/chfw/csvtotable/forks","keys_url":"https://api.github.com/repos/chfw/csvtotable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chfw/csvtotable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chfw/csvtotable/teams","hooks_url":"https://api.github.com/repos/chfw/csvtotable/hooks","issue_events_url":"https://api.github.com/repos/chfw/csvtotable/issues/events{/number}","events_url":"https://api.github.com/repos/chfw/csvtotable/events","assignees_url":"https://api.github.com/repos/chfw/csvtotable/assignees{/user}","branches_url":"https://api.github.com/repos/chfw/csvtotable/branches{/branch}","tags_url":"https://api.github.com/repos/chfw/csvtotable/tags","blobs_url":"https://api.github.com/repos/chfw/csvtotable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chfw/csvtotable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chfw/csvtotable/git/refs{/sha}","trees_url":"https://api.github.com/repos/chfw/csvtotable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chfw/csvtotable/statuses/{sha}","languages_url":"https://api.github.com/repos/chfw/csvtotable/languages","stargazers_url":"https://api.github.com/repos/chfw/csvtotable/stargazers","contributors_url":"https://api.github.com/repos/chfw/csvtotable/contributors","subscribers_url":"https://api.github.com/repos/chfw/csvtotable/subscribers","subscription_url":"https://api.github.com/repos/chfw/csvtotable/subscription","commits_url":"https://api.github.com/repos/chfw/csvtotable/commits{/sha}","git_commits_url":"https://api.github.com/repos/chfw/csvtotable/git/commits{/sha}","comments_url":"https://api.github.com/repos/chfw/csvtotable/comments{/number}","issue_comment_url":"https://api.github.com/repos/chfw/csvtotable/issues/comments{/number}","contents_url":"https://api.github.com/repos/chfw/csvtotable/contents/{+path}","compare_url":"https://api.github.com/repos/chfw/csvtotable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chfw/csvtotable/merges","archive_url":"https://api.github.com/repos/chfw/csvtotable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chfw/csvtotable/downloads","issues_url":"https://api.github.com/repos/chfw/csvtotable/issues{/number}","pulls_url":"https://api.github.com/repos/chfw/csvtotable/pulls{/number}","milestones_url":"https://api.github.com/repos/chfw/csvtotable/milestones{/number}","notifications_url":"https://api.github.com/repos/chfw/csvtotable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chfw/csvtotable/labels{/name}","releases_url":"https://api.github.com/repos/chfw/csvtotable/releases{/id}","deployments_url":"https://api.github.com/repos/chfw/csvtotable/deployments","created_at":"2017-09-13T18:01:07Z","updated_at":"2017-09-13T18:01:08Z","pushed_at":"2017-09-13T22:17:01Z","git_url":"git://github.com/chfw/csvtotable.git","ssh_url":"git@github.com:chfw/csvtotable.git","clone_url":"https://github.com/chfw/csvtotable.git","svn_url":"https://github.com/chfw/csvtotable","homepage":"","size":1616,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vividvilla:master","ref":"master","sha":"0f6f153a33dc82458b4b8e184bc0df7291f98784","user":{"login":"vividvilla","id":715529,"avatar_url":"https://avatars0.githubusercontent.com/u/715529?v=4","gravatar_id":"","url":"https://api.github.com/users/vividvilla","html_url":"https://github.com/vividvilla","followers_url":"https://api.github.com/users/vividvilla/followers","following_url":"https://api.github.com/users/vividvilla/following{/other_user}","gists_url":"https://api.github.com/users/vividvilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vividvilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vividvilla/subscriptions","organizations_url":"https://api.github.com/users/vividvilla/orgs","repos_url":"https://api.github.com/users/vividvilla/repos","events_url":"https://api.github.com/users/vividvilla/events{/privacy}","received_events_url":"https://api.github.com/users/vividvilla/received_events","type":"User","site_admin":false},"repo":{"id":96341852,"name":"csvtotable","full_name":"vividvilla/csvtotable","owner":{"login":"vividvilla","id":715529,"avatar_url":"https://avatars0.githubusercontent.com/u/715529?v=4","gravatar_id":"","url":"https://api.github.com/users/vividvilla","html_url":"https://github.com/vividvilla","followers_url":"https://api.github.com/users/vividvilla/followers","following_url":"https://api.github.com/users/vividvilla/following{/other_user}","gists_url":"https://api.github.com/users/vividvilla/gists{/gist_id}","starred_url":"https://api.github.com/users/vividvilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vividvilla/subscriptions","organizations_url":"https://api.github.com/users/vividvilla/orgs","repos_url":"https://api.github.com/users/vividvilla/repos","events_url":"https://api.github.com/users/vividvilla/events{/privacy}","received_events_url":"https://api.github.com/users/vividvilla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vividvilla/csvtotable","description":"Simple command-line utility to convert CSV files to searchable and sortable HTML table.","fork":false,"url":"https://api.github.com/repos/vividvilla/csvtotable","forks_url":"https://api.github.com/repos/vividvilla/csvtotable/forks","keys_url":"https://api.github.com/repos/vividvilla/csvtotable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vividvilla/csvtotable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vividvilla/csvtotable/teams","hooks_url":"https://api.github.com/repos/vividvilla/csvtotable/hooks","issue_events_url":"https://api.github.com/repos/vividvilla/csvtotable/issues/events{/number}","events_url":"https://api.github.com/repos/vividvilla/csvtotable/events","assignees_url":"https://api.github.com/repos/vividvilla/csvtotable/assignees{/user}","branches_url":"https://api.github.com/repos/vividvilla/csvtotable/branches{/branch}","tags_url":"https://api.github.com/repos/vividvilla/csvtotable/tags","blobs_url":"https://api.github.com/repos/vividvilla/csvtotable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vividvilla/csvtotable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vividvilla/csvtotable/git/refs{/sha}","trees_url":"https://api.github.com/repos/vividvilla/csvtotable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vividvilla/csvtotable/statuses/{sha}","languages_url":"https://api.github.com/repos/vividvilla/csvtotable/languages","stargazers_url":"https://api.github.com/repos/vividvilla/csvtotable/stargazers","contributors_url":"https://api.github.com/repos/vividvilla/csvtotable/contributors","subscribers_url":"https://api.github.com/repos/vividvilla/csvtotable/subscribers","subscription_url":"https://api.github.com/repos/vividvilla/csvtotable/subscription","commits_url":"https://api.github.com/repos/vividvilla/csvtotable/commits{/sha}","git_commits_url":"https://api.github.com/repos/vividvilla/csvtotable/git/commits{/sha}","comments_url":"https://api.github.com/repos/vividvilla/csvtotable/comments{/number}","issue_comment_url":"https://api.github.com/repos/vividvilla/csvtotable/issues/comments{/number}","contents_url":"https://api.github.com/repos/vividvilla/csvtotable/contents/{+path}","compare_url":"https://api.github.com/repos/vividvilla/csvtotable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vividvilla/csvtotable/merges","archive_url":"https://api.github.com/repos/vividvilla/csvtotable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vividvilla/csvtotable/downloads","issues_url":"https://api.github.com/repos/vividvilla/csvtotable/issues{/number}","pulls_url":"https://api.github.com/repos/vividvilla/csvtotable/pulls{/number}","milestones_url":"https://api.github.com/repos/vividvilla/csvtotable/milestones{/number}","notifications_url":"https://api.github.com/repos/vividvilla/csvtotable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vividvilla/csvtotable/labels{/name}","releases_url":"https://api.github.com/repos/vividvilla/csvtotable/releases{/id}","deployments_url":"https://api.github.com/repos/vividvilla/csvtotable/deployments","created_at":"2017-07-05T16:56:48Z","updated_at":"2017-10-26T17:12:46Z","pushed_at":"2017-10-27T09:26:43Z","git_url":"git://github.com/vividvilla/csvtotable.git","ssh_url":"git@github.com:vividvilla/csvtotable.git","clone_url":"https://github.com/vividvilla/csvtotable.git","svn_url":"https://github.com/vividvilla/csvtotable","homepage":"","size":1402,"stargazers_count":672,"watchers_count":672,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":9,"forks":41,"open_issues":9,"watchers":672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vividvilla/csvtotable/pulls/24"},"html":{"href":"https://github.com/vividvilla/csvtotable/pull/24"},"issue":{"href":"https://api.github.com/repos/vividvilla/csvtotable/issues/24"},"comments":{"href":"https://api.github.com/repos/vividvilla/csvtotable/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/vividvilla/csvtotable/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/vividvilla/csvtotable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vividvilla/csvtotable/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/vividvilla/csvtotable/statuses/81f299f9a460a71799353bf29d3d6096e2adf247"}},"author_association":"NONE"}}
{"actor":{"display_login":"vividvilla"}}