{"action":"created","comment":{"url":"https://api.github.com/repos/vega/vega-lite/pulls/comments/151042524","pull_request_review_id":76684843,"id":151042524,"diff_hunk":"@@ -97,6 +98,57 @@ export interface AggregatedFieldDef {\n   as: string;\n }\n \n+export interface WindowFieldDef {\n+  /**\n+   * The operations supported for the window aggregation\n+   */\n+  op: AggregateOp | WindowOnlyOp;\n+\n+  /**\n+   * The optional parameters for the operation\n+   */\n+  param?: Number;\n+\n+  /**\n+   * The field that will be used in the operation, some operations","path":"src/transform.ts","position":24,"original_position":24,"commit_id":"0929e85c9747ea6eb4b34c9f230f2626309e8212","original_commit_id":"0929e85c9747ea6eb4b34c9f230f2626309e8212","user":{"login":"kanitw","id":111269,"avatar_url":"https://avatars1.githubusercontent.com/u/111269?v=4","gravatar_id":"","url":"https://api.github.com/users/kanitw","html_url":"https://github.com/kanitw","followers_url":"https://api.github.com/users/kanitw/followers","following_url":"https://api.github.com/users/kanitw/following{/other_user}","gists_url":"https://api.github.com/users/kanitw/gists{/gist_id}","starred_url":"https://api.github.com/users/kanitw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanitw/subscriptions","organizations_url":"https://api.github.com/users/kanitw/orgs","repos_url":"https://api.github.com/users/kanitw/repos","events_url":"https://api.github.com/users/kanitw/events{/privacy}","received_events_url":"https://api.github.com/users/kanitw/received_events","type":"User","site_admin":false},"body":"The field that will be used in the operation.  Note that some operations ...","created_at":"2017-11-15T06:28:25Z","updated_at":"2017-11-15T06:33:19Z","html_url":"https://github.com/vega/vega-lite/pull/3199#discussion_r151042524","pull_request_url":"https://api.github.com/repos/vega/vega-lite/pulls/3199","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/comments/151042524"},"html":{"href":"https://github.com/vega/vega-lite/pull/3199#discussion_r151042524"},"pull_request":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/3199"}}},"pull_request":{"url":"https://api.github.com/repos/vega/vega-lite/pulls/3199","id":152686441,"html_url":"https://github.com/vega/vega-lite/pull/3199","diff_url":"https://github.com/vega/vega-lite/pull/3199.diff","patch_url":"https://github.com/vega/vega-lite/pull/3199.patch","issue_url":"https://api.github.com/repos/vega/vega-lite/issues/3199","number":3199,"state":"open","locked":false,"title":"[WIP] Added files for window transform","user":{"login":"AkshatSh","id":9097613,"avatar_url":"https://avatars3.githubusercontent.com/u/9097613?v=4","gravatar_id":"","url":"https://api.github.com/users/AkshatSh","html_url":"https://github.com/AkshatSh","followers_url":"https://api.github.com/users/AkshatSh/followers","following_url":"https://api.github.com/users/AkshatSh/following{/other_user}","gists_url":"https://api.github.com/users/AkshatSh/gists{/gist_id}","starred_url":"https://api.github.com/users/AkshatSh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkshatSh/subscriptions","organizations_url":"https://api.github.com/users/AkshatSh/orgs","repos_url":"https://api.github.com/users/AkshatSh/repos","events_url":"https://api.github.com/users/AkshatSh/events{/privacy}","received_events_url":"https://api.github.com/users/AkshatSh/received_events","type":"User","site_admin":false},"body":"Implemented Window Transform for Vega Lite\r\nIssue #2488 \r\nhttps://github.com/vega/vega-lite/issues/2488\r\nPlease:\r\n- [ ] Make your pull request atomic, fixing one issue at a time unless there are many relevant issues that cannot be decoupled.\r\n- [ ] Provide a test case & update the documentation under `site/docs/`\r\n- [ ] Make lint and test pass. (Run `npm run lint`, `npm run test`, `npm run build:examples`, `npm run test:runtime:generate`.)\r\n- [ ] Make sure you have rebased onto the `master` branch.\r\n- [ ] Provide a concise title so that we can just copy it to our release note.\r\n  - Use imperative mood and present tense.\r\n  - Mention relevant issues. (e.g., `#1`)\r\n  \r\nPro-Tip: https://medium.com/@greenberg/writing-pull-requests-your-coworkers-might-enjoy-reading-9d0307e93da3 is a nice article about writing a nice pull request.\r\n\r\n","created_at":"2017-11-15T05:13:26Z","updated_at":"2017-11-15T06:33:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/vega/vega-lite/pulls/3199/commits","review_comments_url":"https://api.github.com/repos/vega/vega-lite/pulls/3199/comments","review_comment_url":"https://api.github.com/repos/vega/vega-lite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vega/vega-lite/issues/3199/comments","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/0929e85c9747ea6eb4b34c9f230f2626309e8212","head":{"label":"vega:ak/WindowTransform","ref":"ak/WindowTransform","sha":"0929e85c9747ea6eb4b34c9f230f2626309e8212","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":26931359,"name":"vega-lite","full_name":"vega/vega-lite","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-lite","description":"A grammar of interactive graphics, built on Vega.","fork":false,"url":"https://api.github.com/repos/vega/vega-lite","forks_url":"https://api.github.com/repos/vega/vega-lite/forks","keys_url":"https://api.github.com/repos/vega/vega-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-lite/teams","hooks_url":"https://api.github.com/repos/vega/vega-lite/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-lite/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-lite/events","assignees_url":"https://api.github.com/repos/vega/vega-lite/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-lite/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-lite/tags","blobs_url":"https://api.github.com/repos/vega/vega-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-lite/languages","stargazers_url":"https://api.github.com/repos/vega/vega-lite/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-lite/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-lite/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-lite/subscription","commits_url":"https://api.github.com/repos/vega/vega-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-lite/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-lite/merges","archive_url":"https://api.github.com/repos/vega/vega-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-lite/downloads","issues_url":"https://api.github.com/repos/vega/vega-lite/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-lite/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-lite/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-lite/deployments","created_at":"2014-11-20T20:52:04Z","updated_at":"2017-11-15T04:17:30Z","pushed_at":"2017-11-15T05:13:27Z","git_url":"git://github.com/vega/vega-lite.git","ssh_url":"git@github.com:vega/vega-lite.git","clone_url":"https://github.com/vega/vega-lite.git","svn_url":"https://github.com/vega/vega-lite","homepage":"https://vega.github.io/vega-lite/","size":56449,"stargazers_count":956,"watchers_count":956,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":179,"forks":115,"open_issues":179,"watchers":956,"default_branch":"master"}},"base":{"label":"vega:master","ref":"master","sha":"f5bc978b009efddb128a6445bd46b0de8b0ba0f3","user":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"repo":{"id":26931359,"name":"vega-lite","full_name":"vega/vega-lite","owner":{"login":"vega","id":11796929,"avatar_url":"https://avatars3.githubusercontent.com/u/11796929?v=4","gravatar_id":"","url":"https://api.github.com/users/vega","html_url":"https://github.com/vega","followers_url":"https://api.github.com/users/vega/followers","following_url":"https://api.github.com/users/vega/following{/other_user}","gists_url":"https://api.github.com/users/vega/gists{/gist_id}","starred_url":"https://api.github.com/users/vega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vega/subscriptions","organizations_url":"https://api.github.com/users/vega/orgs","repos_url":"https://api.github.com/users/vega/repos","events_url":"https://api.github.com/users/vega/events{/privacy}","received_events_url":"https://api.github.com/users/vega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vega/vega-lite","description":"A grammar of interactive graphics, built on Vega.","fork":false,"url":"https://api.github.com/repos/vega/vega-lite","forks_url":"https://api.github.com/repos/vega/vega-lite/forks","keys_url":"https://api.github.com/repos/vega/vega-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vega/vega-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vega/vega-lite/teams","hooks_url":"https://api.github.com/repos/vega/vega-lite/hooks","issue_events_url":"https://api.github.com/repos/vega/vega-lite/issues/events{/number}","events_url":"https://api.github.com/repos/vega/vega-lite/events","assignees_url":"https://api.github.com/repos/vega/vega-lite/assignees{/user}","branches_url":"https://api.github.com/repos/vega/vega-lite/branches{/branch}","tags_url":"https://api.github.com/repos/vega/vega-lite/tags","blobs_url":"https://api.github.com/repos/vega/vega-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vega/vega-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vega/vega-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/vega/vega-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vega/vega-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/vega/vega-lite/languages","stargazers_url":"https://api.github.com/repos/vega/vega-lite/stargazers","contributors_url":"https://api.github.com/repos/vega/vega-lite/contributors","subscribers_url":"https://api.github.com/repos/vega/vega-lite/subscribers","subscription_url":"https://api.github.com/repos/vega/vega-lite/subscription","commits_url":"https://api.github.com/repos/vega/vega-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/vega/vega-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/vega/vega-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/vega/vega-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/vega/vega-lite/contents/{+path}","compare_url":"https://api.github.com/repos/vega/vega-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vega/vega-lite/merges","archive_url":"https://api.github.com/repos/vega/vega-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vega/vega-lite/downloads","issues_url":"https://api.github.com/repos/vega/vega-lite/issues{/number}","pulls_url":"https://api.github.com/repos/vega/vega-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/vega/vega-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/vega/vega-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vega/vega-lite/labels{/name}","releases_url":"https://api.github.com/repos/vega/vega-lite/releases{/id}","deployments_url":"https://api.github.com/repos/vega/vega-lite/deployments","created_at":"2014-11-20T20:52:04Z","updated_at":"2017-11-15T04:17:30Z","pushed_at":"2017-11-15T05:13:27Z","git_url":"git://github.com/vega/vega-lite.git","ssh_url":"git@github.com:vega/vega-lite.git","clone_url":"https://github.com/vega/vega-lite.git","svn_url":"https://github.com/vega/vega-lite","homepage":"https://vega.github.io/vega-lite/","size":56449,"stargazers_count":956,"watchers_count":956,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":179,"forks":115,"open_issues":179,"watchers":956,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/3199"},"html":{"href":"https://github.com/vega/vega-lite/pull/3199"},"issue":{"href":"https://api.github.com/repos/vega/vega-lite/issues/3199"},"comments":{"href":"https://api.github.com/repos/vega/vega-lite/issues/3199/comments"},"review_comments":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/3199/comments"},"review_comment":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vega/vega-lite/pulls/3199/commits"},"statuses":{"href":"https://api.github.com/repos/vega/vega-lite/statuses/0929e85c9747ea6eb4b34c9f230f2626309e8212"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kanitw"}}