{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/824","repository_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws","labels_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/824/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/824/comments","events_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/824/events","html_url":"https://github.com/kubernetes-incubator/kube-aws/pull/824","id":248385689,"number":824,"title":"Fix managed role name validation","user":{"login":"adyromantika","id":4217995,"avatar_url":"https://avatars1.githubusercontent.com/u/4217995?v=4","gravatar_id":"","url":"https://api.github.com/users/adyromantika","html_url":"https://github.com/adyromantika","followers_url":"https://api.github.com/users/adyromantika/followers","following_url":"https://api.github.com/users/adyromantika/following{/other_user}","gists_url":"https://api.github.com/users/adyromantika/gists{/gist_id}","starred_url":"https://api.github.com/users/adyromantika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adyromantika/subscriptions","organizations_url":"https://api.github.com/users/adyromantika/orgs","repos_url":"https://api.github.com/users/adyromantika/repos","events_url":"https://api.github.com/users/adyromantika/events{/privacy}","received_events_url":"https://api.github.com/users/adyromantika/received_events","type":"User","site_admin":false},"labels":[{"id":561748249,"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-08-07T11:44:16Z","updated_at":"2017-08-21T00:51:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/pulls/824","html_url":"https://github.com/kubernetes-incubator/kube-aws/pull/824","diff_url":"https://github.com/kubernetes-incubator/kube-aws/pull/824.diff","patch_url":"https://github.com/kubernetes-incubator/kube-aws/pull/824.patch"},"body":"When creating iam roles for the controller or node pools, validation checks for the whole string consisting of `<cluster_name>-<nested_stack_name>-<12_characters_random_alphanumeric_characters>-<region>-<iam_role_name>`. The validation works as intended if `iam.role.name` is not specified and auto-generated.\r\n\r\nHowever when `iam.role.name` is specified, kube-aws is actually creating `<region_name>-<managed_role_name>` so for the following config it'll actually create a role named `<region>-myrole` so a new validation is needed.\r\n\r\n```\r\n      iam:\r\n        role:\r\n          name: \"myrole\"\r\n```\r\n\r\nThis allows for a little bit more leeway to have a more meaningful name for the fixed role."},"comment":{"url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/comments/323623391","html_url":"https://github.com/kubernetes-incubator/kube-aws/pull/824#issuecomment-323623391","issue_url":"https://api.github.com/repos/kubernetes-incubator/kube-aws/issues/824","id":323623391,"user":{"login":"mumoshu","id":22009,"avatar_url":"https://avatars0.githubusercontent.com/u/22009?v=4","gravatar_id":"","url":"https://api.github.com/users/mumoshu","html_url":"https://github.com/mumoshu","followers_url":"https://api.github.com/users/mumoshu/followers","following_url":"https://api.github.com/users/mumoshu/following{/other_user}","gists_url":"https://api.github.com/users/mumoshu/gists{/gist_id}","starred_url":"https://api.github.com/users/mumoshu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumoshu/subscriptions","organizations_url":"https://api.github.com/users/mumoshu/orgs","repos_url":"https://api.github.com/users/mumoshu/repos","events_url":"https://api.github.com/users/mumoshu/events{/privacy}","received_events_url":"https://api.github.com/users/mumoshu/received_events","type":"User","site_admin":false},"created_at":"2017-08-21T00:51:36Z","updated_at":"2017-08-21T00:51:36Z","body":"@adyromantika LGTM. Thanks for the contribution 👍 "}}
{"actor":{"display_login":"mumoshu"}}