{"action":"created","comment":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/111004990","pull_request_review_id":32218519,"id":111004990,"diff_hunk":"@@ -146,9 +145,12 @@ public T acquire(Integer time, TimeUnit unit) {\n    * @param resource the resource to be released, it should not be reused after calling this method\n    */\n   public void release(T resource) {\n-    mResources.add(resource);\n-    try (LockResource r = new LockResource(mTakeLock)) {\n-      mNotEmpty.signal();\n+    if (resource != null) {\n+      mResources.add(resource);\n+      mCurrentCapacity.incrementAndGet();","path":"core/common/src/main/java/alluxio/resource/ResourcePool.java","position":26,"original_position":26,"commit_id":"763cd7b363ba9fd9d379860d9550c6c819775a81","original_commit_id":"763cd7b363ba9fd9d379860d9550c6c819775a81","user":{"login":"peisun1115","id":18294241,"avatar_url":"https://avatars2.githubusercontent.com/u/18294241?v=3","gravatar_id":"","url":"https://api.github.com/users/peisun1115","html_url":"https://github.com/peisun1115","followers_url":"https://api.github.com/users/peisun1115/followers","following_url":"https://api.github.com/users/peisun1115/following{/other_user}","gists_url":"https://api.github.com/users/peisun1115/gists{/gist_id}","starred_url":"https://api.github.com/users/peisun1115/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peisun1115/subscriptions","organizations_url":"https://api.github.com/users/peisun1115/orgs","repos_url":"https://api.github.com/users/peisun1115/repos","events_url":"https://api.github.com/users/peisun1115/events{/privacy}","received_events_url":"https://api.github.com/users/peisun1115/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2017-04-11T20:28:37Z","updated_at":"2017-04-11T20:28:42Z","html_url":"https://github.com/Alluxio/alluxio/pull/5140#discussion_r111004990","pull_request_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/5140","_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments/111004990"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/5140#discussion_r111004990"},"pull_request":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/5140"}}},"pull_request":{"url":"https://api.github.com/repos/Alluxio/alluxio/pulls/5140","id":115341255,"html_url":"https://github.com/Alluxio/alluxio/pull/5140","diff_url":"https://github.com/Alluxio/alluxio/pull/5140.diff","patch_url":"https://github.com/Alluxio/alluxio/pull/5140.patch","issue_url":"https://api.github.com/repos/Alluxio/alluxio/issues/5140","number":5140,"state":"open","locked":false,"title":"[ALLUXIO-2812] Fix some logical problems in ResourcePool","user":{"login":"Reidddddd","id":5352837,"avatar_url":"https://avatars2.githubusercontent.com/u/5352837?v=3","gravatar_id":"","url":"https://api.github.com/users/Reidddddd","html_url":"https://github.com/Reidddddd","followers_url":"https://api.github.com/users/Reidddddd/followers","following_url":"https://api.github.com/users/Reidddddd/following{/other_user}","gists_url":"https://api.github.com/users/Reidddddd/gists{/gist_id}","starred_url":"https://api.github.com/users/Reidddddd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reidddddd/subscriptions","organizations_url":"https://api.github.com/users/Reidddddd/orgs","repos_url":"https://api.github.com/users/Reidddddd/repos","events_url":"https://api.github.com/users/Reidddddd/events{/privacy}","received_events_url":"https://api.github.com/users/Reidddddd/received_events","type":"User","site_admin":false},"body":"https://alluxio.atlassian.net/browse/ALLUXIO-2812","created_at":"2017-04-11T14:57:27Z","updated_at":"2017-04-11T20:28:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"847deed04a59dd7b020ec9f14cee8633ff1d3dba","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/5140/commits","review_comments_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/5140/comments","review_comment_url":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/issues/5140/comments","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/763cd7b363ba9fd9d379860d9550c6c819775a81","head":{"label":"Reidddddd:alluxio-2812","ref":"alluxio-2812","sha":"763cd7b363ba9fd9d379860d9550c6c819775a81","user":{"login":"Reidddddd","id":5352837,"avatar_url":"https://avatars2.githubusercontent.com/u/5352837?v=3","gravatar_id":"","url":"https://api.github.com/users/Reidddddd","html_url":"https://github.com/Reidddddd","followers_url":"https://api.github.com/users/Reidddddd/followers","following_url":"https://api.github.com/users/Reidddddd/following{/other_user}","gists_url":"https://api.github.com/users/Reidddddd/gists{/gist_id}","starred_url":"https://api.github.com/users/Reidddddd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reidddddd/subscriptions","organizations_url":"https://api.github.com/users/Reidddddd/orgs","repos_url":"https://api.github.com/users/Reidddddd/repos","events_url":"https://api.github.com/users/Reidddddd/events{/privacy}","received_events_url":"https://api.github.com/users/Reidddddd/received_events","type":"User","site_admin":false},"repo":{"id":85531225,"name":"alluxio","full_name":"Reidddddd/alluxio","owner":{"login":"Reidddddd","id":5352837,"avatar_url":"https://avatars2.githubusercontent.com/u/5352837?v=3","gravatar_id":"","url":"https://api.github.com/users/Reidddddd","html_url":"https://github.com/Reidddddd","followers_url":"https://api.github.com/users/Reidddddd/followers","following_url":"https://api.github.com/users/Reidddddd/following{/other_user}","gists_url":"https://api.github.com/users/Reidddddd/gists{/gist_id}","starred_url":"https://api.github.com/users/Reidddddd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Reidddddd/subscriptions","organizations_url":"https://api.github.com/users/Reidddddd/orgs","repos_url":"https://api.github.com/users/Reidddddd/repos","events_url":"https://api.github.com/users/Reidddddd/events{/privacy}","received_events_url":"https://api.github.com/users/Reidddddd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Reidddddd/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":true,"url":"https://api.github.com/repos/Reidddddd/alluxio","forks_url":"https://api.github.com/repos/Reidddddd/alluxio/forks","keys_url":"https://api.github.com/repos/Reidddddd/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Reidddddd/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Reidddddd/alluxio/teams","hooks_url":"https://api.github.com/repos/Reidddddd/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Reidddddd/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Reidddddd/alluxio/events","assignees_url":"https://api.github.com/repos/Reidddddd/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Reidddddd/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Reidddddd/alluxio/tags","blobs_url":"https://api.github.com/repos/Reidddddd/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Reidddddd/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Reidddddd/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Reidddddd/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Reidddddd/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Reidddddd/alluxio/languages","stargazers_url":"https://api.github.com/repos/Reidddddd/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Reidddddd/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Reidddddd/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Reidddddd/alluxio/subscription","commits_url":"https://api.github.com/repos/Reidddddd/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Reidddddd/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Reidddddd/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Reidddddd/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Reidddddd/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Reidddddd/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Reidddddd/alluxio/merges","archive_url":"https://api.github.com/repos/Reidddddd/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Reidddddd/alluxio/downloads","issues_url":"https://api.github.com/repos/Reidddddd/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Reidddddd/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Reidddddd/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Reidddddd/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Reidddddd/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Reidddddd/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Reidddddd/alluxio/deployments","created_at":"2017-03-20T03:23:31Z","updated_at":"2017-03-20T03:23:38Z","pushed_at":"2017-04-11T14:54:36Z","git_url":"git://github.com/Reidddddd/alluxio.git","ssh_url":"git@github.com:Reidddddd/alluxio.git","clone_url":"https://github.com/Reidddddd/alluxio.git","svn_url":"https://github.com/Reidddddd/alluxio","homepage":"http://www.alluxio.org/","size":68134,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alluxio:master","ref":"master","sha":"b17578235a93f0d692c9e97d5afa8a2b0e1869bc","user":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars3.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"alluxio","full_name":"Alluxio/alluxio","owner":{"login":"Alluxio","id":16203694,"avatar_url":"https://avatars3.githubusercontent.com/u/16203694?v=3","gravatar_id":"","url":"https://api.github.com/users/Alluxio","html_url":"https://github.com/Alluxio","followers_url":"https://api.github.com/users/Alluxio/followers","following_url":"https://api.github.com/users/Alluxio/following{/other_user}","gists_url":"https://api.github.com/users/Alluxio/gists{/gist_id}","starred_url":"https://api.github.com/users/Alluxio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alluxio/subscriptions","organizations_url":"https://api.github.com/users/Alluxio/orgs","repos_url":"https://api.github.com/users/Alluxio/repos","events_url":"https://api.github.com/users/Alluxio/events{/privacy}","received_events_url":"https://api.github.com/users/Alluxio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alluxio/alluxio","description":"Alluxio, formerly Tachyon, Unify Data at Memory Speed","fork":false,"url":"https://api.github.com/repos/Alluxio/alluxio","forks_url":"https://api.github.com/repos/Alluxio/alluxio/forks","keys_url":"https://api.github.com/repos/Alluxio/alluxio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alluxio/alluxio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alluxio/alluxio/teams","hooks_url":"https://api.github.com/repos/Alluxio/alluxio/hooks","issue_events_url":"https://api.github.com/repos/Alluxio/alluxio/issues/events{/number}","events_url":"https://api.github.com/repos/Alluxio/alluxio/events","assignees_url":"https://api.github.com/repos/Alluxio/alluxio/assignees{/user}","branches_url":"https://api.github.com/repos/Alluxio/alluxio/branches{/branch}","tags_url":"https://api.github.com/repos/Alluxio/alluxio/tags","blobs_url":"https://api.github.com/repos/Alluxio/alluxio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alluxio/alluxio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alluxio/alluxio/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alluxio/alluxio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alluxio/alluxio/statuses/{sha}","languages_url":"https://api.github.com/repos/Alluxio/alluxio/languages","stargazers_url":"https://api.github.com/repos/Alluxio/alluxio/stargazers","contributors_url":"https://api.github.com/repos/Alluxio/alluxio/contributors","subscribers_url":"https://api.github.com/repos/Alluxio/alluxio/subscribers","subscription_url":"https://api.github.com/repos/Alluxio/alluxio/subscription","commits_url":"https://api.github.com/repos/Alluxio/alluxio/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alluxio/alluxio/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alluxio/alluxio/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alluxio/alluxio/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alluxio/alluxio/contents/{+path}","compare_url":"https://api.github.com/repos/Alluxio/alluxio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alluxio/alluxio/merges","archive_url":"https://api.github.com/repos/Alluxio/alluxio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alluxio/alluxio/downloads","issues_url":"https://api.github.com/repos/Alluxio/alluxio/issues{/number}","pulls_url":"https://api.github.com/repos/Alluxio/alluxio/pulls{/number}","milestones_url":"https://api.github.com/repos/Alluxio/alluxio/milestones{/number}","notifications_url":"https://api.github.com/repos/Alluxio/alluxio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alluxio/alluxio/labels{/name}","releases_url":"https://api.github.com/repos/Alluxio/alluxio/releases{/id}","deployments_url":"https://api.github.com/repos/Alluxio/alluxio/deployments","created_at":"2012-12-21T17:43:46Z","updated_at":"2017-04-10T08:18:42Z","pushed_at":"2017-04-11T20:22:39Z","git_url":"git://github.com/Alluxio/alluxio.git","ssh_url":"git@github.com:Alluxio/alluxio.git","clone_url":"https://github.com/Alluxio/alluxio.git","svn_url":"https://github.com/Alluxio/alluxio","homepage":"http://www.alluxio.org/","size":68267,"stargazers_count":2920,"watchers_count":2920,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1436,"mirror_url":null,"open_issues_count":56,"forks":1436,"open_issues":56,"watchers":2920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/5140"},"html":{"href":"https://github.com/Alluxio/alluxio/pull/5140"},"issue":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/5140"},"comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/issues/5140/comments"},"review_comments":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/5140/comments"},"review_comment":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alluxio/alluxio/pulls/5140/commits"},"statuses":{"href":"https://api.github.com/repos/Alluxio/alluxio/statuses/763cd7b363ba9fd9d379860d9550c6c819775a81"}}}}
{"actor":{"display_login":"peisun1115"}}