{"action":"closed","number":2414,"pull_request":{"url":"https://api.github.com/repos/dotnet/project-system/pulls/2414","id":124931235,"html_url":"https://github.com/dotnet/project-system/pull/2414","diff_url":"https://github.com/dotnet/project-system/pull/2414.diff","patch_url":"https://github.com/dotnet/project-system/pull/2414.patch","issue_url":"https://api.github.com/repos/dotnet/project-system/issues/2414","number":2414,"state":"closed","locked":false,"title":"Handle ref assemblies in up-to-date check","user":{"login":"panopticoncentral","id":684792,"avatar_url":"https://avatars3.githubusercontent.com/u/684792?v=3","gravatar_id":"","url":"https://api.github.com/users/panopticoncentral","html_url":"https://github.com/panopticoncentral","followers_url":"https://api.github.com/users/panopticoncentral/followers","following_url":"https://api.github.com/users/panopticoncentral/following{/other_user}","gists_url":"https://api.github.com/users/panopticoncentral/gists{/gist_id}","starred_url":"https://api.github.com/users/panopticoncentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panopticoncentral/subscriptions","organizations_url":"https://api.github.com/users/panopticoncentral/orgs","repos_url":"https://api.github.com/users/panopticoncentral/repos","events_url":"https://api.github.com/users/panopticoncentral/events{/privacy}","received_events_url":"https://api.github.com/users/panopticoncentral/received_events","type":"User","site_admin":false},"body":"**Customer scenario**\r\n\r\nGiven three projects that have a dependency as such: ClassLibrary1 -> ClassLibrary2 -> ConsoleApp1, if the two class libraries use the new ref assembly feature, then if ClassLibrary1's implementation is changed but not its ref assembly, the up to date check will think that ConsoleApp1 does not need to be rebuilt. It does, though, so it can copy an updated ClassLibrary1 implementation.\r\n\r\nWithout this change building projects with reference assemblies will be broken in the IDE. For Roslyn.sln we're seeing around 70% reduction in incremental build times with reference assemblies. So we want to take this change to enable such productivity enhancements.\r\n\r\n**Bugs this fixes:** \r\n\r\nFixes #2254 \r\n\r\n**Workarounds, if any**\r\n\r\nThe user would have to realize that one of their assemblies is out of date and do a rebuild.\r\n\r\n**Risk**\r\n\r\nLow. The marker file we depend on is only produced in the new ref assembly case, so it doesn't affect existing projects. Fast up to date checks can be turned off if needed.\r\n\r\n**Performance impact**\r\n\r\nLow. We check timestamps on a handful of extra files, small compared to the list of files we already check.\r\n\r\n**Is this a regression from a previous update?**\r\n\r\nNo.\r\n","created_at":"2017-06-09T19:05:48Z","updated_at":"2017-06-21T19:52:31Z","closed_at":"2017-06-21T19:52:31Z","merged_at":"2017-06-21T19:52:31Z","merge_commit_sha":"d2d39fcf980446d050e71eeedbed86fd0057abea","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/project-system/pulls/2414/commits","review_comments_url":"https://api.github.com/repos/dotnet/project-system/pulls/2414/comments","review_comment_url":"https://api.github.com/repos/dotnet/project-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/project-system/issues/2414/comments","statuses_url":"https://api.github.com/repos/dotnet/project-system/statuses/e88ebd5ded5685961e04fb0697c6b00e55bd1cf2","head":{"label":"panopticoncentral:refassem","ref":"refassem","sha":"e88ebd5ded5685961e04fb0697c6b00e55bd1cf2","user":{"login":"panopticoncentral","id":684792,"avatar_url":"https://avatars3.githubusercontent.com/u/684792?v=3","gravatar_id":"","url":"https://api.github.com/users/panopticoncentral","html_url":"https://github.com/panopticoncentral","followers_url":"https://api.github.com/users/panopticoncentral/followers","following_url":"https://api.github.com/users/panopticoncentral/following{/other_user}","gists_url":"https://api.github.com/users/panopticoncentral/gists{/gist_id}","starred_url":"https://api.github.com/users/panopticoncentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panopticoncentral/subscriptions","organizations_url":"https://api.github.com/users/panopticoncentral/orgs","repos_url":"https://api.github.com/users/panopticoncentral/repos","events_url":"https://api.github.com/users/panopticoncentral/events{/privacy}","received_events_url":"https://api.github.com/users/panopticoncentral/received_events","type":"User","site_admin":false},"repo":{"id":81486170,"name":"project-system","full_name":"panopticoncentral/project-system","owner":{"login":"panopticoncentral","id":684792,"avatar_url":"https://avatars3.githubusercontent.com/u/684792?v=3","gravatar_id":"","url":"https://api.github.com/users/panopticoncentral","html_url":"https://github.com/panopticoncentral","followers_url":"https://api.github.com/users/panopticoncentral/followers","following_url":"https://api.github.com/users/panopticoncentral/following{/other_user}","gists_url":"https://api.github.com/users/panopticoncentral/gists{/gist_id}","starred_url":"https://api.github.com/users/panopticoncentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panopticoncentral/subscriptions","organizations_url":"https://api.github.com/users/panopticoncentral/orgs","repos_url":"https://api.github.com/users/panopticoncentral/repos","events_url":"https://api.github.com/users/panopticoncentral/events{/privacy}","received_events_url":"https://api.github.com/users/panopticoncentral/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/panopticoncentral/project-system","description":"The C# and Visual Basic project system for Visual Studio \"15\"","fork":true,"url":"https://api.github.com/repos/panopticoncentral/project-system","forks_url":"https://api.github.com/repos/panopticoncentral/project-system/forks","keys_url":"https://api.github.com/repos/panopticoncentral/project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/panopticoncentral/project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/panopticoncentral/project-system/teams","hooks_url":"https://api.github.com/repos/panopticoncentral/project-system/hooks","issue_events_url":"https://api.github.com/repos/panopticoncentral/project-system/issues/events{/number}","events_url":"https://api.github.com/repos/panopticoncentral/project-system/events","assignees_url":"https://api.github.com/repos/panopticoncentral/project-system/assignees{/user}","branches_url":"https://api.github.com/repos/panopticoncentral/project-system/branches{/branch}","tags_url":"https://api.github.com/repos/panopticoncentral/project-system/tags","blobs_url":"https://api.github.com/repos/panopticoncentral/project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/panopticoncentral/project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/panopticoncentral/project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/panopticoncentral/project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/panopticoncentral/project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/panopticoncentral/project-system/languages","stargazers_url":"https://api.github.com/repos/panopticoncentral/project-system/stargazers","contributors_url":"https://api.github.com/repos/panopticoncentral/project-system/contributors","subscribers_url":"https://api.github.com/repos/panopticoncentral/project-system/subscribers","subscription_url":"https://api.github.com/repos/panopticoncentral/project-system/subscription","commits_url":"https://api.github.com/repos/panopticoncentral/project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/panopticoncentral/project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/panopticoncentral/project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/panopticoncentral/project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/panopticoncentral/project-system/contents/{+path}","compare_url":"https://api.github.com/repos/panopticoncentral/project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/panopticoncentral/project-system/merges","archive_url":"https://api.github.com/repos/panopticoncentral/project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/panopticoncentral/project-system/downloads","issues_url":"https://api.github.com/repos/panopticoncentral/project-system/issues{/number}","pulls_url":"https://api.github.com/repos/panopticoncentral/project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/panopticoncentral/project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/panopticoncentral/project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/panopticoncentral/project-system/labels{/name}","releases_url":"https://api.github.com/repos/panopticoncentral/project-system/releases{/id}","deployments_url":"https://api.github.com/repos/panopticoncentral/project-system/deployments","created_at":"2017-02-09T19:22:10Z","updated_at":"2017-04-04T21:12:29Z","pushed_at":"2017-06-21T06:25:47Z","git_url":"git://github.com/panopticoncentral/project-system.git","ssh_url":"git@github.com:panopticoncentral/project-system.git","clone_url":"https://github.com/panopticoncentral/project-system.git","svn_url":"https://github.com/panopticoncentral/project-system","homepage":null,"size":15030,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c4d33ee930e61548986a959b0d2b90a8e71a2a68","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":56740275,"name":"project-system","full_name":"dotnet/project-system","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/project-system","description":"The C#, F# and Visual Basic project system for Visual Studio","fork":false,"url":"https://api.github.com/repos/dotnet/project-system","forks_url":"https://api.github.com/repos/dotnet/project-system/forks","keys_url":"https://api.github.com/repos/dotnet/project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/project-system/teams","hooks_url":"https://api.github.com/repos/dotnet/project-system/hooks","issue_events_url":"https://api.github.com/repos/dotnet/project-system/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/project-system/events","assignees_url":"https://api.github.com/repos/dotnet/project-system/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/project-system/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/project-system/tags","blobs_url":"https://api.github.com/repos/dotnet/project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/project-system/languages","stargazers_url":"https://api.github.com/repos/dotnet/project-system/stargazers","contributors_url":"https://api.github.com/repos/dotnet/project-system/contributors","subscribers_url":"https://api.github.com/repos/dotnet/project-system/subscribers","subscription_url":"https://api.github.com/repos/dotnet/project-system/subscription","commits_url":"https://api.github.com/repos/dotnet/project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/project-system/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/project-system/merges","archive_url":"https://api.github.com/repos/dotnet/project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/project-system/downloads","issues_url":"https://api.github.com/repos/dotnet/project-system/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/project-system/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/project-system/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/project-system/deployments","created_at":"2016-04-21T03:40:18Z","updated_at":"2017-06-16T15:57:27Z","pushed_at":"2017-06-21T19:52:31Z","git_url":"git://github.com/dotnet/project-system.git","ssh_url":"git@github.com:dotnet/project-system.git","clone_url":"https://github.com/dotnet/project-system.git","svn_url":"https://github.com/dotnet/project-system","homepage":"","size":15165,"stargazers_count":248,"watchers_count":248,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":86,"mirror_url":null,"open_issues_count":420,"forks":86,"open_issues":420,"watchers":248,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/2414"},"html":{"href":"https://github.com/dotnet/project-system/pull/2414"},"issue":{"href":"https://api.github.com/repos/dotnet/project-system/issues/2414"},"comments":{"href":"https://api.github.com/repos/dotnet/project-system/issues/2414/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/2414/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/2414/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/project-system/statuses/e88ebd5ded5685961e04fb0697c6b00e55bd1cf2"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"panopticoncentral","id":684792,"avatar_url":"https://avatars3.githubusercontent.com/u/684792?v=3","gravatar_id":"","url":"https://api.github.com/users/panopticoncentral","html_url":"https://github.com/panopticoncentral","followers_url":"https://api.github.com/users/panopticoncentral/followers","following_url":"https://api.github.com/users/panopticoncentral/following{/other_user}","gists_url":"https://api.github.com/users/panopticoncentral/gists{/gist_id}","starred_url":"https://api.github.com/users/panopticoncentral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panopticoncentral/subscriptions","organizations_url":"https://api.github.com/users/panopticoncentral/orgs","repos_url":"https://api.github.com/users/panopticoncentral/repos","events_url":"https://api.github.com/users/panopticoncentral/events{/privacy}","received_events_url":"https://api.github.com/users/panopticoncentral/received_events","type":"User","site_admin":false},"comments":12,"review_comments":6,"maintainer_can_modify":false,"commits":7,"additions":212,"deletions":38,"changed_files":8}}
{"actor":{"display_login":"panopticoncentral"}}