{"action":"created","comment":{"url":"https://api.github.com/repos/ros/geometry2/pulls/comments/108009582","pull_request_review_id":29021074,"id":108009582,"diff_hunk":"@@ -8,13 +8,13 @@\n   <license>BSD</license>\n \n   <buildtool_depend>catkin</buildtool_depend>\n+\n+  <build_depend>cmake_modules</build_depend>\n   <build_depend>eigen</build_depend>\n   <build_depend>geometry_msgs</build_depend>\n   <build_depend>tf2</build_depend>\n-  <build_depend>cmake_modules</build_depend>\n \n-  <run_depend>geometry_msgs</run_depend>\n-  <run_depend>tf2</run_depend>\n-  <run_depend>cmake_modules</run_depend>\n+  <exec_depend>geometry_msgs</exec_depend>","path":"tf2_eigen/package.xml","position":21,"original_position":21,"commit_id":"ebee945f177ad6ae88445331da0dc2a1215d91ac","original_commit_id":"ebee945f177ad6ae88445331da0dc2a1215d91ac","user":{"login":"tfoote","id":447804,"avatar_url":"https://avatars0.githubusercontent.com/u/447804?v=3","gravatar_id":"","url":"https://api.github.com/users/tfoote","html_url":"https://github.com/tfoote","followers_url":"https://api.github.com/users/tfoote/followers","following_url":"https://api.github.com/users/tfoote/following{/other_user}","gists_url":"https://api.github.com/users/tfoote/gists{/gist_id}","starred_url":"https://api.github.com/users/tfoote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfoote/subscriptions","organizations_url":"https://api.github.com/users/tfoote/orgs","repos_url":"https://api.github.com/users/tfoote/repos","events_url":"https://api.github.com/users/tfoote/events{/privacy}","received_events_url":"https://api.github.com/users/tfoote/received_events","type":"User","site_admin":false},"body":"geometry_msgs and tf2 also needs the `<build_export_depend>` because of the includes in the headers. http://docs.ros.org/kinetic/api/catkin/html/howto/format2/migrating_from_format_1.html#run-depend\r\n\r\nBut since they overlap with the build depends it can be collapsed to just a `<depend>` . ","created_at":"2017-03-24T22:17:31Z","updated_at":"2017-03-24T22:19:27Z","html_url":"https://github.com/ros/geometry2/pull/216#discussion_r108009582","pull_request_url":"https://api.github.com/repos/ros/geometry2/pulls/216","_links":{"self":{"href":"https://api.github.com/repos/ros/geometry2/pulls/comments/108009582"},"html":{"href":"https://github.com/ros/geometry2/pull/216#discussion_r108009582"},"pull_request":{"href":"https://api.github.com/repos/ros/geometry2/pulls/216"}}},"pull_request":{"url":"https://api.github.com/repos/ros/geometry2/pulls/216","id":112530148,"html_url":"https://github.com/ros/geometry2/pull/216","diff_url":"https://github.com/ros/geometry2/pull/216.diff","patch_url":"https://github.com/ros/geometry2/pull/216.patch","issue_url":"https://api.github.com/repos/ros/geometry2/issues/216","number":216,"state":"open","locked":false,"title":"Switch tf2_eigen to use package.xml format 2.","user":{"login":"clalancette","id":163000,"avatar_url":"https://avatars3.githubusercontent.com/u/163000?v=3","gravatar_id":"","url":"https://api.github.com/users/clalancette","html_url":"https://github.com/clalancette","followers_url":"https://api.github.com/users/clalancette/followers","following_url":"https://api.github.com/users/clalancette/following{/other_user}","gists_url":"https://api.github.com/users/clalancette/gists{/gist_id}","starred_url":"https://api.github.com/users/clalancette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clalancette/subscriptions","organizations_url":"https://api.github.com/users/clalancette/orgs","repos_url":"https://api.github.com/users/clalancette/repos","events_url":"https://api.github.com/users/clalancette/events{/privacy}","received_events_url":"https://api.github.com/users/clalancette/received_events","type":"User","site_admin":false},"body":"This is to modernize it a bit to make it more compatible\r\nwith ROS 2.  While we are in here, remove the run/exec dependency\r\non cmake_modules, which doesn't seem to be needed at runtime.\r\n\r\nSigned-off-by: Chris Lalancette <clalancette@osrfoundation.org>","created_at":"2017-03-24T19:45:45Z","updated_at":"2017-03-24T22:19:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c78429b003efeb97a17f69f462717c5ed507340","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros/geometry2/pulls/216/commits","review_comments_url":"https://api.github.com/repos/ros/geometry2/pulls/216/comments","review_comment_url":"https://api.github.com/repos/ros/geometry2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros/geometry2/issues/216/comments","statuses_url":"https://api.github.com/repos/ros/geometry2/statuses/ebee945f177ad6ae88445331da0dc2a1215d91ac","head":{"label":"clalancette:package-xml-format-2","ref":"package-xml-format-2","sha":"ebee945f177ad6ae88445331da0dc2a1215d91ac","user":{"login":"clalancette","id":163000,"avatar_url":"https://avatars3.githubusercontent.com/u/163000?v=3","gravatar_id":"","url":"https://api.github.com/users/clalancette","html_url":"https://github.com/clalancette","followers_url":"https://api.github.com/users/clalancette/followers","following_url":"https://api.github.com/users/clalancette/following{/other_user}","gists_url":"https://api.github.com/users/clalancette/gists{/gist_id}","starred_url":"https://api.github.com/users/clalancette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clalancette/subscriptions","organizations_url":"https://api.github.com/users/clalancette/orgs","repos_url":"https://api.github.com/users/clalancette/repos","events_url":"https://api.github.com/users/clalancette/events{/privacy}","received_events_url":"https://api.github.com/users/clalancette/received_events","type":"User","site_admin":false},"repo":{"id":86104574,"name":"geometry2","full_name":"clalancette/geometry2","owner":{"login":"clalancette","id":163000,"avatar_url":"https://avatars3.githubusercontent.com/u/163000?v=3","gravatar_id":"","url":"https://api.github.com/users/clalancette","html_url":"https://github.com/clalancette","followers_url":"https://api.github.com/users/clalancette/followers","following_url":"https://api.github.com/users/clalancette/following{/other_user}","gists_url":"https://api.github.com/users/clalancette/gists{/gist_id}","starred_url":"https://api.github.com/users/clalancette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clalancette/subscriptions","organizations_url":"https://api.github.com/users/clalancette/orgs","repos_url":"https://api.github.com/users/clalancette/repos","events_url":"https://api.github.com/users/clalancette/events{/privacy}","received_events_url":"https://api.github.com/users/clalancette/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clalancette/geometry2","description":"A set of ROS packages for keeping track of coordinate transforms.","fork":true,"url":"https://api.github.com/repos/clalancette/geometry2","forks_url":"https://api.github.com/repos/clalancette/geometry2/forks","keys_url":"https://api.github.com/repos/clalancette/geometry2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clalancette/geometry2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clalancette/geometry2/teams","hooks_url":"https://api.github.com/repos/clalancette/geometry2/hooks","issue_events_url":"https://api.github.com/repos/clalancette/geometry2/issues/events{/number}","events_url":"https://api.github.com/repos/clalancette/geometry2/events","assignees_url":"https://api.github.com/repos/clalancette/geometry2/assignees{/user}","branches_url":"https://api.github.com/repos/clalancette/geometry2/branches{/branch}","tags_url":"https://api.github.com/repos/clalancette/geometry2/tags","blobs_url":"https://api.github.com/repos/clalancette/geometry2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clalancette/geometry2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clalancette/geometry2/git/refs{/sha}","trees_url":"https://api.github.com/repos/clalancette/geometry2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clalancette/geometry2/statuses/{sha}","languages_url":"https://api.github.com/repos/clalancette/geometry2/languages","stargazers_url":"https://api.github.com/repos/clalancette/geometry2/stargazers","contributors_url":"https://api.github.com/repos/clalancette/geometry2/contributors","subscribers_url":"https://api.github.com/repos/clalancette/geometry2/subscribers","subscription_url":"https://api.github.com/repos/clalancette/geometry2/subscription","commits_url":"https://api.github.com/repos/clalancette/geometry2/commits{/sha}","git_commits_url":"https://api.github.com/repos/clalancette/geometry2/git/commits{/sha}","comments_url":"https://api.github.com/repos/clalancette/geometry2/comments{/number}","issue_comment_url":"https://api.github.com/repos/clalancette/geometry2/issues/comments{/number}","contents_url":"https://api.github.com/repos/clalancette/geometry2/contents/{+path}","compare_url":"https://api.github.com/repos/clalancette/geometry2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clalancette/geometry2/merges","archive_url":"https://api.github.com/repos/clalancette/geometry2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clalancette/geometry2/downloads","issues_url":"https://api.github.com/repos/clalancette/geometry2/issues{/number}","pulls_url":"https://api.github.com/repos/clalancette/geometry2/pulls{/number}","milestones_url":"https://api.github.com/repos/clalancette/geometry2/milestones{/number}","notifications_url":"https://api.github.com/repos/clalancette/geometry2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clalancette/geometry2/labels{/name}","releases_url":"https://api.github.com/repos/clalancette/geometry2/releases{/id}","deployments_url":"https://api.github.com/repos/clalancette/geometry2/deployments","created_at":"2017-03-24T19:38:50Z","updated_at":"2017-03-24T19:38:51Z","pushed_at":"2017-03-24T19:44:44Z","git_url":"git://github.com/clalancette/geometry2.git","ssh_url":"git@github.com:clalancette/geometry2.git","clone_url":"https://github.com/clalancette/geometry2.git","svn_url":"https://github.com/clalancette/geometry2","homepage":"","size":2094,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"indigo-devel"}},"base":{"label":"ros:indigo-devel","ref":"indigo-devel","sha":"120a532abf7d7f315141ab5f75408cfcbf2386ae","user":{"login":"ros","id":547448,"avatar_url":"https://avatars1.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":7449056,"name":"geometry2","full_name":"ros/geometry2","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars1.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/geometry2","description":"A set of ROS packages for keeping track of coordinate transforms.","fork":false,"url":"https://api.github.com/repos/ros/geometry2","forks_url":"https://api.github.com/repos/ros/geometry2/forks","keys_url":"https://api.github.com/repos/ros/geometry2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/geometry2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/geometry2/teams","hooks_url":"https://api.github.com/repos/ros/geometry2/hooks","issue_events_url":"https://api.github.com/repos/ros/geometry2/issues/events{/number}","events_url":"https://api.github.com/repos/ros/geometry2/events","assignees_url":"https://api.github.com/repos/ros/geometry2/assignees{/user}","branches_url":"https://api.github.com/repos/ros/geometry2/branches{/branch}","tags_url":"https://api.github.com/repos/ros/geometry2/tags","blobs_url":"https://api.github.com/repos/ros/geometry2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/geometry2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/geometry2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/geometry2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/geometry2/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/geometry2/languages","stargazers_url":"https://api.github.com/repos/ros/geometry2/stargazers","contributors_url":"https://api.github.com/repos/ros/geometry2/contributors","subscribers_url":"https://api.github.com/repos/ros/geometry2/subscribers","subscription_url":"https://api.github.com/repos/ros/geometry2/subscription","commits_url":"https://api.github.com/repos/ros/geometry2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/geometry2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/geometry2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/geometry2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/geometry2/contents/{+path}","compare_url":"https://api.github.com/repos/ros/geometry2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/geometry2/merges","archive_url":"https://api.github.com/repos/ros/geometry2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/geometry2/downloads","issues_url":"https://api.github.com/repos/ros/geometry2/issues{/number}","pulls_url":"https://api.github.com/repos/ros/geometry2/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/geometry2/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/geometry2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/geometry2/labels{/name}","releases_url":"https://api.github.com/repos/ros/geometry2/releases{/id}","deployments_url":"https://api.github.com/repos/ros/geometry2/deployments","created_at":"2013-01-04T23:33:06Z","updated_at":"2017-03-14T06:56:31Z","pushed_at":"2017-03-24T19:45:46Z","git_url":"git://github.com/ros/geometry2.git","ssh_url":"git@github.com:ros/geometry2.git","clone_url":"https://github.com/ros/geometry2.git","svn_url":"https://github.com/ros/geometry2","homepage":"","size":2093,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":40,"forks":70,"open_issues":40,"watchers":22,"default_branch":"indigo-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros/geometry2/pulls/216"},"html":{"href":"https://github.com/ros/geometry2/pull/216"},"issue":{"href":"https://api.github.com/repos/ros/geometry2/issues/216"},"comments":{"href":"https://api.github.com/repos/ros/geometry2/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/ros/geometry2/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/ros/geometry2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros/geometry2/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/ros/geometry2/statuses/ebee945f177ad6ae88445331da0dc2a1215d91ac"}}}}
{"actor":{"display_login":"tfoote"}}