{"action":"created","comment":{"url":"https://api.github.com/repos/PagerNation/Escalator-API/pulls/comments/110554812","pull_request_review_id":31736310,"id":110554812,"diff_hunk":"@@ -77,8 +77,8 @@ function removeUser(group, userId) {\n \n function makeJoinRequest(groupName, userId) {\n   return userService.exists(userId)\n-    .then(() => JoiHelper.validate(userId, ID_SCHEMA))\n-    .then(id => Group.makeJoinRequest(groupName, id));\n+    .then(() => Promise.all([JoiHelper.validate(userId, ID_SCHEMA), getGroup(groupName)]))","path":"server/services/group.js","position":6,"original_position":6,"commit_id":"43efdb4f3bbf2434375dd909fb3db8b5d57c463f","original_commit_id":"43efdb4f3bbf2434375dd909fb3db8b5d57c463f","user":{"login":"kalebdavis","id":6809736,"avatar_url":"https://avatars0.githubusercontent.com/u/6809736?v=3","gravatar_id":"","url":"https://api.github.com/users/kalebdavis","html_url":"https://github.com/kalebdavis","followers_url":"https://api.github.com/users/kalebdavis/followers","following_url":"https://api.github.com/users/kalebdavis/following{/other_user}","gists_url":"https://api.github.com/users/kalebdavis/gists{/gist_id}","starred_url":"https://api.github.com/users/kalebdavis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalebdavis/subscriptions","organizations_url":"https://api.github.com/users/kalebdavis/orgs","repos_url":"https://api.github.com/users/kalebdavis/repos","events_url":"https://api.github.com/users/kalebdavis/events{/privacy}","received_events_url":"https://api.github.com/users/kalebdavis/received_events","type":"User","site_admin":false},"body":"Weird nit: can you change the order of these promises so the next line uses the results in order? I think it'd be just a tiny bit more readable","created_at":"2017-04-09T22:40:32Z","updated_at":"2017-04-09T22:41:19Z","html_url":"https://github.com/PagerNation/Escalator-API/pull/85#discussion_r110554812","pull_request_url":"https://api.github.com/repos/PagerNation/Escalator-API/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/PagerNation/Escalator-API/pulls/comments/110554812"},"html":{"href":"https://github.com/PagerNation/Escalator-API/pull/85#discussion_r110554812"},"pull_request":{"href":"https://api.github.com/repos/PagerNation/Escalator-API/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/PagerNation/Escalator-API/pulls/85","id":115004749,"html_url":"https://github.com/PagerNation/Escalator-API/pull/85","diff_url":"https://github.com/PagerNation/Escalator-API/pull/85.diff","patch_url":"https://github.com/PagerNation/Escalator-API/pull/85.patch","issue_url":"https://api.github.com/repos/PagerNation/Escalator-API/issues/85","number":85,"state":"open","locked":false,"title":"Fix duplicate join requests","user":{"login":"jarrydlee","id":5650600,"avatar_url":"https://avatars0.githubusercontent.com/u/5650600?v=3","gravatar_id":"","url":"https://api.github.com/users/jarrydlee","html_url":"https://github.com/jarrydlee","followers_url":"https://api.github.com/users/jarrydlee/followers","following_url":"https://api.github.com/users/jarrydlee/following{/other_user}","gists_url":"https://api.github.com/users/jarrydlee/gists{/gist_id}","starred_url":"https://api.github.com/users/jarrydlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jarrydlee/subscriptions","organizations_url":"https://api.github.com/users/jarrydlee/orgs","repos_url":"https://api.github.com/users/jarrydlee/repos","events_url":"https://api.github.com/users/jarrydlee/events{/privacy}","received_events_url":"https://api.github.com/users/jarrydlee/received_events","type":"User","site_admin":false},"body":"fixes https://github.com/PagerNation/Escalator-API/issues/74","created_at":"2017-04-09T22:21:14Z","updated_at":"2017-04-09T22:41:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2313cff46f757a3adf6d4279f6c8218d2bef721","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PagerNation/Escalator-API/pulls/85/commits","review_comments_url":"https://api.github.com/repos/PagerNation/Escalator-API/pulls/85/comments","review_comment_url":"https://api.github.com/repos/PagerNation/Escalator-API/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PagerNation/Escalator-API/issues/85/comments","statuses_url":"https://api.github.com/repos/PagerNation/Escalator-API/statuses/43efdb4f3bbf2434375dd909fb3db8b5d57c463f","head":{"label":"PagerNation:fix-duplicate-join-reqs","ref":"fix-duplicate-join-reqs","sha":"43efdb4f3bbf2434375dd909fb3db8b5d57c463f","user":{"login":"PagerNation","id":22669519,"avatar_url":"https://avatars0.githubusercontent.com/u/22669519?v=3","gravatar_id":"","url":"https://api.github.com/users/PagerNation","html_url":"https://github.com/PagerNation","followers_url":"https://api.github.com/users/PagerNation/followers","following_url":"https://api.github.com/users/PagerNation/following{/other_user}","gists_url":"https://api.github.com/users/PagerNation/gists{/gist_id}","starred_url":"https://api.github.com/users/PagerNation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PagerNation/subscriptions","organizations_url":"https://api.github.com/users/PagerNation/orgs","repos_url":"https://api.github.com/users/PagerNation/repos","events_url":"https://api.github.com/users/PagerNation/events{/privacy}","received_events_url":"https://api.github.com/users/PagerNation/received_events","type":"Organization","site_admin":false},"repo":{"id":70527288,"name":"Escalator-API","full_name":"PagerNation/Escalator-API","owner":{"login":"PagerNation","id":22669519,"avatar_url":"https://avatars0.githubusercontent.com/u/22669519?v=3","gravatar_id":"","url":"https://api.github.com/users/PagerNation","html_url":"https://github.com/PagerNation","followers_url":"https://api.github.com/users/PagerNation/followers","following_url":"https://api.github.com/users/PagerNation/following{/other_user}","gists_url":"https://api.github.com/users/PagerNation/gists{/gist_id}","starred_url":"https://api.github.com/users/PagerNation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PagerNation/subscriptions","organizations_url":"https://api.github.com/users/PagerNation/orgs","repos_url":"https://api.github.com/users/PagerNation/repos","events_url":"https://api.github.com/users/PagerNation/events{/privacy}","received_events_url":"https://api.github.com/users/PagerNation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PagerNation/Escalator-API","description":null,"fork":false,"url":"https://api.github.com/repos/PagerNation/Escalator-API","forks_url":"https://api.github.com/repos/PagerNation/Escalator-API/forks","keys_url":"https://api.github.com/repos/PagerNation/Escalator-API/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PagerNation/Escalator-API/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PagerNation/Escalator-API/teams","hooks_url":"https://api.github.com/repos/PagerNation/Escalator-API/hooks","issue_events_url":"https://api.github.com/repos/PagerNation/Escalator-API/issues/events{/number}","events_url":"https://api.github.com/repos/PagerNation/Escalator-API/events","assignees_url":"https://api.github.com/repos/PagerNation/Escalator-API/assignees{/user}","branches_url":"https://api.github.com/repos/PagerNation/Escalator-API/branches{/branch}","tags_url":"https://api.github.com/repos/PagerNation/Escalator-API/tags","blobs_url":"https://api.github.com/repos/PagerNation/Escalator-API/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PagerNation/Escalator-API/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PagerNation/Escalator-API/git/refs{/sha}","trees_url":"https://api.github.com/repos/PagerNation/Escalator-API/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PagerNation/Escalator-API/statuses/{sha}","languages_url":"https://api.github.com/repos/PagerNation/Escalator-API/languages","stargazers_url":"https://api.github.com/repos/PagerNation/Escalator-API/stargazers","contributors_url":"https://api.github.com/repos/PagerNation/Escalator-API/contributors","subscribers_url":"https://api.github.com/repos/PagerNation/Escalator-API/subscribers","subscription_url":"https://api.github.com/repos/PagerNation/Escalator-API/subscription","commits_url":"https://api.github.com/repos/PagerNation/Escalator-API/commits{/sha}","git_commits_url":"https://api.github.com/repos/PagerNation/Escalator-API/git/commits{/sha}","comments_url":"https://api.github.com/repos/PagerNation/Escalator-API/comments{/number}","issue_comment_url":"https://api.github.com/repos/PagerNation/Escalator-API/issues/comments{/number}","contents_url":"https://api.github.com/repos/PagerNation/Escalator-API/contents/{+path}","compare_url":"https://api.github.com/repos/PagerNation/Escalator-API/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PagerNation/Escalator-API/merges","archive_url":"https://api.github.com/repos/PagerNation/Escalator-API/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PagerNation/Escalator-API/downloads","issues_url":"https://api.github.com/repos/PagerNation/Escalator-API/issues{/number}","pulls_url":"https://api.github.com/repos/PagerNation/Escalator-API/pulls{/number}","milestones_url":"https://api.github.com/repos/PagerNation/Escalator-API/milestones{/number}","notifications_url":"https://api.github.com/repos/PagerNation/Escalator-API/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PagerNation/Escalator-API/labels{/name}","releases_url":"https://api.github.com/repos/PagerNation/Escalator-API/releases{/id}","deployments_url":"https://api.github.com/repos/PagerNation/Escalator-API/deployments","created_at":"2016-10-10T20:44:59Z","updated_at":"2017-03-03T17:12:08Z","pushed_at":"2017-04-09T22:29:12Z","git_url":"git://github.com/PagerNation/Escalator-API.git","ssh_url":"git@github.com:PagerNation/Escalator-API.git","clone_url":"https://github.com/PagerNation/Escalator-API.git","svn_url":"https://github.com/PagerNation/Escalator-API","homepage":null,"size":236,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"PagerNation:master","ref":"master","sha":"a9af34b768584be45b30dc3e745f1a228d8eddec","user":{"login":"PagerNation","id":22669519,"avatar_url":"https://avatars0.githubusercontent.com/u/22669519?v=3","gravatar_id":"","url":"https://api.github.com/users/PagerNation","html_url":"https://github.com/PagerNation","followers_url":"https://api.github.com/users/PagerNation/followers","following_url":"https://api.github.com/users/PagerNation/following{/other_user}","gists_url":"https://api.github.com/users/PagerNation/gists{/gist_id}","starred_url":"https://api.github.com/users/PagerNation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PagerNation/subscriptions","organizations_url":"https://api.github.com/users/PagerNation/orgs","repos_url":"https://api.github.com/users/PagerNation/repos","events_url":"https://api.github.com/users/PagerNation/events{/privacy}","received_events_url":"https://api.github.com/users/PagerNation/received_events","type":"Organization","site_admin":false},"repo":{"id":70527288,"name":"Escalator-API","full_name":"PagerNation/Escalator-API","owner":{"login":"PagerNation","id":22669519,"avatar_url":"https://avatars0.githubusercontent.com/u/22669519?v=3","gravatar_id":"","url":"https://api.github.com/users/PagerNation","html_url":"https://github.com/PagerNation","followers_url":"https://api.github.com/users/PagerNation/followers","following_url":"https://api.github.com/users/PagerNation/following{/other_user}","gists_url":"https://api.github.com/users/PagerNation/gists{/gist_id}","starred_url":"https://api.github.com/users/PagerNation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PagerNation/subscriptions","organizations_url":"https://api.github.com/users/PagerNation/orgs","repos_url":"https://api.github.com/users/PagerNation/repos","events_url":"https://api.github.com/users/PagerNation/events{/privacy}","received_events_url":"https://api.github.com/users/PagerNation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PagerNation/Escalator-API","description":null,"fork":false,"url":"https://api.github.com/repos/PagerNation/Escalator-API","forks_url":"https://api.github.com/repos/PagerNation/Escalator-API/forks","keys_url":"https://api.github.com/repos/PagerNation/Escalator-API/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PagerNation/Escalator-API/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PagerNation/Escalator-API/teams","hooks_url":"https://api.github.com/repos/PagerNation/Escalator-API/hooks","issue_events_url":"https://api.github.com/repos/PagerNation/Escalator-API/issues/events{/number}","events_url":"https://api.github.com/repos/PagerNation/Escalator-API/events","assignees_url":"https://api.github.com/repos/PagerNation/Escalator-API/assignees{/user}","branches_url":"https://api.github.com/repos/PagerNation/Escalator-API/branches{/branch}","tags_url":"https://api.github.com/repos/PagerNation/Escalator-API/tags","blobs_url":"https://api.github.com/repos/PagerNation/Escalator-API/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PagerNation/Escalator-API/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PagerNation/Escalator-API/git/refs{/sha}","trees_url":"https://api.github.com/repos/PagerNation/Escalator-API/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PagerNation/Escalator-API/statuses/{sha}","languages_url":"https://api.github.com/repos/PagerNation/Escalator-API/languages","stargazers_url":"https://api.github.com/repos/PagerNation/Escalator-API/stargazers","contributors_url":"https://api.github.com/repos/PagerNation/Escalator-API/contributors","subscribers_url":"https://api.github.com/repos/PagerNation/Escalator-API/subscribers","subscription_url":"https://api.github.com/repos/PagerNation/Escalator-API/subscription","commits_url":"https://api.github.com/repos/PagerNation/Escalator-API/commits{/sha}","git_commits_url":"https://api.github.com/repos/PagerNation/Escalator-API/git/commits{/sha}","comments_url":"https://api.github.com/repos/PagerNation/Escalator-API/comments{/number}","issue_comment_url":"https://api.github.com/repos/PagerNation/Escalator-API/issues/comments{/number}","contents_url":"https://api.github.com/repos/PagerNation/Escalator-API/contents/{+path}","compare_url":"https://api.github.com/repos/PagerNation/Escalator-API/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PagerNation/Escalator-API/merges","archive_url":"https://api.github.com/repos/PagerNation/Escalator-API/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PagerNation/Escalator-API/downloads","issues_url":"https://api.github.com/repos/PagerNation/Escalator-API/issues{/number}","pulls_url":"https://api.github.com/repos/PagerNation/Escalator-API/pulls{/number}","milestones_url":"https://api.github.com/repos/PagerNation/Escalator-API/milestones{/number}","notifications_url":"https://api.github.com/repos/PagerNation/Escalator-API/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PagerNation/Escalator-API/labels{/name}","releases_url":"https://api.github.com/repos/PagerNation/Escalator-API/releases{/id}","deployments_url":"https://api.github.com/repos/PagerNation/Escalator-API/deployments","created_at":"2016-10-10T20:44:59Z","updated_at":"2017-03-03T17:12:08Z","pushed_at":"2017-04-09T22:29:12Z","git_url":"git://github.com/PagerNation/Escalator-API.git","ssh_url":"git@github.com:PagerNation/Escalator-API.git","clone_url":"https://github.com/PagerNation/Escalator-API.git","svn_url":"https://github.com/PagerNation/Escalator-API","homepage":null,"size":236,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PagerNation/Escalator-API/pulls/85"},"html":{"href":"https://github.com/PagerNation/Escalator-API/pull/85"},"issue":{"href":"https://api.github.com/repos/PagerNation/Escalator-API/issues/85"},"comments":{"href":"https://api.github.com/repos/PagerNation/Escalator-API/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/PagerNation/Escalator-API/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/PagerNation/Escalator-API/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PagerNation/Escalator-API/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/PagerNation/Escalator-API/statuses/43efdb4f3bbf2434375dd909fb3db8b5d57c463f"}}}}
{"actor":{"display_login":"kalebdavis"}}