{"action":"closed","number":11243,"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/11243","id":137570025,"html_url":"https://github.com/highfidelity/hifi/pull/11243","diff_url":"https://github.com/highfidelity/hifi/pull/11243.diff","patch_url":"https://github.com/highfidelity/hifi/pull/11243.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/11243","number":11243,"state":"closed","locked":false,"title":"Fix ray pick crash on shutdown","user":{"login":"SamGondelman","id":7650116,"avatar_url":"https://avatars1.githubusercontent.com/u/7650116?v=4","gravatar_id":"","url":"https://api.github.com/users/SamGondelman","html_url":"https://github.com/SamGondelman","followers_url":"https://api.github.com/users/SamGondelman/followers","following_url":"https://api.github.com/users/SamGondelman/following{/other_user}","gists_url":"https://api.github.com/users/SamGondelman/gists{/gist_id}","starred_url":"https://api.github.com/users/SamGondelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamGondelman/subscriptions","organizations_url":"https://api.github.com/users/SamGondelman/orgs","repos_url":"https://api.github.com/users/SamGondelman/repos","events_url":"https://api.github.com/users/SamGondelman/events{/privacy}","received_events_url":"https://api.github.com/users/SamGondelman/received_events","type":"User","site_admin":false},"body":"[FB7202](https://highfidelity.fogbugz.com/f/cases/7202/mac-interface-crash-on-quit-within-RayPickManager-removeRayPick)\r\n\r\nThe destructor for LaserPointerManager needs to be called before the destructor for RayPickManager.\r\n\r\nTest plan:\r\n- Shouldn't crash on shutdown (on fresh install?), on mac or windows.","created_at":"2017-08-24T23:03:06Z","updated_at":"2017-08-25T16:01:14Z","closed_at":"2017-08-25T16:01:14Z","merged_at":"2017-08-25T16:01:14Z","merge_commit_sha":"4d7700b774afff9434cdff7dd3e0dcecd263469f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/11243/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/11243/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/11243/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/abaccf9edd3e3e84525c97b1ac1dab13aae9f612","head":{"label":"SamGondelman:sharks","ref":"sharks","sha":"abaccf9edd3e3e84525c97b1ac1dab13aae9f612","user":{"login":"SamGondelman","id":7650116,"avatar_url":"https://avatars1.githubusercontent.com/u/7650116?v=4","gravatar_id":"","url":"https://api.github.com/users/SamGondelman","html_url":"https://github.com/SamGondelman","followers_url":"https://api.github.com/users/SamGondelman/followers","following_url":"https://api.github.com/users/SamGondelman/following{/other_user}","gists_url":"https://api.github.com/users/SamGondelman/gists{/gist_id}","starred_url":"https://api.github.com/users/SamGondelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamGondelman/subscriptions","organizations_url":"https://api.github.com/users/SamGondelman/orgs","repos_url":"https://api.github.com/users/SamGondelman/repos","events_url":"https://api.github.com/users/SamGondelman/events{/privacy}","received_events_url":"https://api.github.com/users/SamGondelman/received_events","type":"User","site_admin":false},"repo":{"id":36534104,"name":"hifi","full_name":"SamGondelman/hifi","owner":{"login":"SamGondelman","id":7650116,"avatar_url":"https://avatars1.githubusercontent.com/u/7650116?v=4","gravatar_id":"","url":"https://api.github.com/users/SamGondelman","html_url":"https://github.com/SamGondelman","followers_url":"https://api.github.com/users/SamGondelman/followers","following_url":"https://api.github.com/users/SamGondelman/following{/other_user}","gists_url":"https://api.github.com/users/SamGondelman/gists{/gist_id}","starred_url":"https://api.github.com/users/SamGondelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamGondelman/subscriptions","organizations_url":"https://api.github.com/users/SamGondelman/orgs","repos_url":"https://api.github.com/users/SamGondelman/repos","events_url":"https://api.github.com/users/SamGondelman/events{/privacy}","received_events_url":"https://api.github.com/users/SamGondelman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SamGondelman/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/SamGondelman/hifi","forks_url":"https://api.github.com/repos/SamGondelman/hifi/forks","keys_url":"https://api.github.com/repos/SamGondelman/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamGondelman/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamGondelman/hifi/teams","hooks_url":"https://api.github.com/repos/SamGondelman/hifi/hooks","issue_events_url":"https://api.github.com/repos/SamGondelman/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/SamGondelman/hifi/events","assignees_url":"https://api.github.com/repos/SamGondelman/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/SamGondelman/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/SamGondelman/hifi/tags","blobs_url":"https://api.github.com/repos/SamGondelman/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamGondelman/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamGondelman/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamGondelman/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamGondelman/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/SamGondelman/hifi/languages","stargazers_url":"https://api.github.com/repos/SamGondelman/hifi/stargazers","contributors_url":"https://api.github.com/repos/SamGondelman/hifi/contributors","subscribers_url":"https://api.github.com/repos/SamGondelman/hifi/subscribers","subscription_url":"https://api.github.com/repos/SamGondelman/hifi/subscription","commits_url":"https://api.github.com/repos/SamGondelman/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamGondelman/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamGondelman/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamGondelman/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/SamGondelman/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/SamGondelman/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamGondelman/hifi/merges","archive_url":"https://api.github.com/repos/SamGondelman/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamGondelman/hifi/downloads","issues_url":"https://api.github.com/repos/SamGondelman/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/SamGondelman/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/SamGondelman/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/SamGondelman/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamGondelman/hifi/labels{/name}","releases_url":"https://api.github.com/repos/SamGondelman/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/SamGondelman/hifi/deployments","created_at":"2015-05-29T23:20:11Z","updated_at":"2016-06-01T16:33:23Z","pushed_at":"2017-08-25T00:56:45Z","git_url":"git://github.com/SamGondelman/hifi.git","ssh_url":"git@github.com:SamGondelman/hifi.git","clone_url":"https://github.com/SamGondelman/hifi.git","svn_url":"https://github.com/SamGondelman/hifi","homepage":"","size":378555,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"c0afda859f6e003caa079cca2389b4c747c39c61","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://wiki.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2017-08-24T03:59:28Z","pushed_at":"2017-08-25T16:01:14Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":380172,"stargazers_count":540,"watchers_count":540,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":362,"mirror_url":null,"open_issues_count":141,"forks":362,"open_issues":141,"watchers":540,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/11243"},"html":{"href":"https://github.com/highfidelity/hifi/pull/11243"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/11243"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/11243/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/11243/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/11243/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/abaccf9edd3e3e84525c97b1ac1dab13aae9f612"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"AndrewMeadows","id":2186405,"avatar_url":"https://avatars0.githubusercontent.com/u/2186405?v=4","gravatar_id":"","url":"https://api.github.com/users/AndrewMeadows","html_url":"https://github.com/AndrewMeadows","followers_url":"https://api.github.com/users/AndrewMeadows/followers","following_url":"https://api.github.com/users/AndrewMeadows/following{/other_user}","gists_url":"https://api.github.com/users/AndrewMeadows/gists{/gist_id}","starred_url":"https://api.github.com/users/AndrewMeadows/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndrewMeadows/subscriptions","organizations_url":"https://api.github.com/users/AndrewMeadows/orgs","repos_url":"https://api.github.com/users/AndrewMeadows/repos","events_url":"https://api.github.com/users/AndrewMeadows/events{/privacy}","received_events_url":"https://api.github.com/users/AndrewMeadows/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"AndrewMeadows"}}