{"action":"created","comment":{"url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/comments/102642755","pull_request_review_id":23402377,"id":102642755,"diff_hunk":"@@ -0,0 +1,524 @@\n+within Buildings.Experimental.OpenBuildingControl.CDL.SetPoints;\n+block CombiTimeTable\n+  \"Table look-up with respect to time and linear/periodic extrapolation methods (data from matrix/file)\"\n+  extends Modelica.Blocks.Icons.Block;\n+  parameter Boolean tableOnFile=false\n+    \"= true, if table is defined on file or in function usertab\"\n+    annotation (Dialog(group=\"Table data definition\"));\n+  parameter Real table[:, :] = fill(0.0, 0, 2)\n+    \"Table matrix (time = first column; e.g., table=[0,2])\"\n+    annotation (Dialog(group=\"Table data definition\",enable=not tableOnFile));\n+  parameter String tableName=\"NoName\"\n+    \"Table name on file or in function usertab (see docu)\"\n+    annotation (Dialog(group=\"Table data definition\",enable=tableOnFile));\n+  parameter String fileName=\"NoName\" \"File where matrix is stored\"\n+    annotation (Dialog(\n+      group=\"Table data definition\",\n+      enable=tableOnFile,\n+      loadSelector(filter=\"Text files (*.txt);;MATLAB MAT-files (*.mat)\",\n+          caption=\"Open file in which table is present\")));\n+  parameter Boolean verboseRead=true\n+    \"= true, if info message that file is loading is to be printed\"\n+    annotation (Dialog(group=\"Table data definition\",enable=tableOnFile));\n+  parameter Integer columns[:]=2:size(table, 2)\n+    \"Columns of table to be interpolated\"\n+    annotation (Dialog(group=\"Table data interpretation\"));\n+  parameter Modelica.Blocks.Types.Smoothness smoothness=Modelica.Blocks.Types.Smoothness.LinearSegments","path":"Buildings/Experimental/OpenBuildingControl/CDL/SetPoints/CombiTimeTable.mo","position":26,"original_position":26,"commit_id":"788dfc8f6bfff47f67317ab768ff3c878b9a5f11","original_commit_id":"788dfc8f6bfff47f67317ab768ff3c878b9a5f11","user":{"login":"mwetter","id":1329080,"avatar_url":"https://avatars.githubusercontent.com/u/1329080?v=3","gravatar_id":"","url":"https://api.github.com/users/mwetter","html_url":"https://github.com/mwetter","followers_url":"https://api.github.com/users/mwetter/followers","following_url":"https://api.github.com/users/mwetter/following{/other_user}","gists_url":"https://api.github.com/users/mwetter/gists{/gist_id}","starred_url":"https://api.github.com/users/mwetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwetter/subscriptions","organizations_url":"https://api.github.com/users/mwetter/orgs","repos_url":"https://api.github.com/users/mwetter/repos","events_url":"https://api.github.com/users/mwetter/events{/privacy}","received_events_url":"https://api.github.com/users/mwetter/received_events","type":"User","site_admin":false},"body":"Types need to be moved to `CDL`","created_at":"2017-02-23T05:40:15Z","updated_at":"2017-02-23T05:45:05Z","html_url":"https://github.com/lbl-srg/modelica-buildings/pull/662#discussion_r102642755","pull_request_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/662","_links":{"self":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/comments/102642755"},"html":{"href":"https://github.com/lbl-srg/modelica-buildings/pull/662#discussion_r102642755"},"pull_request":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/662"}}},"pull_request":{"url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/662","id":107538905,"html_url":"https://github.com/lbl-srg/modelica-buildings/pull/662","diff_url":"https://github.com/lbl-srg/modelica-buildings/pull/662.diff","patch_url":"https://github.com/lbl-srg/modelica-buildings/pull/662.patch","issue_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/662","number":662,"state":"open","locked":false,"title":"Issue610 cdl additional blocks","user":{"login":"milicag","id":5322943,"avatar_url":"https://avatars.githubusercontent.com/u/5322943?v=3","gravatar_id":"","url":"https://api.github.com/users/milicag","html_url":"https://github.com/milicag","followers_url":"https://api.github.com/users/milicag/followers","following_url":"https://api.github.com/users/milicag/following{/other_user}","gists_url":"https://api.github.com/users/milicag/gists{/gist_id}","starred_url":"https://api.github.com/users/milicag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milicag/subscriptions","organizations_url":"https://api.github.com/users/milicag/orgs","repos_url":"https://api.github.com/users/milicag/repos","events_url":"https://api.github.com/users/milicag/events{/privacy}","received_events_url":"https://api.github.com/users/milicag/received_events","type":"User","site_admin":false},"body":"The SetPoints package now has the following blocks:\r\n- CalenderTime\r\n- HotWaterTemperatureReset\r\n- ModelTime\r\n- CombiTimeTable\r\n\r\nThese should, for the time being, cover the input requirements. I've replaced ```Table.mo``` with one listed above, due to better functionality.","created_at":"2017-02-23T01:45:23Z","updated_at":"2017-02-23T05:45:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b88cecb9eeb9cae89b0548fd26949f9efd6181a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/662/commits","review_comments_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/662/comments","review_comment_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/662/comments","statuses_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/statuses/788dfc8f6bfff47f67317ab768ff3c878b9a5f11","head":{"label":"lbl-srg:issue610_cdl_additional_blocks","ref":"issue610_cdl_additional_blocks","sha":"788dfc8f6bfff47f67317ab768ff3c878b9a5f11","user":{"login":"lbl-srg","id":3753398,"avatar_url":"https://avatars.githubusercontent.com/u/3753398?v=3","gravatar_id":"","url":"https://api.github.com/users/lbl-srg","html_url":"https://github.com/lbl-srg","followers_url":"https://api.github.com/users/lbl-srg/followers","following_url":"https://api.github.com/users/lbl-srg/following{/other_user}","gists_url":"https://api.github.com/users/lbl-srg/gists{/gist_id}","starred_url":"https://api.github.com/users/lbl-srg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbl-srg/subscriptions","organizations_url":"https://api.github.com/users/lbl-srg/orgs","repos_url":"https://api.github.com/users/lbl-srg/repos","events_url":"https://api.github.com/users/lbl-srg/events{/privacy}","received_events_url":"https://api.github.com/users/lbl-srg/received_events","type":"Organization","site_admin":false},"repo":{"id":8538889,"name":"modelica-buildings","full_name":"lbl-srg/modelica-buildings","owner":{"login":"lbl-srg","id":3753398,"avatar_url":"https://avatars.githubusercontent.com/u/3753398?v=3","gravatar_id":"","url":"https://api.github.com/users/lbl-srg","html_url":"https://github.com/lbl-srg","followers_url":"https://api.github.com/users/lbl-srg/followers","following_url":"https://api.github.com/users/lbl-srg/following{/other_user}","gists_url":"https://api.github.com/users/lbl-srg/gists{/gist_id}","starred_url":"https://api.github.com/users/lbl-srg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbl-srg/subscriptions","organizations_url":"https://api.github.com/users/lbl-srg/orgs","repos_url":"https://api.github.com/users/lbl-srg/repos","events_url":"https://api.github.com/users/lbl-srg/events{/privacy}","received_events_url":"https://api.github.com/users/lbl-srg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lbl-srg/modelica-buildings","description":"Modelica Buildings library","fork":false,"url":"https://api.github.com/repos/lbl-srg/modelica-buildings","forks_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/forks","keys_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/teams","hooks_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/hooks","issue_events_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/events{/number}","events_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/events","assignees_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/assignees{/user}","branches_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/branches{/branch}","tags_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/tags","blobs_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/statuses/{sha}","languages_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/languages","stargazers_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/stargazers","contributors_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/contributors","subscribers_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/subscribers","subscription_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/subscription","commits_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/contents/{+path}","compare_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/merges","archive_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/downloads","issues_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues{/number}","pulls_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls{/number}","milestones_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/milestones{/number}","notifications_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/labels{/name}","releases_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/releases{/id}","deployments_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/deployments","created_at":"2013-03-03T16:36:03Z","updated_at":"2017-02-16T11:38:49Z","pushed_at":"2017-02-23T05:23:11Z","git_url":"git://github.com/lbl-srg/modelica-buildings.git","ssh_url":"git@github.com:lbl-srg/modelica-buildings.git","clone_url":"https://github.com/lbl-srg/modelica-buildings.git","svn_url":"https://github.com/lbl-srg/modelica-buildings","homepage":null,"size":109861,"stargazers_count":44,"watchers_count":44,"language":"Modelica","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":49,"forks":42,"open_issues":49,"watchers":44,"default_branch":"master"}},"base":{"label":"lbl-srg:issue609_cdl","ref":"issue609_cdl","sha":"0aa501f635682bc69af01214e247c732574b5edf","user":{"login":"lbl-srg","id":3753398,"avatar_url":"https://avatars.githubusercontent.com/u/3753398?v=3","gravatar_id":"","url":"https://api.github.com/users/lbl-srg","html_url":"https://github.com/lbl-srg","followers_url":"https://api.github.com/users/lbl-srg/followers","following_url":"https://api.github.com/users/lbl-srg/following{/other_user}","gists_url":"https://api.github.com/users/lbl-srg/gists{/gist_id}","starred_url":"https://api.github.com/users/lbl-srg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbl-srg/subscriptions","organizations_url":"https://api.github.com/users/lbl-srg/orgs","repos_url":"https://api.github.com/users/lbl-srg/repos","events_url":"https://api.github.com/users/lbl-srg/events{/privacy}","received_events_url":"https://api.github.com/users/lbl-srg/received_events","type":"Organization","site_admin":false},"repo":{"id":8538889,"name":"modelica-buildings","full_name":"lbl-srg/modelica-buildings","owner":{"login":"lbl-srg","id":3753398,"avatar_url":"https://avatars.githubusercontent.com/u/3753398?v=3","gravatar_id":"","url":"https://api.github.com/users/lbl-srg","html_url":"https://github.com/lbl-srg","followers_url":"https://api.github.com/users/lbl-srg/followers","following_url":"https://api.github.com/users/lbl-srg/following{/other_user}","gists_url":"https://api.github.com/users/lbl-srg/gists{/gist_id}","starred_url":"https://api.github.com/users/lbl-srg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbl-srg/subscriptions","organizations_url":"https://api.github.com/users/lbl-srg/orgs","repos_url":"https://api.github.com/users/lbl-srg/repos","events_url":"https://api.github.com/users/lbl-srg/events{/privacy}","received_events_url":"https://api.github.com/users/lbl-srg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lbl-srg/modelica-buildings","description":"Modelica Buildings library","fork":false,"url":"https://api.github.com/repos/lbl-srg/modelica-buildings","forks_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/forks","keys_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/teams","hooks_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/hooks","issue_events_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/events{/number}","events_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/events","assignees_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/assignees{/user}","branches_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/branches{/branch}","tags_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/tags","blobs_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/statuses/{sha}","languages_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/languages","stargazers_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/stargazers","contributors_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/contributors","subscribers_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/subscribers","subscription_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/subscription","commits_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/contents/{+path}","compare_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/merges","archive_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/downloads","issues_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues{/number}","pulls_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls{/number}","milestones_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/milestones{/number}","notifications_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/labels{/name}","releases_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/releases{/id}","deployments_url":"https://api.github.com/repos/lbl-srg/modelica-buildings/deployments","created_at":"2013-03-03T16:36:03Z","updated_at":"2017-02-16T11:38:49Z","pushed_at":"2017-02-23T05:23:11Z","git_url":"git://github.com/lbl-srg/modelica-buildings.git","ssh_url":"git@github.com:lbl-srg/modelica-buildings.git","clone_url":"https://github.com/lbl-srg/modelica-buildings.git","svn_url":"https://github.com/lbl-srg/modelica-buildings","homepage":null,"size":109861,"stargazers_count":44,"watchers_count":44,"language":"Modelica","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":49,"forks":42,"open_issues":49,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/662"},"html":{"href":"https://github.com/lbl-srg/modelica-buildings/pull/662"},"issue":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/662"},"comments":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/issues/662/comments"},"review_comments":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/662/comments"},"review_comment":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/pulls/662/commits"},"statuses":{"href":"https://api.github.com/repos/lbl-srg/modelica-buildings/statuses/788dfc8f6bfff47f67317ab768ff3c878b9a5f11"}}}}
{"actor":{"display_login":"mwetter"}}