{"action":"created","comment":{"url":"https://api.github.com/repos/steffengy/schannel-rs/pulls/comments/118755820","pull_request_review_id":40581464,"id":118755820,"diff_hunk":"@@ -60,6 +52,17 @@ impl Builder {\n         self\n     }\n \n+    /// Set a verification callback to be used for connections created with this `Builder`.\n+    ///\n+    /// The callback is provided with a boolean indicating if the (pre)validation was","path":"src/tls_stream.rs","position":42,"original_position":42,"commit_id":"5e72c6990110fec97d5531a5c0155271873b1083","original_commit_id":"5e72c6990110fec97d5531a5c0155271873b1083","user":{"login":"sfackler","id":1455697,"avatar_url":"https://avatars3.githubusercontent.com/u/1455697?v=3","gravatar_id":"","url":"https://api.github.com/users/sfackler","html_url":"https://github.com/sfackler","followers_url":"https://api.github.com/users/sfackler/followers","following_url":"https://api.github.com/users/sfackler/following{/other_user}","gists_url":"https://api.github.com/users/sfackler/gists{/gist_id}","starred_url":"https://api.github.com/users/sfackler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfackler/subscriptions","organizations_url":"https://api.github.com/users/sfackler/orgs","repos_url":"https://api.github.com/users/sfackler/repos","events_url":"https://api.github.com/users/sfackler/events{/privacy}","received_events_url":"https://api.github.com/users/sfackler/received_events","type":"User","site_admin":false},"body":"Docs need to be updated.","created_at":"2017-05-26T17:49:37Z","updated_at":"2017-05-26T17:49:37Z","html_url":"https://github.com/steffengy/schannel-rs/pull/26#discussion_r118755820","pull_request_url":"https://api.github.com/repos/steffengy/schannel-rs/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/steffengy/schannel-rs/pulls/comments/118755820"},"html":{"href":"https://github.com/steffengy/schannel-rs/pull/26#discussion_r118755820"},"pull_request":{"href":"https://api.github.com/repos/steffengy/schannel-rs/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/steffengy/schannel-rs/pulls/26","id":122087581,"html_url":"https://github.com/steffengy/schannel-rs/pull/26","diff_url":"https://github.com/steffengy/schannel-rs/pull/26.diff","patch_url":"https://github.com/steffengy/schannel-rs/pull/26.patch","issue_url":"https://api.github.com/repos/steffengy/schannel-rs/issues/26","number":26,"state":"open","locked":false,"title":"Add a verification callback.","user":{"login":"steffengy","id":1194855,"avatar_url":"https://avatars3.githubusercontent.com/u/1194855?v=3","gravatar_id":"","url":"https://api.github.com/users/steffengy","html_url":"https://github.com/steffengy","followers_url":"https://api.github.com/users/steffengy/followers","following_url":"https://api.github.com/users/steffengy/following{/other_user}","gists_url":"https://api.github.com/users/steffengy/gists{/gist_id}","starred_url":"https://api.github.com/users/steffengy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffengy/subscriptions","organizations_url":"https://api.github.com/users/steffengy/orgs","repos_url":"https://api.github.com/users/steffengy/repos","events_url":"https://api.github.com/users/steffengy/events{/privacy}","received_events_url":"https://api.github.com/users/steffengy/received_events","type":"User","site_admin":false},"body":"Openssl-inspired implementation of verification callbacks.\r\n\r\nTODOs as of now:\r\n- [x] Lifetime's: CertChain should likely borrow/clone CertChainContext!\r\nWhen the related CertChainContext goes out of scope, CertChain points to invalid memory!\r\n- [x] Tests\r\n- [x] ~~Better solution for the `Arc<Fn...>` ?~~","created_at":"2017-05-23T20:26:25Z","updated_at":"2017-05-26T17:49:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7f1bb6bef10a3caae1984851f82e3899ae77f62","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/steffengy/schannel-rs/pulls/26/commits","review_comments_url":"https://api.github.com/repos/steffengy/schannel-rs/pulls/26/comments","review_comment_url":"https://api.github.com/repos/steffengy/schannel-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/steffengy/schannel-rs/issues/26/comments","statuses_url":"https://api.github.com/repos/steffengy/schannel-rs/statuses/5e72c6990110fec97d5531a5c0155271873b1083","head":{"label":"steffengy:verify_callback","ref":"verify_callback","sha":"5e72c6990110fec97d5531a5c0155271873b1083","user":{"login":"steffengy","id":1194855,"avatar_url":"https://avatars3.githubusercontent.com/u/1194855?v=3","gravatar_id":"","url":"https://api.github.com/users/steffengy","html_url":"https://github.com/steffengy","followers_url":"https://api.github.com/users/steffengy/followers","following_url":"https://api.github.com/users/steffengy/following{/other_user}","gists_url":"https://api.github.com/users/steffengy/gists{/gist_id}","starred_url":"https://api.github.com/users/steffengy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffengy/subscriptions","organizations_url":"https://api.github.com/users/steffengy/orgs","repos_url":"https://api.github.com/users/steffengy/repos","events_url":"https://api.github.com/users/steffengy/events{/privacy}","received_events_url":"https://api.github.com/users/steffengy/received_events","type":"User","site_admin":false},"repo":{"id":43839381,"name":"schannel-rs","full_name":"steffengy/schannel-rs","owner":{"login":"steffengy","id":1194855,"avatar_url":"https://avatars3.githubusercontent.com/u/1194855?v=3","gravatar_id":"","url":"https://api.github.com/users/steffengy","html_url":"https://github.com/steffengy","followers_url":"https://api.github.com/users/steffengy/followers","following_url":"https://api.github.com/users/steffengy/following{/other_user}","gists_url":"https://api.github.com/users/steffengy/gists{/gist_id}","starred_url":"https://api.github.com/users/steffengy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffengy/subscriptions","organizations_url":"https://api.github.com/users/steffengy/orgs","repos_url":"https://api.github.com/users/steffengy/repos","events_url":"https://api.github.com/users/steffengy/events{/privacy}","received_events_url":"https://api.github.com/users/steffengy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steffengy/schannel-rs","description":"Schannel API-bindings for rust (provides an interface for native SSL/TLS using windows APIs)","fork":false,"url":"https://api.github.com/repos/steffengy/schannel-rs","forks_url":"https://api.github.com/repos/steffengy/schannel-rs/forks","keys_url":"https://api.github.com/repos/steffengy/schannel-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steffengy/schannel-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steffengy/schannel-rs/teams","hooks_url":"https://api.github.com/repos/steffengy/schannel-rs/hooks","issue_events_url":"https://api.github.com/repos/steffengy/schannel-rs/issues/events{/number}","events_url":"https://api.github.com/repos/steffengy/schannel-rs/events","assignees_url":"https://api.github.com/repos/steffengy/schannel-rs/assignees{/user}","branches_url":"https://api.github.com/repos/steffengy/schannel-rs/branches{/branch}","tags_url":"https://api.github.com/repos/steffengy/schannel-rs/tags","blobs_url":"https://api.github.com/repos/steffengy/schannel-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steffengy/schannel-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steffengy/schannel-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/steffengy/schannel-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steffengy/schannel-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/steffengy/schannel-rs/languages","stargazers_url":"https://api.github.com/repos/steffengy/schannel-rs/stargazers","contributors_url":"https://api.github.com/repos/steffengy/schannel-rs/contributors","subscribers_url":"https://api.github.com/repos/steffengy/schannel-rs/subscribers","subscription_url":"https://api.github.com/repos/steffengy/schannel-rs/subscription","commits_url":"https://api.github.com/repos/steffengy/schannel-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/steffengy/schannel-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/steffengy/schannel-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/steffengy/schannel-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/steffengy/schannel-rs/contents/{+path}","compare_url":"https://api.github.com/repos/steffengy/schannel-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steffengy/schannel-rs/merges","archive_url":"https://api.github.com/repos/steffengy/schannel-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steffengy/schannel-rs/downloads","issues_url":"https://api.github.com/repos/steffengy/schannel-rs/issues{/number}","pulls_url":"https://api.github.com/repos/steffengy/schannel-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/steffengy/schannel-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/steffengy/schannel-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steffengy/schannel-rs/labels{/name}","releases_url":"https://api.github.com/repos/steffengy/schannel-rs/releases{/id}","deployments_url":"https://api.github.com/repos/steffengy/schannel-rs/deployments","created_at":"2015-10-07T19:19:17Z","updated_at":"2017-03-11T14:07:59Z","pushed_at":"2017-05-26T08:03:41Z","git_url":"git://github.com/steffengy/schannel-rs.git","ssh_url":"git@github.com:steffengy/schannel-rs.git","clone_url":"https://github.com/steffengy/schannel-rs.git","svn_url":"https://github.com/steffengy/schannel-rs","homepage":"","size":204,"stargazers_count":4,"watchers_count":4,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":8,"forks":9,"open_issues":8,"watchers":4,"default_branch":"master"}},"base":{"label":"steffengy:master","ref":"master","sha":"e88fb5a9ffcf8de89603352953d931aabceb1383","user":{"login":"steffengy","id":1194855,"avatar_url":"https://avatars3.githubusercontent.com/u/1194855?v=3","gravatar_id":"","url":"https://api.github.com/users/steffengy","html_url":"https://github.com/steffengy","followers_url":"https://api.github.com/users/steffengy/followers","following_url":"https://api.github.com/users/steffengy/following{/other_user}","gists_url":"https://api.github.com/users/steffengy/gists{/gist_id}","starred_url":"https://api.github.com/users/steffengy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffengy/subscriptions","organizations_url":"https://api.github.com/users/steffengy/orgs","repos_url":"https://api.github.com/users/steffengy/repos","events_url":"https://api.github.com/users/steffengy/events{/privacy}","received_events_url":"https://api.github.com/users/steffengy/received_events","type":"User","site_admin":false},"repo":{"id":43839381,"name":"schannel-rs","full_name":"steffengy/schannel-rs","owner":{"login":"steffengy","id":1194855,"avatar_url":"https://avatars3.githubusercontent.com/u/1194855?v=3","gravatar_id":"","url":"https://api.github.com/users/steffengy","html_url":"https://github.com/steffengy","followers_url":"https://api.github.com/users/steffengy/followers","following_url":"https://api.github.com/users/steffengy/following{/other_user}","gists_url":"https://api.github.com/users/steffengy/gists{/gist_id}","starred_url":"https://api.github.com/users/steffengy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffengy/subscriptions","organizations_url":"https://api.github.com/users/steffengy/orgs","repos_url":"https://api.github.com/users/steffengy/repos","events_url":"https://api.github.com/users/steffengy/events{/privacy}","received_events_url":"https://api.github.com/users/steffengy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steffengy/schannel-rs","description":"Schannel API-bindings for rust (provides an interface for native SSL/TLS using windows APIs)","fork":false,"url":"https://api.github.com/repos/steffengy/schannel-rs","forks_url":"https://api.github.com/repos/steffengy/schannel-rs/forks","keys_url":"https://api.github.com/repos/steffengy/schannel-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steffengy/schannel-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steffengy/schannel-rs/teams","hooks_url":"https://api.github.com/repos/steffengy/schannel-rs/hooks","issue_events_url":"https://api.github.com/repos/steffengy/schannel-rs/issues/events{/number}","events_url":"https://api.github.com/repos/steffengy/schannel-rs/events","assignees_url":"https://api.github.com/repos/steffengy/schannel-rs/assignees{/user}","branches_url":"https://api.github.com/repos/steffengy/schannel-rs/branches{/branch}","tags_url":"https://api.github.com/repos/steffengy/schannel-rs/tags","blobs_url":"https://api.github.com/repos/steffengy/schannel-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steffengy/schannel-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steffengy/schannel-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/steffengy/schannel-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steffengy/schannel-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/steffengy/schannel-rs/languages","stargazers_url":"https://api.github.com/repos/steffengy/schannel-rs/stargazers","contributors_url":"https://api.github.com/repos/steffengy/schannel-rs/contributors","subscribers_url":"https://api.github.com/repos/steffengy/schannel-rs/subscribers","subscription_url":"https://api.github.com/repos/steffengy/schannel-rs/subscription","commits_url":"https://api.github.com/repos/steffengy/schannel-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/steffengy/schannel-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/steffengy/schannel-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/steffengy/schannel-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/steffengy/schannel-rs/contents/{+path}","compare_url":"https://api.github.com/repos/steffengy/schannel-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steffengy/schannel-rs/merges","archive_url":"https://api.github.com/repos/steffengy/schannel-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steffengy/schannel-rs/downloads","issues_url":"https://api.github.com/repos/steffengy/schannel-rs/issues{/number}","pulls_url":"https://api.github.com/repos/steffengy/schannel-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/steffengy/schannel-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/steffengy/schannel-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steffengy/schannel-rs/labels{/name}","releases_url":"https://api.github.com/repos/steffengy/schannel-rs/releases{/id}","deployments_url":"https://api.github.com/repos/steffengy/schannel-rs/deployments","created_at":"2015-10-07T19:19:17Z","updated_at":"2017-03-11T14:07:59Z","pushed_at":"2017-05-26T08:03:41Z","git_url":"git://github.com/steffengy/schannel-rs.git","ssh_url":"git@github.com:steffengy/schannel-rs.git","clone_url":"https://github.com/steffengy/schannel-rs.git","svn_url":"https://github.com/steffengy/schannel-rs","homepage":"","size":204,"stargazers_count":4,"watchers_count":4,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":8,"forks":9,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/steffengy/schannel-rs/pulls/26"},"html":{"href":"https://github.com/steffengy/schannel-rs/pull/26"},"issue":{"href":"https://api.github.com/repos/steffengy/schannel-rs/issues/26"},"comments":{"href":"https://api.github.com/repos/steffengy/schannel-rs/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/steffengy/schannel-rs/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/steffengy/schannel-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/steffengy/schannel-rs/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/steffengy/schannel-rs/statuses/5e72c6990110fec97d5531a5c0155271873b1083"}}}}
{"actor":{"display_login":"sfackler"}}