{"action":"created","issue":{"url":"https://api.github.com/repos/electron-userland/electron-packager/issues/635","repository_url":"https://api.github.com/repos/electron-userland/electron-packager","labels_url":"https://api.github.com/repos/electron-userland/electron-packager/issues/635/labels{/name}","comments_url":"https://api.github.com/repos/electron-userland/electron-packager/issues/635/comments","events_url":"https://api.github.com/repos/electron-userland/electron-packager/issues/635/events","html_url":"https://github.com/electron-userland/electron-packager/issues/635","id":222564137,"number":635,"title":"Unable to set icon on Linux target","user":{"login":"DavisDevelopment","id":3256883,"avatar_url":"https://avatars2.githubusercontent.com/u/3256883?v=3","gravatar_id":"","url":"https://api.github.com/users/DavisDevelopment","html_url":"https://github.com/DavisDevelopment","followers_url":"https://api.github.com/users/DavisDevelopment/followers","following_url":"https://api.github.com/users/DavisDevelopment/following{/other_user}","gists_url":"https://api.github.com/users/DavisDevelopment/gists{/gist_id}","starred_url":"https://api.github.com/users/DavisDevelopment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavisDevelopment/subscriptions","organizations_url":"https://api.github.com/users/DavisDevelopment/orgs","repos_url":"https://api.github.com/users/DavisDevelopment/repos","events_url":"https://api.github.com/users/DavisDevelopment/events{/privacy}","received_events_url":"https://api.github.com/users/DavisDevelopment/received_events","type":"User","site_admin":false},"labels":[{"id":277030912,"url":"https://api.github.com/repos/electron-userland/electron-packager/labels/build-target:linux","name":"build-target:linux","color":"bfdadc","default":false},{"id":190730268,"url":"https://api.github.com/repos/electron-userland/electron-packager/labels/question","name":"question","color":"cc317c","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-04-18T22:29:54Z","updated_at":"2017-04-18T22:52:02Z","closed_at":"2017-04-18T22:52:02Z","body":"<!--\r\nThanks for filing an issue!\r\nPlease check off all of the steps as they are completed by replacing [ ] with [x].\r\n-->\r\n\r\n* [x] I have read the [contribution documentation](https://github.com/electron-userland/electron-packager/blob/master/CONTRIBUTING.md) for this project.\r\n* [x] I agree to follow the [code of conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project follows, as appropriate.\r\n* [x] I have searched the issue tracker for an issue that matches the one I want to file, without success.\r\n\r\n**Please describe your issue:**\r\n\r\nI'm building on Ubuntu 16.04 for x64, and while simply running the app will show the icon just fine, the icon once packaged is always the electron icon. I have verified that the icon path is a valid one.\r\n\r\n<!-- For bugs and questions, please answer these questions to the best of your ability. -->\r\n\r\n**Console output when you run electron-packager with the environment variable `DEBUG=electron-packager`. Please include the stack trace if one exists.**\r\n\r\n```\r\n  electron-packager Electron Packager 8.6.0 +0ms\r\n  electron-packager Node v7.7.3 +2ms\r\n  electron-packager Host Operating system: linux (x64) +0ms\r\n  electron-packager Packager Options: {\"name\":\"pman\",\"appname\":\"pman\",\"arch\":\"x64\",\"platform\":\"linux\",\"icon\":null,\"version\":\"1.6.5\",\"dir\":\"/home/ryan/Documents/Development/bplayer4/dist\",\"sourcedir\":\"/home/ryan/Documents/Development/bplayer4/dist\",\"out\":\"/home/ryan/Documents/Development/bplayer4/dist/releases\",\"overwrite\":true,\"asar\":false,\"prune\":true,\"app_version\":null,\"afterCopy\":[null],\"afterExtract\":[]} +0ms\r\n  electron-packager Target Platforms: linux +0ms\r\n  electron-packager Target Architectures: x64 +1ms\r\nWARNING: The version parameter is deprecated, use electronVersion (or --electron-version in the CLI) instead\r\n  electron-packager Inferring appVersion from version in /home/ryan/Documents/Development/bplayer4/dist/package.json +9ms\r\n  electron-packager Application name: pman +0ms\r\n  electron-packager Target Electron version: 1.6.5 +0ms\r\n  electron-packager Downloading Electron with options {\"platform\":\"linux\",\"arch\":\"x64\",\"version\":\"1.6.5\"} +4ms\r\nPackaging app for platform linux x64 using electron v1.6.5\r\n  electron-packager Creating /tmp/electron-packager/linux-x64-template +319ms\r\n  electron-packager Extracting /home/ryan/.electron/electron-v1.6.5-linux-x64.zip to /tmp/electron-packager/linux-x64-template +1ms\r\n  electron-packager Initializing app in /tmp/electron-packager/linux-x64/pman-linux-x64 from /tmp/electron-packager/linux-x64-template template +1s\r\n  electron-packager Ignored paths based on the out param: +1ms [ '/home/ryan/Documents/Development/bplayer4/dist/releases' ]\r\n  electron-packager Running npm prune --production +3s\r\n  electron-packager Renaming electron to pman in /tmp/electron-packager/linux-x64/pman-linux-x64 +5s\r\n  electron-packager Moving /tmp/electron-packager/linux-x64/pman-linux-x64 to /home/ryan/Documents/Development/bplayer4/dist/releases/pman-linux-x64 +0ms\r\n```\r\n\r\n**What command line arguments are you passing? Alternatively, if you are using the API, what\r\nparameters are you passing to the `packager()` function?**\r\n\r\n\r\nI'm using the API, but my options argument is generated programmatically and is thus pretty tricky to post here. I've resorted to simply not setting the 'icon' property.  The only reason I'm posting the issue here is that the icon works fine before I package the app, so I'm pretty sure it must be an issue with electron-packager and not with electron. Is there any way I could fix this, or is there some magical way to set the icon post-packaging that will work? The icon works everywhere else.\r\n"},"comment":{"url":"https://api.github.com/repos/electron-userland/electron-packager/issues/comments/295007783","html_url":"https://github.com/electron-userland/electron-packager/issues/635#issuecomment-295007783","issue_url":"https://api.github.com/repos/electron-userland/electron-packager/issues/635","id":295007783,"user":{"login":"malept","id":11417,"avatar_url":"https://avatars2.githubusercontent.com/u/11417?v=3","gravatar_id":"","url":"https://api.github.com/users/malept","html_url":"https://github.com/malept","followers_url":"https://api.github.com/users/malept/followers","following_url":"https://api.github.com/users/malept/following{/other_user}","gists_url":"https://api.github.com/users/malept/gists{/gist_id}","starred_url":"https://api.github.com/users/malept/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malept/subscriptions","organizations_url":"https://api.github.com/users/malept/orgs","repos_url":"https://api.github.com/users/malept/repos","events_url":"https://api.github.com/users/malept/events{/privacy}","received_events_url":"https://api.github.com/users/malept/received_events","type":"User","site_admin":false},"created_at":"2017-04-18T22:52:02Z","updated_at":"2017-04-18T22:52:02Z","body":"Thanks for filing a bug, but this flag is not used when you are building for Linux targets. From the [API docs for `--icon`](https://github.com/electron-userland/electron-packager/blob/master/docs/api.md#icon):\r\n\r\n> this option is not required, as the dock/window list icon is set via [the `icon` option in the `BrowserWindow` constructor](http://electron.atom.io/docs/api/browser-window/#new-browserwindowoptions). _Please note that you need to use a PNG, and not the OS X or Windows icon formats, in order for it to show up in the dock/window list._ Setting the icon in the file manager is not currently supported."}}
{"actor":{"display_login":"malept"}}