{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/148118172","pull_request_review_id":73313306,"id":148118172,"diff_hunk":"@@ -0,0 +1,97 @@\n+﻿// Copyright (c) Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.\n+\n+using System;\n+using Microsoft.Build.Utilities;\n+\n+namespace Microsoft.CodeAnalysis.BuildTasks\n+{\n+    public abstract class ManagedToolTask : ToolTask\n+    {\n+        protected abstract bool IsManagedTask { get; }\n+\n+        protected abstract string CommandLineArguments { get; }","path":"src/Compilers/Core/MSBuildTask/ManagedToolTask.cs","position":null,"original_position":12,"commit_id":"fb76c0b61ddb55dd2bbe2212764b76fe7aa0747b","original_commit_id":"f5239a496dd54218e6e480d68b21ace4d1b6ba09","user":{"login":"khyperia","id":953151,"avatar_url":"https://avatars2.githubusercontent.com/u/953151?v=4","gravatar_id":"","url":"https://api.github.com/users/khyperia","html_url":"https://github.com/khyperia","followers_url":"https://api.github.com/users/khyperia/followers","following_url":"https://api.github.com/users/khyperia/following{/other_user}","gists_url":"https://api.github.com/users/khyperia/gists{/gist_id}","starred_url":"https://api.github.com/users/khyperia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khyperia/subscriptions","organizations_url":"https://api.github.com/users/khyperia/orgs","repos_url":"https://api.github.com/users/khyperia/repos","events_url":"https://api.github.com/users/khyperia/events{/privacy}","received_events_url":"https://api.github.com/users/khyperia/received_events","type":"User","site_admin":false},"body":"Correct.\r\n\r\n`GenerateCommandLineCommands` is called by MSBuild, and it expects the arguments to the actual process invocation.\r\n\r\nThe corresponding wrapper for that, which is the clean \"just the actual arguments to the tool\", is `CommandLineArguments` (now renamed to `ToolArguments` and doc'd)","created_at":"2017-10-31T20:29:03Z","updated_at":"2017-10-31T20:29:03Z","html_url":"https://github.com/dotnet/roslyn/pull/22807#discussion_r148118172","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/22807","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/148118172"},"html":{"href":"https://github.com/dotnet/roslyn/pull/22807#discussion_r148118172"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/22807"}},"in_reply_to_id":148080640},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/22807","id":148204397,"html_url":"https://github.com/dotnet/roslyn/pull/22807","diff_url":"https://github.com/dotnet/roslyn/pull/22807.diff","patch_url":"https://github.com/dotnet/roslyn/pull/22807.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/22807","number":22807,"state":"open","locked":false,"title":"Implement compiler server on Linux","user":{"login":"khyperia","id":953151,"avatar_url":"https://avatars2.githubusercontent.com/u/953151?v=4","gravatar_id":"","url":"https://api.github.com/users/khyperia","html_url":"https://github.com/khyperia","followers_url":"https://api.github.com/users/khyperia/followers","following_url":"https://api.github.com/users/khyperia/following{/other_user}","gists_url":"https://api.github.com/users/khyperia/gists{/gist_id}","starred_url":"https://api.github.com/users/khyperia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khyperia/subscriptions","organizations_url":"https://api.github.com/users/khyperia/orgs","repos_url":"https://api.github.com/users/khyperia/repos","events_url":"https://api.github.com/users/khyperia/events{/privacy}","received_events_url":"https://api.github.com/users/khyperia/received_events","type":"User","site_admin":false},"body":"This is a follow-up to https://github.com/dotnet/roslyn/pull/22291\r\n\r\nSome notes:\r\n\r\n* The change to CLI `15.5.0-preview-007082` is needed because that's apparently the only CLI version that has my change it it (which makes CLI not set `CscToolPath`)\r\n* Changing `DotnetHost.cs` -> `ManagedToolTask.cs` is needed basically only because of the comment that starts with \"using CommandLineArguments here\" :( (but I do think the new design is way cleaner)\r\n* UnixDomainSocket's reflection/pinvoke calls are sort of a work-in-progress, we're working with corefx to figure out what the best path forward is.\r\n* Moving `CreateServerFailsConnection` to `FailingCompilerServerHost.cs` was required because the old `CreateServerFailsConnection` was failing with incredibly bizzare behavior that me and Andy couldn't figure out after a couple days of debugging.","created_at":"2017-10-23T18:22:17Z","updated_at":"2017-10-31T20:29:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57df24aed258a750a7f0a9b74c5c39a09536d354","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/22807/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/22807/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/22807/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/fb76c0b61ddb55dd2bbe2212764b76fe7aa0747b","head":{"label":"khyperia:impl_portableserver","ref":"impl_portableserver","sha":"fb76c0b61ddb55dd2bbe2212764b76fe7aa0747b","user":{"login":"khyperia","id":953151,"avatar_url":"https://avatars2.githubusercontent.com/u/953151?v=4","gravatar_id":"","url":"https://api.github.com/users/khyperia","html_url":"https://github.com/khyperia","followers_url":"https://api.github.com/users/khyperia/followers","following_url":"https://api.github.com/users/khyperia/following{/other_user}","gists_url":"https://api.github.com/users/khyperia/gists{/gist_id}","starred_url":"https://api.github.com/users/khyperia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khyperia/subscriptions","organizations_url":"https://api.github.com/users/khyperia/orgs","repos_url":"https://api.github.com/users/khyperia/repos","events_url":"https://api.github.com/users/khyperia/events{/privacy}","received_events_url":"https://api.github.com/users/khyperia/received_events","type":"User","site_admin":false},"repo":{"id":35454040,"name":"roslyn","full_name":"khyperia/roslyn","owner":{"login":"khyperia","id":953151,"avatar_url":"https://avatars2.githubusercontent.com/u/953151?v=4","gravatar_id":"","url":"https://api.github.com/users/khyperia","html_url":"https://github.com/khyperia","followers_url":"https://api.github.com/users/khyperia/followers","following_url":"https://api.github.com/users/khyperia/following{/other_user}","gists_url":"https://api.github.com/users/khyperia/gists{/gist_id}","starred_url":"https://api.github.com/users/khyperia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khyperia/subscriptions","organizations_url":"https://api.github.com/users/khyperia/orgs","repos_url":"https://api.github.com/users/khyperia/repos","events_url":"https://api.github.com/users/khyperia/events{/privacy}","received_events_url":"https://api.github.com/users/khyperia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/khyperia/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/khyperia/roslyn","forks_url":"https://api.github.com/repos/khyperia/roslyn/forks","keys_url":"https://api.github.com/repos/khyperia/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khyperia/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khyperia/roslyn/teams","hooks_url":"https://api.github.com/repos/khyperia/roslyn/hooks","issue_events_url":"https://api.github.com/repos/khyperia/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/khyperia/roslyn/events","assignees_url":"https://api.github.com/repos/khyperia/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/khyperia/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/khyperia/roslyn/tags","blobs_url":"https://api.github.com/repos/khyperia/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khyperia/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khyperia/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/khyperia/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khyperia/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/khyperia/roslyn/languages","stargazers_url":"https://api.github.com/repos/khyperia/roslyn/stargazers","contributors_url":"https://api.github.com/repos/khyperia/roslyn/contributors","subscribers_url":"https://api.github.com/repos/khyperia/roslyn/subscribers","subscription_url":"https://api.github.com/repos/khyperia/roslyn/subscription","commits_url":"https://api.github.com/repos/khyperia/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/khyperia/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/khyperia/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/khyperia/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/khyperia/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/khyperia/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khyperia/roslyn/merges","archive_url":"https://api.github.com/repos/khyperia/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khyperia/roslyn/downloads","issues_url":"https://api.github.com/repos/khyperia/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/khyperia/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/khyperia/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/khyperia/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khyperia/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/khyperia/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/khyperia/roslyn/deployments","created_at":"2015-05-11T22:43:33Z","updated_at":"2016-05-09T23:12:38Z","pushed_at":"2017-10-31T20:27:30Z","git_url":"git://github.com/khyperia/roslyn.git","ssh_url":"git@github.com:khyperia/roslyn.git","clone_url":"https://github.com/khyperia/roslyn.git","svn_url":"https://github.com/khyperia/roslyn","homepage":"","size":240646,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:post-dev15.5-contrib","ref":"post-dev15.5-contrib","sha":"c026c3232b6e79f66b98abe8e3b1014ee8179932","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2017-10-31T19:22:13Z","pushed_at":"2017-10-31T20:27:32Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":250250,"stargazers_count":8324,"watchers_count":8324,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2029,"mirror_url":null,"archived":false,"open_issues_count":4081,"forks":2029,"open_issues":4081,"watchers":8324,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/22807"},"html":{"href":"https://github.com/dotnet/roslyn/pull/22807"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/22807"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/22807/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/22807/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/22807/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/fb76c0b61ddb55dd2bbe2212764b76fe7aa0747b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"khyperia"}}