{"action":"created","comment":{"url":"https://api.github.com/repos/alteryx/AlteryxPredictive/pulls/comments/96730019","pull_request_review_id":17321236,"id":96730019,"diff_hunk":"@@ -95,6 +95,18 @@ interactive_lm_report <- function(\n #    y_true = the_actual_values\n #  )\n   if(is.null(cv_metrics)){\n+    #In R, testing inherits(vec, \"numeric\") when vec is a vector of\n+    #integers returns FALSE. Thus, we need to coerce the_fitted_values\n+    #and the_actual_values to numeric if they're integer vectors before\n+    #calling rSquared, since that function tests if the input vectors\n+    #are numeric and errors if they're not. We don't want to change the\n+    #behavior of rSquared because correlation is defined on the real numbers.\n+    if (inherits(x = the_fitted_values, what = \"integer\")) {\n+      the_fitted_values <- as.numeric(the_fitted_values)\n+    }\n+    if (inherits(x = the_actual_values, what = \"integer\")) {\n+      the_actual_values <- as.numeric(the_actual_values)\n+    }","path":"R/interactiveLMReport.R","position":15,"original_position":15,"commit_id":"35d3a5ef5581f63c8638497370953bb4da622156","original_commit_id":"35d3a5ef5581f63c8638497370953bb4da622156","user":{"login":"ramnathv","id":346288,"avatar_url":"https://avatars.githubusercontent.com/u/346288?v=3","gravatar_id":"","url":"https://api.github.com/users/ramnathv","html_url":"https://github.com/ramnathv","followers_url":"https://api.github.com/users/ramnathv/followers","following_url":"https://api.github.com/users/ramnathv/following{/other_user}","gists_url":"https://api.github.com/users/ramnathv/gists{/gist_id}","starred_url":"https://api.github.com/users/ramnathv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramnathv/subscriptions","organizations_url":"https://api.github.com/users/ramnathv/orgs","repos_url":"https://api.github.com/users/ramnathv/repos","events_url":"https://api.github.com/users/ramnathv/events{/privacy}","received_events_url":"https://api.github.com/users/ramnathv/received_events","type":"User","site_admin":false},"body":"I agree with you. That is why I said it is good it works. We are good :)","created_at":"2017-01-18T20:46:17Z","updated_at":"2017-01-18T20:46:17Z","html_url":"https://github.com/alteryx/AlteryxPredictive/pull/110#discussion_r96730019","pull_request_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/alteryx/AlteryxPredictive/pulls/comments/96730019"},"html":{"href":"https://github.com/alteryx/AlteryxPredictive/pull/110#discussion_r96730019"},"pull_request":{"href":"https://api.github.com/repos/alteryx/AlteryxPredictive/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/alteryx/AlteryxPredictive/pulls/110","id":102115690,"html_url":"https://github.com/alteryx/AlteryxPredictive/pull/110","diff_url":"https://github.com/alteryx/AlteryxPredictive/pull/110.diff","patch_url":"https://github.com/alteryx/AlteryxPredictive/pull/110.patch","issue_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/issues/110","number":110,"state":"closed","locked":false,"title":"If the_fitted_values and/or the_actual_values is an integer vector, c…","user":{"login":"btoomey","id":18706762,"avatar_url":"https://avatars.githubusercontent.com/u/18706762?v=3","gravatar_id":"","url":"https://api.github.com/users/btoomey","html_url":"https://github.com/btoomey","followers_url":"https://api.github.com/users/btoomey/followers","following_url":"https://api.github.com/users/btoomey/following{/other_user}","gists_url":"https://api.github.com/users/btoomey/gists{/gist_id}","starred_url":"https://api.github.com/users/btoomey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btoomey/subscriptions","organizations_url":"https://api.github.com/users/btoomey/orgs","repos_url":"https://api.github.com/users/btoomey/repos","events_url":"https://api.github.com/users/btoomey/events{/privacy}","received_events_url":"https://api.github.com/users/btoomey/received_events","type":"User","site_admin":false},"body":"…oerce them/it to a double before calling rSquared on them.","created_at":"2017-01-18T17:48:03Z","updated_at":"2017-01-18T20:46:17Z","closed_at":"2017-01-18T17:51:20Z","merged_at":"2017-01-18T17:51:20Z","merge_commit_sha":"5fc9236e1b640cff9a11e685546b0dfd2cdbc917","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/pulls/110/commits","review_comments_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/pulls/110/comments","review_comment_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/issues/110/comments","statuses_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/statuses/35d3a5ef5581f63c8638497370953bb4da622156","head":{"label":"btoomey:master","ref":"master","sha":"35d3a5ef5581f63c8638497370953bb4da622156","user":{"login":"btoomey","id":18706762,"avatar_url":"https://avatars.githubusercontent.com/u/18706762?v=3","gravatar_id":"","url":"https://api.github.com/users/btoomey","html_url":"https://github.com/btoomey","followers_url":"https://api.github.com/users/btoomey/followers","following_url":"https://api.github.com/users/btoomey/following{/other_user}","gists_url":"https://api.github.com/users/btoomey/gists{/gist_id}","starred_url":"https://api.github.com/users/btoomey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btoomey/subscriptions","organizations_url":"https://api.github.com/users/btoomey/orgs","repos_url":"https://api.github.com/users/btoomey/repos","events_url":"https://api.github.com/users/btoomey/events{/privacy}","received_events_url":"https://api.github.com/users/btoomey/received_events","type":"User","site_admin":false},"repo":{"id":73862312,"name":"AlteryxPredictive","full_name":"btoomey/AlteryxPredictive","owner":{"login":"btoomey","id":18706762,"avatar_url":"https://avatars.githubusercontent.com/u/18706762?v=3","gravatar_id":"","url":"https://api.github.com/users/btoomey","html_url":"https://github.com/btoomey","followers_url":"https://api.github.com/users/btoomey/followers","following_url":"https://api.github.com/users/btoomey/following{/other_user}","gists_url":"https://api.github.com/users/btoomey/gists{/gist_id}","starred_url":"https://api.github.com/users/btoomey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btoomey/subscriptions","organizations_url":"https://api.github.com/users/btoomey/orgs","repos_url":"https://api.github.com/users/btoomey/repos","events_url":"https://api.github.com/users/btoomey/events{/privacy}","received_events_url":"https://api.github.com/users/btoomey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/btoomey/AlteryxPredictive","description":"This is an R package containing utility functions used by the predictive tools in Alteryx.","fork":true,"url":"https://api.github.com/repos/btoomey/AlteryxPredictive","forks_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/forks","keys_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/teams","hooks_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/hooks","issue_events_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/issues/events{/number}","events_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/events","assignees_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/assignees{/user}","branches_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/branches{/branch}","tags_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/tags","blobs_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/git/refs{/sha}","trees_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/statuses/{sha}","languages_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/languages","stargazers_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/stargazers","contributors_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/contributors","subscribers_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/subscribers","subscription_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/subscription","commits_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/commits{/sha}","git_commits_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/git/commits{/sha}","comments_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/comments{/number}","issue_comment_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/issues/comments{/number}","contents_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/contents/{+path}","compare_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/merges","archive_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/downloads","issues_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/issues{/number}","pulls_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/pulls{/number}","milestones_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/milestones{/number}","notifications_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/labels{/name}","releases_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/releases{/id}","deployments_url":"https://api.github.com/repos/btoomey/AlteryxPredictive/deployments","created_at":"2016-11-15T22:49:23Z","updated_at":"2016-11-15T22:49:24Z","pushed_at":"2017-01-18T20:29:00Z","git_url":"git://github.com/btoomey/AlteryxPredictive.git","ssh_url":"git@github.com:btoomey/AlteryxPredictive.git","clone_url":"https://github.com/btoomey/AlteryxPredictive.git","svn_url":"https://github.com/btoomey/AlteryxPredictive","homepage":null,"size":539,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alteryx:master","ref":"master","sha":"214d6f7fde747b1760520ad2ed88744b14dd9a93","user":{"login":"alteryx","id":12972388,"avatar_url":"https://avatars.githubusercontent.com/u/12972388?v=3","gravatar_id":"","url":"https://api.github.com/users/alteryx","html_url":"https://github.com/alteryx","followers_url":"https://api.github.com/users/alteryx/followers","following_url":"https://api.github.com/users/alteryx/following{/other_user}","gists_url":"https://api.github.com/users/alteryx/gists{/gist_id}","starred_url":"https://api.github.com/users/alteryx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alteryx/subscriptions","organizations_url":"https://api.github.com/users/alteryx/orgs","repos_url":"https://api.github.com/users/alteryx/repos","events_url":"https://api.github.com/users/alteryx/events{/privacy}","received_events_url":"https://api.github.com/users/alteryx/received_events","type":"Organization","site_admin":false},"repo":{"id":63398212,"name":"AlteryxPredictive","full_name":"alteryx/AlteryxPredictive","owner":{"login":"alteryx","id":12972388,"avatar_url":"https://avatars.githubusercontent.com/u/12972388?v=3","gravatar_id":"","url":"https://api.github.com/users/alteryx","html_url":"https://github.com/alteryx","followers_url":"https://api.github.com/users/alteryx/followers","following_url":"https://api.github.com/users/alteryx/following{/other_user}","gists_url":"https://api.github.com/users/alteryx/gists{/gist_id}","starred_url":"https://api.github.com/users/alteryx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alteryx/subscriptions","organizations_url":"https://api.github.com/users/alteryx/orgs","repos_url":"https://api.github.com/users/alteryx/repos","events_url":"https://api.github.com/users/alteryx/events{/privacy}","received_events_url":"https://api.github.com/users/alteryx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alteryx/AlteryxPredictive","description":"This is an R package containing utility functions used by the predictive tools in Alteryx.","fork":false,"url":"https://api.github.com/repos/alteryx/AlteryxPredictive","forks_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/forks","keys_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/teams","hooks_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/hooks","issue_events_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/issues/events{/number}","events_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/events","assignees_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/assignees{/user}","branches_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/branches{/branch}","tags_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/tags","blobs_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/git/refs{/sha}","trees_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/statuses/{sha}","languages_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/languages","stargazers_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/stargazers","contributors_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/contributors","subscribers_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/subscribers","subscription_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/subscription","commits_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/commits{/sha}","git_commits_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/git/commits{/sha}","comments_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/comments{/number}","issue_comment_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/issues/comments{/number}","contents_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/contents/{+path}","compare_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/merges","archive_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/downloads","issues_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/issues{/number}","pulls_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/pulls{/number}","milestones_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/milestones{/number}","notifications_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/labels{/name}","releases_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/releases{/id}","deployments_url":"https://api.github.com/repos/alteryx/AlteryxPredictive/deployments","created_at":"2016-07-15T06:40:50Z","updated_at":"2016-12-06T20:38:36Z","pushed_at":"2017-01-18T20:34:26Z","git_url":"git://github.com/alteryx/AlteryxPredictive.git","ssh_url":"git@github.com:alteryx/AlteryxPredictive.git","clone_url":"https://github.com/alteryx/AlteryxPredictive.git","svn_url":"https://github.com/alteryx/AlteryxPredictive","homepage":null,"size":540,"stargazers_count":1,"watchers_count":1,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alteryx/AlteryxPredictive/pulls/110"},"html":{"href":"https://github.com/alteryx/AlteryxPredictive/pull/110"},"issue":{"href":"https://api.github.com/repos/alteryx/AlteryxPredictive/issues/110"},"comments":{"href":"https://api.github.com/repos/alteryx/AlteryxPredictive/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/alteryx/AlteryxPredictive/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/alteryx/AlteryxPredictive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alteryx/AlteryxPredictive/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/alteryx/AlteryxPredictive/statuses/35d3a5ef5581f63c8638497370953bb4da622156"}}}}
{"actor":{"display_login":"ramnathv"}}