{"action":"opened","number":50,"pull_request":{"url":"https://api.github.com/repos/ThierryGoubier/SmaCC/pulls/50","id":154306420,"html_url":"https://github.com/ThierryGoubier/SmaCC/pull/50","diff_url":"https://github.com/ThierryGoubier/SmaCC/pull/50.diff","patch_url":"https://github.com/ThierryGoubier/SmaCC/pull/50.patch","issue_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/issues/50","number":50,"state":"open","locked":false,"title":"Corrects a misconception about the meaning of stream position","user":{"login":"apblack","id":410893,"avatar_url":"https://avatars1.githubusercontent.com/u/410893?v=4","gravatar_id":"","url":"https://api.github.com/users/apblack","html_url":"https://github.com/apblack","followers_url":"https://api.github.com/users/apblack/followers","following_url":"https://api.github.com/users/apblack/following{/other_user}","gists_url":"https://api.github.com/users/apblack/gists{/gist_id}","starred_url":"https://api.github.com/users/apblack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apblack/subscriptions","organizations_url":"https://api.github.com/users/apblack/orgs","repos_url":"https://api.github.com/users/apblack/repos","events_url":"https://api.github.com/users/apblack/events{/privacy}","received_events_url":"https://api.github.com/users/apblack/received_events","type":"User","site_admin":false},"body":"A misconception about the meaning of position in a stream created an off-by-one error in the tests for LineNumberStream as well as in the code for LineNUmberStream>>columnNumber.  This wasn't very noticeable until I started highlighting token ranges in a browser, as well as printing them.\r\n\r\nThe position of a stream is the index of the most-recently-read character.  Initially, a stream is at position 0.  _After_ reading one character, it is at position 1, and so on.  The column number of a stream must therefor be initially 0, and it becomes 1 only after reading the first character of the stream, and subsequently after reading the first character of a line.\r\n\r\nIf the most recently-read character is (one of) the newline character(s), then the column position must be 0.\r\n\r\nI hop that this commit clarifies the tests, as well as adapting them so that the correct code passes the tests.","created_at":"2017-11-23T06:36:57Z","updated_at":"2017-11-23T06:36:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/pulls/50/commits","review_comments_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/pulls/50/comments","review_comment_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/issues/50/comments","statuses_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/statuses/d7fb6add47326e0be7649b1d5bce1dbbc1f391c9","head":{"label":"apblack:master","ref":"master","sha":"d7fb6add47326e0be7649b1d5bce1dbbc1f391c9","user":{"login":"apblack","id":410893,"avatar_url":"https://avatars1.githubusercontent.com/u/410893?v=4","gravatar_id":"","url":"https://api.github.com/users/apblack","html_url":"https://github.com/apblack","followers_url":"https://api.github.com/users/apblack/followers","following_url":"https://api.github.com/users/apblack/following{/other_user}","gists_url":"https://api.github.com/users/apblack/gists{/gist_id}","starred_url":"https://api.github.com/users/apblack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apblack/subscriptions","organizations_url":"https://api.github.com/users/apblack/orgs","repos_url":"https://api.github.com/users/apblack/repos","events_url":"https://api.github.com/users/apblack/events{/privacy}","received_events_url":"https://api.github.com/users/apblack/received_events","type":"User","site_admin":false},"repo":{"id":104228065,"name":"SmaCC","full_name":"apblack/SmaCC","owner":{"login":"apblack","id":410893,"avatar_url":"https://avatars1.githubusercontent.com/u/410893?v=4","gravatar_id":"","url":"https://api.github.com/users/apblack","html_url":"https://github.com/apblack","followers_url":"https://api.github.com/users/apblack/followers","following_url":"https://api.github.com/users/apblack/following{/other_user}","gists_url":"https://api.github.com/users/apblack/gists{/gist_id}","starred_url":"https://api.github.com/users/apblack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apblack/subscriptions","organizations_url":"https://api.github.com/users/apblack/orgs","repos_url":"https://api.github.com/users/apblack/repos","events_url":"https://api.github.com/users/apblack/events{/privacy}","received_events_url":"https://api.github.com/users/apblack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apblack/SmaCC","description":"Smalltalk Compiler Compiler : a parser generator","fork":true,"url":"https://api.github.com/repos/apblack/SmaCC","forks_url":"https://api.github.com/repos/apblack/SmaCC/forks","keys_url":"https://api.github.com/repos/apblack/SmaCC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apblack/SmaCC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apblack/SmaCC/teams","hooks_url":"https://api.github.com/repos/apblack/SmaCC/hooks","issue_events_url":"https://api.github.com/repos/apblack/SmaCC/issues/events{/number}","events_url":"https://api.github.com/repos/apblack/SmaCC/events","assignees_url":"https://api.github.com/repos/apblack/SmaCC/assignees{/user}","branches_url":"https://api.github.com/repos/apblack/SmaCC/branches{/branch}","tags_url":"https://api.github.com/repos/apblack/SmaCC/tags","blobs_url":"https://api.github.com/repos/apblack/SmaCC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apblack/SmaCC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apblack/SmaCC/git/refs{/sha}","trees_url":"https://api.github.com/repos/apblack/SmaCC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apblack/SmaCC/statuses/{sha}","languages_url":"https://api.github.com/repos/apblack/SmaCC/languages","stargazers_url":"https://api.github.com/repos/apblack/SmaCC/stargazers","contributors_url":"https://api.github.com/repos/apblack/SmaCC/contributors","subscribers_url":"https://api.github.com/repos/apblack/SmaCC/subscribers","subscription_url":"https://api.github.com/repos/apblack/SmaCC/subscription","commits_url":"https://api.github.com/repos/apblack/SmaCC/commits{/sha}","git_commits_url":"https://api.github.com/repos/apblack/SmaCC/git/commits{/sha}","comments_url":"https://api.github.com/repos/apblack/SmaCC/comments{/number}","issue_comment_url":"https://api.github.com/repos/apblack/SmaCC/issues/comments{/number}","contents_url":"https://api.github.com/repos/apblack/SmaCC/contents/{+path}","compare_url":"https://api.github.com/repos/apblack/SmaCC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apblack/SmaCC/merges","archive_url":"https://api.github.com/repos/apblack/SmaCC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apblack/SmaCC/downloads","issues_url":"https://api.github.com/repos/apblack/SmaCC/issues{/number}","pulls_url":"https://api.github.com/repos/apblack/SmaCC/pulls{/number}","milestones_url":"https://api.github.com/repos/apblack/SmaCC/milestones{/number}","notifications_url":"https://api.github.com/repos/apblack/SmaCC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apblack/SmaCC/labels{/name}","releases_url":"https://api.github.com/repos/apblack/SmaCC/releases{/id}","deployments_url":"https://api.github.com/repos/apblack/SmaCC/deployments","created_at":"2017-09-20T14:43:14Z","updated_at":"2017-09-20T14:43:34Z","pushed_at":"2017-11-23T06:31:18Z","git_url":"git://github.com/apblack/SmaCC.git","ssh_url":"git@github.com:apblack/SmaCC.git","clone_url":"https://github.com/apblack/SmaCC.git","svn_url":"https://github.com/apblack/SmaCC","homepage":null,"size":6691,"stargazers_count":0,"watchers_count":0,"language":"Smalltalk","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ThierryGoubier:master","ref":"master","sha":"83f488e867966a95d8a201178b368d4edbd831aa","user":{"login":"ThierryGoubier","id":4500310,"avatar_url":"https://avatars1.githubusercontent.com/u/4500310?v=4","gravatar_id":"","url":"https://api.github.com/users/ThierryGoubier","html_url":"https://github.com/ThierryGoubier","followers_url":"https://api.github.com/users/ThierryGoubier/followers","following_url":"https://api.github.com/users/ThierryGoubier/following{/other_user}","gists_url":"https://api.github.com/users/ThierryGoubier/gists{/gist_id}","starred_url":"https://api.github.com/users/ThierryGoubier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThierryGoubier/subscriptions","organizations_url":"https://api.github.com/users/ThierryGoubier/orgs","repos_url":"https://api.github.com/users/ThierryGoubier/repos","events_url":"https://api.github.com/users/ThierryGoubier/events{/privacy}","received_events_url":"https://api.github.com/users/ThierryGoubier/received_events","type":"User","site_admin":false},"repo":{"id":16067668,"name":"SmaCC","full_name":"ThierryGoubier/SmaCC","owner":{"login":"ThierryGoubier","id":4500310,"avatar_url":"https://avatars1.githubusercontent.com/u/4500310?v=4","gravatar_id":"","url":"https://api.github.com/users/ThierryGoubier","html_url":"https://github.com/ThierryGoubier","followers_url":"https://api.github.com/users/ThierryGoubier/followers","following_url":"https://api.github.com/users/ThierryGoubier/following{/other_user}","gists_url":"https://api.github.com/users/ThierryGoubier/gists{/gist_id}","starred_url":"https://api.github.com/users/ThierryGoubier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThierryGoubier/subscriptions","organizations_url":"https://api.github.com/users/ThierryGoubier/orgs","repos_url":"https://api.github.com/users/ThierryGoubier/repos","events_url":"https://api.github.com/users/ThierryGoubier/events{/privacy}","received_events_url":"https://api.github.com/users/ThierryGoubier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ThierryGoubier/SmaCC","description":"Smalltalk Compiler Compiler : a parser generator","fork":false,"url":"https://api.github.com/repos/ThierryGoubier/SmaCC","forks_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/forks","keys_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/teams","hooks_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/hooks","issue_events_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/issues/events{/number}","events_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/events","assignees_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/assignees{/user}","branches_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/branches{/branch}","tags_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/tags","blobs_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/git/refs{/sha}","trees_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/statuses/{sha}","languages_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/languages","stargazers_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/stargazers","contributors_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/contributors","subscribers_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/subscribers","subscription_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/subscription","commits_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/commits{/sha}","git_commits_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/git/commits{/sha}","comments_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/comments{/number}","issue_comment_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/issues/comments{/number}","contents_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/contents/{+path}","compare_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/merges","archive_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/downloads","issues_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/issues{/number}","pulls_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/pulls{/number}","milestones_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/milestones{/number}","notifications_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/labels{/name}","releases_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/releases{/id}","deployments_url":"https://api.github.com/repos/ThierryGoubier/SmaCC/deployments","created_at":"2014-01-20T10:31:32Z","updated_at":"2017-10-02T22:39:41Z","pushed_at":"2017-11-21T14:37:31Z","git_url":"git://github.com/ThierryGoubier/SmaCC.git","ssh_url":"git@github.com:ThierryGoubier/SmaCC.git","clone_url":"https://github.com/ThierryGoubier/SmaCC.git","svn_url":"https://github.com/ThierryGoubier/SmaCC","homepage":null,"size":6684,"stargazers_count":18,"watchers_count":18,"language":"Smalltalk","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":25,"forks":4,"open_issues":25,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ThierryGoubier/SmaCC/pulls/50"},"html":{"href":"https://github.com/ThierryGoubier/SmaCC/pull/50"},"issue":{"href":"https://api.github.com/repos/ThierryGoubier/SmaCC/issues/50"},"comments":{"href":"https://api.github.com/repos/ThierryGoubier/SmaCC/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/ThierryGoubier/SmaCC/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/ThierryGoubier/SmaCC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ThierryGoubier/SmaCC/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/ThierryGoubier/SmaCC/statuses/d7fb6add47326e0be7649b1d5bce1dbbc1f391c9"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":102,"deletions":44,"changed_files":13}}
{"actor":{"display_login":"apblack"}}