{"action":"created","comment":{"url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/comments/125354795","pull_request_review_id":47727878,"id":125354795,"diff_hunk":"@@ -1378,52 +1383,23 @@ candidate:1 1 UDP 1694498815 192.0.2.33 10000 typ host\n             setLocalDescription. However, the remote side, either\n             before or after setRemoteDescription, decides it does not\n             want to accept the new parameters, and sends a reject\n-            message back to the offerer. Now, the offerer, and possibly\n+            message back to the offerer.  Now, the offerer, and possibly\n             the answerer as well, need to return to a stable state and\n-            the previous local/remote description. To support this, we\n+            the previous local/remote description.  To support this, we\n             introduce the concept of \"rollback\".</t>\n \n-            <t>A rollback discards any proposed changes to the session,\n-            returning the state machine to the stable state, and\n-            setting the pending local and/or remote description (see\n-            <xref target=\"sec.pendinglocaldescription\" /> and\n-            <xref target=\"sec.pendingremotedescription\" />) to null.\n-            Any resources or candidates that were allocated by the\n-            abandoned local description are discarded; any media that\n-            is received will be processed according to the previous\n-            local and remote descriptions. Rollback can only be used to\n-            cancel proposed changes; there is no support for rolling\n-            back from a stable state to a previous stable state. Note\n-            that this implies that once the answerer has performed\n-            setLocalDescription with his answer, this cannot be rolled\n-            back.</t>\n-\n-            <t>A rollback will disassociate any RtpTransceivers that\n-            were associated with m= sections by the application of the\n-            rolled-back session description (see\n-            <xref target=\"sec.applying-a-remote-desc\" /> and\n-            <xref target=\"sec.applying-a-local-desc\" />). This means\n-            that some RtpTransceivers that were previously associated\n-            will no longer be associated with any m= section; in such\n-            cases, the value of the RtpTransceiver's mid property MUST\n-            be set to null, and the mapping between the transceiver and\n-            its m= section index MUST be discarded. RtpTransceivers\n-            that were created by applying a remote offer that was\n-            subsequently rolled back MUST be stopped and removed from\n-            the PeerConnection. However, a RtpTransceiver MUST NOT be\n-            removed if a track was attached to the RtpTransceiver via\n-            the addTrack method. This is so that an application may\n-            call addTrack, then call setRemoteDescription with an\n-            offer, then roll back that offer, then call createOffer and\n-            have a m= section for the added track appear in the\n-            generated offer.</t>\n-\n-            <t>A rollback is performed by supplying a session\n-            description of type \"rollback\" with empty contents to\n-            either setLocalDescription or setRemoteDescription,\n-            depending on which was most recently used (i.e. if the new\n-            offer was supplied to setLocalDescription, the rollback\n-            should be done using setLocalDescription as well).</t>\n+             <t>A rollback is performed by supplying a session\n+             description of type \"rollback\" with empty contents to\n+             either setLocalDescription or setRemoteDescription. It is\n+             further described in <xref\n+             target=\"sec.processing-a-rollback\"/>.  Rollback can only\n+             be used to cancel proposed changes; there is no support\n+             for rolling back from a stable state to a previous stable\n+             state. Note that this implies that once the answerer has\n+             performed setLocalDescription with his answer, this\n+             cannot be rolled back and neither the endpoint offerer or","path":"draft-ietf-rtcweb-jsep.xml","position":82,"original_position":82,"commit_id":"dc31a88d904810e6a9f9cbe0acb9ee516768c034","original_commit_id":"dc31a88d904810e6a9f9cbe0acb9ee516768c034","user":{"login":"ekr","id":1111457,"avatar_url":"https://avatars3.githubusercontent.com/u/1111457?v=3","gravatar_id":"","url":"https://api.github.com/users/ekr","html_url":"https://github.com/ekr","followers_url":"https://api.github.com/users/ekr/followers","following_url":"https://api.github.com/users/ekr/following{/other_user}","gists_url":"https://api.github.com/users/ekr/gists{/gist_id}","starred_url":"https://api.github.com/users/ekr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekr/subscriptions","organizations_url":"https://api.github.com/users/ekr/orgs","repos_url":"https://api.github.com/users/ekr/repos","events_url":"https://api.github.com/users/ekr/events{/privacy}","received_events_url":"https://api.github.com/users/ekr/received_events","type":"User","site_admin":false},"body":"As Justin says","created_at":"2017-07-03T20:40:09Z","updated_at":"2017-07-03T20:49:33Z","html_url":"https://github.com/rtcweb-wg/jsep/pull/746#discussion_r125354795","pull_request_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/746","_links":{"self":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/comments/125354795"},"html":{"href":"https://github.com/rtcweb-wg/jsep/pull/746#discussion_r125354795"},"pull_request":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/746"}}},"pull_request":{"url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/746","id":127246732,"html_url":"https://github.com/rtcweb-wg/jsep/pull/746","diff_url":"https://github.com/rtcweb-wg/jsep/pull/746.diff","patch_url":"https://github.com/rtcweb-wg/jsep/pull/746.patch","issue_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/746","number":746,"state":"open","locked":false,"title":"add pointers for rollback to apply local/remote sections","user":{"login":"fluffy","id":217200,"avatar_url":"https://avatars2.githubusercontent.com/u/217200?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffy","html_url":"https://github.com/fluffy","followers_url":"https://api.github.com/users/fluffy/followers","following_url":"https://api.github.com/users/fluffy/following{/other_user}","gists_url":"https://api.github.com/users/fluffy/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffy/subscriptions","organizations_url":"https://api.github.com/users/fluffy/orgs","repos_url":"https://api.github.com/users/fluffy/repos","events_url":"https://api.github.com/users/fluffy/events{/privacy}","received_events_url":"https://api.github.com/users/fluffy/received_events","type":"User","site_admin":false},"body":"Fixes #650 ","created_at":"2017-06-23T16:47:32Z","updated_at":"2017-07-03T20:49:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cfd2da7d9ea0e59357ba8d849aab2adcb9f07e5","assignee":{"login":"fluffy","id":217200,"avatar_url":"https://avatars2.githubusercontent.com/u/217200?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffy","html_url":"https://github.com/fluffy","followers_url":"https://api.github.com/users/fluffy/followers","following_url":"https://api.github.com/users/fluffy/following{/other_user}","gists_url":"https://api.github.com/users/fluffy/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffy/subscriptions","organizations_url":"https://api.github.com/users/fluffy/orgs","repos_url":"https://api.github.com/users/fluffy/repos","events_url":"https://api.github.com/users/fluffy/events{/privacy}","received_events_url":"https://api.github.com/users/fluffy/received_events","type":"User","site_admin":false},"assignees":[{"login":"fluffy","id":217200,"avatar_url":"https://avatars2.githubusercontent.com/u/217200?v=3","gravatar_id":"","url":"https://api.github.com/users/fluffy","html_url":"https://github.com/fluffy","followers_url":"https://api.github.com/users/fluffy/followers","following_url":"https://api.github.com/users/fluffy/following{/other_user}","gists_url":"https://api.github.com/users/fluffy/gists{/gist_id}","starred_url":"https://api.github.com/users/fluffy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fluffy/subscriptions","organizations_url":"https://api.github.com/users/fluffy/orgs","repos_url":"https://api.github.com/users/fluffy/repos","events_url":"https://api.github.com/users/fluffy/events{/privacy}","received_events_url":"https://api.github.com/users/fluffy/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"taylor-b","id":14118599,"avatar_url":"https://avatars0.githubusercontent.com/u/14118599?v=3","gravatar_id":"","url":"https://api.github.com/users/taylor-b","html_url":"https://github.com/taylor-b","followers_url":"https://api.github.com/users/taylor-b/followers","following_url":"https://api.github.com/users/taylor-b/following{/other_user}","gists_url":"https://api.github.com/users/taylor-b/gists{/gist_id}","starred_url":"https://api.github.com/users/taylor-b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylor-b/subscriptions","organizations_url":"https://api.github.com/users/taylor-b/orgs","repos_url":"https://api.github.com/users/taylor-b/repos","events_url":"https://api.github.com/users/taylor-b/events{/privacy}","received_events_url":"https://api.github.com/users/taylor-b/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/746/commits","review_comments_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/746/comments","review_comment_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/746/comments","statuses_url":"https://api.github.com/repos/rtcweb-wg/jsep/statuses/dc31a88d904810e6a9f9cbe0acb9ee516768c034","head":{"label":"rtcweb-wg:issue#650","ref":"issue#650","sha":"dc31a88d904810e6a9f9cbe0acb9ee516768c034","user":{"login":"rtcweb-wg","id":7396946,"avatar_url":"https://avatars1.githubusercontent.com/u/7396946?v=3","gravatar_id":"","url":"https://api.github.com/users/rtcweb-wg","html_url":"https://github.com/rtcweb-wg","followers_url":"https://api.github.com/users/rtcweb-wg/followers","following_url":"https://api.github.com/users/rtcweb-wg/following{/other_user}","gists_url":"https://api.github.com/users/rtcweb-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/rtcweb-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtcweb-wg/subscriptions","organizations_url":"https://api.github.com/users/rtcweb-wg/orgs","repos_url":"https://api.github.com/users/rtcweb-wg/repos","events_url":"https://api.github.com/users/rtcweb-wg/events{/privacy}","received_events_url":"https://api.github.com/users/rtcweb-wg/received_events","type":"Organization","site_admin":false},"repo":{"id":19118011,"name":"jsep","full_name":"rtcweb-wg/jsep","owner":{"login":"rtcweb-wg","id":7396946,"avatar_url":"https://avatars1.githubusercontent.com/u/7396946?v=3","gravatar_id":"","url":"https://api.github.com/users/rtcweb-wg","html_url":"https://github.com/rtcweb-wg","followers_url":"https://api.github.com/users/rtcweb-wg/followers","following_url":"https://api.github.com/users/rtcweb-wg/following{/other_user}","gists_url":"https://api.github.com/users/rtcweb-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/rtcweb-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtcweb-wg/subscriptions","organizations_url":"https://api.github.com/users/rtcweb-wg/orgs","repos_url":"https://api.github.com/users/rtcweb-wg/repos","events_url":"https://api.github.com/users/rtcweb-wg/events{/privacy}","received_events_url":"https://api.github.com/users/rtcweb-wg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rtcweb-wg/jsep","description":null,"fork":false,"url":"https://api.github.com/repos/rtcweb-wg/jsep","forks_url":"https://api.github.com/repos/rtcweb-wg/jsep/forks","keys_url":"https://api.github.com/repos/rtcweb-wg/jsep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtcweb-wg/jsep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtcweb-wg/jsep/teams","hooks_url":"https://api.github.com/repos/rtcweb-wg/jsep/hooks","issue_events_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/events{/number}","events_url":"https://api.github.com/repos/rtcweb-wg/jsep/events","assignees_url":"https://api.github.com/repos/rtcweb-wg/jsep/assignees{/user}","branches_url":"https://api.github.com/repos/rtcweb-wg/jsep/branches{/branch}","tags_url":"https://api.github.com/repos/rtcweb-wg/jsep/tags","blobs_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtcweb-wg/jsep/statuses/{sha}","languages_url":"https://api.github.com/repos/rtcweb-wg/jsep/languages","stargazers_url":"https://api.github.com/repos/rtcweb-wg/jsep/stargazers","contributors_url":"https://api.github.com/repos/rtcweb-wg/jsep/contributors","subscribers_url":"https://api.github.com/repos/rtcweb-wg/jsep/subscribers","subscription_url":"https://api.github.com/repos/rtcweb-wg/jsep/subscription","commits_url":"https://api.github.com/repos/rtcweb-wg/jsep/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtcweb-wg/jsep/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtcweb-wg/jsep/contents/{+path}","compare_url":"https://api.github.com/repos/rtcweb-wg/jsep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtcweb-wg/jsep/merges","archive_url":"https://api.github.com/repos/rtcweb-wg/jsep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtcweb-wg/jsep/downloads","issues_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues{/number}","pulls_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls{/number}","milestones_url":"https://api.github.com/repos/rtcweb-wg/jsep/milestones{/number}","notifications_url":"https://api.github.com/repos/rtcweb-wg/jsep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtcweb-wg/jsep/labels{/name}","releases_url":"https://api.github.com/repos/rtcweb-wg/jsep/releases{/id}","deployments_url":"https://api.github.com/repos/rtcweb-wg/jsep/deployments","created_at":"2014-04-24T17:46:05Z","updated_at":"2017-05-04T09:22:26Z","pushed_at":"2017-07-03T19:09:54Z","git_url":"git://github.com/rtcweb-wg/jsep.git","ssh_url":"git@github.com:rtcweb-wg/jsep.git","clone_url":"https://github.com/rtcweb-wg/jsep.git","svn_url":"https://github.com/rtcweb-wg/jsep","homepage":null,"size":7436,"stargazers_count":17,"watchers_count":17,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":3,"forks":19,"open_issues":3,"watchers":17,"default_branch":"master"}},"base":{"label":"rtcweb-wg:master","ref":"master","sha":"ab6e76d301c958f97daa5dc4e242ed3988020e85","user":{"login":"rtcweb-wg","id":7396946,"avatar_url":"https://avatars1.githubusercontent.com/u/7396946?v=3","gravatar_id":"","url":"https://api.github.com/users/rtcweb-wg","html_url":"https://github.com/rtcweb-wg","followers_url":"https://api.github.com/users/rtcweb-wg/followers","following_url":"https://api.github.com/users/rtcweb-wg/following{/other_user}","gists_url":"https://api.github.com/users/rtcweb-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/rtcweb-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtcweb-wg/subscriptions","organizations_url":"https://api.github.com/users/rtcweb-wg/orgs","repos_url":"https://api.github.com/users/rtcweb-wg/repos","events_url":"https://api.github.com/users/rtcweb-wg/events{/privacy}","received_events_url":"https://api.github.com/users/rtcweb-wg/received_events","type":"Organization","site_admin":false},"repo":{"id":19118011,"name":"jsep","full_name":"rtcweb-wg/jsep","owner":{"login":"rtcweb-wg","id":7396946,"avatar_url":"https://avatars1.githubusercontent.com/u/7396946?v=3","gravatar_id":"","url":"https://api.github.com/users/rtcweb-wg","html_url":"https://github.com/rtcweb-wg","followers_url":"https://api.github.com/users/rtcweb-wg/followers","following_url":"https://api.github.com/users/rtcweb-wg/following{/other_user}","gists_url":"https://api.github.com/users/rtcweb-wg/gists{/gist_id}","starred_url":"https://api.github.com/users/rtcweb-wg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtcweb-wg/subscriptions","organizations_url":"https://api.github.com/users/rtcweb-wg/orgs","repos_url":"https://api.github.com/users/rtcweb-wg/repos","events_url":"https://api.github.com/users/rtcweb-wg/events{/privacy}","received_events_url":"https://api.github.com/users/rtcweb-wg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rtcweb-wg/jsep","description":null,"fork":false,"url":"https://api.github.com/repos/rtcweb-wg/jsep","forks_url":"https://api.github.com/repos/rtcweb-wg/jsep/forks","keys_url":"https://api.github.com/repos/rtcweb-wg/jsep/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtcweb-wg/jsep/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtcweb-wg/jsep/teams","hooks_url":"https://api.github.com/repos/rtcweb-wg/jsep/hooks","issue_events_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/events{/number}","events_url":"https://api.github.com/repos/rtcweb-wg/jsep/events","assignees_url":"https://api.github.com/repos/rtcweb-wg/jsep/assignees{/user}","branches_url":"https://api.github.com/repos/rtcweb-wg/jsep/branches{/branch}","tags_url":"https://api.github.com/repos/rtcweb-wg/jsep/tags","blobs_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtcweb-wg/jsep/statuses/{sha}","languages_url":"https://api.github.com/repos/rtcweb-wg/jsep/languages","stargazers_url":"https://api.github.com/repos/rtcweb-wg/jsep/stargazers","contributors_url":"https://api.github.com/repos/rtcweb-wg/jsep/contributors","subscribers_url":"https://api.github.com/repos/rtcweb-wg/jsep/subscribers","subscription_url":"https://api.github.com/repos/rtcweb-wg/jsep/subscription","commits_url":"https://api.github.com/repos/rtcweb-wg/jsep/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtcweb-wg/jsep/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtcweb-wg/jsep/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtcweb-wg/jsep/contents/{+path}","compare_url":"https://api.github.com/repos/rtcweb-wg/jsep/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtcweb-wg/jsep/merges","archive_url":"https://api.github.com/repos/rtcweb-wg/jsep/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtcweb-wg/jsep/downloads","issues_url":"https://api.github.com/repos/rtcweb-wg/jsep/issues{/number}","pulls_url":"https://api.github.com/repos/rtcweb-wg/jsep/pulls{/number}","milestones_url":"https://api.github.com/repos/rtcweb-wg/jsep/milestones{/number}","notifications_url":"https://api.github.com/repos/rtcweb-wg/jsep/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtcweb-wg/jsep/labels{/name}","releases_url":"https://api.github.com/repos/rtcweb-wg/jsep/releases{/id}","deployments_url":"https://api.github.com/repos/rtcweb-wg/jsep/deployments","created_at":"2014-04-24T17:46:05Z","updated_at":"2017-05-04T09:22:26Z","pushed_at":"2017-07-03T19:09:54Z","git_url":"git://github.com/rtcweb-wg/jsep.git","ssh_url":"git@github.com:rtcweb-wg/jsep.git","clone_url":"https://github.com/rtcweb-wg/jsep.git","svn_url":"https://github.com/rtcweb-wg/jsep","homepage":null,"size":7436,"stargazers_count":17,"watchers_count":17,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"open_issues_count":3,"forks":19,"open_issues":3,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/746"},"html":{"href":"https://github.com/rtcweb-wg/jsep/pull/746"},"issue":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/issues/746"},"comments":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/issues/746/comments"},"review_comments":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/746/comments"},"review_comment":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/pulls/746/commits"},"statuses":{"href":"https://api.github.com/repos/rtcweb-wg/jsep/statuses/dc31a88d904810e6a9f9cbe0acb9ee516768c034"}}}}
{"actor":{"display_login":"ekr"}}