{"action":"created","issue":{"url":"https://api.github.com/repos/GRIFFINCollaboration/detectorSimulations_v10/issues/28","repository_url":"https://api.github.com/repos/GRIFFINCollaboration/detectorSimulations_v10","labels_url":"https://api.github.com/repos/GRIFFINCollaboration/detectorSimulations_v10/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/GRIFFINCollaboration/detectorSimulations_v10/issues/28/comments","events_url":"https://api.github.com/repos/GRIFFINCollaboration/detectorSimulations_v10/issues/28/events","html_url":"https://github.com/GRIFFINCollaboration/detectorSimulations_v10/pull/28","id":255754246,"number":28,"title":"SPICE updates pre master pull","user":{"login":"mspencerTRIUMF","id":29262955,"avatar_url":"https://avatars0.githubusercontent.com/u/29262955?v=4","gravatar_id":"","url":"https://api.github.com/users/mspencerTRIUMF","html_url":"https://github.com/mspencerTRIUMF","followers_url":"https://api.github.com/users/mspencerTRIUMF/followers","following_url":"https://api.github.com/users/mspencerTRIUMF/following{/other_user}","gists_url":"https://api.github.com/users/mspencerTRIUMF/gists{/gist_id}","starred_url":"https://api.github.com/users/mspencerTRIUMF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspencerTRIUMF/subscriptions","organizations_url":"https://api.github.com/users/mspencerTRIUMF/orgs","repos_url":"https://api.github.com/users/mspencerTRIUMF/repos","events_url":"https://api.github.com/users/mspencerTRIUMF/events{/privacy}","received_events_url":"https://api.github.com/users/mspencerTRIUMF/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-06T21:55:17Z","updated_at":"2017-09-12T21:31:10Z","closed_at":"2017-09-12T21:27:50Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/GRIFFINCollaboration/detectorSimulations_v10/pulls/28","html_url":"https://github.com/GRIFFINCollaboration/detectorSimulations_v10/pull/28","diff_url":"https://github.com/GRIFFINCollaboration/detectorSimulations_v10/pull/28.diff","patch_url":"https://github.com/GRIFFINCollaboration/detectorSimulations_v10/pull/28.patch"},"body":"I had a number of commits in my repository, this pull request is the inclusion of my updates to the new master code.\r\n\r\nEdit: resolved SPICE related conflicts. Will leave GRIFFIN conflicts for someone who knows that section of the code better. Looks mostly fine though."},"comment":{"url":"https://api.github.com/repos/GRIFFINCollaboration/detectorSimulations_v10/issues/comments/328990236","html_url":"https://github.com/GRIFFINCollaboration/detectorSimulations_v10/pull/28#issuecomment-328990236","issue_url":"https://api.github.com/repos/GRIFFINCollaboration/detectorSimulations_v10/issues/28","id":328990236,"user":{"login":"VinzenzBildstein","id":7277216,"avatar_url":"https://avatars1.githubusercontent.com/u/7277216?v=4","gravatar_id":"","url":"https://api.github.com/users/VinzenzBildstein","html_url":"https://github.com/VinzenzBildstein","followers_url":"https://api.github.com/users/VinzenzBildstein/followers","following_url":"https://api.github.com/users/VinzenzBildstein/following{/other_user}","gists_url":"https://api.github.com/users/VinzenzBildstein/gists{/gist_id}","starred_url":"https://api.github.com/users/VinzenzBildstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VinzenzBildstein/subscriptions","organizations_url":"https://api.github.com/users/VinzenzBildstein/orgs","repos_url":"https://api.github.com/users/VinzenzBildstein/repos","events_url":"https://api.github.com/users/VinzenzBildstein/events{/privacy}","received_events_url":"https://api.github.com/users/VinzenzBildstein/received_events","type":"User","site_admin":false},"created_at":"2017-09-12T21:31:10Z","updated_at":"2017-09-12T21:31:10Z","author_association":"OWNER","body":"Just some comments, beside the normal removing of conflicts:\r\n- there was a public member declared for HistoManager, changed that to private and added the appropriate setter and getter function\r\n- \"using namespace xxx\" is bad coding style, I removed that\r\n- you can't initialize members in the declaration of the class unless you use c++11, since we don't require that I've removed all initial values (which wouldn't have an effect anyways)\r\n"}}
{"actor":{"display_login":"VinzenzBildstein"}}