{"action":"created","issue":{"url":"https://api.github.com/repos/Yelp/py_zipkin/issues/57","repository_url":"https://api.github.com/repos/Yelp/py_zipkin","labels_url":"https://api.github.com/repos/Yelp/py_zipkin/issues/57/labels{/name}","comments_url":"https://api.github.com/repos/Yelp/py_zipkin/issues/57/comments","events_url":"https://api.github.com/repos/Yelp/py_zipkin/issues/57/events","html_url":"https://github.com/Yelp/py_zipkin/issues/57","id":248482174,"number":57,"title":"py_zipkin span is not accepted by the openzipkin collector.","user":{"login":"travelsalesman","id":2648252,"avatar_url":"https://avatars2.githubusercontent.com/u/2648252?v=4","gravatar_id":"","url":"https://api.github.com/users/travelsalesman","html_url":"https://github.com/travelsalesman","followers_url":"https://api.github.com/users/travelsalesman/followers","following_url":"https://api.github.com/users/travelsalesman/following{/other_user}","gists_url":"https://api.github.com/users/travelsalesman/gists{/gist_id}","starred_url":"https://api.github.com/users/travelsalesman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travelsalesman/subscriptions","organizations_url":"https://api.github.com/users/travelsalesman/orgs","repos_url":"https://api.github.com/users/travelsalesman/repos","events_url":"https://api.github.com/users/travelsalesman/events{/privacy}","received_events_url":"https://api.github.com/users/travelsalesman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-08-07T17:43:46Z","updated_at":"2017-08-29T00:58:04Z","closed_at":null,"body":"1. Run `docker run -d --net host openzipkin/zipkin`\r\n\r\n2. Install py-zipkin `pip install py-zipkin==0.8.3`\r\n2. Run the following python script: \r\n```\r\n#!/usr/bin/env python\r\n\r\nimport requests\r\n\r\nfrom py_zipkin.zipkin import zipkin_span\r\n\r\ndef http_transport(encoded_span):\r\n    # The collector expects a thrift-encoded list of spans.\r\n    requests.post(\r\n        'http://localhost:9411/api/v1/spans',\r\n        data=encoded_span,\r\n        headers={'Content-Type': 'application/x-thrift'},\r\n    )\r\n\r\nif __name__ == '__main__':\r\n    with zipkin_span(\r\n        service_name='test_service',\r\n        transport_handler=http_transport,\r\n        sample_rate=100.0,\r\n    ):\r\n        print \"Work\"\r\n```\r\nI see the following log line in the collector and  get a 400 responce\r\n\r\n```\r\n2017-08-07 00:43:04.851  WARN 7 --- [nio-9411-exec-7] zipkin.server.ZipkinHttpCollector        : [Malformed reading List<Span> from TBinary]([url](url))\r\n\r\njava.lang.IllegalArgumentException: Malformed reading List<Span> from TBinary\r\n\tat zipkin.internal.ThriftCodec.exceptionReading(ThriftCodec.java:600) ~[zipkin-1.29.1.jar!/:na]\r\n\tat zipkin.internal.ThriftCodec.readList(ThriftCodec.java:564) ~[zipkin-1.29.1.jar!/:na]\r\n\tat zipkin.internal.ThriftCodec.readSpans(ThriftCodec.java:88) ~[zipkin-1.29.1.jar!/:na]\r\n\tat zipkin.collector.Collector.acceptSpans(Collector.java:93) ~[zipkin-1.29.1.jar!/:na]\r\n\tat zipkin.server.ZipkinHttpCollector.validateAndStoreSpans(ZipkinHttpCollector.java:88) [classes/:na]\r\n\tat zipkin.server.ZipkinHttpCollector.uploadSpansThrift(ZipkinHttpCollector.java:73) [classes/:na]\r\n```\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Yelp/py_zipkin/issues/comments/325523623","html_url":"https://github.com/Yelp/py_zipkin/issues/57#issuecomment-325523623","issue_url":"https://api.github.com/repos/Yelp/py_zipkin/issues/57","id":325523623,"user":{"login":"adriancole","id":64215,"avatar_url":"https://avatars2.githubusercontent.com/u/64215?v=4","gravatar_id":"","url":"https://api.github.com/users/adriancole","html_url":"https://github.com/adriancole","followers_url":"https://api.github.com/users/adriancole/followers","following_url":"https://api.github.com/users/adriancole/following{/other_user}","gists_url":"https://api.github.com/users/adriancole/gists{/gist_id}","starred_url":"https://api.github.com/users/adriancole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adriancole/subscriptions","organizations_url":"https://api.github.com/users/adriancole/orgs","repos_url":"https://api.github.com/users/adriancole/repos","events_url":"https://api.github.com/users/adriancole/events{/privacy}","received_events_url":"https://api.github.com/users/adriancole/received_events","type":"User","site_admin":false},"created_at":"2017-08-29T00:58:03Z","updated_at":"2017-08-29T00:58:03Z","body":">\n> @adriancole <https://github.com/adriancole> docker image\n> opentracing/zipkin\n>\nI think you mean openzipkin/zipkin\n<https://hub.docker.com/r/openzipkin/zipkin/>, right? OpenZipkin predates\nOpenTracing and is not affiliated with it.\n"}}
{"actor":{"display_login":"adriancole"}}