{"action":"created","comment":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/134614096","pull_request_review_id":57926572,"id":134614096,"diff_hunk":"@@ -0,0 +1,24 @@\n+dnl #\n+dnl # 4.8 API change\n+dnl # kernel vm counters change\n+dnl #\n+AC_DEFUN([ZFS_AC_KERNEL_VM_NODE_STAT], [\n+\tAC_MSG_CHECKING([whether to use vm_node_stat based fn's])\n+\tZFS_LINUX_TRY_COMPILE([\n+\t\t#include <linux/mm.h>\n+\t\t#include <linux/vmstat.h>\n+        ],[\n+\t\t\tint a __attribute__ ((unused)) = NR_VM_NODE_STAT_ITEMS;\n+\t\t\tlong x __attribute__ ((unused)) =\n+\t\t\t\tatomic_long_read(&vm_node_stat[0]);\n+\t\t\t(void) global_node_page_state(0);\n+\t],[\n+\t\tAC_MSG_RESULT(yes)\n+\t\tAC_DEFINE(ZFS_GLOBAL_PAGE_STATE, global_node_page_state,","path":"config/kernel-vm_node_stat.m4","position":17,"original_position":17,"commit_id":"0fee180d36be644d19506502783e9f37d4ef9601","original_commit_id":"0fee180d36be644d19506502783e9f37d4ef9601","user":{"login":"tuxoko","id":119672,"avatar_url":"https://avatars3.githubusercontent.com/u/119672?v=4","gravatar_id":"","url":"https://api.github.com/users/tuxoko","html_url":"https://github.com/tuxoko","followers_url":"https://api.github.com/users/tuxoko/followers","following_url":"https://api.github.com/users/tuxoko/following{/other_user}","gists_url":"https://api.github.com/users/tuxoko/gists{/gist_id}","starred_url":"https://api.github.com/users/tuxoko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuxoko/subscriptions","organizations_url":"https://api.github.com/users/tuxoko/orgs","repos_url":"https://api.github.com/users/tuxoko/repos","events_url":"https://api.github.com/users/tuxoko/events{/privacy}","received_events_url":"https://api.github.com/users/tuxoko/received_events","type":"User","site_admin":false},"body":"Put the marcro definition in a .h file, otherwise it might be hard to find it.","created_at":"2017-08-22T22:07:10Z","updated_at":"2017-08-22T22:07:20Z","html_url":"https://github.com/zfsonlinux/zfs/pull/6528#discussion_r134614096","pull_request_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/6528","_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments/134614096"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/6528#discussion_r134614096"},"pull_request":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/6528"}}},"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/6528","id":136372941,"html_url":"https://github.com/zfsonlinux/zfs/pull/6528","diff_url":"https://github.com/zfsonlinux/zfs/pull/6528.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/6528.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/6528","number":6528,"state":"open","locked":false,"title":"Linux 4.8+ compatibility fix for vm stats","user":{"login":"dbavatar","id":14057304,"avatar_url":"https://avatars2.githubusercontent.com/u/14057304?v=4","gravatar_id":"","url":"https://api.github.com/users/dbavatar","html_url":"https://github.com/dbavatar","followers_url":"https://api.github.com/users/dbavatar/followers","following_url":"https://api.github.com/users/dbavatar/following{/other_user}","gists_url":"https://api.github.com/users/dbavatar/gists{/gist_id}","starred_url":"https://api.github.com/users/dbavatar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbavatar/subscriptions","organizations_url":"https://api.github.com/users/dbavatar/orgs","repos_url":"https://api.github.com/users/dbavatar/repos","events_url":"https://api.github.com/users/dbavatar/events{/privacy}","received_events_url":"https://api.github.com/users/dbavatar/received_events","type":"User","site_admin":false},"body":"vm_node_stat must be used instead of vm_zone_stat. Unfortunately the\r\nold code still compiles potentially leading to silent failure of\r\narc_evictable_memory()\r\n\r\nAKAMAI: CR 3816601: Regression in zfs dropcache test\r\n\r\nSigned-off-by: Debabrata Banerjee <dbanerje@akamai.com>\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n<!---\r\nDocumentation on ZFS Buildbot options can be found at\r\nhttps://github.com/zfsonlinux/zfs/wiki/Buildbot-Options\r\n-->\r\n\r\n### Description\r\nNew autoconf script to detect this\r\n\r\n### Motivation and Context\r\nUpstream changed the variable used without making old code fail compilation\r\nSee 11fb998986a72aa7e997d96d63d52582a01228c5\r\n\r\n### How Has This Been Tested?\r\nTested with debug code that we're building against stat that works. Waiting for the buildbot to verify builds against everything :-)\r\n\r\n### Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Performance enhancement (non-breaking change which improves efficiency)\r\n- [ ] Code cleanup (non-breaking change which makes code smaller or more readable)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] Documentation (a change to man pages or other documentation)\r\n\r\n### Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the ZFS on Linux code style requirements.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n- [x] All commit messages are properly formatted and contain `Signed-off-by`.\r\n- [ ] Change has been approved by a ZFS on Linux member.\r\n","created_at":"2017-08-17T23:14:06Z","updated_at":"2017-08-22T22:07:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6a92515229211979f00c87653c2dd903780c4ea","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/6528/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/6528/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/6528/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/0fee180d36be644d19506502783e9f37d4ef9601","head":{"label":"dbavatar:dbavatar/global_node_page_state","ref":"dbavatar/global_node_page_state","sha":"0fee180d36be644d19506502783e9f37d4ef9601","user":{"login":"dbavatar","id":14057304,"avatar_url":"https://avatars2.githubusercontent.com/u/14057304?v=4","gravatar_id":"","url":"https://api.github.com/users/dbavatar","html_url":"https://github.com/dbavatar","followers_url":"https://api.github.com/users/dbavatar/followers","following_url":"https://api.github.com/users/dbavatar/following{/other_user}","gists_url":"https://api.github.com/users/dbavatar/gists{/gist_id}","starred_url":"https://api.github.com/users/dbavatar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbavatar/subscriptions","organizations_url":"https://api.github.com/users/dbavatar/orgs","repos_url":"https://api.github.com/users/dbavatar/repos","events_url":"https://api.github.com/users/dbavatar/events{/privacy}","received_events_url":"https://api.github.com/users/dbavatar/received_events","type":"User","site_admin":false},"repo":{"id":86111796,"name":"zfs","full_name":"dbavatar/zfs","owner":{"login":"dbavatar","id":14057304,"avatar_url":"https://avatars2.githubusercontent.com/u/14057304?v=4","gravatar_id":"","url":"https://api.github.com/users/dbavatar","html_url":"https://github.com/dbavatar","followers_url":"https://api.github.com/users/dbavatar/followers","following_url":"https://api.github.com/users/dbavatar/following{/other_user}","gists_url":"https://api.github.com/users/dbavatar/gists{/gist_id}","starred_url":"https://api.github.com/users/dbavatar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbavatar/subscriptions","organizations_url":"https://api.github.com/users/dbavatar/orgs","repos_url":"https://api.github.com/users/dbavatar/repos","events_url":"https://api.github.com/users/dbavatar/events{/privacy}","received_events_url":"https://api.github.com/users/dbavatar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbavatar/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":true,"url":"https://api.github.com/repos/dbavatar/zfs","forks_url":"https://api.github.com/repos/dbavatar/zfs/forks","keys_url":"https://api.github.com/repos/dbavatar/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbavatar/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbavatar/zfs/teams","hooks_url":"https://api.github.com/repos/dbavatar/zfs/hooks","issue_events_url":"https://api.github.com/repos/dbavatar/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/dbavatar/zfs/events","assignees_url":"https://api.github.com/repos/dbavatar/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/dbavatar/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/dbavatar/zfs/tags","blobs_url":"https://api.github.com/repos/dbavatar/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbavatar/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbavatar/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbavatar/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbavatar/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/dbavatar/zfs/languages","stargazers_url":"https://api.github.com/repos/dbavatar/zfs/stargazers","contributors_url":"https://api.github.com/repos/dbavatar/zfs/contributors","subscribers_url":"https://api.github.com/repos/dbavatar/zfs/subscribers","subscription_url":"https://api.github.com/repos/dbavatar/zfs/subscription","commits_url":"https://api.github.com/repos/dbavatar/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbavatar/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbavatar/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbavatar/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbavatar/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/dbavatar/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbavatar/zfs/merges","archive_url":"https://api.github.com/repos/dbavatar/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbavatar/zfs/downloads","issues_url":"https://api.github.com/repos/dbavatar/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/dbavatar/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/dbavatar/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/dbavatar/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbavatar/zfs/labels{/name}","releases_url":"https://api.github.com/repos/dbavatar/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/dbavatar/zfs/deployments","created_at":"2017-03-24T21:24:27Z","updated_at":"2017-03-24T21:24:35Z","pushed_at":"2017-08-18T14:26:54Z","git_url":"git://github.com/dbavatar/zfs.git","ssh_url":"git@github.com:dbavatar/zfs.git","clone_url":"https://github.com/dbavatar/zfs.git","svn_url":"https://github.com/dbavatar/zfs","homepage":"http://zfsonlinux.org/","size":40239,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"08de8c16f5d322fb594742ea78958385d8ee5b50","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars3.githubusercontent.com/u/575083?v=4","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars3.githubusercontent.com/u/575083?v=4","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"ZFS on Linux - the official OpenZFS implementation for Linux.","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","deployments_url":"https://api.github.com/repos/zfsonlinux/zfs/deployments","created_at":"2009-12-14T20:20:34Z","updated_at":"2017-08-22T15:07:58Z","pushed_at":"2017-08-22T18:53:41Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":40349,"stargazers_count":2675,"watchers_count":2675,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":632,"mirror_url":null,"open_issues_count":882,"forks":632,"open_issues":882,"watchers":2675,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/6528"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/6528"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/6528"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/6528/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/6528/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/6528/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/0fee180d36be644d19506502783e9f37d4ef9601"}}}}
{"actor":{"display_login":"tuxoko"}}