{"action":"created","issue":{"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1083","repository_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework","labels_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1083/labels{/name}","comments_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1083/comments","events_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1083/events","html_url":"https://github.com/vanilla-framework/vanilla-framework/issues/1083","id":231308539,"number":1083,"title":"Inconsistent navigation header height between Vanilla-using sites","user":{"login":"matthewpaulthomas","id":19801137,"avatar_url":"https://avatars2.githubusercontent.com/u/19801137?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewpaulthomas","html_url":"https://github.com/matthewpaulthomas","followers_url":"https://api.github.com/users/matthewpaulthomas/followers","following_url":"https://api.github.com/users/matthewpaulthomas/following{/other_user}","gists_url":"https://api.github.com/users/matthewpaulthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewpaulthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewpaulthomas/subscriptions","organizations_url":"https://api.github.com/users/matthewpaulthomas/orgs","repos_url":"https://api.github.com/users/matthewpaulthomas/repos","events_url":"https://api.github.com/users/matthewpaulthomas/events{/privacy}","received_events_url":"https://api.github.com/users/matthewpaulthomas/received_events","type":"User","site_admin":false},"labels":[{"id":385881423,"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/labels/Priority:%20High","name":"Priority: High","color":"ECA918","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-05-25T11:01:10Z","updated_at":"2017-07-18T15:59:12Z","closed_at":"2017-07-18T15:57:57Z","body":"[The “Navigation” page](https://docs.vanillaframework.io/en/patterns/navigation) shows a navigation header that is 48px high:\r\n`html {font-size: 16 px}` × (`.p-navigation__link > a {font-size: .875rem}` +\r\n`.p-navigation .p-navigation__links .p-navigation__link {padding: .75rem 1.25rem;}`)\r\n= 16px × (0.875 + 0.75 top + 0.75 bottom) = 48px.\r\n\r\nSome sites using Vanilla are consistent with this:\r\n48px [www.ubuntu.com](https://www.ubuntu.com/)\r\n48px [www.canonical.com](https://www.canonical.com/)\r\n48px [maas.io](https://maas.io/)\r\n\r\nUnfortunately, others are not:\r\n50px [build.snapcraft.io](https://build.snapcraft.io/) ([#800](https://github.com/canonical-websites/build.snapcraft.io/issues/800))\r\n51px [snapcraft.io](https://snapcraft.io/), including [snapcraft.io/docs](https://snapcraft.io/docs/)\r\n53px [docs.ubuntu.com](https://docs.ubuntu.com/core/en/)\r\n53px [jujucharms.com](https://jujucharms.com/how-it-works)\r\n\r\nThe jujucharms.com example is apparently from the past couple of weeks, and build.snapcraft.io from only 3~4 months ago, which suggests that this is not just a matter of some sites using out-of-date Vanilla versions.\r\n\r\nSo, it may be worthwhile investigating how they became inconsistent, and how this can be avoided in future."},"comment":{"url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/comments/316111170","html_url":"https://github.com/vanilla-framework/vanilla-framework/issues/1083#issuecomment-316111170","issue_url":"https://api.github.com/repos/vanilla-framework/vanilla-framework/issues/1083","id":316111170,"user":{"login":"yaili","id":223966,"avatar_url":"https://avatars1.githubusercontent.com/u/223966?v=4","gravatar_id":"","url":"https://api.github.com/users/yaili","html_url":"https://github.com/yaili","followers_url":"https://api.github.com/users/yaili/followers","following_url":"https://api.github.com/users/yaili/following{/other_user}","gists_url":"https://api.github.com/users/yaili/gists{/gist_id}","starred_url":"https://api.github.com/users/yaili/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaili/subscriptions","organizations_url":"https://api.github.com/users/yaili/orgs","repos_url":"https://api.github.com/users/yaili/repos","events_url":"https://api.github.com/users/yaili/events{/privacy}","received_events_url":"https://api.github.com/users/yaili/received_events","type":"User","site_admin":false},"created_at":"2017-07-18T15:59:12Z","updated_at":"2017-07-18T15:59:12Z","body":"This issue was moved to ubuntudesign/vanilla-design#39"}}
{"actor":{"display_login":"yaili"}}