{"action":"created","comment":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments/142042450","pull_request_review_id":66348890,"id":142042450,"diff_hunk":"@@ -1427,6 +1427,7 @@ Layer:\n             tags->'power_source' as power_source,\n             tags->'icao' as icao,\n             tags->'iata' as iata,\n+            tags->'parking' as parking,","path":"project.mml","position":4,"original_position":4,"commit_id":"0b5bb0f56408902f4c8ea8ca6d8ebce6c359f504","original_commit_id":"0b5bb0f56408902f4c8ea8ca6d8ebce6c359f504","user":{"login":"pnorman","id":1190866,"avatar_url":"https://avatars0.githubusercontent.com/u/1190866?v=4","gravatar_id":"","url":"https://api.github.com/users/pnorman","html_url":"https://github.com/pnorman","followers_url":"https://api.github.com/users/pnorman/followers","following_url":"https://api.github.com/users/pnorman/following{/other_user}","gists_url":"https://api.github.com/users/pnorman/gists{/gist_id}","starred_url":"https://api.github.com/users/pnorman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pnorman/subscriptions","organizations_url":"https://api.github.com/users/pnorman/orgs","repos_url":"https://api.github.com/users/pnorman/repos","events_url":"https://api.github.com/users/pnorman/events{/privacy}","received_events_url":"https://api.github.com/users/pnorman/received_events","type":"User","site_admin":false},"body":"https://vimeo.com/68093876 talks about the problem starting at 10:52-14:21. The best way to check this isn't a problem here is to compare the line count of the XML output. If it increases by a dozen lines, that's fine. If it increases by 10000 lines, it's a problem.\r\n\r\nI **suspect** this is okay, but I'm not 100% sure. If you added something that styled **all** objects with some parking value then it would definitely be a problem.","created_at":"2017-10-01T22:26:25Z","updated_at":"2017-10-01T22:26:25Z","html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2875#discussion_r142042450","pull_request_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2875","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments/142042450"},"html":{"href":"https://github.com/gravitystorm/openstreetmap-carto/pull/2875#discussion_r142042450"},"pull_request":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2875"}},"in_reply_to_id":142039826},"pull_request":{"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2875","id":144053494,"html_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2875","diff_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2875.diff","patch_url":"https://github.com/gravitystorm/openstreetmap-carto/pull/2875.patch","issue_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2875","number":2875,"state":"open","locked":false,"title":"Adding rendering for amenity=parking_entrance [WIP]","user":{"login":"kocio-pl","id":5439713,"avatar_url":"https://avatars2.githubusercontent.com/u/5439713?v=4","gravatar_id":"","url":"https://api.github.com/users/kocio-pl","html_url":"https://github.com/kocio-pl","followers_url":"https://api.github.com/users/kocio-pl/followers","following_url":"https://api.github.com/users/kocio-pl/following{/other_user}","gists_url":"https://api.github.com/users/kocio-pl/gists{/gist_id}","starred_url":"https://api.github.com/users/kocio-pl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocio-pl/subscriptions","organizations_url":"https://api.github.com/users/kocio-pl/orgs","repos_url":"https://api.github.com/users/kocio-pl/repos","events_url":"https://api.github.com/users/kocio-pl/events{/privacy}","received_events_url":"https://api.github.com/users/kocio-pl/received_events","type":"User","site_admin":false},"body":"Resolves #270.\r\nRelated to https://github.com/gravitystorm/openstreetmap-carto/issues/552#issuecomment-331990727.\r\n\r\nThis is a draft which renders such entrances but only for `parking=underground`, because other parkings are visible in our style anyway. I plan to:\r\n- [ ]  add the name rendering (it might be useful to know which underground object it leads to)\r\n- [ ]  restrict rendering only to `access=yes` and `access=permissive` (there's too many of private underground parkings)\r\n\r\nExample:\r\n![kx73oup3](https://user-images.githubusercontent.com/5439713/31051235-56dbf6de-a663-11e7-9c12-0475d33666e4.png)","created_at":"2017-10-01T02:49:33Z","updated_at":"2017-10-01T22:26:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ef8e88d900ea40ab6871e744670b4fd6de6e1ad","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2875/commits","review_comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2875/comments","review_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2875/comments","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/0b5bb0f56408902f4c8ea8ca6d8ebce6c359f504","head":{"label":"kocio-pl:parking-entrance","ref":"parking-entrance","sha":"0b5bb0f56408902f4c8ea8ca6d8ebce6c359f504","user":{"login":"kocio-pl","id":5439713,"avatar_url":"https://avatars2.githubusercontent.com/u/5439713?v=4","gravatar_id":"","url":"https://api.github.com/users/kocio-pl","html_url":"https://github.com/kocio-pl","followers_url":"https://api.github.com/users/kocio-pl/followers","following_url":"https://api.github.com/users/kocio-pl/following{/other_user}","gists_url":"https://api.github.com/users/kocio-pl/gists{/gist_id}","starred_url":"https://api.github.com/users/kocio-pl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocio-pl/subscriptions","organizations_url":"https://api.github.com/users/kocio-pl/orgs","repos_url":"https://api.github.com/users/kocio-pl/repos","events_url":"https://api.github.com/users/kocio-pl/events{/privacy}","received_events_url":"https://api.github.com/users/kocio-pl/received_events","type":"User","site_admin":false},"repo":{"id":24188137,"name":"openstreetmap-carto","full_name":"kocio-pl/openstreetmap-carto","owner":{"login":"kocio-pl","id":5439713,"avatar_url":"https://avatars2.githubusercontent.com/u/5439713?v=4","gravatar_id":"","url":"https://api.github.com/users/kocio-pl","html_url":"https://github.com/kocio-pl","followers_url":"https://api.github.com/users/kocio-pl/followers","following_url":"https://api.github.com/users/kocio-pl/following{/other_user}","gists_url":"https://api.github.com/users/kocio-pl/gists{/gist_id}","starred_url":"https://api.github.com/users/kocio-pl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kocio-pl/subscriptions","organizations_url":"https://api.github.com/users/kocio-pl/orgs","repos_url":"https://api.github.com/users/kocio-pl/repos","events_url":"https://api.github.com/users/kocio-pl/events{/privacy}","received_events_url":"https://api.github.com/users/kocio-pl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kocio-pl/openstreetmap-carto","description":"A project to re-implement the standard OpenStreetMap mapnik style, in CartoCSS","fork":true,"url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto","forks_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/forks","keys_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/teams","hooks_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/hooks","issue_events_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/issues/events{/number}","events_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/events","assignees_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/assignees{/user}","branches_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/branches{/branch}","tags_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/tags","blobs_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/git/refs{/sha}","trees_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/statuses/{sha}","languages_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/languages","stargazers_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/stargazers","contributors_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/contributors","subscribers_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/subscribers","subscription_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/subscription","commits_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/commits{/sha}","git_commits_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/git/commits{/sha}","comments_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/comments{/number}","issue_comment_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/issues/comments{/number}","contents_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/contents/{+path}","compare_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/merges","archive_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/downloads","issues_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/issues{/number}","pulls_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/pulls{/number}","milestones_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/milestones{/number}","notifications_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/labels{/name}","releases_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/releases{/id}","deployments_url":"https://api.github.com/repos/kocio-pl/openstreetmap-carto/deployments","created_at":"2014-09-18T12:57:08Z","updated_at":"2016-10-28T23:16:49Z","pushed_at":"2017-10-01T22:24:22Z","git_url":"git://github.com/kocio-pl/openstreetmap-carto.git","ssh_url":"git@github.com:kocio-pl/openstreetmap-carto.git","clone_url":"https://github.com/kocio-pl/openstreetmap-carto.git","svn_url":"https://github.com/kocio-pl/openstreetmap-carto","homepage":null,"size":11122,"stargazers_count":1,"watchers_count":1,"language":"CartoCSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"gravitystorm:master","ref":"master","sha":"ef7d52d604ab0fd4cf42aafe3fd266631e8f7ab2","user":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars1.githubusercontent.com/u/360803?v=4","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"repo":{"id":6707453,"name":"openstreetmap-carto","full_name":"gravitystorm/openstreetmap-carto","owner":{"login":"gravitystorm","id":360803,"avatar_url":"https://avatars1.githubusercontent.com/u/360803?v=4","gravatar_id":"","url":"https://api.github.com/users/gravitystorm","html_url":"https://github.com/gravitystorm","followers_url":"https://api.github.com/users/gravitystorm/followers","following_url":"https://api.github.com/users/gravitystorm/following{/other_user}","gists_url":"https://api.github.com/users/gravitystorm/gists{/gist_id}","starred_url":"https://api.github.com/users/gravitystorm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gravitystorm/subscriptions","organizations_url":"https://api.github.com/users/gravitystorm/orgs","repos_url":"https://api.github.com/users/gravitystorm/repos","events_url":"https://api.github.com/users/gravitystorm/events{/privacy}","received_events_url":"https://api.github.com/users/gravitystorm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gravitystorm/openstreetmap-carto","description":"A general-purpose OpenStreetMap mapnik style, in CartoCSS","fork":false,"url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto","forks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/forks","keys_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/teams","hooks_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/hooks","issue_events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/events{/number}","events_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/events","assignees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/assignees{/user}","branches_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/branches{/branch}","tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/tags","blobs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/refs{/sha}","trees_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/{sha}","languages_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/languages","stargazers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/stargazers","contributors_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/contributors","subscribers_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/subscribers","subscription_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/subscription","commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/commits{/sha}","git_commits_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/git/commits{/sha}","comments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/comments{/number}","issue_comment_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/comments{/number}","contents_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/contents/{+path}","compare_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/merges","archive_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/downloads","issues_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues{/number}","pulls_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls{/number}","milestones_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/milestones{/number}","notifications_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/labels{/name}","releases_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/releases{/id}","deployments_url":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/deployments","created_at":"2012-11-15T16:06:16Z","updated_at":"2017-09-30T01:05:16Z","pushed_at":"2017-10-01T22:19:56Z","git_url":"git://github.com/gravitystorm/openstreetmap-carto.git","ssh_url":"git@github.com:gravitystorm/openstreetmap-carto.git","clone_url":"https://github.com/gravitystorm/openstreetmap-carto.git","svn_url":"https://github.com/gravitystorm/openstreetmap-carto","homepage":"","size":10074,"stargazers_count":585,"watchers_count":585,"language":"CartoCSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":313,"mirror_url":null,"open_issues_count":401,"forks":313,"open_issues":401,"watchers":585,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2875"},"html":{"href":"https://github.com/gravitystorm/openstreetmap-carto/pull/2875"},"issue":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2875"},"comments":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/issues/2875/comments"},"review_comments":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2875/comments"},"review_comment":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/pulls/2875/commits"},"statuses":{"href":"https://api.github.com/repos/gravitystorm/openstreetmap-carto/statuses/0b5bb0f56408902f4c8ea8ca6d8ebce6c359f504"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"pnorman"}}