{"action":"created","issue":{"url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/568","repository_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus","labels_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/568/labels{/name}","comments_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/568/comments","events_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/568/events","html_url":"https://github.com/Particular/NServiceBus.AzureServiceBus/issues/568","id":232845348,"number":568,"title":"Stop triggering CircuitBreaker for TimeoutExceptions and MessageExceptions that are transient","user":{"login":"danielmarbach","id":174258,"avatar_url":"https://avatars2.githubusercontent.com/u/174258?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"labels":[{"id":263510960,"url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/labels/Bug","name":"Bug","color":"e10c02","default":false},{"id":597464396,"url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/labels/State:%20In%20Progress","name":"State: In Progress","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":{"login":"SeanFeldman","id":1309622,"avatar_url":"https://avatars1.githubusercontent.com/u/1309622?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanFeldman","html_url":"https://github.com/SeanFeldman","followers_url":"https://api.github.com/users/SeanFeldman/followers","following_url":"https://api.github.com/users/SeanFeldman/following{/other_user}","gists_url":"https://api.github.com/users/SeanFeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanFeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanFeldman/subscriptions","organizations_url":"https://api.github.com/users/SeanFeldman/orgs","repos_url":"https://api.github.com/users/SeanFeldman/repos","events_url":"https://api.github.com/users/SeanFeldman/events{/privacy}","received_events_url":"https://api.github.com/users/SeanFeldman/received_events","type":"User","site_admin":false},"assignees":[{"login":"SeanFeldman","id":1309622,"avatar_url":"https://avatars1.githubusercontent.com/u/1309622?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanFeldman","html_url":"https://github.com/SeanFeldman","followers_url":"https://api.github.com/users/SeanFeldman/followers","following_url":"https://api.github.com/users/SeanFeldman/following{/other_user}","gists_url":"https://api.github.com/users/SeanFeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanFeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanFeldman/subscriptions","organizations_url":"https://api.github.com/users/SeanFeldman/orgs","repos_url":"https://api.github.com/users/SeanFeldman/repos","events_url":"https://api.github.com/users/SeanFeldman/events{/privacy}","received_events_url":"https://api.github.com/users/SeanFeldman/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/milestones/38","html_url":"https://github.com/Particular/NServiceBus.AzureServiceBus/milestone/38","labels_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/milestones/38/labels","id":2598948,"number":38,"title":"7.2.6","description":null,"creator":{"login":"SeanFeldman","id":1309622,"avatar_url":"https://avatars1.githubusercontent.com/u/1309622?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanFeldman","html_url":"https://github.com/SeanFeldman","followers_url":"https://api.github.com/users/SeanFeldman/followers","following_url":"https://api.github.com/users/SeanFeldman/following{/other_user}","gists_url":"https://api.github.com/users/SeanFeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanFeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanFeldman/subscriptions","organizations_url":"https://api.github.com/users/SeanFeldman/orgs","repos_url":"https://api.github.com/users/SeanFeldman/repos","events_url":"https://api.github.com/users/SeanFeldman/events{/privacy}","received_events_url":"https://api.github.com/users/SeanFeldman/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":2,"state":"open","created_at":"2017-06-22T17:43:25Z","updated_at":"2017-06-29T19:30:54Z","due_on":null,"closed_at":null},"comments":20,"created_at":"2017-06-01T11:13:39Z","updated_at":"2017-06-29T19:30:54Z","closed_at":"2017-06-29T19:30:54Z","body":"Raised from #567 \r\n\r\n## Who's affected\r\n\r\n* Azure Service Bus users with flaky connection to the broker or the broker misbehaving\r\n\r\n## Symptoms\r\n\r\nWhen the broker connection is flaky messages being received can run into the auto lock renewal. When the auto lock renewal process kicks in the Azure SDK raises the `OnExceptionReceived` event. Our adapter subscribes to this event and triggers the circuit breaker for all exceptions that are not `MessageException` with the `IsTransient` property set to `true`. AutoLockRenewal is not treated as a transient exception although it should be. AutoLockRenewal will therefore eventually shut down the endpoint\r\n\r\n```\r\nC:\\BuildAgent\\work\\2f57832e2eee436e\\src\\Transport\\Receiving\\MessageReceiverNotifier.cs:line 225\"\r\n\"event-48b20435a87208d4c0d5240800000000\",\"$6E8DD99D\",\"2017-05-31T22:13:36.5446709+00:00\",\"Debug\",\"Abandoning brokered message de65586d-5427-48d4-9b31-701aee51eec5\",\"\"\r\n\"event-544a9bb3a87208d407d6240800000000\",\"$6097FB2F\",\"2017-05-31T22:13:55.9996339+00:00\",\"Information\",\"OptionsOnExceptionReceived invoked, action: 'RenewLock', with non-transient exception.\",\"System.TimeoutException: The request operation did not complete within the allotted timeout of 00:00:19.0642016. The time allotted to this operation may have been a portion of a longer timeout. For more information on exception types and proper exception handling, please refer to http://go.microsoft.com/fwlink/?LinkId=761101 TrackingId:65083aba-fde6-4e5f-8608-444e17d9c0ed, Timestamp:5/31/2017 10:13:55 PM\r\nat  ... [NotImportant]\r\n31T22:13:55.9996339+00:00\",\"Warning\",\"The circuit breaker for MessagePump on the queue `ITops.Site` is now in the armed state\",\"\"\r\n```\r\n\r\n## Fix\r\nTreat `TimeoutException` and `MessageException` with `IsTransient` property set to true as transient failures.\r\n\r\nSee comment https://github.com/Particular/NServiceBus.AzureServiceBus/issues/568#issuecomment-306455094\r\n\r\n### PoA:\r\n\r\n- [X] Code changes --> https://github.com/Particular/NServiceBus.AzureServiceBus/pull/583\r\n- [x] update doco + smoke test --> https://github.com/Particular/docs.particular.net/pull/2905\r\n- [ ] Create announcement --> https://github.com/Particular/Announcements/pull/165\r\n- [ ] Release -> link\r\n- [ ] Announce on Google Group(https://groups.google.com/forum/#!topic/particularsoftware/yvoWF8c4Av0)"},"comment":{"url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/comments/312075522","html_url":"https://github.com/Particular/NServiceBus.AzureServiceBus/issues/568#issuecomment-312075522","issue_url":"https://api.github.com/repos/Particular/NServiceBus.AzureServiceBus/issues/568","id":312075522,"user":{"login":"SeanFeldman","id":1309622,"avatar_url":"https://avatars1.githubusercontent.com/u/1309622?v=3","gravatar_id":"","url":"https://api.github.com/users/SeanFeldman","html_url":"https://github.com/SeanFeldman","followers_url":"https://api.github.com/users/SeanFeldman/followers","following_url":"https://api.github.com/users/SeanFeldman/following{/other_user}","gists_url":"https://api.github.com/users/SeanFeldman/gists{/gist_id}","starred_url":"https://api.github.com/users/SeanFeldman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SeanFeldman/subscriptions","organizations_url":"https://api.github.com/users/SeanFeldman/orgs","repos_url":"https://api.github.com/users/SeanFeldman/repos","events_url":"https://api.github.com/users/SeanFeldman/events{/privacy}","received_events_url":"https://api.github.com/users/SeanFeldman/received_events","type":"User","site_admin":false},"created_at":"2017-06-29T19:30:54Z","updated_at":"2017-06-29T19:30:54Z","body":"Closed via #583"}}
{"actor":{"display_login":"SeanFeldman"}}