{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/19116","repository_url":"https://api.github.com/repos/joomla/joomla-cms","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19116/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19116/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19116/events","html_url":"https://github.com/joomla/joomla-cms/pull/19116","id":283825284,"number":19116,"title":"com_redirect modal close button check in fix","user":{"login":"Ruud68","id":2733197,"avatar_url":"https://avatars1.githubusercontent.com/u/2733197?v=4","gravatar_id":"","url":"https://api.github.com/users/Ruud68","html_url":"https://github.com/Ruud68","followers_url":"https://api.github.com/users/Ruud68/followers","following_url":"https://api.github.com/users/Ruud68/following{/other_user}","gists_url":"https://api.github.com/users/Ruud68/gists{/gist_id}","starred_url":"https://api.github.com/users/Ruud68/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ruud68/subscriptions","organizations_url":"https://api.github.com/users/Ruud68/orgs","repos_url":"https://api.github.com/users/Ruud68/repos","events_url":"https://api.github.com/users/Ruud68/events{/privacy}","received_events_url":"https://api.github.com/users/Ruud68/received_events","type":"User","site_admin":false},"labels":[{"id":60721348,"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-21T09:43:49Z","updated_at":"2017-12-24T15:48:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/19116","html_url":"https://github.com/joomla/joomla-cms/pull/19116","diff_url":"https://github.com/joomla/joomla-cms/pull/19116.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/19116.patch"},"body":"Pull Request for Issue # .\r\n\r\n### Summary of Changes\r\nChanged the close button (footer) to execute the plugin.cancel task\r\n\r\n### Testing Instructions\r\n\r\n1. [tab 1]open com_redirect\r\n2. [tab 2] open second tab with com_plugins and filter on 'redirect' plugin\r\n3. in [tab 2] enable the redirect plugin and disable the collect urls > save the plugin\r\n4. in [tab 1] in com_redirect click the 'Redirect System Plugin' link in the notice\r\n5. clicking the [Close] button will close the modal\r\n\r\n### Expected result\r\n\r\nThe plg_system_redirect should be checked in\r\n\r\n### Actual result\r\n\r\nThe plg_system_redirect is NOT checked in.\r\nin [tab 2] press ctrl-f5 and you can see that although the modal in tab 1 is closed, the plugin is not checked in correct.\r\n\r\n### Documentation Changes Required\r\nnone.\r\n\r\n### Note\r\nthis was previously fixed here: https://github.com/joomla/joomla-cms/pull/18292 but unfortunately reintroduced with normalize patch: https://github.com/joomla/joomla-cms/pull/18913"},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/353791127","html_url":"https://github.com/joomla/joomla-cms/pull/19116#issuecomment-353791127","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/19116","id":353791127,"user":{"login":"Quy","id":368084,"avatar_url":"https://avatars2.githubusercontent.com/u/368084?v=4","gravatar_id":"","url":"https://api.github.com/users/Quy","html_url":"https://github.com/Quy","followers_url":"https://api.github.com/users/Quy/followers","following_url":"https://api.github.com/users/Quy/following{/other_user}","gists_url":"https://api.github.com/users/Quy/gists{/gist_id}","starred_url":"https://api.github.com/users/Quy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quy/subscriptions","organizations_url":"https://api.github.com/users/Quy/orgs","repos_url":"https://api.github.com/users/Quy/repos","events_url":"https://api.github.com/users/Quy/events{/privacy}","received_events_url":"https://api.github.com/users/Quy/received_events","type":"User","site_admin":false},"created_at":"2017-12-24T15:48:35Z","updated_at":"2017-12-24T15:48:35Z","author_association":"CONTRIBUTOR","body":"I have tested this item :white_check_mark: successfully on 71bb5d969943bf7473ebdf9f2b56a47c1c5b42cb<hr /><sub>This comment was created with the <a href=\"https://github.com/joomla/jissues\">J!Tracker Application</a> at <a href=\"https://issues.joomla.org/tracker/joomla-cms/19116\">issues.joomla.org/tracker/joomla-cms/19116</a>.</sub>"}}
{"actor":{"display_login":"Quy"}}