{"action":"created","comment":{"url":"https://api.github.com/repos/realm/SwiftLint/pulls/comments/96635814","pull_request_review_id":17222330,"id":96635814,"diff_hunk":"@@ -20,7 +20,11 @@ extension CharacterSet {\n             return true\n         #else\n             let otherSet = CharacterSet(charactersIn: string)\n-            return isSuperset(of: otherSet)\n+\n+            // swiftlint:disable force_cast","path":"Source/SwiftLintFramework/Extensions/CharacterSet+LinuxHack.swift","position":6,"original_position":6,"commit_id":"e22bf9df20fe46d9e1aa5b2ce0eb6de573f4c554","original_commit_id":"e22bf9df20fe46d9e1aa5b2ce0eb6de573f4c554","user":{"login":"aamctustwo","id":14542757,"avatar_url":"https://avatars.githubusercontent.com/u/14542757?v=3","gravatar_id":"","url":"https://api.github.com/users/aamctustwo","html_url":"https://github.com/aamctustwo","followers_url":"https://api.github.com/users/aamctustwo/followers","following_url":"https://api.github.com/users/aamctustwo/following{/other_user}","gists_url":"https://api.github.com/users/aamctustwo/gists{/gist_id}","starred_url":"https://api.github.com/users/aamctustwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aamctustwo/subscriptions","organizations_url":"https://api.github.com/users/aamctustwo/orgs","repos_url":"https://api.github.com/users/aamctustwo/repos","events_url":"https://api.github.com/users/aamctustwo/events{/privacy}","received_events_url":"https://api.github.com/users/aamctustwo/received_events","type":"User","site_admin":false},"body":"I had tried that, but it didn't work. ","created_at":"2017-01-18T13:41:49Z","updated_at":"2017-01-18T13:41:50Z","html_url":"https://github.com/realm/SwiftLint/pull/1209#discussion_r96635814","pull_request_url":"https://api.github.com/repos/realm/SwiftLint/pulls/1209","_links":{"self":{"href":"https://api.github.com/repos/realm/SwiftLint/pulls/comments/96635814"},"html":{"href":"https://github.com/realm/SwiftLint/pull/1209#discussion_r96635814"},"pull_request":{"href":"https://api.github.com/repos/realm/SwiftLint/pulls/1209"}}},"pull_request":{"url":"https://api.github.com/repos/realm/SwiftLint/pulls/1209","id":102050105,"html_url":"https://github.com/realm/SwiftLint/pull/1209","diff_url":"https://github.com/realm/SwiftLint/pull/1209.diff","patch_url":"https://github.com/realm/SwiftLint/pull/1209.patch","issue_url":"https://api.github.com/repos/realm/SwiftLint/issues/1209","number":1209,"state":"open","locked":false,"title":"Allowed Character Configuration for Name Rules","user":{"login":"aamctustwo","id":14542757,"avatar_url":"https://avatars.githubusercontent.com/u/14542757?v=3","gravatar_id":"","url":"https://api.github.com/users/aamctustwo","html_url":"https://github.com/aamctustwo","followers_url":"https://api.github.com/users/aamctustwo/followers","following_url":"https://api.github.com/users/aamctustwo/following{/other_user}","gists_url":"https://api.github.com/users/aamctustwo/gists{/gist_id}","starred_url":"https://api.github.com/users/aamctustwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aamctustwo/subscriptions","organizations_url":"https://api.github.com/users/aamctustwo/orgs","repos_url":"https://api.github.com/users/aamctustwo/repos","events_url":"https://api.github.com/users/aamctustwo/events{/privacy}","received_events_url":"https://api.github.com/users/aamctustwo/received_events","type":"User","site_admin":false},"body":"Resolves #628 `Allow '_' both in variable names and type names`.\r\n\r\n### Summary\r\n- Adds `additional_allowed_characters` for name rule configuration (used by both `variable_name` and `type_name` rules)\r\n- Adjusted `CharacterSet.isSuperset(ofCharactersIn:)` to use CoreFoundation directly to work around crash. Still working on isolated this as an example to file a Swift bug report. May be a regression of https://bugs.swift.org/browse/SR-2307","created_at":"2017-01-18T11:48:45Z","updated_at":"2017-01-18T13:41:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3fcb612eb207287e08553ad7cb76acb5f805fb61","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/realm/SwiftLint/pulls/1209/commits","review_comments_url":"https://api.github.com/repos/realm/SwiftLint/pulls/1209/comments","review_comment_url":"https://api.github.com/repos/realm/SwiftLint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/realm/SwiftLint/issues/1209/comments","statuses_url":"https://api.github.com/repos/realm/SwiftLint/statuses/e22bf9df20fe46d9e1aa5b2ce0eb6de573f4c554","head":{"label":"aamctustwo:underscore-variables","ref":"underscore-variables","sha":"e22bf9df20fe46d9e1aa5b2ce0eb6de573f4c554","user":{"login":"aamctustwo","id":14542757,"avatar_url":"https://avatars.githubusercontent.com/u/14542757?v=3","gravatar_id":"","url":"https://api.github.com/users/aamctustwo","html_url":"https://github.com/aamctustwo","followers_url":"https://api.github.com/users/aamctustwo/followers","following_url":"https://api.github.com/users/aamctustwo/following{/other_user}","gists_url":"https://api.github.com/users/aamctustwo/gists{/gist_id}","starred_url":"https://api.github.com/users/aamctustwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aamctustwo/subscriptions","organizations_url":"https://api.github.com/users/aamctustwo/orgs","repos_url":"https://api.github.com/users/aamctustwo/repos","events_url":"https://api.github.com/users/aamctustwo/events{/privacy}","received_events_url":"https://api.github.com/users/aamctustwo/received_events","type":"User","site_admin":false},"repo":{"id":79124393,"name":"SwiftLint","full_name":"aamctustwo/SwiftLint","owner":{"login":"aamctustwo","id":14542757,"avatar_url":"https://avatars.githubusercontent.com/u/14542757?v=3","gravatar_id":"","url":"https://api.github.com/users/aamctustwo","html_url":"https://github.com/aamctustwo","followers_url":"https://api.github.com/users/aamctustwo/followers","following_url":"https://api.github.com/users/aamctustwo/following{/other_user}","gists_url":"https://api.github.com/users/aamctustwo/gists{/gist_id}","starred_url":"https://api.github.com/users/aamctustwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aamctustwo/subscriptions","organizations_url":"https://api.github.com/users/aamctustwo/orgs","repos_url":"https://api.github.com/users/aamctustwo/repos","events_url":"https://api.github.com/users/aamctustwo/events{/privacy}","received_events_url":"https://api.github.com/users/aamctustwo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aamctustwo/SwiftLint","description":"A tool to enforce Swift style and conventions.","fork":true,"url":"https://api.github.com/repos/aamctustwo/SwiftLint","forks_url":"https://api.github.com/repos/aamctustwo/SwiftLint/forks","keys_url":"https://api.github.com/repos/aamctustwo/SwiftLint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aamctustwo/SwiftLint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aamctustwo/SwiftLint/teams","hooks_url":"https://api.github.com/repos/aamctustwo/SwiftLint/hooks","issue_events_url":"https://api.github.com/repos/aamctustwo/SwiftLint/issues/events{/number}","events_url":"https://api.github.com/repos/aamctustwo/SwiftLint/events","assignees_url":"https://api.github.com/repos/aamctustwo/SwiftLint/assignees{/user}","branches_url":"https://api.github.com/repos/aamctustwo/SwiftLint/branches{/branch}","tags_url":"https://api.github.com/repos/aamctustwo/SwiftLint/tags","blobs_url":"https://api.github.com/repos/aamctustwo/SwiftLint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aamctustwo/SwiftLint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aamctustwo/SwiftLint/git/refs{/sha}","trees_url":"https://api.github.com/repos/aamctustwo/SwiftLint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aamctustwo/SwiftLint/statuses/{sha}","languages_url":"https://api.github.com/repos/aamctustwo/SwiftLint/languages","stargazers_url":"https://api.github.com/repos/aamctustwo/SwiftLint/stargazers","contributors_url":"https://api.github.com/repos/aamctustwo/SwiftLint/contributors","subscribers_url":"https://api.github.com/repos/aamctustwo/SwiftLint/subscribers","subscription_url":"https://api.github.com/repos/aamctustwo/SwiftLint/subscription","commits_url":"https://api.github.com/repos/aamctustwo/SwiftLint/commits{/sha}","git_commits_url":"https://api.github.com/repos/aamctustwo/SwiftLint/git/commits{/sha}","comments_url":"https://api.github.com/repos/aamctustwo/SwiftLint/comments{/number}","issue_comment_url":"https://api.github.com/repos/aamctustwo/SwiftLint/issues/comments{/number}","contents_url":"https://api.github.com/repos/aamctustwo/SwiftLint/contents/{+path}","compare_url":"https://api.github.com/repos/aamctustwo/SwiftLint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aamctustwo/SwiftLint/merges","archive_url":"https://api.github.com/repos/aamctustwo/SwiftLint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aamctustwo/SwiftLint/downloads","issues_url":"https://api.github.com/repos/aamctustwo/SwiftLint/issues{/number}","pulls_url":"https://api.github.com/repos/aamctustwo/SwiftLint/pulls{/number}","milestones_url":"https://api.github.com/repos/aamctustwo/SwiftLint/milestones{/number}","notifications_url":"https://api.github.com/repos/aamctustwo/SwiftLint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aamctustwo/SwiftLint/labels{/name}","releases_url":"https://api.github.com/repos/aamctustwo/SwiftLint/releases{/id}","deployments_url":"https://api.github.com/repos/aamctustwo/SwiftLint/deployments","created_at":"2017-01-16T14:06:31Z","updated_at":"2017-01-16T14:06:35Z","pushed_at":"2017-01-18T12:16:39Z","git_url":"git://github.com/aamctustwo/SwiftLint.git","ssh_url":"git@github.com:aamctustwo/SwiftLint.git","clone_url":"https://github.com/aamctustwo/SwiftLint.git","svn_url":"https://github.com/aamctustwo/SwiftLint","homepage":"https://realm.io","size":3596,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"realm:master","ref":"master","sha":"0b268ad606fe98ffe1ef6be08a7aea00cc4e8efc","user":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"repo":{"id":35732214,"name":"SwiftLint","full_name":"realm/SwiftLint","owner":{"login":"realm","id":7575099,"avatar_url":"https://avatars.githubusercontent.com/u/7575099?v=3","gravatar_id":"","url":"https://api.github.com/users/realm","html_url":"https://github.com/realm","followers_url":"https://api.github.com/users/realm/followers","following_url":"https://api.github.com/users/realm/following{/other_user}","gists_url":"https://api.github.com/users/realm/gists{/gist_id}","starred_url":"https://api.github.com/users/realm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/realm/subscriptions","organizations_url":"https://api.github.com/users/realm/orgs","repos_url":"https://api.github.com/users/realm/repos","events_url":"https://api.github.com/users/realm/events{/privacy}","received_events_url":"https://api.github.com/users/realm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/realm/SwiftLint","description":"A tool to enforce Swift style and conventions.","fork":false,"url":"https://api.github.com/repos/realm/SwiftLint","forks_url":"https://api.github.com/repos/realm/SwiftLint/forks","keys_url":"https://api.github.com/repos/realm/SwiftLint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/realm/SwiftLint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/realm/SwiftLint/teams","hooks_url":"https://api.github.com/repos/realm/SwiftLint/hooks","issue_events_url":"https://api.github.com/repos/realm/SwiftLint/issues/events{/number}","events_url":"https://api.github.com/repos/realm/SwiftLint/events","assignees_url":"https://api.github.com/repos/realm/SwiftLint/assignees{/user}","branches_url":"https://api.github.com/repos/realm/SwiftLint/branches{/branch}","tags_url":"https://api.github.com/repos/realm/SwiftLint/tags","blobs_url":"https://api.github.com/repos/realm/SwiftLint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/realm/SwiftLint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/realm/SwiftLint/git/refs{/sha}","trees_url":"https://api.github.com/repos/realm/SwiftLint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/realm/SwiftLint/statuses/{sha}","languages_url":"https://api.github.com/repos/realm/SwiftLint/languages","stargazers_url":"https://api.github.com/repos/realm/SwiftLint/stargazers","contributors_url":"https://api.github.com/repos/realm/SwiftLint/contributors","subscribers_url":"https://api.github.com/repos/realm/SwiftLint/subscribers","subscription_url":"https://api.github.com/repos/realm/SwiftLint/subscription","commits_url":"https://api.github.com/repos/realm/SwiftLint/commits{/sha}","git_commits_url":"https://api.github.com/repos/realm/SwiftLint/git/commits{/sha}","comments_url":"https://api.github.com/repos/realm/SwiftLint/comments{/number}","issue_comment_url":"https://api.github.com/repos/realm/SwiftLint/issues/comments{/number}","contents_url":"https://api.github.com/repos/realm/SwiftLint/contents/{+path}","compare_url":"https://api.github.com/repos/realm/SwiftLint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/realm/SwiftLint/merges","archive_url":"https://api.github.com/repos/realm/SwiftLint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/realm/SwiftLint/downloads","issues_url":"https://api.github.com/repos/realm/SwiftLint/issues{/number}","pulls_url":"https://api.github.com/repos/realm/SwiftLint/pulls{/number}","milestones_url":"https://api.github.com/repos/realm/SwiftLint/milestones{/number}","notifications_url":"https://api.github.com/repos/realm/SwiftLint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/realm/SwiftLint/labels{/name}","releases_url":"https://api.github.com/repos/realm/SwiftLint/releases{/id}","deployments_url":"https://api.github.com/repos/realm/SwiftLint/deployments","created_at":"2015-05-16T16:59:31Z","updated_at":"2017-01-18T13:38:05Z","pushed_at":"2017-01-18T12:16:41Z","git_url":"git://github.com/realm/SwiftLint.git","ssh_url":"git@github.com:realm/SwiftLint.git","clone_url":"https://github.com/realm/SwiftLint.git","svn_url":"https://github.com/realm/SwiftLint","homepage":"https://realm.io","size":3553,"stargazers_count":5659,"watchers_count":5659,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":420,"mirror_url":null,"open_issues_count":156,"forks":420,"open_issues":156,"watchers":5659,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/realm/SwiftLint/pulls/1209"},"html":{"href":"https://github.com/realm/SwiftLint/pull/1209"},"issue":{"href":"https://api.github.com/repos/realm/SwiftLint/issues/1209"},"comments":{"href":"https://api.github.com/repos/realm/SwiftLint/issues/1209/comments"},"review_comments":{"href":"https://api.github.com/repos/realm/SwiftLint/pulls/1209/comments"},"review_comment":{"href":"https://api.github.com/repos/realm/SwiftLint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/realm/SwiftLint/pulls/1209/commits"},"statuses":{"href":"https://api.github.com/repos/realm/SwiftLint/statuses/e22bf9df20fe46d9e1aa5b2ce0eb6de573f4c554"}}}}
{"actor":{"display_login":"aamctustwo"}}