{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/heron/pulls/comments/118156173","pull_request_review_id":39920813,"id":118156173,"diff_hunk":"@@ -68,16 +67,19 @@ class Terminate : public Client {\n \n static TestServer* server_;\n \n-void start_server(sp_uint32 port) {\n+void start_server(sp_uint32* port, CountDownLatch* latch) {","path":"heron/common/tests/cpp/network/switch_unittest.cpp","position":21,"original_position":21,"commit_id":"95bc04083913e5ef5b245c35b3c570c82f4e083d","original_commit_id":"95bc04083913e5ef5b245c35b3c570c82f4e083d","user":{"login":"huijunwu","id":4208547,"avatar_url":"https://avatars3.githubusercontent.com/u/4208547?v=3","gravatar_id":"","url":"https://api.github.com/users/huijunwu","html_url":"https://github.com/huijunwu","followers_url":"https://api.github.com/users/huijunwu/followers","following_url":"https://api.github.com/users/huijunwu/following{/other_user}","gists_url":"https://api.github.com/users/huijunwu/gists{/gist_id}","starred_url":"https://api.github.com/users/huijunwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huijunwu/subscriptions","organizations_url":"https://api.github.com/users/huijunwu/orgs","repos_url":"https://api.github.com/users/huijunwu/repos","events_url":"https://api.github.com/users/huijunwu/events{/privacy}","received_events_url":"https://api.github.com/users/huijunwu/received_events","type":"User","site_admin":false},"body":"Copied from #1847:\r\nThe compiler complained on reference here","created_at":"2017-05-24T03:36:46Z","updated_at":"2017-05-24T03:36:46Z","html_url":"https://github.com/twitter/heron/pull/1852#discussion_r118156173","pull_request_url":"https://api.github.com/repos/twitter/heron/pulls/1852","_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments/118156173"},"html":{"href":"https://github.com/twitter/heron/pull/1852#discussion_r118156173"},"pull_request":{"href":"https://api.github.com/repos/twitter/heron/pulls/1852"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/heron/pulls/1852","id":120071094,"html_url":"https://github.com/twitter/heron/pull/1852","diff_url":"https://github.com/twitter/heron/pull/1852.diff","patch_url":"https://github.com/twitter/heron/pull/1852.patch","issue_url":"https://api.github.com/repos/twitter/heron/issues/1852","number":1852,"state":"open","locked":false,"title":"replace hard coded stmgr port in stmgr_unittest","user":{"login":"huijunwu","id":4208547,"avatar_url":"https://avatars3.githubusercontent.com/u/4208547?v=3","gravatar_id":"","url":"https://api.github.com/users/huijunwu","html_url":"https://github.com/huijunwu","followers_url":"https://api.github.com/users/huijunwu/followers","following_url":"https://api.github.com/users/huijunwu/following{/other_user}","gists_url":"https://api.github.com/users/huijunwu/gists{/gist_id}","starred_url":"https://api.github.com/users/huijunwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huijunwu/subscriptions","organizations_url":"https://api.github.com/users/huijunwu/orgs","repos_url":"https://api.github.com/users/huijunwu/repos","events_url":"https://api.github.com/users/huijunwu/events{/privacy}","received_events_url":"https://api.github.com/users/huijunwu/received_events","type":"User","site_admin":false},"body":"Prerequisite: #1827, #1832, #1847\r\n\r\nThe hard coded ports sometimes conflict in the continuous integration test. This PR replaces hard coded stmgr ports in stmgr_unittest.","created_at":"2017-05-11T10:15:02Z","updated_at":"2017-05-24T03:36:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"007311e242bcfa15144447fb62234dd611391d6d","assignee":{"login":"huijunwu","id":4208547,"avatar_url":"https://avatars3.githubusercontent.com/u/4208547?v=3","gravatar_id":"","url":"https://api.github.com/users/huijunwu","html_url":"https://github.com/huijunwu","followers_url":"https://api.github.com/users/huijunwu/followers","following_url":"https://api.github.com/users/huijunwu/following{/other_user}","gists_url":"https://api.github.com/users/huijunwu/gists{/gist_id}","starred_url":"https://api.github.com/users/huijunwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huijunwu/subscriptions","organizations_url":"https://api.github.com/users/huijunwu/orgs","repos_url":"https://api.github.com/users/huijunwu/repos","events_url":"https://api.github.com/users/huijunwu/events{/privacy}","received_events_url":"https://api.github.com/users/huijunwu/received_events","type":"User","site_admin":false},"assignees":[{"login":"huijunwu","id":4208547,"avatar_url":"https://avatars3.githubusercontent.com/u/4208547?v=3","gravatar_id":"","url":"https://api.github.com/users/huijunwu","html_url":"https://github.com/huijunwu","followers_url":"https://api.github.com/users/huijunwu/followers","following_url":"https://api.github.com/users/huijunwu/following{/other_user}","gists_url":"https://api.github.com/users/huijunwu/gists{/gist_id}","starred_url":"https://api.github.com/users/huijunwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huijunwu/subscriptions","organizations_url":"https://api.github.com/users/huijunwu/orgs","repos_url":"https://api.github.com/users/huijunwu/repos","events_url":"https://api.github.com/users/huijunwu/events{/privacy}","received_events_url":"https://api.github.com/users/huijunwu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/twitter/heron/pulls/1852/commits","review_comments_url":"https://api.github.com/repos/twitter/heron/pulls/1852/comments","review_comment_url":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/heron/issues/1852/comments","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/95bc04083913e5ef5b245c35b3c570c82f4e083d","head":{"label":"huijunwu:stmgrbind0","ref":"stmgrbind0","sha":"95bc04083913e5ef5b245c35b3c570c82f4e083d","user":{"login":"huijunwu","id":4208547,"avatar_url":"https://avatars3.githubusercontent.com/u/4208547?v=3","gravatar_id":"","url":"https://api.github.com/users/huijunwu","html_url":"https://github.com/huijunwu","followers_url":"https://api.github.com/users/huijunwu/followers","following_url":"https://api.github.com/users/huijunwu/following{/other_user}","gists_url":"https://api.github.com/users/huijunwu/gists{/gist_id}","starred_url":"https://api.github.com/users/huijunwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huijunwu/subscriptions","organizations_url":"https://api.github.com/users/huijunwu/orgs","repos_url":"https://api.github.com/users/huijunwu/repos","events_url":"https://api.github.com/users/huijunwu/events{/privacy}","received_events_url":"https://api.github.com/users/huijunwu/received_events","type":"User","site_admin":false},"repo":{"id":82186208,"name":"heron","full_name":"huijunwu/heron","owner":{"login":"huijunwu","id":4208547,"avatar_url":"https://avatars3.githubusercontent.com/u/4208547?v=3","gravatar_id":"","url":"https://api.github.com/users/huijunwu","html_url":"https://github.com/huijunwu","followers_url":"https://api.github.com/users/huijunwu/followers","following_url":"https://api.github.com/users/huijunwu/following{/other_user}","gists_url":"https://api.github.com/users/huijunwu/gists{/gist_id}","starred_url":"https://api.github.com/users/huijunwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huijunwu/subscriptions","organizations_url":"https://api.github.com/users/huijunwu/orgs","repos_url":"https://api.github.com/users/huijunwu/repos","events_url":"https://api.github.com/users/huijunwu/events{/privacy}","received_events_url":"https://api.github.com/users/huijunwu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huijunwu/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":true,"url":"https://api.github.com/repos/huijunwu/heron","forks_url":"https://api.github.com/repos/huijunwu/heron/forks","keys_url":"https://api.github.com/repos/huijunwu/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huijunwu/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huijunwu/heron/teams","hooks_url":"https://api.github.com/repos/huijunwu/heron/hooks","issue_events_url":"https://api.github.com/repos/huijunwu/heron/issues/events{/number}","events_url":"https://api.github.com/repos/huijunwu/heron/events","assignees_url":"https://api.github.com/repos/huijunwu/heron/assignees{/user}","branches_url":"https://api.github.com/repos/huijunwu/heron/branches{/branch}","tags_url":"https://api.github.com/repos/huijunwu/heron/tags","blobs_url":"https://api.github.com/repos/huijunwu/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huijunwu/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huijunwu/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/huijunwu/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huijunwu/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/huijunwu/heron/languages","stargazers_url":"https://api.github.com/repos/huijunwu/heron/stargazers","contributors_url":"https://api.github.com/repos/huijunwu/heron/contributors","subscribers_url":"https://api.github.com/repos/huijunwu/heron/subscribers","subscription_url":"https://api.github.com/repos/huijunwu/heron/subscription","commits_url":"https://api.github.com/repos/huijunwu/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/huijunwu/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/huijunwu/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/huijunwu/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/huijunwu/heron/contents/{+path}","compare_url":"https://api.github.com/repos/huijunwu/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huijunwu/heron/merges","archive_url":"https://api.github.com/repos/huijunwu/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huijunwu/heron/downloads","issues_url":"https://api.github.com/repos/huijunwu/heron/issues{/number}","pulls_url":"https://api.github.com/repos/huijunwu/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/huijunwu/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/huijunwu/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huijunwu/heron/labels{/name}","releases_url":"https://api.github.com/repos/huijunwu/heron/releases{/id}","deployments_url":"https://api.github.com/repos/huijunwu/heron/deployments","created_at":"2017-02-16T13:57:26Z","updated_at":"2017-02-16T13:57:32Z","pushed_at":"2017-05-23T21:52:15Z","git_url":"git://github.com/huijunwu/heron.git","ssh_url":"git@github.com:huijunwu/heron.git","clone_url":"https://github.com/huijunwu/heron.git","svn_url":"https://github.com/huijunwu/heron","homepage":"http://heronstreaming.io","size":55474,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"9e4067f13c90b8bbed0519bd00937eb04e458a67","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars2.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":43158694,"name":"heron","full_name":"twitter/heron","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars2.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":false,"url":"https://api.github.com/repos/twitter/heron","forks_url":"https://api.github.com/repos/twitter/heron/forks","keys_url":"https://api.github.com/repos/twitter/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/heron/teams","hooks_url":"https://api.github.com/repos/twitter/heron/hooks","issue_events_url":"https://api.github.com/repos/twitter/heron/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/heron/events","assignees_url":"https://api.github.com/repos/twitter/heron/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/heron/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/heron/tags","blobs_url":"https://api.github.com/repos/twitter/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/heron/languages","stargazers_url":"https://api.github.com/repos/twitter/heron/stargazers","contributors_url":"https://api.github.com/repos/twitter/heron/contributors","subscribers_url":"https://api.github.com/repos/twitter/heron/subscribers","subscription_url":"https://api.github.com/repos/twitter/heron/subscription","commits_url":"https://api.github.com/repos/twitter/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/heron/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/heron/merges","archive_url":"https://api.github.com/repos/twitter/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/heron/downloads","issues_url":"https://api.github.com/repos/twitter/heron/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/heron/labels{/name}","releases_url":"https://api.github.com/repos/twitter/heron/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/heron/deployments","created_at":"2015-09-25T16:09:24Z","updated_at":"2017-05-23T14:42:00Z","pushed_at":"2017-05-24T02:22:09Z","git_url":"git://github.com/twitter/heron.git","ssh_url":"git@github.com:twitter/heron.git","clone_url":"https://github.com/twitter/heron.git","svn_url":"https://github.com/twitter/heron","homepage":"http://heronstreaming.io","size":130574,"stargazers_count":2713,"watchers_count":2713,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":476,"mirror_url":null,"open_issues_count":262,"forks":476,"open_issues":262,"watchers":2713,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/1852"},"html":{"href":"https://github.com/twitter/heron/pull/1852"},"issue":{"href":"https://api.github.com/repos/twitter/heron/issues/1852"},"comments":{"href":"https://api.github.com/repos/twitter/heron/issues/1852/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/heron/pulls/1852/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/heron/pulls/1852/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/heron/statuses/95bc04083913e5ef5b245c35b3c570c82f4e083d"}}}}
{"actor":{"display_login":"huijunwu"}}