{"action":"created","comment":{"url":"https://api.github.com/repos/micromata/Baumeister/pulls/comments/128467649","pull_request_review_id":51148585,"id":128467649,"diff_hunk":"@@ -1,18 +1,16 @@\n-import gulp from 'gulp';\n-import plumber from 'gulp-plumber';\n-import sass from 'gulp-sass';\n-import sourcemaps from 'gulp-sourcemaps';\n-import uncss from 'uncss';\n-import cssnano from 'cssnano';\n-import autoprefixer from 'autoprefixer';\n-import postcss from 'gulp-postcss';\n-import rename from 'gulp-rename';\n+import gulp from \"gulp\";","path":"gulp/tasks/styles.js","position":null,"original_position":10,"commit_id":"4d2f059f68a191c5342dc4179346faab1fd15dee","original_commit_id":"08ec620f057405f7661ce01f431d94cc1f9ef77e","user":{"login":"mischah","id":441011,"avatar_url":"https://avatars2.githubusercontent.com/u/441011?v=4","gravatar_id":"","url":"https://api.github.com/users/mischah","html_url":"https://github.com/mischah","followers_url":"https://api.github.com/users/mischah/followers","following_url":"https://api.github.com/users/mischah/following{/other_user}","gists_url":"https://api.github.com/users/mischah/gists{/gist_id}","starred_url":"https://api.github.com/users/mischah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mischah/subscriptions","organizations_url":"https://api.github.com/users/mischah/orgs","repos_url":"https://api.github.com/users/mischah/repos","events_url":"https://api.github.com/users/mischah/events{/privacy}","received_events_url":"https://api.github.com/users/mischah/received_events","type":"User","site_admin":false},"body":"No problem 😊 ","created_at":"2017-07-20T09:33:23Z","updated_at":"2017-07-20T09:33:23Z","html_url":"https://github.com/micromata/Baumeister/pull/192#discussion_r128467649","pull_request_url":"https://api.github.com/repos/micromata/Baumeister/pulls/192","_links":{"self":{"href":"https://api.github.com/repos/micromata/Baumeister/pulls/comments/128467649"},"html":{"href":"https://github.com/micromata/Baumeister/pull/192#discussion_r128467649"},"pull_request":{"href":"https://api.github.com/repos/micromata/Baumeister/pulls/192"}}},"pull_request":{"url":"https://api.github.com/repos/micromata/Baumeister/pulls/192","id":130254419,"html_url":"https://github.com/micromata/Baumeister/pull/192","diff_url":"https://github.com/micromata/Baumeister/pull/192.diff","patch_url":"https://github.com/micromata/Baumeister/pull/192.patch","issue_url":"https://api.github.com/repos/micromata/Baumeister/issues/192","number":192,"state":"open","locked":false,"title":"Replace style processing plugins with their PostCSS pendants","user":{"login":"nicolaisueper","id":6556377,"avatar_url":"https://avatars1.githubusercontent.com/u/6556377?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolaisueper","html_url":"https://github.com/nicolaisueper","followers_url":"https://api.github.com/users/nicolaisueper/followers","following_url":"https://api.github.com/users/nicolaisueper/following{/other_user}","gists_url":"https://api.github.com/users/nicolaisueper/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolaisueper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolaisueper/subscriptions","organizations_url":"https://api.github.com/users/nicolaisueper/orgs","repos_url":"https://api.github.com/users/nicolaisueper/repos","events_url":"https://api.github.com/users/nicolaisueper/events{/privacy}","received_events_url":"https://api.github.com/users/nicolaisueper/received_events","type":"User","site_admin":false},"body":"I replaced our style processing plugins with their PostCSS equivalents, because `gulp-uncss` is deprecated now (see #191) and `cssnano` seems to be a nice alternative to `clean-css`.\r\n\r\nWe now make use of the following plugins:\r\n- `gulp-postcss` (PostCSS Gulp plugin)\r\n- `cssnano` (`clean-css` alternative)\r\n- `autoprefixer` (this is actually just a PostCSS plugin)\r\n- `uncss` (ships with a PostCSS plugin)\r\n\r\nI also had to [move the execution of the `styles` task inside the build routine](https://github.com/micromata/Baumeister/compare/191-use-postcss?expand=1#diff-ba210a9157252cc983268fdc3aa3ed52R95). `uncss` requires the html and JS files to be present and located at their proper paths, so [I adjusted the `htmlSources` property](https://github.com/micromata/Baumeister/compare/191-use-postcss?expand=1#diff-00bf9b83b2015b30064c2755fdb36745R15) inside `styles.js` to point to the `dist` directory. If anyone has another or better solution, please let me know. :)","created_at":"2017-07-12T22:57:00Z","updated_at":"2017-07-20T09:33:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8001d9bd7fc629c0a72cf4177ddee677ebeafdc6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"krnlde","id":1087002,"avatar_url":"https://avatars2.githubusercontent.com/u/1087002?v=4","gravatar_id":"","url":"https://api.github.com/users/krnlde","html_url":"https://github.com/krnlde","followers_url":"https://api.github.com/users/krnlde/followers","following_url":"https://api.github.com/users/krnlde/following{/other_user}","gists_url":"https://api.github.com/users/krnlde/gists{/gist_id}","starred_url":"https://api.github.com/users/krnlde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnlde/subscriptions","organizations_url":"https://api.github.com/users/krnlde/orgs","repos_url":"https://api.github.com/users/krnlde/repos","events_url":"https://api.github.com/users/krnlde/events{/privacy}","received_events_url":"https://api.github.com/users/krnlde/received_events","type":"User","site_admin":false},{"login":"revrng","id":6024397,"avatar_url":"https://avatars1.githubusercontent.com/u/6024397?v=4","gravatar_id":"","url":"https://api.github.com/users/revrng","html_url":"https://github.com/revrng","followers_url":"https://api.github.com/users/revrng/followers","following_url":"https://api.github.com/users/revrng/following{/other_user}","gists_url":"https://api.github.com/users/revrng/gists{/gist_id}","starred_url":"https://api.github.com/users/revrng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/revrng/subscriptions","organizations_url":"https://api.github.com/users/revrng/orgs","repos_url":"https://api.github.com/users/revrng/repos","events_url":"https://api.github.com/users/revrng/events{/privacy}","received_events_url":"https://api.github.com/users/revrng/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/micromata/Baumeister/pulls/192/commits","review_comments_url":"https://api.github.com/repos/micromata/Baumeister/pulls/192/comments","review_comment_url":"https://api.github.com/repos/micromata/Baumeister/pulls/comments{/number}","comments_url":"https://api.github.com/repos/micromata/Baumeister/issues/192/comments","statuses_url":"https://api.github.com/repos/micromata/Baumeister/statuses/4d2f059f68a191c5342dc4179346faab1fd15dee","head":{"label":"micromata:191-use-postcss","ref":"191-use-postcss","sha":"4d2f059f68a191c5342dc4179346faab1fd15dee","user":{"login":"micromata","id":1773167,"avatar_url":"https://avatars1.githubusercontent.com/u/1773167?v=4","gravatar_id":"","url":"https://api.github.com/users/micromata","html_url":"https://github.com/micromata","followers_url":"https://api.github.com/users/micromata/followers","following_url":"https://api.github.com/users/micromata/following{/other_user}","gists_url":"https://api.github.com/users/micromata/gists{/gist_id}","starred_url":"https://api.github.com/users/micromata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micromata/subscriptions","organizations_url":"https://api.github.com/users/micromata/orgs","repos_url":"https://api.github.com/users/micromata/repos","events_url":"https://api.github.com/users/micromata/events{/privacy}","received_events_url":"https://api.github.com/users/micromata/received_events","type":"Organization","site_admin":false},"repo":{"id":21695253,"name":"Baumeister","full_name":"micromata/Baumeister","owner":{"login":"micromata","id":1773167,"avatar_url":"https://avatars1.githubusercontent.com/u/1773167?v=4","gravatar_id":"","url":"https://api.github.com/users/micromata","html_url":"https://github.com/micromata","followers_url":"https://api.github.com/users/micromata/followers","following_url":"https://api.github.com/users/micromata/following{/other_user}","gists_url":"https://api.github.com/users/micromata/gists{/gist_id}","starred_url":"https://api.github.com/users/micromata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micromata/subscriptions","organizations_url":"https://api.github.com/users/micromata/orgs","repos_url":"https://api.github.com/users/micromata/repos","events_url":"https://api.github.com/users/micromata/events{/privacy}","received_events_url":"https://api.github.com/users/micromata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/micromata/Baumeister","description":"The aim of this project is to help you to build your things. From Bootstrap themes over static websites to single page applications.","fork":false,"url":"https://api.github.com/repos/micromata/Baumeister","forks_url":"https://api.github.com/repos/micromata/Baumeister/forks","keys_url":"https://api.github.com/repos/micromata/Baumeister/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micromata/Baumeister/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micromata/Baumeister/teams","hooks_url":"https://api.github.com/repos/micromata/Baumeister/hooks","issue_events_url":"https://api.github.com/repos/micromata/Baumeister/issues/events{/number}","events_url":"https://api.github.com/repos/micromata/Baumeister/events","assignees_url":"https://api.github.com/repos/micromata/Baumeister/assignees{/user}","branches_url":"https://api.github.com/repos/micromata/Baumeister/branches{/branch}","tags_url":"https://api.github.com/repos/micromata/Baumeister/tags","blobs_url":"https://api.github.com/repos/micromata/Baumeister/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micromata/Baumeister/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micromata/Baumeister/git/refs{/sha}","trees_url":"https://api.github.com/repos/micromata/Baumeister/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micromata/Baumeister/statuses/{sha}","languages_url":"https://api.github.com/repos/micromata/Baumeister/languages","stargazers_url":"https://api.github.com/repos/micromata/Baumeister/stargazers","contributors_url":"https://api.github.com/repos/micromata/Baumeister/contributors","subscribers_url":"https://api.github.com/repos/micromata/Baumeister/subscribers","subscription_url":"https://api.github.com/repos/micromata/Baumeister/subscription","commits_url":"https://api.github.com/repos/micromata/Baumeister/commits{/sha}","git_commits_url":"https://api.github.com/repos/micromata/Baumeister/git/commits{/sha}","comments_url":"https://api.github.com/repos/micromata/Baumeister/comments{/number}","issue_comment_url":"https://api.github.com/repos/micromata/Baumeister/issues/comments{/number}","contents_url":"https://api.github.com/repos/micromata/Baumeister/contents/{+path}","compare_url":"https://api.github.com/repos/micromata/Baumeister/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micromata/Baumeister/merges","archive_url":"https://api.github.com/repos/micromata/Baumeister/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micromata/Baumeister/downloads","issues_url":"https://api.github.com/repos/micromata/Baumeister/issues{/number}","pulls_url":"https://api.github.com/repos/micromata/Baumeister/pulls{/number}","milestones_url":"https://api.github.com/repos/micromata/Baumeister/milestones{/number}","notifications_url":"https://api.github.com/repos/micromata/Baumeister/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micromata/Baumeister/labels{/name}","releases_url":"https://api.github.com/repos/micromata/Baumeister/releases{/id}","deployments_url":"https://api.github.com/repos/micromata/Baumeister/deployments","created_at":"2014-07-10T13:31:37Z","updated_at":"2017-07-13T23:17:48Z","pushed_at":"2017-07-20T09:32:14Z","git_url":"git://github.com/micromata/Baumeister.git","ssh_url":"git@github.com:micromata/Baumeister.git","clone_url":"https://github.com/micromata/Baumeister.git","svn_url":"https://github.com/micromata/Baumeister","homepage":"https://baumeister.io","size":634,"stargazers_count":111,"watchers_count":111,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":2,"forks":27,"open_issues":2,"watchers":111,"default_branch":"master"}},"base":{"label":"micromata:master","ref":"master","sha":"a9234ea34f50fde39f54bda21971b50546bcd734","user":{"login":"micromata","id":1773167,"avatar_url":"https://avatars1.githubusercontent.com/u/1773167?v=4","gravatar_id":"","url":"https://api.github.com/users/micromata","html_url":"https://github.com/micromata","followers_url":"https://api.github.com/users/micromata/followers","following_url":"https://api.github.com/users/micromata/following{/other_user}","gists_url":"https://api.github.com/users/micromata/gists{/gist_id}","starred_url":"https://api.github.com/users/micromata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micromata/subscriptions","organizations_url":"https://api.github.com/users/micromata/orgs","repos_url":"https://api.github.com/users/micromata/repos","events_url":"https://api.github.com/users/micromata/events{/privacy}","received_events_url":"https://api.github.com/users/micromata/received_events","type":"Organization","site_admin":false},"repo":{"id":21695253,"name":"Baumeister","full_name":"micromata/Baumeister","owner":{"login":"micromata","id":1773167,"avatar_url":"https://avatars1.githubusercontent.com/u/1773167?v=4","gravatar_id":"","url":"https://api.github.com/users/micromata","html_url":"https://github.com/micromata","followers_url":"https://api.github.com/users/micromata/followers","following_url":"https://api.github.com/users/micromata/following{/other_user}","gists_url":"https://api.github.com/users/micromata/gists{/gist_id}","starred_url":"https://api.github.com/users/micromata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micromata/subscriptions","organizations_url":"https://api.github.com/users/micromata/orgs","repos_url":"https://api.github.com/users/micromata/repos","events_url":"https://api.github.com/users/micromata/events{/privacy}","received_events_url":"https://api.github.com/users/micromata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/micromata/Baumeister","description":"The aim of this project is to help you to build your things. From Bootstrap themes over static websites to single page applications.","fork":false,"url":"https://api.github.com/repos/micromata/Baumeister","forks_url":"https://api.github.com/repos/micromata/Baumeister/forks","keys_url":"https://api.github.com/repos/micromata/Baumeister/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micromata/Baumeister/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micromata/Baumeister/teams","hooks_url":"https://api.github.com/repos/micromata/Baumeister/hooks","issue_events_url":"https://api.github.com/repos/micromata/Baumeister/issues/events{/number}","events_url":"https://api.github.com/repos/micromata/Baumeister/events","assignees_url":"https://api.github.com/repos/micromata/Baumeister/assignees{/user}","branches_url":"https://api.github.com/repos/micromata/Baumeister/branches{/branch}","tags_url":"https://api.github.com/repos/micromata/Baumeister/tags","blobs_url":"https://api.github.com/repos/micromata/Baumeister/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micromata/Baumeister/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micromata/Baumeister/git/refs{/sha}","trees_url":"https://api.github.com/repos/micromata/Baumeister/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micromata/Baumeister/statuses/{sha}","languages_url":"https://api.github.com/repos/micromata/Baumeister/languages","stargazers_url":"https://api.github.com/repos/micromata/Baumeister/stargazers","contributors_url":"https://api.github.com/repos/micromata/Baumeister/contributors","subscribers_url":"https://api.github.com/repos/micromata/Baumeister/subscribers","subscription_url":"https://api.github.com/repos/micromata/Baumeister/subscription","commits_url":"https://api.github.com/repos/micromata/Baumeister/commits{/sha}","git_commits_url":"https://api.github.com/repos/micromata/Baumeister/git/commits{/sha}","comments_url":"https://api.github.com/repos/micromata/Baumeister/comments{/number}","issue_comment_url":"https://api.github.com/repos/micromata/Baumeister/issues/comments{/number}","contents_url":"https://api.github.com/repos/micromata/Baumeister/contents/{+path}","compare_url":"https://api.github.com/repos/micromata/Baumeister/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micromata/Baumeister/merges","archive_url":"https://api.github.com/repos/micromata/Baumeister/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micromata/Baumeister/downloads","issues_url":"https://api.github.com/repos/micromata/Baumeister/issues{/number}","pulls_url":"https://api.github.com/repos/micromata/Baumeister/pulls{/number}","milestones_url":"https://api.github.com/repos/micromata/Baumeister/milestones{/number}","notifications_url":"https://api.github.com/repos/micromata/Baumeister/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micromata/Baumeister/labels{/name}","releases_url":"https://api.github.com/repos/micromata/Baumeister/releases{/id}","deployments_url":"https://api.github.com/repos/micromata/Baumeister/deployments","created_at":"2014-07-10T13:31:37Z","updated_at":"2017-07-13T23:17:48Z","pushed_at":"2017-07-20T09:32:14Z","git_url":"git://github.com/micromata/Baumeister.git","ssh_url":"git@github.com:micromata/Baumeister.git","clone_url":"https://github.com/micromata/Baumeister.git","svn_url":"https://github.com/micromata/Baumeister","homepage":"https://baumeister.io","size":634,"stargazers_count":111,"watchers_count":111,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":2,"forks":27,"open_issues":2,"watchers":111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/micromata/Baumeister/pulls/192"},"html":{"href":"https://github.com/micromata/Baumeister/pull/192"},"issue":{"href":"https://api.github.com/repos/micromata/Baumeister/issues/192"},"comments":{"href":"https://api.github.com/repos/micromata/Baumeister/issues/192/comments"},"review_comments":{"href":"https://api.github.com/repos/micromata/Baumeister/pulls/192/comments"},"review_comment":{"href":"https://api.github.com/repos/micromata/Baumeister/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/micromata/Baumeister/pulls/192/commits"},"statuses":{"href":"https://api.github.com/repos/micromata/Baumeister/statuses/4d2f059f68a191c5342dc4179346faab1fd15dee"}}}}
{"actor":{"display_login":"mischah"}}