{"push_id":2085846232,"size":14,"distinct_size":14,"ref":"refs/heads/fix-module-url-in-errors","head":"a4f0b5e7bacb06f1c1da1f435b947de803630317","before":"1bf615a7f6af84ce0b81905b058ea6ae3e339f50","commits":[{"sha":"dd47dc5be2b14c68de4f42d48cacad4db1bfc44e","author":{"name":"Doug Ilijev","email":"379d7edf6e55b3fef54f2d1667cb1c3b3e94393b@microsoft.com"},"message":"Eliminate virtual Print from Inst to improve usefulness of `-RegexBytecodeDebug`","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/dd47dc5be2b14c68de4f42d48cacad4db1bfc44e"},{"sha":"ace1d6538816f2f53a0c37557a641e8a481f5e82","author":{"name":"Doug Ilijev","email":"379d7edf6e55b3fef54f2d1667cb1c3b3e94393b@microsoft.com"},"message":"Remove HardFailMixin to eliminate the boolean field and size cost.","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/ace1d6538816f2f53a0c37557a641e8a481f5e82"},{"sha":"4066662d12fd39d31537ea6c2c64969e58d4a2cb","author":{"name":"Doug Ilijev","email":"379d7edf6e55b3fef54f2d1667cb1c3b3e94393b@microsoft.com"},"message":"Remove 'bool isNegation' from WordBoundaryTestInst","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/4066662d12fd39d31537ea6c2c64969e58d4a2cb"},{"sha":"96ff85cfafd78a8c5ea0b00a216c646b0c46f4ff","author":{"name":"Doug Ilijev","email":"379d7edf6e55b3fef54f2d1667cb1c3b3e94393b@microsoft.com"},"message":"Fix xplat builds: Remove  from templatized ctors to fix compilation unit logic.","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/96ff85cfafd78a8c5ea0b00a216c646b0c46f4ff"},{"sha":"1f3b0f2a3ff62e4091db5818f068474de34aa969","author":{"name":"Matt Gardner","email":"2aade5400692dce07d2ace7b892e1b007390ac5e@microsoft.com"},"message":"ARM64: fix default indir scale","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/1f3b0f2a3ff62e4091db5818f068474de34aa969"},{"sha":"113eae4d422eb992fa70de67bf0c2a22cf1b6cb0","author":{"name":"Matt Gardner","email":"2aade5400692dce07d2ace7b892e1b007390ac5e@microsoft.com"},"message":"ARM64: LDIMM type mismatch","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/113eae4d422eb992fa70de67bf0c2a22cf1b6cb0"},{"sha":"84811f97440d1859eae0fac6ca2727638ef86242","author":{"name":"Akrosh Gandhi","email":"e9cfe1687debb4101ca611737b531a0aba938d45@microsoft.com"},"message":"Improving perf for encodeURI.\n\nThere are lots of busy-hang bugs reported for encodeURIComponent api. When I dig deeper I found that\nmany a times we get input larger than a meg. I created a repro test case for this. We spent most of\nthe time in swprintf. I made easy change to the code and got rid of that.\nIn the repro benchmark\nBefore change :\n  we spent ~3500 ms.\nAfter change :\n  it becomes 450 ms.\n\nThere were opportunities to clean the code further, but I don't see a point of changing the code any more than this.","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/84811f97440d1859eae0fac6ca2727638ef86242"},{"sha":"e6dc0a9dea7c493fc48010dd79ade64c740266f7","author":{"name":"Akrosh Gandhi","email":"e9cfe1687debb4101ca611737b531a0aba938d45@microsoft.com"},"message":"[MERGE #4082 @akroshg] Improving perf for encodeURI.\n\nMerge pull request #4082 from akroshg:encode\n\nThere are lots of busy-hang bugs reported for encodeURIComponent api. When I dig deeper I found that\nmany a times we get input larger than a meg. I created a repro test case for this. We spent most of\nthe time in swprintf. I made easy change to the code and got rid of that.\nIn the repro benchmark\nBefore change :\n  we spent ~3500 ms.\nAfter change :\n  it becomes 450 ms.\n\nThere were opportunities to clean the code further, but I don't see a point of changing the code any more than this.","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/e6dc0a9dea7c493fc48010dd79ade64c740266f7"},{"sha":"875af3cafad4626530ada1973b897ada039ff10b","author":{"name":"Matt Gardner","email":"2aade5400692dce07d2ace7b892e1b007390ac5e@microsoft.com"},"message":"[MERGE #4081 @sigatrev] ARM64: LDIMM type mismatch\n\nMerge pull request #4081 from sigatrev:ldimm","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/875af3cafad4626530ada1973b897ada039ff10b"},{"sha":"8338054952808162789ea7df1043de7750c50a6a","author":{"name":"Matt Gardner","email":"2aade5400692dce07d2ace7b892e1b007390ac5e@microsoft.com"},"message":"[MERGE #4075 @sigatrev] ARM64: fix default indir scale\n\nMerge pull request #4075 from sigatrev:ldr","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/8338054952808162789ea7df1043de7750c50a6a"},{"sha":"240831ec2da53b4a2cf6b430193eaf4373e11a02","author":{"name":"Sandeep Agarwal","email":"5e14cd45ea7d426e2b28c1583d389e139e95a17a@microsoft.com"},"message":"ARM64: Fix loading of functionObject Opnd","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/240831ec2da53b4a2cf6b430193eaf4373e11a02"},{"sha":"59d5bc4dd72a795e7e164e3a5266f8f25a9ad5af","author":{"name":"Doug Ilijev","email":"379d7edf6e55b3fef54f2d1667cb1c3b3e94393b@microsoft.com"},"message":"[MERGE #4066 @dilijev] RegExp Bytecode: Remove HardFailMixin and WordBoundaryTest's isNegation, converting bools to template parameters.\n\nMerge pull request #4066 from dilijev:rebc-rm-bool-hardfail\n\nFollow up to #3915 as part of the \"remove booleans\" opportunity. Other work on removing the rest of the booleans is in progress but more invasive.\n\nThis PR also:\n\n* removes virtual Print from `Inst` so that Debug build `Inst`s don't have a vtable pointer to disrupt the bytecode layout.\n* includes other changes to -RegexBytecodeDebug output to help view important aspects of bytecode layout.\n\nI don't yet have data about runtime and memory improvement with this change, but since we are removing some branches through the use of a boolean template instead of a boolean member variable and decreasing memory by removing the boolean and all of the associated padding (4 or 8 bytes, depending) any time these bytecodes are used, there should be moderate gains in both runtime and memory.\n\nBOITest / BOIHardFailTest / EOITest / EOIHardFailTest / WordBoundaryTest / NegatedWordBoundaryTest go from 0x8 to 0x4 bytes. (Opcode is 32 bit and the bool gets padded out 4 bytes.)\n\nBefore/after snippet for BOITest, for `/(^token|foo)/` (running as `ch.exe -RegexDebug -RegexBytecodeDebug test.js`):\n\nBefore:\n```\n        L0010: (0x008 bytes) BOITest(hardFail: false)\n            0x000001F4591AC0B0[+0x000](0x004) [Inst]: 0c000000\n            0x000001F4591AC0B4[+0x004](0x001) [HardFailMixin]:00\n        L0018: (0x00c bytes) MatchLiteral(literal: \"token\")\n```\n\nAfter:\n```\n        L0010: (0x004 bytes) BOITest(<hardFail>: false)\n            0x0000020E2BECC0B0[+0x000](0x004)(size:0x04)(align:0x04) [Inst]: 0d000000\n        L0014: (0x00c bytes) MatchLiteral(literal: \"token\")\n```\n\nAgain for `/\\b\\B/`:\n\nBefore:\n```\n        L0000: (0x008 bytes) WordBoundaryTest()\n            0x0000023973F34100[+0x000](0x004) [Inst]: 10000000\n            0x0000023973F34100[+0x000](0x008) [WordBoundaryTestInst]: 10000000 00000000\n        L0008: (0x008 bytes) WordBoundaryTest()\n            0x0000023973F34108[+0x000](0x004) [Inst]: 10000000\n            0x0000023973F34108[+0x000](0x008) [WordBoundaryTestInst]: 10000000 01000000\n        L0010: (0x004 bytes) Succ()\n```\n\nAfter:\n```\n        L0000: (0x004 bytes) WordBoundaryTest()\n            0x0000019F284AC190[+0x000](0x004)(size:0x04)(align:0x04) [Inst]: 13000000\n        L0004: (0x004 bytes) NegatedWordBoundaryTest()\n            0x0000019F284AC194[+0x000](0x004)(size:0x04)(align:0x04) [Inst]: 12000000\n        L0008: (0x004 bytes) Succ()\n```","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/59d5bc4dd72a795e7e164e3a5266f8f25a9ad5af"},{"sha":"cda3b6d1d82b33094785e7578f04134e62f18758","author":{"name":"Sandeep Agarwal","email":"5e14cd45ea7d426e2b28c1583d389e139e95a17a@microsoft.com"},"message":"[MERGE #4084 @agarwal-sandeep] ARM64: Fix loading of functionObject Opnd\n\nMerge pull request #4084 from agarwal-sandeep:armwork","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/cda3b6d1d82b33094785e7578f04134e62f18758"},{"sha":"a4f0b5e7bacb06f1c1da1f435b947de803630317","author":{"name":"Bruce Pascoe","email":"75a6d150ed80b559bed945da94434f52dd064e1e@icloud.com"},"message":"Fix ES module filename not visible in stack trace/debugger\n\nJsParseModuleSource() had been creating the source context with url set\nto `nullptr`, which caused the module name not to be visible in error\nbacktraces or debugger JSON.","distinct":true,"url":"https://api.github.com/repos/fatcerberus/ChakraCore/commits/a4f0b5e7bacb06f1c1da1f435b947de803630317"}]}
{"actor":{"display_login":"fatcerberus"}}