{"action":"created","issue":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/580","repository_url":"https://api.github.com/repos/keepassxreboot/keepassxc","labels_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/580/labels{/name}","comments_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/580/comments","events_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/580/events","html_url":"https://github.com/keepassxreboot/keepassxc/pull/580","id":229303562,"number":580,"title":"Feature/430 fix unclean shutdown","user":{"login":"phoerious","id":911270,"avatar_url":"https://avatars2.githubusercontent.com/u/911270?v=3","gravatar_id":"","url":"https://api.github.com/users/phoerious","html_url":"https://github.com/phoerious","followers_url":"https://api.github.com/users/phoerious/followers","following_url":"https://api.github.com/users/phoerious/following{/other_user}","gists_url":"https://api.github.com/users/phoerious/gists{/gist_id}","starred_url":"https://api.github.com/users/phoerious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoerious/subscriptions","organizations_url":"https://api.github.com/users/phoerious/orgs","repos_url":"https://api.github.com/users/phoerious/repos","events_url":"https://api.github.com/users/phoerious/events{/privacy}","received_events_url":"https://api.github.com/users/phoerious/received_events","type":"User","site_admin":false},"labels":[{"id":333293071,"url":"https://api.github.com/repos/keepassxreboot/keepassxc/labels/bug","name":"bug","color":"e0453a","default":true},{"id":525408438,"url":"https://api.github.com/repos/keepassxreboot/keepassxc/labels/OS%20X","name":"OS X","color":"c5def5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/milestones/2","html_url":"https://github.com/keepassxreboot/keepassxc/milestone/2","labels_url":"https://api.github.com/repos/keepassxreboot/keepassxc/milestones/2/labels","id":2157835,"number":2,"title":"v2.2.0","description":"Release that will incorporate major GUI improvements and additional OS integrations","creator":{"login":"droidmonkey","id":2809491,"avatar_url":"https://avatars1.githubusercontent.com/u/2809491?v=3","gravatar_id":"","url":"https://api.github.com/users/droidmonkey","html_url":"https://github.com/droidmonkey","followers_url":"https://api.github.com/users/droidmonkey/followers","following_url":"https://api.github.com/users/droidmonkey/following{/other_user}","gists_url":"https://api.github.com/users/droidmonkey/gists{/gist_id}","starred_url":"https://api.github.com/users/droidmonkey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droidmonkey/subscriptions","organizations_url":"https://api.github.com/users/droidmonkey/orgs","repos_url":"https://api.github.com/users/droidmonkey/repos","events_url":"https://api.github.com/users/droidmonkey/events{/privacy}","received_events_url":"https://api.github.com/users/droidmonkey/received_events","type":"User","site_admin":false},"open_issues":26,"closed_issues":124,"state":"open","created_at":"2016-11-25T15:22:58Z","updated_at":"2017-05-17T21:19:29Z","due_on":"2017-05-27T07:00:00Z","closed_at":null},"comments":7,"created_at":"2017-05-17T10:15:37Z","updated_at":"2017-05-17T23:23:07Z","closed_at":"2017-05-17T21:18:46Z","pull_request":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/pulls/580","html_url":"https://github.com/keepassxreboot/keepassxc/pull/580","diff_url":"https://github.com/keepassxreboot/keepassxc/pull/580.diff","patch_url":"https://github.com/keepassxreboot/keepassxc/pull/580.patch"},"body":"<!--- Provide a general summary of your changes in the title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nThis is a partial fix for issue #430. It resolves shutdown problems on OS X when using the \"Quit\" action from the right-click menu on the dock.\r\n\r\nIt also contains an incomplete clean shutdown implementation for Windows. The signaling mechanism via CreateEvent() and SetEvent() works in general, but trapping the actual system events doesn't. The control handler registered by SetConsoleCtrlHandler() isn't called. Maybe someone more knowledgeable in Windows API internals can help me here. I suppose it may be that Windows doesn't treat KeePassXC as a console application or some other stupid reason.\r\n\r\n**EDIT:** Windows implementation canceled, considered a non-issue (mostly).\r\n\r\n## How has this been tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nRan on macOS Sierra and Windows 10.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? -->\r\n<!--- Please remove all lines which don't apply. -->\r\n- ✅ Bug fix (non-breaking change which fixes an issue)\r\n\r\n## Checklist:\r\n<!--- Please go over all the following points. -->\r\n<!--- Again, remove any lines which don't apply. -->\r\n<!--- Pull Requests that don't fulfill all [REQUIRED] requisites are likely -->\r\n<!--- to be sent back to you for correction or will be rejected.  -->\r\n- ✅ I have read the **CONTRIBUTING** document. **[REQUIRED]**\r\n- ✅ My code follows the code style of this project. **[REQUIRED]**\r\n- ✅ All new and existing tests passed. **[REQUIRED]**\r\n- ✅ I have compiled and verified my code with `-DWITH_ASAN=ON`. **[REQUIRED]**"},"comment":{"url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/comments/302258281","html_url":"https://github.com/keepassxreboot/keepassxc/pull/580#issuecomment-302258281","issue_url":"https://api.github.com/repos/keepassxreboot/keepassxc/issues/580","id":302258281,"user":{"login":"Keisial","id":647460,"avatar_url":"https://avatars0.githubusercontent.com/u/647460?v=3","gravatar_id":"","url":"https://api.github.com/users/Keisial","html_url":"https://github.com/Keisial","followers_url":"https://api.github.com/users/Keisial/followers","following_url":"https://api.github.com/users/Keisial/following{/other_user}","gists_url":"https://api.github.com/users/Keisial/gists{/gist_id}","starred_url":"https://api.github.com/users/Keisial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Keisial/subscriptions","organizations_url":"https://api.github.com/users/Keisial/orgs","repos_url":"https://api.github.com/users/Keisial/repos","events_url":"https://api.github.com/users/Keisial/events{/privacy}","received_events_url":"https://api.github.com/users/Keisial/received_events","type":"User","site_admin":false},"created_at":"2017-05-17T23:23:07Z","updated_at":"2017-05-17T23:23:07Z","body":"signal(SIGINT, ...) should work fine on Windows (at least it used to). Are you building it as a console or Windows application? In the later case, it would not have a console attached (but I don't see how you could be sending Ctrl-C from msys either)."}}
{"actor":{"display_login":"Keisial"}}