{"action":"created","comment":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/123220126","pull_request_review_id":45400500,"id":123220126,"diff_hunk":"@@ -223,7 +225,7 @@ private Object handleReadCommandReturn(InvocationContext rCtx, VisitableCommand\n       } else if (ce instanceof AllOwnersLostException) {\n          if (trace)\n             getLog().tracef(\"All owners for command %s have been lost.\", cmd);\n-         return null;\n+         return rCommand.acceptVisitor(rCtx, LostDataVisitor.INSTANCE);","path":"core/src/main/java/org/infinispan/interceptors/impl/BaseStateTransferInterceptor.java","position":13,"original_position":17,"commit_id":"ed470df83390ecd6982ddcca941dacb0e0870e3f","original_commit_id":"9bdf01ef65035aa4b159a8d860414bb033790120","user":{"login":"danberindei","id":504907,"avatar_url":"https://avatars1.githubusercontent.com/u/504907?v=3","gravatar_id":"","url":"https://api.github.com/users/danberindei","html_url":"https://github.com/danberindei","followers_url":"https://api.github.com/users/danberindei/followers","following_url":"https://api.github.com/users/danberindei/following{/other_user}","gists_url":"https://api.github.com/users/danberindei/gists{/gist_id}","starred_url":"https://api.github.com/users/danberindei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danberindei/subscriptions","organizations_url":"https://api.github.com/users/danberindei/orgs","repos_url":"https://api.github.com/users/danberindei/repos","events_url":"https://api.github.com/users/danberindei/events{/privacy}","received_events_url":"https://api.github.com/users/danberindei/received_events","type":"User","site_admin":false},"body":"Last night I didn't think so, but now I'm leaning towards putting all the checks in DI again:\r\n\r\nhttps://issues.jboss.org/browse/ISPN-7956","created_at":"2017-06-21T11:15:41Z","updated_at":"2017-06-21T11:15:41Z","html_url":"https://github.com/infinispan/infinispan/pull/5175#discussion_r123220126","pull_request_url":"https://api.github.com/repos/infinispan/infinispan/pulls/5175","_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments/123220126"},"html":{"href":"https://github.com/infinispan/infinispan/pull/5175#discussion_r123220126"},"pull_request":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5175"}}},"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/5175","id":123668270,"html_url":"https://github.com/infinispan/infinispan/pull/5175","diff_url":"https://github.com/infinispan/infinispan/pull/5175.diff","patch_url":"https://github.com/infinispan/infinispan/pull/5175.patch","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/5175","number":5175,"state":"open","locked":false,"title":"ISPN-7884 StackOverflowException caused by GetAllCommand","user":{"login":"rvansa","id":2167869,"avatar_url":"https://avatars3.githubusercontent.com/u/2167869?v=3","gravatar_id":"","url":"https://api.github.com/users/rvansa","html_url":"https://github.com/rvansa","followers_url":"https://api.github.com/users/rvansa/followers","following_url":"https://api.github.com/users/rvansa/following{/other_user}","gists_url":"https://api.github.com/users/rvansa/gists{/gist_id}","starred_url":"https://api.github.com/users/rvansa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvansa/subscriptions","organizations_url":"https://api.github.com/users/rvansa/orgs","repos_url":"https://api.github.com/users/rvansa/repos","events_url":"https://api.github.com/users/rvansa/events{/privacy}","received_events_url":"https://api.github.com/users/rvansa/received_events","type":"User","site_admin":false},"body":"https://issues.jboss.org/browse/ISPN-7884\r\n\r\nI've also removed some parts of PartititionHandlingInterceptor that don't make much sense with the overall picture of lost data handling in mind.\r\nNote that this also addresses problem similar to https://issues.jboss.org/browse/ISPN-7889 for `GetAllCommand`.","created_at":"2017-06-02T08:40:14Z","updated_at":"2017-06-21T11:15:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41a992dd1e8592b54cda4880f24ec40958038669","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/infinispan/infinispan/pulls/5175/commits","review_comments_url":"https://api.github.com/repos/infinispan/infinispan/pulls/5175/comments","review_comment_url":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/5175/comments","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/ed470df83390ecd6982ddcca941dacb0e0870e3f","head":{"label":"rvansa:ISPN-7884","ref":"ISPN-7884","sha":"ed470df83390ecd6982ddcca941dacb0e0870e3f","user":{"login":"rvansa","id":2167869,"avatar_url":"https://avatars3.githubusercontent.com/u/2167869?v=3","gravatar_id":"","url":"https://api.github.com/users/rvansa","html_url":"https://github.com/rvansa","followers_url":"https://api.github.com/users/rvansa/followers","following_url":"https://api.github.com/users/rvansa/following{/other_user}","gists_url":"https://api.github.com/users/rvansa/gists{/gist_id}","starred_url":"https://api.github.com/users/rvansa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvansa/subscriptions","organizations_url":"https://api.github.com/users/rvansa/orgs","repos_url":"https://api.github.com/users/rvansa/repos","events_url":"https://api.github.com/users/rvansa/events{/privacy}","received_events_url":"https://api.github.com/users/rvansa/received_events","type":"User","site_admin":false},"repo":{"id":8481591,"name":"infinispan","full_name":"rvansa/infinispan","owner":{"login":"rvansa","id":2167869,"avatar_url":"https://avatars3.githubusercontent.com/u/2167869?v=3","gravatar_id":"","url":"https://api.github.com/users/rvansa","html_url":"https://github.com/rvansa","followers_url":"https://api.github.com/users/rvansa/followers","following_url":"https://api.github.com/users/rvansa/following{/other_user}","gists_url":"https://api.github.com/users/rvansa/gists{/gist_id}","starred_url":"https://api.github.com/users/rvansa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvansa/subscriptions","organizations_url":"https://api.github.com/users/rvansa/orgs","repos_url":"https://api.github.com/users/rvansa/repos","events_url":"https://api.github.com/users/rvansa/events{/privacy}","received_events_url":"https://api.github.com/users/rvansa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rvansa/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":true,"url":"https://api.github.com/repos/rvansa/infinispan","forks_url":"https://api.github.com/repos/rvansa/infinispan/forks","keys_url":"https://api.github.com/repos/rvansa/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rvansa/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rvansa/infinispan/teams","hooks_url":"https://api.github.com/repos/rvansa/infinispan/hooks","issue_events_url":"https://api.github.com/repos/rvansa/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/rvansa/infinispan/events","assignees_url":"https://api.github.com/repos/rvansa/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/rvansa/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/rvansa/infinispan/tags","blobs_url":"https://api.github.com/repos/rvansa/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rvansa/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rvansa/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/rvansa/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rvansa/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/rvansa/infinispan/languages","stargazers_url":"https://api.github.com/repos/rvansa/infinispan/stargazers","contributors_url":"https://api.github.com/repos/rvansa/infinispan/contributors","subscribers_url":"https://api.github.com/repos/rvansa/infinispan/subscribers","subscription_url":"https://api.github.com/repos/rvansa/infinispan/subscription","commits_url":"https://api.github.com/repos/rvansa/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/rvansa/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/rvansa/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/rvansa/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/rvansa/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/rvansa/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rvansa/infinispan/merges","archive_url":"https://api.github.com/repos/rvansa/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rvansa/infinispan/downloads","issues_url":"https://api.github.com/repos/rvansa/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/rvansa/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/rvansa/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/rvansa/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rvansa/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/rvansa/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/rvansa/infinispan/deployments","created_at":"2013-02-28T15:13:16Z","updated_at":"2015-05-05T17:20:40Z","pushed_at":"2017-06-21T11:15:09Z","git_url":"git://github.com/rvansa/infinispan.git","ssh_url":"git@github.com:rvansa/infinispan.git","clone_url":"https://github.com/rvansa/infinispan.git","svn_url":"https://github.com/rvansa/infinispan","homepage":"http://www.infinispan.org","size":92364,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"infinispan:master","ref":"master","sha":"67c306defc539bb15ce590d814d3373994d93abe","user":{"login":"infinispan","id":458093,"avatar_url":"https://avatars0.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"repo":{"id":1050944,"name":"infinispan","full_name":"infinispan/infinispan","owner":{"login":"infinispan","id":458093,"avatar_url":"https://avatars0.githubusercontent.com/u/458093?v=3","gravatar_id":"","url":"https://api.github.com/users/infinispan","html_url":"https://github.com/infinispan","followers_url":"https://api.github.com/users/infinispan/followers","following_url":"https://api.github.com/users/infinispan/following{/other_user}","gists_url":"https://api.github.com/users/infinispan/gists{/gist_id}","starred_url":"https://api.github.com/users/infinispan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infinispan/subscriptions","organizations_url":"https://api.github.com/users/infinispan/orgs","repos_url":"https://api.github.com/users/infinispan/repos","events_url":"https://api.github.com/users/infinispan/events{/privacy}","received_events_url":"https://api.github.com/users/infinispan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/infinispan/infinispan","description":"Infinispan is an open source data grid platform and highly scalable NoSQL cloud data store.","fork":false,"url":"https://api.github.com/repos/infinispan/infinispan","forks_url":"https://api.github.com/repos/infinispan/infinispan/forks","keys_url":"https://api.github.com/repos/infinispan/infinispan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infinispan/infinispan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infinispan/infinispan/teams","hooks_url":"https://api.github.com/repos/infinispan/infinispan/hooks","issue_events_url":"https://api.github.com/repos/infinispan/infinispan/issues/events{/number}","events_url":"https://api.github.com/repos/infinispan/infinispan/events","assignees_url":"https://api.github.com/repos/infinispan/infinispan/assignees{/user}","branches_url":"https://api.github.com/repos/infinispan/infinispan/branches{/branch}","tags_url":"https://api.github.com/repos/infinispan/infinispan/tags","blobs_url":"https://api.github.com/repos/infinispan/infinispan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infinispan/infinispan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infinispan/infinispan/git/refs{/sha}","trees_url":"https://api.github.com/repos/infinispan/infinispan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infinispan/infinispan/statuses/{sha}","languages_url":"https://api.github.com/repos/infinispan/infinispan/languages","stargazers_url":"https://api.github.com/repos/infinispan/infinispan/stargazers","contributors_url":"https://api.github.com/repos/infinispan/infinispan/contributors","subscribers_url":"https://api.github.com/repos/infinispan/infinispan/subscribers","subscription_url":"https://api.github.com/repos/infinispan/infinispan/subscription","commits_url":"https://api.github.com/repos/infinispan/infinispan/commits{/sha}","git_commits_url":"https://api.github.com/repos/infinispan/infinispan/git/commits{/sha}","comments_url":"https://api.github.com/repos/infinispan/infinispan/comments{/number}","issue_comment_url":"https://api.github.com/repos/infinispan/infinispan/issues/comments{/number}","contents_url":"https://api.github.com/repos/infinispan/infinispan/contents/{+path}","compare_url":"https://api.github.com/repos/infinispan/infinispan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infinispan/infinispan/merges","archive_url":"https://api.github.com/repos/infinispan/infinispan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infinispan/infinispan/downloads","issues_url":"https://api.github.com/repos/infinispan/infinispan/issues{/number}","pulls_url":"https://api.github.com/repos/infinispan/infinispan/pulls{/number}","milestones_url":"https://api.github.com/repos/infinispan/infinispan/milestones{/number}","notifications_url":"https://api.github.com/repos/infinispan/infinispan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infinispan/infinispan/labels{/name}","releases_url":"https://api.github.com/repos/infinispan/infinispan/releases{/id}","deployments_url":"https://api.github.com/repos/infinispan/infinispan/deployments","created_at":"2010-11-04T12:33:19Z","updated_at":"2017-06-20T13:27:37Z","pushed_at":"2017-06-21T10:39:32Z","git_url":"git://github.com/infinispan/infinispan.git","ssh_url":"git@github.com:infinispan/infinispan.git","clone_url":"https://github.com/infinispan/infinispan.git","svn_url":"https://github.com/infinispan/infinispan","homepage":"http://www.infinispan.org","size":97701,"stargazers_count":569,"watchers_count":569,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":400,"mirror_url":null,"open_issues_count":18,"forks":400,"open_issues":18,"watchers":569,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5175"},"html":{"href":"https://github.com/infinispan/infinispan/pull/5175"},"issue":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/5175"},"comments":{"href":"https://api.github.com/repos/infinispan/infinispan/issues/5175/comments"},"review_comments":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5175/comments"},"review_comment":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/infinispan/infinispan/pulls/5175/commits"},"statuses":{"href":"https://api.github.com/repos/infinispan/infinispan/statuses/ed470df83390ecd6982ddcca941dacb0e0870e3f"}}}}
{"actor":{"display_login":"danberindei"}}