{"action":"created","comment":{"url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/pulls/comments/127034084","pull_request_review_id":49577988,"id":127034084,"diff_hunk":"@@ -248,6 +253,9 @@ sub _runModule {\n         die \"module $other_module, needed before $module, not found\"\n             if !$self->{modules}->{$other_module};\n \n+        next if (!$self->{modules}->{$other_module}->{enabled} &&\n+            $self->{modules}->{$module}->{runAfterIfEnabled}->{$other_module});\n+","path":"lib/FusionInventory/Agent/Task/Inventory.pm","position":21,"original_position":21,"commit_id":"d68ef713872de3256bacb6879a331311e8f91970","original_commit_id":"45adc2a61a81397265d02750b79fd919ac773733","user":{"login":"guillomovitch","id":293223,"avatar_url":"https://avatars3.githubusercontent.com/u/293223?v=3","gravatar_id":"","url":"https://api.github.com/users/guillomovitch","html_url":"https://github.com/guillomovitch","followers_url":"https://api.github.com/users/guillomovitch/followers","following_url":"https://api.github.com/users/guillomovitch/following{/other_user}","gists_url":"https://api.github.com/users/guillomovitch/gists{/gist_id}","starred_url":"https://api.github.com/users/guillomovitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guillomovitch/subscriptions","organizations_url":"https://api.github.com/users/guillomovitch/orgs","repos_url":"https://api.github.com/users/guillomovitch/repos","events_url":"https://api.github.com/users/guillomovitch/events{/privacy}","received_events_url":"https://api.github.com/users/guillomovitch/received_events","type":"User","site_admin":false},"body":"I'd rather test the disabled condition once only, for better evidence:\r\n\r\n# check the required module status\r\nif (!$self->{modules}->{$other_module})->{enabled} {\r\n    if ($self->{modules}->{$module}->{runAfterIfEnabled}->{$other_module}) {\r\n        # soft dependency: run current module without required one\r\n        next;\r\n    } else {\r\n        # hard dependency: abort current module execution\r\n        die \"module $other_module, needed before $module, not enabled\"\r\n    }\r\n}","created_at":"2017-07-12T18:25:53Z","updated_at":"2017-07-12T18:25:54Z","html_url":"https://github.com/fusioninventory/fusioninventory-agent/pull/339#discussion_r127034084","pull_request_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/pulls/339","_links":{"self":{"href":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/pulls/comments/127034084"},"html":{"href":"https://github.com/fusioninventory/fusioninventory-agent/pull/339#discussion_r127034084"},"pull_request":{"href":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/pulls/339"}}},"pull_request":{"url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/pulls/339","id":130173449,"html_url":"https://github.com/fusioninventory/fusioninventory-agent/pull/339","diff_url":"https://github.com/fusioninventory/fusioninventory-agent/pull/339.diff","patch_url":"https://github.com/fusioninventory/fusioninventory-agent/pull/339.patch","issue_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/issues/339","number":339,"state":"open","locked":false,"title":"Update memory component capacity on virtual systems","user":{"login":"g-bougard","id":12514489,"avatar_url":"https://avatars3.githubusercontent.com/u/12514489?v=3","gravatar_id":"","url":"https://api.github.com/users/g-bougard","html_url":"https://github.com/g-bougard","followers_url":"https://api.github.com/users/g-bougard/followers","following_url":"https://api.github.com/users/g-bougard/following{/other_user}","gists_url":"https://api.github.com/users/g-bougard/gists{/gist_id}","starred_url":"https://api.github.com/users/g-bougard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-bougard/subscriptions","organizations_url":"https://api.github.com/users/g-bougard/orgs","repos_url":"https://api.github.com/users/g-bougard/repos","events_url":"https://api.github.com/users/g-bougard/events{/privacy}","received_events_url":"https://api.github.com/users/g-bougard/received_events","type":"User","site_admin":false},"body":"On virtual systems, memory capacity is often exposed as one component. dmidecode only reports initial capacity in that case. This PR updates the component capacity to the total memory size set in HARDWARE section in such case. So any virtually allocated memory change will be also reported by the agent at the memory component level.\r\n\r\nI had to introduce escape conditions support in inventory module dependencies as total memory size is detected in platform dependent modules.","created_at":"2017-07-12T15:48:50Z","updated_at":"2017-07-12T18:25:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1a778c08571c6d81a879bade18f993c1a0a145b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/pulls/339/commits","review_comments_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/pulls/339/comments","review_comment_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/issues/339/comments","statuses_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/statuses/d68ef713872de3256bacb6879a331311e8f91970","head":{"label":"TECLIB:2.3.x+update-mem-capacity-on-vmsystems","ref":"2.3.x+update-mem-capacity-on-vmsystems","sha":"d68ef713872de3256bacb6879a331311e8f91970","user":{"login":"TECLIB","id":1223260,"avatar_url":"https://avatars0.githubusercontent.com/u/1223260?v=3","gravatar_id":"","url":"https://api.github.com/users/TECLIB","html_url":"https://github.com/TECLIB","followers_url":"https://api.github.com/users/TECLIB/followers","following_url":"https://api.github.com/users/TECLIB/following{/other_user}","gists_url":"https://api.github.com/users/TECLIB/gists{/gist_id}","starred_url":"https://api.github.com/users/TECLIB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TECLIB/subscriptions","organizations_url":"https://api.github.com/users/TECLIB/orgs","repos_url":"https://api.github.com/users/TECLIB/repos","events_url":"https://api.github.com/users/TECLIB/events{/privacy}","received_events_url":"https://api.github.com/users/TECLIB/received_events","type":"Organization","site_admin":false},"repo":{"id":72744131,"name":"fusioninventory-agent","full_name":"TECLIB/fusioninventory-agent","owner":{"login":"TECLIB","id":1223260,"avatar_url":"https://avatars0.githubusercontent.com/u/1223260?v=3","gravatar_id":"","url":"https://api.github.com/users/TECLIB","html_url":"https://github.com/TECLIB","followers_url":"https://api.github.com/users/TECLIB/followers","following_url":"https://api.github.com/users/TECLIB/following{/other_user}","gists_url":"https://api.github.com/users/TECLIB/gists{/gist_id}","starred_url":"https://api.github.com/users/TECLIB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TECLIB/subscriptions","organizations_url":"https://api.github.com/users/TECLIB/orgs","repos_url":"https://api.github.com/users/TECLIB/repos","events_url":"https://api.github.com/users/TECLIB/events{/privacy}","received_events_url":"https://api.github.com/users/TECLIB/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TECLIB/fusioninventory-agent","description":"FusionInventory Agent","fork":true,"url":"https://api.github.com/repos/TECLIB/fusioninventory-agent","forks_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/forks","keys_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/teams","hooks_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/hooks","issue_events_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/issues/events{/number}","events_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/events","assignees_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/assignees{/user}","branches_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/branches{/branch}","tags_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/tags","blobs_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/languages","stargazers_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/stargazers","contributors_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/contributors","subscribers_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/subscribers","subscription_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/subscription","commits_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/contents/{+path}","compare_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/merges","archive_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/downloads","issues_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/issues{/number}","pulls_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/labels{/name}","releases_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/releases{/id}","deployments_url":"https://api.github.com/repos/TECLIB/fusioninventory-agent/deployments","created_at":"2016-11-03T12:42:01Z","updated_at":"2017-07-04T18:19:40Z","pushed_at":"2017-07-12T15:55:19Z","git_url":"git://github.com/TECLIB/fusioninventory-agent.git","ssh_url":"git@github.com:TECLIB/fusioninventory-agent.git","clone_url":"https://github.com/TECLIB/fusioninventory-agent.git","svn_url":"https://github.com/TECLIB/fusioninventory-agent","homepage":"http://www.FusionInventory.org/","size":26961,"stargazers_count":1,"watchers_count":1,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"2.3.x"}},"base":{"label":"fusioninventory:2.3.x","ref":"2.3.x","sha":"6263ece95c74b52d7c440a98f8b117b878f4fe9f","user":{"login":"fusioninventory","id":239747,"avatar_url":"https://avatars3.githubusercontent.com/u/239747?v=3","gravatar_id":"","url":"https://api.github.com/users/fusioninventory","html_url":"https://github.com/fusioninventory","followers_url":"https://api.github.com/users/fusioninventory/followers","following_url":"https://api.github.com/users/fusioninventory/following{/other_user}","gists_url":"https://api.github.com/users/fusioninventory/gists{/gist_id}","starred_url":"https://api.github.com/users/fusioninventory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fusioninventory/subscriptions","organizations_url":"https://api.github.com/users/fusioninventory/orgs","repos_url":"https://api.github.com/users/fusioninventory/repos","events_url":"https://api.github.com/users/fusioninventory/events{/privacy}","received_events_url":"https://api.github.com/users/fusioninventory/received_events","type":"Organization","site_admin":false},"repo":{"id":601251,"name":"fusioninventory-agent","full_name":"fusioninventory/fusioninventory-agent","owner":{"login":"fusioninventory","id":239747,"avatar_url":"https://avatars3.githubusercontent.com/u/239747?v=3","gravatar_id":"","url":"https://api.github.com/users/fusioninventory","html_url":"https://github.com/fusioninventory","followers_url":"https://api.github.com/users/fusioninventory/followers","following_url":"https://api.github.com/users/fusioninventory/following{/other_user}","gists_url":"https://api.github.com/users/fusioninventory/gists{/gist_id}","starred_url":"https://api.github.com/users/fusioninventory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fusioninventory/subscriptions","organizations_url":"https://api.github.com/users/fusioninventory/orgs","repos_url":"https://api.github.com/users/fusioninventory/repos","events_url":"https://api.github.com/users/fusioninventory/events{/privacy}","received_events_url":"https://api.github.com/users/fusioninventory/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fusioninventory/fusioninventory-agent","description":"FusionInventory Agent","fork":false,"url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent","forks_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/forks","keys_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/teams","hooks_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/hooks","issue_events_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/issues/events{/number}","events_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/events","assignees_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/assignees{/user}","branches_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/branches{/branch}","tags_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/tags","blobs_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/languages","stargazers_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/stargazers","contributors_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/contributors","subscribers_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/subscribers","subscription_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/subscription","commits_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/contents/{+path}","compare_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/merges","archive_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/downloads","issues_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/issues{/number}","pulls_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/labels{/name}","releases_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/releases{/id}","deployments_url":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/deployments","created_at":"2010-04-08T18:48:46Z","updated_at":"2017-06-16T13:49:53Z","pushed_at":"2017-07-12T16:02:54Z","git_url":"git://github.com/fusioninventory/fusioninventory-agent.git","ssh_url":"git@github.com:fusioninventory/fusioninventory-agent.git","clone_url":"https://github.com/fusioninventory/fusioninventory-agent.git","svn_url":"https://github.com/fusioninventory/fusioninventory-agent","homepage":"http://fusioninventory.org/","size":30782,"stargazers_count":66,"watchers_count":66,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":44,"forks":67,"open_issues":44,"watchers":66,"default_branch":"2.3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/pulls/339"},"html":{"href":"https://github.com/fusioninventory/fusioninventory-agent/pull/339"},"issue":{"href":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/issues/339"},"comments":{"href":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/issues/339/comments"},"review_comments":{"href":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/pulls/339/comments"},"review_comment":{"href":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/pulls/339/commits"},"statuses":{"href":"https://api.github.com/repos/fusioninventory/fusioninventory-agent/statuses/d68ef713872de3256bacb6879a331311e8f91970"}}}}
{"actor":{"display_login":"guillomovitch"}}