{"action":"created","comment":{"url":"https://api.github.com/repos/apache/metron/pulls/comments/116883407","pull_request_review_id":38540690,"id":116883407,"diff_hunk":"@@ -28,6 +26,17 @@\n public abstract class KeyValueDeserializer implements Serializable {\n   protected TimestampConverter converter;\n \n+  public static class Result {","path":"metron-platform/metron-pcap-backend/src/main/java/org/apache/metron/spout/pcap/deserializer/KeyValueDeserializer.java","position":13,"original_position":13,"commit_id":"6bcc34d0f4d4ae473a768f5909248fb85ffdc487","original_commit_id":"6bcc34d0f4d4ae473a768f5909248fb85ffdc487","user":{"login":"mmiklavc","id":658443,"avatar_url":"https://avatars0.githubusercontent.com/u/658443?v=3","gravatar_id":"","url":"https://api.github.com/users/mmiklavc","html_url":"https://github.com/mmiklavc","followers_url":"https://api.github.com/users/mmiklavc/followers","following_url":"https://api.github.com/users/mmiklavc/following{/other_user}","gists_url":"https://api.github.com/users/mmiklavc/gists{/gist_id}","starred_url":"https://api.github.com/users/mmiklavc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmiklavc/subscriptions","organizations_url":"https://api.github.com/users/mmiklavc/orgs","repos_url":"https://api.github.com/users/mmiklavc/repos","events_url":"https://api.github.com/users/mmiklavc/events{/privacy}","received_events_url":"https://api.github.com/users/mmiklavc/received_events","type":"User","site_admin":false},"body":"I looked at this and decided to tweak the terms a bit in this inner class. After stepping away from it a couple days I couldn't immediately tell what Result.result actually meant :)","created_at":"2017-05-16T23:44:07Z","updated_at":"2017-05-16T23:44:07Z","html_url":"https://github.com/apache/metron/pull/585#discussion_r116883407","pull_request_url":"https://api.github.com/repos/apache/metron/pulls/585","_links":{"self":{"href":"https://api.github.com/repos/apache/metron/pulls/comments/116883407"},"html":{"href":"https://github.com/apache/metron/pull/585#discussion_r116883407"},"pull_request":{"href":"https://api.github.com/repos/apache/metron/pulls/585"}}},"pull_request":{"url":"https://api.github.com/repos/apache/metron/pulls/585","id":120406015,"html_url":"https://github.com/apache/metron/pull/585","diff_url":"https://github.com/apache/metron/pull/585.diff","patch_url":"https://github.com/apache/metron/pull/585.patch","issue_url":"https://api.github.com/repos/apache/metron/issues/585","number":585,"state":"open","locked":false,"title":"METRON-936: Fixes to pcap for performance and testing","user":{"login":"mmiklavc","id":658443,"avatar_url":"https://avatars0.githubusercontent.com/u/658443?v=3","gravatar_id":"","url":"https://api.github.com/users/mmiklavc","html_url":"https://github.com/mmiklavc","followers_url":"https://api.github.com/users/mmiklavc/followers","following_url":"https://api.github.com/users/mmiklavc/following{/other_user}","gists_url":"https://api.github.com/users/mmiklavc/gists{/gist_id}","starred_url":"https://api.github.com/users/mmiklavc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmiklavc/subscriptions","organizations_url":"https://api.github.com/users/mmiklavc/orgs","repos_url":"https://api.github.com/users/mmiklavc/repos","events_url":"https://api.github.com/users/mmiklavc/events{/privacy}","received_events_url":"https://api.github.com/users/mmiklavc/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/METRON-936\r\n\r\nI still have some cleanup and additional docs to add, but I wanted to get this out for review.\r\n\r\n## Contributor Comments\r\n[Please place any comments here.  A description of the problem/enhancement, how to reproduce the issue, your testing methodology, etc.]\r\n\r\n\r\n## Pull Request Checklist\r\n\r\nThank you for submitting a contribution to Apache Metron.  \r\nPlease refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  \r\nPlease refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  \r\n\r\n\r\nIn order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:\r\n\r\n### For all changes:\r\n- [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). \r\n- [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen \"-\" character.\r\n- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?\r\n\r\n\r\n### For code changes:\r\n- [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?\r\n- [ ] Have you included steps or a guide to how the change may be verified and tested manually?\r\n- [ ] Have you ensured that the full suite of tests and checks have been executed in the root incubating-metron folder via:\r\n  ```\r\n  mvn -q clean integration-test install && build_utils/verify_licenses.sh \r\n  ```\r\n\r\n- [ ] Have you written or updated unit tests and or integration tests to verify your changes?\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? \r\n- [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?\r\n\r\n### For documentation related changes:\r\n- [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:\r\n\r\n  ```\r\n  cd site-book\r\n  mvn site\r\n  ```\r\n\r\n#### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.\r\nIt is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.\r\n\r\n","created_at":"2017-05-12T21:03:20Z","updated_at":"2017-05-16T23:44:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08e92b4c4096c34b1614d0311e85d265dcc154de","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/metron/pulls/585/commits","review_comments_url":"https://api.github.com/repos/apache/metron/pulls/585/comments","review_comment_url":"https://api.github.com/repos/apache/metron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/metron/issues/585/comments","statuses_url":"https://api.github.com/repos/apache/metron/statuses/6bcc34d0f4d4ae473a768f5909248fb85ffdc487","head":{"label":"mmiklavc:pcap-fixes","ref":"pcap-fixes","sha":"6bcc34d0f4d4ae473a768f5909248fb85ffdc487","user":{"login":"mmiklavc","id":658443,"avatar_url":"https://avatars0.githubusercontent.com/u/658443?v=3","gravatar_id":"","url":"https://api.github.com/users/mmiklavc","html_url":"https://github.com/mmiklavc","followers_url":"https://api.github.com/users/mmiklavc/followers","following_url":"https://api.github.com/users/mmiklavc/following{/other_user}","gists_url":"https://api.github.com/users/mmiklavc/gists{/gist_id}","starred_url":"https://api.github.com/users/mmiklavc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmiklavc/subscriptions","organizations_url":"https://api.github.com/users/mmiklavc/orgs","repos_url":"https://api.github.com/users/mmiklavc/repos","events_url":"https://api.github.com/users/mmiklavc/events{/privacy}","received_events_url":"https://api.github.com/users/mmiklavc/received_events","type":"User","site_admin":false},"repo":{"id":58224042,"name":"incubator-metron","full_name":"mmiklavc/incubator-metron","owner":{"login":"mmiklavc","id":658443,"avatar_url":"https://avatars0.githubusercontent.com/u/658443?v=3","gravatar_id":"","url":"https://api.github.com/users/mmiklavc","html_url":"https://github.com/mmiklavc","followers_url":"https://api.github.com/users/mmiklavc/followers","following_url":"https://api.github.com/users/mmiklavc/following{/other_user}","gists_url":"https://api.github.com/users/mmiklavc/gists{/gist_id}","starred_url":"https://api.github.com/users/mmiklavc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmiklavc/subscriptions","organizations_url":"https://api.github.com/users/mmiklavc/orgs","repos_url":"https://api.github.com/users/mmiklavc/repos","events_url":"https://api.github.com/users/mmiklavc/events{/privacy}","received_events_url":"https://api.github.com/users/mmiklavc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mmiklavc/incubator-metron","description":"Mirror of Apache Metron (Incubating)","fork":true,"url":"https://api.github.com/repos/mmiklavc/incubator-metron","forks_url":"https://api.github.com/repos/mmiklavc/incubator-metron/forks","keys_url":"https://api.github.com/repos/mmiklavc/incubator-metron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mmiklavc/incubator-metron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mmiklavc/incubator-metron/teams","hooks_url":"https://api.github.com/repos/mmiklavc/incubator-metron/hooks","issue_events_url":"https://api.github.com/repos/mmiklavc/incubator-metron/issues/events{/number}","events_url":"https://api.github.com/repos/mmiklavc/incubator-metron/events","assignees_url":"https://api.github.com/repos/mmiklavc/incubator-metron/assignees{/user}","branches_url":"https://api.github.com/repos/mmiklavc/incubator-metron/branches{/branch}","tags_url":"https://api.github.com/repos/mmiklavc/incubator-metron/tags","blobs_url":"https://api.github.com/repos/mmiklavc/incubator-metron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mmiklavc/incubator-metron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mmiklavc/incubator-metron/git/refs{/sha}","trees_url":"https://api.github.com/repos/mmiklavc/incubator-metron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mmiklavc/incubator-metron/statuses/{sha}","languages_url":"https://api.github.com/repos/mmiklavc/incubator-metron/languages","stargazers_url":"https://api.github.com/repos/mmiklavc/incubator-metron/stargazers","contributors_url":"https://api.github.com/repos/mmiklavc/incubator-metron/contributors","subscribers_url":"https://api.github.com/repos/mmiklavc/incubator-metron/subscribers","subscription_url":"https://api.github.com/repos/mmiklavc/incubator-metron/subscription","commits_url":"https://api.github.com/repos/mmiklavc/incubator-metron/commits{/sha}","git_commits_url":"https://api.github.com/repos/mmiklavc/incubator-metron/git/commits{/sha}","comments_url":"https://api.github.com/repos/mmiklavc/incubator-metron/comments{/number}","issue_comment_url":"https://api.github.com/repos/mmiklavc/incubator-metron/issues/comments{/number}","contents_url":"https://api.github.com/repos/mmiklavc/incubator-metron/contents/{+path}","compare_url":"https://api.github.com/repos/mmiklavc/incubator-metron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mmiklavc/incubator-metron/merges","archive_url":"https://api.github.com/repos/mmiklavc/incubator-metron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mmiklavc/incubator-metron/downloads","issues_url":"https://api.github.com/repos/mmiklavc/incubator-metron/issues{/number}","pulls_url":"https://api.github.com/repos/mmiklavc/incubator-metron/pulls{/number}","milestones_url":"https://api.github.com/repos/mmiklavc/incubator-metron/milestones{/number}","notifications_url":"https://api.github.com/repos/mmiklavc/incubator-metron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mmiklavc/incubator-metron/labels{/name}","releases_url":"https://api.github.com/repos/mmiklavc/incubator-metron/releases{/id}","deployments_url":"https://api.github.com/repos/mmiklavc/incubator-metron/deployments","created_at":"2016-05-06T17:35:02Z","updated_at":"2016-05-06T17:35:05Z","pushed_at":"2017-05-12T20:56:34Z","git_url":"git://github.com/mmiklavc/incubator-metron.git","ssh_url":"git@github.com:mmiklavc/incubator-metron.git","clone_url":"https://github.com/mmiklavc/incubator-metron.git","svn_url":"https://github.com/mmiklavc/incubator-metron","homepage":null,"size":55672,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"345eba8d5940f2789e5a860eb51e8fa9f003c676","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":47607561,"name":"metron","full_name":"apache/metron","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/metron","description":"Mirror of Apache Metron","fork":false,"url":"https://api.github.com/repos/apache/metron","forks_url":"https://api.github.com/repos/apache/metron/forks","keys_url":"https://api.github.com/repos/apache/metron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/metron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/metron/teams","hooks_url":"https://api.github.com/repos/apache/metron/hooks","issue_events_url":"https://api.github.com/repos/apache/metron/issues/events{/number}","events_url":"https://api.github.com/repos/apache/metron/events","assignees_url":"https://api.github.com/repos/apache/metron/assignees{/user}","branches_url":"https://api.github.com/repos/apache/metron/branches{/branch}","tags_url":"https://api.github.com/repos/apache/metron/tags","blobs_url":"https://api.github.com/repos/apache/metron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/metron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/metron/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/metron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/metron/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/metron/languages","stargazers_url":"https://api.github.com/repos/apache/metron/stargazers","contributors_url":"https://api.github.com/repos/apache/metron/contributors","subscribers_url":"https://api.github.com/repos/apache/metron/subscribers","subscription_url":"https://api.github.com/repos/apache/metron/subscription","commits_url":"https://api.github.com/repos/apache/metron/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/metron/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/metron/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/metron/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/metron/contents/{+path}","compare_url":"https://api.github.com/repos/apache/metron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/metron/merges","archive_url":"https://api.github.com/repos/apache/metron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/metron/downloads","issues_url":"https://api.github.com/repos/apache/metron/issues{/number}","pulls_url":"https://api.github.com/repos/apache/metron/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/metron/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/metron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/metron/labels{/name}","releases_url":"https://api.github.com/repos/apache/metron/releases{/id}","deployments_url":"https://api.github.com/repos/apache/metron/deployments","created_at":"2015-12-08T08:00:05Z","updated_at":"2017-05-15T19:43:18Z","pushed_at":"2017-05-16T21:00:19Z","git_url":"git://github.com/apache/metron.git","ssh_url":"git@github.com:apache/metron.git","clone_url":"https://github.com/apache/metron.git","svn_url":"https://github.com/apache/metron","homepage":"","size":53265,"stargazers_count":254,"watchers_count":254,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":208,"mirror_url":"git://git.apache.org/metron.git","open_issues_count":27,"forks":208,"open_issues":27,"watchers":254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/metron/pulls/585"},"html":{"href":"https://github.com/apache/metron/pull/585"},"issue":{"href":"https://api.github.com/repos/apache/metron/issues/585"},"comments":{"href":"https://api.github.com/repos/apache/metron/issues/585/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/metron/pulls/585/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/metron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/metron/pulls/585/commits"},"statuses":{"href":"https://api.github.com/repos/apache/metron/statuses/6bcc34d0f4d4ae473a768f5909248fb85ffdc487"}}}}
{"actor":{"display_login":"mmiklavc"}}