{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/157859162","pull_request_review_id":84571637,"id":157859162,"diff_hunk":"@@ -107,11 +109,17 @@ def __del__(self):\n             if self._source_traceback:\n                 context['source_traceback'] = self._source_traceback\n             self._loop.call_exception_handler(context)\n-        futures.Future.__del__(self)\n+        super().__del__()\n \n     def _repr_info(self):\n         return base_tasks._task_repr_info(self)\n \n+    def set_result(self, result):\n+        raise RuntimeError('Tasks do not support set_result operation')","path":"Lib/asyncio/tasks.py","position":22,"original_position":22,"commit_id":"f645e9d5351dc534177ded7c5bfe8f6d83b64aef","original_commit_id":"f645e9d5351dc534177ded7c5bfe8f6d83b64aef","user":{"login":"asvetlov","id":356399,"avatar_url":"https://avatars0.githubusercontent.com/u/356399?v=4","gravatar_id":"","url":"https://api.github.com/users/asvetlov","html_url":"https://github.com/asvetlov","followers_url":"https://api.github.com/users/asvetlov/followers","following_url":"https://api.github.com/users/asvetlov/following{/other_user}","gists_url":"https://api.github.com/users/asvetlov/gists{/gist_id}","starred_url":"https://api.github.com/users/asvetlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asvetlov/subscriptions","organizations_url":"https://api.github.com/users/asvetlov/orgs","repos_url":"https://api.github.com/users/asvetlov/repos","events_url":"https://api.github.com/users/asvetlov/events{/privacy}","received_events_url":"https://api.github.com/users/asvetlov/received_events","type":"User","site_admin":false},"body":"`Task does not support ...` sounds slightly better to me but I don't insist.","created_at":"2017-12-19T19:54:49Z","updated_at":"2017-12-19T19:54:49Z","html_url":"https://github.com/python/cpython/pull/4923#discussion_r157859162","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/4923","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/157859162"},"html":{"href":"https://github.com/python/cpython/pull/4923#discussion_r157859162"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/4923"}}},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/4923","id":159082820,"html_url":"https://github.com/python/cpython/pull/4923","diff_url":"https://github.com/python/cpython/pull/4923.diff","patch_url":"https://github.com/python/cpython/pull/4923.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/4923","number":4923,"state":"open","locked":false,"title":"bpo-32363: Disable Task.set_exception() and Task.set_result()","user":{"login":"1st1","id":239003,"avatar_url":"https://avatars0.githubusercontent.com/u/239003?v=4","gravatar_id":"","url":"https://api.github.com/users/1st1","html_url":"https://github.com/1st1","followers_url":"https://api.github.com/users/1st1/followers","following_url":"https://api.github.com/users/1st1/following{/other_user}","gists_url":"https://api.github.com/users/1st1/gists{/gist_id}","starred_url":"https://api.github.com/users/1st1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1st1/subscriptions","organizations_url":"https://api.github.com/users/1st1/orgs","repos_url":"https://api.github.com/users/1st1/repos","events_url":"https://api.github.com/users/1st1/events{/privacy}","received_events_url":"https://api.github.com/users/1st1/received_events","type":"User","site_admin":false},"body":"\n\n<!-- issue-number: bpo-32363 -->\nhttps://bugs.python.org/issue32363\n<!-- /issue-number -->\n","created_at":"2017-12-19T05:39:54Z","updated_at":"2017-12-19T19:54:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d173cad7e5123f95306640b45f31c15a20e92cbd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/4923/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/4923/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/4923/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/f645e9d5351dc534177ded7c5bfe8f6d83b64aef","head":{"label":"1st1:no_task_set_methods","ref":"no_task_set_methods","sha":"f645e9d5351dc534177ded7c5bfe8f6d83b64aef","user":{"login":"1st1","id":239003,"avatar_url":"https://avatars0.githubusercontent.com/u/239003?v=4","gravatar_id":"","url":"https://api.github.com/users/1st1","html_url":"https://github.com/1st1","followers_url":"https://api.github.com/users/1st1/followers","following_url":"https://api.github.com/users/1st1/following{/other_user}","gists_url":"https://api.github.com/users/1st1/gists{/gist_id}","starred_url":"https://api.github.com/users/1st1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1st1/subscriptions","organizations_url":"https://api.github.com/users/1st1/orgs","repos_url":"https://api.github.com/users/1st1/repos","events_url":"https://api.github.com/users/1st1/events{/privacy}","received_events_url":"https://api.github.com/users/1st1/received_events","type":"User","site_admin":false},"repo":{"id":83706257,"name":"cpython","full_name":"1st1/cpython","owner":{"login":"1st1","id":239003,"avatar_url":"https://avatars0.githubusercontent.com/u/239003?v=4","gravatar_id":"","url":"https://api.github.com/users/1st1","html_url":"https://github.com/1st1","followers_url":"https://api.github.com/users/1st1/followers","following_url":"https://api.github.com/users/1st1/following{/other_user}","gists_url":"https://api.github.com/users/1st1/gists{/gist_id}","starred_url":"https://api.github.com/users/1st1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1st1/subscriptions","organizations_url":"https://api.github.com/users/1st1/orgs","repos_url":"https://api.github.com/users/1st1/repos","events_url":"https://api.github.com/users/1st1/events{/privacy}","received_events_url":"https://api.github.com/users/1st1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/1st1/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/1st1/cpython","forks_url":"https://api.github.com/repos/1st1/cpython/forks","keys_url":"https://api.github.com/repos/1st1/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1st1/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1st1/cpython/teams","hooks_url":"https://api.github.com/repos/1st1/cpython/hooks","issue_events_url":"https://api.github.com/repos/1st1/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/1st1/cpython/events","assignees_url":"https://api.github.com/repos/1st1/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/1st1/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/1st1/cpython/tags","blobs_url":"https://api.github.com/repos/1st1/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1st1/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1st1/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/1st1/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1st1/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/1st1/cpython/languages","stargazers_url":"https://api.github.com/repos/1st1/cpython/stargazers","contributors_url":"https://api.github.com/repos/1st1/cpython/contributors","subscribers_url":"https://api.github.com/repos/1st1/cpython/subscribers","subscription_url":"https://api.github.com/repos/1st1/cpython/subscription","commits_url":"https://api.github.com/repos/1st1/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/1st1/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/1st1/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/1st1/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/1st1/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/1st1/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1st1/cpython/merges","archive_url":"https://api.github.com/repos/1st1/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1st1/cpython/downloads","issues_url":"https://api.github.com/repos/1st1/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/1st1/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/1st1/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/1st1/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1st1/cpython/labels{/name}","releases_url":"https://api.github.com/repos/1st1/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/1st1/cpython/deployments","created_at":"2017-03-02T17:32:42Z","updated_at":"2017-08-25T06:15:17Z","pushed_at":"2017-12-19T19:54:47Z","git_url":"git://github.com/1st1/cpython.git","ssh_url":"git@github.com:1st1/cpython.git","clone_url":"https://github.com/1st1/cpython.git","svn_url":"https://github.com/1st1/cpython","homepage":"https://www.python.org/","size":212641,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"9818142b1bd20243733a953fb8aa2c7be314c47c","user":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"name":"cpython","full_name":"python/cpython","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2017-12-19T17:34:30Z","pushed_at":"2017-12-19T19:49:35Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":220617,"stargazers_count":14858,"watchers_count":14858,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3658,"mirror_url":null,"archived":false,"open_issues_count":532,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3658,"open_issues":532,"watchers":14858,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/4923"},"html":{"href":"https://github.com/python/cpython/pull/4923"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/4923"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/4923/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/4923/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/4923/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/f645e9d5351dc534177ded7c5bfe8f6d83b64aef"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"asvetlov"}}