{"action":"created","comment":{"url":"https://api.github.com/repos/alexa-js/alexa-app-server/pulls/comments/99675329","pull_request_review_id":20358709,"id":99675329,"diff_hunk":"@@ -217,26 +219,25 @@ var appServer = function(config) {\n               cert: certificate\n             };\n \n-            if (config.passphrase != undefined) {\n-              credentials.passphrase = config.passphrase\n+            if (self.config.passphrase != undefined) {\n+              credentials.passphrase = self.config.passphrase\n             }\n \n-            if (chain != undefined) { //if chain is used the add to credentials\n+            if (chain != undefined) {\n               credentials.ca = chain;\n               self.log(\"using chain certificate from /sslcert\");\n             }\n \n-            try { // These two lines below can fail it the certs were generated incorrectly. But we can continue startup without HTTPS\n-              var httpsServer = https.createServer(credentials, self.express); // create the HTTPS server\n+            try {\n+              // this can fail it the certs were generated incorrectly\n+              var httpsServer = https.createServer(credentials, self.express);\n \n-              // TODO: add separate option to specify specific host address for HTTPS server to bind to???\n-              // Issue #38: https://github.com/alexa-js/alexa-app-server/issues/38\n               if (typeof config.host === 'string') {\n-                self.httpsInstance = httpsServer.listen(config.httpsPort, config.host);\n-                self.log(\"listening on https://\" + config.host + \":\" + config.httpsPort);\n+                self.httpsInstance = httpsServer.listen(self.config.httpsPort, self.config.host);\n+                self.log(\"listening on https:// \" + self.config.host + \":\" + self.config.httpsPort);","path":"index.js","position":212,"original_position":212,"commit_id":"6a56d68970e2efe2953f14abf75c7000fbf1d97e","original_commit_id":"6a56d68970e2efe2953f14abf75c7000fbf1d97e","user":{"login":"tejashah88","id":11187343,"avatar_url":"https://avatars.githubusercontent.com/u/11187343?v=3","gravatar_id":"","url":"https://api.github.com/users/tejashah88","html_url":"https://github.com/tejashah88","followers_url":"https://api.github.com/users/tejashah88/followers","following_url":"https://api.github.com/users/tejashah88/following{/other_user}","gists_url":"https://api.github.com/users/tejashah88/gists{/gist_id}","starred_url":"https://api.github.com/users/tejashah88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejashah88/subscriptions","organizations_url":"https://api.github.com/users/tejashah88/orgs","repos_url":"https://api.github.com/users/tejashah88/repos","events_url":"https://api.github.com/users/tejashah88/events{/privacy}","received_events_url":"https://api.github.com/users/tejashah88/received_events","type":"User","site_admin":false},"body":"Might want to remove the space from `\"https://\"` so that if anyone is copying the exact url, it shouldn't be the following: `\"https:// 127.0.0.1:6000\"`","created_at":"2017-02-06T20:22:30Z","updated_at":"2017-02-06T20:32:14Z","html_url":"https://github.com/alexa-js/alexa-app-server/pull/72#discussion_r99675329","pull_request_url":"https://api.github.com/repos/alexa-js/alexa-app-server/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/alexa-js/alexa-app-server/pulls/comments/99675329"},"html":{"href":"https://github.com/alexa-js/alexa-app-server/pull/72#discussion_r99675329"},"pull_request":{"href":"https://api.github.com/repos/alexa-js/alexa-app-server/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/alexa-js/alexa-app-server/pulls/72","id":104858469,"html_url":"https://github.com/alexa-js/alexa-app-server/pull/72","diff_url":"https://github.com/alexa-js/alexa-app-server/pull/72.diff","patch_url":"https://github.com/alexa-js/alexa-app-server/pull/72.patch","issue_url":"https://api.github.com/repos/alexa-js/alexa-app-server/issues/72","number":72,"state":"open","locked":false,"title":"Clarified use of host, use path.combine for paths and lodash.defaults for config. Expose config.","user":{"login":"dblock","id":542335,"avatar_url":"https://avatars.githubusercontent.com/u/542335?v=3","gravatar_id":"","url":"https://api.github.com/users/dblock","html_url":"https://github.com/dblock","followers_url":"https://api.github.com/users/dblock/followers","following_url":"https://api.github.com/users/dblock/following{/other_user}","gists_url":"https://api.github.com/users/dblock/gists{/gist_id}","starred_url":"https://api.github.com/users/dblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblock/subscriptions","organizations_url":"https://api.github.com/users/dblock/orgs","repos_url":"https://api.github.com/users/dblock/repos","events_url":"https://api.github.com/users/dblock/events{/privacy}","received_events_url":"https://api.github.com/users/dblock/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-06T18:51:27Z","updated_at":"2017-02-06T20:32:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"501a6d813f3234cb04bb3a9adb93f9638c86c213","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alexa-js/alexa-app-server/pulls/72/commits","review_comments_url":"https://api.github.com/repos/alexa-js/alexa-app-server/pulls/72/comments","review_comment_url":"https://api.github.com/repos/alexa-js/alexa-app-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexa-js/alexa-app-server/issues/72/comments","statuses_url":"https://api.github.com/repos/alexa-js/alexa-app-server/statuses/6a56d68970e2efe2953f14abf75c7000fbf1d97e","head":{"label":"dblock:test-server-config","ref":"test-server-config","sha":"6a56d68970e2efe2953f14abf75c7000fbf1d97e","user":{"login":"dblock","id":542335,"avatar_url":"https://avatars.githubusercontent.com/u/542335?v=3","gravatar_id":"","url":"https://api.github.com/users/dblock","html_url":"https://github.com/dblock","followers_url":"https://api.github.com/users/dblock/followers","following_url":"https://api.github.com/users/dblock/following{/other_user}","gists_url":"https://api.github.com/users/dblock/gists{/gist_id}","starred_url":"https://api.github.com/users/dblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblock/subscriptions","organizations_url":"https://api.github.com/users/dblock/orgs","repos_url":"https://api.github.com/users/dblock/repos","events_url":"https://api.github.com/users/dblock/events{/privacy}","received_events_url":"https://api.github.com/users/dblock/received_events","type":"User","site_admin":false},"repo":{"id":78129567,"name":"alexa-app-server","full_name":"dblock/alexa-app-server","owner":{"login":"dblock","id":542335,"avatar_url":"https://avatars.githubusercontent.com/u/542335?v=3","gravatar_id":"","url":"https://api.github.com/users/dblock","html_url":"https://github.com/dblock","followers_url":"https://api.github.com/users/dblock/followers","following_url":"https://api.github.com/users/dblock/following{/other_user}","gists_url":"https://api.github.com/users/dblock/gists{/gist_id}","starred_url":"https://api.github.com/users/dblock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblock/subscriptions","organizations_url":"https://api.github.com/users/dblock/orgs","repos_url":"https://api.github.com/users/dblock/repos","events_url":"https://api.github.com/users/dblock/events{/privacy}","received_events_url":"https://api.github.com/users/dblock/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dblock/alexa-app-server","description":"An example Alexa App Server using Node.js and the alexa-app module","fork":true,"url":"https://api.github.com/repos/dblock/alexa-app-server","forks_url":"https://api.github.com/repos/dblock/alexa-app-server/forks","keys_url":"https://api.github.com/repos/dblock/alexa-app-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dblock/alexa-app-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dblock/alexa-app-server/teams","hooks_url":"https://api.github.com/repos/dblock/alexa-app-server/hooks","issue_events_url":"https://api.github.com/repos/dblock/alexa-app-server/issues/events{/number}","events_url":"https://api.github.com/repos/dblock/alexa-app-server/events","assignees_url":"https://api.github.com/repos/dblock/alexa-app-server/assignees{/user}","branches_url":"https://api.github.com/repos/dblock/alexa-app-server/branches{/branch}","tags_url":"https://api.github.com/repos/dblock/alexa-app-server/tags","blobs_url":"https://api.github.com/repos/dblock/alexa-app-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dblock/alexa-app-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dblock/alexa-app-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/dblock/alexa-app-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dblock/alexa-app-server/statuses/{sha}","languages_url":"https://api.github.com/repos/dblock/alexa-app-server/languages","stargazers_url":"https://api.github.com/repos/dblock/alexa-app-server/stargazers","contributors_url":"https://api.github.com/repos/dblock/alexa-app-server/contributors","subscribers_url":"https://api.github.com/repos/dblock/alexa-app-server/subscribers","subscription_url":"https://api.github.com/repos/dblock/alexa-app-server/subscription","commits_url":"https://api.github.com/repos/dblock/alexa-app-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/dblock/alexa-app-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/dblock/alexa-app-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/dblock/alexa-app-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/dblock/alexa-app-server/contents/{+path}","compare_url":"https://api.github.com/repos/dblock/alexa-app-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dblock/alexa-app-server/merges","archive_url":"https://api.github.com/repos/dblock/alexa-app-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dblock/alexa-app-server/downloads","issues_url":"https://api.github.com/repos/dblock/alexa-app-server/issues{/number}","pulls_url":"https://api.github.com/repos/dblock/alexa-app-server/pulls{/number}","milestones_url":"https://api.github.com/repos/dblock/alexa-app-server/milestones{/number}","notifications_url":"https://api.github.com/repos/dblock/alexa-app-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dblock/alexa-app-server/labels{/name}","releases_url":"https://api.github.com/repos/dblock/alexa-app-server/releases{/id}","deployments_url":"https://api.github.com/repos/dblock/alexa-app-server/deployments","created_at":"2017-01-05T16:32:08Z","updated_at":"2017-02-02T13:04:23Z","pushed_at":"2017-02-06T19:24:49Z","git_url":"git://github.com/dblock/alexa-app-server.git","ssh_url":"git@github.com:dblock/alexa-app-server.git","clone_url":"https://github.com/dblock/alexa-app-server.git","svn_url":"https://github.com/dblock/alexa-app-server","homepage":null,"size":277,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexa-js:master","ref":"master","sha":"16f7ad542a7dd54bd0814c497b9455a30ffa0b21","user":{"login":"alexa-js","id":25057028,"avatar_url":"https://avatars.githubusercontent.com/u/25057028?v=3","gravatar_id":"","url":"https://api.github.com/users/alexa-js","html_url":"https://github.com/alexa-js","followers_url":"https://api.github.com/users/alexa-js/followers","following_url":"https://api.github.com/users/alexa-js/following{/other_user}","gists_url":"https://api.github.com/users/alexa-js/gists{/gist_id}","starred_url":"https://api.github.com/users/alexa-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexa-js/subscriptions","organizations_url":"https://api.github.com/users/alexa-js/orgs","repos_url":"https://api.github.com/users/alexa-js/repos","events_url":"https://api.github.com/users/alexa-js/events{/privacy}","received_events_url":"https://api.github.com/users/alexa-js/received_events","type":"Organization","site_admin":false},"repo":{"id":35554410,"name":"alexa-app-server","full_name":"alexa-js/alexa-app-server","owner":{"login":"alexa-js","id":25057028,"avatar_url":"https://avatars.githubusercontent.com/u/25057028?v=3","gravatar_id":"","url":"https://api.github.com/users/alexa-js","html_url":"https://github.com/alexa-js","followers_url":"https://api.github.com/users/alexa-js/followers","following_url":"https://api.github.com/users/alexa-js/following{/other_user}","gists_url":"https://api.github.com/users/alexa-js/gists{/gist_id}","starred_url":"https://api.github.com/users/alexa-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexa-js/subscriptions","organizations_url":"https://api.github.com/users/alexa-js/orgs","repos_url":"https://api.github.com/users/alexa-js/repos","events_url":"https://api.github.com/users/alexa-js/events{/privacy}","received_events_url":"https://api.github.com/users/alexa-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alexa-js/alexa-app-server","description":"An Alexa app server for alexa-app.","fork":false,"url":"https://api.github.com/repos/alexa-js/alexa-app-server","forks_url":"https://api.github.com/repos/alexa-js/alexa-app-server/forks","keys_url":"https://api.github.com/repos/alexa-js/alexa-app-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexa-js/alexa-app-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexa-js/alexa-app-server/teams","hooks_url":"https://api.github.com/repos/alexa-js/alexa-app-server/hooks","issue_events_url":"https://api.github.com/repos/alexa-js/alexa-app-server/issues/events{/number}","events_url":"https://api.github.com/repos/alexa-js/alexa-app-server/events","assignees_url":"https://api.github.com/repos/alexa-js/alexa-app-server/assignees{/user}","branches_url":"https://api.github.com/repos/alexa-js/alexa-app-server/branches{/branch}","tags_url":"https://api.github.com/repos/alexa-js/alexa-app-server/tags","blobs_url":"https://api.github.com/repos/alexa-js/alexa-app-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexa-js/alexa-app-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexa-js/alexa-app-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexa-js/alexa-app-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexa-js/alexa-app-server/statuses/{sha}","languages_url":"https://api.github.com/repos/alexa-js/alexa-app-server/languages","stargazers_url":"https://api.github.com/repos/alexa-js/alexa-app-server/stargazers","contributors_url":"https://api.github.com/repos/alexa-js/alexa-app-server/contributors","subscribers_url":"https://api.github.com/repos/alexa-js/alexa-app-server/subscribers","subscription_url":"https://api.github.com/repos/alexa-js/alexa-app-server/subscription","commits_url":"https://api.github.com/repos/alexa-js/alexa-app-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexa-js/alexa-app-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexa-js/alexa-app-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexa-js/alexa-app-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexa-js/alexa-app-server/contents/{+path}","compare_url":"https://api.github.com/repos/alexa-js/alexa-app-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexa-js/alexa-app-server/merges","archive_url":"https://api.github.com/repos/alexa-js/alexa-app-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexa-js/alexa-app-server/downloads","issues_url":"https://api.github.com/repos/alexa-js/alexa-app-server/issues{/number}","pulls_url":"https://api.github.com/repos/alexa-js/alexa-app-server/pulls{/number}","milestones_url":"https://api.github.com/repos/alexa-js/alexa-app-server/milestones{/number}","notifications_url":"https://api.github.com/repos/alexa-js/alexa-app-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexa-js/alexa-app-server/labels{/name}","releases_url":"https://api.github.com/repos/alexa-js/alexa-app-server/releases{/id}","deployments_url":"https://api.github.com/repos/alexa-js/alexa-app-server/deployments","created_at":"2015-05-13T14:37:54Z","updated_at":"2017-02-06T19:08:57Z","pushed_at":"2017-02-06T19:24:51Z","git_url":"git://github.com/alexa-js/alexa-app-server.git","ssh_url":"git@github.com:alexa-js/alexa-app-server.git","clone_url":"https://github.com/alexa-js/alexa-app-server.git","svn_url":"https://github.com/alexa-js/alexa-app-server","homepage":"","size":303,"stargazers_count":197,"watchers_count":197,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":10,"forks":65,"open_issues":10,"watchers":197,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexa-js/alexa-app-server/pulls/72"},"html":{"href":"https://github.com/alexa-js/alexa-app-server/pull/72"},"issue":{"href":"https://api.github.com/repos/alexa-js/alexa-app-server/issues/72"},"comments":{"href":"https://api.github.com/repos/alexa-js/alexa-app-server/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/alexa-js/alexa-app-server/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/alexa-js/alexa-app-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexa-js/alexa-app-server/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/alexa-js/alexa-app-server/statuses/6a56d68970e2efe2953f14abf75c7000fbf1d97e"}}}}
{"actor":{"display_login":"tejashah88"}}