{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/151225513","pull_request_review_id":76899215,"id":151225513,"diff_hunk":"@@ -57,5 +60,17 @@ def testGraphUtil(self):\n     self.assertEqual(fused_graph_def.node[3].name, 'E')\n \n \n+class GetPlaceholdersTest(test.TestCase):\n+\n+  def test_get_placeholders(self):\n+    with ops.Graph().as_default() as g:\n+      ids = []\n+      for i in range(5):\n+        x = array_ops.placeholder(dtypes.float32)\n+        ids.append(x._id)\n+      result = graph_util.get_placeholders(g)\n+      result_ids = { i._id for i in result }","path":"tensorflow/contrib/framework/python/framework/graph_util_test.py","position":23,"original_position":23,"commit_id":"d34dbc3cf81659f62040fe936d6ec0a002e7dba7","original_commit_id":"d34dbc3cf81659f62040fe936d6ec0a002e7dba7","user":{"login":"inc0","id":697528,"avatar_url":"https://avatars3.githubusercontent.com/u/697528?v=4","gravatar_id":"","url":"https://api.github.com/users/inc0","html_url":"https://github.com/inc0","followers_url":"https://api.github.com/users/inc0/followers","following_url":"https://api.github.com/users/inc0/following{/other_user}","gists_url":"https://api.github.com/users/inc0/gists{/gist_id}","starred_url":"https://api.github.com/users/inc0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inc0/subscriptions","organizations_url":"https://api.github.com/users/inc0/orgs","repos_url":"https://api.github.com/users/inc0/repos","events_url":"https://api.github.com/users/inc0/events{/privacy}","received_events_url":"https://api.github.com/users/inc0/received_events","type":"User","site_admin":false},"body":"why do we cast this to set? if result would return same placeholder several times, that would still pass this test while being incorrect behavior (I assume..). If ordering doesn't matter we can use sorted function","created_at":"2017-11-15T19:19:11Z","updated_at":"2017-11-15T19:19:18Z","html_url":"https://github.com/tensorflow/tensorflow/pull/14541#discussion_r151225513","pull_request_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14541","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/151225513"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/14541#discussion_r151225513"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14541"}}},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14541","id":152455094,"html_url":"https://github.com/tensorflow/tensorflow/pull/14541","diff_url":"https://github.com/tensorflow/tensorflow/pull/14541.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/14541.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/14541","number":14541,"state":"open","locked":false,"title":"Add feature get_placeholders()","user":{"login":"qmick","id":6958746,"avatar_url":"https://avatars0.githubusercontent.com/u/6958746?v=4","gravatar_id":"","url":"https://api.github.com/users/qmick","html_url":"https://github.com/qmick","followers_url":"https://api.github.com/users/qmick/followers","following_url":"https://api.github.com/users/qmick/following{/other_user}","gists_url":"https://api.github.com/users/qmick/gists{/gist_id}","starred_url":"https://api.github.com/users/qmick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmick/subscriptions","organizations_url":"https://api.github.com/users/qmick/orgs","repos_url":"https://api.github.com/users/qmick/repos","events_url":"https://api.github.com/users/qmick/events{/privacy}","received_events_url":"https://api.github.com/users/qmick/received_events","type":"User","site_admin":false},"body":"Add a new API that can get all placeholders of a graph easily as #14374 requires.","created_at":"2017-11-14T09:42:58Z","updated_at":"2017-11-15T19:19:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6b43f8132af5274313b792767fc0cfdcc1eee59","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14541/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14541/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/14541/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/d34dbc3cf81659f62040fe936d6ec0a002e7dba7","head":{"label":"qmick:14374_get_placeholders","ref":"14374_get_placeholders","sha":"d34dbc3cf81659f62040fe936d6ec0a002e7dba7","user":{"login":"qmick","id":6958746,"avatar_url":"https://avatars0.githubusercontent.com/u/6958746?v=4","gravatar_id":"","url":"https://api.github.com/users/qmick","html_url":"https://github.com/qmick","followers_url":"https://api.github.com/users/qmick/followers","following_url":"https://api.github.com/users/qmick/following{/other_user}","gists_url":"https://api.github.com/users/qmick/gists{/gist_id}","starred_url":"https://api.github.com/users/qmick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmick/subscriptions","organizations_url":"https://api.github.com/users/qmick/orgs","repos_url":"https://api.github.com/users/qmick/repos","events_url":"https://api.github.com/users/qmick/events{/privacy}","received_events_url":"https://api.github.com/users/qmick/received_events","type":"User","site_admin":false},"repo":{"id":109993202,"name":"tensorflow","full_name":"qmick/tensorflow","owner":{"login":"qmick","id":6958746,"avatar_url":"https://avatars0.githubusercontent.com/u/6958746?v=4","gravatar_id":"","url":"https://api.github.com/users/qmick","html_url":"https://github.com/qmick","followers_url":"https://api.github.com/users/qmick/followers","following_url":"https://api.github.com/users/qmick/following{/other_user}","gists_url":"https://api.github.com/users/qmick/gists{/gist_id}","starred_url":"https://api.github.com/users/qmick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmick/subscriptions","organizations_url":"https://api.github.com/users/qmick/orgs","repos_url":"https://api.github.com/users/qmick/repos","events_url":"https://api.github.com/users/qmick/events{/privacy}","received_events_url":"https://api.github.com/users/qmick/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qmick/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/qmick/tensorflow","forks_url":"https://api.github.com/repos/qmick/tensorflow/forks","keys_url":"https://api.github.com/repos/qmick/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qmick/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qmick/tensorflow/teams","hooks_url":"https://api.github.com/repos/qmick/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/qmick/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/qmick/tensorflow/events","assignees_url":"https://api.github.com/repos/qmick/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/qmick/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/qmick/tensorflow/tags","blobs_url":"https://api.github.com/repos/qmick/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qmick/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qmick/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/qmick/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qmick/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/qmick/tensorflow/languages","stargazers_url":"https://api.github.com/repos/qmick/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/qmick/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/qmick/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/qmick/tensorflow/subscription","commits_url":"https://api.github.com/repos/qmick/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/qmick/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/qmick/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/qmick/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/qmick/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/qmick/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qmick/tensorflow/merges","archive_url":"https://api.github.com/repos/qmick/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qmick/tensorflow/downloads","issues_url":"https://api.github.com/repos/qmick/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/qmick/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/qmick/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/qmick/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qmick/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/qmick/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/qmick/tensorflow/deployments","created_at":"2017-11-08T15:24:37Z","updated_at":"2017-11-08T15:25:12Z","pushed_at":"2017-11-14T16:05:15Z","git_url":"git://github.com/qmick/tensorflow.git","ssh_url":"git@github.com:qmick/tensorflow.git","clone_url":"https://github.com/qmick/tensorflow.git","svn_url":"https://github.com/qmick/tensorflow","homepage":"http://tensorflow.org","size":134714,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"7497fca0ab2e87b0a9194f99d421c2e78b30cb17","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"name":"tensorflow","full_name":"tensorflow/tensorflow","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2017-11-15T19:16:19Z","pushed_at":"2017-11-15T18:17:04Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"http://tensorflow.org","size":135618,"stargazers_count":77383,"watchers_count":77383,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38184,"mirror_url":null,"archived":false,"open_issues_count":1372,"forks":38184,"open_issues":1372,"watchers":77383,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14541"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/14541"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/14541"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/14541/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14541/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/14541/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/d34dbc3cf81659f62040fe936d6ec0a002e7dba7"}},"author_association":"NONE"}}
{"actor":{"display_login":"inc0"}}