{"action":"created","comment":{"url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls/comments/136134326","pull_request_review_id":59616880,"id":136134326,"diff_hunk":"@@ -42,11 +57,20 @@ def startAllProcesses(self):\n         TODO: create a function that starts all processes or threads in \"self.T\" all at once.\n         \"\"\"\n \n+        for process in process_list:\n+            process_list[process].set = process_list[process].cmd\n+\n     def stopAllProcesses(self):\n         \"\"\"\n         TODO: create a function that stops all processes or threads in \"self.T\" all at once.\n         \"\"\"\n \n+        print (\"Shutting down\")\n+\n+        for process in process_list:\n+            process.kill()\n+            process.wait()","path":"ProcessManager.py","position":62,"original_position":62,"commit_id":"299942871ca4d37e150a8b4033172d66b169ae73","original_commit_id":"299942871ca4d37e150a8b4033172d66b169ae73","user":{"login":"ottopasuuna","id":5325233,"avatar_url":"https://avatars3.githubusercontent.com/u/5325233?v=4","gravatar_id":"","url":"https://api.github.com/users/ottopasuuna","html_url":"https://github.com/ottopasuuna","followers_url":"https://api.github.com/users/ottopasuuna/followers","following_url":"https://api.github.com/users/ottopasuuna/following{/other_user}","gists_url":"https://api.github.com/users/ottopasuuna/gists{/gist_id}","starred_url":"https://api.github.com/users/ottopasuuna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ottopasuuna/subscriptions","organizations_url":"https://api.github.com/users/ottopasuuna/orgs","repos_url":"https://api.github.com/users/ottopasuuna/repos","events_url":"https://api.github.com/users/ottopasuuna/events{/privacy}","received_events_url":"https://api.github.com/users/ottopasuuna/received_events","type":"User","site_admin":false},"body":"In this for loop, `process` is a `RoboProcess` which doesn't have methods `kill()` or `wait()`. If `RoboProcess` stores a `Popen` object, you'll have to access that and call its `kill()` and `wait()` methods.","created_at":"2017-08-30T17:18:48Z","updated_at":"2017-08-30T17:37:45Z","html_url":"https://github.com/UofSSpaceTeam/robocluster-manager/pull/7#discussion_r136134326","pull_request_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls/7","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls/comments/136134326"},"html":{"href":"https://github.com/UofSSpaceTeam/robocluster-manager/pull/7#discussion_r136134326"},"pull_request":{"href":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls/7","id":138352788,"html_url":"https://github.com/UofSSpaceTeam/robocluster-manager/pull/7","diff_url":"https://github.com/UofSSpaceTeam/robocluster-manager/pull/7.diff","patch_url":"https://github.com/UofSSpaceTeam/robocluster-manager/pull/7.patch","issue_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/issues/7","number":7,"state":"open","locked":false,"title":"Create stop start processes","user":{"login":"chameleon07","id":22333877,"avatar_url":"https://avatars0.githubusercontent.com/u/22333877?v=4","gravatar_id":"","url":"https://api.github.com/users/chameleon07","html_url":"https://github.com/chameleon07","followers_url":"https://api.github.com/users/chameleon07/followers","following_url":"https://api.github.com/users/chameleon07/following{/other_user}","gists_url":"https://api.github.com/users/chameleon07/gists{/gist_id}","starred_url":"https://api.github.com/users/chameleon07/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chameleon07/subscriptions","organizations_url":"https://api.github.com/users/chameleon07/orgs","repos_url":"https://api.github.com/users/chameleon07/repos","events_url":"https://api.github.com/users/chameleon07/events{/privacy}","received_events_url":"https://api.github.com/users/chameleon07/received_events","type":"User","site_admin":false},"body":"-added RoboProcesses class\r\n-created process_list dictionary\r\n-did createProcess function ","created_at":"2017-08-30T07:17:20Z","updated_at":"2017-08-30T17:37:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48b0d98efe40348cd6bd27f5931e94491e0963a5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls/7/commits","review_comments_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls/7/comments","review_comment_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/issues/7/comments","statuses_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/statuses/299942871ca4d37e150a8b4033172d66b169ae73","head":{"label":"UofSSpaceTeam:create-stop-start-processes","ref":"create-stop-start-processes","sha":"299942871ca4d37e150a8b4033172d66b169ae73","user":{"login":"UofSSpaceTeam","id":12777130,"avatar_url":"https://avatars1.githubusercontent.com/u/12777130?v=4","gravatar_id":"","url":"https://api.github.com/users/UofSSpaceTeam","html_url":"https://github.com/UofSSpaceTeam","followers_url":"https://api.github.com/users/UofSSpaceTeam/followers","following_url":"https://api.github.com/users/UofSSpaceTeam/following{/other_user}","gists_url":"https://api.github.com/users/UofSSpaceTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UofSSpaceTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UofSSpaceTeam/subscriptions","organizations_url":"https://api.github.com/users/UofSSpaceTeam/orgs","repos_url":"https://api.github.com/users/UofSSpaceTeam/repos","events_url":"https://api.github.com/users/UofSSpaceTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UofSSpaceTeam/received_events","type":"Organization","site_admin":false},"repo":{"id":99445970,"name":"robocluster-manager","full_name":"UofSSpaceTeam/robocluster-manager","owner":{"login":"UofSSpaceTeam","id":12777130,"avatar_url":"https://avatars1.githubusercontent.com/u/12777130?v=4","gravatar_id":"","url":"https://api.github.com/users/UofSSpaceTeam","html_url":"https://github.com/UofSSpaceTeam","followers_url":"https://api.github.com/users/UofSSpaceTeam/followers","following_url":"https://api.github.com/users/UofSSpaceTeam/following{/other_user}","gists_url":"https://api.github.com/users/UofSSpaceTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UofSSpaceTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UofSSpaceTeam/subscriptions","organizations_url":"https://api.github.com/users/UofSSpaceTeam/orgs","repos_url":"https://api.github.com/users/UofSSpaceTeam/repos","events_url":"https://api.github.com/users/UofSSpaceTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UofSSpaceTeam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UofSSpaceTeam/robocluster-manager","description":"Manages process for the robocluster framework","fork":false,"url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager","forks_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/forks","keys_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/teams","hooks_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/hooks","issue_events_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/issues/events{/number}","events_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/events","assignees_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/assignees{/user}","branches_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/branches{/branch}","tags_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/tags","blobs_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/languages","stargazers_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/stargazers","contributors_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/contributors","subscribers_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/subscribers","subscription_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/subscription","commits_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/contents/{+path}","compare_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/merges","archive_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/downloads","issues_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/issues{/number}","pulls_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/labels{/name}","releases_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/releases{/id}","deployments_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/deployments","created_at":"2017-08-05T20:22:48Z","updated_at":"2017-08-25T18:39:52Z","pushed_at":"2017-08-30T08:10:59Z","git_url":"git://github.com/UofSSpaceTeam/robocluster-manager.git","ssh_url":"git@github.com:UofSSpaceTeam/robocluster-manager.git","clone_url":"https://github.com/UofSSpaceTeam/robocluster-manager.git","svn_url":"https://github.com/UofSSpaceTeam/robocluster-manager","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"dev"}},"base":{"label":"UofSSpaceTeam:dev","ref":"dev","sha":"0967253cc7ac93e8e0cabd48a127ae741c38db28","user":{"login":"UofSSpaceTeam","id":12777130,"avatar_url":"https://avatars1.githubusercontent.com/u/12777130?v=4","gravatar_id":"","url":"https://api.github.com/users/UofSSpaceTeam","html_url":"https://github.com/UofSSpaceTeam","followers_url":"https://api.github.com/users/UofSSpaceTeam/followers","following_url":"https://api.github.com/users/UofSSpaceTeam/following{/other_user}","gists_url":"https://api.github.com/users/UofSSpaceTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UofSSpaceTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UofSSpaceTeam/subscriptions","organizations_url":"https://api.github.com/users/UofSSpaceTeam/orgs","repos_url":"https://api.github.com/users/UofSSpaceTeam/repos","events_url":"https://api.github.com/users/UofSSpaceTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UofSSpaceTeam/received_events","type":"Organization","site_admin":false},"repo":{"id":99445970,"name":"robocluster-manager","full_name":"UofSSpaceTeam/robocluster-manager","owner":{"login":"UofSSpaceTeam","id":12777130,"avatar_url":"https://avatars1.githubusercontent.com/u/12777130?v=4","gravatar_id":"","url":"https://api.github.com/users/UofSSpaceTeam","html_url":"https://github.com/UofSSpaceTeam","followers_url":"https://api.github.com/users/UofSSpaceTeam/followers","following_url":"https://api.github.com/users/UofSSpaceTeam/following{/other_user}","gists_url":"https://api.github.com/users/UofSSpaceTeam/gists{/gist_id}","starred_url":"https://api.github.com/users/UofSSpaceTeam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UofSSpaceTeam/subscriptions","organizations_url":"https://api.github.com/users/UofSSpaceTeam/orgs","repos_url":"https://api.github.com/users/UofSSpaceTeam/repos","events_url":"https://api.github.com/users/UofSSpaceTeam/events{/privacy}","received_events_url":"https://api.github.com/users/UofSSpaceTeam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UofSSpaceTeam/robocluster-manager","description":"Manages process for the robocluster framework","fork":false,"url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager","forks_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/forks","keys_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/teams","hooks_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/hooks","issue_events_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/issues/events{/number}","events_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/events","assignees_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/assignees{/user}","branches_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/branches{/branch}","tags_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/tags","blobs_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/languages","stargazers_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/stargazers","contributors_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/contributors","subscribers_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/subscribers","subscription_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/subscription","commits_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/contents/{+path}","compare_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/merges","archive_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/downloads","issues_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/issues{/number}","pulls_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/labels{/name}","releases_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/releases{/id}","deployments_url":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/deployments","created_at":"2017-08-05T20:22:48Z","updated_at":"2017-08-25T18:39:52Z","pushed_at":"2017-08-30T08:10:59Z","git_url":"git://github.com/UofSSpaceTeam/robocluster-manager.git","ssh_url":"git@github.com:UofSSpaceTeam/robocluster-manager.git","clone_url":"https://github.com/UofSSpaceTeam/robocluster-manager.git","svn_url":"https://github.com/UofSSpaceTeam/robocluster-manager","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":0,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls/7"},"html":{"href":"https://github.com/UofSSpaceTeam/robocluster-manager/pull/7"},"issue":{"href":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/issues/7"},"comments":{"href":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/UofSSpaceTeam/robocluster-manager/statuses/299942871ca4d37e150a8b4033172d66b169ae73"}},"author_association":"NONE"}}
{"actor":{"display_login":"ottopasuuna"}}