{"action":"created","issue":{"url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2785","repository_url":"https://api.github.com/repos/linuxkit/linuxkit","labels_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2785/labels{/name}","comments_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2785/comments","events_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2785/events","html_url":"https://github.com/linuxkit/linuxkit/pull/2785","id":278009882,"number":2785,"title":"pkg: rngd service support on AArch64","user":{"login":"arm64b","id":29669302,"avatar_url":"https://avatars1.githubusercontent.com/u/29669302?v=4","gravatar_id":"","url":"https://api.github.com/users/arm64b","html_url":"https://github.com/arm64b","followers_url":"https://api.github.com/users/arm64b/followers","following_url":"https://api.github.com/users/arm64b/following{/other_user}","gists_url":"https://api.github.com/users/arm64b/gists{/gist_id}","starred_url":"https://api.github.com/users/arm64b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arm64b/subscriptions","organizations_url":"https://api.github.com/users/arm64b/orgs","repos_url":"https://api.github.com/users/arm64b/repos","events_url":"https://api.github.com/users/arm64b/events{/privacy}","received_events_url":"https://api.github.com/users/arm64b/received_events","type":"User","site_admin":false},"labels":[{"id":572728714,"url":"https://api.github.com/repos/linuxkit/linuxkit/labels/status/0-triage","name":"status/0-triage","color":"eeeeee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2017-11-30T06:16:42Z","updated_at":"2017-12-06T13:36:44Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/2785","html_url":"https://github.com/linuxkit/linuxkit/pull/2785","diff_url":"https://github.com/linuxkit/linuxkit/pull/2785.diff","patch_url":"https://github.com/linuxkit/linuxkit/pull/2785.patch"},"body":"Enable the rngd service in case of a real hardware RNG\r\ndevice is available on AArch64 platform\r\n\r\nSigned-off-by: Dennis Chen <dennis.chen@arm.com>\r\n\r\n<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/linuxkit/linuxkit/blob/master/CONTRIBUTING.md\r\n\r\n** Make sure all your commits include a signature generated with `git commit -s` **\r\n\r\nFor additional information on our contributing process, read our contributing\r\nguide https://docs.docker.com/opensource/code/\r\n\r\nIf this is a bug fix, make sure your description includes \"fixes #xxxx\", or\r\n\"closes #xxxx\"\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n**- What I did**\r\nEnable the `rngd` service on AArch64 in case of a hardware RNG device available\r\n**- How I did it**\r\nCheck the `/dev/hwrng` and use it as the entropy source to feed the `/dev/random` if `/dev/hwrng` is the real character device of a RNG hardware.\r\n**- How to verify it**\r\n1. `linuxkit pkg build -org m1130 rngd/`\r\n2.  `docker run --privileged --rm --device /dev/hwrng m1130/rngd:842e5e8ece7934f0cab9fd0027b595ff3471e5b9-dirty`\r\n3. On an AArch64 platform which has a real RNG device such as Cavium ThunderX, we can see the `/sbin/rngd` is running inside the docker.\r\n**- Description for the changelog**\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog:\r\n-->\r\n\r\n\r\n**- A picture of a cute animal (not mandatory but encouraged)**\r\n![summit](https://user-images.githubusercontent.com/29669302/33416678-d033975e-d5d8-11e7-9c82-48a80afded73.jpg)\r\n"},"comment":{"url":"https://api.github.com/repos/linuxkit/linuxkit/issues/comments/349641552","html_url":"https://github.com/linuxkit/linuxkit/pull/2785#issuecomment-349641552","issue_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/2785","id":349641552,"user":{"login":"deitch","id":282526,"avatar_url":"https://avatars3.githubusercontent.com/u/282526?v=4","gravatar_id":"","url":"https://api.github.com/users/deitch","html_url":"https://github.com/deitch","followers_url":"https://api.github.com/users/deitch/followers","following_url":"https://api.github.com/users/deitch/following{/other_user}","gists_url":"https://api.github.com/users/deitch/gists{/gist_id}","starred_url":"https://api.github.com/users/deitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deitch/subscriptions","organizations_url":"https://api.github.com/users/deitch/orgs","repos_url":"https://api.github.com/users/deitch/repos","events_url":"https://api.github.com/users/deitch/events{/privacy}","received_events_url":"https://api.github.com/users/deitch/received_events","type":"User","site_admin":false},"created_at":"2017-12-06T13:36:44Z","updated_at":"2017-12-06T13:36:44Z","author_association":"COLLABORATOR","body":"Took some time to figure out what this is doing. I do have some comments, but they are mostly stylistic, so I will wait for the responses from the others involved.\r\n\r\nA few inline, though."}}
{"actor":{"display_login":"deitch"}}