{"action":"created","comment":{"url":"https://api.github.com/repos/Railcraft/Railcraft/pulls/comments/127616893","pull_request_review_id":50220473,"id":127616893,"diff_hunk":"@@ -87,9 +94,10 @@ public boolean matchesFilter(FluidStack fluidStack) {\n \n     @Override\n     public int fillInternal(FluidStack resource, boolean doFill) {\n-        if (!matchesFilter(resource))","path":"src/main/java/mods/railcraft/common/fluids/tanks/StandardTank.java","position":32,"original_position":32,"commit_id":"dafdadeeed64f42d86c6a695938b34f991afac92","original_commit_id":"0f239abf14b06146f3772b9d6dcd4c823b1bd283","user":{"login":"liach","id":7806504,"avatar_url":"https://avatars4.githubusercontent.com/u/7806504?v=4","gravatar_id":"","url":"https://api.github.com/users/liach","html_url":"https://github.com/liach","followers_url":"https://api.github.com/users/liach/followers","following_url":"https://api.github.com/users/liach/following{/other_user}","gists_url":"https://api.github.com/users/liach/gists{/gist_id}","starred_url":"https://api.github.com/users/liach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liach/subscriptions","organizations_url":"https://api.github.com/users/liach/orgs","repos_url":"https://api.github.com/users/liach/repos","events_url":"https://api.github.com/users/liach/events{/privacy}","received_events_url":"https://api.github.com/users/liach/received_events","type":"User","site_admin":false},"body":"This check is not for `fillInternal` according to the superclass' javadoc. It is for `fill` only, and you put it in the wrong spot.","created_at":"2017-07-16T21:12:27Z","updated_at":"2017-07-16T21:12:27Z","html_url":"https://github.com/Railcraft/Railcraft/pull/1285#discussion_r127616893","pull_request_url":"https://api.github.com/repos/Railcraft/Railcraft/pulls/1285","_links":{"self":{"href":"https://api.github.com/repos/Railcraft/Railcraft/pulls/comments/127616893"},"html":{"href":"https://github.com/Railcraft/Railcraft/pull/1285#discussion_r127616893"},"pull_request":{"href":"https://api.github.com/repos/Railcraft/Railcraft/pulls/1285"}}},"pull_request":{"url":"https://api.github.com/repos/Railcraft/Railcraft/pulls/1285","id":130765808,"html_url":"https://github.com/Railcraft/Railcraft/pull/1285","diff_url":"https://github.com/Railcraft/Railcraft/pull/1285.diff","patch_url":"https://github.com/Railcraft/Railcraft/pull/1285.patch","issue_url":"https://api.github.com/repos/Railcraft/Railcraft/issues/1285","number":1285,"state":"open","locked":false,"title":"Fluid and Tank cart fixes","user":{"login":"liach","id":7806504,"avatar_url":"https://avatars4.githubusercontent.com/u/7806504?v=4","gravatar_id":"","url":"https://api.github.com/users/liach","html_url":"https://github.com/liach","followers_url":"https://api.github.com/users/liach/followers","following_url":"https://api.github.com/users/liach/following{/other_user}","gists_url":"https://api.github.com/users/liach/gists{/gist_id}","starred_url":"https://api.github.com/users/liach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liach/subscriptions","organizations_url":"https://api.github.com/users/liach/orgs","repos_url":"https://api.github.com/users/liach/repos","events_url":"https://api.github.com/users/liach/events{/privacy}","received_events_url":"https://api.github.com/users/liach/received_events","type":"User","site_admin":false},"body":"Fixes #1194\r\nFixes #1248\r\nFixes #1270\r\nNow both 3 slot and 2 slot systems work\r\nTested on my side","created_at":"2017-07-16T20:52:48Z","updated_at":"2017-07-16T21:12:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5634e214d688241527f82b22ab8b1324f85e5fab","assignee":{"login":"liach","id":7806504,"avatar_url":"https://avatars4.githubusercontent.com/u/7806504?v=4","gravatar_id":"","url":"https://api.github.com/users/liach","html_url":"https://github.com/liach","followers_url":"https://api.github.com/users/liach/followers","following_url":"https://api.github.com/users/liach/following{/other_user}","gists_url":"https://api.github.com/users/liach/gists{/gist_id}","starred_url":"https://api.github.com/users/liach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liach/subscriptions","organizations_url":"https://api.github.com/users/liach/orgs","repos_url":"https://api.github.com/users/liach/repos","events_url":"https://api.github.com/users/liach/events{/privacy}","received_events_url":"https://api.github.com/users/liach/received_events","type":"User","site_admin":false},"assignees":[{"login":"liach","id":7806504,"avatar_url":"https://avatars4.githubusercontent.com/u/7806504?v=4","gravatar_id":"","url":"https://api.github.com/users/liach","html_url":"https://github.com/liach","followers_url":"https://api.github.com/users/liach/followers","following_url":"https://api.github.com/users/liach/following{/other_user}","gists_url":"https://api.github.com/users/liach/gists{/gist_id}","starred_url":"https://api.github.com/users/liach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liach/subscriptions","organizations_url":"https://api.github.com/users/liach/orgs","repos_url":"https://api.github.com/users/liach/repos","events_url":"https://api.github.com/users/liach/events{/privacy}","received_events_url":"https://api.github.com/users/liach/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/Railcraft/Railcraft/milestones/19","html_url":"https://github.com/Railcraft/Railcraft/milestone/19","labels_url":"https://api.github.com/repos/Railcraft/Railcraft/milestones/19/labels","id":2408181,"number":19,"title":"Railcraft 10.2.0 - Signals, Charge, and Worldspikes","description":"","creator":{"login":"CovertJaguar","id":1521970,"avatar_url":"https://avatars4.githubusercontent.com/u/1521970?v=4","gravatar_id":"","url":"https://api.github.com/users/CovertJaguar","html_url":"https://github.com/CovertJaguar","followers_url":"https://api.github.com/users/CovertJaguar/followers","following_url":"https://api.github.com/users/CovertJaguar/following{/other_user}","gists_url":"https://api.github.com/users/CovertJaguar/gists{/gist_id}","starred_url":"https://api.github.com/users/CovertJaguar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CovertJaguar/subscriptions","organizations_url":"https://api.github.com/users/CovertJaguar/orgs","repos_url":"https://api.github.com/users/CovertJaguar/repos","events_url":"https://api.github.com/users/CovertJaguar/events{/privacy}","received_events_url":"https://api.github.com/users/CovertJaguar/received_events","type":"User","site_admin":false},"open_issues":29,"closed_issues":58,"state":"open","created_at":"2017-03-24T00:57:22Z","updated_at":"2017-07-16T20:52:48Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Railcraft/Railcraft/pulls/1285/commits","review_comments_url":"https://api.github.com/repos/Railcraft/Railcraft/pulls/1285/comments","review_comment_url":"https://api.github.com/repos/Railcraft/Railcraft/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Railcraft/Railcraft/issues/1285/comments","statuses_url":"https://api.github.com/repos/Railcraft/Railcraft/statuses/dafdadeeed64f42d86c6a695938b34f991afac92","head":{"label":"Railcraft:fix/fluids","ref":"fix/fluids","sha":"dafdadeeed64f42d86c6a695938b34f991afac92","user":{"login":"Railcraft","id":28769941,"avatar_url":"https://avatars7.githubusercontent.com/u/28769941?v=4","gravatar_id":"","url":"https://api.github.com/users/Railcraft","html_url":"https://github.com/Railcraft","followers_url":"https://api.github.com/users/Railcraft/followers","following_url":"https://api.github.com/users/Railcraft/following{/other_user}","gists_url":"https://api.github.com/users/Railcraft/gists{/gist_id}","starred_url":"https://api.github.com/users/Railcraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Railcraft/subscriptions","organizations_url":"https://api.github.com/users/Railcraft/orgs","repos_url":"https://api.github.com/users/Railcraft/repos","events_url":"https://api.github.com/users/Railcraft/events{/privacy}","received_events_url":"https://api.github.com/users/Railcraft/received_events","type":"Organization","site_admin":false},"repo":{"id":7177096,"name":"Railcraft","full_name":"Railcraft/Railcraft","owner":{"login":"Railcraft","id":28769941,"avatar_url":"https://avatars7.githubusercontent.com/u/28769941?v=4","gravatar_id":"","url":"https://api.github.com/users/Railcraft","html_url":"https://github.com/Railcraft","followers_url":"https://api.github.com/users/Railcraft/followers","following_url":"https://api.github.com/users/Railcraft/following{/other_user}","gists_url":"https://api.github.com/users/Railcraft/gists{/gist_id}","starred_url":"https://api.github.com/users/Railcraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Railcraft/subscriptions","organizations_url":"https://api.github.com/users/Railcraft/orgs","repos_url":"https://api.github.com/users/Railcraft/repos","events_url":"https://api.github.com/users/Railcraft/events{/privacy}","received_events_url":"https://api.github.com/users/Railcraft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Railcraft/Railcraft","description":"The Railcraft Mod for Minecraft, source and development.","fork":false,"url":"https://api.github.com/repos/Railcraft/Railcraft","forks_url":"https://api.github.com/repos/Railcraft/Railcraft/forks","keys_url":"https://api.github.com/repos/Railcraft/Railcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Railcraft/Railcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Railcraft/Railcraft/teams","hooks_url":"https://api.github.com/repos/Railcraft/Railcraft/hooks","issue_events_url":"https://api.github.com/repos/Railcraft/Railcraft/issues/events{/number}","events_url":"https://api.github.com/repos/Railcraft/Railcraft/events","assignees_url":"https://api.github.com/repos/Railcraft/Railcraft/assignees{/user}","branches_url":"https://api.github.com/repos/Railcraft/Railcraft/branches{/branch}","tags_url":"https://api.github.com/repos/Railcraft/Railcraft/tags","blobs_url":"https://api.github.com/repos/Railcraft/Railcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Railcraft/Railcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Railcraft/Railcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/Railcraft/Railcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Railcraft/Railcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/Railcraft/Railcraft/languages","stargazers_url":"https://api.github.com/repos/Railcraft/Railcraft/stargazers","contributors_url":"https://api.github.com/repos/Railcraft/Railcraft/contributors","subscribers_url":"https://api.github.com/repos/Railcraft/Railcraft/subscribers","subscription_url":"https://api.github.com/repos/Railcraft/Railcraft/subscription","commits_url":"https://api.github.com/repos/Railcraft/Railcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/Railcraft/Railcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/Railcraft/Railcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/Railcraft/Railcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/Railcraft/Railcraft/contents/{+path}","compare_url":"https://api.github.com/repos/Railcraft/Railcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Railcraft/Railcraft/merges","archive_url":"https://api.github.com/repos/Railcraft/Railcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Railcraft/Railcraft/downloads","issues_url":"https://api.github.com/repos/Railcraft/Railcraft/issues{/number}","pulls_url":"https://api.github.com/repos/Railcraft/Railcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/Railcraft/Railcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/Railcraft/Railcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Railcraft/Railcraft/labels{/name}","releases_url":"https://api.github.com/repos/Railcraft/Railcraft/releases{/id}","deployments_url":"https://api.github.com/repos/Railcraft/Railcraft/deployments","created_at":"2012-12-15T07:42:00Z","updated_at":"2017-07-16T11:25:10Z","pushed_at":"2017-07-16T21:11:55Z","git_url":"git://github.com/Railcraft/Railcraft.git","ssh_url":"git@github.com:Railcraft/Railcraft.git","clone_url":"https://github.com/Railcraft/Railcraft.git","svn_url":"https://github.com/Railcraft/Railcraft","homepage":"http://www.railcraft.info/","size":9657,"stargazers_count":250,"watchers_count":250,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":119,"forks":93,"open_issues":119,"watchers":250,"default_branch":"mc-1.10.2"}},"base":{"label":"Railcraft:mc-1.10.2","ref":"mc-1.10.2","sha":"882633a6898e2db2dae70b70efca5b8a3ad4af46","user":{"login":"Railcraft","id":28769941,"avatar_url":"https://avatars7.githubusercontent.com/u/28769941?v=4","gravatar_id":"","url":"https://api.github.com/users/Railcraft","html_url":"https://github.com/Railcraft","followers_url":"https://api.github.com/users/Railcraft/followers","following_url":"https://api.github.com/users/Railcraft/following{/other_user}","gists_url":"https://api.github.com/users/Railcraft/gists{/gist_id}","starred_url":"https://api.github.com/users/Railcraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Railcraft/subscriptions","organizations_url":"https://api.github.com/users/Railcraft/orgs","repos_url":"https://api.github.com/users/Railcraft/repos","events_url":"https://api.github.com/users/Railcraft/events{/privacy}","received_events_url":"https://api.github.com/users/Railcraft/received_events","type":"Organization","site_admin":false},"repo":{"id":7177096,"name":"Railcraft","full_name":"Railcraft/Railcraft","owner":{"login":"Railcraft","id":28769941,"avatar_url":"https://avatars7.githubusercontent.com/u/28769941?v=4","gravatar_id":"","url":"https://api.github.com/users/Railcraft","html_url":"https://github.com/Railcraft","followers_url":"https://api.github.com/users/Railcraft/followers","following_url":"https://api.github.com/users/Railcraft/following{/other_user}","gists_url":"https://api.github.com/users/Railcraft/gists{/gist_id}","starred_url":"https://api.github.com/users/Railcraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Railcraft/subscriptions","organizations_url":"https://api.github.com/users/Railcraft/orgs","repos_url":"https://api.github.com/users/Railcraft/repos","events_url":"https://api.github.com/users/Railcraft/events{/privacy}","received_events_url":"https://api.github.com/users/Railcraft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Railcraft/Railcraft","description":"The Railcraft Mod for Minecraft, source and development.","fork":false,"url":"https://api.github.com/repos/Railcraft/Railcraft","forks_url":"https://api.github.com/repos/Railcraft/Railcraft/forks","keys_url":"https://api.github.com/repos/Railcraft/Railcraft/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Railcraft/Railcraft/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Railcraft/Railcraft/teams","hooks_url":"https://api.github.com/repos/Railcraft/Railcraft/hooks","issue_events_url":"https://api.github.com/repos/Railcraft/Railcraft/issues/events{/number}","events_url":"https://api.github.com/repos/Railcraft/Railcraft/events","assignees_url":"https://api.github.com/repos/Railcraft/Railcraft/assignees{/user}","branches_url":"https://api.github.com/repos/Railcraft/Railcraft/branches{/branch}","tags_url":"https://api.github.com/repos/Railcraft/Railcraft/tags","blobs_url":"https://api.github.com/repos/Railcraft/Railcraft/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Railcraft/Railcraft/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Railcraft/Railcraft/git/refs{/sha}","trees_url":"https://api.github.com/repos/Railcraft/Railcraft/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Railcraft/Railcraft/statuses/{sha}","languages_url":"https://api.github.com/repos/Railcraft/Railcraft/languages","stargazers_url":"https://api.github.com/repos/Railcraft/Railcraft/stargazers","contributors_url":"https://api.github.com/repos/Railcraft/Railcraft/contributors","subscribers_url":"https://api.github.com/repos/Railcraft/Railcraft/subscribers","subscription_url":"https://api.github.com/repos/Railcraft/Railcraft/subscription","commits_url":"https://api.github.com/repos/Railcraft/Railcraft/commits{/sha}","git_commits_url":"https://api.github.com/repos/Railcraft/Railcraft/git/commits{/sha}","comments_url":"https://api.github.com/repos/Railcraft/Railcraft/comments{/number}","issue_comment_url":"https://api.github.com/repos/Railcraft/Railcraft/issues/comments{/number}","contents_url":"https://api.github.com/repos/Railcraft/Railcraft/contents/{+path}","compare_url":"https://api.github.com/repos/Railcraft/Railcraft/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Railcraft/Railcraft/merges","archive_url":"https://api.github.com/repos/Railcraft/Railcraft/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Railcraft/Railcraft/downloads","issues_url":"https://api.github.com/repos/Railcraft/Railcraft/issues{/number}","pulls_url":"https://api.github.com/repos/Railcraft/Railcraft/pulls{/number}","milestones_url":"https://api.github.com/repos/Railcraft/Railcraft/milestones{/number}","notifications_url":"https://api.github.com/repos/Railcraft/Railcraft/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Railcraft/Railcraft/labels{/name}","releases_url":"https://api.github.com/repos/Railcraft/Railcraft/releases{/id}","deployments_url":"https://api.github.com/repos/Railcraft/Railcraft/deployments","created_at":"2012-12-15T07:42:00Z","updated_at":"2017-07-16T11:25:10Z","pushed_at":"2017-07-16T21:11:55Z","git_url":"git://github.com/Railcraft/Railcraft.git","ssh_url":"git@github.com:Railcraft/Railcraft.git","clone_url":"https://github.com/Railcraft/Railcraft.git","svn_url":"https://github.com/Railcraft/Railcraft","homepage":"http://www.railcraft.info/","size":9657,"stargazers_count":250,"watchers_count":250,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":119,"forks":93,"open_issues":119,"watchers":250,"default_branch":"mc-1.10.2"}},"_links":{"self":{"href":"https://api.github.com/repos/Railcraft/Railcraft/pulls/1285"},"html":{"href":"https://github.com/Railcraft/Railcraft/pull/1285"},"issue":{"href":"https://api.github.com/repos/Railcraft/Railcraft/issues/1285"},"comments":{"href":"https://api.github.com/repos/Railcraft/Railcraft/issues/1285/comments"},"review_comments":{"href":"https://api.github.com/repos/Railcraft/Railcraft/pulls/1285/comments"},"review_comment":{"href":"https://api.github.com/repos/Railcraft/Railcraft/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Railcraft/Railcraft/pulls/1285/commits"},"statuses":{"href":"https://api.github.com/repos/Railcraft/Railcraft/statuses/dafdadeeed64f42d86c6a695938b34f991afac92"}}}}
{"actor":{"display_login":"liach"}}