{"action":"created","comment":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments/97310443","pull_request_review_id":17914833,"id":97310443,"diff_hunk":"@@ -0,0 +1,30 @@\n+#include \"TrackingGeoSvc.h\"\n+\n+// ACTS\n+#include \"ACTS/Plugins/DD4hepPlugins/ConvertDD4hepDetector.hpp\"\n+#include \"ACTS/Detector/TrackingGeometry.hpp\"\n+\n+\n+DECLARE_SERVICE_FACTORY(TrackingGeoSvc)\n+\n+TrackingGeoSvc::TrackingGeoSvc(const std::string& name, ISvcLocator* svc)\n+    : base_class(name, svc), m_trackingGeo(nullptr) {}\n+\n+TrackingGeoSvc::~TrackingGeoSvc() {}\n+\n+StatusCode TrackingGeoSvc::initialize() {\n+  if (Service::initialize().isFailure()) {\n+    error() << \"Unable to initialize Service()\" << endmsg;\n+    return StatusCode::FAILURE;\n+  }\n+  m_geoSvc = service(\"GeoSvc\");\n+  if (!m_geoSvc) {\n+    error() << \"Unable to locate Geometry Service\" << endmsg;\n+    return StatusCode::FAILURE;\n+  }\n+  m_trackingGeo = std::move(Acts::convertDD4hepDetector(\n+        m_geoSvc->getDD4HepGeo(),Acts::Logging::VERBOSE, Acts::equidistant, Acts::equidistant, Acts::equidistant));","path":"Detector/DetComponents/src/TrackingGeoSvc.cpp","position":26,"original_position":26,"commit_id":"b65c7c27a5e0b7f071d8b72fb87515a90be75999","original_commit_id":"b65c7c27a5e0b7f071d8b72fb87515a90be75999","user":{"login":"jlingema","id":5601483,"avatar_url":"https://avatars.githubusercontent.com/u/5601483?v=3","gravatar_id":"","url":"https://api.github.com/users/jlingema","html_url":"https://github.com/jlingema","followers_url":"https://api.github.com/users/jlingema/followers","following_url":"https://api.github.com/users/jlingema/following{/other_user}","gists_url":"https://api.github.com/users/jlingema/gists{/gist_id}","starred_url":"https://api.github.com/users/jlingema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlingema/subscriptions","organizations_url":"https://api.github.com/users/jlingema/orgs","repos_url":"https://api.github.com/users/jlingema/repos","events_url":"https://api.github.com/users/jlingema/events{/privacy}","received_events_url":"https://api.github.com/users/jlingema/received_events","type":"User","site_admin":false},"body":"Yes, as stated above, while we use the Acts logging here, we should at least forward the message level.","created_at":"2017-01-23T12:46:05Z","updated_at":"2017-01-23T12:46:05Z","html_url":"https://github.com/HEP-FCC/FCCSW/pull/119#discussion_r97310443","pull_request_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/119","_links":{"self":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments/97310443"},"html":{"href":"https://github.com/HEP-FCC/FCCSW/pull/119#discussion_r97310443"},"pull_request":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/119"}}},"pull_request":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/119","id":78284975,"html_url":"https://github.com/HEP-FCC/FCCSW/pull/119","diff_url":"https://github.com/HEP-FCC/FCCSW/pull/119.diff","patch_url":"https://github.com/HEP-FCC/FCCSW/pull/119.patch","issue_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/119","number":119,"state":"open","locked":false,"title":"[WIP] ACTS Integration (Tracking Geometry Service)","user":{"login":"vvolkl","id":5057884,"avatar_url":"https://avatars.githubusercontent.com/u/5057884?v=3","gravatar_id":"","url":"https://api.github.com/users/vvolkl","html_url":"https://github.com/vvolkl","followers_url":"https://api.github.com/users/vvolkl/followers","following_url":"https://api.github.com/users/vvolkl/following{/other_user}","gists_url":"https://api.github.com/users/vvolkl/gists{/gist_id}","starred_url":"https://api.github.com/users/vvolkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvolkl/subscriptions","organizations_url":"https://api.github.com/users/vvolkl/orgs","repos_url":"https://api.github.com/users/vvolkl/repos","events_url":"https://api.github.com/users/vvolkl/events{/privacy}","received_events_url":"https://api.github.com/users/vvolkl/received_events","type":"User","site_admin":false},"body":"- @jhrdinka's Tracking Geometry service based on the ACTS DD4hep plugin\r\n- TrkGeoToGDMLDump Service for validation\r\n- Algorithm that wraps current ACTS fitter example\r\n- see https://gitlab.cern.ch/acts/a-common-tracking-sw/wikis/home for details\r\n- requires an ACTS installation in `CMAKE_PREFIX_PATH` and a C++14 installation of DD4hep\r\n\r\nSeeding and Hit conversion in future PR.\r\n","created_at":"2016-07-21T09:34:14Z","updated_at":"2017-01-23T12:46:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dee63290b9b04b901bd48d874c07354b5536f4a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/119/commits","review_comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/119/comments","review_comment_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/119/comments","statuses_url":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/b65c7c27a5e0b7f071d8b72fb87515a90be75999","head":{"label":"vvolkl:acts","ref":"acts","sha":"b65c7c27a5e0b7f071d8b72fb87515a90be75999","user":{"login":"vvolkl","id":5057884,"avatar_url":"https://avatars.githubusercontent.com/u/5057884?v=3","gravatar_id":"","url":"https://api.github.com/users/vvolkl","html_url":"https://github.com/vvolkl","followers_url":"https://api.github.com/users/vvolkl/followers","following_url":"https://api.github.com/users/vvolkl/following{/other_user}","gists_url":"https://api.github.com/users/vvolkl/gists{/gist_id}","starred_url":"https://api.github.com/users/vvolkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvolkl/subscriptions","organizations_url":"https://api.github.com/users/vvolkl/orgs","repos_url":"https://api.github.com/users/vvolkl/repos","events_url":"https://api.github.com/users/vvolkl/events{/privacy}","received_events_url":"https://api.github.com/users/vvolkl/received_events","type":"User","site_admin":false},"repo":{"id":43544566,"name":"FCCSW","full_name":"vvolkl/FCCSW","owner":{"login":"vvolkl","id":5057884,"avatar_url":"https://avatars.githubusercontent.com/u/5057884?v=3","gravatar_id":"","url":"https://api.github.com/users/vvolkl","html_url":"https://github.com/vvolkl","followers_url":"https://api.github.com/users/vvolkl/followers","following_url":"https://api.github.com/users/vvolkl/following{/other_user}","gists_url":"https://api.github.com/users/vvolkl/gists{/gist_id}","starred_url":"https://api.github.com/users/vvolkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vvolkl/subscriptions","organizations_url":"https://api.github.com/users/vvolkl/orgs","repos_url":"https://api.github.com/users/vvolkl/repos","events_url":"https://api.github.com/users/vvolkl/events{/privacy}","received_events_url":"https://api.github.com/users/vvolkl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vvolkl/FCCSW","description":"FCC software, common to FCC-hh, -ee, and -eh.","fork":true,"url":"https://api.github.com/repos/vvolkl/FCCSW","forks_url":"https://api.github.com/repos/vvolkl/FCCSW/forks","keys_url":"https://api.github.com/repos/vvolkl/FCCSW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vvolkl/FCCSW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vvolkl/FCCSW/teams","hooks_url":"https://api.github.com/repos/vvolkl/FCCSW/hooks","issue_events_url":"https://api.github.com/repos/vvolkl/FCCSW/issues/events{/number}","events_url":"https://api.github.com/repos/vvolkl/FCCSW/events","assignees_url":"https://api.github.com/repos/vvolkl/FCCSW/assignees{/user}","branches_url":"https://api.github.com/repos/vvolkl/FCCSW/branches{/branch}","tags_url":"https://api.github.com/repos/vvolkl/FCCSW/tags","blobs_url":"https://api.github.com/repos/vvolkl/FCCSW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vvolkl/FCCSW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vvolkl/FCCSW/git/refs{/sha}","trees_url":"https://api.github.com/repos/vvolkl/FCCSW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vvolkl/FCCSW/statuses/{sha}","languages_url":"https://api.github.com/repos/vvolkl/FCCSW/languages","stargazers_url":"https://api.github.com/repos/vvolkl/FCCSW/stargazers","contributors_url":"https://api.github.com/repos/vvolkl/FCCSW/contributors","subscribers_url":"https://api.github.com/repos/vvolkl/FCCSW/subscribers","subscription_url":"https://api.github.com/repos/vvolkl/FCCSW/subscription","commits_url":"https://api.github.com/repos/vvolkl/FCCSW/commits{/sha}","git_commits_url":"https://api.github.com/repos/vvolkl/FCCSW/git/commits{/sha}","comments_url":"https://api.github.com/repos/vvolkl/FCCSW/comments{/number}","issue_comment_url":"https://api.github.com/repos/vvolkl/FCCSW/issues/comments{/number}","contents_url":"https://api.github.com/repos/vvolkl/FCCSW/contents/{+path}","compare_url":"https://api.github.com/repos/vvolkl/FCCSW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vvolkl/FCCSW/merges","archive_url":"https://api.github.com/repos/vvolkl/FCCSW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vvolkl/FCCSW/downloads","issues_url":"https://api.github.com/repos/vvolkl/FCCSW/issues{/number}","pulls_url":"https://api.github.com/repos/vvolkl/FCCSW/pulls{/number}","milestones_url":"https://api.github.com/repos/vvolkl/FCCSW/milestones{/number}","notifications_url":"https://api.github.com/repos/vvolkl/FCCSW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vvolkl/FCCSW/labels{/name}","releases_url":"https://api.github.com/repos/vvolkl/FCCSW/releases{/id}","deployments_url":"https://api.github.com/repos/vvolkl/FCCSW/deployments","created_at":"2015-10-02T09:16:24Z","updated_at":"2016-01-25T06:00:12Z","pushed_at":"2017-01-22T23:03:00Z","git_url":"git://github.com/vvolkl/FCCSW.git","ssh_url":"git@github.com:vvolkl/FCCSW.git","clone_url":"https://github.com/vvolkl/FCCSW.git","svn_url":"https://github.com/vvolkl/FCCSW","homepage":null,"size":181974,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HEP-FCC:master","ref":"master","sha":"3318c41655ca08c078ef470e9e0c927463cdc670","user":{"login":"HEP-FCC","id":8003187,"avatar_url":"https://avatars.githubusercontent.com/u/8003187?v=3","gravatar_id":"","url":"https://api.github.com/users/HEP-FCC","html_url":"https://github.com/HEP-FCC","followers_url":"https://api.github.com/users/HEP-FCC/followers","following_url":"https://api.github.com/users/HEP-FCC/following{/other_user}","gists_url":"https://api.github.com/users/HEP-FCC/gists{/gist_id}","starred_url":"https://api.github.com/users/HEP-FCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEP-FCC/subscriptions","organizations_url":"https://api.github.com/users/HEP-FCC/orgs","repos_url":"https://api.github.com/users/HEP-FCC/repos","events_url":"https://api.github.com/users/HEP-FCC/events{/privacy}","received_events_url":"https://api.github.com/users/HEP-FCC/received_events","type":"Organization","site_admin":false},"repo":{"id":21388221,"name":"FCCSW","full_name":"HEP-FCC/FCCSW","owner":{"login":"HEP-FCC","id":8003187,"avatar_url":"https://avatars.githubusercontent.com/u/8003187?v=3","gravatar_id":"","url":"https://api.github.com/users/HEP-FCC","html_url":"https://github.com/HEP-FCC","followers_url":"https://api.github.com/users/HEP-FCC/followers","following_url":"https://api.github.com/users/HEP-FCC/following{/other_user}","gists_url":"https://api.github.com/users/HEP-FCC/gists{/gist_id}","starred_url":"https://api.github.com/users/HEP-FCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEP-FCC/subscriptions","organizations_url":"https://api.github.com/users/HEP-FCC/orgs","repos_url":"https://api.github.com/users/HEP-FCC/repos","events_url":"https://api.github.com/users/HEP-FCC/events{/privacy}","received_events_url":"https://api.github.com/users/HEP-FCC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HEP-FCC/FCCSW","description":"FCC software, common to FCC-hh, -ee, and -eh.","fork":false,"url":"https://api.github.com/repos/HEP-FCC/FCCSW","forks_url":"https://api.github.com/repos/HEP-FCC/FCCSW/forks","keys_url":"https://api.github.com/repos/HEP-FCC/FCCSW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HEP-FCC/FCCSW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HEP-FCC/FCCSW/teams","hooks_url":"https://api.github.com/repos/HEP-FCC/FCCSW/hooks","issue_events_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/events{/number}","events_url":"https://api.github.com/repos/HEP-FCC/FCCSW/events","assignees_url":"https://api.github.com/repos/HEP-FCC/FCCSW/assignees{/user}","branches_url":"https://api.github.com/repos/HEP-FCC/FCCSW/branches{/branch}","tags_url":"https://api.github.com/repos/HEP-FCC/FCCSW/tags","blobs_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/refs{/sha}","trees_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/{sha}","languages_url":"https://api.github.com/repos/HEP-FCC/FCCSW/languages","stargazers_url":"https://api.github.com/repos/HEP-FCC/FCCSW/stargazers","contributors_url":"https://api.github.com/repos/HEP-FCC/FCCSW/contributors","subscribers_url":"https://api.github.com/repos/HEP-FCC/FCCSW/subscribers","subscription_url":"https://api.github.com/repos/HEP-FCC/FCCSW/subscription","commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/commits{/sha}","git_commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/commits{/sha}","comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/comments{/number}","issue_comment_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/comments{/number}","contents_url":"https://api.github.com/repos/HEP-FCC/FCCSW/contents/{+path}","compare_url":"https://api.github.com/repos/HEP-FCC/FCCSW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HEP-FCC/FCCSW/merges","archive_url":"https://api.github.com/repos/HEP-FCC/FCCSW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HEP-FCC/FCCSW/downloads","issues_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues{/number}","pulls_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls{/number}","milestones_url":"https://api.github.com/repos/HEP-FCC/FCCSW/milestones{/number}","notifications_url":"https://api.github.com/repos/HEP-FCC/FCCSW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HEP-FCC/FCCSW/labels{/name}","releases_url":"https://api.github.com/repos/HEP-FCC/FCCSW/releases{/id}","deployments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/deployments","created_at":"2014-07-01T13:16:22Z","updated_at":"2016-10-31T10:39:32Z","pushed_at":"2017-01-23T12:33:57Z","git_url":"git://github.com/HEP-FCC/FCCSW.git","ssh_url":"git@github.com:HEP-FCC/FCCSW.git","clone_url":"https://github.com/HEP-FCC/FCCSW.git","svn_url":"https://github.com/HEP-FCC/FCCSW","homepage":"http://fccsw.web.cern.ch","size":175117,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":5,"forks":66,"open_issues":5,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/119"},"html":{"href":"https://github.com/HEP-FCC/FCCSW/pull/119"},"issue":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/119"},"comments":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/b65c7c27a5e0b7f071d8b72fb87515a90be75999"}}}}
{"actor":{"display_login":"jlingema"}}