{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/autorest/pulls/comments/122776211","pull_request_review_id":44921156,"id":122776211,"diff_hunk":"@@ -19,12 +19,16 @@ public class RuleContext\n         /// Initializes a top level context for rules\n         /// </summary>\n         /// <param name=\"root\"></param>\n-        public RuleContext(ServiceDefinition root, Uri file) : this(null)\n+        public RuleContext(ServiceDefinition root, Uri file, ServiceDefinitionMetadata metadata) : this(null)\n         {\n             this.Root = root;\n             this.Value = root;\n             this.File = file;\n-            PopulateResourceTypes(root);\n+            if (metadata.ServiceDefinitionDocumentType == ServiceDefinitionDocumentType.ARM)","path":"src/modeler/AutoRest.Swagger/Validation/Core/RuleContext.cs","position":null,"original_position":11,"commit_id":"af827e3a7ed3db7c9f4537d37ce65045d7213099","original_commit_id":"d1dec80d395da69f142cf6bfff0fdcb10df5bfd2","user":{"login":"dsgouda","id":14796031,"avatar_url":"https://avatars1.githubusercontent.com/u/14796031?v=3","gravatar_id":"","url":"https://api.github.com/users/dsgouda","html_url":"https://github.com/dsgouda","followers_url":"https://api.github.com/users/dsgouda/followers","following_url":"https://api.github.com/users/dsgouda/following{/other_user}","gists_url":"https://api.github.com/users/dsgouda/gists{/gist_id}","starred_url":"https://api.github.com/users/dsgouda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsgouda/subscriptions","organizations_url":"https://api.github.com/users/dsgouda/orgs","repos_url":"https://api.github.com/users/dsgouda/repos","events_url":"https://api.github.com/users/dsgouda/events{/privacy}","received_events_url":"https://api.github.com/users/dsgouda/received_events","type":"User","site_admin":false},"body":"Agreed, even if it does warrant a performance investigation, I think we can revisit this once we move validator to a different repo,","created_at":"2017-06-19T17:47:14Z","updated_at":"2017-06-19T17:47:14Z","html_url":"https://github.com/Azure/autorest/pull/2365#discussion_r122776211","pull_request_url":"https://api.github.com/repos/Azure/autorest/pulls/2365","_links":{"self":{"href":"https://api.github.com/repos/Azure/autorest/pulls/comments/122776211"},"html":{"href":"https://github.com/Azure/autorest/pull/2365#discussion_r122776211"},"pull_request":{"href":"https://api.github.com/repos/Azure/autorest/pulls/2365"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/autorest/pulls/2365","id":125712053,"html_url":"https://github.com/Azure/autorest/pull/2365","diff_url":"https://github.com/Azure/autorest/pull/2365.diff","patch_url":"https://github.com/Azure/autorest/pull/2365.patch","issue_url":"https://api.github.com/repos/Azure/autorest/issues/2365","number":2365,"state":"open","locked":false,"title":"Filtering resource models returned only by post","user":{"login":"dsgouda","id":14796031,"avatar_url":"https://avatars1.githubusercontent.com/u/14796031?v=3","gravatar_id":"","url":"https://api.github.com/users/dsgouda","html_url":"https://github.com/dsgouda","followers_url":"https://api.github.com/users/dsgouda/followers","following_url":"https://api.github.com/users/dsgouda/following{/other_user}","gists_url":"https://api.github.com/users/dsgouda/gists{/gist_id}","starred_url":"https://api.github.com/users/dsgouda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsgouda/subscriptions","organizations_url":"https://api.github.com/users/dsgouda/orgs","repos_url":"https://api.github.com/users/dsgouda/repos","events_url":"https://api.github.com/users/dsgouda/events{/privacy}","received_events_url":"https://api.github.com/users/dsgouda/received_events","type":"User","site_admin":false},"body":"Addressing https://github.com/Azure/autorest/issues/2316","created_at":"2017-06-14T23:13:01Z","updated_at":"2017-06-19T17:47:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f3ef93fbcfe0b8bdd78099d5db4ff2608c410c0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"vishrutshah","id":8782776,"avatar_url":"https://avatars3.githubusercontent.com/u/8782776?v=3","gravatar_id":"","url":"https://api.github.com/users/vishrutshah","html_url":"https://github.com/vishrutshah","followers_url":"https://api.github.com/users/vishrutshah/followers","following_url":"https://api.github.com/users/vishrutshah/following{/other_user}","gists_url":"https://api.github.com/users/vishrutshah/gists{/gist_id}","starred_url":"https://api.github.com/users/vishrutshah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishrutshah/subscriptions","organizations_url":"https://api.github.com/users/vishrutshah/orgs","repos_url":"https://api.github.com/users/vishrutshah/repos","events_url":"https://api.github.com/users/vishrutshah/events{/privacy}","received_events_url":"https://api.github.com/users/vishrutshah/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/autorest/pulls/2365/commits","review_comments_url":"https://api.github.com/repos/Azure/autorest/pulls/2365/comments","review_comment_url":"https://api.github.com/repos/Azure/autorest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/autorest/issues/2365/comments","statuses_url":"https://api.github.com/repos/Azure/autorest/statuses/af827e3a7ed3db7c9f4537d37ce65045d7213099","head":{"label":"dsgouda:i2316","ref":"i2316","sha":"af827e3a7ed3db7c9f4537d37ce65045d7213099","user":{"login":"dsgouda","id":14796031,"avatar_url":"https://avatars1.githubusercontent.com/u/14796031?v=3","gravatar_id":"","url":"https://api.github.com/users/dsgouda","html_url":"https://github.com/dsgouda","followers_url":"https://api.github.com/users/dsgouda/followers","following_url":"https://api.github.com/users/dsgouda/following{/other_user}","gists_url":"https://api.github.com/users/dsgouda/gists{/gist_id}","starred_url":"https://api.github.com/users/dsgouda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsgouda/subscriptions","organizations_url":"https://api.github.com/users/dsgouda/orgs","repos_url":"https://api.github.com/users/dsgouda/repos","events_url":"https://api.github.com/users/dsgouda/events{/privacy}","received_events_url":"https://api.github.com/users/dsgouda/received_events","type":"User","site_admin":false},"repo":{"id":67553230,"name":"autorest","full_name":"dsgouda/autorest","owner":{"login":"dsgouda","id":14796031,"avatar_url":"https://avatars1.githubusercontent.com/u/14796031?v=3","gravatar_id":"","url":"https://api.github.com/users/dsgouda","html_url":"https://github.com/dsgouda","followers_url":"https://api.github.com/users/dsgouda/followers","following_url":"https://api.github.com/users/dsgouda/following{/other_user}","gists_url":"https://api.github.com/users/dsgouda/gists{/gist_id}","starred_url":"https://api.github.com/users/dsgouda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsgouda/subscriptions","organizations_url":"https://api.github.com/users/dsgouda/orgs","repos_url":"https://api.github.com/users/dsgouda/repos","events_url":"https://api.github.com/users/dsgouda/events{/privacy}","received_events_url":"https://api.github.com/users/dsgouda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsgouda/autorest","description":"Swagger (OpenAPI) Specification code generator featuring C# and Razor templates. Supports C#, Java, Node.js, TypeScript, Python and Ruby.","fork":true,"url":"https://api.github.com/repos/dsgouda/autorest","forks_url":"https://api.github.com/repos/dsgouda/autorest/forks","keys_url":"https://api.github.com/repos/dsgouda/autorest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsgouda/autorest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsgouda/autorest/teams","hooks_url":"https://api.github.com/repos/dsgouda/autorest/hooks","issue_events_url":"https://api.github.com/repos/dsgouda/autorest/issues/events{/number}","events_url":"https://api.github.com/repos/dsgouda/autorest/events","assignees_url":"https://api.github.com/repos/dsgouda/autorest/assignees{/user}","branches_url":"https://api.github.com/repos/dsgouda/autorest/branches{/branch}","tags_url":"https://api.github.com/repos/dsgouda/autorest/tags","blobs_url":"https://api.github.com/repos/dsgouda/autorest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsgouda/autorest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsgouda/autorest/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsgouda/autorest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsgouda/autorest/statuses/{sha}","languages_url":"https://api.github.com/repos/dsgouda/autorest/languages","stargazers_url":"https://api.github.com/repos/dsgouda/autorest/stargazers","contributors_url":"https://api.github.com/repos/dsgouda/autorest/contributors","subscribers_url":"https://api.github.com/repos/dsgouda/autorest/subscribers","subscription_url":"https://api.github.com/repos/dsgouda/autorest/subscription","commits_url":"https://api.github.com/repos/dsgouda/autorest/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsgouda/autorest/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsgouda/autorest/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsgouda/autorest/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsgouda/autorest/contents/{+path}","compare_url":"https://api.github.com/repos/dsgouda/autorest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsgouda/autorest/merges","archive_url":"https://api.github.com/repos/dsgouda/autorest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsgouda/autorest/downloads","issues_url":"https://api.github.com/repos/dsgouda/autorest/issues{/number}","pulls_url":"https://api.github.com/repos/dsgouda/autorest/pulls{/number}","milestones_url":"https://api.github.com/repos/dsgouda/autorest/milestones{/number}","notifications_url":"https://api.github.com/repos/dsgouda/autorest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsgouda/autorest/labels{/name}","releases_url":"https://api.github.com/repos/dsgouda/autorest/releases{/id}","deployments_url":"https://api.github.com/repos/dsgouda/autorest/deployments","created_at":"2016-09-06T23:03:41Z","updated_at":"2016-09-06T23:03:49Z","pushed_at":"2017-06-19T16:56:12Z","git_url":"git://github.com/dsgouda/autorest.git","ssh_url":"git@github.com:dsgouda/autorest.git","clone_url":"https://github.com/dsgouda/autorest.git","svn_url":"https://github.com/dsgouda/autorest","homepage":"","size":63507,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"676250ff06edf43637317a4208caab8a6c0712e1","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":31089461,"name":"autorest","full_name":"Azure/autorest","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/autorest","description":"Swagger (OpenAPI) Specification code generator featuring C# and Razor templates. Supports C#, Java, Node.js, TypeScript, Python and Ruby.","fork":false,"url":"https://api.github.com/repos/Azure/autorest","forks_url":"https://api.github.com/repos/Azure/autorest/forks","keys_url":"https://api.github.com/repos/Azure/autorest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/autorest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/autorest/teams","hooks_url":"https://api.github.com/repos/Azure/autorest/hooks","issue_events_url":"https://api.github.com/repos/Azure/autorest/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/autorest/events","assignees_url":"https://api.github.com/repos/Azure/autorest/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/autorest/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/autorest/tags","blobs_url":"https://api.github.com/repos/Azure/autorest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/autorest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/autorest/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/autorest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/autorest/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/autorest/languages","stargazers_url":"https://api.github.com/repos/Azure/autorest/stargazers","contributors_url":"https://api.github.com/repos/Azure/autorest/contributors","subscribers_url":"https://api.github.com/repos/Azure/autorest/subscribers","subscription_url":"https://api.github.com/repos/Azure/autorest/subscription","commits_url":"https://api.github.com/repos/Azure/autorest/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/autorest/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/autorest/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/autorest/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/autorest/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/autorest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/autorest/merges","archive_url":"https://api.github.com/repos/Azure/autorest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/autorest/downloads","issues_url":"https://api.github.com/repos/Azure/autorest/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/autorest/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/autorest/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/autorest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/autorest/labels{/name}","releases_url":"https://api.github.com/repos/Azure/autorest/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/autorest/deployments","created_at":"2015-02-20T23:02:54Z","updated_at":"2017-06-18T12:39:44Z","pushed_at":"2017-06-19T17:15:50Z","git_url":"git://github.com/Azure/autorest.git","ssh_url":"git@github.com:Azure/autorest.git","clone_url":"https://github.com/Azure/autorest.git","svn_url":"https://github.com/Azure/autorest","homepage":"","size":64263,"stargazers_count":849,"watchers_count":849,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":259,"mirror_url":null,"open_issues_count":222,"forks":259,"open_issues":222,"watchers":849,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/autorest/pulls/2365"},"html":{"href":"https://github.com/Azure/autorest/pull/2365"},"issue":{"href":"https://api.github.com/repos/Azure/autorest/issues/2365"},"comments":{"href":"https://api.github.com/repos/Azure/autorest/issues/2365/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/autorest/pulls/2365/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/autorest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/autorest/pulls/2365/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/autorest/statuses/af827e3a7ed3db7c9f4537d37ce65045d7213099"}}}}
{"actor":{"display_login":"dsgouda"}}