{"action":"created","comment":{"url":"https://api.github.com/repos/miekg/dns/pulls/comments/108583788","pull_request_review_id":29623933,"id":108583788,"diff_hunk":"@@ -400,6 +412,12 @@ Loop:\n \tif len(s) == 0 {\n \t\ts = []byte(\".\")\n \t}\n+\t// error if the name is too long, but don't throw it away\n+\tif len(s) >= maxLen {","path":"msg.go","position":63,"original_position":63,"commit_id":"757d2e1acbe521ccee851da70b7c7c3532b33e38","original_commit_id":"757d2e1acbe521ccee851da70b7c7c3532b33e38","user":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars0.githubusercontent.com/u/1199584?v=3","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"body":"Sure. :)","created_at":"2017-03-29T03:10:32Z","updated_at":"2017-03-29T03:10:32Z","html_url":"https://github.com/miekg/dns/pull/478#discussion_r108583788","pull_request_url":"https://api.github.com/repos/miekg/dns/pulls/478","_links":{"self":{"href":"https://api.github.com/repos/miekg/dns/pulls/comments/108583788"},"html":{"href":"https://github.com/miekg/dns/pull/478#discussion_r108583788"},"pull_request":{"href":"https://api.github.com/repos/miekg/dns/pulls/478"}}},"pull_request":{"url":"https://api.github.com/repos/miekg/dns/pulls/478","id":112893012,"html_url":"https://github.com/miekg/dns/pull/478","diff_url":"https://github.com/miekg/dns/pull/478.diff","patch_url":"https://github.com/miekg/dns/pull/478.patch","issue_url":"https://api.github.com/repos/miekg/dns/issues/478","number":478,"state":"open","locked":false,"title":"Domain name limits","user":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars0.githubusercontent.com/u/1199584?v=3","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"body":"Domain names must not exceed 255 octets in wire format.\r\n\r\nRef gh-463\r\nRef gh-469","created_at":"2017-03-28T05:34:08Z","updated_at":"2017-03-29T03:10:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f6b8f8b0203b13c11bce0e7647c728497e666e9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/miekg/dns/pulls/478/commits","review_comments_url":"https://api.github.com/repos/miekg/dns/pulls/478/comments","review_comment_url":"https://api.github.com/repos/miekg/dns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/miekg/dns/issues/478/comments","statuses_url":"https://api.github.com/repos/miekg/dns/statuses/757d2e1acbe521ccee851da70b7c7c3532b33e38","head":{"label":"gibson042:domain-name-limits","ref":"domain-name-limits","sha":"757d2e1acbe521ccee851da70b7c7c3532b33e38","user":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars0.githubusercontent.com/u/1199584?v=3","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"repo":{"id":74835433,"name":"dns","full_name":"gibson042/dns","owner":{"login":"gibson042","id":1199584,"avatar_url":"https://avatars0.githubusercontent.com/u/1199584?v=3","gravatar_id":"","url":"https://api.github.com/users/gibson042","html_url":"https://github.com/gibson042","followers_url":"https://api.github.com/users/gibson042/followers","following_url":"https://api.github.com/users/gibson042/following{/other_user}","gists_url":"https://api.github.com/users/gibson042/gists{/gist_id}","starred_url":"https://api.github.com/users/gibson042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gibson042/subscriptions","organizations_url":"https://api.github.com/users/gibson042/orgs","repos_url":"https://api.github.com/users/gibson042/repos","events_url":"https://api.github.com/users/gibson042/events{/privacy}","received_events_url":"https://api.github.com/users/gibson042/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gibson042/dns","description":"DNS library in Go","fork":true,"url":"https://api.github.com/repos/gibson042/dns","forks_url":"https://api.github.com/repos/gibson042/dns/forks","keys_url":"https://api.github.com/repos/gibson042/dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gibson042/dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gibson042/dns/teams","hooks_url":"https://api.github.com/repos/gibson042/dns/hooks","issue_events_url":"https://api.github.com/repos/gibson042/dns/issues/events{/number}","events_url":"https://api.github.com/repos/gibson042/dns/events","assignees_url":"https://api.github.com/repos/gibson042/dns/assignees{/user}","branches_url":"https://api.github.com/repos/gibson042/dns/branches{/branch}","tags_url":"https://api.github.com/repos/gibson042/dns/tags","blobs_url":"https://api.github.com/repos/gibson042/dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gibson042/dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gibson042/dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/gibson042/dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gibson042/dns/statuses/{sha}","languages_url":"https://api.github.com/repos/gibson042/dns/languages","stargazers_url":"https://api.github.com/repos/gibson042/dns/stargazers","contributors_url":"https://api.github.com/repos/gibson042/dns/contributors","subscribers_url":"https://api.github.com/repos/gibson042/dns/subscribers","subscription_url":"https://api.github.com/repos/gibson042/dns/subscription","commits_url":"https://api.github.com/repos/gibson042/dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/gibson042/dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/gibson042/dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/gibson042/dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/gibson042/dns/contents/{+path}","compare_url":"https://api.github.com/repos/gibson042/dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gibson042/dns/merges","archive_url":"https://api.github.com/repos/gibson042/dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gibson042/dns/downloads","issues_url":"https://api.github.com/repos/gibson042/dns/issues{/number}","pulls_url":"https://api.github.com/repos/gibson042/dns/pulls{/number}","milestones_url":"https://api.github.com/repos/gibson042/dns/milestones{/number}","notifications_url":"https://api.github.com/repos/gibson042/dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gibson042/dns/labels{/name}","releases_url":"https://api.github.com/repos/gibson042/dns/releases{/id}","deployments_url":"https://api.github.com/repos/gibson042/dns/deployments","created_at":"2016-11-26T15:58:53Z","updated_at":"2016-11-26T15:58:55Z","pushed_at":"2017-03-28T05:32:16Z","git_url":"git://github.com/gibson042/dns.git","ssh_url":"git@github.com:gibson042/dns.git","clone_url":"https://github.com/gibson042/dns.git","svn_url":"https://github.com/gibson042/dns","homepage":"https://miek.nl/2014/August/16/go-dns-package","size":10886,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"miekg:master","ref":"master","sha":"b54e1be39a9c14cd0bcea6df97eb15b3ec5e8cde","user":{"login":"miekg","id":353371,"avatar_url":"https://avatars2.githubusercontent.com/u/353371?v=3","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"repo":{"id":815644,"name":"dns","full_name":"miekg/dns","owner":{"login":"miekg","id":353371,"avatar_url":"https://avatars2.githubusercontent.com/u/353371?v=3","gravatar_id":"","url":"https://api.github.com/users/miekg","html_url":"https://github.com/miekg","followers_url":"https://api.github.com/users/miekg/followers","following_url":"https://api.github.com/users/miekg/following{/other_user}","gists_url":"https://api.github.com/users/miekg/gists{/gist_id}","starred_url":"https://api.github.com/users/miekg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miekg/subscriptions","organizations_url":"https://api.github.com/users/miekg/orgs","repos_url":"https://api.github.com/users/miekg/repos","events_url":"https://api.github.com/users/miekg/events{/privacy}","received_events_url":"https://api.github.com/users/miekg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/miekg/dns","description":"DNS library in Go","fork":false,"url":"https://api.github.com/repos/miekg/dns","forks_url":"https://api.github.com/repos/miekg/dns/forks","keys_url":"https://api.github.com/repos/miekg/dns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/miekg/dns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/miekg/dns/teams","hooks_url":"https://api.github.com/repos/miekg/dns/hooks","issue_events_url":"https://api.github.com/repos/miekg/dns/issues/events{/number}","events_url":"https://api.github.com/repos/miekg/dns/events","assignees_url":"https://api.github.com/repos/miekg/dns/assignees{/user}","branches_url":"https://api.github.com/repos/miekg/dns/branches{/branch}","tags_url":"https://api.github.com/repos/miekg/dns/tags","blobs_url":"https://api.github.com/repos/miekg/dns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/miekg/dns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/miekg/dns/git/refs{/sha}","trees_url":"https://api.github.com/repos/miekg/dns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/miekg/dns/statuses/{sha}","languages_url":"https://api.github.com/repos/miekg/dns/languages","stargazers_url":"https://api.github.com/repos/miekg/dns/stargazers","contributors_url":"https://api.github.com/repos/miekg/dns/contributors","subscribers_url":"https://api.github.com/repos/miekg/dns/subscribers","subscription_url":"https://api.github.com/repos/miekg/dns/subscription","commits_url":"https://api.github.com/repos/miekg/dns/commits{/sha}","git_commits_url":"https://api.github.com/repos/miekg/dns/git/commits{/sha}","comments_url":"https://api.github.com/repos/miekg/dns/comments{/number}","issue_comment_url":"https://api.github.com/repos/miekg/dns/issues/comments{/number}","contents_url":"https://api.github.com/repos/miekg/dns/contents/{+path}","compare_url":"https://api.github.com/repos/miekg/dns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/miekg/dns/merges","archive_url":"https://api.github.com/repos/miekg/dns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/miekg/dns/downloads","issues_url":"https://api.github.com/repos/miekg/dns/issues{/number}","pulls_url":"https://api.github.com/repos/miekg/dns/pulls{/number}","milestones_url":"https://api.github.com/repos/miekg/dns/milestones{/number}","notifications_url":"https://api.github.com/repos/miekg/dns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/miekg/dns/labels{/name}","releases_url":"https://api.github.com/repos/miekg/dns/releases{/id}","deployments_url":"https://api.github.com/repos/miekg/dns/deployments","created_at":"2010-08-03T21:56:23Z","updated_at":"2017-03-28T18:10:32Z","pushed_at":"2017-03-28T05:34:08Z","git_url":"git://github.com/miekg/dns.git","ssh_url":"git@github.com:miekg/dns.git","clone_url":"https://github.com/miekg/dns.git","svn_url":"https://github.com/miekg/dns","homepage":"https://miek.nl/2014/August/16/go-dns-package","size":10457,"stargazers_count":2040,"watchers_count":2040,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":370,"mirror_url":null,"open_issues_count":25,"forks":370,"open_issues":25,"watchers":2040,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/miekg/dns/pulls/478"},"html":{"href":"https://github.com/miekg/dns/pull/478"},"issue":{"href":"https://api.github.com/repos/miekg/dns/issues/478"},"comments":{"href":"https://api.github.com/repos/miekg/dns/issues/478/comments"},"review_comments":{"href":"https://api.github.com/repos/miekg/dns/pulls/478/comments"},"review_comment":{"href":"https://api.github.com/repos/miekg/dns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/miekg/dns/pulls/478/commits"},"statuses":{"href":"https://api.github.com/repos/miekg/dns/statuses/757d2e1acbe521ccee851da70b7c7c3532b33e38"}}}}
{"actor":{"display_login":"gibson042"}}