{"action":"closed","number":298,"pull_request":{"url":"https://api.github.com/repos/gorilla/websocket/pulls/298","id":152101082,"html_url":"https://github.com/gorilla/websocket/pull/298","diff_url":"https://github.com/gorilla/websocket/pull/298.diff","patch_url":"https://github.com/gorilla/websocket/pull/298.patch","issue_url":"https://api.github.com/repos/gorilla/websocket/issues/298","number":298,"state":"closed","locked":false,"title":"More consistent error handling in doc","user":{"login":"seppo0010","id":223776,"avatar_url":"https://avatars1.githubusercontent.com/u/223776?v=4","gravatar_id":"","url":"https://api.github.com/users/seppo0010","html_url":"https://github.com/seppo0010","followers_url":"https://api.github.com/users/seppo0010/followers","following_url":"https://api.github.com/users/seppo0010/following{/other_user}","gists_url":"https://api.github.com/users/seppo0010/gists{/gist_id}","starred_url":"https://api.github.com/users/seppo0010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seppo0010/subscriptions","organizations_url":"https://api.github.com/users/seppo0010/orgs","repos_url":"https://api.github.com/users/seppo0010/repos","events_url":"https://api.github.com/users/seppo0010/events{/privacy}","received_events_url":"https://api.github.com/users/seppo0010/received_events","type":"User","site_admin":false},"body":"I noticed the example is actually wrong as the same block both calls `return` with no parameter and `return err`. I think it would be better to allow the code to be used directly. I added calls to log.Println as it was used on the other example as it might be more useful for newcomers to see error messages.","created_at":"2017-11-12T12:02:22Z","updated_at":"2017-11-12T15:44:07Z","closed_at":"2017-11-12T15:44:07Z","merged_at":"2017-11-12T15:44:07Z","merge_commit_sha":"7ca4275b84a9d500f68971c8c4a97f0ec18eb889","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gorilla/websocket/pulls/298/commits","review_comments_url":"https://api.github.com/repos/gorilla/websocket/pulls/298/comments","review_comment_url":"https://api.github.com/repos/gorilla/websocket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gorilla/websocket/issues/298/comments","statuses_url":"https://api.github.com/repos/gorilla/websocket/statuses/86947c68b22afa3d03f04513778493c7f1036999","head":{"label":"seppo0010:patch-1","ref":"patch-1","sha":"86947c68b22afa3d03f04513778493c7f1036999","user":{"login":"seppo0010","id":223776,"avatar_url":"https://avatars1.githubusercontent.com/u/223776?v=4","gravatar_id":"","url":"https://api.github.com/users/seppo0010","html_url":"https://github.com/seppo0010","followers_url":"https://api.github.com/users/seppo0010/followers","following_url":"https://api.github.com/users/seppo0010/following{/other_user}","gists_url":"https://api.github.com/users/seppo0010/gists{/gist_id}","starred_url":"https://api.github.com/users/seppo0010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seppo0010/subscriptions","organizations_url":"https://api.github.com/users/seppo0010/orgs","repos_url":"https://api.github.com/users/seppo0010/repos","events_url":"https://api.github.com/users/seppo0010/events{/privacy}","received_events_url":"https://api.github.com/users/seppo0010/received_events","type":"User","site_admin":false},"repo":{"id":110428779,"name":"websocket","full_name":"seppo0010/websocket","owner":{"login":"seppo0010","id":223776,"avatar_url":"https://avatars1.githubusercontent.com/u/223776?v=4","gravatar_id":"","url":"https://api.github.com/users/seppo0010","html_url":"https://github.com/seppo0010","followers_url":"https://api.github.com/users/seppo0010/followers","following_url":"https://api.github.com/users/seppo0010/following{/other_user}","gists_url":"https://api.github.com/users/seppo0010/gists{/gist_id}","starred_url":"https://api.github.com/users/seppo0010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seppo0010/subscriptions","organizations_url":"https://api.github.com/users/seppo0010/orgs","repos_url":"https://api.github.com/users/seppo0010/repos","events_url":"https://api.github.com/users/seppo0010/events{/privacy}","received_events_url":"https://api.github.com/users/seppo0010/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seppo0010/websocket","description":"A WebSocket implementation for Go.","fork":true,"url":"https://api.github.com/repos/seppo0010/websocket","forks_url":"https://api.github.com/repos/seppo0010/websocket/forks","keys_url":"https://api.github.com/repos/seppo0010/websocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seppo0010/websocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seppo0010/websocket/teams","hooks_url":"https://api.github.com/repos/seppo0010/websocket/hooks","issue_events_url":"https://api.github.com/repos/seppo0010/websocket/issues/events{/number}","events_url":"https://api.github.com/repos/seppo0010/websocket/events","assignees_url":"https://api.github.com/repos/seppo0010/websocket/assignees{/user}","branches_url":"https://api.github.com/repos/seppo0010/websocket/branches{/branch}","tags_url":"https://api.github.com/repos/seppo0010/websocket/tags","blobs_url":"https://api.github.com/repos/seppo0010/websocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seppo0010/websocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seppo0010/websocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/seppo0010/websocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seppo0010/websocket/statuses/{sha}","languages_url":"https://api.github.com/repos/seppo0010/websocket/languages","stargazers_url":"https://api.github.com/repos/seppo0010/websocket/stargazers","contributors_url":"https://api.github.com/repos/seppo0010/websocket/contributors","subscribers_url":"https://api.github.com/repos/seppo0010/websocket/subscribers","subscription_url":"https://api.github.com/repos/seppo0010/websocket/subscription","commits_url":"https://api.github.com/repos/seppo0010/websocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/seppo0010/websocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/seppo0010/websocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/seppo0010/websocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/seppo0010/websocket/contents/{+path}","compare_url":"https://api.github.com/repos/seppo0010/websocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seppo0010/websocket/merges","archive_url":"https://api.github.com/repos/seppo0010/websocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seppo0010/websocket/downloads","issues_url":"https://api.github.com/repos/seppo0010/websocket/issues{/number}","pulls_url":"https://api.github.com/repos/seppo0010/websocket/pulls{/number}","milestones_url":"https://api.github.com/repos/seppo0010/websocket/milestones{/number}","notifications_url":"https://api.github.com/repos/seppo0010/websocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seppo0010/websocket/labels{/name}","releases_url":"https://api.github.com/repos/seppo0010/websocket/releases{/id}","deployments_url":"https://api.github.com/repos/seppo0010/websocket/deployments","created_at":"2017-11-12T11:59:50Z","updated_at":"2017-11-12T11:59:52Z","pushed_at":"2017-11-12T12:01:56Z","git_url":"git://github.com/seppo0010/websocket.git","ssh_url":"git@github.com:seppo0010/websocket.git","clone_url":"https://github.com/seppo0010/websocket.git","svn_url":"https://github.com/seppo0010/websocket","homepage":"","size":282,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gorilla:master","ref":"master","sha":"3da6ca0cb65383f2b607a677b6b55e8358cacee6","user":{"login":"gorilla","id":489566,"avatar_url":"https://avatars0.githubusercontent.com/u/489566?v=4","gravatar_id":"","url":"https://api.github.com/users/gorilla","html_url":"https://github.com/gorilla","followers_url":"https://api.github.com/users/gorilla/followers","following_url":"https://api.github.com/users/gorilla/following{/other_user}","gists_url":"https://api.github.com/users/gorilla/gists{/gist_id}","starred_url":"https://api.github.com/users/gorilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorilla/subscriptions","organizations_url":"https://api.github.com/users/gorilla/orgs","repos_url":"https://api.github.com/users/gorilla/repos","events_url":"https://api.github.com/users/gorilla/events{/privacy}","received_events_url":"https://api.github.com/users/gorilla/received_events","type":"Organization","site_admin":false},"repo":{"id":13624859,"name":"websocket","full_name":"gorilla/websocket","owner":{"login":"gorilla","id":489566,"avatar_url":"https://avatars0.githubusercontent.com/u/489566?v=4","gravatar_id":"","url":"https://api.github.com/users/gorilla","html_url":"https://github.com/gorilla","followers_url":"https://api.github.com/users/gorilla/followers","following_url":"https://api.github.com/users/gorilla/following{/other_user}","gists_url":"https://api.github.com/users/gorilla/gists{/gist_id}","starred_url":"https://api.github.com/users/gorilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorilla/subscriptions","organizations_url":"https://api.github.com/users/gorilla/orgs","repos_url":"https://api.github.com/users/gorilla/repos","events_url":"https://api.github.com/users/gorilla/events{/privacy}","received_events_url":"https://api.github.com/users/gorilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gorilla/websocket","description":"A WebSocket implementation for Go.","fork":false,"url":"https://api.github.com/repos/gorilla/websocket","forks_url":"https://api.github.com/repos/gorilla/websocket/forks","keys_url":"https://api.github.com/repos/gorilla/websocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gorilla/websocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gorilla/websocket/teams","hooks_url":"https://api.github.com/repos/gorilla/websocket/hooks","issue_events_url":"https://api.github.com/repos/gorilla/websocket/issues/events{/number}","events_url":"https://api.github.com/repos/gorilla/websocket/events","assignees_url":"https://api.github.com/repos/gorilla/websocket/assignees{/user}","branches_url":"https://api.github.com/repos/gorilla/websocket/branches{/branch}","tags_url":"https://api.github.com/repos/gorilla/websocket/tags","blobs_url":"https://api.github.com/repos/gorilla/websocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gorilla/websocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gorilla/websocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/gorilla/websocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gorilla/websocket/statuses/{sha}","languages_url":"https://api.github.com/repos/gorilla/websocket/languages","stargazers_url":"https://api.github.com/repos/gorilla/websocket/stargazers","contributors_url":"https://api.github.com/repos/gorilla/websocket/contributors","subscribers_url":"https://api.github.com/repos/gorilla/websocket/subscribers","subscription_url":"https://api.github.com/repos/gorilla/websocket/subscription","commits_url":"https://api.github.com/repos/gorilla/websocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/gorilla/websocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/gorilla/websocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/gorilla/websocket/issues/comments{/number}","contents_url":"https://api.github.com/repos/gorilla/websocket/contents/{+path}","compare_url":"https://api.github.com/repos/gorilla/websocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gorilla/websocket/merges","archive_url":"https://api.github.com/repos/gorilla/websocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gorilla/websocket/downloads","issues_url":"https://api.github.com/repos/gorilla/websocket/issues{/number}","pulls_url":"https://api.github.com/repos/gorilla/websocket/pulls{/number}","milestones_url":"https://api.github.com/repos/gorilla/websocket/milestones{/number}","notifications_url":"https://api.github.com/repos/gorilla/websocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gorilla/websocket/labels{/name}","releases_url":"https://api.github.com/repos/gorilla/websocket/releases{/id}","deployments_url":"https://api.github.com/repos/gorilla/websocket/deployments","created_at":"2013-10-16T16:41:46Z","updated_at":"2017-11-12T13:51:31Z","pushed_at":"2017-11-12T15:44:07Z","git_url":"git://github.com/gorilla/websocket.git","ssh_url":"git@github.com:gorilla/websocket.git","clone_url":"https://github.com/gorilla/websocket.git","svn_url":"https://github.com/gorilla/websocket","homepage":"","size":278,"stargazers_count":4453,"watchers_count":4453,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":795,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":795,"open_issues":6,"watchers":4453,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gorilla/websocket/pulls/298"},"html":{"href":"https://github.com/gorilla/websocket/pull/298"},"issue":{"href":"https://api.github.com/repos/gorilla/websocket/issues/298"},"comments":{"href":"https://api.github.com/repos/gorilla/websocket/issues/298/comments"},"review_comments":{"href":"https://api.github.com/repos/gorilla/websocket/pulls/298/comments"},"review_comment":{"href":"https://api.github.com/repos/gorilla/websocket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gorilla/websocket/pulls/298/commits"},"statuses":{"href":"https://api.github.com/repos/gorilla/websocket/statuses/86947c68b22afa3d03f04513778493c7f1036999"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"garyburd","id":33411,"avatar_url":"https://avatars2.githubusercontent.com/u/33411?v=4","gravatar_id":"","url":"https://api.github.com/users/garyburd","html_url":"https://github.com/garyburd","followers_url":"https://api.github.com/users/garyburd/followers","following_url":"https://api.github.com/users/garyburd/following{/other_user}","gists_url":"https://api.github.com/users/garyburd/gists{/gist_id}","starred_url":"https://api.github.com/users/garyburd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyburd/subscriptions","organizations_url":"https://api.github.com/users/garyburd/orgs","repos_url":"https://api.github.com/users/garyburd/repos","events_url":"https://api.github.com/users/garyburd/events{/privacy}","received_events_url":"https://api.github.com/users/garyburd/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"garyburd"}}