{"action":"created","comment":{"url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls/comments/100258119","pull_request_review_id":20957492,"id":100258119,"diff_hunk":"@@ -9,10 +9,10 @@\n IPBLOCKS = re.compile(\"(^|\\n)(?P<block>\\d+:.*?)(?=(\\n\\d+)|$)\", re.S)\n IPMAC = re.compile(\"^\\s+link/\\w+\\s+(?P<mac>(\\w+:){5}\\w{2})\", re.M)\n IPIP = re.compile(\"^\\s+inet\\s(?P<ip>(\\d+\\.){3}\\d+)/(?P<cidr>\\d+)\", re.M)\n-IPNAME = re.compile(\"^\\d+: (?P<name>.*?)(?=[:@])\", re.M)\n+IPNAME = re.compile(\"^\\d+: (?P<name>.*?)(?=[:@]).+ mtu (?P<mtu>\\d+)\", re.M)\n \n def parseBlock(block):\n-    result = {'ip': [], 'cidr': [], 'mac': '', 'name': ''}\n+    result = {'ip': [], 'cidr': [], 'mac': '', 'name': '', 'mtu': ''}","path":"lib/JumpScale/core/system/net.py","position":9,"original_position":9,"commit_id":"0c631a771ffbd9e771cf904fd330461d71c42906","original_commit_id":"0c631a771ffbd9e771cf904fd330461d71c42906","user":{"login":"grimpy","id":143869,"avatar_url":"https://avatars.githubusercontent.com/u/143869?v=3","gravatar_id":"","url":"https://api.github.com/users/grimpy","html_url":"https://github.com/grimpy","followers_url":"https://api.github.com/users/grimpy/followers","following_url":"https://api.github.com/users/grimpy/following{/other_user}","gists_url":"https://api.github.com/users/grimpy/gists{/gist_id}","starred_url":"https://api.github.com/users/grimpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimpy/subscriptions","organizations_url":"https://api.github.com/users/grimpy/orgs","repos_url":"https://api.github.com/users/grimpy/repos","events_url":"https://api.github.com/users/grimpy/events{/privacy}","received_events_url":"https://api.github.com/users/grimpy/received_events","type":"User","site_admin":false},"body":"we probably want to make mtu an integer not a string.\r\nso make the default value 0\r\nand parse it.","created_at":"2017-02-09T09:08:57Z","updated_at":"2017-02-09T09:08:57Z","html_url":"https://github.com/jumpscale7/jumpscale_core7/pull/20#discussion_r100258119","pull_request_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls/comments/100258119"},"html":{"href":"https://github.com/jumpscale7/jumpscale_core7/pull/20#discussion_r100258119"},"pull_request":{"href":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls/20","id":105367733,"html_url":"https://github.com/jumpscale7/jumpscale_core7/pull/20","diff_url":"https://github.com/jumpscale7/jumpscale_core7/pull/20.diff","patch_url":"https://github.com/jumpscale7/jumpscale_core7/pull/20.patch","issue_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/issues/20","number":20,"state":"open","locked":false,"title":"Added mtu info","user":{"login":"alichaddad","id":24762033,"avatar_url":"https://avatars.githubusercontent.com/u/24762033?v=3","gravatar_id":"","url":"https://api.github.com/users/alichaddad","html_url":"https://github.com/alichaddad","followers_url":"https://api.github.com/users/alichaddad/followers","following_url":"https://api.github.com/users/alichaddad/following{/other_user}","gists_url":"https://api.github.com/users/alichaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/alichaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alichaddad/subscriptions","organizations_url":"https://api.github.com/users/alichaddad/orgs","repos_url":"https://api.github.com/users/alichaddad/repos","events_url":"https://api.github.com/users/alichaddad/events{/privacy}","received_events_url":"https://api.github.com/users/alichaddad/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-09T06:32:25Z","updated_at":"2017-02-09T09:08:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9813f9ff7eefca0da0518b7805083d1fdbb6a684","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls/20/commits","review_comments_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls/20/comments","review_comment_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/issues/20/comments","statuses_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/statuses/0c631a771ffbd9e771cf904fd330461d71c42906","head":{"label":"jumpscale7:7.1.7_networkmtu","ref":"7.1.7_networkmtu","sha":"0c631a771ffbd9e771cf904fd330461d71c42906","user":{"login":"jumpscale7","id":17393039,"avatar_url":"https://avatars.githubusercontent.com/u/17393039?v=3","gravatar_id":"","url":"https://api.github.com/users/jumpscale7","html_url":"https://github.com/jumpscale7","followers_url":"https://api.github.com/users/jumpscale7/followers","following_url":"https://api.github.com/users/jumpscale7/following{/other_user}","gists_url":"https://api.github.com/users/jumpscale7/gists{/gist_id}","starred_url":"https://api.github.com/users/jumpscale7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jumpscale7/subscriptions","organizations_url":"https://api.github.com/users/jumpscale7/orgs","repos_url":"https://api.github.com/users/jumpscale7/repos","events_url":"https://api.github.com/users/jumpscale7/events{/privacy}","received_events_url":"https://api.github.com/users/jumpscale7/received_events","type":"Organization","site_admin":false},"repo":{"id":52712967,"name":"jumpscale_core7","full_name":"jumpscale7/jumpscale_core7","owner":{"login":"jumpscale7","id":17393039,"avatar_url":"https://avatars.githubusercontent.com/u/17393039?v=3","gravatar_id":"","url":"https://api.github.com/users/jumpscale7","html_url":"https://github.com/jumpscale7","followers_url":"https://api.github.com/users/jumpscale7/followers","following_url":"https://api.github.com/users/jumpscale7/following{/other_user}","gists_url":"https://api.github.com/users/jumpscale7/gists{/gist_id}","starred_url":"https://api.github.com/users/jumpscale7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jumpscale7/subscriptions","organizations_url":"https://api.github.com/users/jumpscale7/orgs","repos_url":"https://api.github.com/users/jumpscale7/repos","events_url":"https://api.github.com/users/jumpscale7/events{/privacy}","received_events_url":"https://api.github.com/users/jumpscale7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jumpscale7/jumpscale_core7","description":"new version of jumpscale","fork":false,"url":"https://api.github.com/repos/jumpscale7/jumpscale_core7","forks_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/forks","keys_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/teams","hooks_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/hooks","issue_events_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/issues/events{/number}","events_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/events","assignees_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/assignees{/user}","branches_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/branches{/branch}","tags_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/tags","blobs_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/git/refs{/sha}","trees_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/statuses/{sha}","languages_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/languages","stargazers_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/stargazers","contributors_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/contributors","subscribers_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/subscribers","subscription_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/subscription","commits_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/commits{/sha}","git_commits_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/git/commits{/sha}","comments_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/comments{/number}","issue_comment_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/issues/comments{/number}","contents_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/contents/{+path}","compare_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/merges","archive_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/downloads","issues_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/issues{/number}","pulls_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls{/number}","milestones_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/milestones{/number}","notifications_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/labels{/name}","releases_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/releases{/id}","deployments_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/deployments","created_at":"2016-02-28T09:02:39Z","updated_at":"2016-05-23T08:01:17Z","pushed_at":"2017-02-09T06:32:26Z","git_url":"git://github.com/jumpscale7/jumpscale_core7.git","ssh_url":"git@github.com:jumpscale7/jumpscale_core7.git","clone_url":"https://github.com/jumpscale7/jumpscale_core7.git","svn_url":"https://github.com/jumpscale7/jumpscale_core7","homepage":null,"size":5537,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jumpscale7:7.1.7","ref":"7.1.7","sha":"5360322b46caa343d993e139cee4ca8df6f5d0d1","user":{"login":"jumpscale7","id":17393039,"avatar_url":"https://avatars.githubusercontent.com/u/17393039?v=3","gravatar_id":"","url":"https://api.github.com/users/jumpscale7","html_url":"https://github.com/jumpscale7","followers_url":"https://api.github.com/users/jumpscale7/followers","following_url":"https://api.github.com/users/jumpscale7/following{/other_user}","gists_url":"https://api.github.com/users/jumpscale7/gists{/gist_id}","starred_url":"https://api.github.com/users/jumpscale7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jumpscale7/subscriptions","organizations_url":"https://api.github.com/users/jumpscale7/orgs","repos_url":"https://api.github.com/users/jumpscale7/repos","events_url":"https://api.github.com/users/jumpscale7/events{/privacy}","received_events_url":"https://api.github.com/users/jumpscale7/received_events","type":"Organization","site_admin":false},"repo":{"id":52712967,"name":"jumpscale_core7","full_name":"jumpscale7/jumpscale_core7","owner":{"login":"jumpscale7","id":17393039,"avatar_url":"https://avatars.githubusercontent.com/u/17393039?v=3","gravatar_id":"","url":"https://api.github.com/users/jumpscale7","html_url":"https://github.com/jumpscale7","followers_url":"https://api.github.com/users/jumpscale7/followers","following_url":"https://api.github.com/users/jumpscale7/following{/other_user}","gists_url":"https://api.github.com/users/jumpscale7/gists{/gist_id}","starred_url":"https://api.github.com/users/jumpscale7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jumpscale7/subscriptions","organizations_url":"https://api.github.com/users/jumpscale7/orgs","repos_url":"https://api.github.com/users/jumpscale7/repos","events_url":"https://api.github.com/users/jumpscale7/events{/privacy}","received_events_url":"https://api.github.com/users/jumpscale7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jumpscale7/jumpscale_core7","description":"new version of jumpscale","fork":false,"url":"https://api.github.com/repos/jumpscale7/jumpscale_core7","forks_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/forks","keys_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/teams","hooks_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/hooks","issue_events_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/issues/events{/number}","events_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/events","assignees_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/assignees{/user}","branches_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/branches{/branch}","tags_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/tags","blobs_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/git/refs{/sha}","trees_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/statuses/{sha}","languages_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/languages","stargazers_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/stargazers","contributors_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/contributors","subscribers_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/subscribers","subscription_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/subscription","commits_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/commits{/sha}","git_commits_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/git/commits{/sha}","comments_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/comments{/number}","issue_comment_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/issues/comments{/number}","contents_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/contents/{+path}","compare_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/merges","archive_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/downloads","issues_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/issues{/number}","pulls_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls{/number}","milestones_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/milestones{/number}","notifications_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/labels{/name}","releases_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/releases{/id}","deployments_url":"https://api.github.com/repos/jumpscale7/jumpscale_core7/deployments","created_at":"2016-02-28T09:02:39Z","updated_at":"2016-05-23T08:01:17Z","pushed_at":"2017-02-09T06:32:26Z","git_url":"git://github.com/jumpscale7/jumpscale_core7.git","ssh_url":"git@github.com:jumpscale7/jumpscale_core7.git","clone_url":"https://github.com/jumpscale7/jumpscale_core7.git","svn_url":"https://github.com/jumpscale7/jumpscale_core7","homepage":null,"size":5537,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls/20"},"html":{"href":"https://github.com/jumpscale7/jumpscale_core7/pull/20"},"issue":{"href":"https://api.github.com/repos/jumpscale7/jumpscale_core7/issues/20"},"comments":{"href":"https://api.github.com/repos/jumpscale7/jumpscale_core7/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jumpscale7/jumpscale_core7/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/jumpscale7/jumpscale_core7/statuses/0c631a771ffbd9e771cf904fd330461d71c42906"}}}}
{"actor":{"display_login":"grimpy"}}