{"action":"created","comment":{"url":"https://api.github.com/repos/apache/parquet-mr/pulls/comments/99480330","pull_request_review_id":20161382,"id":99480330,"diff_hunk":"@@ -138,6 +138,11 @@ public void add(Object value) {\n       };\n \n       Class<?> fieldClass = fields.get(avroField.name());\n+      if ((null != fieldClass) && (Modifier.isAbstract(fieldClass.getModifiers()) ||\n+          Modifier.isInterface(fieldClass.getModifiers()) ||\n+          fieldClass.equals(Object.class)) ) {\n+        fieldClass = null;\n+      }","path":"parquet-avro/src/main/java/org/apache/parquet/avro/AvroRecordConverter.java","position":8,"original_position":8,"commit_id":"26a428688c27d57944c9a9f4b193af43e8759653","original_commit_id":"26a428688c27d57944c9a9f4b193af43e8759653","user":{"login":"aeroevan","id":44744,"avatar_url":"https://avatars.githubusercontent.com/u/44744?v=3","gravatar_id":"","url":"https://api.github.com/users/aeroevan","html_url":"https://github.com/aeroevan","followers_url":"https://api.github.com/users/aeroevan/followers","following_url":"https://api.github.com/users/aeroevan/following{/other_user}","gists_url":"https://api.github.com/users/aeroevan/gists{/gist_id}","starred_url":"https://api.github.com/users/aeroevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeroevan/subscriptions","organizations_url":"https://api.github.com/users/aeroevan/orgs","repos_url":"https://api.github.com/users/aeroevan/repos","events_url":"https://api.github.com/users/aeroevan/events{/privacy}","received_events_url":"https://api.github.com/users/aeroevan/received_events","type":"User","site_admin":false},"body":"We were chatting on slack about the full reasoning.","created_at":"2017-02-05T03:06:01Z","updated_at":"2017-02-05T03:06:01Z","html_url":"https://github.com/apache/parquet-mr/pull/403#discussion_r99480330","pull_request_url":"https://api.github.com/repos/apache/parquet-mr/pulls/403","_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/comments/99480330"},"html":{"href":"https://github.com/apache/parquet-mr/pull/403#discussion_r99480330"},"pull_request":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/403"}}},"pull_request":{"url":"https://api.github.com/repos/apache/parquet-mr/pulls/403","id":104231108,"html_url":"https://github.com/apache/parquet-mr/pull/403","diff_url":"https://github.com/apache/parquet-mr/pull/403.diff","patch_url":"https://github.com/apache/parquet-mr/pull/403.patch","issue_url":"https://api.github.com/repos/apache/parquet-mr/issues/403","number":403,"state":"open","locked":false,"title":"PARQUET-856: Do not pass knownClass if it is abstract/interface/Object.","user":{"login":"aeroevan","id":44744,"avatar_url":"https://avatars.githubusercontent.com/u/44744?v=3","gravatar_id":"","url":"https://api.github.com/users/aeroevan","html_url":"https://github.com/aeroevan","followers_url":"https://api.github.com/users/aeroevan/followers","following_url":"https://api.github.com/users/aeroevan/following{/other_user}","gists_url":"https://api.github.com/users/aeroevan/gists{/gist_id}","starred_url":"https://api.github.com/users/aeroevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeroevan/subscriptions","organizations_url":"https://api.github.com/users/aeroevan/orgs","repos_url":"https://api.github.com/users/aeroevan/repos","events_url":"https://api.github.com/users/aeroevan/events{/privacy}","received_events_url":"https://api.github.com/users/aeroevan/received_events","type":"User","site_admin":false},"body":"Fixes a very small corner case in parquet-avro if reflection of abstract generic fields is used.","created_at":"2017-02-01T21:58:40Z","updated_at":"2017-02-05T03:06:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0a9ea079ba5b9301bf2f6974940f96ed7a1a787","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/parquet-mr/pulls/403/commits","review_comments_url":"https://api.github.com/repos/apache/parquet-mr/pulls/403/comments","review_comment_url":"https://api.github.com/repos/apache/parquet-mr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/parquet-mr/issues/403/comments","statuses_url":"https://api.github.com/repos/apache/parquet-mr/statuses/26a428688c27d57944c9a9f4b193af43e8759653","head":{"label":"aeroevan:bugfix/PARQUET-856","ref":"bugfix/PARQUET-856","sha":"26a428688c27d57944c9a9f4b193af43e8759653","user":{"login":"aeroevan","id":44744,"avatar_url":"https://avatars.githubusercontent.com/u/44744?v=3","gravatar_id":"","url":"https://api.github.com/users/aeroevan","html_url":"https://github.com/aeroevan","followers_url":"https://api.github.com/users/aeroevan/followers","following_url":"https://api.github.com/users/aeroevan/following{/other_user}","gists_url":"https://api.github.com/users/aeroevan/gists{/gist_id}","starred_url":"https://api.github.com/users/aeroevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeroevan/subscriptions","organizations_url":"https://api.github.com/users/aeroevan/orgs","repos_url":"https://api.github.com/users/aeroevan/repos","events_url":"https://api.github.com/users/aeroevan/events{/privacy}","received_events_url":"https://api.github.com/users/aeroevan/received_events","type":"User","site_admin":false},"repo":{"id":80668390,"name":"parquet-mr","full_name":"aeroevan/parquet-mr","owner":{"login":"aeroevan","id":44744,"avatar_url":"https://avatars.githubusercontent.com/u/44744?v=3","gravatar_id":"","url":"https://api.github.com/users/aeroevan","html_url":"https://github.com/aeroevan","followers_url":"https://api.github.com/users/aeroevan/followers","following_url":"https://api.github.com/users/aeroevan/following{/other_user}","gists_url":"https://api.github.com/users/aeroevan/gists{/gist_id}","starred_url":"https://api.github.com/users/aeroevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeroevan/subscriptions","organizations_url":"https://api.github.com/users/aeroevan/orgs","repos_url":"https://api.github.com/users/aeroevan/repos","events_url":"https://api.github.com/users/aeroevan/events{/privacy}","received_events_url":"https://api.github.com/users/aeroevan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aeroevan/parquet-mr","description":"Mirror of Apache Parquet","fork":true,"url":"https://api.github.com/repos/aeroevan/parquet-mr","forks_url":"https://api.github.com/repos/aeroevan/parquet-mr/forks","keys_url":"https://api.github.com/repos/aeroevan/parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeroevan/parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeroevan/parquet-mr/teams","hooks_url":"https://api.github.com/repos/aeroevan/parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/aeroevan/parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/aeroevan/parquet-mr/events","assignees_url":"https://api.github.com/repos/aeroevan/parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/aeroevan/parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/aeroevan/parquet-mr/tags","blobs_url":"https://api.github.com/repos/aeroevan/parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeroevan/parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeroevan/parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeroevan/parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeroevan/parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/aeroevan/parquet-mr/languages","stargazers_url":"https://api.github.com/repos/aeroevan/parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/aeroevan/parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/aeroevan/parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/aeroevan/parquet-mr/subscription","commits_url":"https://api.github.com/repos/aeroevan/parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeroevan/parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeroevan/parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeroevan/parquet-mr/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeroevan/parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/aeroevan/parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeroevan/parquet-mr/merges","archive_url":"https://api.github.com/repos/aeroevan/parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeroevan/parquet-mr/downloads","issues_url":"https://api.github.com/repos/aeroevan/parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/aeroevan/parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/aeroevan/parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/aeroevan/parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeroevan/parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/aeroevan/parquet-mr/releases{/id}","deployments_url":"https://api.github.com/repos/aeroevan/parquet-mr/deployments","created_at":"2017-02-01T21:54:55Z","updated_at":"2017-02-01T21:54:59Z","pushed_at":"2017-02-01T21:57:16Z","git_url":"git://github.com/aeroevan/parquet-mr.git","ssh_url":"git@github.com:aeroevan/parquet-mr.git","clone_url":"https://github.com/aeroevan/parquet-mr.git","svn_url":"https://github.com/aeroevan/parquet-mr","homepage":null,"size":14416,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2fd62ee4d524c270764e9b91dca72e5cf1a005b7","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20675636,"name":"parquet-mr","full_name":"apache/parquet-mr","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/parquet-mr","description":"Mirror of Apache Parquet","fork":false,"url":"https://api.github.com/repos/apache/parquet-mr","forks_url":"https://api.github.com/repos/apache/parquet-mr/forks","keys_url":"https://api.github.com/repos/apache/parquet-mr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/parquet-mr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/parquet-mr/teams","hooks_url":"https://api.github.com/repos/apache/parquet-mr/hooks","issue_events_url":"https://api.github.com/repos/apache/parquet-mr/issues/events{/number}","events_url":"https://api.github.com/repos/apache/parquet-mr/events","assignees_url":"https://api.github.com/repos/apache/parquet-mr/assignees{/user}","branches_url":"https://api.github.com/repos/apache/parquet-mr/branches{/branch}","tags_url":"https://api.github.com/repos/apache/parquet-mr/tags","blobs_url":"https://api.github.com/repos/apache/parquet-mr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/parquet-mr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/parquet-mr/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/parquet-mr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/parquet-mr/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/parquet-mr/languages","stargazers_url":"https://api.github.com/repos/apache/parquet-mr/stargazers","contributors_url":"https://api.github.com/repos/apache/parquet-mr/contributors","subscribers_url":"https://api.github.com/repos/apache/parquet-mr/subscribers","subscription_url":"https://api.github.com/repos/apache/parquet-mr/subscription","commits_url":"https://api.github.com/repos/apache/parquet-mr/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/parquet-mr/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/parquet-mr/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/parquet-mr/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/parquet-mr/contents/{+path}","compare_url":"https://api.github.com/repos/apache/parquet-mr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/parquet-mr/merges","archive_url":"https://api.github.com/repos/apache/parquet-mr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/parquet-mr/downloads","issues_url":"https://api.github.com/repos/apache/parquet-mr/issues{/number}","pulls_url":"https://api.github.com/repos/apache/parquet-mr/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/parquet-mr/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/parquet-mr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/parquet-mr/labels{/name}","releases_url":"https://api.github.com/repos/apache/parquet-mr/releases{/id}","deployments_url":"https://api.github.com/repos/apache/parquet-mr/deployments","created_at":"2014-06-10T07:00:07Z","updated_at":"2017-02-02T04:29:17Z","pushed_at":"2017-02-02T19:09:08Z","git_url":"git://github.com/apache/parquet-mr.git","ssh_url":"git@github.com:apache/parquet-mr.git","clone_url":"https://github.com/apache/parquet-mr.git","svn_url":"https://github.com/apache/parquet-mr","homepage":null,"size":14406,"stargazers_count":345,"watchers_count":345,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":288,"mirror_url":"git://git.apache.org/parquet-mr.git","open_issues_count":52,"forks":288,"open_issues":52,"watchers":345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/403"},"html":{"href":"https://github.com/apache/parquet-mr/pull/403"},"issue":{"href":"https://api.github.com/repos/apache/parquet-mr/issues/403"},"comments":{"href":"https://api.github.com/repos/apache/parquet-mr/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/parquet-mr/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/apache/parquet-mr/statuses/26a428688c27d57944c9a9f4b193af43e8759653"}}}}
{"actor":{"display_login":"aeroevan"}}