{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/16589","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/16589/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/16589/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/16589/events","html_url":"https://github.com/openshift/origin/pull/16589","id":261128112,"number":16589,"title":"individual diagnostic parameters","user":{"login":"sosiouxme","id":29690,"avatar_url":"https://avatars1.githubusercontent.com/u/29690?v=4","gravatar_id":"","url":"https://api.github.com/users/sosiouxme","html_url":"https://github.com/sosiouxme","followers_url":"https://api.github.com/users/sosiouxme/followers","following_url":"https://api.github.com/users/sosiouxme/following{/other_user}","gists_url":"https://api.github.com/users/sosiouxme/gists{/gist_id}","starred_url":"https://api.github.com/users/sosiouxme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosiouxme/subscriptions","organizations_url":"https://api.github.com/users/sosiouxme/orgs","repos_url":"https://api.github.com/users/sosiouxme/repos","events_url":"https://api.github.com/users/sosiouxme/events{/privacy}","received_events_url":"https://api.github.com/users/sosiouxme/received_events","type":"User","site_admin":false},"labels":[{"id":640548662,"url":"https://api.github.com/repos/openshift/origin/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"rajatchopra","id":982221,"avatar_url":"https://avatars2.githubusercontent.com/u/982221?v=4","gravatar_id":"","url":"https://api.github.com/users/rajatchopra","html_url":"https://github.com/rajatchopra","followers_url":"https://api.github.com/users/rajatchopra/followers","following_url":"https://api.github.com/users/rajatchopra/following{/other_user}","gists_url":"https://api.github.com/users/rajatchopra/gists{/gist_id}","starred_url":"https://api.github.com/users/rajatchopra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajatchopra/subscriptions","organizations_url":"https://api.github.com/users/rajatchopra/orgs","repos_url":"https://api.github.com/users/rajatchopra/repos","events_url":"https://api.github.com/users/rajatchopra/events{/privacy}","received_events_url":"https://api.github.com/users/rajatchopra/received_events","type":"User","site_admin":false},"assignees":[{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars0.githubusercontent.com/u/158611?v=4","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},{"login":"rajatchopra","id":982221,"avatar_url":"https://avatars2.githubusercontent.com/u/982221?v=4","gravatar_id":"","url":"https://api.github.com/users/rajatchopra","html_url":"https://github.com/rajatchopra","followers_url":"https://api.github.com/users/rajatchopra/followers","following_url":"https://api.github.com/users/rajatchopra/following{/other_user}","gists_url":"https://api.github.com/users/rajatchopra/gists{/gist_id}","starred_url":"https://api.github.com/users/rajatchopra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rajatchopra/subscriptions","organizations_url":"https://api.github.com/users/rajatchopra/orgs","repos_url":"https://api.github.com/users/rajatchopra/repos","events_url":"https://api.github.com/users/rajatchopra/events{/privacy}","received_events_url":"https://api.github.com/users/rajatchopra/received_events","type":"User","site_admin":false}],"milestone":null,"comments":20,"created_at":"2017-09-27T21:45:29Z","updated_at":"2017-11-24T22:26:54Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/16589","html_url":"https://github.com/openshift/origin/pull/16589","diff_url":"https://github.com/openshift/origin/pull/16589.diff","patch_url":"https://github.com/openshift/origin/pull/16589.patch"},"body":"This addresses https://github.com/openshift/origin/issues/14640 by giving individual diagnostics the ability to receive parameters without defining any more flags (need this anyway for the app-create diagnostic I'm working on). It also deprecates the existing flags for NetworkCheck as well as the config envvar for EtcdWriteVolume in favor of the new parameter scheme.\r\n\r\n```\r\n$ oc adm diagnostics -h\r\nThis utility helps troubleshoot and diagnose known problems. It runs diagnostics using a client and/or the state of a\r\nrunning master / node host. \r\n\r\n...\r\n\r\nDiagnostics may be individually run by passing diagnostic name(s) as arguments. \r\n\r\n  oc adm diagnostics DiagnosticName\r\n  \r\nDiagnostic parameters may be given values similarly: \r\n\r\n  oc adm diagnostics DiagnosticName.parameter=value\r\n  \r\n...\r\n\r\nOptions:\r\n      --cluster-context='': Client context to use for cluster administrator\r\n      --config='': Path to the config file to use for CLI requests.\r\n      --context='': The name of the kubeconfig context to use\r\n  -l, --diaglevel=1: Level of diagnostic output: 4: Error, 3: Warn, 2: Notice, 1: Info, 0: Debug\r\n      --host=false: If true, look for systemd and journald units even without master/node config\r\n      --images='openshift/origin-${component}:${version}': Image template for DiagnosticPod to use in creating a pod\r\n      --latest-images=false: If true, when expanding the image template, use latest version, not release version\r\n      --list-params=false: List parameters for specified diagnostic(s) and exit\r\n      --loglevel=0: Set the level of log output (0-10)\r\n      --logspec='': Set per module logging with file|pattern=LEVEL,...\r\n      --master-config='': Path to master config file (implies --host)\r\n      --node-config='': Path to node config file (implies --host)\r\n      --prevent-modification=false: If true, may be set to prevent diagnostics making any changes via the API\r\n\r\n$ oc adm diagnostics  NetworkCheck --list-params\r\n[Note] Determining if client configuration exists for client/cluster diagnostics\r\nInfo:  Successfully read a client config file at '/home/lmeyer/.kube/config'\r\n\r\nInfo:  Valid parameters for NetworkCheck are:\r\n         logDir: Path to store diagnostic results in case of errors (default /tmp/openshift/)\r\n         podImage: Image to use for diagnostic pod (default openshift/origin:v3.7.0-alpha.1)\r\n         podPort: Serving port on the diagnostic test pod (default 8080)\r\n         podProtocol: Protocol used to connect to diagnostic test pod (default TCP)\r\n         testPodImage: Image to use for diagnostic test pod (default openshift/origin-deployer:v3.7.0-alpha.1)\r\n\r\n$ oc adm diagnostics  EtcdWriteVolume EtcdWriteVolume.duration=10s\r\n[Note] Determining if client configuration exists for client/cluster diagnostics\r\nInfo:  Successfully read a client config file at '/root/.kube/config'\r\n\r\n[Note] Running diagnostic: EtcdWriteVolume\r\n       Description: Check the volume of writes against etcd and classify them by operation and key for 10s\r\n       \r\nInfo:  Measured 0.7 writes/sec\r\n       /                                                                                      7 100.0%\r\n       /v3:PUT                                                                                7 100.0%\r\n```"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/346902348","html_url":"https://github.com/openshift/origin/pull/16589#issuecomment-346902348","issue_url":"https://api.github.com/repos/openshift/origin/issues/16589","id":346902348,"user":{"login":"openshift-ci-robot","id":30189103,"avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2017-11-24T22:26:54Z","updated_at":"2017-11-24T22:26:54Z","author_association":"NONE","body":"@sosiouxme: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/openshift-jenkins/verify | 820a23714f9bf280d3dbf455afa0377aa1f00d0b | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16589/test_pull_request_origin_verify/5942/) | `/test verify`\nci/openshift-jenkins/extended_conformance_install | 820a23714f9bf280d3dbf455afa0377aa1f00d0b | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/16589/test_pull_request_origin_extended_conformance_install/2924/) | `/test extended_conformance_install`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/16589). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/sosiouxme). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/origin/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}