{"action":"created","comment":{"url":"https://api.github.com/repos/alertlogic/cwe-collector/pulls/comments/156632771","pull_request_review_id":83139987,"id":156632771,"diff_hunk":"@@ -338,7 +379,7 @@\n             \"DependsOn\": [\n                 \"LambdaKmsKey\",\n                 \"EncryptLambdaFunction\",\n-                \"EncryptLambdaPolicy\"\n+                \"BasicLambdaPolicy\"","path":"cfn/guardduty.template","position":129,"original_position":129,"commit_id":"c04b39cd117d065abb6f4bda988d37cce7be4491","original_commit_id":"23af3032d1dacb525b275acbd9016f554fa190e6","user":{"login":"kkuzmin","id":6872804,"avatar_url":"https://avatars3.githubusercontent.com/u/6872804?v=4","gravatar_id":"","url":"https://api.github.com/users/kkuzmin","html_url":"https://github.com/kkuzmin","followers_url":"https://api.github.com/users/kkuzmin/followers","following_url":"https://api.github.com/users/kkuzmin/following{/other_user}","gists_url":"https://api.github.com/users/kkuzmin/gists{/gist_id}","starred_url":"https://api.github.com/users/kkuzmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkuzmin/subscriptions","organizations_url":"https://api.github.com/users/kkuzmin/orgs","repos_url":"https://api.github.com/users/kkuzmin/repos","events_url":"https://api.github.com/users/kkuzmin/events{/privacy}","received_events_url":"https://api.github.com/users/kkuzmin/received_events","type":"User","site_admin":false},"body":"`BasicLambdaPolicy` can't be added as a dependency to `EndpointAPIs` because there is a circle in this case:\r\n```\r\nEncryptLambdaFunction -> EndpointAPIs -> BasicLambdaPolicy -> EncryptLambdaFunction\r\n```","created_at":"2017-12-13T11:31:53Z","updated_at":"2017-12-13T11:31:53Z","html_url":"https://github.com/alertlogic/cwe-collector/pull/16#discussion_r156632771","pull_request_url":"https://api.github.com/repos/alertlogic/cwe-collector/pulls/16","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/alertlogic/cwe-collector/pulls/comments/156632771"},"html":{"href":"https://github.com/alertlogic/cwe-collector/pull/16#discussion_r156632771"},"pull_request":{"href":"https://api.github.com/repos/alertlogic/cwe-collector/pulls/16"}},"in_reply_to_id":156173934},"pull_request":{"url":"https://api.github.com/repos/alertlogic/cwe-collector/pulls/16","id":156945772,"html_url":"https://github.com/alertlogic/cwe-collector/pull/16","diff_url":"https://github.com/alertlogic/cwe-collector/pull/16.diff","patch_url":"https://github.com/alertlogic/cwe-collector/pull/16.patch","issue_url":"https://api.github.com/repos/alertlogic/cwe-collector/issues/16","number":16,"state":"open","locked":false,"title":"Use basic lambda policy for GetEndpoints function.","user":{"login":"kkuzmin","id":6872804,"avatar_url":"https://avatars3.githubusercontent.com/u/6872804?v=4","gravatar_id":"","url":"https://api.github.com/users/kkuzmin","html_url":"https://github.com/kkuzmin","followers_url":"https://api.github.com/users/kkuzmin/followers","following_url":"https://api.github.com/users/kkuzmin/following{/other_user}","gists_url":"https://api.github.com/users/kkuzmin/gists{/gist_id}","starred_url":"https://api.github.com/users/kkuzmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkuzmin/subscriptions","organizations_url":"https://api.github.com/users/kkuzmin/orgs","repos_url":"https://api.github.com/users/kkuzmin/repos","events_url":"https://api.github.com/users/kkuzmin/events{/privacy}","received_events_url":"https://api.github.com/users/kkuzmin/received_events","type":"User","site_admin":false},"body":"### Problem Description\r\n`GetEndpointsLambdaFunction` lacks permissions for creating CW log group. Therefore all all log events for this function are missed which makes it more difficult to trace any invocation issues.\r\n\r\n### Solution Description\r\nIntroduce `BasicLambdaRole` and `BasicLambdaPolicy` which allows `GetEndpointsLambdaFunction` and `EncryptLambdaFunction` to create CW logs groups/streams and put log events.\r\n\r\n### Reviewers\r\n@andrey-smirnov @ikemsley @tomdos @alexturkin ","created_at":"2017-12-07T09:43:03Z","updated_at":"2017-12-13T11:31:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1c1b349c8813aa1adb0546b46c271fe30f9d188","assignee":{"login":"alexturkin","id":3668455,"avatar_url":"https://avatars2.githubusercontent.com/u/3668455?v=4","gravatar_id":"","url":"https://api.github.com/users/alexturkin","html_url":"https://github.com/alexturkin","followers_url":"https://api.github.com/users/alexturkin/followers","following_url":"https://api.github.com/users/alexturkin/following{/other_user}","gists_url":"https://api.github.com/users/alexturkin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexturkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexturkin/subscriptions","organizations_url":"https://api.github.com/users/alexturkin/orgs","repos_url":"https://api.github.com/users/alexturkin/repos","events_url":"https://api.github.com/users/alexturkin/events{/privacy}","received_events_url":"https://api.github.com/users/alexturkin/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexturkin","id":3668455,"avatar_url":"https://avatars2.githubusercontent.com/u/3668455?v=4","gravatar_id":"","url":"https://api.github.com/users/alexturkin","html_url":"https://github.com/alexturkin","followers_url":"https://api.github.com/users/alexturkin/followers","following_url":"https://api.github.com/users/alexturkin/following{/other_user}","gists_url":"https://api.github.com/users/alexturkin/gists{/gist_id}","starred_url":"https://api.github.com/users/alexturkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexturkin/subscriptions","organizations_url":"https://api.github.com/users/alexturkin/orgs","repos_url":"https://api.github.com/users/alexturkin/repos","events_url":"https://api.github.com/users/alexturkin/events{/privacy}","received_events_url":"https://api.github.com/users/alexturkin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/alertlogic/cwe-collector/pulls/16/commits","review_comments_url":"https://api.github.com/repos/alertlogic/cwe-collector/pulls/16/comments","review_comment_url":"https://api.github.com/repos/alertlogic/cwe-collector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alertlogic/cwe-collector/issues/16/comments","statuses_url":"https://api.github.com/repos/alertlogic/cwe-collector/statuses/c04b39cd117d065abb6f4bda988d37cce7be4491","head":{"label":"kkuzmin:fix_cfn","ref":"fix_cfn","sha":"c04b39cd117d065abb6f4bda988d37cce7be4491","user":{"login":"kkuzmin","id":6872804,"avatar_url":"https://avatars3.githubusercontent.com/u/6872804?v=4","gravatar_id":"","url":"https://api.github.com/users/kkuzmin","html_url":"https://github.com/kkuzmin","followers_url":"https://api.github.com/users/kkuzmin/followers","following_url":"https://api.github.com/users/kkuzmin/following{/other_user}","gists_url":"https://api.github.com/users/kkuzmin/gists{/gist_id}","starred_url":"https://api.github.com/users/kkuzmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkuzmin/subscriptions","organizations_url":"https://api.github.com/users/kkuzmin/orgs","repos_url":"https://api.github.com/users/kkuzmin/repos","events_url":"https://api.github.com/users/kkuzmin/events{/privacy}","received_events_url":"https://api.github.com/users/kkuzmin/received_events","type":"User","site_admin":false},"repo":{"id":113191866,"name":"cwe-collector","full_name":"kkuzmin/cwe-collector","owner":{"login":"kkuzmin","id":6872804,"avatar_url":"https://avatars3.githubusercontent.com/u/6872804?v=4","gravatar_id":"","url":"https://api.github.com/users/kkuzmin","html_url":"https://github.com/kkuzmin","followers_url":"https://api.github.com/users/kkuzmin/followers","following_url":"https://api.github.com/users/kkuzmin/following{/other_user}","gists_url":"https://api.github.com/users/kkuzmin/gists{/gist_id}","starred_url":"https://api.github.com/users/kkuzmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkuzmin/subscriptions","organizations_url":"https://api.github.com/users/kkuzmin/orgs","repos_url":"https://api.github.com/users/kkuzmin/repos","events_url":"https://api.github.com/users/kkuzmin/events{/privacy}","received_events_url":"https://api.github.com/users/kkuzmin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kkuzmin/cwe-collector","description":"AWS CloudWatch Events Collector","fork":true,"url":"https://api.github.com/repos/kkuzmin/cwe-collector","forks_url":"https://api.github.com/repos/kkuzmin/cwe-collector/forks","keys_url":"https://api.github.com/repos/kkuzmin/cwe-collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkuzmin/cwe-collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkuzmin/cwe-collector/teams","hooks_url":"https://api.github.com/repos/kkuzmin/cwe-collector/hooks","issue_events_url":"https://api.github.com/repos/kkuzmin/cwe-collector/issues/events{/number}","events_url":"https://api.github.com/repos/kkuzmin/cwe-collector/events","assignees_url":"https://api.github.com/repos/kkuzmin/cwe-collector/assignees{/user}","branches_url":"https://api.github.com/repos/kkuzmin/cwe-collector/branches{/branch}","tags_url":"https://api.github.com/repos/kkuzmin/cwe-collector/tags","blobs_url":"https://api.github.com/repos/kkuzmin/cwe-collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkuzmin/cwe-collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkuzmin/cwe-collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkuzmin/cwe-collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkuzmin/cwe-collector/statuses/{sha}","languages_url":"https://api.github.com/repos/kkuzmin/cwe-collector/languages","stargazers_url":"https://api.github.com/repos/kkuzmin/cwe-collector/stargazers","contributors_url":"https://api.github.com/repos/kkuzmin/cwe-collector/contributors","subscribers_url":"https://api.github.com/repos/kkuzmin/cwe-collector/subscribers","subscription_url":"https://api.github.com/repos/kkuzmin/cwe-collector/subscription","commits_url":"https://api.github.com/repos/kkuzmin/cwe-collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkuzmin/cwe-collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkuzmin/cwe-collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkuzmin/cwe-collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkuzmin/cwe-collector/contents/{+path}","compare_url":"https://api.github.com/repos/kkuzmin/cwe-collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkuzmin/cwe-collector/merges","archive_url":"https://api.github.com/repos/kkuzmin/cwe-collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkuzmin/cwe-collector/downloads","issues_url":"https://api.github.com/repos/kkuzmin/cwe-collector/issues{/number}","pulls_url":"https://api.github.com/repos/kkuzmin/cwe-collector/pulls{/number}","milestones_url":"https://api.github.com/repos/kkuzmin/cwe-collector/milestones{/number}","notifications_url":"https://api.github.com/repos/kkuzmin/cwe-collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkuzmin/cwe-collector/labels{/name}","releases_url":"https://api.github.com/repos/kkuzmin/cwe-collector/releases{/id}","deployments_url":"https://api.github.com/repos/kkuzmin/cwe-collector/deployments","created_at":"2017-12-05T14:23:45Z","updated_at":"2017-12-05T14:23:46Z","pushed_at":"2017-12-12T13:08:32Z","git_url":"git://github.com/kkuzmin/cwe-collector.git","ssh_url":"git@github.com:kkuzmin/cwe-collector.git","clone_url":"https://github.com/kkuzmin/cwe-collector.git","svn_url":"https://github.com/kkuzmin/cwe-collector","homepage":"","size":80,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"integration"}},"base":{"label":"alertlogic:integration","ref":"integration","sha":"9459f7577da9a73bc03d0ae8ea634042369291f7","user":{"login":"alertlogic","id":1900859,"avatar_url":"https://avatars0.githubusercontent.com/u/1900859?v=4","gravatar_id":"","url":"https://api.github.com/users/alertlogic","html_url":"https://github.com/alertlogic","followers_url":"https://api.github.com/users/alertlogic/followers","following_url":"https://api.github.com/users/alertlogic/following{/other_user}","gists_url":"https://api.github.com/users/alertlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/alertlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alertlogic/subscriptions","organizations_url":"https://api.github.com/users/alertlogic/orgs","repos_url":"https://api.github.com/users/alertlogic/repos","events_url":"https://api.github.com/users/alertlogic/events{/privacy}","received_events_url":"https://api.github.com/users/alertlogic/received_events","type":"Organization","site_admin":false},"repo":{"id":110233754,"name":"cwe-collector","full_name":"alertlogic/cwe-collector","owner":{"login":"alertlogic","id":1900859,"avatar_url":"https://avatars0.githubusercontent.com/u/1900859?v=4","gravatar_id":"","url":"https://api.github.com/users/alertlogic","html_url":"https://github.com/alertlogic","followers_url":"https://api.github.com/users/alertlogic/followers","following_url":"https://api.github.com/users/alertlogic/following{/other_user}","gists_url":"https://api.github.com/users/alertlogic/gists{/gist_id}","starred_url":"https://api.github.com/users/alertlogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alertlogic/subscriptions","organizations_url":"https://api.github.com/users/alertlogic/orgs","repos_url":"https://api.github.com/users/alertlogic/repos","events_url":"https://api.github.com/users/alertlogic/events{/privacy}","received_events_url":"https://api.github.com/users/alertlogic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alertlogic/cwe-collector","description":"AWS CloudWatch Events Collector","fork":false,"url":"https://api.github.com/repos/alertlogic/cwe-collector","forks_url":"https://api.github.com/repos/alertlogic/cwe-collector/forks","keys_url":"https://api.github.com/repos/alertlogic/cwe-collector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alertlogic/cwe-collector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alertlogic/cwe-collector/teams","hooks_url":"https://api.github.com/repos/alertlogic/cwe-collector/hooks","issue_events_url":"https://api.github.com/repos/alertlogic/cwe-collector/issues/events{/number}","events_url":"https://api.github.com/repos/alertlogic/cwe-collector/events","assignees_url":"https://api.github.com/repos/alertlogic/cwe-collector/assignees{/user}","branches_url":"https://api.github.com/repos/alertlogic/cwe-collector/branches{/branch}","tags_url":"https://api.github.com/repos/alertlogic/cwe-collector/tags","blobs_url":"https://api.github.com/repos/alertlogic/cwe-collector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alertlogic/cwe-collector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alertlogic/cwe-collector/git/refs{/sha}","trees_url":"https://api.github.com/repos/alertlogic/cwe-collector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alertlogic/cwe-collector/statuses/{sha}","languages_url":"https://api.github.com/repos/alertlogic/cwe-collector/languages","stargazers_url":"https://api.github.com/repos/alertlogic/cwe-collector/stargazers","contributors_url":"https://api.github.com/repos/alertlogic/cwe-collector/contributors","subscribers_url":"https://api.github.com/repos/alertlogic/cwe-collector/subscribers","subscription_url":"https://api.github.com/repos/alertlogic/cwe-collector/subscription","commits_url":"https://api.github.com/repos/alertlogic/cwe-collector/commits{/sha}","git_commits_url":"https://api.github.com/repos/alertlogic/cwe-collector/git/commits{/sha}","comments_url":"https://api.github.com/repos/alertlogic/cwe-collector/comments{/number}","issue_comment_url":"https://api.github.com/repos/alertlogic/cwe-collector/issues/comments{/number}","contents_url":"https://api.github.com/repos/alertlogic/cwe-collector/contents/{+path}","compare_url":"https://api.github.com/repos/alertlogic/cwe-collector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alertlogic/cwe-collector/merges","archive_url":"https://api.github.com/repos/alertlogic/cwe-collector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alertlogic/cwe-collector/downloads","issues_url":"https://api.github.com/repos/alertlogic/cwe-collector/issues{/number}","pulls_url":"https://api.github.com/repos/alertlogic/cwe-collector/pulls{/number}","milestones_url":"https://api.github.com/repos/alertlogic/cwe-collector/milestones{/number}","notifications_url":"https://api.github.com/repos/alertlogic/cwe-collector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alertlogic/cwe-collector/labels{/name}","releases_url":"https://api.github.com/repos/alertlogic/cwe-collector/releases{/id}","deployments_url":"https://api.github.com/repos/alertlogic/cwe-collector/deployments","created_at":"2017-11-10T10:15:44Z","updated_at":"2017-11-29T05:47:23Z","pushed_at":"2017-12-12T13:08:33Z","git_url":"git://github.com/alertlogic/cwe-collector.git","ssh_url":"git@github.com:alertlogic/cwe-collector.git","clone_url":"https://github.com/alertlogic/cwe-collector.git","svn_url":"https://github.com/alertlogic/cwe-collector","homepage":"","size":73,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"integration"}},"_links":{"self":{"href":"https://api.github.com/repos/alertlogic/cwe-collector/pulls/16"},"html":{"href":"https://github.com/alertlogic/cwe-collector/pull/16"},"issue":{"href":"https://api.github.com/repos/alertlogic/cwe-collector/issues/16"},"comments":{"href":"https://api.github.com/repos/alertlogic/cwe-collector/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/alertlogic/cwe-collector/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/alertlogic/cwe-collector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alertlogic/cwe-collector/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/alertlogic/cwe-collector/statuses/c04b39cd117d065abb6f4bda988d37cce7be4491"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kkuzmin"}}