{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/lightbeam-we/pulls/comments/134902394","pull_request_review_id":58250506,"id":134902394,"diff_hunk":"@@ -220,34 +220,52 @@ main {\n }\n \n .toggle-switch {\n-  display: flex;\n+  display: inline-flex;\n   align-items: center;\n   justify-content: space-around;\n   height: 30px;\n-  width: 70px;\n-  margin-left: 10px;\n+  width: 55px;\n+  margin-left: 5px;\n   background-color: var(--secondary-color);\n-  border-radius: 2px;\n+  border-radius: 5px;\n+  position: relative;\n }\n \n-input[type=\"checkbox\"] {\n-  -moz-appearance: none;\n-  margin: 0;\n+.toggle-switch input{\n+  display: none;","path":"css/style.css","position":23,"original_position":23,"commit_id":"4c48f67408c59e6be2acdd0f1579c75cfd0b8707","original_commit_id":"4c48f67408c59e6be2acdd0f1579c75cfd0b8707","user":{"login":"jonathanKingston","id":338988,"avatar_url":"https://avatars3.githubusercontent.com/u/338988?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathanKingston","html_url":"https://github.com/jonathanKingston","followers_url":"https://api.github.com/users/jonathanKingston/followers","following_url":"https://api.github.com/users/jonathanKingston/following{/other_user}","gists_url":"https://api.github.com/users/jonathanKingston/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanKingston/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanKingston/subscriptions","organizations_url":"https://api.github.com/users/jonathanKingston/orgs","repos_url":"https://api.github.com/users/jonathanKingston/repos","events_url":"https://api.github.com/users/jonathanKingston/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanKingston/received_events","type":"User","site_admin":false},"body":"If you make the opacity not 0 can you see it? Style it like the switch instead?\r\n\r\nAlso I think the active is on the wrong element: `.toggle-switch:active` instead should be: `.toggle-switch input:active`\r\n\r\nSomething like:\r\n```\r\n.toggle-switch input {\r\n  -moz-appearance: none;\r\n}\r\n\r\n.toggle-switch input:checked::before {\r\n  ...\r\n}\r\n\r\n.toggle-switch input::after {\r\n  ...\r\n}\r\n\r\n.toggle-switch input:checked {\r\n  ...\r\n}\r\n\r\n.toggle-switch input:checked::after {\r\n  ...\r\n}\r\n\r\n.toggle-switch input:active {\r\n  border:1px solid var(--button-active-border-color);\r\n}\r\n```","created_at":"2017-08-24T00:23:36Z","updated_at":"2017-08-24T00:23:37Z","html_url":"https://github.com/mozilla/lightbeam-we/pull/170#discussion_r134902394","pull_request_url":"https://api.github.com/repos/mozilla/lightbeam-we/pulls/170","_links":{"self":{"href":"https://api.github.com/repos/mozilla/lightbeam-we/pulls/comments/134902394"},"html":{"href":"https://github.com/mozilla/lightbeam-we/pull/170#discussion_r134902394"},"pull_request":{"href":"https://api.github.com/repos/mozilla/lightbeam-we/pulls/170"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/lightbeam-we/pulls/170","id":137120005,"html_url":"https://github.com/mozilla/lightbeam-we/pull/170","diff_url":"https://github.com/mozilla/lightbeam-we/pull/170.diff","patch_url":"https://github.com/mozilla/lightbeam-we/pull/170.patch","issue_url":"https://api.github.com/repos/mozilla/lightbeam-we/issues/170","number":170,"state":"open","locked":false,"title":"#66 Changes proposed for getting the toggle button up","user":{"login":"laxmy","id":25521469,"avatar_url":"https://avatars2.githubusercontent.com/u/25521469?v=4","gravatar_id":"","url":"https://api.github.com/users/laxmy","html_url":"https://github.com/laxmy","followers_url":"https://api.github.com/users/laxmy/followers","following_url":"https://api.github.com/users/laxmy/following{/other_user}","gists_url":"https://api.github.com/users/laxmy/gists{/gist_id}","starred_url":"https://api.github.com/users/laxmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laxmy/subscriptions","organizations_url":"https://api.github.com/users/laxmy/orgs","repos_url":"https://api.github.com/users/laxmy/repos","events_url":"https://api.github.com/users/laxmy/events{/privacy}","received_events_url":"https://api.github.com/users/laxmy/received_events","type":"User","site_admin":false},"body":"Here are the changes I did to get the toggle button up. \r\nI have done it using css :before and :after to 'toggle'  like @jonathanKingston proposed to get the button and the 'on'-'off' label. I have also made changes to the button dimensions to make it look more like the original lightbeam switch.\r\nHope I used the right color.\r\nLet me know if this works.\r\n#66 Fix toggle button to work with CSS","created_at":"2017-08-23T02:49:47Z","updated_at":"2017-08-24T00:23:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58b806e8e786245303c4380b6e3b5895de2da6fb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/lightbeam-we/pulls/170/commits","review_comments_url":"https://api.github.com/repos/mozilla/lightbeam-we/pulls/170/comments","review_comment_url":"https://api.github.com/repos/mozilla/lightbeam-we/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/lightbeam-we/issues/170/comments","statuses_url":"https://api.github.com/repos/mozilla/lightbeam-we/statuses/4c48f67408c59e6be2acdd0f1579c75cfd0b8707","head":{"label":"laxmy:master","ref":"master","sha":"4c48f67408c59e6be2acdd0f1579c75cfd0b8707","user":{"login":"laxmy","id":25521469,"avatar_url":"https://avatars2.githubusercontent.com/u/25521469?v=4","gravatar_id":"","url":"https://api.github.com/users/laxmy","html_url":"https://github.com/laxmy","followers_url":"https://api.github.com/users/laxmy/followers","following_url":"https://api.github.com/users/laxmy/following{/other_user}","gists_url":"https://api.github.com/users/laxmy/gists{/gist_id}","starred_url":"https://api.github.com/users/laxmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laxmy/subscriptions","organizations_url":"https://api.github.com/users/laxmy/orgs","repos_url":"https://api.github.com/users/laxmy/repos","events_url":"https://api.github.com/users/laxmy/events{/privacy}","received_events_url":"https://api.github.com/users/laxmy/received_events","type":"User","site_admin":false},"repo":{"id":100642650,"name":"lightbeam-we","full_name":"laxmy/lightbeam-we","owner":{"login":"laxmy","id":25521469,"avatar_url":"https://avatars2.githubusercontent.com/u/25521469?v=4","gravatar_id":"","url":"https://api.github.com/users/laxmy","html_url":"https://github.com/laxmy","followers_url":"https://api.github.com/users/laxmy/followers","following_url":"https://api.github.com/users/laxmy/following{/other_user}","gists_url":"https://api.github.com/users/laxmy/gists{/gist_id}","starred_url":"https://api.github.com/users/laxmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laxmy/subscriptions","organizations_url":"https://api.github.com/users/laxmy/orgs","repos_url":"https://api.github.com/users/laxmy/repos","events_url":"https://api.github.com/users/laxmy/events{/privacy}","received_events_url":"https://api.github.com/users/laxmy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/laxmy/lightbeam-we","description":"Web Extension version of the Mozilla Lightbeam add-on","fork":true,"url":"https://api.github.com/repos/laxmy/lightbeam-we","forks_url":"https://api.github.com/repos/laxmy/lightbeam-we/forks","keys_url":"https://api.github.com/repos/laxmy/lightbeam-we/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laxmy/lightbeam-we/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laxmy/lightbeam-we/teams","hooks_url":"https://api.github.com/repos/laxmy/lightbeam-we/hooks","issue_events_url":"https://api.github.com/repos/laxmy/lightbeam-we/issues/events{/number}","events_url":"https://api.github.com/repos/laxmy/lightbeam-we/events","assignees_url":"https://api.github.com/repos/laxmy/lightbeam-we/assignees{/user}","branches_url":"https://api.github.com/repos/laxmy/lightbeam-we/branches{/branch}","tags_url":"https://api.github.com/repos/laxmy/lightbeam-we/tags","blobs_url":"https://api.github.com/repos/laxmy/lightbeam-we/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laxmy/lightbeam-we/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laxmy/lightbeam-we/git/refs{/sha}","trees_url":"https://api.github.com/repos/laxmy/lightbeam-we/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laxmy/lightbeam-we/statuses/{sha}","languages_url":"https://api.github.com/repos/laxmy/lightbeam-we/languages","stargazers_url":"https://api.github.com/repos/laxmy/lightbeam-we/stargazers","contributors_url":"https://api.github.com/repos/laxmy/lightbeam-we/contributors","subscribers_url":"https://api.github.com/repos/laxmy/lightbeam-we/subscribers","subscription_url":"https://api.github.com/repos/laxmy/lightbeam-we/subscription","commits_url":"https://api.github.com/repos/laxmy/lightbeam-we/commits{/sha}","git_commits_url":"https://api.github.com/repos/laxmy/lightbeam-we/git/commits{/sha}","comments_url":"https://api.github.com/repos/laxmy/lightbeam-we/comments{/number}","issue_comment_url":"https://api.github.com/repos/laxmy/lightbeam-we/issues/comments{/number}","contents_url":"https://api.github.com/repos/laxmy/lightbeam-we/contents/{+path}","compare_url":"https://api.github.com/repos/laxmy/lightbeam-we/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laxmy/lightbeam-we/merges","archive_url":"https://api.github.com/repos/laxmy/lightbeam-we/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laxmy/lightbeam-we/downloads","issues_url":"https://api.github.com/repos/laxmy/lightbeam-we/issues{/number}","pulls_url":"https://api.github.com/repos/laxmy/lightbeam-we/pulls{/number}","milestones_url":"https://api.github.com/repos/laxmy/lightbeam-we/milestones{/number}","notifications_url":"https://api.github.com/repos/laxmy/lightbeam-we/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laxmy/lightbeam-we/labels{/name}","releases_url":"https://api.github.com/repos/laxmy/lightbeam-we/releases{/id}","deployments_url":"https://api.github.com/repos/laxmy/lightbeam-we/deployments","created_at":"2017-08-17T20:28:29Z","updated_at":"2017-08-17T20:28:30Z","pushed_at":"2017-08-23T02:37:27Z","git_url":"git://github.com/laxmy/lightbeam-we.git","ssh_url":"git@github.com:laxmy/lightbeam-we.git","clone_url":"https://github.com/laxmy/lightbeam-we.git","svn_url":"https://github.com/laxmy/lightbeam-we","homepage":null,"size":772,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"a9651fcb35ccd3201f5b0d3fadc64e81ee635506","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":88814110,"name":"lightbeam-we","full_name":"mozilla/lightbeam-we","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/lightbeam-we","description":"Web Extension version of the Mozilla Lightbeam add-on","fork":false,"url":"https://api.github.com/repos/mozilla/lightbeam-we","forks_url":"https://api.github.com/repos/mozilla/lightbeam-we/forks","keys_url":"https://api.github.com/repos/mozilla/lightbeam-we/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/lightbeam-we/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/lightbeam-we/teams","hooks_url":"https://api.github.com/repos/mozilla/lightbeam-we/hooks","issue_events_url":"https://api.github.com/repos/mozilla/lightbeam-we/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/lightbeam-we/events","assignees_url":"https://api.github.com/repos/mozilla/lightbeam-we/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/lightbeam-we/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/lightbeam-we/tags","blobs_url":"https://api.github.com/repos/mozilla/lightbeam-we/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/lightbeam-we/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/lightbeam-we/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/lightbeam-we/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/lightbeam-we/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/lightbeam-we/languages","stargazers_url":"https://api.github.com/repos/mozilla/lightbeam-we/stargazers","contributors_url":"https://api.github.com/repos/mozilla/lightbeam-we/contributors","subscribers_url":"https://api.github.com/repos/mozilla/lightbeam-we/subscribers","subscription_url":"https://api.github.com/repos/mozilla/lightbeam-we/subscription","commits_url":"https://api.github.com/repos/mozilla/lightbeam-we/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/lightbeam-we/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/lightbeam-we/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/lightbeam-we/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/lightbeam-we/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/lightbeam-we/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/lightbeam-we/merges","archive_url":"https://api.github.com/repos/mozilla/lightbeam-we/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/lightbeam-we/downloads","issues_url":"https://api.github.com/repos/mozilla/lightbeam-we/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/lightbeam-we/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/lightbeam-we/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/lightbeam-we/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/lightbeam-we/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/lightbeam-we/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/lightbeam-we/deployments","created_at":"2017-04-20T02:55:56Z","updated_at":"2017-08-19T19:37:44Z","pushed_at":"2017-08-23T20:53:38Z","git_url":"git://github.com/mozilla/lightbeam-we.git","ssh_url":"git@github.com:mozilla/lightbeam-we.git","clone_url":"https://github.com/mozilla/lightbeam-we.git","svn_url":"https://github.com/mozilla/lightbeam-we","homepage":null,"size":790,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":52,"forks":6,"open_issues":52,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/lightbeam-we/pulls/170"},"html":{"href":"https://github.com/mozilla/lightbeam-we/pull/170"},"issue":{"href":"https://api.github.com/repos/mozilla/lightbeam-we/issues/170"},"comments":{"href":"https://api.github.com/repos/mozilla/lightbeam-we/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/lightbeam-we/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/lightbeam-we/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/lightbeam-we/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/lightbeam-we/statuses/4c48f67408c59e6be2acdd0f1579c75cfd0b8707"}}}}
{"actor":{"display_login":"jonathanKingston"}}