{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments/104790665","pull_request_review_id":25642973,"id":104790665,"diff_hunk":"@@ -38,24 +41,35 @@\n \tprivate final String dslText;\n \n \tpublic TaskDefinition(String name, String dsl) {\n+\t\tthis(name, dsl, false);\n+\t}\n+\n+\tTaskDefinition(String registeredAppName, String label, Map<String, String> properties) {\n+\t\tsuper(registeredAppName, label, properties);\n+\t\tthis.dslText = \"\";\n+\t\tproperties.put(\"spring.cloud.task.name\", registeredAppName);\n+\t}\n+\n+\tpublic TaskDefinition(String name, String dsl, boolean isComposedTask) {\n \t\tthis.dslText = dsl;\n-\t\tAppNode taskNode = new TaskParser(name, dsl).parse();\n-\t\tsetRegisteredAppName(taskNode.getName());\n \t\tMap<String, String> properties = new HashMap<>();\n-\t\tif (taskNode.hasArguments()) {\n-\t\t\tfor (ArgumentNode argumentNode : taskNode.getArguments()) {\n-\t\t\t\tproperties.put(argumentNode.getName(), argumentNode.getValue());\n+\t\tif(isComposedTask) {","path":"spring-cloud-dataflow-core/src/main/java/org/springframework/cloud/dataflow/core/TaskDefinition.java","position":45,"original_position":45,"commit_id":"82fddb3111890715a0e0071fb3caa44e7a43df20","original_commit_id":"0c2108470eda03fec9be864d4303497ce433da89","user":{"login":"cppwfs","id":695673,"avatar_url":"https://avatars2.githubusercontent.com/u/695673?v=3","gravatar_id":"","url":"https://api.github.com/users/cppwfs","html_url":"https://github.com/cppwfs","followers_url":"https://api.github.com/users/cppwfs/followers","following_url":"https://api.github.com/users/cppwfs/following{/other_user}","gists_url":"https://api.github.com/users/cppwfs/gists{/gist_id}","starred_url":"https://api.github.com/users/cppwfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppwfs/subscriptions","organizations_url":"https://api.github.com/users/cppwfs/orgs","repos_url":"https://api.github.com/users/cppwfs/repos","events_url":"https://api.github.com/users/cppwfs/events{/privacy}","received_events_url":"https://api.github.com/users/cppwfs/received_events","type":"User","site_admin":false},"body":"I think the primary issue is that a task definition is comprised of an app with supporting properties.  While a composed task is comprised of task definitions.  ","created_at":"2017-03-07T21:59:20Z","updated_at":"2017-03-07T21:59:20Z","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1218#discussion_r104790665","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1218","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments/104790665"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1218#discussion_r104790665"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1218"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1218","id":109355905,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1218","diff_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1218.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1218.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/1218","number":1218,"state":"open","locked":false,"title":"Adds Task Composed Restful API","user":{"login":"cppwfs","id":695673,"avatar_url":"https://avatars2.githubusercontent.com/u/695673?v=3","gravatar_id":"","url":"https://api.github.com/users/cppwfs","html_url":"https://github.com/cppwfs","followers_url":"https://api.github.com/users/cppwfs/followers","following_url":"https://api.github.com/users/cppwfs/following{/other_user}","gists_url":"https://api.github.com/users/cppwfs/gists{/gist_id}","starred_url":"https://api.github.com/users/cppwfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppwfs/subscriptions","organizations_url":"https://api.github.com/users/cppwfs/orgs","repos_url":"https://api.github.com/users/cppwfs/repos","events_url":"https://api.github.com/users/cppwfs/events{/privacy}","received_events_url":"https://api.github.com/users/cppwfs/received_events","type":"User","site_admin":false},"body":"resolves #1141 \r\nresolves #1142\r\n\r\nAdded support for task compose to the shell\r\nThis PR includes registering the task-composed-runner at SCDF start.  ","created_at":"2017-03-06T21:44:33Z","updated_at":"2017-03-07T21:59:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7aa4acd8425b8f6ea29fe4bb75a3a08a40504b5c","assignee":{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars1.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"assignees":[{"login":"ilayaperumalg","id":151690,"avatar_url":"https://avatars1.githubusercontent.com/u/151690?v=3","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1218/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1218/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/1218/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/82fddb3111890715a0e0071fb3caa44e7a43df20","head":{"label":"cppwfs:SCDF-1141","ref":"SCDF-1141","sha":"82fddb3111890715a0e0071fb3caa44e7a43df20","user":{"login":"cppwfs","id":695673,"avatar_url":"https://avatars2.githubusercontent.com/u/695673?v=3","gravatar_id":"","url":"https://api.github.com/users/cppwfs","html_url":"https://github.com/cppwfs","followers_url":"https://api.github.com/users/cppwfs/followers","following_url":"https://api.github.com/users/cppwfs/following{/other_user}","gists_url":"https://api.github.com/users/cppwfs/gists{/gist_id}","starred_url":"https://api.github.com/users/cppwfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppwfs/subscriptions","organizations_url":"https://api.github.com/users/cppwfs/orgs","repos_url":"https://api.github.com/users/cppwfs/repos","events_url":"https://api.github.com/users/cppwfs/events{/privacy}","received_events_url":"https://api.github.com/users/cppwfs/received_events","type":"User","site_admin":false},"repo":{"id":61755534,"name":"spring-cloud-dataflow","full_name":"cppwfs/spring-cloud-dataflow","owner":{"login":"cppwfs","id":695673,"avatar_url":"https://avatars2.githubusercontent.com/u/695673?v=3","gravatar_id":"","url":"https://api.github.com/users/cppwfs","html_url":"https://github.com/cppwfs","followers_url":"https://api.github.com/users/cppwfs/followers","following_url":"https://api.github.com/users/cppwfs/following{/other_user}","gists_url":"https://api.github.com/users/cppwfs/gists{/gist_id}","starred_url":"https://api.github.com/users/cppwfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppwfs/subscriptions","organizations_url":"https://api.github.com/users/cppwfs/orgs","repos_url":"https://api.github.com/users/cppwfs/repos","events_url":"https://api.github.com/users/cppwfs/events{/privacy}","received_events_url":"https://api.github.com/users/cppwfs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cppwfs/spring-cloud-dataflow","description":"Spring Cloud Data Flow provides orchestration for data microservices, including both stream and task processing","fork":true,"url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/cppwfs/spring-cloud-dataflow/deployments","created_at":"2016-06-22T22:25:54Z","updated_at":"2016-06-22T22:25:57Z","pushed_at":"2017-03-07T20:46:08Z","git_url":"git://github.com/cppwfs/spring-cloud-dataflow.git","ssh_url":"git@github.com:cppwfs/spring-cloud-dataflow.git","clone_url":"https://github.com/cppwfs/spring-cloud-dataflow.git","svn_url":"https://github.com/cppwfs/spring-cloud-dataflow","homepage":"http://cloud.spring.io/spring-cloud-dataflow/","size":17048,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"fe8bad1462b0650aad2c4878a616450f50c33bde","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars3.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":39469487,"name":"spring-cloud-dataflow","full_name":"spring-cloud/spring-cloud-dataflow","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars3.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow","description":"Spring Cloud Data Flow provides orchestration for microservices, including both stream and task/batch processing","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/deployments","created_at":"2015-07-21T20:56:11Z","updated_at":"2017-02-28T11:10:05Z","pushed_at":"2017-03-07T20:46:09Z","git_url":"git://github.com/spring-cloud/spring-cloud-dataflow.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-dataflow.git","clone_url":"https://github.com/spring-cloud/spring-cloud-dataflow.git","svn_url":"https://github.com/spring-cloud/spring-cloud-dataflow","homepage":"http://cloud.spring.io/spring-cloud-dataflow/","size":17056,"stargazers_count":141,"watchers_count":141,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":114,"mirror_url":null,"open_issues_count":130,"forks":114,"open_issues":130,"watchers":141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1218"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1218"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/1218"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/1218/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1218/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1218/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/82fddb3111890715a0e0071fb3caa44e7a43df20"}}}}
{"actor":{"display_login":"cppwfs"}}