{"action":"closed","number":36,"pull_request":{"url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/pulls/36","id":143193255,"html_url":"https://github.com/mdruskin/kubernetes-enterprise-control/pull/36","diff_url":"https://github.com/mdruskin/kubernetes-enterprise-control/pull/36.diff","patch_url":"https://github.com/mdruskin/kubernetes-enterprise-control/pull/36.patch","issue_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/issues/36","number":36,"state":"closed","locked":false,"title":"Fixes the initialization of the API server hostport for the authorizer.","user":{"login":"filmil","id":246576,"avatar_url":"https://avatars2.githubusercontent.com/u/246576?v=4","gravatar_id":"","url":"https://api.github.com/users/filmil","html_url":"https://github.com/filmil","followers_url":"https://api.github.com/users/filmil/followers","following_url":"https://api.github.com/users/filmil/following{/other_user}","gists_url":"https://api.github.com/users/filmil/gists{/gist_id}","starred_url":"https://api.github.com/users/filmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filmil/subscriptions","organizations_url":"https://api.github.com/users/filmil/orgs","repos_url":"https://api.github.com/users/filmil/repos","events_url":"https://api.github.com/users/filmil/events{/privacy}","received_events_url":"https://api.github.com/users/filmil/received_events","type":"User","site_admin":false},"body":"Using 'localhost' as the hostname for the API server hostport does not\r\nwork, because the apiserver certificate is not valid for localhost.  I\r\ndidn't notice this problem before because I only printed that there was\r\na HTTP OK status as result.  But not that the payload actually contains\r\nan error.\r\n\r\nLuckily, since minikube rewrites the API server certificate at start, we\r\ncan steal the information about cluster IP address and add that to\r\nthe authorizer's systemd configuration.\r\n\r\nBut, this requires that the init of systemd config be pushed until after\r\nthe minikube cluster is running, so this meant moving the systemd config\r\ncode accordingly.\r\n\r\nIn retrospect, d'oh!\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/mdruskin/kubernetes-enterprise-control/36)\n<!-- Reviewable:end -->\n","created_at":"2017-09-26T17:14:16Z","updated_at":"2017-09-26T20:33:47Z","closed_at":"2017-09-26T20:33:47Z","merged_at":"2017-09-26T20:33:47Z","merge_commit_sha":"b1ba04295cd9c273aca31390f613acd35dcd0a9f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/pulls/36/commits","review_comments_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/pulls/36/comments","review_comment_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/issues/36/comments","statuses_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/statuses/5207f61a50b95d627ec870b01e1ac324f51894b2","head":{"label":"filmil:f_fix_certs","ref":"f_fix_certs","sha":"5207f61a50b95d627ec870b01e1ac324f51894b2","user":{"login":"filmil","id":246576,"avatar_url":"https://avatars2.githubusercontent.com/u/246576?v=4","gravatar_id":"","url":"https://api.github.com/users/filmil","html_url":"https://github.com/filmil","followers_url":"https://api.github.com/users/filmil/followers","following_url":"https://api.github.com/users/filmil/following{/other_user}","gists_url":"https://api.github.com/users/filmil/gists{/gist_id}","starred_url":"https://api.github.com/users/filmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filmil/subscriptions","organizations_url":"https://api.github.com/users/filmil/orgs","repos_url":"https://api.github.com/users/filmil/repos","events_url":"https://api.github.com/users/filmil/events{/privacy}","received_events_url":"https://api.github.com/users/filmil/received_events","type":"User","site_admin":false},"repo":{"id":101784348,"name":"kubernetes-enterprise-control","full_name":"filmil/kubernetes-enterprise-control","owner":{"login":"filmil","id":246576,"avatar_url":"https://avatars2.githubusercontent.com/u/246576?v=4","gravatar_id":"","url":"https://api.github.com/users/filmil","html_url":"https://github.com/filmil","followers_url":"https://api.github.com/users/filmil/followers","following_url":"https://api.github.com/users/filmil/following{/other_user}","gists_url":"https://api.github.com/users/filmil/gists{/gist_id}","starred_url":"https://api.github.com/users/filmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filmil/subscriptions","organizations_url":"https://api.github.com/users/filmil/orgs","repos_url":"https://api.github.com/users/filmil/repos","events_url":"https://api.github.com/users/filmil/events{/privacy}","received_events_url":"https://api.github.com/users/filmil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/filmil/kubernetes-enterprise-control","description":null,"fork":true,"url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control","forks_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/forks","keys_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/teams","hooks_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/hooks","issue_events_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/issues/events{/number}","events_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/events","assignees_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/assignees{/user}","branches_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/branches{/branch}","tags_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/tags","blobs_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/statuses/{sha}","languages_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/languages","stargazers_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/stargazers","contributors_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/contributors","subscribers_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/subscribers","subscription_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/subscription","commits_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/issues/comments{/number}","contents_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/contents/{+path}","compare_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/merges","archive_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/downloads","issues_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/issues{/number}","pulls_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/pulls{/number}","milestones_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/milestones{/number}","notifications_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/labels{/name}","releases_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/releases{/id}","deployments_url":"https://api.github.com/repos/filmil/kubernetes-enterprise-control/deployments","created_at":"2017-08-29T16:45:13Z","updated_at":"2017-09-05T20:16:59Z","pushed_at":"2017-09-26T20:33:02Z","git_url":"git://github.com/filmil/kubernetes-enterprise-control.git","ssh_url":"git@github.com:filmil/kubernetes-enterprise-control.git","clone_url":"https://github.com/filmil/kubernetes-enterprise-control.git","svn_url":"https://github.com/filmil/kubernetes-enterprise-control","homepage":null,"size":166,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mdruskin:master","ref":"master","sha":"521d790687d75a5c11b59324f664a91d82d971e3","user":{"login":"mdruskin","id":17014149,"avatar_url":"https://avatars2.githubusercontent.com/u/17014149?v=4","gravatar_id":"","url":"https://api.github.com/users/mdruskin","html_url":"https://github.com/mdruskin","followers_url":"https://api.github.com/users/mdruskin/followers","following_url":"https://api.github.com/users/mdruskin/following{/other_user}","gists_url":"https://api.github.com/users/mdruskin/gists{/gist_id}","starred_url":"https://api.github.com/users/mdruskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdruskin/subscriptions","organizations_url":"https://api.github.com/users/mdruskin/orgs","repos_url":"https://api.github.com/users/mdruskin/repos","events_url":"https://api.github.com/users/mdruskin/events{/privacy}","received_events_url":"https://api.github.com/users/mdruskin/received_events","type":"User","site_admin":false},"repo":{"id":101702040,"name":"kubernetes-enterprise-control","full_name":"mdruskin/kubernetes-enterprise-control","owner":{"login":"mdruskin","id":17014149,"avatar_url":"https://avatars2.githubusercontent.com/u/17014149?v=4","gravatar_id":"","url":"https://api.github.com/users/mdruskin","html_url":"https://github.com/mdruskin","followers_url":"https://api.github.com/users/mdruskin/followers","following_url":"https://api.github.com/users/mdruskin/following{/other_user}","gists_url":"https://api.github.com/users/mdruskin/gists{/gist_id}","starred_url":"https://api.github.com/users/mdruskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdruskin/subscriptions","organizations_url":"https://api.github.com/users/mdruskin/orgs","repos_url":"https://api.github.com/users/mdruskin/repos","events_url":"https://api.github.com/users/mdruskin/events{/privacy}","received_events_url":"https://api.github.com/users/mdruskin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdruskin/kubernetes-enterprise-control","description":null,"fork":false,"url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control","forks_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/forks","keys_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/teams","hooks_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/hooks","issue_events_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/issues/events{/number}","events_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/events","assignees_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/assignees{/user}","branches_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/branches{/branch}","tags_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/tags","blobs_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/statuses/{sha}","languages_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/languages","stargazers_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/stargazers","contributors_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/contributors","subscribers_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/subscribers","subscription_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/subscription","commits_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/issues/comments{/number}","contents_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/contents/{+path}","compare_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/merges","archive_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/downloads","issues_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/issues{/number}","pulls_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/pulls{/number}","milestones_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/milestones{/number}","notifications_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/labels{/name}","releases_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/releases{/id}","deployments_url":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/deployments","created_at":"2017-08-29T00:55:06Z","updated_at":"2017-09-05T19:23:56Z","pushed_at":"2017-09-26T20:33:47Z","git_url":"git://github.com/mdruskin/kubernetes-enterprise-control.git","ssh_url":"git@github.com:mdruskin/kubernetes-enterprise-control.git","clone_url":"https://github.com/mdruskin/kubernetes-enterprise-control.git","svn_url":"https://github.com/mdruskin/kubernetes-enterprise-control","homepage":null,"size":177,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/pulls/36"},"html":{"href":"https://github.com/mdruskin/kubernetes-enterprise-control/pull/36"},"issue":{"href":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/issues/36"},"comments":{"href":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/mdruskin/kubernetes-enterprise-control/statuses/5207f61a50b95d627ec870b01e1ac324f51894b2"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"filmil","id":246576,"avatar_url":"https://avatars2.githubusercontent.com/u/246576?v=4","gravatar_id":"","url":"https://api.github.com/users/filmil","html_url":"https://github.com/filmil","followers_url":"https://api.github.com/users/filmil/followers","following_url":"https://api.github.com/users/filmil/following{/other_user}","gists_url":"https://api.github.com/users/filmil/gists{/gist_id}","starred_url":"https://api.github.com/users/filmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filmil/subscriptions","organizations_url":"https://api.github.com/users/filmil/orgs","repos_url":"https://api.github.com/users/filmil/repos","events_url":"https://api.github.com/users/filmil/events{/privacy}","received_events_url":"https://api.github.com/users/filmil/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":69,"deletions":18,"changed_files":8}}
{"actor":{"display_login":"filmil"}}