{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/16404","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/16404/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/16404/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/16404/events","html_url":"https://github.com/nodejs/node/pull/16404","id":267586804,"number":16404,"title":"process: add isExiting","user":{"login":"bengl","id":110455,"avatar_url":"https://avatars2.githubusercontent.com/u/110455?v=4","gravatar_id":"","url":"https://api.github.com/users/bengl","html_url":"https://github.com/bengl","followers_url":"https://api.github.com/users/bengl/followers","following_url":"https://api.github.com/users/bengl/following{/other_user}","gists_url":"https://api.github.com/users/bengl/gists{/gist_id}","starred_url":"https://api.github.com/users/bengl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengl/subscriptions","organizations_url":"https://api.github.com/users/bengl/orgs","repos_url":"https://api.github.com/users/bengl/repos","events_url":"https://api.github.com/users/bengl/events{/privacy}","received_events_url":"https://api.github.com/users/bengl/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"url":"https://api.github.com/repos/nodejs/node/labels/c++","name":"c++","color":"e11d21","default":false},{"id":281232761,"url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-23T08:45:47Z","updated_at":"2017-10-23T15:51:02Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/16404","html_url":"https://github.com/nodejs/node/pull/16404","diff_url":"https://github.com/nodejs/node/pull/16404.diff","patch_url":"https://github.com/nodejs/node/pull/16404.patch"},"body":"This replaces the previously undocumented `_exiting` property with a\r\nread-only property giving the same information. Setting the property is\r\nrestricted to internals, to prevent tampering. Tampering could affect\r\nnextTick behavior, for example.\r\n\r\nTwitter thread for context: https://twitter.com/bengl/status/922361992379166721\r\n\r\nIt may or may not make sense to keep `_exiting` around as an alias, if there's userland code using it. That's easy enough to do if reviewers would like that.\r\n\r\n/cc @addaleax @Trott \r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\nprocess"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/338704852","html_url":"https://github.com/nodejs/node/pull/16404#issuecomment-338704852","issue_url":"https://api.github.com/repos/nodejs/node/issues/16404","id":338704852,"user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"created_at":"2017-10-23T15:51:02Z","updated_at":"2017-10-23T15:51:02Z","author_association":"OWNER","body":"> Why expose this publicly now?\r\n\r\nFor one, it tells you whether there’s a chance async operations that you schedule will finish or not.\r\n\r\n> The only code that can run during exist is within `'exit'` event handlers, right?\r\n\r\nYes, it should tell you exactly that – whether you’re inside an `'exit'` handler or not."}}
{"actor":{"display_login":"addaleax"}}