{"action":"created","issue":{"url":"https://api.github.com/repos/elliotchance/c2go/issues/171","repository_url":"https://api.github.com/repos/elliotchance/c2go","labels_url":"https://api.github.com/repos/elliotchance/c2go/issues/171/labels{/name}","comments_url":"https://api.github.com/repos/elliotchance/c2go/issues/171/comments","events_url":"https://api.github.com/repos/elliotchance/c2go/issues/171/events","html_url":"https://github.com/elliotchance/c2go/pull/171","id":237353810,"number":171,"title":"Clarify preprocess error","user":{"login":"Konstantin8105","id":16690032,"avatar_url":"https://avatars1.githubusercontent.com/u/16690032?v=3","gravatar_id":"","url":"https://api.github.com/users/Konstantin8105","html_url":"https://github.com/Konstantin8105","followers_url":"https://api.github.com/users/Konstantin8105/followers","following_url":"https://api.github.com/users/Konstantin8105/following{/other_user}","gists_url":"https://api.github.com/users/Konstantin8105/gists{/gist_id}","starred_url":"https://api.github.com/users/Konstantin8105/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Konstantin8105/subscriptions","organizations_url":"https://api.github.com/users/Konstantin8105/orgs","repos_url":"https://api.github.com/users/Konstantin8105/repos","events_url":"https://api.github.com/users/Konstantin8105/events{/privacy}","received_events_url":"https://api.github.com/users/Konstantin8105/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2017-06-20T21:41:04Z","updated_at":"2017-06-22T11:00:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elliotchance/c2go/pulls/171","html_url":"https://github.com/elliotchance/c2go/pull/171","diff_url":"https://github.com/elliotchance/c2go/pull/171.diff","patch_url":"https://github.com/elliotchance/c2go/pull/171.patch"},"body":"\r\nFix #159\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/elliotchance/c2go/171)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/elliotchance/c2go/issues/comments/310347627","html_url":"https://github.com/elliotchance/c2go/pull/171#issuecomment-310347627","issue_url":"https://api.github.com/repos/elliotchance/c2go/issues/171","id":310347627,"user":{"login":"Konstantin8105","id":16690032,"avatar_url":"https://avatars1.githubusercontent.com/u/16690032?v=3","gravatar_id":"","url":"https://api.github.com/users/Konstantin8105","html_url":"https://github.com/Konstantin8105","followers_url":"https://api.github.com/users/Konstantin8105/followers","following_url":"https://api.github.com/users/Konstantin8105/following{/other_user}","gists_url":"https://api.github.com/users/Konstantin8105/gists{/gist_id}","starred_url":"https://api.github.com/users/Konstantin8105/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Konstantin8105/subscriptions","organizations_url":"https://api.github.com/users/Konstantin8105/orgs","repos_url":"https://api.github.com/users/Konstantin8105/repos","events_url":"https://api.github.com/users/Konstantin8105/events{/privacy}","received_events_url":"https://api.github.com/users/Konstantin8105/received_events","type":"User","site_admin":false},"created_at":"2017-06-22T11:00:21Z","updated_at":"2017-06-22T11:00:21Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 15 unresolved discussions.\n\n---\n\n*[.gitignore, line 18 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnBwDZdPQGiM3y6k8br:-KnEPxYKwyLqdkUHqfPt:bb6un1j) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/.gitignore#L18)):*\n<details><summary><i>Previously, elliotchance (Elliot Chance) wrote…</i></summary><blockquote>\n\nRathe then listing many different temporary file types that vim will produce there is a more general way to do it: https://stackoverflow.com/a/4824199/1470961\n</blockquote></details>\n\nDone\n\n---\n\n*[LICENSE, line 3 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnBwWi2FmrfFd07XLRQ:-KnEQ4nOb9UPKY_btZnS:bb6un1j) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/LICENSE#L3)):*\n<details><summary><i>Previously, elliotchance (Elliot Chance) wrote…</i></summary><blockquote>\n\nPlease remove your name. The copyright notice does not extend to general contributors.\n\nYou will appear as one of the contributors (one the PR is merged) here: https://github.com/elliotchance/c2go/graphs/contributors\n</blockquote></details>\n\nDone\n\n---\n\n*[main.go, line 227 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnBy91weEUH-1dMu-vg:-KnEQgS1v5R3TD8gvtVk:bb6un1j) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/main.go#L227)):*\n<details><summary><i>Previously, elliotchance (Elliot Chance) wrote…</i></summary><blockquote>\n\n`could not create file: %s%03d%s`\n</blockquote></details>\n\nDone\n\n---\n\n*[main.go, line 272 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnByHatTHcd3btRhJcp:-KnEQn5QTg64B9gpB0Zu:bb6un1j) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/main.go#L272)):*\n<details><summary><i>Previously, elliotchance (Elliot Chance) wrote…</i></summary><blockquote>\n\n\"ast\"\n</blockquote></details>\n\nDone\n\n---\n\n*[main.go, line 285 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnByPLA9elwWsqEJ4-j:-KnER7HllQ-axPsM929t:bb6un1j) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/main.go#L285)):*\n<details><summary><i>Previously, elliotchance (Elliot Chance) wrote…</i></summary><blockquote>\n\nThis code is duplicated for each case. Please move it after the `switch`.\n</blockquote></details>\n\nDone\n\n---\n\n*[main.go, line 292 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnByWO0Lz2vFpzxsnoH:-KnER9DZdTRiEAlnLc-d:bb6un1j) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/main.go#L292)):*\n<details><summary><i>Previously, elliotchance (Elliot Chance) wrote…</i></summary><blockquote>\n\n\"transpile\"\n</blockquote></details>\n\nDone\n\n---\n\n*[main.go, line 306 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnByd1es-0NSm8wf-tV:-KnERBtEDFQDCCyXBSnW:bb6un1j) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/main.go#L306)):*\n<details><summary><i>Previously, elliotchance (Elliot Chance) wrote…</i></summary><blockquote>\n\nRemove this so that there is only one error handler after the `switch` (see the previous comment).\n</blockquote></details>\n\nDone\n\n---\n\n*[main_test.go, line 168 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnBypuwBCtJpyRzbocu:-KnERVJ5piqOMsxy27GR:bb6un1j) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/main_test.go#L168)):*\n<details><summary><i>Previously, elliotchance (Elliot Chance) wrote…</i></summary><blockquote>\n\nCan this be written more simply as?\n\n```go\ndefer os.Remove(tempFile.Name())\n```\n</blockquote></details>\n\nDone\n\n---\n\n*[main_test.go, line 192 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnBzRsJceUnA2Vfduh8:-KnERinZ6jW7Qree2e_v:bb6un1j) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/main_test.go#L192)):*\n<details><summary><i>Previously, elliotchance (Elliot Chance) wrote…</i></summary><blockquote>\n\n\"$GOPATH is not set\"\n</blockquote></details>\n\nDone\n\n---\n\n*[main_test.go, line 198 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnBzZOpxGHK_Do3JU7k:-KnERpt_TSHaeyWvlrR5:bb6un1j) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/main_test.go#L198)):*\n<details><summary><i>Previously, elliotchance (Elliot Chance) wrote…</i></summary><blockquote>\n\n\"Cannot set the value of $GOPATH\"\n</blockquote></details>\n\nDone\n\n---\n\n*[main_test.go, line 202 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnBzhr_ILsAj9hKYX4G:-KnES1UL9E_uFSac2L06:bqog7zb) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/main_test.go#L202)):*\n<details><summary><i>Previously, elliotchance (Elliot Chance) wrote…</i></summary><blockquote>\n\nThe defer should be before it tries to set the value. In case it doesn't set the value correct it will reset it back to the same value it was before anyway.\n</blockquote></details>\n\nAgree.\n\n---\n\n*[main_test.go, line 205 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnBzwBugEOuigS0sCZP:-KnESBupY-XZtqQJMUVL:b-z9pmpo) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/main_test.go#L205)):*\n> \"Cannot restore the value of $GOPATH\"\nDone\n\n---\n\n*[main_test.go, line 210 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnC-0KR0md-U8PHXL0N:-KnESK8Q0JmAFFwnS0Nn:bb6un1j) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/main_test.go#L210)):*\n<details><summary><i>Previously, elliotchance (Elliot Chance) wrote…</i></summary><blockquote>\n\nYou can allocate and initialise a pointer of a struct by placing a `&` before the definition.\n\n```go\nerr = Start(&ProgramArgs{})\n```\n</blockquote></details>\n\nDone\n\n---\n\n*[main_test.go, line 212 at r6](https://reviewable.io:443/reviews/elliotchance/c2go/171#-KnC-I6z0BZ62_6HFE_y:-KnESPtaj0YJd_2n3N7j:bb6un1j) ([raw file](https://github.com/elliotchance/c2go/blob/24a2550a24b3298b1f0338d7494de8a09529da29/main_test.go#L212)):*\n<details><summary><i>Previously, elliotchance (Elliot Chance) wrote…</i></summary><blockquote>\n\nYou should return the actual error message here:\n\n```go\nt.Error(err.Error())\n```\n\n</blockquote></details>\n\nDone\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/elliotchance/c2go/171)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"Konstantin8105"}}