{"action":"created","comment":{"url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/comments/149067215","pull_request_review_id":74396906,"id":149067215,"diff_hunk":"@@ -0,0 +1,45 @@\n+# Service configuration\n+\n+Vehicle recall service is able to use few environment variable. They are used to set properly application logger.","path":"docs/ServiceConfiguration.md","position":3,"original_position":3,"commit_id":"400d53332ead3530039299296d046565ab971995","original_commit_id":"400d53332ead3530039299296d046565ab971995","user":{"login":"ryszardm-kainos","id":26869650,"avatar_url":"https://avatars0.githubusercontent.com/u/26869650?v=4","gravatar_id":"","url":"https://api.github.com/users/ryszardm-kainos","html_url":"https://github.com/ryszardm-kainos","followers_url":"https://api.github.com/users/ryszardm-kainos/followers","following_url":"https://api.github.com/users/ryszardm-kainos/following{/other_user}","gists_url":"https://api.github.com/users/ryszardm-kainos/gists{/gist_id}","starred_url":"https://api.github.com/users/ryszardm-kainos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryszardm-kainos/subscriptions","organizations_url":"https://api.github.com/users/ryszardm-kainos/orgs","repos_url":"https://api.github.com/users/ryszardm-kainos/repos","events_url":"https://api.github.com/users/ryszardm-kainos/events{/privacy}","received_events_url":"https://api.github.com/users/ryszardm-kainos/received_events","type":"User","site_admin":false},"body":"`a` few environment variable`s` (...) to `set up  application logger properly`.","created_at":"2017-11-06T12:33:34Z","updated_at":"2017-11-06T12:37:18Z","html_url":"https://github.com/dvsa/vehicle-recalls-api/pull/6#discussion_r149067215","pull_request_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/6","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/comments/149067215"},"html":{"href":"https://github.com/dvsa/vehicle-recalls-api/pull/6#discussion_r149067215"},"pull_request":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/6","id":150788022,"html_url":"https://github.com/dvsa/vehicle-recalls-api/pull/6","diff_url":"https://github.com/dvsa/vehicle-recalls-api/pull/6.diff","patch_url":"https://github.com/dvsa/vehicle-recalls-api/pull/6.patch","issue_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/6","number":6,"state":"open","locked":false,"title":"Bl-6136 error logging in recall lambda","user":{"login":"Marcin-Duszynski","id":12165279,"avatar_url":"https://avatars2.githubusercontent.com/u/12165279?v=4","gravatar_id":"","url":"https://api.github.com/users/Marcin-Duszynski","html_url":"https://github.com/Marcin-Duszynski","followers_url":"https://api.github.com/users/Marcin-Duszynski/followers","following_url":"https://api.github.com/users/Marcin-Duszynski/following{/other_user}","gists_url":"https://api.github.com/users/Marcin-Duszynski/gists{/gist_id}","starred_url":"https://api.github.com/users/Marcin-Duszynski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Marcin-Duszynski/subscriptions","organizations_url":"https://api.github.com/users/Marcin-Duszynski/orgs","repos_url":"https://api.github.com/users/Marcin-Duszynski/repos","events_url":"https://api.github.com/users/Marcin-Duszynski/events{/privacy}","received_events_url":"https://api.github.com/users/Marcin-Duszynski/received_events","type":"User","site_admin":false},"body":"### What are the relevant Jira tickets?\r\nBl-6136\r\n\r\n### Where should the reviewer start?\r\n* README.MD -> documentation is updated and now reflect current app state\r\n* SMMT configuration module has new name\r\n* New configuration provider, config/service. It's a storage for service related parameters e.g. log level\r\n* Debug, info and error logs\r\n* Morgan express js request logger is removed\r\n* Documentation\r\n\r\n## Dev checklist:\r\n- Is proper destination **branch** selected?\r\n- Are proper **label** and **reviewers** selected?\r\n- Has code been tested manually?\r\n- Has code been covered by unit tests?\r\n- Are unit test executed on Jenkins during pull request build?\r\n- Do all unit tests pass?\r\n- Is Jira ticket state updated?\r\n\r\n## Code review checklist (for reviewers -> Copy to your comment)\r\n- Is proper destination **branch** selected?\r\n- Are proper **label** and **reviewers** selected?\r\n- Do you understand task goal and business context?\r\n- Is documentation updated and understandable?\r\n- Has code been covered by unit tests?\r\n- Did you identify technical issues/debt and reported it to TA? \r\n- Does code meet SOLID principles?\r\n- Does code meet DRY principle?\r\n- Is code in better state than before (scout rule)?","created_at":"2017-11-06T07:45:38Z","updated_at":"2017-11-06T12:37:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3578ccda3dd20f94808d1152fb9fc58ef0c3f38","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/6/commits","review_comments_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/6/comments","review_comment_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/6/comments","statuses_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/statuses/400d53332ead3530039299296d046565ab971995","head":{"label":"dvsa:BL-6136-Error-logging-in-Recall-Lambda","ref":"BL-6136-Error-logging-in-Recall-Lambda","sha":"400d53332ead3530039299296d046565ab971995","user":{"login":"dvsa","id":24296376,"avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"repo":{"id":105773325,"name":"vehicle-recalls-api","full_name":"dvsa/vehicle-recalls-api","owner":{"login":"dvsa","id":24296376,"avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dvsa/vehicle-recalls-api","description":"Repository for Vehicle Recalls API","fork":false,"url":"https://api.github.com/repos/dvsa/vehicle-recalls-api","forks_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/forks","keys_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/teams","hooks_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/hooks","issue_events_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/events{/number}","events_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/events","assignees_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/assignees{/user}","branches_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/branches{/branch}","tags_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/tags","blobs_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/statuses/{sha}","languages_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/languages","stargazers_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/stargazers","contributors_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/contributors","subscribers_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/subscribers","subscription_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/subscription","commits_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/contents/{+path}","compare_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/merges","archive_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/downloads","issues_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues{/number}","pulls_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls{/number}","milestones_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/milestones{/number}","notifications_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/labels{/name}","releases_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/releases{/id}","deployments_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/deployments","created_at":"2017-10-04T13:42:19Z","updated_at":"2017-10-27T10:47:22Z","pushed_at":"2017-11-06T08:37:29Z","git_url":"git://github.com/dvsa/vehicle-recalls-api.git","ssh_url":"git@github.com:dvsa/vehicle-recalls-api.git","clone_url":"https://github.com/dvsa/vehicle-recalls-api.git","svn_url":"https://github.com/dvsa/vehicle-recalls-api","homepage":null,"size":178,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"dvsa:master","ref":"master","sha":"aa355739332401e67e248b5f16971b782858fa50","user":{"login":"dvsa","id":24296376,"avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"repo":{"id":105773325,"name":"vehicle-recalls-api","full_name":"dvsa/vehicle-recalls-api","owner":{"login":"dvsa","id":24296376,"avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dvsa/vehicle-recalls-api","description":"Repository for Vehicle Recalls API","fork":false,"url":"https://api.github.com/repos/dvsa/vehicle-recalls-api","forks_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/forks","keys_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/teams","hooks_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/hooks","issue_events_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/events{/number}","events_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/events","assignees_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/assignees{/user}","branches_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/branches{/branch}","tags_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/tags","blobs_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/statuses/{sha}","languages_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/languages","stargazers_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/stargazers","contributors_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/contributors","subscribers_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/subscribers","subscription_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/subscription","commits_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/contents/{+path}","compare_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/merges","archive_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/downloads","issues_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues{/number}","pulls_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls{/number}","milestones_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/milestones{/number}","notifications_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/labels{/name}","releases_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/releases{/id}","deployments_url":"https://api.github.com/repos/dvsa/vehicle-recalls-api/deployments","created_at":"2017-10-04T13:42:19Z","updated_at":"2017-10-27T10:47:22Z","pushed_at":"2017-11-06T08:37:29Z","git_url":"git://github.com/dvsa/vehicle-recalls-api.git","ssh_url":"git@github.com:dvsa/vehicle-recalls-api.git","clone_url":"https://github.com/dvsa/vehicle-recalls-api.git","svn_url":"https://github.com/dvsa/vehicle-recalls-api","homepage":null,"size":178,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/6"},"html":{"href":"https://github.com/dvsa/vehicle-recalls-api/pull/6"},"issue":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/6"},"comments":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/dvsa/vehicle-recalls-api/statuses/400d53332ead3530039299296d046565ab971995"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ryszardm-kainos"}}