{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/active_shipping/pulls/comments/105012123","pull_request_review_id":25872554,"id":105012123,"diff_hunk":"@@ -386,6 +386,13 @@ def test_strip_9_digit_zip_codes\n     assert request =~ /\\>12345\\</\n   end\n \n+  def test_strip_9_digit_zip_codes_world_rates\n+    request = URI.decode(@carrier.send(:build_world_rate_request, location_fixtures[:beverly_hills_9_zip],\n+                                        package_fixtures[:book], location_fixtures[:auckland], {}))\n+    assert !(request =~ /\\>90210-1234\\</)","path":"test/unit/carriers/usps_test.rb","position":null,"original_position":7,"commit_id":"7e8dc0e6435533ad09b6d99762500c778ef3c313","original_commit_id":"e0adcd466ae2e41848d35d7eaf8691d4270b4993","user":{"login":"anthonyn60","id":6720451,"avatar_url":"https://avatars0.githubusercontent.com/u/6720451?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonyn60","html_url":"https://github.com/anthonyn60","followers_url":"https://api.github.com/users/anthonyn60/followers","following_url":"https://api.github.com/users/anthonyn60/following{/other_user}","gists_url":"https://api.github.com/users/anthonyn60/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyn60/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyn60/subscriptions","organizations_url":"https://api.github.com/users/anthonyn60/orgs","repos_url":"https://api.github.com/users/anthonyn60/repos","events_url":"https://api.github.com/users/anthonyn60/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyn60/received_events","type":"User","site_admin":false},"body":"Refactored to address your feedback. I agree, there's more clarity when the entire tag is included.","created_at":"2017-03-08T20:15:43Z","updated_at":"2017-03-08T20:15:43Z","html_url":"https://github.com/Shopify/active_shipping/pull/489#discussion_r105012123","pull_request_url":"https://api.github.com/repos/Shopify/active_shipping/pulls/489","_links":{"self":{"href":"https://api.github.com/repos/Shopify/active_shipping/pulls/comments/105012123"},"html":{"href":"https://github.com/Shopify/active_shipping/pull/489#discussion_r105012123"},"pull_request":{"href":"https://api.github.com/repos/Shopify/active_shipping/pulls/489"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/active_shipping/pulls/489","id":109759331,"html_url":"https://github.com/Shopify/active_shipping/pull/489","diff_url":"https://github.com/Shopify/active_shipping/pull/489.diff","patch_url":"https://github.com/Shopify/active_shipping/pull/489.patch","issue_url":"https://api.github.com/repos/Shopify/active_shipping/issues/489","number":489,"state":"open","locked":false,"title":"Strip 9 digit origin zip code for world rate requests","user":{"login":"anthonyn60","id":6720451,"avatar_url":"https://avatars0.githubusercontent.com/u/6720451?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonyn60","html_url":"https://github.com/anthonyn60","followers_url":"https://api.github.com/users/anthonyn60/followers","following_url":"https://api.github.com/users/anthonyn60/following{/other_user}","gists_url":"https://api.github.com/users/anthonyn60/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyn60/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyn60/subscriptions","organizations_url":"https://api.github.com/users/anthonyn60/orgs","repos_url":"https://api.github.com/users/anthonyn60/repos","events_url":"https://api.github.com/users/anthonyn60/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyn60/received_events","type":"User","site_admin":false},"body":"## What\r\n\r\nThis PR truncates origin +4 zip codes for USPS world rate requests using the `strip_zip` method.\r\n\r\n## Why\r\n\r\n`build_world_rate_request` may throw an invalid zip code error if a +4 origin zip code is used in its original form. `build_us_rate_request` gets around this by calling `strip_zip` on any zip codes passed into the XML for cleansing. I'm adding the same behaviour to the `build_world_rate_request` method when it creates its own `xml`.\r\n","created_at":"2017-03-08T18:51:23Z","updated_at":"2017-03-08T20:15:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4931e874b9de7c9fc0d95ffc0d7c46387dc358bc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/active_shipping/pulls/489/commits","review_comments_url":"https://api.github.com/repos/Shopify/active_shipping/pulls/489/comments","review_comment_url":"https://api.github.com/repos/Shopify/active_shipping/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/active_shipping/issues/489/comments","statuses_url":"https://api.github.com/repos/Shopify/active_shipping/statuses/7e8dc0e6435533ad09b6d99762500c778ef3c313","head":{"label":"Shopify:strip_9_digit_zip_world_rates","ref":"strip_9_digit_zip_world_rates","sha":"7e8dc0e6435533ad09b6d99762500c778ef3c313","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":11598,"name":"active_shipping","full_name":"Shopify/active_shipping","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/active_shipping","description":"ActiveShipping is a simple shipping abstraction library extracted from Shopify","fork":false,"url":"https://api.github.com/repos/Shopify/active_shipping","forks_url":"https://api.github.com/repos/Shopify/active_shipping/forks","keys_url":"https://api.github.com/repos/Shopify/active_shipping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/active_shipping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/active_shipping/teams","hooks_url":"https://api.github.com/repos/Shopify/active_shipping/hooks","issue_events_url":"https://api.github.com/repos/Shopify/active_shipping/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/active_shipping/events","assignees_url":"https://api.github.com/repos/Shopify/active_shipping/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/active_shipping/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/active_shipping/tags","blobs_url":"https://api.github.com/repos/Shopify/active_shipping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/active_shipping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/active_shipping/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/active_shipping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/active_shipping/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/active_shipping/languages","stargazers_url":"https://api.github.com/repos/Shopify/active_shipping/stargazers","contributors_url":"https://api.github.com/repos/Shopify/active_shipping/contributors","subscribers_url":"https://api.github.com/repos/Shopify/active_shipping/subscribers","subscription_url":"https://api.github.com/repos/Shopify/active_shipping/subscription","commits_url":"https://api.github.com/repos/Shopify/active_shipping/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/active_shipping/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/active_shipping/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/active_shipping/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/active_shipping/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/active_shipping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/active_shipping/merges","archive_url":"https://api.github.com/repos/Shopify/active_shipping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/active_shipping/downloads","issues_url":"https://api.github.com/repos/Shopify/active_shipping/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/active_shipping/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/active_shipping/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/active_shipping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/active_shipping/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/active_shipping/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/active_shipping/deployments","created_at":"2008-04-21T18:13:39Z","updated_at":"2017-03-03T00:15:52Z","pushed_at":"2017-03-08T20:14:57Z","git_url":"git://github.com/Shopify/active_shipping.git","ssh_url":"git@github.com:Shopify/active_shipping.git","clone_url":"https://github.com/Shopify/active_shipping.git","svn_url":"https://github.com/Shopify/active_shipping","homepage":"http://shopify.github.io/active_shipping","size":2307,"stargazers_count":705,"watchers_count":705,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":395,"mirror_url":null,"open_issues_count":55,"forks":395,"open_issues":55,"watchers":705,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"e212b85ac067b2f74886b5e186f5ceee3897c3db","user":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":11598,"name":"active_shipping","full_name":"Shopify/active_shipping","owner":{"login":"Shopify","id":8085,"avatar_url":"https://avatars2.githubusercontent.com/u/8085?v=3","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Shopify/active_shipping","description":"ActiveShipping is a simple shipping abstraction library extracted from Shopify","fork":false,"url":"https://api.github.com/repos/Shopify/active_shipping","forks_url":"https://api.github.com/repos/Shopify/active_shipping/forks","keys_url":"https://api.github.com/repos/Shopify/active_shipping/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/active_shipping/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/active_shipping/teams","hooks_url":"https://api.github.com/repos/Shopify/active_shipping/hooks","issue_events_url":"https://api.github.com/repos/Shopify/active_shipping/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/active_shipping/events","assignees_url":"https://api.github.com/repos/Shopify/active_shipping/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/active_shipping/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/active_shipping/tags","blobs_url":"https://api.github.com/repos/Shopify/active_shipping/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/active_shipping/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/active_shipping/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/active_shipping/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/active_shipping/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/active_shipping/languages","stargazers_url":"https://api.github.com/repos/Shopify/active_shipping/stargazers","contributors_url":"https://api.github.com/repos/Shopify/active_shipping/contributors","subscribers_url":"https://api.github.com/repos/Shopify/active_shipping/subscribers","subscription_url":"https://api.github.com/repos/Shopify/active_shipping/subscription","commits_url":"https://api.github.com/repos/Shopify/active_shipping/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/active_shipping/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/active_shipping/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/active_shipping/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/active_shipping/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/active_shipping/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/active_shipping/merges","archive_url":"https://api.github.com/repos/Shopify/active_shipping/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/active_shipping/downloads","issues_url":"https://api.github.com/repos/Shopify/active_shipping/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/active_shipping/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/active_shipping/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/active_shipping/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/active_shipping/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/active_shipping/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/active_shipping/deployments","created_at":"2008-04-21T18:13:39Z","updated_at":"2017-03-03T00:15:52Z","pushed_at":"2017-03-08T20:14:57Z","git_url":"git://github.com/Shopify/active_shipping.git","ssh_url":"git@github.com:Shopify/active_shipping.git","clone_url":"https://github.com/Shopify/active_shipping.git","svn_url":"https://github.com/Shopify/active_shipping","homepage":"http://shopify.github.io/active_shipping","size":2307,"stargazers_count":705,"watchers_count":705,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":395,"mirror_url":null,"open_issues_count":55,"forks":395,"open_issues":55,"watchers":705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/active_shipping/pulls/489"},"html":{"href":"https://github.com/Shopify/active_shipping/pull/489"},"issue":{"href":"https://api.github.com/repos/Shopify/active_shipping/issues/489"},"comments":{"href":"https://api.github.com/repos/Shopify/active_shipping/issues/489/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/active_shipping/pulls/489/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/active_shipping/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/active_shipping/pulls/489/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/active_shipping/statuses/7e8dc0e6435533ad09b6d99762500c778ef3c313"}}}}
{"actor":{"display_login":"anthonyn60"}}