{"action":"created","comment":{"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/comments/152259228","pull_request_review_id":78092513,"id":152259228,"diff_hunk":"@@ -137,11 +135,7 @@ def detect_pkey_index_violated(e)\n \n     def build_event_entity(record)\n       return nil unless record","path":"rails_event_store_active_record/lib/rails_event_store_active_record/event_repository.rb","position":null,"original_position":37,"commit_id":"effb408de26d278368f7dcf5988e4446785be158","original_commit_id":"e7f93ad4e3b5b2bf8876178028e39cc655b5cf12","user":{"login":"paneq","id":65587,"avatar_url":"https://avatars2.githubusercontent.com/u/65587?v=4","gravatar_id":"","url":"https://api.github.com/users/paneq","html_url":"https://github.com/paneq","followers_url":"https://api.github.com/users/paneq/followers","following_url":"https://api.github.com/users/paneq/following{/other_user}","gists_url":"https://api.github.com/users/paneq/gists{/gist_id}","starred_url":"https://api.github.com/users/paneq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paneq/subscriptions","organizations_url":"https://api.github.com/users/paneq/orgs","repos_url":"https://api.github.com/users/paneq/repos","events_url":"https://api.github.com/users/paneq/events{/privacy}","received_events_url":"https://api.github.com/users/paneq/received_events","type":"User","site_admin":false},"body":"Yep, but it is only needed in one place (I believe) so let's keep it close to that one place only.","created_at":"2017-11-21T12:24:20Z","updated_at":"2017-11-21T12:24:20Z","html_url":"https://github.com/RailsEventStore/rails_event_store/pull/168#discussion_r152259228","pull_request_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/168","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/comments/152259228"},"html":{"href":"https://github.com/RailsEventStore/rails_event_store/pull/168#discussion_r152259228"},"pull_request":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/168"}},"in_reply_to_id":152256401},"pull_request":{"url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/168","id":153849256,"html_url":"https://github.com/RailsEventStore/rails_event_store/pull/168","diff_url":"https://github.com/RailsEventStore/rails_event_store/pull/168.diff","patch_url":"https://github.com/RailsEventStore/rails_event_store/pull/168.patch","issue_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/168","number":168,"state":"open","locked":false,"title":"Events mappers / serialisers proposal","user":{"login":"andrzejsliwa","id":9280,"avatar_url":"https://avatars2.githubusercontent.com/u/9280?v=4","gravatar_id":"","url":"https://api.github.com/users/andrzejsliwa","html_url":"https://github.com/andrzejsliwa","followers_url":"https://api.github.com/users/andrzejsliwa/followers","following_url":"https://api.github.com/users/andrzejsliwa/following{/other_user}","gists_url":"https://api.github.com/users/andrzejsliwa/gists{/gist_id}","starred_url":"https://api.github.com/users/andrzejsliwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrzejsliwa/subscriptions","organizations_url":"https://api.github.com/users/andrzejsliwa/orgs","repos_url":"https://api.github.com/users/andrzejsliwa/repos","events_url":"https://api.github.com/users/andrzejsliwa/events{/privacy}","received_events_url":"https://api.github.com/users/andrzejsliwa/received_events","type":"User","site_admin":false},"body":"Related issue: #154\r\n\r\nGoal:\r\n- Lets customise the serialisation and factorisation of the events.\r\n- Switch from ActiveRecord declarative serialisation to explicit, configured version.\r\n- Keep backward compatibility.\r\n \r\nExtra:\r\nAs proof of concept `WithEventClassRemapping` mapper was added to handle example use case of events classes \"translation\" on the fly (To keep store immutable, in case of renaming/moving events classes)","created_at":"2017-11-21T10:21:54Z","updated_at":"2017-11-21T12:24:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"296e1b3f2cb44534553fe7611b15b1e6c182d990","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/168/commits","review_comments_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/168/comments","review_comment_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/168/comments","statuses_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/statuses/effb408de26d278368f7dcf5988e4446785be158","head":{"label":"andrzejsliwa:feature/custom_serializers_aka_mappers","ref":"feature/custom_serializers_aka_mappers","sha":"effb408de26d278368f7dcf5988e4446785be158","user":{"login":"andrzejsliwa","id":9280,"avatar_url":"https://avatars2.githubusercontent.com/u/9280?v=4","gravatar_id":"","url":"https://api.github.com/users/andrzejsliwa","html_url":"https://github.com/andrzejsliwa","followers_url":"https://api.github.com/users/andrzejsliwa/followers","following_url":"https://api.github.com/users/andrzejsliwa/following{/other_user}","gists_url":"https://api.github.com/users/andrzejsliwa/gists{/gist_id}","starred_url":"https://api.github.com/users/andrzejsliwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrzejsliwa/subscriptions","organizations_url":"https://api.github.com/users/andrzejsliwa/orgs","repos_url":"https://api.github.com/users/andrzejsliwa/repos","events_url":"https://api.github.com/users/andrzejsliwa/events{/privacy}","received_events_url":"https://api.github.com/users/andrzejsliwa/received_events","type":"User","site_admin":false},"repo":{"id":111406634,"name":"rails_event_store","full_name":"andrzejsliwa/rails_event_store","owner":{"login":"andrzejsliwa","id":9280,"avatar_url":"https://avatars2.githubusercontent.com/u/9280?v=4","gravatar_id":"","url":"https://api.github.com/users/andrzejsliwa","html_url":"https://github.com/andrzejsliwa","followers_url":"https://api.github.com/users/andrzejsliwa/followers","following_url":"https://api.github.com/users/andrzejsliwa/following{/other_user}","gists_url":"https://api.github.com/users/andrzejsliwa/gists{/gist_id}","starred_url":"https://api.github.com/users/andrzejsliwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrzejsliwa/subscriptions","organizations_url":"https://api.github.com/users/andrzejsliwa/orgs","repos_url":"https://api.github.com/users/andrzejsliwa/repos","events_url":"https://api.github.com/users/andrzejsliwa/events{/privacy}","received_events_url":"https://api.github.com/users/andrzejsliwa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrzejsliwa/rails_event_store","description":"A Ruby implementation of an Event Store based on Active Record.","fork":true,"url":"https://api.github.com/repos/andrzejsliwa/rails_event_store","forks_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/forks","keys_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/teams","hooks_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/hooks","issue_events_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/issues/events{/number}","events_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/events","assignees_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/assignees{/user}","branches_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/branches{/branch}","tags_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/tags","blobs_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/statuses/{sha}","languages_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/languages","stargazers_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/stargazers","contributors_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/contributors","subscribers_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/subscribers","subscription_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/subscription","commits_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/contents/{+path}","compare_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/merges","archive_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/downloads","issues_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/issues{/number}","pulls_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/pulls{/number}","milestones_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/milestones{/number}","notifications_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/labels{/name}","releases_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/releases{/id}","deployments_url":"https://api.github.com/repos/andrzejsliwa/rails_event_store/deployments","created_at":"2017-11-20T12:17:28Z","updated_at":"2017-11-20T12:17:29Z","pushed_at":"2017-11-21T12:23:03Z","git_url":"git://github.com/andrzejsliwa/rails_event_store.git","ssh_url":"git@github.com:andrzejsliwa/rails_event_store.git","clone_url":"https://github.com/andrzejsliwa/rails_event_store.git","svn_url":"https://github.com/andrzejsliwa/rails_event_store","homepage":"http://railseventstore.org","size":1084,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"RailsEventStore:master","ref":"master","sha":"51e29b3096b2152d67f96d7c49a2a4492e2febb3","user":{"login":"RailsEventStore","id":29432749,"avatar_url":"https://avatars1.githubusercontent.com/u/29432749?v=4","gravatar_id":"","url":"https://api.github.com/users/RailsEventStore","html_url":"https://github.com/RailsEventStore","followers_url":"https://api.github.com/users/RailsEventStore/followers","following_url":"https://api.github.com/users/RailsEventStore/following{/other_user}","gists_url":"https://api.github.com/users/RailsEventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/RailsEventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RailsEventStore/subscriptions","organizations_url":"https://api.github.com/users/RailsEventStore/orgs","repos_url":"https://api.github.com/users/RailsEventStore/repos","events_url":"https://api.github.com/users/RailsEventStore/events{/privacy}","received_events_url":"https://api.github.com/users/RailsEventStore/received_events","type":"Organization","site_admin":false},"repo":{"id":33212527,"name":"rails_event_store","full_name":"RailsEventStore/rails_event_store","owner":{"login":"RailsEventStore","id":29432749,"avatar_url":"https://avatars1.githubusercontent.com/u/29432749?v=4","gravatar_id":"","url":"https://api.github.com/users/RailsEventStore","html_url":"https://github.com/RailsEventStore","followers_url":"https://api.github.com/users/RailsEventStore/followers","following_url":"https://api.github.com/users/RailsEventStore/following{/other_user}","gists_url":"https://api.github.com/users/RailsEventStore/gists{/gist_id}","starred_url":"https://api.github.com/users/RailsEventStore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RailsEventStore/subscriptions","organizations_url":"https://api.github.com/users/RailsEventStore/orgs","repos_url":"https://api.github.com/users/RailsEventStore/repos","events_url":"https://api.github.com/users/RailsEventStore/events{/privacy}","received_events_url":"https://api.github.com/users/RailsEventStore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RailsEventStore/rails_event_store","description":"A Ruby implementation of an Event Store based on Active Record.","fork":false,"url":"https://api.github.com/repos/RailsEventStore/rails_event_store","forks_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/forks","keys_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/teams","hooks_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/hooks","issue_events_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/events{/number}","events_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/events","assignees_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/assignees{/user}","branches_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/branches{/branch}","tags_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/tags","blobs_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/refs{/sha}","trees_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/statuses/{sha}","languages_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/languages","stargazers_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/stargazers","contributors_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/contributors","subscribers_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/subscribers","subscription_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/subscription","commits_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/commits{/sha}","git_commits_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/git/commits{/sha}","comments_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/comments{/number}","issue_comment_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/comments{/number}","contents_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/contents/{+path}","compare_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/merges","archive_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/downloads","issues_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues{/number}","pulls_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls{/number}","milestones_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/milestones{/number}","notifications_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/labels{/name}","releases_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/releases{/id}","deployments_url":"https://api.github.com/repos/RailsEventStore/rails_event_store/deployments","created_at":"2015-03-31T22:02:32Z","updated_at":"2017-11-17T15:50:14Z","pushed_at":"2017-11-21T12:23:05Z","git_url":"git://github.com/RailsEventStore/rails_event_store.git","ssh_url":"git@github.com:RailsEventStore/rails_event_store.git","clone_url":"https://github.com/RailsEventStore/rails_event_store.git","svn_url":"https://github.com/RailsEventStore/rails_event_store","homepage":"http://railseventstore.org","size":1096,"stargazers_count":315,"watchers_count":315,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":36,"forks":28,"open_issues":36,"watchers":315,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/168"},"html":{"href":"https://github.com/RailsEventStore/rails_event_store/pull/168"},"issue":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/168"},"comments":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/RailsEventStore/rails_event_store/statuses/effb408de26d278368f7dcf5988e4446785be158"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"paneq"}}