{"action":"opened","number":831,"pull_request":{"url":"https://api.github.com/repos/thestonefox/VRTK/pulls/831","id":102051867,"html_url":"https://github.com/thestonefox/VRTK/pull/831","diff_url":"https://github.com/thestonefox/VRTK/pull/831.diff","patch_url":"https://github.com/thestonefox/VRTK/pull/831.patch","issue_url":"https://api.github.com/repos/thestonefox/VRTK/issues/831","number":831,"state":"open","locked":false,"title":"Bugfix/simulator controller consistency","user":{"login":"burnedikt","id":6168665,"avatar_url":"https://avatars.githubusercontent.com/u/6168665?v=3","gravatar_id":"","url":"https://api.github.com/users/burnedikt","html_url":"https://github.com/burnedikt","followers_url":"https://api.github.com/users/burnedikt/followers","following_url":"https://api.github.com/users/burnedikt/following{/other_user}","gists_url":"https://api.github.com/users/burnedikt/gists{/gist_id}","starred_url":"https://api.github.com/users/burnedikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burnedikt/subscriptions","organizations_url":"https://api.github.com/users/burnedikt/orgs","repos_url":"https://api.github.com/users/burnedikt/repos","events_url":"https://api.github.com/users/burnedikt/events{/privacy}","received_events_url":"https://api.github.com/users/burnedikt/received_events","type":"User","site_admin":false},"body":"When trying to develop without any VR-Hardware, the simulator comes in really handy. However, I noticed that some events on the simulator (e.g. touchdown, touchup, touched on any buttons) are never fired. While it makes sense to not fire those events from a technical perspective (since we cannot distinguish between press and touch on a keyboard) it makes developing a whole lot harder, since a developer potentially has to use different types of events during development (Simulator) and in production (HMD). \r\n\r\nFurthermore, the Simulator SDK right now does not allow for finding script alias controllers. Whenever the calls to get a controller (e.g. `GetControllerLeftHand` or `GetControllerByIndex`) are used, the boolean `actual` parameter is simply ignored and the actual controllers are always returned. This is not in line with the base implementation or the implementation for SteamVR.\r\n\r\nThis PR mitigates both the above problems.\r\n\r\n- Touch Events are now always fired alongside with pressed / released events\r\n- Controller Retrieval / Finding logic has been reworked to be more consistent with other implementations","created_at":"2017-01-18T12:00:35Z","updated_at":"2017-01-18T12:00:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/thestonefox/VRTK/pulls/831/commits","review_comments_url":"https://api.github.com/repos/thestonefox/VRTK/pulls/831/comments","review_comment_url":"https://api.github.com/repos/thestonefox/VRTK/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thestonefox/VRTK/issues/831/comments","statuses_url":"https://api.github.com/repos/thestonefox/VRTK/statuses/ec004478e3379c2abfddcfe5b2628b8977ee0fa0","head":{"label":"burnedikt:bugfix/simulator-controller-consistency","ref":"bugfix/simulator-controller-consistency","sha":"ec004478e3379c2abfddcfe5b2628b8977ee0fa0","user":{"login":"burnedikt","id":6168665,"avatar_url":"https://avatars.githubusercontent.com/u/6168665?v=3","gravatar_id":"","url":"https://api.github.com/users/burnedikt","html_url":"https://github.com/burnedikt","followers_url":"https://api.github.com/users/burnedikt/followers","following_url":"https://api.github.com/users/burnedikt/following{/other_user}","gists_url":"https://api.github.com/users/burnedikt/gists{/gist_id}","starred_url":"https://api.github.com/users/burnedikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burnedikt/subscriptions","organizations_url":"https://api.github.com/users/burnedikt/orgs","repos_url":"https://api.github.com/users/burnedikt/repos","events_url":"https://api.github.com/users/burnedikt/events{/privacy}","received_events_url":"https://api.github.com/users/burnedikt/received_events","type":"User","site_admin":false},"repo":{"id":79332693,"name":"VRTK","full_name":"burnedikt/VRTK","owner":{"login":"burnedikt","id":6168665,"avatar_url":"https://avatars.githubusercontent.com/u/6168665?v=3","gravatar_id":"","url":"https://api.github.com/users/burnedikt","html_url":"https://github.com/burnedikt","followers_url":"https://api.github.com/users/burnedikt/followers","following_url":"https://api.github.com/users/burnedikt/following{/other_user}","gists_url":"https://api.github.com/users/burnedikt/gists{/gist_id}","starred_url":"https://api.github.com/users/burnedikt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/burnedikt/subscriptions","organizations_url":"https://api.github.com/users/burnedikt/orgs","repos_url":"https://api.github.com/users/burnedikt/repos","events_url":"https://api.github.com/users/burnedikt/events{/privacy}","received_events_url":"https://api.github.com/users/burnedikt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/burnedikt/VRTK","description":"A productive VR Toolkit for rapidly building VR solutions in Unity3d.","fork":true,"url":"https://api.github.com/repos/burnedikt/VRTK","forks_url":"https://api.github.com/repos/burnedikt/VRTK/forks","keys_url":"https://api.github.com/repos/burnedikt/VRTK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/burnedikt/VRTK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/burnedikt/VRTK/teams","hooks_url":"https://api.github.com/repos/burnedikt/VRTK/hooks","issue_events_url":"https://api.github.com/repos/burnedikt/VRTK/issues/events{/number}","events_url":"https://api.github.com/repos/burnedikt/VRTK/events","assignees_url":"https://api.github.com/repos/burnedikt/VRTK/assignees{/user}","branches_url":"https://api.github.com/repos/burnedikt/VRTK/branches{/branch}","tags_url":"https://api.github.com/repos/burnedikt/VRTK/tags","blobs_url":"https://api.github.com/repos/burnedikt/VRTK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/burnedikt/VRTK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/burnedikt/VRTK/git/refs{/sha}","trees_url":"https://api.github.com/repos/burnedikt/VRTK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/burnedikt/VRTK/statuses/{sha}","languages_url":"https://api.github.com/repos/burnedikt/VRTK/languages","stargazers_url":"https://api.github.com/repos/burnedikt/VRTK/stargazers","contributors_url":"https://api.github.com/repos/burnedikt/VRTK/contributors","subscribers_url":"https://api.github.com/repos/burnedikt/VRTK/subscribers","subscription_url":"https://api.github.com/repos/burnedikt/VRTK/subscription","commits_url":"https://api.github.com/repos/burnedikt/VRTK/commits{/sha}","git_commits_url":"https://api.github.com/repos/burnedikt/VRTK/git/commits{/sha}","comments_url":"https://api.github.com/repos/burnedikt/VRTK/comments{/number}","issue_comment_url":"https://api.github.com/repos/burnedikt/VRTK/issues/comments{/number}","contents_url":"https://api.github.com/repos/burnedikt/VRTK/contents/{+path}","compare_url":"https://api.github.com/repos/burnedikt/VRTK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/burnedikt/VRTK/merges","archive_url":"https://api.github.com/repos/burnedikt/VRTK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/burnedikt/VRTK/downloads","issues_url":"https://api.github.com/repos/burnedikt/VRTK/issues{/number}","pulls_url":"https://api.github.com/repos/burnedikt/VRTK/pulls{/number}","milestones_url":"https://api.github.com/repos/burnedikt/VRTK/milestones{/number}","notifications_url":"https://api.github.com/repos/burnedikt/VRTK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/burnedikt/VRTK/labels{/name}","releases_url":"https://api.github.com/repos/burnedikt/VRTK/releases{/id}","deployments_url":"https://api.github.com/repos/burnedikt/VRTK/deployments","created_at":"2017-01-18T11:14:40Z","updated_at":"2017-01-18T11:14:45Z","pushed_at":"2017-01-18T11:54:32Z","git_url":"git://github.com/burnedikt/VRTK.git","ssh_url":"git@github.com:burnedikt/VRTK.git","clone_url":"https://github.com/burnedikt/VRTK.git","svn_url":"https://github.com/burnedikt/VRTK","homepage":"http://vrtk.io","size":77540,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thestonefox:master","ref":"master","sha":"e3c87c22cf48a2e177d78c9796ebf475f2c82709","user":{"login":"thestonefox","id":1029673,"avatar_url":"https://avatars.githubusercontent.com/u/1029673?v=3","gravatar_id":"","url":"https://api.github.com/users/thestonefox","html_url":"https://github.com/thestonefox","followers_url":"https://api.github.com/users/thestonefox/followers","following_url":"https://api.github.com/users/thestonefox/following{/other_user}","gists_url":"https://api.github.com/users/thestonefox/gists{/gist_id}","starred_url":"https://api.github.com/users/thestonefox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thestonefox/subscriptions","organizations_url":"https://api.github.com/users/thestonefox/orgs","repos_url":"https://api.github.com/users/thestonefox/repos","events_url":"https://api.github.com/users/thestonefox/events{/privacy}","received_events_url":"https://api.github.com/users/thestonefox/received_events","type":"User","site_admin":false},"repo":{"id":56940351,"name":"VRTK","full_name":"thestonefox/VRTK","owner":{"login":"thestonefox","id":1029673,"avatar_url":"https://avatars.githubusercontent.com/u/1029673?v=3","gravatar_id":"","url":"https://api.github.com/users/thestonefox","html_url":"https://github.com/thestonefox","followers_url":"https://api.github.com/users/thestonefox/followers","following_url":"https://api.github.com/users/thestonefox/following{/other_user}","gists_url":"https://api.github.com/users/thestonefox/gists{/gist_id}","starred_url":"https://api.github.com/users/thestonefox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thestonefox/subscriptions","organizations_url":"https://api.github.com/users/thestonefox/orgs","repos_url":"https://api.github.com/users/thestonefox/repos","events_url":"https://api.github.com/users/thestonefox/events{/privacy}","received_events_url":"https://api.github.com/users/thestonefox/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thestonefox/VRTK","description":"A productive VR Toolkit for rapidly building VR solutions in Unity3d.","fork":false,"url":"https://api.github.com/repos/thestonefox/VRTK","forks_url":"https://api.github.com/repos/thestonefox/VRTK/forks","keys_url":"https://api.github.com/repos/thestonefox/VRTK/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thestonefox/VRTK/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thestonefox/VRTK/teams","hooks_url":"https://api.github.com/repos/thestonefox/VRTK/hooks","issue_events_url":"https://api.github.com/repos/thestonefox/VRTK/issues/events{/number}","events_url":"https://api.github.com/repos/thestonefox/VRTK/events","assignees_url":"https://api.github.com/repos/thestonefox/VRTK/assignees{/user}","branches_url":"https://api.github.com/repos/thestonefox/VRTK/branches{/branch}","tags_url":"https://api.github.com/repos/thestonefox/VRTK/tags","blobs_url":"https://api.github.com/repos/thestonefox/VRTK/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thestonefox/VRTK/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thestonefox/VRTK/git/refs{/sha}","trees_url":"https://api.github.com/repos/thestonefox/VRTK/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thestonefox/VRTK/statuses/{sha}","languages_url":"https://api.github.com/repos/thestonefox/VRTK/languages","stargazers_url":"https://api.github.com/repos/thestonefox/VRTK/stargazers","contributors_url":"https://api.github.com/repos/thestonefox/VRTK/contributors","subscribers_url":"https://api.github.com/repos/thestonefox/VRTK/subscribers","subscription_url":"https://api.github.com/repos/thestonefox/VRTK/subscription","commits_url":"https://api.github.com/repos/thestonefox/VRTK/commits{/sha}","git_commits_url":"https://api.github.com/repos/thestonefox/VRTK/git/commits{/sha}","comments_url":"https://api.github.com/repos/thestonefox/VRTK/comments{/number}","issue_comment_url":"https://api.github.com/repos/thestonefox/VRTK/issues/comments{/number}","contents_url":"https://api.github.com/repos/thestonefox/VRTK/contents/{+path}","compare_url":"https://api.github.com/repos/thestonefox/VRTK/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thestonefox/VRTK/merges","archive_url":"https://api.github.com/repos/thestonefox/VRTK/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thestonefox/VRTK/downloads","issues_url":"https://api.github.com/repos/thestonefox/VRTK/issues{/number}","pulls_url":"https://api.github.com/repos/thestonefox/VRTK/pulls{/number}","milestones_url":"https://api.github.com/repos/thestonefox/VRTK/milestones{/number}","notifications_url":"https://api.github.com/repos/thestonefox/VRTK/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thestonefox/VRTK/labels{/name}","releases_url":"https://api.github.com/repos/thestonefox/VRTK/releases{/id}","deployments_url":"https://api.github.com/repos/thestonefox/VRTK/deployments","created_at":"2016-04-23T20:55:19Z","updated_at":"2017-01-18T09:52:27Z","pushed_at":"2017-01-17T22:05:34Z","git_url":"git://github.com/thestonefox/VRTK.git","ssh_url":"git@github.com:thestonefox/VRTK.git","clone_url":"https://github.com/thestonefox/VRTK.git","svn_url":"https://github.com/thestonefox/VRTK","homepage":"http://vrtk.io","size":77540,"stargazers_count":1165,"watchers_count":1165,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":307,"mirror_url":null,"open_issues_count":64,"forks":307,"open_issues":64,"watchers":1165,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thestonefox/VRTK/pulls/831"},"html":{"href":"https://github.com/thestonefox/VRTK/pull/831"},"issue":{"href":"https://api.github.com/repos/thestonefox/VRTK/issues/831"},"comments":{"href":"https://api.github.com/repos/thestonefox/VRTK/issues/831/comments"},"review_comments":{"href":"https://api.github.com/repos/thestonefox/VRTK/pulls/831/comments"},"review_comment":{"href":"https://api.github.com/repos/thestonefox/VRTK/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thestonefox/VRTK/pulls/831/commits"},"statuses":{"href":"https://api.github.com/repos/thestonefox/VRTK/statuses/ec004478e3379c2abfddcfe5b2628b8977ee0fa0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":65,"deletions":33,"changed_files":1}}
{"actor":{"display_login":"burnedikt"}}