{"action":"created","comment":{"url":"https://api.github.com/repos/apache/flink/pulls/comments/95437867","pull_request_review_id":15992624,"id":95437867,"diff_hunk":"@@ -120,6 +120,7 @@ trait FlinkRel {\n         case typeName if SqlTypeName.YEAR_INTERVAL_TYPES.contains(typeName) => s + 8\n         case typeName if SqlTypeName.DAY_INTERVAL_TYPES.contains(typeName) => s + 4\n         case SqlTypeName.TIME | SqlTypeName.TIMESTAMP | SqlTypeName.DATE => s + 12\n+        case SqlTypeName.ARRAY | SqlTypeName.ROW | SqlTypeName.ANY => s + 24","path":"flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/FlinkRel.scala","position":4,"original_position":4,"commit_id":"8472588f35d95c2d227a3387090d3a6e6ded343d","original_commit_id":"8472588f35d95c2d227a3387090d3a6e6ded343d","user":{"login":"KurtYoung","id":955396,"avatar_url":"https://avatars.githubusercontent.com/u/955396?v=3","gravatar_id":"","url":"https://api.github.com/users/KurtYoung","html_url":"https://github.com/KurtYoung","followers_url":"https://api.github.com/users/KurtYoung/followers","following_url":"https://api.github.com/users/KurtYoung/following{/other_user}","gists_url":"https://api.github.com/users/KurtYoung/gists{/gist_id}","starred_url":"https://api.github.com/users/KurtYoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KurtYoung/subscriptions","organizations_url":"https://api.github.com/users/KurtYoung/orgs","repos_url":"https://api.github.com/users/KurtYoung/repos","events_url":"https://api.github.com/users/KurtYoung/events{/privacy}","received_events_url":"https://api.github.com/users/KurtYoung/received_events","type":"User","site_admin":false},"body":"Any chance we can expand the ARRAY or the ROW type, and only counting the basic data structures to make this a little more accurate?","created_at":"2017-01-10T19:25:24Z","updated_at":"2017-01-10T19:25:39Z","html_url":"https://github.com/apache/flink/pull/3073#discussion_r95437867","pull_request_url":"https://api.github.com/repos/apache/flink/pulls/3073","_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/comments/95437867"},"html":{"href":"https://github.com/apache/flink/pull/3073#discussion_r95437867"},"pull_request":{"href":"https://api.github.com/repos/apache/flink/pulls/3073"}}},"pull_request":{"url":"https://api.github.com/repos/apache/flink/pulls/3073","id":100456121,"html_url":"https://github.com/apache/flink/pull/3073","diff_url":"https://github.com/apache/flink/pull/3073.diff","patch_url":"https://github.com/apache/flink/pull/3073.patch","issue_url":"https://api.github.com/repos/apache/flink/issues/3073","number":3073,"state":"open","locked":false,"title":"[FLINK-5418] [table] Estimated row size does not support nested types","user":{"login":"twalthr","id":5746567,"avatar_url":"https://avatars.githubusercontent.com/u/5746567?v=3","gravatar_id":"","url":"https://api.github.com/users/twalthr","html_url":"https://github.com/twalthr","followers_url":"https://api.github.com/users/twalthr/followers","following_url":"https://api.github.com/users/twalthr/following{/other_user}","gists_url":"https://api.github.com/users/twalthr/gists{/gist_id}","starred_url":"https://api.github.com/users/twalthr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalthr/subscriptions","organizations_url":"https://api.github.com/users/twalthr/orgs","repos_url":"https://api.github.com/users/twalthr/repos","events_url":"https://api.github.com/users/twalthr/events{/privacy}","received_events_url":"https://api.github.com/users/twalthr/received_events","type":"User","site_admin":false},"body":"This adds an estimate for array, composite and generic types.","created_at":"2017-01-06T13:01:42Z","updated_at":"2017-01-10T19:25:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8384de8733dc64850180f572c194924b5d03db97","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/flink/pulls/3073/commits","review_comments_url":"https://api.github.com/repos/apache/flink/pulls/3073/comments","review_comment_url":"https://api.github.com/repos/apache/flink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/flink/issues/3073/comments","statuses_url":"https://api.github.com/repos/apache/flink/statuses/8472588f35d95c2d227a3387090d3a6e6ded343d","head":{"label":"twalthr:FLINK-5418","ref":"FLINK-5418","sha":"8472588f35d95c2d227a3387090d3a6e6ded343d","user":{"login":"twalthr","id":5746567,"avatar_url":"https://avatars.githubusercontent.com/u/5746567?v=3","gravatar_id":"","url":"https://api.github.com/users/twalthr","html_url":"https://github.com/twalthr","followers_url":"https://api.github.com/users/twalthr/followers","following_url":"https://api.github.com/users/twalthr/following{/other_user}","gists_url":"https://api.github.com/users/twalthr/gists{/gist_id}","starred_url":"https://api.github.com/users/twalthr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalthr/subscriptions","organizations_url":"https://api.github.com/users/twalthr/orgs","repos_url":"https://api.github.com/users/twalthr/repos","events_url":"https://api.github.com/users/twalthr/events{/privacy}","received_events_url":"https://api.github.com/users/twalthr/received_events","type":"User","site_admin":false},"repo":{"id":20658760,"name":"flink","full_name":"twalthr/flink","owner":{"login":"twalthr","id":5746567,"avatar_url":"https://avatars.githubusercontent.com/u/5746567?v=3","gravatar_id":"","url":"https://api.github.com/users/twalthr","html_url":"https://github.com/twalthr","followers_url":"https://api.github.com/users/twalthr/followers","following_url":"https://api.github.com/users/twalthr/following{/other_user}","gists_url":"https://api.github.com/users/twalthr/gists{/gist_id}","starred_url":"https://api.github.com/users/twalthr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twalthr/subscriptions","organizations_url":"https://api.github.com/users/twalthr/orgs","repos_url":"https://api.github.com/users/twalthr/repos","events_url":"https://api.github.com/users/twalthr/events{/privacy}","received_events_url":"https://api.github.com/users/twalthr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/twalthr/flink","description":"Mirror of Apache Flink","fork":true,"url":"https://api.github.com/repos/twalthr/flink","forks_url":"https://api.github.com/repos/twalthr/flink/forks","keys_url":"https://api.github.com/repos/twalthr/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twalthr/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twalthr/flink/teams","hooks_url":"https://api.github.com/repos/twalthr/flink/hooks","issue_events_url":"https://api.github.com/repos/twalthr/flink/issues/events{/number}","events_url":"https://api.github.com/repos/twalthr/flink/events","assignees_url":"https://api.github.com/repos/twalthr/flink/assignees{/user}","branches_url":"https://api.github.com/repos/twalthr/flink/branches{/branch}","tags_url":"https://api.github.com/repos/twalthr/flink/tags","blobs_url":"https://api.github.com/repos/twalthr/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twalthr/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twalthr/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/twalthr/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twalthr/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/twalthr/flink/languages","stargazers_url":"https://api.github.com/repos/twalthr/flink/stargazers","contributors_url":"https://api.github.com/repos/twalthr/flink/contributors","subscribers_url":"https://api.github.com/repos/twalthr/flink/subscribers","subscription_url":"https://api.github.com/repos/twalthr/flink/subscription","commits_url":"https://api.github.com/repos/twalthr/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/twalthr/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/twalthr/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/twalthr/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/twalthr/flink/contents/{+path}","compare_url":"https://api.github.com/repos/twalthr/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twalthr/flink/merges","archive_url":"https://api.github.com/repos/twalthr/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twalthr/flink/downloads","issues_url":"https://api.github.com/repos/twalthr/flink/issues{/number}","pulls_url":"https://api.github.com/repos/twalthr/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/twalthr/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/twalthr/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twalthr/flink/labels{/name}","releases_url":"https://api.github.com/repos/twalthr/flink/releases{/id}","deployments_url":"https://api.github.com/repos/twalthr/flink/deployments","created_at":"2014-06-09T19:08:51Z","updated_at":"2016-11-15T11:08:50Z","pushed_at":"2017-01-10T13:54:08Z","git_url":"git://github.com/twalthr/flink.git","ssh_url":"git@github.com:twalthr/flink.git","clone_url":"https://github.com/twalthr/flink.git","svn_url":"https://github.com/twalthr/flink","homepage":null,"size":109103,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"14bef95b87a490d1f1ccae6a9e0573e3981b3c34","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":20587599,"name":"flink","full_name":"apache/flink","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/flink","description":"Mirror of Apache Flink","fork":false,"url":"https://api.github.com/repos/apache/flink","forks_url":"https://api.github.com/repos/apache/flink/forks","keys_url":"https://api.github.com/repos/apache/flink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/flink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/flink/teams","hooks_url":"https://api.github.com/repos/apache/flink/hooks","issue_events_url":"https://api.github.com/repos/apache/flink/issues/events{/number}","events_url":"https://api.github.com/repos/apache/flink/events","assignees_url":"https://api.github.com/repos/apache/flink/assignees{/user}","branches_url":"https://api.github.com/repos/apache/flink/branches{/branch}","tags_url":"https://api.github.com/repos/apache/flink/tags","blobs_url":"https://api.github.com/repos/apache/flink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/flink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/flink/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/flink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/flink/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/flink/languages","stargazers_url":"https://api.github.com/repos/apache/flink/stargazers","contributors_url":"https://api.github.com/repos/apache/flink/contributors","subscribers_url":"https://api.github.com/repos/apache/flink/subscribers","subscription_url":"https://api.github.com/repos/apache/flink/subscription","commits_url":"https://api.github.com/repos/apache/flink/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/flink/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/flink/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/flink/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/flink/contents/{+path}","compare_url":"https://api.github.com/repos/apache/flink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/flink/merges","archive_url":"https://api.github.com/repos/apache/flink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/flink/downloads","issues_url":"https://api.github.com/repos/apache/flink/issues{/number}","pulls_url":"https://api.github.com/repos/apache/flink/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/flink/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/flink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/flink/labels{/name}","releases_url":"https://api.github.com/repos/apache/flink/releases{/id}","deployments_url":"https://api.github.com/repos/apache/flink/deployments","created_at":"2014-06-07T07:00:10Z","updated_at":"2017-01-10T19:13:34Z","pushed_at":"2017-01-10T19:13:20Z","git_url":"git://github.com/apache/flink.git","ssh_url":"git@github.com:apache/flink.git","clone_url":"https://github.com/apache/flink.git","svn_url":"https://github.com/apache/flink","homepage":null,"size":111571,"stargazers_count":1895,"watchers_count":1895,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1302,"mirror_url":"git://git.apache.org/flink.git","open_issues_count":197,"forks":1302,"open_issues":197,"watchers":1895,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/flink/pulls/3073"},"html":{"href":"https://github.com/apache/flink/pull/3073"},"issue":{"href":"https://api.github.com/repos/apache/flink/issues/3073"},"comments":{"href":"https://api.github.com/repos/apache/flink/issues/3073/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/flink/pulls/3073/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/flink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/flink/pulls/3073/commits"},"statuses":{"href":"https://api.github.com/repos/apache/flink/statuses/8472588f35d95c2d227a3387090d3a6e6ded343d"}}}}
{"actor":{"display_login":"KurtYoung"}}