{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular-cli/issues/8964","repository_url":"https://api.github.com/repos/angular/angular-cli","labels_url":"https://api.github.com/repos/angular/angular-cli/issues/8964/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular-cli/issues/8964/comments","events_url":"https://api.github.com/repos/angular/angular-cli/issues/8964/events","html_url":"https://github.com/angular/angular-cli/pull/8964","id":283984911,"number":8964,"title":"fix(@ngtools/webpack): improve missing TS file error message","user":{"login":"filipesilva","id":4172079,"avatar_url":"https://avatars2.githubusercontent.com/u/4172079?v=4","gravatar_id":"","url":"https://api.github.com/users/filipesilva","html_url":"https://github.com/filipesilva","followers_url":"https://api.github.com/users/filipesilva/followers","following_url":"https://api.github.com/users/filipesilva/following{/other_user}","gists_url":"https://api.github.com/users/filipesilva/gists{/gist_id}","starred_url":"https://api.github.com/users/filipesilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filipesilva/subscriptions","organizations_url":"https://api.github.com/users/filipesilva/orgs","repos_url":"https://api.github.com/users/filipesilva/repos","events_url":"https://api.github.com/users/filipesilva/events{/privacy}","received_events_url":"https://api.github.com/users/filipesilva/received_events","type":"User","site_admin":false},"labels":[{"id":393399567,"url":"https://api.github.com/repos/angular/angular-cli/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-12-21T19:44:32Z","updated_at":"2017-12-21T23:29:15Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/angular/angular-cli/pulls/8964","html_url":"https://github.com/angular/angular-cli/pull/8964","diff_url":"https://github.com/angular/angular-cli/pull/8964.diff","patch_url":"https://github.com/angular/angular-cli/pull/8964.patch"},"body":"Related to https://github.com/angular/angular-cli/issues/8284#issuecomment-341417325"},"comment":{"url":"https://api.github.com/repos/angular/angular-cli/issues/comments/353483582","html_url":"https://github.com/angular/angular-cli/pull/8964#issuecomment-353483582","issue_url":"https://api.github.com/repos/angular/angular-cli/issues/8964","id":353483582,"user":{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars3.githubusercontent.com/u/216296?v=4","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false},"created_at":"2017-12-21T23:29:15Z","updated_at":"2017-12-21T23:29:15Z","author_association":"OWNER","body":"ok. that was a wrong link. Please use https://goo.gl/jB3GVv thanks!\n\nOn Thu, Dec 21, 2017 at 3:26 PM Igor Minar <iminar@google.com> wrote:\n\n> uh oh. let me take a look\n>\n>\n> On Thu, Dec 21, 2017 at 1:41 PM Filipe Silva <notifications@github.com>\n> wrote:\n>\n>> *@filipesilva* commented on this pull request.\n>> ------------------------------\n>>\n>> In packages/@ngtools/webpack/src/angular_compiler_plugin.ts\n>> <https://github.com/angular/angular-cli/pull/8964#discussion_r158384993>:\n>>\n>> > -      // Check if the TS file exists.\n>> -      if (fileName.endsWith('.ts') && !this._compilerHost.fileExists(fileName, false)) {\n>> -        throw new Error(`${fileName} is not part of the compilation. `\n>> -          + `Please make sure it is in your tsconfig via the 'files' or 'include' property.`);\n>> -      }\n>> +      // Check if the TS input file and the JS output file exist.\n>> +      if ((fileName.endsWith('.ts') && !this._compilerHost.fileExists(fileName, false))\n>> +        || !this._compilerHost.fileExists(outputFile, false)) {\n>> +        let msg = `${fileName} is missing from the TypeScript compilation. `\n>> +          + `Please make sure it is in your tsconfig via the 'files' or 'include' property.`;\n>> +\n>> +        if (/(\\\\|\\/)node_modules(\\\\|\\/)/.test(fileName)) {\n>> +          msg += '\\nThe missing file seems to be part of a third party library. '\n>> +            + 'TS files in published libraries are often a sign of a badly packaged library. '\n>> +            + 'Please open an issue in the library repository to alert its author and ask them '\n>> +            + 'to package the library using the Angular Package Format (https://goo.gl/AfWtpq).';\n>>\n>> @IgorMinar <https://github.com/igorminar> ^\n>>\n>> —\n>> You are receiving this because you were mentioned.\n>>\n>>\n>> Reply to this email directly, view it on GitHub\n>> <https://github.com/angular/angular-cli/pull/8964#discussion_r158384993>,\n>> or mute the thread\n>> <https://github.com/notifications/unsubscribe-auth/AANM6Ian4OTMZBi-gOSqQhw0EM7ULX4Rks5tCtCRgaJpZM4RKRJ1>\n>> .\n>>\n>\n"}}
{"actor":{"display_login":"IgorMinar"}}