{"action":"created","comment":{"url":"https://api.github.com/repos/prometheus/docs/pulls/comments/116711311","pull_request_review_id":38352195,"id":116711311,"diff_hunk":"@@ -459,7 +459,8 @@ preferably before publicly announcing it. If you’re not ready to release yet,\n putting your username and WIP is fine.\n \n This is a registry to make our users’ lives a little easier, not a commitment\n-to develop particular exporters.\n+to develop particular exporters. For exporters on internal applications we","path":"content/docs/instrumenting/writing_exporters.md","position":5,"original_position":5,"commit_id":"9d0d3749e28e404995ecfa2de776e3a1c720b58c","original_commit_id":"9d0d3749e28e404995ecfa2de776e3a1c720b58c","user":{"login":"brian-brazil","id":7115638,"avatar_url":"https://avatars3.githubusercontent.com/u/7115638?v=3","gravatar_id":"","url":"https://api.github.com/users/brian-brazil","html_url":"https://github.com/brian-brazil","followers_url":"https://api.github.com/users/brian-brazil/followers","following_url":"https://api.github.com/users/brian-brazil/following{/other_user}","gists_url":"https://api.github.com/users/brian-brazil/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-brazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-brazil/subscriptions","organizations_url":"https://api.github.com/users/brian-brazil/orgs","repos_url":"https://api.github.com/users/brian-brazil/repos","events_url":"https://api.github.com/users/brian-brazil/events{/privacy}","received_events_url":"https://api.github.com/users/brian-brazil/received_events","type":"User","site_admin":false},"body":"s/on/for/","created_at":"2017-05-16T10:50:22Z","updated_at":"2017-05-16T10:50:22Z","html_url":"https://github.com/prometheus/docs/pull/746#discussion_r116711311","pull_request_url":"https://api.github.com/repos/prometheus/docs/pulls/746","_links":{"self":{"href":"https://api.github.com/repos/prometheus/docs/pulls/comments/116711311"},"html":{"href":"https://github.com/prometheus/docs/pull/746#discussion_r116711311"},"pull_request":{"href":"https://api.github.com/repos/prometheus/docs/pulls/746"}}},"pull_request":{"url":"https://api.github.com/repos/prometheus/docs/pulls/746","id":120625086,"html_url":"https://github.com/prometheus/docs/pull/746","diff_url":"https://github.com/prometheus/docs/pull/746.diff","patch_url":"https://github.com/prometheus/docs/pull/746.patch","issue_url":"https://api.github.com/repos/prometheus/docs/issues/746","number":746,"state":"open","locked":false,"title":"Update writing_exporters.md","user":{"login":"tback","id":83432,"avatar_url":"https://avatars3.githubusercontent.com/u/83432?v=3","gravatar_id":"","url":"https://api.github.com/users/tback","html_url":"https://github.com/tback","followers_url":"https://api.github.com/users/tback/followers","following_url":"https://api.github.com/users/tback/following{/other_user}","gists_url":"https://api.github.com/users/tback/gists{/gist_id}","starred_url":"https://api.github.com/users/tback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tback/subscriptions","organizations_url":"https://api.github.com/users/tback/orgs","repos_url":"https://api.github.com/users/tback/repos","events_url":"https://api.github.com/users/tback/events{/privacy}","received_events_url":"https://api.github.com/users/tback/received_events","type":"User","site_admin":false},"body":"Add note about choosing port numbers for exporters on internal\r\napplications. This reflects that the port range is a mere suggestion.\r\n\r\nDiscussion on prometheus-users is in\r\nhttps://groups.google.com/d/topic/prometheus-users/S1ZzJMkR1tk/discussion\r\n\r\nReplaces https://github.com/prometheus/docs/pull/744","created_at":"2017-05-15T15:11:16Z","updated_at":"2017-05-16T10:50:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5254f687b4191ba9e334836bbbef1ce1e3d4d36d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/prometheus/docs/pulls/746/commits","review_comments_url":"https://api.github.com/repos/prometheus/docs/pulls/746/comments","review_comment_url":"https://api.github.com/repos/prometheus/docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prometheus/docs/issues/746/comments","statuses_url":"https://api.github.com/repos/prometheus/docs/statuses/9d0d3749e28e404995ecfa2de776e3a1c720b58c","head":{"label":"tback:master","ref":"master","sha":"9d0d3749e28e404995ecfa2de776e3a1c720b58c","user":{"login":"tback","id":83432,"avatar_url":"https://avatars3.githubusercontent.com/u/83432?v=3","gravatar_id":"","url":"https://api.github.com/users/tback","html_url":"https://github.com/tback","followers_url":"https://api.github.com/users/tback/followers","following_url":"https://api.github.com/users/tback/following{/other_user}","gists_url":"https://api.github.com/users/tback/gists{/gist_id}","starred_url":"https://api.github.com/users/tback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tback/subscriptions","organizations_url":"https://api.github.com/users/tback/orgs","repos_url":"https://api.github.com/users/tback/repos","events_url":"https://api.github.com/users/tback/events{/privacy}","received_events_url":"https://api.github.com/users/tback/received_events","type":"User","site_admin":false},"repo":{"id":91349306,"name":"docs","full_name":"tback/docs","owner":{"login":"tback","id":83432,"avatar_url":"https://avatars3.githubusercontent.com/u/83432?v=3","gravatar_id":"","url":"https://api.github.com/users/tback","html_url":"https://github.com/tback","followers_url":"https://api.github.com/users/tback/followers","following_url":"https://api.github.com/users/tback/following{/other_user}","gists_url":"https://api.github.com/users/tback/gists{/gist_id}","starred_url":"https://api.github.com/users/tback/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tback/subscriptions","organizations_url":"https://api.github.com/users/tback/orgs","repos_url":"https://api.github.com/users/tback/repos","events_url":"https://api.github.com/users/tback/events{/privacy}","received_events_url":"https://api.github.com/users/tback/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tback/docs","description":"Prometheus documentation: content and static site generator","fork":true,"url":"https://api.github.com/repos/tback/docs","forks_url":"https://api.github.com/repos/tback/docs/forks","keys_url":"https://api.github.com/repos/tback/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tback/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tback/docs/teams","hooks_url":"https://api.github.com/repos/tback/docs/hooks","issue_events_url":"https://api.github.com/repos/tback/docs/issues/events{/number}","events_url":"https://api.github.com/repos/tback/docs/events","assignees_url":"https://api.github.com/repos/tback/docs/assignees{/user}","branches_url":"https://api.github.com/repos/tback/docs/branches{/branch}","tags_url":"https://api.github.com/repos/tback/docs/tags","blobs_url":"https://api.github.com/repos/tback/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tback/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tback/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tback/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tback/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/tback/docs/languages","stargazers_url":"https://api.github.com/repos/tback/docs/stargazers","contributors_url":"https://api.github.com/repos/tback/docs/contributors","subscribers_url":"https://api.github.com/repos/tback/docs/subscribers","subscription_url":"https://api.github.com/repos/tback/docs/subscription","commits_url":"https://api.github.com/repos/tback/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tback/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tback/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tback/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tback/docs/contents/{+path}","compare_url":"https://api.github.com/repos/tback/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tback/docs/merges","archive_url":"https://api.github.com/repos/tback/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tback/docs/downloads","issues_url":"https://api.github.com/repos/tback/docs/issues{/number}","pulls_url":"https://api.github.com/repos/tback/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/tback/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/tback/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tback/docs/labels{/name}","releases_url":"https://api.github.com/repos/tback/docs/releases{/id}","deployments_url":"https://api.github.com/repos/tback/docs/deployments","created_at":"2017-05-15T14:45:52Z","updated_at":"2017-05-15T14:45:55Z","pushed_at":"2017-05-15T15:35:59Z","git_url":"git://github.com/tback/docs.git","ssh_url":"git@github.com:tback/docs.git","clone_url":"https://github.com/tback/docs.git","svn_url":"https://github.com/tback/docs","homepage":"https://prometheus.io","size":12515,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prometheus:master","ref":"master","sha":"a6cd943a46f2983acde31cd984abee6816138cac","user":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars0.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"repo":{"id":28233924,"name":"docs","full_name":"prometheus/docs","owner":{"login":"prometheus","id":3380462,"avatar_url":"https://avatars0.githubusercontent.com/u/3380462?v=3","gravatar_id":"","url":"https://api.github.com/users/prometheus","html_url":"https://github.com/prometheus","followers_url":"https://api.github.com/users/prometheus/followers","following_url":"https://api.github.com/users/prometheus/following{/other_user}","gists_url":"https://api.github.com/users/prometheus/gists{/gist_id}","starred_url":"https://api.github.com/users/prometheus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prometheus/subscriptions","organizations_url":"https://api.github.com/users/prometheus/orgs","repos_url":"https://api.github.com/users/prometheus/repos","events_url":"https://api.github.com/users/prometheus/events{/privacy}","received_events_url":"https://api.github.com/users/prometheus/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prometheus/docs","description":"Prometheus documentation: content and static site generator","fork":false,"url":"https://api.github.com/repos/prometheus/docs","forks_url":"https://api.github.com/repos/prometheus/docs/forks","keys_url":"https://api.github.com/repos/prometheus/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prometheus/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prometheus/docs/teams","hooks_url":"https://api.github.com/repos/prometheus/docs/hooks","issue_events_url":"https://api.github.com/repos/prometheus/docs/issues/events{/number}","events_url":"https://api.github.com/repos/prometheus/docs/events","assignees_url":"https://api.github.com/repos/prometheus/docs/assignees{/user}","branches_url":"https://api.github.com/repos/prometheus/docs/branches{/branch}","tags_url":"https://api.github.com/repos/prometheus/docs/tags","blobs_url":"https://api.github.com/repos/prometheus/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prometheus/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prometheus/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/prometheus/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prometheus/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/prometheus/docs/languages","stargazers_url":"https://api.github.com/repos/prometheus/docs/stargazers","contributors_url":"https://api.github.com/repos/prometheus/docs/contributors","subscribers_url":"https://api.github.com/repos/prometheus/docs/subscribers","subscription_url":"https://api.github.com/repos/prometheus/docs/subscription","commits_url":"https://api.github.com/repos/prometheus/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/prometheus/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/prometheus/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/prometheus/docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/prometheus/docs/contents/{+path}","compare_url":"https://api.github.com/repos/prometheus/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prometheus/docs/merges","archive_url":"https://api.github.com/repos/prometheus/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prometheus/docs/downloads","issues_url":"https://api.github.com/repos/prometheus/docs/issues{/number}","pulls_url":"https://api.github.com/repos/prometheus/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/prometheus/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/prometheus/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prometheus/docs/labels{/name}","releases_url":"https://api.github.com/repos/prometheus/docs/releases{/id}","deployments_url":"https://api.github.com/repos/prometheus/docs/deployments","created_at":"2014-12-19T15:06:35Z","updated_at":"2017-05-15T11:02:30Z","pushed_at":"2017-05-16T10:24:49Z","git_url":"git://github.com/prometheus/docs.git","ssh_url":"git@github.com:prometheus/docs.git","clone_url":"https://github.com/prometheus/docs.git","svn_url":"https://github.com/prometheus/docs","homepage":"https://prometheus.io","size":12511,"stargazers_count":56,"watchers_count":56,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":192,"mirror_url":null,"open_issues_count":60,"forks":192,"open_issues":60,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prometheus/docs/pulls/746"},"html":{"href":"https://github.com/prometheus/docs/pull/746"},"issue":{"href":"https://api.github.com/repos/prometheus/docs/issues/746"},"comments":{"href":"https://api.github.com/repos/prometheus/docs/issues/746/comments"},"review_comments":{"href":"https://api.github.com/repos/prometheus/docs/pulls/746/comments"},"review_comment":{"href":"https://api.github.com/repos/prometheus/docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prometheus/docs/pulls/746/commits"},"statuses":{"href":"https://api.github.com/repos/prometheus/docs/statuses/9d0d3749e28e404995ecfa2de776e3a1c720b58c"}}}}
{"actor":{"display_login":"brian-brazil"}}