{"action":"created","comment":{"url":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls/comments/118215088","pull_request_review_id":39983415,"id":118215088,"diff_hunk":"@@ -17,11 +17,11 @@ <h2 juicy-style=\"itemName: Header; height: 35px;\">Barcode details</h2>\n                 </ul>\n             </template>\n         </div>\n-        <label class=\"control-label barcodes-box-label\" juicy-style=\"itemName: Code label; height: 35px; width: 150px;\">Code</label>\n-        <input type=\"text\" value=\"{{model.Code$::input}}\" class=\"barcodes-form-input barcodes-box-control form-control\" juicy-style=\"itemName: Code input; height: 35px; width: 500px; widthFlexible: true;\"/>\n-        <x-barcode code=\"{{model.CheckedCode}}\" class=\"barcodes-form-barcode\" juicy-style=\"itemName: Barcode; width: 500px; height: 80px;\"></x-barcode>\n-        <button value=\"{{model.Save$::click}}\" type=\"button\" class=\"btn btn-primary barcodes-form-button\" onmousedown=\"++this.value\" juicy-style=\"itemName: Save; width: 75px; height: 35px;\">Save</button>\n-        <button value=\"{{model.Cancel$::click}}\" type=\"button\" class=\"btn btn-default barcodes-form-button\" onmousedown=\"++this.value\" juicy-style=\"itemName: Cancel; width: 75px; height: 35px;\">Cancel</button>\n+        <label slot=\"barcodes/barcode-code-label\" class=\"control-label barcodes-box-label\">Code</label>\n+        <input slot=\"barcodes/barcode-code-input\" type=\"text\" value=\"{{model.Code$::input}}\" class=\"barcodes-form-input barcodes-box-control form-control\" />\n+        <x-barcode slot=\"barcodes/barcode-x-barcode\" code=\"{{model.CheckedCode}}\" class=\"barcodes-form-barcode\"></x-barcode>\n+        <button slot=\"barcodes/barcode-save-button\" value=\"{{model.Save$::click}}\" type=\"button\" class=\"btn btn-primary barcodes-form-button\" onmousedown=\"++this.value\" juicy-style=\"itemName: Save; width: 75px; height: 35px;\">Save</button>\n+        <button slot=\"barcodes/barcode-cancel-button\" value=\"{{model.Cancel$::click}}\" type=\"button\" class=\"btn btn-default barcodes-form-button\" onmousedown=\"++this.value\" juicy-style=\"itemName: Cancel; width: 75px; height: 35px;\">Cancel</button>","path":"src/Barcodes/wwwroot/Barcodes/viewmodels/BarcodePage.html","position":26,"original_position":26,"commit_id":"ac1ef069106cf12b35abe2e77b94524d1ac33b53","original_commit_id":"5f570ea0c0265a33c373a3ea36570bd1f63a5eff","user":{"login":"tomalec","id":17435,"avatar_url":"https://avatars2.githubusercontent.com/u/17435?v=3","gravatar_id":"","url":"https://api.github.com/users/tomalec","html_url":"https://github.com/tomalec","followers_url":"https://api.github.com/users/tomalec/followers","following_url":"https://api.github.com/users/tomalec/following{/other_user}","gists_url":"https://api.github.com/users/tomalec/gists{/gist_id}","starred_url":"https://api.github.com/users/tomalec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomalec/subscriptions","organizations_url":"https://api.github.com/users/tomalec/orgs","repos_url":"https://api.github.com/users/tomalec/repos","events_url":"https://api.github.com/users/tomalec/events{/privacy}","received_events_url":"https://api.github.com/users/tomalec/received_events","type":"User","site_admin":false},"body":"I usually vote for \"the shorter the better\" but that's a very good point that two pages from the same app could be blended together. I think it's worth mentioning in guidelines.\r\nSpeaking of prefixing with page name, it's definitely straightforward convention, but make produce pretty long and obfuscated code. \r\n\r\nMaybe we could say in the guidelines to just make it unique, and use personal judgement for each app to make it short and maintainable.\r\nSometimes `save-person-button` vs. `save-organization-button` is enough, sometimes you may need `persondetails-save-button` vs `personsummary-save-button` makes more sense.","created_at":"2017-05-24T10:19:47Z","updated_at":"2017-05-24T10:19:47Z","html_url":"https://github.com/StarcounterApps/Barcodes/pull/16#discussion_r118215088","pull_request_url":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls/comments/118215088"},"html":{"href":"https://github.com/StarcounterApps/Barcodes/pull/16#discussion_r118215088"},"pull_request":{"href":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls/16","id":121754463,"html_url":"https://github.com/StarcounterApps/Barcodes/pull/16","diff_url":"https://github.com/StarcounterApps/Barcodes/pull/16.diff","patch_url":"https://github.com/StarcounterApps/Barcodes/pull/16.patch","issue_url":"https://api.github.com/repos/StarcounterApps/Barcodes/issues/16","number":16,"state":"open","locked":false,"title":"9 declarative shadow dom","user":{"login":"PatrykSzwer","id":25042256,"avatar_url":"https://avatars1.githubusercontent.com/u/25042256?v=3","gravatar_id":"","url":"https://api.github.com/users/PatrykSzwer","html_url":"https://github.com/PatrykSzwer","followers_url":"https://api.github.com/users/PatrykSzwer/followers","following_url":"https://api.github.com/users/PatrykSzwer/following{/other_user}","gists_url":"https://api.github.com/users/PatrykSzwer/gists{/gist_id}","starred_url":"https://api.github.com/users/PatrykSzwer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PatrykSzwer/subscriptions","organizations_url":"https://api.github.com/users/PatrykSzwer/orgs","repos_url":"https://api.github.com/users/PatrykSzwer/repos","events_url":"https://api.github.com/users/PatrykSzwer/events{/privacy}","received_events_url":"https://api.github.com/users/PatrykSzwer/received_events","type":"User","site_admin":false},"body":"#9 ","created_at":"2017-05-22T11:20:17Z","updated_at":"2017-05-24T10:19:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"303179d0241b4006010f537bca8d4b8f797f7bef","assignee":null,"assignees":[],"requested_reviewers":[{"login":"warpech","id":566463,"avatar_url":"https://avatars3.githubusercontent.com/u/566463?v=3","gravatar_id":"","url":"https://api.github.com/users/warpech","html_url":"https://github.com/warpech","followers_url":"https://api.github.com/users/warpech/followers","following_url":"https://api.github.com/users/warpech/following{/other_user}","gists_url":"https://api.github.com/users/warpech/gists{/gist_id}","starred_url":"https://api.github.com/users/warpech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warpech/subscriptions","organizations_url":"https://api.github.com/users/warpech/orgs","repos_url":"https://api.github.com/users/warpech/repos","events_url":"https://api.github.com/users/warpech/events{/privacy}","received_events_url":"https://api.github.com/users/warpech/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls/16/commits","review_comments_url":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls/16/comments","review_comment_url":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/StarcounterApps/Barcodes/issues/16/comments","statuses_url":"https://api.github.com/repos/StarcounterApps/Barcodes/statuses/ac1ef069106cf12b35abe2e77b94524d1ac33b53","head":{"label":"StarcounterApps:9_declarative_shadow_dom","ref":"9_declarative_shadow_dom","sha":"ac1ef069106cf12b35abe2e77b94524d1ac33b53","user":{"login":"StarcounterApps","id":1219062,"avatar_url":"https://avatars0.githubusercontent.com/u/1219062?v=3","gravatar_id":"","url":"https://api.github.com/users/StarcounterApps","html_url":"https://github.com/StarcounterApps","followers_url":"https://api.github.com/users/StarcounterApps/followers","following_url":"https://api.github.com/users/StarcounterApps/following{/other_user}","gists_url":"https://api.github.com/users/StarcounterApps/gists{/gist_id}","starred_url":"https://api.github.com/users/StarcounterApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StarcounterApps/subscriptions","organizations_url":"https://api.github.com/users/StarcounterApps/orgs","repos_url":"https://api.github.com/users/StarcounterApps/repos","events_url":"https://api.github.com/users/StarcounterApps/events{/privacy}","received_events_url":"https://api.github.com/users/StarcounterApps/received_events","type":"Organization","site_admin":false},"repo":{"id":31204355,"name":"Barcodes","full_name":"StarcounterApps/Barcodes","owner":{"login":"StarcounterApps","id":1219062,"avatar_url":"https://avatars0.githubusercontent.com/u/1219062?v=3","gravatar_id":"","url":"https://api.github.com/users/StarcounterApps","html_url":"https://github.com/StarcounterApps","followers_url":"https://api.github.com/users/StarcounterApps/followers","following_url":"https://api.github.com/users/StarcounterApps/following{/other_user}","gists_url":"https://api.github.com/users/StarcounterApps/gists{/gist_id}","starred_url":"https://api.github.com/users/StarcounterApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StarcounterApps/subscriptions","organizations_url":"https://api.github.com/users/StarcounterApps/orgs","repos_url":"https://api.github.com/users/StarcounterApps/repos","events_url":"https://api.github.com/users/StarcounterApps/events{/privacy}","received_events_url":"https://api.github.com/users/StarcounterApps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StarcounterApps/Barcodes","description":"Put a barcode on anything. Try it with products.","fork":false,"url":"https://api.github.com/repos/StarcounterApps/Barcodes","forks_url":"https://api.github.com/repos/StarcounterApps/Barcodes/forks","keys_url":"https://api.github.com/repos/StarcounterApps/Barcodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StarcounterApps/Barcodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StarcounterApps/Barcodes/teams","hooks_url":"https://api.github.com/repos/StarcounterApps/Barcodes/hooks","issue_events_url":"https://api.github.com/repos/StarcounterApps/Barcodes/issues/events{/number}","events_url":"https://api.github.com/repos/StarcounterApps/Barcodes/events","assignees_url":"https://api.github.com/repos/StarcounterApps/Barcodes/assignees{/user}","branches_url":"https://api.github.com/repos/StarcounterApps/Barcodes/branches{/branch}","tags_url":"https://api.github.com/repos/StarcounterApps/Barcodes/tags","blobs_url":"https://api.github.com/repos/StarcounterApps/Barcodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StarcounterApps/Barcodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StarcounterApps/Barcodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/StarcounterApps/Barcodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StarcounterApps/Barcodes/statuses/{sha}","languages_url":"https://api.github.com/repos/StarcounterApps/Barcodes/languages","stargazers_url":"https://api.github.com/repos/StarcounterApps/Barcodes/stargazers","contributors_url":"https://api.github.com/repos/StarcounterApps/Barcodes/contributors","subscribers_url":"https://api.github.com/repos/StarcounterApps/Barcodes/subscribers","subscription_url":"https://api.github.com/repos/StarcounterApps/Barcodes/subscription","commits_url":"https://api.github.com/repos/StarcounterApps/Barcodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/StarcounterApps/Barcodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/StarcounterApps/Barcodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/StarcounterApps/Barcodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/StarcounterApps/Barcodes/contents/{+path}","compare_url":"https://api.github.com/repos/StarcounterApps/Barcodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StarcounterApps/Barcodes/merges","archive_url":"https://api.github.com/repos/StarcounterApps/Barcodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StarcounterApps/Barcodes/downloads","issues_url":"https://api.github.com/repos/StarcounterApps/Barcodes/issues{/number}","pulls_url":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls{/number}","milestones_url":"https://api.github.com/repos/StarcounterApps/Barcodes/milestones{/number}","notifications_url":"https://api.github.com/repos/StarcounterApps/Barcodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StarcounterApps/Barcodes/labels{/name}","releases_url":"https://api.github.com/repos/StarcounterApps/Barcodes/releases{/id}","deployments_url":"https://api.github.com/repos/StarcounterApps/Barcodes/deployments","created_at":"2015-02-23T10:58:43Z","updated_at":"2017-03-07T06:38:15Z","pushed_at":"2017-05-22T11:20:18Z","git_url":"git://github.com/StarcounterApps/Barcodes.git","ssh_url":"git@github.com:StarcounterApps/Barcodes.git","clone_url":"https://github.com/StarcounterApps/Barcodes.git","svn_url":"https://github.com/StarcounterApps/Barcodes","homepage":"","size":737,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"StarcounterApps:develop","ref":"develop","sha":"719af2a20832aa47e725dc4f78f4aa6dceea6e9d","user":{"login":"StarcounterApps","id":1219062,"avatar_url":"https://avatars0.githubusercontent.com/u/1219062?v=3","gravatar_id":"","url":"https://api.github.com/users/StarcounterApps","html_url":"https://github.com/StarcounterApps","followers_url":"https://api.github.com/users/StarcounterApps/followers","following_url":"https://api.github.com/users/StarcounterApps/following{/other_user}","gists_url":"https://api.github.com/users/StarcounterApps/gists{/gist_id}","starred_url":"https://api.github.com/users/StarcounterApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StarcounterApps/subscriptions","organizations_url":"https://api.github.com/users/StarcounterApps/orgs","repos_url":"https://api.github.com/users/StarcounterApps/repos","events_url":"https://api.github.com/users/StarcounterApps/events{/privacy}","received_events_url":"https://api.github.com/users/StarcounterApps/received_events","type":"Organization","site_admin":false},"repo":{"id":31204355,"name":"Barcodes","full_name":"StarcounterApps/Barcodes","owner":{"login":"StarcounterApps","id":1219062,"avatar_url":"https://avatars0.githubusercontent.com/u/1219062?v=3","gravatar_id":"","url":"https://api.github.com/users/StarcounterApps","html_url":"https://github.com/StarcounterApps","followers_url":"https://api.github.com/users/StarcounterApps/followers","following_url":"https://api.github.com/users/StarcounterApps/following{/other_user}","gists_url":"https://api.github.com/users/StarcounterApps/gists{/gist_id}","starred_url":"https://api.github.com/users/StarcounterApps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StarcounterApps/subscriptions","organizations_url":"https://api.github.com/users/StarcounterApps/orgs","repos_url":"https://api.github.com/users/StarcounterApps/repos","events_url":"https://api.github.com/users/StarcounterApps/events{/privacy}","received_events_url":"https://api.github.com/users/StarcounterApps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/StarcounterApps/Barcodes","description":"Put a barcode on anything. Try it with products.","fork":false,"url":"https://api.github.com/repos/StarcounterApps/Barcodes","forks_url":"https://api.github.com/repos/StarcounterApps/Barcodes/forks","keys_url":"https://api.github.com/repos/StarcounterApps/Barcodes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/StarcounterApps/Barcodes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/StarcounterApps/Barcodes/teams","hooks_url":"https://api.github.com/repos/StarcounterApps/Barcodes/hooks","issue_events_url":"https://api.github.com/repos/StarcounterApps/Barcodes/issues/events{/number}","events_url":"https://api.github.com/repos/StarcounterApps/Barcodes/events","assignees_url":"https://api.github.com/repos/StarcounterApps/Barcodes/assignees{/user}","branches_url":"https://api.github.com/repos/StarcounterApps/Barcodes/branches{/branch}","tags_url":"https://api.github.com/repos/StarcounterApps/Barcodes/tags","blobs_url":"https://api.github.com/repos/StarcounterApps/Barcodes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/StarcounterApps/Barcodes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/StarcounterApps/Barcodes/git/refs{/sha}","trees_url":"https://api.github.com/repos/StarcounterApps/Barcodes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/StarcounterApps/Barcodes/statuses/{sha}","languages_url":"https://api.github.com/repos/StarcounterApps/Barcodes/languages","stargazers_url":"https://api.github.com/repos/StarcounterApps/Barcodes/stargazers","contributors_url":"https://api.github.com/repos/StarcounterApps/Barcodes/contributors","subscribers_url":"https://api.github.com/repos/StarcounterApps/Barcodes/subscribers","subscription_url":"https://api.github.com/repos/StarcounterApps/Barcodes/subscription","commits_url":"https://api.github.com/repos/StarcounterApps/Barcodes/commits{/sha}","git_commits_url":"https://api.github.com/repos/StarcounterApps/Barcodes/git/commits{/sha}","comments_url":"https://api.github.com/repos/StarcounterApps/Barcodes/comments{/number}","issue_comment_url":"https://api.github.com/repos/StarcounterApps/Barcodes/issues/comments{/number}","contents_url":"https://api.github.com/repos/StarcounterApps/Barcodes/contents/{+path}","compare_url":"https://api.github.com/repos/StarcounterApps/Barcodes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/StarcounterApps/Barcodes/merges","archive_url":"https://api.github.com/repos/StarcounterApps/Barcodes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/StarcounterApps/Barcodes/downloads","issues_url":"https://api.github.com/repos/StarcounterApps/Barcodes/issues{/number}","pulls_url":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls{/number}","milestones_url":"https://api.github.com/repos/StarcounterApps/Barcodes/milestones{/number}","notifications_url":"https://api.github.com/repos/StarcounterApps/Barcodes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/StarcounterApps/Barcodes/labels{/name}","releases_url":"https://api.github.com/repos/StarcounterApps/Barcodes/releases{/id}","deployments_url":"https://api.github.com/repos/StarcounterApps/Barcodes/deployments","created_at":"2015-02-23T10:58:43Z","updated_at":"2017-03-07T06:38:15Z","pushed_at":"2017-05-22T11:20:18Z","git_url":"git://github.com/StarcounterApps/Barcodes.git","ssh_url":"git@github.com:StarcounterApps/Barcodes.git","clone_url":"https://github.com/StarcounterApps/Barcodes.git","svn_url":"https://github.com/StarcounterApps/Barcodes","homepage":"","size":737,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls/16"},"html":{"href":"https://github.com/StarcounterApps/Barcodes/pull/16"},"issue":{"href":"https://api.github.com/repos/StarcounterApps/Barcodes/issues/16"},"comments":{"href":"https://api.github.com/repos/StarcounterApps/Barcodes/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/StarcounterApps/Barcodes/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/StarcounterApps/Barcodes/statuses/ac1ef069106cf12b35abe2e77b94524d1ac33b53"}}}}
{"actor":{"display_login":"tomalec"}}