{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/gax-java/pulls/comments/143820634","pull_request_review_id":68389280,"id":143820634,"diff_hunk":"@@ -80,10 +82,14 @@ private GrpcCallableFactory() {}\n    * wrapping it. Designed for use by generated code.\n    *\n    * @param methodDescriptor the gRPC method descriptor\n+   * @param paramsExtractor request message parameters extractor, which will be used to populate\n+   *     routing headers\n    */\n   public static <RequestT, ResponseT> UnaryCallable<RequestT, ResponseT> createDirectCallable(\n-      MethodDescriptor<RequestT, ResponseT> methodDescriptor) {\n-    return new GrpcDirectCallable<>(methodDescriptor);\n+      MethodDescriptor<RequestT, ResponseT> methodDescriptor,\n+      RequestParamsExtractor<RequestT> paramsExtractor) {","path":"gax-grpc/src/main/java/com/google/api/gax/grpc/GrpcCallableFactory.java","position":20,"original_position":20,"commit_id":"d03fab682ad1bf1efb4b2c4b6bcd23198fc50c73","original_commit_id":"d03fab682ad1bf1efb4b2c4b6bcd23198fc50c73","user":{"login":"vam-google","id":25311427,"avatar_url":"https://avatars3.githubusercontent.com/u/25311427?v=4","gravatar_id":"","url":"https://api.github.com/users/vam-google","html_url":"https://github.com/vam-google","followers_url":"https://api.github.com/users/vam-google/followers","following_url":"https://api.github.com/users/vam-google/following{/other_user}","gists_url":"https://api.github.com/users/vam-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vam-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vam-google/subscriptions","organizations_url":"https://api.github.com/users/vam-google/orgs","repos_url":"https://api.github.com/users/vam-google/repos","events_url":"https://api.github.com/users/vam-google/events{/privacy}","received_events_url":"https://api.github.com/users/vam-google/received_events","type":"User","site_admin":false},"body":"Why do you thing it is a minority case. There is a good chance that there will be more usage of this. This basically adds easily-modifiable headers to all grpc calls. Here they will be used for \"static\" routing , but they are not limited to it. In future there will be stuff like transaction-based headers and similar stuff.","created_at":"2017-10-10T18:53:25Z","updated_at":"2017-10-10T18:53:56Z","html_url":"https://github.com/googleapis/gax-java/pull/375#discussion_r143820634","pull_request_url":"https://api.github.com/repos/googleapis/gax-java/pulls/375","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/googleapis/gax-java/pulls/comments/143820634"},"html":{"href":"https://github.com/googleapis/gax-java/pull/375#discussion_r143820634"},"pull_request":{"href":"https://api.github.com/repos/googleapis/gax-java/pulls/375"}},"in_reply_to_id":143084708},"pull_request":{"url":"https://api.github.com/repos/googleapis/gax-java/pulls/375","id":145042704,"html_url":"https://github.com/googleapis/gax-java/pull/375","diff_url":"https://github.com/googleapis/gax-java/pull/375.diff","patch_url":"https://github.com/googleapis/gax-java/pull/375.patch","issue_url":"https://api.github.com/repos/googleapis/gax-java/issues/375","number":375,"state":"open","locked":false,"title":"Add support for header-based routing (\"x-goog-request-params\" header)","user":{"login":"vam-google","id":25311427,"avatar_url":"https://avatars3.githubusercontent.com/u/25311427?v=4","gravatar_id":"","url":"https://api.github.com/users/vam-google","html_url":"https://github.com/vam-google","followers_url":"https://api.github.com/users/vam-google/followers","following_url":"https://api.github.com/users/vam-google/following{/other_user}","gists_url":"https://api.github.com/users/vam-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vam-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vam-google/subscriptions","organizations_url":"https://api.github.com/users/vam-google/orgs","repos_url":"https://api.github.com/users/vam-google/repos","events_url":"https://api.github.com/users/vam-google/events{/privacy}","received_events_url":"https://api.github.com/users/vam-google/received_events","type":"User","site_admin":false},"body":"Unary and server-streaming calls are supported. Client streaming and bidirectional streaming calls re not supported yet.","created_at":"2017-10-05T23:16:20Z","updated_at":"2017-10-10T18:54:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b3534a035beb6b973b68d39fbd6d2a0f0188de2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/gax-java/pulls/375/commits","review_comments_url":"https://api.github.com/repos/googleapis/gax-java/pulls/375/comments","review_comment_url":"https://api.github.com/repos/googleapis/gax-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/gax-java/issues/375/comments","statuses_url":"https://api.github.com/repos/googleapis/gax-java/statuses/d03fab682ad1bf1efb4b2c4b6bcd23198fc50c73","head":{"label":"vam-google:master","ref":"master","sha":"d03fab682ad1bf1efb4b2c4b6bcd23198fc50c73","user":{"login":"vam-google","id":25311427,"avatar_url":"https://avatars3.githubusercontent.com/u/25311427?v=4","gravatar_id":"","url":"https://api.github.com/users/vam-google","html_url":"https://github.com/vam-google","followers_url":"https://api.github.com/users/vam-google/followers","following_url":"https://api.github.com/users/vam-google/following{/other_user}","gists_url":"https://api.github.com/users/vam-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vam-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vam-google/subscriptions","organizations_url":"https://api.github.com/users/vam-google/orgs","repos_url":"https://api.github.com/users/vam-google/repos","events_url":"https://api.github.com/users/vam-google/events{/privacy}","received_events_url":"https://api.github.com/users/vam-google/received_events","type":"User","site_admin":false},"repo":{"id":80246120,"name":"gax-java","full_name":"vam-google/gax-java","owner":{"login":"vam-google","id":25311427,"avatar_url":"https://avatars3.githubusercontent.com/u/25311427?v=4","gravatar_id":"","url":"https://api.github.com/users/vam-google","html_url":"https://github.com/vam-google","followers_url":"https://api.github.com/users/vam-google/followers","following_url":"https://api.github.com/users/vam-google/following{/other_user}","gists_url":"https://api.github.com/users/vam-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vam-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vam-google/subscriptions","organizations_url":"https://api.github.com/users/vam-google/orgs","repos_url":"https://api.github.com/users/vam-google/repos","events_url":"https://api.github.com/users/vam-google/events{/privacy}","received_events_url":"https://api.github.com/users/vam-google/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vam-google/gax-java","description":"Google API Extensions for Java","fork":true,"url":"https://api.github.com/repos/vam-google/gax-java","forks_url":"https://api.github.com/repos/vam-google/gax-java/forks","keys_url":"https://api.github.com/repos/vam-google/gax-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vam-google/gax-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vam-google/gax-java/teams","hooks_url":"https://api.github.com/repos/vam-google/gax-java/hooks","issue_events_url":"https://api.github.com/repos/vam-google/gax-java/issues/events{/number}","events_url":"https://api.github.com/repos/vam-google/gax-java/events","assignees_url":"https://api.github.com/repos/vam-google/gax-java/assignees{/user}","branches_url":"https://api.github.com/repos/vam-google/gax-java/branches{/branch}","tags_url":"https://api.github.com/repos/vam-google/gax-java/tags","blobs_url":"https://api.github.com/repos/vam-google/gax-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vam-google/gax-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vam-google/gax-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/vam-google/gax-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vam-google/gax-java/statuses/{sha}","languages_url":"https://api.github.com/repos/vam-google/gax-java/languages","stargazers_url":"https://api.github.com/repos/vam-google/gax-java/stargazers","contributors_url":"https://api.github.com/repos/vam-google/gax-java/contributors","subscribers_url":"https://api.github.com/repos/vam-google/gax-java/subscribers","subscription_url":"https://api.github.com/repos/vam-google/gax-java/subscription","commits_url":"https://api.github.com/repos/vam-google/gax-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/vam-google/gax-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/vam-google/gax-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/vam-google/gax-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/vam-google/gax-java/contents/{+path}","compare_url":"https://api.github.com/repos/vam-google/gax-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vam-google/gax-java/merges","archive_url":"https://api.github.com/repos/vam-google/gax-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vam-google/gax-java/downloads","issues_url":"https://api.github.com/repos/vam-google/gax-java/issues{/number}","pulls_url":"https://api.github.com/repos/vam-google/gax-java/pulls{/number}","milestones_url":"https://api.github.com/repos/vam-google/gax-java/milestones{/number}","notifications_url":"https://api.github.com/repos/vam-google/gax-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vam-google/gax-java/labels{/name}","releases_url":"https://api.github.com/repos/vam-google/gax-java/releases{/id}","deployments_url":"https://api.github.com/repos/vam-google/gax-java/deployments","created_at":"2017-01-27T21:09:00Z","updated_at":"2017-01-27T21:09:02Z","pushed_at":"2017-10-05T23:15:10Z","git_url":"git://github.com/vam-google/gax-java.git","ssh_url":"git@github.com:vam-google/gax-java.git","clone_url":"https://github.com/vam-google/gax-java.git","svn_url":"https://github.com/vam-google/gax-java","homepage":"","size":1860,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"ad5645dc1a0e9b88e2f8b79abdc8f75be971b27e","user":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":50872805,"name":"gax-java","full_name":"googleapis/gax-java","owner":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleapis/gax-java","description":"Google API Extensions for Java","fork":false,"url":"https://api.github.com/repos/googleapis/gax-java","forks_url":"https://api.github.com/repos/googleapis/gax-java/forks","keys_url":"https://api.github.com/repos/googleapis/gax-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/gax-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/gax-java/teams","hooks_url":"https://api.github.com/repos/googleapis/gax-java/hooks","issue_events_url":"https://api.github.com/repos/googleapis/gax-java/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/gax-java/events","assignees_url":"https://api.github.com/repos/googleapis/gax-java/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/gax-java/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/gax-java/tags","blobs_url":"https://api.github.com/repos/googleapis/gax-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/gax-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/gax-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/gax-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/gax-java/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/gax-java/languages","stargazers_url":"https://api.github.com/repos/googleapis/gax-java/stargazers","contributors_url":"https://api.github.com/repos/googleapis/gax-java/contributors","subscribers_url":"https://api.github.com/repos/googleapis/gax-java/subscribers","subscription_url":"https://api.github.com/repos/googleapis/gax-java/subscription","commits_url":"https://api.github.com/repos/googleapis/gax-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/gax-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/gax-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/gax-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/gax-java/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/gax-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/gax-java/merges","archive_url":"https://api.github.com/repos/googleapis/gax-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/gax-java/downloads","issues_url":"https://api.github.com/repos/googleapis/gax-java/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/gax-java/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/gax-java/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/gax-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/gax-java/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/gax-java/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/gax-java/deployments","created_at":"2016-02-01T21:33:22Z","updated_at":"2017-07-07T18:30:54Z","pushed_at":"2017-10-09T23:42:10Z","git_url":"git://github.com/googleapis/gax-java.git","ssh_url":"git@github.com:googleapis/gax-java.git","clone_url":"https://github.com/googleapis/gax-java.git","svn_url":"https://github.com/googleapis/gax-java","homepage":"","size":7111,"stargazers_count":14,"watchers_count":14,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":14,"forks":17,"open_issues":14,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/gax-java/pulls/375"},"html":{"href":"https://github.com/googleapis/gax-java/pull/375"},"issue":{"href":"https://api.github.com/repos/googleapis/gax-java/issues/375"},"comments":{"href":"https://api.github.com/repos/googleapis/gax-java/issues/375/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/gax-java/pulls/375/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/gax-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/gax-java/pulls/375/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/gax-java/statuses/d03fab682ad1bf1efb4b2c4b6bcd23198fc50c73"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vam-google"}}