{"push_id":1549446851,"size":56,"distinct_size":56,"ref":"refs/heads/master","head":"09a91f0528bbe58ba0d8f9620fb978ad19f89052","before":"48ad600916bc239fcb549b3d5dc4a1a7d49ba6c3","commits":[{"sha":"aaf0ac7e7c0598b1182b640b2414c05254605a45","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"xenFormatXLDisk: Don't leak @target\n\n==11260== 1,006 bytes in 1 blocks are definitely lost in loss record 106 of 111\n==11260==    at 0x4C2AE5F: malloc (vg_replace_malloc.c:297)\n==11260==    by 0x4C2BDFF: realloc (vg_replace_malloc.c:693)\n==11260==    by 0x4EA430B: virReallocN (viralloc.c:245)\n==11260==    by 0x4EA7C52: virBufferGrow (virbuffer.c:130)\n==11260==    by 0x4EA7D28: virBufferAdd (virbuffer.c:165)\n==11260==    by 0x4EA8E10: virBufferStrcat (virbuffer.c:718)\n==11260==    by 0x42D263: xenFormatXLDiskSrcNet (xen_xl.c:960)\n==11260==    by 0x42D4EB: xenFormatXLDiskSrc (xen_xl.c:1015)\n==11260==    by 0x42D870: xenFormatXLDisk (xen_xl.c:1101)\n==11260==    by 0x42DA89: xenFormatXLDomainDisks (xen_xl.c:1148)\n==11260==    by 0x42EAF8: xenFormatXL (xen_xl.c:1558)\n==11260==    by 0x40E85F: testCompareParseXML (xlconfigtest.c:105)\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/aaf0ac7e7c0598b1182b640b2414c05254605a45"},{"sha":"3172d26730b67ba23f9d03e65e8f32b2249f7e12","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"virProcessRunInMountNamespace: Report errors from child\n\nThe comment to the function states that the errors from the child\nprocess are reported. Well, the error buffer is filled with\npossible error messages. But then it is thrown away. Among with\nimportant error message from the child process.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/3172d26730b67ba23f9d03e65e8f32b2249f7e12"},{"sha":"6094169b83562e23b4b262dc5df28e54d498663d","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"util: Introduce virFileReadLink\n\nWe will need to traverse the symlinks one step at the time.\nTherefore we need to see where a symlink is pointing to.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/6094169b83562e23b4b262dc5df28e54d498663d"},{"sha":"0a4652381fefa13f7fad5a1c4f0d699546ed3f42","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemuDomainPrepareDisk: Fix ordering\n\nThe current ordering is as follows:\n1) set label\n2) create the device in namespace\n3) allow device in the cgroup\n\nWhile this might work for now, it will definitely not work if the\nsecurity driver would use transactions as in that case there\nwould be no device to relabel in the domain namespace as the\ndevice is created in the second step.\nSwap steps 1) and 2) to allow security driver to use more\ntransactions.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/0a4652381fefa13f7fad5a1c4f0d699546ed3f42"},{"sha":"3e6839d4e801cdcc9d49cd9e4bf83a3694b2a273","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemuSecurityRestoreAllLabel: Don't use transactions\n\nBecause of the nature of security driver transactions, it is\nimpossible to use them properly. The thing is, transactions enter\nthe domain namespace and commit all the seclabel changes.\nHowever, in RestoreAllLabel() this is impossible - the qemu\nprocess, the only process running in the namespace, is gone. And\nthus is the namespace. Therefore we shouldn't use the transactions\nas there is no namespace to enter.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/3e6839d4e801cdcc9d49cd9e4bf83a3694b2a273"},{"sha":"0f0fcc2cd405637601273423ae56f845c2678fb1","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemu_security: Use more transactions\n\nThe idea is to move all the seclabel setting to security driver.\nHaving the relabel code spread all over the place looks very\nmessy.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/0f0fcc2cd405637601273423ae56f845c2678fb1"},{"sha":"b621291f5c9c3d36c04520bfa01b5440e56c034e","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemuDomain{Attach,Detach}Device NS helpers: Don't relabel devices\n\nAfter previous commit this has become redundant step.\nAlso setting up devices in namespace and setting their label\nlater on are two different steps and should be not done at once.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/b621291f5c9c3d36c04520bfa01b5440e56c034e"},{"sha":"54ed6722148077d45712a0a96b0c0d38a3f622d3","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemuDomainCreateDevice: Properly deal with symlinks\n\nImagine you have a disk with the following source set up:\n\n/dev/disk/by-uuid/$uuid (symlink to) -> /dev/sda\n\nAfter cbc45525cb21 the transitive end of the symlink chain is\ncreated (/dev/sda), but we need to create any item in chain too.\nOthers might rely on that.\nIn this case, /dev/disk/by-uuid/$uuid comes from domain XML thus\nit is this path that secdriver tries to relabel. Not the resolved\none.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/54ed6722148077d45712a0a96b0c0d38a3f622d3"},{"sha":"4ac847f93b950f4cf724149ebe408b65edd3a980","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemuDomainCreateDevice: Don't loop endlessly\n\nWhen working with symlinks it is fairly easy to get into a loop.\nDon't.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/4ac847f93b950f4cf724149ebe408b65edd3a980"},{"sha":"3f5fcacf89322f48c4c1b229c39771c088a3cc42","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemuDomainAttachDeviceMknod: Deal with symlinks\n\nSimilarly to one of the previous commits, we need to deal\nproperly with symlinks in hotplug case too.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/3f5fcacf89322f48c4c1b229c39771c088a3cc42"},{"sha":"7f0b382522c6cea296ef4b15ed96ddea9564e140","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemuDomainAttachDeviceMknod: Don't loop endlessly\n\nWhen working with symlinks it is fairly easy to get into a loop.\nDon't.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/7f0b382522c6cea296ef4b15ed96ddea9564e140"},{"sha":"66c21aee89597e23a00906aa195ecb0ad620a1f3","author":{"name":"Roman Bogorodskiy","email":"be56f82784a423d301db8f60637af99aa5b10d53@gmail.com"},"message":"bhyve: fix virtio disk addresses\n\nLike it usually happens, I fixed one thing and broke another:\nin 803966c76 address allocation was fixed for SATA disks, but\nbroke that for virtio disks, because it dropped disk address\nassignment completely. It's not needed for SATA disks anymore,\nbut still needed for the virtio ones.\n\nBring that back and add a couple of tests to make sure it won't\nhappen again.","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/66c21aee89597e23a00906aa195ecb0ad620a1f3"},{"sha":"28a7fd8ac17deab4d95746148e3cfafb620c6669","author":{"name":"Roman Bogorodskiy","email":"be56f82784a423d301db8f60637af99aa5b10d53@gmail.com"},"message":"docs: mention bhyve SATA address changes in news.xml","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/28a7fd8ac17deab4d95746148e3cfafb620c6669"},{"sha":"c2e60ad0e5124482942164e5fec088157f5e716a","author":{"name":"Andrea Bolognani","email":"0c58d8c54619c257465b8c09c1c6917894f8def9@redhat.com"},"message":"qemu: Forbid <memoryBacking><locked> without <memtune><hard_limit>\n\nIn order for memory locking to work, the hard limit on memory\nlocking (and usage) has to be set appropriately by the user.\n\nThe documentation mentions the requirement already: with this\npatch, it's going to be enforced by runtime checks as well,\nby forbidding a non-compliant guest from being defined as well\nas edited and started.\n\nResolves: https://bugzilla.redhat.com/show_bug.cgi?id=1316774","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/c2e60ad0e5124482942164e5fec088157f5e716a"},{"sha":"dd8ac030fbd28bba81c24cdf1311e47a350a7683","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"util: add MTU arg to virNetDevTapCreateInBridgePort()\n\nvirNetDevTapCreateInBridgePort() has always set the new tap device to\nthe current MTU of the bridge it's being attached to. There is one\ncase where we will want to set the new tap device to a different\n(usually larger) MTU - if that's done with the very first device added\nto the bridge, the bridge's MTU will be set to the device's MTU. This\npatch allows for that possibility by adding \"int mtu\" to the arg list\nfor virNetDevTapCreateInBridgePort(), but all callers are sending -1,\nso it doesn't yet have any effect.\n\nSince the requested MTU isn't necessarily what is used in the end (for\nexample, if there is no MTU requested, the tap device will be set to\nthe current MTU of the bridge), and the hypervisor may want to know\nthe actual MTU used, we also return the actual MTU to the caller (if\nactualMTU is non-NULL).","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/dd8ac030fbd28bba81c24cdf1311e47a350a7683"},{"sha":"68a42bf6f701515df472f0dd039a1d7429ea62a8","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"conf: support configuring mtu size in a virtual network\n\nExample:\n\n  <network>\n     ...\n     <mtu size='9000'/>\n     ...\n\nIf mtu is unset, it's assumed that we want the default for whatever is\nthe underlying transport (usually this is 1500).\n\nThis setting isn't yet wired in, so it will have no effect.\n\nThis partially resolves: https://bugzilla.redhat.com/1224348","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/68a42bf6f701515df472f0dd039a1d7429ea62a8"},{"sha":"c0f706865e4ecac0ddaafdb4b9fc2db8d9612481","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"network: honor mtu setting when creating network\n\nThis resolves: https://bugzilla.redhat.com/1224348","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/c0f706865e4ecac0ddaafdb4b9fc2db8d9612481"},{"sha":"2841e6756d5807a4119e004bc5fb8e7d70806458","author":{"name":"Laine Stump","email":"5116b02f16c03abd1615869c9ce1568cbda149e8@laine.org"},"message":"qemu: propagate bridge MTU into qemu \"host_mtu\" option\n\nlibvirt was able to set the host_mtu option when an MTU was explicitly\ngiven in the interface config (with <mtu size='n'/>), set the MTU of a\nlibvirt network in the network config (with the same named\nsubelement), and would automatically set the MTU of any tap device to\nthe MTU of the network.\n\nThis patch ties that all together (for networks based on tap devices\nand either Linux host bridges or OVS bridges) by learning the MTU of\nthe network (i.e. the bridge) during qemuInterfaceBridgeConnect(), and\nreturning that value so that it can then be passed to\nqemuBuildNicDevStr(); qemuBuildNicDevStr() then sets host_mtu in the\ninterface's commandline options.\n\nThe result is that a higher MTU for all guests connecting to a\nparticular network will be plumbed top to bottom by simply changing\nthe MTU of the network (in libvirt's config for libvirt-managed\nnetworks, or directly on the bridge device for simple host bridges or\nOVS bridges managed outside of libvirt).\n\nOne question I have about this - it occurred to me that in the case of\nmigrating a guest from a host with an older libvirt to one with a\nnewer libvirt, the guest may have *not* had the host_mtu option on the\nolder machine, but *will* have it on the newer machine. I'm curious if\nthis could lead to incompatibilities between source and destination (I\nguess it all depends on whether or not the setting of host_mtu has a\npractical effect on a guest that is already running - Maxime?)\n\nLikewise, we could run into problems when migrating from a newer\nlibvirt to older libvirt - The guest would have been told of the\nhigher MTU on the newer libvirt, then migrated to a host that didn't\nunderstand <mtu size='blah'/>. (If this really is a problem, it would\nbe a problem with or without the current patch).","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/2841e6756d5807a4119e004bc5fb8e7d70806458"},{"sha":"7d93a8851922fef906b12be93771c2c9ec659d18","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemuDomainAttachSCSIVHostDevice: Prefer qemuSecurity wrappers\n\nSince we have qemuSecurity wrappers over\nvirSecurityManagerSetHostdevLabel and\nvirSecurityManagerRestoreHostdevLabel we ought to use them\ninstead of calling secdriver APIs directly.  Without those\nwrappers the labelling won't be done in the correct namespace\nand thus won't apply to the nodes seen by qemu itself.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/7d93a8851922fef906b12be93771c2c9ec659d18"},{"sha":"45599e407cd3da62eadcd886183e5c3a8b20f932","author":{"name":"Michal Privoznik","email":"ff52d8b477e4489d0b3b856d550bc61214c6ad4b@redhat.com"},"message":"qemuDomainAttachSCSIVHostDevice: manage /dev entry\n\nAgain, one missed bit. This time without this commit there is no\n/dev entry in the namespace of the qemu process when attaching\nvhost SCSI device.\n\nSigned-off-by: Michal Privoznik <mprivozn@redhat.com>","distinct":true,"url":"https://api.github.com/repos/crobinso/libvirt/commits/45599e407cd3da62eadcd886183e5c3a8b20f932"}]}
{"actor":{"display_login":"crobinso"}}