{"action":"created","comment":{"url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/comments/151132228","pull_request_review_id":76789225,"id":151132228,"diff_hunk":"@@ -127,7 +127,7 @@ public static function output( $post ) {\n \t\t\t\t\t'id'          => 'maximum_amount',\n \t\t\t\t\t'label'       => __( 'Maximum spend', 'woocommerce' ),\n \t\t\t\t\t'placeholder' => __( 'No maximum', 'woocommerce' ),\n-\t\t\t\t\t'description' => __( 'This field allows you to set the maximum spend (subtotal, including taxes) allowed when using the coupon.', 'woocommerce' ),\n+\t\t\t\t\t'description' => __( 'This field allows you to set the maximum spend (displayed subtotal) allowed when using the coupon.', 'woocommerce' ),","path":"includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php","position":14,"original_position":14,"commit_id":"4521011219ee5a6ee8fef53404e2a1edf19c728d","original_commit_id":"4521011219ee5a6ee8fef53404e2a1edf19c728d","user":{"login":"mikejolley","id":90977,"avatar_url":"https://avatars2.githubusercontent.com/u/90977?v=4","gravatar_id":"","url":"https://api.github.com/users/mikejolley","html_url":"https://github.com/mikejolley","followers_url":"https://api.github.com/users/mikejolley/followers","following_url":"https://api.github.com/users/mikejolley/following{/other_user}","gists_url":"https://api.github.com/users/mikejolley/gists{/gist_id}","starred_url":"https://api.github.com/users/mikejolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikejolley/subscriptions","organizations_url":"https://api.github.com/users/mikejolley/orgs","repos_url":"https://api.github.com/users/mikejolley/repos","events_url":"https://api.github.com/users/mikejolley/events{/privacy}","received_events_url":"https://api.github.com/users/mikejolley/received_events","type":"User","site_admin":false},"body":"we can just call this subtotal","created_at":"2017-11-15T13:57:48Z","updated_at":"2017-11-15T13:59:27Z","html_url":"https://github.com/woocommerce/woocommerce/pull/17710#discussion_r151132228","pull_request_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/17710","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/comments/151132228"},"html":{"href":"https://github.com/woocommerce/woocommerce/pull/17710#discussion_r151132228"},"pull_request":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/17710"}}},"pull_request":{"url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/17710","id":152736038,"html_url":"https://github.com/woocommerce/woocommerce/pull/17710","diff_url":"https://github.com/woocommerce/woocommerce/pull/17710.diff","patch_url":"https://github.com/woocommerce/woocommerce/pull/17710.patch","issue_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/17710","number":17710,"state":"open","locked":false,"title":"Coupon min/max spend based on displayed subtotal","user":{"login":"kloon","id":271630,"avatar_url":"https://avatars1.githubusercontent.com/u/271630?v=4","gravatar_id":"","url":"https://api.github.com/users/kloon","html_url":"https://github.com/kloon","followers_url":"https://api.github.com/users/kloon/followers","following_url":"https://api.github.com/users/kloon/following{/other_user}","gists_url":"https://api.github.com/users/kloon/gists{/gist_id}","starred_url":"https://api.github.com/users/kloon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kloon/subscriptions","organizations_url":"https://api.github.com/users/kloon/orgs","repos_url":"https://api.github.com/users/kloon/repos","events_url":"https://api.github.com/users/kloon/events{/privacy}","received_events_url":"https://api.github.com/users/kloon/received_events","type":"User","site_admin":false},"body":"This PR fixes the issue where the min and max spend was not based on the displayed subtotal. Adjusted the functionality to work out based on what the customer is seeing as the subtotal in the cart and also updated the tooltip to reflect it is based on the displayed subtotal.\r\n\r\nCloses #17697 ","created_at":"2017-11-15T10:25:33Z","updated_at":"2017-11-15T13:59:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cef46fa4ac05102566feee81990faee42c712339","assignee":{"login":"kloon","id":271630,"avatar_url":"https://avatars1.githubusercontent.com/u/271630?v=4","gravatar_id":"","url":"https://api.github.com/users/kloon","html_url":"https://github.com/kloon","followers_url":"https://api.github.com/users/kloon/followers","following_url":"https://api.github.com/users/kloon/following{/other_user}","gists_url":"https://api.github.com/users/kloon/gists{/gist_id}","starred_url":"https://api.github.com/users/kloon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kloon/subscriptions","organizations_url":"https://api.github.com/users/kloon/orgs","repos_url":"https://api.github.com/users/kloon/repos","events_url":"https://api.github.com/users/kloon/events{/privacy}","received_events_url":"https://api.github.com/users/kloon/received_events","type":"User","site_admin":false},"assignees":[{"login":"kloon","id":271630,"avatar_url":"https://avatars1.githubusercontent.com/u/271630?v=4","gravatar_id":"","url":"https://api.github.com/users/kloon","html_url":"https://github.com/kloon","followers_url":"https://api.github.com/users/kloon/followers","following_url":"https://api.github.com/users/kloon/following{/other_user}","gists_url":"https://api.github.com/users/kloon/gists{/gist_id}","starred_url":"https://api.github.com/users/kloon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kloon/subscriptions","organizations_url":"https://api.github.com/users/kloon/orgs","repos_url":"https://api.github.com/users/kloon/repos","events_url":"https://api.github.com/users/kloon/events{/privacy}","received_events_url":"https://api.github.com/users/kloon/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/woocommerce/woocommerce/milestones/107","html_url":"https://github.com/woocommerce/woocommerce/milestone/107","labels_url":"https://api.github.com/repos/woocommerce/woocommerce/milestones/107/labels","id":2886560,"number":107,"title":"3.2.4","description":null,"creator":{"login":"claudiulodro","id":7317227,"avatar_url":"https://avatars3.githubusercontent.com/u/7317227?v=4","gravatar_id":"","url":"https://api.github.com/users/claudiulodro","html_url":"https://github.com/claudiulodro","followers_url":"https://api.github.com/users/claudiulodro/followers","following_url":"https://api.github.com/users/claudiulodro/following{/other_user}","gists_url":"https://api.github.com/users/claudiulodro/gists{/gist_id}","starred_url":"https://api.github.com/users/claudiulodro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/claudiulodro/subscriptions","organizations_url":"https://api.github.com/users/claudiulodro/orgs","repos_url":"https://api.github.com/users/claudiulodro/repos","events_url":"https://api.github.com/users/claudiulodro/events{/privacy}","received_events_url":"https://api.github.com/users/claudiulodro/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":44,"state":"open","created_at":"2017-11-03T17:36:43Z","updated_at":"2017-11-15T11:05:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/17710/commits","review_comments_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/17710/comments","review_comment_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/17710/comments","statuses_url":"https://api.github.com/repos/woocommerce/woocommerce/statuses/4521011219ee5a6ee8fef53404e2a1edf19c728d","head":{"label":"woocommerce:fix/17697-coupon-spend-incl-taxes","ref":"fix/17697-coupon-spend-incl-taxes","sha":"4521011219ee5a6ee8fef53404e2a1edf19c728d","user":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":2179920,"name":"woocommerce","full_name":"woocommerce/woocommerce","owner":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/woocommerce/woocommerce","description":"An open source eCommerce plugin for WordPress.","fork":false,"url":"https://api.github.com/repos/woocommerce/woocommerce","forks_url":"https://api.github.com/repos/woocommerce/woocommerce/forks","keys_url":"https://api.github.com/repos/woocommerce/woocommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woocommerce/woocommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woocommerce/woocommerce/teams","hooks_url":"https://api.github.com/repos/woocommerce/woocommerce/hooks","issue_events_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/events{/number}","events_url":"https://api.github.com/repos/woocommerce/woocommerce/events","assignees_url":"https://api.github.com/repos/woocommerce/woocommerce/assignees{/user}","branches_url":"https://api.github.com/repos/woocommerce/woocommerce/branches{/branch}","tags_url":"https://api.github.com/repos/woocommerce/woocommerce/tags","blobs_url":"https://api.github.com/repos/woocommerce/woocommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woocommerce/woocommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woocommerce/woocommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/woocommerce/woocommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woocommerce/woocommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/woocommerce/woocommerce/languages","stargazers_url":"https://api.github.com/repos/woocommerce/woocommerce/stargazers","contributors_url":"https://api.github.com/repos/woocommerce/woocommerce/contributors","subscribers_url":"https://api.github.com/repos/woocommerce/woocommerce/subscribers","subscription_url":"https://api.github.com/repos/woocommerce/woocommerce/subscription","commits_url":"https://api.github.com/repos/woocommerce/woocommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/woocommerce/woocommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/woocommerce/woocommerce/contents/{+path}","compare_url":"https://api.github.com/repos/woocommerce/woocommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woocommerce/woocommerce/merges","archive_url":"https://api.github.com/repos/woocommerce/woocommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woocommerce/woocommerce/downloads","issues_url":"https://api.github.com/repos/woocommerce/woocommerce/issues{/number}","pulls_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/woocommerce/woocommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/woocommerce/woocommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woocommerce/woocommerce/labels{/name}","releases_url":"https://api.github.com/repos/woocommerce/woocommerce/releases{/id}","deployments_url":"https://api.github.com/repos/woocommerce/woocommerce/deployments","created_at":"2011-08-09T15:12:11Z","updated_at":"2017-11-15T08:17:47Z","pushed_at":"2017-11-15T13:41:34Z","git_url":"git://github.com/woocommerce/woocommerce.git","ssh_url":"git@github.com:woocommerce/woocommerce.git","clone_url":"https://github.com/woocommerce/woocommerce.git","svn_url":"https://github.com/woocommerce/woocommerce","homepage":"http://www.woocommerce.com/","size":135333,"stargazers_count":3865,"watchers_count":3865,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3466,"mirror_url":null,"archived":false,"open_issues_count":82,"forks":3466,"open_issues":82,"watchers":3865,"default_branch":"master"}},"base":{"label":"woocommerce:master","ref":"master","sha":"6a8966382d5975e6545fdaa9ea1b00fc12452ac2","user":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":2179920,"name":"woocommerce","full_name":"woocommerce/woocommerce","owner":{"login":"woocommerce","id":473596,"avatar_url":"https://avatars0.githubusercontent.com/u/473596?v=4","gravatar_id":"","url":"https://api.github.com/users/woocommerce","html_url":"https://github.com/woocommerce","followers_url":"https://api.github.com/users/woocommerce/followers","following_url":"https://api.github.com/users/woocommerce/following{/other_user}","gists_url":"https://api.github.com/users/woocommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/woocommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woocommerce/subscriptions","organizations_url":"https://api.github.com/users/woocommerce/orgs","repos_url":"https://api.github.com/users/woocommerce/repos","events_url":"https://api.github.com/users/woocommerce/events{/privacy}","received_events_url":"https://api.github.com/users/woocommerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/woocommerce/woocommerce","description":"An open source eCommerce plugin for WordPress.","fork":false,"url":"https://api.github.com/repos/woocommerce/woocommerce","forks_url":"https://api.github.com/repos/woocommerce/woocommerce/forks","keys_url":"https://api.github.com/repos/woocommerce/woocommerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woocommerce/woocommerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woocommerce/woocommerce/teams","hooks_url":"https://api.github.com/repos/woocommerce/woocommerce/hooks","issue_events_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/events{/number}","events_url":"https://api.github.com/repos/woocommerce/woocommerce/events","assignees_url":"https://api.github.com/repos/woocommerce/woocommerce/assignees{/user}","branches_url":"https://api.github.com/repos/woocommerce/woocommerce/branches{/branch}","tags_url":"https://api.github.com/repos/woocommerce/woocommerce/tags","blobs_url":"https://api.github.com/repos/woocommerce/woocommerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woocommerce/woocommerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woocommerce/woocommerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/woocommerce/woocommerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woocommerce/woocommerce/statuses/{sha}","languages_url":"https://api.github.com/repos/woocommerce/woocommerce/languages","stargazers_url":"https://api.github.com/repos/woocommerce/woocommerce/stargazers","contributors_url":"https://api.github.com/repos/woocommerce/woocommerce/contributors","subscribers_url":"https://api.github.com/repos/woocommerce/woocommerce/subscribers","subscription_url":"https://api.github.com/repos/woocommerce/woocommerce/subscription","commits_url":"https://api.github.com/repos/woocommerce/woocommerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/woocommerce/woocommerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/woocommerce/woocommerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/woocommerce/woocommerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/woocommerce/woocommerce/contents/{+path}","compare_url":"https://api.github.com/repos/woocommerce/woocommerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woocommerce/woocommerce/merges","archive_url":"https://api.github.com/repos/woocommerce/woocommerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woocommerce/woocommerce/downloads","issues_url":"https://api.github.com/repos/woocommerce/woocommerce/issues{/number}","pulls_url":"https://api.github.com/repos/woocommerce/woocommerce/pulls{/number}","milestones_url":"https://api.github.com/repos/woocommerce/woocommerce/milestones{/number}","notifications_url":"https://api.github.com/repos/woocommerce/woocommerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woocommerce/woocommerce/labels{/name}","releases_url":"https://api.github.com/repos/woocommerce/woocommerce/releases{/id}","deployments_url":"https://api.github.com/repos/woocommerce/woocommerce/deployments","created_at":"2011-08-09T15:12:11Z","updated_at":"2017-11-15T08:17:47Z","pushed_at":"2017-11-15T13:41:34Z","git_url":"git://github.com/woocommerce/woocommerce.git","ssh_url":"git@github.com:woocommerce/woocommerce.git","clone_url":"https://github.com/woocommerce/woocommerce.git","svn_url":"https://github.com/woocommerce/woocommerce","homepage":"http://www.woocommerce.com/","size":135333,"stargazers_count":3865,"watchers_count":3865,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3466,"mirror_url":null,"archived":false,"open_issues_count":82,"forks":3466,"open_issues":82,"watchers":3865,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/17710"},"html":{"href":"https://github.com/woocommerce/woocommerce/pull/17710"},"issue":{"href":"https://api.github.com/repos/woocommerce/woocommerce/issues/17710"},"comments":{"href":"https://api.github.com/repos/woocommerce/woocommerce/issues/17710/comments"},"review_comments":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/17710/comments"},"review_comment":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/woocommerce/woocommerce/pulls/17710/commits"},"statuses":{"href":"https://api.github.com/repos/woocommerce/woocommerce/statuses/4521011219ee5a6ee8fef53404e2a1edf19c728d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"mikejolley"}}