{"action":"created","comment":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/138403496","pull_request_review_id":62193319,"id":138403496,"diff_hunk":"@@ -0,0 +1,57 @@\n+// Distributed under the MIT License.\n+// See LICENSE.txt for details.\n+\n+/// \\file\n+/// Defines base-class FunctionOneD.\n+\n+#pragma once\n+\n+#include <memory>\n+\n+#include \"Options/Factory.hpp\"\n+\n+/// Holds classes implementing FunctionOneD (functions \\f$R\\to R\\f$).\n+namespace FunctionsOneD {}\n+\n+namespace FunctionsOneD {\n+class Gaussian;\n+class Sinusoid;\n+  class PowX;\n+}  // namespace FunctionsOneD\n+\n+/*! \\ingroup FunctionsOneD\n+ *  Encodes a function \\f$R\\to R\\f$.\n+ */\n+class FunctionOneD : public Factory<FunctionOneD> {\n+ public:\n+  static std::string class_id() { return \"FunctionOneD\"; }","path":"src/Numerical/FunctionsOneD/FunctionOneD.hpp","position":27,"original_position":27,"commit_id":"269c289bd39bf554c006b7206a76e8ea78718d91","original_commit_id":"269c289bd39bf554c006b7206a76e8ea78718d91","user":{"login":"wthrowe","id":867117,"avatar_url":"https://avatars1.githubusercontent.com/u/867117?v=4","gravatar_id":"","url":"https://api.github.com/users/wthrowe","html_url":"https://github.com/wthrowe","followers_url":"https://api.github.com/users/wthrowe/followers","following_url":"https://api.github.com/users/wthrowe/following{/other_user}","gists_url":"https://api.github.com/users/wthrowe/gists{/gist_id}","starred_url":"https://api.github.com/users/wthrowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wthrowe/subscriptions","organizations_url":"https://api.github.com/users/wthrowe/orgs","repos_url":"https://api.github.com/users/wthrowe/repos","events_url":"https://api.github.com/users/wthrowe/events{/privacy}","received_events_url":"https://api.github.com/users/wthrowe/received_events","type":"User","site_admin":false},"body":"Remove","created_at":"2017-09-12T16:40:30Z","updated_at":"2017-09-12T16:49:53Z","html_url":"https://github.com/sxs-collaboration/spectre/pull/202#discussion_r138403496","pull_request_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/202","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments/138403496"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/202#discussion_r138403496"},"pull_request":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/202"}}},"pull_request":{"url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/202","id":140606782,"html_url":"https://github.com/sxs-collaboration/spectre/pull/202","diff_url":"https://github.com/sxs-collaboration/spectre/pull/202.diff","patch_url":"https://github.com/sxs-collaboration/spectre/pull/202.patch","issue_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/202","number":202,"state":"open","locked":false,"title":"Add FunctionsOneD and PowX","user":{"login":"osheamonn","id":13049958,"avatar_url":"https://avatars0.githubusercontent.com/u/13049958?v=4","gravatar_id":"","url":"https://api.github.com/users/osheamonn","html_url":"https://github.com/osheamonn","followers_url":"https://api.github.com/users/osheamonn/followers","following_url":"https://api.github.com/users/osheamonn/following{/other_user}","gists_url":"https://api.github.com/users/osheamonn/gists{/gist_id}","starred_url":"https://api.github.com/users/osheamonn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheamonn/subscriptions","organizations_url":"https://api.github.com/users/osheamonn/orgs","repos_url":"https://api.github.com/users/osheamonn/repos","events_url":"https://api.github.com/users/osheamonn/events{/privacy}","received_events_url":"https://api.github.com/users/osheamonn/received_events","type":"User","site_admin":false},"body":"I've a few questions concerning this pull request: \r\n1) Is the placement inside Numerical reasonable? I don't think it's very natural for what are pure math functions to be inside a numerical folder, but we don't currently have anywhere that makes more sense. \r\n\r\n2) What's the preferred method of implementing `operator==` for derived classes? I haven't implemented it yet but we should have one for PowX. \r\n\r\n3) Are we unit testing `create` functions? ","created_at":"2017-09-12T15:08:05Z","updated_at":"2017-09-12T16:49:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7b25897fb0176d650c94c2962dd8eecf179baaa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/202/commits","review_comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/202/comments","review_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/202/comments","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/269c289bd39bf554c006b7206a76e8ea78718d91","head":{"label":"osheamonn:add_one_d_functions","ref":"add_one_d_functions","sha":"269c289bd39bf554c006b7206a76e8ea78718d91","user":{"login":"osheamonn","id":13049958,"avatar_url":"https://avatars0.githubusercontent.com/u/13049958?v=4","gravatar_id":"","url":"https://api.github.com/users/osheamonn","html_url":"https://github.com/osheamonn","followers_url":"https://api.github.com/users/osheamonn/followers","following_url":"https://api.github.com/users/osheamonn/following{/other_user}","gists_url":"https://api.github.com/users/osheamonn/gists{/gist_id}","starred_url":"https://api.github.com/users/osheamonn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheamonn/subscriptions","organizations_url":"https://api.github.com/users/osheamonn/orgs","repos_url":"https://api.github.com/users/osheamonn/repos","events_url":"https://api.github.com/users/osheamonn/events{/privacy}","received_events_url":"https://api.github.com/users/osheamonn/received_events","type":"User","site_admin":false},"repo":{"id":94911451,"name":"spectre","full_name":"osheamonn/spectre","owner":{"login":"osheamonn","id":13049958,"avatar_url":"https://avatars0.githubusercontent.com/u/13049958?v=4","gravatar_id":"","url":"https://api.github.com/users/osheamonn","html_url":"https://github.com/osheamonn","followers_url":"https://api.github.com/users/osheamonn/followers","following_url":"https://api.github.com/users/osheamonn/following{/other_user}","gists_url":"https://api.github.com/users/osheamonn/gists{/gist_id}","starred_url":"https://api.github.com/users/osheamonn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osheamonn/subscriptions","organizations_url":"https://api.github.com/users/osheamonn/orgs","repos_url":"https://api.github.com/users/osheamonn/repos","events_url":"https://api.github.com/users/osheamonn/events{/privacy}","received_events_url":"https://api.github.com/users/osheamonn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/osheamonn/spectre","description":null,"fork":true,"url":"https://api.github.com/repos/osheamonn/spectre","forks_url":"https://api.github.com/repos/osheamonn/spectre/forks","keys_url":"https://api.github.com/repos/osheamonn/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osheamonn/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osheamonn/spectre/teams","hooks_url":"https://api.github.com/repos/osheamonn/spectre/hooks","issue_events_url":"https://api.github.com/repos/osheamonn/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/osheamonn/spectre/events","assignees_url":"https://api.github.com/repos/osheamonn/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/osheamonn/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/osheamonn/spectre/tags","blobs_url":"https://api.github.com/repos/osheamonn/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osheamonn/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osheamonn/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/osheamonn/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osheamonn/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/osheamonn/spectre/languages","stargazers_url":"https://api.github.com/repos/osheamonn/spectre/stargazers","contributors_url":"https://api.github.com/repos/osheamonn/spectre/contributors","subscribers_url":"https://api.github.com/repos/osheamonn/spectre/subscribers","subscription_url":"https://api.github.com/repos/osheamonn/spectre/subscription","commits_url":"https://api.github.com/repos/osheamonn/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/osheamonn/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/osheamonn/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/osheamonn/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/osheamonn/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/osheamonn/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osheamonn/spectre/merges","archive_url":"https://api.github.com/repos/osheamonn/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osheamonn/spectre/downloads","issues_url":"https://api.github.com/repos/osheamonn/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/osheamonn/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/osheamonn/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/osheamonn/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osheamonn/spectre/labels{/name}","releases_url":"https://api.github.com/repos/osheamonn/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/osheamonn/spectre/deployments","created_at":"2017-06-20T16:17:41Z","updated_at":"2017-06-20T16:17:43Z","pushed_at":"2017-09-12T15:07:24Z","git_url":"git://github.com/osheamonn/spectre.git","ssh_url":"git@github.com:osheamonn/spectre.git","clone_url":"https://github.com/osheamonn/spectre.git","svn_url":"https://github.com/osheamonn/spectre","homepage":null,"size":3236,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sxs-collaboration:develop","ref":"develop","sha":"0528a3516f8df4ce976e225f8f79dc43de1a5c32","user":{"login":"sxs-collaboration","id":26882595,"avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"repo":{"id":87570510,"name":"spectre","full_name":"sxs-collaboration/spectre","owner":{"login":"sxs-collaboration","id":26882595,"avatar_url":"https://avatars2.githubusercontent.com/u/26882595?v=4","gravatar_id":"","url":"https://api.github.com/users/sxs-collaboration","html_url":"https://github.com/sxs-collaboration","followers_url":"https://api.github.com/users/sxs-collaboration/followers","following_url":"https://api.github.com/users/sxs-collaboration/following{/other_user}","gists_url":"https://api.github.com/users/sxs-collaboration/gists{/gist_id}","starred_url":"https://api.github.com/users/sxs-collaboration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sxs-collaboration/subscriptions","organizations_url":"https://api.github.com/users/sxs-collaboration/orgs","repos_url":"https://api.github.com/users/sxs-collaboration/repos","events_url":"https://api.github.com/users/sxs-collaboration/events{/privacy}","received_events_url":"https://api.github.com/users/sxs-collaboration/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sxs-collaboration/spectre","description":null,"fork":false,"url":"https://api.github.com/repos/sxs-collaboration/spectre","forks_url":"https://api.github.com/repos/sxs-collaboration/spectre/forks","keys_url":"https://api.github.com/repos/sxs-collaboration/spectre/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sxs-collaboration/spectre/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sxs-collaboration/spectre/teams","hooks_url":"https://api.github.com/repos/sxs-collaboration/spectre/hooks","issue_events_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/events{/number}","events_url":"https://api.github.com/repos/sxs-collaboration/spectre/events","assignees_url":"https://api.github.com/repos/sxs-collaboration/spectre/assignees{/user}","branches_url":"https://api.github.com/repos/sxs-collaboration/spectre/branches{/branch}","tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/tags","blobs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/refs{/sha}","trees_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/{sha}","languages_url":"https://api.github.com/repos/sxs-collaboration/spectre/languages","stargazers_url":"https://api.github.com/repos/sxs-collaboration/spectre/stargazers","contributors_url":"https://api.github.com/repos/sxs-collaboration/spectre/contributors","subscribers_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscribers","subscription_url":"https://api.github.com/repos/sxs-collaboration/spectre/subscription","commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/commits{/sha}","git_commits_url":"https://api.github.com/repos/sxs-collaboration/spectre/git/commits{/sha}","comments_url":"https://api.github.com/repos/sxs-collaboration/spectre/comments{/number}","issue_comment_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues/comments{/number}","contents_url":"https://api.github.com/repos/sxs-collaboration/spectre/contents/{+path}","compare_url":"https://api.github.com/repos/sxs-collaboration/spectre/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sxs-collaboration/spectre/merges","archive_url":"https://api.github.com/repos/sxs-collaboration/spectre/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sxs-collaboration/spectre/downloads","issues_url":"https://api.github.com/repos/sxs-collaboration/spectre/issues{/number}","pulls_url":"https://api.github.com/repos/sxs-collaboration/spectre/pulls{/number}","milestones_url":"https://api.github.com/repos/sxs-collaboration/spectre/milestones{/number}","notifications_url":"https://api.github.com/repos/sxs-collaboration/spectre/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sxs-collaboration/spectre/labels{/name}","releases_url":"https://api.github.com/repos/sxs-collaboration/spectre/releases{/id}","deployments_url":"https://api.github.com/repos/sxs-collaboration/spectre/deployments","created_at":"2017-04-07T17:28:20Z","updated_at":"2017-09-06T02:35:49Z","pushed_at":"2017-09-12T15:19:32Z","git_url":"git://github.com/sxs-collaboration/spectre.git","ssh_url":"git@github.com:sxs-collaboration/spectre.git","clone_url":"https://github.com/sxs-collaboration/spectre.git","svn_url":"https://github.com/sxs-collaboration/spectre","homepage":null,"size":39105,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"open_issues_count":37,"forks":8,"open_issues":37,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/202"},"html":{"href":"https://github.com/sxs-collaboration/spectre/pull/202"},"issue":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/202"},"comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/issues/202/comments"},"review_comments":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/202/comments"},"review_comment":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/pulls/202/commits"},"statuses":{"href":"https://api.github.com/repos/sxs-collaboration/spectre/statuses/269c289bd39bf554c006b7206a76e8ea78718d91"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"wthrowe"}}