{"action":"created","comment":{"url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/comments/152573929","pull_request_review_id":78455097,"id":152573929,"diff_hunk":"@@ -509,6 +509,16 @@ var replyWithArtifact = async function(taskId, runId, name, req, res) {\n       key: artifact.details.key,\n     };\n \n+    res.set('x-amz-meta-runid', runId);\n+    res.set('x-amz-meta-taskid', taskId);\n+    res.set('x-amz-meta-name', name);\n+    res.set('x-amz-meta-content-sha256', artifact.details.contentSha256);","path":"src/artifacts.js","position":7,"original_position":7,"commit_id":"f53a106b7768a8bcd9b01e7664ad3a00575bc8a9","original_commit_id":"f53a106b7768a8bcd9b01e7664ad3a00575bc8a9","user":{"login":"jhford","id":607353,"avatar_url":"https://avatars3.githubusercontent.com/u/607353?v=4","gravatar_id":"","url":"https://api.github.com/users/jhford","html_url":"https://github.com/jhford","followers_url":"https://api.github.com/users/jhford/followers","following_url":"https://api.github.com/users/jhford/following{/other_user}","gists_url":"https://api.github.com/users/jhford/gists{/gist_id}","starred_url":"https://api.github.com/users/jhford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhford/subscriptions","organizations_url":"https://api.github.com/users/jhford/orgs","repos_url":"https://api.github.com/users/jhford/repos","events_url":"https://api.github.com/users/jhford/events{/privacy}","received_events_url":"https://api.github.com/users/jhford/received_events","type":"User","site_admin":false},"body":"nope, x-amz-content-sha256 is the sha256 of the request for the S3 request but is not persisted as an object header.  It is actually closer in relation to x-amz-meta-transfer-sha256 than x-amz-meta-content-sha256.  In single part uploads, it does match exactly x-amz-meta-transfer-sha256 but in multipart it matches per request the sha256 of the content-encoded parts.","created_at":"2017-11-22T14:09:16Z","updated_at":"2017-11-22T14:09:16Z","html_url":"https://github.com/taskcluster/taskcluster-queue/pull/221#discussion_r152573929","pull_request_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/221","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/comments/152573929"},"html":{"href":"https://github.com/taskcluster/taskcluster-queue/pull/221#discussion_r152573929"},"pull_request":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/221"}},"in_reply_to_id":149188394},"pull_request":{"url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/221","id":150546047,"html_url":"https://github.com/taskcluster/taskcluster-queue/pull/221","diff_url":"https://github.com/taskcluster/taskcluster-queue/pull/221.diff","patch_url":"https://github.com/taskcluster/taskcluster-queue/pull/221.patch","issue_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/221","number":221,"state":"open","locked":false,"title":"Disable cloud-mirror for blobs for the time being.","user":{"login":"jhford","id":607353,"avatar_url":"https://avatars3.githubusercontent.com/u/607353?v=4","gravatar_id":"","url":"https://api.github.com/users/jhford","html_url":"https://github.com/jhford","followers_url":"https://api.github.com/users/jhford/followers","following_url":"https://api.github.com/users/jhford/following{/other_user}","gists_url":"https://api.github.com/users/jhford/gists{/gist_id}","starred_url":"https://api.github.com/users/jhford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhford/subscriptions","organizations_url":"https://api.github.com/users/jhford/orgs","repos_url":"https://api.github.com/users/jhford/repos","events_url":"https://api.github.com/users/jhford/events{/privacy}","received_events_url":"https://api.github.com/users/jhford/received_events","type":"User","site_admin":false},"body":"Basically, I need to double check a few things in cloud-mirror before we start\nsending artifacts to it.  Also adding some headers to the 303s that we're\nsending out to include details about the artifact.  This let's us get the\ninformation without actually following a redirect and let's us do sanity checks\nin clients that the artifact we originally asked for matches the one we end up\ngetting, even if there are many redirects in between.","created_at":"2017-11-03T14:46:28Z","updated_at":"2017-11-22T14:09:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a96aca84ccf5476509f2f346ac8b3466fa5114e","assignee":{"login":"jhford","id":607353,"avatar_url":"https://avatars3.githubusercontent.com/u/607353?v=4","gravatar_id":"","url":"https://api.github.com/users/jhford","html_url":"https://github.com/jhford","followers_url":"https://api.github.com/users/jhford/followers","following_url":"https://api.github.com/users/jhford/following{/other_user}","gists_url":"https://api.github.com/users/jhford/gists{/gist_id}","starred_url":"https://api.github.com/users/jhford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhford/subscriptions","organizations_url":"https://api.github.com/users/jhford/orgs","repos_url":"https://api.github.com/users/jhford/repos","events_url":"https://api.github.com/users/jhford/events{/privacy}","received_events_url":"https://api.github.com/users/jhford/received_events","type":"User","site_admin":false},"assignees":[{"login":"jhford","id":607353,"avatar_url":"https://avatars3.githubusercontent.com/u/607353?v=4","gravatar_id":"","url":"https://api.github.com/users/jhford","html_url":"https://github.com/jhford","followers_url":"https://api.github.com/users/jhford/followers","following_url":"https://api.github.com/users/jhford/following{/other_user}","gists_url":"https://api.github.com/users/jhford/gists{/gist_id}","starred_url":"https://api.github.com/users/jhford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhford/subscriptions","organizations_url":"https://api.github.com/users/jhford/orgs","repos_url":"https://api.github.com/users/jhford/repos","events_url":"https://api.github.com/users/jhford/events{/privacy}","received_events_url":"https://api.github.com/users/jhford/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/221/commits","review_comments_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/221/comments","review_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/comments{/number}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/221/comments","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/statuses/f53a106b7768a8bcd9b01e7664ad3a00575bc8a9","head":{"label":"taskcluster:set-headers-for-blob-types","ref":"set-headers-for-blob-types","sha":"f53a106b7768a8bcd9b01e7664ad3a00575bc8a9","user":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":16423616,"name":"taskcluster-queue","full_name":"taskcluster/taskcluster-queue","owner":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/taskcluster-queue","description":"The central queue coordinating execution of tasks in the taskcluster setup.","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-queue","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/deployments","created_at":"2014-01-31T23:12:31Z","updated_at":"2017-07-28T07:05:36Z","pushed_at":"2017-11-22T14:07:14Z","git_url":"git://github.com/taskcluster/taskcluster-queue.git","ssh_url":"git@github.com:taskcluster/taskcluster-queue.git","clone_url":"https://github.com/taskcluster/taskcluster-queue.git","svn_url":"https://github.com/taskcluster/taskcluster-queue","homepage":"","size":17098,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":18,"open_issues":6,"watchers":4,"default_branch":"master"}},"base":{"label":"taskcluster:master","ref":"master","sha":"21e2769375f61e762a386e192c6be1cc5b2135b3","user":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"repo":{"id":16423616,"name":"taskcluster-queue","full_name":"taskcluster/taskcluster-queue","owner":{"login":"taskcluster","id":6257436,"avatar_url":"https://avatars2.githubusercontent.com/u/6257436?v=4","gravatar_id":"","url":"https://api.github.com/users/taskcluster","html_url":"https://github.com/taskcluster","followers_url":"https://api.github.com/users/taskcluster/followers","following_url":"https://api.github.com/users/taskcluster/following{/other_user}","gists_url":"https://api.github.com/users/taskcluster/gists{/gist_id}","starred_url":"https://api.github.com/users/taskcluster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taskcluster/subscriptions","organizations_url":"https://api.github.com/users/taskcluster/orgs","repos_url":"https://api.github.com/users/taskcluster/repos","events_url":"https://api.github.com/users/taskcluster/events{/privacy}","received_events_url":"https://api.github.com/users/taskcluster/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/taskcluster/taskcluster-queue","description":"The central queue coordinating execution of tasks in the taskcluster setup.","fork":false,"url":"https://api.github.com/repos/taskcluster/taskcluster-queue","forks_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/forks","keys_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/teams","hooks_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/hooks","issue_events_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/events{/number}","events_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/events","assignees_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/assignees{/user}","branches_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/branches{/branch}","tags_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/tags","blobs_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/refs{/sha}","trees_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/statuses/{sha}","languages_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/languages","stargazers_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/stargazers","contributors_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/contributors","subscribers_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/subscribers","subscription_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/subscription","commits_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/commits{/sha}","git_commits_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/git/commits{/sha}","comments_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/comments{/number}","issue_comment_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/comments{/number}","contents_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/contents/{+path}","compare_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/merges","archive_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/downloads","issues_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues{/number}","pulls_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls{/number}","milestones_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/milestones{/number}","notifications_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/labels{/name}","releases_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/releases{/id}","deployments_url":"https://api.github.com/repos/taskcluster/taskcluster-queue/deployments","created_at":"2014-01-31T23:12:31Z","updated_at":"2017-07-28T07:05:36Z","pushed_at":"2017-11-22T14:07:14Z","git_url":"git://github.com/taskcluster/taskcluster-queue.git","ssh_url":"git@github.com:taskcluster/taskcluster-queue.git","clone_url":"https://github.com/taskcluster/taskcluster-queue.git","svn_url":"https://github.com/taskcluster/taskcluster-queue","homepage":"","size":17098,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":6,"forks":18,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/221"},"html":{"href":"https://github.com/taskcluster/taskcluster-queue/pull/221"},"issue":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/221"},"comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/issues/221/comments"},"review_comments":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/221/comments"},"review_comment":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/pulls/221/commits"},"statuses":{"href":"https://api.github.com/repos/taskcluster/taskcluster-queue/statuses/f53a106b7768a8bcd9b01e7664ad3a00575bc8a9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jhford"}}