{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/5292","repository_url":"https://api.github.com/repos/mozilla/fxa-content-server","labels_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/5292/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/5292/comments","events_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/5292/events","html_url":"https://github.com/mozilla/fxa-content-server/issues/5292","id":245920799,"number":5292,"title":"addresses engine always offered for Firefox 56+","user":{"login":"mhammond","id":83924,"avatar_url":"https://avatars1.githubusercontent.com/u/83924?v=4","gravatar_id":"","url":"https://api.github.com/users/mhammond","html_url":"https://github.com/mhammond","followers_url":"https://api.github.com/users/mhammond/followers","following_url":"https://api.github.com/users/mhammond/following{/other_user}","gists_url":"https://api.github.com/users/mhammond/gists{/gist_id}","starred_url":"https://api.github.com/users/mhammond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhammond/subscriptions","organizations_url":"https://api.github.com/users/mhammond/orgs","repos_url":"https://api.github.com/users/mhammond/repos","events_url":"https://api.github.com/users/mhammond/events{/privacy}","received_events_url":"https://api.github.com/users/mhammond/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-27T04:12:06Z","updated_at":"2017-07-27T04:22:16Z","closed_at":null,"body":"I know we agreed to this way back when, but it seems a little risky and may be worth addressing: the \"addresses\" engine is always offered to Firefox 56 even when that preference is pref'd off in desktop itself. There's a small risk addresses will not be enabled for 56 and if it is not, it's probably bad to offer the engine.\r\n\r\nI understand there's a bit of a risk in making this change on the server, but I'm not quite sure how to balance that against the risk of addresses not making 56 - IIUC, the only thing we are waiting on is QA signoff, and I *think* it will be fine, but I'm getting this on file anyway."},"comment":{"url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/comments/318254606","html_url":"https://github.com/mozilla/fxa-content-server/issues/5292#issuecomment-318254606","issue_url":"https://api.github.com/repos/mozilla/fxa-content-server/issues/5292","id":318254606,"user":{"login":"rfk","id":34695,"avatar_url":"https://avatars3.githubusercontent.com/u/34695?v=4","gravatar_id":"","url":"https://api.github.com/users/rfk","html_url":"https://github.com/rfk","followers_url":"https://api.github.com/users/rfk/followers","following_url":"https://api.github.com/users/rfk/following{/other_user}","gists_url":"https://api.github.com/users/rfk/gists{/gist_id}","starred_url":"https://api.github.com/users/rfk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfk/subscriptions","organizations_url":"https://api.github.com/users/rfk/orgs","repos_url":"https://api.github.com/users/rfk/repos","events_url":"https://api.github.com/users/rfk/events{/privacy}","received_events_url":"https://api.github.com/users/rfk/received_events","type":"User","site_admin":false},"created_at":"2017-07-27T04:22:16Z","updated_at":"2017-07-27T04:22:16Z","body":"Mark clarified in IRC that *if* addresses ships in 56 then it will advertise that fact in the device capability handshake, so IIUC the ask here is to remove the hardcoded \"show addresses engines to Firefox 56+\" and let it fall back to the more general \"show addresses engines if it's advertised in the capabilities handshake\".\r\n\r\nI've no idea how big a change that is for us on the FxA side tho..."}}
{"actor":{"display_login":"rfk"}}