{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/project-system/issues/2071","repository_url":"https://api.github.com/repos/dotnet/project-system","labels_url":"https://api.github.com/repos/dotnet/project-system/issues/2071/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/project-system/issues/2071/comments","events_url":"https://api.github.com/repos/dotnet/project-system/issues/2071/events","html_url":"https://github.com/dotnet/project-system/pull/2071","id":224257047,"number":2071,"title":"Add a provider which adds Runtime assemblies to metadata reference for VB Framework projects","user":{"login":"basoundr","id":10550513,"avatar_url":"https://avatars1.githubusercontent.com/u/10550513?v=3","gravatar_id":"","url":"https://api.github.com/users/basoundr","html_url":"https://github.com/basoundr","followers_url":"https://api.github.com/users/basoundr/followers","following_url":"https://api.github.com/users/basoundr/following{/other_user}","gists_url":"https://api.github.com/users/basoundr/gists{/gist_id}","starred_url":"https://api.github.com/users/basoundr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basoundr/subscriptions","organizations_url":"https://api.github.com/users/basoundr/orgs","repos_url":"https://api.github.com/users/basoundr/repos","events_url":"https://api.github.com/users/basoundr/events{/privacy}","received_events_url":"https://api.github.com/users/basoundr/received_events","type":"User","site_admin":false},"labels":[{"id":370752484,"url":"https://api.github.com/repos/dotnet/project-system/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-04-25T20:08:14Z","updated_at":"2017-04-27T21:14:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/project-system/pulls/2071","html_url":"https://github.com/dotnet/project-system/pull/2071","diff_url":"https://github.com/dotnet/project-system/pull/2071.diff","patch_url":"https://github.com/dotnet/project-system/pull/2071.patch"},"body":"VB Framework projects needs references to the Core libraries, without which Object and all the essential types will be missing. This reference was added by VisualBasic Project in the legacy world. This change will perform a similar functionality but not at the CPSProject level, the equivalent of the VisualBasic project in the legacy world.\r\n\r\nCurrently this Provider is added to the Managed VS layer since currently there is no IVT for VB VS layer to ServicesVisualStudio project in Roslyn. Once the change to add IVT to VB VS layer, this provider should move to the VB VS Layer. Issue - #2072\r\n\r\nTagging @srivatsn @dotnet/project-system for review\r\n\r\nTests are on the way. Will update the PR when ready.\r\n\r\n**Customer scenario**\r\n\r\nWithout this change, the language service for all of VB framework projects is broken\r\n\r\n**Bugs this fixes:** \r\n\r\n#1961 \r\n\r\n**Workarounds, if any**\r\n\r\nNone\r\n\r\n**Risk**\r\n\r\nLow. This change is only for VB framework projects.\r\n\r\n**Performance impact**\r\n\r\nNone. There is no complex computation. \r\n\r\n**Is this a regression from a previous update?**\r\n\r\nNo. This scenario could not have worked before unless the Core libraries were added by mistake.\r\n\r\n**Root cause analysis:**\r\n\r\nThis is parity behavior of the VB Legacy Project which is one of the many things that VB does.\r\n\r\n**How was the bug found?**\r\n\r\nAd-hoc testing\r\n"},"comment":{"url":"https://api.github.com/repos/dotnet/project-system/issues/comments/297841337","html_url":"https://github.com/dotnet/project-system/pull/2071#issuecomment-297841337","issue_url":"https://api.github.com/repos/dotnet/project-system/issues/2071","id":297841337,"user":{"login":"basoundr","id":10550513,"avatar_url":"https://avatars1.githubusercontent.com/u/10550513?v=3","gravatar_id":"","url":"https://api.github.com/users/basoundr","html_url":"https://github.com/basoundr","followers_url":"https://api.github.com/users/basoundr/followers","following_url":"https://api.github.com/users/basoundr/following{/other_user}","gists_url":"https://api.github.com/users/basoundr/gists{/gist_id}","starred_url":"https://api.github.com/users/basoundr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basoundr/subscriptions","organizations_url":"https://api.github.com/users/basoundr/orgs","repos_url":"https://api.github.com/users/basoundr/repos","events_url":"https://api.github.com/users/basoundr/events{/privacy}","received_events_url":"https://api.github.com/users/basoundr/received_events","type":"User","site_admin":false},"created_at":"2017-04-27T21:14:35Z","updated_at":"2017-04-27T21:14:35Z","body":"@srivatsn I have addressed your concerns and I have combined the behavior of [Vbc Task](http://index/?leftProject=Microsoft.Build.Tasks.v4.0&leftSymbol=v0z2ullltq6z&file=Vbc.cs&line=430) and old LS behavior(http://index/?query=visualbasicprojectoptions&rightProject=Microsoft.VisualStudio.LanguageServices.VisualBasic&file=ProjectSystemShim%5CVisualBasicProjectOptionsHelper.vb&line=114)"}}
{"actor":{"display_login":"basoundr"}}