{"action":"closed","issue":{"url":"https://api.github.com/repos/amarburg/lsd_slam/issues/16","repository_url":"https://api.github.com/repos/amarburg/lsd_slam","labels_url":"https://api.github.com/repos/amarburg/lsd_slam/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/amarburg/lsd_slam/issues/16/comments","events_url":"https://api.github.com/repos/amarburg/lsd_slam/issues/16/events","html_url":"https://github.com/amarburg/lsd_slam/issues/16","id":221401490,"number":16,"title":"Add Eigen3 as system library","user":{"login":"FirefoxMetzger","id":4402489,"avatar_url":"https://avatars2.githubusercontent.com/u/4402489?v=3","gravatar_id":"","url":"https://api.github.com/users/FirefoxMetzger","html_url":"https://github.com/FirefoxMetzger","followers_url":"https://api.github.com/users/FirefoxMetzger/followers","following_url":"https://api.github.com/users/FirefoxMetzger/following{/other_user}","gists_url":"https://api.github.com/users/FirefoxMetzger/gists{/gist_id}","starred_url":"https://api.github.com/users/FirefoxMetzger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FirefoxMetzger/subscriptions","organizations_url":"https://api.github.com/users/FirefoxMetzger/orgs","repos_url":"https://api.github.com/users/FirefoxMetzger/repos","events_url":"https://api.github.com/users/FirefoxMetzger/events{/privacy}","received_events_url":"https://api.github.com/users/FirefoxMetzger/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-04-12T21:54:22Z","updated_at":"2017-04-13T22:23:20Z","closed_at":"2017-04-13T22:23:20Z","body":"While compiling the project with warning `-Wignored-attributes` Eigen3 turns into a very ... very chatty library. It makes it unnecessarily hard to spot actual compile errors.\r\n\r\nAdding it as a system library like\r\n\r\n    set( LSDSLAM_INCLUDE_DIRS                                                                 \r\n    ${CMAKE_SOURCE_DIR}/lib                                                               \r\n    ${CMAKE_SOURCE_DIR}/lib/lsd_core                                                      \r\n    ${OpenCV_INCLUDE_DIRS}                                                                \r\n    ${Boost_INCLUDE_DIR}                                                                  \r\n    ${Pangolin_INCLUDE_DIRS}                                                              \r\n    ${PROJECT_SOURCE_DIR}/thirdparty/Sophus                                               \r\n    ${G2O_INCLUDE_DIR}                                                                    \r\n    SYSTEM ${EIGEN3_INCLUDE_DIR} )   \r\n\r\nin the top level `CMakeLists.txt` stops Eigen3 from printing warnings. This makes the build process much cleaner."}}
{"actor":{"display_login":"amarburg"}}