{"action":"created","comment":{"url":"https://api.github.com/repos/gridstack/gridstack.js/pulls/comments/139595609","pull_request_review_id":63548233,"id":139595609,"diff_hunk":"@@ -5,16 +5,16 @@ describe('gridstack', function() {\n     var w;\n     var gridstackHTML =\n         '<div class=\"grid-stack\">' +","path":"spec/gridstack-spec.js","position":3,"original_position":3,"commit_id":"b00f81607a5231d00eb9dfee46e0d98ca2013f77","original_commit_id":"b00f81607a5231d00eb9dfee46e0d98ca2013f77","user":{"login":"adumesny","id":3496166,"avatar_url":"https://avatars1.githubusercontent.com/u/3496166?v=4","gravatar_id":"","url":"https://api.github.com/users/adumesny","html_url":"https://github.com/adumesny","followers_url":"https://api.github.com/users/adumesny/followers","following_url":"https://api.github.com/users/adumesny/following{/other_user}","gists_url":"https://api.github.com/users/adumesny/gists{/gist_id}","starred_url":"https://api.github.com/users/adumesny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adumesny/subscriptions","organizations_url":"https://api.github.com/users/adumesny/orgs","repos_url":"https://api.github.com/users/adumesny/repos","events_url":"https://api.github.com/users/adumesny/events{/privacy}","received_events_url":"https://api.github.com/users/adumesny/received_events","type":"User","site_admin":false},"body":"those are just formatting 2 spaces change. ignore.","created_at":"2017-09-19T04:33:44Z","updated_at":"2017-09-19T04:37:57Z","html_url":"https://github.com/gridstack/gridstack.js/pull/786#discussion_r139595609","pull_request_url":"https://api.github.com/repos/gridstack/gridstack.js/pulls/786","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gridstack/gridstack.js/pulls/comments/139595609"},"html":{"href":"https://github.com/gridstack/gridstack.js/pull/786#discussion_r139595609"},"pull_request":{"href":"https://api.github.com/repos/gridstack/gridstack.js/pulls/786"}}},"pull_request":{"url":"https://api.github.com/repos/gridstack/gridstack.js/pulls/786","id":141727909,"html_url":"https://github.com/gridstack/gridstack.js/pull/786","diff_url":"https://github.com/gridstack/gridstack.js/pull/786.diff","patch_url":"https://github.com/gridstack/gridstack.js/pull/786.patch","issue_url":"https://api.github.com/repos/gridstack/gridstack.js/issues/786","number":786,"state":"open","locked":false,"title":"fixed cellHeight() check for no-op return","user":{"login":"adumesny","id":3496166,"avatar_url":"https://avatars1.githubusercontent.com/u/3496166?v=4","gravatar_id":"","url":"https://api.github.com/users/adumesny","html_url":"https://github.com/adumesny","followers_url":"https://api.github.com/users/adumesny/followers","following_url":"https://api.github.com/users/adumesny/following{/other_user}","gists_url":"https://api.github.com/users/adumesny/gists{/gist_id}","starred_url":"https://api.github.com/users/adumesny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adumesny/subscriptions","organizations_url":"https://api.github.com/users/adumesny/orgs","repos_url":"https://api.github.com/users/adumesny/repos","events_url":"https://api.github.com/users/adumesny/events{/privacy}","received_events_url":"https://api.github.com/users/adumesny/received_events","type":"User","site_admin":false},"body":"the code that checked for cell height and unit being the same was incorrect.\r\n\r\nTesting Done:  calling this should be no-op, but wasn't\r\nthis.grid.cellHeight( this.grid.cellHeight() );\r\n\r\ncode right below uses correct names\r\nthis.opts.cellHeightUnit = heightData.unit;\r\nthis.opts.cellHeight = heightData.height;\r\n\r\nP.S. this is why Typescript is good - you don't do those stupid JS typos....","created_at":"2017-09-18T23:34:28Z","updated_at":"2017-09-19T04:37:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdcb66c29c3baa472bee410f357bb952746088d7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gridstack/gridstack.js/pulls/786/commits","review_comments_url":"https://api.github.com/repos/gridstack/gridstack.js/pulls/786/comments","review_comment_url":"https://api.github.com/repos/gridstack/gridstack.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gridstack/gridstack.js/issues/786/comments","statuses_url":"https://api.github.com/repos/gridstack/gridstack.js/statuses/b00f81607a5231d00eb9dfee46e0d98ca2013f77","head":{"label":"adumesny:develop","ref":"develop","sha":"b00f81607a5231d00eb9dfee46e0d98ca2013f77","user":{"login":"adumesny","id":3496166,"avatar_url":"https://avatars1.githubusercontent.com/u/3496166?v=4","gravatar_id":"","url":"https://api.github.com/users/adumesny","html_url":"https://github.com/adumesny","followers_url":"https://api.github.com/users/adumesny/followers","following_url":"https://api.github.com/users/adumesny/following{/other_user}","gists_url":"https://api.github.com/users/adumesny/gists{/gist_id}","starred_url":"https://api.github.com/users/adumesny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adumesny/subscriptions","organizations_url":"https://api.github.com/users/adumesny/orgs","repos_url":"https://api.github.com/users/adumesny/repos","events_url":"https://api.github.com/users/adumesny/events{/privacy}","received_events_url":"https://api.github.com/users/adumesny/received_events","type":"User","site_admin":false},"repo":{"id":98580361,"name":"gridstack.js","full_name":"adumesny/gridstack.js","owner":{"login":"adumesny","id":3496166,"avatar_url":"https://avatars1.githubusercontent.com/u/3496166?v=4","gravatar_id":"","url":"https://api.github.com/users/adumesny","html_url":"https://github.com/adumesny","followers_url":"https://api.github.com/users/adumesny/followers","following_url":"https://api.github.com/users/adumesny/following{/other_user}","gists_url":"https://api.github.com/users/adumesny/gists{/gist_id}","starred_url":"https://api.github.com/users/adumesny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adumesny/subscriptions","organizations_url":"https://api.github.com/users/adumesny/orgs","repos_url":"https://api.github.com/users/adumesny/repos","events_url":"https://api.github.com/users/adumesny/events{/privacy}","received_events_url":"https://api.github.com/users/adumesny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adumesny/gridstack.js","description":"gridstack.js is a jQuery plugin for widget layout","fork":true,"url":"https://api.github.com/repos/adumesny/gridstack.js","forks_url":"https://api.github.com/repos/adumesny/gridstack.js/forks","keys_url":"https://api.github.com/repos/adumesny/gridstack.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adumesny/gridstack.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adumesny/gridstack.js/teams","hooks_url":"https://api.github.com/repos/adumesny/gridstack.js/hooks","issue_events_url":"https://api.github.com/repos/adumesny/gridstack.js/issues/events{/number}","events_url":"https://api.github.com/repos/adumesny/gridstack.js/events","assignees_url":"https://api.github.com/repos/adumesny/gridstack.js/assignees{/user}","branches_url":"https://api.github.com/repos/adumesny/gridstack.js/branches{/branch}","tags_url":"https://api.github.com/repos/adumesny/gridstack.js/tags","blobs_url":"https://api.github.com/repos/adumesny/gridstack.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adumesny/gridstack.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adumesny/gridstack.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/adumesny/gridstack.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adumesny/gridstack.js/statuses/{sha}","languages_url":"https://api.github.com/repos/adumesny/gridstack.js/languages","stargazers_url":"https://api.github.com/repos/adumesny/gridstack.js/stargazers","contributors_url":"https://api.github.com/repos/adumesny/gridstack.js/contributors","subscribers_url":"https://api.github.com/repos/adumesny/gridstack.js/subscribers","subscription_url":"https://api.github.com/repos/adumesny/gridstack.js/subscription","commits_url":"https://api.github.com/repos/adumesny/gridstack.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/adumesny/gridstack.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/adumesny/gridstack.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/adumesny/gridstack.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/adumesny/gridstack.js/contents/{+path}","compare_url":"https://api.github.com/repos/adumesny/gridstack.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adumesny/gridstack.js/merges","archive_url":"https://api.github.com/repos/adumesny/gridstack.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adumesny/gridstack.js/downloads","issues_url":"https://api.github.com/repos/adumesny/gridstack.js/issues{/number}","pulls_url":"https://api.github.com/repos/adumesny/gridstack.js/pulls{/number}","milestones_url":"https://api.github.com/repos/adumesny/gridstack.js/milestones{/number}","notifications_url":"https://api.github.com/repos/adumesny/gridstack.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adumesny/gridstack.js/labels{/name}","releases_url":"https://api.github.com/repos/adumesny/gridstack.js/releases{/id}","deployments_url":"https://api.github.com/repos/adumesny/gridstack.js/deployments","created_at":"2017-07-27T21:14:56Z","updated_at":"2017-09-14T21:19:10Z","pushed_at":"2017-09-19T04:13:10Z","git_url":"git://github.com/adumesny/gridstack.js.git","ssh_url":"git@github.com:adumesny/gridstack.js.git","clone_url":"https://github.com/adumesny/gridstack.js.git","svn_url":"https://github.com/adumesny/gridstack.js","homepage":null,"size":1484,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"gridstack:develop","ref":"develop","sha":"10e141edfb13bf81b0202f51dd78e81a0ccf2fb7","user":{"login":"gridstack","id":31674162,"avatar_url":"https://avatars1.githubusercontent.com/u/31674162?v=4","gravatar_id":"","url":"https://api.github.com/users/gridstack","html_url":"https://github.com/gridstack","followers_url":"https://api.github.com/users/gridstack/followers","following_url":"https://api.github.com/users/gridstack/following{/other_user}","gists_url":"https://api.github.com/users/gridstack/gists{/gist_id}","starred_url":"https://api.github.com/users/gridstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridstack/subscriptions","organizations_url":"https://api.github.com/users/gridstack/orgs","repos_url":"https://api.github.com/users/gridstack/repos","events_url":"https://api.github.com/users/gridstack/events{/privacy}","received_events_url":"https://api.github.com/users/gridstack/received_events","type":"Organization","site_admin":false},"repo":{"id":26417283,"name":"gridstack.js","full_name":"gridstack/gridstack.js","owner":{"login":"gridstack","id":31674162,"avatar_url":"https://avatars1.githubusercontent.com/u/31674162?v=4","gravatar_id":"","url":"https://api.github.com/users/gridstack","html_url":"https://github.com/gridstack","followers_url":"https://api.github.com/users/gridstack/followers","following_url":"https://api.github.com/users/gridstack/following{/other_user}","gists_url":"https://api.github.com/users/gridstack/gists{/gist_id}","starred_url":"https://api.github.com/users/gridstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridstack/subscriptions","organizations_url":"https://api.github.com/users/gridstack/orgs","repos_url":"https://api.github.com/users/gridstack/repos","events_url":"https://api.github.com/users/gridstack/events{/privacy}","received_events_url":"https://api.github.com/users/gridstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gridstack/gridstack.js","description":"gridstack.js is a jQuery plugin for widget layout","fork":false,"url":"https://api.github.com/repos/gridstack/gridstack.js","forks_url":"https://api.github.com/repos/gridstack/gridstack.js/forks","keys_url":"https://api.github.com/repos/gridstack/gridstack.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gridstack/gridstack.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gridstack/gridstack.js/teams","hooks_url":"https://api.github.com/repos/gridstack/gridstack.js/hooks","issue_events_url":"https://api.github.com/repos/gridstack/gridstack.js/issues/events{/number}","events_url":"https://api.github.com/repos/gridstack/gridstack.js/events","assignees_url":"https://api.github.com/repos/gridstack/gridstack.js/assignees{/user}","branches_url":"https://api.github.com/repos/gridstack/gridstack.js/branches{/branch}","tags_url":"https://api.github.com/repos/gridstack/gridstack.js/tags","blobs_url":"https://api.github.com/repos/gridstack/gridstack.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gridstack/gridstack.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gridstack/gridstack.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/gridstack/gridstack.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gridstack/gridstack.js/statuses/{sha}","languages_url":"https://api.github.com/repos/gridstack/gridstack.js/languages","stargazers_url":"https://api.github.com/repos/gridstack/gridstack.js/stargazers","contributors_url":"https://api.github.com/repos/gridstack/gridstack.js/contributors","subscribers_url":"https://api.github.com/repos/gridstack/gridstack.js/subscribers","subscription_url":"https://api.github.com/repos/gridstack/gridstack.js/subscription","commits_url":"https://api.github.com/repos/gridstack/gridstack.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/gridstack/gridstack.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/gridstack/gridstack.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/gridstack/gridstack.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/gridstack/gridstack.js/contents/{+path}","compare_url":"https://api.github.com/repos/gridstack/gridstack.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gridstack/gridstack.js/merges","archive_url":"https://api.github.com/repos/gridstack/gridstack.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gridstack/gridstack.js/downloads","issues_url":"https://api.github.com/repos/gridstack/gridstack.js/issues{/number}","pulls_url":"https://api.github.com/repos/gridstack/gridstack.js/pulls{/number}","milestones_url":"https://api.github.com/repos/gridstack/gridstack.js/milestones{/number}","notifications_url":"https://api.github.com/repos/gridstack/gridstack.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gridstack/gridstack.js/labels{/name}","releases_url":"https://api.github.com/repos/gridstack/gridstack.js/releases{/id}","deployments_url":"https://api.github.com/repos/gridstack/gridstack.js/deployments","created_at":"2014-11-10T02:18:32Z","updated_at":"2017-09-18T18:17:24Z","pushed_at":"2017-09-19T04:13:13Z","git_url":"git://github.com/gridstack/gridstack.js.git","ssh_url":"git@github.com:gridstack/gridstack.js.git","clone_url":"https://github.com/gridstack/gridstack.js.git","svn_url":"https://github.com/gridstack/gridstack.js","homepage":null,"size":1470,"stargazers_count":2128,"watchers_count":2128,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":632,"mirror_url":null,"open_issues_count":95,"forks":632,"open_issues":95,"watchers":2128,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gridstack/gridstack.js/pulls/786"},"html":{"href":"https://github.com/gridstack/gridstack.js/pull/786"},"issue":{"href":"https://api.github.com/repos/gridstack/gridstack.js/issues/786"},"comments":{"href":"https://api.github.com/repos/gridstack/gridstack.js/issues/786/comments"},"review_comments":{"href":"https://api.github.com/repos/gridstack/gridstack.js/pulls/786/comments"},"review_comment":{"href":"https://api.github.com/repos/gridstack/gridstack.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gridstack/gridstack.js/pulls/786/commits"},"statuses":{"href":"https://api.github.com/repos/gridstack/gridstack.js/statuses/b00f81607a5231d00eb9dfee46e0d98ca2013f77"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adumesny"}}