{"action":"created","comment":{"url":"https://api.github.com/repos/vaadin/flow/pulls/comments/145626934","pull_request_review_id":70452434,"id":145626934,"diff_hunk":"@@ -0,0 +1,124 @@\n+/*\n+ * Copyright 2000-2017 Vaadin Ltd.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not\n+ * use this file except in compliance with the License. You may obtain a copy of\n+ * the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package com.vaadin.ui.html;\n+\n+import com.vaadin.ui.common.HtmlContainer;\n+import com.vaadin.ui.common.PropertyDescriptor;\n+import com.vaadin.ui.common.PropertyDescriptors;\n+import com.vaadin.ui.event.ClickNotifier;\n+import com.vaadin.ui.Component;\n+import com.vaadin.ui.Tag;\n+\n+/**\n+ * Component representing a <code>&lt;ol&gt;</code> element.\n+ *\n+ * @author Vaadin Ltd\n+ */\n+@Tag(Tag.OL)\n+public class OrderedList extends HtmlContainer implements ClickNotifier {\n+\n+    public static enum ItemType {","path":"flow-html-components/src/main/java/com/vaadin/ui/html/OrderedList.java","position":33,"original_position":33,"commit_id":"7e6a04d0538afefe68e942fa44df35f169236869","original_commit_id":"7e6a04d0538afefe68e942fa44df35f169236869","user":{"login":"vaadin-bot","id":20280877,"avatar_url":"https://avatars1.githubusercontent.com/u/20280877?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin-bot","html_url":"https://github.com/vaadin-bot","followers_url":"https://api.github.com/users/vaadin-bot/followers","following_url":"https://api.github.com/users/vaadin-bot/following{/other_user}","gists_url":"https://api.github.com/users/vaadin-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin-bot/subscriptions","organizations_url":"https://api.github.com/users/vaadin-bot/orgs","repos_url":"https://api.github.com/users/vaadin-bot/repos","events_url":"https://api.github.com/users/vaadin-bot/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin-bot/received_events","type":"User","site_admin":false},"body":"![CRITICAL](https://sonarsource.github.io/sonar-github/severity-critical.png 'Severity: CRITICAL') Document this public enum. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AUndocumentedApi)\n![MINOR](https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR') Remove this redundant \"static\" qualifier. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.projects.vaadin.com/coding_rules#rule_key=squid%3AS2786)\n","created_at":"2017-10-19T08:12:17Z","updated_at":"2017-10-19T08:12:17Z","html_url":"https://github.com/vaadin/flow/pull/2719#discussion_r145626934","pull_request_url":"https://api.github.com/repos/vaadin/flow/pulls/2719","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/vaadin/flow/pulls/comments/145626934"},"html":{"href":"https://github.com/vaadin/flow/pull/2719#discussion_r145626934"},"pull_request":{"href":"https://api.github.com/repos/vaadin/flow/pulls/2719"}}},"pull_request":{"url":"https://api.github.com/repos/vaadin/flow/pulls/2719","id":147409529,"html_url":"https://github.com/vaadin/flow/pull/2719","diff_url":"https://github.com/vaadin/flow/pull/2719.diff","patch_url":"https://github.com/vaadin/flow/pull/2719.patch","issue_url":"https://api.github.com/repos/vaadin/flow/issues/2719","number":2719,"state":"open","locked":false,"title":"Add missing base HTML elements","user":{"login":"heruan","id":851745,"avatar_url":"https://avatars2.githubusercontent.com/u/851745?v=4","gravatar_id":"","url":"https://api.github.com/users/heruan","html_url":"https://github.com/heruan","followers_url":"https://api.github.com/users/heruan/followers","following_url":"https://api.github.com/users/heruan/following{/other_user}","gists_url":"https://api.github.com/users/heruan/gists{/gist_id}","starred_url":"https://api.github.com/users/heruan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heruan/subscriptions","organizations_url":"https://api.github.com/users/heruan/orgs","repos_url":"https://api.github.com/users/heruan/repos","events_url":"https://api.github.com/users/heruan/events{/privacy}","received_events_url":"https://api.github.com/users/heruan/received_events","type":"User","site_admin":false},"body":"Fixes #2535 adding `<p>` elements and also `<li>`, `<ul>`, `<ol>`, `<dl>`, `<dt>` and `<dd>`.\r\n\r\nTests are coming.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/flow/2719)\n<!-- Reviewable:end -->\n","created_at":"2017-10-18T21:02:11Z","updated_at":"2017-10-19T08:12:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ef421395ddf3281d5d6ae814c14d8c1eb2077fb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/vaadin/flow/pulls/2719/commits","review_comments_url":"https://api.github.com/repos/vaadin/flow/pulls/2719/comments","review_comment_url":"https://api.github.com/repos/vaadin/flow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vaadin/flow/issues/2719/comments","statuses_url":"https://api.github.com/repos/vaadin/flow/statuses/7e6a04d0538afefe68e942fa44df35f169236869","head":{"label":"heruan:2535-p-and-others","ref":"2535-p-and-others","sha":"7e6a04d0538afefe68e942fa44df35f169236869","user":{"login":"heruan","id":851745,"avatar_url":"https://avatars2.githubusercontent.com/u/851745?v=4","gravatar_id":"","url":"https://api.github.com/users/heruan","html_url":"https://github.com/heruan","followers_url":"https://api.github.com/users/heruan/followers","following_url":"https://api.github.com/users/heruan/following{/other_user}","gists_url":"https://api.github.com/users/heruan/gists{/gist_id}","starred_url":"https://api.github.com/users/heruan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heruan/subscriptions","organizations_url":"https://api.github.com/users/heruan/orgs","repos_url":"https://api.github.com/users/heruan/repos","events_url":"https://api.github.com/users/heruan/events{/privacy}","received_events_url":"https://api.github.com/users/heruan/received_events","type":"User","site_admin":false},"repo":{"id":106555407,"name":"flow","full_name":"heruan/flow","owner":{"login":"heruan","id":851745,"avatar_url":"https://avatars2.githubusercontent.com/u/851745?v=4","gravatar_id":"","url":"https://api.github.com/users/heruan","html_url":"https://github.com/heruan","followers_url":"https://api.github.com/users/heruan/followers","following_url":"https://api.github.com/users/heruan/following{/other_user}","gists_url":"https://api.github.com/users/heruan/gists{/gist_id}","starred_url":"https://api.github.com/users/heruan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heruan/subscriptions","organizations_url":"https://api.github.com/users/heruan/orgs","repos_url":"https://api.github.com/users/heruan/repos","events_url":"https://api.github.com/users/heruan/events{/privacy}","received_events_url":"https://api.github.com/users/heruan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heruan/flow","description":"Flow is a Java framework for building modern web sites that look great and perform well.","fork":true,"url":"https://api.github.com/repos/heruan/flow","forks_url":"https://api.github.com/repos/heruan/flow/forks","keys_url":"https://api.github.com/repos/heruan/flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heruan/flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heruan/flow/teams","hooks_url":"https://api.github.com/repos/heruan/flow/hooks","issue_events_url":"https://api.github.com/repos/heruan/flow/issues/events{/number}","events_url":"https://api.github.com/repos/heruan/flow/events","assignees_url":"https://api.github.com/repos/heruan/flow/assignees{/user}","branches_url":"https://api.github.com/repos/heruan/flow/branches{/branch}","tags_url":"https://api.github.com/repos/heruan/flow/tags","blobs_url":"https://api.github.com/repos/heruan/flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heruan/flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heruan/flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/heruan/flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heruan/flow/statuses/{sha}","languages_url":"https://api.github.com/repos/heruan/flow/languages","stargazers_url":"https://api.github.com/repos/heruan/flow/stargazers","contributors_url":"https://api.github.com/repos/heruan/flow/contributors","subscribers_url":"https://api.github.com/repos/heruan/flow/subscribers","subscription_url":"https://api.github.com/repos/heruan/flow/subscription","commits_url":"https://api.github.com/repos/heruan/flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/heruan/flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/heruan/flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/heruan/flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/heruan/flow/contents/{+path}","compare_url":"https://api.github.com/repos/heruan/flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heruan/flow/merges","archive_url":"https://api.github.com/repos/heruan/flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heruan/flow/downloads","issues_url":"https://api.github.com/repos/heruan/flow/issues{/number}","pulls_url":"https://api.github.com/repos/heruan/flow/pulls{/number}","milestones_url":"https://api.github.com/repos/heruan/flow/milestones{/number}","notifications_url":"https://api.github.com/repos/heruan/flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heruan/flow/labels{/name}","releases_url":"https://api.github.com/repos/heruan/flow/releases{/id}","deployments_url":"https://api.github.com/repos/heruan/flow/deployments","created_at":"2017-10-11T13:07:28Z","updated_at":"2017-10-11T13:07:36Z","pushed_at":"2017-10-19T07:54:09Z","git_url":"git://github.com/heruan/flow.git","ssh_url":"git@github.com:heruan/flow.git","clone_url":"https://github.com/heruan/flow.git","svn_url":"https://github.com/heruan/flow","homepage":"","size":91146,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vaadin:master","ref":"master","sha":"bb3f226578b4d46a795735acdd08c8a5eb2c44c1","user":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":34809191,"name":"flow","full_name":"vaadin/flow","owner":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/flow","description":"Flow is a Java framework for building modern web sites that look great and perform well.","fork":false,"url":"https://api.github.com/repos/vaadin/flow","forks_url":"https://api.github.com/repos/vaadin/flow/forks","keys_url":"https://api.github.com/repos/vaadin/flow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/flow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/flow/teams","hooks_url":"https://api.github.com/repos/vaadin/flow/hooks","issue_events_url":"https://api.github.com/repos/vaadin/flow/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/flow/events","assignees_url":"https://api.github.com/repos/vaadin/flow/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/flow/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/flow/tags","blobs_url":"https://api.github.com/repos/vaadin/flow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/flow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/flow/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/flow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/flow/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/flow/languages","stargazers_url":"https://api.github.com/repos/vaadin/flow/stargazers","contributors_url":"https://api.github.com/repos/vaadin/flow/contributors","subscribers_url":"https://api.github.com/repos/vaadin/flow/subscribers","subscription_url":"https://api.github.com/repos/vaadin/flow/subscription","commits_url":"https://api.github.com/repos/vaadin/flow/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/flow/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/flow/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/flow/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/flow/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/flow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/flow/merges","archive_url":"https://api.github.com/repos/vaadin/flow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/flow/downloads","issues_url":"https://api.github.com/repos/vaadin/flow/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/flow/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/flow/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/flow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/flow/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/flow/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/flow/deployments","created_at":"2015-04-29T17:54:35Z","updated_at":"2017-10-16T18:38:04Z","pushed_at":"2017-10-19T07:54:15Z","git_url":"git://github.com/vaadin/flow.git","ssh_url":"git@github.com:vaadin/flow.git","clone_url":"https://github.com/vaadin/flow.git","svn_url":"https://github.com/vaadin/flow","homepage":"","size":98466,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":392,"forks":2,"open_issues":392,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vaadin/flow/pulls/2719"},"html":{"href":"https://github.com/vaadin/flow/pull/2719"},"issue":{"href":"https://api.github.com/repos/vaadin/flow/issues/2719"},"comments":{"href":"https://api.github.com/repos/vaadin/flow/issues/2719/comments"},"review_comments":{"href":"https://api.github.com/repos/vaadin/flow/pulls/2719/comments"},"review_comment":{"href":"https://api.github.com/repos/vaadin/flow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vaadin/flow/pulls/2719/commits"},"statuses":{"href":"https://api.github.com/repos/vaadin/flow/statuses/7e6a04d0538afefe68e942fa44df35f169236869"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"vaadin-bot"}}