{"action":"created","issue":{"url":"https://api.github.com/repos/ftylitak/qzxing/issues/20","repository_url":"https://api.github.com/repos/ftylitak/qzxing","labels_url":"https://api.github.com/repos/ftylitak/qzxing/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/ftylitak/qzxing/issues/20/comments","events_url":"https://api.github.com/repos/ftylitak/qzxing/issues/20/events","html_url":"https://github.com/ftylitak/qzxing/pull/20","id":202441213,"number":20,"title":"QZXingFilter: More fixes to captureRect stuff","user":{"login":"nickdiego","id":1189757,"avatar_url":"https://avatars.githubusercontent.com/u/1189757?v=3","gravatar_id":"","url":"https://api.github.com/users/nickdiego","html_url":"https://github.com/nickdiego","followers_url":"https://api.github.com/users/nickdiego/followers","following_url":"https://api.github.com/users/nickdiego/following{/other_user}","gists_url":"https://api.github.com/users/nickdiego/gists{/gist_id}","starred_url":"https://api.github.com/users/nickdiego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickdiego/subscriptions","organizations_url":"https://api.github.com/users/nickdiego/orgs","repos_url":"https://api.github.com/users/nickdiego/repos","events_url":"https://api.github.com/users/nickdiego/events{/privacy}","received_events_url":"https://api.github.com/users/nickdiego/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-01-23T03:56:45Z","updated_at":"2017-01-23T18:13:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ftylitak/qzxing/pulls/20","html_url":"https://github.com/ftylitak/qzxing/pull/20","diff_url":"https://github.com/ftylitak/qzxing/pull/20.diff","patch_url":"https://github.com/ftylitak/qzxing/pull/20.patch"},"body":"- x and y can be zero;\r\n- crop image, before sending to decoder, of if captureRect \"is valid\""},"comment":{"url":"https://api.github.com/repos/ftylitak/qzxing/issues/comments/274570212","html_url":"https://github.com/ftylitak/qzxing/pull/20#issuecomment-274570212","issue_url":"https://api.github.com/repos/ftylitak/qzxing/issues/20","id":274570212,"user":{"login":"ftylitak","id":550020,"avatar_url":"https://avatars.githubusercontent.com/u/550020?v=3","gravatar_id":"","url":"https://api.github.com/users/ftylitak","html_url":"https://github.com/ftylitak","followers_url":"https://api.github.com/users/ftylitak/followers","following_url":"https://api.github.com/users/ftylitak/following{/other_user}","gists_url":"https://api.github.com/users/ftylitak/gists{/gist_id}","starred_url":"https://api.github.com/users/ftylitak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ftylitak/subscriptions","organizations_url":"https://api.github.com/users/ftylitak/orgs","repos_url":"https://api.github.com/users/ftylitak/repos","events_url":"https://api.github.com/users/ftylitak/events{/privacy}","received_events_url":"https://api.github.com/users/ftylitak/received_events","type":"User","site_admin":false},"created_at":"2017-01-23T18:13:59Z","updated_at":"2017-01-23T18:13:59Z","body":"Hello @nickdiego \r\n\r\nmay i ask, in which case would the x or y be zero? And in these cases, why should we consider it a valid rectangle when by definition of the rectangle it is not a rectangle? \r\n\r\nAlso according to the documentation of QRect.isEmpty, \"isEmpty() == !isValid\". "}}
{"actor":{"display_login":"ftylitak"}}