{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/150870124","pull_request_review_id":76484602,"id":150870124,"diff_hunk":"@@ -287,3 +458,56 @@ func getVolumeSource(spec *volume.Spec) (*v1.ISCSIVolumeSource, bool, error) {\n \n \treturn nil, false, fmt.Errorf(\"Spec does not reference an ISCSI volume type\")\n }\n+\n+func createVolumeFromiISCSIVolumeSource(volumeName string, iscsi v1.ISCSIVolumeSource) *v1.Volume {","path":"pkg/volume/iscsi/iscsi.go","position":247,"original_position":247,"commit_id":"f0871e7bb407bad63bfb4447ff0916988595c708","original_commit_id":"f0871e7bb407bad63bfb4447ff0916988595c708","user":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars0.githubusercontent.com/u/7062400?v=4","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"body":"extra `i`","created_at":"2017-11-14T15:40:20Z","updated_at":"2017-11-14T15:40:20Z","html_url":"https://github.com/kubernetes/kubernetes/pull/54752#discussion_r150870124","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54752","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/150870124"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/54752#discussion_r150870124"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54752"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54752","id":149352121,"html_url":"https://github.com/kubernetes/kubernetes/pull/54752","diff_url":"https://github.com/kubernetes/kubernetes/pull/54752.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/54752.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54752","number":54752,"state":"open","locked":false,"title":"Block volumes Support: iSCSI plugin update","user":{"login":"mtanino","id":19844283,"avatar_url":"https://avatars0.githubusercontent.com/u/19844283?v=4","gravatar_id":"","url":"https://api.github.com/users/mtanino","html_url":"https://github.com/mtanino","followers_url":"https://api.github.com/users/mtanino/followers","following_url":"https://api.github.com/users/mtanino/following{/other_user}","gists_url":"https://api.github.com/users/mtanino/gists{/gist_id}","starred_url":"https://api.github.com/users/mtanino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtanino/subscriptions","organizations_url":"https://api.github.com/users/mtanino/orgs","repos_url":"https://api.github.com/users/mtanino/repos","events_url":"https://api.github.com/users/mtanino/events{/privacy}","received_events_url":"https://api.github.com/users/mtanino/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n\r\nAdd interface changes to iSCSI volume plugin to enable block volumes support feature.\r\n\r\n**Which issue this PR fixes**: \r\nBased on this proposal (kubernetes/community#805 & kubernetes/community#1265) and this feature issue: kubernetes/features#351\r\n\r\n**Special notes for your reviewer**:\r\n\r\nThis PR temporarily includes following changes except iSCSI plugin change for reviewing purpose.\r\nThese changes will be removed from the PR once they are merged.\r\n- (#50457) API Change \r\n- (#51494) Container runtime interface change, volumemanager changes, operationexecutor changes\r\n\r\nThere are another PRs related to this functionality.\r\n(#50457) API Change\r\n(#53385) VolumeMode PV-PVC Binding change\r\n(#51494) Container runtime interface change, volumemanager changes, operationexecutor changes\r\n(#55112) Block volume: Command line printer update\r\nPlugins\r\n(#51493) Block volumes Support: FC plugin update\r\n(#54752) Block volumes Support: iSCSI plugin update\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```\r\nNONE\r\n```","created_at":"2017-10-28T19:50:31Z","updated_at":"2017-11-14T15:40:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8b30932a85480b345e52494c026f54038a8956f","assignee":{"login":"rootfs","id":7062400,"avatar_url":"https://avatars0.githubusercontent.com/u/7062400?v=4","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},"assignees":[{"login":"rootfs","id":7062400,"avatar_url":"https://avatars0.githubusercontent.com/u/7062400?v=4","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},{"login":"erictune","id":8105590,"avatar_url":"https://avatars3.githubusercontent.com/u/8105590?v=4","gravatar_id":"","url":"https://api.github.com/users/erictune","html_url":"https://github.com/erictune","followers_url":"https://api.github.com/users/erictune/followers","following_url":"https://api.github.com/users/erictune/following{/other_user}","gists_url":"https://api.github.com/users/erictune/gists{/gist_id}","starred_url":"https://api.github.com/users/erictune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erictune/subscriptions","organizations_url":"https://api.github.com/users/erictune/orgs","repos_url":"https://api.github.com/users/erictune/repos","events_url":"https://api.github.com/users/erictune/events{/privacy}","received_events_url":"https://api.github.com/users/erictune/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54752/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54752/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54752/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f0871e7bb407bad63bfb4447ff0916988595c708","head":{"label":"mtanino:pr/BlockVolumesSupport-iscsi","ref":"pr/BlockVolumesSupport-iscsi","sha":"f0871e7bb407bad63bfb4447ff0916988595c708","user":{"login":"mtanino","id":19844283,"avatar_url":"https://avatars0.githubusercontent.com/u/19844283?v=4","gravatar_id":"","url":"https://api.github.com/users/mtanino","html_url":"https://github.com/mtanino","followers_url":"https://api.github.com/users/mtanino/followers","following_url":"https://api.github.com/users/mtanino/following{/other_user}","gists_url":"https://api.github.com/users/mtanino/gists{/gist_id}","starred_url":"https://api.github.com/users/mtanino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtanino/subscriptions","organizations_url":"https://api.github.com/users/mtanino/orgs","repos_url":"https://api.github.com/users/mtanino/repos","events_url":"https://api.github.com/users/mtanino/events{/privacy}","received_events_url":"https://api.github.com/users/mtanino/received_events","type":"User","site_admin":false},"repo":{"id":82726371,"name":"kubernetes","full_name":"mtanino/kubernetes","owner":{"login":"mtanino","id":19844283,"avatar_url":"https://avatars0.githubusercontent.com/u/19844283?v=4","gravatar_id":"","url":"https://api.github.com/users/mtanino","html_url":"https://github.com/mtanino","followers_url":"https://api.github.com/users/mtanino/followers","following_url":"https://api.github.com/users/mtanino/following{/other_user}","gists_url":"https://api.github.com/users/mtanino/gists{/gist_id}","starred_url":"https://api.github.com/users/mtanino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtanino/subscriptions","organizations_url":"https://api.github.com/users/mtanino/orgs","repos_url":"https://api.github.com/users/mtanino/repos","events_url":"https://api.github.com/users/mtanino/events{/privacy}","received_events_url":"https://api.github.com/users/mtanino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtanino/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/mtanino/kubernetes","forks_url":"https://api.github.com/repos/mtanino/kubernetes/forks","keys_url":"https://api.github.com/repos/mtanino/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtanino/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtanino/kubernetes/teams","hooks_url":"https://api.github.com/repos/mtanino/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mtanino/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mtanino/kubernetes/events","assignees_url":"https://api.github.com/repos/mtanino/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mtanino/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mtanino/kubernetes/tags","blobs_url":"https://api.github.com/repos/mtanino/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtanino/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtanino/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtanino/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtanino/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mtanino/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mtanino/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mtanino/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mtanino/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mtanino/kubernetes/subscription","commits_url":"https://api.github.com/repos/mtanino/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtanino/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtanino/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtanino/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtanino/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mtanino/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtanino/kubernetes/merges","archive_url":"https://api.github.com/repos/mtanino/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtanino/kubernetes/downloads","issues_url":"https://api.github.com/repos/mtanino/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mtanino/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mtanino/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mtanino/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtanino/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mtanino/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/mtanino/kubernetes/deployments","created_at":"2017-02-21T20:57:08Z","updated_at":"2017-02-21T20:57:38Z","pushed_at":"2017-11-14T05:44:26Z","git_url":"git://github.com/mtanino/kubernetes.git","ssh_url":"git@github.com:mtanino/kubernetes.git","clone_url":"https://github.com/mtanino/kubernetes.git","svn_url":"https://github.com/mtanino/kubernetes","homepage":"http://kubernetes.io","size":523008,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"338ee7f5d56eb506082b7683566440ec1b271f8c","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-11-14T15:37:25Z","pushed_at":"2017-11-14T15:32:51Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":736641,"stargazers_count":28872,"watchers_count":28872,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10324,"mirror_url":null,"archived":false,"open_issues_count":5548,"forks":10324,"open_issues":5548,"watchers":28872,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54752"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/54752"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/54752"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/54752/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54752/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54752/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/f0871e7bb407bad63bfb4447ff0916988595c708"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rootfs"}}