{"action":"created","issue":{"url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/72","repository_url":"https://api.github.com/repos/Travix-International/travix-ui-kit","labels_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/72/comments","events_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/72/events","html_url":"https://github.com/Travix-International/travix-ui-kit/issues/72","id":225686689,"number":72,"title":"Rendering button","user":{"login":"ibsukru","id":1394705,"avatar_url":"https://avatars0.githubusercontent.com/u/1394705?v=3","gravatar_id":"","url":"https://api.github.com/users/ibsukru","html_url":"https://github.com/ibsukru","followers_url":"https://api.github.com/users/ibsukru/followers","following_url":"https://api.github.com/users/ibsukru/following{/other_user}","gists_url":"https://api.github.com/users/ibsukru/gists{/gist_id}","starred_url":"https://api.github.com/users/ibsukru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibsukru/subscriptions","organizations_url":"https://api.github.com/users/ibsukru/orgs","repos_url":"https://api.github.com/users/ibsukru/repos","events_url":"https://api.github.com/users/ibsukru/events{/privacy}","received_events_url":"https://api.github.com/users/ibsukru/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-05-02T12:56:55Z","updated_at":"2017-05-05T08:14:16Z","closed_at":null,"body":"Button component is not rendering until i add onClick event\r\nI saw this is by purpose on code but it is very much optioned"},"comment":{"url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/comments/299407655","html_url":"https://github.com/Travix-International/travix-ui-kit/issues/72#issuecomment-299407655","issue_url":"https://api.github.com/repos/Travix-International/travix-ui-kit/issues/72","id":299407655,"user":{"login":"fahad19","id":20046,"avatar_url":"https://avatars1.githubusercontent.com/u/20046?v=3","gravatar_id":"","url":"https://api.github.com/users/fahad19","html_url":"https://github.com/fahad19","followers_url":"https://api.github.com/users/fahad19/followers","following_url":"https://api.github.com/users/fahad19/following{/other_user}","gists_url":"https://api.github.com/users/fahad19/gists{/gist_id}","starred_url":"https://api.github.com/users/fahad19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fahad19/subscriptions","organizations_url":"https://api.github.com/users/fahad19/orgs","repos_url":"https://api.github.com/users/fahad19/repos","events_url":"https://api.github.com/users/fahad19/events{/privacy}","received_events_url":"https://api.github.com/users/fahad19/received_events","type":"User","site_admin":false},"created_at":"2017-05-05T08:14:16Z","updated_at":"2017-05-05T08:14:16Z","body":"Like I said before:\r\n\r\n> `<Button>` should render with or without any `onClick` event handler. It's primary responsibility is to render a button, even if a plain one.\r\n\r\nBetter stay close to the HTML element that you are trying to wrap with this Component.\r\n\r\n* Extending the behavior of `<button>` HTML element: 👍 \r\n* Limiting the usage of regular `<button>`: 👎 \r\n\r\n---\r\n\r\none other thing I noticed, why does one returned `<button>` has `...restProps`, and the other doesn't? \r\n\r\nhttps://github.com/Travix-International/travix-ui-kit/blob/92edfa8d6d9be2e0d3f3ab190456c9fe44a86e52/components/button/button.js#L36-L46"}}
{"actor":{"display_login":"fahad19"}}