{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/95007604","pull_request_review_id":15553595,"id":95007604,"diff_hunk":"@@ -20,6 +25,8 @@ OS_BUILD_PLATFORMS=(\"${platforms[@]}\")\n host_platform=$(os::build::host_platform)\n if [[ $host_platform == \"linux/ppc64le\" ]]; then\n   OS_GOFLAGS_LINUX_PPC64LE=\"-tags=gssapi\" os::build::build_binaries \"${OS_CROSS_COMPILE_TARGETS[@]}\"\n+elif [[ $host_platform == \"linux/arm64\" ]]; then","path":"hack/build-cross.sh","position":16,"original_position":16,"commit_id":"a12e23c33f98f13d646210380797c80905fe5d7f","original_commit_id":"a12e23c33f98f13d646210380797c80905fe5d7f","user":{"login":"tdawson","id":1068301,"avatar_url":"https://avatars.githubusercontent.com/u/1068301?v=3","gravatar_id":"","url":"https://api.github.com/users/tdawson","html_url":"https://github.com/tdawson","followers_url":"https://api.github.com/users/tdawson/followers","following_url":"https://api.github.com/users/tdawson/following{/other_user}","gists_url":"https://api.github.com/users/tdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/tdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdawson/subscriptions","organizations_url":"https://api.github.com/users/tdawson/orgs","repos_url":"https://api.github.com/users/tdawson/repos","events_url":"https://api.github.com/users/tdawson/events{/privacy}","received_events_url":"https://api.github.com/users/tdawson/received_events","type":"User","site_admin":false},"body":"Sorry for the delay, but my aarch64 testing area is having issues. \r\nOn x86_64 this works if you get rid of the 'local platform_goflags_envvar;'  So it looks like this.\r\n\r\n```\r\nplatform_goflags_envvar=\"OS_GOFLAGS_$(echo ${platform} | tr '[:lower:]/' '[:upper:]_')\"\r\ndeclare \"${platform_goflags_envvar}=-tags=gssapi\"\r\nos::build::build_binaries \"${OS_CROSS_COMPILE_TARGETS[@]}\"\r\n```\r\nIf it passes the aarch64 test, I'll update this pull request with it in.","created_at":"2017-01-06T19:46:15Z","updated_at":"2017-01-06T19:46:15Z","html_url":"https://github.com/openshift/origin/pull/12333#discussion_r95007604","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/12333","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/95007604"},"html":{"href":"https://github.com/openshift/origin/pull/12333#discussion_r95007604"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/12333"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/12333","id":99185629,"html_url":"https://github.com/openshift/origin/pull/12333","diff_url":"https://github.com/openshift/origin/pull/12333.diff","patch_url":"https://github.com/openshift/origin/pull/12333.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/12333","number":12333,"state":"open","locked":false,"title":"Non redistributable does not build everything, plus aarch64","user":{"login":"tdawson","id":1068301,"avatar_url":"https://avatars.githubusercontent.com/u/1068301?v=3","gravatar_id":"","url":"https://api.github.com/users/tdawson","html_url":"https://github.com/tdawson","followers_url":"https://api.github.com/users/tdawson/followers","following_url":"https://api.github.com/users/tdawson/following{/other_user}","gists_url":"https://api.github.com/users/tdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/tdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdawson/subscriptions","organizations_url":"https://api.github.com/users/tdawson/orgs","repos_url":"https://api.github.com/users/tdawson/repos","events_url":"https://api.github.com/users/tdawson/events{/privacy}","received_events_url":"https://api.github.com/users/tdawson/received_events","type":"User","site_admin":false},"body":"If you set the non-redistributable bit to 0, it will not build everything.\r\nThis not only saves time, but helps for multi-arches that might not be able to do cross compiling.\r\nThis also allows origin rpms to be built on aarch64","created_at":"2016-12-22T23:29:16Z","updated_at":"2017-01-06T19:46:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4541d4a159e6e2662399a9541c68f5a85a0bb538","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/12333/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/12333/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/12333/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/a12e23c33f98f13d646210380797c80905fe5d7f","head":{"label":"tdawson:2016-12-multi-arch-non-redistribute","ref":"2016-12-multi-arch-non-redistribute","sha":"a12e23c33f98f13d646210380797c80905fe5d7f","user":{"login":"tdawson","id":1068301,"avatar_url":"https://avatars.githubusercontent.com/u/1068301?v=3","gravatar_id":"","url":"https://api.github.com/users/tdawson","html_url":"https://github.com/tdawson","followers_url":"https://api.github.com/users/tdawson/followers","following_url":"https://api.github.com/users/tdawson/following{/other_user}","gists_url":"https://api.github.com/users/tdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/tdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdawson/subscriptions","organizations_url":"https://api.github.com/users/tdawson/orgs","repos_url":"https://api.github.com/users/tdawson/repos","events_url":"https://api.github.com/users/tdawson/events{/privacy}","received_events_url":"https://api.github.com/users/tdawson/received_events","type":"User","site_admin":false},"repo":{"id":31215679,"name":"origin","full_name":"tdawson/origin","owner":{"login":"tdawson","id":1068301,"avatar_url":"https://avatars.githubusercontent.com/u/1068301?v=3","gravatar_id":"","url":"https://api.github.com/users/tdawson","html_url":"https://github.com/tdawson","followers_url":"https://api.github.com/users/tdawson/followers","following_url":"https://api.github.com/users/tdawson/following{/other_user}","gists_url":"https://api.github.com/users/tdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/tdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdawson/subscriptions","organizations_url":"https://api.github.com/users/tdawson/orgs","repos_url":"https://api.github.com/users/tdawson/repos","events_url":"https://api.github.com/users/tdawson/events{/privacy}","received_events_url":"https://api.github.com/users/tdawson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tdawson/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/tdawson/origin","forks_url":"https://api.github.com/repos/tdawson/origin/forks","keys_url":"https://api.github.com/repos/tdawson/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tdawson/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tdawson/origin/teams","hooks_url":"https://api.github.com/repos/tdawson/origin/hooks","issue_events_url":"https://api.github.com/repos/tdawson/origin/issues/events{/number}","events_url":"https://api.github.com/repos/tdawson/origin/events","assignees_url":"https://api.github.com/repos/tdawson/origin/assignees{/user}","branches_url":"https://api.github.com/repos/tdawson/origin/branches{/branch}","tags_url":"https://api.github.com/repos/tdawson/origin/tags","blobs_url":"https://api.github.com/repos/tdawson/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tdawson/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tdawson/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/tdawson/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tdawson/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/tdawson/origin/languages","stargazers_url":"https://api.github.com/repos/tdawson/origin/stargazers","contributors_url":"https://api.github.com/repos/tdawson/origin/contributors","subscribers_url":"https://api.github.com/repos/tdawson/origin/subscribers","subscription_url":"https://api.github.com/repos/tdawson/origin/subscription","commits_url":"https://api.github.com/repos/tdawson/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/tdawson/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/tdawson/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/tdawson/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/tdawson/origin/contents/{+path}","compare_url":"https://api.github.com/repos/tdawson/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tdawson/origin/merges","archive_url":"https://api.github.com/repos/tdawson/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tdawson/origin/downloads","issues_url":"https://api.github.com/repos/tdawson/origin/issues{/number}","pulls_url":"https://api.github.com/repos/tdawson/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/tdawson/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/tdawson/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tdawson/origin/labels{/name}","releases_url":"https://api.github.com/repos/tdawson/origin/releases{/id}","deployments_url":"https://api.github.com/repos/tdawson/origin/deployments","created_at":"2015-02-23T16:02:17Z","updated_at":"2016-10-24T21:50:44Z","pushed_at":"2016-12-23T14:31:26Z","git_url":"git://github.com/tdawson/origin.git","ssh_url":"git@github.com:tdawson/origin.git","clone_url":"https://github.com/tdawson/origin.git","svn_url":"https://github.com/tdawson/origin","homepage":"https://openshift.github.io","size":447814,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"bea25bc2085fa7303f76bf07bb1fa26a336f80e2","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"Enterprise Kubernetes for Developers","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin/deployments","created_at":"2014-07-30T20:04:05Z","updated_at":"2017-01-06T18:32:44Z","pushed_at":"2017-01-06T19:44:23Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":457561,"stargazers_count":2217,"watchers_count":2217,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1482,"mirror_url":null,"open_issues_count":1166,"forks":1482,"open_issues":1166,"watchers":2217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/12333"},"html":{"href":"https://github.com/openshift/origin/pull/12333"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/12333"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/12333/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/12333/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/12333/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/a12e23c33f98f13d646210380797c80905fe5d7f"}}}}
{"actor":{"display_login":"tdawson"}}