{"action":"created","comment":{"url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/pulls/comments/98187880","pull_request_review_id":18822673,"id":98187880,"diff_hunk":"@@ -2,14 +2,14 @@\n     function ($q, $http, umbRequestHelper) {\n         return {\n             getContentTypeAliasByGuid: function (guid) {\n-                var url = \"/umbraco/backoffice/DocTypeGridEditorApi/DocTypeGridEditorApi/GetContentTypeAliasByGuid?guid=\" + guid;\n+            \tvar url = umbRequestHelper.convertVirtualToAbsolutePath(\"~/umbraco/backoffice/DocTypeGridEditorApi/DocTypeGridEditorApi/GetContentTypeAliasByGuid?guid=\" + guid);","path":"src/Our.Umbraco.DocTypeGridEditor/Web/UI/App_Plugins/DocTypeGridEditor/Js/doctypegrideditor.resources.js","position":5,"original_position":5,"commit_id":"88ff7fefbaff65aeb8550e543cd56ea3168550fa","original_commit_id":"88ff7fefbaff65aeb8550e543cd56ea3168550fa","user":{"login":"leekelleher","id":209066,"avatar_url":"https://avatars.githubusercontent.com/u/209066?v=3","gravatar_id":"","url":"https://api.github.com/users/leekelleher","html_url":"https://github.com/leekelleher","followers_url":"https://api.github.com/users/leekelleher/followers","following_url":"https://api.github.com/users/leekelleher/following{/other_user}","gists_url":"https://api.github.com/users/leekelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/leekelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leekelleher/subscriptions","organizations_url":"https://api.github.com/users/leekelleher/orgs","repos_url":"https://api.github.com/users/leekelleher/repos","events_url":"https://api.github.com/users/leekelleher/events{/privacy}","received_events_url":"https://api.github.com/users/leekelleher/received_events","type":"User","site_admin":false},"body":"@0Neji Sorry to sound picky, any chance you can correct the whitespacing - tab to spaces? Thanks.","created_at":"2017-01-27T11:46:16Z","updated_at":"2017-01-27T11:46:16Z","html_url":"https://github.com/umco/umbraco-doc-type-grid-editor/pull/63#discussion_r98187880","pull_request_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/pulls/comments/98187880"},"html":{"href":"https://github.com/umco/umbraco-doc-type-grid-editor/pull/63#discussion_r98187880"},"pull_request":{"href":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/pulls/63","id":103477678,"html_url":"https://github.com/umco/umbraco-doc-type-grid-editor/pull/63","diff_url":"https://github.com/umco/umbraco-doc-type-grid-editor/pull/63.diff","patch_url":"https://github.com/umco/umbraco-doc-type-grid-editor/pull/63.patch","issue_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/issues/63","number":63,"state":"open","locked":false,"title":"Fix urls by converting virtual paths to absolute","user":{"login":"0Neji","id":4700480,"avatar_url":"https://avatars.githubusercontent.com/u/4700480?v=3","gravatar_id":"","url":"https://api.github.com/users/0Neji","html_url":"https://github.com/0Neji","followers_url":"https://api.github.com/users/0Neji/followers","following_url":"https://api.github.com/users/0Neji/following{/other_user}","gists_url":"https://api.github.com/users/0Neji/gists{/gist_id}","starred_url":"https://api.github.com/users/0Neji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0Neji/subscriptions","organizations_url":"https://api.github.com/users/0Neji/orgs","repos_url":"https://api.github.com/users/0Neji/repos","events_url":"https://api.github.com/users/0Neji/events{/privacy}","received_events_url":"https://api.github.com/users/0Neji/received_events","type":"User","site_admin":false},"body":"I ran into a problem using Doc Type Grid Editor in a child application - currently the paths simply point to the root of the site/application. This should fix that by using `umbRequestHelper.convertVirtualToAbsolutePath` to specify a virtual path and have it converted to the correct absolute path that umbraco is actually using.","created_at":"2017-01-27T11:39:56Z","updated_at":"2017-01-27T11:46:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa92117dfd53c0a5d8672783a0c5616717ae61c6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/pulls/63/commits","review_comments_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/pulls/63/comments","review_comment_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/issues/63/comments","statuses_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/statuses/88ff7fefbaff65aeb8550e543cd56ea3168550fa","head":{"label":"0Neji:child-application-fixes","ref":"child-application-fixes","sha":"88ff7fefbaff65aeb8550e543cd56ea3168550fa","user":{"login":"0Neji","id":4700480,"avatar_url":"https://avatars.githubusercontent.com/u/4700480?v=3","gravatar_id":"","url":"https://api.github.com/users/0Neji","html_url":"https://github.com/0Neji","followers_url":"https://api.github.com/users/0Neji/followers","following_url":"https://api.github.com/users/0Neji/following{/other_user}","gists_url":"https://api.github.com/users/0Neji/gists{/gist_id}","starred_url":"https://api.github.com/users/0Neji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0Neji/subscriptions","organizations_url":"https://api.github.com/users/0Neji/orgs","repos_url":"https://api.github.com/users/0Neji/repos","events_url":"https://api.github.com/users/0Neji/events{/privacy}","received_events_url":"https://api.github.com/users/0Neji/received_events","type":"User","site_admin":false},"repo":{"id":80201418,"name":"umbraco-doc-type-grid-editor","full_name":"0Neji/umbraco-doc-type-grid-editor","owner":{"login":"0Neji","id":4700480,"avatar_url":"https://avatars.githubusercontent.com/u/4700480?v=3","gravatar_id":"","url":"https://api.github.com/users/0Neji","html_url":"https://github.com/0Neji","followers_url":"https://api.github.com/users/0Neji/followers","following_url":"https://api.github.com/users/0Neji/following{/other_user}","gists_url":"https://api.github.com/users/0Neji/gists{/gist_id}","starred_url":"https://api.github.com/users/0Neji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0Neji/subscriptions","organizations_url":"https://api.github.com/users/0Neji/orgs","repos_url":"https://api.github.com/users/0Neji/repos","events_url":"https://api.github.com/users/0Neji/events{/privacy}","received_events_url":"https://api.github.com/users/0Neji/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/0Neji/umbraco-doc-type-grid-editor","description":"Doc Type Grid Editor for Umbraco 7.2+","fork":true,"url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor","forks_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/forks","keys_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/teams","hooks_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/hooks","issue_events_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/issues/events{/number}","events_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/events","assignees_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/assignees{/user}","branches_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/branches{/branch}","tags_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/tags","blobs_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/languages","stargazers_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/stargazers","contributors_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/contributors","subscribers_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/subscribers","subscription_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/subscription","commits_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/contents/{+path}","compare_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/merges","archive_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/downloads","issues_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/issues{/number}","pulls_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/labels{/name}","releases_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/releases{/id}","deployments_url":"https://api.github.com/repos/0Neji/umbraco-doc-type-grid-editor/deployments","created_at":"2017-01-27T11:13:47Z","updated_at":"2017-01-27T11:13:50Z","pushed_at":"2017-01-27T11:35:07Z","git_url":"git://github.com/0Neji/umbraco-doc-type-grid-editor.git","ssh_url":"git@github.com:0Neji/umbraco-doc-type-grid-editor.git","clone_url":"https://github.com/0Neji/umbraco-doc-type-grid-editor.git","svn_url":"https://github.com/0Neji/umbraco-doc-type-grid-editor","homepage":"http://our.umbraco.org/projects/backoffice-extensions/doc-type-grid-editor","size":20882,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"umco:develop","ref":"develop","sha":"5b3f31c0591d10187b6700ecfa71ab521c95227e","user":{"login":"umco","id":19313569,"avatar_url":"https://avatars.githubusercontent.com/u/19313569?v=3","gravatar_id":"","url":"https://api.github.com/users/umco","html_url":"https://github.com/umco","followers_url":"https://api.github.com/users/umco/followers","following_url":"https://api.github.com/users/umco/following{/other_user}","gists_url":"https://api.github.com/users/umco/gists{/gist_id}","starred_url":"https://api.github.com/users/umco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umco/subscriptions","organizations_url":"https://api.github.com/users/umco/orgs","repos_url":"https://api.github.com/users/umco/repos","events_url":"https://api.github.com/users/umco/events{/privacy}","received_events_url":"https://api.github.com/users/umco/received_events","type":"Organization","site_admin":false},"repo":{"id":31364788,"name":"umbraco-doc-type-grid-editor","full_name":"umco/umbraco-doc-type-grid-editor","owner":{"login":"umco","id":19313569,"avatar_url":"https://avatars.githubusercontent.com/u/19313569?v=3","gravatar_id":"","url":"https://api.github.com/users/umco","html_url":"https://github.com/umco","followers_url":"https://api.github.com/users/umco/followers","following_url":"https://api.github.com/users/umco/following{/other_user}","gists_url":"https://api.github.com/users/umco/gists{/gist_id}","starred_url":"https://api.github.com/users/umco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/umco/subscriptions","organizations_url":"https://api.github.com/users/umco/orgs","repos_url":"https://api.github.com/users/umco/repos","events_url":"https://api.github.com/users/umco/events{/privacy}","received_events_url":"https://api.github.com/users/umco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/umco/umbraco-doc-type-grid-editor","description":"Doc Type Grid Editor for Umbraco 7.2+","fork":false,"url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor","forks_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/forks","keys_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/teams","hooks_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/hooks","issue_events_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/issues/events{/number}","events_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/events","assignees_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/assignees{/user}","branches_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/branches{/branch}","tags_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/tags","blobs_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/languages","stargazers_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/stargazers","contributors_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/contributors","subscribers_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/subscribers","subscription_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/subscription","commits_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/contents/{+path}","compare_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/merges","archive_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/downloads","issues_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/issues{/number}","pulls_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/labels{/name}","releases_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/releases{/id}","deployments_url":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/deployments","created_at":"2015-02-26T11:53:29Z","updated_at":"2017-01-18T15:55:33Z","pushed_at":"2017-01-27T11:39:57Z","git_url":"git://github.com/umco/umbraco-doc-type-grid-editor.git","ssh_url":"git@github.com:umco/umbraco-doc-type-grid-editor.git","clone_url":"https://github.com/umco/umbraco-doc-type-grid-editor.git","svn_url":"https://github.com/umco/umbraco-doc-type-grid-editor","homepage":"http://our.umbraco.org/projects/backoffice-extensions/doc-type-grid-editor","size":20882,"stargazers_count":17,"watchers_count":17,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":11,"forks":19,"open_issues":11,"watchers":17,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/pulls/63"},"html":{"href":"https://github.com/umco/umbraco-doc-type-grid-editor/pull/63"},"issue":{"href":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/issues/63"},"comments":{"href":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/umco/umbraco-doc-type-grid-editor/statuses/88ff7fefbaff65aeb8550e543cd56ea3168550fa"}}}}
{"actor":{"display_login":"leekelleher"}}