{"action":"created","comment":{"url":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls/comments/102351882","pull_request_review_id":23105652,"id":102351882,"diff_hunk":"@@ -0,0 +1,167 @@\n+import {IBMP180Device, IBMP180Options, IBMP180Info} from './bmp180.interfaces'\n+import {DRIVER, MODELS, TYPE, SUBSCRIBE_TOPICS} from './bmp180.constants'\n+\n+import {printTopicTitle} from '../../../../../helpers/screen.methods'\n+\n+import Talkative from '../../../../../talkative'\n+\n+import {EventEmitter2} from 'eventemitter2'\n+\n+\n+const bmp180 = require('./lib')\n+\n+export default class BMP180 extends EventEmitter2 implements IBMP180Device {\n+  private id: string\n+  private model: string\n+  private type: string\n+  private active: boolean\n+  private ready: boolean\n+  private BMP: any\n+  private address: number\n+\n+  // REVIEW: should this class contains calibration fields???\n+\n+  private temperatureCalibration: number = 0\n+\n+  constructor (options: IBMP180Options, talkative: Talkative) {\n+    super()\n+\n+    this.id = options.id\n+    this.model = options.model || MODELS.GET_DEFAULT()\n+    this.address = options.address\n+    this.active = options.active\n+    this.type = TYPE\n+    this.BMP = new bmp180({address: this.address})\n+\n+    this.BMP.init((err, val) => {","path":"src/app/engines/devices-engine/devices/hybrid/bmp180/bmp180.class.ts","position":36,"original_position":36,"commit_id":"4abdc133818df903330d20d9fb8426705e6437b2","original_commit_id":"4abdc133818df903330d20d9fb8426705e6437b2","user":{"login":"cagodoy","id":8485620,"avatar_url":"https://avatars.githubusercontent.com/u/8485620?v=3","gravatar_id":"","url":"https://api.github.com/users/cagodoy","html_url":"https://github.com/cagodoy","followers_url":"https://api.github.com/users/cagodoy/followers","following_url":"https://api.github.com/users/cagodoy/following{/other_user}","gists_url":"https://api.github.com/users/cagodoy/gists{/gist_id}","starred_url":"https://api.github.com/users/cagodoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cagodoy/subscriptions","organizations_url":"https://api.github.com/users/cagodoy/orgs","repos_url":"https://api.github.com/users/cagodoy/repos","events_url":"https://api.github.com/users/cagodoy/events{/privacy}","received_events_url":"https://api.github.com/users/cagodoy/received_events","type":"User","site_admin":false},"body":".\r\n","created_at":"2017-02-22T00:02:30Z","updated_at":"2017-02-22T00:02:34Z","html_url":"https://github.com/wisegrowth/wisebot-core/pull/10#discussion_r102351882","pull_request_url":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls/comments/102351882"},"html":{"href":"https://github.com/wisegrowth/wisebot-core/pull/10#discussion_r102351882"},"pull_request":{"href":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls/10","id":107302649,"html_url":"https://github.com/wisegrowth/wisebot-core/pull/10","diff_url":"https://github.com/wisegrowth/wisebot-core/pull/10.diff","patch_url":"https://github.com/wisegrowth/wisebot-core/pull/10.patch","issue_url":"https://api.github.com/repos/wisegrowth/wisebot-core/issues/10","number":10,"state":"open","locked":false,"title":"Mt feature/implements bmp180","user":{"login":"mtavano","id":8041435,"avatar_url":"https://avatars.githubusercontent.com/u/8041435?v=3","gravatar_id":"","url":"https://api.github.com/users/mtavano","html_url":"https://github.com/mtavano","followers_url":"https://api.github.com/users/mtavano/followers","following_url":"https://api.github.com/users/mtavano/following{/other_user}","gists_url":"https://api.github.com/users/mtavano/gists{/gist_id}","starred_url":"https://api.github.com/users/mtavano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtavano/subscriptions","organizations_url":"https://api.github.com/users/mtavano/orgs","repos_url":"https://api.github.com/users/mtavano/repos","events_url":"https://api.github.com/users/mtavano/events{/privacy}","received_events_url":"https://api.github.com/users/mtavano/received_events","type":"User","site_admin":false},"body":"On this OR I've implemented all the necessary stuffs to work in a near future with the BMP180 sensor. This means the following things\r\n\r\n* Barometer device interfaces\r\n* Altitude device interfaces\r\n\r\nAnd to complete all the features availables on BMP180 I've used the ITemperatureDevice interface.\r\n\r\n\r\nSo, how we can se, the BMP180 is an hybrid device that allows to handle three differents environments to measure and trigger actions on real time.\r\n\r\nIt is important to know that the altitude measurement is not given by the sensor, at least natively. On datasheet you can find the formula to determinate the altitude given by the current pressure and the atmosferic pressure at the sea level.\r\n\r\n\r\nLink: https://cdn-shop.adafruit.com/datasheets/BST-BMP180-DS000-09.pdf","created_at":"2017-02-21T23:28:15Z","updated_at":"2017-02-22T00:02:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20add4d11f1d74c65d59266dbbc3f3460218cbe0","assignee":{"login":"sebastianvera","id":1817522,"avatar_url":"https://avatars.githubusercontent.com/u/1817522?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianvera","html_url":"https://github.com/sebastianvera","followers_url":"https://api.github.com/users/sebastianvera/followers","following_url":"https://api.github.com/users/sebastianvera/following{/other_user}","gists_url":"https://api.github.com/users/sebastianvera/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianvera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianvera/subscriptions","organizations_url":"https://api.github.com/users/sebastianvera/orgs","repos_url":"https://api.github.com/users/sebastianvera/repos","events_url":"https://api.github.com/users/sebastianvera/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianvera/received_events","type":"User","site_admin":false},"assignees":[{"login":"sebastianvera","id":1817522,"avatar_url":"https://avatars.githubusercontent.com/u/1817522?v=3","gravatar_id":"","url":"https://api.github.com/users/sebastianvera","html_url":"https://github.com/sebastianvera","followers_url":"https://api.github.com/users/sebastianvera/followers","following_url":"https://api.github.com/users/sebastianvera/following{/other_user}","gists_url":"https://api.github.com/users/sebastianvera/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianvera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianvera/subscriptions","organizations_url":"https://api.github.com/users/sebastianvera/orgs","repos_url":"https://api.github.com/users/sebastianvera/repos","events_url":"https://api.github.com/users/sebastianvera/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianvera/received_events","type":"User","site_admin":false},{"login":"javierjah","id":7358220,"avatar_url":"https://avatars.githubusercontent.com/u/7358220?v=3","gravatar_id":"","url":"https://api.github.com/users/javierjah","html_url":"https://github.com/javierjah","followers_url":"https://api.github.com/users/javierjah/followers","following_url":"https://api.github.com/users/javierjah/following{/other_user}","gists_url":"https://api.github.com/users/javierjah/gists{/gist_id}","starred_url":"https://api.github.com/users/javierjah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierjah/subscriptions","organizations_url":"https://api.github.com/users/javierjah/orgs","repos_url":"https://api.github.com/users/javierjah/repos","events_url":"https://api.github.com/users/javierjah/events{/privacy}","received_events_url":"https://api.github.com/users/javierjah/received_events","type":"User","site_admin":false},{"login":"cagodoy","id":8485620,"avatar_url":"https://avatars.githubusercontent.com/u/8485620?v=3","gravatar_id":"","url":"https://api.github.com/users/cagodoy","html_url":"https://github.com/cagodoy","followers_url":"https://api.github.com/users/cagodoy/followers","following_url":"https://api.github.com/users/cagodoy/following{/other_user}","gists_url":"https://api.github.com/users/cagodoy/gists{/gist_id}","starred_url":"https://api.github.com/users/cagodoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cagodoy/subscriptions","organizations_url":"https://api.github.com/users/cagodoy/orgs","repos_url":"https://api.github.com/users/cagodoy/repos","events_url":"https://api.github.com/users/cagodoy/events{/privacy}","received_events_url":"https://api.github.com/users/cagodoy/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls/10/commits","review_comments_url":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls/10/comments","review_comment_url":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wisegrowth/wisebot-core/issues/10/comments","statuses_url":"https://api.github.com/repos/wisegrowth/wisebot-core/statuses/4abdc133818df903330d20d9fb8426705e6437b2","head":{"label":"wisegrowth:mt-feature/implements-bmp180","ref":"mt-feature/implements-bmp180","sha":"4abdc133818df903330d20d9fb8426705e6437b2","user":{"login":"wisegrowth","id":25491546,"avatar_url":"https://avatars.githubusercontent.com/u/25491546?v=3","gravatar_id":"","url":"https://api.github.com/users/wisegrowth","html_url":"https://github.com/wisegrowth","followers_url":"https://api.github.com/users/wisegrowth/followers","following_url":"https://api.github.com/users/wisegrowth/following{/other_user}","gists_url":"https://api.github.com/users/wisegrowth/gists{/gist_id}","starred_url":"https://api.github.com/users/wisegrowth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wisegrowth/subscriptions","organizations_url":"https://api.github.com/users/wisegrowth/orgs","repos_url":"https://api.github.com/users/wisegrowth/repos","events_url":"https://api.github.com/users/wisegrowth/events{/privacy}","received_events_url":"https://api.github.com/users/wisegrowth/received_events","type":"Organization","site_admin":false},"repo":{"id":60830616,"name":"wisebot-core","full_name":"wisegrowth/wisebot-core","owner":{"login":"wisegrowth","id":25491546,"avatar_url":"https://avatars.githubusercontent.com/u/25491546?v=3","gravatar_id":"","url":"https://api.github.com/users/wisegrowth","html_url":"https://github.com/wisegrowth","followers_url":"https://api.github.com/users/wisegrowth/followers","following_url":"https://api.github.com/users/wisegrowth/following{/other_user}","gists_url":"https://api.github.com/users/wisegrowth/gists{/gist_id}","starred_url":"https://api.github.com/users/wisegrowth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wisegrowth/subscriptions","organizations_url":"https://api.github.com/users/wisegrowth/orgs","repos_url":"https://api.github.com/users/wisegrowth/repos","events_url":"https://api.github.com/users/wisegrowth/events{/privacy}","received_events_url":"https://api.github.com/users/wisegrowth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wisegrowth/wisebot-core","description":"Is the core of an Wisebot iot device, which by means of sensors and actuators, allow to execute customized rules in function of schedulers or events.","fork":false,"url":"https://api.github.com/repos/wisegrowth/wisebot-core","forks_url":"https://api.github.com/repos/wisegrowth/wisebot-core/forks","keys_url":"https://api.github.com/repos/wisegrowth/wisebot-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wisegrowth/wisebot-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wisegrowth/wisebot-core/teams","hooks_url":"https://api.github.com/repos/wisegrowth/wisebot-core/hooks","issue_events_url":"https://api.github.com/repos/wisegrowth/wisebot-core/issues/events{/number}","events_url":"https://api.github.com/repos/wisegrowth/wisebot-core/events","assignees_url":"https://api.github.com/repos/wisegrowth/wisebot-core/assignees{/user}","branches_url":"https://api.github.com/repos/wisegrowth/wisebot-core/branches{/branch}","tags_url":"https://api.github.com/repos/wisegrowth/wisebot-core/tags","blobs_url":"https://api.github.com/repos/wisegrowth/wisebot-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wisegrowth/wisebot-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wisegrowth/wisebot-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wisegrowth/wisebot-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wisegrowth/wisebot-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wisegrowth/wisebot-core/languages","stargazers_url":"https://api.github.com/repos/wisegrowth/wisebot-core/stargazers","contributors_url":"https://api.github.com/repos/wisegrowth/wisebot-core/contributors","subscribers_url":"https://api.github.com/repos/wisegrowth/wisebot-core/subscribers","subscription_url":"https://api.github.com/repos/wisegrowth/wisebot-core/subscription","commits_url":"https://api.github.com/repos/wisegrowth/wisebot-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wisegrowth/wisebot-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wisegrowth/wisebot-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wisegrowth/wisebot-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wisegrowth/wisebot-core/contents/{+path}","compare_url":"https://api.github.com/repos/wisegrowth/wisebot-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wisegrowth/wisebot-core/merges","archive_url":"https://api.github.com/repos/wisegrowth/wisebot-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wisegrowth/wisebot-core/downloads","issues_url":"https://api.github.com/repos/wisegrowth/wisebot-core/issues{/number}","pulls_url":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wisegrowth/wisebot-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wisegrowth/wisebot-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wisegrowth/wisebot-core/labels{/name}","releases_url":"https://api.github.com/repos/wisegrowth/wisebot-core/releases{/id}","deployments_url":"https://api.github.com/repos/wisegrowth/wisebot-core/deployments","created_at":"2016-06-10T07:20:52Z","updated_at":"2017-02-17T20:17:59Z","pushed_at":"2017-02-21T23:28:15Z","git_url":"git://github.com/wisegrowth/wisebot-core.git","ssh_url":"git@github.com:wisegrowth/wisebot-core.git","clone_url":"https://github.com/wisegrowth/wisebot-core.git","svn_url":"https://github.com/wisegrowth/wisebot-core","homepage":"","size":800,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"development"}},"base":{"label":"wisegrowth:development","ref":"development","sha":"8c0b62608abb27f7497b8b8e27c75f0d96293293","user":{"login":"wisegrowth","id":25491546,"avatar_url":"https://avatars.githubusercontent.com/u/25491546?v=3","gravatar_id":"","url":"https://api.github.com/users/wisegrowth","html_url":"https://github.com/wisegrowth","followers_url":"https://api.github.com/users/wisegrowth/followers","following_url":"https://api.github.com/users/wisegrowth/following{/other_user}","gists_url":"https://api.github.com/users/wisegrowth/gists{/gist_id}","starred_url":"https://api.github.com/users/wisegrowth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wisegrowth/subscriptions","organizations_url":"https://api.github.com/users/wisegrowth/orgs","repos_url":"https://api.github.com/users/wisegrowth/repos","events_url":"https://api.github.com/users/wisegrowth/events{/privacy}","received_events_url":"https://api.github.com/users/wisegrowth/received_events","type":"Organization","site_admin":false},"repo":{"id":60830616,"name":"wisebot-core","full_name":"wisegrowth/wisebot-core","owner":{"login":"wisegrowth","id":25491546,"avatar_url":"https://avatars.githubusercontent.com/u/25491546?v=3","gravatar_id":"","url":"https://api.github.com/users/wisegrowth","html_url":"https://github.com/wisegrowth","followers_url":"https://api.github.com/users/wisegrowth/followers","following_url":"https://api.github.com/users/wisegrowth/following{/other_user}","gists_url":"https://api.github.com/users/wisegrowth/gists{/gist_id}","starred_url":"https://api.github.com/users/wisegrowth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wisegrowth/subscriptions","organizations_url":"https://api.github.com/users/wisegrowth/orgs","repos_url":"https://api.github.com/users/wisegrowth/repos","events_url":"https://api.github.com/users/wisegrowth/events{/privacy}","received_events_url":"https://api.github.com/users/wisegrowth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wisegrowth/wisebot-core","description":"Is the core of an Wisebot iot device, which by means of sensors and actuators, allow to execute customized rules in function of schedulers or events.","fork":false,"url":"https://api.github.com/repos/wisegrowth/wisebot-core","forks_url":"https://api.github.com/repos/wisegrowth/wisebot-core/forks","keys_url":"https://api.github.com/repos/wisegrowth/wisebot-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wisegrowth/wisebot-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wisegrowth/wisebot-core/teams","hooks_url":"https://api.github.com/repos/wisegrowth/wisebot-core/hooks","issue_events_url":"https://api.github.com/repos/wisegrowth/wisebot-core/issues/events{/number}","events_url":"https://api.github.com/repos/wisegrowth/wisebot-core/events","assignees_url":"https://api.github.com/repos/wisegrowth/wisebot-core/assignees{/user}","branches_url":"https://api.github.com/repos/wisegrowth/wisebot-core/branches{/branch}","tags_url":"https://api.github.com/repos/wisegrowth/wisebot-core/tags","blobs_url":"https://api.github.com/repos/wisegrowth/wisebot-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wisegrowth/wisebot-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wisegrowth/wisebot-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wisegrowth/wisebot-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wisegrowth/wisebot-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wisegrowth/wisebot-core/languages","stargazers_url":"https://api.github.com/repos/wisegrowth/wisebot-core/stargazers","contributors_url":"https://api.github.com/repos/wisegrowth/wisebot-core/contributors","subscribers_url":"https://api.github.com/repos/wisegrowth/wisebot-core/subscribers","subscription_url":"https://api.github.com/repos/wisegrowth/wisebot-core/subscription","commits_url":"https://api.github.com/repos/wisegrowth/wisebot-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wisegrowth/wisebot-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wisegrowth/wisebot-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wisegrowth/wisebot-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wisegrowth/wisebot-core/contents/{+path}","compare_url":"https://api.github.com/repos/wisegrowth/wisebot-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wisegrowth/wisebot-core/merges","archive_url":"https://api.github.com/repos/wisegrowth/wisebot-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wisegrowth/wisebot-core/downloads","issues_url":"https://api.github.com/repos/wisegrowth/wisebot-core/issues{/number}","pulls_url":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wisegrowth/wisebot-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wisegrowth/wisebot-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wisegrowth/wisebot-core/labels{/name}","releases_url":"https://api.github.com/repos/wisegrowth/wisebot-core/releases{/id}","deployments_url":"https://api.github.com/repos/wisegrowth/wisebot-core/deployments","created_at":"2016-06-10T07:20:52Z","updated_at":"2017-02-17T20:17:59Z","pushed_at":"2017-02-21T23:28:15Z","git_url":"git://github.com/wisegrowth/wisebot-core.git","ssh_url":"git@github.com:wisegrowth/wisebot-core.git","clone_url":"https://github.com/wisegrowth/wisebot-core.git","svn_url":"https://github.com/wisegrowth/wisebot-core","homepage":"","size":800,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls/10"},"html":{"href":"https://github.com/wisegrowth/wisebot-core/pull/10"},"issue":{"href":"https://api.github.com/repos/wisegrowth/wisebot-core/issues/10"},"comments":{"href":"https://api.github.com/repos/wisegrowth/wisebot-core/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wisegrowth/wisebot-core/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/wisegrowth/wisebot-core/statuses/4abdc133818df903330d20d9fb8426705e6437b2"}}}}
{"actor":{"display_login":"cagodoy"}}