{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/96106090","pull_request_review_id":16684825,"id":96106090,"diff_hunk":"@@ -238,7 +392,8 @@ object Invokeable {\n         parameterTypes.map(_.getName).mkString(\", \")\n       })\")\n \n-    assert(m.getReturnType == sct.runtimeClass,\n+    // generic type parameters return java.lang.Object instead of the correct class\n+    assert(m.getReturnType.isAssignableFrom(sct.runtimeClass),","path":"src/main/scala/org/broadinstitute/hail/asm4s/Code.scala","position":334,"original_position":334,"commit_id":"42e8d47fcd3c61abe9eb04c68fcf0afca07e407a","original_commit_id":"42e8d47fcd3c61abe9eb04c68fcf0afca07e407a","user":{"login":"danking","id":106194,"avatar_url":"https://avatars.githubusercontent.com/u/106194?v=3","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"body":"I need to think more about this. Generic parameters complicate things. I think there should be a `Code.checkcast[S]` in here.","created_at":"2017-01-14T02:25:12Z","updated_at":"2017-01-14T02:25:12Z","html_url":"https://github.com/hail-is/hail/pull/1254#discussion_r96106090","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/1254","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/96106090"},"html":{"href":"https://github.com/hail-is/hail/pull/1254#discussion_r96106090"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/1254"}}},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/1254","id":101545748,"html_url":"https://github.com/hail-is/hail/pull/1254","diff_url":"https://github.com/hail-is/hail/pull/1254.diff","patch_url":"https://github.com/hail-is/hail/pull/1254.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/1254","number":1254,"state":"open","locked":false,"title":"NOT READY: Compiler","user":{"login":"danking","id":106194,"avatar_url":"https://avatars.githubusercontent.com/u/106194?v=3","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"body":"It's still broken on a lot of aggregator expressions and it's a big mess, but people can start to take a look.","created_at":"2017-01-14T02:02:29Z","updated_at":"2017-01-14T02:25:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7948257f3693116925ca60c50c9fd886735a67f0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/1254/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/1254/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/1254/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/42e8d47fcd3c61abe9eb04c68fcf0afca07e407a","head":{"label":"danking:compiler2","ref":"compiler2","sha":"42e8d47fcd3c61abe9eb04c68fcf0afca07e407a","user":{"login":"danking","id":106194,"avatar_url":"https://avatars.githubusercontent.com/u/106194?v=3","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"repo":{"id":64700952,"name":"hail","full_name":"danking/hail","owner":{"login":"danking","id":106194,"avatar_url":"https://avatars.githubusercontent.com/u/106194?v=3","gravatar_id":"","url":"https://api.github.com/users/danking","html_url":"https://github.com/danking","followers_url":"https://api.github.com/users/danking/followers","following_url":"https://api.github.com/users/danking/following{/other_user}","gists_url":"https://api.github.com/users/danking/gists{/gist_id}","starred_url":"https://api.github.com/users/danking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danking/subscriptions","organizations_url":"https://api.github.com/users/danking/orgs","repos_url":"https://api.github.com/users/danking/repos","events_url":"https://api.github.com/users/danking/events{/privacy}","received_events_url":"https://api.github.com/users/danking/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danking/hail","description":"Hail, a framework for scalable genetic data analysis","fork":true,"url":"https://api.github.com/repos/danking/hail","forks_url":"https://api.github.com/repos/danking/hail/forks","keys_url":"https://api.github.com/repos/danking/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danking/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danking/hail/teams","hooks_url":"https://api.github.com/repos/danking/hail/hooks","issue_events_url":"https://api.github.com/repos/danking/hail/issues/events{/number}","events_url":"https://api.github.com/repos/danking/hail/events","assignees_url":"https://api.github.com/repos/danking/hail/assignees{/user}","branches_url":"https://api.github.com/repos/danking/hail/branches{/branch}","tags_url":"https://api.github.com/repos/danking/hail/tags","blobs_url":"https://api.github.com/repos/danking/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danking/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danking/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/danking/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danking/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/danking/hail/languages","stargazers_url":"https://api.github.com/repos/danking/hail/stargazers","contributors_url":"https://api.github.com/repos/danking/hail/contributors","subscribers_url":"https://api.github.com/repos/danking/hail/subscribers","subscription_url":"https://api.github.com/repos/danking/hail/subscription","commits_url":"https://api.github.com/repos/danking/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/danking/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/danking/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/danking/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/danking/hail/contents/{+path}","compare_url":"https://api.github.com/repos/danking/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danking/hail/merges","archive_url":"https://api.github.com/repos/danking/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danking/hail/downloads","issues_url":"https://api.github.com/repos/danking/hail/issues{/number}","pulls_url":"https://api.github.com/repos/danking/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/danking/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/danking/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danking/hail/labels{/name}","releases_url":"https://api.github.com/repos/danking/hail/releases{/id}","deployments_url":"https://api.github.com/repos/danking/hail/deployments","created_at":"2016-08-01T20:55:06Z","updated_at":"2016-08-01T20:55:08Z","pushed_at":"2017-01-14T02:23:07Z","git_url":"git://github.com/danking/hail.git","ssh_url":"git@github.com:danking/hail.git","clone_url":"https://github.com/danking/hail.git","svn_url":"https://github.com/danking/hail","homepage":"","size":10141,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"d4a4de388650657ccb796f4bb4eee789d657994a","user":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars.githubusercontent.com/u/20861792?v=3","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"name":"hail","full_name":"hail-is/hail","owner":{"login":"hail-is","id":20861792,"avatar_url":"https://avatars.githubusercontent.com/u/20861792?v=3","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hail-is/hail","description":"Scalable genetic data analysis","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2017-01-13T16:58:20Z","pushed_at":"2017-01-14T02:23:08Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":8330,"stargazers_count":96,"watchers_count":96,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":297,"forks":28,"open_issues":297,"watchers":96,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/1254"},"html":{"href":"https://github.com/hail-is/hail/pull/1254"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/1254"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/1254/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/1254/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/1254/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/42e8d47fcd3c61abe9eb04c68fcf0afca07e407a"}}}}
{"actor":{"display_login":"danking"}}