{"action":"created","issue":{"url":"https://api.github.com/repos/servo/webrender/issues/1011","repository_url":"https://api.github.com/repos/servo/webrender","labels_url":"https://api.github.com/repos/servo/webrender/issues/1011/labels{/name}","comments_url":"https://api.github.com/repos/servo/webrender/issues/1011/comments","events_url":"https://api.github.com/repos/servo/webrender/issues/1011/events","html_url":"https://github.com/servo/webrender/pull/1011","id":217104847,"number":1011,"title":"Optimize GPU time spent in clears.","user":{"login":"glennw","id":2350882,"avatar_url":"https://avatars3.githubusercontent.com/u/2350882?v=3","gravatar_id":"","url":"https://api.github.com/users/glennw","html_url":"https://github.com/glennw","followers_url":"https://api.github.com/users/glennw/followers","following_url":"https://api.github.com/users/glennw/following{/other_user}","gists_url":"https://api.github.com/users/glennw/gists{/gist_id}","starred_url":"https://api.github.com/users/glennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennw/subscriptions","organizations_url":"https://api.github.com/users/glennw/orgs","repos_url":"https://api.github.com/users/glennw/repos","events_url":"https://api.github.com/users/glennw/events{/privacy}","received_events_url":"https://api.github.com/users/glennw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-03-27T00:19:11Z","updated_at":"2017-03-28T07:32:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/servo/webrender/pulls/1011","html_url":"https://github.com/servo/webrender/pull/1011","diff_url":"https://github.com/servo/webrender/pull/1011.diff","patch_url":"https://github.com/servo/webrender/pull/1011.patch"},"body":"For alpha and color render targets, track the used rect in\r\nthe texture allocator. Use this to apply a scissor rect when\r\nclearing the targets.\r\n\r\nOn my GPU (HD530) this brings the GPU time on https://github.com/servo/servo\r\ndown from 2.7ms to 2.2ms. Other sites that use 1+ render targets also\r\nsee significant wins for GPU time.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/webrender/1011)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/webrender/issues/comments/289687470","html_url":"https://github.com/servo/webrender/pull/1011#issuecomment-289687470","issue_url":"https://api.github.com/repos/servo/webrender/issues/1011","id":289687470,"user":{"login":"glennw","id":2350882,"avatar_url":"https://avatars3.githubusercontent.com/u/2350882?v=3","gravatar_id":"","url":"https://api.github.com/users/glennw","html_url":"https://github.com/glennw","followers_url":"https://api.github.com/users/glennw/followers","following_url":"https://api.github.com/users/glennw/following{/other_user}","gists_url":"https://api.github.com/users/glennw/gists{/gist_id}","starred_url":"https://api.github.com/users/glennw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennw/subscriptions","organizations_url":"https://api.github.com/users/glennw/orgs","repos_url":"https://api.github.com/users/glennw/repos","events_url":"https://api.github.com/users/glennw/events{/privacy}","received_events_url":"https://api.github.com/users/glennw/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T07:32:32Z","updated_at":"2017-03-28T07:32:32Z","body":"I profiled this on my nVidia GPU, which is ```GeForce GTX 960M NVIDIA 375.39```. I also saw very significant performance gains there (perhaps more than the Intel GPU, on average).\r\n\r\nI've added comments mentioning that this is a large win on Intel/nVidia hardware, but may not be on all GPUs. I don't have any AMD hardware to benchmark.\r\n\r\nI think it makes sense to merge this - it's a very significant performance win, and (I assume) the majority of our target market will be running Intel GPUs. We can always benchmark and measure on other GPUs in the future.\r\n"}}
{"actor":{"display_login":"glennw"}}