{"action":"created","comment":{"url":"https://api.github.com/repos/zeit/serve/pulls/comments/144789832","pull_request_review_id":69494198,"id":144789832,"diff_hunk":"@@ -4,6 +4,7 @@\n const path = require('path')\n \n // Packages\n+const https = require('https')","path":"bin/serve.js","position":4,"original_position":4,"commit_id":"abb9c668aa18d6635c28d69ac95128970b898717","original_commit_id":"abb9c668aa18d6635c28d69ac95128970b898717","user":{"login":"leo","id":6170607,"avatar_url":"https://avatars1.githubusercontent.com/u/6170607?v=4","gravatar_id":"","url":"https://api.github.com/users/leo","html_url":"https://github.com/leo","followers_url":"https://api.github.com/users/leo/followers","following_url":"https://api.github.com/users/leo/following{/other_user}","gists_url":"https://api.github.com/users/leo/gists{/gist_id}","starred_url":"https://api.github.com/users/leo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leo/subscriptions","organizations_url":"https://api.github.com/users/leo/orgs","repos_url":"https://api.github.com/users/leo/repos","events_url":"https://api.github.com/users/leo/events{/privacy}","received_events_url":"https://api.github.com/users/leo/received_events","type":"User","site_admin":false},"body":"This is not a package - it needs to be part of the \"Native\" import group.","created_at":"2017-10-16T09:01:54Z","updated_at":"2017-10-16T09:03:25Z","html_url":"https://github.com/zeit/serve/pull/274#discussion_r144789832","pull_request_url":"https://api.github.com/repos/zeit/serve/pulls/274","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/zeit/serve/pulls/comments/144789832"},"html":{"href":"https://github.com/zeit/serve/pull/274#discussion_r144789832"},"pull_request":{"href":"https://api.github.com/repos/zeit/serve/pulls/274"}}},"pull_request":{"url":"https://api.github.com/repos/zeit/serve/pulls/274","id":145847965,"html_url":"https://github.com/zeit/serve/pull/274","diff_url":"https://github.com/zeit/serve/pull/274.diff","patch_url":"https://github.com/zeit/serve/pull/274.patch","issue_url":"https://api.github.com/repos/zeit/serve/issues/274","number":274,"state":"open","locked":false,"title":"Support HTTPS","user":{"login":"justanotherdot","id":5350032,"avatar_url":"https://avatars3.githubusercontent.com/u/5350032?v=4","gravatar_id":"","url":"https://api.github.com/users/justanotherdot","html_url":"https://github.com/justanotherdot","followers_url":"https://api.github.com/users/justanotherdot/followers","following_url":"https://api.github.com/users/justanotherdot/following{/other_user}","gists_url":"https://api.github.com/users/justanotherdot/gists{/gist_id}","starred_url":"https://api.github.com/users/justanotherdot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justanotherdot/subscriptions","organizations_url":"https://api.github.com/users/justanotherdot/orgs","repos_url":"https://api.github.com/users/justanotherdot/repos","events_url":"https://api.github.com/users/justanotherdot/events{/privacy}","received_events_url":"https://api.github.com/users/justanotherdot/received_events","type":"User","site_admin":false},"body":"This should hopefully resolve #178. It uses the example given in the\r\n`micro` examples of `with-https`. It has some rough edges still that\r\nneeded to be sanded down:\r\n\r\n* Choosing a specific short flag name for ssl (and if the initial flag\r\nshould still be called ssl; I'm tempted to rename it to `https` or what\r\nhave you) - would like if someone chimed in about their design thoughts for this.\r\n\r\n* The example always acks with 200 and the example object - should just be a matter of passing off the handler as `fn` to `microHttps`.\r\n\r\n* It does not support compression and merely overwrites the previous\r\nserver var - should also be trivial, just compress the handler before handing it off to whichever server will take it. ","created_at":"2017-10-11T03:19:46Z","updated_at":"2017-10-16T09:03:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"465862f0b95ee408c67c70504ce9cd4c65b7758b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zeit/serve/pulls/274/commits","review_comments_url":"https://api.github.com/repos/zeit/serve/pulls/274/comments","review_comment_url":"https://api.github.com/repos/zeit/serve/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeit/serve/issues/274/comments","statuses_url":"https://api.github.com/repos/zeit/serve/statuses/abb9c668aa18d6635c28d69ac95128970b898717","head":{"label":"justanotherdot:justanotherdot/support-https","ref":"justanotherdot/support-https","sha":"abb9c668aa18d6635c28d69ac95128970b898717","user":{"login":"justanotherdot","id":5350032,"avatar_url":"https://avatars3.githubusercontent.com/u/5350032?v=4","gravatar_id":"","url":"https://api.github.com/users/justanotherdot","html_url":"https://github.com/justanotherdot","followers_url":"https://api.github.com/users/justanotherdot/followers","following_url":"https://api.github.com/users/justanotherdot/following{/other_user}","gists_url":"https://api.github.com/users/justanotherdot/gists{/gist_id}","starred_url":"https://api.github.com/users/justanotherdot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justanotherdot/subscriptions","organizations_url":"https://api.github.com/users/justanotherdot/orgs","repos_url":"https://api.github.com/users/justanotherdot/repos","events_url":"https://api.github.com/users/justanotherdot/events{/privacy}","received_events_url":"https://api.github.com/users/justanotherdot/received_events","type":"User","site_admin":false},"repo":{"id":106488546,"name":"serve","full_name":"justanotherdot/serve","owner":{"login":"justanotherdot","id":5350032,"avatar_url":"https://avatars3.githubusercontent.com/u/5350032?v=4","gravatar_id":"","url":"https://api.github.com/users/justanotherdot","html_url":"https://github.com/justanotherdot","followers_url":"https://api.github.com/users/justanotherdot/followers","following_url":"https://api.github.com/users/justanotherdot/following{/other_user}","gists_url":"https://api.github.com/users/justanotherdot/gists{/gist_id}","starred_url":"https://api.github.com/users/justanotherdot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justanotherdot/subscriptions","organizations_url":"https://api.github.com/users/justanotherdot/orgs","repos_url":"https://api.github.com/users/justanotherdot/repos","events_url":"https://api.github.com/users/justanotherdot/events{/privacy}","received_events_url":"https://api.github.com/users/justanotherdot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justanotherdot/serve","description":"Static file serving and directory listing","fork":true,"url":"https://api.github.com/repos/justanotherdot/serve","forks_url":"https://api.github.com/repos/justanotherdot/serve/forks","keys_url":"https://api.github.com/repos/justanotherdot/serve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justanotherdot/serve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justanotherdot/serve/teams","hooks_url":"https://api.github.com/repos/justanotherdot/serve/hooks","issue_events_url":"https://api.github.com/repos/justanotherdot/serve/issues/events{/number}","events_url":"https://api.github.com/repos/justanotherdot/serve/events","assignees_url":"https://api.github.com/repos/justanotherdot/serve/assignees{/user}","branches_url":"https://api.github.com/repos/justanotherdot/serve/branches{/branch}","tags_url":"https://api.github.com/repos/justanotherdot/serve/tags","blobs_url":"https://api.github.com/repos/justanotherdot/serve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justanotherdot/serve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justanotherdot/serve/git/refs{/sha}","trees_url":"https://api.github.com/repos/justanotherdot/serve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justanotherdot/serve/statuses/{sha}","languages_url":"https://api.github.com/repos/justanotherdot/serve/languages","stargazers_url":"https://api.github.com/repos/justanotherdot/serve/stargazers","contributors_url":"https://api.github.com/repos/justanotherdot/serve/contributors","subscribers_url":"https://api.github.com/repos/justanotherdot/serve/subscribers","subscription_url":"https://api.github.com/repos/justanotherdot/serve/subscription","commits_url":"https://api.github.com/repos/justanotherdot/serve/commits{/sha}","git_commits_url":"https://api.github.com/repos/justanotherdot/serve/git/commits{/sha}","comments_url":"https://api.github.com/repos/justanotherdot/serve/comments{/number}","issue_comment_url":"https://api.github.com/repos/justanotherdot/serve/issues/comments{/number}","contents_url":"https://api.github.com/repos/justanotherdot/serve/contents/{+path}","compare_url":"https://api.github.com/repos/justanotherdot/serve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justanotherdot/serve/merges","archive_url":"https://api.github.com/repos/justanotherdot/serve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justanotherdot/serve/downloads","issues_url":"https://api.github.com/repos/justanotherdot/serve/issues{/number}","pulls_url":"https://api.github.com/repos/justanotherdot/serve/pulls{/number}","milestones_url":"https://api.github.com/repos/justanotherdot/serve/milestones{/number}","notifications_url":"https://api.github.com/repos/justanotherdot/serve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justanotherdot/serve/labels{/name}","releases_url":"https://api.github.com/repos/justanotherdot/serve/releases{/id}","deployments_url":"https://api.github.com/repos/justanotherdot/serve/deployments","created_at":"2017-10-11T01:07:45Z","updated_at":"2017-10-11T01:07:47Z","pushed_at":"2017-10-11T04:14:04Z","git_url":"git://github.com/justanotherdot/serve.git","ssh_url":"git@github.com:justanotherdot/serve.git","clone_url":"https://github.com/justanotherdot/serve.git","svn_url":"https://github.com/justanotherdot/serve","homepage":"https://npmjs.com/serve","size":426,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zeit:master","ref":"master","sha":"f687c994e4d58ecbc5541852e6fb3f4974fc12dd","user":{"login":"zeit","id":14985020,"avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"repo":{"id":57182064,"name":"serve","full_name":"zeit/serve","owner":{"login":"zeit","id":14985020,"avatar_url":"https://avatars0.githubusercontent.com/u/14985020?v=4","gravatar_id":"","url":"https://api.github.com/users/zeit","html_url":"https://github.com/zeit","followers_url":"https://api.github.com/users/zeit/followers","following_url":"https://api.github.com/users/zeit/following{/other_user}","gists_url":"https://api.github.com/users/zeit/gists{/gist_id}","starred_url":"https://api.github.com/users/zeit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeit/subscriptions","organizations_url":"https://api.github.com/users/zeit/orgs","repos_url":"https://api.github.com/users/zeit/repos","events_url":"https://api.github.com/users/zeit/events{/privacy}","received_events_url":"https://api.github.com/users/zeit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zeit/serve","description":"Static file serving and directory listing","fork":false,"url":"https://api.github.com/repos/zeit/serve","forks_url":"https://api.github.com/repos/zeit/serve/forks","keys_url":"https://api.github.com/repos/zeit/serve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeit/serve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeit/serve/teams","hooks_url":"https://api.github.com/repos/zeit/serve/hooks","issue_events_url":"https://api.github.com/repos/zeit/serve/issues/events{/number}","events_url":"https://api.github.com/repos/zeit/serve/events","assignees_url":"https://api.github.com/repos/zeit/serve/assignees{/user}","branches_url":"https://api.github.com/repos/zeit/serve/branches{/branch}","tags_url":"https://api.github.com/repos/zeit/serve/tags","blobs_url":"https://api.github.com/repos/zeit/serve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeit/serve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeit/serve/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeit/serve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeit/serve/statuses/{sha}","languages_url":"https://api.github.com/repos/zeit/serve/languages","stargazers_url":"https://api.github.com/repos/zeit/serve/stargazers","contributors_url":"https://api.github.com/repos/zeit/serve/contributors","subscribers_url":"https://api.github.com/repos/zeit/serve/subscribers","subscription_url":"https://api.github.com/repos/zeit/serve/subscription","commits_url":"https://api.github.com/repos/zeit/serve/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeit/serve/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeit/serve/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeit/serve/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeit/serve/contents/{+path}","compare_url":"https://api.github.com/repos/zeit/serve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeit/serve/merges","archive_url":"https://api.github.com/repos/zeit/serve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeit/serve/downloads","issues_url":"https://api.github.com/repos/zeit/serve/issues{/number}","pulls_url":"https://api.github.com/repos/zeit/serve/pulls{/number}","milestones_url":"https://api.github.com/repos/zeit/serve/milestones{/number}","notifications_url":"https://api.github.com/repos/zeit/serve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeit/serve/labels{/name}","releases_url":"https://api.github.com/repos/zeit/serve/releases{/id}","deployments_url":"https://api.github.com/repos/zeit/serve/deployments","created_at":"2016-04-27T03:58:25Z","updated_at":"2017-10-16T02:27:58Z","pushed_at":"2017-10-16T08:57:00Z","git_url":"git://github.com/zeit/serve.git","ssh_url":"git@github.com:zeit/serve.git","clone_url":"https://github.com/zeit/serve.git","svn_url":"https://github.com/zeit/serve","homepage":"https://npmjs.com/serve","size":446,"stargazers_count":1520,"watchers_count":1520,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":132,"mirror_url":null,"open_issues_count":13,"forks":132,"open_issues":13,"watchers":1520,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeit/serve/pulls/274"},"html":{"href":"https://github.com/zeit/serve/pull/274"},"issue":{"href":"https://api.github.com/repos/zeit/serve/issues/274"},"comments":{"href":"https://api.github.com/repos/zeit/serve/issues/274/comments"},"review_comments":{"href":"https://api.github.com/repos/zeit/serve/pulls/274/comments"},"review_comment":{"href":"https://api.github.com/repos/zeit/serve/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeit/serve/pulls/274/commits"},"statuses":{"href":"https://api.github.com/repos/zeit/serve/statuses/abb9c668aa18d6635c28d69ac95128970b898717"}},"author_association":"NONE"}}
{"actor":{"display_login":"leo"}}