{"push_id":1849401128,"size":12,"distinct_size":1,"ref":"refs/heads/master","head":"df5d8f593e599bcfdb6f90d08fd2a8b87faa225b","before":"0687b5973b7d722a6bed3676bc1bcc5b384bed5c","commits":[{"sha":"3eb450fe435ba71b20ad2a4da94df8b71c5df3d7","author":{"name":"Alex Tomlins","email":"31b9da3a3465b3ecfa36a9fa34a21a9e359978e7@digital.cabinet-office.gov.uk"},"message":"Fix test suite name for compose client suite.","distinct":false,"url":"https://api.github.com/repos/alphagov/paas-compose-broker/commits/3eb450fe435ba71b20ad2a4da94df8b71c5df3d7"},{"sha":"d3768fc5d4a9a68679718cc1556d63df29135f68","author":{"name":"Alex Tomlins","email":"31b9da3a3465b3ecfa36a9fa34a21a9e359978e7@digital.cabinet-office.gov.uk"},"message":"Refactor catalog.Load to be a constructor.\n\nIn every case we were using this it was being used to populate a new\ninstance. It therefore makes sense for it to be a constructor that\nreturns a populated instance.","distinct":false,"url":"https://api.github.com/repos/alphagov/paas-compose-broker/commits/d3768fc5d4a9a68679718cc1556d63df29135f68"},{"sha":"30d8c3165ac927ee687c7328d892f085e4a45a7d","author":{"name":"Alex Tomlins","email":"31b9da3a3465b3ecfa36a9fa34a21a9e359978e7@digital.cabinet-office.gov.uk"},"message":"Combine integration test suites.\n\nCombining these avoids duplicating much of the setup code. This uses\nGinkgo's Skip function[1] to disable the tests that hit the real compose\nAPI when needed.\n\nAs part of this refactoring, I've also reduced the use of global\nvariables in the tests. This results in the context for tests being\ndefined much closer to the individual tests themselves, which helps\nreadability.\n\n[1]http://onsi.github.io/ginkgo/#pending-specs","distinct":false,"url":"https://api.github.com/repos/alphagov/paas-compose-broker/commits/30d8c3165ac927ee687c7328d892f085e4a45a7d"},{"sha":"dbe62da2e2b0e1c35329279ea24b98306bcd1a4b","author":{"name":"Alex Tomlins","email":"31b9da3a3465b3ecfa36a9fa34a21a9e359978e7@digital.cabinet-office.gov.uk"},"message":"Use numeric HTTP status codes in tests.\n\nUsing the constants from the http package actually makes it a little\nharder to read in this instance. The service broker API docs[1] specify\nall the response codes numerically, and having to mentally translate\nfrom the names back to the numbers slows down reading these tests.\n\n[1] https://docs.cloudfoundry.org/services/api.html","distinct":false,"url":"https://api.github.com/repos/alphagov/paas-compose-broker/commits/dbe62da2e2b0e1c35329279ea24b98306bcd1a4b"},{"sha":"06fbb41af1911f629ae507d89e781c637d340ea0","author":{"name":"Alex Tomlins","email":"31b9da3a3465b3ecfa36a9fa34a21a9e359978e7@digital.cabinet-office.gov.uk"},"message":"Send broker test logs to GinkgoWriter\n\nThis reduces noise when running the tests. The log output will still be\nprinted when a test fails - but only the log output for that test.","distinct":false,"url":"https://api.github.com/repos/alphagov/paas-compose-broker/commits/06fbb41af1911f629ae507d89e781c637d340ea0"},{"sha":"15a394c049458af6e698e8876580b9510e559a82","author":{"name":"Alex Tomlins","email":"31b9da3a3465b3ecfa36a9fa34a21a9e359978e7@digital.cabinet-office.gov.uk"},"message":"Don't store a pointer to a slice in FakeComposeClient\n\nThis makes it a bit more compersome to use, and is unnecessary.","distinct":false,"url":"https://api.github.com/repos/alphagov/paas-compose-broker/commits/15a394c049458af6e698e8876580b9510e559a82"},{"sha":"e13a886a056d9ebabf04a8022b54894416704420","author":{"name":"Alex Tomlins","email":"31b9da3a3465b3ecfa36a9fa34a21a9e359978e7@digital.cabinet-office.gov.uk"},"message":"Move lookup of account and cluster ID into broker.New\n\nThis removes this logic from main, and means that it can be tested more\neasily. It also means that this is covered by the integration tests.\n\nThis has required extending the compose.Client interface to include\nthese extra methods. We were previously relying on a concrete type to do\nthese lookups.","distinct":false,"url":"https://api.github.com/repos/alphagov/paas-compose-broker/commits/e13a886a056d9ebabf04a8022b54894416704420"},{"sha":"cc19938a5005d32464e60fe0e2fd453bfacf29aa","author":{"name":"Alex Tomlins","email":"31b9da3a3465b3ecfa36a9fa34a21a9e359978e7@digital.cabinet-office.gov.uk"},"message":"Fix database name returned from Bind call.\n\nThis was previously using the RequestURI from the returned connection\nstring, which included both the leading '/' and the query params.","distinct":false,"url":"https://api.github.com/repos/alphagov/paas-compose-broker/commits/cc19938a5005d32464e60fe0e2fd453bfacf29aa"},{"sha":"f97ba402f2c5ce312c6b1aeef435cc50228eba11","author":{"name":"Alex Tomlins","email":"31b9da3a3465b3ecfa36a9fa34a21a9e359978e7@digital.cabinet-office.gov.uk"},"message":"Remove JDBC URI from returned credentials\n\nThe official Mongo Java driver[1] doesn't use JDBC and therefore uses\nthe standard mongodb connection string format[2]. From talking with some\njava developers we don't think this is useful to return. We're also not\nclear what parameters would need to be provided etc.\n\n[1]http://mongodb.github.io/mongo-java-driver/3.4/driver/\n[2]https://docs.mongodb.com/manual/reference/connection-string/#standard-connection-string-format","distinct":false,"url":"https://api.github.com/repos/alphagov/paas-compose-broker/commits/f97ba402f2c5ce312c6b1aeef435cc50228eba11"},{"sha":"e73fda3628c1b5f24532372b4e51cc593da24772","author":{"name":"Alex Tomlins","email":"31b9da3a3465b3ecfa36a9fa34a21a9e359978e7@digital.cabinet-office.gov.uk"},"message":"Don't return ErrInstanceDoesNotExist for all errors\n\nWe were previously returning ErrInstanceDoesNotExist for any error\nreturned from the call to get the compose Deployment by name. This could\nlead to erroneously reporting to CloudController that things are gone\nwhen they aren't, and potentially lead to orphaned deployments.\n\nAs part of fixing this, I've switched to use the upstream client's\nGetDeploymentByName() method which was recently added.","distinct":false,"url":"https://api.github.com/repos/alphagov/paas-compose-broker/commits/e73fda3628c1b5f24532372b4e51cc593da24772"},{"sha":"37ff98a13512bc5ea90bd4a050bee011da4bc346","author":{"name":"Alex Tomlins","email":"31b9da3a3465b3ecfa36a9fa34a21a9e359978e7@digital.cabinet-office.gov.uk"},"message":"Add GetCluster() to compose.Client interface.\n\nRemoves the need for a type assertion in the tests - cleans up a FIXME","distinct":false,"url":"https://api.github.com/repos/alphagov/paas-compose-broker/commits/37ff98a13512bc5ea90bd4a050bee011da4bc346"},{"sha":"df5d8f593e599bcfdb6f90d08fd2a8b87faa225b","author":{"name":"Piotr Komborski","email":"73a8e733ebaf1ae03d66577f52417f07f1ce289d@users.noreply.github.com"},"message":"Merge pull request #5 from alphagov/fix_database_name\n\n[#147992413] Fix returned database name","distinct":true,"url":"https://api.github.com/repos/alphagov/paas-compose-broker/commits/df5d8f593e599bcfdb6f90d08fd2a8b87faa225b"}]}
{"actor":{"display_login":"combor"}}