{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/44491","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/44491/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/44491/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/44491/events","html_url":"https://github.com/kubernetes/kubernetes/pull/44491","id":221771076,"number":44491,"title":"Define const annotation variable once","user":{"login":"NickrenREN","id":6104418,"avatar_url":"https://avatars0.githubusercontent.com/u/6104418?v=3","gravatar_id":"","url":"https://api.github.com/users/NickrenREN","html_url":"https://github.com/NickrenREN","followers_url":"https://api.github.com/users/NickrenREN/followers","following_url":"https://api.github.com/users/NickrenREN/following{/other_user}","gists_url":"https://api.github.com/users/NickrenREN/gists{/gist_id}","starred_url":"https://api.github.com/users/NickrenREN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickrenREN/subscriptions","organizations_url":"https://api.github.com/users/NickrenREN/orgs","repos_url":"https://api.github.com/users/NickrenREN/repos","events_url":"https://api.github.com/users/NickrenREN/events{/privacy}","received_events_url":"https://api.github.com/users/NickrenREN/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450895,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"open","locked":false,"assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars3.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars3.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-04-14T08:57:07Z","updated_at":"2017-04-24T01:04:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/44491","html_url":"https://github.com/kubernetes/kubernetes/pull/44491","diff_url":"https://github.com/kubernetes/kubernetes/pull/44491.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/44491.patch"},"body":"We do not need to define the const annotation var twice in pkg/volume and pkg/volume/validation\r\n\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/296502696","html_url":"https://github.com/kubernetes/kubernetes/pull/44491#issuecomment-296502696","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/44491","id":296502696,"user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars3.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"created_at":"2017-04-24T01:04:48Z","updated_at":"2017-04-24T01:04:48Z","body":"We explicitly do NOT take a dependency from pkg/volume into pkg/volume/validation, because that then means the API is now dependent on all volume related code.  This was intentional.  \r\n\r\nRefactoring the annotation to some common location imported by both pkg/volume and pkg/volume/validation that has no additional dependencies would be acceptable, but not this move."}}
{"actor":{"display_login":"smarterclayton"}}