{"action":"created","comment":{"url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/pulls/comments/147965661","pull_request_review_id":73133762,"id":147965661,"diff_hunk":"@@ -1,8 +1,8 @@\n #ifndef MPAGSCIPHER_RUNCAESARCIPHER_HPP\n-#define MPAGSCIPHER_RUNCAESERCIPHER_HPP\n+#define MPAGSCIPHER_RUNCAESARCIPHER_HPP","path":"MPAGSCipher/runCaesarCipher.hpp","position":3,"original_position":3,"commit_id":"d6c03b234dbe8b9dede6b36069c929e71cd1028d","original_commit_id":"d6c03b234dbe8b9dede6b36069c929e71cd1028d","user":{"login":"tomlatham","id":6817722,"avatar_url":"https://avatars3.githubusercontent.com/u/6817722?v=4","gravatar_id":"","url":"https://api.github.com/users/tomlatham","html_url":"https://github.com/tomlatham","followers_url":"https://api.github.com/users/tomlatham/followers","following_url":"https://api.github.com/users/tomlatham/following{/other_user}","gists_url":"https://api.github.com/users/tomlatham/gists{/gist_id}","starred_url":"https://api.github.com/users/tomlatham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomlatham/subscriptions","organizations_url":"https://api.github.com/users/tomlatham/orgs","repos_url":"https://api.github.com/users/tomlatham/repos","events_url":"https://api.github.com/users/tomlatham/events{/privacy}","received_events_url":"https://api.github.com/users/tomlatham/received_events","type":"User","site_admin":false},"body":"This rather tricky bug was spotted by the clang++ compiler but I guess not by g++ or whatever you are using.\r\nIt's always best to actually copy and paste the ifndef line and then change the ifndef to define so that you're sure that the string is identical.","created_at":"2017-10-31T11:36:49Z","updated_at":"2017-10-31T11:36:49Z","html_url":"https://github.com/cpp-pg-mpags/mpags-c-course-day-2-smngr/pull/1#discussion_r147965661","pull_request_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/pulls/1","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/pulls/comments/147965661"},"html":{"href":"https://github.com/cpp-pg-mpags/mpags-c-course-day-2-smngr/pull/1#discussion_r147965661"},"pull_request":{"href":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/pulls/1","id":149758545,"html_url":"https://github.com/cpp-pg-mpags/mpags-c-course-day-2-smngr/pull/1","diff_url":"https://github.com/cpp-pg-mpags/mpags-c-course-day-2-smngr/pull/1.diff","patch_url":"https://github.com/cpp-pg-mpags/mpags-c-course-day-2-smngr/pull/1.patch","issue_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/issues/1","number":1,"state":"open","locked":false,"title":"TEL edits to Day2 homework","user":{"login":"tomlatham","id":6817722,"avatar_url":"https://avatars3.githubusercontent.com/u/6817722?v=4","gravatar_id":"","url":"https://api.github.com/users/tomlatham","html_url":"https://github.com/tomlatham","followers_url":"https://api.github.com/users/tomlatham/followers","following_url":"https://api.github.com/users/tomlatham/following{/other_user}","gists_url":"https://api.github.com/users/tomlatham/gists{/gist_id}","starred_url":"https://api.github.com/users/tomlatham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomlatham/subscriptions","organizations_url":"https://api.github.com/users/tomlatham/orgs","repos_url":"https://api.github.com/users/tomlatham/repos","events_url":"https://api.github.com/users/tomlatham/events{/privacy}","received_events_url":"https://api.github.com/users/tomlatham/received_events","type":"User","site_admin":false},"body":"Generally very nicely done.  The code works almost exactly as expected.\r\nWould be nice to have all functions documented with a comment preceding the declaration in the header file.\r\nPlease find a few other specific comments below along with a few suggested edits.\r\n","created_at":"2017-10-31T11:23:09Z","updated_at":"2017-10-31T11:36:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a59364d5d8dc07f7e449e17d59f19b3cd096a7e1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/pulls/1/commits","review_comments_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/pulls/1/comments","review_comment_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/issues/1/comments","statuses_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/statuses/d6c03b234dbe8b9dede6b36069c929e71cd1028d","head":{"label":"tomlatham:Day2Branch","ref":"Day2Branch","sha":"d6c03b234dbe8b9dede6b36069c929e71cd1028d","user":{"login":"tomlatham","id":6817722,"avatar_url":"https://avatars3.githubusercontent.com/u/6817722?v=4","gravatar_id":"","url":"https://api.github.com/users/tomlatham","html_url":"https://github.com/tomlatham","followers_url":"https://api.github.com/users/tomlatham/followers","following_url":"https://api.github.com/users/tomlatham/following{/other_user}","gists_url":"https://api.github.com/users/tomlatham/gists{/gist_id}","starred_url":"https://api.github.com/users/tomlatham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomlatham/subscriptions","organizations_url":"https://api.github.com/users/tomlatham/orgs","repos_url":"https://api.github.com/users/tomlatham/repos","events_url":"https://api.github.com/users/tomlatham/events{/privacy}","received_events_url":"https://api.github.com/users/tomlatham/received_events","type":"User","site_admin":false},"repo":{"id":108913713,"name":"mpags-c-course-day-2-smngr","full_name":"tomlatham/mpags-c-course-day-2-smngr","owner":{"login":"tomlatham","id":6817722,"avatar_url":"https://avatars3.githubusercontent.com/u/6817722?v=4","gravatar_id":"","url":"https://api.github.com/users/tomlatham","html_url":"https://github.com/tomlatham","followers_url":"https://api.github.com/users/tomlatham/followers","following_url":"https://api.github.com/users/tomlatham/following{/other_user}","gists_url":"https://api.github.com/users/tomlatham/gists{/gist_id}","starred_url":"https://api.github.com/users/tomlatham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomlatham/subscriptions","organizations_url":"https://api.github.com/users/tomlatham/orgs","repos_url":"https://api.github.com/users/tomlatham/repos","events_url":"https://api.github.com/users/tomlatham/events{/privacy}","received_events_url":"https://api.github.com/users/tomlatham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomlatham/mpags-c-course-day-2-smngr","description":"mpags-c-course-day-2-smngr created by GitHub Classroom","fork":true,"url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr","forks_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/forks","keys_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/teams","hooks_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/hooks","issue_events_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/issues/events{/number}","events_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/events","assignees_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/assignees{/user}","branches_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/branches{/branch}","tags_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/tags","blobs_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/statuses/{sha}","languages_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/languages","stargazers_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/stargazers","contributors_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/contributors","subscribers_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/subscribers","subscription_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/subscription","commits_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/contents/{+path}","compare_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/merges","archive_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/downloads","issues_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/issues{/number}","pulls_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/pulls{/number}","milestones_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/milestones{/number}","notifications_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/labels{/name}","releases_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/releases{/id}","deployments_url":"https://api.github.com/repos/tomlatham/mpags-c-course-day-2-smngr/deployments","created_at":"2017-10-30T22:06:42Z","updated_at":"2017-10-30T22:06:44Z","pushed_at":"2017-10-31T11:08:07Z","git_url":"git://github.com/tomlatham/mpags-c-course-day-2-smngr.git","ssh_url":"git@github.com:tomlatham/mpags-c-course-day-2-smngr.git","clone_url":"https://github.com/tomlatham/mpags-c-course-day-2-smngr.git","svn_url":"https://github.com/tomlatham/mpags-c-course-day-2-smngr","homepage":null,"size":23,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"Day2Branch"}},"base":{"label":"cpp-pg-mpags:Day2Branch","ref":"Day2Branch","sha":"540788ded2e40c54d5f92c69050a5ad6fe1fbf92","user":{"login":"cpp-pg-mpags","id":22007561,"avatar_url":"https://avatars1.githubusercontent.com/u/22007561?v=4","gravatar_id":"","url":"https://api.github.com/users/cpp-pg-mpags","html_url":"https://github.com/cpp-pg-mpags","followers_url":"https://api.github.com/users/cpp-pg-mpags/followers","following_url":"https://api.github.com/users/cpp-pg-mpags/following{/other_user}","gists_url":"https://api.github.com/users/cpp-pg-mpags/gists{/gist_id}","starred_url":"https://api.github.com/users/cpp-pg-mpags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpp-pg-mpags/subscriptions","organizations_url":"https://api.github.com/users/cpp-pg-mpags/orgs","repos_url":"https://api.github.com/users/cpp-pg-mpags/repos","events_url":"https://api.github.com/users/cpp-pg-mpags/events{/privacy}","received_events_url":"https://api.github.com/users/cpp-pg-mpags/received_events","type":"Organization","site_admin":false},"repo":{"id":108433906,"name":"mpags-c-course-day-2-smngr","full_name":"cpp-pg-mpags/mpags-c-course-day-2-smngr","owner":{"login":"cpp-pg-mpags","id":22007561,"avatar_url":"https://avatars1.githubusercontent.com/u/22007561?v=4","gravatar_id":"","url":"https://api.github.com/users/cpp-pg-mpags","html_url":"https://github.com/cpp-pg-mpags","followers_url":"https://api.github.com/users/cpp-pg-mpags/followers","following_url":"https://api.github.com/users/cpp-pg-mpags/following{/other_user}","gists_url":"https://api.github.com/users/cpp-pg-mpags/gists{/gist_id}","starred_url":"https://api.github.com/users/cpp-pg-mpags/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpp-pg-mpags/subscriptions","organizations_url":"https://api.github.com/users/cpp-pg-mpags/orgs","repos_url":"https://api.github.com/users/cpp-pg-mpags/repos","events_url":"https://api.github.com/users/cpp-pg-mpags/events{/privacy}","received_events_url":"https://api.github.com/users/cpp-pg-mpags/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cpp-pg-mpags/mpags-c-course-day-2-smngr","description":"mpags-c-course-day-2-smngr created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr","forks_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/forks","keys_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/teams","hooks_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/hooks","issue_events_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/issues/events{/number}","events_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/events","assignees_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/assignees{/user}","branches_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/branches{/branch}","tags_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/tags","blobs_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/statuses/{sha}","languages_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/languages","stargazers_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/stargazers","contributors_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/contributors","subscribers_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/subscribers","subscription_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/subscription","commits_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/contents/{+path}","compare_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/merges","archive_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/downloads","issues_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/issues{/number}","pulls_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/pulls{/number}","milestones_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/milestones{/number}","notifications_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/labels{/name}","releases_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/releases{/id}","deployments_url":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/deployments","created_at":"2017-10-26T16:00:04Z","updated_at":"2017-10-26T16:00:19Z","pushed_at":"2017-10-31T11:23:09Z","git_url":"git://github.com/cpp-pg-mpags/mpags-c-course-day-2-smngr.git","ssh_url":"git@github.com:cpp-pg-mpags/mpags-c-course-day-2-smngr.git","clone_url":"https://github.com/cpp-pg-mpags/mpags-c-course-day-2-smngr.git","svn_url":"https://github.com/cpp-pg-mpags/mpags-c-course-day-2-smngr","homepage":null,"size":23,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"Day2Branch"}},"_links":{"self":{"href":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/pulls/1"},"html":{"href":"https://github.com/cpp-pg-mpags/mpags-c-course-day-2-smngr/pull/1"},"issue":{"href":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/issues/1"},"comments":{"href":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/cpp-pg-mpags/mpags-c-course-day-2-smngr/statuses/d6c03b234dbe8b9dede6b36069c929e71cd1028d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tomlatham"}}