{"action":"created","comment":{"url":"https://api.github.com/repos/openconfig/ygot/pulls/comments/140104915","pull_request_review_id":64129945,"id":140104915,"diff_hunk":"@@ -362,16 +363,18 @@ func (s *genState) findEnumSet(entries map[string]*yang.Entry, compressPaths boo\n // base's name. This function wraps the identityrefBaseTypeFromIdentity\n // function since it covers the common case that the caller is interested in\n // determining the name from an identityref leaf, rather than directly from the\n-// identity.\n-func (s *genState) resolveIdentityRefBaseType(idr *yang.Entry) string {\n-\treturn s.identityrefBaseTypeFromIdentity(idr.Type.IdentityBase)\n+// identity. If the omitUnderscores bool is set to true, underscores are omitted\n+// from the name returned.\n+func (s *genState) resolveIdentityRefBaseType(idr *yang.Entry, omitUnderscores bool) string {\n+\treturn s.identityrefBaseTypeFromIdentity(idr.Type.IdentityBase, omitUnderscores)\n }\n \n // identityrefBaseTypeFromIdentity takes an input yang.Identity pointer and\n // determines the name of the identity used within the generated code for it. The value\n // returned is based on the defining module followed by the CamelCase-ified version\n-// of the identity's name.\n-func (s *genState) identityrefBaseTypeFromIdentity(i *yang.Identity) string {\n+// of the identity's name. If omitUnderscores is set to false, the module name is\n+// separated with undescores, otherwise they are omitted.\n+func (s *genState) identityrefBaseTypeFromIdentity(i *yang.Identity, omitUnderscores bool) string {","path":"ygen/genstate.go","position":104,"original_position":104,"commit_id":"fa26896e3e18197f050f19d67b98ccdb2c65ed93","original_commit_id":"fa26896e3e18197f050f19d67b98ccdb2c65ed93","user":{"login":"robshakir","id":4836821,"avatar_url":"https://avatars3.githubusercontent.com/u/4836821?v=4","gravatar_id":"","url":"https://api.github.com/users/robshakir","html_url":"https://github.com/robshakir","followers_url":"https://api.github.com/users/robshakir/followers","following_url":"https://api.github.com/users/robshakir/following{/other_user}","gists_url":"https://api.github.com/users/robshakir/gists{/gist_id}","starred_url":"https://api.github.com/users/robshakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robshakir/subscriptions","organizations_url":"https://api.github.com/users/robshakir/orgs","repos_url":"https://api.github.com/users/robshakir/repos","events_url":"https://api.github.com/users/robshakir/events{/privacy}","received_events_url":"https://api.github.com/users/robshakir/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-09-20T22:03:47Z","updated_at":"2017-09-20T22:04:36Z","html_url":"https://github.com/openconfig/ygot/pull/44#discussion_r140104915","pull_request_url":"https://api.github.com/repos/openconfig/ygot/pulls/44","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openconfig/ygot/pulls/comments/140104915"},"html":{"href":"https://github.com/openconfig/ygot/pull/44#discussion_r140104915"},"pull_request":{"href":"https://api.github.com/repos/openconfig/ygot/pulls/44"}},"in_reply_to_id":140029786},"pull_request":{"url":"https://api.github.com/repos/openconfig/ygot/pulls/44","id":142009564,"html_url":"https://github.com/openconfig/ygot/pull/44","diff_url":"https://github.com/openconfig/ygot/pull/44.diff","patch_url":"https://github.com/openconfig/ygot/pull/44.patch","issue_url":"https://api.github.com/repos/openconfig/ygot/issues/44","number":44,"state":"open","locked":false,"title":"Add configurable import paths, protobuf enum renames.","user":{"login":"robshakir","id":4836821,"avatar_url":"https://avatars3.githubusercontent.com/u/4836821?v=4","gravatar_id":"","url":"https://api.github.com/users/robshakir","html_url":"https://github.com/robshakir","followers_url":"https://api.github.com/users/robshakir/followers","following_url":"https://api.github.com/users/robshakir/following{/other_user}","gists_url":"https://api.github.com/users/robshakir/gists{/gist_id}","starred_url":"https://api.github.com/users/robshakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robshakir/subscriptions","organizations_url":"https://api.github.com/users/robshakir/orgs","repos_url":"https://api.github.com/users/robshakir/repos","events_url":"https://api.github.com/users/robshakir/events{/privacy}","received_events_url":"https://api.github.com/users/robshakir/received_events","type":"User","site_admin":false},"body":"* Add support for flags to specify the import paths for `yext.proto` and `ywrapper.proto`.\r\n* Update enumerated name output formats to comply with protobuf best practice.","created_at":"2017-09-20T04:46:56Z","updated_at":"2017-09-20T22:04:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dd5586248e615cedb39b0a5df1514f8c559252b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openconfig/ygot/pulls/44/commits","review_comments_url":"https://api.github.com/repos/openconfig/ygot/pulls/44/comments","review_comment_url":"https://api.github.com/repos/openconfig/ygot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openconfig/ygot/issues/44/comments","statuses_url":"https://api.github.com/repos/openconfig/ygot/statuses/fa26896e3e18197f050f19d67b98ccdb2c65ed93","head":{"label":"openconfig:robjs-protogen-12","ref":"robjs-protogen-12","sha":"fa26896e3e18197f050f19d67b98ccdb2c65ed93","user":{"login":"openconfig","id":8780263,"avatar_url":"https://avatars3.githubusercontent.com/u/8780263?v=4","gravatar_id":"","url":"https://api.github.com/users/openconfig","html_url":"https://github.com/openconfig","followers_url":"https://api.github.com/users/openconfig/followers","following_url":"https://api.github.com/users/openconfig/following{/other_user}","gists_url":"https://api.github.com/users/openconfig/gists{/gist_id}","starred_url":"https://api.github.com/users/openconfig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openconfig/subscriptions","organizations_url":"https://api.github.com/users/openconfig/orgs","repos_url":"https://api.github.com/users/openconfig/repos","events_url":"https://api.github.com/users/openconfig/events{/privacy}","received_events_url":"https://api.github.com/users/openconfig/received_events","type":"Organization","site_admin":false},"repo":{"id":99452048,"name":"ygot","full_name":"openconfig/ygot","owner":{"login":"openconfig","id":8780263,"avatar_url":"https://avatars3.githubusercontent.com/u/8780263?v=4","gravatar_id":"","url":"https://api.github.com/users/openconfig","html_url":"https://github.com/openconfig","followers_url":"https://api.github.com/users/openconfig/followers","following_url":"https://api.github.com/users/openconfig/following{/other_user}","gists_url":"https://api.github.com/users/openconfig/gists{/gist_id}","starred_url":"https://api.github.com/users/openconfig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openconfig/subscriptions","organizations_url":"https://api.github.com/users/openconfig/orgs","repos_url":"https://api.github.com/users/openconfig/repos","events_url":"https://api.github.com/users/openconfig/events{/privacy}","received_events_url":"https://api.github.com/users/openconfig/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openconfig/ygot","description":"A toolkit for working with YANG data models in Go.","fork":false,"url":"https://api.github.com/repos/openconfig/ygot","forks_url":"https://api.github.com/repos/openconfig/ygot/forks","keys_url":"https://api.github.com/repos/openconfig/ygot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openconfig/ygot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openconfig/ygot/teams","hooks_url":"https://api.github.com/repos/openconfig/ygot/hooks","issue_events_url":"https://api.github.com/repos/openconfig/ygot/issues/events{/number}","events_url":"https://api.github.com/repos/openconfig/ygot/events","assignees_url":"https://api.github.com/repos/openconfig/ygot/assignees{/user}","branches_url":"https://api.github.com/repos/openconfig/ygot/branches{/branch}","tags_url":"https://api.github.com/repos/openconfig/ygot/tags","blobs_url":"https://api.github.com/repos/openconfig/ygot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openconfig/ygot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openconfig/ygot/git/refs{/sha}","trees_url":"https://api.github.com/repos/openconfig/ygot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openconfig/ygot/statuses/{sha}","languages_url":"https://api.github.com/repos/openconfig/ygot/languages","stargazers_url":"https://api.github.com/repos/openconfig/ygot/stargazers","contributors_url":"https://api.github.com/repos/openconfig/ygot/contributors","subscribers_url":"https://api.github.com/repos/openconfig/ygot/subscribers","subscription_url":"https://api.github.com/repos/openconfig/ygot/subscription","commits_url":"https://api.github.com/repos/openconfig/ygot/commits{/sha}","git_commits_url":"https://api.github.com/repos/openconfig/ygot/git/commits{/sha}","comments_url":"https://api.github.com/repos/openconfig/ygot/comments{/number}","issue_comment_url":"https://api.github.com/repos/openconfig/ygot/issues/comments{/number}","contents_url":"https://api.github.com/repos/openconfig/ygot/contents/{+path}","compare_url":"https://api.github.com/repos/openconfig/ygot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openconfig/ygot/merges","archive_url":"https://api.github.com/repos/openconfig/ygot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openconfig/ygot/downloads","issues_url":"https://api.github.com/repos/openconfig/ygot/issues{/number}","pulls_url":"https://api.github.com/repos/openconfig/ygot/pulls{/number}","milestones_url":"https://api.github.com/repos/openconfig/ygot/milestones{/number}","notifications_url":"https://api.github.com/repos/openconfig/ygot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openconfig/ygot/labels{/name}","releases_url":"https://api.github.com/repos/openconfig/ygot/releases{/id}","deployments_url":"https://api.github.com/repos/openconfig/ygot/deployments","created_at":"2017-08-05T22:56:40Z","updated_at":"2017-09-13T04:13:43Z","pushed_at":"2017-09-20T21:59:37Z","git_url":"git://github.com/openconfig/ygot.git","ssh_url":"git@github.com:openconfig/ygot.git","clone_url":"https://github.com/openconfig/ygot.git","svn_url":"https://github.com/openconfig/ygot","homepage":null,"size":12189,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":5,"default_branch":"master"}},"base":{"label":"openconfig:master","ref":"master","sha":"de7be2242e9fa3edc15668ea58e6ac8a807f7537","user":{"login":"openconfig","id":8780263,"avatar_url":"https://avatars3.githubusercontent.com/u/8780263?v=4","gravatar_id":"","url":"https://api.github.com/users/openconfig","html_url":"https://github.com/openconfig","followers_url":"https://api.github.com/users/openconfig/followers","following_url":"https://api.github.com/users/openconfig/following{/other_user}","gists_url":"https://api.github.com/users/openconfig/gists{/gist_id}","starred_url":"https://api.github.com/users/openconfig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openconfig/subscriptions","organizations_url":"https://api.github.com/users/openconfig/orgs","repos_url":"https://api.github.com/users/openconfig/repos","events_url":"https://api.github.com/users/openconfig/events{/privacy}","received_events_url":"https://api.github.com/users/openconfig/received_events","type":"Organization","site_admin":false},"repo":{"id":99452048,"name":"ygot","full_name":"openconfig/ygot","owner":{"login":"openconfig","id":8780263,"avatar_url":"https://avatars3.githubusercontent.com/u/8780263?v=4","gravatar_id":"","url":"https://api.github.com/users/openconfig","html_url":"https://github.com/openconfig","followers_url":"https://api.github.com/users/openconfig/followers","following_url":"https://api.github.com/users/openconfig/following{/other_user}","gists_url":"https://api.github.com/users/openconfig/gists{/gist_id}","starred_url":"https://api.github.com/users/openconfig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openconfig/subscriptions","organizations_url":"https://api.github.com/users/openconfig/orgs","repos_url":"https://api.github.com/users/openconfig/repos","events_url":"https://api.github.com/users/openconfig/events{/privacy}","received_events_url":"https://api.github.com/users/openconfig/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openconfig/ygot","description":"A toolkit for working with YANG data models in Go.","fork":false,"url":"https://api.github.com/repos/openconfig/ygot","forks_url":"https://api.github.com/repos/openconfig/ygot/forks","keys_url":"https://api.github.com/repos/openconfig/ygot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openconfig/ygot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openconfig/ygot/teams","hooks_url":"https://api.github.com/repos/openconfig/ygot/hooks","issue_events_url":"https://api.github.com/repos/openconfig/ygot/issues/events{/number}","events_url":"https://api.github.com/repos/openconfig/ygot/events","assignees_url":"https://api.github.com/repos/openconfig/ygot/assignees{/user}","branches_url":"https://api.github.com/repos/openconfig/ygot/branches{/branch}","tags_url":"https://api.github.com/repos/openconfig/ygot/tags","blobs_url":"https://api.github.com/repos/openconfig/ygot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openconfig/ygot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openconfig/ygot/git/refs{/sha}","trees_url":"https://api.github.com/repos/openconfig/ygot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openconfig/ygot/statuses/{sha}","languages_url":"https://api.github.com/repos/openconfig/ygot/languages","stargazers_url":"https://api.github.com/repos/openconfig/ygot/stargazers","contributors_url":"https://api.github.com/repos/openconfig/ygot/contributors","subscribers_url":"https://api.github.com/repos/openconfig/ygot/subscribers","subscription_url":"https://api.github.com/repos/openconfig/ygot/subscription","commits_url":"https://api.github.com/repos/openconfig/ygot/commits{/sha}","git_commits_url":"https://api.github.com/repos/openconfig/ygot/git/commits{/sha}","comments_url":"https://api.github.com/repos/openconfig/ygot/comments{/number}","issue_comment_url":"https://api.github.com/repos/openconfig/ygot/issues/comments{/number}","contents_url":"https://api.github.com/repos/openconfig/ygot/contents/{+path}","compare_url":"https://api.github.com/repos/openconfig/ygot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openconfig/ygot/merges","archive_url":"https://api.github.com/repos/openconfig/ygot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openconfig/ygot/downloads","issues_url":"https://api.github.com/repos/openconfig/ygot/issues{/number}","pulls_url":"https://api.github.com/repos/openconfig/ygot/pulls{/number}","milestones_url":"https://api.github.com/repos/openconfig/ygot/milestones{/number}","notifications_url":"https://api.github.com/repos/openconfig/ygot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openconfig/ygot/labels{/name}","releases_url":"https://api.github.com/repos/openconfig/ygot/releases{/id}","deployments_url":"https://api.github.com/repos/openconfig/ygot/deployments","created_at":"2017-08-05T22:56:40Z","updated_at":"2017-09-13T04:13:43Z","pushed_at":"2017-09-20T21:59:37Z","git_url":"git://github.com/openconfig/ygot.git","ssh_url":"git@github.com:openconfig/ygot.git","clone_url":"https://github.com/openconfig/ygot.git","svn_url":"https://github.com/openconfig/ygot","homepage":null,"size":12189,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":11,"forks":2,"open_issues":11,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openconfig/ygot/pulls/44"},"html":{"href":"https://github.com/openconfig/ygot/pull/44"},"issue":{"href":"https://api.github.com/repos/openconfig/ygot/issues/44"},"comments":{"href":"https://api.github.com/repos/openconfig/ygot/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/openconfig/ygot/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/openconfig/ygot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openconfig/ygot/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/openconfig/ygot/statuses/fa26896e3e18197f050f19d67b98ccdb2c65ed93"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"robshakir"}}