{"action":"closed","number":130,"pull_request":{"url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/pulls/130","id":134068156,"html_url":"https://github.com/ashfurrow/Nimble-Snapshots/pull/130","diff_url":"https://github.com/ashfurrow/Nimble-Snapshots/pull/130.diff","patch_url":"https://github.com/ashfurrow/Nimble-Snapshots/pull/130.patch","issue_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/issues/130","number":130,"state":"closed","locked":false,"title":"[WIP] Swift-4 Upgrade","user":{"login":"Vkt0r","id":4573453,"avatar_url":"https://avatars3.githubusercontent.com/u/4573453?v=4","gravatar_id":"","url":"https://api.github.com/users/Vkt0r","html_url":"https://github.com/Vkt0r","followers_url":"https://api.github.com/users/Vkt0r/followers","following_url":"https://api.github.com/users/Vkt0r/following{/other_user}","gists_url":"https://api.github.com/users/Vkt0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Vkt0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vkt0r/subscriptions","organizations_url":"https://api.github.com/users/Vkt0r/orgs","repos_url":"https://api.github.com/users/Vkt0r/repos","events_url":"https://api.github.com/users/Vkt0r/events{/privacy}","received_events_url":"https://api.github.com/users/Vkt0r/received_events","type":"User","site_admin":false},"body":"Hi guys,\r\n\r\nUntil XCode 9.0 beta 4 I was using the library without any problem using Carthage and compiling it using the XCode 9 command line tools when I ran `carthage update --platform ios`.\r\n\r\nNow in XCode 9.0 beta 4 ocurred a minor change the API of `XCTestCase` the `name: String?` variable changed and the compiler was complaining about it when `carthage` ran. I was able to fix the compilation error removing the optional chaining.\r\n\r\nAfter that I migrate the project to Swift 4 and set the default optimizations recommended by XCode, I fixed a minor issue regarding the migration and the library is compiling without any problem and it was possible to integrate in the project I'm using with XCode 9 beta4.\r\n\r\nI think we can start migrating the library to Swift 4 as we can use libraries with other Swift versions without any problem thanks to XCode 9. I set the PR to `WIP` to work on any change necessary.","created_at":"2017-08-04T00:19:59Z","updated_at":"2017-10-05T18:41:22Z","closed_at":"2017-10-05T18:41:22Z","merged_at":null,"merge_commit_sha":"19b63bb414c2efaea268015d18fb753cd12d0c98","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/pulls/130/commits","review_comments_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/pulls/130/comments","review_comment_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/issues/130/comments","statuses_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/statuses/1d59b6c72da77486e0c0e4b56e2cd5ba864f6a35","head":{"label":"Vkt0r:swift-4","ref":"swift-4","sha":"1d59b6c72da77486e0c0e4b56e2cd5ba864f6a35","user":{"login":"Vkt0r","id":4573453,"avatar_url":"https://avatars3.githubusercontent.com/u/4573453?v=4","gravatar_id":"","url":"https://api.github.com/users/Vkt0r","html_url":"https://github.com/Vkt0r","followers_url":"https://api.github.com/users/Vkt0r/followers","following_url":"https://api.github.com/users/Vkt0r/following{/other_user}","gists_url":"https://api.github.com/users/Vkt0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Vkt0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vkt0r/subscriptions","organizations_url":"https://api.github.com/users/Vkt0r/orgs","repos_url":"https://api.github.com/users/Vkt0r/repos","events_url":"https://api.github.com/users/Vkt0r/events{/privacy}","received_events_url":"https://api.github.com/users/Vkt0r/received_events","type":"User","site_admin":false},"repo":{"id":90877827,"name":"Nimble-Snapshots","full_name":"Vkt0r/Nimble-Snapshots","owner":{"login":"Vkt0r","id":4573453,"avatar_url":"https://avatars3.githubusercontent.com/u/4573453?v=4","gravatar_id":"","url":"https://api.github.com/users/Vkt0r","html_url":"https://github.com/Vkt0r","followers_url":"https://api.github.com/users/Vkt0r/followers","following_url":"https://api.github.com/users/Vkt0r/following{/other_user}","gists_url":"https://api.github.com/users/Vkt0r/gists{/gist_id}","starred_url":"https://api.github.com/users/Vkt0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vkt0r/subscriptions","organizations_url":"https://api.github.com/users/Vkt0r/orgs","repos_url":"https://api.github.com/users/Vkt0r/repos","events_url":"https://api.github.com/users/Vkt0r/events{/privacy}","received_events_url":"https://api.github.com/users/Vkt0r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vkt0r/Nimble-Snapshots","description":"Nimble matchers for FBSnapshotTestCase","fork":true,"url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots","forks_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/forks","keys_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/teams","hooks_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/hooks","issue_events_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/issues/events{/number}","events_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/events","assignees_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/assignees{/user}","branches_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/branches{/branch}","tags_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/tags","blobs_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/statuses/{sha}","languages_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/languages","stargazers_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/stargazers","contributors_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/contributors","subscribers_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/subscribers","subscription_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/subscription","commits_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/contents/{+path}","compare_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/merges","archive_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/downloads","issues_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/issues{/number}","pulls_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/pulls{/number}","milestones_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/milestones{/number}","notifications_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/labels{/name}","releases_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/releases{/id}","deployments_url":"https://api.github.com/repos/Vkt0r/Nimble-Snapshots/deployments","created_at":"2017-05-10T15:08:25Z","updated_at":"2017-05-10T15:08:26Z","pushed_at":"2017-08-23T03:11:33Z","git_url":"git://github.com/Vkt0r/Nimble-Snapshots.git","ssh_url":"git@github.com:Vkt0r/Nimble-Snapshots.git","clone_url":"https://github.com/Vkt0r/Nimble-Snapshots.git","svn_url":"https://github.com/Vkt0r/Nimble-Snapshots","homepage":"","size":990,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ashfurrow:master","ref":"master","sha":"48d697a08e7d11f582bb39a7b6b9558b0d2083c0","user":{"login":"ashfurrow","id":498212,"avatar_url":"https://avatars3.githubusercontent.com/u/498212?v=4","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"repo":{"id":22723832,"name":"Nimble-Snapshots","full_name":"ashfurrow/Nimble-Snapshots","owner":{"login":"ashfurrow","id":498212,"avatar_url":"https://avatars3.githubusercontent.com/u/498212?v=4","gravatar_id":"","url":"https://api.github.com/users/ashfurrow","html_url":"https://github.com/ashfurrow","followers_url":"https://api.github.com/users/ashfurrow/followers","following_url":"https://api.github.com/users/ashfurrow/following{/other_user}","gists_url":"https://api.github.com/users/ashfurrow/gists{/gist_id}","starred_url":"https://api.github.com/users/ashfurrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashfurrow/subscriptions","organizations_url":"https://api.github.com/users/ashfurrow/orgs","repos_url":"https://api.github.com/users/ashfurrow/repos","events_url":"https://api.github.com/users/ashfurrow/events{/privacy}","received_events_url":"https://api.github.com/users/ashfurrow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashfurrow/Nimble-Snapshots","description":"Nimble matchers for FBSnapshotTestCase","fork":false,"url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots","forks_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/forks","keys_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/teams","hooks_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/hooks","issue_events_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/issues/events{/number}","events_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/events","assignees_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/assignees{/user}","branches_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/branches{/branch}","tags_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/tags","blobs_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/statuses/{sha}","languages_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/languages","stargazers_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/stargazers","contributors_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/contributors","subscribers_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/subscribers","subscription_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/subscription","commits_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/contents/{+path}","compare_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/merges","archive_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/downloads","issues_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/issues{/number}","pulls_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/pulls{/number}","milestones_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/milestones{/number}","notifications_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/labels{/name}","releases_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/releases{/id}","deployments_url":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/deployments","created_at":"2014-08-07T14:16:58Z","updated_at":"2017-09-29T15:38:38Z","pushed_at":"2017-10-05T18:39:04Z","git_url":"git://github.com/ashfurrow/Nimble-Snapshots.git","ssh_url":"git@github.com:ashfurrow/Nimble-Snapshots.git","clone_url":"https://github.com/ashfurrow/Nimble-Snapshots.git","svn_url":"https://github.com/ashfurrow/Nimble-Snapshots","homepage":"","size":1430,"stargazers_count":156,"watchers_count":156,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":4,"forks":48,"open_issues":4,"watchers":156,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/pulls/130"},"html":{"href":"https://github.com/ashfurrow/Nimble-Snapshots/pull/130"},"issue":{"href":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/issues/130"},"comments":{"href":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/ashfurrow/Nimble-Snapshots/statuses/1d59b6c72da77486e0c0e4b56e2cd5ba864f6a35"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":5,"review_comments":5,"maintainer_can_modify":false,"commits":16,"additions":105,"deletions":52,"changed_files":21}}
{"actor":{"display_login":"ashfurrow"}}