{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/2989","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/2989/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/2989/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/2989/events","html_url":"https://github.com/WordPress/gutenberg/pull/2989","id":264634920,"number":2989,"title":"Components: Add a generic navigable menu component","user":{"login":"youknowriad","id":272444,"avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"labels":[{"id":546517042,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/Accessibility","name":"Accessibility","color":"655104","default":false},{"id":659839209,"url":"https://api.github.com/repos/WordPress/gutenberg/labels/UI%20Components","name":"UI Components","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"youknowriad","id":272444,"avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"assignees":[{"login":"youknowriad","id":272444,"avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/WordPress/gutenberg/milestones/24","html_url":"https://github.com/WordPress/gutenberg/milestone/24","labels_url":"https://api.github.com/repos/WordPress/gutenberg/milestones/24/labels","id":2815245,"number":24,"title":"Beta 1.5","description":"","creator":{"login":"karmatosed","id":253067,"avatar_url":"https://avatars3.githubusercontent.com/u/253067?v=4","gravatar_id":"","url":"https://api.github.com/users/karmatosed","html_url":"https://github.com/karmatosed","followers_url":"https://api.github.com/users/karmatosed/followers","following_url":"https://api.github.com/users/karmatosed/following{/other_user}","gists_url":"https://api.github.com/users/karmatosed/gists{/gist_id}","starred_url":"https://api.github.com/users/karmatosed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karmatosed/subscriptions","organizations_url":"https://api.github.com/users/karmatosed/orgs","repos_url":"https://api.github.com/users/karmatosed/repos","events_url":"https://api.github.com/users/karmatosed/events{/privacy}","received_events_url":"https://api.github.com/users/karmatosed/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":2,"state":"open","created_at":"2017-10-04T17:23:59Z","updated_at":"2017-10-12T04:08:29Z","due_on":null,"closed_at":null},"comments":12,"created_at":"2017-10-11T15:34:39Z","updated_at":"2017-10-12T14:52:18Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/2989","html_url":"https://github.com/WordPress/gutenberg/pull/2989","diff_url":"https://github.com/WordPress/gutenberg/pull/2989.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/2989.patch"},"body":"I found that in several places, we'll have to create menus navigable using arrow keys. (toolbar, switcher ). I'm trying to extract this logic to a generic Navigable Menu Component.\r\n\r\nI also dropped the DropdownMenu component which was not very reusable. (Tried and failed reusing it several times). It can be replaced with a combo `Dropdown` and `NavigableMenu`\r\n\r\nThe name of the component is probably not great, but I'm having a hard time finding a good name.\r\n\r\nI'm using the component in the table block toolbar and in the block switcher dropdown. Could be used later for #2960 "},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/336161965","html_url":"https://github.com/WordPress/gutenberg/pull/2989#issuecomment-336161965","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/2989","id":336161965,"user":{"login":"youknowriad","id":272444,"avatar_url":"https://avatars3.githubusercontent.com/u/272444?v=4","gravatar_id":"","url":"https://api.github.com/users/youknowriad","html_url":"https://github.com/youknowriad","followers_url":"https://api.github.com/users/youknowriad/followers","following_url":"https://api.github.com/users/youknowriad/following{/other_user}","gists_url":"https://api.github.com/users/youknowriad/gists{/gist_id}","starred_url":"https://api.github.com/users/youknowriad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youknowriad/subscriptions","organizations_url":"https://api.github.com/users/youknowriad/orgs","repos_url":"https://api.github.com/users/youknowriad/repos","events_url":"https://api.github.com/users/youknowriad/events{/privacy}","received_events_url":"https://api.github.com/users/youknowriad/received_events","type":"User","site_admin":false},"created_at":"2017-10-12T14:52:18Z","updated_at":"2017-10-12T14:52:18Z","author_association":"COLLABORATOR","body":"> tabindex=0 should be on the element with role=menu and not on the popover.\r\n\r\nCan you explain why the `tabIndex=0` should be on the menu? This is causing an issue when opening the popover, because opening the popover moves the focus to the first tabbable element in the popover (whether the popover contains a menu or not) and if it contains a menu, it's moving the focus to the menu if we add `tabIndex=0` instead of the first element of the menu. Is this correct?"}}
{"actor":{"display_login":"youknowriad"}}