{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/17495","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/17495/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/17495/comments","events_url":"https://api.github.com/repos/apache/spark/issues/17495/events","html_url":"https://github.com/apache/spark/pull/17495","id":218452131,"number":17495,"title":"[SPARK-20172][Core] Add file permission check when listing files in FsHistoryProvider","user":{"login":"jerryshao","id":850797,"avatar_url":"https://avatars1.githubusercontent.com/u/850797?v=3","gravatar_id":"","url":"https://api.github.com/users/jerryshao","html_url":"https://github.com/jerryshao","followers_url":"https://api.github.com/users/jerryshao/followers","following_url":"https://api.github.com/users/jerryshao/following{/other_user}","gists_url":"https://api.github.com/users/jerryshao/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryshao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryshao/subscriptions","organizations_url":"https://api.github.com/users/jerryshao/orgs","repos_url":"https://api.github.com/users/jerryshao/repos","events_url":"https://api.github.com/users/jerryshao/events{/privacy}","received_events_url":"https://api.github.com/users/jerryshao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-03-31T09:47:32Z","updated_at":"2017-04-07T09:49:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/17495","html_url":"https://github.com/apache/spark/pull/17495","diff_url":"https://github.com/apache/spark/pull/17495.diff","patch_url":"https://github.com/apache/spark/pull/17495.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nIn the current Spark's HistoryServer we expected to get `AccessControlException` during listing all the files, but unfortunately it was not worked because we actually doesn't check the access permission and no other calls will throw such exception. What was worse is that this check will be deferred until reading files, which is not necessary and quite verbose, since it will be printed out the exception in every 10 seconds when checking the files.\r\n\r\nSo here with this fix, we actually check the read permission during listing the files, which could avoid unnecessary file read later on and suppress the verbose log.\r\n\r\n## How was this patch tested?\r\n\r\nAdd unit test to verify."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/292492690","html_url":"https://github.com/apache/spark/pull/17495#issuecomment-292492690","issue_url":"https://api.github.com/repos/apache/spark/issues/17495","id":292492690,"user":{"login":"SparkQA","id":8108735,"avatar_url":"https://avatars2.githubusercontent.com/u/8108735?v=3","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2017-04-07T09:49:35Z","updated_at":"2017-04-07T09:49:35Z","body":"**[Test build #75594 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75594/testReport)** for PR 17495 at commit [`63142cc`](https://github.com/apache/spark/commit/63142cc82cc131b51c9d66525670caf4cba2ad39).\n * This patch passes all tests.\n * This patch merges cleanly.\n * This patch adds no public classes."}}
{"actor":{"display_login":"SparkQA"}}