{"action":"created","comment":{"url":"https://api.github.com/repos/frappe/frappe/pulls/comments/126899175","pull_request_review_id":49427419,"id":126899175,"diff_hunk":"@@ -0,0 +1,52 @@\n+# Copyright (c) 2015, Frappe Technologies Pvt. Ltd. and Contributors\n+# MIT License. See license.txt\n+\n+from __future__ import unicode_literals\n+import unittest\n+import frappe\n+\n+from frappe.desk import notifications\n+from frappe.test_runner import make_test_objects\n+import frappe.utils\n+\n+class TestNotifications(unittest.TestCase):\n+\tdef setUp(self):\n+\t\ttest_records = [\n+\t\t\t{\n+\t\t\t\"abbr\": \"_TC\",\n+\t\t\t\"company_name\": \"_Test Company\",","path":"frappe/tests/test_notifications.py","position":17,"original_position":17,"commit_id":"adfba9f7270f3839f125b51edbf5f26b981c71de","original_commit_id":"adfba9f7270f3839f125b51edbf5f26b981c71de","user":{"login":"rmehta","id":140076,"avatar_url":"https://avatars2.githubusercontent.com/u/140076?v=3","gravatar_id":"","url":"https://api.github.com/users/rmehta","html_url":"https://github.com/rmehta","followers_url":"https://api.github.com/users/rmehta/followers","following_url":"https://api.github.com/users/rmehta/following{/other_user}","gists_url":"https://api.github.com/users/rmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/rmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmehta/subscriptions","organizations_url":"https://api.github.com/users/rmehta/orgs","repos_url":"https://api.github.com/users/rmehta/repos","events_url":"https://api.github.com/users/rmehta/events{/privacy}","received_events_url":"https://api.github.com/users/rmehta/received_events","type":"User","site_admin":false},"body":"also reason why tests are failing","created_at":"2017-07-12T08:58:28Z","updated_at":"2017-07-12T08:58:28Z","html_url":"https://github.com/frappe/frappe/pull/3641#discussion_r126899175","pull_request_url":"https://api.github.com/repos/frappe/frappe/pulls/3641","_links":{"self":{"href":"https://api.github.com/repos/frappe/frappe/pulls/comments/126899175"},"html":{"href":"https://github.com/frappe/frappe/pull/3641#discussion_r126899175"},"pull_request":{"href":"https://api.github.com/repos/frappe/frappe/pulls/3641"}}},"pull_request":{"url":"https://api.github.com/repos/frappe/frappe/pulls/3641","id":129462620,"html_url":"https://github.com/frappe/frappe/pull/3641","diff_url":"https://github.com/frappe/frappe/pull/3641.diff","patch_url":"https://github.com/frappe/frappe/pull/3641.patch","issue_url":"https://api.github.com/repos/frappe/frappe/issues/3641","number":3641,"state":"open","locked":false,"title":"Graphs, and target notifications","user":{"login":"pratu16x7","id":5196925,"avatar_url":"https://avatars0.githubusercontent.com/u/5196925?v=3","gravatar_id":"","url":"https://api.github.com/users/pratu16x7","html_url":"https://github.com/pratu16x7","followers_url":"https://api.github.com/users/pratu16x7/followers","following_url":"https://api.github.com/users/pratu16x7/following{/other_user}","gists_url":"https://api.github.com/users/pratu16x7/gists{/gist_id}","starred_url":"https://api.github.com/users/pratu16x7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pratu16x7/subscriptions","organizations_url":"https://api.github.com/users/pratu16x7/orgs","repos_url":"https://api.github.com/users/pratu16x7/repos","events_url":"https://api.github.com/users/pratu16x7/events{/privacy}","received_events_url":"https://api.github.com/users/pratu16x7/received_events","type":"User","site_admin":false},"body":"For frappe/erpnext#9723\r\n\r\n- graph.js (Also add in dashboard)\r\n- cleanup notifications.js, add target progress","created_at":"2017-07-07T18:33:01Z","updated_at":"2017-07-12T08:58:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4706fbb9b6b9f6e10b86cceff4d6c1ff820fc6cd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/frappe/frappe/pulls/3641/commits","review_comments_url":"https://api.github.com/repos/frappe/frappe/pulls/3641/comments","review_comment_url":"https://api.github.com/repos/frappe/frappe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/frappe/frappe/issues/3641/comments","statuses_url":"https://api.github.com/repos/frappe/frappe/statuses/adfba9f7270f3839f125b51edbf5f26b981c71de","head":{"label":"pratu16x7:sales-goal","ref":"sales-goal","sha":"adfba9f7270f3839f125b51edbf5f26b981c71de","user":{"login":"pratu16x7","id":5196925,"avatar_url":"https://avatars0.githubusercontent.com/u/5196925?v=3","gravatar_id":"","url":"https://api.github.com/users/pratu16x7","html_url":"https://github.com/pratu16x7","followers_url":"https://api.github.com/users/pratu16x7/followers","following_url":"https://api.github.com/users/pratu16x7/following{/other_user}","gists_url":"https://api.github.com/users/pratu16x7/gists{/gist_id}","starred_url":"https://api.github.com/users/pratu16x7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pratu16x7/subscriptions","organizations_url":"https://api.github.com/users/pratu16x7/orgs","repos_url":"https://api.github.com/users/pratu16x7/repos","events_url":"https://api.github.com/users/pratu16x7/events{/privacy}","received_events_url":"https://api.github.com/users/pratu16x7/received_events","type":"User","site_admin":false},"repo":{"id":72198729,"name":"frappe","full_name":"pratu16x7/frappe","owner":{"login":"pratu16x7","id":5196925,"avatar_url":"https://avatars0.githubusercontent.com/u/5196925?v=3","gravatar_id":"","url":"https://api.github.com/users/pratu16x7","html_url":"https://github.com/pratu16x7","followers_url":"https://api.github.com/users/pratu16x7/followers","following_url":"https://api.github.com/users/pratu16x7/following{/other_user}","gists_url":"https://api.github.com/users/pratu16x7/gists{/gist_id}","starred_url":"https://api.github.com/users/pratu16x7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pratu16x7/subscriptions","organizations_url":"https://api.github.com/users/pratu16x7/orgs","repos_url":"https://api.github.com/users/pratu16x7/repos","events_url":"https://api.github.com/users/pratu16x7/events{/privacy}","received_events_url":"https://api.github.com/users/pratu16x7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pratu16x7/frappe","description":"Rapid Application Development Framework in Python & JS. Used to build ERPNext","fork":true,"url":"https://api.github.com/repos/pratu16x7/frappe","forks_url":"https://api.github.com/repos/pratu16x7/frappe/forks","keys_url":"https://api.github.com/repos/pratu16x7/frappe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pratu16x7/frappe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pratu16x7/frappe/teams","hooks_url":"https://api.github.com/repos/pratu16x7/frappe/hooks","issue_events_url":"https://api.github.com/repos/pratu16x7/frappe/issues/events{/number}","events_url":"https://api.github.com/repos/pratu16x7/frappe/events","assignees_url":"https://api.github.com/repos/pratu16x7/frappe/assignees{/user}","branches_url":"https://api.github.com/repos/pratu16x7/frappe/branches{/branch}","tags_url":"https://api.github.com/repos/pratu16x7/frappe/tags","blobs_url":"https://api.github.com/repos/pratu16x7/frappe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pratu16x7/frappe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pratu16x7/frappe/git/refs{/sha}","trees_url":"https://api.github.com/repos/pratu16x7/frappe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pratu16x7/frappe/statuses/{sha}","languages_url":"https://api.github.com/repos/pratu16x7/frappe/languages","stargazers_url":"https://api.github.com/repos/pratu16x7/frappe/stargazers","contributors_url":"https://api.github.com/repos/pratu16x7/frappe/contributors","subscribers_url":"https://api.github.com/repos/pratu16x7/frappe/subscribers","subscription_url":"https://api.github.com/repos/pratu16x7/frappe/subscription","commits_url":"https://api.github.com/repos/pratu16x7/frappe/commits{/sha}","git_commits_url":"https://api.github.com/repos/pratu16x7/frappe/git/commits{/sha}","comments_url":"https://api.github.com/repos/pratu16x7/frappe/comments{/number}","issue_comment_url":"https://api.github.com/repos/pratu16x7/frappe/issues/comments{/number}","contents_url":"https://api.github.com/repos/pratu16x7/frappe/contents/{+path}","compare_url":"https://api.github.com/repos/pratu16x7/frappe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pratu16x7/frappe/merges","archive_url":"https://api.github.com/repos/pratu16x7/frappe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pratu16x7/frappe/downloads","issues_url":"https://api.github.com/repos/pratu16x7/frappe/issues{/number}","pulls_url":"https://api.github.com/repos/pratu16x7/frappe/pulls{/number}","milestones_url":"https://api.github.com/repos/pratu16x7/frappe/milestones{/number}","notifications_url":"https://api.github.com/repos/pratu16x7/frappe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pratu16x7/frappe/labels{/name}","releases_url":"https://api.github.com/repos/pratu16x7/frappe/releases{/id}","deployments_url":"https://api.github.com/repos/pratu16x7/frappe/deployments","created_at":"2016-10-28T10:34:13Z","updated_at":"2016-10-28T10:34:18Z","pushed_at":"2017-07-12T06:41:32Z","git_url":"git://github.com/pratu16x7/frappe.git","ssh_url":"git@github.com:pratu16x7/frappe.git","clone_url":"https://github.com/pratu16x7/frappe.git","svn_url":"https://github.com/pratu16x7/frappe","homepage":"http://frappe.io","size":104884,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"frappe:develop","ref":"develop","sha":"4f5f43c279d6f2e3e2ff263197358fe7fb24e7ed","user":{"login":"frappe","id":836974,"avatar_url":"https://avatars1.githubusercontent.com/u/836974?v=3","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"repo":{"id":1864194,"name":"frappe","full_name":"frappe/frappe","owner":{"login":"frappe","id":836974,"avatar_url":"https://avatars1.githubusercontent.com/u/836974?v=3","gravatar_id":"","url":"https://api.github.com/users/frappe","html_url":"https://github.com/frappe","followers_url":"https://api.github.com/users/frappe/followers","following_url":"https://api.github.com/users/frappe/following{/other_user}","gists_url":"https://api.github.com/users/frappe/gists{/gist_id}","starred_url":"https://api.github.com/users/frappe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frappe/subscriptions","organizations_url":"https://api.github.com/users/frappe/orgs","repos_url":"https://api.github.com/users/frappe/repos","events_url":"https://api.github.com/users/frappe/events{/privacy}","received_events_url":"https://api.github.com/users/frappe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/frappe/frappe","description":"Full Stack Web Framework in Python & JS. Used to build ERPNext","fork":false,"url":"https://api.github.com/repos/frappe/frappe","forks_url":"https://api.github.com/repos/frappe/frappe/forks","keys_url":"https://api.github.com/repos/frappe/frappe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frappe/frappe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frappe/frappe/teams","hooks_url":"https://api.github.com/repos/frappe/frappe/hooks","issue_events_url":"https://api.github.com/repos/frappe/frappe/issues/events{/number}","events_url":"https://api.github.com/repos/frappe/frappe/events","assignees_url":"https://api.github.com/repos/frappe/frappe/assignees{/user}","branches_url":"https://api.github.com/repos/frappe/frappe/branches{/branch}","tags_url":"https://api.github.com/repos/frappe/frappe/tags","blobs_url":"https://api.github.com/repos/frappe/frappe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frappe/frappe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frappe/frappe/git/refs{/sha}","trees_url":"https://api.github.com/repos/frappe/frappe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frappe/frappe/statuses/{sha}","languages_url":"https://api.github.com/repos/frappe/frappe/languages","stargazers_url":"https://api.github.com/repos/frappe/frappe/stargazers","contributors_url":"https://api.github.com/repos/frappe/frappe/contributors","subscribers_url":"https://api.github.com/repos/frappe/frappe/subscribers","subscription_url":"https://api.github.com/repos/frappe/frappe/subscription","commits_url":"https://api.github.com/repos/frappe/frappe/commits{/sha}","git_commits_url":"https://api.github.com/repos/frappe/frappe/git/commits{/sha}","comments_url":"https://api.github.com/repos/frappe/frappe/comments{/number}","issue_comment_url":"https://api.github.com/repos/frappe/frappe/issues/comments{/number}","contents_url":"https://api.github.com/repos/frappe/frappe/contents/{+path}","compare_url":"https://api.github.com/repos/frappe/frappe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frappe/frappe/merges","archive_url":"https://api.github.com/repos/frappe/frappe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frappe/frappe/downloads","issues_url":"https://api.github.com/repos/frappe/frappe/issues{/number}","pulls_url":"https://api.github.com/repos/frappe/frappe/pulls{/number}","milestones_url":"https://api.github.com/repos/frappe/frappe/milestones{/number}","notifications_url":"https://api.github.com/repos/frappe/frappe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frappe/frappe/labels{/name}","releases_url":"https://api.github.com/repos/frappe/frappe/releases{/id}","deployments_url":"https://api.github.com/repos/frappe/frappe/deployments","created_at":"2011-06-08T08:14:16Z","updated_at":"2017-07-10T07:40:18Z","pushed_at":"2017-07-12T08:57:41Z","git_url":"git://github.com/frappe/frappe.git","ssh_url":"git@github.com:frappe/frappe.git","clone_url":"https://github.com/frappe/frappe.git","svn_url":"https://github.com/frappe/frappe","homepage":"http://frappe.io","size":105634,"stargazers_count":630,"watchers_count":630,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":514,"mirror_url":null,"open_issues_count":243,"forks":514,"open_issues":243,"watchers":630,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/frappe/frappe/pulls/3641"},"html":{"href":"https://github.com/frappe/frappe/pull/3641"},"issue":{"href":"https://api.github.com/repos/frappe/frappe/issues/3641"},"comments":{"href":"https://api.github.com/repos/frappe/frappe/issues/3641/comments"},"review_comments":{"href":"https://api.github.com/repos/frappe/frappe/pulls/3641/comments"},"review_comment":{"href":"https://api.github.com/repos/frappe/frappe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/frappe/frappe/pulls/3641/commits"},"statuses":{"href":"https://api.github.com/repos/frappe/frappe/statuses/adfba9f7270f3839f125b51edbf5f26b981c71de"}}}}
{"actor":{"display_login":"rmehta"}}