{"action":"created","issue":{"url":"https://api.github.com/repos/gophercloud/gophercloud/issues/413","repository_url":"https://api.github.com/repos/gophercloud/gophercloud","labels_url":"https://api.github.com/repos/gophercloud/gophercloud/issues/413/labels{/name}","comments_url":"https://api.github.com/repos/gophercloud/gophercloud/issues/413/comments","events_url":"https://api.github.com/repos/gophercloud/gophercloud/issues/413/events","html_url":"https://github.com/gophercloud/gophercloud/pull/413","id":243184940,"number":413,"title":"Add v3 and microversion support to cinder","user":{"login":"j-griffith","id":1231500,"avatar_url":"https://avatars6.githubusercontent.com/u/1231500?v=4","gravatar_id":"","url":"https://api.github.com/users/j-griffith","html_url":"https://github.com/j-griffith","followers_url":"https://api.github.com/users/j-griffith/followers","following_url":"https://api.github.com/users/j-griffith/following{/other_user}","gists_url":"https://api.github.com/users/j-griffith/gists{/gist_id}","starred_url":"https://api.github.com/users/j-griffith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-griffith/subscriptions","organizations_url":"https://api.github.com/users/j-griffith/orgs","repos_url":"https://api.github.com/users/j-griffith/repos","events_url":"https://api.github.com/users/j-griffith/events{/privacy}","received_events_url":"https://api.github.com/users/j-griffith/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-15T16:25:06Z","updated_at":"2017-07-15T16:30:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gophercloud/gophercloud/pulls/413","html_url":"https://github.com/gophercloud/gophercloud/pull/413","diff_url":"https://github.com/gophercloud/gophercloud/pull/413.diff","patch_url":"https://github.com/gophercloud/gophercloud/pull/413.patch"},"body":"This change pulls the existing V2 implementations into V3.  Note that\r\nthe base V3 version (3.0) is a direct map back to V2.  As a result to\r\nuse the base V3 endpoint for Cinder we can don't need to change anything\r\nother than the URL.  Also clean up some simple lint errors in\r\nrequests.go\r\n\r\nOne thing that the base V3 version does buy us here though is\r\nMicroversions (for better or worse).  So, this change also adds in the\r\nability to specify MicroVersion in the additional-header of the\r\nServiceClient.  This will be important going forward and so we can now\r\nadd things like the new standalone Attachment API.\r\n\r\nFor #412\r\n\r\nVolume V3 just points to V2 unless a microversioned call is issued:\r\n    https://github.com/openstack/cinder/blob/master/cinder/api/v3/volumes.py#L25\r\n    https://github.com/openstack/cinder/blob/master/cinder/api/v3/volumes.py#L50\r\n\r\nAn example of a micro versioned call (not implemented in gophercloud):\r\n    https://github.com/openstack/cinder/blob/master/cinder/api/v3/volumes.py#L212\r\n\r\nEven the base V3 view builder just utilizes V2 (only adding additional\r\ninfo for specific versions):\r\n    https://github.com/openstack/cinder/blob/master/cinder/api/v3/views/volumes.py#L19\r\n    https://github.com/openstack/cinder/blob/master/cinder/api/v3/views/snapshots.py#L19\r\n"},"comment":{"url":"https://api.github.com/repos/gophercloud/gophercloud/issues/comments/315545514","html_url":"https://github.com/gophercloud/gophercloud/pull/413#issuecomment-315545514","issue_url":"https://api.github.com/repos/gophercloud/gophercloud/issues/413","id":315545514,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars5.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-07-15T16:30:14Z","updated_at":"2017-07-15T16:30:14Z","body":"\n[![Coverage Status](https://coveralls.io/builds/12408346/badge)](https://coveralls.io/builds/12408346)\n\nCoverage decreased (-0.09%) to 70.943% when pulling **18dc2ad1c94ba541f7e43e3b7eb6674b76daa995 on j-griffith:add_v3_and_microversion_support_to_cinder** into **062f2739aef0b03a8e68cd94865c34d416d753e0 on gophercloud:master**.\n"}}
{"actor":{"display_login":"coveralls"}}