{"action":"created","issue":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/2580","repository_url":"https://api.github.com/repos/triplea-game/triplea","labels_url":"https://api.github.com/repos/triplea-game/triplea/issues/2580/labels{/name}","comments_url":"https://api.github.com/repos/triplea-game/triplea/issues/2580/comments","events_url":"https://api.github.com/repos/triplea-game/triplea/issues/2580/events","html_url":"https://github.com/triplea-game/triplea/pull/2580","id":272070684,"number":2580,"title":"Add new BackgroundTaskRunner method for Runnables","user":{"login":"ssoloff","id":4826349,"avatar_url":"https://avatars2.githubusercontent.com/u/4826349?v=4","gravatar_id":"","url":"https://api.github.com/users/ssoloff","html_url":"https://github.com/ssoloff","followers_url":"https://api.github.com/users/ssoloff/followers","following_url":"https://api.github.com/users/ssoloff/following{/other_user}","gists_url":"https://api.github.com/users/ssoloff/gists{/gist_id}","starred_url":"https://api.github.com/users/ssoloff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssoloff/subscriptions","organizations_url":"https://api.github.com/users/ssoloff/orgs","repos_url":"https://api.github.com/users/ssoloff/repos","events_url":"https://api.github.com/users/ssoloff/events{/privacy}","received_events_url":"https://api.github.com/users/ssoloff/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-08T04:23:38Z","updated_at":"2017-11-08T04:30:00Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/triplea-game/triplea/pulls/2580","html_url":"https://github.com/triplea-game/triplea/pull/2580","diff_url":"https://github.com/triplea-game/triplea/pull/2580.diff","patch_url":"https://github.com/triplea-game/triplea/pull/2580.patch"},"body":"This PR adds the new `BackgroundTaskRunner#runInBackground(String, Runnable)` method.  Callers that do not require a result from the background task can use this method instead of the method that accepts a `Supplier<T>` and having to return `null` (or some other artificial value).  All calls to `runInBackgroundAndReturn()` that did not use the return value were converted to call `runInBackground()` instead.\r\n\r\nI also renamed the `runInBackgroundAndReturnOrThrow()` method.  The `OrThrow` suffix was not necessary to distinguish this overload from the version that does not throw because they have parameter lists of different lengths (this wasn't the case when I originally added these methods, but I forgot to rename them at that time)."},"comment":{"url":"https://api.github.com/repos/triplea-game/triplea/issues/comments/342707803","html_url":"https://github.com/triplea-game/triplea/pull/2580#issuecomment-342707803","issue_url":"https://api.github.com/repos/triplea-game/triplea/issues/2580","id":342707803,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-11-08T04:30:00Z","updated_at":"2017-11-08T04:30:00Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/triplea-game/triplea/pull/2580?src=pr&el=h1) Report\n> Merging [#2580](https://codecov.io/gh/triplea-game/triplea/pull/2580?src=pr&el=desc) into [master](https://codecov.io/gh/triplea-game/triplea/commit/4899e8325ce2d963838010f801a8fe9a9a6688ae?src=pr&el=desc) will **decrease** coverage by `<.01%`.\n> The diff coverage is `0%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/triplea-game/triplea/pull/2580/graphs/tree.svg?width=650&height=150&src=pr&token=QPS14q4xnG)](https://codecov.io/gh/triplea-game/triplea/pull/2580?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master    #2580      +/-   ##\n============================================\n- Coverage     20.89%   20.89%   -0.01%     \n+ Complexity     5926     5924       -2     \n============================================\n  Files           834      834              \n  Lines         73360    73363       +3     \n  Branches      12337    12337              \n============================================\n- Hits          15328    15327       -1     \n- Misses        55878    55882       +4     \n  Partials       2154     2154\n```\n\n\n| [Impacted Files](https://codecov.io/gh/triplea-game/triplea/pull/2580?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [.../framework/ui/background/BackgroundTaskRunner.java](https://codecov.io/gh/triplea-game/triplea/pull/2580?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9nYW1lcy9zdHJhdGVneS9lbmdpbmUvZnJhbWV3b3JrL3VpL2JhY2tncm91bmQvQmFja2dyb3VuZFRhc2tSdW5uZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...strategy/engine/lobby/client/login/LobbyLogin.java](https://codecov.io/gh/triplea-game/triplea/pull/2580?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9nYW1lcy9zdHJhdGVneS9lbmdpbmUvbG9iYnkvY2xpZW50L2xvZ2luL0xvYmJ5TG9naW4uamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...engine/framework/startup/ui/GameSelectorPanel.java](https://codecov.io/gh/triplea-game/triplea/pull/2580?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9nYW1lcy9zdHJhdGVneS9lbmdpbmUvZnJhbWV3b3JrL3N0YXJ0dXAvdWkvR2FtZVNlbGVjdG9yUGFuZWwuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...va/games/strategy/engine/framework/GameRunner.java](https://codecov.io/gh/triplea-game/triplea/pull/2580?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9nYW1lcy9zdHJhdGVneS9lbmdpbmUvZnJhbWV3b3JrL0dhbWVSdW5uZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...ategy/triplea/oddsCalculator/ta/BattleResults.java](https://codecov.io/gh/triplea-game/triplea/pull/2580?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9nYW1lcy9zdHJhdGVneS90cmlwbGVhL29kZHNDYWxjdWxhdG9yL3RhL0JhdHRsZVJlc3VsdHMuamF2YQ==) | `52% <0%> (-4%)` | `9% <0%> (-2%)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/triplea-game/triplea/pull/2580?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/triplea-game/triplea/pull/2580?src=pr&el=footer). Last update [4899e83...a9a9bee](https://codecov.io/gh/triplea-game/triplea/pull/2580?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}