{"action":"created","issue":{"url":"https://api.github.com/repos/filoghost/HolographicDisplays/issues/52","repository_url":"https://api.github.com/repos/filoghost/HolographicDisplays","labels_url":"https://api.github.com/repos/filoghost/HolographicDisplays/issues/52/labels{/name}","comments_url":"https://api.github.com/repos/filoghost/HolographicDisplays/issues/52/comments","events_url":"https://api.github.com/repos/filoghost/HolographicDisplays/issues/52/events","html_url":"https://github.com/filoghost/HolographicDisplays/issues/52","id":207059676,"number":52,"title":"Make PluginHologramManager use HashSet","user":{"login":"MedicOP","id":18251099,"avatar_url":"https://avatars.githubusercontent.com/u/18251099?v=3","gravatar_id":"","url":"https://api.github.com/users/MedicOP","html_url":"https://github.com/MedicOP","followers_url":"https://api.github.com/users/MedicOP/followers","following_url":"https://api.github.com/users/MedicOP/following{/other_user}","gists_url":"https://api.github.com/users/MedicOP/gists{/gist_id}","starred_url":"https://api.github.com/users/MedicOP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MedicOP/subscriptions","organizations_url":"https://api.github.com/users/MedicOP/orgs","repos_url":"https://api.github.com/users/MedicOP/repos","events_url":"https://api.github.com/users/MedicOP/events{/privacy}","received_events_url":"https://api.github.com/users/MedicOP/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-02-12T16:07:17Z","updated_at":"2017-02-13T13:21:47Z","closed_at":null,"body":"Is there any reason why PluginHologramManager uses an ArrayList instead of a HashSet to store the PluginHolograms?\r\n\r\nWhen you have 5000+ holograms with new ones constantly being removed and created, the ArrayList becomes quite the bottleneck"},"comment":{"url":"https://api.github.com/repos/filoghost/HolographicDisplays/issues/comments/279390615","html_url":"https://github.com/filoghost/HolographicDisplays/issues/52#issuecomment-279390615","issue_url":"https://api.github.com/repos/filoghost/HolographicDisplays/issues/52","id":279390615,"user":{"login":"filoghost","id":3776612,"avatar_url":"https://avatars.githubusercontent.com/u/3776612?v=3","gravatar_id":"","url":"https://api.github.com/users/filoghost","html_url":"https://github.com/filoghost","followers_url":"https://api.github.com/users/filoghost/followers","following_url":"https://api.github.com/users/filoghost/following{/other_user}","gists_url":"https://api.github.com/users/filoghost/gists{/gist_id}","starred_url":"https://api.github.com/users/filoghost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filoghost/subscriptions","organizations_url":"https://api.github.com/users/filoghost/orgs","repos_url":"https://api.github.com/users/filoghost/repos","events_url":"https://api.github.com/users/filoghost/events{/privacy}","received_events_url":"https://api.github.com/users/filoghost/received_events","type":"User","site_admin":false},"created_at":"2017-02-13T13:21:47Z","updated_at":"2017-02-13T13:21:47Z","body":"Because I would have to iterate through the Set anyways, to check if each hologram is in a given chunk, and the Set is slower for iteration. The solution would be to use Map<ChunkCoords, List/Set<Hologram>>, with the map being updated when a hologram is moved to another chunk. Doing so would make adding/removing/iterating proportional to the # of holograms in the chunk, instead of the whole world."}}
{"actor":{"display_login":"filoghost"}}