{"action":"created","issue":{"url":"https://api.github.com/repos/neagle/gokibitz/issues/120","repository_url":"https://api.github.com/repos/neagle/gokibitz","labels_url":"https://api.github.com/repos/neagle/gokibitz/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/neagle/gokibitz/issues/120/comments","events_url":"https://api.github.com/repos/neagle/gokibitz/issues/120/events","html_url":"https://github.com/neagle/gokibitz/issues/120","id":148448163,"number":120,"title":"Show a \"Loading comment\" when you know there is a comment","user":{"login":"ajcsimons","id":6985666,"avatar_url":"https://avatars.githubusercontent.com/u/6985666?v=3","gravatar_id":"","url":"https://api.github.com/users/ajcsimons","html_url":"https://github.com/ajcsimons","followers_url":"https://api.github.com/users/ajcsimons/followers","following_url":"https://api.github.com/users/ajcsimons/following{/other_user}","gists_url":"https://api.github.com/users/ajcsimons/gists{/gist_id}","starred_url":"https://api.github.com/users/ajcsimons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajcsimons/subscriptions","organizations_url":"https://api.github.com/users/ajcsimons/orgs","repos_url":"https://api.github.com/users/ajcsimons/repos","events_url":"https://api.github.com/users/ajcsimons/events{/privacy}","received_events_url":"https://api.github.com/users/ajcsimons/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2016-04-14T18:42:03Z","updated_at":"2017-01-19T19:45:06Z","closed_at":"2017-01-19T18:18:23Z","body":"Someone linked me to your site, and I thought it was broken because the comments don't appear quickly enough if you whiz through the moves with right arrow navigation. From http://www.lifein19x19.com/forum/viewtopic.php?f=15&t=13082:\n\nSo the reason I couldn't see comments is because I followed the link, and then held down my right arrow key to whiz through the game and no comments appeared as the stones appeared on the board. That's because the comments are loaded asynchronously by ajax and take a long time to appear, by which time you've moved on to the next move (so you get loads of js errors). I suggest the developer stores a list of the moves with comments on first load (edit: it already has this as on move 0 it lists the moves with comments) so that when you whiz through it knows to display a \"Loading comment\" message on relevant moves (and not to issue the ajax request for comments immediately on moves the cache suggests have no comments (but have a small chance to have been commented since initial page load)), but wait a short time to reduce the request spam which is presumably why it is a lot slower to load comments after whizzing through moves that if you directly navigate to one with a fresh page request.\n"},"comment":{"url":"https://api.github.com/repos/neagle/gokibitz/issues/comments/273878002","html_url":"https://github.com/neagle/gokibitz/issues/120#issuecomment-273878002","issue_url":"https://api.github.com/repos/neagle/gokibitz/issues/120","id":273878002,"user":{"login":"popz73","id":12851952,"avatar_url":"https://avatars.githubusercontent.com/u/12851952?v=3","gravatar_id":"","url":"https://api.github.com/users/popz73","html_url":"https://github.com/popz73","followers_url":"https://api.github.com/users/popz73/followers","following_url":"https://api.github.com/users/popz73/following{/other_user}","gists_url":"https://api.github.com/users/popz73/gists{/gist_id}","starred_url":"https://api.github.com/users/popz73/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popz73/subscriptions","organizations_url":"https://api.github.com/users/popz73/orgs","repos_url":"https://api.github.com/users/popz73/repos","events_url":"https://api.github.com/users/popz73/events{/privacy}","received_events_url":"https://api.github.com/users/popz73/received_events","type":"User","site_admin":false},"created_at":"2017-01-19T19:45:06Z","updated_at":"2017-01-19T19:45:06Z","body":"Hi! Thanks, but this doesn't help - now what we is have an animation on *every move* for <x>ms until we know the result of the fetch (until we know if there are comments or not).\r\nFor slow/far connections (like mine), it actually makes the game browsing experience much busier/distracting.\r\n\r\nWhen browsing through a game, the feedback of the stones is immediate - the info of \"comment/no comment\" should be too. The idea here (or at least my idea, and my understanding of the opening comment) would be to have this immediate loading indicator *only for moves that contain comments* - for the other ones, nothing will be shown.\r\nThis is what will allow us to browse the game and be alerted when actual comments are being loaded, so we don't miss them. If we're alerted *all the time* as we are today, it just becomes a nuisance.\r\n\r\nAt first load, the \"list of moves with comments\" should be stored, and those would be the only moves where the loading indicator would be shown. If you want to be perfect and trigger the loading comment for \"live\" (written after the first load), this list could be refreshed periodically in the background. \r\nBut that part wouldn't be that important, it would be only to cover a very small percentage of cases. "}}
{"actor":{"display_login":"popz73"}}