{"action":"created","issue":{"url":"https://api.github.com/repos/Appboy/appboy-android-sdk/issues/69","repository_url":"https://api.github.com/repos/Appboy/appboy-android-sdk","labels_url":"https://api.github.com/repos/Appboy/appboy-android-sdk/issues/69/labels{/name}","comments_url":"https://api.github.com/repos/Appboy/appboy-android-sdk/issues/69/comments","events_url":"https://api.github.com/repos/Appboy/appboy-android-sdk/issues/69/events","html_url":"https://github.com/Appboy/appboy-android-sdk/pull/69","id":198749187,"number":69,"title":"ProGuard: Replace -dontoptimize with -keep rules","user":{"login":"mnonnenmacher","id":2741977,"avatar_url":"https://avatars.githubusercontent.com/u/2741977?v=3","gravatar_id":"","url":"https://api.github.com/users/mnonnenmacher","html_url":"https://github.com/mnonnenmacher","followers_url":"https://api.github.com/users/mnonnenmacher/followers","following_url":"https://api.github.com/users/mnonnenmacher/following{/other_user}","gists_url":"https://api.github.com/users/mnonnenmacher/gists{/gist_id}","starred_url":"https://api.github.com/users/mnonnenmacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnonnenmacher/subscriptions","organizations_url":"https://api.github.com/users/mnonnenmacher/orgs","repos_url":"https://api.github.com/users/mnonnenmacher/repos","events_url":"https://api.github.com/users/mnonnenmacher/events{/privacy}","received_events_url":"https://api.github.com/users/mnonnenmacher/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-01-04T16:27:12Z","updated_at":"2017-01-05T22:29:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Appboy/appboy-android-sdk/pulls/69","html_url":"https://github.com/Appboy/appboy-android-sdk/pull/69","diff_url":"https://github.com/Appboy/appboy-android-sdk/pull/69.diff","patch_url":"https://github.com/Appboy/appboy-android-sdk/pull/69.patch"},"body":"Using -dontoptimize disables ProGuard optimization for all users of this\r\nlibrary. Instead configure keep rules to keep the classes from\r\ncom.appboy.ui and com.appboy.services.\r\n\r\nThis a very severe issue because in the project I'm currently working on we rely on ProGuard optimization for several reasons. Without -dontoptimize we had the same issue as in https://github.com/Appboy/appboy-android-sdk/issues/49 but the added keep rules fixed this."},"comment":{"url":"https://api.github.com/repos/Appboy/appboy-android-sdk/issues/comments/270776621","html_url":"https://github.com/Appboy/appboy-android-sdk/pull/69#issuecomment-270776621","issue_url":"https://api.github.com/repos/Appboy/appboy-android-sdk/issues/69","id":270776621,"user":{"login":"Bucimis","id":1174698,"avatar_url":"https://avatars.githubusercontent.com/u/1174698?v=3","gravatar_id":"","url":"https://api.github.com/users/Bucimis","html_url":"https://github.com/Bucimis","followers_url":"https://api.github.com/users/Bucimis/followers","following_url":"https://api.github.com/users/Bucimis/following{/other_user}","gists_url":"https://api.github.com/users/Bucimis/gists{/gist_id}","starred_url":"https://api.github.com/users/Bucimis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bucimis/subscriptions","organizations_url":"https://api.github.com/users/Bucimis/orgs","repos_url":"https://api.github.com/users/Bucimis/repos","events_url":"https://api.github.com/users/Bucimis/events{/privacy}","received_events_url":"https://api.github.com/users/Bucimis/received_events","type":"User","site_admin":false},"created_at":"2017-01-05T22:29:51Z","updated_at":"2017-01-05T22:29:51Z","body":"@mnonnenmacher Sounds good to us - we'll merge this pr now.  Note that aars with the new proguard config won't be available in maven until after our next release - you may need to use a forked version until then.\r\n\r\nUsers who optimize should see a decrease in their output apk size as a result of this change.\r\n\r\nThanks for submitting the pull request!\r\n\r\nCheers,\r\nJared"}}
{"actor":{"display_login":"Bucimis"}}