{"action":"created","issue":{"url":"https://api.github.com/repos/GrahamCampbell/Laravel-Manager/issues/8","repository_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Manager","labels_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Manager/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Manager/issues/8/comments","events_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Manager/issues/8/events","html_url":"https://github.com/GrahamCampbell/Laravel-Manager/issues/8","id":252752432,"number":8,"title":"Unable to test facade when class extends AbstractManager","user":{"login":"brandonferens","id":1819546,"avatar_url":"https://avatars2.githubusercontent.com/u/1819546?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonferens","html_url":"https://github.com/brandonferens","followers_url":"https://api.github.com/users/brandonferens/followers","following_url":"https://api.github.com/users/brandonferens/following{/other_user}","gists_url":"https://api.github.com/users/brandonferens/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonferens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonferens/subscriptions","organizations_url":"https://api.github.com/users/brandonferens/orgs","repos_url":"https://api.github.com/users/brandonferens/repos","events_url":"https://api.github.com/users/brandonferens/events{/privacy}","received_events_url":"https://api.github.com/users/brandonferens/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-24T22:47:00Z","updated_at":"2017-08-28T16:33:57Z","closed_at":"2017-08-25T19:51:36Z","body":"Hey Graham,\r\nI am currently attempting to write some tests revolving around Vimeo upload functionality. I am using vinkla/laravel-vimeo to accomplish this. During my tests I am attempting to mock the Vimeo facade. The VimeoManger that the facade delivers extends your AbstractManager class. The issue ultimately comes down to the fact that the Mock class expects the `__call()` method's signature to to be the same.\r\n\r\nI have a feeling most classes that use facades don't implement that magic method, so it generally isn't a problem.\r\n\r\nThe mock class expects the signature:\r\n`__call($method, array $args)`\r\n\r\nwhereas AbstractManager has:\r\n`__call(string $method, array $parameters)`\r\n\r\nAttempting to override your method within the VimeoManager doesn't work. However, simply updating your `__call()` method does. I'm curious if I can create a pull request to literally just change out the signature? I don't see how this would affect any functionality of the method.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/GrahamCampbell/Laravel-Manager/issues/comments/325404862","html_url":"https://github.com/GrahamCampbell/Laravel-Manager/issues/8#issuecomment-325404862","issue_url":"https://api.github.com/repos/GrahamCampbell/Laravel-Manager/issues/8","id":325404862,"user":{"login":"brandonferens","id":1819546,"avatar_url":"https://avatars2.githubusercontent.com/u/1819546?v=4","gravatar_id":"","url":"https://api.github.com/users/brandonferens","html_url":"https://github.com/brandonferens","followers_url":"https://api.github.com/users/brandonferens/followers","following_url":"https://api.github.com/users/brandonferens/following{/other_user}","gists_url":"https://api.github.com/users/brandonferens/gists{/gist_id}","starred_url":"https://api.github.com/users/brandonferens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandonferens/subscriptions","organizations_url":"https://api.github.com/users/brandonferens/orgs","repos_url":"https://api.github.com/users/brandonferens/repos","events_url":"https://api.github.com/users/brandonferens/events{/privacy}","received_events_url":"https://api.github.com/users/brandonferens/received_events","type":"User","site_admin":false},"created_at":"2017-08-28T16:33:57Z","updated_at":"2017-08-28T16:33:57Z","body":"Yep, that did the trick. Thanks @GrahamCampbell "}}
{"actor":{"display_login":"brandonferens"}}