{"action":"created","comment":{"url":"https://api.github.com/repos/switchboardpy/switchboard/pulls/comments/94458990","pull_request_review_id":14986719,"id":94458990,"diff_hunk":"@@ -36,44 +52,54 @@ def set_values(self, name):\n         if name and not self.label:\n             self.label = titlize(name)\n \n-    def is_active(self, condition, value):\n-        return condition == value\n+    def is_active(self, value, actual_value):\n+        return value == actual_value\n \n     def validate(self, data):\n         value = data.get(self.name)\n         if value:\n             value = self.clean(value)\n-            assert isinstance(value, basestring), 'clean methods must return strings'\n+            is_string = isinstance(value, basestring)\n+            assert is_string, 'clean methods must return strings'\n         return value\n \n-    def clean(self, value):\n+    def clean(self, value):  # pragma: nocover","path":"switchboard/conditions.py","position":55,"original_position":55,"commit_id":"bba201226a165c9ae1dd70991aedccdecc9e95d3","original_commit_id":"bba201226a165c9ae1dd70991aedccdecc9e95d3","user":{"login":"kadams54","id":378036,"avatar_url":"https://avatars.githubusercontent.com/u/378036?v=3","gravatar_id":"","url":"https://api.github.com/users/kadams54","html_url":"https://github.com/kadams54","followers_url":"https://api.github.com/users/kadams54/followers","following_url":"https://api.github.com/users/kadams54/following{/other_user}","gists_url":"https://api.github.com/users/kadams54/gists{/gist_id}","starred_url":"https://api.github.com/users/kadams54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadams54/subscriptions","organizations_url":"https://api.github.com/users/kadams54/orgs","repos_url":"https://api.github.com/users/kadams54/repos","events_url":"https://api.github.com/users/kadams54/events{/privacy}","received_events_url":"https://api.github.com/users/kadams54/received_events","type":"User","site_admin":false},"body":"Per my comment above... I think 100% code coverage is more accurate than 98%, when the remaining 2% are class definitions that consist entirely of `pass` or functions that exist just to define an API (e.g., subclasses are expected to implement the real logic).","created_at":"2017-01-03T18:46:16Z","updated_at":"2017-01-03T18:46:17Z","html_url":"https://github.com/switchboardpy/switchboard/pull/51#discussion_r94458990","pull_request_url":"https://api.github.com/repos/switchboardpy/switchboard/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/switchboardpy/switchboard/pulls/comments/94458990"},"html":{"href":"https://github.com/switchboardpy/switchboard/pull/51#discussion_r94458990"},"pull_request":{"href":"https://api.github.com/repos/switchboardpy/switchboard/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/switchboardpy/switchboard/pulls/51","id":99482995,"html_url":"https://github.com/switchboardpy/switchboard/pull/51","diff_url":"https://github.com/switchboardpy/switchboard/pull/51.diff","patch_url":"https://github.com/switchboardpy/switchboard/pull/51.patch","issue_url":"https://api.github.com/repos/switchboardpy/switchboard/issues/51","number":51,"state":"open","locked":false,"title":"WIP - Moar test coverage","user":{"login":"kadams54","id":378036,"avatar_url":"https://avatars.githubusercontent.com/u/378036?v=3","gravatar_id":"","url":"https://api.github.com/users/kadams54","html_url":"https://github.com/kadams54","followers_url":"https://api.github.com/users/kadams54/followers","following_url":"https://api.github.com/users/kadams54/following{/other_user}","gists_url":"https://api.github.com/users/kadams54/gists{/gist_id}","starred_url":"https://api.github.com/users/kadams54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadams54/subscriptions","organizations_url":"https://api.github.com/users/kadams54/orgs","repos_url":"https://api.github.com/users/kadams54/repos","events_url":"https://api.github.com/users/kadams54/events{/privacy}","received_events_url":"https://api.github.com/users/kadams54/received_events","type":"User","site_admin":false},"body":"Fixes #48.\r\n\r\nWork in progress branch in order to get feedback from Codecov.","created_at":"2016-12-27T20:58:58Z","updated_at":"2017-01-03T18:46:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d019a5d3674d1f549a0050ec8140c2ef49c07889","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/switchboardpy/switchboard/pulls/51/commits","review_comments_url":"https://api.github.com/repos/switchboardpy/switchboard/pulls/51/comments","review_comment_url":"https://api.github.com/repos/switchboardpy/switchboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/switchboardpy/switchboard/issues/51/comments","statuses_url":"https://api.github.com/repos/switchboardpy/switchboard/statuses/bba201226a165c9ae1dd70991aedccdecc9e95d3","head":{"label":"kadams54:moar-test-coverage","ref":"moar-test-coverage","sha":"bba201226a165c9ae1dd70991aedccdecc9e95d3","user":{"login":"kadams54","id":378036,"avatar_url":"https://avatars.githubusercontent.com/u/378036?v=3","gravatar_id":"","url":"https://api.github.com/users/kadams54","html_url":"https://github.com/kadams54","followers_url":"https://api.github.com/users/kadams54/followers","following_url":"https://api.github.com/users/kadams54/following{/other_user}","gists_url":"https://api.github.com/users/kadams54/gists{/gist_id}","starred_url":"https://api.github.com/users/kadams54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadams54/subscriptions","organizations_url":"https://api.github.com/users/kadams54/orgs","repos_url":"https://api.github.com/users/kadams54/repos","events_url":"https://api.github.com/users/kadams54/events{/privacy}","received_events_url":"https://api.github.com/users/kadams54/received_events","type":"User","site_admin":false},"repo":{"id":27505272,"name":"switchboard","full_name":"kadams54/switchboard","owner":{"login":"kadams54","id":378036,"avatar_url":"https://avatars.githubusercontent.com/u/378036?v=3","gravatar_id":"","url":"https://api.github.com/users/kadams54","html_url":"https://github.com/kadams54","followers_url":"https://api.github.com/users/kadams54/followers","following_url":"https://api.github.com/users/kadams54/following{/other_user}","gists_url":"https://api.github.com/users/kadams54/gists{/gist_id}","starred_url":"https://api.github.com/users/kadams54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kadams54/subscriptions","organizations_url":"https://api.github.com/users/kadams54/orgs","repos_url":"https://api.github.com/users/kadams54/repos","events_url":"https://api.github.com/users/kadams54/events{/privacy}","received_events_url":"https://api.github.com/users/kadams54/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kadams54/switchboard","description":"The main feature flipper library and web admin application.","fork":true,"url":"https://api.github.com/repos/kadams54/switchboard","forks_url":"https://api.github.com/repos/kadams54/switchboard/forks","keys_url":"https://api.github.com/repos/kadams54/switchboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kadams54/switchboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kadams54/switchboard/teams","hooks_url":"https://api.github.com/repos/kadams54/switchboard/hooks","issue_events_url":"https://api.github.com/repos/kadams54/switchboard/issues/events{/number}","events_url":"https://api.github.com/repos/kadams54/switchboard/events","assignees_url":"https://api.github.com/repos/kadams54/switchboard/assignees{/user}","branches_url":"https://api.github.com/repos/kadams54/switchboard/branches{/branch}","tags_url":"https://api.github.com/repos/kadams54/switchboard/tags","blobs_url":"https://api.github.com/repos/kadams54/switchboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kadams54/switchboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kadams54/switchboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/kadams54/switchboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kadams54/switchboard/statuses/{sha}","languages_url":"https://api.github.com/repos/kadams54/switchboard/languages","stargazers_url":"https://api.github.com/repos/kadams54/switchboard/stargazers","contributors_url":"https://api.github.com/repos/kadams54/switchboard/contributors","subscribers_url":"https://api.github.com/repos/kadams54/switchboard/subscribers","subscription_url":"https://api.github.com/repos/kadams54/switchboard/subscription","commits_url":"https://api.github.com/repos/kadams54/switchboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/kadams54/switchboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/kadams54/switchboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/kadams54/switchboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/kadams54/switchboard/contents/{+path}","compare_url":"https://api.github.com/repos/kadams54/switchboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kadams54/switchboard/merges","archive_url":"https://api.github.com/repos/kadams54/switchboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kadams54/switchboard/downloads","issues_url":"https://api.github.com/repos/kadams54/switchboard/issues{/number}","pulls_url":"https://api.github.com/repos/kadams54/switchboard/pulls{/number}","milestones_url":"https://api.github.com/repos/kadams54/switchboard/milestones{/number}","notifications_url":"https://api.github.com/repos/kadams54/switchboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kadams54/switchboard/labels{/name}","releases_url":"https://api.github.com/repos/kadams54/switchboard/releases{/id}","deployments_url":"https://api.github.com/repos/kadams54/switchboard/deployments","created_at":"2014-12-03T20:04:48Z","updated_at":"2016-11-01T13:28:09Z","pushed_at":"2017-01-03T15:28:11Z","git_url":"git://github.com/kadams54/switchboard.git","ssh_url":"git@github.com:kadams54/switchboard.git","clone_url":"https://github.com/kadams54/switchboard.git","svn_url":"https://github.com/kadams54/switchboard","homepage":null,"size":324,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"switchboardpy:master","ref":"master","sha":"0ef5610badb22f67fb0707af8db7aa0478f12c5d","user":{"login":"switchboardpy","id":10028618,"avatar_url":"https://avatars.githubusercontent.com/u/10028618?v=3","gravatar_id":"","url":"https://api.github.com/users/switchboardpy","html_url":"https://github.com/switchboardpy","followers_url":"https://api.github.com/users/switchboardpy/followers","following_url":"https://api.github.com/users/switchboardpy/following{/other_user}","gists_url":"https://api.github.com/users/switchboardpy/gists{/gist_id}","starred_url":"https://api.github.com/users/switchboardpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/switchboardpy/subscriptions","organizations_url":"https://api.github.com/users/switchboardpy/orgs","repos_url":"https://api.github.com/users/switchboardpy/repos","events_url":"https://api.github.com/users/switchboardpy/events{/privacy}","received_events_url":"https://api.github.com/users/switchboardpy/received_events","type":"Organization","site_admin":false},"repo":{"id":27382363,"name":"switchboard","full_name":"switchboardpy/switchboard","owner":{"login":"switchboardpy","id":10028618,"avatar_url":"https://avatars.githubusercontent.com/u/10028618?v=3","gravatar_id":"","url":"https://api.github.com/users/switchboardpy","html_url":"https://github.com/switchboardpy","followers_url":"https://api.github.com/users/switchboardpy/followers","following_url":"https://api.github.com/users/switchboardpy/following{/other_user}","gists_url":"https://api.github.com/users/switchboardpy/gists{/gist_id}","starred_url":"https://api.github.com/users/switchboardpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/switchboardpy/subscriptions","organizations_url":"https://api.github.com/users/switchboardpy/orgs","repos_url":"https://api.github.com/users/switchboardpy/repos","events_url":"https://api.github.com/users/switchboardpy/events{/privacy}","received_events_url":"https://api.github.com/users/switchboardpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/switchboardpy/switchboard","description":"The main feature flipper library and web admin application.","fork":false,"url":"https://api.github.com/repos/switchboardpy/switchboard","forks_url":"https://api.github.com/repos/switchboardpy/switchboard/forks","keys_url":"https://api.github.com/repos/switchboardpy/switchboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/switchboardpy/switchboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/switchboardpy/switchboard/teams","hooks_url":"https://api.github.com/repos/switchboardpy/switchboard/hooks","issue_events_url":"https://api.github.com/repos/switchboardpy/switchboard/issues/events{/number}","events_url":"https://api.github.com/repos/switchboardpy/switchboard/events","assignees_url":"https://api.github.com/repos/switchboardpy/switchboard/assignees{/user}","branches_url":"https://api.github.com/repos/switchboardpy/switchboard/branches{/branch}","tags_url":"https://api.github.com/repos/switchboardpy/switchboard/tags","blobs_url":"https://api.github.com/repos/switchboardpy/switchboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/switchboardpy/switchboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/switchboardpy/switchboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/switchboardpy/switchboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/switchboardpy/switchboard/statuses/{sha}","languages_url":"https://api.github.com/repos/switchboardpy/switchboard/languages","stargazers_url":"https://api.github.com/repos/switchboardpy/switchboard/stargazers","contributors_url":"https://api.github.com/repos/switchboardpy/switchboard/contributors","subscribers_url":"https://api.github.com/repos/switchboardpy/switchboard/subscribers","subscription_url":"https://api.github.com/repos/switchboardpy/switchboard/subscription","commits_url":"https://api.github.com/repos/switchboardpy/switchboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/switchboardpy/switchboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/switchboardpy/switchboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/switchboardpy/switchboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/switchboardpy/switchboard/contents/{+path}","compare_url":"https://api.github.com/repos/switchboardpy/switchboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/switchboardpy/switchboard/merges","archive_url":"https://api.github.com/repos/switchboardpy/switchboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/switchboardpy/switchboard/downloads","issues_url":"https://api.github.com/repos/switchboardpy/switchboard/issues{/number}","pulls_url":"https://api.github.com/repos/switchboardpy/switchboard/pulls{/number}","milestones_url":"https://api.github.com/repos/switchboardpy/switchboard/milestones{/number}","notifications_url":"https://api.github.com/repos/switchboardpy/switchboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/switchboardpy/switchboard/labels{/name}","releases_url":"https://api.github.com/repos/switchboardpy/switchboard/releases{/id}","deployments_url":"https://api.github.com/repos/switchboardpy/switchboard/deployments","created_at":"2014-12-01T14:11:50Z","updated_at":"2016-11-04T07:04:02Z","pushed_at":"2017-01-03T15:28:13Z","git_url":"git://github.com/switchboardpy/switchboard.git","ssh_url":"git@github.com:switchboardpy/switchboard.git","clone_url":"https://github.com/switchboardpy/switchboard.git","svn_url":"https://github.com/switchboardpy/switchboard","homepage":null,"size":246,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":18,"forks":4,"open_issues":18,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/switchboardpy/switchboard/pulls/51"},"html":{"href":"https://github.com/switchboardpy/switchboard/pull/51"},"issue":{"href":"https://api.github.com/repos/switchboardpy/switchboard/issues/51"},"comments":{"href":"https://api.github.com/repos/switchboardpy/switchboard/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/switchboardpy/switchboard/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/switchboardpy/switchboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/switchboardpy/switchboard/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/switchboardpy/switchboard/statuses/bba201226a165c9ae1dd70991aedccdecc9e95d3"}}}}
{"actor":{"display_login":"kadams54"}}