{"action":"created","comment":{"url":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls/comments/125992645","pull_request_review_id":48437407,"id":125992645,"diff_hunk":"@@ -166,6 +166,10 @@ protected void previewParameters(ParametersHolder parameters) {\n                         && isEmpty(wellKnownConfig.getNetworkAuthenticationTargetUrls()))) {\n                     parameters.add(\"login_hint\", String.format(\"MCCMNC:%s\", mccMnc));\n         }\n+\n+        if (!ConnectSdk.isCellularDataNetworkConnected()) {","path":"connect/src/com/telenor/connect/AbstractSdkProfile.java","position":5,"original_position":5,"commit_id":"0a9c650840ee00257db369f85b61cab867d33fef","original_commit_id":"0a9c650840ee00257db369f85b61cab867d33fef","user":{"login":"gorandostanic","id":27007202,"avatar_url":"https://avatars3.githubusercontent.com/u/27007202?v=3","gravatar_id":"","url":"https://api.github.com/users/gorandostanic","html_url":"https://github.com/gorandostanic","followers_url":"https://api.github.com/users/gorandostanic/followers","following_url":"https://api.github.com/users/gorandostanic/following{/other_user}","gists_url":"https://api.github.com/users/gorandostanic/gists{/gist_id}","starred_url":"https://api.github.com/users/gorandostanic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorandostanic/subscriptions","organizations_url":"https://api.github.com/users/gorandostanic/orgs","repos_url":"https://api.github.com/users/gorandostanic/repos","events_url":"https://api.github.com/users/gorandostanic/events{/privacy}","received_events_url":"https://api.github.com/users/gorandostanic/received_events","type":"User","site_admin":false},"body":"To be honest, I'd prefer if you got rid of the Wi-Fi thing in the force-HE patch as well. I think you don't need it. Correct me if i am wrong, but I think the only thing you have to care about is the availability of the cellular network. If it is available, and if it is default, then you are lucky because you don't have to do anything. If it is not default, you force HE. In all other cases you do nothing. For example, I think there is an obvious bug in the current force-HE caused by taking into the equation a dependency which naturally isn't there. For example, if a phone is tethered via Bluetooth or otherwise, your wifi callback wouldn't fire => the app wouldn't behave as devised, would it? ","created_at":"2017-07-06T19:21:47Z","updated_at":"2017-07-06T19:21:47Z","html_url":"https://github.com/telenordigital/connect-android-sdk/pull/66#discussion_r125992645","pull_request_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls/comments/125992645"},"html":{"href":"https://github.com/telenordigital/connect-android-sdk/pull/66#discussion_r125992645"},"pull_request":{"href":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls/66","id":129189860,"html_url":"https://github.com/telenordigital/connect-android-sdk/pull/66","diff_url":"https://github.com/telenordigital/connect-android-sdk/pull/66.diff","patch_url":"https://github.com/telenordigital/connect-android-sdk/pull/66.patch","issue_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/issues/66","number":66,"state":"open","locked":false,"title":"Fix the hotspot issue in the Android SDK","user":{"login":"gorandostanic","id":27007202,"avatar_url":"https://avatars3.githubusercontent.com/u/27007202?v=3","gravatar_id":"","url":"https://api.github.com/users/gorandostanic","html_url":"https://github.com/gorandostanic","followers_url":"https://api.github.com/users/gorandostanic/followers","following_url":"https://api.github.com/users/gorandostanic/following{/other_user}","gists_url":"https://api.github.com/users/gorandostanic/gists{/gist_id}","starred_url":"https://api.github.com/users/gorandostanic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gorandostanic/subscriptions","organizations_url":"https://api.github.com/users/gorandostanic/orgs","repos_url":"https://api.github.com/users/gorandostanic/repos","events_url":"https://api.github.com/users/gorandostanic/events{/privacy}","received_events_url":"https://api.github.com/users/gorandostanic/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-06T13:48:08Z","updated_at":"2017-07-06T19:21:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c518dd0b272ddaca70714365157bee9461c8b52","assignee":null,"assignees":[],"requested_reviewers":[{"login":"phyrex1an","id":204677,"avatar_url":"https://avatars1.githubusercontent.com/u/204677?v=3","gravatar_id":"","url":"https://api.github.com/users/phyrex1an","html_url":"https://github.com/phyrex1an","followers_url":"https://api.github.com/users/phyrex1an/followers","following_url":"https://api.github.com/users/phyrex1an/following{/other_user}","gists_url":"https://api.github.com/users/phyrex1an/gists{/gist_id}","starred_url":"https://api.github.com/users/phyrex1an/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phyrex1an/subscriptions","organizations_url":"https://api.github.com/users/phyrex1an/orgs","repos_url":"https://api.github.com/users/phyrex1an/repos","events_url":"https://api.github.com/users/phyrex1an/events{/privacy}","received_events_url":"https://api.github.com/users/phyrex1an/received_events","type":"User","site_admin":false},{"login":"DidierParat","id":25526011,"avatar_url":"https://avatars2.githubusercontent.com/u/25526011?v=3","gravatar_id":"","url":"https://api.github.com/users/DidierParat","html_url":"https://github.com/DidierParat","followers_url":"https://api.github.com/users/DidierParat/followers","following_url":"https://api.github.com/users/DidierParat/following{/other_user}","gists_url":"https://api.github.com/users/DidierParat/gists{/gist_id}","starred_url":"https://api.github.com/users/DidierParat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DidierParat/subscriptions","organizations_url":"https://api.github.com/users/DidierParat/orgs","repos_url":"https://api.github.com/users/DidierParat/repos","events_url":"https://api.github.com/users/DidierParat/events{/privacy}","received_events_url":"https://api.github.com/users/DidierParat/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls/66/commits","review_comments_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls/66/comments","review_comment_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/issues/66/comments","statuses_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/statuses/0a9c650840ee00257db369f85b61cab867d33fef","head":{"label":"telenordigital:MC-1658-hotspot-issue-fix","ref":"MC-1658-hotspot-issue-fix","sha":"0a9c650840ee00257db369f85b61cab867d33fef","user":{"login":"telenordigital","id":14310842,"avatar_url":"https://avatars3.githubusercontent.com/u/14310842?v=3","gravatar_id":"","url":"https://api.github.com/users/telenordigital","html_url":"https://github.com/telenordigital","followers_url":"https://api.github.com/users/telenordigital/followers","following_url":"https://api.github.com/users/telenordigital/following{/other_user}","gists_url":"https://api.github.com/users/telenordigital/gists{/gist_id}","starred_url":"https://api.github.com/users/telenordigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telenordigital/subscriptions","organizations_url":"https://api.github.com/users/telenordigital/orgs","repos_url":"https://api.github.com/users/telenordigital/repos","events_url":"https://api.github.com/users/telenordigital/events{/privacy}","received_events_url":"https://api.github.com/users/telenordigital/received_events","type":"Organization","site_admin":false},"repo":{"id":52869089,"name":"connect-android-sdk","full_name":"telenordigital/connect-android-sdk","owner":{"login":"telenordigital","id":14310842,"avatar_url":"https://avatars3.githubusercontent.com/u/14310842?v=3","gravatar_id":"","url":"https://api.github.com/users/telenordigital","html_url":"https://github.com/telenordigital","followers_url":"https://api.github.com/users/telenordigital/followers","following_url":"https://api.github.com/users/telenordigital/following{/other_user}","gists_url":"https://api.github.com/users/telenordigital/gists{/gist_id}","starred_url":"https://api.github.com/users/telenordigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telenordigital/subscriptions","organizations_url":"https://api.github.com/users/telenordigital/orgs","repos_url":"https://api.github.com/users/telenordigital/repos","events_url":"https://api.github.com/users/telenordigital/events{/privacy}","received_events_url":"https://api.github.com/users/telenordigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telenordigital/connect-android-sdk","description":"Android SDK for Telenor Connect","fork":false,"url":"https://api.github.com/repos/telenordigital/connect-android-sdk","forks_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/forks","keys_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/teams","hooks_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/events","assignees_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/tags","blobs_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/languages","stargazers_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/subscription","commits_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/merges","archive_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/downloads","issues_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/deployments","created_at":"2016-03-01T10:37:38Z","updated_at":"2017-01-27T10:48:49Z","pushed_at":"2017-07-06T13:48:09Z","git_url":"git://github.com/telenordigital/connect-android-sdk.git","ssh_url":"git@github.com:telenordigital/connect-android-sdk.git","clone_url":"https://github.com/telenordigital/connect-android-sdk.git","svn_url":"https://github.com/telenordigital/connect-android-sdk","homepage":"http://docs.telenordigital.com/connect/","size":773,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":6,"default_branch":"master"}},"base":{"label":"telenordigital:MC-1595-operator-selection","ref":"MC-1595-operator-selection","sha":"e9744a443f869f1921da9f4ba2d003dc3465a93a","user":{"login":"telenordigital","id":14310842,"avatar_url":"https://avatars3.githubusercontent.com/u/14310842?v=3","gravatar_id":"","url":"https://api.github.com/users/telenordigital","html_url":"https://github.com/telenordigital","followers_url":"https://api.github.com/users/telenordigital/followers","following_url":"https://api.github.com/users/telenordigital/following{/other_user}","gists_url":"https://api.github.com/users/telenordigital/gists{/gist_id}","starred_url":"https://api.github.com/users/telenordigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telenordigital/subscriptions","organizations_url":"https://api.github.com/users/telenordigital/orgs","repos_url":"https://api.github.com/users/telenordigital/repos","events_url":"https://api.github.com/users/telenordigital/events{/privacy}","received_events_url":"https://api.github.com/users/telenordigital/received_events","type":"Organization","site_admin":false},"repo":{"id":52869089,"name":"connect-android-sdk","full_name":"telenordigital/connect-android-sdk","owner":{"login":"telenordigital","id":14310842,"avatar_url":"https://avatars3.githubusercontent.com/u/14310842?v=3","gravatar_id":"","url":"https://api.github.com/users/telenordigital","html_url":"https://github.com/telenordigital","followers_url":"https://api.github.com/users/telenordigital/followers","following_url":"https://api.github.com/users/telenordigital/following{/other_user}","gists_url":"https://api.github.com/users/telenordigital/gists{/gist_id}","starred_url":"https://api.github.com/users/telenordigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/telenordigital/subscriptions","organizations_url":"https://api.github.com/users/telenordigital/orgs","repos_url":"https://api.github.com/users/telenordigital/repos","events_url":"https://api.github.com/users/telenordigital/events{/privacy}","received_events_url":"https://api.github.com/users/telenordigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/telenordigital/connect-android-sdk","description":"Android SDK for Telenor Connect","fork":false,"url":"https://api.github.com/repos/telenordigital/connect-android-sdk","forks_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/forks","keys_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/teams","hooks_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/hooks","issue_events_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/events","assignees_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/tags","blobs_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/languages","stargazers_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/stargazers","contributors_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/contributors","subscribers_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/subscribers","subscription_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/subscription","commits_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/merges","archive_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/downloads","issues_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/labels{/name}","releases_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/telenordigital/connect-android-sdk/deployments","created_at":"2016-03-01T10:37:38Z","updated_at":"2017-01-27T10:48:49Z","pushed_at":"2017-07-06T13:48:09Z","git_url":"git://github.com/telenordigital/connect-android-sdk.git","ssh_url":"git@github.com:telenordigital/connect-android-sdk.git","clone_url":"https://github.com/telenordigital/connect-android-sdk.git","svn_url":"https://github.com/telenordigital/connect-android-sdk","homepage":"http://docs.telenordigital.com/connect/","size":773,"stargazers_count":6,"watchers_count":6,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":6,"forks":7,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls/66"},"html":{"href":"https://github.com/telenordigital/connect-android-sdk/pull/66"},"issue":{"href":"https://api.github.com/repos/telenordigital/connect-android-sdk/issues/66"},"comments":{"href":"https://api.github.com/repos/telenordigital/connect-android-sdk/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/telenordigital/connect-android-sdk/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/telenordigital/connect-android-sdk/statuses/0a9c650840ee00257db369f85b61cab867d33fef"}}}}
{"actor":{"display_login":"gorandostanic"}}