{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/112849921","pull_request_review_id":34194645,"id":112849921,"diff_hunk":"@@ -80,6 +80,7 @@\n #include <stdlib.h>\n #include <string.h>\n #include <sys/types.h>\n+#include <fcntl.h>","path":"src/node.cc","position":4,"original_position":4,"commit_id":"8c340364745615df5903db0d5113768c14615b9f","original_commit_id":"8c340364745615df5903db0d5113768c14615b9f","user":{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars1.githubusercontent.com/u/1538624?v=3","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false},"body":"Can you please maintain the alphabetical order? A comment detailing what macro is used like above for `PATH_MAX` would be helpful too.","created_at":"2017-04-24T00:50:27Z","updated_at":"2017-04-24T00:50:27Z","html_url":"https://github.com/nodejs/node/pull/12540#discussion_r112849921","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/12540","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/112849921"},"html":{"href":"https://github.com/nodejs/node/pull/12540#discussion_r112849921"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/12540"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/12540","id":116783093,"html_url":"https://github.com/nodejs/node/pull/12540","diff_url":"https://github.com/nodejs/node/pull/12540.diff","patch_url":"https://github.com/nodejs/node/pull/12540.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/12540","number":12540,"state":"open","locked":false,"title":"src: add fcntl.h include to node.cc","user":{"login":"bzoz","id":17704638,"avatar_url":"https://avatars1.githubusercontent.com/u/17704638?v=3","gravatar_id":"","url":"https://api.github.com/users/bzoz","html_url":"https://github.com/bzoz","followers_url":"https://api.github.com/users/bzoz/followers","following_url":"https://api.github.com/users/bzoz/following{/other_user}","gists_url":"https://api.github.com/users/bzoz/gists{/gist_id}","starred_url":"https://api.github.com/users/bzoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bzoz/subscriptions","organizations_url":"https://api.github.com/users/bzoz/orgs","repos_url":"https://api.github.com/users/bzoz/repos","events_url":"https://api.github.com/users/bzoz/events{/privacy}","received_events_url":"https://api.github.com/users/bzoz/received_events","type":"User","site_admin":false},"body":"PR https://github.com/nodejs/node/pull/11863 added `_O_RDWR` to `node.cc` which is defined in fcntl.h. This adds this include directly to `node.cc` to prevent build fails like in https://github.com/nodejs/node/pull/12498\r\n\r\n/cc @MylesBorins \r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\nsrc\r\n","created_at":"2017-04-20T14:21:52Z","updated_at":"2017-04-24T00:50:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2f497b32270fefe066234ae01def177b73cb24c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/12540/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/12540/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/12540/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/8c340364745615df5903db0d5113768c14615b9f","head":{"label":"janeasystems:bartek-add-fcntl","ref":"bartek-add-fcntl","sha":"8c340364745615df5903db0d5113768c14615b9f","user":{"login":"janeasystems","id":9194778,"avatar_url":"https://avatars1.githubusercontent.com/u/9194778?v=3","gravatar_id":"","url":"https://api.github.com/users/janeasystems","html_url":"https://github.com/janeasystems","followers_url":"https://api.github.com/users/janeasystems/followers","following_url":"https://api.github.com/users/janeasystems/following{/other_user}","gists_url":"https://api.github.com/users/janeasystems/gists{/gist_id}","starred_url":"https://api.github.com/users/janeasystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janeasystems/subscriptions","organizations_url":"https://api.github.com/users/janeasystems/orgs","repos_url":"https://api.github.com/users/janeasystems/repos","events_url":"https://api.github.com/users/janeasystems/events{/privacy}","received_events_url":"https://api.github.com/users/janeasystems/received_events","type":"Organization","site_admin":false},"repo":{"id":36501512,"name":"node","full_name":"janeasystems/node","owner":{"login":"janeasystems","id":9194778,"avatar_url":"https://avatars1.githubusercontent.com/u/9194778?v=3","gravatar_id":"","url":"https://api.github.com/users/janeasystems","html_url":"https://github.com/janeasystems","followers_url":"https://api.github.com/users/janeasystems/followers","following_url":"https://api.github.com/users/janeasystems/following{/other_user}","gists_url":"https://api.github.com/users/janeasystems/gists{/gist_id}","starred_url":"https://api.github.com/users/janeasystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janeasystems/subscriptions","organizations_url":"https://api.github.com/users/janeasystems/orgs","repos_url":"https://api.github.com/users/janeasystems/repos","events_url":"https://api.github.com/users/janeasystems/events{/privacy}","received_events_url":"https://api.github.com/users/janeasystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/janeasystems/node","description":"Node.js, but with bigger and faster version numbers","fork":true,"url":"https://api.github.com/repos/janeasystems/node","forks_url":"https://api.github.com/repos/janeasystems/node/forks","keys_url":"https://api.github.com/repos/janeasystems/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janeasystems/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janeasystems/node/teams","hooks_url":"https://api.github.com/repos/janeasystems/node/hooks","issue_events_url":"https://api.github.com/repos/janeasystems/node/issues/events{/number}","events_url":"https://api.github.com/repos/janeasystems/node/events","assignees_url":"https://api.github.com/repos/janeasystems/node/assignees{/user}","branches_url":"https://api.github.com/repos/janeasystems/node/branches{/branch}","tags_url":"https://api.github.com/repos/janeasystems/node/tags","blobs_url":"https://api.github.com/repos/janeasystems/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janeasystems/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janeasystems/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/janeasystems/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janeasystems/node/statuses/{sha}","languages_url":"https://api.github.com/repos/janeasystems/node/languages","stargazers_url":"https://api.github.com/repos/janeasystems/node/stargazers","contributors_url":"https://api.github.com/repos/janeasystems/node/contributors","subscribers_url":"https://api.github.com/repos/janeasystems/node/subscribers","subscription_url":"https://api.github.com/repos/janeasystems/node/subscription","commits_url":"https://api.github.com/repos/janeasystems/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/janeasystems/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/janeasystems/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/janeasystems/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/janeasystems/node/contents/{+path}","compare_url":"https://api.github.com/repos/janeasystems/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janeasystems/node/merges","archive_url":"https://api.github.com/repos/janeasystems/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janeasystems/node/downloads","issues_url":"https://api.github.com/repos/janeasystems/node/issues{/number}","pulls_url":"https://api.github.com/repos/janeasystems/node/pulls{/number}","milestones_url":"https://api.github.com/repos/janeasystems/node/milestones{/number}","notifications_url":"https://api.github.com/repos/janeasystems/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janeasystems/node/labels{/name}","releases_url":"https://api.github.com/repos/janeasystems/node/releases{/id}","deployments_url":"https://api.github.com/repos/janeasystems/node/deployments","created_at":"2015-05-29T11:56:02Z","updated_at":"2016-10-26T22:21:34Z","pushed_at":"2017-04-22T14:02:45Z","git_url":"git://github.com/janeasystems/node.git","ssh_url":"git@github.com:janeasystems/node.git","clone_url":"https://github.com/janeasystems/node.git","svn_url":"https://github.com/janeasystems/node","homepage":"https://iojs.org","size":273901,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"ce986de829457c39257cd205067602e765768fb0","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-04-24T00:21:25Z","pushed_at":"2017-04-23T22:30:58Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":279826,"stargazers_count":34172,"watchers_count":34172,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6517,"mirror_url":null,"open_issues_count":1048,"forks":6517,"open_issues":1048,"watchers":34172,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/12540"},"html":{"href":"https://github.com/nodejs/node/pull/12540"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/12540"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/12540/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/12540/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/12540/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/8c340364745615df5903db0d5113768c14615b9f"}}}}
{"actor":{"display_login":"TimothyGu"}}