{"action":"created","issue":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/4171","repository_url":"https://api.github.com/repos/checkstyle/checkstyle","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/4171/labels{/name}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/4171/comments","events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/4171/events","html_url":"https://github.com/checkstyle/checkstyle/pull/4171","id":220306019,"number":4171,"title":"Issue #3131: Add support for try with resources","user":{"login":"kukreja-vikramaditya","id":15936912,"avatar_url":"https://avatars0.githubusercontent.com/u/15936912?v=3","gravatar_id":"","url":"https://api.github.com/users/kukreja-vikramaditya","html_url":"https://github.com/kukreja-vikramaditya","followers_url":"https://api.github.com/users/kukreja-vikramaditya/followers","following_url":"https://api.github.com/users/kukreja-vikramaditya/following{/other_user}","gists_url":"https://api.github.com/users/kukreja-vikramaditya/gists{/gist_id}","starred_url":"https://api.github.com/users/kukreja-vikramaditya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kukreja-vikramaditya/subscriptions","organizations_url":"https://api.github.com/users/kukreja-vikramaditya/orgs","repos_url":"https://api.github.com/users/kukreja-vikramaditya/repos","events_url":"https://api.github.com/users/kukreja-vikramaditya/events{/privacy}","received_events_url":"https://api.github.com/users/kukreja-vikramaditya/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":32,"created_at":"2017-04-07T19:25:24Z","updated_at":"2017-07-10T17:19:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/4171","html_url":"https://github.com/checkstyle/checkstyle/pull/4171","diff_url":"https://github.com/checkstyle/checkstyle/pull/4171.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/4171.patch"},"body":"Issue: #3131\r\n"},"comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments/314174435","html_url":"https://github.com/checkstyle/checkstyle/pull/4171#issuecomment-314174435","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/4171","id":314174435,"user":{"login":"rnveach","id":5427943,"avatar_url":"https://avatars2.githubusercontent.com/u/5427943?v=3","gravatar_id":"","url":"https://api.github.com/users/rnveach","html_url":"https://github.com/rnveach","followers_url":"https://api.github.com/users/rnveach/followers","following_url":"https://api.github.com/users/rnveach/following{/other_user}","gists_url":"https://api.github.com/users/rnveach/gists{/gist_id}","starred_url":"https://api.github.com/users/rnveach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnveach/subscriptions","organizations_url":"https://api.github.com/users/rnveach/orgs","repos_url":"https://api.github.com/users/rnveach/repos","events_url":"https://api.github.com/users/rnveach/events{/privacy}","received_events_url":"https://api.github.com/users/rnveach/received_events","type":"User","site_admin":false},"created_at":"2017-07-10T17:19:30Z","updated_at":"2017-07-10T17:19:30Z","body":"> Where to put wrapping is not business of indentation Check.\r\n\r\n@romani It is not specifying where to place wrapping. It is specifying where to indent wrapping.\r\nCode is currently like:\r\n````\r\n90          try (ByteArrayInputStream in = new ByteArrayInputStream(decoder.getBytes());\r\n91                  ) {\r\n````\r\nIndentation is requesting it be like:\r\n````\r\n90          try (ByteArrayInputStream in = new ByteArrayInputStream(decoder.getBytes());\r\n91          ) {\r\n````\r\n\r\n> It seems to me that the warning is correct\r\n\r\n@kukreja-vikramaditya Look at your examples from the major IDEs at https://github.com/checkstyle/checkstyle/issues/3131#issuecomment-292514375 .\r\n\r\nNetbeans follows the indentation of htmlunit while IDEA and Eclipse don't. So this is a false positive and you must accept indentation of either one.\r\nPlease fix your code. No PR to htmlunit should be done."}}
{"actor":{"display_login":"rnveach"}}