{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/157612414","pull_request_review_id":84283892,"id":157612414,"diff_hunk":"@@ -7,69 +7,108 @@\n import asyncio\n import logging\n \n-from homeassistant.core import callback\n-from homeassistant.helpers.dispatcher import async_dispatcher_connect\n import homeassistant.components.alarm_control_panel as alarm\n-\n-from homeassistant.components.alarmdecoder import (DATA_AD,\n-                                                   SIGNAL_PANEL_MESSAGE)\n-\n+from homeassistant.components.alarmdecoder import (\n+    DATA_AD, SIGNAL_PANEL_MESSAGE)\n from homeassistant.const import (\n     STATE_ALARM_ARMED_AWAY, STATE_ALARM_ARMED_HOME, STATE_ALARM_DISARMED,\n-    STATE_UNKNOWN, STATE_ALARM_TRIGGERED)\n+    STATE_ALARM_TRIGGERED)\n \n _LOGGER = logging.getLogger(__name__)\n \n DEPENDENCIES = ['alarmdecoder']\n \n \n-@asyncio.coroutine\n-def async_setup_platform(hass, config, async_add_devices, discovery_info=None):\n+def setup_platform(hass, config, add_devices, discovery_info=None):\n     \"\"\"Set up for AlarmDecoder alarm panels.\"\"\"\n-    _LOGGER.debug(\"AlarmDecoderAlarmPanel: setup\")\n-\n-    device = AlarmDecoderAlarmPanel(\"Alarm Panel\", hass)\n-\n-    async_add_devices([device])\n+    add_devices([AlarmDecoderAlarmPanel()])\n \n     return True\n \n \n class AlarmDecoderAlarmPanel(alarm.AlarmControlPanel):\n     \"\"\"Representation of an AlarmDecoder-based alarm panel.\"\"\"\n \n-    def __init__(self, name, hass):\n+    def __init__(self):\n         \"\"\"Initialize the alarm panel.\"\"\"\n         self._display = \"\"\n-        self._name = name\n-        self._state = STATE_UNKNOWN\n-\n-        _LOGGER.debug(\"Setting up panel\")\n+        self._name = \"Alarm Panel\"\n+        self._state = None\n+\n+        self._ac_power = STATE_UNKNOWN\n+        self._backlight_on = STATE_UNKNOWN\n+        self._battery_low = STATE_UNKNOWN\n+        self._check_zone = STATE_UNKNOWN","path":"homeassistant/components/alarm_control_panel/alarmdecoder.py","position":54,"original_position":54,"commit_id":"24f4430f256c54145da28b26c023c9a49e923cf8","original_commit_id":"24f4430f256c54145da28b26c023c9a49e923cf8","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"undefined name 'STATE_UNKNOWN'","created_at":"2017-12-18T21:59:25Z","updated_at":"2017-12-18T21:59:25Z","html_url":"https://github.com/home-assistant/home-assistant/pull/11155#discussion_r157612414","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/11155","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/157612414"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/11155#discussion_r157612414"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/11155"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/11155","id":158585218,"html_url":"https://github.com/home-assistant/home-assistant/pull/11155","diff_url":"https://github.com/home-assistant/home-assistant/pull/11155.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/11155.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/11155","number":11155,"state":"open","locked":false,"title":"Add attributes to AlarmDecoder","user":{"login":"hawk259","id":20422096,"avatar_url":"https://avatars2.githubusercontent.com/u/20422096?v=4","gravatar_id":"","url":"https://api.github.com/users/hawk259","html_url":"https://github.com/hawk259","followers_url":"https://api.github.com/users/hawk259/followers","following_url":"https://api.github.com/users/hawk259/following{/other_user}","gists_url":"https://api.github.com/users/hawk259/gists{/gist_id}","starred_url":"https://api.github.com/users/hawk259/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawk259/subscriptions","organizations_url":"https://api.github.com/users/hawk259/orgs","repos_url":"https://api.github.com/users/hawk259/repos","events_url":"https://api.github.com/users/hawk259/events{/privacy}","received_events_url":"https://api.github.com/users/hawk259/received_events","type":"User","site_admin":false},"body":"Adding new attributes to AlarmDecoder: ac_power, backlight_on, battery_low, che…ck_zone, chime, entry_delay_off, programming_mode, ready, zone_bypassed\r\n\r\n## Checklist:\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [ ] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [ ] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54","created_at":"2017-12-15T11:47:07Z","updated_at":"2017-12-18T21:59:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a614db96746a65a682d7ebe137038dc58825ea9a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andrey-git","id":5478779,"avatar_url":"https://avatars0.githubusercontent.com/u/5478779?v=4","gravatar_id":"","url":"https://api.github.com/users/andrey-git","html_url":"https://github.com/andrey-git","followers_url":"https://api.github.com/users/andrey-git/followers","following_url":"https://api.github.com/users/andrey-git/following{/other_user}","gists_url":"https://api.github.com/users/andrey-git/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-git/subscriptions","organizations_url":"https://api.github.com/users/andrey-git/orgs","repos_url":"https://api.github.com/users/andrey-git/repos","events_url":"https://api.github.com/users/andrey-git/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-git/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/11155/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/11155/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/11155/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/24f4430f256c54145da28b26c023c9a49e923cf8","head":{"label":"hawk259:dev","ref":"dev","sha":"24f4430f256c54145da28b26c023c9a49e923cf8","user":{"login":"hawk259","id":20422096,"avatar_url":"https://avatars2.githubusercontent.com/u/20422096?v=4","gravatar_id":"","url":"https://api.github.com/users/hawk259","html_url":"https://github.com/hawk259","followers_url":"https://api.github.com/users/hawk259/followers","following_url":"https://api.github.com/users/hawk259/following{/other_user}","gists_url":"https://api.github.com/users/hawk259/gists{/gist_id}","starred_url":"https://api.github.com/users/hawk259/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawk259/subscriptions","organizations_url":"https://api.github.com/users/hawk259/orgs","repos_url":"https://api.github.com/users/hawk259/repos","events_url":"https://api.github.com/users/hawk259/events{/privacy}","received_events_url":"https://api.github.com/users/hawk259/received_events","type":"User","site_admin":false},"repo":{"id":114244838,"name":"home-assistant","full_name":"hawk259/home-assistant","owner":{"login":"hawk259","id":20422096,"avatar_url":"https://avatars2.githubusercontent.com/u/20422096?v=4","gravatar_id":"","url":"https://api.github.com/users/hawk259","html_url":"https://github.com/hawk259","followers_url":"https://api.github.com/users/hawk259/followers","following_url":"https://api.github.com/users/hawk259/following{/other_user}","gists_url":"https://api.github.com/users/hawk259/gists{/gist_id}","starred_url":"https://api.github.com/users/hawk259/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawk259/subscriptions","organizations_url":"https://api.github.com/users/hawk259/orgs","repos_url":"https://api.github.com/users/hawk259/repos","events_url":"https://api.github.com/users/hawk259/events{/privacy}","received_events_url":"https://api.github.com/users/hawk259/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hawk259/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/hawk259/home-assistant","forks_url":"https://api.github.com/repos/hawk259/home-assistant/forks","keys_url":"https://api.github.com/repos/hawk259/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hawk259/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hawk259/home-assistant/teams","hooks_url":"https://api.github.com/repos/hawk259/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/hawk259/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/hawk259/home-assistant/events","assignees_url":"https://api.github.com/repos/hawk259/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/hawk259/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/hawk259/home-assistant/tags","blobs_url":"https://api.github.com/repos/hawk259/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hawk259/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hawk259/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/hawk259/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hawk259/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/hawk259/home-assistant/languages","stargazers_url":"https://api.github.com/repos/hawk259/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/hawk259/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/hawk259/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/hawk259/home-assistant/subscription","commits_url":"https://api.github.com/repos/hawk259/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/hawk259/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/hawk259/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/hawk259/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/hawk259/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/hawk259/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hawk259/home-assistant/merges","archive_url":"https://api.github.com/repos/hawk259/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hawk259/home-assistant/downloads","issues_url":"https://api.github.com/repos/hawk259/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/hawk259/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/hawk259/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/hawk259/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hawk259/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/hawk259/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/hawk259/home-assistant/deployments","created_at":"2017-12-14T11:55:07Z","updated_at":"2017-12-14T11:55:16Z","pushed_at":"2017-12-18T21:59:11Z","git_url":"git://github.com/hawk259/home-assistant.git","ssh_url":"git@github.com:hawk259/home-assistant.git","clone_url":"https://github.com/hawk259/home-assistant.git","svn_url":"https://github.com/hawk259/home-assistant","homepage":"https://home-assistant.io","size":76580,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"de4c8adca257e0d72aadb48b7b9c1e7b560c0932","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2017-12-18T21:53:24Z","pushed_at":"2017-12-18T21:59:14Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":76688,"stargazers_count":10915,"watchers_count":10915,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3135,"mirror_url":null,"archived":false,"open_issues_count":686,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3135,"open_issues":686,"watchers":10915,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/11155"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/11155"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/11155"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/11155/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/11155/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/11155/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/24f4430f256c54145da28b26c023c9a49e923cf8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}