{"action":"created","comment":{"url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/pulls/comments/107218679","pull_request_review_id":28178057,"id":107218679,"diff_hunk":"@@ -24,7 +24,34 @@ describe(\"Patternfly Dropdown Component Test\", function () {\n \n     customElement.addEventListener('hidden.bs.dropdown', function () {\n       expect(button.parentNode.classList.contains('open')).toBe(false);\n-      done();\n     }, false);\n   });\n+\n+  it(\"disabled button should not open dropdown\", function () {\n+    var button = customElement.querySelector('.btn');\n+    button.classList.add('disabled');\n+    customElement.toggle();\n+    expect(button.parentNode.classList.contains('open')).toBe(false);\n+    button.dispatchEvent(new MouseEvent('click'));\n+    expect(button.parentNode.classList.contains('open')).toBe(false);\n+  });\n+\n+  it(\"should select an element\", function () {\n+    var buttonText = customElement.querySelector('.btn');\n+    var item = customElement.querySelector('ul.dropdown-menu > li:nth-child(2)');\n+    expect(buttonText.innerText).toBe('Dropdown');\n+    expect(item.innerText).toBe('Item 1');\n+  });\n+\n+  it(\"should not click disabled item\", function () {\n+    var item = customElement.querySelector('ul.dropdown-menu  li.disabled a');\n+    var event = new MouseEvent('click',{\n+      bubbles: true,\n+      cancelable: true,\n+      view: window\n+    });\n+    customElement.disableClick();","path":"src/pf-dropdown/pf-dropdown.spec.js","position":53,"original_position":40,"commit_id":"6c628dfb47968d198e81e5b2bdb0e5a5dfe95e75","original_commit_id":"6c628dfb47968d198e81e5b2bdb0e5a5dfe95e75","user":{"login":"dlabrecq","id":17481322,"avatar_url":"https://avatars1.githubusercontent.com/u/17481322?v=3","gravatar_id":"","url":"https://api.github.com/users/dlabrecq","html_url":"https://github.com/dlabrecq","followers_url":"https://api.github.com/users/dlabrecq/followers","following_url":"https://api.github.com/users/dlabrecq/following{/other_user}","gists_url":"https://api.github.com/users/dlabrecq/gists{/gist_id}","starred_url":"https://api.github.com/users/dlabrecq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlabrecq/subscriptions","organizations_url":"https://api.github.com/users/dlabrecq/orgs","repos_url":"https://api.github.com/users/dlabrecq/repos","events_url":"https://api.github.com/users/dlabrecq/events{/privacy}","received_events_url":"https://api.github.com/users/dlabrecq/received_events","type":"User","site_admin":false},"body":"You shouldn't call disableClick() yourself. That wouldn't be a true test for a disabled menu option.\r\n\r\nI don't believe this is an issue with PhantomJs. Other than the disabled class on the \"li\" element, I don't see anything that will prevent the anchor from generating an onclick event across browsers. You may also need to disable the anchor itself. For example:\r\n\r\n&lt;li class=\"disabled\">&lt;a href=\"#\" onclick=\"return false;\">Item 3&lt/a>&lt;/li>","created_at":"2017-03-21T17:19:50Z","updated_at":"2017-03-21T17:41:17Z","html_url":"https://github.com/patternfly-webcomponents/patternfly-webcomponents/pull/23#discussion_r107218679","pull_request_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/pulls/comments/107218679"},"html":{"href":"https://github.com/patternfly-webcomponents/patternfly-webcomponents/pull/23#discussion_r107218679"},"pull_request":{"href":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/pulls/23","id":109706467,"html_url":"https://github.com/patternfly-webcomponents/patternfly-webcomponents/pull/23","diff_url":"https://github.com/patternfly-webcomponents/patternfly-webcomponents/pull/23.diff","patch_url":"https://github.com/patternfly-webcomponents/patternfly-webcomponents/pull/23.patch","issue_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/issues/23","number":23,"state":"open","locked":false,"title":"pf-dropdown","user":{"login":"sahil143","id":9278015,"avatar_url":"https://avatars1.githubusercontent.com/u/9278015?v=3","gravatar_id":"","url":"https://api.github.com/users/sahil143","html_url":"https://github.com/sahil143","followers_url":"https://api.github.com/users/sahil143/followers","following_url":"https://api.github.com/users/sahil143/following{/other_user}","gists_url":"https://api.github.com/users/sahil143/gists{/gist_id}","starred_url":"https://api.github.com/users/sahil143/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahil143/subscriptions","organizations_url":"https://api.github.com/users/sahil143/orgs","repos_url":"https://api.github.com/users/sahil143/repos","events_url":"https://api.github.com/users/sahil143/events{/privacy}","received_events_url":"https://api.github.com/users/sahil143/received_events","type":"User","site_admin":false},"body":"Introducing `<pf-dropdown>` new Web component based on Bootstrap Dropdown.","created_at":"2017-03-08T14:31:50Z","updated_at":"2017-03-21T17:41:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c18aeccbe808341264c8d3bdfcf45b35fd6e031","assignee":{"login":"bleathem","id":265649,"avatar_url":"https://avatars2.githubusercontent.com/u/265649?v=3","gravatar_id":"","url":"https://api.github.com/users/bleathem","html_url":"https://github.com/bleathem","followers_url":"https://api.github.com/users/bleathem/followers","following_url":"https://api.github.com/users/bleathem/following{/other_user}","gists_url":"https://api.github.com/users/bleathem/gists{/gist_id}","starred_url":"https://api.github.com/users/bleathem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleathem/subscriptions","organizations_url":"https://api.github.com/users/bleathem/orgs","repos_url":"https://api.github.com/users/bleathem/repos","events_url":"https://api.github.com/users/bleathem/events{/privacy}","received_events_url":"https://api.github.com/users/bleathem/received_events","type":"User","site_admin":false},"assignees":[{"login":"bleathem","id":265649,"avatar_url":"https://avatars2.githubusercontent.com/u/265649?v=3","gravatar_id":"","url":"https://api.github.com/users/bleathem","html_url":"https://github.com/bleathem","followers_url":"https://api.github.com/users/bleathem/followers","following_url":"https://api.github.com/users/bleathem/following{/other_user}","gists_url":"https://api.github.com/users/bleathem/gists{/gist_id}","starred_url":"https://api.github.com/users/bleathem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleathem/subscriptions","organizations_url":"https://api.github.com/users/bleathem/orgs","repos_url":"https://api.github.com/users/bleathem/repos","events_url":"https://api.github.com/users/bleathem/events{/privacy}","received_events_url":"https://api.github.com/users/bleathem/received_events","type":"User","site_admin":false},{"login":"dlabrecq","id":17481322,"avatar_url":"https://avatars1.githubusercontent.com/u/17481322?v=3","gravatar_id":"","url":"https://api.github.com/users/dlabrecq","html_url":"https://github.com/dlabrecq","followers_url":"https://api.github.com/users/dlabrecq/followers","following_url":"https://api.github.com/users/dlabrecq/following{/other_user}","gists_url":"https://api.github.com/users/dlabrecq/gists{/gist_id}","starred_url":"https://api.github.com/users/dlabrecq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlabrecq/subscriptions","organizations_url":"https://api.github.com/users/dlabrecq/orgs","repos_url":"https://api.github.com/users/dlabrecq/repos","events_url":"https://api.github.com/users/dlabrecq/events{/privacy}","received_events_url":"https://api.github.com/users/dlabrecq/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/pulls/23/commits","review_comments_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/pulls/23/comments","review_comment_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/pulls/comments{/number}","comments_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/issues/23/comments","statuses_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/statuses/6c628dfb47968d198e81e5b2bdb0e5a5dfe95e75","head":{"label":"sahil143:dropdown","ref":"dropdown","sha":"6c628dfb47968d198e81e5b2bdb0e5a5dfe95e75","user":{"login":"sahil143","id":9278015,"avatar_url":"https://avatars1.githubusercontent.com/u/9278015?v=3","gravatar_id":"","url":"https://api.github.com/users/sahil143","html_url":"https://github.com/sahil143","followers_url":"https://api.github.com/users/sahil143/followers","following_url":"https://api.github.com/users/sahil143/following{/other_user}","gists_url":"https://api.github.com/users/sahil143/gists{/gist_id}","starred_url":"https://api.github.com/users/sahil143/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahil143/subscriptions","organizations_url":"https://api.github.com/users/sahil143/orgs","repos_url":"https://api.github.com/users/sahil143/repos","events_url":"https://api.github.com/users/sahil143/events{/privacy}","received_events_url":"https://api.github.com/users/sahil143/received_events","type":"User","site_admin":false},"repo":{"id":74536017,"name":"patternfly-webcomponents","full_name":"sahil143/patternfly-webcomponents","owner":{"login":"sahil143","id":9278015,"avatar_url":"https://avatars1.githubusercontent.com/u/9278015?v=3","gravatar_id":"","url":"https://api.github.com/users/sahil143","html_url":"https://github.com/sahil143","followers_url":"https://api.github.com/users/sahil143/followers","following_url":"https://api.github.com/users/sahil143/following{/other_user}","gists_url":"https://api.github.com/users/sahil143/gists{/gist_id}","starred_url":"https://api.github.com/users/sahil143/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahil143/subscriptions","organizations_url":"https://api.github.com/users/sahil143/orgs","repos_url":"https://api.github.com/users/sahil143/repos","events_url":"https://api.github.com/users/sahil143/events{/privacy}","received_events_url":"https://api.github.com/users/sahil143/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sahil143/patternfly-webcomponents","description":"This project provides a set of core Web Components for the PatternFly reference implementation","fork":true,"url":"https://api.github.com/repos/sahil143/patternfly-webcomponents","forks_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/forks","keys_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/teams","hooks_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/hooks","issue_events_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/issues/events{/number}","events_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/events","assignees_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/assignees{/user}","branches_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/branches{/branch}","tags_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/tags","blobs_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/git/refs{/sha}","trees_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/statuses/{sha}","languages_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/languages","stargazers_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/stargazers","contributors_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/contributors","subscribers_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/subscribers","subscription_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/subscription","commits_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/commits{/sha}","git_commits_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/git/commits{/sha}","comments_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/comments{/number}","issue_comment_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/issues/comments{/number}","contents_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/contents/{+path}","compare_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/merges","archive_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/downloads","issues_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/issues{/number}","pulls_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/pulls{/number}","milestones_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/milestones{/number}","notifications_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/labels{/name}","releases_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/releases{/id}","deployments_url":"https://api.github.com/repos/sahil143/patternfly-webcomponents/deployments","created_at":"2016-11-23T03:13:22Z","updated_at":"2016-11-23T03:13:24Z","pushed_at":"2017-03-21T13:28:46Z","git_url":"git://github.com/sahil143/patternfly-webcomponents.git","ssh_url":"git@github.com:sahil143/patternfly-webcomponents.git","clone_url":"https://github.com/sahil143/patternfly-webcomponents.git","svn_url":"https://github.com/sahil143/patternfly-webcomponents","homepage":"","size":4223,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"patternfly-webcomponents:master","ref":"master","sha":"77fd1b05eb543429016bcac9e6ca8af50ed4ed10","user":{"login":"patternfly-webcomponents","id":23172391,"avatar_url":"https://avatars2.githubusercontent.com/u/23172391?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly-webcomponents","html_url":"https://github.com/patternfly-webcomponents","followers_url":"https://api.github.com/users/patternfly-webcomponents/followers","following_url":"https://api.github.com/users/patternfly-webcomponents/following{/other_user}","gists_url":"https://api.github.com/users/patternfly-webcomponents/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly-webcomponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly-webcomponents/subscriptions","organizations_url":"https://api.github.com/users/patternfly-webcomponents/orgs","repos_url":"https://api.github.com/users/patternfly-webcomponents/repos","events_url":"https://api.github.com/users/patternfly-webcomponents/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly-webcomponents/received_events","type":"Organization","site_admin":false},"repo":{"id":72454055,"name":"patternfly-webcomponents","full_name":"patternfly-webcomponents/patternfly-webcomponents","owner":{"login":"patternfly-webcomponents","id":23172391,"avatar_url":"https://avatars2.githubusercontent.com/u/23172391?v=3","gravatar_id":"","url":"https://api.github.com/users/patternfly-webcomponents","html_url":"https://github.com/patternfly-webcomponents","followers_url":"https://api.github.com/users/patternfly-webcomponents/followers","following_url":"https://api.github.com/users/patternfly-webcomponents/following{/other_user}","gists_url":"https://api.github.com/users/patternfly-webcomponents/gists{/gist_id}","starred_url":"https://api.github.com/users/patternfly-webcomponents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patternfly-webcomponents/subscriptions","organizations_url":"https://api.github.com/users/patternfly-webcomponents/orgs","repos_url":"https://api.github.com/users/patternfly-webcomponents/repos","events_url":"https://api.github.com/users/patternfly-webcomponents/events{/privacy}","received_events_url":"https://api.github.com/users/patternfly-webcomponents/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/patternfly-webcomponents/patternfly-webcomponents","description":"This project provides a set of core Web Components for the PatternFly reference implementation","fork":false,"url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents","forks_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/forks","keys_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/teams","hooks_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/hooks","issue_events_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/issues/events{/number}","events_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/events","assignees_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/assignees{/user}","branches_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/branches{/branch}","tags_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/tags","blobs_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/git/refs{/sha}","trees_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/statuses/{sha}","languages_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/languages","stargazers_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/stargazers","contributors_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/contributors","subscribers_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/subscribers","subscription_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/subscription","commits_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/commits{/sha}","git_commits_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/git/commits{/sha}","comments_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/comments{/number}","issue_comment_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/issues/comments{/number}","contents_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/contents/{+path}","compare_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/merges","archive_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/downloads","issues_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/issues{/number}","pulls_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/pulls{/number}","milestones_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/milestones{/number}","notifications_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/labels{/name}","releases_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/releases{/id}","deployments_url":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/deployments","created_at":"2016-10-31T16:12:08Z","updated_at":"2017-03-13T17:56:26Z","pushed_at":"2017-03-21T13:28:47Z","git_url":"git://github.com/patternfly-webcomponents/patternfly-webcomponents.git","ssh_url":"git@github.com:patternfly-webcomponents/patternfly-webcomponents.git","clone_url":"https://github.com/patternfly-webcomponents/patternfly-webcomponents.git","svn_url":"https://github.com/patternfly-webcomponents/patternfly-webcomponents","homepage":"https://patternfly-webcomponents.github.io/","size":8050,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":6,"mirror_url":null,"open_issues_count":12,"forks":6,"open_issues":12,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/pulls/23"},"html":{"href":"https://github.com/patternfly-webcomponents/patternfly-webcomponents/pull/23"},"issue":{"href":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/issues/23"},"comments":{"href":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/patternfly-webcomponents/patternfly-webcomponents/statuses/6c628dfb47968d198e81e5b2bdb0e5a5dfe95e75"}}}}
{"actor":{"display_login":"dlabrecq"}}