{"action":"created","issue":{"url":"https://api.github.com/repos/mendix/SearchInput/issues/11","repository_url":"https://api.github.com/repos/mendix/SearchInput","labels_url":"https://api.github.com/repos/mendix/SearchInput/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/mendix/SearchInput/issues/11/comments","events_url":"https://api.github.com/repos/mendix/SearchInput/issues/11/events","html_url":"https://github.com/mendix/SearchInput/issues/11","id":216074792,"number":11,"title":"Error count badge on tabcontainer is not removed","user":{"login":"dkho87","id":18614452,"avatar_url":"https://avatars3.githubusercontent.com/u/18614452?v=3","gravatar_id":"","url":"https://api.github.com/users/dkho87","html_url":"https://github.com/dkho87","followers_url":"https://api.github.com/users/dkho87/followers","following_url":"https://api.github.com/users/dkho87/following{/other_user}","gists_url":"https://api.github.com/users/dkho87/gists{/gist_id}","starred_url":"https://api.github.com/users/dkho87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkho87/subscriptions","organizations_url":"https://api.github.com/users/dkho87/orgs","repos_url":"https://api.github.com/users/dkho87/repos","events_url":"https://api.github.com/users/dkho87/events{/privacy}","received_events_url":"https://api.github.com/users/dkho87/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"JelteMX","id":14937393,"avatar_url":"https://avatars1.githubusercontent.com/u/14937393?v=3","gravatar_id":"","url":"https://api.github.com/users/JelteMX","html_url":"https://github.com/JelteMX","followers_url":"https://api.github.com/users/JelteMX/followers","following_url":"https://api.github.com/users/JelteMX/following{/other_user}","gists_url":"https://api.github.com/users/JelteMX/gists{/gist_id}","starred_url":"https://api.github.com/users/JelteMX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JelteMX/subscriptions","organizations_url":"https://api.github.com/users/JelteMX/orgs","repos_url":"https://api.github.com/users/JelteMX/repos","events_url":"https://api.github.com/users/JelteMX/events{/privacy}","received_events_url":"https://api.github.com/users/JelteMX/received_events","type":"User","site_admin":false},"assignees":[{"login":"JelteMX","id":14937393,"avatar_url":"https://avatars1.githubusercontent.com/u/14937393?v=3","gravatar_id":"","url":"https://api.github.com/users/JelteMX","html_url":"https://github.com/JelteMX","followers_url":"https://api.github.com/users/JelteMX/followers","following_url":"https://api.github.com/users/JelteMX/following{/other_user}","gists_url":"https://api.github.com/users/JelteMX/gists{/gist_id}","starred_url":"https://api.github.com/users/JelteMX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JelteMX/subscriptions","organizations_url":"https://api.github.com/users/JelteMX/orgs","repos_url":"https://api.github.com/users/JelteMX/repos","events_url":"https://api.github.com/users/JelteMX/events{/privacy}","received_events_url":"https://api.github.com/users/JelteMX/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-03-22T14:05:57Z","updated_at":"2017-03-28T09:11:31Z","closed_at":"2017-03-28T09:10:37Z","body":"Somehow the executeMicroflow function does not result in proper handling of the validation badge count at the tabcontainer level. \r\n\r\nNormally having a validation error would result in an increase of the notification badge, which also happens in with this widget and is correct behaviour. However, as soon as you correct the error, in the next validation run the notification badge count is not decreased.\r\n\r\nTo correct this, I've added the following quick fix to my instance of the widget, but would like to know what the proper way would be to have this fixed (which is why I haven't created a pull request yet).\r\n\r\nIn the executeMicroflow function I simply added:\r\n` if(this._hadValidationFeedback) {\r\n                    this._decreaseValidationNotification();\r\n                    this._hadValidationFeedback = false;\r\n                }`\r\n\r\nnear the end of the function."},"comment":{"url":"https://api.github.com/repos/mendix/SearchInput/issues/comments/289710321","html_url":"https://github.com/mendix/SearchInput/issues/11#issuecomment-289710321","issue_url":"https://api.github.com/repos/mendix/SearchInput/issues/11","id":289710321,"user":{"login":"JelteMX","id":14937393,"avatar_url":"https://avatars1.githubusercontent.com/u/14937393?v=3","gravatar_id":"","url":"https://api.github.com/users/JelteMX","html_url":"https://github.com/JelteMX","followers_url":"https://api.github.com/users/JelteMX/followers","following_url":"https://api.github.com/users/JelteMX/following{/other_user}","gists_url":"https://api.github.com/users/JelteMX/gists{/gist_id}","starred_url":"https://api.github.com/users/JelteMX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JelteMX/subscriptions","organizations_url":"https://api.github.com/users/JelteMX/orgs","repos_url":"https://api.github.com/users/JelteMX/repos","events_url":"https://api.github.com/users/JelteMX/events{/privacy}","received_events_url":"https://api.github.com/users/JelteMX/received_events","type":"User","site_admin":false},"created_at":"2017-03-28T09:11:31Z","updated_at":"2017-03-28T09:11:31Z","body":"I decided to add this to ``_clearValidations``, your solution is right. Thanks for reporting! I'll add this to the new version of the widget"}}
{"actor":{"display_login":"JelteMX"}}