{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/118413470","pull_request_review_id":40202424,"id":118413470,"diff_hunk":"@@ -195,7 +209,7 @@ class SparseReduceSumOp : public OpKernel {\n     // g.group() provides the coordinates of a particular reduced value.\n     sp.Reorder<T>(reduction.reorder_dims);\n     for (const auto &g : sp.group(reduction.group_by_dims)) {\n-      group_sum.device(ctx->eigen_cpu_device()) = g.template values<T>().sum();\n+      Op::template Run<T>(ctx, group_sum, g.template values<T>());","path":"tensorflow/core/kernels/sparse_reduce_op.cc","position":null,"original_position":33,"commit_id":"d23fd8763d97960ea67521efc977c57e50b0263c","original_commit_id":"d509e10860508464ecf61e7a9b14b1fc6d4ccb6b","user":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars3.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"body":"Thanks @concretevitamin. The PR has been updated.","created_at":"2017-05-25T03:47:47Z","updated_at":"2017-05-25T03:47:48Z","html_url":"https://github.com/tensorflow/tensorflow/pull/10056#discussion_r118413470","pull_request_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/10056","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/118413470"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/10056#discussion_r118413470"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/10056"}}},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/10056","id":121606909,"html_url":"https://github.com/tensorflow/tensorflow/pull/10056","diff_url":"https://github.com/tensorflow/tensorflow/pull/10056.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/10056.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/10056","number":10056,"state":"open","locked":false,"title":"Add support for sparse_reduce_max and sparse_reduce_max_sparse","user":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars3.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"body":"This commit tries to address the issue raised in #10002 to have\r\nthe support for sparse_reduce_max and sparse_reduce_max_sparse.\r\n\r\nSigned-off-by: Yong Tang <yong.tang.github@outlook.com>","created_at":"2017-05-20T02:11:09Z","updated_at":"2017-05-25T03:47:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ab18c4806428e3dc3e54801a79498c9cfd6b0ae","assignee":{"login":"concretevitamin","id":592670,"avatar_url":"https://avatars0.githubusercontent.com/u/592670?v=3","gravatar_id":"","url":"https://api.github.com/users/concretevitamin","html_url":"https://github.com/concretevitamin","followers_url":"https://api.github.com/users/concretevitamin/followers","following_url":"https://api.github.com/users/concretevitamin/following{/other_user}","gists_url":"https://api.github.com/users/concretevitamin/gists{/gist_id}","starred_url":"https://api.github.com/users/concretevitamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concretevitamin/subscriptions","organizations_url":"https://api.github.com/users/concretevitamin/orgs","repos_url":"https://api.github.com/users/concretevitamin/repos","events_url":"https://api.github.com/users/concretevitamin/events{/privacy}","received_events_url":"https://api.github.com/users/concretevitamin/received_events","type":"User","site_admin":false},"assignees":[{"login":"concretevitamin","id":592670,"avatar_url":"https://avatars0.githubusercontent.com/u/592670?v=3","gravatar_id":"","url":"https://api.github.com/users/concretevitamin","html_url":"https://github.com/concretevitamin","followers_url":"https://api.github.com/users/concretevitamin/followers","following_url":"https://api.github.com/users/concretevitamin/following{/other_user}","gists_url":"https://api.github.com/users/concretevitamin/gists{/gist_id}","starred_url":"https://api.github.com/users/concretevitamin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concretevitamin/subscriptions","organizations_url":"https://api.github.com/users/concretevitamin/orgs","repos_url":"https://api.github.com/users/concretevitamin/repos","events_url":"https://api.github.com/users/concretevitamin/events{/privacy}","received_events_url":"https://api.github.com/users/concretevitamin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/10056/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/10056/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/10056/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/d23fd8763d97960ea67521efc977c57e50b0263c","head":{"label":"yongtang:10002-sparse_reduce_max","ref":"10002-sparse_reduce_max","sha":"d23fd8763d97960ea67521efc977c57e50b0263c","user":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars3.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"repo":{"id":83927595,"name":"tensorflow","full_name":"yongtang/tensorflow","owner":{"login":"yongtang","id":6932348,"avatar_url":"https://avatars3.githubusercontent.com/u/6932348?v=3","gravatar_id":"","url":"https://api.github.com/users/yongtang","html_url":"https://github.com/yongtang","followers_url":"https://api.github.com/users/yongtang/followers","following_url":"https://api.github.com/users/yongtang/following{/other_user}","gists_url":"https://api.github.com/users/yongtang/gists{/gist_id}","starred_url":"https://api.github.com/users/yongtang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yongtang/subscriptions","organizations_url":"https://api.github.com/users/yongtang/orgs","repos_url":"https://api.github.com/users/yongtang/repos","events_url":"https://api.github.com/users/yongtang/events{/privacy}","received_events_url":"https://api.github.com/users/yongtang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yongtang/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/yongtang/tensorflow","forks_url":"https://api.github.com/repos/yongtang/tensorflow/forks","keys_url":"https://api.github.com/repos/yongtang/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yongtang/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yongtang/tensorflow/teams","hooks_url":"https://api.github.com/repos/yongtang/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/yongtang/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/yongtang/tensorflow/events","assignees_url":"https://api.github.com/repos/yongtang/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/yongtang/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/yongtang/tensorflow/tags","blobs_url":"https://api.github.com/repos/yongtang/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yongtang/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yongtang/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/yongtang/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yongtang/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/yongtang/tensorflow/languages","stargazers_url":"https://api.github.com/repos/yongtang/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/yongtang/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/yongtang/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/yongtang/tensorflow/subscription","commits_url":"https://api.github.com/repos/yongtang/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/yongtang/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/yongtang/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/yongtang/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/yongtang/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/yongtang/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yongtang/tensorflow/merges","archive_url":"https://api.github.com/repos/yongtang/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yongtang/tensorflow/downloads","issues_url":"https://api.github.com/repos/yongtang/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/yongtang/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/yongtang/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/yongtang/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yongtang/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/yongtang/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/yongtang/tensorflow/deployments","created_at":"2017-03-04T22:02:53Z","updated_at":"2017-03-04T22:03:13Z","pushed_at":"2017-05-25T02:39:11Z","git_url":"git://github.com/yongtang/tensorflow.git","ssh_url":"git@github.com:yongtang/tensorflow.git","clone_url":"https://github.com/yongtang/tensorflow.git","svn_url":"https://github.com/yongtang/tensorflow","homepage":"http://tensorflow.org","size":106820,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"0b723590631432584d0761c03285eabb55116c6d","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars2.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"name":"tensorflow","full_name":"tensorflow/tensorflow","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars2.githubusercontent.com/u/15658638?v=3","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2017-05-25T03:44:46Z","pushed_at":"2017-05-25T03:12:43Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"http://tensorflow.org","size":106820,"stargazers_count":58361,"watchers_count":58361,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27896,"mirror_url":null,"open_issues_count":1179,"forks":27896,"open_issues":1179,"watchers":58361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/10056"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/10056"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/10056"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/10056/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/10056/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/10056/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/d23fd8763d97960ea67521efc977c57e50b0263c"}}}}
{"actor":{"display_login":"yongtang"}}