{"action":"created","comment":{"url":"https://api.github.com/repos/ravimeda/corefx/pulls/comments/111669059","pull_request_review_id":32930615,"id":111669059,"diff_hunk":"@@ -0,0 +1,69 @@\n+#!/usr/bin/env bash\n+\n+usage()\n+{\n+    echo \"usage: $0 <repository-root> <tool-name> <override-scripts-folder-path> <strict-tool-version-match>\"\n+    echo \"repository-root                   Path to repository root.\"\n+    echo \"tool-name                         Name of the tool to search and/or download.\"\n+    echo \"override-scripts-folder-path      If a path is specified then, search and acquire scripts from the specified folder will be invoked. Otherwise, search will use the default search and acquire scripts located within the repository.\"\n+    echo \"strict-tool-version-match         If equals to \\\"strict\\\" then, search will ensure that the version of the tool searched is the declared version. Otherwise, search will attempt to find a version of the tool, which may not be the declared version.\"\n+    echo \"\"\n+    echo \"Invokes an extension that calls the appropriate search and/or acquire scripts. ToolName and StrictToolVersionMatch are passed on to the extension.\"\n+    echo \"\"\n+    echo \"Example #1\"\n+    echo \"probe-tool.sh \\\"/Users/dotnet/corefx\\\" cmake \"\" \"\"\"\n+    echo \"Probes for CMake, not necessarily the declared version, using the default search and acquire scripts located within the repository.\"\n+    echo \"\"\n+    echo \"Example #2\"\n+    echo \"probe-tool.sh \\\"/Users/dotnet/corefx\\\" cmake \"\" strict\"\n+    echo \"Probes for the declared version of CMake using the default search and acquire scripts located within the repository.\"\n+    echo \"\"\n+    echo \"Example #3\"\n+    echo \"probe-tool.sh \\\"/Users/dotnet/corefx\\\" cmake \\\"/Users/dotnet/MyCustomScripts\\\" strict\"\n+    echo \"Probes for the declared version of CMake using the search and acquire scripts located in \\\"/Users/dotnet/MyCustomScripts\\\".\"\n+    echo \"\"\n+}\n+\n+if [ $# -ne 4 ]; then\n+    usage\n+    exit 1\n+fi\n+\n+repoRoot=\"$(cd \"$1\"; pwd -P)\"\n+toolName=\"$2\"\n+overrideScriptsFolderPath=\"$3\"\n+strictToolVersionMatch=\"$4\"\n+\n+scriptPath=\"$(cd \"$(dirname \"$0\")\"; pwd -P)\"\n+. \"$scriptPath/tool-helper.sh\"\n+\n+exit_if_arg_empty \"repository-root\" \"$repoRoot\"\n+exit_if_arg_empty \"tool-name\" \"$toolName\"\n+\n+if [ ! -z \"$overrideScriptsFolderPath\" ] && [ ! -d \"$overrideScriptsFolderPath\" ]; then","path":"tools-local/unix/probe-tool.sh","position":43,"original_position":43,"commit_id":"1ee4e0b01e65555c05a9610354815c40ae464290","original_commit_id":"1ee4e0b01e65555c05a9610354815c40ae464290","user":{"login":"ravimeda","id":12752450,"avatar_url":"https://avatars2.githubusercontent.com/u/12752450?v=3","gravatar_id":"","url":"https://api.github.com/users/ravimeda","html_url":"https://github.com/ravimeda","followers_url":"https://api.github.com/users/ravimeda/followers","following_url":"https://api.github.com/users/ravimeda/following{/other_user}","gists_url":"https://api.github.com/users/ravimeda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravimeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravimeda/subscriptions","organizations_url":"https://api.github.com/users/ravimeda/orgs","repos_url":"https://api.github.com/users/ravimeda/repos","events_url":"https://api.github.com/users/ravimeda/events{/privacy}","received_events_url":"https://api.github.com/users/ravimeda/received_events","type":"User","site_admin":false},"body":"As discussed offline, validate the given value is a valid directory only if a non-empty string (path) is provided. \r\n\r\n---\r\nIn reply to: [111428605](https://github.com/ravimeda/corefx/pull/9#discussion_r111428605) [](ancestors = 111428605)","created_at":"2017-04-15T17:05:07Z","updated_at":"2017-04-15T17:05:07Z","html_url":"https://github.com/ravimeda/corefx/pull/9#discussion_r111669059","pull_request_url":"https://api.github.com/repos/ravimeda/corefx/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/ravimeda/corefx/pulls/comments/111669059"},"html":{"href":"https://github.com/ravimeda/corefx/pull/9#discussion_r111669059"},"pull_request":{"href":"https://api.github.com/repos/ravimeda/corefx/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/ravimeda/corefx/pulls/9","id":114732751,"html_url":"https://github.com/ravimeda/corefx/pull/9","diff_url":"https://github.com/ravimeda/corefx/pull/9.diff","patch_url":"https://github.com/ravimeda/corefx/pull/9.patch","issue_url":"https://api.github.com/repos/ravimeda/corefx/issues/9","number":9,"state":"open","locked":false,"title":"Addressed comments from PR (#7) Search and acquire build tools.","user":{"login":"ravimeda","id":12752450,"avatar_url":"https://avatars2.githubusercontent.com/u/12752450?v=3","gravatar_id":"","url":"https://api.github.com/users/ravimeda","html_url":"https://github.com/ravimeda","followers_url":"https://api.github.com/users/ravimeda/followers","following_url":"https://api.github.com/users/ravimeda/following{/other_user}","gists_url":"https://api.github.com/users/ravimeda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravimeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravimeda/subscriptions","organizations_url":"https://api.github.com/users/ravimeda/orgs","repos_url":"https://api.github.com/users/ravimeda/repos","events_url":"https://api.github.com/users/ravimeda/events{/privacy}","received_events_url":"https://api.github.com/users/ravimeda/received_events","type":"User","site_admin":false},"body":"This PR addresses the comments in PR https://github.com/ravimeda/corefx/pull/7\r\nSince there were significant changes, I am sending out a fresh PR. Summary of changes:\r\n1. Removed named arguments\r\n2. Repository root is the new argument passed to scripts\r\n\r\nA concern I have with these changes is a few arguments passed to scripts are not used anywhere within the script. These unused arguments are being passed due to the contract `invoke-extensions` maintains. Any suggestions for improvement is greatly appreciated.\r\n\r\n@MichaelSimons two comments from PR https://github.com/ravimeda/corefx/pull/7 on .toolversions file have not been addressed since I'll need some clarification.\r\n\r\n @dagood PTAL.\r\n","created_at":"2017-04-07T02:32:14Z","updated_at":"2017-04-15T17:05:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"188f8e610d81ff2caa7f3b95ee17a89332b204ae","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ravimeda/corefx/pulls/9/commits","review_comments_url":"https://api.github.com/repos/ravimeda/corefx/pulls/9/comments","review_comment_url":"https://api.github.com/repos/ravimeda/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravimeda/corefx/issues/9/comments","statuses_url":"https://api.github.com/repos/ravimeda/corefx/statuses/1ee4e0b01e65555c05a9610354815c40ae464290","head":{"label":"ravimeda:PR7_Comments","ref":"PR7_Comments","sha":"1ee4e0b01e65555c05a9610354815c40ae464290","user":{"login":"ravimeda","id":12752450,"avatar_url":"https://avatars2.githubusercontent.com/u/12752450?v=3","gravatar_id":"","url":"https://api.github.com/users/ravimeda","html_url":"https://github.com/ravimeda","followers_url":"https://api.github.com/users/ravimeda/followers","following_url":"https://api.github.com/users/ravimeda/following{/other_user}","gists_url":"https://api.github.com/users/ravimeda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravimeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravimeda/subscriptions","organizations_url":"https://api.github.com/users/ravimeda/orgs","repos_url":"https://api.github.com/users/ravimeda/repos","events_url":"https://api.github.com/users/ravimeda/events{/privacy}","received_events_url":"https://api.github.com/users/ravimeda/received_events","type":"User","site_admin":false},"repo":{"id":42665934,"name":"corefx","full_name":"ravimeda/corefx","owner":{"login":"ravimeda","id":12752450,"avatar_url":"https://avatars2.githubusercontent.com/u/12752450?v=3","gravatar_id":"","url":"https://api.github.com/users/ravimeda","html_url":"https://github.com/ravimeda","followers_url":"https://api.github.com/users/ravimeda/followers","following_url":"https://api.github.com/users/ravimeda/following{/other_user}","gists_url":"https://api.github.com/users/ravimeda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravimeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravimeda/subscriptions","organizations_url":"https://api.github.com/users/ravimeda/orgs","repos_url":"https://api.github.com/users/ravimeda/repos","events_url":"https://api.github.com/users/ravimeda/events{/privacy}","received_events_url":"https://api.github.com/users/ravimeda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ravimeda/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/ravimeda/corefx","forks_url":"https://api.github.com/repos/ravimeda/corefx/forks","keys_url":"https://api.github.com/repos/ravimeda/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravimeda/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravimeda/corefx/teams","hooks_url":"https://api.github.com/repos/ravimeda/corefx/hooks","issue_events_url":"https://api.github.com/repos/ravimeda/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/ravimeda/corefx/events","assignees_url":"https://api.github.com/repos/ravimeda/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/ravimeda/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/ravimeda/corefx/tags","blobs_url":"https://api.github.com/repos/ravimeda/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravimeda/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravimeda/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravimeda/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravimeda/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/ravimeda/corefx/languages","stargazers_url":"https://api.github.com/repos/ravimeda/corefx/stargazers","contributors_url":"https://api.github.com/repos/ravimeda/corefx/contributors","subscribers_url":"https://api.github.com/repos/ravimeda/corefx/subscribers","subscription_url":"https://api.github.com/repos/ravimeda/corefx/subscription","commits_url":"https://api.github.com/repos/ravimeda/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravimeda/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravimeda/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravimeda/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravimeda/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/ravimeda/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravimeda/corefx/merges","archive_url":"https://api.github.com/repos/ravimeda/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravimeda/corefx/downloads","issues_url":"https://api.github.com/repos/ravimeda/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/ravimeda/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/ravimeda/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/ravimeda/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravimeda/corefx/labels{/name}","releases_url":"https://api.github.com/repos/ravimeda/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/ravimeda/corefx/deployments","created_at":"2015-09-17T15:55:47Z","updated_at":"2016-11-29T01:42:43Z","pushed_at":"2017-04-15T07:03:53Z","git_url":"git://github.com/ravimeda/corefx.git","ssh_url":"git@github.com:ravimeda/corefx.git","clone_url":"https://github.com/ravimeda/corefx.git","svn_url":"https://github.com/ravimeda/corefx","homepage":"http://dotnet.github.io/core/","size":135531,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ravimeda:master","ref":"master","sha":"64cb97b454b160a6a7b5045a2d499d6ac002b919","user":{"login":"ravimeda","id":12752450,"avatar_url":"https://avatars2.githubusercontent.com/u/12752450?v=3","gravatar_id":"","url":"https://api.github.com/users/ravimeda","html_url":"https://github.com/ravimeda","followers_url":"https://api.github.com/users/ravimeda/followers","following_url":"https://api.github.com/users/ravimeda/following{/other_user}","gists_url":"https://api.github.com/users/ravimeda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravimeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravimeda/subscriptions","organizations_url":"https://api.github.com/users/ravimeda/orgs","repos_url":"https://api.github.com/users/ravimeda/repos","events_url":"https://api.github.com/users/ravimeda/events{/privacy}","received_events_url":"https://api.github.com/users/ravimeda/received_events","type":"User","site_admin":false},"repo":{"id":42665934,"name":"corefx","full_name":"ravimeda/corefx","owner":{"login":"ravimeda","id":12752450,"avatar_url":"https://avatars2.githubusercontent.com/u/12752450?v=3","gravatar_id":"","url":"https://api.github.com/users/ravimeda","html_url":"https://github.com/ravimeda","followers_url":"https://api.github.com/users/ravimeda/followers","following_url":"https://api.github.com/users/ravimeda/following{/other_user}","gists_url":"https://api.github.com/users/ravimeda/gists{/gist_id}","starred_url":"https://api.github.com/users/ravimeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravimeda/subscriptions","organizations_url":"https://api.github.com/users/ravimeda/orgs","repos_url":"https://api.github.com/users/ravimeda/repos","events_url":"https://api.github.com/users/ravimeda/events{/privacy}","received_events_url":"https://api.github.com/users/ravimeda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ravimeda/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/ravimeda/corefx","forks_url":"https://api.github.com/repos/ravimeda/corefx/forks","keys_url":"https://api.github.com/repos/ravimeda/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravimeda/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravimeda/corefx/teams","hooks_url":"https://api.github.com/repos/ravimeda/corefx/hooks","issue_events_url":"https://api.github.com/repos/ravimeda/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/ravimeda/corefx/events","assignees_url":"https://api.github.com/repos/ravimeda/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/ravimeda/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/ravimeda/corefx/tags","blobs_url":"https://api.github.com/repos/ravimeda/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravimeda/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravimeda/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravimeda/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravimeda/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/ravimeda/corefx/languages","stargazers_url":"https://api.github.com/repos/ravimeda/corefx/stargazers","contributors_url":"https://api.github.com/repos/ravimeda/corefx/contributors","subscribers_url":"https://api.github.com/repos/ravimeda/corefx/subscribers","subscription_url":"https://api.github.com/repos/ravimeda/corefx/subscription","commits_url":"https://api.github.com/repos/ravimeda/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravimeda/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravimeda/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravimeda/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravimeda/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/ravimeda/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravimeda/corefx/merges","archive_url":"https://api.github.com/repos/ravimeda/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravimeda/corefx/downloads","issues_url":"https://api.github.com/repos/ravimeda/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/ravimeda/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/ravimeda/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/ravimeda/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravimeda/corefx/labels{/name}","releases_url":"https://api.github.com/repos/ravimeda/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/ravimeda/corefx/deployments","created_at":"2015-09-17T15:55:47Z","updated_at":"2016-11-29T01:42:43Z","pushed_at":"2017-04-15T07:03:53Z","git_url":"git://github.com/ravimeda/corefx.git","ssh_url":"git@github.com:ravimeda/corefx.git","clone_url":"https://github.com/ravimeda/corefx.git","svn_url":"https://github.com/ravimeda/corefx","homepage":"http://dotnet.github.io/core/","size":135531,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ravimeda/corefx/pulls/9"},"html":{"href":"https://github.com/ravimeda/corefx/pull/9"},"issue":{"href":"https://api.github.com/repos/ravimeda/corefx/issues/9"},"comments":{"href":"https://api.github.com/repos/ravimeda/corefx/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/ravimeda/corefx/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/ravimeda/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravimeda/corefx/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/ravimeda/corefx/statuses/1ee4e0b01e65555c05a9610354815c40ae464290"}}}}
{"actor":{"display_login":"ravimeda"}}