{"action":"created","comment":{"url":"https://api.github.com/repos/slide-rs/specs/pulls/comments/151707725","pull_request_review_id":77459902,"id":151707725,"diff_hunk":"@@ -148,6 +150,62 @@ impl<T: Component> Drop for MaskedStorage<T> {\n     }\n }\n \n+#[derive(Derivative)]\n+#[derivative(Default(bound = \"\"))]\n+/// Associates the component's storage with its metadata.\n+pub struct WrappedStorage<T: Component> {","path":"src/storage/mod.rs","position":67,"original_position":67,"commit_id":"203eda5bfab3858627eafbac36b964b861a0bd14","original_commit_id":"203eda5bfab3858627eafbac36b964b861a0bd14","user":{"login":"torkleyy","id":23152057,"avatar_url":"https://avatars1.githubusercontent.com/u/23152057?v=4","gravatar_id":"","url":"https://api.github.com/users/torkleyy","html_url":"https://github.com/torkleyy","followers_url":"https://api.github.com/users/torkleyy/followers","following_url":"https://api.github.com/users/torkleyy/following{/other_user}","gists_url":"https://api.github.com/users/torkleyy/gists{/gist_id}","starred_url":"https://api.github.com/users/torkleyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torkleyy/subscriptions","organizations_url":"https://api.github.com/users/torkleyy/orgs","repos_url":"https://api.github.com/users/torkleyy/repos","events_url":"https://api.github.com/users/torkleyy/events{/privacy}","received_events_url":"https://api.github.com/users/torkleyy/received_events","type":"User","site_admin":false},"body":"I don't see why we need such a type.","created_at":"2017-11-17T15:11:52Z","updated_at":"2017-11-17T15:15:05Z","html_url":"https://github.com/slide-rs/specs/pull/301#discussion_r151707725","pull_request_url":"https://api.github.com/repos/slide-rs/specs/pulls/301","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/slide-rs/specs/pulls/comments/151707725"},"html":{"href":"https://github.com/slide-rs/specs/pull/301#discussion_r151707725"},"pull_request":{"href":"https://api.github.com/repos/slide-rs/specs/pulls/301"}}},"pull_request":{"url":"https://api.github.com/repos/slide-rs/specs/pulls/301","id":152692060,"html_url":"https://github.com/slide-rs/specs/pull/301","diff_url":"https://github.com/slide-rs/specs/pull/301.diff","patch_url":"https://github.com/slide-rs/specs/pull/301.patch","issue_url":"https://api.github.com/repos/slide-rs/specs/issues/301","number":301,"state":"open","locked":false,"title":"Metadata","user":{"login":"Aceeri","id":5142292,"avatar_url":"https://avatars3.githubusercontent.com/u/5142292?v=4","gravatar_id":"","url":"https://api.github.com/users/Aceeri","html_url":"https://github.com/Aceeri","followers_url":"https://api.github.com/users/Aceeri/followers","following_url":"https://api.github.com/users/Aceeri/following{/other_user}","gists_url":"https://api.github.com/users/Aceeri/gists{/gist_id}","starred_url":"https://api.github.com/users/Aceeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aceeri/subscriptions","organizations_url":"https://api.github.com/users/Aceeri/orgs","repos_url":"https://api.github.com/users/Aceeri/repos","events_url":"https://api.github.com/users/Aceeri/events{/privacy}","received_events_url":"https://api.github.com/users/Aceeri/received_events","type":"User","site_admin":false},"body":"Moves the wrapper storages into their own separate \"observing\" structures. This is a breaking change due to no default associated types, but I think it might be better for ergonomics.\r\n\r\nChecks won't pass right now, still need to update the docs and such. Somewhat of a proof of concept right now.\r\n\r\nfixes https://github.com/slide-rs/specs/issues/232","created_at":"2017-11-15T06:06:56Z","updated_at":"2017-11-17T15:15:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4830f5ab1e85d83dd271b30c06463adc9758870a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/slide-rs/specs/pulls/301/commits","review_comments_url":"https://api.github.com/repos/slide-rs/specs/pulls/301/comments","review_comment_url":"https://api.github.com/repos/slide-rs/specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slide-rs/specs/issues/301/comments","statuses_url":"https://api.github.com/repos/slide-rs/specs/statuses/203eda5bfab3858627eafbac36b964b861a0bd14","head":{"label":"Aceeri:side","ref":"side","sha":"203eda5bfab3858627eafbac36b964b861a0bd14","user":{"login":"Aceeri","id":5142292,"avatar_url":"https://avatars3.githubusercontent.com/u/5142292?v=4","gravatar_id":"","url":"https://api.github.com/users/Aceeri","html_url":"https://github.com/Aceeri","followers_url":"https://api.github.com/users/Aceeri/followers","following_url":"https://api.github.com/users/Aceeri/following{/other_user}","gists_url":"https://api.github.com/users/Aceeri/gists{/gist_id}","starred_url":"https://api.github.com/users/Aceeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aceeri/subscriptions","organizations_url":"https://api.github.com/users/Aceeri/orgs","repos_url":"https://api.github.com/users/Aceeri/repos","events_url":"https://api.github.com/users/Aceeri/events{/privacy}","received_events_url":"https://api.github.com/users/Aceeri/received_events","type":"User","site_admin":false},"repo":{"id":71599566,"name":"specs","full_name":"Aceeri/specs","owner":{"login":"Aceeri","id":5142292,"avatar_url":"https://avatars3.githubusercontent.com/u/5142292?v=4","gravatar_id":"","url":"https://api.github.com/users/Aceeri","html_url":"https://github.com/Aceeri","followers_url":"https://api.github.com/users/Aceeri/followers","following_url":"https://api.github.com/users/Aceeri/following{/other_user}","gists_url":"https://api.github.com/users/Aceeri/gists{/gist_id}","starred_url":"https://api.github.com/users/Aceeri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aceeri/subscriptions","organizations_url":"https://api.github.com/users/Aceeri/orgs","repos_url":"https://api.github.com/users/Aceeri/repos","events_url":"https://api.github.com/users/Aceeri/events{/privacy}","received_events_url":"https://api.github.com/users/Aceeri/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Aceeri/specs","description":"Specs - Parallel ECS","fork":true,"url":"https://api.github.com/repos/Aceeri/specs","forks_url":"https://api.github.com/repos/Aceeri/specs/forks","keys_url":"https://api.github.com/repos/Aceeri/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Aceeri/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Aceeri/specs/teams","hooks_url":"https://api.github.com/repos/Aceeri/specs/hooks","issue_events_url":"https://api.github.com/repos/Aceeri/specs/issues/events{/number}","events_url":"https://api.github.com/repos/Aceeri/specs/events","assignees_url":"https://api.github.com/repos/Aceeri/specs/assignees{/user}","branches_url":"https://api.github.com/repos/Aceeri/specs/branches{/branch}","tags_url":"https://api.github.com/repos/Aceeri/specs/tags","blobs_url":"https://api.github.com/repos/Aceeri/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Aceeri/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Aceeri/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Aceeri/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Aceeri/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/Aceeri/specs/languages","stargazers_url":"https://api.github.com/repos/Aceeri/specs/stargazers","contributors_url":"https://api.github.com/repos/Aceeri/specs/contributors","subscribers_url":"https://api.github.com/repos/Aceeri/specs/subscribers","subscription_url":"https://api.github.com/repos/Aceeri/specs/subscription","commits_url":"https://api.github.com/repos/Aceeri/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Aceeri/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Aceeri/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Aceeri/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Aceeri/specs/contents/{+path}","compare_url":"https://api.github.com/repos/Aceeri/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Aceeri/specs/merges","archive_url":"https://api.github.com/repos/Aceeri/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Aceeri/specs/downloads","issues_url":"https://api.github.com/repos/Aceeri/specs/issues{/number}","pulls_url":"https://api.github.com/repos/Aceeri/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/Aceeri/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/Aceeri/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Aceeri/specs/labels{/name}","releases_url":"https://api.github.com/repos/Aceeri/specs/releases{/id}","deployments_url":"https://api.github.com/repos/Aceeri/specs/deployments","created_at":"2016-10-21T21:51:30Z","updated_at":"2016-10-21T21:51:31Z","pushed_at":"2017-11-17T07:25:17Z","git_url":"git://github.com/Aceeri/specs.git","ssh_url":"git@github.com:Aceeri/specs.git","clone_url":"https://github.com/Aceeri/specs.git","svn_url":"https://github.com/Aceeri/specs","homepage":"https://slide-rs.github.io/specs/","size":2920,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slide-rs:master","ref":"master","sha":"1d0a8997741956e3d6445de09527fe7bce3408fc","user":{"login":"slide-rs","id":12649318,"avatar_url":"https://avatars3.githubusercontent.com/u/12649318?v=4","gravatar_id":"","url":"https://api.github.com/users/slide-rs","html_url":"https://github.com/slide-rs","followers_url":"https://api.github.com/users/slide-rs/followers","following_url":"https://api.github.com/users/slide-rs/following{/other_user}","gists_url":"https://api.github.com/users/slide-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/slide-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slide-rs/subscriptions","organizations_url":"https://api.github.com/users/slide-rs/orgs","repos_url":"https://api.github.com/users/slide-rs/repos","events_url":"https://api.github.com/users/slide-rs/events{/privacy}","received_events_url":"https://api.github.com/users/slide-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":55565443,"name":"specs","full_name":"slide-rs/specs","owner":{"login":"slide-rs","id":12649318,"avatar_url":"https://avatars3.githubusercontent.com/u/12649318?v=4","gravatar_id":"","url":"https://api.github.com/users/slide-rs","html_url":"https://github.com/slide-rs","followers_url":"https://api.github.com/users/slide-rs/followers","following_url":"https://api.github.com/users/slide-rs/following{/other_user}","gists_url":"https://api.github.com/users/slide-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/slide-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slide-rs/subscriptions","organizations_url":"https://api.github.com/users/slide-rs/orgs","repos_url":"https://api.github.com/users/slide-rs/repos","events_url":"https://api.github.com/users/slide-rs/events{/privacy}","received_events_url":"https://api.github.com/users/slide-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slide-rs/specs","description":"Specs - Parallel ECS","fork":false,"url":"https://api.github.com/repos/slide-rs/specs","forks_url":"https://api.github.com/repos/slide-rs/specs/forks","keys_url":"https://api.github.com/repos/slide-rs/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slide-rs/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slide-rs/specs/teams","hooks_url":"https://api.github.com/repos/slide-rs/specs/hooks","issue_events_url":"https://api.github.com/repos/slide-rs/specs/issues/events{/number}","events_url":"https://api.github.com/repos/slide-rs/specs/events","assignees_url":"https://api.github.com/repos/slide-rs/specs/assignees{/user}","branches_url":"https://api.github.com/repos/slide-rs/specs/branches{/branch}","tags_url":"https://api.github.com/repos/slide-rs/specs/tags","blobs_url":"https://api.github.com/repos/slide-rs/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slide-rs/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slide-rs/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/slide-rs/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slide-rs/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/slide-rs/specs/languages","stargazers_url":"https://api.github.com/repos/slide-rs/specs/stargazers","contributors_url":"https://api.github.com/repos/slide-rs/specs/contributors","subscribers_url":"https://api.github.com/repos/slide-rs/specs/subscribers","subscription_url":"https://api.github.com/repos/slide-rs/specs/subscription","commits_url":"https://api.github.com/repos/slide-rs/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/slide-rs/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/slide-rs/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/slide-rs/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/slide-rs/specs/contents/{+path}","compare_url":"https://api.github.com/repos/slide-rs/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slide-rs/specs/merges","archive_url":"https://api.github.com/repos/slide-rs/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slide-rs/specs/downloads","issues_url":"https://api.github.com/repos/slide-rs/specs/issues{/number}","pulls_url":"https://api.github.com/repos/slide-rs/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/slide-rs/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/slide-rs/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slide-rs/specs/labels{/name}","releases_url":"https://api.github.com/repos/slide-rs/specs/releases{/id}","deployments_url":"https://api.github.com/repos/slide-rs/specs/deployments","created_at":"2016-04-06T01:06:31Z","updated_at":"2017-11-16T16:47:25Z","pushed_at":"2017-11-17T07:25:18Z","git_url":"git://github.com/slide-rs/specs.git","ssh_url":"git@github.com:slide-rs/specs.git","clone_url":"https://github.com/slide-rs/specs.git","svn_url":"https://github.com/slide-rs/specs","homepage":"https://slide-rs.github.io/","size":6804,"stargazers_count":397,"watchers_count":397,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":17,"forks":49,"open_issues":17,"watchers":397,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slide-rs/specs/pulls/301"},"html":{"href":"https://github.com/slide-rs/specs/pull/301"},"issue":{"href":"https://api.github.com/repos/slide-rs/specs/issues/301"},"comments":{"href":"https://api.github.com/repos/slide-rs/specs/issues/301/comments"},"review_comments":{"href":"https://api.github.com/repos/slide-rs/specs/pulls/301/comments"},"review_comment":{"href":"https://api.github.com/repos/slide-rs/specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slide-rs/specs/pulls/301/commits"},"statuses":{"href":"https://api.github.com/repos/slide-rs/specs/statuses/203eda5bfab3858627eafbac36b964b861a0bd14"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"torkleyy"}}