{"action":"opened","number":116,"pull_request":{"url":"https://api.github.com/repos/aspnet/WebHooks/pulls/116","id":105945469,"html_url":"https://github.com/aspnet/WebHooks/pull/116","diff_url":"https://github.com/aspnet/WebHooks/pull/116.diff","patch_url":"https://github.com/aspnet/WebHooks/pull/116.patch","issue_url":"https://api.github.com/repos/aspnet/WebHooks/issues/116","number":116,"state":"open","locked":false,"title":"Await for the response messages and then put responses into list.","user":{"login":"petetheman79","id":12416318,"avatar_url":"https://avatars.githubusercontent.com/u/12416318?v=3","gravatar_id":"","url":"https://api.github.com/users/petetheman79","html_url":"https://github.com/petetheman79","followers_url":"https://api.github.com/users/petetheman79/followers","following_url":"https://api.github.com/users/petetheman79/following{/other_user}","gists_url":"https://api.github.com/users/petetheman79/gists{/gist_id}","starred_url":"https://api.github.com/users/petetheman79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petetheman79/subscriptions","organizations_url":"https://api.github.com/users/petetheman79/orgs","repos_url":"https://api.github.com/users/petetheman79/repos","events_url":"https://api.github.com/users/petetheman79/events{/privacy}","received_events_url":"https://api.github.com/users/petetheman79/received_events","type":"User","site_admin":false},"body":"When a WebHook is added with an invalid Uri (host does not exist etc) by using the noecho feature so that the WebHook uri is not validated, when the WebHookSender sends the message an exception is thrown in AzureWebHookDequeueManager line 281 when waiting for all Tasks to complete. This causes the rest of the code to not be executed. This causes a situation where all messages are resent indefinitely causing duplicate messages to be transmitted.\r\n\r\nThe solution that I have is to remove the Task.WhenAll(requestTasks) and rather to await on the _parent._httpClient.SendAsync(request) to ensure that exceptions while posting are handled in the exception handling block.","created_at":"2017-02-13T17:53:52Z","updated_at":"2017-02-13T17:53:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/WebHooks/pulls/116/commits","review_comments_url":"https://api.github.com/repos/aspnet/WebHooks/pulls/116/comments","review_comment_url":"https://api.github.com/repos/aspnet/WebHooks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/WebHooks/issues/116/comments","statuses_url":"https://api.github.com/repos/aspnet/WebHooks/statuses/559dbf6a5347a84f8b645ca3567d02c7b99b0e10","head":{"label":"petetheman79:fix_duplicatemessages","ref":"fix_duplicatemessages","sha":"559dbf6a5347a84f8b645ca3567d02c7b99b0e10","user":{"login":"petetheman79","id":12416318,"avatar_url":"https://avatars.githubusercontent.com/u/12416318?v=3","gravatar_id":"","url":"https://api.github.com/users/petetheman79","html_url":"https://github.com/petetheman79","followers_url":"https://api.github.com/users/petetheman79/followers","following_url":"https://api.github.com/users/petetheman79/following{/other_user}","gists_url":"https://api.github.com/users/petetheman79/gists{/gist_id}","starred_url":"https://api.github.com/users/petetheman79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petetheman79/subscriptions","organizations_url":"https://api.github.com/users/petetheman79/orgs","repos_url":"https://api.github.com/users/petetheman79/repos","events_url":"https://api.github.com/users/petetheman79/events{/privacy}","received_events_url":"https://api.github.com/users/petetheman79/received_events","type":"User","site_admin":false},"repo":{"id":81846949,"name":"WebHooks","full_name":"petetheman79/WebHooks","owner":{"login":"petetheman79","id":12416318,"avatar_url":"https://avatars.githubusercontent.com/u/12416318?v=3","gravatar_id":"","url":"https://api.github.com/users/petetheman79","html_url":"https://github.com/petetheman79","followers_url":"https://api.github.com/users/petetheman79/followers","following_url":"https://api.github.com/users/petetheman79/following{/other_user}","gists_url":"https://api.github.com/users/petetheman79/gists{/gist_id}","starred_url":"https://api.github.com/users/petetheman79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petetheman79/subscriptions","organizations_url":"https://api.github.com/users/petetheman79/orgs","repos_url":"https://api.github.com/users/petetheman79/repos","events_url":"https://api.github.com/users/petetheman79/events{/privacy}","received_events_url":"https://api.github.com/users/petetheman79/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petetheman79/WebHooks","description":"Libraries to create and consume web hooks","fork":true,"url":"https://api.github.com/repos/petetheman79/WebHooks","forks_url":"https://api.github.com/repos/petetheman79/WebHooks/forks","keys_url":"https://api.github.com/repos/petetheman79/WebHooks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petetheman79/WebHooks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petetheman79/WebHooks/teams","hooks_url":"https://api.github.com/repos/petetheman79/WebHooks/hooks","issue_events_url":"https://api.github.com/repos/petetheman79/WebHooks/issues/events{/number}","events_url":"https://api.github.com/repos/petetheman79/WebHooks/events","assignees_url":"https://api.github.com/repos/petetheman79/WebHooks/assignees{/user}","branches_url":"https://api.github.com/repos/petetheman79/WebHooks/branches{/branch}","tags_url":"https://api.github.com/repos/petetheman79/WebHooks/tags","blobs_url":"https://api.github.com/repos/petetheman79/WebHooks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petetheman79/WebHooks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petetheman79/WebHooks/git/refs{/sha}","trees_url":"https://api.github.com/repos/petetheman79/WebHooks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petetheman79/WebHooks/statuses/{sha}","languages_url":"https://api.github.com/repos/petetheman79/WebHooks/languages","stargazers_url":"https://api.github.com/repos/petetheman79/WebHooks/stargazers","contributors_url":"https://api.github.com/repos/petetheman79/WebHooks/contributors","subscribers_url":"https://api.github.com/repos/petetheman79/WebHooks/subscribers","subscription_url":"https://api.github.com/repos/petetheman79/WebHooks/subscription","commits_url":"https://api.github.com/repos/petetheman79/WebHooks/commits{/sha}","git_commits_url":"https://api.github.com/repos/petetheman79/WebHooks/git/commits{/sha}","comments_url":"https://api.github.com/repos/petetheman79/WebHooks/comments{/number}","issue_comment_url":"https://api.github.com/repos/petetheman79/WebHooks/issues/comments{/number}","contents_url":"https://api.github.com/repos/petetheman79/WebHooks/contents/{+path}","compare_url":"https://api.github.com/repos/petetheman79/WebHooks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petetheman79/WebHooks/merges","archive_url":"https://api.github.com/repos/petetheman79/WebHooks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petetheman79/WebHooks/downloads","issues_url":"https://api.github.com/repos/petetheman79/WebHooks/issues{/number}","pulls_url":"https://api.github.com/repos/petetheman79/WebHooks/pulls{/number}","milestones_url":"https://api.github.com/repos/petetheman79/WebHooks/milestones{/number}","notifications_url":"https://api.github.com/repos/petetheman79/WebHooks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petetheman79/WebHooks/labels{/name}","releases_url":"https://api.github.com/repos/petetheman79/WebHooks/releases{/id}","deployments_url":"https://api.github.com/repos/petetheman79/WebHooks/deployments","created_at":"2017-02-13T16:39:03Z","updated_at":"2017-02-13T16:39:06Z","pushed_at":"2017-02-13T16:45:59Z","git_url":"git://github.com/petetheman79/WebHooks.git","ssh_url":"git@github.com:petetheman79/WebHooks.git","clone_url":"https://github.com/petetheman79/WebHooks.git","svn_url":"https://github.com/petetheman79/WebHooks","homepage":null,"size":1607,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aspnet:master","ref":"master","sha":"547c225b558040997a9dbcdd98eff01e8f3d188e","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":39802789,"name":"WebHooks","full_name":"aspnet/WebHooks","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/WebHooks","description":"Libraries to create and consume web hooks","fork":false,"url":"https://api.github.com/repos/aspnet/WebHooks","forks_url":"https://api.github.com/repos/aspnet/WebHooks/forks","keys_url":"https://api.github.com/repos/aspnet/WebHooks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/WebHooks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/WebHooks/teams","hooks_url":"https://api.github.com/repos/aspnet/WebHooks/hooks","issue_events_url":"https://api.github.com/repos/aspnet/WebHooks/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/WebHooks/events","assignees_url":"https://api.github.com/repos/aspnet/WebHooks/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/WebHooks/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/WebHooks/tags","blobs_url":"https://api.github.com/repos/aspnet/WebHooks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/WebHooks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/WebHooks/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/WebHooks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/WebHooks/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/WebHooks/languages","stargazers_url":"https://api.github.com/repos/aspnet/WebHooks/stargazers","contributors_url":"https://api.github.com/repos/aspnet/WebHooks/contributors","subscribers_url":"https://api.github.com/repos/aspnet/WebHooks/subscribers","subscription_url":"https://api.github.com/repos/aspnet/WebHooks/subscription","commits_url":"https://api.github.com/repos/aspnet/WebHooks/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/WebHooks/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/WebHooks/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/WebHooks/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/WebHooks/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/WebHooks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/WebHooks/merges","archive_url":"https://api.github.com/repos/aspnet/WebHooks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/WebHooks/downloads","issues_url":"https://api.github.com/repos/aspnet/WebHooks/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/WebHooks/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/WebHooks/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/WebHooks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/WebHooks/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/WebHooks/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/WebHooks/deployments","created_at":"2015-07-27T23:27:08Z","updated_at":"2017-02-13T02:22:07Z","pushed_at":"2017-01-11T05:37:06Z","git_url":"git://github.com/aspnet/WebHooks.git","ssh_url":"git@github.com:aspnet/WebHooks.git","clone_url":"https://github.com/aspnet/WebHooks.git","svn_url":"https://github.com/aspnet/WebHooks","homepage":null,"size":1607,"stargazers_count":376,"watchers_count":376,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":170,"mirror_url":null,"open_issues_count":34,"forks":170,"open_issues":34,"watchers":376,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/WebHooks/pulls/116"},"html":{"href":"https://github.com/aspnet/WebHooks/pull/116"},"issue":{"href":"https://api.github.com/repos/aspnet/WebHooks/issues/116"},"comments":{"href":"https://api.github.com/repos/aspnet/WebHooks/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/WebHooks/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/WebHooks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/WebHooks/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/WebHooks/statuses/559dbf6a5347a84f8b645ca3567d02c7b99b0e10"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":8,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"petetheman79"}}