{"action":"created","comment":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/comments/114616809","pull_request_review_id":36098566,"id":114616809,"diff_hunk":"@@ -387,6 +387,12 @@ rcv_priority_frame(Http2ConnectionState &cstate, const Http2Frame &frame)\n                       \"priority parse error\");\n   }\n \n+  //  A stream cannot depend on itself.  An endpoint MUST treat this as a stream error of type PROTOCOL_ERROR.\n+  if (stream_id == priority.stream_dependency) {\n+    return Http2Error(Http2ErrorClass::HTTP2_ERROR_CLASS_CONNECTION, Http2ErrorCode::HTTP2_ERROR_PROTOCOL_ERROR,","path":"proxy/http2/Http2ConnectionState.cc","position":null,"original_position":6,"commit_id":"48f3b1b78d9eb63993b0c30bf3af06cbc36f88ae","original_commit_id":"4a089fdc41af3cad9c7f0744cfc2046b400ef252","user":{"login":"zizhong","id":3625100,"avatar_url":"https://avatars0.githubusercontent.com/u/3625100?v=3","gravatar_id":"","url":"https://api.github.com/users/zizhong","html_url":"https://github.com/zizhong","followers_url":"https://api.github.com/users/zizhong/followers","following_url":"https://api.github.com/users/zizhong/following{/other_user}","gists_url":"https://api.github.com/users/zizhong/gists{/gist_id}","starred_url":"https://api.github.com/users/zizhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zizhong/subscriptions","organizations_url":"https://api.github.com/users/zizhong/orgs","repos_url":"https://api.github.com/users/zizhong/repos","events_url":"https://api.github.com/users/zizhong/events{/privacy}","received_events_url":"https://api.github.com/users/zizhong/received_events","type":"User","site_admin":false},"body":"@maskit Thanks! Fixed.","created_at":"2017-05-03T18:18:44Z","updated_at":"2017-05-03T18:18:45Z","html_url":"https://github.com/apache/trafficserver/pull/1752#discussion_r114616809","pull_request_url":"https://api.github.com/repos/apache/trafficserver/pulls/1752","_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments/114616809"},"html":{"href":"https://github.com/apache/trafficserver/pull/1752#discussion_r114616809"},"pull_request":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/1752"}}},"pull_request":{"url":"https://api.github.com/repos/apache/trafficserver/pulls/1752","id":118663865,"html_url":"https://github.com/apache/trafficserver/pull/1752","diff_url":"https://github.com/apache/trafficserver/pull/1752.diff","patch_url":"https://github.com/apache/trafficserver/pull/1752.patch","issue_url":"https://api.github.com/repos/apache/trafficserver/issues/1752","number":1752,"state":"open","locked":false,"title":"h2spec: handling PRIORITY frame that depend on itself","user":{"login":"zizhong","id":3625100,"avatar_url":"https://avatars0.githubusercontent.com/u/3625100?v=3","gravatar_id":"","url":"https://api.github.com/users/zizhong","html_url":"https://github.com/zizhong","followers_url":"https://api.github.com/users/zizhong/followers","following_url":"https://api.github.com/users/zizhong/following{/other_user}","gists_url":"https://api.github.com/users/zizhong/gists{/gist_id}","starred_url":"https://api.github.com/users/zizhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zizhong/subscriptions","organizations_url":"https://api.github.com/users/zizhong/orgs","repos_url":"https://api.github.com/users/zizhong/repos","events_url":"https://api.github.com/users/zizhong/events{/privacy}","received_events_url":"https://api.github.com/users/zizhong/received_events","type":"User","site_admin":false},"body":"The issue reported by `h2spec` is\r\n```Hypertext Transfer Protocol Version 2 (HTTP/2)\r\n  5. Streams and Multiplexing\r\n    5.3. Stream Priority\r\n      5.3.1. Stream Dependencies\r\n        × 2: Sends PRIORITY frame that depend on itself\r\n          -> The endpoint MUST treat this as a stream error of type PROTOCOL_ERROR.\r\n             Expected: GOAWAY Frame (Error Code: PROTOCOL_ERROR)\r\n                       RST_STREAM Frame (Error Code: PROTOCOL_ERROR)\r\n                       Connection closed\r\n               Actual: Timeout\r\n```\r\nWith this fix,\r\n```\r\nHypertext Transfer Protocol Version 2 (HTTP/2)\r\n  5. Streams and Multiplexing\r\n    5.3. Stream Priority\r\n      5.3.1. Stream Dependencies\r\n             [send] SETTINGS Frame (length:6, flags:0x00, stream_id:0)\r\n             [recv] SETTINGS Frame (length:12, flags:0x00, stream_id:0)\r\n             [send] SETTINGS Frame (length:0, flags:0x01, stream_id:0)\r\n             [recv] WINDOW_UPDATE Frame (length:4, flags:0x00, stream_id:0)\r\n             [recv] SETTINGS Frame (length:0, flags:0x01, stream_id:0)\r\n             [send] PRIORITY Frame (length:5, flags:0x00, stream_id:1)\r\n             [recv] Connection closed\r\n        ✔ 2: Sends PRIORITY frame that depend on itself\r\n\r\nFinished in 0.0501 seconds\r\n1 tests, 1 passed, 0 skipped, 0 failed\r\n```\r\n","created_at":"2017-05-02T22:55:40Z","updated_at":"2017-05-03T18:18:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a1651a99cddc7ea90afa33850eb1c40a1e4c31f","assignee":{"login":"zizhong","id":3625100,"avatar_url":"https://avatars0.githubusercontent.com/u/3625100?v=3","gravatar_id":"","url":"https://api.github.com/users/zizhong","html_url":"https://github.com/zizhong","followers_url":"https://api.github.com/users/zizhong/followers","following_url":"https://api.github.com/users/zizhong/following{/other_user}","gists_url":"https://api.github.com/users/zizhong/gists{/gist_id}","starred_url":"https://api.github.com/users/zizhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zizhong/subscriptions","organizations_url":"https://api.github.com/users/zizhong/orgs","repos_url":"https://api.github.com/users/zizhong/repos","events_url":"https://api.github.com/users/zizhong/events{/privacy}","received_events_url":"https://api.github.com/users/zizhong/received_events","type":"User","site_admin":false},"assignees":[{"login":"zizhong","id":3625100,"avatar_url":"https://avatars0.githubusercontent.com/u/3625100?v=3","gravatar_id":"","url":"https://api.github.com/users/zizhong","html_url":"https://github.com/zizhong","followers_url":"https://api.github.com/users/zizhong/followers","following_url":"https://api.github.com/users/zizhong/following{/other_user}","gists_url":"https://api.github.com/users/zizhong/gists{/gist_id}","starred_url":"https://api.github.com/users/zizhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zizhong/subscriptions","organizations_url":"https://api.github.com/users/zizhong/orgs","repos_url":"https://api.github.com/users/zizhong/repos","events_url":"https://api.github.com/users/zizhong/events{/privacy}","received_events_url":"https://api.github.com/users/zizhong/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/apache/trafficserver/milestones/6","html_url":"https://github.com/apache/trafficserver/milestone/6","labels_url":"https://api.github.com/repos/apache/trafficserver/milestones/6/labels","id":1763406,"number":6,"title":"8.0.0","description":"","creator":{"login":"zwoop","id":202131,"avatar_url":"https://avatars2.githubusercontent.com/u/202131?v=3","gravatar_id":"","url":"https://api.github.com/users/zwoop","html_url":"https://github.com/zwoop","followers_url":"https://api.github.com/users/zwoop/followers","following_url":"https://api.github.com/users/zwoop/following{/other_user}","gists_url":"https://api.github.com/users/zwoop/gists{/gist_id}","starred_url":"https://api.github.com/users/zwoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwoop/subscriptions","organizations_url":"https://api.github.com/users/zwoop/orgs","repos_url":"https://api.github.com/users/zwoop/repos","events_url":"https://api.github.com/users/zwoop/events{/privacy}","received_events_url":"https://api.github.com/users/zwoop/received_events","type":"User","site_admin":false},"open_issues":78,"closed_issues":156,"state":"open","created_at":"2016-05-12T22:13:34Z","updated_at":"2017-05-03T02:35:26Z","due_on":"2017-10-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/trafficserver/pulls/1752/commits","review_comments_url":"https://api.github.com/repos/apache/trafficserver/pulls/1752/comments","review_comment_url":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/trafficserver/issues/1752/comments","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/48f3b1b78d9eb63993b0c30bf3af06cbc36f88ae","head":{"label":"zizhong:http2spec_5.3.2","ref":"http2spec_5.3.2","sha":"48f3b1b78d9eb63993b0c30bf3af06cbc36f88ae","user":{"login":"zizhong","id":3625100,"avatar_url":"https://avatars0.githubusercontent.com/u/3625100?v=3","gravatar_id":"","url":"https://api.github.com/users/zizhong","html_url":"https://github.com/zizhong","followers_url":"https://api.github.com/users/zizhong/followers","following_url":"https://api.github.com/users/zizhong/following{/other_user}","gists_url":"https://api.github.com/users/zizhong/gists{/gist_id}","starred_url":"https://api.github.com/users/zizhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zizhong/subscriptions","organizations_url":"https://api.github.com/users/zizhong/orgs","repos_url":"https://api.github.com/users/zizhong/repos","events_url":"https://api.github.com/users/zizhong/events{/privacy}","received_events_url":"https://api.github.com/users/zizhong/received_events","type":"User","site_admin":false},"repo":{"id":39374537,"name":"trafficserver","full_name":"zizhong/trafficserver","owner":{"login":"zizhong","id":3625100,"avatar_url":"https://avatars0.githubusercontent.com/u/3625100?v=3","gravatar_id":"","url":"https://api.github.com/users/zizhong","html_url":"https://github.com/zizhong","followers_url":"https://api.github.com/users/zizhong/followers","following_url":"https://api.github.com/users/zizhong/following{/other_user}","gists_url":"https://api.github.com/users/zizhong/gists{/gist_id}","starred_url":"https://api.github.com/users/zizhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zizhong/subscriptions","organizations_url":"https://api.github.com/users/zizhong/orgs","repos_url":"https://api.github.com/users/zizhong/repos","events_url":"https://api.github.com/users/zizhong/events{/privacy}","received_events_url":"https://api.github.com/users/zizhong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zizhong/trafficserver","description":"Mirror of Apache Traffic Server","fork":true,"url":"https://api.github.com/repos/zizhong/trafficserver","forks_url":"https://api.github.com/repos/zizhong/trafficserver/forks","keys_url":"https://api.github.com/repos/zizhong/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zizhong/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zizhong/trafficserver/teams","hooks_url":"https://api.github.com/repos/zizhong/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/zizhong/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/zizhong/trafficserver/events","assignees_url":"https://api.github.com/repos/zizhong/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/zizhong/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/zizhong/trafficserver/tags","blobs_url":"https://api.github.com/repos/zizhong/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zizhong/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zizhong/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/zizhong/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zizhong/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/zizhong/trafficserver/languages","stargazers_url":"https://api.github.com/repos/zizhong/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/zizhong/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/zizhong/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/zizhong/trafficserver/subscription","commits_url":"https://api.github.com/repos/zizhong/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/zizhong/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/zizhong/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/zizhong/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/zizhong/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/zizhong/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zizhong/trafficserver/merges","archive_url":"https://api.github.com/repos/zizhong/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zizhong/trafficserver/downloads","issues_url":"https://api.github.com/repos/zizhong/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/zizhong/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/zizhong/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/zizhong/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zizhong/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/zizhong/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/zizhong/trafficserver/deployments","created_at":"2015-07-20T09:18:59Z","updated_at":"2016-04-19T23:56:29Z","pushed_at":"2017-05-03T18:18:06Z","git_url":"git://github.com/zizhong/trafficserver.git","ssh_url":"git@github.com:zizhong/trafficserver.git","clone_url":"https://github.com/zizhong/trafficserver.git","svn_url":"https://github.com/zizhong/trafficserver","homepage":null,"size":66957,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a23df669239bd466a3e22ca2c028ed5cd3630674","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":356066,"name":"trafficserver","full_name":"apache/trafficserver","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/trafficserver","description":"Mirror of Apache Traffic Server","fork":false,"url":"https://api.github.com/repos/apache/trafficserver","forks_url":"https://api.github.com/repos/apache/trafficserver/forks","keys_url":"https://api.github.com/repos/apache/trafficserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/trafficserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/trafficserver/teams","hooks_url":"https://api.github.com/repos/apache/trafficserver/hooks","issue_events_url":"https://api.github.com/repos/apache/trafficserver/issues/events{/number}","events_url":"https://api.github.com/repos/apache/trafficserver/events","assignees_url":"https://api.github.com/repos/apache/trafficserver/assignees{/user}","branches_url":"https://api.github.com/repos/apache/trafficserver/branches{/branch}","tags_url":"https://api.github.com/repos/apache/trafficserver/tags","blobs_url":"https://api.github.com/repos/apache/trafficserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/trafficserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/trafficserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/trafficserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/trafficserver/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/trafficserver/languages","stargazers_url":"https://api.github.com/repos/apache/trafficserver/stargazers","contributors_url":"https://api.github.com/repos/apache/trafficserver/contributors","subscribers_url":"https://api.github.com/repos/apache/trafficserver/subscribers","subscription_url":"https://api.github.com/repos/apache/trafficserver/subscription","commits_url":"https://api.github.com/repos/apache/trafficserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/trafficserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/trafficserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/trafficserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/trafficserver/contents/{+path}","compare_url":"https://api.github.com/repos/apache/trafficserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/trafficserver/merges","archive_url":"https://api.github.com/repos/apache/trafficserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/trafficserver/downloads","issues_url":"https://api.github.com/repos/apache/trafficserver/issues{/number}","pulls_url":"https://api.github.com/repos/apache/trafficserver/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/trafficserver/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/trafficserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/trafficserver/labels{/name}","releases_url":"https://api.github.com/repos/apache/trafficserver/releases{/id}","deployments_url":"https://api.github.com/repos/apache/trafficserver/deployments","created_at":"2009-10-31T08:00:10Z","updated_at":"2017-04-28T12:35:01Z","pushed_at":"2017-05-03T18:18:07Z","git_url":"git://github.com/apache/trafficserver.git","ssh_url":"git@github.com:apache/trafficserver.git","clone_url":"https://github.com/apache/trafficserver.git","svn_url":"https://github.com/apache/trafficserver","homepage":null,"size":66946,"stargazers_count":527,"watchers_count":527,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":420,"mirror_url":null,"open_issues_count":159,"forks":420,"open_issues":159,"watchers":527,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/1752"},"html":{"href":"https://github.com/apache/trafficserver/pull/1752"},"issue":{"href":"https://api.github.com/repos/apache/trafficserver/issues/1752"},"comments":{"href":"https://api.github.com/repos/apache/trafficserver/issues/1752/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/1752/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/trafficserver/pulls/1752/commits"},"statuses":{"href":"https://api.github.com/repos/apache/trafficserver/statuses/48f3b1b78d9eb63993b0c30bf3af06cbc36f88ae"}}}}
{"actor":{"display_login":"zizhong"}}