{"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode/pulls/comments/129712729","pull_request_review_id":52515499,"id":129712729,"diff_hunk":"@@ -0,0 +1,396 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license\n+ * agreements. See the NOTICE file distributed with this work for additional information regarding\n+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance with the License. You may obtain a\n+ * copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License\n+ * is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n+ * or implied. See the License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package org.apache.geode.management.internal.cli.shell;\n+\n+import static java.util.concurrent.TimeUnit.MINUTES;\n+\n+import java.io.File;\n+import java.io.IOException;\n+import java.util.ArrayList;\n+import java.util.Arrays;\n+\n+import junitparams.JUnitParamsRunner;\n+import junitparams.Parameters;\n+import org.junit.Assume;\n+import org.junit.Before;\n+import org.junit.BeforeClass;\n+import org.junit.Rule;\n+import org.junit.Test;\n+import org.junit.experimental.categories.Category;\n+import org.junit.runner.RunWith;\n+\n+import org.apache.geode.internal.AvailablePort;\n+import org.apache.geode.internal.ExitCode;\n+import org.apache.geode.internal.process.PidFile;\n+import org.apache.geode.management.internal.cli.util.CommandStringBuilder;\n+import org.apache.geode.management.internal.cli.util.ThreePhraseGenerator;\n+import org.apache.geode.test.dunit.rules.gfsh.GfshExecution;\n+import org.apache.geode.test.dunit.rules.gfsh.GfshRule;\n+import org.apache.geode.test.dunit.rules.gfsh.GfshScript;\n+import org.apache.geode.test.junit.categories.AcceptanceTest;\n+\n+// Originally created in response to GEODE-2971\n+\n+@Category(AcceptanceTest.class)\n+@RunWith(JUnitParamsRunner.class)\n+public class GfshExitCodeStatusCommandsDUnitTest {","path":"geode-assembly/src/test/java/org/apache/geode/management/internal/cli/shell/GfshExitCodeStatusCommandsDUnitTest.java","position":48,"original_position":48,"commit_id":"132a71f7f605ce2e1fa29c52794e0c0d4a462f8d","original_commit_id":"132a71f7f605ce2e1fa29c52794e0c0d4a462f8d","user":{"login":"kirklund","id":1444301,"avatar_url":"https://avatars2.githubusercontent.com/u/1444301?v=4","gravatar_id":"","url":"https://api.github.com/users/kirklund","html_url":"https://github.com/kirklund","followers_url":"https://api.github.com/users/kirklund/followers","following_url":"https://api.github.com/users/kirklund/following{/other_user}","gists_url":"https://api.github.com/users/kirklund/gists{/gist_id}","starred_url":"https://api.github.com/users/kirklund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirklund/subscriptions","organizations_url":"https://api.github.com/users/kirklund/orgs","repos_url":"https://api.github.com/users/kirklund/repos","events_url":"https://api.github.com/users/kirklund/events{/privacy}","received_events_url":"https://api.github.com/users/kirklund/received_events","type":"User","site_admin":false},"body":"I recommend removing \"DUnit\" from the name especially since it's not categorized as DistributedTest.","created_at":"2017-07-26T22:28:23Z","updated_at":"2017-07-26T22:38:54Z","html_url":"https://github.com/apache/geode/pull/652#discussion_r129712729","pull_request_url":"https://api.github.com/repos/apache/geode/pulls/652","_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/comments/129712729"},"html":{"href":"https://github.com/apache/geode/pull/652#discussion_r129712729"},"pull_request":{"href":"https://api.github.com/repos/apache/geode/pulls/652"}}},"pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/652","id":132142205,"html_url":"https://github.com/apache/geode/pull/652","diff_url":"https://github.com/apache/geode/pull/652.diff","patch_url":"https://github.com/apache/geode/pull/652.patch","issue_url":"https://api.github.com/repos/apache/geode/issues/652","number":652,"state":"open","locked":false,"title":"Geode-2971: Introduce ExitCode to resolve inconsistency of shell exit values","user":{"login":"PurelyApplied","id":7175687,"avatar_url":"https://avatars0.githubusercontent.com/u/7175687?v=4","gravatar_id":"","url":"https://api.github.com/users/PurelyApplied","html_url":"https://github.com/PurelyApplied","followers_url":"https://api.github.com/users/PurelyApplied/followers","following_url":"https://api.github.com/users/PurelyApplied/following{/other_user}","gists_url":"https://api.github.com/users/PurelyApplied/gists{/gist_id}","starred_url":"https://api.github.com/users/PurelyApplied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PurelyApplied/subscriptions","organizations_url":"https://api.github.com/users/PurelyApplied/orgs","repos_url":"https://api.github.com/users/PurelyApplied/repos","events_url":"https://api.github.com/users/PurelyApplied/events{/privacy}","received_events_url":"https://api.github.com/users/PurelyApplied/received_events","type":"User","site_admin":false},"body":"There are a few sections containing `// TODO PSRhomberg`.  Most are there to mark a specific request for feedback, and two are there to explain a change that counterintuitively respects existing behavior.\r\n\r\n- [ ] Have you removed your `TODO` comments?\r\n- [ ] Is your initial contribution a single, squashed commit?\r\n","created_at":"2017-07-24T20:51:15Z","updated_at":"2017-07-26T22:38:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06176692823eda97a3f744161fb4523fd3caafcc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode/pulls/652/commits","review_comments_url":"https://api.github.com/repos/apache/geode/pulls/652/comments","review_comment_url":"https://api.github.com/repos/apache/geode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode/issues/652/comments","statuses_url":"https://api.github.com/repos/apache/geode/statuses/132a71f7f605ce2e1fa29c52794e0c0d4a462f8d","head":{"label":"PurelyApplied:geode-2971","ref":"geode-2971","sha":"132a71f7f605ce2e1fa29c52794e0c0d4a462f8d","user":{"login":"PurelyApplied","id":7175687,"avatar_url":"https://avatars0.githubusercontent.com/u/7175687?v=4","gravatar_id":"","url":"https://api.github.com/users/PurelyApplied","html_url":"https://github.com/PurelyApplied","followers_url":"https://api.github.com/users/PurelyApplied/followers","following_url":"https://api.github.com/users/PurelyApplied/following{/other_user}","gists_url":"https://api.github.com/users/PurelyApplied/gists{/gist_id}","starred_url":"https://api.github.com/users/PurelyApplied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PurelyApplied/subscriptions","organizations_url":"https://api.github.com/users/PurelyApplied/orgs","repos_url":"https://api.github.com/users/PurelyApplied/repos","events_url":"https://api.github.com/users/PurelyApplied/events{/privacy}","received_events_url":"https://api.github.com/users/PurelyApplied/received_events","type":"User","site_admin":false},"repo":{"id":85762855,"name":"geode","full_name":"PurelyApplied/geode","owner":{"login":"PurelyApplied","id":7175687,"avatar_url":"https://avatars0.githubusercontent.com/u/7175687?v=4","gravatar_id":"","url":"https://api.github.com/users/PurelyApplied","html_url":"https://github.com/PurelyApplied","followers_url":"https://api.github.com/users/PurelyApplied/followers","following_url":"https://api.github.com/users/PurelyApplied/following{/other_user}","gists_url":"https://api.github.com/users/PurelyApplied/gists{/gist_id}","starred_url":"https://api.github.com/users/PurelyApplied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PurelyApplied/subscriptions","organizations_url":"https://api.github.com/users/PurelyApplied/orgs","repos_url":"https://api.github.com/users/PurelyApplied/repos","events_url":"https://api.github.com/users/PurelyApplied/events{/privacy}","received_events_url":"https://api.github.com/users/PurelyApplied/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PurelyApplied/geode","description":"Mirror of Apache Geode","fork":true,"url":"https://api.github.com/repos/PurelyApplied/geode","forks_url":"https://api.github.com/repos/PurelyApplied/geode/forks","keys_url":"https://api.github.com/repos/PurelyApplied/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PurelyApplied/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PurelyApplied/geode/teams","hooks_url":"https://api.github.com/repos/PurelyApplied/geode/hooks","issue_events_url":"https://api.github.com/repos/PurelyApplied/geode/issues/events{/number}","events_url":"https://api.github.com/repos/PurelyApplied/geode/events","assignees_url":"https://api.github.com/repos/PurelyApplied/geode/assignees{/user}","branches_url":"https://api.github.com/repos/PurelyApplied/geode/branches{/branch}","tags_url":"https://api.github.com/repos/PurelyApplied/geode/tags","blobs_url":"https://api.github.com/repos/PurelyApplied/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PurelyApplied/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PurelyApplied/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/PurelyApplied/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PurelyApplied/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/PurelyApplied/geode/languages","stargazers_url":"https://api.github.com/repos/PurelyApplied/geode/stargazers","contributors_url":"https://api.github.com/repos/PurelyApplied/geode/contributors","subscribers_url":"https://api.github.com/repos/PurelyApplied/geode/subscribers","subscription_url":"https://api.github.com/repos/PurelyApplied/geode/subscription","commits_url":"https://api.github.com/repos/PurelyApplied/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/PurelyApplied/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/PurelyApplied/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/PurelyApplied/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/PurelyApplied/geode/contents/{+path}","compare_url":"https://api.github.com/repos/PurelyApplied/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PurelyApplied/geode/merges","archive_url":"https://api.github.com/repos/PurelyApplied/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PurelyApplied/geode/downloads","issues_url":"https://api.github.com/repos/PurelyApplied/geode/issues{/number}","pulls_url":"https://api.github.com/repos/PurelyApplied/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/PurelyApplied/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/PurelyApplied/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PurelyApplied/geode/labels{/name}","releases_url":"https://api.github.com/repos/PurelyApplied/geode/releases{/id}","deployments_url":"https://api.github.com/repos/PurelyApplied/geode/deployments","created_at":"2017-03-21T23:11:29Z","updated_at":"2017-03-21T23:11:47Z","pushed_at":"2017-07-26T21:18:07Z","git_url":"git://github.com/PurelyApplied/geode.git","ssh_url":"git@github.com:PurelyApplied/geode.git","clone_url":"https://github.com/PurelyApplied/geode.git","svn_url":"https://github.com/PurelyApplied/geode","homepage":"","size":109668,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"b8891128959df5e5a5621f4567a9d4f43b9b1647","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"name":"geode","full_name":"apache/geode","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/geode","description":"Mirror of Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2017-07-26T16:09:15Z","pushed_at":"2017-07-26T22:28:10Z","git_url":"git://github.com/apache/geode.git","ssh_url":"git@github.com:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":133389,"stargazers_count":1015,"watchers_count":1015,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":371,"mirror_url":"git://git.apache.org/geode.git","open_issues_count":22,"forks":371,"open_issues":22,"watchers":1015,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/652"},"html":{"href":"https://github.com/apache/geode/pull/652"},"issue":{"href":"https://api.github.com/repos/apache/geode/issues/652"},"comments":{"href":"https://api.github.com/repos/apache/geode/issues/652/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode/pulls/652/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode/pulls/652/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode/statuses/132a71f7f605ce2e1fa29c52794e0c0d4a462f8d"}}}}
{"actor":{"display_login":"kirklund"}}