{"action":"created","issue":{"url":"https://api.github.com/repos/miekg/dns/issues/452","repository_url":"https://api.github.com/repos/miekg/dns","labels_url":"https://api.github.com/repos/miekg/dns/issues/452/labels{/name}","comments_url":"https://api.github.com/repos/miekg/dns/issues/452/comments","events_url":"https://api.github.com/repos/miekg/dns/issues/452/events","html_url":"https://github.com/miekg/dns/pull/452","id":207303391,"number":452,"title":"Added NameList function to ClientConfig","user":{"login":"fastest963","id":112555,"avatar_url":"https://avatars.githubusercontent.com/u/112555?v=3","gravatar_id":"","url":"https://api.github.com/users/fastest963","html_url":"https://github.com/fastest963","followers_url":"https://api.github.com/users/fastest963/followers","following_url":"https://api.github.com/users/fastest963/following{/other_user}","gists_url":"https://api.github.com/users/fastest963/gists{/gist_id}","starred_url":"https://api.github.com/users/fastest963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastest963/subscriptions","organizations_url":"https://api.github.com/users/fastest963/orgs","repos_url":"https://api.github.com/users/fastest963/repos","events_url":"https://api.github.com/users/fastest963/events{/privacy}","received_events_url":"https://api.github.com/users/fastest963/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-02-13T18:40:14Z","updated_at":"2017-02-13T20:09:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/miekg/dns/pulls/452","html_url":"https://github.com/miekg/dns/pull/452","diff_url":"https://github.com/miekg/dns/pull/452.diff","patch_url":"https://github.com/miekg/dns/pull/452.patch"},"body":"Instead of forcing users to build the list of queries they should make for a given name (like https://github.com/prometheus/prometheus/blob/master/discovery/dns/dns.go#L171) `ClientConfig` should have a `NameList` function much like https://github.com/golang/go/blob/master/src/net/dnsclient_unix.go#L360 to get a slice of all the given names.\r\n\r\nThis would also fix a prometheus bug where they're incorrectly looking at suffixes first instead of trying fqdn if it has ndots. I'll make a PR for that once this is fixed."},"comment":{"url":"https://api.github.com/repos/miekg/dns/issues/comments/279507581","html_url":"https://github.com/miekg/dns/pull/452#issuecomment-279507581","issue_url":"https://api.github.com/repos/miekg/dns/issues/452","id":279507581,"user":{"login":"fastest963","id":112555,"avatar_url":"https://avatars.githubusercontent.com/u/112555?v=3","gravatar_id":"","url":"https://api.github.com/users/fastest963","html_url":"https://github.com/fastest963","followers_url":"https://api.github.com/users/fastest963/followers","following_url":"https://api.github.com/users/fastest963/following{/other_user}","gists_url":"https://api.github.com/users/fastest963/gists{/gist_id}","starred_url":"https://api.github.com/users/fastest963/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastest963/subscriptions","organizations_url":"https://api.github.com/users/fastest963/orgs","repos_url":"https://api.github.com/users/fastest963/repos","events_url":"https://api.github.com/users/fastest963/events{/privacy}","received_events_url":"https://api.github.com/users/fastest963/received_events","type":"User","site_admin":false},"created_at":"2017-02-13T20:09:53Z","updated_at":"2017-02-13T20:09:53Z","body":"Updated to use `[]string{}` instead of `make`"}}
{"actor":{"display_login":"fastest963"}}