{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/151661984","pull_request_review_id":77405420,"id":151661984,"diff_hunk":"@@ -79,7 +79,12 @@ enum net_tcp_state {\n /* RFC 1122 4.2.2.6 \"If an MSS option is not received at connection\n  * setup, TCP MUST assume a default send MSS of 536\"\n  */\n-#define NET_TCP_DEFAULT_MSS   536\n+/*#define NET_TCP_DEFAULT_MSS   536*/\n+/* TODO: We don't yet implement full MSS negotiation in Zephyr,\n+ * but have tests which rely on being able to send \"full\" IPv6\n+ * (MTU 1280) packets, so for now set default MSS to higher value\n+ */\n+#define NET_TCP_DEFAULT_MSS   1280","path":"subsys/net/ip/tcp.h","position":10,"original_position":10,"commit_id":"d880d1796279967894db9f616849e896ff4c8248","original_commit_id":"d880d1796279967894db9f616849e896ff4c8248","user":{"login":"pfalcon","id":500451,"avatar_url":"https://avatars3.githubusercontent.com/u/500451?v=4","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"body":"@pfl thanks, but:\r\n\r\n1. What you say is pretty obvious and known to the author of the patch.\r\n2. Zephyr IP stack has multiple violations of IP standards.\r\n3. There's incremental work to make it compliant, and fixing one issue often leads to exposing issues in other parts of code.\r\n4. This patch is part of the work to get more overall p.1 fixes into the 1.10 release, rather than less, which requires quite extensive negotiations and compromises among all the parties involves, see #119, #4821, #4934, #5015, etc.\r\n","created_at":"2017-11-17T11:19:48Z","updated_at":"2017-11-17T11:19:48Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5034#discussion_r151661984","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5034","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/151661984"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/5034#discussion_r151661984"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5034"}},"in_reply_to_id":151655164},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5034","id":153263480,"html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5034","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5034.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/5034.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5034","number":5034,"state":"open","locked":false,"title":"net: tcp: Use larger default MSS until its negotiation is fully implemented (1.10 release workaround)","user":{"login":"pfalcon","id":500451,"avatar_url":"https://avatars3.githubusercontent.com/u/500451?v=4","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"body":"We don't yet implement MSS negotiation for all directions (client vs\r\nserver), and yet have tests/samples which assume that it's possible\r\nto transfer more than default MSS of 536 in a single packet.\r\n\r\nSo, until negotiation is fully implemented, bump default MSS to be\r\nhigher.\r\n\r\nSigned-off-by: Paul Sokolovsky <paul.sokolovsky@linaro.org>","created_at":"2017-11-17T10:29:36Z","updated_at":"2017-11-17T11:19:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"712bf5f2155116f6fc1282dfdf8767a7f6ac81ae","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jukkar","id":1098415,"avatar_url":"https://avatars3.githubusercontent.com/u/1098415?v=4","gravatar_id":"","url":"https://api.github.com/users/jukkar","html_url":"https://github.com/jukkar","followers_url":"https://api.github.com/users/jukkar/followers","following_url":"https://api.github.com/users/jukkar/following{/other_user}","gists_url":"https://api.github.com/users/jukkar/gists{/gist_id}","starred_url":"https://api.github.com/users/jukkar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jukkar/subscriptions","organizations_url":"https://api.github.com/users/jukkar/orgs","repos_url":"https://api.github.com/users/jukkar/repos","events_url":"https://api.github.com/users/jukkar/events{/privacy}","received_events_url":"https://api.github.com/users/jukkar/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5034/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5034/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5034/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/d880d1796279967894db9f616849e896ff4c8248","head":{"label":"pfalcon:net-unbreak-broken-samples-for-1.10-release","ref":"net-unbreak-broken-samples-for-1.10-release","sha":"d880d1796279967894db9f616849e896ff4c8248","user":{"login":"pfalcon","id":500451,"avatar_url":"https://avatars3.githubusercontent.com/u/500451?v=4","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"repo":{"id":89925445,"name":"zephyr","full_name":"pfalcon/zephyr","owner":{"login":"pfalcon","id":500451,"avatar_url":"https://avatars3.githubusercontent.com/u/500451?v=4","gravatar_id":"","url":"https://api.github.com/users/pfalcon","html_url":"https://github.com/pfalcon","followers_url":"https://api.github.com/users/pfalcon/followers","following_url":"https://api.github.com/users/pfalcon/following{/other_user}","gists_url":"https://api.github.com/users/pfalcon/gists{/gist_id}","starred_url":"https://api.github.com/users/pfalcon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfalcon/subscriptions","organizations_url":"https://api.github.com/users/pfalcon/orgs","repos_url":"https://api.github.com/users/pfalcon/repos","events_url":"https://api.github.com/users/pfalcon/events{/privacy}","received_events_url":"https://api.github.com/users/pfalcon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfalcon/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/pfalcon/zephyr","forks_url":"https://api.github.com/repos/pfalcon/zephyr/forks","keys_url":"https://api.github.com/repos/pfalcon/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfalcon/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfalcon/zephyr/teams","hooks_url":"https://api.github.com/repos/pfalcon/zephyr/hooks","issue_events_url":"https://api.github.com/repos/pfalcon/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/pfalcon/zephyr/events","assignees_url":"https://api.github.com/repos/pfalcon/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/pfalcon/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/pfalcon/zephyr/tags","blobs_url":"https://api.github.com/repos/pfalcon/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfalcon/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfalcon/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfalcon/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfalcon/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/pfalcon/zephyr/languages","stargazers_url":"https://api.github.com/repos/pfalcon/zephyr/stargazers","contributors_url":"https://api.github.com/repos/pfalcon/zephyr/contributors","subscribers_url":"https://api.github.com/repos/pfalcon/zephyr/subscribers","subscription_url":"https://api.github.com/repos/pfalcon/zephyr/subscription","commits_url":"https://api.github.com/repos/pfalcon/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfalcon/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfalcon/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfalcon/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfalcon/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/pfalcon/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfalcon/zephyr/merges","archive_url":"https://api.github.com/repos/pfalcon/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfalcon/zephyr/downloads","issues_url":"https://api.github.com/repos/pfalcon/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/pfalcon/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/pfalcon/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/pfalcon/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfalcon/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/pfalcon/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/pfalcon/zephyr/deployments","created_at":"2017-05-01T13:16:09Z","updated_at":"2017-05-01T13:16:45Z","pushed_at":"2017-11-17T10:29:10Z","git_url":"git://github.com/pfalcon/zephyr.git","ssh_url":"git@github.com:pfalcon/zephyr.git","clone_url":"https://github.com/pfalcon/zephyr.git","svn_url":"https://github.com/pfalcon/zephyr","homepage":"http://zephyrproject.org/doc","size":93468,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"486e15682769403e565ee20393e5713e037de598","user":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2017-11-17T10:50:05Z","pushed_at":"2017-11-17T11:16:34Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"http://zephyrproject.org/doc","size":93725,"stargazers_count":463,"watchers_count":463,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":357,"mirror_url":null,"archived":false,"open_issues_count":706,"forks":357,"open_issues":706,"watchers":463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5034"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/5034"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5034"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/5034/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5034/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/5034/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/d880d1796279967894db9f616849e896ff4c8248"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pfalcon"}}