{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/dimbleby/c-ares-resolver/pulls/5","id":151776216,"html_url":"https://github.com/dimbleby/c-ares-resolver/pull/5","diff_url":"https://github.com/dimbleby/c-ares-resolver/pull/5.diff","patch_url":"https://github.com/dimbleby/c-ares-resolver/pull/5.patch","issue_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/issues/5","number":5,"state":"closed","locked":false,"title":"Stay alive while queries pending","user":{"login":"dimbleby","id":875184,"avatar_url":"https://avatars3.githubusercontent.com/u/875184?v=4","gravatar_id":"","url":"https://api.github.com/users/dimbleby","html_url":"https://github.com/dimbleby","followers_url":"https://api.github.com/users/dimbleby/followers","following_url":"https://api.github.com/users/dimbleby/following{/other_user}","gists_url":"https://api.github.com/users/dimbleby/gists{/gist_id}","starred_url":"https://api.github.com/users/dimbleby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimbleby/subscriptions","organizations_url":"https://api.github.com/users/dimbleby/orgs","repos_url":"https://api.github.com/users/dimbleby/repos","events_url":"https://api.github.com/users/dimbleby/events{/privacy}","received_events_url":"https://api.github.com/users/dimbleby/received_events","type":"User","site_admin":false},"body":"Fixes #4.\r\n\r\nBut is it the right thing to do?\r\n\r\n* On the plus side, it's clearly a more convenient API if users don't have to worry about keeping resolvers alive while queries are pending\r\n* Against this though: it's unnecessary cost for users who were perfectly willing to have a long-lived resolver all along.\r\n\r\nIs this automatic keeping-things-alive stuff really in the spirit of rust-y zero-cost abstractions?  Could recommend that if this is what's wanted, users can achieve the desired result for themselves with a little more code eg wrap their resolver in an `Arc<RwLock<>>` and have their callbacks hold clones of that `Arc`.\r\n\r\nBut that's undeniably awkward...\r\n\r\nI dunno.  I'll probably leave this open for a short period, while I mull over my indecision.","created_at":"2017-11-09T22:10:24Z","updated_at":"2017-11-11T10:55:38Z","closed_at":"2017-11-11T10:55:38Z","merged_at":null,"merge_commit_sha":"14324af86afd826d7c001731673182a88119b8c7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/pulls/5/commits","review_comments_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/pulls/5/comments","review_comment_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/issues/5/comments","statuses_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/statuses/c604699270ac3f805b65ba842d704cf85bbe11f7","head":{"label":"dimbleby:stay-alive-while-queries-pending","ref":"stay-alive-while-queries-pending","sha":"c604699270ac3f805b65ba842d704cf85bbe11f7","user":{"login":"dimbleby","id":875184,"avatar_url":"https://avatars3.githubusercontent.com/u/875184?v=4","gravatar_id":"","url":"https://api.github.com/users/dimbleby","html_url":"https://github.com/dimbleby","followers_url":"https://api.github.com/users/dimbleby/followers","following_url":"https://api.github.com/users/dimbleby/following{/other_user}","gists_url":"https://api.github.com/users/dimbleby/gists{/gist_id}","starred_url":"https://api.github.com/users/dimbleby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimbleby/subscriptions","organizations_url":"https://api.github.com/users/dimbleby/orgs","repos_url":"https://api.github.com/users/dimbleby/repos","events_url":"https://api.github.com/users/dimbleby/events{/privacy}","received_events_url":"https://api.github.com/users/dimbleby/received_events","type":"User","site_admin":false},"repo":{"id":71047489,"name":"c-ares-resolver","full_name":"dimbleby/c-ares-resolver","owner":{"login":"dimbleby","id":875184,"avatar_url":"https://avatars3.githubusercontent.com/u/875184?v=4","gravatar_id":"","url":"https://api.github.com/users/dimbleby","html_url":"https://github.com/dimbleby","followers_url":"https://api.github.com/users/dimbleby/followers","following_url":"https://api.github.com/users/dimbleby/following{/other_user}","gists_url":"https://api.github.com/users/dimbleby/gists{/gist_id}","starred_url":"https://api.github.com/users/dimbleby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimbleby/subscriptions","organizations_url":"https://api.github.com/users/dimbleby/orgs","repos_url":"https://api.github.com/users/dimbleby/repos","events_url":"https://api.github.com/users/dimbleby/events{/privacy}","received_events_url":"https://api.github.com/users/dimbleby/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dimbleby/c-ares-resolver","description":"Rust DNS resolvers built on c-ares","fork":false,"url":"https://api.github.com/repos/dimbleby/c-ares-resolver","forks_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/forks","keys_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/teams","hooks_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/hooks","issue_events_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/issues/events{/number}","events_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/events","assignees_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/assignees{/user}","branches_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/branches{/branch}","tags_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/tags","blobs_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/statuses/{sha}","languages_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/languages","stargazers_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/stargazers","contributors_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/contributors","subscribers_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/subscribers","subscription_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/subscription","commits_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/contents/{+path}","compare_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/merges","archive_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/downloads","issues_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/issues{/number}","pulls_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/pulls{/number}","milestones_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/milestones{/number}","notifications_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/labels{/name}","releases_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/releases{/id}","deployments_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/deployments","created_at":"2016-10-16T11:57:00Z","updated_at":"2017-10-19T15:39:50Z","pushed_at":"2017-11-11T10:08:36Z","git_url":"git://github.com/dimbleby/c-ares-resolver.git","ssh_url":"git@github.com:dimbleby/c-ares-resolver.git","clone_url":"https://github.com/dimbleby/c-ares-resolver.git","svn_url":"https://github.com/dimbleby/c-ares-resolver","homepage":"","size":8610,"stargazers_count":9,"watchers_count":9,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"dimbleby:master","ref":"master","sha":"62b13317746d66468dfd0df312a1c48cac9641aa","user":{"login":"dimbleby","id":875184,"avatar_url":"https://avatars3.githubusercontent.com/u/875184?v=4","gravatar_id":"","url":"https://api.github.com/users/dimbleby","html_url":"https://github.com/dimbleby","followers_url":"https://api.github.com/users/dimbleby/followers","following_url":"https://api.github.com/users/dimbleby/following{/other_user}","gists_url":"https://api.github.com/users/dimbleby/gists{/gist_id}","starred_url":"https://api.github.com/users/dimbleby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimbleby/subscriptions","organizations_url":"https://api.github.com/users/dimbleby/orgs","repos_url":"https://api.github.com/users/dimbleby/repos","events_url":"https://api.github.com/users/dimbleby/events{/privacy}","received_events_url":"https://api.github.com/users/dimbleby/received_events","type":"User","site_admin":false},"repo":{"id":71047489,"name":"c-ares-resolver","full_name":"dimbleby/c-ares-resolver","owner":{"login":"dimbleby","id":875184,"avatar_url":"https://avatars3.githubusercontent.com/u/875184?v=4","gravatar_id":"","url":"https://api.github.com/users/dimbleby","html_url":"https://github.com/dimbleby","followers_url":"https://api.github.com/users/dimbleby/followers","following_url":"https://api.github.com/users/dimbleby/following{/other_user}","gists_url":"https://api.github.com/users/dimbleby/gists{/gist_id}","starred_url":"https://api.github.com/users/dimbleby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimbleby/subscriptions","organizations_url":"https://api.github.com/users/dimbleby/orgs","repos_url":"https://api.github.com/users/dimbleby/repos","events_url":"https://api.github.com/users/dimbleby/events{/privacy}","received_events_url":"https://api.github.com/users/dimbleby/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dimbleby/c-ares-resolver","description":"Rust DNS resolvers built on c-ares","fork":false,"url":"https://api.github.com/repos/dimbleby/c-ares-resolver","forks_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/forks","keys_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/teams","hooks_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/hooks","issue_events_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/issues/events{/number}","events_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/events","assignees_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/assignees{/user}","branches_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/branches{/branch}","tags_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/tags","blobs_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/git/refs{/sha}","trees_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/statuses/{sha}","languages_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/languages","stargazers_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/stargazers","contributors_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/contributors","subscribers_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/subscribers","subscription_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/subscription","commits_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/commits{/sha}","git_commits_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/git/commits{/sha}","comments_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/comments{/number}","issue_comment_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/issues/comments{/number}","contents_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/contents/{+path}","compare_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/merges","archive_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/downloads","issues_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/issues{/number}","pulls_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/pulls{/number}","milestones_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/milestones{/number}","notifications_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/labels{/name}","releases_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/releases{/id}","deployments_url":"https://api.github.com/repos/dimbleby/c-ares-resolver/deployments","created_at":"2016-10-16T11:57:00Z","updated_at":"2017-10-19T15:39:50Z","pushed_at":"2017-11-11T10:08:36Z","git_url":"git://github.com/dimbleby/c-ares-resolver.git","ssh_url":"git@github.com:dimbleby/c-ares-resolver.git","clone_url":"https://github.com/dimbleby/c-ares-resolver.git","svn_url":"https://github.com/dimbleby/c-ares-resolver","homepage":"","size":8610,"stargazers_count":9,"watchers_count":9,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dimbleby/c-ares-resolver/pulls/5"},"html":{"href":"https://github.com/dimbleby/c-ares-resolver/pull/5"},"issue":{"href":"https://api.github.com/repos/dimbleby/c-ares-resolver/issues/5"},"comments":{"href":"https://api.github.com/repos/dimbleby/c-ares-resolver/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/dimbleby/c-ares-resolver/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/dimbleby/c-ares-resolver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dimbleby/c-ares-resolver/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/dimbleby/c-ares-resolver/statuses/c604699270ac3f805b65ba842d704cf85bbe11f7"}},"author_association":"OWNER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":117,"deletions":109,"changed_files":8}}
{"actor":{"display_login":"dimbleby"}}