{"action":"created","comment":{"url":"https://api.github.com/repos/apache/tinkerpop/pulls/comments/141109744","pull_request_review_id":65277228,"id":141109744,"diff_hunk":"@@ -79,7 +85,77 @@ public void AddSource(string sourceName, params object[] args)\n         /// <param name=\"args\">The traversal method arguments.</param>\n         public void AddStep(string stepName, params object[] args)\n         {\n-            StepInstructions.Add(new Instruction(stepName, args));\n+            StepInstructions.Add(new Instruction(stepName, FlattenArguments(args)));\n+            Bindings.Clear();","path":"gremlin-dotnet/src/Gremlin.Net/Process/Traversal/Bytecode.cs","position":36,"original_position":36,"commit_id":"b8a278c6ce1ab7337fd6563cbf43c2f152c4aac4","original_commit_id":"b8a278c6ce1ab7337fd6563cbf43c2f152c4aac4","user":{"login":"jorgebay","id":2931196,"avatar_url":"https://avatars3.githubusercontent.com/u/2931196?v=4","gravatar_id":"","url":"https://api.github.com/users/jorgebay","html_url":"https://github.com/jorgebay","followers_url":"https://api.github.com/users/jorgebay/followers","following_url":"https://api.github.com/users/jorgebay/following{/other_user}","gists_url":"https://api.github.com/users/jorgebay/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebay/subscriptions","organizations_url":"https://api.github.com/users/jorgebay/orgs","repos_url":"https://api.github.com/users/jorgebay/repos","events_url":"https://api.github.com/users/jorgebay/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebay/received_events","type":"User","site_admin":false},"body":"I agree that a solution could be an overkill on the API...\r\n\r\nI'm +1 from not supporting bindings in the .NET GLV (and document it), I don't see much purpose.\r\n\r\nWhat do you think about not supporting Bindings on the .NET GLV @okram @spmallette @robertdale ?","created_at":"2017-09-26T16:26:21Z","updated_at":"2017-09-26T16:26:21Z","html_url":"https://github.com/apache/tinkerpop/pull/712#discussion_r141109744","pull_request_url":"https://api.github.com/repos/apache/tinkerpop/pulls/712","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/comments/141109744"},"html":{"href":"https://github.com/apache/tinkerpop/pull/712#discussion_r141109744"},"pull_request":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/712"}},"in_reply_to_id":140818483},"pull_request":{"url":"https://api.github.com/repos/apache/tinkerpop/pulls/712","id":140617160,"html_url":"https://github.com/apache/tinkerpop/pull/712","diff_url":"https://github.com/apache/tinkerpop/pull/712.diff","patch_url":"https://github.com/apache/tinkerpop/pull/712.patch","issue_url":"https://api.github.com/repos/apache/tinkerpop/issues/712","number":712,"state":"open","locked":false,"title":"TINKERPOP-1752: Gremlin.Net: Generate completely type-safe methods","user":{"login":"FlorianHockmann","id":21224336,"avatar_url":"https://avatars1.githubusercontent.com/u/21224336?v=4","gravatar_id":"","url":"https://api.github.com/users/FlorianHockmann","html_url":"https://github.com/FlorianHockmann","followers_url":"https://api.github.com/users/FlorianHockmann/followers","following_url":"https://api.github.com/users/FlorianHockmann/following{/other_user}","gists_url":"https://api.github.com/users/FlorianHockmann/gists{/gist_id}","starred_url":"https://api.github.com/users/FlorianHockmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlorianHockmann/subscriptions","organizations_url":"https://api.github.com/users/FlorianHockmann/orgs","repos_url":"https://api.github.com/users/FlorianHockmann/repos","events_url":"https://api.github.com/users/FlorianHockmann/events{/privacy}","received_events_url":"https://api.github.com/users/FlorianHockmann/received_events","type":"User","site_admin":false},"body":"https://issues.apache.org/jira/browse/TINKERPOP-1752\r\n\r\nAll steps are now (basically) type-safe and the original argument names from Gremlin-Java are used. However, we currently don't support some Java types like `Comparator`. Those were simply replaced by `object` until we find a better solution. A problem with this workaround is that some overloads from Gremlin-Java are not supported in Gremlin.Net as they would result in the same method signature.\r\n\r\nThe implementation of `Bindings` is now basically the same as in Gremlin-Java. This change was necessary as `Bindings.Of()` can no longer return a `Binding` object\r\n\r\nThese changes also revealed a bug in the tests where the `WithoutStrategies` source step was called with objects of strategies instead of just with their types. However, `WithoutStrategies` still can't work right now as a GraphSON serializer is missing for `Type`.\r\n\r\nThe `Group` step for example looks now like this:\r\n```cs\r\n/// <summary>\r\n///     Adds the group step to this <see cref=\"GraphTraversal{SType, EType}\" />.\r\n/// </summary>\r\npublic GraphTraversal< S , IDictionary<K, V> > Group<K, V> ()\r\n{\r\n    Bytecode.AddStep(\"group\");\r\n    return Wrap< S , IDictionary<K, V> >(this);\r\n}\r\n\r\n/// <summary>\r\n///     Adds the group step to this <see cref=\"GraphTraversal{SType, EType}\" />.\r\n/// </summary>\r\npublic GraphTraversal< S , E > Group (string sideEffectKey)\r\n{\r\n    Bytecode.AddStep(\"group\", sideEffectKey);\r\n    return Wrap< S , E >(this);\r\n}\r\n```\r\nSo this should also solve [TINKERPOP-1751](https://issues.apache.org/jira/browse/TINKERPOP-1751) that mentioned the missing overload for `Group` that returns `IDictionary<K, V>`.","created_at":"2017-09-12T15:45:11Z","updated_at":"2017-09-26T16:26:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"285e0842bd5a833d747e66f221431c22ad3c842f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/tinkerpop/pulls/712/commits","review_comments_url":"https://api.github.com/repos/apache/tinkerpop/pulls/712/comments","review_comment_url":"https://api.github.com/repos/apache/tinkerpop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/tinkerpop/issues/712/comments","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/b8a278c6ce1ab7337fd6563cbf43c2f152c4aac4","head":{"label":"apache:TINKERPOP-1752","ref":"TINKERPOP-1752","sha":"b8a278c6ce1ab7337fd6563cbf43c2f152c4aac4","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":30449481,"name":"tinkerpop","full_name":"apache/tinkerpop","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tinkerpop","description":"Mirror of Apache TinkerPop","fork":false,"url":"https://api.github.com/repos/apache/tinkerpop","forks_url":"https://api.github.com/repos/apache/tinkerpop/forks","keys_url":"https://api.github.com/repos/apache/tinkerpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tinkerpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tinkerpop/teams","hooks_url":"https://api.github.com/repos/apache/tinkerpop/hooks","issue_events_url":"https://api.github.com/repos/apache/tinkerpop/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tinkerpop/events","assignees_url":"https://api.github.com/repos/apache/tinkerpop/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tinkerpop/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tinkerpop/tags","blobs_url":"https://api.github.com/repos/apache/tinkerpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tinkerpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tinkerpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tinkerpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tinkerpop/languages","stargazers_url":"https://api.github.com/repos/apache/tinkerpop/stargazers","contributors_url":"https://api.github.com/repos/apache/tinkerpop/contributors","subscribers_url":"https://api.github.com/repos/apache/tinkerpop/subscribers","subscription_url":"https://api.github.com/repos/apache/tinkerpop/subscription","commits_url":"https://api.github.com/repos/apache/tinkerpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tinkerpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tinkerpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tinkerpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tinkerpop/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tinkerpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tinkerpop/merges","archive_url":"https://api.github.com/repos/apache/tinkerpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tinkerpop/downloads","issues_url":"https://api.github.com/repos/apache/tinkerpop/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tinkerpop/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tinkerpop/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tinkerpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tinkerpop/labels{/name}","releases_url":"https://api.github.com/repos/apache/tinkerpop/releases{/id}","deployments_url":"https://api.github.com/repos/apache/tinkerpop/deployments","created_at":"2015-02-07T08:00:05Z","updated_at":"2017-09-26T08:41:10Z","pushed_at":"2017-09-26T15:34:50Z","git_url":"git://github.com/apache/tinkerpop.git","ssh_url":"git@github.com:apache/tinkerpop.git","clone_url":"https://github.com/apache/tinkerpop.git","svn_url":"https://github.com/apache/tinkerpop","homepage":"http://tinkerpop.apache.org/","size":141738,"stargazers_count":408,"watchers_count":408,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":238,"mirror_url":"git://git.apache.org/tinkerpop.git","open_issues_count":12,"forks":238,"open_issues":12,"watchers":408,"default_branch":"master"}},"base":{"label":"apache:tp32","ref":"tp32","sha":"132011fb539fa2dd1776650c1a8c8cfc940afdaf","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":30449481,"name":"tinkerpop","full_name":"apache/tinkerpop","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tinkerpop","description":"Mirror of Apache TinkerPop","fork":false,"url":"https://api.github.com/repos/apache/tinkerpop","forks_url":"https://api.github.com/repos/apache/tinkerpop/forks","keys_url":"https://api.github.com/repos/apache/tinkerpop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tinkerpop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tinkerpop/teams","hooks_url":"https://api.github.com/repos/apache/tinkerpop/hooks","issue_events_url":"https://api.github.com/repos/apache/tinkerpop/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tinkerpop/events","assignees_url":"https://api.github.com/repos/apache/tinkerpop/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tinkerpop/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tinkerpop/tags","blobs_url":"https://api.github.com/repos/apache/tinkerpop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tinkerpop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tinkerpop/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tinkerpop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tinkerpop/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tinkerpop/languages","stargazers_url":"https://api.github.com/repos/apache/tinkerpop/stargazers","contributors_url":"https://api.github.com/repos/apache/tinkerpop/contributors","subscribers_url":"https://api.github.com/repos/apache/tinkerpop/subscribers","subscription_url":"https://api.github.com/repos/apache/tinkerpop/subscription","commits_url":"https://api.github.com/repos/apache/tinkerpop/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tinkerpop/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tinkerpop/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tinkerpop/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tinkerpop/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tinkerpop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tinkerpop/merges","archive_url":"https://api.github.com/repos/apache/tinkerpop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tinkerpop/downloads","issues_url":"https://api.github.com/repos/apache/tinkerpop/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tinkerpop/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tinkerpop/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tinkerpop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tinkerpop/labels{/name}","releases_url":"https://api.github.com/repos/apache/tinkerpop/releases{/id}","deployments_url":"https://api.github.com/repos/apache/tinkerpop/deployments","created_at":"2015-02-07T08:00:05Z","updated_at":"2017-09-26T08:41:10Z","pushed_at":"2017-09-26T15:34:50Z","git_url":"git://github.com/apache/tinkerpop.git","ssh_url":"git@github.com:apache/tinkerpop.git","clone_url":"https://github.com/apache/tinkerpop.git","svn_url":"https://github.com/apache/tinkerpop","homepage":"http://tinkerpop.apache.org/","size":141738,"stargazers_count":408,"watchers_count":408,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":238,"mirror_url":"git://git.apache.org/tinkerpop.git","open_issues_count":12,"forks":238,"open_issues":12,"watchers":408,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/712"},"html":{"href":"https://github.com/apache/tinkerpop/pull/712"},"issue":{"href":"https://api.github.com/repos/apache/tinkerpop/issues/712"},"comments":{"href":"https://api.github.com/repos/apache/tinkerpop/issues/712/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/712/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/tinkerpop/pulls/712/commits"},"statuses":{"href":"https://api.github.com/repos/apache/tinkerpop/statuses/b8a278c6ce1ab7337fd6563cbf43c2f152c4aac4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jorgebay"}}