{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/110469955","pull_request_review_id":31650358,"id":110469955,"diff_hunk":"@@ -599,5 +599,180 @@ class Program\n }\";\n             await TestInRegularAndScriptAsync(initial, expected);\n         }\n+\n+        [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsMakeMethodAsynchronous)]\n+        [WorkItem(14133, \"https://github.com/dotnet/roslyn/issues/14133\")]\n+        public async Task AddAsyncInLocalFunction()\n+        {\n+            await TestInRegularAndScriptAsync(\n+@\"using System.Threading.Tasks;\n+\n+class C\n+{\n+    public void M1()\n+    {\n+        void M2()\n+        {\n+            [|await M3Async();|]\n+        }\n+    }\n+\n+    async Task<int> M3Async()\n+    {\n+        return 1;\n+    }\n+}\",\n+@\"using System.Threading.Tasks;\n+\n+class C\n+{\n+    public void M1()\n+    {\n+        async Task M2Async()\n+        {\n+            await M3Async();\n+        }\n+    }\n+\n+    async Task<int> M3Async()\n+    {\n+        return 1;\n+    }\n+}\");\n+        }\n+\n+        [Fact, Trait(Traits.Feature, Traits.Features.CodeActionsMakeMethodAsynchronous)]\n+        [WorkItem(14133, \"https://github.com/dotnet/roslyn/issues/14133\")]\n+        public async Task AddAsyncInLocalFunctionKeepVoidReturn()\n+        {\n+            await TestInRegularAndScriptAsync(\n+@\"using System.Threading.Tasks;\n+\n+class C\n+{\n+    public void M1()\n+    {\n+        void M2()\n+        {\n+            [|await M3Async();|]\n+        }\n+    }\n+\n+    async Task<int> M3Async()\n+    {\n+        return 1;\n+    }\n+}\",\n+@\"using System.Threading.Tasks;\n+\n+class C\n+{\n+    public void M1()\n+    {\n+        async void M2Async()\n+        {\n+            await M3Async();\n+        }\n+    }\n+\n+    async Task<int> M3Async()\n+    {\n+        return 1;\n+    }\n+}\",\n+index: 1);\n+        }\n+\n+        [Theory]","path":"src/EditorFeatures/CSharpTest/Diagnostics/MakeMethodAsynchronous/MakeMethodAsynchronousTests.cs","position":88,"original_position":88,"commit_id":"c8b6a0ea916dc17b017c513f7429f527b423c535","original_commit_id":"c8b6a0ea916dc17b017c513f7429f527b423c535","user":{"login":"Pilchie","id":312835,"avatar_url":"https://avatars0.githubusercontent.com/u/312835?v=3","gravatar_id":"","url":"https://api.github.com/users/Pilchie","html_url":"https://github.com/Pilchie","followers_url":"https://api.github.com/users/Pilchie/followers","following_url":"https://api.github.com/users/Pilchie/following{/other_user}","gists_url":"https://api.github.com/users/Pilchie/gists{/gist_id}","starred_url":"https://api.github.com/users/Pilchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pilchie/subscriptions","organizations_url":"https://api.github.com/users/Pilchie/orgs","repos_url":"https://api.github.com/users/Pilchie/repos","events_url":"https://api.github.com/users/Pilchie/events{/privacy}","received_events_url":"https://api.github.com/users/Pilchie/received_events","type":"User","site_admin":false},"body":"mailto:lrieger@precast-software.com","created_at":"2017-04-07T19:53:41Z","updated_at":"2017-04-07T19:53:41Z","html_url":"https://github.com/dotnet/roslyn/pull/18307#discussion_r110469955","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/18307","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/110469955"},"html":{"href":"https://github.com/dotnet/roslyn/pull/18307#discussion_r110469955"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18307"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/18307","id":113321780,"html_url":"https://github.com/dotnet/roslyn/pull/18307","diff_url":"https://github.com/dotnet/roslyn/pull/18307.diff","patch_url":"https://github.com/dotnet/roslyn/pull/18307.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/18307","number":18307,"state":"open","locked":false,"title":"Fix support for local functions in \"Make Method Asynchronous\"","user":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars2.githubusercontent.com/u/1408396?v=3","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"body":"Fixes #14133 \r\n\r\nI also fixed a similar issue in the \"Make Method Synchronous\" code fix provider.\r\n\r\nTagging @dotnet/roslyn-ide  for review","created_at":"2017-03-30T00:13:51Z","updated_at":"2017-04-07T19:53:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ab56e39a387bb8769aae62377223412fe975ae2","assignee":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars2.githubusercontent.com/u/1408396?v=3","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"assignees":[{"login":"sharwell","id":1408396,"avatar_url":"https://avatars2.githubusercontent.com/u/1408396?v=3","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/28","html_url":"https://github.com/dotnet/roslyn/milestone/28","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/28/labels","id":2372708,"number":28,"title":"15.3","description":"","creator":{"login":"jinujoseph","id":12449387,"avatar_url":"https://avatars0.githubusercontent.com/u/12449387?v=3","gravatar_id":"","url":"https://api.github.com/users/jinujoseph","html_url":"https://github.com/jinujoseph","followers_url":"https://api.github.com/users/jinujoseph/followers","following_url":"https://api.github.com/users/jinujoseph/following{/other_user}","gists_url":"https://api.github.com/users/jinujoseph/gists{/gist_id}","starred_url":"https://api.github.com/users/jinujoseph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinujoseph/subscriptions","organizations_url":"https://api.github.com/users/jinujoseph/orgs","repos_url":"https://api.github.com/users/jinujoseph/repos","events_url":"https://api.github.com/users/jinujoseph/events{/privacy}","received_events_url":"https://api.github.com/users/jinujoseph/received_events","type":"User","site_admin":false},"open_issues":516,"closed_issues":124,"state":"open","created_at":"2017-03-08T20:32:19Z","updated_at":"2017-04-07T19:52:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/18307/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/18307/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/18307/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/c8b6a0ea916dc17b017c513f7429f527b423c535","head":{"label":"sharwell:async-local-function","ref":"async-local-function","sha":"c8b6a0ea916dc17b017c513f7429f527b423c535","user":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars2.githubusercontent.com/u/1408396?v=3","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"repo":{"id":29280707,"name":"roslyn","full_name":"sharwell/roslyn","owner":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars2.githubusercontent.com/u/1408396?v=3","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sharwell/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/sharwell/roslyn","forks_url":"https://api.github.com/repos/sharwell/roslyn/forks","keys_url":"https://api.github.com/repos/sharwell/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharwell/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharwell/roslyn/teams","hooks_url":"https://api.github.com/repos/sharwell/roslyn/hooks","issue_events_url":"https://api.github.com/repos/sharwell/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/sharwell/roslyn/events","assignees_url":"https://api.github.com/repos/sharwell/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/sharwell/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/sharwell/roslyn/tags","blobs_url":"https://api.github.com/repos/sharwell/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharwell/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharwell/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharwell/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharwell/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/sharwell/roslyn/languages","stargazers_url":"https://api.github.com/repos/sharwell/roslyn/stargazers","contributors_url":"https://api.github.com/repos/sharwell/roslyn/contributors","subscribers_url":"https://api.github.com/repos/sharwell/roslyn/subscribers","subscription_url":"https://api.github.com/repos/sharwell/roslyn/subscription","commits_url":"https://api.github.com/repos/sharwell/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharwell/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharwell/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharwell/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharwell/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/sharwell/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharwell/roslyn/merges","archive_url":"https://api.github.com/repos/sharwell/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharwell/roslyn/downloads","issues_url":"https://api.github.com/repos/sharwell/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/sharwell/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/sharwell/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/sharwell/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharwell/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/sharwell/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/sharwell/roslyn/deployments","created_at":"2015-01-15T04:27:54Z","updated_at":"2015-05-02T22:30:33Z","pushed_at":"2017-04-05T20:40:24Z","git_url":"git://github.com/sharwell/roslyn.git","ssh_url":"git@github.com:sharwell/roslyn.git","clone_url":"https://github.com/sharwell/roslyn.git","svn_url":"https://github.com/sharwell/roslyn","homepage":"","size":200497,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"2ae6d29a250a8562943ba9ce8f01427e9bdfac15","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2017-04-07T18:33:44Z","pushed_at":"2017-04-07T19:50:54Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":208474,"stargazers_count":7340,"watchers_count":7340,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1769,"mirror_url":null,"open_issues_count":3478,"forks":1769,"open_issues":3478,"watchers":7340,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18307"},"html":{"href":"https://github.com/dotnet/roslyn/pull/18307"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/18307"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/18307/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18307/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/18307/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/c8b6a0ea916dc17b017c513f7429f527b423c535"}}}}
{"actor":{"display_login":"Pilchie"}}