{"action":"created","comment":{"url":"https://api.github.com/repos/open-ch/safebrowsing/pulls/comments/151932084","pull_request_review_id":77715251,"id":151932084,"diff_hunk":"@@ -504,9 +505,10 @@ func main() {\n \t\tos.Exit(1)\n \t}\n \tconf := safebrowsing.Config{\n-\t\tAPIKey: *apiKeyFlag,\n-\t\tDBPath: *databaseFlag,\n-\t\tLogger: os.Stderr,\n+\t\tAPIKey:   *apiKeyFlag,\n+\t\tProxyURL: *proxyFlag,\n+\t\tDBPath:   *databaseFlag,\n+\t\tLogger:   os.Stderr,\n \t}\n \tsb, err := safebrowsing.NewSafeBrowser(conf)","path":"cmd/sbserver/main.go","position":20,"original_position":20,"commit_id":"0cfbbaa8e87965e8a5fc49a6421d184a1a38faa3","original_commit_id":"0cfbbaa8e87965e8a5fc49a6421d184a1a38faa3","user":{"login":"thrk2","id":1714883,"avatar_url":"https://avatars1.githubusercontent.com/u/1714883?v=4","gravatar_id":"","url":"https://api.github.com/users/thrk2","html_url":"https://github.com/thrk2","followers_url":"https://api.github.com/users/thrk2/followers","following_url":"https://api.github.com/users/thrk2/following{/other_user}","gists_url":"https://api.github.com/users/thrk2/gists{/gist_id}","starred_url":"https://api.github.com/users/thrk2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thrk2/subscriptions","organizations_url":"https://api.github.com/users/thrk2/orgs","repos_url":"https://api.github.com/users/thrk2/repos","events_url":"https://api.github.com/users/thrk2/events{/privacy}","received_events_url":"https://api.github.com/users/thrk2/received_events","type":"User","site_admin":false},"body":"So I would call gsb like \r\n\r\n```\r\n\tconfig := safebrowsing.Config{\r\n\t\tAPIKey: conf.GetString(\"feeds.gsb.apikey\"),\r\n\t\tDBPath: conf.GetString(\"feeds.gsb.database\"),\r\n\t\tProxyURL: conf.GetString(\"feeds.gsb.proxy\"),\r\n\t}\r\n```\r\n```\r\n\tsafebrowser, err := safebrowsing.NewSafeBrowser(config)\r\n```","created_at":"2017-11-20T09:01:29Z","updated_at":"2017-11-20T09:01:29Z","html_url":"https://github.com/open-ch/safebrowsing/pull/1#discussion_r151932084","pull_request_url":"https://api.github.com/repos/open-ch/safebrowsing/pulls/1","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/open-ch/safebrowsing/pulls/comments/151932084"},"html":{"href":"https://github.com/open-ch/safebrowsing/pull/1#discussion_r151932084"},"pull_request":{"href":"https://api.github.com/repos/open-ch/safebrowsing/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/open-ch/safebrowsing/pulls/1","id":153347297,"html_url":"https://github.com/open-ch/safebrowsing/pull/1","diff_url":"https://github.com/open-ch/safebrowsing/pull/1.diff","patch_url":"https://github.com/open-ch/safebrowsing/pull/1.patch","issue_url":"https://api.github.com/repos/open-ch/safebrowsing/issues/1","number":1,"state":"open","locked":false,"title":"Added proxy support","user":{"login":"3kt","id":12101744,"avatar_url":"https://avatars2.githubusercontent.com/u/12101744?v=4","gravatar_id":"","url":"https://api.github.com/users/3kt","html_url":"https://github.com/3kt","followers_url":"https://api.github.com/users/3kt/followers","following_url":"https://api.github.com/users/3kt/following{/other_user}","gists_url":"https://api.github.com/users/3kt/gists{/gist_id}","starred_url":"https://api.github.com/users/3kt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3kt/subscriptions","organizations_url":"https://api.github.com/users/3kt/orgs","repos_url":"https://api.github.com/users/3kt/repos","events_url":"https://api.github.com/users/3kt/events{/privacy}","received_events_url":"https://api.github.com/users/3kt/received_events","type":"User","site_admin":false},"body":"A proxy can now be used by using the -proxy parameter in both sblookup and sbserver. This overrides the default use of the environment variable HTTP_PROXY (or http_proxy). Please refer to https://golang.org/pkg/net/http/#RoundTripper for more info","created_at":"2017-11-17T17:02:18Z","updated_at":"2017-11-20T09:01:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7cec3b155dce347eff5a6ec8c12d1ed69fe7b6eb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-ch/safebrowsing/pulls/1/commits","review_comments_url":"https://api.github.com/repos/open-ch/safebrowsing/pulls/1/comments","review_comment_url":"https://api.github.com/repos/open-ch/safebrowsing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-ch/safebrowsing/issues/1/comments","statuses_url":"https://api.github.com/repos/open-ch/safebrowsing/statuses/0cfbbaa8e87965e8a5fc49a6421d184a1a38faa3","head":{"label":"3kt:master","ref":"master","sha":"0cfbbaa8e87965e8a5fc49a6421d184a1a38faa3","user":{"login":"3kt","id":12101744,"avatar_url":"https://avatars2.githubusercontent.com/u/12101744?v=4","gravatar_id":"","url":"https://api.github.com/users/3kt","html_url":"https://github.com/3kt","followers_url":"https://api.github.com/users/3kt/followers","following_url":"https://api.github.com/users/3kt/following{/other_user}","gists_url":"https://api.github.com/users/3kt/gists{/gist_id}","starred_url":"https://api.github.com/users/3kt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3kt/subscriptions","organizations_url":"https://api.github.com/users/3kt/orgs","repos_url":"https://api.github.com/users/3kt/repos","events_url":"https://api.github.com/users/3kt/events{/privacy}","received_events_url":"https://api.github.com/users/3kt/received_events","type":"User","site_admin":false},"repo":{"id":111126391,"name":"safebrowsing","full_name":"3kt/safebrowsing","owner":{"login":"3kt","id":12101744,"avatar_url":"https://avatars2.githubusercontent.com/u/12101744?v=4","gravatar_id":"","url":"https://api.github.com/users/3kt","html_url":"https://github.com/3kt","followers_url":"https://api.github.com/users/3kt/followers","following_url":"https://api.github.com/users/3kt/following{/other_user}","gists_url":"https://api.github.com/users/3kt/gists{/gist_id}","starred_url":"https://api.github.com/users/3kt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3kt/subscriptions","organizations_url":"https://api.github.com/users/3kt/orgs","repos_url":"https://api.github.com/users/3kt/repos","events_url":"https://api.github.com/users/3kt/events{/privacy}","received_events_url":"https://api.github.com/users/3kt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/3kt/safebrowsing","description":"Safe Browsing API Go Client","fork":true,"url":"https://api.github.com/repos/3kt/safebrowsing","forks_url":"https://api.github.com/repos/3kt/safebrowsing/forks","keys_url":"https://api.github.com/repos/3kt/safebrowsing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/3kt/safebrowsing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/3kt/safebrowsing/teams","hooks_url":"https://api.github.com/repos/3kt/safebrowsing/hooks","issue_events_url":"https://api.github.com/repos/3kt/safebrowsing/issues/events{/number}","events_url":"https://api.github.com/repos/3kt/safebrowsing/events","assignees_url":"https://api.github.com/repos/3kt/safebrowsing/assignees{/user}","branches_url":"https://api.github.com/repos/3kt/safebrowsing/branches{/branch}","tags_url":"https://api.github.com/repos/3kt/safebrowsing/tags","blobs_url":"https://api.github.com/repos/3kt/safebrowsing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/3kt/safebrowsing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/3kt/safebrowsing/git/refs{/sha}","trees_url":"https://api.github.com/repos/3kt/safebrowsing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/3kt/safebrowsing/statuses/{sha}","languages_url":"https://api.github.com/repos/3kt/safebrowsing/languages","stargazers_url":"https://api.github.com/repos/3kt/safebrowsing/stargazers","contributors_url":"https://api.github.com/repos/3kt/safebrowsing/contributors","subscribers_url":"https://api.github.com/repos/3kt/safebrowsing/subscribers","subscription_url":"https://api.github.com/repos/3kt/safebrowsing/subscription","commits_url":"https://api.github.com/repos/3kt/safebrowsing/commits{/sha}","git_commits_url":"https://api.github.com/repos/3kt/safebrowsing/git/commits{/sha}","comments_url":"https://api.github.com/repos/3kt/safebrowsing/comments{/number}","issue_comment_url":"https://api.github.com/repos/3kt/safebrowsing/issues/comments{/number}","contents_url":"https://api.github.com/repos/3kt/safebrowsing/contents/{+path}","compare_url":"https://api.github.com/repos/3kt/safebrowsing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/3kt/safebrowsing/merges","archive_url":"https://api.github.com/repos/3kt/safebrowsing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/3kt/safebrowsing/downloads","issues_url":"https://api.github.com/repos/3kt/safebrowsing/issues{/number}","pulls_url":"https://api.github.com/repos/3kt/safebrowsing/pulls{/number}","milestones_url":"https://api.github.com/repos/3kt/safebrowsing/milestones{/number}","notifications_url":"https://api.github.com/repos/3kt/safebrowsing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/3kt/safebrowsing/labels{/name}","releases_url":"https://api.github.com/repos/3kt/safebrowsing/releases{/id}","deployments_url":"https://api.github.com/repos/3kt/safebrowsing/deployments","created_at":"2017-11-17T16:35:04Z","updated_at":"2017-11-17T16:35:06Z","pushed_at":"2017-11-17T16:48:32Z","git_url":"git://github.com/3kt/safebrowsing.git","ssh_url":"git@github.com:3kt/safebrowsing.git","clone_url":"https://github.com/3kt/safebrowsing.git","svn_url":"https://github.com/3kt/safebrowsing","homepage":"","size":6520,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-ch:master","ref":"master","sha":"b349c85eca8b6bf57c2242beb6c6ae20244275fe","user":{"login":"open-ch","id":6841371,"avatar_url":"https://avatars3.githubusercontent.com/u/6841371?v=4","gravatar_id":"","url":"https://api.github.com/users/open-ch","html_url":"https://github.com/open-ch","followers_url":"https://api.github.com/users/open-ch/followers","following_url":"https://api.github.com/users/open-ch/following{/other_user}","gists_url":"https://api.github.com/users/open-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/open-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-ch/subscriptions","organizations_url":"https://api.github.com/users/open-ch/orgs","repos_url":"https://api.github.com/users/open-ch/repos","events_url":"https://api.github.com/users/open-ch/events{/privacy}","received_events_url":"https://api.github.com/users/open-ch/received_events","type":"Organization","site_admin":false},"repo":{"id":111125611,"name":"safebrowsing","full_name":"open-ch/safebrowsing","owner":{"login":"open-ch","id":6841371,"avatar_url":"https://avatars3.githubusercontent.com/u/6841371?v=4","gravatar_id":"","url":"https://api.github.com/users/open-ch","html_url":"https://github.com/open-ch","followers_url":"https://api.github.com/users/open-ch/followers","following_url":"https://api.github.com/users/open-ch/following{/other_user}","gists_url":"https://api.github.com/users/open-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/open-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-ch/subscriptions","organizations_url":"https://api.github.com/users/open-ch/orgs","repos_url":"https://api.github.com/users/open-ch/repos","events_url":"https://api.github.com/users/open-ch/events{/privacy}","received_events_url":"https://api.github.com/users/open-ch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-ch/safebrowsing","description":"Safe Browsing API Go Client","fork":true,"url":"https://api.github.com/repos/open-ch/safebrowsing","forks_url":"https://api.github.com/repos/open-ch/safebrowsing/forks","keys_url":"https://api.github.com/repos/open-ch/safebrowsing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-ch/safebrowsing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-ch/safebrowsing/teams","hooks_url":"https://api.github.com/repos/open-ch/safebrowsing/hooks","issue_events_url":"https://api.github.com/repos/open-ch/safebrowsing/issues/events{/number}","events_url":"https://api.github.com/repos/open-ch/safebrowsing/events","assignees_url":"https://api.github.com/repos/open-ch/safebrowsing/assignees{/user}","branches_url":"https://api.github.com/repos/open-ch/safebrowsing/branches{/branch}","tags_url":"https://api.github.com/repos/open-ch/safebrowsing/tags","blobs_url":"https://api.github.com/repos/open-ch/safebrowsing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-ch/safebrowsing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-ch/safebrowsing/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-ch/safebrowsing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-ch/safebrowsing/statuses/{sha}","languages_url":"https://api.github.com/repos/open-ch/safebrowsing/languages","stargazers_url":"https://api.github.com/repos/open-ch/safebrowsing/stargazers","contributors_url":"https://api.github.com/repos/open-ch/safebrowsing/contributors","subscribers_url":"https://api.github.com/repos/open-ch/safebrowsing/subscribers","subscription_url":"https://api.github.com/repos/open-ch/safebrowsing/subscription","commits_url":"https://api.github.com/repos/open-ch/safebrowsing/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-ch/safebrowsing/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-ch/safebrowsing/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-ch/safebrowsing/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-ch/safebrowsing/contents/{+path}","compare_url":"https://api.github.com/repos/open-ch/safebrowsing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-ch/safebrowsing/merges","archive_url":"https://api.github.com/repos/open-ch/safebrowsing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-ch/safebrowsing/downloads","issues_url":"https://api.github.com/repos/open-ch/safebrowsing/issues{/number}","pulls_url":"https://api.github.com/repos/open-ch/safebrowsing/pulls{/number}","milestones_url":"https://api.github.com/repos/open-ch/safebrowsing/milestones{/number}","notifications_url":"https://api.github.com/repos/open-ch/safebrowsing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-ch/safebrowsing/labels{/name}","releases_url":"https://api.github.com/repos/open-ch/safebrowsing/releases{/id}","deployments_url":"https://api.github.com/repos/open-ch/safebrowsing/deployments","created_at":"2017-11-17T16:27:43Z","updated_at":"2017-11-17T16:27:45Z","pushed_at":"2017-11-17T17:02:19Z","git_url":"git://github.com/open-ch/safebrowsing.git","ssh_url":"git@github.com:open-ch/safebrowsing.git","clone_url":"https://github.com/open-ch/safebrowsing.git","svn_url":"https://github.com/open-ch/safebrowsing","homepage":"","size":6518,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-ch/safebrowsing/pulls/1"},"html":{"href":"https://github.com/open-ch/safebrowsing/pull/1"},"issue":{"href":"https://api.github.com/repos/open-ch/safebrowsing/issues/1"},"comments":{"href":"https://api.github.com/repos/open-ch/safebrowsing/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/open-ch/safebrowsing/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/open-ch/safebrowsing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-ch/safebrowsing/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/open-ch/safebrowsing/statuses/0cfbbaa8e87965e8a5fc49a6421d184a1a38faa3"}},"author_association":"NONE"}}
{"actor":{"display_login":"thrk2"}}