{"action":"created","comment":{"url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments/113198355","pull_request_review_id":34566804,"id":113198355,"diff_hunk":"@@ -32,70 +32,46 @@ bin/linuxkit: $(LINUXKIT_DEPS) | bin\n \trm tmp_linuxkit_bin.tar\n \ttouch $@\n \n-test-initrd.img: $(MOBY) test/test.yml\n-\t$(MOBY) build test/test.yml\n-\n-test-bzImage: test-initrd.img\n-\n-.PHONY: test-qemu-efi\n-test-qemu-efi: $(LINUXKIT) test-efi.iso\n-\t$(LINUXKIT) run $^ | tee test-efi.log\n-\t$(call check_test_log, test-efi.log)\n-\n bin:\n \tmkdir -p $@\n \n install:\n \tcp -R ./bin/* $(PREFIX)/bin\n \n-define check_test_log\n-\t@cat $1 |grep -q 'test suite PASSED'\n-endef\n-\n-.PHONY: test-hyperkit\n-test-hyperkit: $(LINUXKIT) test-initrd.img test-bzImage test-cmdline\n-\trm -f disk.img\n-\t$(LINUXKIT) run test | tee test.log\n-\t$(call check_test_log, test.log)\n-\n-.PHONY: test-gcp\n-test-gcp: $(LINUXKIT) test.img.tar.gz\n-\t$(LINUXKIT) push gcp test.img.tar.gz\n-\t$(LINUXKIT) run gcp test | tee test-gcp.log\n-\t$(call check_test_log, test-gcp.log)\n-\n .PHONY: test\n-test: $(LINUXKIT) test-initrd.img test-bzImage test-cmdline\n-\t$(LINUXKIT) run test | tee test.log\n-\t$(call check_test_log, test.log)\n+test: $(LINUXKIT) $(MOBY)\n+\t@MOBY=$$(if [ \"$(MOBY)\" = \"bin/moby\" ]; then echo $(PWD)/$(MOBY); else echo $(MOBY); fi) \\","path":"Makefile","position":41,"original_position":41,"commit_id":"00e85ab4ad356b52bcb3335c40fae19314836e87","original_commit_id":"00e85ab4ad356b52bcb3335c40fae19314836e87","user":{"login":"dave-tucker","id":3781777,"avatar_url":"https://avatars0.githubusercontent.com/u/3781777?v=3","gravatar_id":"","url":"https://api.github.com/users/dave-tucker","html_url":"https://github.com/dave-tucker","followers_url":"https://api.github.com/users/dave-tucker/followers","following_url":"https://api.github.com/users/dave-tucker/following{/other_user}","gists_url":"https://api.github.com/users/dave-tucker/gists{/gist_id}","starred_url":"https://api.github.com/users/dave-tucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dave-tucker/subscriptions","organizations_url":"https://api.github.com/users/dave-tucker/orgs","repos_url":"https://api.github.com/users/dave-tucker/repos","events_url":"https://api.github.com/users/dave-tucker/events{/privacy}","received_events_url":"https://api.github.com/users/dave-tucker/received_events","type":"User","site_admin":false},"body":"Does that mean that we can assume `moby` or `linuxkit` are in the `$PATH`?\r\nThat would simplify things a lot!","created_at":"2017-04-25T13:45:17Z","updated_at":"2017-04-25T13:45:17Z","html_url":"https://github.com/linuxkit/linuxkit/pull/1655#discussion_r113198355","pull_request_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/1655","_links":{"self":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments/113198355"},"html":{"href":"https://github.com/linuxkit/linuxkit/pull/1655#discussion_r113198355"},"pull_request":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/1655"}}},"pull_request":{"url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/1655","id":116370646,"html_url":"https://github.com/linuxkit/linuxkit/pull/1655","diff_url":"https://github.com/linuxkit/linuxkit/pull/1655.diff","patch_url":"https://github.com/linuxkit/linuxkit/pull/1655.patch","issue_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/1655","number":1655,"state":"open","locked":false,"title":"Clean up the tests","user":{"login":"dave-tucker","id":3781777,"avatar_url":"https://avatars0.githubusercontent.com/u/3781777?v=3","gravatar_id":"","url":"https://api.github.com/users/dave-tucker","html_url":"https://github.com/dave-tucker","followers_url":"https://api.github.com/users/dave-tucker/followers","following_url":"https://api.github.com/users/dave-tucker/following{/other_user}","gists_url":"https://api.github.com/users/dave-tucker/gists{/gist_id}","starred_url":"https://api.github.com/users/dave-tucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dave-tucker/subscriptions","organizations_url":"https://api.github.com/users/dave-tucker/orgs","repos_url":"https://api.github.com/users/dave-tucker/repos","events_url":"https://api.github.com/users/dave-tucker/events{/privacy}","received_events_url":"https://api.github.com/users/dave-tucker/received_events","type":"User","site_admin":false},"body":"This PR cleans up the tests a little.\n\nIt moves the packages in to a `tests/pkg` directory.\nThe YAML files are moved to `tests/cases`.\n\nThis follows the convention in the root of the repo and allows for better modularity.\n\nThe `test/test.yml` is now `tests/cases/test-kernel-config.yml` which better reflects its purpose.\nI also removed `dhcpd` from the `test-kernel-config.yml` and used the new `poweroff` pkg to shutdown on completion.\n\nRework of #1598","created_at":"2017-04-18T16:39:36Z","updated_at":"2017-04-25T13:45:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d4ff7e43bcde3d6861dbc306015a1c00fcee919","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/1655/commits","review_comments_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/1655/comments","review_comment_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/1655/comments","statuses_url":"https://api.github.com/repos/linuxkit/linuxkit/statuses/00e85ab4ad356b52bcb3335c40fae19314836e87","head":{"label":"dave-tucker:test-cleanup","ref":"test-cleanup","sha":"00e85ab4ad356b52bcb3335c40fae19314836e87","user":{"login":"dave-tucker","id":3781777,"avatar_url":"https://avatars0.githubusercontent.com/u/3781777?v=3","gravatar_id":"","url":"https://api.github.com/users/dave-tucker","html_url":"https://github.com/dave-tucker","followers_url":"https://api.github.com/users/dave-tucker/followers","following_url":"https://api.github.com/users/dave-tucker/following{/other_user}","gists_url":"https://api.github.com/users/dave-tucker/gists{/gist_id}","starred_url":"https://api.github.com/users/dave-tucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dave-tucker/subscriptions","organizations_url":"https://api.github.com/users/dave-tucker/orgs","repos_url":"https://api.github.com/users/dave-tucker/repos","events_url":"https://api.github.com/users/dave-tucker/events{/privacy}","received_events_url":"https://api.github.com/users/dave-tucker/received_events","type":"User","site_admin":false},"repo":{"id":88644217,"name":"linuxkit","full_name":"dave-tucker/linuxkit","owner":{"login":"dave-tucker","id":3781777,"avatar_url":"https://avatars0.githubusercontent.com/u/3781777?v=3","gravatar_id":"","url":"https://api.github.com/users/dave-tucker","html_url":"https://github.com/dave-tucker","followers_url":"https://api.github.com/users/dave-tucker/followers","following_url":"https://api.github.com/users/dave-tucker/following{/other_user}","gists_url":"https://api.github.com/users/dave-tucker/gists{/gist_id}","starred_url":"https://api.github.com/users/dave-tucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dave-tucker/subscriptions","organizations_url":"https://api.github.com/users/dave-tucker/orgs","repos_url":"https://api.github.com/users/dave-tucker/repos","events_url":"https://api.github.com/users/dave-tucker/events{/privacy}","received_events_url":"https://api.github.com/users/dave-tucker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dave-tucker/linuxkit","description":"A toolkit for building secure, portable and lean operating systems for containers","fork":true,"url":"https://api.github.com/repos/dave-tucker/linuxkit","forks_url":"https://api.github.com/repos/dave-tucker/linuxkit/forks","keys_url":"https://api.github.com/repos/dave-tucker/linuxkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dave-tucker/linuxkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dave-tucker/linuxkit/teams","hooks_url":"https://api.github.com/repos/dave-tucker/linuxkit/hooks","issue_events_url":"https://api.github.com/repos/dave-tucker/linuxkit/issues/events{/number}","events_url":"https://api.github.com/repos/dave-tucker/linuxkit/events","assignees_url":"https://api.github.com/repos/dave-tucker/linuxkit/assignees{/user}","branches_url":"https://api.github.com/repos/dave-tucker/linuxkit/branches{/branch}","tags_url":"https://api.github.com/repos/dave-tucker/linuxkit/tags","blobs_url":"https://api.github.com/repos/dave-tucker/linuxkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dave-tucker/linuxkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dave-tucker/linuxkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/dave-tucker/linuxkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dave-tucker/linuxkit/statuses/{sha}","languages_url":"https://api.github.com/repos/dave-tucker/linuxkit/languages","stargazers_url":"https://api.github.com/repos/dave-tucker/linuxkit/stargazers","contributors_url":"https://api.github.com/repos/dave-tucker/linuxkit/contributors","subscribers_url":"https://api.github.com/repos/dave-tucker/linuxkit/subscribers","subscription_url":"https://api.github.com/repos/dave-tucker/linuxkit/subscription","commits_url":"https://api.github.com/repos/dave-tucker/linuxkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/dave-tucker/linuxkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/dave-tucker/linuxkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/dave-tucker/linuxkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/dave-tucker/linuxkit/contents/{+path}","compare_url":"https://api.github.com/repos/dave-tucker/linuxkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dave-tucker/linuxkit/merges","archive_url":"https://api.github.com/repos/dave-tucker/linuxkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dave-tucker/linuxkit/downloads","issues_url":"https://api.github.com/repos/dave-tucker/linuxkit/issues{/number}","pulls_url":"https://api.github.com/repos/dave-tucker/linuxkit/pulls{/number}","milestones_url":"https://api.github.com/repos/dave-tucker/linuxkit/milestones{/number}","notifications_url":"https://api.github.com/repos/dave-tucker/linuxkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dave-tucker/linuxkit/labels{/name}","releases_url":"https://api.github.com/repos/dave-tucker/linuxkit/releases{/id}","deployments_url":"https://api.github.com/repos/dave-tucker/linuxkit/deployments","created_at":"2017-04-18T16:00:00Z","updated_at":"2017-04-18T16:00:02Z","pushed_at":"2017-04-25T13:28:52Z","git_url":"git://github.com/dave-tucker/linuxkit.git","ssh_url":"git@github.com:dave-tucker/linuxkit.git","clone_url":"https://github.com/dave-tucker/linuxkit.git","svn_url":"https://github.com/dave-tucker/linuxkit","homepage":"","size":16114,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linuxkit:master","ref":"master","sha":"35d8070abc85690e6578453c946d1f47d458bf3a","user":{"login":"linuxkit","id":27256246,"avatar_url":"https://avatars1.githubusercontent.com/u/27256246?v=3","gravatar_id":"","url":"https://api.github.com/users/linuxkit","html_url":"https://github.com/linuxkit","followers_url":"https://api.github.com/users/linuxkit/followers","following_url":"https://api.github.com/users/linuxkit/following{/other_user}","gists_url":"https://api.github.com/users/linuxkit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxkit/subscriptions","organizations_url":"https://api.github.com/users/linuxkit/orgs","repos_url":"https://api.github.com/users/linuxkit/repos","events_url":"https://api.github.com/users/linuxkit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxkit/received_events","type":"Organization","site_admin":false},"repo":{"id":46932243,"name":"linuxkit","full_name":"linuxkit/linuxkit","owner":{"login":"linuxkit","id":27256246,"avatar_url":"https://avatars1.githubusercontent.com/u/27256246?v=3","gravatar_id":"","url":"https://api.github.com/users/linuxkit","html_url":"https://github.com/linuxkit","followers_url":"https://api.github.com/users/linuxkit/followers","following_url":"https://api.github.com/users/linuxkit/following{/other_user}","gists_url":"https://api.github.com/users/linuxkit/gists{/gist_id}","starred_url":"https://api.github.com/users/linuxkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linuxkit/subscriptions","organizations_url":"https://api.github.com/users/linuxkit/orgs","repos_url":"https://api.github.com/users/linuxkit/repos","events_url":"https://api.github.com/users/linuxkit/events{/privacy}","received_events_url":"https://api.github.com/users/linuxkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linuxkit/linuxkit","description":"A toolkit for building secure, portable and lean operating systems for containers","fork":false,"url":"https://api.github.com/repos/linuxkit/linuxkit","forks_url":"https://api.github.com/repos/linuxkit/linuxkit/forks","keys_url":"https://api.github.com/repos/linuxkit/linuxkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linuxkit/linuxkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linuxkit/linuxkit/teams","hooks_url":"https://api.github.com/repos/linuxkit/linuxkit/hooks","issue_events_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/events{/number}","events_url":"https://api.github.com/repos/linuxkit/linuxkit/events","assignees_url":"https://api.github.com/repos/linuxkit/linuxkit/assignees{/user}","branches_url":"https://api.github.com/repos/linuxkit/linuxkit/branches{/branch}","tags_url":"https://api.github.com/repos/linuxkit/linuxkit/tags","blobs_url":"https://api.github.com/repos/linuxkit/linuxkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linuxkit/linuxkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linuxkit/linuxkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/linuxkit/linuxkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linuxkit/linuxkit/statuses/{sha}","languages_url":"https://api.github.com/repos/linuxkit/linuxkit/languages","stargazers_url":"https://api.github.com/repos/linuxkit/linuxkit/stargazers","contributors_url":"https://api.github.com/repos/linuxkit/linuxkit/contributors","subscribers_url":"https://api.github.com/repos/linuxkit/linuxkit/subscribers","subscription_url":"https://api.github.com/repos/linuxkit/linuxkit/subscription","commits_url":"https://api.github.com/repos/linuxkit/linuxkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/linuxkit/linuxkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/linuxkit/linuxkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/linuxkit/linuxkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/linuxkit/linuxkit/contents/{+path}","compare_url":"https://api.github.com/repos/linuxkit/linuxkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linuxkit/linuxkit/merges","archive_url":"https://api.github.com/repos/linuxkit/linuxkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linuxkit/linuxkit/downloads","issues_url":"https://api.github.com/repos/linuxkit/linuxkit/issues{/number}","pulls_url":"https://api.github.com/repos/linuxkit/linuxkit/pulls{/number}","milestones_url":"https://api.github.com/repos/linuxkit/linuxkit/milestones{/number}","notifications_url":"https://api.github.com/repos/linuxkit/linuxkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linuxkit/linuxkit/labels{/name}","releases_url":"https://api.github.com/repos/linuxkit/linuxkit/releases{/id}","deployments_url":"https://api.github.com/repos/linuxkit/linuxkit/deployments","created_at":"2015-11-26T14:48:52Z","updated_at":"2017-04-25T13:42:19Z","pushed_at":"2017-04-25T13:28:53Z","git_url":"git://github.com/linuxkit/linuxkit.git","ssh_url":"git@github.com:linuxkit/linuxkit.git","clone_url":"https://github.com/linuxkit/linuxkit.git","svn_url":"https://github.com/linuxkit/linuxkit","homepage":"","size":16110,"stargazers_count":2112,"watchers_count":2112,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":161,"mirror_url":null,"open_issues_count":160,"forks":161,"open_issues":160,"watchers":2112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/1655"},"html":{"href":"https://github.com/linuxkit/linuxkit/pull/1655"},"issue":{"href":"https://api.github.com/repos/linuxkit/linuxkit/issues/1655"},"comments":{"href":"https://api.github.com/repos/linuxkit/linuxkit/issues/1655/comments"},"review_comments":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/1655/comments"},"review_comment":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linuxkit/linuxkit/pulls/1655/commits"},"statuses":{"href":"https://api.github.com/repos/linuxkit/linuxkit/statuses/00e85ab4ad356b52bcb3335c40fae19314836e87"}}}}
{"actor":{"display_login":"dave-tucker"}}