{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/99547288","pull_request_review_id":20225905,"id":99547288,"diff_hunk":"@@ -35,6 +35,12 @@ class PlgButtonFields extends JPlugin\n \t */\n \tpublic function onDisplay($name)\n \t{\n+\t\t// Do not display button if content and system plugins are disabled\n+\t\tif (!JPluginHelper::isEnabled('content', 'fields') && !JPluginHelper::isEnabled('system', 'fields'))\n+\t\t{","path":"plugins/editors-xtd/fields/fields.php","position":6,"original_position":6,"commit_id":"f34367be648032066a5acb6481dddcfba536ebe5","original_commit_id":"f34367be648032066a5acb6481dddcfba536ebe5","user":{"login":"csthomas","id":9054379,"avatar_url":"https://avatars.githubusercontent.com/u/9054379?v=3","gravatar_id":"","url":"https://api.github.com/users/csthomas","html_url":"https://github.com/csthomas","followers_url":"https://api.github.com/users/csthomas/followers","following_url":"https://api.github.com/users/csthomas/following{/other_user}","gists_url":"https://api.github.com/users/csthomas/gists{/gist_id}","starred_url":"https://api.github.com/users/csthomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csthomas/subscriptions","organizations_url":"https://api.github.com/users/csthomas/orgs","repos_url":"https://api.github.com/users/csthomas/repos","events_url":"https://api.github.com/users/csthomas/events{/privacy}","received_events_url":"https://api.github.com/users/csthomas/received_events","type":"User","site_admin":false},"body":"> The Button - Fields editors-xtd should only display when both the Content - Fields and System - Fields are enabled.\r\nAccording to your comment, please change `&&` to `||`","created_at":"2017-02-06T09:45:37Z","updated_at":"2017-02-06T09:45:38Z","html_url":"https://github.com/joomla/joomla-cms/pull/13946#discussion_r99547288","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13946","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/99547288"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/13946#discussion_r99547288"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13946"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13946","id":104754071,"html_url":"https://github.com/joomla/joomla-cms/pull/13946","diff_url":"https://github.com/joomla/joomla-cms/pull/13946.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/13946.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13946","number":13946,"state":"open","locked":false,"title":"Module and fields editors-xtd buttons should only display when their related plugins are enabled.","user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"body":"The Button - Module editor-xtd should only display when Content - Load Modules is enabled.\r\nThe Button - Fields editors-xtd should only display when **both** the Content - Fields and System - Fields are enabled.\r\n\r\nOtherwise the tags entered with these buttons will show as tags `{whatever}` as they will not be able to display what they should.\r\n\r\n**Test instructions**\r\nUse TinyMCE and edit an article.\r\nPatch and test disabling the said plugins. The buttons will not display anymore.\r\n\r\n@Bakual","created_at":"2017-02-06T08:30:58Z","updated_at":"2017-02-06T09:45:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0e7642c9c62d5a3ba95a75bd59347fee96cdd86","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13946/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/13946/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/13946/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/f34367be648032066a5acb6481dddcfba536ebe5","head":{"label":"infograf768:fields_button_display","ref":"fields_button_display","sha":"f34367be648032066a5acb6481dddcfba536ebe5","user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"repo":{"id":3025712,"name":"joomla-cms","full_name":"infograf768/joomla-cms","owner":{"login":"infograf768","id":869724,"avatar_url":"https://avatars.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/infograf768/joomla-cms","description":"Fork of the Joomla! CMS","fork":true,"url":"https://api.github.com/repos/infograf768/joomla-cms","forks_url":"https://api.github.com/repos/infograf768/joomla-cms/forks","keys_url":"https://api.github.com/repos/infograf768/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infograf768/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infograf768/joomla-cms/teams","hooks_url":"https://api.github.com/repos/infograf768/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/infograf768/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/infograf768/joomla-cms/events","assignees_url":"https://api.github.com/repos/infograf768/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/infograf768/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/infograf768/joomla-cms/tags","blobs_url":"https://api.github.com/repos/infograf768/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infograf768/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infograf768/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/infograf768/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infograf768/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/infograf768/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/infograf768/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/infograf768/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/infograf768/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/infograf768/joomla-cms/subscription","commits_url":"https://api.github.com/repos/infograf768/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/infograf768/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/infograf768/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/infograf768/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/infograf768/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/infograf768/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infograf768/joomla-cms/merges","archive_url":"https://api.github.com/repos/infograf768/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infograf768/joomla-cms/downloads","issues_url":"https://api.github.com/repos/infograf768/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/infograf768/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/infograf768/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/infograf768/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infograf768/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/infograf768/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/infograf768/joomla-cms/deployments","created_at":"2011-12-21T08:55:33Z","updated_at":"2016-02-15T02:03:35Z","pushed_at":"2017-02-06T09:19:00Z","git_url":"git://github.com/infograf768/joomla-cms.git","ssh_url":"git@github.com:infograf768/joomla-cms.git","clone_url":"https://github.com/infograf768/joomla-cms.git","svn_url":"https://github.com/infograf768/joomla-cms","homepage":"http://joomla.org","size":161671,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"joomla:staging","ref":"staging","sha":"fa610bb0adc4292b9d2bc10679f474e80b7a52ea","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2017-02-04T11:44:40Z","pushed_at":"2017-02-06T09:24:50Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":181781,"stargazers_count":2248,"watchers_count":2248,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2387,"mirror_url":null,"open_issues_count":622,"forks":2387,"open_issues":622,"watchers":2248,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13946"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/13946"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13946"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/13946/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13946/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/13946/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/f34367be648032066a5acb6481dddcfba536ebe5"}}}}
{"actor":{"display_login":"csthomas"}}