{"action":"created","comment":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments/147139435","pull_request_review_id":72189736,"id":147139435,"diff_hunk":"@@ -0,0 +1,119 @@\n+require('../../stylus/components/_data-iterator.styl')\n+\n+import DataIterable from '../../mixins/data-iterable'\n+\n+export default {\n+  name: 'v-data-iterator',\n+\n+  mixins: [DataIterable],\n+\n+  inheritAttrs: false,\n+\n+  props: {\n+    tag: {\n+      type: String,\n+      default: 'div'\n+    }\n+  },\n+\n+  computed: {\n+    classes () {\n+      return {\n+        'dataiterator': true,\n+        'dataiterator--select-all': this.selectAll !== false,\n+        'theme--dark': this.dark,\n+        'theme--light': this.light\n+      }\n+    }\n+  },\n+\n+  methods: {\n+    createProps (item, index) {","path":"src/components/VDataIterator/VDataIterator.js","position":31,"original_position":31,"commit_id":"48184dec3d7850cb0b39b52e620e701233156a04","original_commit_id":"48184dec3d7850cb0b39b52e620e701233156a04","user":{"login":"nekosaur","id":623137,"avatar_url":"https://avatars3.githubusercontent.com/u/623137?v=4","gravatar_id":"","url":"https://api.github.com/users/nekosaur","html_url":"https://github.com/nekosaur","followers_url":"https://api.github.com/users/nekosaur/followers","following_url":"https://api.github.com/users/nekosaur/following{/other_user}","gists_url":"https://api.github.com/users/nekosaur/gists{/gist_id}","starred_url":"https://api.github.com/users/nekosaur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nekosaur/subscriptions","organizations_url":"https://api.github.com/users/nekosaur/orgs","repos_url":"https://api.github.com/users/nekosaur/repos","events_url":"https://api.github.com/users/nekosaur/events{/privacy}","received_events_url":"https://api.github.com/users/nekosaur/received_events","type":"User","site_admin":false},"body":"Try to refactor createProps from v-data-table into data-iterable instead.","created_at":"2017-10-26T13:24:40Z","updated_at":"2017-10-26T13:40:59Z","html_url":"https://github.com/vuetifyjs/vuetify/pull/2297#discussion_r147139435","pull_request_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2297","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments/147139435"},"html":{"href":"https://github.com/vuetifyjs/vuetify/pull/2297#discussion_r147139435"},"pull_request":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2297"}}},"pull_request":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2297","id":148039768,"html_url":"https://github.com/vuetifyjs/vuetify/pull/2297","diff_url":"https://github.com/vuetifyjs/vuetify/pull/2297.diff","patch_url":"https://github.com/vuetifyjs/vuetify/pull/2297.patch","issue_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/2297","number":2297,"state":"open","locked":false,"title":"New Component: Data Iterator (DataTable abstraction)","user":{"login":"Phlow2001","id":4063783,"avatar_url":"https://avatars3.githubusercontent.com/u/4063783?v=4","gravatar_id":"","url":"https://api.github.com/users/Phlow2001","html_url":"https://github.com/Phlow2001","followers_url":"https://api.github.com/users/Phlow2001/followers","following_url":"https://api.github.com/users/Phlow2001/following{/other_user}","gists_url":"https://api.github.com/users/Phlow2001/gists{/gist_id}","starred_url":"https://api.github.com/users/Phlow2001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phlow2001/subscriptions","organizations_url":"https://api.github.com/users/Phlow2001/orgs","repos_url":"https://api.github.com/users/Phlow2001/repos","events_url":"https://api.github.com/users/Phlow2001/events{/privacy}","received_events_url":"https://api.github.com/users/Phlow2001/received_events","type":"User","site_admin":false},"body":"- Extracted data related behavior from VDataTable into data-iterable mixin\r\n- Refactored VDataTable to be render and data table specific behavior with data-iterable mixin\r\n- Created new VDataIterator component with data-iterable mixin\r\n- Fixed bugs in VDataTable no-data and no-results, as well as fixing and enhancing data table tests.\r\n- Added VDataIterator tests and snapshots\r\n\r\nExample usage of VDataIterator: https://codepen.io/jayblanchard/pen/NvbwMa?editors=1010","created_at":"2017-10-23T04:52:07Z","updated_at":"2017-10-26T13:40:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"349f8ddc5f3551df062dbcd53ba2ff814d8a0fe1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2297/commits","review_comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2297/comments","review_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/2297/comments","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/48184dec3d7850cb0b39b52e620e701233156a04","head":{"label":"Phlow2001:DataIterableAbstraction","ref":"DataIterableAbstraction","sha":"48184dec3d7850cb0b39b52e620e701233156a04","user":{"login":"Phlow2001","id":4063783,"avatar_url":"https://avatars3.githubusercontent.com/u/4063783?v=4","gravatar_id":"","url":"https://api.github.com/users/Phlow2001","html_url":"https://github.com/Phlow2001","followers_url":"https://api.github.com/users/Phlow2001/followers","following_url":"https://api.github.com/users/Phlow2001/following{/other_user}","gists_url":"https://api.github.com/users/Phlow2001/gists{/gist_id}","starred_url":"https://api.github.com/users/Phlow2001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phlow2001/subscriptions","organizations_url":"https://api.github.com/users/Phlow2001/orgs","repos_url":"https://api.github.com/users/Phlow2001/repos","events_url":"https://api.github.com/users/Phlow2001/events{/privacy}","received_events_url":"https://api.github.com/users/Phlow2001/received_events","type":"User","site_admin":false},"repo":{"id":98423073,"name":"vuetify","full_name":"Phlow2001/vuetify","owner":{"login":"Phlow2001","id":4063783,"avatar_url":"https://avatars3.githubusercontent.com/u/4063783?v=4","gravatar_id":"","url":"https://api.github.com/users/Phlow2001","html_url":"https://github.com/Phlow2001","followers_url":"https://api.github.com/users/Phlow2001/followers","following_url":"https://api.github.com/users/Phlow2001/following{/other_user}","gists_url":"https://api.github.com/users/Phlow2001/gists{/gist_id}","starred_url":"https://api.github.com/users/Phlow2001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Phlow2001/subscriptions","organizations_url":"https://api.github.com/users/Phlow2001/orgs","repos_url":"https://api.github.com/users/Phlow2001/repos","events_url":"https://api.github.com/users/Phlow2001/events{/privacy}","received_events_url":"https://api.github.com/users/Phlow2001/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Phlow2001/vuetify","description":"Material Component Framework for Vue.js 2","fork":true,"url":"https://api.github.com/repos/Phlow2001/vuetify","forks_url":"https://api.github.com/repos/Phlow2001/vuetify/forks","keys_url":"https://api.github.com/repos/Phlow2001/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Phlow2001/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Phlow2001/vuetify/teams","hooks_url":"https://api.github.com/repos/Phlow2001/vuetify/hooks","issue_events_url":"https://api.github.com/repos/Phlow2001/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/Phlow2001/vuetify/events","assignees_url":"https://api.github.com/repos/Phlow2001/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/Phlow2001/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/Phlow2001/vuetify/tags","blobs_url":"https://api.github.com/repos/Phlow2001/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Phlow2001/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Phlow2001/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/Phlow2001/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Phlow2001/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/Phlow2001/vuetify/languages","stargazers_url":"https://api.github.com/repos/Phlow2001/vuetify/stargazers","contributors_url":"https://api.github.com/repos/Phlow2001/vuetify/contributors","subscribers_url":"https://api.github.com/repos/Phlow2001/vuetify/subscribers","subscription_url":"https://api.github.com/repos/Phlow2001/vuetify/subscription","commits_url":"https://api.github.com/repos/Phlow2001/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/Phlow2001/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/Phlow2001/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/Phlow2001/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/Phlow2001/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/Phlow2001/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Phlow2001/vuetify/merges","archive_url":"https://api.github.com/repos/Phlow2001/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Phlow2001/vuetify/downloads","issues_url":"https://api.github.com/repos/Phlow2001/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/Phlow2001/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/Phlow2001/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/Phlow2001/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Phlow2001/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/Phlow2001/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/Phlow2001/vuetify/deployments","created_at":"2017-07-26T12:58:49Z","updated_at":"2017-07-26T12:58:52Z","pushed_at":"2017-10-23T20:54:57Z","git_url":"git://github.com/Phlow2001/vuetify.git","ssh_url":"git@github.com:Phlow2001/vuetify.git","clone_url":"https://github.com/Phlow2001/vuetify.git","svn_url":"https://github.com/Phlow2001/vuetify","homepage":"https://vuetifyjs.com","size":10547,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"vuetifyjs:dev","ref":"dev","sha":"abbd52ba99d6d9b5f963f3e49c2e90e9a76bebc0","user":{"login":"vuetifyjs","id":22138497,"avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67962648,"name":"vuetify","full_name":"vuetifyjs/vuetify","owner":{"login":"vuetifyjs","id":22138497,"avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vuetifyjs/vuetify","description":"Material Component Framework for Vue.js 2","fork":false,"url":"https://api.github.com/repos/vuetifyjs/vuetify","forks_url":"https://api.github.com/repos/vuetifyjs/vuetify/forks","keys_url":"https://api.github.com/repos/vuetifyjs/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuetifyjs/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuetifyjs/vuetify/teams","hooks_url":"https://api.github.com/repos/vuetifyjs/vuetify/hooks","issue_events_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/vuetifyjs/vuetify/events","assignees_url":"https://api.github.com/repos/vuetifyjs/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/vuetifyjs/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/tags","blobs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/vuetifyjs/vuetify/languages","stargazers_url":"https://api.github.com/repos/vuetifyjs/vuetify/stargazers","contributors_url":"https://api.github.com/repos/vuetifyjs/vuetify/contributors","subscribers_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscribers","subscription_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscription","commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuetifyjs/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/vuetifyjs/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuetifyjs/vuetify/merges","archive_url":"https://api.github.com/repos/vuetifyjs/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuetifyjs/vuetify/downloads","issues_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/vuetifyjs/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/vuetifyjs/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuetifyjs/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/vuetifyjs/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/vuetifyjs/vuetify/deployments","created_at":"2016-09-12T00:39:35Z","updated_at":"2017-10-26T12:54:55Z","pushed_at":"2017-10-26T12:27:44Z","git_url":"git://github.com/vuetifyjs/vuetify.git","ssh_url":"git@github.com:vuetifyjs/vuetify.git","clone_url":"https://github.com/vuetifyjs/vuetify.git","svn_url":"https://github.com/vuetifyjs/vuetify","homepage":"https://vuetifyjs.com","size":10622,"stargazers_count":6079,"watchers_count":6079,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":460,"mirror_url":null,"archived":false,"open_issues_count":148,"forks":460,"open_issues":148,"watchers":6079,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2297"},"html":{"href":"https://github.com/vuetifyjs/vuetify/pull/2297"},"issue":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/2297"},"comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/2297/comments"},"review_comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2297/comments"},"review_comment":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/2297/commits"},"statuses":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/48184dec3d7850cb0b39b52e620e701233156a04"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nekosaur"}}