{"action":"created","comment":{"url":"https://api.github.com/repos/conan-io/conan/pulls/comments/133771383","pull_request_review_id":56985713,"id":133771383,"diff_hunk":"@@ -0,0 +1,18 @@\n+from conans.errors import InvalidConanSettingField\n+\n+\n+def preprocess(settings, output):\n+    fill_runtime(settings, output)\n+\n+\n+def fill_runtime(settings, output):\n+    try:\n+        if settings.compiler == \"Visual Studio\":\n+            if settings.get_safe(\"compiler.runtime\") is None:\n+                settings.compiler.runtime = \"MDd\" if settings.get_safe(\"build_type\") == \"Debug\" \\\n+                                                  else \"MD\"\n+                output.info(\"Setting 'compiler.runtime' not declared, automatically \"\n+                            \"adjusted to '%s'\" % settings.compiler.runtime)\n+    except InvalidConanSettingField:  # If the settings structure doesn't match these general","path":"conans/client/settings_preprocessor.py","position":16,"original_position":16,"commit_id":"ee927c3eee5688dee9c62e565a5b78f3e8c063db","original_commit_id":"ee927c3eee5688dee9c62e565a5b78f3e8c063db","user":{"login":"memsharded","id":15367152,"avatar_url":"https://avatars2.githubusercontent.com/u/15367152?v=4","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"body":"I guess it is somewhat related to your question about opt-it, opt-out. We need to make sure this doesn't block users, yet it is useful.\r\n\r\nI think this might belong to the profile. So a profile can have ``runtime = auto`` or ``runtime = MT auto`` or something like that.","created_at":"2017-08-17T17:02:34Z","updated_at":"2017-08-17T17:02:46Z","html_url":"https://github.com/conan-io/conan/pull/1625#discussion_r133771383","pull_request_url":"https://api.github.com/repos/conan-io/conan/pulls/1625","_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments/133771383"},"html":{"href":"https://github.com/conan-io/conan/pull/1625#discussion_r133771383"},"pull_request":{"href":"https://api.github.com/repos/conan-io/conan/pulls/1625"}}},"pull_request":{"url":"https://api.github.com/repos/conan-io/conan/pulls/1625","id":136295354,"html_url":"https://github.com/conan-io/conan/pull/1625","diff_url":"https://github.com/conan-io/conan/pull/1625.diff","patch_url":"https://github.com/conan-io/conan/pull/1625.patch","issue_url":"https://api.github.com/repos/conan-io/conan/issues/1625","number":1625,"state":"open","locked":false,"title":"Settings preprocessor for runtime","user":{"login":"lasote","id":3807515,"avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"body":"- Should be opt-in or opt-out maybe?\r\n- Related with #1497 ","created_at":"2017-08-17T16:07:11Z","updated_at":"2017-08-17T17:02:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b4748ef523e91799a610d4dbd165e36f46c6dea","assignee":{"login":"memsharded","id":15367152,"avatar_url":"https://avatars2.githubusercontent.com/u/15367152?v=4","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"assignees":[{"login":"memsharded","id":15367152,"avatar_url":"https://avatars2.githubusercontent.com/u/15367152?v=4","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/conan-io/conan/milestones/21","html_url":"https://github.com/conan-io/conan/milestone/21","labels_url":"https://api.github.com/repos/conan-io/conan/milestones/21/labels","id":2612401,"number":21,"title":"0.26","description":null,"creator":{"login":"memsharded","id":15367152,"avatar_url":"https://avatars2.githubusercontent.com/u/15367152?v=4","gravatar_id":"","url":"https://api.github.com/users/memsharded","html_url":"https://github.com/memsharded","followers_url":"https://api.github.com/users/memsharded/followers","following_url":"https://api.github.com/users/memsharded/following{/other_user}","gists_url":"https://api.github.com/users/memsharded/gists{/gist_id}","starred_url":"https://api.github.com/users/memsharded/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/memsharded/subscriptions","organizations_url":"https://api.github.com/users/memsharded/orgs","repos_url":"https://api.github.com/users/memsharded/repos","events_url":"https://api.github.com/users/memsharded/events{/privacy}","received_events_url":"https://api.github.com/users/memsharded/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":24,"state":"open","created_at":"2017-06-29T14:51:04Z","updated_at":"2017-08-17T16:38:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/conan-io/conan/pulls/1625/commits","review_comments_url":"https://api.github.com/repos/conan-io/conan/pulls/1625/comments","review_comment_url":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/conan-io/conan/issues/1625/comments","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/ee927c3eee5688dee9c62e565a5b78f3e8c063db","head":{"label":"lasote:feature/settings_preprocessor","ref":"feature/settings_preprocessor","sha":"ee927c3eee5688dee9c62e565a5b78f3e8c063db","user":{"login":"lasote","id":3807515,"avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"repo":{"id":47204017,"name":"conan","full_name":"lasote/conan","owner":{"login":"lasote","id":3807515,"avatar_url":"https://avatars1.githubusercontent.com/u/3807515?v=4","gravatar_id":"","url":"https://api.github.com/users/lasote","html_url":"https://github.com/lasote","followers_url":"https://api.github.com/users/lasote/followers","following_url":"https://api.github.com/users/lasote/following{/other_user}","gists_url":"https://api.github.com/users/lasote/gists{/gist_id}","starred_url":"https://api.github.com/users/lasote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasote/subscriptions","organizations_url":"https://api.github.com/users/lasote/orgs","repos_url":"https://api.github.com/users/lasote/repos","events_url":"https://api.github.com/users/lasote/events{/privacy}","received_events_url":"https://api.github.com/users/lasote/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lasote/conan","description":"Conan.io - The open-source C/C++ package manager","fork":true,"url":"https://api.github.com/repos/lasote/conan","forks_url":"https://api.github.com/repos/lasote/conan/forks","keys_url":"https://api.github.com/repos/lasote/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lasote/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lasote/conan/teams","hooks_url":"https://api.github.com/repos/lasote/conan/hooks","issue_events_url":"https://api.github.com/repos/lasote/conan/issues/events{/number}","events_url":"https://api.github.com/repos/lasote/conan/events","assignees_url":"https://api.github.com/repos/lasote/conan/assignees{/user}","branches_url":"https://api.github.com/repos/lasote/conan/branches{/branch}","tags_url":"https://api.github.com/repos/lasote/conan/tags","blobs_url":"https://api.github.com/repos/lasote/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lasote/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lasote/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/lasote/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lasote/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/lasote/conan/languages","stargazers_url":"https://api.github.com/repos/lasote/conan/stargazers","contributors_url":"https://api.github.com/repos/lasote/conan/contributors","subscribers_url":"https://api.github.com/repos/lasote/conan/subscribers","subscription_url":"https://api.github.com/repos/lasote/conan/subscription","commits_url":"https://api.github.com/repos/lasote/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/lasote/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/lasote/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/lasote/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/lasote/conan/contents/{+path}","compare_url":"https://api.github.com/repos/lasote/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lasote/conan/merges","archive_url":"https://api.github.com/repos/lasote/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lasote/conan/downloads","issues_url":"https://api.github.com/repos/lasote/conan/issues{/number}","pulls_url":"https://api.github.com/repos/lasote/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/lasote/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/lasote/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lasote/conan/labels{/name}","releases_url":"https://api.github.com/repos/lasote/conan/releases{/id}","deployments_url":"https://api.github.com/repos/lasote/conan/deployments","created_at":"2015-12-01T16:56:42Z","updated_at":"2017-07-19T13:30:17Z","pushed_at":"2017-08-17T16:05:37Z","git_url":"git://github.com/lasote/conan.git","ssh_url":"git@github.com:lasote/conan.git","clone_url":"https://github.com/lasote/conan.git","svn_url":"https://github.com/lasote/conan","homepage":"https://conan.io","size":3155,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"conan-io:develop","ref":"develop","sha":"ab624f6a4936e0cbe994684020192c9150f1127e","user":{"login":"conan-io","id":15212165,"avatar_url":"https://avatars3.githubusercontent.com/u/15212165?v=4","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"repo":{"id":47190624,"name":"conan","full_name":"conan-io/conan","owner":{"login":"conan-io","id":15212165,"avatar_url":"https://avatars3.githubusercontent.com/u/15212165?v=4","gravatar_id":"","url":"https://api.github.com/users/conan-io","html_url":"https://github.com/conan-io","followers_url":"https://api.github.com/users/conan-io/followers","following_url":"https://api.github.com/users/conan-io/following{/other_user}","gists_url":"https://api.github.com/users/conan-io/gists{/gist_id}","starred_url":"https://api.github.com/users/conan-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conan-io/subscriptions","organizations_url":"https://api.github.com/users/conan-io/orgs","repos_url":"https://api.github.com/users/conan-io/repos","events_url":"https://api.github.com/users/conan-io/events{/privacy}","received_events_url":"https://api.github.com/users/conan-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/conan-io/conan","description":"Conan.io - The open-source C/C++ package manager","fork":false,"url":"https://api.github.com/repos/conan-io/conan","forks_url":"https://api.github.com/repos/conan-io/conan/forks","keys_url":"https://api.github.com/repos/conan-io/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/conan-io/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/conan-io/conan/teams","hooks_url":"https://api.github.com/repos/conan-io/conan/hooks","issue_events_url":"https://api.github.com/repos/conan-io/conan/issues/events{/number}","events_url":"https://api.github.com/repos/conan-io/conan/events","assignees_url":"https://api.github.com/repos/conan-io/conan/assignees{/user}","branches_url":"https://api.github.com/repos/conan-io/conan/branches{/branch}","tags_url":"https://api.github.com/repos/conan-io/conan/tags","blobs_url":"https://api.github.com/repos/conan-io/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/conan-io/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/conan-io/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/conan-io/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/conan-io/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/conan-io/conan/languages","stargazers_url":"https://api.github.com/repos/conan-io/conan/stargazers","contributors_url":"https://api.github.com/repos/conan-io/conan/contributors","subscribers_url":"https://api.github.com/repos/conan-io/conan/subscribers","subscription_url":"https://api.github.com/repos/conan-io/conan/subscription","commits_url":"https://api.github.com/repos/conan-io/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/conan-io/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/conan-io/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/conan-io/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/conan-io/conan/contents/{+path}","compare_url":"https://api.github.com/repos/conan-io/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/conan-io/conan/merges","archive_url":"https://api.github.com/repos/conan-io/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/conan-io/conan/downloads","issues_url":"https://api.github.com/repos/conan-io/conan/issues{/number}","pulls_url":"https://api.github.com/repos/conan-io/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/conan-io/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/conan-io/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/conan-io/conan/labels{/name}","releases_url":"https://api.github.com/repos/conan-io/conan/releases{/id}","deployments_url":"https://api.github.com/repos/conan-io/conan/deployments","created_at":"2015-12-01T13:17:02Z","updated_at":"2017-08-16T01:15:18Z","pushed_at":"2017-08-17T16:07:12Z","git_url":"git://github.com/conan-io/conan.git","ssh_url":"git@github.com:conan-io/conan.git","clone_url":"https://github.com/conan-io/conan.git","svn_url":"https://github.com/conan-io/conan","homepage":"https://conan.io","size":2797,"stargazers_count":1127,"watchers_count":1127,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":159,"mirror_url":null,"open_issues_count":231,"forks":159,"open_issues":231,"watchers":1127,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/conan-io/conan/pulls/1625"},"html":{"href":"https://github.com/conan-io/conan/pull/1625"},"issue":{"href":"https://api.github.com/repos/conan-io/conan/issues/1625"},"comments":{"href":"https://api.github.com/repos/conan-io/conan/issues/1625/comments"},"review_comments":{"href":"https://api.github.com/repos/conan-io/conan/pulls/1625/comments"},"review_comment":{"href":"https://api.github.com/repos/conan-io/conan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/conan-io/conan/pulls/1625/commits"},"statuses":{"href":"https://api.github.com/repos/conan-io/conan/statuses/ee927c3eee5688dee9c62e565a5b78f3e8c063db"}}}}
{"actor":{"display_login":"memsharded"}}