{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab-distro/pulls/comments/141010893","pull_request_review_id":65161189,"id":141010893,"diff_hunk":"@@ -206,6 +213,32 @@\n                 </plugins>\n             </build>\n         </profile>\n+        <profile>\n+            <id>snapshotbuild</id>\n+            <activation>\n+                <property>\n+                    <name>!release</name>\n+                </property>\n+            </activation>\n+            <properties>\n+                <build.number>- local build -</build.number>\n+                <online.repo>https://openhab.jfrog.io/openhab/online-repo-snapshot/${online.repo.version}</online.repo>\n+                <pax.url.suffix>@snapshots</pax.url.suffix>\n+            </properties>\n+        </profile>\n+        <profile>\n+            <id>releasebuild</id>\n+            <activation>\n+                <property>\n+                    <name>release</name>\n+                </property>\n+            </activation>\n+            <properties>\n+                <build.number>- release build -</build.number>","path":"pom.xml","position":66,"original_position":66,"commit_id":"b5e5fa173e5a2736e5dbd6ac8bf172f5625bfc72","original_commit_id":"b5e5fa173e5a2736e5dbd6ac8bf172f5625bfc72","user":{"login":"ThomDietrich","id":2870104,"avatar_url":"https://avatars3.githubusercontent.com/u/2870104?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomDietrich","html_url":"https://github.com/ThomDietrich","followers_url":"https://api.github.com/users/ThomDietrich/followers","following_url":"https://api.github.com/users/ThomDietrich/following{/other_user}","gists_url":"https://api.github.com/users/ThomDietrich/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomDietrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomDietrich/subscriptions","organizations_url":"https://api.github.com/users/ThomDietrich/orgs","repos_url":"https://api.github.com/users/ThomDietrich/repos","events_url":"https://api.github.com/users/ThomDietrich/events{/privacy}","received_events_url":"https://api.github.com/users/ThomDietrich/received_events","type":"User","site_admin":false},"body":"Release Build, correct.\r\n@pfink the reason is simple, openHABian will show the version details on ssh login and the dashes were \"ugly\" while not having any purpose. Currently there is a simple search and replace logic in place:\r\n\r\n![grafik](https://user-images.githubusercontent.com/2870104/30854341-a866b0b2-a2b1-11e7-9852-c98f571e9359.png)\r\n","created_at":"2017-09-26T09:57:34Z","updated_at":"2017-09-26T09:57:35Z","html_url":"https://github.com/openhab/openhab-distro/pull/543#discussion_r141010893","pull_request_url":"https://api.github.com/repos/openhab/openhab-distro/pulls/543","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab-distro/pulls/comments/141010893"},"html":{"href":"https://github.com/openhab/openhab-distro/pull/543#discussion_r141010893"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab-distro/pulls/543"}},"in_reply_to_id":140968956},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab-distro/pulls/543","id":142995722,"html_url":"https://github.com/openhab/openhab-distro/pull/543","diff_url":"https://github.com/openhab/openhab-distro/pull/543.diff","patch_url":"https://github.com/openhab/openhab-distro/pull/543.patch","issue_url":"https://api.github.com/repos/openhab/openhab-distro/issues/543","number":543,"state":"open","locked":false,"title":"Automatically calculate online.repo+pax url suffix+build number depending whether there is a releasebuild or not","user":{"login":"pfink","id":7902693,"avatar_url":"https://avatars1.githubusercontent.com/u/7902693?v=4","gravatar_id":"","url":"https://api.github.com/users/pfink","html_url":"https://github.com/pfink","followers_url":"https://api.github.com/users/pfink/followers","following_url":"https://api.github.com/users/pfink/following{/other_user}","gists_url":"https://api.github.com/users/pfink/gists{/gist_id}","starred_url":"https://api.github.com/users/pfink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfink/subscriptions","organizations_url":"https://api.github.com/users/pfink/orgs","repos_url":"https://api.github.com/users/pfink/repos","events_url":"https://api.github.com/users/pfink/events{/privacy}","received_events_url":"https://api.github.com/users/pfink/received_events","type":"User","site_admin":false},"body":"@kaikreuzer: Unfortunately, for those properties the existing property updating mechanism cannot be used as it just works for (already released) versions. To not have multiple property updating mechanisms, I'd suggest to automatically calculate those properties. \"Release properties\" will be used when providing `-Drelease` while building.\r\n\r\nSigned-off-by: Patrick Fink <mail@pfink.de>","created_at":"2017-09-25T22:06:41Z","updated_at":"2017-09-26T09:57:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cc2e07bce03c26d15492502af290a7c8c788211","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab-distro/pulls/543/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab-distro/pulls/543/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab-distro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab-distro/issues/543/comments","statuses_url":"https://api.github.com/repos/openhab/openhab-distro/statuses/b5e5fa173e5a2736e5dbd6ac8bf172f5625bfc72","head":{"label":"pfink:pr-online-repo-pax","ref":"pr-online-repo-pax","sha":"b5e5fa173e5a2736e5dbd6ac8bf172f5625bfc72","user":{"login":"pfink","id":7902693,"avatar_url":"https://avatars1.githubusercontent.com/u/7902693?v=4","gravatar_id":"","url":"https://api.github.com/users/pfink","html_url":"https://github.com/pfink","followers_url":"https://api.github.com/users/pfink/followers","following_url":"https://api.github.com/users/pfink/following{/other_user}","gists_url":"https://api.github.com/users/pfink/gists{/gist_id}","starred_url":"https://api.github.com/users/pfink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfink/subscriptions","organizations_url":"https://api.github.com/users/pfink/orgs","repos_url":"https://api.github.com/users/pfink/repos","events_url":"https://api.github.com/users/pfink/events{/privacy}","received_events_url":"https://api.github.com/users/pfink/received_events","type":"User","site_admin":false},"repo":{"id":93344477,"name":"openhab-distro","full_name":"pfink/openhab-distro","owner":{"login":"pfink","id":7902693,"avatar_url":"https://avatars1.githubusercontent.com/u/7902693?v=4","gravatar_id":"","url":"https://api.github.com/users/pfink","html_url":"https://github.com/pfink","followers_url":"https://api.github.com/users/pfink/followers","following_url":"https://api.github.com/users/pfink/following{/other_user}","gists_url":"https://api.github.com/users/pfink/gists{/gist_id}","starred_url":"https://api.github.com/users/pfink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfink/subscriptions","organizations_url":"https://api.github.com/users/pfink/orgs","repos_url":"https://api.github.com/users/pfink/repos","events_url":"https://api.github.com/users/pfink/events{/privacy}","received_events_url":"https://api.github.com/users/pfink/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfink/openhab-distro","description":"The binary distribution of openHAB","fork":true,"url":"https://api.github.com/repos/pfink/openhab-distro","forks_url":"https://api.github.com/repos/pfink/openhab-distro/forks","keys_url":"https://api.github.com/repos/pfink/openhab-distro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfink/openhab-distro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfink/openhab-distro/teams","hooks_url":"https://api.github.com/repos/pfink/openhab-distro/hooks","issue_events_url":"https://api.github.com/repos/pfink/openhab-distro/issues/events{/number}","events_url":"https://api.github.com/repos/pfink/openhab-distro/events","assignees_url":"https://api.github.com/repos/pfink/openhab-distro/assignees{/user}","branches_url":"https://api.github.com/repos/pfink/openhab-distro/branches{/branch}","tags_url":"https://api.github.com/repos/pfink/openhab-distro/tags","blobs_url":"https://api.github.com/repos/pfink/openhab-distro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfink/openhab-distro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfink/openhab-distro/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfink/openhab-distro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfink/openhab-distro/statuses/{sha}","languages_url":"https://api.github.com/repos/pfink/openhab-distro/languages","stargazers_url":"https://api.github.com/repos/pfink/openhab-distro/stargazers","contributors_url":"https://api.github.com/repos/pfink/openhab-distro/contributors","subscribers_url":"https://api.github.com/repos/pfink/openhab-distro/subscribers","subscription_url":"https://api.github.com/repos/pfink/openhab-distro/subscription","commits_url":"https://api.github.com/repos/pfink/openhab-distro/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfink/openhab-distro/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfink/openhab-distro/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfink/openhab-distro/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfink/openhab-distro/contents/{+path}","compare_url":"https://api.github.com/repos/pfink/openhab-distro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfink/openhab-distro/merges","archive_url":"https://api.github.com/repos/pfink/openhab-distro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfink/openhab-distro/downloads","issues_url":"https://api.github.com/repos/pfink/openhab-distro/issues{/number}","pulls_url":"https://api.github.com/repos/pfink/openhab-distro/pulls{/number}","milestones_url":"https://api.github.com/repos/pfink/openhab-distro/milestones{/number}","notifications_url":"https://api.github.com/repos/pfink/openhab-distro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfink/openhab-distro/labels{/name}","releases_url":"https://api.github.com/repos/pfink/openhab-distro/releases{/id}","deployments_url":"https://api.github.com/repos/pfink/openhab-distro/deployments","created_at":"2017-06-04T22:11:22Z","updated_at":"2017-06-28T23:56:34Z","pushed_at":"2017-09-25T22:26:20Z","git_url":"git://github.com/pfink/openhab-distro.git","ssh_url":"git@github.com:pfink/openhab-distro.git","clone_url":"https://github.com/pfink/openhab-distro.git","svn_url":"https://github.com/pfink/openhab-distro","homepage":null,"size":1259,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"334f2341a47596374299052ed20546222c7a58e8","user":{"login":"openhab","id":1007353,"avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":48767955,"name":"openhab-distro","full_name":"openhab/openhab-distro","owner":{"login":"openhab","id":1007353,"avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab-distro","description":"The binary distribution of openHAB","fork":false,"url":"https://api.github.com/repos/openhab/openhab-distro","forks_url":"https://api.github.com/repos/openhab/openhab-distro/forks","keys_url":"https://api.github.com/repos/openhab/openhab-distro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab-distro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab-distro/teams","hooks_url":"https://api.github.com/repos/openhab/openhab-distro/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab-distro/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab-distro/events","assignees_url":"https://api.github.com/repos/openhab/openhab-distro/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab-distro/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab-distro/tags","blobs_url":"https://api.github.com/repos/openhab/openhab-distro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab-distro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab-distro/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab-distro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab-distro/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab-distro/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab-distro/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab-distro/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab-distro/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab-distro/subscription","commits_url":"https://api.github.com/repos/openhab/openhab-distro/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab-distro/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab-distro/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab-distro/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab-distro/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab-distro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab-distro/merges","archive_url":"https://api.github.com/repos/openhab/openhab-distro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab-distro/downloads","issues_url":"https://api.github.com/repos/openhab/openhab-distro/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab-distro/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab-distro/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab-distro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab-distro/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab-distro/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab-distro/deployments","created_at":"2015-12-29T21:30:04Z","updated_at":"2017-09-25T06:44:42Z","pushed_at":"2017-09-26T09:43:58Z","git_url":"git://github.com/openhab/openhab-distro.git","ssh_url":"git@github.com:openhab/openhab-distro.git","clone_url":"https://github.com/openhab/openhab-distro.git","svn_url":"https://github.com/openhab/openhab-distro","homepage":null,"size":1259,"stargazers_count":341,"watchers_count":341,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"open_issues_count":37,"forks":190,"open_issues":37,"watchers":341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab-distro/pulls/543"},"html":{"href":"https://github.com/openhab/openhab-distro/pull/543"},"issue":{"href":"https://api.github.com/repos/openhab/openhab-distro/issues/543"},"comments":{"href":"https://api.github.com/repos/openhab/openhab-distro/issues/543/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab-distro/pulls/543/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab-distro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab-distro/pulls/543/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab-distro/statuses/b5e5fa173e5a2736e5dbd6ac8bf172f5625bfc72"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ThomDietrich"}}