{"action":"created","issue":{"url":"https://api.github.com/repos/jflex-de/jflex/issues/244","repository_url":"https://api.github.com/repos/jflex-de/jflex","labels_url":"https://api.github.com/repos/jflex-de/jflex/issues/244/labels{/name}","comments_url":"https://api.github.com/repos/jflex-de/jflex/issues/244/comments","events_url":"https://api.github.com/repos/jflex-de/jflex/issues/244/events","html_url":"https://github.com/jflex-de/jflex/pull/244","id":271618603,"number":244,"title":"Let Travis fail if a test fail","user":{"login":"regisd","id":838356,"avatar_url":"https://avatars1.githubusercontent.com/u/838356?v=4","gravatar_id":"","url":"https://api.github.com/users/regisd","html_url":"https://github.com/regisd","followers_url":"https://api.github.com/users/regisd/followers","following_url":"https://api.github.com/users/regisd/following{/other_user}","gists_url":"https://api.github.com/users/regisd/gists{/gist_id}","starred_url":"https://api.github.com/users/regisd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regisd/subscriptions","organizations_url":"https://api.github.com/users/regisd/orgs","repos_url":"https://api.github.com/users/regisd/repos","events_url":"https://api.github.com/users/regisd/events{/privacy}","received_events_url":"https://api.github.com/users/regisd/received_events","type":"User","site_admin":false},"labels":[{"id":177259978,"url":"https://api.github.com/repos/jflex-de/jflex/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":{"login":"regisd","id":838356,"avatar_url":"https://avatars1.githubusercontent.com/u/838356?v=4","gravatar_id":"","url":"https://api.github.com/users/regisd","html_url":"https://github.com/regisd","followers_url":"https://api.github.com/users/regisd/followers","following_url":"https://api.github.com/users/regisd/following{/other_user}","gists_url":"https://api.github.com/users/regisd/gists{/gist_id}","starred_url":"https://api.github.com/users/regisd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regisd/subscriptions","organizations_url":"https://api.github.com/users/regisd/orgs","repos_url":"https://api.github.com/users/regisd/repos","events_url":"https://api.github.com/users/regisd/events{/privacy}","received_events_url":"https://api.github.com/users/regisd/received_events","type":"User","site_admin":false},"assignees":[{"login":"regisd","id":838356,"avatar_url":"https://avatars1.githubusercontent.com/u/838356?v=4","gravatar_id":"","url":"https://api.github.com/users/regisd","html_url":"https://github.com/regisd","followers_url":"https://api.github.com/users/regisd/followers","following_url":"https://api.github.com/users/regisd/following{/other_user}","gists_url":"https://api.github.com/users/regisd/gists{/gist_id}","starred_url":"https://api.github.com/users/regisd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regisd/subscriptions","organizations_url":"https://api.github.com/users/regisd/orgs","repos_url":"https://api.github.com/users/regisd/repos","events_url":"https://api.github.com/users/regisd/events{/privacy}","received_events_url":"https://api.github.com/users/regisd/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/jflex-de/jflex/milestones/10","html_url":"https://github.com/jflex-de/jflex/milestone/10","labels_url":"https://api.github.com/repos/jflex-de/jflex/milestones/10/labels","id":1035185,"number":10,"title":"1.7.0","description":"collecting issues for the 1.7.0 release of JFlex","creator":{"login":"lsf37","id":5506585,"avatar_url":"https://avatars0.githubusercontent.com/u/5506585?v=4","gravatar_id":"","url":"https://api.github.com/users/lsf37","html_url":"https://github.com/lsf37","followers_url":"https://api.github.com/users/lsf37/followers","following_url":"https://api.github.com/users/lsf37/following{/other_user}","gists_url":"https://api.github.com/users/lsf37/gists{/gist_id}","starred_url":"https://api.github.com/users/lsf37/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsf37/subscriptions","organizations_url":"https://api.github.com/users/lsf37/orgs","repos_url":"https://api.github.com/users/lsf37/repos","events_url":"https://api.github.com/users/lsf37/events{/privacy}","received_events_url":"https://api.github.com/users/lsf37/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":17,"state":"open","created_at":"2015-03-23T21:25:56Z","updated_at":"2017-11-06T21:03:17Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2017-11-06T21:00:17Z","updated_at":"2017-11-06T21:21:43Z","closed_at":"2017-11-06T21:02:59Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jflex-de/jflex/pulls/244","html_url":"https://github.com/jflex-de/jflex/pull/244","diff_url":"https://github.com/jflex-de/jflex/pull/244.diff","patch_url":"https://github.com/jflex-de/jflex/pull/244.patch"},"body":"`set -e`: Exit immediately if a command exits with a non-zero status.\r\n\r\nHowever\r\n> the shell does not exit if the command that fails is part of the command list immediately following a while or until keyword, part of the test in an if statement, **part of any command executed in a && or ||** list except the command following the final && or ||, any command in a pipeline but the last, or if the command’s return status is being inverted with !. \r\n\r\nhttps://www.gnu.org/software/bash/manual/html_node/The-Set-Builtin.html\r\n\r\nHence ending the execution of the test with `&& cd ..` prevents the exit of the script in case of failure.\r\n\r\nChange to parent directory on its own line.\r\n\r\nFix #242 "},"comment":{"url":"https://api.github.com/repos/jflex-de/jflex/issues/comments/342290936","html_url":"https://github.com/jflex-de/jflex/pull/244#issuecomment-342290936","issue_url":"https://api.github.com/repos/jflex-de/jflex/issues/244","id":342290936,"user":{"login":"lsf37","id":5506585,"avatar_url":"https://avatars0.githubusercontent.com/u/5506585?v=4","gravatar_id":"","url":"https://api.github.com/users/lsf37","html_url":"https://github.com/lsf37","followers_url":"https://api.github.com/users/lsf37/followers","following_url":"https://api.github.com/users/lsf37/following{/other_user}","gists_url":"https://api.github.com/users/lsf37/gists{/gist_id}","starred_url":"https://api.github.com/users/lsf37/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsf37/subscriptions","organizations_url":"https://api.github.com/users/lsf37/orgs","repos_url":"https://api.github.com/users/lsf37/repos","events_url":"https://api.github.com/users/lsf37/events{/privacy}","received_events_url":"https://api.github.com/users/lsf37/received_events","type":"User","site_admin":false},"created_at":"2017-11-06T21:21:43Z","updated_at":"2017-11-06T21:21:43Z","author_association":"OWNER","body":"Following on from the other discussion, the problem is that the `&&` chain propagates the exit code correctly, but `set -e` ignores it. That means though, that this change only observes failure in the last `make` in the chain on each line. If the directory is wrong (as it was for the ant build), or if something before in the `make clean` goes wrong, we won't see it showing up in Travis. \r\n\r\nIf I'm reading `set -e` right, replacing `&&` with just `;` should do the trick, because it's not a `&&` chain any more. I.e. my whole attempt of using `&&` for propagating failure was just wrong unless you use it with the `|| exit 1` pattern. I'll experiment with `;` and see if that is a bit nicer and catches all of them."}}
{"actor":{"display_login":"lsf37"}}