{"action":"created","issue":{"url":"https://api.github.com/repos/byu-oit/ios-byuSuite/issues/292","repository_url":"https://api.github.com/repos/byu-oit/ios-byuSuite","labels_url":"https://api.github.com/repos/byu-oit/ios-byuSuite/issues/292/labels{/name}","comments_url":"https://api.github.com/repos/byu-oit/ios-byuSuite/issues/292/comments","events_url":"https://api.github.com/repos/byu-oit/ios-byuSuite/issues/292/events","html_url":"https://github.com/byu-oit/ios-byuSuite/pull/292","id":281543063,"number":292,"title":"hotfix/parking -> dev","user":{"login":"ecbrady","id":12305705,"avatar_url":"https://avatars3.githubusercontent.com/u/12305705?v=4","gravatar_id":"","url":"https://api.github.com/users/ecbrady","html_url":"https://github.com/ecbrady","followers_url":"https://api.github.com/users/ecbrady/followers","following_url":"https://api.github.com/users/ecbrady/following{/other_user}","gists_url":"https://api.github.com/users/ecbrady/gists{/gist_id}","starred_url":"https://api.github.com/users/ecbrady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecbrady/subscriptions","organizations_url":"https://api.github.com/users/ecbrady/orgs","repos_url":"https://api.github.com/users/ecbrady/repos","events_url":"https://api.github.com/users/ecbrady/events{/privacy}","received_events_url":"https://api.github.com/users/ecbrady/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2017-12-12T21:28:02Z","updated_at":"2017-12-21T20:14:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/byu-oit/ios-byuSuite/pulls/292","html_url":"https://github.com/byu-oit/ios-byuSuite/pull/292","diff_url":"https://github.com/byu-oit/ios-byuSuite/pull/292.diff","patch_url":"https://github.com/byu-oit/ios-byuSuite/pull/292.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/byu-oit/ios-byusuite/292)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/byu-oit/ios-byuSuite/issues/comments/353447149","html_url":"https://github.com/byu-oit/ios-byuSuite/pull/292#issuecomment-353447149","issue_url":"https://api.github.com/repos/byu-oit/ios-byuSuite/issues/292","id":353447149,"user":{"login":"ecbrady","id":12305705,"avatar_url":"https://avatars3.githubusercontent.com/u/12305705?v=4","gravatar_id":"","url":"https://api.github.com/users/ecbrady","html_url":"https://github.com/ecbrady","followers_url":"https://api.github.com/users/ecbrady/followers","following_url":"https://api.github.com/users/ecbrady/following{/other_user}","gists_url":"https://api.github.com/users/ecbrady/gists{/gist_id}","starred_url":"https://api.github.com/users/ecbrady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecbrady/subscriptions","organizations_url":"https://api.github.com/users/ecbrady/orgs","repos_url":"https://api.github.com/users/ecbrady/repos","events_url":"https://api.github.com/users/ecbrady/events{/privacy}","received_events_url":"https://api.github.com/users/ecbrady/received_events","type":"User","site_admin":false},"created_at":"2017-12-21T20:14:14Z","updated_at":"2017-12-21T20:14:14Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 78 of 95 files reviewed at latest revision, 100 unresolved discussions.\n\n---\n\n*[byuSuite/Apps/Parking/controller/EditVehicleViewController.swift, line 9 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0QHFTplGASaD7cDzaU:-L0uMM-pdfM2TAuHPhIr:b-896fix) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/EditVehicleViewController.swift#L9)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nWe might be able to replace this with an unwind segue\n</blockquote></details>\n\nDone.\n\n---\n\n*[byuSuite/Apps/Parking/controller/EditVehicleViewController.swift, line 14 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0QHw8OogqhZYiN7RaW:-L0uK-IpJMzFhRFldjwj:bb77ufg) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/EditVehicleViewController.swift#L14)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nIs this a form sheet?\n</blockquote></details>\n\nYes.\n\n---\n\n*[byuSuite/Apps/Parking/controller/EditVehicleViewController.swift, line 33 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0QHz3eYAibcQ399jIQ:-L0uMS-NYcRcWZXy8FA1:b-f0942k) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/EditVehicleViewController.swift#L33)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nMake them private\n</blockquote></details>\n\nOops haha.\n\n---\n\n*[byuSuite/Apps/Parking/controller/EditVehicleViewController.swift, line 42 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0QRMQuvMzgzHcQxptJ:-L0uMr6bRrdigdyPfLz4:b-896fix) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/EditVehicleViewController.swift#L42)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nStoryboard?\n</blockquote></details>\n\nDone.\n\n---\n\n*[byuSuite/Apps/Parking/controller/EditVehicleViewController.swift, line 47 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0QSpTI6_Os3OZNRDju:-L0uMwQ3nfG4w3v2uW5q:b-896fix) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/EditVehicleViewController.swift#L47)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nStoryboard\n</blockquote></details>\n\nDone.\n\n---\n\n*[byuSuite/Apps/Parking/controller/EditVehicleViewController.swift, line 57 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0QT4FrTLrQqwgqJzti:-L0uNS_V3FOs1zF44ipC:b-896fix) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/EditVehicleViewController.swift#L57)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\n`let index = codes.index(where: { $0.codeId == self.vehicle.stateCode?.codeId }) ?? 0`\n</blockquote></details>\n\nDone.\n\n---\n\n*[byuSuite/Apps/Parking/controller/EditVehicleViewController.swift, line 76 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0QZMeqDOmm1OABbdUH:-L0uNtXjRW6jgOI3ZHjk:b-896fix) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/EditVehicleViewController.swift#L76)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nDid we make a ByuModalViewController that does this for us?\n</blockquote></details>\n\nDone.\n\n---\n\n*[byuSuite/Apps/Parking/controller/EditVehicleViewController.swift, line 82 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0QZSW_fhwBrTrhbs8-:-L0uNzcOXPIGEKW90-kl:b1qaw8y) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/EditVehicleViewController.swift#L82)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nIs this default? If you remove it, does it not work?\n</blockquote></details>\n\nIt won't build without it\n\n---\n\n*[byuSuite/Apps/Parking/controller/MyVehiclesViewController.swift, line 127 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0MXcdxLLQ4qzaiRluZ:-L0uc9LJ9EHagfvOsima:b-896fix) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/MyVehiclesViewController.swift#L127)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nYou know what? I think you were right... I still think it was good to flip them, but let's change it to `error == nil`. Then you can make `callbackVehicle` an `_`\n</blockquote></details>\n\nDone.\n\n---\n\n*[byuSuite/Apps/Parking/controller/MyVehiclesViewController.swift, line 197 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0MYz4pC-2-LanCyV6x:-L0ucEdXKvUh-HhReOCu:b-ybe5gt) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/MyVehiclesViewController.swift#L197)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nWhy are we create this wrapper? Were we having issues if multiple pop ups were displaying at once?\n</blockquote></details>\n\nI'm not sure. Objective-c was doing that so I just duplicated it.\n\n---\n\n*[byuSuite/Apps/Parking/controller/MyVehiclesViewController.swift, line 124 at r8](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0RQBRROa__cgTUPpce:-L0uc3R4TwCgCrwzytkd:b-896fix) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/6212d4af043e454da32fc937c71fe503dbae6481/byuSuite/Apps/Parking/controller/MyVehiclesViewController.swift#L124)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nKeep the success on top, but change `callbackVehicle` to `_` and check `error == nil`\n</blockquote></details>\n\nDone.\n\n---\n\n*[byuSuite/Apps/Parking/controller/PrivilegesViewController.swift, line 13 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0PaJh1UJ_nVmzvjZvA:-L0ucjCA-MW21Iq8T2W3:b-896fix) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/PrivilegesViewController.swift#L13)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nLet's rename this ParkingLotsViewController\n</blockquote></details>\n\nDone.\n\n---\n\n*[byuSuite/Apps/Parking/controller/PrivilegesViewController.swift, line 28 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0Pai9FbMixgJrht9zF:-L0ud21wxSeWVLEHxeid:b-9frikv) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/PrivilegesViewController.swift#L28)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nLet's call this clientCallbackCounter, like we did in the VehiclesVC\n</blockquote></details>\n\nActually it was never used.\n\n---\n\n*[byuSuite/Apps/Parking/controller/PrivilegesViewController.swift, line 42 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0Pbn1_TJsxfsJYHznM:-L0ueM32xGp6FIwwyxJf:b-896fix) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/PrivilegesViewController.swift#L42)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nCan we not do this in the storyboard (disabled) and just enable it here?\n</blockquote></details>\n\nDone.\n\n---\n\n*[byuSuite/Apps/Parking/controller/PrivilegesViewController.swift, line 76 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0PgRtIli8x6rXG4YBq:-L0uej1xwKjqZsIc9T4q:b-ygwjyk) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/PrivilegesViewController.swift#L76)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nWhat will this even be showing? I didn't think we had annotations on this map...\n</blockquote></details>\n\nSo I tried removing this method and it turns out that every time you add an overlay, a pin is added as well. Everything we're doing here is to hide those pins.\n\n---\n\n*[byuSuite/Apps/Parking/controller/PrivilegesViewController.swift, line 87 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0Ph0Y3mcZ3CpwYcKZU:-L0ufAjhoWTl7UF44Ddi:b-896fix) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/PrivilegesViewController.swift#L87)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nDefault to \"Unknown\"\n</blockquote></details>\n\nDone.\n\n---\n\n*[byuSuite/Apps/Parking/controller/PrivilegesViewController.swift, line 89 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0Ph6gd8vqkK2k0lN8h:-L0ufH-tG9JwULSvXZOz:b-q8o0nj) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/PrivilegesViewController.swift#L89)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nHave we tested this to make sure it fits/looks good? Also, default to Unknown\n</blockquote></details>\n\nYes I believe so.\n\n---\n\n*[byuSuite/Apps/Parking/controller/PrivilegesViewController.swift, line 97 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0PhHoCiL8orjK0wejd:-L0ufS-xpG7c_2U_SEHe:brhtak9) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/PrivilegesViewController.swift#L97)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nUse map\n</blockquote></details>\n\nInstead of zone? We're displaying parking zones though.\n\n---\n\n*[byuSuite/Apps/Parking/controller/PrivilegesViewController.swift, line 106 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0PcfHVC1HbFov7BDQX:-L0ufXIyR9S1CTZjPaDf:b-896fix) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/PrivilegesViewController.swift#L106)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nAdd space after `:`\n</blockquote></details>\n\nDone.\n\n---\n\n*[byuSuite/Apps/Parking/controller/PrivilegesViewController.swift, line 108 at r7](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292#-L0Pc9174QWcdWtkAGlE:-L0uh5xUQOciTvA9KU8P:b-b828o) ([raw file](https://github.com/byu-oit/ios-byusuite/blob/653a3a3af20a44ed1450dd74ef6e60fb9b6178cf/byuSuite/Apps/Parking/controller/PrivilegesViewController.swift#L108)):*\n<details><summary><i>Previously, romrell4 (Eric Romrell) wrote…</i></summary><blockquote>\n\nDo a `first(where:)` instead of `filter().first`...\nActually I think this function can look something like this now:\n```swift\nprivate func getZone(privId: String?, from zones: [ParkingZone]) -> ParkingZone? {\n  guard let privId = privId, let zone = zones.first(where: { $0.letter == privId || $0.letter == \"B,C\" && HOUSING_PRIVS.contains(privId) } ) {\n    return zone\n  }\n  return zones.first(where: { $0.name == \"Visitor Parking\" } )\n}\n```\n</blockquote></details>\n\nDo you mean if let rather than guard let? The guard let needs an else.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/byu-oit/ios-byusuite/292)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"ecbrady"}}