{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/19805","repository_url":"https://api.github.com/repos/dotnet/roslyn","labels_url":"https://api.github.com/repos/dotnet/roslyn/issues/19805/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/19805/comments","events_url":"https://api.github.com/repos/dotnet/roslyn/issues/19805/events","html_url":"https://github.com/dotnet/roslyn/pull/19805","id":231680278,"number":19805,"title":"InternalsVisibleToCompletionProvider","user":{"login":"MaStr11","id":24472128,"avatar_url":"https://avatars2.githubusercontent.com/u/24472128?v=3","gravatar_id":"","url":"https://api.github.com/users/MaStr11","html_url":"https://github.com/MaStr11","followers_url":"https://api.github.com/users/MaStr11/followers","following_url":"https://api.github.com/users/MaStr11/following{/other_user}","gists_url":"https://api.github.com/users/MaStr11/gists{/gist_id}","starred_url":"https://api.github.com/users/MaStr11/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaStr11/subscriptions","organizations_url":"https://api.github.com/users/MaStr11/orgs","repos_url":"https://api.github.com/users/MaStr11/repos","events_url":"https://api.github.com/users/MaStr11/events{/privacy}","received_events_url":"https://api.github.com/users/MaStr11/received_events","type":"User","site_admin":false},"labels":[{"id":166377917,"url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-IDE","name":"Area-IDE","color":"5319e7","default":false},{"id":197452922,"url":"https://api.github.com/repos/dotnet/roslyn/labels/cla-already-signed","name":"cla-already-signed","color":"FFFFFF","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2017-05-26T16:52:00Z","updated_at":"2017-06-12T19:33:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/19805","html_url":"https://github.com/dotnet/roslyn/pull/19805","diff_url":"https://github.com/dotnet/roslyn/pull/19805.diff","patch_url":"https://github.com/dotnet/roslyn/pull/19805.patch"},"body":"**Customer scenario**\r\n\r\nCustomer request #18889.\r\n\r\n**Bugs this fixes:**\r\n\r\n#18889 Productivity: IntelliSense support for InternalsVisibleToAttribute \r\n\r\n**Workarounds, if any**\r\n\r\nNew feature.\r\n\r\n**Risk**\r\n\r\nNew *CompletionProvider*. Might break IntelliSense.\r\n\r\n**Performance impact**\r\n\r\nMemory pressure and IDE hangs caused by code completion might be possible.\r\n\r\n**Is this a regression from a previous update?**\r\n\r\nNo.\r\n\r\n**Root cause analysis:**\r\n\r\nNew Feature.\r\n\r\n**How was the bug found?**\r\n\r\nFeature request.\r\n\r\n**PR description**\r\n\r\n![internalsvisibletocompletionprovider](https://cloud.githubusercontent.com/assets/24472128/26581453/d198243e-453c-11e7-9361-bb7f95413dd7.gif)\r\n\r\n**30.5.07 Update**\r\n\r\nThe PR is now ready for review and is feature complete.\r\n\r\nWhat is included?\r\n\r\n* The C# version of the *CompletionProvider*\r\n* The option to live test the current implementation by starting *VisualStudioSetup*.\r\n* Support for public key of strong named assemblies\r\n* A few unit tests.\r\n\r\nWhat is missing/broken?\r\n\r\n* A VisualBasic version is missing\r\n\r\nBeside these points there are some more fundamental questions that should be answered before I proceed: \r\n\r\n* Is a Visual Basic version mandatory? Should there be at least an abstract base class for a future VB implementation?\r\n* Are there any major pieces missing from the current solution?\r\n* How far should the testing of the attribute go? Currently I stopped at syntax level. Should this be extended to SemanticModel.GetTypeInfo() to test whether the attribute is of type *System.Runtime.CompilerServices.InternalsVisibleToAttribute*\r\n* What is the correct way to get the assembly name (Project.AssemblyName or Project.Name)?\r\n* How to detect valid project types?\r\n* Is *CompletionItem.Create* the right way to create the completion entry or should I take *SymbolCompletionItem.CreateWithNameAndKind*?\r\n* The unit test needs a workspace with a solution with more than one project. Is the way I added the project correct or are there better ways to do this?\r\n* Is it okay to trigger the completion list when a double quote is inserted?\r\n\r\nPlease give me some directions on how to proceed (or just close the PR if this is likely never considered to be included in Roslyn)."},"comment":{"url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/307895716","html_url":"https://github.com/dotnet/roslyn/pull/19805#issuecomment-307895716","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/19805","id":307895716,"user":{"login":"CyrusNajmabadi","id":4564579,"avatar_url":"https://avatars0.githubusercontent.com/u/4564579?v=3","gravatar_id":"","url":"https://api.github.com/users/CyrusNajmabadi","html_url":"https://github.com/CyrusNajmabadi","followers_url":"https://api.github.com/users/CyrusNajmabadi/followers","following_url":"https://api.github.com/users/CyrusNajmabadi/following{/other_user}","gists_url":"https://api.github.com/users/CyrusNajmabadi/gists{/gist_id}","starred_url":"https://api.github.com/users/CyrusNajmabadi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CyrusNajmabadi/subscriptions","organizations_url":"https://api.github.com/users/CyrusNajmabadi/orgs","repos_url":"https://api.github.com/users/CyrusNajmabadi/repos","events_url":"https://api.github.com/users/CyrusNajmabadi/events{/privacy}","received_events_url":"https://api.github.com/users/CyrusNajmabadi/received_events","type":"User","site_admin":false},"created_at":"2017-06-12T19:33:01Z","updated_at":"2017-06-12T19:33:01Z","body":"> Use VirtualizedStrongNameProvider (as in the old tests) failed because the class is in an assembly that is not referenced by EditorServicesTest2\r\n\r\nI would be fine with this.  I think it's find for EditorServicesTest2 to have a reference to TestUtilities.Desktop.\r\n\r\nThanks for all your hard work here!"}}
{"actor":{"display_login":"CyrusNajmabadi"}}