{"action":"created","comment":{"url":"https://api.github.com/repos/dojo/shim/pulls/comments/104739587","pull_request_review_id":25589426,"id":104739587,"diff_hunk":"@@ -35,17 +85,62 @@ to the key/value pair. This allows for the garbage collector to remove pairs.\n \n Look at [Map](docs/Map.md) for more information on how to use WeakMap.\n \n+### Iterators\n+\n+The `@dojo/shim/iterator` module is an implementation of the [ES2015 Iterator specification](http://www.ecma-international.org/ecma-262/6.0/#sec-iteration).\n+\n+### Math\n+\n+The [`@dojo/shim/math`](docs/math.md) module provides implementations for many math methods.\n+\n+### Number\n \n-## How do I use this package?\n+The `dojo/shim/number` module provides implementations for several `Number` methods.\n \n-TODO: Add appropriate usage and instruction guidelines\n+* `isNaN`\n+* `isFinite`\n+* `isInteger`\n+* `isSafeInteger`\n+\n+### Object\n+\n+The `dojo/shim/object` provides implementations of `Object` methods.\n+\n+* is\n+* getOwnPropertySumbols\n+* getOwnPropertyNames\n+* getOwnPropertyDescriptor\n+* values\n+* entires\n+\n+### Observables\n+\n+The [`@dojo/shim/Observable`](docs/Observable.md) class is an implementation of the proposed [Observable specification](https://tc39.github.io/proposal-observable/).  Observables are further extended in [`@dojo/core/Observable`](https://github.com/dojo/core/blob/master/src/Observable.ts).\n+\n+### Promises\n+\n+[`@dojo/shim/Promise`](docs/Promise.md) is an implementation of the [ES2015 Promise specification](http://www.ecma-international.org/ecma-262/6.0/#sec-promise-objects).\n+\n+### String\n+\n+The [`@dojo/shim/string`](docs/string.md) module contains `String` methods.\n+\n+### Symbols\n+\n+`@dojo/shim/Symbol` provides an implementation of the [ES2015 Symbol specification](http://www.ecma-international.org/ecma-262/6.0/#sec-symbol-objects) for browsers that do not natively support `Symbol`.","path":"README.md","position":116,"original_position":116,"commit_id":"d2a2b6fcfcd0d4926bca6eee4acb93c262489d34","original_commit_id":"d2a2b6fcfcd0d4926bca6eee4acb93c262489d34","user":{"login":"dylans","id":97291,"avatar_url":"https://avatars2.githubusercontent.com/u/97291?v=3","gravatar_id":"","url":"https://api.github.com/users/dylans","html_url":"https://github.com/dylans","followers_url":"https://api.github.com/users/dylans/followers","following_url":"https://api.github.com/users/dylans/following{/other_user}","gists_url":"https://api.github.com/users/dylans/gists{/gist_id}","starred_url":"https://api.github.com/users/dylans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylans/subscriptions","organizations_url":"https://api.github.com/users/dylans/orgs","repos_url":"https://api.github.com/users/dylans/repos","events_url":"https://api.github.com/users/dylans/events{/privacy}","received_events_url":"https://api.github.com/users/dylans/received_events","type":"User","site_admin":false},"body":"just browsers, or JS environments? (Not that I know of a non-browser JS engine we support that doesn't support Symbols), just don't think the shim is browser specific.","created_at":"2017-03-07T18:19:35Z","updated_at":"2017-03-07T18:29:14Z","html_url":"https://github.com/dojo/shim/pull/79#discussion_r104739587","pull_request_url":"https://api.github.com/repos/dojo/shim/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/dojo/shim/pulls/comments/104739587"},"html":{"href":"https://github.com/dojo/shim/pull/79#discussion_r104739587"},"pull_request":{"href":"https://api.github.com/repos/dojo/shim/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/dojo/shim/pulls/79","id":109501241,"html_url":"https://github.com/dojo/shim/pull/79","diff_url":"https://github.com/dojo/shim/pull/79.diff","patch_url":"https://github.com/dojo/shim/pull/79.patch","issue_url":"https://api.github.com/repos/dojo/shim/issues/79","number":79,"state":"open","locked":false,"title":"Updating README, meta #140","user":{"login":"rorticus","id":2008858,"avatar_url":"https://avatars1.githubusercontent.com/u/2008858?v=3","gravatar_id":"","url":"https://api.github.com/users/rorticus","html_url":"https://github.com/rorticus","followers_url":"https://api.github.com/users/rorticus/followers","following_url":"https://api.github.com/users/rorticus/following{/other_user}","gists_url":"https://api.github.com/users/rorticus/gists{/gist_id}","starred_url":"https://api.github.com/users/rorticus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rorticus/subscriptions","organizations_url":"https://api.github.com/users/rorticus/orgs","repos_url":"https://api.github.com/users/rorticus/repos","events_url":"https://api.github.com/users/rorticus/events{/privacy}","received_events_url":"https://api.github.com/users/rorticus/received_events","type":"User","site_admin":false},"body":"**Type:** feature\r\n\r\nThe following has been addressed in the PR:\r\n\r\n* [x] There is a related issue\r\n* [ ] All code matches the [style guide](https://github.com/dojo/meta/blob/master/STYLE.md)\r\n* [ ] Unit or Functional tests are included in the PR\r\n\r\n<!--\r\nOur bots should ensure:\r\n\r\n* [ ] All contributors have signed a CLA\r\n* [ ] The PR passes CI testing\r\n* [ ] Code coverage is maintained\r\n* [ ] The PR has been reviewed and approved\r\n-->\r\n\r\n**Description:**\r\n\r\nUpdated README!\r\n\r\nResolves: https://github.com/dojo/meta/issues/140\r\n","created_at":"2017-03-07T15:18:39Z","updated_at":"2017-03-07T18:29:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a54cf0669a1412298e734cb68719608974b4ecad","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dojo/shim/pulls/79/commits","review_comments_url":"https://api.github.com/repos/dojo/shim/pulls/79/comments","review_comment_url":"https://api.github.com/repos/dojo/shim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/shim/issues/79/comments","statuses_url":"https://api.github.com/repos/dojo/shim/statuses/d2a2b6fcfcd0d4926bca6eee4acb93c262489d34","head":{"label":"rorticus:meta-140","ref":"meta-140","sha":"d2a2b6fcfcd0d4926bca6eee4acb93c262489d34","user":{"login":"rorticus","id":2008858,"avatar_url":"https://avatars1.githubusercontent.com/u/2008858?v=3","gravatar_id":"","url":"https://api.github.com/users/rorticus","html_url":"https://github.com/rorticus","followers_url":"https://api.github.com/users/rorticus/followers","following_url":"https://api.github.com/users/rorticus/following{/other_user}","gists_url":"https://api.github.com/users/rorticus/gists{/gist_id}","starred_url":"https://api.github.com/users/rorticus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rorticus/subscriptions","organizations_url":"https://api.github.com/users/rorticus/orgs","repos_url":"https://api.github.com/users/rorticus/repos","events_url":"https://api.github.com/users/rorticus/events{/privacy}","received_events_url":"https://api.github.com/users/rorticus/received_events","type":"User","site_admin":false},"repo":{"id":70271159,"name":"shim","full_name":"rorticus/shim","owner":{"login":"rorticus","id":2008858,"avatar_url":"https://avatars1.githubusercontent.com/u/2008858?v=3","gravatar_id":"","url":"https://api.github.com/users/rorticus","html_url":"https://github.com/rorticus","followers_url":"https://api.github.com/users/rorticus/followers","following_url":"https://api.github.com/users/rorticus/following{/other_user}","gists_url":"https://api.github.com/users/rorticus/gists{/gist_id}","starred_url":"https://api.github.com/users/rorticus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rorticus/subscriptions","organizations_url":"https://api.github.com/users/rorticus/orgs","repos_url":"https://api.github.com/users/rorticus/repos","events_url":"https://api.github.com/users/rorticus/events{/privacy}","received_events_url":"https://api.github.com/users/rorticus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rorticus/shim","description":":rocket: Modules that provide modular fills of ES6+ functionality in Dojo 2.","fork":true,"url":"https://api.github.com/repos/rorticus/shim","forks_url":"https://api.github.com/repos/rorticus/shim/forks","keys_url":"https://api.github.com/repos/rorticus/shim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rorticus/shim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rorticus/shim/teams","hooks_url":"https://api.github.com/repos/rorticus/shim/hooks","issue_events_url":"https://api.github.com/repos/rorticus/shim/issues/events{/number}","events_url":"https://api.github.com/repos/rorticus/shim/events","assignees_url":"https://api.github.com/repos/rorticus/shim/assignees{/user}","branches_url":"https://api.github.com/repos/rorticus/shim/branches{/branch}","tags_url":"https://api.github.com/repos/rorticus/shim/tags","blobs_url":"https://api.github.com/repos/rorticus/shim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rorticus/shim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rorticus/shim/git/refs{/sha}","trees_url":"https://api.github.com/repos/rorticus/shim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rorticus/shim/statuses/{sha}","languages_url":"https://api.github.com/repos/rorticus/shim/languages","stargazers_url":"https://api.github.com/repos/rorticus/shim/stargazers","contributors_url":"https://api.github.com/repos/rorticus/shim/contributors","subscribers_url":"https://api.github.com/repos/rorticus/shim/subscribers","subscription_url":"https://api.github.com/repos/rorticus/shim/subscription","commits_url":"https://api.github.com/repos/rorticus/shim/commits{/sha}","git_commits_url":"https://api.github.com/repos/rorticus/shim/git/commits{/sha}","comments_url":"https://api.github.com/repos/rorticus/shim/comments{/number}","issue_comment_url":"https://api.github.com/repos/rorticus/shim/issues/comments{/number}","contents_url":"https://api.github.com/repos/rorticus/shim/contents/{+path}","compare_url":"https://api.github.com/repos/rorticus/shim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rorticus/shim/merges","archive_url":"https://api.github.com/repos/rorticus/shim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rorticus/shim/downloads","issues_url":"https://api.github.com/repos/rorticus/shim/issues{/number}","pulls_url":"https://api.github.com/repos/rorticus/shim/pulls{/number}","milestones_url":"https://api.github.com/repos/rorticus/shim/milestones{/number}","notifications_url":"https://api.github.com/repos/rorticus/shim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rorticus/shim/labels{/name}","releases_url":"https://api.github.com/repos/rorticus/shim/releases{/id}","deployments_url":"https://api.github.com/repos/rorticus/shim/deployments","created_at":"2016-10-07T18:10:08Z","updated_at":"2016-10-07T18:10:11Z","pushed_at":"2017-03-07T15:17:38Z","git_url":"git://github.com/rorticus/shim.git","ssh_url":"git@github.com:rorticus/shim.git","clone_url":"https://github.com/rorticus/shim.git","svn_url":"https://github.com/rorticus/shim","homepage":"","size":706,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"ded33c45ab878c96066d9532f753d7838d0f5b0c","user":{"login":"dojo","id":86896,"avatar_url":"https://avatars1.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":61533876,"name":"shim","full_name":"dojo/shim","owner":{"login":"dojo","id":86896,"avatar_url":"https://avatars1.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/shim","description":":rocket: Modules that provide modular fills of ES6+ functionality in Dojo 2.","fork":false,"url":"https://api.github.com/repos/dojo/shim","forks_url":"https://api.github.com/repos/dojo/shim/forks","keys_url":"https://api.github.com/repos/dojo/shim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/shim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/shim/teams","hooks_url":"https://api.github.com/repos/dojo/shim/hooks","issue_events_url":"https://api.github.com/repos/dojo/shim/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/shim/events","assignees_url":"https://api.github.com/repos/dojo/shim/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/shim/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/shim/tags","blobs_url":"https://api.github.com/repos/dojo/shim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/shim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/shim/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/shim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/shim/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/shim/languages","stargazers_url":"https://api.github.com/repos/dojo/shim/stargazers","contributors_url":"https://api.github.com/repos/dojo/shim/contributors","subscribers_url":"https://api.github.com/repos/dojo/shim/subscribers","subscription_url":"https://api.github.com/repos/dojo/shim/subscription","commits_url":"https://api.github.com/repos/dojo/shim/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/shim/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/shim/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/shim/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/shim/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/shim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/shim/merges","archive_url":"https://api.github.com/repos/dojo/shim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/shim/downloads","issues_url":"https://api.github.com/repos/dojo/shim/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/shim/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/shim/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/shim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/shim/labels{/name}","releases_url":"https://api.github.com/repos/dojo/shim/releases{/id}","deployments_url":"https://api.github.com/repos/dojo/shim/deployments","created_at":"2016-06-20T09:20:39Z","updated_at":"2017-03-07T14:37:32Z","pushed_at":"2017-03-07T15:18:40Z","git_url":"git://github.com/dojo/shim.git","ssh_url":"git@github.com:dojo/shim.git","clone_url":"https://github.com/dojo/shim.git","svn_url":"https://github.com/dojo/shim","homepage":"","size":692,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":4,"forks":10,"open_issues":4,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/shim/pulls/79"},"html":{"href":"https://github.com/dojo/shim/pull/79"},"issue":{"href":"https://api.github.com/repos/dojo/shim/issues/79"},"comments":{"href":"https://api.github.com/repos/dojo/shim/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/shim/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/shim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/shim/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/shim/statuses/d2a2b6fcfcd0d4926bca6eee4acb93c262489d34"}}}}
{"actor":{"display_login":"dylans"}}