{"action":"created","issue":{"url":"https://api.github.com/repos/CartoDB/cartodb/issues/11789","repository_url":"https://api.github.com/repos/CartoDB/cartodb","labels_url":"https://api.github.com/repos/CartoDB/cartodb/issues/11789/labels{/name}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/11789/comments","events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/11789/events","html_url":"https://github.com/CartoDB/cartodb/pull/11789","id":215051942,"number":11789,"title":"Adds export image","user":{"login":"javierarce","id":4933,"avatar_url":"https://avatars1.githubusercontent.com/u/4933?v=3","gravatar_id":"","url":"https://api.github.com/users/javierarce","html_url":"https://github.com/javierarce","followers_url":"https://api.github.com/users/javierarce/followers","following_url":"https://api.github.com/users/javierarce/following{/other_user}","gists_url":"https://api.github.com/users/javierarce/gists{/gist_id}","starred_url":"https://api.github.com/users/javierarce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierarce/subscriptions","organizations_url":"https://api.github.com/users/javierarce/orgs","repos_url":"https://api.github.com/users/javierarce/repos","events_url":"https://api.github.com/users/javierarce/events{/privacy}","received_events_url":"https://api.github.com/users/javierarce/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":28,"created_at":"2017-03-17T16:16:45Z","updated_at":"2017-04-03T09:12:41Z","closed_at":"2017-03-29T08:23:46Z","pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/11789","html_url":"https://github.com/CartoDB/cartodb/pull/11789","diff_url":"https://github.com/CartoDB/cartodb/pull/11789.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/11789.patch"},"body":"This PR adds the ability to export maps as images.\r\n\r\n- This feature already exists in the Editor, but wasn't available for Builder.\r\n- Depends on https://github.com/CartoDB/cartodb.js/issues/1595\r\n- Depends on the `static-maps-layers-filter` of Windshaft.\r\n\r\n![export](https://cloud.githubusercontent.com/assets/4933/24053547/ac3958f8-0b39-11e7-99e8-8af1fea40e99.gif)\r\n\r\n### Characteristics:\r\n\r\n- Users can change the width & height of a rectangle that will be used as a reference to generate the image.\r\n- Images can be exported as JPG or PNG files.\r\n- The images are limited to 8192 x 8192 pixels.\r\n- Image resolution is set to 72 DPI.\r\n- JPEG quality is 85%.\r\n- The name of the exported image will be: *Name of the map*.{jpg|png}.\r\n\r\n### Future enhancements\r\n\r\n- Google Maps basemaps won't appear right now. This will be handled in a different ticket.\r\n- We'll implement the inclusion of the CARTO logo and the map attribution in a future ticket.\r\n- Before we implement the export of legends, they will be hidden from the view.\r\n\r\n### Tracking of this feature\r\n\r\nThis feature contains certain classes to track its use:\r\n\r\n`.track-ImageExport.track-typeJPG`\r\n`.track-ImageExport.track-typePNG`\r\n`.track-ImageExport.track-inputWidth`\r\n`.track-ImageExport.track-inputHeight`\r\n`.track-ImageExport.track-export`\r\n`.track-ImageExport.track-nodeTopLeft`\r\n`.track-ImageExport.track-nodeTopCenter`\r\n`.track-ImageExport.track-nodeTopRight`\r\n`.track-ImageExport.track-nodeMiddleLeft`\r\n`.track-ImageExport.track-nodeMiddleCenter`\r\n`.track-ImageExport.track-nodeBottomLeft`\r\n`.track-ImageExport.track-nodeBottomCenter`\r\n`.track-ImageExport.track-nodeBottomRight`\r\n\r\n### Extra stuff\r\n\r\nBeside the main feature, this PR adds a couple of changes to the existing codebase:\r\n\r\n- Adds the ability to add classes in the text and radio form fields.\r\n- Adds specs for the text and radio form fields.\r\n- Adds the ability to increase/decrease the value of the text fields using the up & down arrows (using the shift key makes the increment/decrement bigger)\r\n- Adds the ability to add clases to the `StackLayoutViews`.\r\n\r\n### Feature flag\r\n\r\nThis feature is protected by the `static-maps` feature flag.\r\n\r\n### How to test this\r\n\r\nEnable the `static-maps` feature flag and then simply create a map (with or without geometries) and export it. Change the basemap and export it again (remember that at this moment we don't export Google Maps basemaps).\r\n\r\nThis PR requires having [this cartodb.js PR](https://github.com/CartoDB/cartodb.js/pull/1598). If you are doing acceptance and the PR is not already merged, point the cartodb.js dependency to the #static-images branch.\r\n\r\nSee original ticket here: #10822 "},"comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments/291089310","html_url":"https://github.com/CartoDB/cartodb/pull/11789#issuecomment-291089310","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/11789","id":291089310,"user":{"login":"xavijam","id":132146,"avatar_url":"https://avatars0.githubusercontent.com/u/132146?v=3","gravatar_id":"","url":"https://api.github.com/users/xavijam","html_url":"https://github.com/xavijam","followers_url":"https://api.github.com/users/xavijam/followers","following_url":"https://api.github.com/users/xavijam/following{/other_user}","gists_url":"https://api.github.com/users/xavijam/gists{/gist_id}","starred_url":"https://api.github.com/users/xavijam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xavijam/subscriptions","organizations_url":"https://api.github.com/users/xavijam/orgs","repos_url":"https://api.github.com/users/xavijam/repos","events_url":"https://api.github.com/users/xavijam/events{/privacy}","received_events_url":"https://api.github.com/users/xavijam/received_events","type":"User","site_admin":false},"created_at":"2017-04-03T09:12:41Z","updated_at":"2017-04-03T09:12:41Z","body":"Let's deploy to the same staging (ded07? let's change the package version) and let me review the changes, ok? "}}
{"actor":{"display_login":"xavijam"}}