{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/112720669","pull_request_review_id":34058490,"id":112720669,"diff_hunk":"@@ -172,47 +151,51 @@ The following channels are supported for each bridge/thing\n | keyhold            | W          | String       | (Advanced) Send a keyhold from the zone                              |\n | keycode            | W          | String       | (Advanced) Send a keycode from the zone                              |\n | event              | W          | String       | (Advanced) Send an event from the zone                               |\n+| systemfavorites    | RW         | String*      | The JSON representation for system favorites                         |\n+| zonefavorites      | RW         | String**     | The JSON representation for zone favorites                           |\n+| presets            | RW         | String***    | The JSON representation for zone presets                             |\n+| mminit             | W          | Switch****   | Whether to initial a media management session (ON) or close an existing one (OFF) |\n+| mmcontextmenu      | W          | Switch****   | Whether to initial a media management context session (ON) or close an existing one (OFF) |\n+\n+#### Notes:\n+1. As of the time of this document, rating ON (like) produced an error in the firmware from the related command.  This has been reported to Russound.\n+2. keypress/keyrelease/keyhold/keycode/event are advanced commands that will pass the related event string to Russound (i.e. \"EVENT C[x].Z[y]!KeyPress [stringtype]\").  Please see the \"RIO Protocol for 3rd Party Integrators.pdf\" (found at the Russound Portal) for proper string forms.\n+3. If you send a OnOffType to the volume will have the same affect as turning the zone on/off (ie sending OnOffType to \"status\")\n+4. The volume PercentType will be scaled to Russound's volume of 0-50 (ie 50% = volume of 25, 100% = volume of 50)\n+5. Initialize a media management session by sending ON to the channel.  The related source thing will then start sending out media management information in the MM channels.  To close the session - simply send OFF to the channel.  Sending OFF to the channel when a session has not been initialized does nothing.  Likewise if the related source is a tuner, this command does nothing.\n \n-* As of the time of this document, rating ON (like) produced an error in the firmware from the related command.  This has been reported to Russound.\n-* keypress/keyrelease/keyhold/keycode/event are advanced commands that will pass the related event string to Russound (i.e. \"EVENT C[x].Z[y]!KeyPress [stringtype]\").  Please see the \"RIO Protocol for 3rd Party Integrators.pdf\" (found at the Russound Portal) for proper string forms.\n-* If you send a OnOffType to the volume will have the same affect as turning the zone on/off (ie sending OnOffType to \"status\")\n-* The volume PercentType will be scaled to Russound's volume of 0-50 (ie 50% = volume of 25, 100% = volume of 50)\n+##### System Favorites\n+The JSON will look like `[{\"id\":xxx,\"valid\":true,\"name\":\"yyyy\"},...]` and will have a representation for each VALID favorite on the system (ie where \"valid\" is true).  You will have up to 32 system favorites in the JSON array (the ID field will be between 1 and 32).  System favorites will be the same on ALL zones (because they are system level).  This channel appears on the zone because when you send a system favorite representation to zone channel, it sets the system favorite to what is playing in the zone.  \n \n+There are three different ways to use this channel:","path":"addons/binding/org.openhab.binding.russound/README.md","position":250,"original_position":250,"commit_id":"9ace8a40ea9b408a661b94f9b5435b3d018d22b9","original_commit_id":"9ace8a40ea9b408a661b94f9b5435b3d018d22b9","user":{"login":"kaikreuzer","id":3244965,"avatar_url":"https://avatars0.githubusercontent.com/u/3244965?v=3","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"body":"please add an empty line after this","created_at":"2017-04-21T15:54:42Z","updated_at":"2017-04-21T15:57:08Z","html_url":"https://github.com/openhab/openhab2-addons/pull/2135#discussion_r112720669","pull_request_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2135","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/112720669"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/2135#discussion_r112720669"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2135"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2135","id":114816329,"html_url":"https://github.com/openhab/openhab2-addons/pull/2135","diff_url":"https://github.com/openhab/openhab2-addons/pull/2135.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/2135.patch","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2135","number":2135,"state":"open","locked":false,"title":"1974 Russound Discovery","user":{"login":"tmrobert8","id":20641634,"avatar_url":"https://avatars1.githubusercontent.com/u/20641634?v=3","gravatar_id":"","url":"https://api.github.com/users/tmrobert8","html_url":"https://github.com/tmrobert8","followers_url":"https://api.github.com/users/tmrobert8/followers","following_url":"https://api.github.com/users/tmrobert8/following{/other_user}","gists_url":"https://api.github.com/users/tmrobert8/gists{/gist_id}","starred_url":"https://api.github.com/users/tmrobert8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmrobert8/subscriptions","organizations_url":"https://api.github.com/users/tmrobert8/orgs","repos_url":"https://api.github.com/users/tmrobert8/repos","events_url":"https://api.github.com/users/tmrobert8/events{/privacy}","received_events_url":"https://api.github.com/users/tmrobert8/received_events","type":"User","site_admin":false},"body":"This pull request adds auto discovery of Russound devices (and all controllers/sources/zones on the device itself).  Likewise, I've added all the media management functionality (to support UIs - like the HABPanel widget I've developed for this).  Removed/rearranged alot of functionality as well.\r\n\r\nLet me know what I've done wrong  ;)","created_at":"2017-04-07T13:30:18Z","updated_at":"2017-04-21T15:57:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecf066d10b1c300cdf5eb2fe53126f947ef87b16","assignee":{"login":"kaikreuzer","id":3244965,"avatar_url":"https://avatars0.githubusercontent.com/u/3244965?v=3","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"assignees":[{"login":"kaikreuzer","id":3244965,"avatar_url":"https://avatars0.githubusercontent.com/u/3244965?v=3","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2135/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2135/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/2135/comments","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/9ace8a40ea9b408a661b94f9b5435b3d018d22b9","head":{"label":"tmrobert8:1974-Russound-Discovery","ref":"1974-Russound-Discovery","sha":"9ace8a40ea9b408a661b94f9b5435b3d018d22b9","user":{"login":"tmrobert8","id":20641634,"avatar_url":"https://avatars1.githubusercontent.com/u/20641634?v=3","gravatar_id":"","url":"https://api.github.com/users/tmrobert8","html_url":"https://github.com/tmrobert8","followers_url":"https://api.github.com/users/tmrobert8/followers","following_url":"https://api.github.com/users/tmrobert8/following{/other_user}","gists_url":"https://api.github.com/users/tmrobert8/gists{/gist_id}","starred_url":"https://api.github.com/users/tmrobert8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmrobert8/subscriptions","organizations_url":"https://api.github.com/users/tmrobert8/orgs","repos_url":"https://api.github.com/users/tmrobert8/repos","events_url":"https://api.github.com/users/tmrobert8/events{/privacy}","received_events_url":"https://api.github.com/users/tmrobert8/received_events","type":"User","site_admin":false},"repo":{"id":68837270,"name":"openhab2-addons","full_name":"tmrobert8/openhab2-addons","owner":{"login":"tmrobert8","id":20641634,"avatar_url":"https://avatars1.githubusercontent.com/u/20641634?v=3","gravatar_id":"","url":"https://api.github.com/users/tmrobert8","html_url":"https://github.com/tmrobert8","followers_url":"https://api.github.com/users/tmrobert8/followers","following_url":"https://api.github.com/users/tmrobert8/following{/other_user}","gists_url":"https://api.github.com/users/tmrobert8/gists{/gist_id}","starred_url":"https://api.github.com/users/tmrobert8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmrobert8/subscriptions","organizations_url":"https://api.github.com/users/tmrobert8/orgs","repos_url":"https://api.github.com/users/tmrobert8/repos","events_url":"https://api.github.com/users/tmrobert8/events{/privacy}","received_events_url":"https://api.github.com/users/tmrobert8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmrobert8/openhab2-addons","description":"The next-generation open Home Automation Bus (openHAB)","fork":true,"url":"https://api.github.com/repos/tmrobert8/openhab2-addons","forks_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/forks","keys_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/events","assignees_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/merges","archive_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/tmrobert8/openhab2-addons/deployments","created_at":"2016-09-21T16:39:11Z","updated_at":"2016-09-21T16:39:16Z","pushed_at":"2017-04-14T16:51:42Z","git_url":"git://github.com/tmrobert8/openhab2-addons.git","ssh_url":"git@github.com:tmrobert8/openhab2-addons.git","clone_url":"https://github.com/tmrobert8/openhab2-addons.git","svn_url":"https://github.com/tmrobert8/openhab2-addons","homepage":null,"size":77005,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"4db2418194792ee6846c8376d558f763ffc9c8a2","user":{"login":"openhab","id":1007353,"avatar_url":"https://avatars3.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":19753195,"name":"openhab2-addons","full_name":"openhab/openhab2-addons","owner":{"login":"openhab","id":1007353,"avatar_url":"https://avatars3.githubusercontent.com/u/1007353?v=3","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openhab/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":false,"url":"https://api.github.com/repos/openhab/openhab2-addons","forks_url":"https://api.github.com/repos/openhab/openhab2-addons/forks","keys_url":"https://api.github.com/repos/openhab/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/openhab/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab2-addons/events","assignees_url":"https://api.github.com/repos/openhab/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/openhab/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab2-addons/merges","archive_url":"https://api.github.com/repos/openhab/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/openhab/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab2-addons/deployments","created_at":"2014-05-13T19:41:58Z","updated_at":"2017-04-19T18:15:52Z","pushed_at":"2017-04-21T14:34:38Z","git_url":"git://github.com/openhab/openhab2-addons.git","ssh_url":"git@github.com:openhab/openhab2-addons.git","clone_url":"https://github.com/openhab/openhab2-addons.git","svn_url":"https://github.com/openhab/openhab2-addons","homepage":"","size":76885,"stargazers_count":566,"watchers_count":566,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":943,"mirror_url":null,"open_issues_count":334,"forks":943,"open_issues":334,"watchers":566,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2135"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/2135"},"issue":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/2135"},"comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/2135/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2135/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/2135/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab2-addons/statuses/9ace8a40ea9b408a661b94f9b5435b3d018d22b9"}}}}
{"actor":{"display_login":"kaikreuzer"}}