{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments/107451779","pull_request_review_id":28425081,"id":107451779,"diff_hunk":"@@ -145,13 +146,15 @@ public long executeTask(String taskName, Map<String, String> taskDeploymentPrope\n \t\tResource metadataResource = appRegistration.getMetadataResource();\n \n \t\tTaskExecution taskExecution = taskExecutionRepository.createTaskExecution();\n-\t\ttaskDefinition = this.updateTaskProperties(taskDefinition, taskExecution);\n+\t\ttaskDefinition = this.updateTaskProperties(taskDefinition);\n \n \t\tMap<String, String> appDeploymentProperties = extractAppProperties(taskDefinition.getRegisteredAppName(), taskDeploymentProperties);\n \t\tMap<String, String> deployerDeploymentProperties = DeploymentPropertiesUtils.extractAndQualifyDeployerProperties(taskDeploymentProperties, taskDefinition.getRegisteredAppName());\n \t\tAppDefinition revisedDefinition = mergeAndExpandAppProperties(taskDefinition, metadataResource, appDeploymentProperties);\n \n-\t\tAppDeploymentRequest request = new AppDeploymentRequest(revisedDefinition, appResource, deployerDeploymentProperties, commandLineArgs);\n+\t\tList<String> updatedCmdLineArgs = new ArrayList<>(commandLineArgs);","path":"spring-cloud-dataflow-server-core/src/main/java/org/springframework/cloud/dataflow/server/service/impl/DefaultTaskService.java","position":20,"original_position":20,"commit_id":"6285bf8861cae8a074acddc4070a73f46c32afb1","original_commit_id":"6285bf8861cae8a074acddc4070a73f46c32afb1","user":{"login":"cppwfs","id":695673,"avatar_url":"https://avatars2.githubusercontent.com/u/695673?v=3","gravatar_id":"","url":"https://api.github.com/users/cppwfs","html_url":"https://github.com/cppwfs","followers_url":"https://api.github.com/users/cppwfs/followers","following_url":"https://api.github.com/users/cppwfs/following{/other_user}","gists_url":"https://api.github.com/users/cppwfs/gists{/gist_id}","starred_url":"https://api.github.com/users/cppwfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cppwfs/subscriptions","organizations_url":"https://api.github.com/users/cppwfs/orgs","repos_url":"https://api.github.com/users/cppwfs/repos","events_url":"https://api.github.com/users/cppwfs/events{/privacy}","received_events_url":"https://api.github.com/users/cppwfs/received_events","type":"User","site_admin":false},"body":"Should we check to see if the spring.cloud.task.executionid is already present in the command line args.  If already present should we throw an exception, since Data Flow needs to own it (at least for CF).\r\n","created_at":"2017-03-22T15:49:32Z","updated_at":"2017-03-22T15:49:38Z","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1256#discussion_r107451779","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1256","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments/107451779"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1256#discussion_r107451779"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1256"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1256","id":112041586,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1256","diff_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1256.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1256.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/1256","number":1256,"state":"open","locked":false,"title":"Pass spring.cloud.task.executionid as cmdLine arg","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars0.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/spring-cloud/spring-cloud-dataflow/issues/1255","created_at":"2017-03-22T15:42:23Z","updated_at":"2017-03-22T15:49:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a519310f05869b4d6ec46b0caede548cc241cb1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1256/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1256/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/1256/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/6285bf8861cae8a074acddc4070a73f46c32afb1","head":{"label":"ericbottard:issue_1255","ref":"issue_1255","sha":"6285bf8861cae8a074acddc4070a73f46c32afb1","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars0.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"repo":{"id":40243328,"name":"spring-cloud-dataflow","full_name":"ericbottard/spring-cloud-dataflow","owner":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars0.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericbottard/spring-cloud-dataflow","description":null,"fork":true,"url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/deployments","created_at":"2015-08-05T12:13:08Z","updated_at":"2015-09-07T07:14:40Z","pushed_at":"2017-03-22T15:42:18Z","git_url":"git://github.com/ericbottard/spring-cloud-dataflow.git","ssh_url":"git@github.com:ericbottard/spring-cloud-dataflow.git","clone_url":"https://github.com/ericbottard/spring-cloud-dataflow.git","svn_url":"https://github.com/ericbottard/spring-cloud-dataflow","homepage":null,"size":16696,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"318f7f977e915d92809f405561476a741516cc3b","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars3.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":39469487,"name":"spring-cloud-dataflow","full_name":"spring-cloud/spring-cloud-dataflow","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars3.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow","description":"Spring Cloud Data Flow provides orchestration for microservices, including both stream and task/batch processing","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/releases{/id}","deployments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/deployments","created_at":"2015-07-21T20:56:11Z","updated_at":"2017-03-22T06:23:26Z","pushed_at":"2017-03-22T15:42:24Z","git_url":"git://github.com/spring-cloud/spring-cloud-dataflow.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-dataflow.git","clone_url":"https://github.com/spring-cloud/spring-cloud-dataflow.git","svn_url":"https://github.com/spring-cloud/spring-cloud-dataflow","homepage":"http://cloud.spring.io/spring-cloud-dataflow/","size":17154,"stargazers_count":147,"watchers_count":147,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":117,"mirror_url":null,"open_issues_count":130,"forks":117,"open_issues":130,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1256"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/1256"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/1256"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/1256/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1256/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/1256/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/6285bf8861cae8a074acddc4070a73f46c32afb1"}}}}
{"actor":{"display_login":"cppwfs"}}