{"push_id":1621811403,"size":1,"distinct_size":1,"ref":"refs/heads/no-discovery.msterin","head":"9775c9b01ac0324b2413fc37e61088473db2594f","before":"b53689c39964dc631f4a876a96905d7391aaaed4","commits":[{"sha":"9775c9b01ac0324b2413fc37e61088473db2594f","author":{"name":"Mark Sterin","email":"104bb4081d23dc4c65bcdf4248f3d4608e68409c@vmware.com"},"message":"Disabled volume discovery and added env var to enable it if needed\n\nVolume discovery was written to address challenges with docker/plugin startup order,\nand as potential auto-recovery for plugin crashes.\n\n* We do not see crashes often (as a matter of fact, only once so far , with VMCI memory issues  - and\nit' fixed).\n* Docker now manages the order of plugin invocation/startup with\nManaged Plugins.\n* and, the last but not the least, during the discovery we make assumption about Docker API availability,\nbut Docker makes API available only AFTER full startup including plugin initialization, so it could lead to\nbug like #1039, where docker either hangs for 15-20 sec (like with legacy plugin) or steps on it's own\nbugs and crash (like with managed plugin)\n\nIn the spirit of taking care of the \"sunny day\" first, when everything works OK and our code does not crash,\nthis commit turns off discovery on startup.\n\nManaged plugin handles all restarts and remounts fine. Legacy plugin may have issues if we crash, but first of all\nwe never crash :-) and second legacy plugins are getting depreciated anyways","distinct":true,"url":"https://api.github.com/repos/vmware/docker-volume-vsphere/commits/9775c9b01ac0324b2413fc37e61088473db2594f"}]}
{"actor":{"display_login":"msterin"}}