{"action":"created","comment":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/97579703","pull_request_review_id":18193369,"id":97579703,"diff_hunk":"@@ -0,0 +1,814 @@\n+<?php\n+\n+namespace tests\\integration\\Pim\\Bundle\\ApiBundle\\Controller\\Rest\\Attribute;\n+\n+use Akeneo\\Test\\Integration\\Configuration;\n+use Akeneo\\Test\\Integration\\TestCase;\n+use Symfony\\Component\\HttpFoundation\\Response;\n+\n+class ListAttributeIntegration extends TestCase\n+{\n+    public function testListAttributes()\n+    {\n+        $client = static::createClient();\n+\n+        $client->request('GET', 'api/rest/v1/attributes?limit=50&page=1');","path":"src/Pim/Bundle/ApiBundle/tests/integration/Controller/Rest/Attribute/ListAttributeIntegration.php","position":15,"original_position":15,"commit_id":"a49b22a75ee9e2cd1b01335030c975125d342db1","original_commit_id":"a49b22a75ee9e2cd1b01335030c975125d342db1","user":{"login":"ahocquard","id":1942439,"avatar_url":"https://avatars.githubusercontent.com/u/1942439?v=3","gravatar_id":"","url":"https://api.github.com/users/ahocquard","html_url":"https://github.com/ahocquard","followers_url":"https://api.github.com/users/ahocquard/followers","following_url":"https://api.github.com/users/ahocquard/following{/other_user}","gists_url":"https://api.github.com/users/ahocquard/gists{/gist_id}","starred_url":"https://api.github.com/users/ahocquard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahocquard/subscriptions","organizations_url":"https://api.github.com/users/ahocquard/orgs","repos_url":"https://api.github.com/users/ahocquard/repos","events_url":"https://api.github.com/users/ahocquard/events{/privacy}","received_events_url":"https://api.github.com/users/ahocquard/received_events","type":"User","site_admin":false},"body":"why get all elements ? A better option would be :\r\n- to add a test without limit and page 1 specified in the url, to test that only 10 elements are returned.\r\n- test with limit=5 and page=2 to test that you only get the attributes from 6 to 10 position.","created_at":"2017-01-24T15:56:16Z","updated_at":"2017-01-24T15:58:06Z","html_url":"https://github.com/akeneo/pim-community-dev/pull/5563#discussion_r97579703","pull_request_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5563","_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments/97579703"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/5563#discussion_r97579703"},"pull_request":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5563"}}},"pull_request":{"url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5563","id":102721321,"html_url":"https://github.com/akeneo/pim-community-dev/pull/5563","diff_url":"https://github.com/akeneo/pim-community-dev/pull/5563.diff","patch_url":"https://github.com/akeneo/pim-community-dev/pull/5563.patch","issue_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/5563","number":5563,"state":"open","locked":false,"title":"API-15: Get a list of attributes ","user":{"login":"momoss","id":17565301,"avatar_url":"https://avatars.githubusercontent.com/u/17565301?v=3","gravatar_id":"","url":"https://api.github.com/users/momoss","html_url":"https://github.com/momoss","followers_url":"https://api.github.com/users/momoss/followers","following_url":"https://api.github.com/users/momoss/following{/other_user}","gists_url":"https://api.github.com/users/momoss/gists{/gist_id}","starred_url":"https://api.github.com/users/momoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/momoss/subscriptions","organizations_url":"https://api.github.com/users/momoss/orgs","repos_url":"https://api.github.com/users/momoss/repos","events_url":"https://api.github.com/users/momoss/events{/privacy}","received_events_url":"https://api.github.com/users/momoss/received_events","type":"User","site_admin":false},"body":"Get a list of attributes\r\nhttps://akeneo.atlassian.net/browse/API-15\r\n\r\nCall /api/rest/v1/attributes\r\nResponse 200\r\n\r\n```\r\n[{\"code\":\"sku\",\"type\":\"pim_catalog_identifier\",\"group\":\"marketing\",\"unique\":true,\"useable_as_grid_filter\":true,\"allowed_extensions\":[],\"metric_family\":null,\"default_metric_unit\":null,\"reference_data_name\":null,\"available_locales\":[],\"max_characters\":null,\"validation_rule\":null,\"validation_regexp\":null,\"wysiwyg_enabled\":false,\"number_min\":null,\"number_max\":null,\"decimals_allowed\":false,\"negative_allowed\":false,\"date_min\":null,\"date_max\":null,\"max_file_size\":null,\"minimum_input_length\":0,\"sort_order\":0,\"localizable\":false,\"scopable\":false,\"labels\":{\"de_DE\":\"SKU\",\"en_US\":\"SKU\",\"fr_FR\":\"SKU\"}},{\"code\":\"name\",\"type\":\"pim_catalog_text\",\"group\":\"marketing\",\"unique\":false,\"useable_as_grid_filter\":true,\"allowed_extensions\":[],\"metric_family\":null,\"default_metric_unit\":null,\"reference_data_name\":null,\"available_locales\":[],\"max_characters\":null,\"validation_rule\":null,\"validation_regexp\":null,\"wysiwyg_enabled\":false,\"number_min\":null,\"number_max\":null,\"decimals_allowed\":false,\"negative_allowed\":false,\"date_min\":null,\"date_max\":null,\"max_file_size\":null,\"minimum_input_length\":0,\"sort_order\":0,\"localizable\":false,\"scopable\":false,\"labels\":{\"de_DE\":\"Name\",\"en_US\":\"Name\",\"fr_FR\":\"Nom\"}}]\r\n```\r\n\r\n| Q                                 | A\r\n| --------------------------------- | ---\r\n| Added Specs                       | :negative_squared_cross_mark:\r\n| Added Behats                      | :negative_squared_cross_mark:\r\n| Added integration tests           | :white_check_mark:\r\n| Changelog updated                 | :negative_squared_cross_mark:\r\n| Review and 2 GTM                  | :clock1:\r\n| Micro Demo to the PO (Story only) | :negative_squared_cross_mark:\r\n| Migration script                  | :negative_squared_cross_mark:\r\n| Tech Doc                          | :negative_squared_cross_mark:\r\n\r\n:white_check_mark: Done and pass\r\n\r\n:red_circle: Done but fail\r\n\r\n:clock1: Done but pending\r\n\r\n:negative_squared_cross_mark: Not needed\r\n","created_at":"2017-01-23T13:46:14Z","updated_at":"2017-01-24T15:58:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"116a95f290c55d437c954edc32852855072aea11","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5563/commits","review_comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5563/comments","review_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/5563/comments","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/a49b22a75ee9e2cd1b01335030c975125d342db1","head":{"label":"akeneo:API-15","ref":"API-15","sha":"a49b22a75ee9e2cd1b01335030c975125d342db1","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"name":"pim-community-dev","full_name":"akeneo/pim-community-dev","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/pim-community-dev","description":"[Community Development Repository] The open source Product Information Management (PIM)","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/akeneo/pim-community-dev/deployments","created_at":"2012-08-10T09:27:26Z","updated_at":"2017-01-23T09:55:05Z","pushed_at":"2017-01-24T15:39:52Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"git@github.com:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://www.akeneo.com","size":100491,"stargazers_count":361,"watchers_count":361,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":196,"mirror_url":null,"open_issues_count":160,"forks":196,"open_issues":160,"watchers":361,"default_branch":"master"}},"base":{"label":"akeneo:api-web","ref":"api-web","sha":"8367c9700ccac19950752095316753d6b231d4e7","user":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"repo":{"id":5367323,"name":"pim-community-dev","full_name":"akeneo/pim-community-dev","owner":{"login":"akeneo","id":2510186,"avatar_url":"https://avatars.githubusercontent.com/u/2510186?v=3","gravatar_id":"","url":"https://api.github.com/users/akeneo","html_url":"https://github.com/akeneo","followers_url":"https://api.github.com/users/akeneo/followers","following_url":"https://api.github.com/users/akeneo/following{/other_user}","gists_url":"https://api.github.com/users/akeneo/gists{/gist_id}","starred_url":"https://api.github.com/users/akeneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akeneo/subscriptions","organizations_url":"https://api.github.com/users/akeneo/orgs","repos_url":"https://api.github.com/users/akeneo/repos","events_url":"https://api.github.com/users/akeneo/events{/privacy}","received_events_url":"https://api.github.com/users/akeneo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akeneo/pim-community-dev","description":"[Community Development Repository] The open source Product Information Management (PIM)","fork":false,"url":"https://api.github.com/repos/akeneo/pim-community-dev","forks_url":"https://api.github.com/repos/akeneo/pim-community-dev/forks","keys_url":"https://api.github.com/repos/akeneo/pim-community-dev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akeneo/pim-community-dev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akeneo/pim-community-dev/teams","hooks_url":"https://api.github.com/repos/akeneo/pim-community-dev/hooks","issue_events_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/events{/number}","events_url":"https://api.github.com/repos/akeneo/pim-community-dev/events","assignees_url":"https://api.github.com/repos/akeneo/pim-community-dev/assignees{/user}","branches_url":"https://api.github.com/repos/akeneo/pim-community-dev/branches{/branch}","tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/tags","blobs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/refs{/sha}","trees_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/{sha}","languages_url":"https://api.github.com/repos/akeneo/pim-community-dev/languages","stargazers_url":"https://api.github.com/repos/akeneo/pim-community-dev/stargazers","contributors_url":"https://api.github.com/repos/akeneo/pim-community-dev/contributors","subscribers_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscribers","subscription_url":"https://api.github.com/repos/akeneo/pim-community-dev/subscription","commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/commits{/sha}","git_commits_url":"https://api.github.com/repos/akeneo/pim-community-dev/git/commits{/sha}","comments_url":"https://api.github.com/repos/akeneo/pim-community-dev/comments{/number}","issue_comment_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues/comments{/number}","contents_url":"https://api.github.com/repos/akeneo/pim-community-dev/contents/{+path}","compare_url":"https://api.github.com/repos/akeneo/pim-community-dev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akeneo/pim-community-dev/merges","archive_url":"https://api.github.com/repos/akeneo/pim-community-dev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akeneo/pim-community-dev/downloads","issues_url":"https://api.github.com/repos/akeneo/pim-community-dev/issues{/number}","pulls_url":"https://api.github.com/repos/akeneo/pim-community-dev/pulls{/number}","milestones_url":"https://api.github.com/repos/akeneo/pim-community-dev/milestones{/number}","notifications_url":"https://api.github.com/repos/akeneo/pim-community-dev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akeneo/pim-community-dev/labels{/name}","releases_url":"https://api.github.com/repos/akeneo/pim-community-dev/releases{/id}","deployments_url":"https://api.github.com/repos/akeneo/pim-community-dev/deployments","created_at":"2012-08-10T09:27:26Z","updated_at":"2017-01-23T09:55:05Z","pushed_at":"2017-01-24T15:39:52Z","git_url":"git://github.com/akeneo/pim-community-dev.git","ssh_url":"git@github.com:akeneo/pim-community-dev.git","clone_url":"https://github.com/akeneo/pim-community-dev.git","svn_url":"https://github.com/akeneo/pim-community-dev","homepage":"http://www.akeneo.com","size":100491,"stargazers_count":361,"watchers_count":361,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":196,"mirror_url":null,"open_issues_count":160,"forks":196,"open_issues":160,"watchers":361,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5563"},"html":{"href":"https://github.com/akeneo/pim-community-dev/pull/5563"},"issue":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/5563"},"comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/issues/5563/comments"},"review_comments":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5563/comments"},"review_comment":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/pulls/5563/commits"},"statuses":{"href":"https://api.github.com/repos/akeneo/pim-community-dev/statuses/a49b22a75ee9e2cd1b01335030c975125d342db1"}}}}
{"actor":{"display_login":"ahocquard"}}