{"action":"created","comment":{"url":"https://api.github.com/repos/lede-project/source/pulls/comments/139294005","pull_request_review_id":63210799,"id":139294005,"diff_hunk":"@@ -201,7 +201,7 @@ CONFIG_INTEL_IDLE=y\n # CONFIG_IOMMU_DEBUG is not set\n # CONFIG_ISCSI_IBFT_FIND is not set\n # CONFIG_ITCO_VENDOR_SUPPORT is not set\n-CONFIG_ITCO_WDT=y\n+# CONFIG_ITCO_WDT is not set","path":"target/linux/x86/64/config-default","position":5,"original_position":5,"commit_id":"569bca4b21f664bdd2a063ebe3741903855ac2d9","original_commit_id":"569bca4b21f664bdd2a063ebe3741903855ac2d9","user":{"login":"pprindeville","id":187120,"avatar_url":"https://avatars3.githubusercontent.com/u/187120?v=4","gravatar_id":"","url":"https://api.github.com/users/pprindeville","html_url":"https://github.com/pprindeville","followers_url":"https://api.github.com/users/pprindeville/followers","following_url":"https://api.github.com/users/pprindeville/following{/other_user}","gists_url":"https://api.github.com/users/pprindeville/gists{/gist_id}","starred_url":"https://api.github.com/users/pprindeville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pprindeville/subscriptions","organizations_url":"https://api.github.com/users/pprindeville/orgs","repos_url":"https://api.github.com/users/pprindeville/repos","events_url":"https://api.github.com/users/pprindeville/events{/privacy}","received_events_url":"https://api.github.com/users/pprindeville/received_events","type":"User","site_admin":false},"body":"Because (1) it's not applicable to Pentium, Atom, or any flavor or AMD processor (k8-64 or k10), (2) because watchdogs are traditionally built as kmods, and (3) because you might want to configure the parameters that it's loaded with (without having to diddle the grub parameters).","created_at":"2017-09-16T19:53:31Z","updated_at":"2017-09-16T19:53:31Z","html_url":"https://github.com/lede-project/source/pull/1350#discussion_r139294005","pull_request_url":"https://api.github.com/repos/lede-project/source/pulls/1350","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lede-project/source/pulls/comments/139294005"},"html":{"href":"https://github.com/lede-project/source/pull/1350#discussion_r139294005"},"pull_request":{"href":"https://api.github.com/repos/lede-project/source/pulls/1350"}},"in_reply_to_id":139293533},"pull_request":{"url":"https://api.github.com/repos/lede-project/source/pulls/1350","id":141392082,"html_url":"https://github.com/lede-project/source/pull/1350","diff_url":"https://github.com/lede-project/source/pull/1350.diff","patch_url":"https://github.com/lede-project/source/pull/1350.patch","issue_url":"https://api.github.com/repos/lede-project/source/issues/1350","number":1350,"state":"open","locked":false,"title":"kernel: add packaging for Xeon iTCO watchdog timer","user":{"login":"pprindeville","id":187120,"avatar_url":"https://avatars3.githubusercontent.com/u/187120?v=4","gravatar_id":"","url":"https://api.github.com/users/pprindeville","html_url":"https://github.com/pprindeville","followers_url":"https://api.github.com/users/pprindeville/followers","following_url":"https://api.github.com/users/pprindeville/following{/other_user}","gists_url":"https://api.github.com/users/pprindeville/gists{/gist_id}","starred_url":"https://api.github.com/users/pprindeville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pprindeville/subscriptions","organizations_url":"https://api.github.com/users/pprindeville/orgs","repos_url":"https://api.github.com/users/pprindeville/repos","events_url":"https://api.github.com/users/pprindeville/events{/privacy}","received_events_url":"https://api.github.com/users/pprindeville/received_events","type":"User","site_admin":false},"body":"Third (I believe) generation and later Xeon chipsets included the iTCO watchdog timer on the processor.  Add module support for this.\r\n\r\nSigned-off-by: Philip Prindeville <philipp@redfish-solutions.com>\r\n","created_at":"2017-09-15T20:11:23Z","updated_at":"2017-09-16T19:53:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adc3e1c7573c6f109e1bf2b8d5d054cc0cf1072f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lede-project/source/pulls/1350/commits","review_comments_url":"https://api.github.com/repos/lede-project/source/pulls/1350/comments","review_comment_url":"https://api.github.com/repos/lede-project/source/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lede-project/source/issues/1350/comments","statuses_url":"https://api.github.com/repos/lede-project/source/statuses/569bca4b21f664bdd2a063ebe3741903855ac2d9","head":{"label":"pprindeville:kmod-itco-wdt","ref":"kmod-itco-wdt","sha":"569bca4b21f664bdd2a063ebe3741903855ac2d9","user":{"login":"pprindeville","id":187120,"avatar_url":"https://avatars3.githubusercontent.com/u/187120?v=4","gravatar_id":"","url":"https://api.github.com/users/pprindeville","html_url":"https://github.com/pprindeville","followers_url":"https://api.github.com/users/pprindeville/followers","following_url":"https://api.github.com/users/pprindeville/following{/other_user}","gists_url":"https://api.github.com/users/pprindeville/gists{/gist_id}","starred_url":"https://api.github.com/users/pprindeville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pprindeville/subscriptions","organizations_url":"https://api.github.com/users/pprindeville/orgs","repos_url":"https://api.github.com/users/pprindeville/repos","events_url":"https://api.github.com/users/pprindeville/events{/privacy}","received_events_url":"https://api.github.com/users/pprindeville/received_events","type":"User","site_admin":false},"repo":{"id":83726716,"name":"source","full_name":"pprindeville/source","owner":{"login":"pprindeville","id":187120,"avatar_url":"https://avatars3.githubusercontent.com/u/187120?v=4","gravatar_id":"","url":"https://api.github.com/users/pprindeville","html_url":"https://github.com/pprindeville","followers_url":"https://api.github.com/users/pprindeville/followers","following_url":"https://api.github.com/users/pprindeville/following{/other_user}","gists_url":"https://api.github.com/users/pprindeville/gists{/gist_id}","starred_url":"https://api.github.com/users/pprindeville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pprindeville/subscriptions","organizations_url":"https://api.github.com/users/pprindeville/orgs","repos_url":"https://api.github.com/users/pprindeville/repos","events_url":"https://api.github.com/users/pprindeville/events{/privacy}","received_events_url":"https://api.github.com/users/pprindeville/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pprindeville/source","description":"Mirror of https://git.lede-project.org/?p=source.git Please send your PRs against this tree. They will be merged via staging trees and appear in this tree once the staging trees get merged back into source.git","fork":true,"url":"https://api.github.com/repos/pprindeville/source","forks_url":"https://api.github.com/repos/pprindeville/source/forks","keys_url":"https://api.github.com/repos/pprindeville/source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pprindeville/source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pprindeville/source/teams","hooks_url":"https://api.github.com/repos/pprindeville/source/hooks","issue_events_url":"https://api.github.com/repos/pprindeville/source/issues/events{/number}","events_url":"https://api.github.com/repos/pprindeville/source/events","assignees_url":"https://api.github.com/repos/pprindeville/source/assignees{/user}","branches_url":"https://api.github.com/repos/pprindeville/source/branches{/branch}","tags_url":"https://api.github.com/repos/pprindeville/source/tags","blobs_url":"https://api.github.com/repos/pprindeville/source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pprindeville/source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pprindeville/source/git/refs{/sha}","trees_url":"https://api.github.com/repos/pprindeville/source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pprindeville/source/statuses/{sha}","languages_url":"https://api.github.com/repos/pprindeville/source/languages","stargazers_url":"https://api.github.com/repos/pprindeville/source/stargazers","contributors_url":"https://api.github.com/repos/pprindeville/source/contributors","subscribers_url":"https://api.github.com/repos/pprindeville/source/subscribers","subscription_url":"https://api.github.com/repos/pprindeville/source/subscription","commits_url":"https://api.github.com/repos/pprindeville/source/commits{/sha}","git_commits_url":"https://api.github.com/repos/pprindeville/source/git/commits{/sha}","comments_url":"https://api.github.com/repos/pprindeville/source/comments{/number}","issue_comment_url":"https://api.github.com/repos/pprindeville/source/issues/comments{/number}","contents_url":"https://api.github.com/repos/pprindeville/source/contents/{+path}","compare_url":"https://api.github.com/repos/pprindeville/source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pprindeville/source/merges","archive_url":"https://api.github.com/repos/pprindeville/source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pprindeville/source/downloads","issues_url":"https://api.github.com/repos/pprindeville/source/issues{/number}","pulls_url":"https://api.github.com/repos/pprindeville/source/pulls{/number}","milestones_url":"https://api.github.com/repos/pprindeville/source/milestones{/number}","notifications_url":"https://api.github.com/repos/pprindeville/source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pprindeville/source/labels{/name}","releases_url":"https://api.github.com/repos/pprindeville/source/releases{/id}","deployments_url":"https://api.github.com/repos/pprindeville/source/deployments","created_at":"2017-03-02T21:30:58Z","updated_at":"2017-03-02T21:31:14Z","pushed_at":"2017-09-16T16:18:34Z","git_url":"git://github.com/pprindeville/source.git","ssh_url":"git@github.com:pprindeville/source.git","clone_url":"https://github.com/pprindeville/source.git","svn_url":"https://github.com/pprindeville/source","homepage":"","size":141446,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lede-project:master","ref":"master","sha":"9c500db89680af5d89fb679e08452c8f090d804d","user":{"login":"lede-project","id":18146401,"avatar_url":"https://avatars0.githubusercontent.com/u/18146401?v=4","gravatar_id":"","url":"https://api.github.com/users/lede-project","html_url":"https://github.com/lede-project","followers_url":"https://api.github.com/users/lede-project/followers","following_url":"https://api.github.com/users/lede-project/following{/other_user}","gists_url":"https://api.github.com/users/lede-project/gists{/gist_id}","starred_url":"https://api.github.com/users/lede-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lede-project/subscriptions","organizations_url":"https://api.github.com/users/lede-project/orgs","repos_url":"https://api.github.com/users/lede-project/repos","events_url":"https://api.github.com/users/lede-project/events{/privacy}","received_events_url":"https://api.github.com/users/lede-project/received_events","type":"Organization","site_admin":false},"repo":{"id":58552470,"name":"source","full_name":"lede-project/source","owner":{"login":"lede-project","id":18146401,"avatar_url":"https://avatars0.githubusercontent.com/u/18146401?v=4","gravatar_id":"","url":"https://api.github.com/users/lede-project","html_url":"https://github.com/lede-project","followers_url":"https://api.github.com/users/lede-project/followers","following_url":"https://api.github.com/users/lede-project/following{/other_user}","gists_url":"https://api.github.com/users/lede-project/gists{/gist_id}","starred_url":"https://api.github.com/users/lede-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lede-project/subscriptions","organizations_url":"https://api.github.com/users/lede-project/orgs","repos_url":"https://api.github.com/users/lede-project/repos","events_url":"https://api.github.com/users/lede-project/events{/privacy}","received_events_url":"https://api.github.com/users/lede-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lede-project/source","description":"Mirror of https://git.lede-project.org/?p=source.git Please send your PRs against this tree. They will be merged via staging trees and appear in this tree once the staging trees get merged back into source.git","fork":false,"url":"https://api.github.com/repos/lede-project/source","forks_url":"https://api.github.com/repos/lede-project/source/forks","keys_url":"https://api.github.com/repos/lede-project/source/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lede-project/source/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lede-project/source/teams","hooks_url":"https://api.github.com/repos/lede-project/source/hooks","issue_events_url":"https://api.github.com/repos/lede-project/source/issues/events{/number}","events_url":"https://api.github.com/repos/lede-project/source/events","assignees_url":"https://api.github.com/repos/lede-project/source/assignees{/user}","branches_url":"https://api.github.com/repos/lede-project/source/branches{/branch}","tags_url":"https://api.github.com/repos/lede-project/source/tags","blobs_url":"https://api.github.com/repos/lede-project/source/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lede-project/source/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lede-project/source/git/refs{/sha}","trees_url":"https://api.github.com/repos/lede-project/source/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lede-project/source/statuses/{sha}","languages_url":"https://api.github.com/repos/lede-project/source/languages","stargazers_url":"https://api.github.com/repos/lede-project/source/stargazers","contributors_url":"https://api.github.com/repos/lede-project/source/contributors","subscribers_url":"https://api.github.com/repos/lede-project/source/subscribers","subscription_url":"https://api.github.com/repos/lede-project/source/subscription","commits_url":"https://api.github.com/repos/lede-project/source/commits{/sha}","git_commits_url":"https://api.github.com/repos/lede-project/source/git/commits{/sha}","comments_url":"https://api.github.com/repos/lede-project/source/comments{/number}","issue_comment_url":"https://api.github.com/repos/lede-project/source/issues/comments{/number}","contents_url":"https://api.github.com/repos/lede-project/source/contents/{+path}","compare_url":"https://api.github.com/repos/lede-project/source/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lede-project/source/merges","archive_url":"https://api.github.com/repos/lede-project/source/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lede-project/source/downloads","issues_url":"https://api.github.com/repos/lede-project/source/issues{/number}","pulls_url":"https://api.github.com/repos/lede-project/source/pulls{/number}","milestones_url":"https://api.github.com/repos/lede-project/source/milestones{/number}","notifications_url":"https://api.github.com/repos/lede-project/source/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lede-project/source/labels{/name}","releases_url":"https://api.github.com/repos/lede-project/source/releases{/id}","deployments_url":"https://api.github.com/repos/lede-project/source/deployments","created_at":"2016-05-11T14:31:34Z","updated_at":"2017-09-16T06:22:17Z","pushed_at":"2017-09-16T19:18:21Z","git_url":"git://github.com/lede-project/source.git","ssh_url":"git@github.com:lede-project/source.git","clone_url":"https://github.com/lede-project/source.git","svn_url":"https://github.com/lede-project/source","homepage":"","size":141853,"stargazers_count":878,"watchers_count":878,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":753,"mirror_url":null,"open_issues_count":83,"forks":753,"open_issues":83,"watchers":878,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lede-project/source/pulls/1350"},"html":{"href":"https://github.com/lede-project/source/pull/1350"},"issue":{"href":"https://api.github.com/repos/lede-project/source/issues/1350"},"comments":{"href":"https://api.github.com/repos/lede-project/source/issues/1350/comments"},"review_comments":{"href":"https://api.github.com/repos/lede-project/source/pulls/1350/comments"},"review_comment":{"href":"https://api.github.com/repos/lede-project/source/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lede-project/source/pulls/1350/commits"},"statuses":{"href":"https://api.github.com/repos/lede-project/source/statuses/569bca4b21f664bdd2a063ebe3741903855ac2d9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pprindeville"}}