{"comment":{"url":"https://api.github.com/repos/madecode15/PocketMine-MP/comments/20929553","html_url":"https://github.com/madecode15/PocketMine-MP/commit/db4c3c93da23a4b8adcf00e639d9f02f74f1b9ab#commitcomment-20929553","id":20929553,"user":{"login":"JackNoordhuis","id":10399774,"avatar_url":"https://avatars.githubusercontent.com/u/10399774?v=3","gravatar_id":"","url":"https://api.github.com/users/JackNoordhuis","html_url":"https://github.com/JackNoordhuis","followers_url":"https://api.github.com/users/JackNoordhuis/followers","following_url":"https://api.github.com/users/JackNoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/JackNoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/JackNoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JackNoordhuis/subscriptions","organizations_url":"https://api.github.com/users/JackNoordhuis/orgs","repos_url":"https://api.github.com/users/JackNoordhuis/repos","events_url":"https://api.github.com/users/JackNoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/JackNoordhuis/received_events","type":"User","site_admin":false},"position":56,"line":56,"path":"src/pocketmine/command/defaults/WeatherCommand.php","commit_id":"db4c3c93da23a4b8adcf00e639d9f02f74f1b9ab","created_at":"2017-02-17T11:52:44Z","updated_at":"2017-02-17T11:52:44Z","body":"Just because the server hasn't removed all references to the player object doesn't mean all code the player has called before destroying the object should be executed. It's actually bad to keep executing the code if the player isn't even online.\r\n\r\nThere are possible scenarios that can cause the player to execute the command after they've disconnected simply because a plugin is still holding a reference to a player.\r\n\r\nAlso, just because this has been done before doesn't mean it is right. PocketMine is a mess and spreading the existing mess even further for the sake of consistency is just laziness in my opinion."}}
{"actor":{"display_login":"JackNoordhuis"}}