{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/129234577","pull_request_review_id":51984712,"id":129234577,"diff_hunk":"@@ -645,7 +657,13 @@ def fit(self, X, y):\n             self.priors_ = self.priors\n \n         cov = None\n-        if self.store_covariances:\n+        store_covariance = None\n+        if self.store_covariances is not None:\n+            warnings.warn(\"'store_covariances' was renamed to store_covariance\"\n+                          \" in version 0.19 and will be removed in 0.21.\",\n+                          DeprecationWarning)\n+            store_covariance = self.store_covariances","path":"sklearn/discriminant_analysis.py","position":88,"original_position":88,"commit_id":"c187197d57574d78479f6ed9ebe63c602e5bd2dc","original_commit_id":"c187197d57574d78479f6ed9ebe63c602e5bd2dc","user":{"login":"mrbeann","id":9161747,"avatar_url":"https://avatars0.githubusercontent.com/u/9161747?v=4","gravatar_id":"","url":"https://api.github.com/users/mrbeann","html_url":"https://github.com/mrbeann","followers_url":"https://api.github.com/users/mrbeann/followers","following_url":"https://api.github.com/users/mrbeann/following{/other_user}","gists_url":"https://api.github.com/users/mrbeann/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbeann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbeann/subscriptions","organizations_url":"https://api.github.com/users/mrbeann/orgs","repos_url":"https://api.github.com/users/mrbeann/repos","events_url":"https://api.github.com/users/mrbeann/events{/privacy}","received_events_url":"https://api.github.com/users/mrbeann/received_events","type":"User","site_admin":false},"body":"but we can't figure out the value of `store_covariance ` is come from `self.store_covariance` or `self.store_covariances`, then we can't decide whether to raise a warning?","created_at":"2017-07-25T07:52:28Z","updated_at":"2017-07-25T07:52:28Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/8130#discussion_r129234577","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8130","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/129234577"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/8130#discussion_r129234577"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8130"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8130","id":99570626,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/8130","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/8130.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/8130.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8130","number":8130,"state":"open","locked":false,"title":"[MRG+1] Issue#7998 : Consistent parameters between QDA and LDA","user":{"login":"mrbeann","id":9161747,"avatar_url":"https://avatars0.githubusercontent.com/u/9161747?v=4","gravatar_id":"","url":"https://api.github.com/users/mrbeann","html_url":"https://github.com/mrbeann","followers_url":"https://api.github.com/users/mrbeann/followers","following_url":"https://api.github.com/users/mrbeann/following{/other_user}","gists_url":"https://api.github.com/users/mrbeann/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbeann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbeann/subscriptions","organizations_url":"https://api.github.com/users/mrbeann/orgs","repos_url":"https://api.github.com/users/mrbeann/repos","events_url":"https://api.github.com/users/mrbeann/events{/privacy}","received_events_url":"https://api.github.com/users/mrbeann/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for contributing a pull request! Please ensure you have taken a look at\r\nthe contribution guidelines: https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#Contributing-Pull-Requests\r\n-->\r\n#### Reference Issue\r\n<!-- Example: Fixes #1234 -->\r\nFix [#7998](https://github.com/scikit-learn/scikit-learn/issues/7998)\r\n\r\nsee also [the previous one](https://github.com/scikit-learn/scikit-learn/pull/8118)\r\n\r\n<!--\r\nPlease be aware that we are a loose team of volunteers so patience is\r\nnecessary; assistance handling other issues is very welcome. We value\r\nall user contributions, no matter how minor they are. If we are slow to\r\nreview, either the pull request needs some benchmarking, tinkering,\r\nconvincing, etc. or more likely the reviewers are simply busy. In either\r\ncase, we ask for your understanding during the review process.\r\nFor more information, see our FAQ on this topic:\r\nhttp://scikit-learn.org/dev/faq.html#why-is-my-pull-request-not-getting-any-attention.\r\n\r\nThanks for contributing!\r\n-->\r\n","created_at":"2016-12-28T16:58:56Z","updated_at":"2017-07-25T07:52:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"667d35b06bb40771613c62f4abb2617f16c94a67","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/21","html_url":"https://github.com/scikit-learn/scikit-learn/milestone/21","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones/21/labels","id":1970916,"number":21,"title":"0.19","description":"","creator":{"login":"amueller","id":449558,"avatar_url":"https://avatars3.githubusercontent.com/u/449558?v=4","gravatar_id":"","url":"https://api.github.com/users/amueller","html_url":"https://github.com/amueller","followers_url":"https://api.github.com/users/amueller/followers","following_url":"https://api.github.com/users/amueller/following{/other_user}","gists_url":"https://api.github.com/users/amueller/gists{/gist_id}","starred_url":"https://api.github.com/users/amueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amueller/subscriptions","organizations_url":"https://api.github.com/users/amueller/orgs","repos_url":"https://api.github.com/users/amueller/repos","events_url":"https://api.github.com/users/amueller/events{/privacy}","received_events_url":"https://api.github.com/users/amueller/received_events","type":"User","site_admin":false},"open_issues":51,"closed_issues":175,"state":"open","created_at":"2016-08-29T22:34:33Z","updated_at":"2017-07-24T23:18:52Z","due_on":"2017-07-04T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8130/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8130/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8130/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/c187197d57574d78479f6ed9ebe63c602e5bd2dc","head":{"label":"mrbeann:pr7998","ref":"pr7998","sha":"c187197d57574d78479f6ed9ebe63c602e5bd2dc","user":{"login":"mrbeann","id":9161747,"avatar_url":"https://avatars0.githubusercontent.com/u/9161747?v=4","gravatar_id":"","url":"https://api.github.com/users/mrbeann","html_url":"https://github.com/mrbeann","followers_url":"https://api.github.com/users/mrbeann/followers","following_url":"https://api.github.com/users/mrbeann/following{/other_user}","gists_url":"https://api.github.com/users/mrbeann/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbeann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbeann/subscriptions","organizations_url":"https://api.github.com/users/mrbeann/orgs","repos_url":"https://api.github.com/users/mrbeann/repos","events_url":"https://api.github.com/users/mrbeann/events{/privacy}","received_events_url":"https://api.github.com/users/mrbeann/received_events","type":"User","site_admin":false},"repo":{"id":73677087,"name":"scikit-learn","full_name":"mrbeann/scikit-learn","owner":{"login":"mrbeann","id":9161747,"avatar_url":"https://avatars0.githubusercontent.com/u/9161747?v=4","gravatar_id":"","url":"https://api.github.com/users/mrbeann","html_url":"https://github.com/mrbeann","followers_url":"https://api.github.com/users/mrbeann/followers","following_url":"https://api.github.com/users/mrbeann/following{/other_user}","gists_url":"https://api.github.com/users/mrbeann/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbeann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbeann/subscriptions","organizations_url":"https://api.github.com/users/mrbeann/orgs","repos_url":"https://api.github.com/users/mrbeann/repos","events_url":"https://api.github.com/users/mrbeann/events{/privacy}","received_events_url":"https://api.github.com/users/mrbeann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrbeann/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/mrbeann/scikit-learn","forks_url":"https://api.github.com/repos/mrbeann/scikit-learn/forks","keys_url":"https://api.github.com/repos/mrbeann/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrbeann/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrbeann/scikit-learn/teams","hooks_url":"https://api.github.com/repos/mrbeann/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/mrbeann/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/mrbeann/scikit-learn/events","assignees_url":"https://api.github.com/repos/mrbeann/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/mrbeann/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/mrbeann/scikit-learn/tags","blobs_url":"https://api.github.com/repos/mrbeann/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrbeann/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrbeann/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrbeann/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrbeann/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/mrbeann/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/mrbeann/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/mrbeann/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/mrbeann/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/mrbeann/scikit-learn/subscription","commits_url":"https://api.github.com/repos/mrbeann/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrbeann/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrbeann/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrbeann/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrbeann/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/mrbeann/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrbeann/scikit-learn/merges","archive_url":"https://api.github.com/repos/mrbeann/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrbeann/scikit-learn/downloads","issues_url":"https://api.github.com/repos/mrbeann/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/mrbeann/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/mrbeann/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/mrbeann/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrbeann/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/mrbeann/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/mrbeann/scikit-learn/deployments","created_at":"2016-11-14T07:06:30Z","updated_at":"2016-11-14T07:06:38Z","pushed_at":"2017-07-25T03:11:56Z","git_url":"git://github.com/mrbeann/scikit-learn.git","ssh_url":"git@github.com:mrbeann/scikit-learn.git","clone_url":"https://github.com/mrbeann/scikit-learn.git","svn_url":"https://github.com/mrbeann/scikit-learn","homepage":"http://scikit-learn.org","size":83868,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"e14c6827eecca873f150b422ec6ec0033465c9c1","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2017-07-25T07:35:14Z","pushed_at":"2017-07-25T07:50:27Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":84352,"stargazers_count":20054,"watchers_count":20054,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10804,"mirror_url":null,"open_issues_count":1403,"forks":10804,"open_issues":1403,"watchers":20054,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8130"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/8130"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8130"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/8130/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8130/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/8130/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/c187197d57574d78479f6ed9ebe63c602e5bd2dc"}}}}
{"actor":{"display_login":"mrbeann"}}