{"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/109938407","pull_request_review_id":31073325,"id":109938407,"diff_hunk":"@@ -1733,41 +1695,59 @@ XFEM::setSolution(SystemBase & sys,\n                   NumericVector<Number> & old_solution,\n                   NumericVector<Number> & older_solution)\n {\n-  for (auto dit = stored_solution.begin(); dit != stored_solution.end(); ++dit)\n+  for (auto node_it = _mesh->local_nodes_begin(); node_it != _mesh->nodes_end(); ++node_it)","path":"modules/xfem/src/base/XFEM.C","position":50,"original_position":50,"commit_id":"2e9f1f5cfa020e23b00733a4574e7f3f7a3ef211","original_commit_id":"2e9f1f5cfa020e23b00733a4574e7f3f7a3ef211","user":{"login":"permcody","id":3036960,"avatar_url":"https://avatars1.githubusercontent.com/u/3036960?v=3","gravatar_id":"","url":"https://api.github.com/users/permcody","html_url":"https://github.com/permcody","followers_url":"https://api.github.com/users/permcody/followers","following_url":"https://api.github.com/users/permcody/following{/other_user}","gists_url":"https://api.github.com/users/permcody/gists{/gist_id}","starred_url":"https://api.github.com/users/permcody/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/permcody/subscriptions","organizations_url":"https://api.github.com/users/permcody/orgs","repos_url":"https://api.github.com/users/permcody/repos","events_url":"https://api.github.com/users/permcody/events{/privacy}","received_events_url":"https://api.github.com/users/permcody/received_events","type":"User","site_admin":false},"body":"I'd move the `nodes_end()` call out of the loop. The libMesh iterators can be slow to evaluate.","created_at":"2017-04-05T14:55:15Z","updated_at":"2017-04-05T14:58:11Z","html_url":"https://github.com/idaholab/moose/pull/8865#discussion_r109938407","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/8865","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/109938407"},"html":{"href":"https://github.com/idaholab/moose/pull/8865#discussion_r109938407"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/8865"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/8865","id":114229429,"html_url":"https://github.com/idaholab/moose/pull/8865","diff_url":"https://github.com/idaholab/moose/pull/8865.diff","patch_url":"https://github.com/idaholab/moose/pull/8865.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/8865","number":8865,"state":"open","locked":false,"title":"Improve the procedure for setting the solution","user":{"login":"bwspenc","id":6609012,"avatar_url":"https://avatars2.githubusercontent.com/u/6609012?v=3","gravatar_id":"","url":"https://api.github.com/users/bwspenc","html_url":"https://github.com/bwspenc","followers_url":"https://api.github.com/users/bwspenc/followers","following_url":"https://api.github.com/users/bwspenc/following{/other_user}","gists_url":"https://api.github.com/users/bwspenc/gists{/gist_id}","starred_url":"https://api.github.com/users/bwspenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwspenc/subscriptions","organizations_url":"https://api.github.com/users/bwspenc/orgs","repos_url":"https://api.github.com/users/bwspenc/repos","events_url":"https://api.github.com/users/bwspenc/events{/privacy}","received_events_url":"https://api.github.com/users/bwspenc/received_events","type":"User","site_admin":false},"body":" ref #8763","created_at":"2017-04-04T19:50:39Z","updated_at":"2017-04-05T14:58:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7063c0a02ca3ca708e8e28a18b1ac2d7734c3c04","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/8865/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/8865/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/8865/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/2e9f1f5cfa020e23b00733a4574e7f3f7a3ef211","head":{"label":"bwspenc:xfem_init_bug","ref":"xfem_init_bug","sha":"2e9f1f5cfa020e23b00733a4574e7f3f7a3ef211","user":{"login":"bwspenc","id":6609012,"avatar_url":"https://avatars2.githubusercontent.com/u/6609012?v=3","gravatar_id":"","url":"https://api.github.com/users/bwspenc","html_url":"https://github.com/bwspenc","followers_url":"https://api.github.com/users/bwspenc/followers","following_url":"https://api.github.com/users/bwspenc/following{/other_user}","gists_url":"https://api.github.com/users/bwspenc/gists{/gist_id}","starred_url":"https://api.github.com/users/bwspenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwspenc/subscriptions","organizations_url":"https://api.github.com/users/bwspenc/orgs","repos_url":"https://api.github.com/users/bwspenc/repos","events_url":"https://api.github.com/users/bwspenc/events{/privacy}","received_events_url":"https://api.github.com/users/bwspenc/received_events","type":"User","site_admin":false},"repo":{"id":17871830,"name":"moose","full_name":"bwspenc/moose","owner":{"login":"bwspenc","id":6609012,"avatar_url":"https://avatars2.githubusercontent.com/u/6609012?v=3","gravatar_id":"","url":"https://api.github.com/users/bwspenc","html_url":"https://github.com/bwspenc","followers_url":"https://api.github.com/users/bwspenc/followers","following_url":"https://api.github.com/users/bwspenc/following{/other_user}","gists_url":"https://api.github.com/users/bwspenc/gists{/gist_id}","starred_url":"https://api.github.com/users/bwspenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwspenc/subscriptions","organizations_url":"https://api.github.com/users/bwspenc/orgs","repos_url":"https://api.github.com/users/bwspenc/repos","events_url":"https://api.github.com/users/bwspenc/events{/privacy}","received_events_url":"https://api.github.com/users/bwspenc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bwspenc/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/bwspenc/moose","forks_url":"https://api.github.com/repos/bwspenc/moose/forks","keys_url":"https://api.github.com/repos/bwspenc/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwspenc/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwspenc/moose/teams","hooks_url":"https://api.github.com/repos/bwspenc/moose/hooks","issue_events_url":"https://api.github.com/repos/bwspenc/moose/issues/events{/number}","events_url":"https://api.github.com/repos/bwspenc/moose/events","assignees_url":"https://api.github.com/repos/bwspenc/moose/assignees{/user}","branches_url":"https://api.github.com/repos/bwspenc/moose/branches{/branch}","tags_url":"https://api.github.com/repos/bwspenc/moose/tags","blobs_url":"https://api.github.com/repos/bwspenc/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwspenc/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwspenc/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwspenc/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwspenc/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/bwspenc/moose/languages","stargazers_url":"https://api.github.com/repos/bwspenc/moose/stargazers","contributors_url":"https://api.github.com/repos/bwspenc/moose/contributors","subscribers_url":"https://api.github.com/repos/bwspenc/moose/subscribers","subscription_url":"https://api.github.com/repos/bwspenc/moose/subscription","commits_url":"https://api.github.com/repos/bwspenc/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwspenc/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwspenc/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwspenc/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwspenc/moose/contents/{+path}","compare_url":"https://api.github.com/repos/bwspenc/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwspenc/moose/merges","archive_url":"https://api.github.com/repos/bwspenc/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwspenc/moose/downloads","issues_url":"https://api.github.com/repos/bwspenc/moose/issues{/number}","pulls_url":"https://api.github.com/repos/bwspenc/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/bwspenc/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/bwspenc/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwspenc/moose/labels{/name}","releases_url":"https://api.github.com/repos/bwspenc/moose/releases{/id}","deployments_url":"https://api.github.com/repos/bwspenc/moose/deployments","created_at":"2014-03-18T15:50:50Z","updated_at":"2016-11-14T23:23:41Z","pushed_at":"2017-04-04T19:55:51Z","git_url":"git://github.com/bwspenc/moose.git","ssh_url":"git@github.com:bwspenc/moose.git","clone_url":"https://github.com/bwspenc/moose.git","svn_url":"https://github.com/bwspenc/moose","homepage":null,"size":189030,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":1,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"0b8764afeaf0d5b964db03627b100ee627bbf940","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars3.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars3.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","deployments_url":"https://api.github.com/repos/idaholab/moose/deployments","created_at":"2014-02-14T22:26:15Z","updated_at":"2017-03-29T17:34:36Z","pushed_at":"2017-04-05T14:52:54Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":188753,"stargazers_count":199,"watchers_count":199,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":333,"mirror_url":null,"open_issues_count":673,"forks":333,"open_issues":673,"watchers":199,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/8865"},"html":{"href":"https://github.com/idaholab/moose/pull/8865"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/8865"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/8865/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/8865/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/8865/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/2e9f1f5cfa020e23b00733a4574e7f3f7a3ef211"}}}}
{"actor":{"display_login":"permcody"}}