{"action":"created","issue":{"url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/197","repository_url":"https://api.github.com/repos/jtablesaw/tablesaw","labels_url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/197/labels{/name}","comments_url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/197/comments","events_url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/197/events","html_url":"https://github.com/jtablesaw/tablesaw/pull/197","id":273660198,"number":197,"title":"Remove Kotlin files","user":{"login":"benmccann","id":322311,"avatar_url":"https://avatars3.githubusercontent.com/u/322311?v=4","gravatar_id":"","url":"https://api.github.com/users/benmccann","html_url":"https://github.com/benmccann","followers_url":"https://api.github.com/users/benmccann/followers","following_url":"https://api.github.com/users/benmccann/following{/other_user}","gists_url":"https://api.github.com/users/benmccann/gists{/gist_id}","starred_url":"https://api.github.com/users/benmccann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benmccann/subscriptions","organizations_url":"https://api.github.com/users/benmccann/orgs","repos_url":"https://api.github.com/users/benmccann/repos","events_url":"https://api.github.com/users/benmccann/events{/privacy}","received_events_url":"https://api.github.com/users/benmccann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-11-14T03:59:12Z","updated_at":"2017-11-14T23:43:28Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/jtablesaw/tablesaw/pulls/197","html_url":"https://github.com/jtablesaw/tablesaw/pull/197","diff_url":"https://github.com/jtablesaw/tablesaw/pull/197.diff","patch_url":"https://github.com/jtablesaw/tablesaw/pull/197.patch"},"body":"@lwhite1 if this is okay with you, I'd like to remove the Kotlin files for now as you suggested\r\n\r\nIn case others are curious why:\r\n- Not finished yet and not as well-maintained\r\n- Not documented\r\n- Makes it hard to edit the code in Eclipse since Kotlin editing is really only supported by Intellij\r\n- Removes Kotlin dependency from core Java library. If we want to add it back later we should consider doing so in a separate project\r\n- Not clear that the current Kotlin code lets you do anything in Kotlin that the Java code doesn't\r\n- Doesn't appear to be implemented in the most concise manner. I don't know Kotlin well, but it appears that using `Derived` keyword would cut out 90%+ of this code\r\n\r\nWe could possibly support Kotlin in the future, but ideally we should address the above points if/when we do so"},"comment":{"url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/comments/344437852","html_url":"https://github.com/jtablesaw/tablesaw/pull/197#issuecomment-344437852","issue_url":"https://api.github.com/repos/jtablesaw/tablesaw/issues/197","id":344437852,"user":{"login":"lwhite1","id":3430274,"avatar_url":"https://avatars0.githubusercontent.com/u/3430274?v=4","gravatar_id":"","url":"https://api.github.com/users/lwhite1","html_url":"https://github.com/lwhite1","followers_url":"https://api.github.com/users/lwhite1/followers","following_url":"https://api.github.com/users/lwhite1/following{/other_user}","gists_url":"https://api.github.com/users/lwhite1/gists{/gist_id}","starred_url":"https://api.github.com/users/lwhite1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwhite1/subscriptions","organizations_url":"https://api.github.com/users/lwhite1/orgs","repos_url":"https://api.github.com/users/lwhite1/repos","events_url":"https://api.github.com/users/lwhite1/events{/privacy}","received_events_url":"https://api.github.com/users/lwhite1/received_events","type":"User","site_admin":false},"created_at":"2017-11-14T23:43:27Z","updated_at":"2017-11-14T23:43:27Z","author_association":"COLLABORATOR","body":"Yeah, you should really stop using eclipse ;)\n\nHave at it.\n\nOn Mon, Nov 13, 2017 at 10:59 PM, Ben McCann <notifications@github.com>\nwrote:\n\n> @lwhite1 <https://github.com/lwhite1> if this is okay with you, I'd like\n> to remove the Kotlin files for now as you suggested\n>\n> In case others are curious why:\n>\n>    - Not finished yet and not as well-maintained\n>    - Not documented\n>    - Makes it hard to edit the code in Eclipse since Kotlin editing is\n>    really only supported by Intellij\n>    - Removes Kotlin dependency from core Java library. If we want to add\n>    it back later we should consider doing so in a separate project\n>    - Not clear that the current Kotlin code lets you do anything in\n>    Kotlin that the Java code doesn't\n>    - Doesn't appear to be implemented in the most concise manner. I don't\n>    know Kotlin well, but it appears that using Derived keyword would cut\n>    out 90%+ of this code\n>\n> We could possibly support Kotlin in the future, but ideally we should\n> address the above points if/when we do so\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/jtablesaw/tablesaw/pull/197\n> Commit Summary\n>\n>    - Remove Kotlin files\n>\n> File Changes\n>\n>    - *M* core/pom.xml\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-0> (15)\n>    - *M* core/src/main/java/tech/tablesaw/api/FloatColumn.java\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-1> (7)\n>    - *M* core/src/main/java/tech/tablesaw/api/IntColumn.java\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-2> (3)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/AbstractCol.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-3> (24)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/BooleanCol.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-4> (73)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/CategoryCol.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-5> (110)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/Col.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-6> (158)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/Dataframe.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-7> (147)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/DateCol.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-8> (199)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/DateTimeCol.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-9> (110)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/DoubleCol.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-10> (154)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/FloatCol.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-11> (147)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/IntCol.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-12> (204)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/LongCol.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-13> (148)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/NumericCol.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-14> (69)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/ShortCol.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-15> (148)\n>    - *D* core/src/main/kotlin/tech/tablesaw/kapi/TimeCol.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-16> (81)\n>    - *D* core/src/test/kotlin/tech/tablesaw/kapi/IntColTest.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-17> (133)\n>    - *M* docs/contributing.md\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-18> (1)\n>    - *M* plot/pom.xml\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-19> (10)\n>    - *M* plot/src/main/java/tech/tablesaw/api/plot/Scatter.java\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-20> (14)\n>    - *D* plot/src/test/kotlin/tech/tablesaw/kapi/TornadoTest.kt\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-21> (155)\n>    - *M* pom.xml\n>    <https://github.com/jtablesaw/tablesaw/pull/197/files#diff-22> (32)\n>\n> Patch Links:\n>\n>    - https://github.com/jtablesaw/tablesaw/pull/197.patch\n>    - https://github.com/jtablesaw/tablesaw/pull/197.diff\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/jtablesaw/tablesaw/pull/197>, or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ADRXgvLP81FYleG1ZyUuZxwWCfKMuBAAks5s2RATgaJpZM4QcxWF>\n> .\n>\n"}}
{"actor":{"display_login":"lwhite1"}}