{"action":"created","comment":{"url":"https://api.github.com/repos/pravega/pravega/pulls/comments/144679926","pull_request_review_id":69376777,"id":144679926,"diff_hunk":"@@ -0,0 +1,16 @@\n+#!/bin/bash\n+#\n+# Copyright (c) 2017 Dell Inc., or its subsidiaries. All Rights Reserved.\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+","path":"test/system/Change_Docker_Config.sh","position":11,"original_position":11,"commit_id":"55738acb665a8e4ebd740629feb467756736e3f1","original_commit_id":"55738acb665a8e4ebd740629feb467756736e3f1","user":{"login":"tkaitchuck","id":4756752,"avatar_url":"https://avatars1.githubusercontent.com/u/4756752?v=4","gravatar_id":"","url":"https://api.github.com/users/tkaitchuck","html_url":"https://github.com/tkaitchuck","followers_url":"https://api.github.com/users/tkaitchuck/followers","following_url":"https://api.github.com/users/tkaitchuck/following{/other_user}","gists_url":"https://api.github.com/users/tkaitchuck/gists{/gist_id}","starred_url":"https://api.github.com/users/tkaitchuck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkaitchuck/subscriptions","organizations_url":"https://api.github.com/users/tkaitchuck/orgs","repos_url":"https://api.github.com/users/tkaitchuck/repos","events_url":"https://api.github.com/users/tkaitchuck/events{/privacy}","received_events_url":"https://api.github.com/users/tkaitchuck/received_events","type":"User","site_admin":false},"body":"I think you want a `set -e` here","created_at":"2017-10-14T00:26:31Z","updated_at":"2017-10-14T00:58:51Z","html_url":"https://github.com/pravega/pravega/pull/1906#discussion_r144679926","pull_request_url":"https://api.github.com/repos/pravega/pravega/pulls/1906","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments/144679926"},"html":{"href":"https://github.com/pravega/pravega/pull/1906#discussion_r144679926"},"pull_request":{"href":"https://api.github.com/repos/pravega/pravega/pulls/1906"}}},"pull_request":{"url":"https://api.github.com/repos/pravega/pravega/pulls/1906","id":142167289,"html_url":"https://github.com/pravega/pravega/pull/1906","diff_url":"https://github.com/pravega/pravega/pull/1906.diff","patch_url":"https://github.com/pravega/pravega/pull/1906.patch","issue_url":"https://api.github.com/repos/pravega/pravega/issues/1906","number":1906,"state":"open","locked":false,"title":"Issue 1411: Docker swarm based system test framework","user":{"login":"Prabha-Veerubhotla","id":20699674,"avatar_url":"https://avatars2.githubusercontent.com/u/20699674?v=4","gravatar_id":"","url":"https://api.github.com/users/Prabha-Veerubhotla","html_url":"https://github.com/Prabha-Veerubhotla","followers_url":"https://api.github.com/users/Prabha-Veerubhotla/followers","following_url":"https://api.github.com/users/Prabha-Veerubhotla/following{/other_user}","gists_url":"https://api.github.com/users/Prabha-Veerubhotla/gists{/gist_id}","starred_url":"https://api.github.com/users/Prabha-Veerubhotla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prabha-Veerubhotla/subscriptions","organizations_url":"https://api.github.com/users/Prabha-Veerubhotla/orgs","repos_url":"https://api.github.com/users/Prabha-Veerubhotla/repos","events_url":"https://api.github.com/users/Prabha-Veerubhotla/events{/privacy}","received_events_url":"https://api.github.com/users/Prabha-Veerubhotla/received_events","type":"User","site_admin":false},"body":"**Change log description**\r\nThe idea is to use docker (along with docker-swarm) to deploy various components / services  and execute system tests in Pravega i.e. zookeeper, bookkeeper, hdfs, Segmentstore, Controller \r\n**Purpose of the change**\r\nFixes #1411\r\nThis docker based system test framework supports running of system tests locally i.e (on our development machine/laptops).\r\n**What the code does**\r\nDeploys servcies and executes test using docker swarm\r\n**How to verify it**\r\n ./gradlew --info startSystemTestsWithDocker \" -PdockerRegistryUrl=\" \" -DmasterIP=\" \" -DimageVersion=\" \" -DskipServiceInstallation=false -Dlog.level=DEBUG -DexecType=DOCKER\r\n\r\nThe flag `-DexecType`  should be set to `DOCKER`  for this execution to be invoked.","created_at":"2017-09-20T18:14:46Z","updated_at":"2017-10-14T00:58:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cd46b19c17c8b6c2bca244a28d6064597e93a91","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fpj","id":572920,"avatar_url":"https://avatars3.githubusercontent.com/u/572920?v=4","gravatar_id":"","url":"https://api.github.com/users/fpj","html_url":"https://github.com/fpj","followers_url":"https://api.github.com/users/fpj/followers","following_url":"https://api.github.com/users/fpj/following{/other_user}","gists_url":"https://api.github.com/users/fpj/gists{/gist_id}","starred_url":"https://api.github.com/users/fpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fpj/subscriptions","organizations_url":"https://api.github.com/users/fpj/orgs","repos_url":"https://api.github.com/users/fpj/repos","events_url":"https://api.github.com/users/fpj/events{/privacy}","received_events_url":"https://api.github.com/users/fpj/received_events","type":"User","site_admin":false},{"login":"shiveshr","id":13659022,"avatar_url":"https://avatars2.githubusercontent.com/u/13659022?v=4","gravatar_id":"","url":"https://api.github.com/users/shiveshr","html_url":"https://github.com/shiveshr","followers_url":"https://api.github.com/users/shiveshr/followers","following_url":"https://api.github.com/users/shiveshr/following{/other_user}","gists_url":"https://api.github.com/users/shiveshr/gists{/gist_id}","starred_url":"https://api.github.com/users/shiveshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiveshr/subscriptions","organizations_url":"https://api.github.com/users/shiveshr/orgs","repos_url":"https://api.github.com/users/shiveshr/repos","events_url":"https://api.github.com/users/shiveshr/events{/privacy}","received_events_url":"https://api.github.com/users/shiveshr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pravega/pravega/pulls/1906/commits","review_comments_url":"https://api.github.com/repos/pravega/pravega/pulls/1906/comments","review_comment_url":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pravega/pravega/issues/1906/comments","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/55738acb665a8e4ebd740629feb467756736e3f1","head":{"label":"Prabha-Veerubhotla:docker-framework","ref":"docker-framework","sha":"55738acb665a8e4ebd740629feb467756736e3f1","user":{"login":"Prabha-Veerubhotla","id":20699674,"avatar_url":"https://avatars2.githubusercontent.com/u/20699674?v=4","gravatar_id":"","url":"https://api.github.com/users/Prabha-Veerubhotla","html_url":"https://github.com/Prabha-Veerubhotla","followers_url":"https://api.github.com/users/Prabha-Veerubhotla/followers","following_url":"https://api.github.com/users/Prabha-Veerubhotla/following{/other_user}","gists_url":"https://api.github.com/users/Prabha-Veerubhotla/gists{/gist_id}","starred_url":"https://api.github.com/users/Prabha-Veerubhotla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prabha-Veerubhotla/subscriptions","organizations_url":"https://api.github.com/users/Prabha-Veerubhotla/orgs","repos_url":"https://api.github.com/users/Prabha-Veerubhotla/repos","events_url":"https://api.github.com/users/Prabha-Veerubhotla/events{/privacy}","received_events_url":"https://api.github.com/users/Prabha-Veerubhotla/received_events","type":"User","site_admin":false},"repo":{"id":91452574,"name":"pravega","full_name":"Prabha-Veerubhotla/pravega","owner":{"login":"Prabha-Veerubhotla","id":20699674,"avatar_url":"https://avatars2.githubusercontent.com/u/20699674?v=4","gravatar_id":"","url":"https://api.github.com/users/Prabha-Veerubhotla","html_url":"https://github.com/Prabha-Veerubhotla","followers_url":"https://api.github.com/users/Prabha-Veerubhotla/followers","following_url":"https://api.github.com/users/Prabha-Veerubhotla/following{/other_user}","gists_url":"https://api.github.com/users/Prabha-Veerubhotla/gists{/gist_id}","starred_url":"https://api.github.com/users/Prabha-Veerubhotla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Prabha-Veerubhotla/subscriptions","organizations_url":"https://api.github.com/users/Prabha-Veerubhotla/orgs","repos_url":"https://api.github.com/users/Prabha-Veerubhotla/repos","events_url":"https://api.github.com/users/Prabha-Veerubhotla/events{/privacy}","received_events_url":"https://api.github.com/users/Prabha-Veerubhotla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Prabha-Veerubhotla/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":true,"url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega","forks_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/forks","keys_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/teams","hooks_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/hooks","issue_events_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/events","assignees_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/tags","blobs_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/languages","stargazers_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/stargazers","contributors_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/contributors","subscribers_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/subscribers","subscription_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/subscription","commits_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/merges","archive_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/downloads","issues_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/labels{/name}","releases_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/Prabha-Veerubhotla/pravega/deployments","created_at":"2017-05-16T11:52:33Z","updated_at":"2017-05-16T11:52:37Z","pushed_at":"2017-10-12T11:33:14Z","git_url":"git://github.com/Prabha-Veerubhotla/pravega.git","ssh_url":"git@github.com:Prabha-Veerubhotla/pravega.git","clone_url":"https://github.com/Prabha-Veerubhotla/pravega.git","svn_url":"https://github.com/Prabha-Veerubhotla/pravega","homepage":"http://pravega.io","size":20517,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pravega:master","ref":"master","sha":"fea6192c9eb80ff98a3b9118989d29865ae46d78","user":{"login":"pravega","id":25698199,"avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"repo":{"id":63096822,"name":"pravega","full_name":"pravega/pravega","owner":{"login":"pravega","id":25698199,"avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pravega/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":false,"url":"https://api.github.com/repos/pravega/pravega","forks_url":"https://api.github.com/repos/pravega/pravega/forks","keys_url":"https://api.github.com/repos/pravega/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pravega/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pravega/pravega/teams","hooks_url":"https://api.github.com/repos/pravega/pravega/hooks","issue_events_url":"https://api.github.com/repos/pravega/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/pravega/pravega/events","assignees_url":"https://api.github.com/repos/pravega/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/pravega/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/pravega/pravega/tags","blobs_url":"https://api.github.com/repos/pravega/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pravega/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pravega/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/pravega/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/pravega/pravega/languages","stargazers_url":"https://api.github.com/repos/pravega/pravega/stargazers","contributors_url":"https://api.github.com/repos/pravega/pravega/contributors","subscribers_url":"https://api.github.com/repos/pravega/pravega/subscribers","subscription_url":"https://api.github.com/repos/pravega/pravega/subscription","commits_url":"https://api.github.com/repos/pravega/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/pravega/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/pravega/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/pravega/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/pravega/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/pravega/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pravega/pravega/merges","archive_url":"https://api.github.com/repos/pravega/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pravega/pravega/downloads","issues_url":"https://api.github.com/repos/pravega/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/pravega/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/pravega/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/pravega/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pravega/pravega/labels{/name}","releases_url":"https://api.github.com/repos/pravega/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/pravega/pravega/deployments","created_at":"2016-07-11T19:41:03Z","updated_at":"2017-10-10T11:27:07Z","pushed_at":"2017-10-14T00:13:00Z","git_url":"git://github.com/pravega/pravega.git","ssh_url":"git@github.com:pravega/pravega.git","clone_url":"https://github.com/pravega/pravega.git","svn_url":"https://github.com/pravega/pravega","homepage":"http://pravega.io","size":20906,"stargazers_count":115,"watchers_count":115,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":298,"forks":47,"open_issues":298,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/1906"},"html":{"href":"https://github.com/pravega/pravega/pull/1906"},"issue":{"href":"https://api.github.com/repos/pravega/pravega/issues/1906"},"comments":{"href":"https://api.github.com/repos/pravega/pravega/issues/1906/comments"},"review_comments":{"href":"https://api.github.com/repos/pravega/pravega/pulls/1906/comments"},"review_comment":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pravega/pravega/pulls/1906/commits"},"statuses":{"href":"https://api.github.com/repos/pravega/pravega/statuses/55738acb665a8e4ebd740629feb467756736e3f1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tkaitchuck"}}