{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/community/pulls/comments/95112192","pull_request_review_id":15655175,"id":95112192,"diff_hunk":"@@ -0,0 +1,64 @@\n+# Initial networking for VMs using pod NICs\n+\n+Author: Fabian Deutsch \\<fabiand@redhat.com\\>\n+\n+## Introduction\n+\n+VMs need network connectivity. This proposal is about a first start in this direction.\n+\n+The working assumption is that libvirtd is running with a host-view, thus in the host's\n+network namespace.\n+On the other hand we want to connect VMs to the NIC(s) of the pod in which they are running.\n+\n+To keep it simple and work with what we have today, we just handle a single NIC (thus multiple should\n+not make a difference).\n+\n+Another benefit of this proposal is that we will connect to the veth of the pod - thus all the networking infrastructure beyong this point is not relevant to us. Which means we are independnt of it for now. It could be delivered by weave, flannel, or something else.","path":"design-proposals/initial-networking.md","position":16,"original_position":16,"commit_id":"6b20dcac9f19d63d25b4c1b5c55dd7adcbe55dd8","original_commit_id":"6b20dcac9f19d63d25b4c1b5c55dd7adcbe55dd8","user":{"login":"rmohr","id":4534621,"avatar_url":"https://avatars.githubusercontent.com/u/4534621?v=3","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},"body":"Note that his implementation would be would be limited to solutions which use veth pairs. It is also possible to attach a macvlan to a host device and then directly move it into another namespace without veths between.","created_at":"2017-01-09T08:08:20Z","updated_at":"2017-01-09T08:22:22Z","html_url":"https://github.com/kubevirt/community/pull/1#discussion_r95112192","pull_request_url":"https://api.github.com/repos/kubevirt/community/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/community/pulls/comments/95112192"},"html":{"href":"https://github.com/kubevirt/community/pull/1#discussion_r95112192"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/community/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/community/pulls/1","id":100281037,"html_url":"https://github.com/kubevirt/community/pull/1","diff_url":"https://github.com/kubevirt/community/pull/1.diff","patch_url":"https://github.com/kubevirt/community/pull/1.patch","issue_url":"https://api.github.com/repos/kubevirt/community/issues/1","number":1,"state":"open","locked":false,"title":"Proposal: Initial networking","user":{"login":"fabiand","id":83456,"avatar_url":"https://avatars.githubusercontent.com/u/83456?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiand","html_url":"https://github.com/fabiand","followers_url":"https://api.github.com/users/fabiand/followers","following_url":"https://api.github.com/users/fabiand/following{/other_user}","gists_url":"https://api.github.com/users/fabiand/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiand/subscriptions","organizations_url":"https://api.github.com/users/fabiand/orgs","repos_url":"https://api.github.com/users/fabiand/repos","events_url":"https://api.github.com/users/fabiand/events{/privacy}","received_events_url":"https://api.github.com/users/fabiand/received_events","type":"User","site_admin":false},"body":"Proposal of how to do the initial VM networking.","created_at":"2017-01-05T12:19:20Z","updated_at":"2017-01-09T08:22:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ebb06b93e29cc58068559ee061c58ac49f4e3ff","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/community/pulls/1/commits","review_comments_url":"https://api.github.com/repos/kubevirt/community/pulls/1/comments","review_comment_url":"https://api.github.com/repos/kubevirt/community/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/community/issues/1/comments","statuses_url":"https://api.github.com/repos/kubevirt/community/statuses/6b20dcac9f19d63d25b4c1b5c55dd7adcbe55dd8","head":{"label":"fabiand:initial-networking","ref":"initial-networking","sha":"6b20dcac9f19d63d25b4c1b5c55dd7adcbe55dd8","user":{"login":"fabiand","id":83456,"avatar_url":"https://avatars.githubusercontent.com/u/83456?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiand","html_url":"https://github.com/fabiand","followers_url":"https://api.github.com/users/fabiand/followers","following_url":"https://api.github.com/users/fabiand/following{/other_user}","gists_url":"https://api.github.com/users/fabiand/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiand/subscriptions","organizations_url":"https://api.github.com/users/fabiand/orgs","repos_url":"https://api.github.com/users/fabiand/repos","events_url":"https://api.github.com/users/fabiand/events{/privacy}","received_events_url":"https://api.github.com/users/fabiand/received_events","type":"User","site_admin":false},"repo":{"id":78110303,"name":"kubevirt-community","full_name":"fabiand/kubevirt-community","owner":{"login":"fabiand","id":83456,"avatar_url":"https://avatars.githubusercontent.com/u/83456?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiand","html_url":"https://github.com/fabiand","followers_url":"https://api.github.com/users/fabiand/followers","following_url":"https://api.github.com/users/fabiand/following{/other_user}","gists_url":"https://api.github.com/users/fabiand/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiand/subscriptions","organizations_url":"https://api.github.com/users/fabiand/orgs","repos_url":"https://api.github.com/users/fabiand/repos","events_url":"https://api.github.com/users/fabiand/events{/privacy}","received_events_url":"https://api.github.com/users/fabiand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabiand/kubevirt-community","description":"Community content","fork":true,"url":"https://api.github.com/repos/fabiand/kubevirt-community","forks_url":"https://api.github.com/repos/fabiand/kubevirt-community/forks","keys_url":"https://api.github.com/repos/fabiand/kubevirt-community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabiand/kubevirt-community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabiand/kubevirt-community/teams","hooks_url":"https://api.github.com/repos/fabiand/kubevirt-community/hooks","issue_events_url":"https://api.github.com/repos/fabiand/kubevirt-community/issues/events{/number}","events_url":"https://api.github.com/repos/fabiand/kubevirt-community/events","assignees_url":"https://api.github.com/repos/fabiand/kubevirt-community/assignees{/user}","branches_url":"https://api.github.com/repos/fabiand/kubevirt-community/branches{/branch}","tags_url":"https://api.github.com/repos/fabiand/kubevirt-community/tags","blobs_url":"https://api.github.com/repos/fabiand/kubevirt-community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabiand/kubevirt-community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabiand/kubevirt-community/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabiand/kubevirt-community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabiand/kubevirt-community/statuses/{sha}","languages_url":"https://api.github.com/repos/fabiand/kubevirt-community/languages","stargazers_url":"https://api.github.com/repos/fabiand/kubevirt-community/stargazers","contributors_url":"https://api.github.com/repos/fabiand/kubevirt-community/contributors","subscribers_url":"https://api.github.com/repos/fabiand/kubevirt-community/subscribers","subscription_url":"https://api.github.com/repos/fabiand/kubevirt-community/subscription","commits_url":"https://api.github.com/repos/fabiand/kubevirt-community/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabiand/kubevirt-community/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabiand/kubevirt-community/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabiand/kubevirt-community/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabiand/kubevirt-community/contents/{+path}","compare_url":"https://api.github.com/repos/fabiand/kubevirt-community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabiand/kubevirt-community/merges","archive_url":"https://api.github.com/repos/fabiand/kubevirt-community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabiand/kubevirt-community/downloads","issues_url":"https://api.github.com/repos/fabiand/kubevirt-community/issues{/number}","pulls_url":"https://api.github.com/repos/fabiand/kubevirt-community/pulls{/number}","milestones_url":"https://api.github.com/repos/fabiand/kubevirt-community/milestones{/number}","notifications_url":"https://api.github.com/repos/fabiand/kubevirt-community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabiand/kubevirt-community/labels{/name}","releases_url":"https://api.github.com/repos/fabiand/kubevirt-community/releases{/id}","deployments_url":"https://api.github.com/repos/fabiand/kubevirt-community/deployments","created_at":"2017-01-05T12:16:50Z","updated_at":"2017-01-05T12:17:05Z","pushed_at":"2017-01-05T12:44:45Z","git_url":"git://github.com/fabiand/kubevirt-community.git","ssh_url":"git@github.com:fabiand/kubevirt-community.git","clone_url":"https://github.com/fabiand/kubevirt-community.git","svn_url":"https://github.com/fabiand/kubevirt-community","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:master","ref":"master","sha":"beb268f633c0574f47c32c45b7a751fab7d86917","user":{"login":"kubevirt","id":18700703,"avatar_url":"https://avatars.githubusercontent.com/u/18700703?v=3","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":76551371,"name":"community","full_name":"kubevirt/community","owner":{"login":"kubevirt","id":18700703,"avatar_url":"https://avatars.githubusercontent.com/u/18700703?v=3","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubevirt/community","description":"Community content","fork":false,"url":"https://api.github.com/repos/kubevirt/community","forks_url":"https://api.github.com/repos/kubevirt/community/forks","keys_url":"https://api.github.com/repos/kubevirt/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/community/teams","hooks_url":"https://api.github.com/repos/kubevirt/community/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/community/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/community/events","assignees_url":"https://api.github.com/repos/kubevirt/community/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/community/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/community/tags","blobs_url":"https://api.github.com/repos/kubevirt/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/community/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/community/languages","stargazers_url":"https://api.github.com/repos/kubevirt/community/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/community/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/community/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/community/subscription","commits_url":"https://api.github.com/repos/kubevirt/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/community/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/community/merges","archive_url":"https://api.github.com/repos/kubevirt/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/community/downloads","issues_url":"https://api.github.com/repos/kubevirt/community/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/community/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/community/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/community/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/community/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/community/deployments","created_at":"2016-12-15T10:49:16Z","updated_at":"2016-12-15T10:49:16Z","pushed_at":"2017-01-05T12:44:46Z","git_url":"git://github.com/kubevirt/community.git","ssh_url":"git@github.com:kubevirt/community.git","clone_url":"https://github.com/kubevirt/community.git","svn_url":"https://github.com/kubevirt/community","homepage":null,"size":9,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/community/pulls/1"},"html":{"href":"https://github.com/kubevirt/community/pull/1"},"issue":{"href":"https://api.github.com/repos/kubevirt/community/issues/1"},"comments":{"href":"https://api.github.com/repos/kubevirt/community/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/community/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/community/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/community/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/community/statuses/6b20dcac9f19d63d25b4c1b5c55dd7adcbe55dd8"}}}}
{"actor":{"display_login":"rmohr"}}