{"action":"created","comment":{"url":"https://api.github.com/repos/doganyazar/pundunjs/pulls/comments/102821639","pull_request_review_id":23590731,"id":102821639,"diff_hunk":"@@ -14,7 +14,20 @@ class Transport {\n \n   connect(cb) {\n     return this._openSocket().then(() => this._authenticate()).then(() => {\n-      this.socket.on('data', cb)\n+      var buffers = []\n+      var rem, len\n+      this.socket.on('data', (chunk) => {","path":"lib/transport.js","position":7,"original_position":7,"commit_id":"042fb464432ad55d7644d51d4112bd712eca41e8","original_commit_id":"042fb464432ad55d7644d51d4112bd712eca41e8","user":{"login":"erdemaksu","id":9436836,"avatar_url":"https://avatars.githubusercontent.com/u/9436836?v=3","gravatar_id":"","url":"https://api.github.com/users/erdemaksu","html_url":"https://github.com/erdemaksu","followers_url":"https://api.github.com/users/erdemaksu/followers","following_url":"https://api.github.com/users/erdemaksu/following{/other_user}","gists_url":"https://api.github.com/users/erdemaksu/gists{/gist_id}","starred_url":"https://api.github.com/users/erdemaksu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erdemaksu/subscriptions","organizations_url":"https://api.github.com/users/erdemaksu/orgs","repos_url":"https://api.github.com/users/erdemaksu/repos","events_url":"https://api.github.com/users/erdemaksu/events{/privacy}","received_events_url":"https://api.github.com/users/erdemaksu/received_events","type":"User","site_admin":false},"body":"I'll keep length header at transport level. Proprietary wire protocol and Apollo protocol will be handled on higher level. ","created_at":"2017-02-23T21:23:58Z","updated_at":"2017-02-23T21:23:58Z","html_url":"https://github.com/doganyazar/pundunjs/pull/2#discussion_r102821639","pull_request_url":"https://api.github.com/repos/doganyazar/pundunjs/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/doganyazar/pundunjs/pulls/comments/102821639"},"html":{"href":"https://github.com/doganyazar/pundunjs/pull/2#discussion_r102821639"},"pull_request":{"href":"https://api.github.com/repos/doganyazar/pundunjs/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/doganyazar/pundunjs/pulls/2","id":107663882,"html_url":"https://github.com/doganyazar/pundunjs/pull/2","diff_url":"https://github.com/doganyazar/pundunjs/pull/2.diff","patch_url":"https://github.com/doganyazar/pundunjs/pull/2.patch","issue_url":"https://api.github.com/repos/doganyazar/pundunjs/issues/2","number":2,"state":"open","locked":false,"title":"Handle fragmented packets from tcp socket.","user":{"login":"erdemaksu","id":9436836,"avatar_url":"https://avatars.githubusercontent.com/u/9436836?v=3","gravatar_id":"","url":"https://api.github.com/users/erdemaksu","html_url":"https://github.com/erdemaksu","followers_url":"https://api.github.com/users/erdemaksu/followers","following_url":"https://api.github.com/users/erdemaksu/following{/other_user}","gists_url":"https://api.github.com/users/erdemaksu/gists{/gist_id}","starred_url":"https://api.github.com/users/erdemaksu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erdemaksu/subscriptions","organizations_url":"https://api.github.com/users/erdemaksu/orgs","repos_url":"https://api.github.com/users/erdemaksu/repos","events_url":"https://api.github.com/users/erdemaksu/events{/privacy}","received_events_url":"https://api.github.com/users/erdemaksu/received_events","type":"User","site_admin":false},"body":"Use the length information to count the received bytes and relay complete packets to call back function.","created_at":"2017-02-23T16:43:51Z","updated_at":"2017-02-23T21:23:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c1c87e68176d8275c694755d0924d2140adf4b1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/doganyazar/pundunjs/pulls/2/commits","review_comments_url":"https://api.github.com/repos/doganyazar/pundunjs/pulls/2/comments","review_comment_url":"https://api.github.com/repos/doganyazar/pundunjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doganyazar/pundunjs/issues/2/comments","statuses_url":"https://api.github.com/repos/doganyazar/pundunjs/statuses/042fb464432ad55d7644d51d4112bd712eca41e8","head":{"label":"pundunlabs:dev.fix.socket_read","ref":"dev.fix.socket_read","sha":"042fb464432ad55d7644d51d4112bd712eca41e8","user":{"login":"pundunlabs","id":12515813,"avatar_url":"https://avatars.githubusercontent.com/u/12515813?v=3","gravatar_id":"","url":"https://api.github.com/users/pundunlabs","html_url":"https://github.com/pundunlabs","followers_url":"https://api.github.com/users/pundunlabs/followers","following_url":"https://api.github.com/users/pundunlabs/following{/other_user}","gists_url":"https://api.github.com/users/pundunlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/pundunlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pundunlabs/subscriptions","organizations_url":"https://api.github.com/users/pundunlabs/orgs","repos_url":"https://api.github.com/users/pundunlabs/repos","events_url":"https://api.github.com/users/pundunlabs/events{/privacy}","received_events_url":"https://api.github.com/users/pundunlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":81571894,"name":"pundunjs","full_name":"pundunlabs/pundunjs","owner":{"login":"pundunlabs","id":12515813,"avatar_url":"https://avatars.githubusercontent.com/u/12515813?v=3","gravatar_id":"","url":"https://api.github.com/users/pundunlabs","html_url":"https://github.com/pundunlabs","followers_url":"https://api.github.com/users/pundunlabs/followers","following_url":"https://api.github.com/users/pundunlabs/following{/other_user}","gists_url":"https://api.github.com/users/pundunlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/pundunlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pundunlabs/subscriptions","organizations_url":"https://api.github.com/users/pundunlabs/orgs","repos_url":"https://api.github.com/users/pundunlabs/repos","events_url":"https://api.github.com/users/pundunlabs/events{/privacy}","received_events_url":"https://api.github.com/users/pundunlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pundunlabs/pundunjs","description":"Node.js client for pundun DB","fork":true,"url":"https://api.github.com/repos/pundunlabs/pundunjs","forks_url":"https://api.github.com/repos/pundunlabs/pundunjs/forks","keys_url":"https://api.github.com/repos/pundunlabs/pundunjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pundunlabs/pundunjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pundunlabs/pundunjs/teams","hooks_url":"https://api.github.com/repos/pundunlabs/pundunjs/hooks","issue_events_url":"https://api.github.com/repos/pundunlabs/pundunjs/issues/events{/number}","events_url":"https://api.github.com/repos/pundunlabs/pundunjs/events","assignees_url":"https://api.github.com/repos/pundunlabs/pundunjs/assignees{/user}","branches_url":"https://api.github.com/repos/pundunlabs/pundunjs/branches{/branch}","tags_url":"https://api.github.com/repos/pundunlabs/pundunjs/tags","blobs_url":"https://api.github.com/repos/pundunlabs/pundunjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pundunlabs/pundunjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pundunlabs/pundunjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/pundunlabs/pundunjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pundunlabs/pundunjs/statuses/{sha}","languages_url":"https://api.github.com/repos/pundunlabs/pundunjs/languages","stargazers_url":"https://api.github.com/repos/pundunlabs/pundunjs/stargazers","contributors_url":"https://api.github.com/repos/pundunlabs/pundunjs/contributors","subscribers_url":"https://api.github.com/repos/pundunlabs/pundunjs/subscribers","subscription_url":"https://api.github.com/repos/pundunlabs/pundunjs/subscription","commits_url":"https://api.github.com/repos/pundunlabs/pundunjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/pundunlabs/pundunjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/pundunlabs/pundunjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/pundunlabs/pundunjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/pundunlabs/pundunjs/contents/{+path}","compare_url":"https://api.github.com/repos/pundunlabs/pundunjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pundunlabs/pundunjs/merges","archive_url":"https://api.github.com/repos/pundunlabs/pundunjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pundunlabs/pundunjs/downloads","issues_url":"https://api.github.com/repos/pundunlabs/pundunjs/issues{/number}","pulls_url":"https://api.github.com/repos/pundunlabs/pundunjs/pulls{/number}","milestones_url":"https://api.github.com/repos/pundunlabs/pundunjs/milestones{/number}","notifications_url":"https://api.github.com/repos/pundunlabs/pundunjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pundunlabs/pundunjs/labels{/name}","releases_url":"https://api.github.com/repos/pundunlabs/pundunjs/releases{/id}","deployments_url":"https://api.github.com/repos/pundunlabs/pundunjs/deployments","created_at":"2017-02-10T14:16:37Z","updated_at":"2017-02-10T14:16:39Z","pushed_at":"2017-02-23T16:43:08Z","git_url":"git://github.com/pundunlabs/pundunjs.git","ssh_url":"git@github.com:pundunlabs/pundunjs.git","clone_url":"https://github.com/pundunlabs/pundunjs.git","svn_url":"https://github.com/pundunlabs/pundunjs","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doganyazar:master","ref":"master","sha":"57c9598ca79f45b9926c2d6a9891cfe5bb7c3317","user":{"login":"doganyazar","id":1618686,"avatar_url":"https://avatars.githubusercontent.com/u/1618686?v=3","gravatar_id":"","url":"https://api.github.com/users/doganyazar","html_url":"https://github.com/doganyazar","followers_url":"https://api.github.com/users/doganyazar/followers","following_url":"https://api.github.com/users/doganyazar/following{/other_user}","gists_url":"https://api.github.com/users/doganyazar/gists{/gist_id}","starred_url":"https://api.github.com/users/doganyazar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doganyazar/subscriptions","organizations_url":"https://api.github.com/users/doganyazar/orgs","repos_url":"https://api.github.com/users/doganyazar/repos","events_url":"https://api.github.com/users/doganyazar/events{/privacy}","received_events_url":"https://api.github.com/users/doganyazar/received_events","type":"User","site_admin":false},"repo":{"id":79516109,"name":"pundunjs","full_name":"doganyazar/pundunjs","owner":{"login":"doganyazar","id":1618686,"avatar_url":"https://avatars.githubusercontent.com/u/1618686?v=3","gravatar_id":"","url":"https://api.github.com/users/doganyazar","html_url":"https://github.com/doganyazar","followers_url":"https://api.github.com/users/doganyazar/followers","following_url":"https://api.github.com/users/doganyazar/following{/other_user}","gists_url":"https://api.github.com/users/doganyazar/gists{/gist_id}","starred_url":"https://api.github.com/users/doganyazar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doganyazar/subscriptions","organizations_url":"https://api.github.com/users/doganyazar/orgs","repos_url":"https://api.github.com/users/doganyazar/repos","events_url":"https://api.github.com/users/doganyazar/events{/privacy}","received_events_url":"https://api.github.com/users/doganyazar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/doganyazar/pundunjs","description":"Node.js client for pundun DB","fork":false,"url":"https://api.github.com/repos/doganyazar/pundunjs","forks_url":"https://api.github.com/repos/doganyazar/pundunjs/forks","keys_url":"https://api.github.com/repos/doganyazar/pundunjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doganyazar/pundunjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doganyazar/pundunjs/teams","hooks_url":"https://api.github.com/repos/doganyazar/pundunjs/hooks","issue_events_url":"https://api.github.com/repos/doganyazar/pundunjs/issues/events{/number}","events_url":"https://api.github.com/repos/doganyazar/pundunjs/events","assignees_url":"https://api.github.com/repos/doganyazar/pundunjs/assignees{/user}","branches_url":"https://api.github.com/repos/doganyazar/pundunjs/branches{/branch}","tags_url":"https://api.github.com/repos/doganyazar/pundunjs/tags","blobs_url":"https://api.github.com/repos/doganyazar/pundunjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doganyazar/pundunjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doganyazar/pundunjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/doganyazar/pundunjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doganyazar/pundunjs/statuses/{sha}","languages_url":"https://api.github.com/repos/doganyazar/pundunjs/languages","stargazers_url":"https://api.github.com/repos/doganyazar/pundunjs/stargazers","contributors_url":"https://api.github.com/repos/doganyazar/pundunjs/contributors","subscribers_url":"https://api.github.com/repos/doganyazar/pundunjs/subscribers","subscription_url":"https://api.github.com/repos/doganyazar/pundunjs/subscription","commits_url":"https://api.github.com/repos/doganyazar/pundunjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/doganyazar/pundunjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/doganyazar/pundunjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/doganyazar/pundunjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/doganyazar/pundunjs/contents/{+path}","compare_url":"https://api.github.com/repos/doganyazar/pundunjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doganyazar/pundunjs/merges","archive_url":"https://api.github.com/repos/doganyazar/pundunjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doganyazar/pundunjs/downloads","issues_url":"https://api.github.com/repos/doganyazar/pundunjs/issues{/number}","pulls_url":"https://api.github.com/repos/doganyazar/pundunjs/pulls{/number}","milestones_url":"https://api.github.com/repos/doganyazar/pundunjs/milestones{/number}","notifications_url":"https://api.github.com/repos/doganyazar/pundunjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doganyazar/pundunjs/labels{/name}","releases_url":"https://api.github.com/repos/doganyazar/pundunjs/releases{/id}","deployments_url":"https://api.github.com/repos/doganyazar/pundunjs/deployments","created_at":"2017-01-20T02:12:34Z","updated_at":"2017-01-21T15:41:22Z","pushed_at":"2017-02-23T16:43:51Z","git_url":"git://github.com/doganyazar/pundunjs.git","ssh_url":"git@github.com:doganyazar/pundunjs.git","clone_url":"https://github.com/doganyazar/pundunjs.git","svn_url":"https://github.com/doganyazar/pundunjs","homepage":null,"size":16,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doganyazar/pundunjs/pulls/2"},"html":{"href":"https://github.com/doganyazar/pundunjs/pull/2"},"issue":{"href":"https://api.github.com/repos/doganyazar/pundunjs/issues/2"},"comments":{"href":"https://api.github.com/repos/doganyazar/pundunjs/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/doganyazar/pundunjs/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/doganyazar/pundunjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doganyazar/pundunjs/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/doganyazar/pundunjs/statuses/042fb464432ad55d7644d51d4112bd712eca41e8"}}}}
{"actor":{"display_login":"erdemaksu"}}