{"action":"created","issue":{"url":"https://api.github.com/repos/singularityware/singularity/issues/1114","repository_url":"https://api.github.com/repos/singularityware/singularity","labels_url":"https://api.github.com/repos/singularityware/singularity/issues/1114/labels{/name}","comments_url":"https://api.github.com/repos/singularityware/singularity/issues/1114/comments","events_url":"https://api.github.com/repos/singularityware/singularity/issues/1114/events","html_url":"https://github.com/singularityware/singularity/pull/1114","id":269301648,"number":1114,"title":"Debian squashfs-tools dependency","user":{"login":"dexter2cz","id":13104459,"avatar_url":"https://avatars3.githubusercontent.com/u/13104459?v=4","gravatar_id":"","url":"https://api.github.com/users/dexter2cz","html_url":"https://github.com/dexter2cz","followers_url":"https://api.github.com/users/dexter2cz/followers","following_url":"https://api.github.com/users/dexter2cz/following{/other_user}","gists_url":"https://api.github.com/users/dexter2cz/gists{/gist_id}","starred_url":"https://api.github.com/users/dexter2cz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dexter2cz/subscriptions","organizations_url":"https://api.github.com/users/dexter2cz/orgs","repos_url":"https://api.github.com/users/dexter2cz/repos","events_url":"https://api.github.com/users/dexter2cz/events{/privacy}","received_events_url":"https://api.github.com/users/dexter2cz/received_events","type":"User","site_admin":false},"labels":[{"id":271060103,"url":"https://api.github.com/repos/singularityware/singularity/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-10-28T09:45:44Z","updated_at":"2017-11-01T21:21:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/singularityware/singularity/pulls/1114","html_url":"https://github.com/singularityware/singularity/pull/1114","diff_url":"https://github.com/singularityware/singularity/pull/1114.diff","patch_url":"https://github.com/singularityware/singularity/pull/1114.patch"},"body":"**Description of the Pull Request (PR):**\r\n\r\nAdded squashfs-tools as debian dependency\r\n\r\n**This fixes or addresses the following GitHub issues:**\r\n\r\n- Ref: #1090\r\n\r\n\r\n**Checkoff for all PRs:**\r\n\r\n- [ ] I have read the [Guidelines for Contributing](https://github.com/singularityware/singularity/blob/master/CONTRIBUTING.md), and this PR conforms to the stated requirements.\r\n- [ ] I have tested this PR locally with a `make test`\r\n- [x] This PR is NOT against the project's master branch\r\n- [ ] I have added myself as a contributor to the [contributors's file](https://github.com/singularityware/singularity/blob/master/CONTRIBUTORS.md)\r\n- [x] This PR is ready for review and/or merge\r\n\r\n\r\nAttn: @singularityware-admin @yarikoptic \r\n"},"comment":{"url":"https://api.github.com/repos/singularityware/singularity/issues/comments/341246658","html_url":"https://github.com/singularityware/singularity/pull/1114#issuecomment-341246658","issue_url":"https://api.github.com/repos/singularityware/singularity/issues/1114","id":341246658,"user":{"login":"olifre","id":166759,"avatar_url":"https://avatars0.githubusercontent.com/u/166759?v=4","gravatar_id":"","url":"https://api.github.com/users/olifre","html_url":"https://github.com/olifre","followers_url":"https://api.github.com/users/olifre/followers","following_url":"https://api.github.com/users/olifre/following{/other_user}","gists_url":"https://api.github.com/users/olifre/gists{/gist_id}","starred_url":"https://api.github.com/users/olifre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olifre/subscriptions","organizations_url":"https://api.github.com/users/olifre/orgs","repos_url":"https://api.github.com/users/olifre/repos","events_url":"https://api.github.com/users/olifre/events{/privacy}","received_events_url":"https://api.github.com/users/olifre/received_events","type":"User","site_admin":false},"created_at":"2017-11-01T21:21:00Z","updated_at":"2017-11-01T21:21:00Z","author_association":"CONTRIBUTOR","body":"@vsoch I did not add the changelog, I only complained when it was not updated with the last release, and added a line to the release checklist to keep it updated ;-). \r\nAs you can see from #1057 , people appear to use the `debian/` files within this repo to build packages. \r\n\r\nI can only speak for us: We generally pull packaging code from a distro (e.g. debian) and base our build to roll out on our cluster and desktops on their packaging (we do our on packaging for some things to have better control over \"when updates are rolled out\" and have updates in-sync between RedHat and Debian). \r\nOn the other hand, if the packaging code in the project is well maintained and updated (e.g. with new dependencies), this allows both the distro to base their initial packaging on it, and allows users to base their packaging on it. \r\nSo I'd think it's nice to have packaging code \"someplace singularity maintained\" to give all distros and users a good starting point. It's also a clean place to document new dependencies, and would allow you to offer independently built deb's and rpm's easily, if you decide to do that. \r\n\r\nOf course, if there is someone within the singularity team who has a short turnaround time to contribute directly to debian ( @yarikoptic ?) and feels detecting new dependencies is possible without maintained packaging code directly in Singularity, that's fine with me. Then I'll keep looking at official debian packaging and pull from there. \r\n\r\nMaybe, in this context, I should also mention https://github.com/singularityware/singularity/pull/1093 which still has entered neither the singularity packaging code nor debian. "}}
{"actor":{"display_login":"olifre"}}