{"action":"opened","number":19289,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/19289","id":126038863,"html_url":"https://github.com/cms-sw/cmssw/pull/19289","diff_url":"https://github.com/cms-sw/cmssw/pull/19289.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/19289.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19289","number":19289,"state":"open","locked":false,"title":"Fix includes in DigiCollectionProfiler.h","user":{"login":"Teemperor","id":736001,"avatar_url":"https://avatars3.githubusercontent.com/u/736001?v=3","gravatar_id":"","url":"https://api.github.com/users/Teemperor","html_url":"https://github.com/Teemperor","followers_url":"https://api.github.com/users/Teemperor/followers","following_url":"https://api.github.com/users/Teemperor/following{/other_user}","gists_url":"https://api.github.com/users/Teemperor/gists{/gist_id}","starred_url":"https://api.github.com/users/Teemperor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teemperor/subscriptions","organizations_url":"https://api.github.com/users/Teemperor/orgs","repos_url":"https://api.github.com/users/Teemperor/repos","events_url":"https://api.github.com/users/Teemperor/events{/privacy}","received_events_url":"https://api.github.com/users/Teemperor/received_events","type":"User","site_admin":false},"body":"We replace the forward declarations of TH1F, TH2F and TProfile with\r\nactual includes as we call method from these classes in the lines\r\n87-89, so a forward declaration no longer guarantees that this\r\nheader compiles. The same goes for ParameterSet in line 56.\r\n\r\nFor SiStripCluster we add the proper include as we use it in line 146.","created_at":"2017-06-16T13:58:04Z","updated_at":"2017-06-16T13:58:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/19289/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/19289/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19289/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/b858901c8176d15592344aa62520ef5c6de62871","head":{"label":"Teemperor:FixIncludesDigiCollectionProfiler.h","ref":"FixIncludesDigiCollectionProfiler.h","sha":"b858901c8176d15592344aa62520ef5c6de62871","user":{"login":"Teemperor","id":736001,"avatar_url":"https://avatars3.githubusercontent.com/u/736001?v=3","gravatar_id":"","url":"https://api.github.com/users/Teemperor","html_url":"https://github.com/Teemperor","followers_url":"https://api.github.com/users/Teemperor/followers","following_url":"https://api.github.com/users/Teemperor/following{/other_user}","gists_url":"https://api.github.com/users/Teemperor/gists{/gist_id}","starred_url":"https://api.github.com/users/Teemperor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teemperor/subscriptions","organizations_url":"https://api.github.com/users/Teemperor/orgs","repos_url":"https://api.github.com/users/Teemperor/repos","events_url":"https://api.github.com/users/Teemperor/events{/privacy}","received_events_url":"https://api.github.com/users/Teemperor/received_events","type":"User","site_admin":false},"repo":{"id":85077068,"name":"cmssw","full_name":"Teemperor/cmssw","owner":{"login":"Teemperor","id":736001,"avatar_url":"https://avatars3.githubusercontent.com/u/736001?v=3","gravatar_id":"","url":"https://api.github.com/users/Teemperor","html_url":"https://github.com/Teemperor","followers_url":"https://api.github.com/users/Teemperor/followers","following_url":"https://api.github.com/users/Teemperor/following{/other_user}","gists_url":"https://api.github.com/users/Teemperor/gists{/gist_id}","starred_url":"https://api.github.com/users/Teemperor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teemperor/subscriptions","organizations_url":"https://api.github.com/users/Teemperor/orgs","repos_url":"https://api.github.com/users/Teemperor/repos","events_url":"https://api.github.com/users/Teemperor/events{/privacy}","received_events_url":"https://api.github.com/users/Teemperor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Teemperor/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/Teemperor/cmssw","forks_url":"https://api.github.com/repos/Teemperor/cmssw/forks","keys_url":"https://api.github.com/repos/Teemperor/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Teemperor/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Teemperor/cmssw/teams","hooks_url":"https://api.github.com/repos/Teemperor/cmssw/hooks","issue_events_url":"https://api.github.com/repos/Teemperor/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/Teemperor/cmssw/events","assignees_url":"https://api.github.com/repos/Teemperor/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/Teemperor/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/Teemperor/cmssw/tags","blobs_url":"https://api.github.com/repos/Teemperor/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Teemperor/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Teemperor/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/Teemperor/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Teemperor/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/Teemperor/cmssw/languages","stargazers_url":"https://api.github.com/repos/Teemperor/cmssw/stargazers","contributors_url":"https://api.github.com/repos/Teemperor/cmssw/contributors","subscribers_url":"https://api.github.com/repos/Teemperor/cmssw/subscribers","subscription_url":"https://api.github.com/repos/Teemperor/cmssw/subscription","commits_url":"https://api.github.com/repos/Teemperor/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/Teemperor/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/Teemperor/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/Teemperor/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/Teemperor/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/Teemperor/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Teemperor/cmssw/merges","archive_url":"https://api.github.com/repos/Teemperor/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Teemperor/cmssw/downloads","issues_url":"https://api.github.com/repos/Teemperor/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/Teemperor/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/Teemperor/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/Teemperor/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Teemperor/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/Teemperor/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/Teemperor/cmssw/deployments","created_at":"2017-03-15T13:41:23Z","updated_at":"2017-03-15T13:44:18Z","pushed_at":"2017-06-16T13:57:28Z","git_url":"git://github.com/Teemperor/cmssw.git","ssh_url":"git@github.com:Teemperor/cmssw.git","clone_url":"https://github.com/Teemperor/cmssw.git","svn_url":"https://github.com/Teemperor/cmssw","homepage":"http://cms-sw.github.io/","size":950973,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-sw:master","ref":"master","sha":"ede192338a35ee1a3ad7fb66196c5a00c99ef429","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars3.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars3.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2017-06-09T00:02:18Z","pushed_at":"2017-06-16T13:45:43Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":953180,"stargazers_count":421,"watchers_count":421,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2234,"mirror_url":null,"open_issues_count":385,"forks":2234,"open_issues":385,"watchers":421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/19289"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/19289"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/19289"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/19289/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/19289/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/19289/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/b858901c8176d15592344aa62520ef5c6de62871"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":5,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"Teemperor"}}