{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/154949038","pull_request_review_id":81184609,"id":154949038,"diff_hunk":"@@ -247,9 +256,11 @@ private void passivate() {\n \n   static//#supervisor\n   public class CounterSupervisor extends AbstractActor {\n+    public static final String ShardingTypeName = \"CounterSupervisor\";\n+    public static final Props props = Props.create(CounterSupervisor::new);\n \n     private final ActorRef counter = getContext().actorOf(\n-        Props.create(Counter.class), \"theCounter\");\n+            Counter.propsFactory.apply(\"theCounter\"), \"theCounter\");","path":"akka-docs/src/test/java/jdocs/sharding/ClusterShardingTest.java","position":92,"original_position":92,"commit_id":"ffa7cf78c667643f508f2cbd19f5f7986f841ccf","original_commit_id":"ffa7cf78c667643f508f2cbd19f5f7986f841ccf","user":{"login":"patriknw","id":336161,"avatar_url":"https://avatars3.githubusercontent.com/u/336161?v=4","gravatar_id":"","url":"https://api.github.com/users/patriknw","html_url":"https://github.com/patriknw","followers_url":"https://api.github.com/users/patriknw/followers","following_url":"https://api.github.com/users/patriknw/following{/other_user}","gists_url":"https://api.github.com/users/patriknw/gists{/gist_id}","starred_url":"https://api.github.com/users/patriknw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patriknw/subscriptions","organizations_url":"https://api.github.com/users/patriknw/orgs","repos_url":"https://api.github.com/users/patriknw/repos","events_url":"https://api.github.com/users/patriknw/events{/privacy}","received_events_url":"https://api.github.com/users/patriknw/received_events","type":"User","site_admin":false},"body":"this would be weird, entities would get the id \"theCounter\"\r\n\r\nThe `CounterSupervisor` should also get its id from the factory parameter and pass that to `Counter.props(entityId)` here.","created_at":"2017-12-05T13:49:13Z","updated_at":"2017-12-05T14:00:21Z","html_url":"https://github.com/akka/akka/pull/24058#discussion_r154949038","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/24058","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/154949038"},"html":{"href":"https://github.com/akka/akka/pull/24058#discussion_r154949038"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/24058"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/24058","id":154525446,"html_url":"https://github.com/akka/akka/pull/24058","diff_url":"https://github.com/akka/akka/pull/24058.diff","patch_url":"https://github.com/akka/akka/pull/24058.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/24058","number":24058,"state":"open","locked":false,"title":"Add entity id to sharding props (#24053)","user":{"login":"talpr","id":3009362,"avatar_url":"https://avatars1.githubusercontent.com/u/3009362?v=4","gravatar_id":"","url":"https://api.github.com/users/talpr","html_url":"https://github.com/talpr","followers_url":"https://api.github.com/users/talpr/followers","following_url":"https://api.github.com/users/talpr/following{/other_user}","gists_url":"https://api.github.com/users/talpr/gists{/gist_id}","starred_url":"https://api.github.com/users/talpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talpr/subscriptions","organizations_url":"https://api.github.com/users/talpr/orgs","repos_url":"https://api.github.com/users/talpr/repos","events_url":"https://api.github.com/users/talpr/events{/privacy}","received_events_url":"https://api.github.com/users/talpr/received_events","type":"User","site_admin":false},"body":"Add overloads for `ClusterSharding.start` that take function from entity id to props.\r\n\r\nI modified the tests that were included in the docs to use the id from props as well, let me know if you want me to revert that part...","created_at":"2017-11-24T11:14:12Z","updated_at":"2017-12-05T14:00:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d956b94c681d9d5a7b836806c264134cc7b52faf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/24058/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/24058/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/24058/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/ffa7cf78c667643f508f2cbd19f5f7986f841ccf","head":{"label":"talpr:talpr-24053-add-entity-id-to-sharding-props","ref":"talpr-24053-add-entity-id-to-sharding-props","sha":"ffa7cf78c667643f508f2cbd19f5f7986f841ccf","user":{"login":"talpr","id":3009362,"avatar_url":"https://avatars1.githubusercontent.com/u/3009362?v=4","gravatar_id":"","url":"https://api.github.com/users/talpr","html_url":"https://github.com/talpr","followers_url":"https://api.github.com/users/talpr/followers","following_url":"https://api.github.com/users/talpr/following{/other_user}","gists_url":"https://api.github.com/users/talpr/gists{/gist_id}","starred_url":"https://api.github.com/users/talpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talpr/subscriptions","organizations_url":"https://api.github.com/users/talpr/orgs","repos_url":"https://api.github.com/users/talpr/repos","events_url":"https://api.github.com/users/talpr/events{/privacy}","received_events_url":"https://api.github.com/users/talpr/received_events","type":"User","site_admin":false},"repo":{"id":76438831,"name":"akka","full_name":"talpr/akka","owner":{"login":"talpr","id":3009362,"avatar_url":"https://avatars1.githubusercontent.com/u/3009362?v=4","gravatar_id":"","url":"https://api.github.com/users/talpr","html_url":"https://github.com/talpr","followers_url":"https://api.github.com/users/talpr/followers","following_url":"https://api.github.com/users/talpr/following{/other_user}","gists_url":"https://api.github.com/users/talpr/gists{/gist_id}","starred_url":"https://api.github.com/users/talpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/talpr/subscriptions","organizations_url":"https://api.github.com/users/talpr/orgs","repos_url":"https://api.github.com/users/talpr/repos","events_url":"https://api.github.com/users/talpr/events{/privacy}","received_events_url":"https://api.github.com/users/talpr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/talpr/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/talpr/akka","forks_url":"https://api.github.com/repos/talpr/akka/forks","keys_url":"https://api.github.com/repos/talpr/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/talpr/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/talpr/akka/teams","hooks_url":"https://api.github.com/repos/talpr/akka/hooks","issue_events_url":"https://api.github.com/repos/talpr/akka/issues/events{/number}","events_url":"https://api.github.com/repos/talpr/akka/events","assignees_url":"https://api.github.com/repos/talpr/akka/assignees{/user}","branches_url":"https://api.github.com/repos/talpr/akka/branches{/branch}","tags_url":"https://api.github.com/repos/talpr/akka/tags","blobs_url":"https://api.github.com/repos/talpr/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/talpr/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/talpr/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/talpr/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/talpr/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/talpr/akka/languages","stargazers_url":"https://api.github.com/repos/talpr/akka/stargazers","contributors_url":"https://api.github.com/repos/talpr/akka/contributors","subscribers_url":"https://api.github.com/repos/talpr/akka/subscribers","subscription_url":"https://api.github.com/repos/talpr/akka/subscription","commits_url":"https://api.github.com/repos/talpr/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/talpr/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/talpr/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/talpr/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/talpr/akka/contents/{+path}","compare_url":"https://api.github.com/repos/talpr/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/talpr/akka/merges","archive_url":"https://api.github.com/repos/talpr/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/talpr/akka/downloads","issues_url":"https://api.github.com/repos/talpr/akka/issues{/number}","pulls_url":"https://api.github.com/repos/talpr/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/talpr/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/talpr/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/talpr/akka/labels{/name}","releases_url":"https://api.github.com/repos/talpr/akka/releases{/id}","deployments_url":"https://api.github.com/repos/talpr/akka/deployments","created_at":"2016-12-14T08:14:41Z","updated_at":"2016-12-14T08:14:53Z","pushed_at":"2017-12-05T11:10:56Z","git_url":"git://github.com/talpr/akka.git","ssh_url":"git@github.com:talpr/akka.git","clone_url":"https://github.com/talpr/akka.git","svn_url":"https://github.com/talpr/akka","homepage":"http://akka.io","size":202805,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"akka:master","ref":"master","sha":"dbad545803dd7b036ca201546d86585720432e4b","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars2.githubusercontent.com/u/1496237?v=4","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Build highly concurrent, distributed, and resilient message-driven applications on the JVM","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","deployments_url":"https://api.github.com/repos/akka/akka/deployments","created_at":"2009-02-16T12:51:54Z","updated_at":"2017-12-05T12:29:44Z","pushed_at":"2017-12-05T13:54:28Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":204704,"stargazers_count":7926,"watchers_count":7926,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2519,"mirror_url":null,"archived":false,"open_issues_count":610,"license":null,"forks":2519,"open_issues":610,"watchers":7926,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/24058"},"html":{"href":"https://github.com/akka/akka/pull/24058"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/24058"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/24058/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/24058/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/24058/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/ffa7cf78c667643f508f2cbd19f5f7986f841ccf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"patriknw"}}