{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/136383205","pull_request_review_id":59905888,"id":136383205,"diff_hunk":"@@ -425,6 +452,16 @@ func after() {\n \t\t}\n \t\tf.Close()\n \t}\n+\tif benchmarkResulrFile != \"\" {\n+\t\tf, err := os.Create(benchmarkResulrFile)\n+\t\tif err != nil {\n+\t\t\tfmt.Fprintf(os.Stderr, \"testing: %s\\n\", err)","path":"benchmark/benchmain/main.go","position":197,"original_position":197,"commit_id":"408fcc6679cce4938884acbf377b3e68edb7dabf","original_commit_id":"408fcc6679cce4938884acbf377b3e68edb7dabf","user":{"login":"dfawley","id":26072277,"avatar_url":"https://avatars1.githubusercontent.com/u/26072277?v=4","gravatar_id":"","url":"https://api.github.com/users/dfawley","html_url":"https://github.com/dfawley","followers_url":"https://api.github.com/users/dfawley/followers","following_url":"https://api.github.com/users/dfawley/following{/other_user}","gists_url":"https://api.github.com/users/dfawley/gists{/gist_id}","starred_url":"https://api.github.com/users/dfawley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfawley/subscriptions","organizations_url":"https://api.github.com/users/dfawley/orgs","repos_url":"https://api.github.com/users/dfawley/repos","events_url":"https://api.github.com/users/dfawley/events{/privacy}","received_events_url":"https://api.github.com/users/dfawley/received_events","type":"User","site_admin":false},"body":"log.Fatalf()","created_at":"2017-08-31T16:26:06Z","updated_at":"2017-08-31T16:29:29Z","html_url":"https://github.com/grpc/grpc-go/pull/1493#discussion_r136383205","pull_request_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1493","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments/136383205"},"html":{"href":"https://github.com/grpc/grpc-go/pull/1493#discussion_r136383205"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1493"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-go/pulls/1493","id":138309588,"html_url":"https://github.com/grpc/grpc-go/pull/1493","diff_url":"https://github.com/grpc/grpc-go/pull/1493.diff","patch_url":"https://github.com/grpc/grpc-go/pull/1493.patch","issue_url":"https://api.github.com/repos/grpc/grpc-go/issues/1493","number":1493,"state":"open","locked":false,"title":"benchmain: format output of benchmark to a table","user":{"login":"ZhouyihaiDing","id":28968539,"avatar_url":"https://avatars3.githubusercontent.com/u/28968539?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhouyihaiDing","html_url":"https://github.com/ZhouyihaiDing","followers_url":"https://api.github.com/users/ZhouyihaiDing/followers","following_url":"https://api.github.com/users/ZhouyihaiDing/following{/other_user}","gists_url":"https://api.github.com/users/ZhouyihaiDing/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhouyihaiDing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhouyihaiDing/subscriptions","organizations_url":"https://api.github.com/users/ZhouyihaiDing/orgs","repos_url":"https://api.github.com/users/ZhouyihaiDing/repos","events_url":"https://api.github.com/users/ZhouyihaiDing/events{/privacy}","received_events_url":"https://api.github.com/users/ZhouyihaiDing/received_events","type":"User","site_admin":false},"body":"The output will be a table with 5 columns: benchmark name, 50% latency, 90% lantency, Bytes per Alloc and number of Allocs.\r\n\r\nTo shorten the benchmark name, features shared by all test cases will be extracted and print ahead of the table.\r\n\r\nFor example,\r\n`go run benchmark/benchmain/main.go -benchtime=1s -workloads=all   -compression=on -maxConcurrentCalls=1 -traceMode=false   -reqSizeBytes=1,1048576 -respSizeBytes=1,1048576   -latency=0s -kbps=0 -mtu=0   -cpuProfile=cpuProf -memProfile=memProf -memProfileRate=10000`\r\nwill print\r\n```\r\n Shared festures: \r\n--------------------\r\nenable-tracing_false\r\nlatency_0s\r\nkbps_0\r\nMTU_0\r\nmaxConcurrentCalls_1\r\nCompressor_true\r\n\r\n------------------------------\r\nBenchmark Name                                                                   \t50% latency \t90% latency \tBytes per Alloc \tNumber of Allocs\r\nUnary-reqSize_1B-respSize_1B                                                    :       242.4330 µs        301.6290 µs  \t   11771 B/op\t     225 allocs/op \r\nStream-reqSize_1B-respSize_1B                                                   :       550.5400 µs        765.9560 µs  \t 1172962 B/op\t     139 allocs/op \r\nUnary-reqSize_1B-respSize_1048576B                                              :         4.1215 ms          4.7527 ms  \t10553718 B/op\t    1338 allocs/op \r\nStream-reqSize_1B-respSize_1048576B                                             :        12.9757 ms         17.6339 ms  \t 9074074 B/op\t     173 allocs/op \r\nUnary-reqSize_1048576B-respSize_1B                                              :         4.3785 ms          5.0291 ms  \t10555464 B/op\t    1374 allocs/op \r\nStream-reqSize_1048576B-respSize_1B                                             :        12.7951 ms         17.4144 ms  \t 9068061 B/op\t     172 allocs/op \r\nUnary-reqSize_1048576B-respSize_1048576B                                        :         8.1528 ms          9.2155 ms  \t21096680 B/op\t    2467 allocs/op \r\nStream-reqSize_1048576B-respSize_1048576B                                       :        29.4988 ms         33.5302 ms  \t16610965 B/op\t     191 allocs/op\r\n```","created_at":"2017-08-29T23:55:24Z","updated_at":"2017-08-31T16:29:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"732b009498d132b0371ff38b14a18c7d81da9349","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1493/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-go/pulls/1493/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-go/issues/1493/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/408fcc6679cce4938884acbf377b3e68edb7dabf","head":{"label":"ZhouyihaiDing:column_output","ref":"column_output","sha":"408fcc6679cce4938884acbf377b3e68edb7dabf","user":{"login":"ZhouyihaiDing","id":28968539,"avatar_url":"https://avatars3.githubusercontent.com/u/28968539?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhouyihaiDing","html_url":"https://github.com/ZhouyihaiDing","followers_url":"https://api.github.com/users/ZhouyihaiDing/followers","following_url":"https://api.github.com/users/ZhouyihaiDing/following{/other_user}","gists_url":"https://api.github.com/users/ZhouyihaiDing/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhouyihaiDing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhouyihaiDing/subscriptions","organizations_url":"https://api.github.com/users/ZhouyihaiDing/orgs","repos_url":"https://api.github.com/users/ZhouyihaiDing/repos","events_url":"https://api.github.com/users/ZhouyihaiDing/events{/privacy}","received_events_url":"https://api.github.com/users/ZhouyihaiDing/received_events","type":"User","site_admin":false},"repo":{"id":95264928,"name":"grpc-go","full_name":"ZhouyihaiDing/grpc-go","owner":{"login":"ZhouyihaiDing","id":28968539,"avatar_url":"https://avatars3.githubusercontent.com/u/28968539?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhouyihaiDing","html_url":"https://github.com/ZhouyihaiDing","followers_url":"https://api.github.com/users/ZhouyihaiDing/followers","following_url":"https://api.github.com/users/ZhouyihaiDing/following{/other_user}","gists_url":"https://api.github.com/users/ZhouyihaiDing/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhouyihaiDing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhouyihaiDing/subscriptions","organizations_url":"https://api.github.com/users/ZhouyihaiDing/orgs","repos_url":"https://api.github.com/users/ZhouyihaiDing/repos","events_url":"https://api.github.com/users/ZhouyihaiDing/events{/privacy}","received_events_url":"https://api.github.com/users/ZhouyihaiDing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZhouyihaiDing/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go","forks_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/forks","keys_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/teams","hooks_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/events","assignees_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/tags","blobs_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/languages","stargazers_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/subscription","commits_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/merges","archive_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/downloads","issues_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/ZhouyihaiDing/grpc-go/deployments","created_at":"2017-06-24T00:07:31Z","updated_at":"2017-06-24T00:07:33Z","pushed_at":"2017-08-31T03:09:56Z","git_url":"git://github.com/ZhouyihaiDing/grpc-go.git","ssh_url":"git@github.com:ZhouyihaiDing/grpc-go.git","clone_url":"https://github.com/ZhouyihaiDing/grpc-go.git","svn_url":"https://github.com/ZhouyihaiDing/grpc-go","homepage":"","size":4136,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":7,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"3a378f9deb683b3a7d282e3c75dc2a35fb042977","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729907,"name":"grpc-go","full_name":"grpc/grpc-go","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars1.githubusercontent.com/u/7802525?v=4","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-go","description":"The Go language implementation of gRPC. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-go","forks_url":"https://api.github.com/repos/grpc/grpc-go/forks","keys_url":"https://api.github.com/repos/grpc/grpc-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-go/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-go/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-go/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-go/events","assignees_url":"https://api.github.com/repos/grpc/grpc-go/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-go/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-go/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-go/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-go/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-go/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-go/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-go/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-go/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-go/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-go/merges","archive_url":"https://api.github.com/repos/grpc/grpc-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-go/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-go/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-go/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-go/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-go/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-go/releases{/id}","deployments_url":"https://api.github.com/repos/grpc/grpc-go/deployments","created_at":"2014-12-08T18:59:34Z","updated_at":"2017-08-31T16:09:14Z","pushed_at":"2017-08-31T03:09:57Z","git_url":"git://github.com/grpc/grpc-go.git","ssh_url":"git@github.com:grpc/grpc-go.git","clone_url":"https://github.com/grpc/grpc-go.git","svn_url":"https://github.com/grpc/grpc-go","homepage":"","size":4041,"stargazers_count":3812,"watchers_count":3812,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":713,"mirror_url":null,"open_issues_count":100,"forks":713,"open_issues":100,"watchers":3812,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1493"},"html":{"href":"https://github.com/grpc/grpc-go/pull/1493"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/1493"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-go/issues/1493/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1493/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-go/pulls/1493/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-go/statuses/408fcc6679cce4938884acbf377b3e68edb7dabf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dfawley"}}