{"action":"opened","number":646,"pull_request":{"url":"https://api.github.com/repos/sardana-org/sardana/pulls/646","id":152377415,"html_url":"https://github.com/sardana-org/sardana/pull/646","diff_url":"https://github.com/sardana-org/sardana/pull/646.diff","patch_url":"https://github.com/sardana-org/sardana/pull/646.patch","issue_url":"https://api.github.com/repos/sardana-org/sardana/issues/646","number":646,"state":"open","locked":false,"title":"[WIP] Add support to GeneralHooks (#200)","user":{"login":"reszelaz","id":6735649,"avatar_url":"https://avatars1.githubusercontent.com/u/6735649?v=4","gravatar_id":"","url":"https://api.github.com/users/reszelaz","html_url":"https://github.com/reszelaz","followers_url":"https://api.github.com/users/reszelaz/followers","following_url":"https://api.github.com/users/reszelaz/following{/other_user}","gists_url":"https://api.github.com/users/reszelaz/gists{/gist_id}","starred_url":"https://api.github.com/users/reszelaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reszelaz/subscriptions","organizations_url":"https://api.github.com/users/reszelaz/orgs","repos_url":"https://api.github.com/users/reszelaz/repos","events_url":"https://api.github.com/users/reszelaz/events{/privacy}","received_events_url":"https://api.github.com/users/reszelaz/received_events","type":"User","site_admin":false},"body":"This PR is for development of the GeneralHooks feature as requested in #200.\r\n\r\nTODOs:\r\n\r\n- [ ] Agree on GeneralHooks environment variable syntax (see #200 for discussion) - now it uses the programmatic API e.g. `senv GeneralHooks \"[('MyHook1', ['my-hook-place'])]\"`\r\n- [ ] Report and fix bug in Hookable.hooks.set (now it only resets the list with hooks and not the dictionary with hints)\r\n- [ ] Extract GeneralHooks configuration at the very start of the macro/sequence execution (this may be a more general issue)\r\n- [ ] Agree and implement the commodity macros e.g. `lsgenhook`, `addgenhook`, etc.\r\n- [ ] Add support to callables?\r\n \r\nFor testing I use this https://github.com/reszelaz/generalHooks. Ideally this should be converted into tests...","created_at":"2017-11-13T23:42:08Z","updated_at":"2017-11-13T23:42:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sardana-org/sardana/pulls/646/commits","review_comments_url":"https://api.github.com/repos/sardana-org/sardana/pulls/646/comments","review_comment_url":"https://api.github.com/repos/sardana-org/sardana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sardana-org/sardana/issues/646/comments","statuses_url":"https://api.github.com/repos/sardana-org/sardana/statuses/7520d09639f3b16ac48f6ec8425b586a85f50f37","head":{"label":"reszelaz:issue-200","ref":"issue-200","sha":"7520d09639f3b16ac48f6ec8425b586a85f50f37","user":{"login":"reszelaz","id":6735649,"avatar_url":"https://avatars1.githubusercontent.com/u/6735649?v=4","gravatar_id":"","url":"https://api.github.com/users/reszelaz","html_url":"https://github.com/reszelaz","followers_url":"https://api.github.com/users/reszelaz/followers","following_url":"https://api.github.com/users/reszelaz/following{/other_user}","gists_url":"https://api.github.com/users/reszelaz/gists{/gist_id}","starred_url":"https://api.github.com/users/reszelaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reszelaz/subscriptions","organizations_url":"https://api.github.com/users/reszelaz/orgs","repos_url":"https://api.github.com/users/reszelaz/repos","events_url":"https://api.github.com/users/reszelaz/events{/privacy}","received_events_url":"https://api.github.com/users/reszelaz/received_events","type":"User","site_admin":false},"repo":{"id":75381676,"name":"sardana","full_name":"reszelaz/sardana","owner":{"login":"reszelaz","id":6735649,"avatar_url":"https://avatars1.githubusercontent.com/u/6735649?v=4","gravatar_id":"","url":"https://api.github.com/users/reszelaz","html_url":"https://github.com/reszelaz","followers_url":"https://api.github.com/users/reszelaz/followers","following_url":"https://api.github.com/users/reszelaz/following{/other_user}","gists_url":"https://api.github.com/users/reszelaz/gists{/gist_id}","starred_url":"https://api.github.com/users/reszelaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reszelaz/subscriptions","organizations_url":"https://api.github.com/users/reszelaz/orgs","repos_url":"https://api.github.com/users/reszelaz/repos","events_url":"https://api.github.com/users/reszelaz/events{/privacy}","received_events_url":"https://api.github.com/users/reszelaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reszelaz/sardana","description":"Fork (reszelaz) of the Sardana project (http://www.sardana-controls.org/). ","fork":true,"url":"https://api.github.com/repos/reszelaz/sardana","forks_url":"https://api.github.com/repos/reszelaz/sardana/forks","keys_url":"https://api.github.com/repos/reszelaz/sardana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reszelaz/sardana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reszelaz/sardana/teams","hooks_url":"https://api.github.com/repos/reszelaz/sardana/hooks","issue_events_url":"https://api.github.com/repos/reszelaz/sardana/issues/events{/number}","events_url":"https://api.github.com/repos/reszelaz/sardana/events","assignees_url":"https://api.github.com/repos/reszelaz/sardana/assignees{/user}","branches_url":"https://api.github.com/repos/reszelaz/sardana/branches{/branch}","tags_url":"https://api.github.com/repos/reszelaz/sardana/tags","blobs_url":"https://api.github.com/repos/reszelaz/sardana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reszelaz/sardana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reszelaz/sardana/git/refs{/sha}","trees_url":"https://api.github.com/repos/reszelaz/sardana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reszelaz/sardana/statuses/{sha}","languages_url":"https://api.github.com/repos/reszelaz/sardana/languages","stargazers_url":"https://api.github.com/repos/reszelaz/sardana/stargazers","contributors_url":"https://api.github.com/repos/reszelaz/sardana/contributors","subscribers_url":"https://api.github.com/repos/reszelaz/sardana/subscribers","subscription_url":"https://api.github.com/repos/reszelaz/sardana/subscription","commits_url":"https://api.github.com/repos/reszelaz/sardana/commits{/sha}","git_commits_url":"https://api.github.com/repos/reszelaz/sardana/git/commits{/sha}","comments_url":"https://api.github.com/repos/reszelaz/sardana/comments{/number}","issue_comment_url":"https://api.github.com/repos/reszelaz/sardana/issues/comments{/number}","contents_url":"https://api.github.com/repos/reszelaz/sardana/contents/{+path}","compare_url":"https://api.github.com/repos/reszelaz/sardana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reszelaz/sardana/merges","archive_url":"https://api.github.com/repos/reszelaz/sardana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reszelaz/sardana/downloads","issues_url":"https://api.github.com/repos/reszelaz/sardana/issues{/number}","pulls_url":"https://api.github.com/repos/reszelaz/sardana/pulls{/number}","milestones_url":"https://api.github.com/repos/reszelaz/sardana/milestones{/number}","notifications_url":"https://api.github.com/repos/reszelaz/sardana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reszelaz/sardana/labels{/name}","releases_url":"https://api.github.com/repos/reszelaz/sardana/releases{/id}","deployments_url":"https://api.github.com/repos/reszelaz/sardana/deployments","created_at":"2016-12-02T09:35:05Z","updated_at":"2017-03-02T23:10:58Z","pushed_at":"2017-11-13T23:28:24Z","git_url":"git://github.com/reszelaz/sardana.git","ssh_url":"git@github.com:reszelaz/sardana.git","clone_url":"https://github.com/reszelaz/sardana.git","svn_url":"https://github.com/reszelaz/sardana","homepage":"","size":54062,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"sardana-org:develop","ref":"develop","sha":"01b154244c97e09b316be39fbf2e7a15d149e4f3","user":{"login":"sardana-org","id":22996613,"avatar_url":"https://avatars3.githubusercontent.com/u/22996613?v=4","gravatar_id":"","url":"https://api.github.com/users/sardana-org","html_url":"https://github.com/sardana-org","followers_url":"https://api.github.com/users/sardana-org/followers","following_url":"https://api.github.com/users/sardana-org/following{/other_user}","gists_url":"https://api.github.com/users/sardana-org/gists{/gist_id}","starred_url":"https://api.github.com/users/sardana-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sardana-org/subscriptions","organizations_url":"https://api.github.com/users/sardana-org/orgs","repos_url":"https://api.github.com/users/sardana-org/repos","events_url":"https://api.github.com/users/sardana-org/events{/privacy}","received_events_url":"https://api.github.com/users/sardana-org/received_events","type":"Organization","site_admin":false},"repo":{"id":74042659,"name":"sardana","full_name":"sardana-org/sardana","owner":{"login":"sardana-org","id":22996613,"avatar_url":"https://avatars3.githubusercontent.com/u/22996613?v=4","gravatar_id":"","url":"https://api.github.com/users/sardana-org","html_url":"https://github.com/sardana-org","followers_url":"https://api.github.com/users/sardana-org/followers","following_url":"https://api.github.com/users/sardana-org/following{/other_user}","gists_url":"https://api.github.com/users/sardana-org/gists{/gist_id}","starred_url":"https://api.github.com/users/sardana-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sardana-org/subscriptions","organizations_url":"https://api.github.com/users/sardana-org/orgs","repos_url":"https://api.github.com/users/sardana-org/repos","events_url":"https://api.github.com/users/sardana-org/events{/privacy}","received_events_url":"https://api.github.com/users/sardana-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sardana-org/sardana","description":"Canonical repository of the Sardana project (http://www.sardana-controls.org/). ","fork":false,"url":"https://api.github.com/repos/sardana-org/sardana","forks_url":"https://api.github.com/repos/sardana-org/sardana/forks","keys_url":"https://api.github.com/repos/sardana-org/sardana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sardana-org/sardana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sardana-org/sardana/teams","hooks_url":"https://api.github.com/repos/sardana-org/sardana/hooks","issue_events_url":"https://api.github.com/repos/sardana-org/sardana/issues/events{/number}","events_url":"https://api.github.com/repos/sardana-org/sardana/events","assignees_url":"https://api.github.com/repos/sardana-org/sardana/assignees{/user}","branches_url":"https://api.github.com/repos/sardana-org/sardana/branches{/branch}","tags_url":"https://api.github.com/repos/sardana-org/sardana/tags","blobs_url":"https://api.github.com/repos/sardana-org/sardana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sardana-org/sardana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sardana-org/sardana/git/refs{/sha}","trees_url":"https://api.github.com/repos/sardana-org/sardana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sardana-org/sardana/statuses/{sha}","languages_url":"https://api.github.com/repos/sardana-org/sardana/languages","stargazers_url":"https://api.github.com/repos/sardana-org/sardana/stargazers","contributors_url":"https://api.github.com/repos/sardana-org/sardana/contributors","subscribers_url":"https://api.github.com/repos/sardana-org/sardana/subscribers","subscription_url":"https://api.github.com/repos/sardana-org/sardana/subscription","commits_url":"https://api.github.com/repos/sardana-org/sardana/commits{/sha}","git_commits_url":"https://api.github.com/repos/sardana-org/sardana/git/commits{/sha}","comments_url":"https://api.github.com/repos/sardana-org/sardana/comments{/number}","issue_comment_url":"https://api.github.com/repos/sardana-org/sardana/issues/comments{/number}","contents_url":"https://api.github.com/repos/sardana-org/sardana/contents/{+path}","compare_url":"https://api.github.com/repos/sardana-org/sardana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sardana-org/sardana/merges","archive_url":"https://api.github.com/repos/sardana-org/sardana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sardana-org/sardana/downloads","issues_url":"https://api.github.com/repos/sardana-org/sardana/issues{/number}","pulls_url":"https://api.github.com/repos/sardana-org/sardana/pulls{/number}","milestones_url":"https://api.github.com/repos/sardana-org/sardana/milestones{/number}","notifications_url":"https://api.github.com/repos/sardana-org/sardana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sardana-org/sardana/labels{/name}","releases_url":"https://api.github.com/repos/sardana-org/sardana/releases{/id}","deployments_url":"https://api.github.com/repos/sardana-org/sardana/deployments","created_at":"2016-11-17T15:55:09Z","updated_at":"2017-09-18T11:03:47Z","pushed_at":"2017-11-09T09:15:25Z","git_url":"git://github.com/sardana-org/sardana.git","ssh_url":"git@github.com:sardana-org/sardana.git","clone_url":"https://github.com/sardana-org/sardana.git","svn_url":"https://github.com/sardana-org/sardana","homepage":null,"size":54058,"stargazers_count":15,"watchers_count":15,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":253,"forks":20,"open_issues":253,"watchers":15,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sardana-org/sardana/pulls/646"},"html":{"href":"https://github.com/sardana-org/sardana/pull/646"},"issue":{"href":"https://api.github.com/repos/sardana-org/sardana/issues/646"},"comments":{"href":"https://api.github.com/repos/sardana-org/sardana/issues/646/comments"},"review_comments":{"href":"https://api.github.com/repos/sardana-org/sardana/pulls/646/comments"},"review_comment":{"href":"https://api.github.com/repos/sardana-org/sardana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sardana-org/sardana/pulls/646/commits"},"statuses":{"href":"https://api.github.com/repos/sardana-org/sardana/statuses/7520d09639f3b16ac48f6ec8425b586a85f50f37"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":60,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"reszelaz"}}