{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/115528403","pull_request_review_id":37074050,"id":115528403,"diff_hunk":"@@ -64,6 +64,9 @@ FLAGS += -DUSE_POLLY\n ifeq ($(USE_POLLY_OPENMP),1)\n FLAGS += -fopenmp\n endif\n+ifeq ($(USE_POLLY_ACC),1)\n+LLVMLINK += -lPollyPPCG -Wl,-rpath=$(shell $(LLVM_CONFIG_HOST) --libdir),--no-as-needed -lGPURuntime -Wl,--as-needed","path":"src/Makefile","position":5,"original_position":5,"commit_id":"d9b7cae0ed8bd73db9977919b79e7d9dd9a8086c","original_commit_id":"d9b7cae0ed8bd73db9977919b79e7d9dd9a8086c","user":{"login":"tobig","id":521960,"avatar_url":"https://avatars2.githubusercontent.com/u/521960?v=3","gravatar_id":"","url":"https://api.github.com/users/tobig","html_url":"https://github.com/tobig","followers_url":"https://api.github.com/users/tobig/followers","following_url":"https://api.github.com/users/tobig/following{/other_user}","gists_url":"https://api.github.com/users/tobig/gists{/gist_id}","starred_url":"https://api.github.com/users/tobig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobig/subscriptions","organizations_url":"https://api.github.com/users/tobig/orgs","repos_url":"https://api.github.com/users/tobig/repos","events_url":"https://api.github.com/users/tobig/events{/privacy}","received_events_url":"https://api.github.com/users/tobig/received_events","type":"User","site_admin":false},"body":"This is just an alternative suggestion. I am fine with the --no-as-needed, if this works for the Julia people. As you say, GPURuntime is certainly different in nature than normal LLVM libraries as it is a run-time library.","created_at":"2017-05-09T15:56:54Z","updated_at":"2017-05-09T15:56:55Z","html_url":"https://github.com/JuliaLang/julia/pull/21736#discussion_r115528403","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/21736","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/115528403"},"html":{"href":"https://github.com/JuliaLang/julia/pull/21736#discussion_r115528403"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/21736"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/21736","id":119331858,"html_url":"https://github.com/JuliaLang/julia/pull/21736","diff_url":"https://github.com/JuliaLang/julia/pull/21736.diff","patch_url":"https://github.com/JuliaLang/julia/pull/21736.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/21736","number":21736,"state":"open","locked":false,"title":"Introduce USE_POLLY_ACC","user":{"login":"singam-sanjay","id":6310523,"avatar_url":"https://avatars3.githubusercontent.com/u/6310523?v=3","gravatar_id":"","url":"https://api.github.com/users/singam-sanjay","html_url":"https://github.com/singam-sanjay","followers_url":"https://api.github.com/users/singam-sanjay/followers","following_url":"https://api.github.com/users/singam-sanjay/following{/other_user}","gists_url":"https://api.github.com/users/singam-sanjay/gists{/gist_id}","starred_url":"https://api.github.com/users/singam-sanjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singam-sanjay/subscriptions","organizations_url":"https://api.github.com/users/singam-sanjay/orgs","repos_url":"https://api.github.com/users/singam-sanjay/repos","events_url":"https://api.github.com/users/singam-sanjay/events{/privacy}","received_events_url":"https://api.github.com/users/singam-sanjay/received_events","type":"User","site_admin":false},"body":"Introduce the USE_POLLY_ACC variable to enable Polly's GPGPU codegeneration facilities.","created_at":"2017-05-07T09:16:57Z","updated_at":"2017-05-09T15:56:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb491968ae37bbd781244da33db597c976595886","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/21736/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/21736/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/21736/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/d9b7cae0ed8bd73db9977919b79e7d9dd9a8086c","head":{"label":"singam-sanjay:USE_POLLY_ACC","ref":"USE_POLLY_ACC","sha":"d9b7cae0ed8bd73db9977919b79e7d9dd9a8086c","user":{"login":"singam-sanjay","id":6310523,"avatar_url":"https://avatars3.githubusercontent.com/u/6310523?v=3","gravatar_id":"","url":"https://api.github.com/users/singam-sanjay","html_url":"https://github.com/singam-sanjay","followers_url":"https://api.github.com/users/singam-sanjay/followers","following_url":"https://api.github.com/users/singam-sanjay/following{/other_user}","gists_url":"https://api.github.com/users/singam-sanjay/gists{/gist_id}","starred_url":"https://api.github.com/users/singam-sanjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singam-sanjay/subscriptions","organizations_url":"https://api.github.com/users/singam-sanjay/orgs","repos_url":"https://api.github.com/users/singam-sanjay/repos","events_url":"https://api.github.com/users/singam-sanjay/events{/privacy}","received_events_url":"https://api.github.com/users/singam-sanjay/received_events","type":"User","site_admin":false},"repo":{"id":90400647,"name":"julia","full_name":"singam-sanjay/julia","owner":{"login":"singam-sanjay","id":6310523,"avatar_url":"https://avatars3.githubusercontent.com/u/6310523?v=3","gravatar_id":"","url":"https://api.github.com/users/singam-sanjay","html_url":"https://github.com/singam-sanjay","followers_url":"https://api.github.com/users/singam-sanjay/followers","following_url":"https://api.github.com/users/singam-sanjay/following{/other_user}","gists_url":"https://api.github.com/users/singam-sanjay/gists{/gist_id}","starred_url":"https://api.github.com/users/singam-sanjay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singam-sanjay/subscriptions","organizations_url":"https://api.github.com/users/singam-sanjay/orgs","repos_url":"https://api.github.com/users/singam-sanjay/repos","events_url":"https://api.github.com/users/singam-sanjay/events{/privacy}","received_events_url":"https://api.github.com/users/singam-sanjay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/singam-sanjay/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/singam-sanjay/julia","forks_url":"https://api.github.com/repos/singam-sanjay/julia/forks","keys_url":"https://api.github.com/repos/singam-sanjay/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singam-sanjay/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singam-sanjay/julia/teams","hooks_url":"https://api.github.com/repos/singam-sanjay/julia/hooks","issue_events_url":"https://api.github.com/repos/singam-sanjay/julia/issues/events{/number}","events_url":"https://api.github.com/repos/singam-sanjay/julia/events","assignees_url":"https://api.github.com/repos/singam-sanjay/julia/assignees{/user}","branches_url":"https://api.github.com/repos/singam-sanjay/julia/branches{/branch}","tags_url":"https://api.github.com/repos/singam-sanjay/julia/tags","blobs_url":"https://api.github.com/repos/singam-sanjay/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singam-sanjay/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singam-sanjay/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/singam-sanjay/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singam-sanjay/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/singam-sanjay/julia/languages","stargazers_url":"https://api.github.com/repos/singam-sanjay/julia/stargazers","contributors_url":"https://api.github.com/repos/singam-sanjay/julia/contributors","subscribers_url":"https://api.github.com/repos/singam-sanjay/julia/subscribers","subscription_url":"https://api.github.com/repos/singam-sanjay/julia/subscription","commits_url":"https://api.github.com/repos/singam-sanjay/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/singam-sanjay/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/singam-sanjay/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/singam-sanjay/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/singam-sanjay/julia/contents/{+path}","compare_url":"https://api.github.com/repos/singam-sanjay/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singam-sanjay/julia/merges","archive_url":"https://api.github.com/repos/singam-sanjay/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singam-sanjay/julia/downloads","issues_url":"https://api.github.com/repos/singam-sanjay/julia/issues{/number}","pulls_url":"https://api.github.com/repos/singam-sanjay/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/singam-sanjay/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/singam-sanjay/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singam-sanjay/julia/labels{/name}","releases_url":"https://api.github.com/repos/singam-sanjay/julia/releases{/id}","deployments_url":"https://api.github.com/repos/singam-sanjay/julia/deployments","created_at":"2017-05-05T17:27:19Z","updated_at":"2017-05-05T17:27:30Z","pushed_at":"2017-05-07T09:15:32Z","git_url":"git://github.com/singam-sanjay/julia.git","ssh_url":"git@github.com:singam-sanjay/julia.git","clone_url":"https://github.com/singam-sanjay/julia.git","svn_url":"https://github.com/singam-sanjay/julia","homepage":"http://julialang.org/","size":153510,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"f4cd98b6ca2e69b3a5ba01001231be29652e8bad","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars3.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars3.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2017-05-09T15:33:22Z","pushed_at":"2017-05-09T15:32:38Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":154465,"stargazers_count":8573,"watchers_count":8573,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1961,"mirror_url":null,"open_issues_count":2305,"forks":1961,"open_issues":2305,"watchers":8573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/21736"},"html":{"href":"https://github.com/JuliaLang/julia/pull/21736"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/21736"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/21736/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/21736/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/21736/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/d9b7cae0ed8bd73db9977919b79e7d9dd9a8086c"}}}}
{"actor":{"display_login":"tobig"}}