{"action":"closed","number":7523,"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/7523","id":106351112,"html_url":"https://github.com/Sylius/Sylius/pull/7523","diff_url":"https://github.com/Sylius/Sylius/pull/7523.diff","patch_url":"https://github.com/Sylius/Sylius/pull/7523.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/7523","number":7523,"state":"closed","locked":false,"title":"Make `ProductTaxon` a proxy for `Taxon`.","user":{"login":"steffenbrem","id":1569156,"avatar_url":"https://avatars2.githubusercontent.com/u/1569156?v=3","gravatar_id":"","url":"https://api.github.com/users/steffenbrem","html_url":"https://github.com/steffenbrem","followers_url":"https://api.github.com/users/steffenbrem/followers","following_url":"https://api.github.com/users/steffenbrem/following{/other_user}","gists_url":"https://api.github.com/users/steffenbrem/gists{/gist_id}","starred_url":"https://api.github.com/users/steffenbrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffenbrem/subscriptions","organizations_url":"https://api.github.com/users/steffenbrem/orgs","repos_url":"https://api.github.com/users/steffenbrem/repos","events_url":"https://api.github.com/users/steffenbrem/events{/privacy}","received_events_url":"https://api.github.com/users/steffenbrem/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | no |\r\n| New feature?    | yes |\r\n| BC breaks?      | no |\r\n| Related tickets | none |\r\n| License         | MIT |\r\n\r\nI proposed this setup in Slack and @pjedrzejewski agreed on letting me make a PR. Themes and templates could look a lot cleaner when using these patterns.\r\n\r\nWith `ProductTaxon` being a proxy of `Taxon` we can do this:\r\n\r\n```twig\r\n{# proposal: we change `productTaxons` to `taxons` #}\r\n{% for taxon in product.taxons %}\r\n    {{taxon.name}} {# will get it from the `taxon` internally #}\r\n    {{taxon.position}} {# we still work with a ProductTaxon, so this works :D #}\r\n{% endfor %}\r\n```\r\n\r\nI would like to know if it would be preferred to change `Product::productTaxons` to `Product::taxons` if we would introduce this idea. To me it feels a lot better to use just `taxons`, since you basically have a `Taxon`.","created_at":"2017-02-15T16:47:46Z","updated_at":"2017-03-22T13:07:45Z","closed_at":"2017-03-22T13:07:45Z","merged_at":null,"merge_commit_sha":"8823190b8dae748ad1f9e015b451ae6195498f48","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Sylius/Sylius/milestones/10","html_url":"https://github.com/Sylius/Sylius/milestone/10","labels_url":"https://api.github.com/repos/Sylius/Sylius/milestones/10/labels","id":2377015,"number":10,"title":"v1.0.0-beta.2","description":"The 2nd BETA release of Sylius.","creator":{"login":"pjedrzejewski","id":614970,"avatar_url":"https://avatars1.githubusercontent.com/u/614970?v=3","gravatar_id":"","url":"https://api.github.com/users/pjedrzejewski","html_url":"https://github.com/pjedrzejewski","followers_url":"https://api.github.com/users/pjedrzejewski/followers","following_url":"https://api.github.com/users/pjedrzejewski/following{/other_user}","gists_url":"https://api.github.com/users/pjedrzejewski/gists{/gist_id}","starred_url":"https://api.github.com/users/pjedrzejewski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjedrzejewski/subscriptions","organizations_url":"https://api.github.com/users/pjedrzejewski/orgs","repos_url":"https://api.github.com/users/pjedrzejewski/repos","events_url":"https://api.github.com/users/pjedrzejewski/events{/privacy}","received_events_url":"https://api.github.com/users/pjedrzejewski/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":29,"state":"open","created_at":"2017-03-10T09:48:03Z","updated_at":"2017-03-22T13:07:45Z","due_on":"2017-03-17T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/7523/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/7523/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/7523/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/5d4f90d9fc6c24e636b1d691be31c66a13286743","head":{"label":"steffenbrem:feature/product-taxon-proxy-taxon-interface","ref":"feature/product-taxon-proxy-taxon-interface","sha":"5d4f90d9fc6c24e636b1d691be31c66a13286743","user":{"login":"steffenbrem","id":1569156,"avatar_url":"https://avatars2.githubusercontent.com/u/1569156?v=3","gravatar_id":"","url":"https://api.github.com/users/steffenbrem","html_url":"https://github.com/steffenbrem","followers_url":"https://api.github.com/users/steffenbrem/followers","following_url":"https://api.github.com/users/steffenbrem/following{/other_user}","gists_url":"https://api.github.com/users/steffenbrem/gists{/gist_id}","starred_url":"https://api.github.com/users/steffenbrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffenbrem/subscriptions","organizations_url":"https://api.github.com/users/steffenbrem/orgs","repos_url":"https://api.github.com/users/steffenbrem/repos","events_url":"https://api.github.com/users/steffenbrem/events{/privacy}","received_events_url":"https://api.github.com/users/steffenbrem/received_events","type":"User","site_admin":false},"repo":{"id":20862736,"name":"Sylius","full_name":"steffenbrem/Sylius","owner":{"login":"steffenbrem","id":1569156,"avatar_url":"https://avatars2.githubusercontent.com/u/1569156?v=3","gravatar_id":"","url":"https://api.github.com/users/steffenbrem","html_url":"https://github.com/steffenbrem","followers_url":"https://api.github.com/users/steffenbrem/followers","following_url":"https://api.github.com/users/steffenbrem/following{/other_user}","gists_url":"https://api.github.com/users/steffenbrem/gists{/gist_id}","starred_url":"https://api.github.com/users/steffenbrem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steffenbrem/subscriptions","organizations_url":"https://api.github.com/users/steffenbrem/orgs","repos_url":"https://api.github.com/users/steffenbrem/repos","events_url":"https://api.github.com/users/steffenbrem/events{/privacy}","received_events_url":"https://api.github.com/users/steffenbrem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steffenbrem/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":true,"url":"https://api.github.com/repos/steffenbrem/Sylius","forks_url":"https://api.github.com/repos/steffenbrem/Sylius/forks","keys_url":"https://api.github.com/repos/steffenbrem/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steffenbrem/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steffenbrem/Sylius/teams","hooks_url":"https://api.github.com/repos/steffenbrem/Sylius/hooks","issue_events_url":"https://api.github.com/repos/steffenbrem/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/steffenbrem/Sylius/events","assignees_url":"https://api.github.com/repos/steffenbrem/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/steffenbrem/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/steffenbrem/Sylius/tags","blobs_url":"https://api.github.com/repos/steffenbrem/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steffenbrem/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steffenbrem/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/steffenbrem/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steffenbrem/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/steffenbrem/Sylius/languages","stargazers_url":"https://api.github.com/repos/steffenbrem/Sylius/stargazers","contributors_url":"https://api.github.com/repos/steffenbrem/Sylius/contributors","subscribers_url":"https://api.github.com/repos/steffenbrem/Sylius/subscribers","subscription_url":"https://api.github.com/repos/steffenbrem/Sylius/subscription","commits_url":"https://api.github.com/repos/steffenbrem/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/steffenbrem/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/steffenbrem/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/steffenbrem/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/steffenbrem/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/steffenbrem/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steffenbrem/Sylius/merges","archive_url":"https://api.github.com/repos/steffenbrem/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steffenbrem/Sylius/downloads","issues_url":"https://api.github.com/repos/steffenbrem/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/steffenbrem/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/steffenbrem/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/steffenbrem/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steffenbrem/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/steffenbrem/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/steffenbrem/Sylius/deployments","created_at":"2014-06-15T18:55:05Z","updated_at":"2016-03-14T15:02:06Z","pushed_at":"2017-03-02T12:41:16Z","git_url":"git://github.com/steffenbrem/Sylius.git","ssh_url":"git@github.com:steffenbrem/Sylius.git","clone_url":"https://github.com/steffenbrem/Sylius.git","svn_url":"https://github.com/steffenbrem/Sylius","homepage":"Sylius.org","size":57124,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"b4e30e96a904c09fbb02f7fbc0ff71b52c672487","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars1.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars1.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius/deployments","created_at":"2011-11-05T22:05:52Z","updated_at":"2017-03-22T04:19:34Z","pushed_at":"2017-03-22T13:07:45Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://Sylius.org","size":58245,"stargazers_count":2892,"watchers_count":2892,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1060,"mirror_url":null,"open_issues_count":461,"forks":1060,"open_issues":461,"watchers":2892,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/7523"},"html":{"href":"https://github.com/Sylius/Sylius/pull/7523"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/7523"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/7523/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/7523/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/7523/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/5d4f90d9fc6c24e636b1d691be31c66a13286743"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":10,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":546,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"pjedrzejewski"}}