{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/95232603","pull_request_review_id":15781119,"id":95232603,"diff_hunk":"@@ -57,6 +57,18 @@ function getUnmaskedContext(workInProgress : Fiber) : Object {\n }\n exports.getUnmaskedContext = getUnmaskedContext;\n \n+function cacheContext(workInProgress : Fiber, unmaskedContext : Object, maskedContext : Object) {\n+  if (isContextConsumer(workInProgress)) {","path":"src/renderers/shared/fiber/ReactFiberContext.js","position":5,"original_position":5,"commit_id":"a06bb126abc75232b37e8231fb1fe48f2bffed09","original_commit_id":"a06bb126abc75232b37e8231fb1fe48f2bffed09","user":{"login":"gaearon","id":810438,"avatar_url":"https://avatars.githubusercontent.com/u/810438?v=3","gravatar_id":"","url":"https://api.github.com/users/gaearon","html_url":"https://github.com/gaearon","followers_url":"https://api.github.com/users/gaearon/followers","following_url":"https://api.github.com/users/gaearon/following{/other_user}","gists_url":"https://api.github.com/users/gaearon/gists{/gist_id}","starred_url":"https://api.github.com/users/gaearon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaearon/subscriptions","organizations_url":"https://api.github.com/users/gaearon/orgs","repos_url":"https://api.github.com/users/gaearon/repos","events_url":"https://api.github.com/users/gaearon/events{/privacy}","received_events_url":"https://api.github.com/users/gaearon/received_events","type":"User","site_admin":false},"body":"We could but it seems a bit fishy to make one perf optimization to rely on another perf optimization being present in another file. Returning `null` since more explicit if we want to \"signal\" that it's not a context consumer.","created_at":"2017-01-09T19:52:51Z","updated_at":"2017-01-09T19:52:51Z","html_url":"https://github.com/facebook/react/pull/8723#discussion_r95232603","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/8723","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/95232603"},"html":{"href":"https://github.com/facebook/react/pull/8723#discussion_r95232603"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/8723"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/8723","id":100743915,"html_url":"https://github.com/facebook/react/pull/8723","diff_url":"https://github.com/facebook/react/pull/8723.diff","patch_url":"https://github.com/facebook/react/pull/8723.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/8723","number":8723,"state":"open","locked":false,"title":"Improve unmasked context caching","user":{"login":"bvaughn","id":29597,"avatar_url":"https://avatars.githubusercontent.com/u/29597?v=3","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"body":"* Only store cached masked/unmasked contexts on `context` consumers.\r\n* Move all references to __reactInternal* cached attributes inside of `ReactFiberContext`.\r\n\r\nRelated to [this discussion thread](https://github.com/facebook/react/pull/8706#discussion_r95220106).","created_at":"2017-01-09T19:21:38Z","updated_at":"2017-01-09T19:52:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4140c74bca7e896c823746b4fdcfae92a0cbe61","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/8723/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/8723/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/8723/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/a06bb126abc75232b37e8231fb1fe48f2bffed09","head":{"label":"bvaughn:improve-unmasked-context-caching","ref":"improve-unmasked-context-caching","sha":"a06bb126abc75232b37e8231fb1fe48f2bffed09","user":{"login":"bvaughn","id":29597,"avatar_url":"https://avatars.githubusercontent.com/u/29597?v=3","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"repo":{"id":74410855,"name":"react","full_name":"bvaughn/react","owner":{"login":"bvaughn","id":29597,"avatar_url":"https://avatars.githubusercontent.com/u/29597?v=3","gravatar_id":"","url":"https://api.github.com/users/bvaughn","html_url":"https://github.com/bvaughn","followers_url":"https://api.github.com/users/bvaughn/followers","following_url":"https://api.github.com/users/bvaughn/following{/other_user}","gists_url":"https://api.github.com/users/bvaughn/gists{/gist_id}","starred_url":"https://api.github.com/users/bvaughn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bvaughn/subscriptions","organizations_url":"https://api.github.com/users/bvaughn/orgs","repos_url":"https://api.github.com/users/bvaughn/repos","events_url":"https://api.github.com/users/bvaughn/events{/privacy}","received_events_url":"https://api.github.com/users/bvaughn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bvaughn/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/bvaughn/react","forks_url":"https://api.github.com/repos/bvaughn/react/forks","keys_url":"https://api.github.com/repos/bvaughn/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bvaughn/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bvaughn/react/teams","hooks_url":"https://api.github.com/repos/bvaughn/react/hooks","issue_events_url":"https://api.github.com/repos/bvaughn/react/issues/events{/number}","events_url":"https://api.github.com/repos/bvaughn/react/events","assignees_url":"https://api.github.com/repos/bvaughn/react/assignees{/user}","branches_url":"https://api.github.com/repos/bvaughn/react/branches{/branch}","tags_url":"https://api.github.com/repos/bvaughn/react/tags","blobs_url":"https://api.github.com/repos/bvaughn/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bvaughn/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bvaughn/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/bvaughn/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bvaughn/react/statuses/{sha}","languages_url":"https://api.github.com/repos/bvaughn/react/languages","stargazers_url":"https://api.github.com/repos/bvaughn/react/stargazers","contributors_url":"https://api.github.com/repos/bvaughn/react/contributors","subscribers_url":"https://api.github.com/repos/bvaughn/react/subscribers","subscription_url":"https://api.github.com/repos/bvaughn/react/subscription","commits_url":"https://api.github.com/repos/bvaughn/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/bvaughn/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/bvaughn/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/bvaughn/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/bvaughn/react/contents/{+path}","compare_url":"https://api.github.com/repos/bvaughn/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bvaughn/react/merges","archive_url":"https://api.github.com/repos/bvaughn/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bvaughn/react/downloads","issues_url":"https://api.github.com/repos/bvaughn/react/issues{/number}","pulls_url":"https://api.github.com/repos/bvaughn/react/pulls{/number}","milestones_url":"https://api.github.com/repos/bvaughn/react/milestones{/number}","notifications_url":"https://api.github.com/repos/bvaughn/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bvaughn/react/labels{/name}","releases_url":"https://api.github.com/repos/bvaughn/react/releases{/id}","deployments_url":"https://api.github.com/repos/bvaughn/react/deployments","created_at":"2016-11-21T22:18:38Z","updated_at":"2016-11-21T22:18:45Z","pushed_at":"2017-01-09T19:19:08Z","git_url":"git://github.com/bvaughn/react.git","ssh_url":"git@github.com:bvaughn/react.git","clone_url":"https://github.com/bvaughn/react.git","svn_url":"https://github.com/bvaughn/react","homepage":"https://facebook.github.io/react/","size":110995,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"c78e403d7b4728adb3242425097f2574124169c3","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2017-01-09T19:30:54Z","pushed_at":"2017-01-09T19:50:46Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://facebook.github.io/react/","size":112396,"stargazers_count":57286,"watchers_count":57286,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10356,"mirror_url":null,"open_issues_count":674,"forks":10356,"open_issues":674,"watchers":57286,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/8723"},"html":{"href":"https://github.com/facebook/react/pull/8723"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/8723"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/8723/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/8723/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/8723/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/a06bb126abc75232b37e8231fb1fe48f2bffed09"}}}}
{"actor":{"display_login":"gaearon"}}