{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/client/issues/5916","repository_url":"https://api.github.com/repos/owncloud/client","labels_url":"https://api.github.com/repos/owncloud/client/issues/5916/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/client/issues/5916/comments","events_url":"https://api.github.com/repos/owncloud/client/issues/5916/events","html_url":"https://github.com/owncloud/client/pull/5916","id":244378073,"number":5916,"title":"Splitt off Abstract Folder class from Folder","user":{"login":"dragotin","id":1070214,"avatar_url":"https://avatars2.githubusercontent.com/u/1070214?v=4","gravatar_id":"","url":"https://api.github.com/users/dragotin","html_url":"https://github.com/dragotin","followers_url":"https://api.github.com/users/dragotin/followers","following_url":"https://api.github.com/users/dragotin/following{/other_user}","gists_url":"https://api.github.com/users/dragotin/gists{/gist_id}","starred_url":"https://api.github.com/users/dragotin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragotin/subscriptions","organizations_url":"https://api.github.com/users/dragotin/orgs","repos_url":"https://api.github.com/users/dragotin/repos","events_url":"https://api.github.com/users/dragotin/events{/privacy}","received_events_url":"https://api.github.com/users/dragotin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-20T14:14:40Z","updated_at":"2017-07-26T13:03:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/client/pulls/5916","html_url":"https://github.com/owncloud/client/pull/5916","diff_url":"https://github.com/owncloud/client/pull/5916.diff","patch_url":"https://github.com/owncloud/client/pull/5916.patch"},"body":"Please consider this (large) patch. I splits off an abstract class for folders, providing the integration with the application by managing the interfaces with GUI, socketapi, scheduling and such. The folder class now only still contains things specific to this (the old, common) type  of sync folder. \r\n\r\nHowever, with the new structure we will be able to develop other folder types, such as folders that are actually containers containing a file folder structure, which require special handling in the client code.\r\n\r\nA long term goal is that folders can even have different sync engines.\r\n\r\nI am looking forward to hearing your comments.  "},"comment":{"url":"https://api.github.com/repos/owncloud/client/issues/comments/318046714","html_url":"https://github.com/owncloud/client/pull/5916#issuecomment-318046714","issue_url":"https://api.github.com/repos/owncloud/client/issues/5916","id":318046714,"user":{"login":"ogoffart","id":959326,"avatar_url":"https://avatars3.githubusercontent.com/u/959326?v=4","gravatar_id":"","url":"https://api.github.com/users/ogoffart","html_url":"https://github.com/ogoffart","followers_url":"https://api.github.com/users/ogoffart/followers","following_url":"https://api.github.com/users/ogoffart/following{/other_user}","gists_url":"https://api.github.com/users/ogoffart/gists{/gist_id}","starred_url":"https://api.github.com/users/ogoffart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogoffart/subscriptions","organizations_url":"https://api.github.com/users/ogoffart/orgs","repos_url":"https://api.github.com/users/ogoffart/repos","events_url":"https://api.github.com/users/ogoffart/events{/privacy}","received_events_url":"https://api.github.com/users/ogoffart/received_events","type":"User","site_admin":false},"created_at":"2017-07-26T13:03:32Z","updated_at":"2017-07-26T13:03:32Z","body":"Hi @dragotin,\r\n\r\nCan you elaborate on the use case for this change?\r\n\r\nI'm just worried that adding an abstraction layer that we don't need makes things more complicated."}}
{"actor":{"display_login":"ogoffart"}}