{"action":"created","comment":{"url":"https://api.github.com/repos/line/armeria/pulls/comments/147571881","pull_request_review_id":72688676,"id":147571881,"diff_hunk":"@@ -69,5 +89,13 @@ idea {\n         sourceDirs += file(\"${protobuf.generatedFilesBaseDir}/main/grpc\");\n         sourceDirs += file(\"${protobuf.generatedFilesBaseDir}/test/java\");\n         sourceDirs += file(\"${protobuf.generatedFilesBaseDir}/test/grpc\");\n+        sourceDirs += file(\"${protobuf.generatedFilesBaseDir}/jmh/java\");\n+        sourceDirs += file(\"${protobuf.generatedFilesBaseDir}/jmh/grpc\");\n     }\n }\n+\n+tasks.checkstyleJmh.enabled = false","path":"grpc/build.gradle","position":null,"original_position":50,"commit_id":"6c0ea2e0e155ba9fdb720363d886e385276c8397","original_commit_id":"df85a0625c774bcd11986a3b9e25e24a1ff2cdfd","user":{"login":"anuraaga","id":198344,"avatar_url":"https://avatars0.githubusercontent.com/u/198344?v=4","gravatar_id":"","url":"https://api.github.com/users/anuraaga","html_url":"https://github.com/anuraaga","followers_url":"https://api.github.com/users/anuraaga/followers","following_url":"https://api.github.com/users/anuraaga/following{/other_user}","gists_url":"https://api.github.com/users/anuraaga/gists{/gist_id}","starred_url":"https://api.github.com/users/anuraaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuraaga/subscriptions","organizations_url":"https://api.github.com/users/anuraaga/orgs","repos_url":"https://api.github.com/users/anuraaga/repos","events_url":"https://api.github.com/users/anuraaga/events{/privacy}","received_events_url":"https://api.github.com/users/anuraaga/received_events","type":"User","site_admin":false},"body":"Didn't want to deal with javadoc, but realized I could edit the checkstyle config so they're treated as tests, fixed.","created_at":"2017-10-29T06:33:12Z","updated_at":"2017-10-29T06:33:12Z","html_url":"https://github.com/line/armeria/pull/798#discussion_r147571881","pull_request_url":"https://api.github.com/repos/line/armeria/pulls/798","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/comments/147571881"},"html":{"href":"https://github.com/line/armeria/pull/798#discussion_r147571881"},"pull_request":{"href":"https://api.github.com/repos/line/armeria/pulls/798"}},"in_reply_to_id":147383377},"pull_request":{"url":"https://api.github.com/repos/line/armeria/pulls/798","id":148596844,"html_url":"https://github.com/line/armeria/pull/798","diff_url":"https://github.com/line/armeria/pull/798.diff","patch_url":"https://github.com/line/armeria/pull/798.patch","issue_url":"https://api.github.com/repos/line/armeria/issues/798","number":798,"state":"open","locked":false,"title":"Add a simple benchmark for gRPC.","user":{"login":"anuraaga","id":198344,"avatar_url":"https://avatars0.githubusercontent.com/u/198344?v=4","gravatar_id":"","url":"https://api.github.com/users/anuraaga","html_url":"https://github.com/anuraaga","followers_url":"https://api.github.com/users/anuraaga/followers","following_url":"https://api.github.com/users/anuraaga/following{/other_user}","gists_url":"https://api.github.com/users/anuraaga/gists{/gist_id}","starred_url":"https://api.github.com/users/anuraaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuraaga/subscriptions","organizations_url":"https://api.github.com/users/anuraaga/orgs","repos_url":"https://api.github.com/users/anuraaga/repos","events_url":"https://api.github.com/users/anuraaga/events{/privacy}","received_events_url":"https://api.github.com/users/anuraaga/received_events","type":"User","site_admin":false},"body":"It just sends and receives a real-world-esque proto (Github search API) but this should be a reasonable sanity check of the HTTP + marshalling logic, which is the core of gRPC.\r\n\r\nPreliminary benchmarks show around\r\n- 750 qps for armeria\r\n- 1100 qps for upstream (with faster JIT warmup from eyeballing the warmup iterations)\r\n\r\nIt will be interesting to dig into the difference going forward - I don't like being 25% slower!","created_at":"2017-10-25T08:08:08Z","updated_at":"2017-10-29T06:33:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"228d371a3cb0d320fad065b489c5735f69e1d4f3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/line/armeria/milestones/87","html_url":"https://github.com/line/armeria/milestone/87","labels_url":"https://api.github.com/repos/line/armeria/milestones/87/labels","id":2857855,"number":87,"title":"0.55.0","description":null,"creator":{"login":"trustin","id":173918,"avatar_url":"https://avatars0.githubusercontent.com/u/173918?v=4","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":4,"state":"open","created_at":"2017-10-23T06:38:45Z","updated_at":"2017-10-29T03:50:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/line/armeria/pulls/798/commits","review_comments_url":"https://api.github.com/repos/line/armeria/pulls/798/comments","review_comment_url":"https://api.github.com/repos/line/armeria/pulls/comments{/number}","comments_url":"https://api.github.com/repos/line/armeria/issues/798/comments","statuses_url":"https://api.github.com/repos/line/armeria/statuses/6c0ea2e0e155ba9fdb720363d886e385276c8397","head":{"label":"anuraaga:dev_rag","ref":"dev_rag","sha":"6c0ea2e0e155ba9fdb720363d886e385276c8397","user":{"login":"anuraaga","id":198344,"avatar_url":"https://avatars0.githubusercontent.com/u/198344?v=4","gravatar_id":"","url":"https://api.github.com/users/anuraaga","html_url":"https://github.com/anuraaga","followers_url":"https://api.github.com/users/anuraaga/followers","following_url":"https://api.github.com/users/anuraaga/following{/other_user}","gists_url":"https://api.github.com/users/anuraaga/gists{/gist_id}","starred_url":"https://api.github.com/users/anuraaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuraaga/subscriptions","organizations_url":"https://api.github.com/users/anuraaga/orgs","repos_url":"https://api.github.com/users/anuraaga/repos","events_url":"https://api.github.com/users/anuraaga/events{/privacy}","received_events_url":"https://api.github.com/users/anuraaga/received_events","type":"User","site_admin":false},"repo":{"id":46321489,"name":"armeria","full_name":"anuraaga/armeria","owner":{"login":"anuraaga","id":198344,"avatar_url":"https://avatars0.githubusercontent.com/u/198344?v=4","gravatar_id":"","url":"https://api.github.com/users/anuraaga","html_url":"https://github.com/anuraaga","followers_url":"https://api.github.com/users/anuraaga/followers","following_url":"https://api.github.com/users/anuraaga/following{/other_user}","gists_url":"https://api.github.com/users/anuraaga/gists{/gist_id}","starred_url":"https://api.github.com/users/anuraaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anuraaga/subscriptions","organizations_url":"https://api.github.com/users/anuraaga/orgs","repos_url":"https://api.github.com/users/anuraaga/repos","events_url":"https://api.github.com/users/anuraaga/events{/privacy}","received_events_url":"https://api.github.com/users/anuraaga/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anuraaga/armeria","description":"Asynchronous RPC/API client/server library built on top of Java 8, Netty 4.1, HTTP/2, and Thrift","fork":true,"url":"https://api.github.com/repos/anuraaga/armeria","forks_url":"https://api.github.com/repos/anuraaga/armeria/forks","keys_url":"https://api.github.com/repos/anuraaga/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anuraaga/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anuraaga/armeria/teams","hooks_url":"https://api.github.com/repos/anuraaga/armeria/hooks","issue_events_url":"https://api.github.com/repos/anuraaga/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/anuraaga/armeria/events","assignees_url":"https://api.github.com/repos/anuraaga/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/anuraaga/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/anuraaga/armeria/tags","blobs_url":"https://api.github.com/repos/anuraaga/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anuraaga/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anuraaga/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/anuraaga/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anuraaga/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/anuraaga/armeria/languages","stargazers_url":"https://api.github.com/repos/anuraaga/armeria/stargazers","contributors_url":"https://api.github.com/repos/anuraaga/armeria/contributors","subscribers_url":"https://api.github.com/repos/anuraaga/armeria/subscribers","subscription_url":"https://api.github.com/repos/anuraaga/armeria/subscription","commits_url":"https://api.github.com/repos/anuraaga/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/anuraaga/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/anuraaga/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/anuraaga/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/anuraaga/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/anuraaga/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anuraaga/armeria/merges","archive_url":"https://api.github.com/repos/anuraaga/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anuraaga/armeria/downloads","issues_url":"https://api.github.com/repos/anuraaga/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/anuraaga/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/anuraaga/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/anuraaga/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anuraaga/armeria/labels{/name}","releases_url":"https://api.github.com/repos/anuraaga/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/anuraaga/armeria/deployments","created_at":"2015-11-17T03:43:26Z","updated_at":"2016-12-09T07:51:08Z","pushed_at":"2017-10-29T06:32:53Z","git_url":"git://github.com/anuraaga/armeria.git","ssh_url":"git@github.com:anuraaga/armeria.git","clone_url":"https://github.com/anuraaga/armeria.git","svn_url":"https://github.com/anuraaga/armeria","homepage":"http://line.github.io/armeria/","size":22891,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"line:master","ref":"master","sha":"b0d918e1919cffccc788844f23f8a4e5c9342778","user":{"login":"line","id":13128444,"avatar_url":"https://avatars2.githubusercontent.com/u/13128444?v=4","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"repo":{"id":46251204,"name":"armeria","full_name":"line/armeria","owner":{"login":"line","id":13128444,"avatar_url":"https://avatars2.githubusercontent.com/u/13128444?v=4","gravatar_id":"","url":"https://api.github.com/users/line","html_url":"https://github.com/line","followers_url":"https://api.github.com/users/line/followers","following_url":"https://api.github.com/users/line/following{/other_user}","gists_url":"https://api.github.com/users/line/gists{/gist_id}","starred_url":"https://api.github.com/users/line/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/line/subscriptions","organizations_url":"https://api.github.com/users/line/orgs","repos_url":"https://api.github.com/users/line/repos","events_url":"https://api.github.com/users/line/events{/privacy}","received_events_url":"https://api.github.com/users/line/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/line/armeria","description":"Asynchronous RPC/REST library built on top of Java 8, Netty, HTTP/2, Thrift and gRPC","fork":false,"url":"https://api.github.com/repos/line/armeria","forks_url":"https://api.github.com/repos/line/armeria/forks","keys_url":"https://api.github.com/repos/line/armeria/keys{/key_id}","collaborators_url":"https://api.github.com/repos/line/armeria/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/line/armeria/teams","hooks_url":"https://api.github.com/repos/line/armeria/hooks","issue_events_url":"https://api.github.com/repos/line/armeria/issues/events{/number}","events_url":"https://api.github.com/repos/line/armeria/events","assignees_url":"https://api.github.com/repos/line/armeria/assignees{/user}","branches_url":"https://api.github.com/repos/line/armeria/branches{/branch}","tags_url":"https://api.github.com/repos/line/armeria/tags","blobs_url":"https://api.github.com/repos/line/armeria/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/line/armeria/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/line/armeria/git/refs{/sha}","trees_url":"https://api.github.com/repos/line/armeria/git/trees{/sha}","statuses_url":"https://api.github.com/repos/line/armeria/statuses/{sha}","languages_url":"https://api.github.com/repos/line/armeria/languages","stargazers_url":"https://api.github.com/repos/line/armeria/stargazers","contributors_url":"https://api.github.com/repos/line/armeria/contributors","subscribers_url":"https://api.github.com/repos/line/armeria/subscribers","subscription_url":"https://api.github.com/repos/line/armeria/subscription","commits_url":"https://api.github.com/repos/line/armeria/commits{/sha}","git_commits_url":"https://api.github.com/repos/line/armeria/git/commits{/sha}","comments_url":"https://api.github.com/repos/line/armeria/comments{/number}","issue_comment_url":"https://api.github.com/repos/line/armeria/issues/comments{/number}","contents_url":"https://api.github.com/repos/line/armeria/contents/{+path}","compare_url":"https://api.github.com/repos/line/armeria/compare/{base}...{head}","merges_url":"https://api.github.com/repos/line/armeria/merges","archive_url":"https://api.github.com/repos/line/armeria/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/line/armeria/downloads","issues_url":"https://api.github.com/repos/line/armeria/issues{/number}","pulls_url":"https://api.github.com/repos/line/armeria/pulls{/number}","milestones_url":"https://api.github.com/repos/line/armeria/milestones{/number}","notifications_url":"https://api.github.com/repos/line/armeria/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/line/armeria/labels{/name}","releases_url":"https://api.github.com/repos/line/armeria/releases{/id}","deployments_url":"https://api.github.com/repos/line/armeria/deployments","created_at":"2015-11-16T04:04:01Z","updated_at":"2017-10-28T10:30:26Z","pushed_at":"2017-10-29T06:32:54Z","git_url":"git://github.com/line/armeria.git","ssh_url":"git@github.com:line/armeria.git","clone_url":"https://github.com/line/armeria.git","svn_url":"https://github.com/line/armeria","homepage":"http://line.github.io/armeria/","size":25925,"stargazers_count":916,"watchers_count":916,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":236,"mirror_url":null,"archived":false,"open_issues_count":68,"forks":236,"open_issues":68,"watchers":916,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/line/armeria/pulls/798"},"html":{"href":"https://github.com/line/armeria/pull/798"},"issue":{"href":"https://api.github.com/repos/line/armeria/issues/798"},"comments":{"href":"https://api.github.com/repos/line/armeria/issues/798/comments"},"review_comments":{"href":"https://api.github.com/repos/line/armeria/pulls/798/comments"},"review_comment":{"href":"https://api.github.com/repos/line/armeria/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/line/armeria/pulls/798/commits"},"statuses":{"href":"https://api.github.com/repos/line/armeria/statuses/6c0ea2e0e155ba9fdb720363d886e385276c8397"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"anuraaga"}}