{"action":"created","comment":{"url":"https://api.github.com/repos/pret/pokeruby/pulls/comments/125171732","pull_request_review_id":47539515,"id":125171732,"diff_hunk":"@@ -1,6 +1,10 @@\n #ifndef GUARD_TASK_H\n #define GUARD_TASK_H\n \n+// general task defines\n+#define TASK gTasks[taskId]\n+#define FUNC func","path":"include/task.h","position":6,"original_position":6,"commit_id":"5f3d11e9dee2d6025c938f97a05d0a8de7df5e3a","original_commit_id":"8059cdb262be63f8e6a879c716e7a0fa664a547d","user":{"login":"ProjectRevoTPP","id":11638236,"avatar_url":"https://avatars0.githubusercontent.com/u/11638236?v=3","gravatar_id":"","url":"https://api.github.com/users/ProjectRevoTPP","html_url":"https://github.com/ProjectRevoTPP","followers_url":"https://api.github.com/users/ProjectRevoTPP/followers","following_url":"https://api.github.com/users/ProjectRevoTPP/following{/other_user}","gists_url":"https://api.github.com/users/ProjectRevoTPP/gists{/gist_id}","starred_url":"https://api.github.com/users/ProjectRevoTPP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProjectRevoTPP/subscriptions","organizations_url":"https://api.github.com/users/ProjectRevoTPP/orgs","repos_url":"https://api.github.com/users/ProjectRevoTPP/repos","events_url":"https://api.github.com/users/ProjectRevoTPP/events{/privacy}","received_events_url":"https://api.github.com/users/ProjectRevoTPP/received_events","type":"User","site_admin":false},"body":"yes, but since multiple files use local task defines, if I don't put them in a more global header, it's going to cause console errors (albeit they wont cause the build nor Travis to fail) because its declared in multiple places.","created_at":"2017-07-02T01:02:33Z","updated_at":"2017-07-02T01:02:33Z","html_url":"https://github.com/pret/pokeruby/pull/346#discussion_r125171732","pull_request_url":"https://api.github.com/repos/pret/pokeruby/pulls/346","_links":{"self":{"href":"https://api.github.com/repos/pret/pokeruby/pulls/comments/125171732"},"html":{"href":"https://github.com/pret/pokeruby/pull/346#discussion_r125171732"},"pull_request":{"href":"https://api.github.com/repos/pret/pokeruby/pulls/346"}}},"pull_request":{"url":"https://api.github.com/repos/pret/pokeruby/pulls/346","id":127384260,"html_url":"https://github.com/pret/pokeruby/pull/346","diff_url":"https://github.com/pret/pokeruby/pull/346.diff","patch_url":"https://github.com/pret/pokeruby/pull/346.patch","issue_url":"https://api.github.com/repos/pret/pokeruby/issues/346","number":346,"state":"open","locked":false,"title":"Sound check menu","user":{"login":"ProjectRevoTPP","id":11638236,"avatar_url":"https://avatars0.githubusercontent.com/u/11638236?v=3","gravatar_id":"","url":"https://api.github.com/users/ProjectRevoTPP","html_url":"https://github.com/ProjectRevoTPP","followers_url":"https://api.github.com/users/ProjectRevoTPP/followers","following_url":"https://api.github.com/users/ProjectRevoTPP/following{/other_user}","gists_url":"https://api.github.com/users/ProjectRevoTPP/gists{/gist_id}","starred_url":"https://api.github.com/users/ProjectRevoTPP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProjectRevoTPP/subscriptions","organizations_url":"https://api.github.com/users/ProjectRevoTPP/orgs","repos_url":"https://api.github.com/users/ProjectRevoTPP/repos","events_url":"https://api.github.com/users/ProjectRevoTPP/events{/privacy}","received_events_url":"https://api.github.com/users/ProjectRevoTPP/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-06-26T00:14:49Z","updated_at":"2017-07-02T01:02:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a5d27cf51a18823da98937fb4588b804e2d5a08","assignee":null,"assignees":[],"requested_reviewers":[{"login":"yenatch","id":1654211,"avatar_url":"https://avatars2.githubusercontent.com/u/1654211?v=3","gravatar_id":"","url":"https://api.github.com/users/yenatch","html_url":"https://github.com/yenatch","followers_url":"https://api.github.com/users/yenatch/followers","following_url":"https://api.github.com/users/yenatch/following{/other_user}","gists_url":"https://api.github.com/users/yenatch/gists{/gist_id}","starred_url":"https://api.github.com/users/yenatch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yenatch/subscriptions","organizations_url":"https://api.github.com/users/yenatch/orgs","repos_url":"https://api.github.com/users/yenatch/repos","events_url":"https://api.github.com/users/yenatch/events{/privacy}","received_events_url":"https://api.github.com/users/yenatch/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pret/pokeruby/pulls/346/commits","review_comments_url":"https://api.github.com/repos/pret/pokeruby/pulls/346/comments","review_comment_url":"https://api.github.com/repos/pret/pokeruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pret/pokeruby/issues/346/comments","statuses_url":"https://api.github.com/repos/pret/pokeruby/statuses/5f3d11e9dee2d6025c938f97a05d0a8de7df5e3a","head":{"label":"ProjectRevoTPP:sound_check_menu","ref":"sound_check_menu","sha":"5f3d11e9dee2d6025c938f97a05d0a8de7df5e3a","user":{"login":"ProjectRevoTPP","id":11638236,"avatar_url":"https://avatars0.githubusercontent.com/u/11638236?v=3","gravatar_id":"","url":"https://api.github.com/users/ProjectRevoTPP","html_url":"https://github.com/ProjectRevoTPP","followers_url":"https://api.github.com/users/ProjectRevoTPP/followers","following_url":"https://api.github.com/users/ProjectRevoTPP/following{/other_user}","gists_url":"https://api.github.com/users/ProjectRevoTPP/gists{/gist_id}","starred_url":"https://api.github.com/users/ProjectRevoTPP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProjectRevoTPP/subscriptions","organizations_url":"https://api.github.com/users/ProjectRevoTPP/orgs","repos_url":"https://api.github.com/users/ProjectRevoTPP/repos","events_url":"https://api.github.com/users/ProjectRevoTPP/events{/privacy}","received_events_url":"https://api.github.com/users/ProjectRevoTPP/received_events","type":"User","site_admin":false},"repo":{"id":77411518,"name":"pokeruby","full_name":"ProjectRevoTPP/pokeruby","owner":{"login":"ProjectRevoTPP","id":11638236,"avatar_url":"https://avatars0.githubusercontent.com/u/11638236?v=3","gravatar_id":"","url":"https://api.github.com/users/ProjectRevoTPP","html_url":"https://github.com/ProjectRevoTPP","followers_url":"https://api.github.com/users/ProjectRevoTPP/followers","following_url":"https://api.github.com/users/ProjectRevoTPP/following{/other_user}","gists_url":"https://api.github.com/users/ProjectRevoTPP/gists{/gist_id}","starred_url":"https://api.github.com/users/ProjectRevoTPP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProjectRevoTPP/subscriptions","organizations_url":"https://api.github.com/users/ProjectRevoTPP/orgs","repos_url":"https://api.github.com/users/ProjectRevoTPP/repos","events_url":"https://api.github.com/users/ProjectRevoTPP/events{/privacy}","received_events_url":"https://api.github.com/users/ProjectRevoTPP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ProjectRevoTPP/pokeruby","description":"Disassembly of Pokémon Ruby/Sapphire","fork":true,"url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby","forks_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/forks","keys_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/teams","hooks_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/hooks","issue_events_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/issues/events{/number}","events_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/events","assignees_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/assignees{/user}","branches_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/branches{/branch}","tags_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/tags","blobs_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/statuses/{sha}","languages_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/languages","stargazers_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/stargazers","contributors_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/contributors","subscribers_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/subscribers","subscription_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/subscription","commits_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/contents/{+path}","compare_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/merges","archive_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/downloads","issues_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/issues{/number}","pulls_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/pulls{/number}","milestones_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/milestones{/number}","notifications_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/labels{/name}","releases_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/releases{/id}","deployments_url":"https://api.github.com/repos/ProjectRevoTPP/pokeruby/deployments","created_at":"2016-12-26T23:16:28Z","updated_at":"2017-05-04T06:42:44Z","pushed_at":"2017-07-02T01:01:11Z","git_url":"git://github.com/ProjectRevoTPP/pokeruby.git","ssh_url":"git@github.com:ProjectRevoTPP/pokeruby.git","clone_url":"https://github.com/ProjectRevoTPP/pokeruby.git","svn_url":"https://github.com/ProjectRevoTPP/pokeruby","homepage":"","size":37777,"stargazers_count":0,"watchers_count":0,"language":"Assembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pret:master","ref":"master","sha":"06b6cada0ddedc62063171703ba6607019751a9a","user":{"login":"pret","id":10761592,"avatar_url":"https://avatars2.githubusercontent.com/u/10761592?v=3","gravatar_id":"","url":"https://api.github.com/users/pret","html_url":"https://github.com/pret","followers_url":"https://api.github.com/users/pret/followers","following_url":"https://api.github.com/users/pret/following{/other_user}","gists_url":"https://api.github.com/users/pret/gists{/gist_id}","starred_url":"https://api.github.com/users/pret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pret/subscriptions","organizations_url":"https://api.github.com/users/pret/orgs","repos_url":"https://api.github.com/users/pret/repos","events_url":"https://api.github.com/users/pret/events{/privacy}","received_events_url":"https://api.github.com/users/pret/received_events","type":"Organization","site_admin":false},"repo":{"id":50256891,"name":"pokeruby","full_name":"pret/pokeruby","owner":{"login":"pret","id":10761592,"avatar_url":"https://avatars2.githubusercontent.com/u/10761592?v=3","gravatar_id":"","url":"https://api.github.com/users/pret","html_url":"https://github.com/pret","followers_url":"https://api.github.com/users/pret/followers","following_url":"https://api.github.com/users/pret/following{/other_user}","gists_url":"https://api.github.com/users/pret/gists{/gist_id}","starred_url":"https://api.github.com/users/pret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pret/subscriptions","organizations_url":"https://api.github.com/users/pret/orgs","repos_url":"https://api.github.com/users/pret/repos","events_url":"https://api.github.com/users/pret/events{/privacy}","received_events_url":"https://api.github.com/users/pret/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pret/pokeruby","description":"Disassembly of Pokémon Ruby/Sapphire","fork":false,"url":"https://api.github.com/repos/pret/pokeruby","forks_url":"https://api.github.com/repos/pret/pokeruby/forks","keys_url":"https://api.github.com/repos/pret/pokeruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pret/pokeruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pret/pokeruby/teams","hooks_url":"https://api.github.com/repos/pret/pokeruby/hooks","issue_events_url":"https://api.github.com/repos/pret/pokeruby/issues/events{/number}","events_url":"https://api.github.com/repos/pret/pokeruby/events","assignees_url":"https://api.github.com/repos/pret/pokeruby/assignees{/user}","branches_url":"https://api.github.com/repos/pret/pokeruby/branches{/branch}","tags_url":"https://api.github.com/repos/pret/pokeruby/tags","blobs_url":"https://api.github.com/repos/pret/pokeruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pret/pokeruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pret/pokeruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/pret/pokeruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pret/pokeruby/statuses/{sha}","languages_url":"https://api.github.com/repos/pret/pokeruby/languages","stargazers_url":"https://api.github.com/repos/pret/pokeruby/stargazers","contributors_url":"https://api.github.com/repos/pret/pokeruby/contributors","subscribers_url":"https://api.github.com/repos/pret/pokeruby/subscribers","subscription_url":"https://api.github.com/repos/pret/pokeruby/subscription","commits_url":"https://api.github.com/repos/pret/pokeruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/pret/pokeruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/pret/pokeruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/pret/pokeruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/pret/pokeruby/contents/{+path}","compare_url":"https://api.github.com/repos/pret/pokeruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pret/pokeruby/merges","archive_url":"https://api.github.com/repos/pret/pokeruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pret/pokeruby/downloads","issues_url":"https://api.github.com/repos/pret/pokeruby/issues{/number}","pulls_url":"https://api.github.com/repos/pret/pokeruby/pulls{/number}","milestones_url":"https://api.github.com/repos/pret/pokeruby/milestones{/number}","notifications_url":"https://api.github.com/repos/pret/pokeruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pret/pokeruby/labels{/name}","releases_url":"https://api.github.com/repos/pret/pokeruby/releases{/id}","deployments_url":"https://api.github.com/repos/pret/pokeruby/deployments","created_at":"2016-01-23T20:26:46Z","updated_at":"2017-07-02T00:04:44Z","pushed_at":"2017-07-02T01:01:12Z","git_url":"git://github.com/pret/pokeruby.git","ssh_url":"git@github.com:pret/pokeruby.git","clone_url":"https://github.com/pret/pokeruby.git","svn_url":"https://github.com/pret/pokeruby","homepage":"","size":37602,"stargazers_count":90,"watchers_count":90,"language":"Assembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":34,"forks":27,"open_issues":34,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pret/pokeruby/pulls/346"},"html":{"href":"https://github.com/pret/pokeruby/pull/346"},"issue":{"href":"https://api.github.com/repos/pret/pokeruby/issues/346"},"comments":{"href":"https://api.github.com/repos/pret/pokeruby/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/pret/pokeruby/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/pret/pokeruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pret/pokeruby/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/pret/pokeruby/statuses/5f3d11e9dee2d6025c938f97a05d0a8de7df5e3a"}}}}
{"actor":{"display_login":"ProjectRevoTPP"}}