{"action":"created","comment":{"url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls/comments/154149639","pull_request_review_id":80268956,"id":154149639,"diff_hunk":"@@ -0,0 +1,70 @@\n+'use strict';\n+\n+const DefaultConfig = require('../DefaultConfig');\n+const MACROSTEP = /^macro (.*) ?is executed$/;\n+\n+/**\n+ * Macro to create a Cucumber step by combining a block of steps, simplifying often recurring steps.\n+ * @class\n+ * @extends DefaultConfig\n+ */\n+class Macro extends DefaultConfig {\n+\n+    constructor() {\n+        super();\n+        this.macros = {};\n+    }\n+\n+    /**\n+     * Function to filter out scenarios of a feature (scenario, scenario outline)\n+     * before they are processed.\n+     * Return FALSE if the given element should be filtered out. Otherwise it won't be.\n+     *\n+     * @param {Scenario|ScenarioOutline} scenario The scenario to be tested.\n+     * @param {Feature} parent The parent feature of the scenario.\n+     * @param {number} i The index of the current element.\n+     * @returns {boolean|*} FALSE if the given element should be filtered out.\n+     */\n+    preFilterScenario(scenario, parent, i) {\n+        const macroTag = scenario.tags.find(tag => /^@macro\\(.*\\)/.test(tag.name));\n+\n+        if (macroTag) {\n+            const name = macroTag.name.substring(7, macroTag.name.length - 1);\n+\n+            if (name.length === 0) {\n+                throw new Error('Name is not provided for macro for scenario ${scenario.name}.');","path":"lib/builtIn/Macro.js","position":35,"original_position":35,"commit_id":"fd73f2e2129fb29ff40dde988318e9452e63eb9e","original_commit_id":"fd73f2e2129fb29ff40dde988318e9452e63eb9e","user":{"login":"szikszail","id":9324618,"avatar_url":"https://avatars3.githubusercontent.com/u/9324618?v=4","gravatar_id":"","url":"https://api.github.com/users/szikszail","html_url":"https://github.com/szikszail","followers_url":"https://api.github.com/users/szikszail/followers","following_url":"https://api.github.com/users/szikszail/following{/other_user}","gists_url":"https://api.github.com/users/szikszail/gists{/gist_id}","starred_url":"https://api.github.com/users/szikszail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szikszail/subscriptions","organizations_url":"https://api.github.com/users/szikszail/orgs","repos_url":"https://api.github.com/users/szikszail/repos","events_url":"https://api.github.com/users/szikszail/events{/privacy}","received_events_url":"https://api.github.com/users/szikszail/received_events","type":"User","site_admin":false},"body":"@judit-nahaj I am sure, that here, you wanted to use the template literals, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals","created_at":"2017-11-30T17:42:38Z","updated_at":"2017-11-30T17:44:17Z","html_url":"https://github.com/judit-nahaj/gherkin-precompiler/pull/16#discussion_r154149639","pull_request_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls/16","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls/comments/154149639"},"html":{"href":"https://github.com/judit-nahaj/gherkin-precompiler/pull/16#discussion_r154149639"},"pull_request":{"href":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls/16","id":154870335,"html_url":"https://github.com/judit-nahaj/gherkin-precompiler/pull/16","diff_url":"https://github.com/judit-nahaj/gherkin-precompiler/pull/16.diff","patch_url":"https://github.com/judit-nahaj/gherkin-precompiler/pull/16.patch","issue_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/issues/16","number":16,"state":"open","locked":false,"title":"Feature/9/macro","user":{"login":"judit-nahaj","id":14162187,"avatar_url":"https://avatars1.githubusercontent.com/u/14162187?v=4","gravatar_id":"","url":"https://api.github.com/users/judit-nahaj","html_url":"https://github.com/judit-nahaj","followers_url":"https://api.github.com/users/judit-nahaj/followers","following_url":"https://api.github.com/users/judit-nahaj/following{/other_user}","gists_url":"https://api.github.com/users/judit-nahaj/gists{/gist_id}","starred_url":"https://api.github.com/users/judit-nahaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judit-nahaj/subscriptions","organizations_url":"https://api.github.com/users/judit-nahaj/orgs","repos_url":"https://api.github.com/users/judit-nahaj/repos","events_url":"https://api.github.com/users/judit-nahaj/events{/privacy}","received_events_url":"https://api.github.com/users/judit-nahaj/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-27T17:27:48Z","updated_at":"2017-11-30T17:44:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff24e9892980f2925d069e6f92504f83b9ac7f67","assignee":{"login":"judit-nahaj","id":14162187,"avatar_url":"https://avatars1.githubusercontent.com/u/14162187?v=4","gravatar_id":"","url":"https://api.github.com/users/judit-nahaj","html_url":"https://github.com/judit-nahaj","followers_url":"https://api.github.com/users/judit-nahaj/followers","following_url":"https://api.github.com/users/judit-nahaj/following{/other_user}","gists_url":"https://api.github.com/users/judit-nahaj/gists{/gist_id}","starred_url":"https://api.github.com/users/judit-nahaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judit-nahaj/subscriptions","organizations_url":"https://api.github.com/users/judit-nahaj/orgs","repos_url":"https://api.github.com/users/judit-nahaj/repos","events_url":"https://api.github.com/users/judit-nahaj/events{/privacy}","received_events_url":"https://api.github.com/users/judit-nahaj/received_events","type":"User","site_admin":false},"assignees":[{"login":"judit-nahaj","id":14162187,"avatar_url":"https://avatars1.githubusercontent.com/u/14162187?v=4","gravatar_id":"","url":"https://api.github.com/users/judit-nahaj","html_url":"https://github.com/judit-nahaj","followers_url":"https://api.github.com/users/judit-nahaj/followers","following_url":"https://api.github.com/users/judit-nahaj/following{/other_user}","gists_url":"https://api.github.com/users/judit-nahaj/gists{/gist_id}","starred_url":"https://api.github.com/users/judit-nahaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judit-nahaj/subscriptions","organizations_url":"https://api.github.com/users/judit-nahaj/orgs","repos_url":"https://api.github.com/users/judit-nahaj/repos","events_url":"https://api.github.com/users/judit-nahaj/events{/privacy}","received_events_url":"https://api.github.com/users/judit-nahaj/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/milestones/2","html_url":"https://github.com/judit-nahaj/gherkin-precompiler/milestone/2","labels_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/milestones/2/labels","id":2684407,"number":2,"title":"v1.1.0","description":"It contains additional plugins and predefined preprocessors.","creator":{"login":"szikszail","id":9324618,"avatar_url":"https://avatars3.githubusercontent.com/u/9324618?v=4","gravatar_id":"","url":"https://api.github.com/users/szikszail","html_url":"https://github.com/szikszail","followers_url":"https://api.github.com/users/szikszail/followers","following_url":"https://api.github.com/users/szikszail/following{/other_user}","gists_url":"https://api.github.com/users/szikszail/gists{/gist_id}","starred_url":"https://api.github.com/users/szikszail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szikszail/subscriptions","organizations_url":"https://api.github.com/users/szikszail/orgs","repos_url":"https://api.github.com/users/szikszail/repos","events_url":"https://api.github.com/users/szikszail/events{/privacy}","received_events_url":"https://api.github.com/users/szikszail/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":6,"state":"open","created_at":"2017-08-07T07:50:22Z","updated_at":"2017-11-27T17:55:13Z","due_on":"2017-12-04T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls/16/commits","review_comments_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls/16/comments","review_comment_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/issues/16/comments","statuses_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/statuses/fd73f2e2129fb29ff40dde988318e9452e63eb9e","head":{"label":"judit-nahaj:feature/9/macro","ref":"feature/9/macro","sha":"fd73f2e2129fb29ff40dde988318e9452e63eb9e","user":{"login":"judit-nahaj","id":14162187,"avatar_url":"https://avatars1.githubusercontent.com/u/14162187?v=4","gravatar_id":"","url":"https://api.github.com/users/judit-nahaj","html_url":"https://github.com/judit-nahaj","followers_url":"https://api.github.com/users/judit-nahaj/followers","following_url":"https://api.github.com/users/judit-nahaj/following{/other_user}","gists_url":"https://api.github.com/users/judit-nahaj/gists{/gist_id}","starred_url":"https://api.github.com/users/judit-nahaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judit-nahaj/subscriptions","organizations_url":"https://api.github.com/users/judit-nahaj/orgs","repos_url":"https://api.github.com/users/judit-nahaj/repos","events_url":"https://api.github.com/users/judit-nahaj/events{/privacy}","received_events_url":"https://api.github.com/users/judit-nahaj/received_events","type":"User","site_admin":false},"repo":{"id":87965612,"name":"gherkin-precompiler","full_name":"judit-nahaj/gherkin-precompiler","owner":{"login":"judit-nahaj","id":14162187,"avatar_url":"https://avatars1.githubusercontent.com/u/14162187?v=4","gravatar_id":"","url":"https://api.github.com/users/judit-nahaj","html_url":"https://github.com/judit-nahaj","followers_url":"https://api.github.com/users/judit-nahaj/followers","following_url":"https://api.github.com/users/judit-nahaj/following{/other_user}","gists_url":"https://api.github.com/users/judit-nahaj/gists{/gist_id}","starred_url":"https://api.github.com/users/judit-nahaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judit-nahaj/subscriptions","organizations_url":"https://api.github.com/users/judit-nahaj/orgs","repos_url":"https://api.github.com/users/judit-nahaj/repos","events_url":"https://api.github.com/users/judit-nahaj/events{/privacy}","received_events_url":"https://api.github.com/users/judit-nahaj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/judit-nahaj/gherkin-precompiler","description":"Simple preprocessor for Gherkin feature files","fork":false,"url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler","forks_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/forks","keys_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/teams","hooks_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/hooks","issue_events_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/issues/events{/number}","events_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/events","assignees_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/assignees{/user}","branches_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/branches{/branch}","tags_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/tags","blobs_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/languages","stargazers_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/stargazers","contributors_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/contributors","subscribers_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/subscribers","subscription_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/subscription","commits_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/contents/{+path}","compare_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/merges","archive_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/downloads","issues_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/issues{/number}","pulls_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/labels{/name}","releases_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/releases{/id}","deployments_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/deployments","created_at":"2017-04-11T18:17:21Z","updated_at":"2017-11-03T21:12:55Z","pushed_at":"2017-11-29T20:41:45Z","git_url":"git://github.com/judit-nahaj/gherkin-precompiler.git","ssh_url":"git@github.com:judit-nahaj/gherkin-precompiler.git","clone_url":"https://github.com/judit-nahaj/gherkin-precompiler.git","svn_url":"https://github.com/judit-nahaj/gherkin-precompiler","homepage":null,"size":55,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"base":{"label":"judit-nahaj:master","ref":"master","sha":"233be5a6f86a04d441065c50d0acd44137a0df0a","user":{"login":"judit-nahaj","id":14162187,"avatar_url":"https://avatars1.githubusercontent.com/u/14162187?v=4","gravatar_id":"","url":"https://api.github.com/users/judit-nahaj","html_url":"https://github.com/judit-nahaj","followers_url":"https://api.github.com/users/judit-nahaj/followers","following_url":"https://api.github.com/users/judit-nahaj/following{/other_user}","gists_url":"https://api.github.com/users/judit-nahaj/gists{/gist_id}","starred_url":"https://api.github.com/users/judit-nahaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judit-nahaj/subscriptions","organizations_url":"https://api.github.com/users/judit-nahaj/orgs","repos_url":"https://api.github.com/users/judit-nahaj/repos","events_url":"https://api.github.com/users/judit-nahaj/events{/privacy}","received_events_url":"https://api.github.com/users/judit-nahaj/received_events","type":"User","site_admin":false},"repo":{"id":87965612,"name":"gherkin-precompiler","full_name":"judit-nahaj/gherkin-precompiler","owner":{"login":"judit-nahaj","id":14162187,"avatar_url":"https://avatars1.githubusercontent.com/u/14162187?v=4","gravatar_id":"","url":"https://api.github.com/users/judit-nahaj","html_url":"https://github.com/judit-nahaj","followers_url":"https://api.github.com/users/judit-nahaj/followers","following_url":"https://api.github.com/users/judit-nahaj/following{/other_user}","gists_url":"https://api.github.com/users/judit-nahaj/gists{/gist_id}","starred_url":"https://api.github.com/users/judit-nahaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judit-nahaj/subscriptions","organizations_url":"https://api.github.com/users/judit-nahaj/orgs","repos_url":"https://api.github.com/users/judit-nahaj/repos","events_url":"https://api.github.com/users/judit-nahaj/events{/privacy}","received_events_url":"https://api.github.com/users/judit-nahaj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/judit-nahaj/gherkin-precompiler","description":"Simple preprocessor for Gherkin feature files","fork":false,"url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler","forks_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/forks","keys_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/teams","hooks_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/hooks","issue_events_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/issues/events{/number}","events_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/events","assignees_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/assignees{/user}","branches_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/branches{/branch}","tags_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/tags","blobs_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/statuses/{sha}","languages_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/languages","stargazers_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/stargazers","contributors_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/contributors","subscribers_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/subscribers","subscription_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/subscription","commits_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/contents/{+path}","compare_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/merges","archive_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/downloads","issues_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/issues{/number}","pulls_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls{/number}","milestones_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/milestones{/number}","notifications_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/labels{/name}","releases_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/releases{/id}","deployments_url":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/deployments","created_at":"2017-04-11T18:17:21Z","updated_at":"2017-11-03T21:12:55Z","pushed_at":"2017-11-29T20:41:45Z","git_url":"git://github.com/judit-nahaj/gherkin-precompiler.git","ssh_url":"git@github.com:judit-nahaj/gherkin-precompiler.git","clone_url":"https://github.com/judit-nahaj/gherkin-precompiler.git","svn_url":"https://github.com/judit-nahaj/gherkin-precompiler","homepage":null,"size":55,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls/16"},"html":{"href":"https://github.com/judit-nahaj/gherkin-precompiler/pull/16"},"issue":{"href":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/issues/16"},"comments":{"href":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/judit-nahaj/gherkin-precompiler/statuses/fd73f2e2129fb29ff40dde988318e9452e63eb9e"}},"author_association":"OWNER"}}
{"actor":{"display_login":"szikszail"}}