{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/112813354","pull_request_review_id":34160996,"id":112813354,"diff_hunk":"@@ -268,15 +268,29 @@\n     var console;\n     Object.defineProperty(global, 'console', {\n       configurable: true,\n-      enumerable: true,\n+      enumerable: false,\n       get: function() {\n         if (!console) {\n           console = NativeModule.require('console');\n           installInspectorConsoleIfNeeded(console,\n                                           inspectorConsole,\n                                           wrapConsoleCall);\n         }\n+        Object.defineProperty(global, 'console', {\n+          configurable: true,\n+          writable: true,\n+          enumerable: false,\n+          value: console\n+        });\n         return console;\n+      },\n+      set: function(customConsole) {","path":"lib/internal/bootstrap_node.js","position":21,"original_position":21,"commit_id":"26c437dd080f1123e60cd0ccf605afe58e7c2ab0","original_commit_id":"26c437dd080f1123e60cd0ccf605afe58e7c2ab0","user":{"login":"Wandalen","id":7414255,"avatar_url":"https://avatars2.githubusercontent.com/u/7414255?v=3","gravatar_id":"","url":"https://api.github.com/users/Wandalen","html_url":"https://github.com/Wandalen","followers_url":"https://api.github.com/users/Wandalen/followers","following_url":"https://api.github.com/users/Wandalen/following{/other_user}","gists_url":"https://api.github.com/users/Wandalen/gists{/gist_id}","starred_url":"https://api.github.com/users/Wandalen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wandalen/subscriptions","organizations_url":"https://api.github.com/users/Wandalen/orgs","repos_url":"https://api.github.com/users/Wandalen/repos","events_url":"https://api.github.com/users/Wandalen/events{/privacy}","received_events_url":"https://api.github.com/users/Wandalen/received_events","type":"User","site_admin":false},"body":"@addaleax can/should I push that changes after launched by TimothyGu remote testing? ","created_at":"2017-04-22T16:42:42Z","updated_at":"2017-04-22T16:42:42Z","html_url":"https://github.com/nodejs/node/pull/12454#discussion_r112813354","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/12454","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/112813354"},"html":{"href":"https://github.com/nodejs/node/pull/12454#discussion_r112813354"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/12454"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/12454","id":116078211,"html_url":"https://github.com/nodejs/node/pull/12454","diff_url":"https://github.com/nodejs/node/pull/12454.diff","patch_url":"https://github.com/nodejs/node/pull/12454.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/12454","number":12454,"state":"open","locked":false,"title":"console: make console consistent with the standard - overridable","user":{"login":"Wandalen","id":7414255,"avatar_url":"https://avatars2.githubusercontent.com/u/7414255?v=3","gravatar_id":"","url":"https://api.github.com/users/Wandalen","html_url":"https://github.com/Wandalen","followers_url":"https://api.github.com/users/Wandalen/followers","following_url":"https://api.github.com/users/Wandalen/following{/other_user}","gists_url":"https://api.github.com/users/Wandalen/gists{/gist_id}","starred_url":"https://api.github.com/users/Wandalen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wandalen/subscriptions","organizations_url":"https://api.github.com/users/Wandalen/orgs","repos_url":"https://api.github.com/users/Wandalen/repos","events_url":"https://api.github.com/users/Wandalen/events{/privacy}","received_events_url":"https://api.github.com/users/Wandalen/received_events","type":"User","site_admin":false},"body":"make console overridable by custom console( without delete )\r\n\r\nadd test suite from w3c/web-platform-tests( console-is-a-namespace )\r\nfew test cases commented out from the test suite\r\nto make nodejs console even more consistent further changes needed\r\nwhich will come in the next commit\r\nwhich could be more breaking than this one\r\n\r\nFixes: https://github.com/nodejs/node/issues/11805\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n","created_at":"2017-04-17T01:00:45Z","updated_at":"2017-04-22T16:42:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1e874a6e10bf89fc29fd291f38e984defea0c53","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/12454/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/12454/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/12454/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/26c437dd080f1123e60cd0ccf605afe58e7c2ab0","head":{"label":"Wandalen:console-consistent-with-standard","ref":"console-consistent-with-standard","sha":"26c437dd080f1123e60cd0ccf605afe58e7c2ab0","user":{"login":"Wandalen","id":7414255,"avatar_url":"https://avatars2.githubusercontent.com/u/7414255?v=3","gravatar_id":"","url":"https://api.github.com/users/Wandalen","html_url":"https://github.com/Wandalen","followers_url":"https://api.github.com/users/Wandalen/followers","following_url":"https://api.github.com/users/Wandalen/following{/other_user}","gists_url":"https://api.github.com/users/Wandalen/gists{/gist_id}","starred_url":"https://api.github.com/users/Wandalen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wandalen/subscriptions","organizations_url":"https://api.github.com/users/Wandalen/orgs","repos_url":"https://api.github.com/users/Wandalen/repos","events_url":"https://api.github.com/users/Wandalen/events{/privacy}","received_events_url":"https://api.github.com/users/Wandalen/received_events","type":"User","site_admin":false},"repo":{"id":88441683,"name":"node","full_name":"Wandalen/node","owner":{"login":"Wandalen","id":7414255,"avatar_url":"https://avatars2.githubusercontent.com/u/7414255?v=3","gravatar_id":"","url":"https://api.github.com/users/Wandalen","html_url":"https://github.com/Wandalen","followers_url":"https://api.github.com/users/Wandalen/followers","following_url":"https://api.github.com/users/Wandalen/following{/other_user}","gists_url":"https://api.github.com/users/Wandalen/gists{/gist_id}","starred_url":"https://api.github.com/users/Wandalen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wandalen/subscriptions","organizations_url":"https://api.github.com/users/Wandalen/orgs","repos_url":"https://api.github.com/users/Wandalen/repos","events_url":"https://api.github.com/users/Wandalen/events{/privacy}","received_events_url":"https://api.github.com/users/Wandalen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Wandalen/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/Wandalen/node","forks_url":"https://api.github.com/repos/Wandalen/node/forks","keys_url":"https://api.github.com/repos/Wandalen/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wandalen/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wandalen/node/teams","hooks_url":"https://api.github.com/repos/Wandalen/node/hooks","issue_events_url":"https://api.github.com/repos/Wandalen/node/issues/events{/number}","events_url":"https://api.github.com/repos/Wandalen/node/events","assignees_url":"https://api.github.com/repos/Wandalen/node/assignees{/user}","branches_url":"https://api.github.com/repos/Wandalen/node/branches{/branch}","tags_url":"https://api.github.com/repos/Wandalen/node/tags","blobs_url":"https://api.github.com/repos/Wandalen/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wandalen/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wandalen/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wandalen/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wandalen/node/statuses/{sha}","languages_url":"https://api.github.com/repos/Wandalen/node/languages","stargazers_url":"https://api.github.com/repos/Wandalen/node/stargazers","contributors_url":"https://api.github.com/repos/Wandalen/node/contributors","subscribers_url":"https://api.github.com/repos/Wandalen/node/subscribers","subscription_url":"https://api.github.com/repos/Wandalen/node/subscription","commits_url":"https://api.github.com/repos/Wandalen/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wandalen/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wandalen/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wandalen/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wandalen/node/contents/{+path}","compare_url":"https://api.github.com/repos/Wandalen/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wandalen/node/merges","archive_url":"https://api.github.com/repos/Wandalen/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wandalen/node/downloads","issues_url":"https://api.github.com/repos/Wandalen/node/issues{/number}","pulls_url":"https://api.github.com/repos/Wandalen/node/pulls{/number}","milestones_url":"https://api.github.com/repos/Wandalen/node/milestones{/number}","notifications_url":"https://api.github.com/repos/Wandalen/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wandalen/node/labels{/name}","releases_url":"https://api.github.com/repos/Wandalen/node/releases{/id}","deployments_url":"https://api.github.com/repos/Wandalen/node/deployments","created_at":"2017-04-16T20:47:45Z","updated_at":"2017-04-16T20:48:14Z","pushed_at":"2017-04-17T17:20:32Z","git_url":"git://github.com/Wandalen/node.git","ssh_url":"git@github.com:Wandalen/node.git","clone_url":"https://github.com/Wandalen/node.git","svn_url":"https://github.com/Wandalen/node","homepage":"https://nodejs.org","size":278394,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"189afc8dc2a4a01e6e97493e167ad6d2db6ff065","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars0.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-04-22T15:15:59Z","pushed_at":"2017-04-22T14:37:51Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":279267,"stargazers_count":34128,"watchers_count":34128,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6506,"mirror_url":null,"open_issues_count":1033,"forks":6506,"open_issues":1033,"watchers":34128,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/12454"},"html":{"href":"https://github.com/nodejs/node/pull/12454"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/12454"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/12454/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/12454/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/12454/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/26c437dd080f1123e60cd0ccf605afe58e7c2ab0"}}}}
{"actor":{"display_login":"Wandalen"}}