{"action":"created","issue":{"url":"https://api.github.com/repos/kenzanmedia/angularjs-webpack-seed/issues/11","repository_url":"https://api.github.com/repos/kenzanmedia/angularjs-webpack-seed","labels_url":"https://api.github.com/repos/kenzanmedia/angularjs-webpack-seed/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/kenzanmedia/angularjs-webpack-seed/issues/11/comments","events_url":"https://api.github.com/repos/kenzanmedia/angularjs-webpack-seed/issues/11/events","html_url":"https://github.com/kenzanmedia/angularjs-webpack-seed/pull/11","id":227850039,"number":11,"title":"implement an example of lazy-loading (#3)","user":{"login":"thisgeek","id":20053,"avatar_url":"https://avatars0.githubusercontent.com/u/20053?v=3","gravatar_id":"","url":"https://api.github.com/users/thisgeek","html_url":"https://github.com/thisgeek","followers_url":"https://api.github.com/users/thisgeek/followers","following_url":"https://api.github.com/users/thisgeek/following{/other_user}","gists_url":"https://api.github.com/users/thisgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/thisgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisgeek/subscriptions","organizations_url":"https://api.github.com/users/thisgeek/orgs","repos_url":"https://api.github.com/users/thisgeek/repos","events_url":"https://api.github.com/users/thisgeek/events{/privacy}","received_events_url":"https://api.github.com/users/thisgeek/received_events","type":"User","site_admin":false},"labels":[{"id":597108565,"url":"https://api.github.com/repos/kenzanmedia/angularjs-webpack-seed/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true}],"state":"open","locked":false,"assignee":{"login":"thisgeek","id":20053,"avatar_url":"https://avatars0.githubusercontent.com/u/20053?v=3","gravatar_id":"","url":"https://api.github.com/users/thisgeek","html_url":"https://github.com/thisgeek","followers_url":"https://api.github.com/users/thisgeek/followers","following_url":"https://api.github.com/users/thisgeek/following{/other_user}","gists_url":"https://api.github.com/users/thisgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/thisgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisgeek/subscriptions","organizations_url":"https://api.github.com/users/thisgeek/orgs","repos_url":"https://api.github.com/users/thisgeek/repos","events_url":"https://api.github.com/users/thisgeek/events{/privacy}","received_events_url":"https://api.github.com/users/thisgeek/received_events","type":"User","site_admin":false},"assignees":[{"login":"thisgeek","id":20053,"avatar_url":"https://avatars0.githubusercontent.com/u/20053?v=3","gravatar_id":"","url":"https://api.github.com/users/thisgeek","html_url":"https://github.com/thisgeek","followers_url":"https://api.github.com/users/thisgeek/followers","following_url":"https://api.github.com/users/thisgeek/following{/other_user}","gists_url":"https://api.github.com/users/thisgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/thisgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisgeek/subscriptions","organizations_url":"https://api.github.com/users/thisgeek/orgs","repos_url":"https://api.github.com/users/thisgeek/repos","events_url":"https://api.github.com/users/thisgeek/events{/privacy}","received_events_url":"https://api.github.com/users/thisgeek/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2017-05-11T00:55:41Z","updated_at":"2017-05-17T13:38:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kenzanmedia/angularjs-webpack-seed/pulls/11","html_url":"https://github.com/kenzanmedia/angularjs-webpack-seed/pull/11","diff_url":"https://github.com/kenzanmedia/angularjs-webpack-seed/pull/11.diff","patch_url":"https://github.com/kenzanmedia/angularjs-webpack-seed/pull/11.patch"},"body":"Resolves (#3).\n\nAs implemented, the lazy-loading employed here leverages webpack 2's support\nfor the pending dynamic import syntax. Eslint and babel now include plugins and\nconfigurations that accept the new syntax.\n\nHere's how it works: The dynamic import requests the files needed for the\napplication's routes. It provides the promise returned by the templateProvider\nfunction for each route. For the controller, the approach is more indirect. At\nthe time of configuration, the route knows its controller by name, but that is\nall. Within a resolve function, the ocLazyLoad service injects the module that\nregisters the controller. Now, when the router looks up the controller by name\nit finds it in the registry.\n\nNote: Grouping the related imports in a common chunk requires the use of a\n\"magic comment\", which in turn required a webpack upgrade."},"comment":{"url":"https://api.github.com/repos/kenzanmedia/angularjs-webpack-seed/issues/comments/302092762","html_url":"https://github.com/kenzanmedia/angularjs-webpack-seed/pull/11#issuecomment-302092762","issue_url":"https://api.github.com/repos/kenzanmedia/angularjs-webpack-seed/issues/11","id":302092762,"user":{"login":"thisgeek","id":20053,"avatar_url":"https://avatars0.githubusercontent.com/u/20053?v=3","gravatar_id":"","url":"https://api.github.com/users/thisgeek","html_url":"https://github.com/thisgeek","followers_url":"https://api.github.com/users/thisgeek/followers","following_url":"https://api.github.com/users/thisgeek/following{/other_user}","gists_url":"https://api.github.com/users/thisgeek/gists{/gist_id}","starred_url":"https://api.github.com/users/thisgeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisgeek/subscriptions","organizations_url":"https://api.github.com/users/thisgeek/orgs","repos_url":"https://api.github.com/users/thisgeek/repos","events_url":"https://api.github.com/users/thisgeek/events{/privacy}","received_events_url":"https://api.github.com/users/thisgeek/received_events","type":"User","site_admin":false},"created_at":"2017-05-17T13:38:30Z","updated_at":"2017-05-17T13:38:30Z","body":"@thescientist13 Now I'm second-guessing. Should I have measured the speed of hot module reloading? I should probably have tried something close to what [ingro did](https://github.com/webpack/webpack/issues/4636#issuecomment-301830807)."}}
{"actor":{"display_login":"thisgeek"}}