{"action":"created","issue":{"url":"https://api.github.com/repos/vgteam/vg/issues/935","repository_url":"https://api.github.com/repos/vgteam/vg","labels_url":"https://api.github.com/repos/vgteam/vg/issues/935/labels{/name}","comments_url":"https://api.github.com/repos/vgteam/vg/issues/935/comments","events_url":"https://api.github.com/repos/vgteam/vg/issues/935/events","html_url":"https://github.com/vgteam/vg/pull/935","id":247475315,"number":935,"title":"Use parse_region() from xg.hpp","user":{"login":"glennhickey","id":901102,"avatar_url":"https://avatars3.githubusercontent.com/u/901102?v=4","gravatar_id":"","url":"https://api.github.com/users/glennhickey","html_url":"https://github.com/glennhickey","followers_url":"https://api.github.com/users/glennhickey/followers","following_url":"https://api.github.com/users/glennhickey/following{/other_user}","gists_url":"https://api.github.com/users/glennhickey/gists{/gist_id}","starred_url":"https://api.github.com/users/glennhickey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennhickey/subscriptions","organizations_url":"https://api.github.com/users/glennhickey/orgs","repos_url":"https://api.github.com/users/glennhickey/repos","events_url":"https://api.github.com/users/glennhickey/events{/privacy}","received_events_url":"https://api.github.com/users/glennhickey/received_events","type":"User","site_admin":false},"labels":[{"id":280142072,"url":"https://api.github.com/repos/vgteam/vg/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-02T18:08:50Z","updated_at":"2017-08-02T21:00:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vgteam/vg/pulls/935","html_url":"https://github.com/vgteam/vg/pull/935","diff_url":"https://github.com/vgteam/vg/pull/935.diff","patch_url":"https://github.com/vgteam/vg/pull/935.patch"},"body":"As complained about in #934, parse_region() was redefined a bunch of times.  This removes the definitions from path.cpp and region.cpp, so that everyone uses the one in xg.cpp.  If xg ever moves into vg, we can put it back in region.cpp which would be a bit cleaner.  \r\n\r\nWhatever was using the old region.cpp version, will now be different in that the start coordinate defaults to -1 instead of 0, and the end coordinate defaults to the start instead of start+1, but all the tests seem to pass. "},"comment":{"url":"https://api.github.com/repos/vgteam/vg/issues/comments/319796871","html_url":"https://github.com/vgteam/vg/pull/935#issuecomment-319796871","issue_url":"https://api.github.com/repos/vgteam/vg/issues/935","id":319796871,"user":{"login":"cgcloud-jenkins","id":12962446,"avatar_url":"https://avatars2.githubusercontent.com/u/12962446?v=4","gravatar_id":"","url":"https://api.github.com/users/cgcloud-jenkins","html_url":"https://github.com/cgcloud-jenkins","followers_url":"https://api.github.com/users/cgcloud-jenkins/followers","following_url":"https://api.github.com/users/cgcloud-jenkins/following{/other_user}","gists_url":"https://api.github.com/users/cgcloud-jenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/cgcloud-jenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgcloud-jenkins/subscriptions","organizations_url":"https://api.github.com/users/cgcloud-jenkins/orgs","repos_url":"https://api.github.com/users/cgcloud-jenkins/repos","events_url":"https://api.github.com/users/cgcloud-jenkins/events{/privacy}","received_events_url":"https://api.github.com/users/cgcloud-jenkins/received_events","type":"User","site_admin":false},"created_at":"2017-08-02T21:00:03Z","updated_at":"2017-08-02T21:00:03Z","body":"[Jenkins vg tests](http://jenkins.cgcloud.info/job/vg/294/) complete for [PR 935](https://github.com/vgteam/vg/pull/935).  View the [full report here](http://cgl-pipeline-inputs.s3.amazonaws.com/vg_cgl/vg_ci/jenkins_reports/commit/629e020985d7276f9240f080e6c1d36a5128f279/index.html).\n\n10 tests passed, 0 tests failed and 7 tests skipped in 7909 seconds\n\n"}}
{"actor":{"display_login":"cgcloud-jenkins"}}