{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/logstash/pulls/comments/137129143","pull_request_review_id":60756966,"id":137129143,"diff_hunk":"@@ -2,6 +2,16 @@\n logstash: 7.0.0-alpha1\n logstash-core: 7.0.0-alpha1\n logstash-core-plugin-api: 2.1.16\n+\n+# jruby must reference a *released* version of jruby which can be downloaded from the official download url\n+# *and* for which jars artifacts are published for compile-time\n jruby:\n   version: 9.1.12.0\n   sha1: 9b6c15d42eb11db7215d94dd9842ee5184a41fea\n+\n+# jruby-runtime, if specified, will override the jruby version installed in vendor/jruby for logstash runtime only,\n+# not for the compile-time jars\n+jruby-runtime:\n+  url: http://ci.jruby.org/snapshots/previous/jruby-bin-9.1.13.0-SNAPSHOT.tar.gz\n+  version: 9.1.13.0-SNAPSHOT\n+  sha1: 47560ccae3e30f8193cb5b40b8deef4a39fa094e","path":"versions.yml","position":16,"original_position":16,"commit_id":"feb00144e3fa1bee9b123e858d49719090b1ba65","original_commit_id":"feb00144e3fa1bee9b123e858d49719090b1ba65","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars1.githubusercontent.com/u/2010?v=4","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"body":"good point. ","created_at":"2017-09-05T22:16:34Z","updated_at":"2017-09-05T22:16:34Z","html_url":"https://github.com/elastic/logstash/pull/8144#discussion_r137129143","pull_request_url":"https://api.github.com/repos/elastic/logstash/pulls/8144","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments/137129143"},"html":{"href":"https://github.com/elastic/logstash/pull/8144#discussion_r137129143"},"pull_request":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8144"}},"in_reply_to_id":137128405},"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/8144","id":139397532,"html_url":"https://github.com/elastic/logstash/pull/8144","diff_url":"https://github.com/elastic/logstash/pull/8144.diff","patch_url":"https://github.com/elastic/logstash/pull/8144.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/8144","number":8144,"state":"open","locked":false,"title":"add option for different jruby runtime version","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars1.githubusercontent.com/u/2010?v=4","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"body":"Add support for an optional `jruby-runtime:` key in `versions.yml`. \r\n\r\nIf `jruby-runtime:` is specified it will override the **runtime** JRuby version installed in `vendor/jruby`. \r\n\r\nNote that the `jruby:` key will still be used to reference the compile-time *provided* jars in `build.gradle`. \r\n\r\nThis is useful to be able to use a JRuby pre-relase/snapshot version for the builds & specs or measure performance. \r\n\r\nThis PR also sets the `jruby-runtime:` to  9.1.13.0-SNAPSHOT so we can start testing against the fix  for the JRuby JIT problem #8006","created_at":"2017-09-05T19:04:20Z","updated_at":"2017-09-05T22:16:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48be71428f28ba76187f0e8edd42d5fede427d3d","assignee":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"assignees":[{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/8144/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/8144/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/8144/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/feb00144e3fa1bee9b123e858d49719090b1ba65","head":{"label":"colinsurprenant:jruby-versions","ref":"jruby-versions","sha":"feb00144e3fa1bee9b123e858d49719090b1ba65","user":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars1.githubusercontent.com/u/2010?v=4","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"repo":{"id":17155108,"name":"logstash","full_name":"colinsurprenant/logstash","owner":{"login":"colinsurprenant","id":2010,"avatar_url":"https://avatars1.githubusercontent.com/u/2010?v=4","gravatar_id":"","url":"https://api.github.com/users/colinsurprenant","html_url":"https://github.com/colinsurprenant","followers_url":"https://api.github.com/users/colinsurprenant/followers","following_url":"https://api.github.com/users/colinsurprenant/following{/other_user}","gists_url":"https://api.github.com/users/colinsurprenant/gists{/gist_id}","starred_url":"https://api.github.com/users/colinsurprenant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colinsurprenant/subscriptions","organizations_url":"https://api.github.com/users/colinsurprenant/orgs","repos_url":"https://api.github.com/users/colinsurprenant/repos","events_url":"https://api.github.com/users/colinsurprenant/events{/privacy}","received_events_url":"https://api.github.com/users/colinsurprenant/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colinsurprenant/logstash","description":"logstash - logs/event transport, processing, management, search.","fork":true,"url":"https://api.github.com/repos/colinsurprenant/logstash","forks_url":"https://api.github.com/repos/colinsurprenant/logstash/forks","keys_url":"https://api.github.com/repos/colinsurprenant/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colinsurprenant/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colinsurprenant/logstash/teams","hooks_url":"https://api.github.com/repos/colinsurprenant/logstash/hooks","issue_events_url":"https://api.github.com/repos/colinsurprenant/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/colinsurprenant/logstash/events","assignees_url":"https://api.github.com/repos/colinsurprenant/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/colinsurprenant/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/colinsurprenant/logstash/tags","blobs_url":"https://api.github.com/repos/colinsurprenant/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colinsurprenant/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colinsurprenant/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/colinsurprenant/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colinsurprenant/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/colinsurprenant/logstash/languages","stargazers_url":"https://api.github.com/repos/colinsurprenant/logstash/stargazers","contributors_url":"https://api.github.com/repos/colinsurprenant/logstash/contributors","subscribers_url":"https://api.github.com/repos/colinsurprenant/logstash/subscribers","subscription_url":"https://api.github.com/repos/colinsurprenant/logstash/subscription","commits_url":"https://api.github.com/repos/colinsurprenant/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/colinsurprenant/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/colinsurprenant/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/colinsurprenant/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/colinsurprenant/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/colinsurprenant/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colinsurprenant/logstash/merges","archive_url":"https://api.github.com/repos/colinsurprenant/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colinsurprenant/logstash/downloads","issues_url":"https://api.github.com/repos/colinsurprenant/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/colinsurprenant/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/colinsurprenant/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/colinsurprenant/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colinsurprenant/logstash/labels{/name}","releases_url":"https://api.github.com/repos/colinsurprenant/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/colinsurprenant/logstash/deployments","created_at":"2014-02-24T23:52:15Z","updated_at":"2015-04-13T10:39:50Z","pushed_at":"2017-09-05T20:09:45Z","git_url":"git://github.com/colinsurprenant/logstash.git","ssh_url":"git@github.com:colinsurprenant/logstash.git","clone_url":"https://github.com/colinsurprenant/logstash.git","svn_url":"https://github.com/colinsurprenant/logstash","homepage":"http://logstash.net/","size":95106,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"a14fbfc3e21e4a8662af2440074c3a3f37a3f370","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"Logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/logstash/deployments","created_at":"2010-11-18T01:31:50Z","updated_at":"2017-09-05T17:30:07Z","pushed_at":"2017-09-05T22:01:14Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":96034,"stargazers_count":7922,"watchers_count":7922,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2241,"mirror_url":null,"open_issues_count":986,"forks":2241,"open_issues":986,"watchers":7922,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8144"},"html":{"href":"https://github.com/elastic/logstash/pull/8144"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/8144"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/8144/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8144/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8144/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/feb00144e3fa1bee9b123e858d49719090b1ba65"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"colinsurprenant"}}