{"action":"created","comment":{"url":"https://api.github.com/repos/spotify/styx/pulls/comments/148779857","pull_request_review_id":74076800,"id":148779857,"diff_hunk":"@@ -49,17 +48,15 @@\n \n   private final StateFactory stateFactory;\n   private final StateManager stateManager;\n-  private final Storage storage;\n \n-  StateInitializingTrigger(StateFactory stateFactory, StateManager stateManager, Storage storage) {\n+  StateInitializingTrigger(StateFactory stateFactory, StateManager stateManager) {\n     this.stateFactory = Objects.requireNonNull(stateFactory);\n     this.stateManager = Objects.requireNonNull(stateManager);\n-    this.storage = Objects.requireNonNull(storage);\n   }\n \n   @Override\n   public CompletionStage<Void> event(Workflow workflow, Trigger trigger, Instant instant) {\n-    if (!WorkflowValidator.hasDockerConfiguration(workflow, storage)) {","path":"styx-scheduler-service/src/main/java/com/spotify/styx/StateInitializingTrigger.java","position":23,"original_position":23,"commit_id":"0a1c8539059e6245c4d67d4dcadba9c4acd8f0ad","original_commit_id":"0a1c8539059e6245c4d67d4dcadba9c4acd8f0ad","user":{"login":"bergman","id":76548,"avatar_url":"https://avatars0.githubusercontent.com/u/76548?v=4","gravatar_id":"","url":"https://api.github.com/users/bergman","html_url":"https://github.com/bergman","followers_url":"https://api.github.com/users/bergman/followers","following_url":"https://api.github.com/users/bergman/following{/other_user}","gists_url":"https://api.github.com/users/bergman/gists{/gist_id}","starred_url":"https://api.github.com/users/bergman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergman/subscriptions","organizations_url":"https://api.github.com/users/bergman/orgs","repos_url":"https://api.github.com/users/bergman/repos","events_url":"https://api.github.com/users/bergman/events{/privacy}","received_events_url":"https://api.github.com/users/bergman/received_events","type":"User","site_admin":false},"body":"agreed, we should rework the workflow cache soon","created_at":"2017-11-03T13:24:12Z","updated_at":"2017-11-03T13:24:12Z","html_url":"https://github.com/spotify/styx/pull/318#discussion_r148779857","pull_request_url":"https://api.github.com/repos/spotify/styx/pulls/318","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/spotify/styx/pulls/comments/148779857"},"html":{"href":"https://github.com/spotify/styx/pull/318#discussion_r148779857"},"pull_request":{"href":"https://api.github.com/repos/spotify/styx/pulls/318"}},"in_reply_to_id":148751881},"pull_request":{"url":"https://api.github.com/repos/spotify/styx/pulls/318","id":149759556,"html_url":"https://github.com/spotify/styx/pull/318","diff_url":"https://github.com/spotify/styx/pull/318.diff","patch_url":"https://github.com/spotify/styx/pull/318.patch","issue_url":"https://api.github.com/repos/spotify/styx/issues/318","number":318,"state":"open","locked":false,"title":"Remove dockerImage and commitSha from WorkflowState","user":{"login":"bergman","id":76548,"avatar_url":"https://avatars0.githubusercontent.com/u/76548?v=4","gravatar_id":"","url":"https://api.github.com/users/bergman","html_url":"https://github.com/bergman","followers_url":"https://api.github.com/users/bergman/followers","following_url":"https://api.github.com/users/bergman/following{/other_user}","gists_url":"https://api.github.com/users/bergman/gists{/gist_id}","starred_url":"https://api.github.com/users/bergman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergman/subscriptions","organizations_url":"https://api.github.com/users/bergman/orgs","repos_url":"https://api.github.com/users/bergman/repos","events_url":"https://api.github.com/users/bergman/events{/privacy}","received_events_url":"https://api.github.com/users/bergman/received_events","type":"User","site_admin":false},"body":"~~this is not as harsh as #315 , keeping wf state for reading still but populating from wf configuration~~\r\n\r\nthis is just as harsh now","created_at":"2017-10-31T11:28:03Z","updated_at":"2017-11-03T13:24:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6efb83725dabe1de9020501b024d0d96b4d87d27","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/spotify/styx/pulls/318/commits","review_comments_url":"https://api.github.com/repos/spotify/styx/pulls/318/comments","review_comment_url":"https://api.github.com/repos/spotify/styx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/styx/issues/318/comments","statuses_url":"https://api.github.com/repos/spotify/styx/statuses/0a1c8539059e6245c4d67d4dcadba9c4acd8f0ad","head":{"label":"spotify:use-wfconf-where-possible","ref":"use-wfconf-where-possible","sha":"0a1c8539059e6245c4d67d4dcadba9c4acd8f0ad","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":74431644,"name":"styx","full_name":"spotify/styx","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/styx","description":"The path to execution","fork":false,"url":"https://api.github.com/repos/spotify/styx","forks_url":"https://api.github.com/repos/spotify/styx/forks","keys_url":"https://api.github.com/repos/spotify/styx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/styx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/styx/teams","hooks_url":"https://api.github.com/repos/spotify/styx/hooks","issue_events_url":"https://api.github.com/repos/spotify/styx/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/styx/events","assignees_url":"https://api.github.com/repos/spotify/styx/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/styx/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/styx/tags","blobs_url":"https://api.github.com/repos/spotify/styx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/styx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/styx/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/styx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/styx/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/styx/languages","stargazers_url":"https://api.github.com/repos/spotify/styx/stargazers","contributors_url":"https://api.github.com/repos/spotify/styx/contributors","subscribers_url":"https://api.github.com/repos/spotify/styx/subscribers","subscription_url":"https://api.github.com/repos/spotify/styx/subscription","commits_url":"https://api.github.com/repos/spotify/styx/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/styx/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/styx/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/styx/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/styx/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/styx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/styx/merges","archive_url":"https://api.github.com/repos/spotify/styx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/styx/downloads","issues_url":"https://api.github.com/repos/spotify/styx/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/styx/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/styx/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/styx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/styx/labels{/name}","releases_url":"https://api.github.com/repos/spotify/styx/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/styx/deployments","created_at":"2016-11-22T03:44:55Z","updated_at":"2017-11-01T20:14:50Z","pushed_at":"2017-11-03T08:47:26Z","git_url":"git://github.com/spotify/styx.git","ssh_url":"git@github.com:spotify/styx.git","clone_url":"https://github.com/spotify/styx.git","svn_url":"https://github.com/spotify/styx","homepage":"","size":3330,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":20,"forks":9,"open_issues":20,"watchers":59,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"18a0052d84e2760b7e08e43ea164b32b20235f9a","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":74431644,"name":"styx","full_name":"spotify/styx","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/styx","description":"The path to execution","fork":false,"url":"https://api.github.com/repos/spotify/styx","forks_url":"https://api.github.com/repos/spotify/styx/forks","keys_url":"https://api.github.com/repos/spotify/styx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/styx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/styx/teams","hooks_url":"https://api.github.com/repos/spotify/styx/hooks","issue_events_url":"https://api.github.com/repos/spotify/styx/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/styx/events","assignees_url":"https://api.github.com/repos/spotify/styx/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/styx/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/styx/tags","blobs_url":"https://api.github.com/repos/spotify/styx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/styx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/styx/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/styx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/styx/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/styx/languages","stargazers_url":"https://api.github.com/repos/spotify/styx/stargazers","contributors_url":"https://api.github.com/repos/spotify/styx/contributors","subscribers_url":"https://api.github.com/repos/spotify/styx/subscribers","subscription_url":"https://api.github.com/repos/spotify/styx/subscription","commits_url":"https://api.github.com/repos/spotify/styx/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/styx/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/styx/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/styx/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/styx/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/styx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/styx/merges","archive_url":"https://api.github.com/repos/spotify/styx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/styx/downloads","issues_url":"https://api.github.com/repos/spotify/styx/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/styx/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/styx/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/styx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/styx/labels{/name}","releases_url":"https://api.github.com/repos/spotify/styx/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/styx/deployments","created_at":"2016-11-22T03:44:55Z","updated_at":"2017-11-01T20:14:50Z","pushed_at":"2017-11-03T08:47:26Z","git_url":"git://github.com/spotify/styx.git","ssh_url":"git@github.com:spotify/styx.git","clone_url":"https://github.com/spotify/styx.git","svn_url":"https://github.com/spotify/styx","homepage":"","size":3330,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":20,"forks":9,"open_issues":20,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/styx/pulls/318"},"html":{"href":"https://github.com/spotify/styx/pull/318"},"issue":{"href":"https://api.github.com/repos/spotify/styx/issues/318"},"comments":{"href":"https://api.github.com/repos/spotify/styx/issues/318/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/styx/pulls/318/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/styx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/styx/pulls/318/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/styx/statuses/0a1c8539059e6245c4d67d4dcadba9c4acd8f0ad"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bergman"}}