{"action":"created","comment":{"url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/pulls/comments/118106270","pull_request_review_id":39868309,"id":118106270,"diff_hunk":"@@ -11,6 +11,11 @@ require \"lib.pl\";\n \n my $dbh = DbiTestConnect($test_dsn, $test_user, $test_password, { mysql_enable_utf8 => 1, PrintError => 1, RaiseError => 1 });\n \n+if (!MinimumVersion($dbh, '5.5')) {\n+    plan skip_all =>\n+        \"SKIP TEST: You must have MySQL version 5.5 or greater for this test to run\";","path":"t/55utf8_jp.t","position":6,"original_position":6,"commit_id":"a20bf845518f1e3513ec2b6399a3d83d726112ba","original_commit_id":"a20bf845518f1e3513ec2b6399a3d83d726112ba","user":{"login":"pali","id":7141871,"avatar_url":"https://avatars0.githubusercontent.com/u/7141871?v=3","gravatar_id":"","url":"https://api.github.com/users/pali","html_url":"https://github.com/pali","followers_url":"https://api.github.com/users/pali/followers","following_url":"https://api.github.com/users/pali/following{/other_user}","gists_url":"https://api.github.com/users/pali/gists{/gist_id}","starred_url":"https://api.github.com/users/pali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pali/subscriptions","organizations_url":"https://api.github.com/users/pali/orgs","repos_url":"https://api.github.com/users/pali/repos","events_url":"https://api.github.com/users/pali/events{/privacy}","received_events_url":"https://api.github.com/users/pali/received_events","type":"User","site_admin":false},"body":"Why is this test skipped before 5.5? On Travis it is working...\r\nMySQL 5.1: https://travis-ci.org/perl5-dbi/DBD-mysql/jobs/227161603\r\nMySQL 5.0: https://travis-ci.org/perl5-dbi/DBD-mysql/jobs/227161601\r\nMySQL 4.1: https://travis-ci.org/perl5-dbi/DBD-mysql/jobs/227161599","created_at":"2017-05-23T21:04:23Z","updated_at":"2017-05-23T21:08:27Z","html_url":"https://github.com/perl5-dbi/DBD-mysql/pull/127#discussion_r118106270","pull_request_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/pulls/127","_links":{"self":{"href":"https://api.github.com/repos/perl5-dbi/DBD-mysql/pulls/comments/118106270"},"html":{"href":"https://github.com/perl5-dbi/DBD-mysql/pull/127#discussion_r118106270"},"pull_request":{"href":"https://api.github.com/repos/perl5-dbi/DBD-mysql/pulls/127"}}},"pull_request":{"url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/pulls/127","id":121925853,"html_url":"https://github.com/perl5-dbi/DBD-mysql/pull/127","diff_url":"https://github.com/perl5-dbi/DBD-mysql/pull/127.diff","patch_url":"https://github.com/perl5-dbi/DBD-mysql/pull/127.patch","issue_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/issues/127","number":127,"state":"closed","locked":false,"title":"Added skip logic for unsupported MySQL Server versions","user":{"login":"ikari7789","id":1041215,"avatar_url":"https://avatars2.githubusercontent.com/u/1041215?v=3","gravatar_id":"","url":"https://api.github.com/users/ikari7789","html_url":"https://github.com/ikari7789","followers_url":"https://api.github.com/users/ikari7789/followers","following_url":"https://api.github.com/users/ikari7789/following{/other_user}","gists_url":"https://api.github.com/users/ikari7789/gists{/gist_id}","starred_url":"https://api.github.com/users/ikari7789/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikari7789/subscriptions","organizations_url":"https://api.github.com/users/ikari7789/orgs","repos_url":"https://api.github.com/users/ikari7789/repos","events_url":"https://api.github.com/users/ikari7789/events{/privacy}","received_events_url":"https://api.github.com/users/ikari7789/received_events","type":"User","site_admin":false},"body":"Added logic to skip tests when they are ran against a version of MySQL that doesn't support the feature being tested.","created_at":"2017-05-23T06:59:43Z","updated_at":"2017-05-23T21:08:27Z","closed_at":"2017-05-23T20:03:55Z","merged_at":"2017-05-23T20:03:55Z","merge_commit_sha":"c734a966df7947e45e77eff47d01dca793e2048f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/pulls/127/commits","review_comments_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/pulls/127/comments","review_comment_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/issues/127/comments","statuses_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/statuses/a20bf845518f1e3513ec2b6399a3d83d726112ba","head":{"label":"ikari7789:add-additional-checks-in-tests","ref":"add-additional-checks-in-tests","sha":"a20bf845518f1e3513ec2b6399a3d83d726112ba","user":{"login":"ikari7789","id":1041215,"avatar_url":"https://avatars2.githubusercontent.com/u/1041215?v=3","gravatar_id":"","url":"https://api.github.com/users/ikari7789","html_url":"https://github.com/ikari7789","followers_url":"https://api.github.com/users/ikari7789/followers","following_url":"https://api.github.com/users/ikari7789/following{/other_user}","gists_url":"https://api.github.com/users/ikari7789/gists{/gist_id}","starred_url":"https://api.github.com/users/ikari7789/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikari7789/subscriptions","organizations_url":"https://api.github.com/users/ikari7789/orgs","repos_url":"https://api.github.com/users/ikari7789/repos","events_url":"https://api.github.com/users/ikari7789/events{/privacy}","received_events_url":"https://api.github.com/users/ikari7789/received_events","type":"User","site_admin":false},"repo":{"id":61691179,"name":"DBD-mysql","full_name":"ikari7789/DBD-mysql","owner":{"login":"ikari7789","id":1041215,"avatar_url":"https://avatars2.githubusercontent.com/u/1041215?v=3","gravatar_id":"","url":"https://api.github.com/users/ikari7789","html_url":"https://github.com/ikari7789","followers_url":"https://api.github.com/users/ikari7789/followers","following_url":"https://api.github.com/users/ikari7789/following{/other_user}","gists_url":"https://api.github.com/users/ikari7789/gists{/gist_id}","starred_url":"https://api.github.com/users/ikari7789/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikari7789/subscriptions","organizations_url":"https://api.github.com/users/ikari7789/orgs","repos_url":"https://api.github.com/users/ikari7789/repos","events_url":"https://api.github.com/users/ikari7789/events{/privacy}","received_events_url":"https://api.github.com/users/ikari7789/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ikari7789/DBD-mysql","description":"MySQL driver for the Perl5 Database Interface (DBI)","fork":true,"url":"https://api.github.com/repos/ikari7789/DBD-mysql","forks_url":"https://api.github.com/repos/ikari7789/DBD-mysql/forks","keys_url":"https://api.github.com/repos/ikari7789/DBD-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ikari7789/DBD-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ikari7789/DBD-mysql/teams","hooks_url":"https://api.github.com/repos/ikari7789/DBD-mysql/hooks","issue_events_url":"https://api.github.com/repos/ikari7789/DBD-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/ikari7789/DBD-mysql/events","assignees_url":"https://api.github.com/repos/ikari7789/DBD-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/ikari7789/DBD-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/ikari7789/DBD-mysql/tags","blobs_url":"https://api.github.com/repos/ikari7789/DBD-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ikari7789/DBD-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ikari7789/DBD-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/ikari7789/DBD-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ikari7789/DBD-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/ikari7789/DBD-mysql/languages","stargazers_url":"https://api.github.com/repos/ikari7789/DBD-mysql/stargazers","contributors_url":"https://api.github.com/repos/ikari7789/DBD-mysql/contributors","subscribers_url":"https://api.github.com/repos/ikari7789/DBD-mysql/subscribers","subscription_url":"https://api.github.com/repos/ikari7789/DBD-mysql/subscription","commits_url":"https://api.github.com/repos/ikari7789/DBD-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/ikari7789/DBD-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/ikari7789/DBD-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/ikari7789/DBD-mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/ikari7789/DBD-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/ikari7789/DBD-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ikari7789/DBD-mysql/merges","archive_url":"https://api.github.com/repos/ikari7789/DBD-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ikari7789/DBD-mysql/downloads","issues_url":"https://api.github.com/repos/ikari7789/DBD-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/ikari7789/DBD-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/ikari7789/DBD-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/ikari7789/DBD-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ikari7789/DBD-mysql/labels{/name}","releases_url":"https://api.github.com/repos/ikari7789/DBD-mysql/releases{/id}","deployments_url":"https://api.github.com/repos/ikari7789/DBD-mysql/deployments","created_at":"2016-06-22T05:23:07Z","updated_at":"2016-06-22T05:23:08Z","pushed_at":"2017-05-23T07:00:37Z","git_url":"git://github.com/ikari7789/DBD-mysql.git","ssh_url":"git@github.com:ikari7789/DBD-mysql.git","clone_url":"https://github.com/ikari7789/DBD-mysql.git","svn_url":"https://github.com/ikari7789/DBD-mysql","homepage":"https://metacpan.org/module/DBD::mysql","size":2063,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"perl5-dbi:master","ref":"master","sha":"d67abbf9ecb0faf0556799f0287361012ce03843","user":{"login":"perl5-dbi","id":4020603,"avatar_url":"https://avatars2.githubusercontent.com/u/4020603?v=3","gravatar_id":"","url":"https://api.github.com/users/perl5-dbi","html_url":"https://github.com/perl5-dbi","followers_url":"https://api.github.com/users/perl5-dbi/followers","following_url":"https://api.github.com/users/perl5-dbi/following{/other_user}","gists_url":"https://api.github.com/users/perl5-dbi/gists{/gist_id}","starred_url":"https://api.github.com/users/perl5-dbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perl5-dbi/subscriptions","organizations_url":"https://api.github.com/users/perl5-dbi/orgs","repos_url":"https://api.github.com/users/perl5-dbi/repos","events_url":"https://api.github.com/users/perl5-dbi/events{/privacy}","received_events_url":"https://api.github.com/users/perl5-dbi/received_events","type":"Organization","site_admin":false},"repo":{"id":12426816,"name":"DBD-mysql","full_name":"perl5-dbi/DBD-mysql","owner":{"login":"perl5-dbi","id":4020603,"avatar_url":"https://avatars2.githubusercontent.com/u/4020603?v=3","gravatar_id":"","url":"https://api.github.com/users/perl5-dbi","html_url":"https://github.com/perl5-dbi","followers_url":"https://api.github.com/users/perl5-dbi/followers","following_url":"https://api.github.com/users/perl5-dbi/following{/other_user}","gists_url":"https://api.github.com/users/perl5-dbi/gists{/gist_id}","starred_url":"https://api.github.com/users/perl5-dbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/perl5-dbi/subscriptions","organizations_url":"https://api.github.com/users/perl5-dbi/orgs","repos_url":"https://api.github.com/users/perl5-dbi/repos","events_url":"https://api.github.com/users/perl5-dbi/events{/privacy}","received_events_url":"https://api.github.com/users/perl5-dbi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/perl5-dbi/DBD-mysql","description":"MySQL driver for the Perl5 Database Interface (DBI)","fork":false,"url":"https://api.github.com/repos/perl5-dbi/DBD-mysql","forks_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/forks","keys_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/teams","hooks_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/hooks","issue_events_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/issues/events{/number}","events_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/events","assignees_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/assignees{/user}","branches_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/branches{/branch}","tags_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/tags","blobs_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/git/refs{/sha}","trees_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/statuses/{sha}","languages_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/languages","stargazers_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/stargazers","contributors_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/contributors","subscribers_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/subscribers","subscription_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/subscription","commits_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/commits{/sha}","git_commits_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/git/commits{/sha}","comments_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/comments{/number}","issue_comment_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/issues/comments{/number}","contents_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/contents/{+path}","compare_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/merges","archive_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/downloads","issues_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/issues{/number}","pulls_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/pulls{/number}","milestones_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/milestones{/number}","notifications_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/labels{/name}","releases_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/releases{/id}","deployments_url":"https://api.github.com/repos/perl5-dbi/DBD-mysql/deployments","created_at":"2013-08-28T06:54:08Z","updated_at":"2017-04-03T14:07:16Z","pushed_at":"2017-05-23T20:04:11Z","git_url":"git://github.com/perl5-dbi/DBD-mysql.git","ssh_url":"git@github.com:perl5-dbi/DBD-mysql.git","clone_url":"https://github.com/perl5-dbi/DBD-mysql.git","svn_url":"https://github.com/perl5-dbi/DBD-mysql","homepage":"https://metacpan.org/module/DBD::mysql","size":2069,"stargazers_count":21,"watchers_count":21,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":7,"forks":36,"open_issues":7,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/perl5-dbi/DBD-mysql/pulls/127"},"html":{"href":"https://github.com/perl5-dbi/DBD-mysql/pull/127"},"issue":{"href":"https://api.github.com/repos/perl5-dbi/DBD-mysql/issues/127"},"comments":{"href":"https://api.github.com/repos/perl5-dbi/DBD-mysql/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/perl5-dbi/DBD-mysql/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/perl5-dbi/DBD-mysql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/perl5-dbi/DBD-mysql/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/perl5-dbi/DBD-mysql/statuses/a20bf845518f1e3513ec2b6399a3d83d726112ba"}}}}
{"actor":{"display_login":"pali"}}