{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments/122971646","pull_request_review_id":45131217,"id":122971646,"diff_hunk":"@@ -20,7 +20,7 @@ public protocol NavigationViewControllerDelegate {\n     /**\n      Called when the user arrives at the destination.\n      */\n-    @objc optional func navigationViewController(_ navigationViewController : NavigationViewController, didArriveAt destination: MGLAnnotation)\n+    @objc optional func navigationViewController(_ navigationViewController : NavigationViewController, didArriveAt destination: Waypoint)","path":"MapboxNavigation/NavigationViewController.swift","position":5,"original_position":5,"commit_id":"988dfd0cafc154b6b59d20637ccc5cdf7c804f42","original_commit_id":"cbe2ce1e93a81a3e939b5df7f3e33ebdebf69c28","user":{"login":"bsudekum","id":1058624,"avatar_url":"https://avatars3.githubusercontent.com/u/1058624?v=3","gravatar_id":"","url":"https://api.github.com/users/bsudekum","html_url":"https://github.com/bsudekum","followers_url":"https://api.github.com/users/bsudekum/followers","following_url":"https://api.github.com/users/bsudekum/following{/other_user}","gists_url":"https://api.github.com/users/bsudekum/gists{/gist_id}","starred_url":"https://api.github.com/users/bsudekum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsudekum/subscriptions","organizations_url":"https://api.github.com/users/bsudekum/orgs","repos_url":"https://api.github.com/users/bsudekum/repos","events_url":"https://api.github.com/users/bsudekum/events{/privacy}","received_events_url":"https://api.github.com/users/bsudekum/received_events","type":"User","site_admin":false},"body":"I think one method is good enough here.","created_at":"2017-06-20T13:15:15Z","updated_at":"2017-06-20T13:15:15Z","html_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/270#discussion_r122971646","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/270","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments/122971646"},"html":{"href":"https://github.com/mapbox/mapbox-navigation-ios/pull/270#discussion_r122971646"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/270"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/270","id":124750145,"html_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/270","diff_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/270.diff","patch_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/270.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/270","number":270,"state":"open","locked":false,"title":"Add waypoint handling","user":{"login":"bsudekum","id":1058624,"avatar_url":"https://avatars3.githubusercontent.com/u/1058624?v=3","gravatar_id":"","url":"https://api.github.com/users/bsudekum","html_url":"https://github.com/bsudekum","followers_url":"https://api.github.com/users/bsudekum/followers","following_url":"https://api.github.com/users/bsudekum/following{/other_user}","gists_url":"https://api.github.com/users/bsudekum/gists{/gist_id}","starred_url":"https://api.github.com/users/bsudekum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsudekum/subscriptions","organizations_url":"https://api.github.com/users/bsudekum/orgs","repos_url":"https://api.github.com/users/bsudekum/repos","events_url":"https://api.github.com/users/bsudekum/events{/privacy}","received_events_url":"https://api.github.com/users/bsudekum/received_events","type":"User","site_admin":false},"body":"_Very work in progress_\r\n\r\nTo do:\r\n\r\n- [x] Add waypoint handling to example app\r\n- [ ] Improve instructions upon approaching leg destination\r\n- [ ] ~~Add UI elements for arriving and leaving waypoint~~\r\n\r\n/cc @1ec5 @frederoni @cammace @ericrwolfe ","created_at":"2017-06-08T21:38:16Z","updated_at":"2017-06-20T13:15:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a3fcb3a41a8dd4c69b5d7856b2047f57c966afe","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/270/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/270/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/270/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/988dfd0cafc154b6b59d20637ccc5cdf7c804f42","head":{"label":"mapbox:waypoints","ref":"waypoints","sha":"988dfd0cafc154b6b59d20637ccc5cdf7c804f42","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars2.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":73870932,"name":"mapbox-navigation-ios","full_name":"mapbox/mapbox-navigation-ios","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars2.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-navigation-ios","description":"Turn-by-turn navigation logic and UI in Swift or Objective-C on iOS","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios","forks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/deployments","created_at":"2016-11-16T01:23:44Z","updated_at":"2017-06-16T15:08:57Z","pushed_at":"2017-06-20T12:21:51Z","git_url":"git://github.com/mapbox/mapbox-navigation-ios.git","ssh_url":"git@github.com:mapbox/mapbox-navigation-ios.git","clone_url":"https://github.com/mapbox/mapbox-navigation-ios.git","svn_url":"https://github.com/mapbox/mapbox-navigation-ios","homepage":"https://www.mapbox.com/navigation-sdk/","size":8230,"stargazers_count":83,"watchers_count":83,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"open_issues_count":50,"forks":34,"open_issues":50,"watchers":83,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"f6b6557d081555439d67ca4f69ee25accddddc58","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars2.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":73870932,"name":"mapbox-navigation-ios","full_name":"mapbox/mapbox-navigation-ios","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars2.githubusercontent.com/u/600935?v=3","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-navigation-ios","description":"Turn-by-turn navigation logic and UI in Swift or Objective-C on iOS","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios","forks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/deployments","created_at":"2016-11-16T01:23:44Z","updated_at":"2017-06-16T15:08:57Z","pushed_at":"2017-06-20T12:21:51Z","git_url":"git://github.com/mapbox/mapbox-navigation-ios.git","ssh_url":"git@github.com:mapbox/mapbox-navigation-ios.git","clone_url":"https://github.com/mapbox/mapbox-navigation-ios.git","svn_url":"https://github.com/mapbox/mapbox-navigation-ios","homepage":"https://www.mapbox.com/navigation-sdk/","size":8230,"stargazers_count":83,"watchers_count":83,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":34,"mirror_url":null,"open_issues_count":50,"forks":34,"open_issues":50,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/270"},"html":{"href":"https://github.com/mapbox/mapbox-navigation-ios/pull/270"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/270"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/988dfd0cafc154b6b59d20637ccc5cdf7c804f42"}}}}
{"actor":{"display_login":"bsudekum"}}