{"action":"created","issue":{"url":"https://api.github.com/repos/richardasaurus/imdb-pie/issues/18","repository_url":"https://api.github.com/repos/richardasaurus/imdb-pie","labels_url":"https://api.github.com/repos/richardasaurus/imdb-pie/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/richardasaurus/imdb-pie/issues/18/comments","events_url":"https://api.github.com/repos/richardasaurus/imdb-pie/issues/18/events","html_url":"https://github.com/richardasaurus/imdb-pie/issues/18","id":100335081,"number":18,"title":"Inconsistent results for title_exists()","user":{"login":"sijis","id":618177,"avatar_url":"https://avatars2.githubusercontent.com/u/618177?v=4","gravatar_id":"","url":"https://api.github.com/users/sijis","html_url":"https://github.com/sijis","followers_url":"https://api.github.com/users/sijis/followers","following_url":"https://api.github.com/users/sijis/following{/other_user}","gists_url":"https://api.github.com/users/sijis/gists{/gist_id}","starred_url":"https://api.github.com/users/sijis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijis/subscriptions","organizations_url":"https://api.github.com/users/sijis/orgs","repos_url":"https://api.github.com/users/sijis/repos","events_url":"https://api.github.com/users/sijis/events{/privacy}","received_events_url":"https://api.github.com/users/sijis/received_events","type":"User","site_admin":false},"labels":[{"id":23673564,"url":"https://api.github.com/repos/richardasaurus/imdb-pie/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2015-08-11T15:10:35Z","updated_at":"2017-12-24T23:31:20Z","closed_at":"2017-12-24T23:31:20Z","author_association":"NONE","body":"Hi,\n\nIn testing out some functionality (imdbpie (4.0.2)), I noticed that the title_exists() method is inconsistent. I would expect that the method would either return True or False, but in some instances I receive a HTTPError.\n\nThe odd thing is that if I have enough bad characters, I get the False response, as expected. \n\n``` python\nIn [1]: import imdbpie\n\nIn [2]: imdb = imdbpie.Imdb()\n..\nIn [53]: imdb.title_exists('tt123456')\n---------------------------------------------------------------------------\nHTTPError                                 Traceback (most recent call last)\n<ipython-input-53-7664b9a92afc> in <module>()\n----> 1 imdb.title_exists('tt123456')\n\n/home/saviles/virtualenvs/errbot-py3.4.1/lib/python3.4/site-packages/imdbpie/imdbpie.py in title_exists(self, imdb_id)\n    100             return False\n    101         else:\n--> 102             response.raise_for_status()\n    103 \n    104     def search_for_person(self, name):\n\n/home/saviles/virtualenvs/errbot-py3.4.1/lib/python3.4/site-packages/requests/models.py in raise_for_status(self)\n    849 \n    850         if http_error_msg:\n--> 851             raise HTTPError(http_error_msg, response=self)\n    852 \n    853     def close(self):\n\nHTTPError: 405 Client Error: Method Not Allowed\n\nIn [54]: imdb.title_exists('tt1234567')\nOut[54]: True\n\nIn [55]: imdb.title_exists('tt1234567890')\nOut[55]: False\n\nIn [56]: \n...\n```\n\nAlso, it also appears that it movie_id must begin with 'tt' otherwise it always returns the HTTPError\n\n``` python\n\nIn [56]: imdb.title_exists('123456')\n---------------------------------------------------------------------------\nHTTPError                                 Traceback (most recent call last)\n<ipython-input-56-ff2c3862f9a6> in <module>()\n----> 1 imdb.title_exists('123456')\n\n/home/saviles/virtualenvs/errbot-py3.4.1/lib/python3.4/site-packages/imdbpie/imdbpie.py in title_exists(self, imdb_id)\n    100             return False\n    101         else:\n--> 102             response.raise_for_status()\n    103 \n    104     def search_for_person(self, name):\n\n/home/saviles/virtualenvs/errbot-py3.4.1/lib/python3.4/site-packages/requests/models.py in raise_for_status(self)\n    849 \n    850         if http_error_msg:\n--> 851             raise HTTPError(http_error_msg, response=self)\n    852 \n    853     def close(self):\n\nHTTPError: 405 Client Error: Method Not Allowed\n\nIn [57]: imdb.title_exists('1234567')\n---------------------------------------------------------------------------\nHTTPError                                 Traceback (most recent call last)\n<ipython-input-57-416ef5e2c95d> in <module>()\n----> 1 imdb.title_exists('1234567')\n\n/home/saviles/virtualenvs/errbot-py3.4.1/lib/python3.4/site-packages/imdbpie/imdbpie.py in title_exists(self, imdb_id)\n    100             return False\n    101         else:\n--> 102             response.raise_for_status()\n    103 \n    104     def search_for_person(self, name):\n\n/home/saviles/virtualenvs/errbot-py3.4.1/lib/python3.4/site-packages/requests/models.py in raise_for_status(self)\n    849 \n    850         if http_error_msg:\n--> 851             raise HTTPError(http_error_msg, response=self)\n    852 \n    853     def close(self):\n\nHTTPError: 405 Client Error: Method Not Allowed\n\nIn [58]: imdb.title_exists('1234567890')\n---------------------------------------------------------------------------\nHTTPError                                 Traceback (most recent call last)\n<ipython-input-58-bdb8214432ec> in <module>()\n----> 1 imdb.title_exists('1234567890')\n\n/home/saviles/virtualenvs/errbot-py3.4.1/lib/python3.4/site-packages/imdbpie/imdbpie.py in title_exists(self, imdb_id)\n    100             return False\n    101         else:\n--> 102             response.raise_for_status()\n    103 \n    104     def search_for_person(self, name):\n\n/home/saviles/virtualenvs/errbot-py3.4.1/lib/python3.4/site-packages/requests/models.py in raise_for_status(self)\n    849 \n    850         if http_error_msg:\n--> 851             raise HTTPError(http_error_msg, response=self)\n    852 \n    853     def close(self):\n\nHTTPError: 405 Client Error: Method Not Allowed\n\n```\n"},"comment":{"url":"https://api.github.com/repos/richardasaurus/imdb-pie/issues/comments/353807429","html_url":"https://github.com/richardasaurus/imdb-pie/issues/18#issuecomment-353807429","issue_url":"https://api.github.com/repos/richardasaurus/imdb-pie/issues/18","id":353807429,"user":{"login":"richardasaurus","id":2279659,"avatar_url":"https://avatars1.githubusercontent.com/u/2279659?v=4","gravatar_id":"","url":"https://api.github.com/users/richardasaurus","html_url":"https://github.com/richardasaurus","followers_url":"https://api.github.com/users/richardasaurus/followers","following_url":"https://api.github.com/users/richardasaurus/following{/other_user}","gists_url":"https://api.github.com/users/richardasaurus/gists{/gist_id}","starred_url":"https://api.github.com/users/richardasaurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardasaurus/subscriptions","organizations_url":"https://api.github.com/users/richardasaurus/orgs","repos_url":"https://api.github.com/users/richardasaurus/repos","events_url":"https://api.github.com/users/richardasaurus/events{/privacy}","received_events_url":"https://api.github.com/users/richardasaurus/received_events","type":"User","site_admin":false},"created_at":"2017-12-24T23:31:20Z","updated_at":"2017-12-24T23:31:20Z","author_association":"OWNER","body":"this is fixed in version `4.4.0`"}}
{"actor":{"display_login":"richardasaurus"}}