{"action":"created","comment":{"url":"https://api.github.com/repos/coala/coala/pulls/comments/148928677","pull_request_review_id":74253181,"id":148928677,"diff_hunk":"@@ -235,11 +237,18 @@ def _schedule_bears(self, bears):\n                 logging.debug('Scheduled {!r} (tasks: {})'.format(bear,\n                                                                   len(tasks)))\n \n+                # Cleanup bears without tasks after all bears had the chance to\n+                # schedule their tasks. Not doing so might stop the run too\n+                # early, as the cleanup is also responsible for stopping the\n+                # event-loop when no more tasks do exist.\n                 if not tasks:\n-                    # We need to recheck our runtime if something is left to\n-                    # process, as when no tasks were offloaded the event-loop\n-                    # could hang up otherwise.\n-                    self._cleanup_bear(bear)\n+                    bears_without_tasks_to_cleanup.append(bear)","path":"coalib/core/Core.py","position":22,"original_position":22,"commit_id":"231b747123a6a23b4d34fb133421ab9c34b452c4","original_commit_id":"231b747123a6a23b4d34fb133421ab9c34b452c4","user":{"login":"shreyans800755","id":3727351,"avatar_url":"https://avatars2.githubusercontent.com/u/3727351?v=4","gravatar_id":"","url":"https://api.github.com/users/shreyans800755","html_url":"https://github.com/shreyans800755","followers_url":"https://api.github.com/users/shreyans800755/followers","following_url":"https://api.github.com/users/shreyans800755/following{/other_user}","gists_url":"https://api.github.com/users/shreyans800755/gists{/gist_id}","starred_url":"https://api.github.com/users/shreyans800755/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shreyans800755/subscriptions","organizations_url":"https://api.github.com/users/shreyans800755/orgs","repos_url":"https://api.github.com/users/shreyans800755/repos","events_url":"https://api.github.com/users/shreyans800755/events{/privacy}","received_events_url":"https://api.github.com/users/shreyans800755/received_events","type":"User","site_admin":false},"body":"Oh my bad. Can be done in different commit.","created_at":"2017-11-04T11:53:01Z","updated_at":"2017-11-04T11:59:56Z","html_url":"https://github.com/coala/coala/pull/4819#discussion_r148928677","pull_request_url":"https://api.github.com/repos/coala/coala/pulls/4819","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/coala/coala/pulls/comments/148928677"},"html":{"href":"https://github.com/coala/coala/pull/4819#discussion_r148928677"},"pull_request":{"href":"https://api.github.com/repos/coala/coala/pulls/4819"}},"in_reply_to_id":148339346},"pull_request":{"url":"https://api.github.com/repos/coala/coala/pulls/4819","id":149927076,"html_url":"https://github.com/coala/coala/pull/4819","diff_url":"https://github.com/coala/coala/pull/4819.diff","patch_url":"https://github.com/coala/coala/pull/4819.patch","issue_url":"https://api.github.com/repos/coala/coala/issues/4819","number":4819,"state":"open","locked":false,"title":"core: Do not close event loop too early","user":{"login":"Makman2","id":6023916,"avatar_url":"https://avatars3.githubusercontent.com/u/6023916?v=4","gravatar_id":"","url":"https://api.github.com/users/Makman2","html_url":"https://github.com/Makman2","followers_url":"https://api.github.com/users/Makman2/followers","following_url":"https://api.github.com/users/Makman2/following{/other_user}","gists_url":"https://api.github.com/users/Makman2/gists{/gist_id}","starred_url":"https://api.github.com/users/Makman2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Makman2/subscriptions","organizations_url":"https://api.github.com/users/Makman2/orgs","repos_url":"https://api.github.com/users/Makman2/repos","events_url":"https://api.github.com/users/Makman2/events{/privacy}","received_events_url":"https://api.github.com/users/Makman2/received_events","type":"User","site_admin":false},"body":"... when scheduling all dependency bears. Bears that offload no tasks\r\nmay cause the event-loop to close too early while other bears had no\r\nchance to submit their tasks.\r\n\r\nFixes https://github.com/coala/coala/issues/4505","created_at":"2017-10-31T22:53:22Z","updated_at":"2017-11-04T11:59:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc90d967da15319de12581b1b976cd7ec29ecbde","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/coala/coala/pulls/4819/commits","review_comments_url":"https://api.github.com/repos/coala/coala/pulls/4819/comments","review_comment_url":"https://api.github.com/repos/coala/coala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coala/coala/issues/4819/comments","statuses_url":"https://api.github.com/repos/coala/coala/statuses/231b747123a6a23b4d34fb133421ab9c34b452c4","head":{"label":"coala:Makman2/NEXTGEN/early-event-loop-close","ref":"Makman2/NEXTGEN/early-event-loop-close","sha":"231b747123a6a23b4d34fb133421ab9c34b452c4","user":{"login":"coala","id":10620750,"avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"repo":{"id":19816973,"name":"coala","full_name":"coala/coala","owner":{"login":"coala","id":10620750,"avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coala/coala","description":"coala provides a unified command-line interface for linting and fixing all your code, regardless of the programming languages you use.","fork":false,"url":"https://api.github.com/repos/coala/coala","forks_url":"https://api.github.com/repos/coala/coala/forks","keys_url":"https://api.github.com/repos/coala/coala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coala/coala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coala/coala/teams","hooks_url":"https://api.github.com/repos/coala/coala/hooks","issue_events_url":"https://api.github.com/repos/coala/coala/issues/events{/number}","events_url":"https://api.github.com/repos/coala/coala/events","assignees_url":"https://api.github.com/repos/coala/coala/assignees{/user}","branches_url":"https://api.github.com/repos/coala/coala/branches{/branch}","tags_url":"https://api.github.com/repos/coala/coala/tags","blobs_url":"https://api.github.com/repos/coala/coala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coala/coala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coala/coala/git/refs{/sha}","trees_url":"https://api.github.com/repos/coala/coala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coala/coala/statuses/{sha}","languages_url":"https://api.github.com/repos/coala/coala/languages","stargazers_url":"https://api.github.com/repos/coala/coala/stargazers","contributors_url":"https://api.github.com/repos/coala/coala/contributors","subscribers_url":"https://api.github.com/repos/coala/coala/subscribers","subscription_url":"https://api.github.com/repos/coala/coala/subscription","commits_url":"https://api.github.com/repos/coala/coala/commits{/sha}","git_commits_url":"https://api.github.com/repos/coala/coala/git/commits{/sha}","comments_url":"https://api.github.com/repos/coala/coala/comments{/number}","issue_comment_url":"https://api.github.com/repos/coala/coala/issues/comments{/number}","contents_url":"https://api.github.com/repos/coala/coala/contents/{+path}","compare_url":"https://api.github.com/repos/coala/coala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coala/coala/merges","archive_url":"https://api.github.com/repos/coala/coala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coala/coala/downloads","issues_url":"https://api.github.com/repos/coala/coala/issues{/number}","pulls_url":"https://api.github.com/repos/coala/coala/pulls{/number}","milestones_url":"https://api.github.com/repos/coala/coala/milestones{/number}","notifications_url":"https://api.github.com/repos/coala/coala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coala/coala/labels{/name}","releases_url":"https://api.github.com/repos/coala/coala/releases{/id}","deployments_url":"https://api.github.com/repos/coala/coala/deployments","created_at":"2014-05-15T11:35:34Z","updated_at":"2017-11-04T00:50:28Z","pushed_at":"2017-11-04T10:31:28Z","git_url":"git://github.com/coala/coala.git","ssh_url":"git@github.com:coala/coala.git","clone_url":"https://github.com/coala/coala.git","svn_url":"https://github.com/coala/coala","homepage":"https://coala.io/","size":12817,"stargazers_count":1649,"watchers_count":1649,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":807,"mirror_url":null,"archived":false,"open_issues_count":664,"forks":807,"open_issues":664,"watchers":1649,"default_branch":"master"}},"base":{"label":"coala:master","ref":"master","sha":"6cddd1a7f7373822280c0afe9610d55a9049514d","user":{"login":"coala","id":10620750,"avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"repo":{"id":19816973,"name":"coala","full_name":"coala/coala","owner":{"login":"coala","id":10620750,"avatar_url":"https://avatars3.githubusercontent.com/u/10620750?v=4","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coala/coala","description":"coala provides a unified command-line interface for linting and fixing all your code, regardless of the programming languages you use.","fork":false,"url":"https://api.github.com/repos/coala/coala","forks_url":"https://api.github.com/repos/coala/coala/forks","keys_url":"https://api.github.com/repos/coala/coala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coala/coala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coala/coala/teams","hooks_url":"https://api.github.com/repos/coala/coala/hooks","issue_events_url":"https://api.github.com/repos/coala/coala/issues/events{/number}","events_url":"https://api.github.com/repos/coala/coala/events","assignees_url":"https://api.github.com/repos/coala/coala/assignees{/user}","branches_url":"https://api.github.com/repos/coala/coala/branches{/branch}","tags_url":"https://api.github.com/repos/coala/coala/tags","blobs_url":"https://api.github.com/repos/coala/coala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coala/coala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coala/coala/git/refs{/sha}","trees_url":"https://api.github.com/repos/coala/coala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coala/coala/statuses/{sha}","languages_url":"https://api.github.com/repos/coala/coala/languages","stargazers_url":"https://api.github.com/repos/coala/coala/stargazers","contributors_url":"https://api.github.com/repos/coala/coala/contributors","subscribers_url":"https://api.github.com/repos/coala/coala/subscribers","subscription_url":"https://api.github.com/repos/coala/coala/subscription","commits_url":"https://api.github.com/repos/coala/coala/commits{/sha}","git_commits_url":"https://api.github.com/repos/coala/coala/git/commits{/sha}","comments_url":"https://api.github.com/repos/coala/coala/comments{/number}","issue_comment_url":"https://api.github.com/repos/coala/coala/issues/comments{/number}","contents_url":"https://api.github.com/repos/coala/coala/contents/{+path}","compare_url":"https://api.github.com/repos/coala/coala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coala/coala/merges","archive_url":"https://api.github.com/repos/coala/coala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coala/coala/downloads","issues_url":"https://api.github.com/repos/coala/coala/issues{/number}","pulls_url":"https://api.github.com/repos/coala/coala/pulls{/number}","milestones_url":"https://api.github.com/repos/coala/coala/milestones{/number}","notifications_url":"https://api.github.com/repos/coala/coala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coala/coala/labels{/name}","releases_url":"https://api.github.com/repos/coala/coala/releases{/id}","deployments_url":"https://api.github.com/repos/coala/coala/deployments","created_at":"2014-05-15T11:35:34Z","updated_at":"2017-11-04T00:50:28Z","pushed_at":"2017-11-04T10:31:28Z","git_url":"git://github.com/coala/coala.git","ssh_url":"git@github.com:coala/coala.git","clone_url":"https://github.com/coala/coala.git","svn_url":"https://github.com/coala/coala","homepage":"https://coala.io/","size":12817,"stargazers_count":1649,"watchers_count":1649,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":807,"mirror_url":null,"archived":false,"open_issues_count":664,"forks":807,"open_issues":664,"watchers":1649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coala/coala/pulls/4819"},"html":{"href":"https://github.com/coala/coala/pull/4819"},"issue":{"href":"https://api.github.com/repos/coala/coala/issues/4819"},"comments":{"href":"https://api.github.com/repos/coala/coala/issues/4819/comments"},"review_comments":{"href":"https://api.github.com/repos/coala/coala/pulls/4819/comments"},"review_comment":{"href":"https://api.github.com/repos/coala/coala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coala/coala/pulls/4819/commits"},"statuses":{"href":"https://api.github.com/repos/coala/coala/statuses/231b747123a6a23b4d34fb133421ab9c34b452c4"}},"author_association":"OWNER"}}
{"actor":{"display_login":"shreyans800755"}}