{"push_id":1996826717,"size":95,"distinct_size":95,"ref":"refs/heads/master","head":"c09d54335547d57b7ee1f9e8834a08e6a2c0eb7f","before":"3aceafd3cfe7792ebf4927a3461495957ff35bf2","commits":[{"sha":"23aeafae7dca421186230134e8d7e2fb5bf7afc3","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"sql: add string repr for CopyDataBlock stmt","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/23aeafae7dca421186230134e8d7e2fb5bf7afc3"},{"sha":"937a7b314f5f6e90e1a55ad12a63b0d02b16d6a1","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"sql: don't hide broken state with SHOW TRANSACTION STATUS","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/937a7b314f5f6e90e1a55ad12a63b0d02b16d6a1"},{"sha":"2647778d58a0cfd510a27fa2ea6672cbe4f5f143","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"sql: Executor takes control over auto-retries\n\nBefore this patch, the Executor was delegating the handling of\nauto-retries (the loop handling retriable errors) to the lower-level\ntxn.Exec() interface. With all due respect for that interface, it is now\ntime for the Executor to take control over these retries for a number of\nreasons:\n- conceptually, the Executor is already dealing with client-directed\nretries, so it's already in the \"retry\" business. It was confusing that\nthe auto-retries were handled elsewhere.\n- the txn.Exec() interfaces forces the Executor into an unusual\nclosure-passing programming style. If there's no reason for it, it'd\nbetter do without.\n- the Executor already had special needs which required txn.Exec() to be\nextended with control options in a ExecOpt structure. SQL is the only\nuser of that control, so burdening the more general txn.Exec() interface\nwas already unfortunate. Which leads us to the most important:\n- a future commit fixes #17592 - the fix is yet another condition\ncontrolling whether or not we can auto-retry: we can't if we've already\nstreamed results to the client. This is something that can't cleanly be\nput into that ExecOpt structure, so it's really time for the Executor to\ncontrol the retry loop.\n\nI've also made other improvements in the code close to auto-retries:\n- The state transition AutoRetry->Open moves up from runTxnAttempt() to\nexecParsed(); the new place makes more sense - we're now dealing with\nthis transition after we've done dealing with auto-retries.\n- The code was doing something seemingly non-sensical: it was holding on\nto a reference to the KV transaction before running some statements, and\ndoing stuff to that reference afterwards, despite the fact that the KV\ntxn might have been cleaned up and gone by the time control returned to\nthat layer. This was done in relation to #7881, to paper over an\nunexpected state assertion firing. This code cannot be maintained now;\nit's time to try again without it.","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/2647778d58a0cfd510a27fa2ea6672cbe4f5f143"},{"sha":"098f008a55a392712716c2d978ceb9ec2531fc96","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"sql: split Executor.execParsed()\n\nThis method was too long and, as of the previous commit, the\nclosure-passing style it used was no longer required.","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/098f008a55a392712716c2d978ceb9ec2531fc96"},{"sha":"ffc704a406a0afe70d67c857a8a31a4af8f4fdd0","author":{"name":"Andrei Matei","email":"82d83a1950b1b041ac07a9fa8d0428277a5e4bfe@cockroachlabs.com"},"message":"sql: don't auto-retry if we've already sent results to the client\n\nFixes #17592\n\nEver since results streaming, the condition about whether we can\nauto-retry or not has become more complicated: we can't auto-retry if\nwe've previously streamed any results to the client. However, we were\nignoring this fact and retrying regardless. This patch adds this\ncondition.","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/ffc704a406a0afe70d67c857a8a31a4af8f4fdd0"},{"sha":"e451edbeffc19ef2b4afb5b6b8634deaf9f2bf36","author":{"name":"Matt Jibson","email":"e67f95f42c4959cac33fbbbc1922229fe473494d@gmail.com"},"message":"sqlccl: populate CSV backup descriptor metadata","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/e451edbeffc19ef2b4afb5b6b8634deaf9f2bf36"},{"sha":"0d5e9a09a6cd25c4a20e9b4f0e1199b9c834e50f","author":{"name":"Matt Jibson","email":"e67f95f42c4959cac33fbbbc1922229fe473494d@gmail.com"},"message":"sqlccl: remove unused time invocation","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/0d5e9a09a6cd25c4a20e9b4f0e1199b9c834e50f"},{"sha":"3451547a6046e59c5b6bc5e2fb0dc8db0121d3c1","author":{"name":"Jordan Lewis","email":"4e088bb3970e64102f0d8aade89f559fa1aa3065@gmail.com"},"message":"sql/sqlbase: DecodeIndexKey gets index, not index id","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/3451547a6046e59c5b6bc5e2fb0dc8db0121d3c1"},{"sha":"1268db12ae8eaecdb34ee120b6fc94d00cafbbbe","author":{"name":"Alex Robinson","email":"2f0a128f2222659ab181ef1399b3a62c7c31ce13@gmail.com"},"message":"acceptance: Fix DockerCluster.ExecCLI to match the expected behavior\n\nThe Cluster interface requires that the ExecCLI implementation prepends\nthe cockroach binary before the args passed to the command.","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/1268db12ae8eaecdb34ee120b6fc94d00cafbbbe"},{"sha":"614d81a8f40a4b3079b93b36b1cce3c131c7857b","author":{"name":"Peter Mattis","email":"96165b703fa5ad88ee03d1dd21db6648d592b647@gmail.com"},"message":"storage: improve error message for failed splits and change replicas\n\nWhen a split or change replicas fails because the underlying descriptor\nchanged provide a more informative error messages.\n\nBefore:\n\nunexpected value:\nraw_bytes:\"I\\205B\\247\\003\\010\\001\\022\\000\\032\\001a\\\"\\006\\010\\001\\020\\001\\030\\001(\\002\"\ntimestamp:<wall_time:1505319352553640907 logical:0 >\n\nAfter:\n\ndescriptor changed: [expected] r1:/M{in-ax} [(n1,s1):1, next=2] != [actual] r1:{/Min-a} [(n1,s1):1, next=2]\n\nSee #17180","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/614d81a8f40a4b3079b93b36b1cce3c131c7857b"},{"sha":"c34da28f55792115d9a14edd0df0ad93f4fd9d56","author":{"name":"Matt Jibson","email":"e67f95f42c4959cac33fbbbc1922229fe473494d@gmail.com"},"message":"sqlccl: add tests for CSV create table errors\n\nmakeCSVTableDescriptor now checks the create statement for more\nfailures. This is needed because otherwise sql.MakeTableDesc can panic\ndue to the nil EvalContext (like when processing DEFAULT expressions).","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/c34da28f55792115d9a14edd0df0ad93f4fd9d56"},{"sha":"616934fd57dc8e14a51c950545688344daac9843","author":{"name":"Vivek Menezes","email":"e22d9408c57356cd5c64e3772ff80699d307c9d5@cockroachlabs.com"},"message":"sql: fix TRUNCATE on a table in the middle of a schema change\n\nTRUNCATE drops the existing table and creates a new one with the\nsame schema. In doing so it currently copies over all the schema\nchange mutations and jobs associated with the schema change thus\nassociating the same job with two tables. This is broken!\n\nThis change associates all the mutations and jobs with the table being\ndropped, and converts all outstanding schema changes on the new table\nto the public state. The new table is empty and thus doesn't need\na backfill job.","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/616934fd57dc8e14a51c950545688344daac9843"},{"sha":"a8e90b9ffcf997dcbebfb984e743a6989fd55e9f","author":{"name":"Peter Mattis","email":"6214814a67b9688a08e8c6dc7fa5dee076dddc8d@cockroachlabs.com"},"message":"Merge pull request #18482 from petermattis/pmattis/admin-split-condition-failed\n\nstorage: improve error message for failed splits","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/a8e90b9ffcf997dcbebfb984e743a6989fd55e9f"},{"sha":"95cff88d9d4b7ad1357eaa61a9a70a4ef8ed9a34","author":{"name":"Richard Wu","email":"26d57fc3248b50b328b8e433ab103ef582587e20@gmail.com"},"message":"distsql: refactor distributed aggregation to support arbitrary local aggregate inputs in final stage","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/95cff88d9d4b7ad1357eaa61a9a70a4ef8ed9a34"},{"sha":"1c6b7214bb2dea1a36668b119dda250642ac22a1","author":{"name":"Richard Wu","email":"26d57fc3248b50b328b8e433ab103ef582587e20@gmail.com"},"message":"Merge pull request #18386 from richardwu/stddev-var-local-final\n\ndistsql: refactor distributed aggregation to support arbitrary local aggregate inputs in final stage","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/1c6b7214bb2dea1a36668b119dda250642ac22a1"},{"sha":"1e12450bc77ccafa583f649120ef2fc25f11096c","author":{"name":"Alex Robinson","email":"2f0a128f2222659ab181ef1399b3a62c7c31ce13@gmail.com"},"message":"server: Provide a more useful error if init is run more than once\n\n`cockroach init` now prints confirmation of success when it succeeds\nand a more digestible error when run on an already initialized cluster.","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/1e12450bc77ccafa583f649120ef2fc25f11096c"},{"sha":"4969e286b4e84845c55b4446a162f738b2c8c666","author":{"name":"Matt Jibson","email":"e67f95f42c4959cac33fbbbc1922229fe473494d@gmail.com"},"message":"Merge pull request #18438 from mjibson/csv-walltime\n\nsqlccl: remove unused time invocation","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/4969e286b4e84845c55b4446a162f738b2c8c666"},{"sha":"31565fb9f91618d988f9d24dbd983b3b4011799a","author":{"name":"Alex Robinson","email":"2f0a128f2222659ab181ef1399b3a62c7c31ce13@gmail.com"},"message":"ui: Clarify name of the node count graph\n\nAddresses #18452 for 1.1","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/31565fb9f91618d988f9d24dbd983b3b4011799a"},{"sha":"6fa087778c2d9c89f5678b6ebd0b2b88e1d3e078","author":{"name":"Matt Jibson","email":"e67f95f42c4959cac33fbbbc1922229fe473494d@gmail.com"},"message":"cliccl: add `load show` subcommand to display backup info\n\nExample output:\n\n```\nStartTime: 1970-01-01T00:00:00Z (0.000000000,0)\nEndTime: 2017-09-12T19:04:53.74638877Z (1505243093.746388770,0)\nDataSize: 211103038 (201 MiB)\nRows: 0\nIndexEntries: 0\nSystemRecords: 0\nFormatVersion: 0\nClusterID: 00000000-0000-0000-0000-000000000000\nNodeID: 0\nBuildInfo: CockroachDB   (, built , )\nSpans:\n        /Table/5{1-2}\nFiles:\n        1.sst:\n                Span: /Table/51/1/1{/0-902791/0/NULL}\n                Sha512: 0ad2effe72d9fc5bd03da616f5fc586c8e272208e524dde118beb6e6d649d7760c7842afa8c2a9aae612c39ba19974f5cf178e48ff04b82692e443a68545b379\n                DataSize: 0 (0 B)\n                Rows: 0\n                IndexEntries: 0\n                SystemRecords: 0\n        2.sst:\n                Span: /Table/51/1/{1902816/0-3805765/0/NULL}\n                Sha512: b570a22f494b2e3ac553d1cfd1ed559378f3177ed470d8baced7137fb3f8a95a6efa9cbce1d0981324a05dba2c5708feb30fe2d862815cb485972d2df2724372\n                DataSize: 0 (0 B)\n                Rows: 0\n                IndexEntries: 0\n                SystemRecords: 0\n        3.sst:\n                Span: /Table/51/1/{3805766/0-5709250/0/NULL}\n                Sha512: 938cb2e531e164d660a8a3e9ddc2603e343061f860efcd4a29a74b5f9f6a38e7fe1ace78b13b5aee5dab2a39457c0887bc827cf7e76b76a3f1d284e32c54a332\n                DataSize: 0 (0 B)\n                Rows: 0\n                IndexEntries: 0\n                SystemRecords: 0\n        4.sst:\n                Span: /Table/51/{1/5709251/0-3/10292/3714624/0/NULL}\n                Sha512: 539a9a0473e92d3ae53460b63e4a9e5c90461d4b6af861c897b1ef6469d317a91857bf6dd8762d268a49c1ac77cc564c32fb24c17603fde68c31c9f7fba817d8\n                DataSize: 0 (0 B)\n                Rows: 0\n                IndexEntries: 0\n                SystemRecords: 0\n        5.sst:\n                Span: /Table/51/3/10{292/3722688/0-440/5999872/0/NULL}\n                Sha512: 6bb4feeec8394661958222a26fdbf20ec9a2a155a8c45494eade9dc2025b64040e7f698de4a17e55619544fddc3170b401c1cf2987ddcdf9346606a2008bfd87\n                DataSize: 0 (0 B)\n                Rows: 0\n                IndexEntries: 0\n                SystemRecords: 0\nDescriptors:\n        50: csv (database)\n        51: orders (table)\n```","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/6fa087778c2d9c89f5678b6ebd0b2b88e1d3e078"},{"sha":"af757547ad1f4970a17a9545b3753ff390425621","author":{"name":"Andrei Matei","email":"10a93020cc4f038c14193f054a8660a80d6d683c@gmail.com"},"message":"Merge pull request #18268 from andreimatei/sql-fix-autoretry-after-results-streamed\n\nsql: don't auto-retry if we've already sent results to the client","distinct":true,"url":"https://api.github.com/repos/hainesc/cockroach/commits/af757547ad1f4970a17a9545b3753ff390425621"}]}
{"actor":{"display_login":"hainesc"}}