{"action":"created","issue":{"url":"https://api.github.com/repos/fede1024/rust-rdkafka/issues/22","repository_url":"https://api.github.com/repos/fede1024/rust-rdkafka","labels_url":"https://api.github.com/repos/fede1024/rust-rdkafka/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/fede1024/rust-rdkafka/issues/22/comments","events_url":"https://api.github.com/repos/fede1024/rust-rdkafka/issues/22/events","html_url":"https://github.com/fede1024/rust-rdkafka/pull/22","id":198355217,"number":22,"title":"Convert unwraps to expects and test for custom product context","user":{"login":"thijsc","id":9794,"avatar_url":"https://avatars.githubusercontent.com/u/9794?v=3","gravatar_id":"","url":"https://api.github.com/users/thijsc","html_url":"https://github.com/thijsc","followers_url":"https://api.github.com/users/thijsc/followers","following_url":"https://api.github.com/users/thijsc/following{/other_user}","gists_url":"https://api.github.com/users/thijsc/gists{/gist_id}","starred_url":"https://api.github.com/users/thijsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thijsc/subscriptions","organizations_url":"https://api.github.com/users/thijsc/orgs","repos_url":"https://api.github.com/users/thijsc/repos","events_url":"https://api.github.com/users/thijsc/events{/privacy}","received_events_url":"https://api.github.com/users/thijsc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-01-02T16:15:19Z","updated_at":"2017-01-02T17:43:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fede1024/rust-rdkafka/pulls/22","html_url":"https://github.com/fede1024/rust-rdkafka/pull/22","diff_url":"https://github.com/fede1024/rust-rdkafka/pull/22.diff","patch_url":"https://github.com/fede1024/rust-rdkafka/pull/22.patch"},"body":"This converts some unwraps to expects so I could rule out some causes of a crash I'm seeing. It looks like the crash is caused by using a custom producer context, so I've added an integration test for this.\r\n\r\nThe test in this pull runs indefinitely. When you change line 54 back to this:\r\n\r\n```rust\r\n.create::<FutureProducer<_>>()\r\n```\r\n\r\nThe test passes within a second or two again. Seems like something breaks when using `create_with_context` instead of `create`, so far I have no idea why. Any thoughts?"},"comment":{"url":"https://api.github.com/repos/fede1024/rust-rdkafka/issues/comments/270001111","html_url":"https://github.com/fede1024/rust-rdkafka/pull/22#issuecomment-270001111","issue_url":"https://api.github.com/repos/fede1024/rust-rdkafka/issues/22","id":270001111,"user":{"login":"fede1024","id":1543631,"avatar_url":"https://avatars.githubusercontent.com/u/1543631?v=3","gravatar_id":"","url":"https://api.github.com/users/fede1024","html_url":"https://github.com/fede1024","followers_url":"https://api.github.com/users/fede1024/followers","following_url":"https://api.github.com/users/fede1024/following{/other_user}","gists_url":"https://api.github.com/users/fede1024/gists{/gist_id}","starred_url":"https://api.github.com/users/fede1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fede1024/subscriptions","organizations_url":"https://api.github.com/users/fede1024/orgs","repos_url":"https://api.github.com/users/fede1024/repos","events_url":"https://api.github.com/users/fede1024/events{/privacy}","received_events_url":"https://api.github.com/users/fede1024/received_events","type":"User","site_admin":false},"created_at":"2017-01-02T17:43:30Z","updated_at":"2017-01-02T17:43:30Z","body":"The way the `FutureProducer` allows to specify a `ProducerContext` is very confusing at the moment, since the only method currently available in the trait is not actually executed (since it is used by the `FutureProducer` itself). I think we should remove this test, since it is a bit misleading.\r\n\r\nI'll update the `FutureProducer` to use a different trait instead of `ProducerContext` (or nothing at all)."}}
{"actor":{"display_login":"fede1024"}}