{"action":"created","comment":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/98650282","pull_request_review_id":19295813,"id":98650282,"diff_hunk":"@@ -103,23 +98,11 @@ In order to have your new payment method available in the checkout remember to *\n Payment Gateway and Configurations\n ----------------------------------\n \n-In order to add a new gateway, configure it in the ``app/config.yml`` file of your project in such a way:\n-\n-.. code-block:: yaml\n-\n-    payum:\n-        gateways:\n-            paypal_express_checkout:\n-                factory: \"paypal_express_checkout\"\n-                payum.http_client: \"@sylius.payum.http_client\"\n-                username: \"TEST\"\n-                password: \"TEST\"\n-                signature: \"TEST\"\n-                sandbox: \"true\"\n+In order to add a new gateway, you should implement it's configuration form type with ``sylius.gateway_configuration_type`` tag. It will be then available in Admin panel in gateways dropdown.","path":"docs/book/orders/payments.rst","position":43,"original_position":43,"commit_id":"a4c3b6642a9a6e19657aa9d61b99789882d70a6b","original_commit_id":"a4c3b6642a9a6e19657aa9d61b99789882d70a6b","user":{"login":"TheMadeleine","id":13198869,"avatar_url":"https://avatars.githubusercontent.com/u/13198869?v=3","gravatar_id":"","url":"https://api.github.com/users/TheMadeleine","html_url":"https://github.com/TheMadeleine","followers_url":"https://api.github.com/users/TheMadeleine/followers","following_url":"https://api.github.com/users/TheMadeleine/following{/other_user}","gists_url":"https://api.github.com/users/TheMadeleine/gists{/gist_id}","starred_url":"https://api.github.com/users/TheMadeleine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheMadeleine/subscriptions","organizations_url":"https://api.github.com/users/TheMadeleine/orgs","repos_url":"https://api.github.com/users/TheMadeleine/repos","events_url":"https://api.github.com/users/TheMadeleine/events{/privacy}","received_events_url":"https://api.github.com/users/TheMadeleine/received_events","type":"User","site_admin":false},"body":"`Then it will be available in the Admin panel in the gateway choice dropdown.`","created_at":"2017-01-31T11:49:17Z","updated_at":"2017-01-31T11:54:42Z","html_url":"https://github.com/Sylius/Sylius/pull/7237#discussion_r98650282","pull_request_url":"https://api.github.com/repos/Sylius/Sylius/pulls/7237","_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments/98650282"},"html":{"href":"https://github.com/Sylius/Sylius/pull/7237#discussion_r98650282"},"pull_request":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/7237"}}},"pull_request":{"url":"https://api.github.com/repos/Sylius/Sylius/pulls/7237","id":101081734,"html_url":"https://github.com/Sylius/Sylius/pull/7237","diff_url":"https://github.com/Sylius/Sylius/pull/7237.diff","patch_url":"https://github.com/Sylius/Sylius/pull/7237.patch","issue_url":"https://api.github.com/repos/Sylius/Sylius/issues/7237","number":7237,"state":"open","locked":false,"title":"[Payum][Payment][Admin] Manage gateway config in admin panel","user":{"login":"Zales0123","id":6212718,"avatar_url":"https://avatars.githubusercontent.com/u/6212718?v=3","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"body":"| Q               | A\r\n| --------------- | ---\r\n| Bug fix?        | yes |\r\n| New feature?    | yes |\r\n| BC breaks?      | yes |\r\n| Related tickets | |\r\n| License         | MIT |\r\n\r\nIn order to be more flexible with payments, we can now configure payment gateways in admin panel. For now we support three gateways:\r\n- offline\r\n- paypal_express_checkout\r\n- stripe_checkout\r\n\r\nIt should be easy to implement new gateways, as it only requires to add proper configuration form and register it with `sylius.gateway_configuration_type` tag.\r\n\r\n![zrzut ekranu 2017-01-11 o 16 22 57](https://cloud.githubusercontent.com/assets/6212718/21854266/6bafef6a-d81a-11e6-824f-0a28541ad5f0.png)\r\n\r\nTo-do:\r\n- [x] improve forms UI\r\n- [x] update `UPGRADE.md`\r\n- [x] update documentation\r\n","created_at":"2017-01-11T14:58:15Z","updated_at":"2017-01-31T11:54:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89139b4853d25c93cfea4602353a2550a4c9823e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sylius/Sylius/pulls/7237/commits","review_comments_url":"https://api.github.com/repos/Sylius/Sylius/pulls/7237/comments","review_comment_url":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sylius/Sylius/issues/7237/comments","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/a4c3b6642a9a6e19657aa9d61b99789882d70a6b","head":{"label":"Zales0123:manage-gateway-config-in-admin-panel","ref":"manage-gateway-config-in-admin-panel","sha":"a4c3b6642a9a6e19657aa9d61b99789882d70a6b","user":{"login":"Zales0123","id":6212718,"avatar_url":"https://avatars.githubusercontent.com/u/6212718?v=3","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"repo":{"id":28911466,"name":"Sylius","full_name":"Zales0123/Sylius","owner":{"login":"Zales0123","id":6212718,"avatar_url":"https://avatars.githubusercontent.com/u/6212718?v=3","gravatar_id":"","url":"https://api.github.com/users/Zales0123","html_url":"https://github.com/Zales0123","followers_url":"https://api.github.com/users/Zales0123/followers","following_url":"https://api.github.com/users/Zales0123/following{/other_user}","gists_url":"https://api.github.com/users/Zales0123/gists{/gist_id}","starred_url":"https://api.github.com/users/Zales0123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zales0123/subscriptions","organizations_url":"https://api.github.com/users/Zales0123/orgs","repos_url":"https://api.github.com/users/Zales0123/repos","events_url":"https://api.github.com/users/Zales0123/events{/privacy}","received_events_url":"https://api.github.com/users/Zales0123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Zales0123/Sylius","description":"Modern e-commerce for PHP, based on the Symfony2 framework.","fork":true,"url":"https://api.github.com/repos/Zales0123/Sylius","forks_url":"https://api.github.com/repos/Zales0123/Sylius/forks","keys_url":"https://api.github.com/repos/Zales0123/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zales0123/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zales0123/Sylius/teams","hooks_url":"https://api.github.com/repos/Zales0123/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Zales0123/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Zales0123/Sylius/events","assignees_url":"https://api.github.com/repos/Zales0123/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Zales0123/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Zales0123/Sylius/tags","blobs_url":"https://api.github.com/repos/Zales0123/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zales0123/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zales0123/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zales0123/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zales0123/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Zales0123/Sylius/languages","stargazers_url":"https://api.github.com/repos/Zales0123/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Zales0123/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Zales0123/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Zales0123/Sylius/subscription","commits_url":"https://api.github.com/repos/Zales0123/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zales0123/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zales0123/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zales0123/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zales0123/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Zales0123/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zales0123/Sylius/merges","archive_url":"https://api.github.com/repos/Zales0123/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zales0123/Sylius/downloads","issues_url":"https://api.github.com/repos/Zales0123/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Zales0123/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Zales0123/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Zales0123/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zales0123/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Zales0123/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Zales0123/Sylius/deployments","created_at":"2015-01-07T11:20:44Z","updated_at":"2016-01-14T10:09:00Z","pushed_at":"2017-01-30T12:19:05Z","git_url":"git://github.com/Zales0123/Sylius.git","ssh_url":"git@github.com:Zales0123/Sylius.git","clone_url":"https://github.com/Zales0123/Sylius.git","svn_url":"https://github.com/Zales0123/Sylius","homepage":"Sylius.org","size":54004,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sylius:master","ref":"master","sha":"f563c74e2c3107cf162a8203c2e931585e0a927a","user":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"repo":{"id":2717549,"name":"Sylius","full_name":"Sylius/Sylius","owner":{"login":"Sylius","id":719423,"avatar_url":"https://avatars.githubusercontent.com/u/719423?v=3","gravatar_id":"","url":"https://api.github.com/users/Sylius","html_url":"https://github.com/Sylius","followers_url":"https://api.github.com/users/Sylius/followers","following_url":"https://api.github.com/users/Sylius/following{/other_user}","gists_url":"https://api.github.com/users/Sylius/gists{/gist_id}","starred_url":"https://api.github.com/users/Sylius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sylius/subscriptions","organizations_url":"https://api.github.com/users/Sylius/orgs","repos_url":"https://api.github.com/users/Sylius/repos","events_url":"https://api.github.com/users/Sylius/events{/privacy}","received_events_url":"https://api.github.com/users/Sylius/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sylius/Sylius","description":"eCommerce PHP framework built on top of Symfony with component-based architecture and format-agnostic rendering. (HTML/JSON/XML)","fork":false,"url":"https://api.github.com/repos/Sylius/Sylius","forks_url":"https://api.github.com/repos/Sylius/Sylius/forks","keys_url":"https://api.github.com/repos/Sylius/Sylius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sylius/Sylius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sylius/Sylius/teams","hooks_url":"https://api.github.com/repos/Sylius/Sylius/hooks","issue_events_url":"https://api.github.com/repos/Sylius/Sylius/issues/events{/number}","events_url":"https://api.github.com/repos/Sylius/Sylius/events","assignees_url":"https://api.github.com/repos/Sylius/Sylius/assignees{/user}","branches_url":"https://api.github.com/repos/Sylius/Sylius/branches{/branch}","tags_url":"https://api.github.com/repos/Sylius/Sylius/tags","blobs_url":"https://api.github.com/repos/Sylius/Sylius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sylius/Sylius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sylius/Sylius/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sylius/Sylius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sylius/Sylius/statuses/{sha}","languages_url":"https://api.github.com/repos/Sylius/Sylius/languages","stargazers_url":"https://api.github.com/repos/Sylius/Sylius/stargazers","contributors_url":"https://api.github.com/repos/Sylius/Sylius/contributors","subscribers_url":"https://api.github.com/repos/Sylius/Sylius/subscribers","subscription_url":"https://api.github.com/repos/Sylius/Sylius/subscription","commits_url":"https://api.github.com/repos/Sylius/Sylius/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sylius/Sylius/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sylius/Sylius/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sylius/Sylius/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sylius/Sylius/contents/{+path}","compare_url":"https://api.github.com/repos/Sylius/Sylius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sylius/Sylius/merges","archive_url":"https://api.github.com/repos/Sylius/Sylius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sylius/Sylius/downloads","issues_url":"https://api.github.com/repos/Sylius/Sylius/issues{/number}","pulls_url":"https://api.github.com/repos/Sylius/Sylius/pulls{/number}","milestones_url":"https://api.github.com/repos/Sylius/Sylius/milestones{/number}","notifications_url":"https://api.github.com/repos/Sylius/Sylius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sylius/Sylius/labels{/name}","releases_url":"https://api.github.com/repos/Sylius/Sylius/releases{/id}","deployments_url":"https://api.github.com/repos/Sylius/Sylius/deployments","created_at":"2011-11-05T22:05:52Z","updated_at":"2017-01-31T07:39:07Z","pushed_at":"2017-01-31T11:28:47Z","git_url":"git://github.com/Sylius/Sylius.git","ssh_url":"git@github.com:Sylius/Sylius.git","clone_url":"https://github.com/Sylius/Sylius.git","svn_url":"https://github.com/Sylius/Sylius","homepage":"http://Sylius.org","size":53641,"stargazers_count":2722,"watchers_count":2722,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1013,"mirror_url":null,"open_issues_count":467,"forks":1013,"open_issues":467,"watchers":2722,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/7237"},"html":{"href":"https://github.com/Sylius/Sylius/pull/7237"},"issue":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/7237"},"comments":{"href":"https://api.github.com/repos/Sylius/Sylius/issues/7237/comments"},"review_comments":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/7237/comments"},"review_comment":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sylius/Sylius/pulls/7237/commits"},"statuses":{"href":"https://api.github.com/repos/Sylius/Sylius/statuses/a4c3b6642a9a6e19657aa9d61b99789882d70a6b"}}}}
{"actor":{"display_login":"TheMadeleine"}}