{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/comments/114666369","pull_request_review_id":36152690,"id":114666369,"diff_hunk":"@@ -0,0 +1,115 @@\n+apiVersion: extensions/v1beta1\n+kind: Deployment\n+metadata:\n+  name: heapster\n+  namespace: kube-system\n+  labels:\n+    k8s-addon: monitoring-standalone.addons.k8s.io\n+    k8s-app: heapster\n+    kubernetes.io/cluster-service: \"true\"\n+    version: v1.6.0\n+spec:\n+  replicas: 1\n+  selector:\n+    matchLabels:\n+      k8s-app: heapster\n+      version: v1.6.0\n+  template:\n+    metadata:\n+      labels:\n+        k8s-app: heapster\n+        version: v1.6.0\n+      annotations:\n+        scheduler.alpha.kubernetes.io/critical-pod: ''\n+        scheduler.alpha.kubernetes.io/tolerations: '[{\"key\":\"CriticalAddonsOnly\", \"operator\":\"Exists\"}]'\n+    spec:\n+      serviceAccountName: heapster\n+      containers:\n+        - image: gcr.io/google_containers/heapster:v1.3.0\n+          name: heapster\n+          livenessProbe:\n+            httpGet:\n+              path: /healthz\n+              port: 8082\n+              scheme: HTTP\n+            initialDelaySeconds: 180\n+            timeoutSeconds: 5\n+          resources:\n+            # keep request = limit to keep this container in guaranteed class\n+            limits:\n+              cpu: 100m\n+              memory: 300Mi\n+            requests:\n+              cpu: 100m\n+              memory: 300Mi\n+          command:\n+            - /heapster\n+            - --source=kubernetes.summary_api:''\n+        - image: gcr.io/google_containers/addon-resizer:1.7\n+          name: heapster-nanny\n+          resources:\n+            limits:\n+              cpu: 50m\n+              memory: 100Mi\n+            requests:\n+              cpu: 50m\n+              memory: 100Mi\n+          env:\n+            - name: MY_POD_NAME\n+              valueFrom:\n+                fieldRef:\n+                  fieldPath: metadata.name\n+            - name: MY_POD_NAMESPACE\n+              valueFrom:\n+                fieldRef:\n+                  fieldPath: metadata.namespace\n+          command:\n+            - /pod_nanny\n+            - --cpu=80m\n+            - --extra-cpu=0.5m\n+            - --memory=140Mi\n+            - --extra-memory=4Mi\n+            - --threshold=5\n+            - --deployment=heapster\n+            - --container=heapster\n+            - --poll-period=300000","path":"addons/monitoring-standalone/v1.6.0.yaml","position":75,"original_position":75,"commit_id":"881ca9e01f351047e199dc1492e8f2da26a981c1","original_commit_id":"881ca9e01f351047e199dc1492e8f2da26a981c1","user":{"login":"chrislovecnm","id":335402,"avatar_url":"https://avatars1.githubusercontent.com/u/335402?v=3","gravatar_id":"","url":"https://api.github.com/users/chrislovecnm","html_url":"https://github.com/chrislovecnm","followers_url":"https://api.github.com/users/chrislovecnm/followers","following_url":"https://api.github.com/users/chrislovecnm/following{/other_user}","gists_url":"https://api.github.com/users/chrislovecnm/gists{/gist_id}","starred_url":"https://api.github.com/users/chrislovecnm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrislovecnm/subscriptions","organizations_url":"https://api.github.com/users/chrislovecnm/orgs","repos_url":"https://api.github.com/users/chrislovecnm/repos","events_url":"https://api.github.com/users/chrislovecnm/events{/privacy}","received_events_url":"https://api.github.com/users/chrislovecnm/received_events","type":"User","site_admin":false},"body":"This is standalone without data persistence?","created_at":"2017-05-03T22:17:13Z","updated_at":"2017-05-03T22:17:13Z","html_url":"https://github.com/kubernetes/kops/pull/2483#discussion_r114666369","pull_request_url":"https://api.github.com/repos/kubernetes/kops/pulls/2483","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments/114666369"},"html":{"href":"https://github.com/kubernetes/kops/pull/2483#discussion_r114666369"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/2483"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/2483","id":118672335,"html_url":"https://github.com/kubernetes/kops/pull/2483","diff_url":"https://github.com/kubernetes/kops/pull/2483.diff","patch_url":"https://github.com/kubernetes/kops/pull/2483.patch","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/2483","number":2483,"state":"open","locked":false,"title":"add heapster addon","user":{"login":"sethpollack","id":4913482,"avatar_url":"https://avatars2.githubusercontent.com/u/4913482?v=3","gravatar_id":"","url":"https://api.github.com/users/sethpollack","html_url":"https://github.com/sethpollack","followers_url":"https://api.github.com/users/sethpollack/followers","following_url":"https://api.github.com/users/sethpollack/following{/other_user}","gists_url":"https://api.github.com/users/sethpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/sethpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethpollack/subscriptions","organizations_url":"https://api.github.com/users/sethpollack/orgs","repos_url":"https://api.github.com/users/sethpollack/repos","events_url":"https://api.github.com/users/sethpollack/events{/privacy}","received_events_url":"https://api.github.com/users/sethpollack/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.kubernetes.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.kubernetes.io/reviews/kubernetes/kops/2483)\n<!-- Reviewable:end -->\n","created_at":"2017-05-03T00:15:07Z","updated_at":"2017-05-03T22:17:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4034f089ff6a988facfcc48ff5c33f70a9dd14c0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kops/pulls/2483/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kops/pulls/2483/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/2483/comments","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/881ca9e01f351047e199dc1492e8f2da26a981c1","head":{"label":"sethpollack:addon_heapster","ref":"addon_heapster","sha":"881ca9e01f351047e199dc1492e8f2da26a981c1","user":{"login":"sethpollack","id":4913482,"avatar_url":"https://avatars2.githubusercontent.com/u/4913482?v=3","gravatar_id":"","url":"https://api.github.com/users/sethpollack","html_url":"https://github.com/sethpollack","followers_url":"https://api.github.com/users/sethpollack/followers","following_url":"https://api.github.com/users/sethpollack/following{/other_user}","gists_url":"https://api.github.com/users/sethpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/sethpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethpollack/subscriptions","organizations_url":"https://api.github.com/users/sethpollack/orgs","repos_url":"https://api.github.com/users/sethpollack/repos","events_url":"https://api.github.com/users/sethpollack/events{/privacy}","received_events_url":"https://api.github.com/users/sethpollack/received_events","type":"User","site_admin":false},"repo":{"id":80325763,"name":"kops","full_name":"sethpollack/kops","owner":{"login":"sethpollack","id":4913482,"avatar_url":"https://avatars2.githubusercontent.com/u/4913482?v=3","gravatar_id":"","url":"https://api.github.com/users/sethpollack","html_url":"https://github.com/sethpollack","followers_url":"https://api.github.com/users/sethpollack/followers","following_url":"https://api.github.com/users/sethpollack/following{/other_user}","gists_url":"https://api.github.com/users/sethpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/sethpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethpollack/subscriptions","organizations_url":"https://api.github.com/users/sethpollack/orgs","repos_url":"https://api.github.com/users/sethpollack/repos","events_url":"https://api.github.com/users/sethpollack/events{/privacy}","received_events_url":"https://api.github.com/users/sethpollack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sethpollack/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":true,"url":"https://api.github.com/repos/sethpollack/kops","forks_url":"https://api.github.com/repos/sethpollack/kops/forks","keys_url":"https://api.github.com/repos/sethpollack/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sethpollack/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sethpollack/kops/teams","hooks_url":"https://api.github.com/repos/sethpollack/kops/hooks","issue_events_url":"https://api.github.com/repos/sethpollack/kops/issues/events{/number}","events_url":"https://api.github.com/repos/sethpollack/kops/events","assignees_url":"https://api.github.com/repos/sethpollack/kops/assignees{/user}","branches_url":"https://api.github.com/repos/sethpollack/kops/branches{/branch}","tags_url":"https://api.github.com/repos/sethpollack/kops/tags","blobs_url":"https://api.github.com/repos/sethpollack/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sethpollack/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sethpollack/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/sethpollack/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sethpollack/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/sethpollack/kops/languages","stargazers_url":"https://api.github.com/repos/sethpollack/kops/stargazers","contributors_url":"https://api.github.com/repos/sethpollack/kops/contributors","subscribers_url":"https://api.github.com/repos/sethpollack/kops/subscribers","subscription_url":"https://api.github.com/repos/sethpollack/kops/subscription","commits_url":"https://api.github.com/repos/sethpollack/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/sethpollack/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/sethpollack/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/sethpollack/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/sethpollack/kops/contents/{+path}","compare_url":"https://api.github.com/repos/sethpollack/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sethpollack/kops/merges","archive_url":"https://api.github.com/repos/sethpollack/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sethpollack/kops/downloads","issues_url":"https://api.github.com/repos/sethpollack/kops/issues{/number}","pulls_url":"https://api.github.com/repos/sethpollack/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/sethpollack/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/sethpollack/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sethpollack/kops/labels{/name}","releases_url":"https://api.github.com/repos/sethpollack/kops/releases{/id}","deployments_url":"https://api.github.com/repos/sethpollack/kops/deployments","created_at":"2017-01-29T02:58:27Z","updated_at":"2017-01-29T02:58:31Z","pushed_at":"2017-05-03T00:13:56Z","git_url":"git://github.com/sethpollack/kops.git","ssh_url":"git@github.com:sethpollack/kops.git","clone_url":"https://github.com/sethpollack/kops.git","svn_url":"https://github.com/sethpollack/kops","homepage":"","size":123220,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"77f222d319e66cc8d65ee13449db7a6a002087d5","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62091339,"name":"kops","full_name":"kubernetes/kops","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kops","forks_url":"https://api.github.com/repos/kubernetes/kops/forks","keys_url":"https://api.github.com/repos/kubernetes/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kops/teams","hooks_url":"https://api.github.com/repos/kubernetes/kops/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kops/events","assignees_url":"https://api.github.com/repos/kubernetes/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kops/tags","blobs_url":"https://api.github.com/repos/kubernetes/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kops/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kops/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kops/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kops/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kops/subscription","commits_url":"https://api.github.com/repos/kubernetes/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kops/merges","archive_url":"https://api.github.com/repos/kubernetes/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kops/downloads","issues_url":"https://api.github.com/repos/kubernetes/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kops/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kops/deployments","created_at":"2016-06-27T22:01:15Z","updated_at":"2017-05-03T20:20:52Z","pushed_at":"2017-05-03T21:37:19Z","git_url":"git://github.com/kubernetes/kops.git","ssh_url":"git@github.com:kubernetes/kops.git","clone_url":"https://github.com/kubernetes/kops.git","svn_url":"https://github.com/kubernetes/kops","homepage":"","size":134819,"stargazers_count":1673,"watchers_count":1673,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":426,"mirror_url":null,"open_issues_count":616,"forks":426,"open_issues":616,"watchers":1673,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/2483"},"html":{"href":"https://github.com/kubernetes/kops/pull/2483"},"issue":{"href":"https://api.github.com/repos/kubernetes/kops/issues/2483"},"comments":{"href":"https://api.github.com/repos/kubernetes/kops/issues/2483/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/2483/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/2483/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kops/statuses/881ca9e01f351047e199dc1492e8f2da26a981c1"}}}}
{"actor":{"display_login":"chrislovecnm"}}