{"action":"created","issue":{"url":"https://api.github.com/repos/vmware/govmomi/issues/844","repository_url":"https://api.github.com/repos/vmware/govmomi","labels_url":"https://api.github.com/repos/vmware/govmomi/issues/844/labels{/name}","comments_url":"https://api.github.com/repos/vmware/govmomi/issues/844/comments","events_url":"https://api.github.com/repos/vmware/govmomi/issues/844/events","html_url":"https://github.com/vmware/govmomi/issues/844","id":259029416,"number":844,"title":"Finder/fields with slashes unmarshaling issue","user":{"login":"vancluever","id":10704423,"avatar_url":"https://avatars0.githubusercontent.com/u/10704423?v=4","gravatar_id":"","url":"https://api.github.com/users/vancluever","html_url":"https://github.com/vancluever","followers_url":"https://api.github.com/users/vancluever/followers","following_url":"https://api.github.com/users/vancluever/following{/other_user}","gists_url":"https://api.github.com/users/vancluever/gists{/gist_id}","starred_url":"https://api.github.com/users/vancluever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vancluever/subscriptions","organizations_url":"https://api.github.com/users/vancluever/orgs","repos_url":"https://api.github.com/users/vancluever/repos","events_url":"https://api.github.com/users/vancluever/events{/privacy}","received_events_url":"https://api.github.com/users/vancluever/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-20T03:34:04Z","updated_at":"2017-09-20T17:06:11Z","closed_at":null,"author_association":"NONE","body":"Hey all,\r\n\r\nThis is kind of a continuation of #734 and possibly even more. It looks like the slash matching that was added with this commit is not working 100%, main reason being is that paths are fetched URL escaped.\r\n\r\nExample: A network named `my-net/work` actually shows up as `my-net%2fwork`, illustrated by this debug log message I put into `recurser.go`:\r\n\r\n```\r\n2017/09/19 20:06:12 [DEBUG] could not find path: port/group, trying to locate against /hashi-dc/network/port%2fgroup\r\n```\r\n\r\nUnescaping the string fixes this, but I think this opens another whole can of worms here as the object is not only coming back with an escaped name here, but also seemingly in other fields such as the actual name of the network, etc:\r\n\r\n```\r\n2017/09/19 20:24:57 [DEBUG] mvm.Guest.Net - []types.GuestNicInfo{types.GuestNicInfo{DynamicData:types.DynamicData{}, Network:\"port%2fgroup\", IpAddress:[]string{\"172.16.1.150\", \"fe80::250:56ff:fe94:e26c\"}, MacAddress:\"00:50:56:94:e2:6c\", Connected:true, DeviceConfigId:4000, DnsConfig:(*types.NetDnsConfigInfo)(nil), IpConfig:(*types.NetIpConfigInfo)(0xc420521830), NetBIOSConfig:types.BaseNetBIOSConfigInfo(nil)}}\r\n```\r\n\r\nI wonder if this is a deeper thing where fields with slashes in certain respects are being escaped in the API and will need to be unescaped on unmarshaling or something. Thoughts?\r\n\r\nRelated: terraform-providers/terraform-provider-vsphere#165\r\n"},"comment":{"url":"https://api.github.com/repos/vmware/govmomi/issues/comments/330917357","html_url":"https://github.com/vmware/govmomi/issues/844#issuecomment-330917357","issue_url":"https://api.github.com/repos/vmware/govmomi/issues/844","id":330917357,"user":{"login":"dougm","id":30171,"avatar_url":"https://avatars3.githubusercontent.com/u/30171?v=4","gravatar_id":"","url":"https://api.github.com/users/dougm","html_url":"https://github.com/dougm","followers_url":"https://api.github.com/users/dougm/followers","following_url":"https://api.github.com/users/dougm/following{/other_user}","gists_url":"https://api.github.com/users/dougm/gists{/gist_id}","starred_url":"https://api.github.com/users/dougm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougm/subscriptions","organizations_url":"https://api.github.com/users/dougm/orgs","repos_url":"https://api.github.com/users/dougm/repos","events_url":"https://api.github.com/users/dougm/events{/privacy}","received_events_url":"https://api.github.com/users/dougm/received_events","type":"User","site_admin":false},"created_at":"2017-09-20T17:06:11Z","updated_at":"2017-09-20T17:06:11Z","author_association":"MEMBER","body":"ok, that might be as-designed and my bad for only testing with the API and not the UI.  Though I had expected the API to validate the name doesn't include a '/' if that was the case.  I'll look into it today."}}
{"actor":{"display_login":"dougm"}}