{"action":"created","comment":{"url":"https://api.github.com/repos/dthain/basekernel/pulls/comments/144035917","pull_request_review_id":68634685,"id":144035917,"diff_hunk":"@@ -10,13 +10,15 @@ This program requires that write() and exit() work correctly.\n */","path":"src/test.c","position":1,"original_position":1,"commit_id":"c891d5fed6638b9180273fdee6212f536d355b72","original_commit_id":"c891d5fed6638b9180273fdee6212f536d355b72","user":{"login":"dthain","id":2752914,"avatar_url":"https://avatars3.githubusercontent.com/u/2752914?v=4","gravatar_id":"","url":"https://api.github.com/users/dthain","html_url":"https://github.com/dthain","followers_url":"https://api.github.com/users/dthain/followers","following_url":"https://api.github.com/users/dthain/following{/other_user}","gists_url":"https://api.github.com/users/dthain/gists{/gist_id}","starred_url":"https://api.github.com/users/dthain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dthain/subscriptions","organizations_url":"https://api.github.com/users/dthain/orgs","repos_url":"https://api.github.com/users/dthain/repos","events_url":"https://api.github.com/users/dthain/events{/privacy}","received_events_url":"https://api.github.com/users/dthain/received_events","type":"User","site_admin":false},"body":"This is starting to look like a C program!","created_at":"2017-10-11T14:50:43Z","updated_at":"2017-10-11T14:51:21Z","html_url":"https://github.com/dthain/basekernel/pull/52#discussion_r144035917","pull_request_url":"https://api.github.com/repos/dthain/basekernel/pulls/52","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dthain/basekernel/pulls/comments/144035917"},"html":{"href":"https://github.com/dthain/basekernel/pull/52#discussion_r144035917"},"pull_request":{"href":"https://api.github.com/repos/dthain/basekernel/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/dthain/basekernel/pulls/52","id":143287112,"html_url":"https://github.com/dthain/basekernel/pull/52","diff_url":"https://github.com/dthain/basekernel/pull/52.diff","patch_url":"https://github.com/dthain/basekernel/pull/52.patch","issue_url":"https://api.github.com/repos/dthain/basekernel/issues/52","number":52,"state":"open","locked":false,"title":"Temporary user lib in its own file","user":{"login":"JohnathonNow","id":5497725,"avatar_url":"https://avatars0.githubusercontent.com/u/5497725?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnathonNow","html_url":"https://github.com/JohnathonNow","followers_url":"https://api.github.com/users/JohnathonNow/followers","following_url":"https://api.github.com/users/JohnathonNow/following{/other_user}","gists_url":"https://api.github.com/users/JohnathonNow/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnathonNow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnathonNow/subscriptions","organizations_url":"https://api.github.com/users/JohnathonNow/orgs","repos_url":"https://api.github.com/users/JohnathonNow/repos","events_url":"https://api.github.com/users/JohnathonNow/events{/privacy}","received_events_url":"https://api.github.com/users/JohnathonNow/received_events","type":"User","site_admin":false},"body":"I have user library that is just string.h with printf buffering a call to `debug` along with an added `flush` function. I would like to move this into the existing string.[ch] files, but I'm not quite sure how to get around printf needing to use either `debug` in user mode or `console_write` in kernel mode.","created_at":"2017-09-27T02:51:52Z","updated_at":"2017-10-11T14:51:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13dea54b7eb947e32801ccaaf767346fd583ea50","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dthain/basekernel/pulls/52/commits","review_comments_url":"https://api.github.com/repos/dthain/basekernel/pulls/52/comments","review_comment_url":"https://api.github.com/repos/dthain/basekernel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dthain/basekernel/issues/52/comments","statuses_url":"https://api.github.com/repos/dthain/basekernel/statuses/c891d5fed6638b9180273fdee6212f536d355b72","head":{"label":"JohnathonNow:feature/user_string_lib","ref":"feature/user_string_lib","sha":"c891d5fed6638b9180273fdee6212f536d355b72","user":{"login":"JohnathonNow","id":5497725,"avatar_url":"https://avatars0.githubusercontent.com/u/5497725?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnathonNow","html_url":"https://github.com/JohnathonNow","followers_url":"https://api.github.com/users/JohnathonNow/followers","following_url":"https://api.github.com/users/JohnathonNow/following{/other_user}","gists_url":"https://api.github.com/users/JohnathonNow/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnathonNow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnathonNow/subscriptions","organizations_url":"https://api.github.com/users/JohnathonNow/orgs","repos_url":"https://api.github.com/users/JohnathonNow/repos","events_url":"https://api.github.com/users/JohnathonNow/events{/privacy}","received_events_url":"https://api.github.com/users/JohnathonNow/received_events","type":"User","site_admin":false},"repo":{"id":101947211,"name":"basekernel","full_name":"JohnathonNow/basekernel","owner":{"login":"JohnathonNow","id":5497725,"avatar_url":"https://avatars0.githubusercontent.com/u/5497725?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnathonNow","html_url":"https://github.com/JohnathonNow","followers_url":"https://api.github.com/users/JohnathonNow/followers","following_url":"https://api.github.com/users/JohnathonNow/following{/other_user}","gists_url":"https://api.github.com/users/JohnathonNow/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnathonNow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnathonNow/subscriptions","organizations_url":"https://api.github.com/users/JohnathonNow/orgs","repos_url":"https://api.github.com/users/JohnathonNow/repos","events_url":"https://api.github.com/users/JohnathonNow/events{/privacy}","received_events_url":"https://api.github.com/users/JohnathonNow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JohnathonNow/basekernel","description":"A simple OS kernel for research, teaching, and fun.","fork":true,"url":"https://api.github.com/repos/JohnathonNow/basekernel","forks_url":"https://api.github.com/repos/JohnathonNow/basekernel/forks","keys_url":"https://api.github.com/repos/JohnathonNow/basekernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JohnathonNow/basekernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JohnathonNow/basekernel/teams","hooks_url":"https://api.github.com/repos/JohnathonNow/basekernel/hooks","issue_events_url":"https://api.github.com/repos/JohnathonNow/basekernel/issues/events{/number}","events_url":"https://api.github.com/repos/JohnathonNow/basekernel/events","assignees_url":"https://api.github.com/repos/JohnathonNow/basekernel/assignees{/user}","branches_url":"https://api.github.com/repos/JohnathonNow/basekernel/branches{/branch}","tags_url":"https://api.github.com/repos/JohnathonNow/basekernel/tags","blobs_url":"https://api.github.com/repos/JohnathonNow/basekernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JohnathonNow/basekernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JohnathonNow/basekernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/JohnathonNow/basekernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JohnathonNow/basekernel/statuses/{sha}","languages_url":"https://api.github.com/repos/JohnathonNow/basekernel/languages","stargazers_url":"https://api.github.com/repos/JohnathonNow/basekernel/stargazers","contributors_url":"https://api.github.com/repos/JohnathonNow/basekernel/contributors","subscribers_url":"https://api.github.com/repos/JohnathonNow/basekernel/subscribers","subscription_url":"https://api.github.com/repos/JohnathonNow/basekernel/subscription","commits_url":"https://api.github.com/repos/JohnathonNow/basekernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/JohnathonNow/basekernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/JohnathonNow/basekernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/JohnathonNow/basekernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/JohnathonNow/basekernel/contents/{+path}","compare_url":"https://api.github.com/repos/JohnathonNow/basekernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JohnathonNow/basekernel/merges","archive_url":"https://api.github.com/repos/JohnathonNow/basekernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JohnathonNow/basekernel/downloads","issues_url":"https://api.github.com/repos/JohnathonNow/basekernel/issues{/number}","pulls_url":"https://api.github.com/repos/JohnathonNow/basekernel/pulls{/number}","milestones_url":"https://api.github.com/repos/JohnathonNow/basekernel/milestones{/number}","notifications_url":"https://api.github.com/repos/JohnathonNow/basekernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JohnathonNow/basekernel/labels{/name}","releases_url":"https://api.github.com/repos/JohnathonNow/basekernel/releases{/id}","deployments_url":"https://api.github.com/repos/JohnathonNow/basekernel/deployments","created_at":"2017-08-31T01:52:28Z","updated_at":"2017-08-31T01:52:30Z","pushed_at":"2017-10-10T18:56:58Z","git_url":"git://github.com/JohnathonNow/basekernel.git","ssh_url":"git@github.com:JohnathonNow/basekernel.git","clone_url":"https://github.com/JohnathonNow/basekernel.git","svn_url":"https://github.com/JohnathonNow/basekernel","homepage":null,"size":2037,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dthain:master","ref":"master","sha":"2bd6e9ec4e752e8ea7fbe9275b82e6f14264ef50","user":{"login":"dthain","id":2752914,"avatar_url":"https://avatars3.githubusercontent.com/u/2752914?v=4","gravatar_id":"","url":"https://api.github.com/users/dthain","html_url":"https://github.com/dthain","followers_url":"https://api.github.com/users/dthain/followers","following_url":"https://api.github.com/users/dthain/following{/other_user}","gists_url":"https://api.github.com/users/dthain/gists{/gist_id}","starred_url":"https://api.github.com/users/dthain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dthain/subscriptions","organizations_url":"https://api.github.com/users/dthain/orgs","repos_url":"https://api.github.com/users/dthain/repos","events_url":"https://api.github.com/users/dthain/events{/privacy}","received_events_url":"https://api.github.com/users/dthain/received_events","type":"User","site_admin":false},"repo":{"id":48499743,"name":"basekernel","full_name":"dthain/basekernel","owner":{"login":"dthain","id":2752914,"avatar_url":"https://avatars3.githubusercontent.com/u/2752914?v=4","gravatar_id":"","url":"https://api.github.com/users/dthain","html_url":"https://github.com/dthain","followers_url":"https://api.github.com/users/dthain/followers","following_url":"https://api.github.com/users/dthain/following{/other_user}","gists_url":"https://api.github.com/users/dthain/gists{/gist_id}","starred_url":"https://api.github.com/users/dthain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dthain/subscriptions","organizations_url":"https://api.github.com/users/dthain/orgs","repos_url":"https://api.github.com/users/dthain/repos","events_url":"https://api.github.com/users/dthain/events{/privacy}","received_events_url":"https://api.github.com/users/dthain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dthain/basekernel","description":"A simple OS kernel for research, teaching, and fun.","fork":false,"url":"https://api.github.com/repos/dthain/basekernel","forks_url":"https://api.github.com/repos/dthain/basekernel/forks","keys_url":"https://api.github.com/repos/dthain/basekernel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dthain/basekernel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dthain/basekernel/teams","hooks_url":"https://api.github.com/repos/dthain/basekernel/hooks","issue_events_url":"https://api.github.com/repos/dthain/basekernel/issues/events{/number}","events_url":"https://api.github.com/repos/dthain/basekernel/events","assignees_url":"https://api.github.com/repos/dthain/basekernel/assignees{/user}","branches_url":"https://api.github.com/repos/dthain/basekernel/branches{/branch}","tags_url":"https://api.github.com/repos/dthain/basekernel/tags","blobs_url":"https://api.github.com/repos/dthain/basekernel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dthain/basekernel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dthain/basekernel/git/refs{/sha}","trees_url":"https://api.github.com/repos/dthain/basekernel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dthain/basekernel/statuses/{sha}","languages_url":"https://api.github.com/repos/dthain/basekernel/languages","stargazers_url":"https://api.github.com/repos/dthain/basekernel/stargazers","contributors_url":"https://api.github.com/repos/dthain/basekernel/contributors","subscribers_url":"https://api.github.com/repos/dthain/basekernel/subscribers","subscription_url":"https://api.github.com/repos/dthain/basekernel/subscription","commits_url":"https://api.github.com/repos/dthain/basekernel/commits{/sha}","git_commits_url":"https://api.github.com/repos/dthain/basekernel/git/commits{/sha}","comments_url":"https://api.github.com/repos/dthain/basekernel/comments{/number}","issue_comment_url":"https://api.github.com/repos/dthain/basekernel/issues/comments{/number}","contents_url":"https://api.github.com/repos/dthain/basekernel/contents/{+path}","compare_url":"https://api.github.com/repos/dthain/basekernel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dthain/basekernel/merges","archive_url":"https://api.github.com/repos/dthain/basekernel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dthain/basekernel/downloads","issues_url":"https://api.github.com/repos/dthain/basekernel/issues{/number}","pulls_url":"https://api.github.com/repos/dthain/basekernel/pulls{/number}","milestones_url":"https://api.github.com/repos/dthain/basekernel/milestones{/number}","notifications_url":"https://api.github.com/repos/dthain/basekernel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dthain/basekernel/labels{/name}","releases_url":"https://api.github.com/repos/dthain/basekernel/releases{/id}","deployments_url":"https://api.github.com/repos/dthain/basekernel/deployments","created_at":"2015-12-23T16:17:36Z","updated_at":"2017-10-07T17:38:56Z","pushed_at":"2017-10-10T18:57:00Z","git_url":"git://github.com/dthain/basekernel.git","ssh_url":"git@github.com:dthain/basekernel.git","clone_url":"https://github.com/dthain/basekernel.git","svn_url":"https://github.com/dthain/basekernel","homepage":null,"size":2010,"stargazers_count":138,"watchers_count":138,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":34,"mirror_url":null,"open_issues_count":19,"forks":34,"open_issues":19,"watchers":138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dthain/basekernel/pulls/52"},"html":{"href":"https://github.com/dthain/basekernel/pull/52"},"issue":{"href":"https://api.github.com/repos/dthain/basekernel/issues/52"},"comments":{"href":"https://api.github.com/repos/dthain/basekernel/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/dthain/basekernel/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/dthain/basekernel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dthain/basekernel/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/dthain/basekernel/statuses/c891d5fed6638b9180273fdee6212f536d355b72"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dthain"}}