{"action":"created","comment":{"url":"https://api.github.com/repos/alicevision/openMVG/pulls/comments/121170521","pull_request_review_id":43203633,"id":121170521,"diff_hunk":"@@ -0,0 +1,1231 @@\n+#include \"openMVG/multiview/projection.hpp\"\n+#include \"openMVG/numeric/numeric.h\"\n+#include \"openMVG/multiview/solver_resection_p4pf.hpp\"\n+\n+#include <cmath>\n+#include <cstring>\n+#include <limits>\n+#include <iostream>\n+\n+namespace openMVG {\n+namespace resection {\n+\n+void GJ(double *A, int rcnt, int ccnt, double tol)\n+{\n+  int row = 0;\n+  int col = 0;\n+  int k;\n+  int l;","path":"src/openMVG/multiview/solver_resection_p4pf.cpp","position":18,"original_position":18,"commit_id":"d104525d0786bc8c490c47089a28ff2a201ea62e","original_commit_id":"d104525d0786bc8c490c47089a28ff2a201ea62e","user":{"login":"simogasp","id":1331744,"avatar_url":"https://avatars0.githubusercontent.com/u/1331744?v=3","gravatar_id":"","url":"https://api.github.com/users/simogasp","html_url":"https://github.com/simogasp","followers_url":"https://api.github.com/users/simogasp/followers","following_url":"https://api.github.com/users/simogasp/following{/other_user}","gists_url":"https://api.github.com/users/simogasp/gists{/gist_id}","starred_url":"https://api.github.com/users/simogasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simogasp/subscriptions","organizations_url":"https://api.github.com/users/simogasp/orgs","repos_url":"https://api.github.com/users/simogasp/repos","events_url":"https://api.github.com/users/simogasp/events{/privacy}","received_events_url":"https://api.github.com/users/simogasp/received_events","type":"User","site_admin":false},"body":"`l` and `k`, beside the naming issue, can be safely removed here and declared inside each for","created_at":"2017-06-09T16:38:17Z","updated_at":"2017-06-09T16:38:17Z","html_url":"https://github.com/alicevision/openMVG/pull/306#discussion_r121170521","pull_request_url":"https://api.github.com/repos/alicevision/openMVG/pulls/306","_links":{"self":{"href":"https://api.github.com/repos/alicevision/openMVG/pulls/comments/121170521"},"html":{"href":"https://github.com/alicevision/openMVG/pull/306#discussion_r121170521"},"pull_request":{"href":"https://api.github.com/repos/alicevision/openMVG/pulls/306"}}},"pull_request":{"url":"https://api.github.com/repos/alicevision/openMVG/pulls/306","id":120766019,"html_url":"https://github.com/alicevision/openMVG/pull/306","diff_url":"https://github.com/alicevision/openMVG/pull/306.diff","patch_url":"https://github.com/alicevision/openMVG/pull/306.patch","issue_url":"https://api.github.com/repos/alicevision/openMVG/issues/306","number":306,"state":"open","locked":false,"title":"[multiview] Added basic functions for p4pf","user":{"login":"simogasp","id":1331744,"avatar_url":"https://avatars0.githubusercontent.com/u/1331744?v=3","gravatar_id":"","url":"https://api.github.com/users/simogasp","html_url":"https://github.com/simogasp","followers_url":"https://api.github.com/users/simogasp/followers","following_url":"https://api.github.com/users/simogasp/following{/other_user}","gists_url":"https://api.github.com/users/simogasp/gists{/gist_id}","starred_url":"https://api.github.com/users/simogasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simogasp/subscriptions","organizations_url":"https://api.github.com/users/simogasp/orgs","repos_url":"https://api.github.com/users/simogasp/repos","events_url":"https://api.github.com/users/simogasp/events{/privacy}","received_events_url":"https://api.github.com/users/simogasp/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-16T08:00:43Z","updated_at":"2017-06-09T16:38:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6e33009cc575852fae442e86e208c55b14d365a","assignee":{"login":"simogasp","id":1331744,"avatar_url":"https://avatars0.githubusercontent.com/u/1331744?v=3","gravatar_id":"","url":"https://api.github.com/users/simogasp","html_url":"https://github.com/simogasp","followers_url":"https://api.github.com/users/simogasp/followers","following_url":"https://api.github.com/users/simogasp/following{/other_user}","gists_url":"https://api.github.com/users/simogasp/gists{/gist_id}","starred_url":"https://api.github.com/users/simogasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simogasp/subscriptions","organizations_url":"https://api.github.com/users/simogasp/orgs","repos_url":"https://api.github.com/users/simogasp/repos","events_url":"https://api.github.com/users/simogasp/events{/privacy}","received_events_url":"https://api.github.com/users/simogasp/received_events","type":"User","site_admin":false},"assignees":[{"login":"simogasp","id":1331744,"avatar_url":"https://avatars0.githubusercontent.com/u/1331744?v=3","gravatar_id":"","url":"https://api.github.com/users/simogasp","html_url":"https://github.com/simogasp","followers_url":"https://api.github.com/users/simogasp/followers","following_url":"https://api.github.com/users/simogasp/following{/other_user}","gists_url":"https://api.github.com/users/simogasp/gists{/gist_id}","starred_url":"https://api.github.com/users/simogasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simogasp/subscriptions","organizations_url":"https://api.github.com/users/simogasp/orgs","repos_url":"https://api.github.com/users/simogasp/repos","events_url":"https://api.github.com/users/simogasp/events{/privacy}","received_events_url":"https://api.github.com/users/simogasp/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"fabiencastan","id":153585,"avatar_url":"https://avatars0.githubusercontent.com/u/153585?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiencastan","html_url":"https://github.com/fabiencastan","followers_url":"https://api.github.com/users/fabiencastan/followers","following_url":"https://api.github.com/users/fabiencastan/following{/other_user}","gists_url":"https://api.github.com/users/fabiencastan/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiencastan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiencastan/subscriptions","organizations_url":"https://api.github.com/users/fabiencastan/orgs","repos_url":"https://api.github.com/users/fabiencastan/repos","events_url":"https://api.github.com/users/fabiencastan/events{/privacy}","received_events_url":"https://api.github.com/users/fabiencastan/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/alicevision/openMVG/milestones/23","html_url":"https://github.com/alicevision/openMVG/milestone/23","labels_url":"https://api.github.com/repos/alicevision/openMVG/milestones/23/labels","id":2433308,"number":23,"title":"2017_05","description":"","creator":{"login":"simogasp","id":1331744,"avatar_url":"https://avatars0.githubusercontent.com/u/1331744?v=3","gravatar_id":"","url":"https://api.github.com/users/simogasp","html_url":"https://github.com/simogasp","followers_url":"https://api.github.com/users/simogasp/followers","following_url":"https://api.github.com/users/simogasp/following{/other_user}","gists_url":"https://api.github.com/users/simogasp/gists{/gist_id}","starred_url":"https://api.github.com/users/simogasp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simogasp/subscriptions","organizations_url":"https://api.github.com/users/simogasp/orgs","repos_url":"https://api.github.com/users/simogasp/repos","events_url":"https://api.github.com/users/simogasp/events{/privacy}","received_events_url":"https://api.github.com/users/simogasp/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":3,"state":"open","created_at":"2017-04-04T10:27:48Z","updated_at":"2017-05-16T15:41:10Z","due_on":"2017-06-01T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/alicevision/openMVG/pulls/306/commits","review_comments_url":"https://api.github.com/repos/alicevision/openMVG/pulls/306/comments","review_comment_url":"https://api.github.com/repos/alicevision/openMVG/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alicevision/openMVG/issues/306/comments","statuses_url":"https://api.github.com/repos/alicevision/openMVG/statuses/d104525d0786bc8c490c47089a28ff2a201ea62e","head":{"label":"alicevision:dev_P4Pf","ref":"dev_P4Pf","sha":"d104525d0786bc8c490c47089a28ff2a201ea62e","user":{"login":"alicevision","id":9333123,"avatar_url":"https://avatars3.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/alicevision","html_url":"https://github.com/alicevision","followers_url":"https://api.github.com/users/alicevision/followers","following_url":"https://api.github.com/users/alicevision/following{/other_user}","gists_url":"https://api.github.com/users/alicevision/gists{/gist_id}","starred_url":"https://api.github.com/users/alicevision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicevision/subscriptions","organizations_url":"https://api.github.com/users/alicevision/orgs","repos_url":"https://api.github.com/users/alicevision/repos","events_url":"https://api.github.com/users/alicevision/events{/privacy}","received_events_url":"https://api.github.com/users/alicevision/received_events","type":"Organization","site_admin":false},"repo":{"id":28635894,"name":"openMVG","full_name":"alicevision/openMVG","owner":{"login":"alicevision","id":9333123,"avatar_url":"https://avatars3.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/alicevision","html_url":"https://github.com/alicevision","followers_url":"https://api.github.com/users/alicevision/followers","following_url":"https://api.github.com/users/alicevision/following{/other_user}","gists_url":"https://api.github.com/users/alicevision/gists{/gist_id}","starred_url":"https://api.github.com/users/alicevision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicevision/subscriptions","organizations_url":"https://api.github.com/users/alicevision/orgs","repos_url":"https://api.github.com/users/alicevision/repos","events_url":"https://api.github.com/users/alicevision/events{/privacy}","received_events_url":"https://api.github.com/users/alicevision/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alicevision/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":false,"url":"https://api.github.com/repos/alicevision/openMVG","forks_url":"https://api.github.com/repos/alicevision/openMVG/forks","keys_url":"https://api.github.com/repos/alicevision/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alicevision/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alicevision/openMVG/teams","hooks_url":"https://api.github.com/repos/alicevision/openMVG/hooks","issue_events_url":"https://api.github.com/repos/alicevision/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/alicevision/openMVG/events","assignees_url":"https://api.github.com/repos/alicevision/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/alicevision/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/alicevision/openMVG/tags","blobs_url":"https://api.github.com/repos/alicevision/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alicevision/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alicevision/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/alicevision/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alicevision/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/alicevision/openMVG/languages","stargazers_url":"https://api.github.com/repos/alicevision/openMVG/stargazers","contributors_url":"https://api.github.com/repos/alicevision/openMVG/contributors","subscribers_url":"https://api.github.com/repos/alicevision/openMVG/subscribers","subscription_url":"https://api.github.com/repos/alicevision/openMVG/subscription","commits_url":"https://api.github.com/repos/alicevision/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/alicevision/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/alicevision/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/alicevision/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/alicevision/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/alicevision/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alicevision/openMVG/merges","archive_url":"https://api.github.com/repos/alicevision/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alicevision/openMVG/downloads","issues_url":"https://api.github.com/repos/alicevision/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/alicevision/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/alicevision/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/alicevision/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alicevision/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/alicevision/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/alicevision/openMVG/deployments","created_at":"2014-12-30T15:39:27Z","updated_at":"2017-05-17T20:14:08Z","pushed_at":"2017-06-09T16:30:55Z","git_url":"git://github.com/alicevision/openMVG.git","ssh_url":"git@github.com:alicevision/openMVG.git","clone_url":"https://github.com/alicevision/openMVG.git","svn_url":"https://github.com/alicevision/openMVG","homepage":"","size":24551,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":54,"forks":4,"open_issues":54,"watchers":7,"default_branch":"popart_develop"}},"base":{"label":"alicevision:popart_develop","ref":"popart_develop","sha":"9224e891093291ec11afc3ac7dc0abf3f9f87648","user":{"login":"alicevision","id":9333123,"avatar_url":"https://avatars3.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/alicevision","html_url":"https://github.com/alicevision","followers_url":"https://api.github.com/users/alicevision/followers","following_url":"https://api.github.com/users/alicevision/following{/other_user}","gists_url":"https://api.github.com/users/alicevision/gists{/gist_id}","starred_url":"https://api.github.com/users/alicevision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicevision/subscriptions","organizations_url":"https://api.github.com/users/alicevision/orgs","repos_url":"https://api.github.com/users/alicevision/repos","events_url":"https://api.github.com/users/alicevision/events{/privacy}","received_events_url":"https://api.github.com/users/alicevision/received_events","type":"Organization","site_admin":false},"repo":{"id":28635894,"name":"openMVG","full_name":"alicevision/openMVG","owner":{"login":"alicevision","id":9333123,"avatar_url":"https://avatars3.githubusercontent.com/u/9333123?v=3","gravatar_id":"","url":"https://api.github.com/users/alicevision","html_url":"https://github.com/alicevision","followers_url":"https://api.github.com/users/alicevision/followers","following_url":"https://api.github.com/users/alicevision/following{/other_user}","gists_url":"https://api.github.com/users/alicevision/gists{/gist_id}","starred_url":"https://api.github.com/users/alicevision/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicevision/subscriptions","organizations_url":"https://api.github.com/users/alicevision/orgs","repos_url":"https://api.github.com/users/alicevision/repos","events_url":"https://api.github.com/users/alicevision/events{/privacy}","received_events_url":"https://api.github.com/users/alicevision/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alicevision/openMVG","description":"open Multiple View Geometry library. Basis for 3D computer vision and Structure from Motion.","fork":false,"url":"https://api.github.com/repos/alicevision/openMVG","forks_url":"https://api.github.com/repos/alicevision/openMVG/forks","keys_url":"https://api.github.com/repos/alicevision/openMVG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alicevision/openMVG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alicevision/openMVG/teams","hooks_url":"https://api.github.com/repos/alicevision/openMVG/hooks","issue_events_url":"https://api.github.com/repos/alicevision/openMVG/issues/events{/number}","events_url":"https://api.github.com/repos/alicevision/openMVG/events","assignees_url":"https://api.github.com/repos/alicevision/openMVG/assignees{/user}","branches_url":"https://api.github.com/repos/alicevision/openMVG/branches{/branch}","tags_url":"https://api.github.com/repos/alicevision/openMVG/tags","blobs_url":"https://api.github.com/repos/alicevision/openMVG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alicevision/openMVG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alicevision/openMVG/git/refs{/sha}","trees_url":"https://api.github.com/repos/alicevision/openMVG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alicevision/openMVG/statuses/{sha}","languages_url":"https://api.github.com/repos/alicevision/openMVG/languages","stargazers_url":"https://api.github.com/repos/alicevision/openMVG/stargazers","contributors_url":"https://api.github.com/repos/alicevision/openMVG/contributors","subscribers_url":"https://api.github.com/repos/alicevision/openMVG/subscribers","subscription_url":"https://api.github.com/repos/alicevision/openMVG/subscription","commits_url":"https://api.github.com/repos/alicevision/openMVG/commits{/sha}","git_commits_url":"https://api.github.com/repos/alicevision/openMVG/git/commits{/sha}","comments_url":"https://api.github.com/repos/alicevision/openMVG/comments{/number}","issue_comment_url":"https://api.github.com/repos/alicevision/openMVG/issues/comments{/number}","contents_url":"https://api.github.com/repos/alicevision/openMVG/contents/{+path}","compare_url":"https://api.github.com/repos/alicevision/openMVG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alicevision/openMVG/merges","archive_url":"https://api.github.com/repos/alicevision/openMVG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alicevision/openMVG/downloads","issues_url":"https://api.github.com/repos/alicevision/openMVG/issues{/number}","pulls_url":"https://api.github.com/repos/alicevision/openMVG/pulls{/number}","milestones_url":"https://api.github.com/repos/alicevision/openMVG/milestones{/number}","notifications_url":"https://api.github.com/repos/alicevision/openMVG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alicevision/openMVG/labels{/name}","releases_url":"https://api.github.com/repos/alicevision/openMVG/releases{/id}","deployments_url":"https://api.github.com/repos/alicevision/openMVG/deployments","created_at":"2014-12-30T15:39:27Z","updated_at":"2017-05-17T20:14:08Z","pushed_at":"2017-06-09T16:30:55Z","git_url":"git://github.com/alicevision/openMVG.git","ssh_url":"git@github.com:alicevision/openMVG.git","clone_url":"https://github.com/alicevision/openMVG.git","svn_url":"https://github.com/alicevision/openMVG","homepage":"","size":24551,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":54,"forks":4,"open_issues":54,"watchers":7,"default_branch":"popart_develop"}},"_links":{"self":{"href":"https://api.github.com/repos/alicevision/openMVG/pulls/306"},"html":{"href":"https://github.com/alicevision/openMVG/pull/306"},"issue":{"href":"https://api.github.com/repos/alicevision/openMVG/issues/306"},"comments":{"href":"https://api.github.com/repos/alicevision/openMVG/issues/306/comments"},"review_comments":{"href":"https://api.github.com/repos/alicevision/openMVG/pulls/306/comments"},"review_comment":{"href":"https://api.github.com/repos/alicevision/openMVG/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alicevision/openMVG/pulls/306/commits"},"statuses":{"href":"https://api.github.com/repos/alicevision/openMVG/statuses/d104525d0786bc8c490c47089a28ff2a201ea62e"}}}}
{"actor":{"display_login":"simogasp"}}