{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/151802346","pull_request_review_id":77576898,"id":151802346,"diff_hunk":"@@ -18,7 +18,7 @@ package proxy\n \n const (\n \t// KubeProxyConfigMap is the proxy ConfigMap manifest","path":"cmd/kubeadm/app/phases/addons/proxy/manifests.go","position":3,"original_position":3,"commit_id":"43abe8edd744d39e92161a3661d5ed9d34d3e69b","original_commit_id":"43abe8edd744d39e92161a3661d5ed9d34d3e69b","user":{"login":"luxas","id":5442475,"avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"body":"comment needs updating","created_at":"2017-11-17T22:16:38Z","updated_at":"2017-11-17T22:32:43Z","html_url":"https://github.com/kubernetes/kubernetes/pull/55972#discussion_r151802346","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55972","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/151802346"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/55972#discussion_r151802346"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55972"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55972","id":153386752,"html_url":"https://github.com/kubernetes/kubernetes/pull/55972","diff_url":"https://github.com/kubernetes/kubernetes/pull/55972.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/55972.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/55972","number":55972,"state":"open","locked":false,"title":"Update kubeadm config for setting kube-proxy bind address","user":{"login":"rpothier","id":3081592,"avatar_url":"https://avatars3.githubusercontent.com/u/3081592?v=4","gravatar_id":"","url":"https://api.github.com/users/rpothier","html_url":"https://github.com/rpothier","followers_url":"https://api.github.com/users/rpothier/followers","following_url":"https://api.github.com/users/rpothier/following{/other_user}","gists_url":"https://api.github.com/users/rpothier/gists{/gist_id}","starred_url":"https://api.github.com/users/rpothier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpothier/subscriptions","organizations_url":"https://api.github.com/users/rpothier/orgs","repos_url":"https://api.github.com/users/rpothier/repos","events_url":"https://api.github.com/users/rpothier/events{/privacy}","received_events_url":"https://api.github.com/users/rpothier/received_events","type":"User","site_admin":false},"body":"This change adds configuring the kube-proxy bind address to be an\r\nIPv6 address based on the whether the API server advertise address is IPv6.\r\n\r\n\r\n\r\n**What this PR does / why we need it**:\r\nThis PR sets the bind address for kube-proxy to be a IPv6 address. This is needed for IPv6\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #50927\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n\r\n```release-note NONE\r\n\r\n```\r\n","created_at":"2017-11-17T20:26:25Z","updated_at":"2017-11-17T22:32:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59f7044fd1c3820a316e9191c48da7fc310075f9","assignee":{"login":"luxas","id":5442475,"avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false},"assignees":[{"login":"errordeveloper","id":251467,"avatar_url":"https://avatars1.githubusercontent.com/u/251467?v=4","gravatar_id":"","url":"https://api.github.com/users/errordeveloper","html_url":"https://github.com/errordeveloper","followers_url":"https://api.github.com/users/errordeveloper/followers","following_url":"https://api.github.com/users/errordeveloper/following{/other_user}","gists_url":"https://api.github.com/users/errordeveloper/gists{/gist_id}","starred_url":"https://api.github.com/users/errordeveloper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/errordeveloper/subscriptions","organizations_url":"https://api.github.com/users/errordeveloper/orgs","repos_url":"https://api.github.com/users/errordeveloper/repos","events_url":"https://api.github.com/users/errordeveloper/events{/privacy}","received_events_url":"https://api.github.com/users/errordeveloper/received_events","type":"User","site_admin":false},{"login":"luxas","id":5442475,"avatar_url":"https://avatars1.githubusercontent.com/u/5442475?v=4","gravatar_id":"","url":"https://api.github.com/users/luxas","html_url":"https://github.com/luxas","followers_url":"https://api.github.com/users/luxas/followers","following_url":"https://api.github.com/users/luxas/following{/other_user}","gists_url":"https://api.github.com/users/luxas/gists{/gist_id}","starred_url":"https://api.github.com/users/luxas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luxas/subscriptions","organizations_url":"https://api.github.com/users/luxas/orgs","repos_url":"https://api.github.com/users/luxas/repos","events_url":"https://api.github.com/users/luxas/events{/privacy}","received_events_url":"https://api.github.com/users/luxas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55972/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55972/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/55972/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/43abe8edd744d39e92161a3661d5ed9d34d3e69b","head":{"label":"rpothier:v6_proxy_bind_addr","ref":"v6_proxy_bind_addr","sha":"43abe8edd744d39e92161a3661d5ed9d34d3e69b","user":{"login":"rpothier","id":3081592,"avatar_url":"https://avatars3.githubusercontent.com/u/3081592?v=4","gravatar_id":"","url":"https://api.github.com/users/rpothier","html_url":"https://github.com/rpothier","followers_url":"https://api.github.com/users/rpothier/followers","following_url":"https://api.github.com/users/rpothier/following{/other_user}","gists_url":"https://api.github.com/users/rpothier/gists{/gist_id}","starred_url":"https://api.github.com/users/rpothier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpothier/subscriptions","organizations_url":"https://api.github.com/users/rpothier/orgs","repos_url":"https://api.github.com/users/rpothier/repos","events_url":"https://api.github.com/users/rpothier/events{/privacy}","received_events_url":"https://api.github.com/users/rpothier/received_events","type":"User","site_admin":false},"repo":{"id":85582316,"name":"kubernetes","full_name":"rpothier/kubernetes","owner":{"login":"rpothier","id":3081592,"avatar_url":"https://avatars3.githubusercontent.com/u/3081592?v=4","gravatar_id":"","url":"https://api.github.com/users/rpothier","html_url":"https://github.com/rpothier","followers_url":"https://api.github.com/users/rpothier/followers","following_url":"https://api.github.com/users/rpothier/following{/other_user}","gists_url":"https://api.github.com/users/rpothier/gists{/gist_id}","starred_url":"https://api.github.com/users/rpothier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpothier/subscriptions","organizations_url":"https://api.github.com/users/rpothier/orgs","repos_url":"https://api.github.com/users/rpothier/repos","events_url":"https://api.github.com/users/rpothier/events{/privacy}","received_events_url":"https://api.github.com/users/rpothier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rpothier/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/rpothier/kubernetes","forks_url":"https://api.github.com/repos/rpothier/kubernetes/forks","keys_url":"https://api.github.com/repos/rpothier/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpothier/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpothier/kubernetes/teams","hooks_url":"https://api.github.com/repos/rpothier/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/rpothier/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/rpothier/kubernetes/events","assignees_url":"https://api.github.com/repos/rpothier/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/rpothier/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/rpothier/kubernetes/tags","blobs_url":"https://api.github.com/repos/rpothier/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpothier/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpothier/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpothier/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpothier/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/rpothier/kubernetes/languages","stargazers_url":"https://api.github.com/repos/rpothier/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/rpothier/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/rpothier/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/rpothier/kubernetes/subscription","commits_url":"https://api.github.com/repos/rpothier/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpothier/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpothier/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpothier/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpothier/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/rpothier/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpothier/kubernetes/merges","archive_url":"https://api.github.com/repos/rpothier/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpothier/kubernetes/downloads","issues_url":"https://api.github.com/repos/rpothier/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/rpothier/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/rpothier/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/rpothier/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpothier/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/rpothier/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/rpothier/kubernetes/deployments","created_at":"2017-03-20T13:49:58Z","updated_at":"2017-03-20T13:50:31Z","pushed_at":"2017-11-17T22:12:40Z","git_url":"git://github.com/rpothier/kubernetes.git","ssh_url":"git@github.com:rpothier/kubernetes.git","clone_url":"https://github.com/rpothier/kubernetes.git","svn_url":"https://github.com/rpothier/kubernetes","homepage":"http://kubernetes.io","size":523930,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3ec7487c0fdd6ac7498fbf093b7192579581227f","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-11-17T22:25:28Z","pushed_at":"2017-11-17T22:30:46Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":744792,"stargazers_count":29009,"watchers_count":29009,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10378,"mirror_url":null,"archived":false,"open_issues_count":5592,"forks":10378,"open_issues":5592,"watchers":29009,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55972"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/55972"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/55972"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/55972/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55972/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55972/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/43abe8edd744d39e92161a3661d5ed9d34d3e69b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"luxas"}}