{"action":"created","comment":{"url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls/comments/104022988","pull_request_review_id":24836257,"id":104022988,"diff_hunk":"@@ -169,8 +158,13 @@ def as_dict(self):\n         responses = self.register_errors()\n \n         for ns in self.api.namespaces:\n+            if ns.internal and not show_internal:\n+                continue\n             for resource, url, kwargs in ns.resources:\n-                paths[extract_path(url)] = self.serialize_resource(ns, resource, url, kwargs)\n+                if resource.internal and not show_internal:","path":"wsgiservice_restplus/swagger.py","position":54,"original_position":54,"commit_id":"131acddf006f51d3961a4ac71f137be327f58ef0","original_commit_id":"131acddf006f51d3961a4ac71f137be327f58ef0","user":{"login":"Wattos","id":724759,"avatar_url":"https://avatars1.githubusercontent.com/u/724759?v=3","gravatar_id":"","url":"https://api.github.com/users/Wattos","html_url":"https://github.com/Wattos","followers_url":"https://api.github.com/users/Wattos/followers","following_url":"https://api.github.com/users/Wattos/following{/other_user}","gists_url":"https://api.github.com/users/Wattos/gists{/gist_id}","starred_url":"https://api.github.com/users/Wattos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wattos/subscriptions","organizations_url":"https://api.github.com/users/Wattos/orgs","repos_url":"https://api.github.com/users/Wattos/repos","events_url":"https://api.github.com/users/Wattos/events{/privacy}","received_events_url":"https://api.github.com/users/Wattos/received_events","type":"User","site_admin":false},"body":"`kwarge.get('public', False)` instead of `internal`. This is better design","created_at":"2017-03-02T20:32:40Z","updated_at":"2017-03-02T20:32:40Z","html_url":"https://github.com/beekpr/wsgiservice-restplus/pull/9#discussion_r104022988","pull_request_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls/comments/104022988"},"html":{"href":"https://github.com/beekpr/wsgiservice-restplus/pull/9#discussion_r104022988"},"pull_request":{"href":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls/9","id":108752430,"html_url":"https://github.com/beekpr/wsgiservice-restplus/pull/9","diff_url":"https://github.com/beekpr/wsgiservice-restplus/pull/9.diff","patch_url":"https://github.com/beekpr/wsgiservice-restplus/pull/9.patch","issue_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/issues/9","number":9,"state":"open","locked":false,"title":"FUL-5009: Ability to restrict resources for internal use only","user":{"login":"philthyharry","id":17498257,"avatar_url":"https://avatars1.githubusercontent.com/u/17498257?v=3","gravatar_id":"","url":"https://api.github.com/users/philthyharry","html_url":"https://github.com/philthyharry","followers_url":"https://api.github.com/users/philthyharry/followers","following_url":"https://api.github.com/users/philthyharry/following{/other_user}","gists_url":"https://api.github.com/users/philthyharry/gists{/gist_id}","starred_url":"https://api.github.com/users/philthyharry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philthyharry/subscriptions","organizations_url":"https://api.github.com/users/philthyharry/orgs","repos_url":"https://api.github.com/users/philthyharry/repos","events_url":"https://api.github.com/users/philthyharry/events{/privacy}","received_events_url":"https://api.github.com/users/philthyharry/received_events","type":"User","site_admin":false},"body":"Namespaces or `route()` method can now be given `internal=True` parameter to restrict the namespace/resource respectively for internal display only. Thus:\r\n\r\n`/api/2/swagger.json` will return a swagger.json which will NOT include resources/namespaces that have been marked as internal.\r\n\r\n`/api/2/swagger.json?internal=true` will return the entire swagger.json (including internal endpoints)\r\n\r\n\r\n","created_at":"2017-03-02T12:50:21Z","updated_at":"2017-03-02T20:32:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3384c8e6f3e527c9fee5229d854a4bd68a4d05e3","assignee":{"login":"Wattos","id":724759,"avatar_url":"https://avatars1.githubusercontent.com/u/724759?v=3","gravatar_id":"","url":"https://api.github.com/users/Wattos","html_url":"https://github.com/Wattos","followers_url":"https://api.github.com/users/Wattos/followers","following_url":"https://api.github.com/users/Wattos/following{/other_user}","gists_url":"https://api.github.com/users/Wattos/gists{/gist_id}","starred_url":"https://api.github.com/users/Wattos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wattos/subscriptions","organizations_url":"https://api.github.com/users/Wattos/orgs","repos_url":"https://api.github.com/users/Wattos/repos","events_url":"https://api.github.com/users/Wattos/events{/privacy}","received_events_url":"https://api.github.com/users/Wattos/received_events","type":"User","site_admin":false},"assignees":[{"login":"Wattos","id":724759,"avatar_url":"https://avatars1.githubusercontent.com/u/724759?v=3","gravatar_id":"","url":"https://api.github.com/users/Wattos","html_url":"https://github.com/Wattos","followers_url":"https://api.github.com/users/Wattos/followers","following_url":"https://api.github.com/users/Wattos/following{/other_user}","gists_url":"https://api.github.com/users/Wattos/gists{/gist_id}","starred_url":"https://api.github.com/users/Wattos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wattos/subscriptions","organizations_url":"https://api.github.com/users/Wattos/orgs","repos_url":"https://api.github.com/users/Wattos/repos","events_url":"https://api.github.com/users/Wattos/events{/privacy}","received_events_url":"https://api.github.com/users/Wattos/received_events","type":"User","site_admin":false},{"login":"philthyharry","id":17498257,"avatar_url":"https://avatars1.githubusercontent.com/u/17498257?v=3","gravatar_id":"","url":"https://api.github.com/users/philthyharry","html_url":"https://github.com/philthyharry","followers_url":"https://api.github.com/users/philthyharry/followers","following_url":"https://api.github.com/users/philthyharry/following{/other_user}","gists_url":"https://api.github.com/users/philthyharry/gists{/gist_id}","starred_url":"https://api.github.com/users/philthyharry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philthyharry/subscriptions","organizations_url":"https://api.github.com/users/philthyharry/orgs","repos_url":"https://api.github.com/users/philthyharry/repos","events_url":"https://api.github.com/users/philthyharry/events{/privacy}","received_events_url":"https://api.github.com/users/philthyharry/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls/9/commits","review_comments_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls/9/comments","review_comment_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/issues/9/comments","statuses_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/statuses/131acddf006f51d3961a4ac71f137be327f58ef0","head":{"label":"beekpr:FUL-5009","ref":"FUL-5009","sha":"131acddf006f51d3961a4ac71f137be327f58ef0","user":{"login":"beekpr","id":9117555,"avatar_url":"https://avatars1.githubusercontent.com/u/9117555?v=3","gravatar_id":"","url":"https://api.github.com/users/beekpr","html_url":"https://github.com/beekpr","followers_url":"https://api.github.com/users/beekpr/followers","following_url":"https://api.github.com/users/beekpr/following{/other_user}","gists_url":"https://api.github.com/users/beekpr/gists{/gist_id}","starred_url":"https://api.github.com/users/beekpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beekpr/subscriptions","organizations_url":"https://api.github.com/users/beekpr/orgs","repos_url":"https://api.github.com/users/beekpr/repos","events_url":"https://api.github.com/users/beekpr/events{/privacy}","received_events_url":"https://api.github.com/users/beekpr/received_events","type":"Organization","site_admin":false},"repo":{"id":69541165,"name":"wsgiservice-restplus","full_name":"beekpr/wsgiservice-restplus","owner":{"login":"beekpr","id":9117555,"avatar_url":"https://avatars1.githubusercontent.com/u/9117555?v=3","gravatar_id":"","url":"https://api.github.com/users/beekpr","html_url":"https://github.com/beekpr","followers_url":"https://api.github.com/users/beekpr/followers","following_url":"https://api.github.com/users/beekpr/following{/other_user}","gists_url":"https://api.github.com/users/beekpr/gists{/gist_id}","starred_url":"https://api.github.com/users/beekpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beekpr/subscriptions","organizations_url":"https://api.github.com/users/beekpr/orgs","repos_url":"https://api.github.com/users/beekpr/repos","events_url":"https://api.github.com/users/beekpr/events{/privacy}","received_events_url":"https://api.github.com/users/beekpr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/beekpr/wsgiservice-restplus","description":null,"fork":false,"url":"https://api.github.com/repos/beekpr/wsgiservice-restplus","forks_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/forks","keys_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/teams","hooks_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/hooks","issue_events_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/issues/events{/number}","events_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/events","assignees_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/assignees{/user}","branches_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/branches{/branch}","tags_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/tags","blobs_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/git/refs{/sha}","trees_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/statuses/{sha}","languages_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/languages","stargazers_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/stargazers","contributors_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/contributors","subscribers_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/subscribers","subscription_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/subscription","commits_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/commits{/sha}","git_commits_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/git/commits{/sha}","comments_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/comments{/number}","issue_comment_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/issues/comments{/number}","contents_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/contents/{+path}","compare_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/merges","archive_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/downloads","issues_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/issues{/number}","pulls_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls{/number}","milestones_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/milestones{/number}","notifications_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/labels{/name}","releases_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/releases{/id}","deployments_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/deployments","created_at":"2016-09-29T07:14:52Z","updated_at":"2016-12-07T16:08:23Z","pushed_at":"2017-03-02T15:35:52Z","git_url":"git://github.com/beekpr/wsgiservice-restplus.git","ssh_url":"git@github.com:beekpr/wsgiservice-restplus.git","clone_url":"https://github.com/beekpr/wsgiservice-restplus.git","svn_url":"https://github.com/beekpr/wsgiservice-restplus","homepage":null,"size":974,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"beekpr:master","ref":"master","sha":"4a4aa67d23b5872ddd8ddb9bffaeca596c52f491","user":{"login":"beekpr","id":9117555,"avatar_url":"https://avatars1.githubusercontent.com/u/9117555?v=3","gravatar_id":"","url":"https://api.github.com/users/beekpr","html_url":"https://github.com/beekpr","followers_url":"https://api.github.com/users/beekpr/followers","following_url":"https://api.github.com/users/beekpr/following{/other_user}","gists_url":"https://api.github.com/users/beekpr/gists{/gist_id}","starred_url":"https://api.github.com/users/beekpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beekpr/subscriptions","organizations_url":"https://api.github.com/users/beekpr/orgs","repos_url":"https://api.github.com/users/beekpr/repos","events_url":"https://api.github.com/users/beekpr/events{/privacy}","received_events_url":"https://api.github.com/users/beekpr/received_events","type":"Organization","site_admin":false},"repo":{"id":69541165,"name":"wsgiservice-restplus","full_name":"beekpr/wsgiservice-restplus","owner":{"login":"beekpr","id":9117555,"avatar_url":"https://avatars1.githubusercontent.com/u/9117555?v=3","gravatar_id":"","url":"https://api.github.com/users/beekpr","html_url":"https://github.com/beekpr","followers_url":"https://api.github.com/users/beekpr/followers","following_url":"https://api.github.com/users/beekpr/following{/other_user}","gists_url":"https://api.github.com/users/beekpr/gists{/gist_id}","starred_url":"https://api.github.com/users/beekpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beekpr/subscriptions","organizations_url":"https://api.github.com/users/beekpr/orgs","repos_url":"https://api.github.com/users/beekpr/repos","events_url":"https://api.github.com/users/beekpr/events{/privacy}","received_events_url":"https://api.github.com/users/beekpr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/beekpr/wsgiservice-restplus","description":null,"fork":false,"url":"https://api.github.com/repos/beekpr/wsgiservice-restplus","forks_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/forks","keys_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/teams","hooks_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/hooks","issue_events_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/issues/events{/number}","events_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/events","assignees_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/assignees{/user}","branches_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/branches{/branch}","tags_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/tags","blobs_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/git/refs{/sha}","trees_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/statuses/{sha}","languages_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/languages","stargazers_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/stargazers","contributors_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/contributors","subscribers_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/subscribers","subscription_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/subscription","commits_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/commits{/sha}","git_commits_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/git/commits{/sha}","comments_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/comments{/number}","issue_comment_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/issues/comments{/number}","contents_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/contents/{+path}","compare_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/merges","archive_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/downloads","issues_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/issues{/number}","pulls_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls{/number}","milestones_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/milestones{/number}","notifications_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/labels{/name}","releases_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/releases{/id}","deployments_url":"https://api.github.com/repos/beekpr/wsgiservice-restplus/deployments","created_at":"2016-09-29T07:14:52Z","updated_at":"2016-12-07T16:08:23Z","pushed_at":"2017-03-02T15:35:52Z","git_url":"git://github.com/beekpr/wsgiservice-restplus.git","ssh_url":"git@github.com:beekpr/wsgiservice-restplus.git","clone_url":"https://github.com/beekpr/wsgiservice-restplus.git","svn_url":"https://github.com/beekpr/wsgiservice-restplus","homepage":null,"size":974,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls/9"},"html":{"href":"https://github.com/beekpr/wsgiservice-restplus/pull/9"},"issue":{"href":"https://api.github.com/repos/beekpr/wsgiservice-restplus/issues/9"},"comments":{"href":"https://api.github.com/repos/beekpr/wsgiservice-restplus/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/beekpr/wsgiservice-restplus/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/beekpr/wsgiservice-restplus/statuses/131acddf006f51d3961a4ac71f137be327f58ef0"}}}}
{"actor":{"display_login":"Wattos"}}