{"action":"created","issue":{"url":"https://api.github.com/repos/vlio20/angular-datepicker/issues/109","repository_url":"https://api.github.com/repos/vlio20/angular-datepicker","labels_url":"https://api.github.com/repos/vlio20/angular-datepicker/issues/109/labels{/name}","comments_url":"https://api.github.com/repos/vlio20/angular-datepicker/issues/109/comments","events_url":"https://api.github.com/repos/vlio20/angular-datepicker/issues/109/events","html_url":"https://github.com/vlio20/angular-datepicker/pull/109","id":238237438,"number":109,"title":"feat(timeselect): Add inline dp-time-select","user":{"login":"isaacplmann","id":861504,"avatar_url":"https://avatars3.githubusercontent.com/u/861504?v=3","gravatar_id":"","url":"https://api.github.com/users/isaacplmann","html_url":"https://github.com/isaacplmann","followers_url":"https://api.github.com/users/isaacplmann/followers","following_url":"https://api.github.com/users/isaacplmann/following{/other_user}","gists_url":"https://api.github.com/users/isaacplmann/gists{/gist_id}","starred_url":"https://api.github.com/users/isaacplmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isaacplmann/subscriptions","organizations_url":"https://api.github.com/users/isaacplmann/orgs","repos_url":"https://api.github.com/users/isaacplmann/repos","events_url":"https://api.github.com/users/isaacplmann/events{/privacy}","received_events_url":"https://api.github.com/users/isaacplmann/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-06-23T19:49:49Z","updated_at":"2017-06-26T17:31:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vlio20/angular-datepicker/pulls/109","html_url":"https://github.com/vlio20/angular-datepicker/pull/109","diff_url":"https://github.com/vlio20/angular-datepicker/pull/109.diff","patch_url":"https://github.com/vlio20/angular-datepicker/pull/109.patch"},"body":"I've added an inline `<dp-time-select>` component.  Here's the config object:\r\n\r\n```ts\r\nexport interface ITimeSelectConfig extends ICalendar {\r\n  hours12Format?: string; // 'hh'\r\n  hours24Format?: string; // 'HH'\r\n  meridiemFormat?: string; // 'A'\r\n  minutesFormat?: string; // 'mm'\r\n  minutesInterval?: number; // 1\r\n  secondsFormat?: string; // 'ss'\r\n  secondsInterval?: number; // 1\r\n  showSeconds?: boolean; // false\r\n  showTwentyFourHours?: boolean; // false\r\n  timeSeparator?: string; // ':'\r\n}\r\n```\r\n\r\nNext step is to add values to the ECalendarType enum: `Time` and `DayTime` (or `DateTime`) and then add the appropriate integrations in the `<dp-day-picker>`.  I'll work on `Time` first, since it is the simpler one.\r\n\r\nDiscussion points:\r\n1. I can foresee some ambiguity with the `min` and `max` values in the config object.  For a `Time` calendar type, the `min` and `max` should probably have the day portion of the datetime ignored and only compare the time portion with the value in the `<dp-time-select>`.  However, for a `DayTime` calendar type, the day portion needs to be included in the calculation.  I think it is clear enough from the context what `min` and `max` should mean, but, if you want, I can add `minTime` and `maxTime` properties to the `ITimeSelectConfig`.\r\n\r\n2. It would probably be useful to update the demo code to hide irrelevant config options based on the currently selected mode.  I was thinking of creating some kind of look up table to hide/show config options as the mode changes.  I'd be happy to work on that if you think it's a good idea."},"comment":{"url":"https://api.github.com/repos/vlio20/angular-datepicker/issues/comments/311126047","html_url":"https://github.com/vlio20/angular-datepicker/pull/109#issuecomment-311126047","issue_url":"https://api.github.com/repos/vlio20/angular-datepicker/issues/109","id":311126047,"user":{"login":"vlio20","id":4542641,"avatar_url":"https://avatars3.githubusercontent.com/u/4542641?v=3","gravatar_id":"","url":"https://api.github.com/users/vlio20","html_url":"https://github.com/vlio20","followers_url":"https://api.github.com/users/vlio20/followers","following_url":"https://api.github.com/users/vlio20/following{/other_user}","gists_url":"https://api.github.com/users/vlio20/gists{/gist_id}","starred_url":"https://api.github.com/users/vlio20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlio20/subscriptions","organizations_url":"https://api.github.com/users/vlio20/orgs","repos_url":"https://api.github.com/users/vlio20/repos","events_url":"https://api.github.com/users/vlio20/events{/privacy}","received_events_url":"https://api.github.com/users/vlio20/received_events","type":"User","site_admin":false},"created_at":"2017-06-26T17:25:02Z","updated_at":"2017-06-26T17:25:02Z","body":"will check"}}
{"actor":{"display_login":"vlio20"}}