{"action":"closed","number":1898,"pull_request":{"url":"https://api.github.com/repos/cinder/Cinder/pulls/1898","id":141955274,"html_url":"https://github.com/cinder/Cinder/pull/1898","diff_url":"https://github.com/cinder/Cinder/pull/1898.diff","patch_url":"https://github.com/cinder/Cinder/pull/1898.patch","issue_url":"https://api.github.com/repos/cinder/Cinder/issues/1898","number":1898,"state":"closed","locked":false,"title":"fix seek with samplerate conversion","user":{"login":"richardeakin","id":5132127,"avatar_url":"https://avatars0.githubusercontent.com/u/5132127?v=4","gravatar_id":"","url":"https://api.github.com/users/richardeakin","html_url":"https://github.com/richardeakin","followers_url":"https://api.github.com/users/richardeakin/followers","following_url":"https://api.github.com/users/richardeakin/following{/other_user}","gists_url":"https://api.github.com/users/richardeakin/gists{/gist_id}","starred_url":"https://api.github.com/users/richardeakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardeakin/subscriptions","organizations_url":"https://api.github.com/users/richardeakin/orgs","repos_url":"https://api.github.com/users/richardeakin/repos","events_url":"https://api.github.com/users/richardeakin/events{/privacy}","received_events_url":"https://api.github.com/users/richardeakin/received_events","type":"User","site_admin":false},"body":"read pos was being rounded to zero. Use case was when the `audio::Context` samplerate was 48000, and file being read / seeked was 44100.","created_at":"2017-09-19T20:58:29Z","updated_at":"2017-09-21T19:57:26Z","closed_at":"2017-09-21T19:57:26Z","merged_at":"2017-09-21T19:57:26Z","merge_commit_sha":"3e57959ef73f10d0fd86b6496bdb00c3b6d0c18a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cinder/Cinder/pulls/1898/commits","review_comments_url":"https://api.github.com/repos/cinder/Cinder/pulls/1898/comments","review_comment_url":"https://api.github.com/repos/cinder/Cinder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cinder/Cinder/issues/1898/comments","statuses_url":"https://api.github.com/repos/cinder/Cinder/statuses/6b80a0c4356a0e8694c105da9b5aa3466cd18c99","head":{"label":"richardeakin:audio_fix_seek_conversion","ref":"audio_fix_seek_conversion","sha":"6b80a0c4356a0e8694c105da9b5aa3466cd18c99","user":{"login":"richardeakin","id":5132127,"avatar_url":"https://avatars0.githubusercontent.com/u/5132127?v=4","gravatar_id":"","url":"https://api.github.com/users/richardeakin","html_url":"https://github.com/richardeakin","followers_url":"https://api.github.com/users/richardeakin/followers","following_url":"https://api.github.com/users/richardeakin/following{/other_user}","gists_url":"https://api.github.com/users/richardeakin/gists{/gist_id}","starred_url":"https://api.github.com/users/richardeakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardeakin/subscriptions","organizations_url":"https://api.github.com/users/richardeakin/orgs","repos_url":"https://api.github.com/users/richardeakin/repos","events_url":"https://api.github.com/users/richardeakin/events{/privacy}","received_events_url":"https://api.github.com/users/richardeakin/received_events","type":"User","site_admin":false},"repo":{"id":23873373,"name":"Cinder","full_name":"richardeakin/Cinder","owner":{"login":"richardeakin","id":5132127,"avatar_url":"https://avatars0.githubusercontent.com/u/5132127?v=4","gravatar_id":"","url":"https://api.github.com/users/richardeakin","html_url":"https://github.com/richardeakin","followers_url":"https://api.github.com/users/richardeakin/followers","following_url":"https://api.github.com/users/richardeakin/following{/other_user}","gists_url":"https://api.github.com/users/richardeakin/gists{/gist_id}","starred_url":"https://api.github.com/users/richardeakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardeakin/subscriptions","organizations_url":"https://api.github.com/users/richardeakin/orgs","repos_url":"https://api.github.com/users/richardeakin/repos","events_url":"https://api.github.com/users/richardeakin/events{/privacy}","received_events_url":"https://api.github.com/users/richardeakin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richardeakin/Cinder","description":"personal dev fork of cinder","fork":true,"url":"https://api.github.com/repos/richardeakin/Cinder","forks_url":"https://api.github.com/repos/richardeakin/Cinder/forks","keys_url":"https://api.github.com/repos/richardeakin/Cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardeakin/Cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardeakin/Cinder/teams","hooks_url":"https://api.github.com/repos/richardeakin/Cinder/hooks","issue_events_url":"https://api.github.com/repos/richardeakin/Cinder/issues/events{/number}","events_url":"https://api.github.com/repos/richardeakin/Cinder/events","assignees_url":"https://api.github.com/repos/richardeakin/Cinder/assignees{/user}","branches_url":"https://api.github.com/repos/richardeakin/Cinder/branches{/branch}","tags_url":"https://api.github.com/repos/richardeakin/Cinder/tags","blobs_url":"https://api.github.com/repos/richardeakin/Cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardeakin/Cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardeakin/Cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardeakin/Cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardeakin/Cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/richardeakin/Cinder/languages","stargazers_url":"https://api.github.com/repos/richardeakin/Cinder/stargazers","contributors_url":"https://api.github.com/repos/richardeakin/Cinder/contributors","subscribers_url":"https://api.github.com/repos/richardeakin/Cinder/subscribers","subscription_url":"https://api.github.com/repos/richardeakin/Cinder/subscription","commits_url":"https://api.github.com/repos/richardeakin/Cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardeakin/Cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardeakin/Cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardeakin/Cinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardeakin/Cinder/contents/{+path}","compare_url":"https://api.github.com/repos/richardeakin/Cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardeakin/Cinder/merges","archive_url":"https://api.github.com/repos/richardeakin/Cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardeakin/Cinder/downloads","issues_url":"https://api.github.com/repos/richardeakin/Cinder/issues{/number}","pulls_url":"https://api.github.com/repos/richardeakin/Cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/richardeakin/Cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/richardeakin/Cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardeakin/Cinder/labels{/name}","releases_url":"https://api.github.com/repos/richardeakin/Cinder/releases{/id}","deployments_url":"https://api.github.com/repos/richardeakin/Cinder/deployments","created_at":"2014-09-10T12:21:24Z","updated_at":"2017-03-06T16:01:51Z","pushed_at":"2017-09-21T19:56:45Z","git_url":"git://github.com/richardeakin/Cinder.git","ssh_url":"git@github.com:richardeakin/Cinder.git","clone_url":"https://github.com/richardeakin/Cinder.git","svn_url":"https://github.com/richardeakin/Cinder","homepage":"http://libcinder.org","size":370766,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"cinder:master","ref":"master","sha":"ff4781385028d40510d89ca2e4e824b51bb3fb7a","user":{"login":"cinder","id":154586,"avatar_url":"https://avatars2.githubusercontent.com/u/154586?v=4","gravatar_id":"","url":"https://api.github.com/users/cinder","html_url":"https://github.com/cinder","followers_url":"https://api.github.com/users/cinder/followers","following_url":"https://api.github.com/users/cinder/following{/other_user}","gists_url":"https://api.github.com/users/cinder/gists{/gist_id}","starred_url":"https://api.github.com/users/cinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinder/subscriptions","organizations_url":"https://api.github.com/users/cinder/orgs","repos_url":"https://api.github.com/users/cinder/repos","events_url":"https://api.github.com/users/cinder/events{/privacy}","received_events_url":"https://api.github.com/users/cinder/received_events","type":"User","site_admin":false},"repo":{"id":622127,"name":"Cinder","full_name":"cinder/Cinder","owner":{"login":"cinder","id":154586,"avatar_url":"https://avatars2.githubusercontent.com/u/154586?v=4","gravatar_id":"","url":"https://api.github.com/users/cinder","html_url":"https://github.com/cinder","followers_url":"https://api.github.com/users/cinder/followers","following_url":"https://api.github.com/users/cinder/following{/other_user}","gists_url":"https://api.github.com/users/cinder/gists{/gist_id}","starred_url":"https://api.github.com/users/cinder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cinder/subscriptions","organizations_url":"https://api.github.com/users/cinder/orgs","repos_url":"https://api.github.com/users/cinder/repos","events_url":"https://api.github.com/users/cinder/events{/privacy}","received_events_url":"https://api.github.com/users/cinder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cinder/Cinder","description":"Cinder is a community-developed, free and open source library for professional-quality creative coding in C++.","fork":false,"url":"https://api.github.com/repos/cinder/Cinder","forks_url":"https://api.github.com/repos/cinder/Cinder/forks","keys_url":"https://api.github.com/repos/cinder/Cinder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cinder/Cinder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cinder/Cinder/teams","hooks_url":"https://api.github.com/repos/cinder/Cinder/hooks","issue_events_url":"https://api.github.com/repos/cinder/Cinder/issues/events{/number}","events_url":"https://api.github.com/repos/cinder/Cinder/events","assignees_url":"https://api.github.com/repos/cinder/Cinder/assignees{/user}","branches_url":"https://api.github.com/repos/cinder/Cinder/branches{/branch}","tags_url":"https://api.github.com/repos/cinder/Cinder/tags","blobs_url":"https://api.github.com/repos/cinder/Cinder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cinder/Cinder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cinder/Cinder/git/refs{/sha}","trees_url":"https://api.github.com/repos/cinder/Cinder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cinder/Cinder/statuses/{sha}","languages_url":"https://api.github.com/repos/cinder/Cinder/languages","stargazers_url":"https://api.github.com/repos/cinder/Cinder/stargazers","contributors_url":"https://api.github.com/repos/cinder/Cinder/contributors","subscribers_url":"https://api.github.com/repos/cinder/Cinder/subscribers","subscription_url":"https://api.github.com/repos/cinder/Cinder/subscription","commits_url":"https://api.github.com/repos/cinder/Cinder/commits{/sha}","git_commits_url":"https://api.github.com/repos/cinder/Cinder/git/commits{/sha}","comments_url":"https://api.github.com/repos/cinder/Cinder/comments{/number}","issue_comment_url":"https://api.github.com/repos/cinder/Cinder/issues/comments{/number}","contents_url":"https://api.github.com/repos/cinder/Cinder/contents/{+path}","compare_url":"https://api.github.com/repos/cinder/Cinder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cinder/Cinder/merges","archive_url":"https://api.github.com/repos/cinder/Cinder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cinder/Cinder/downloads","issues_url":"https://api.github.com/repos/cinder/Cinder/issues{/number}","pulls_url":"https://api.github.com/repos/cinder/Cinder/pulls{/number}","milestones_url":"https://api.github.com/repos/cinder/Cinder/milestones{/number}","notifications_url":"https://api.github.com/repos/cinder/Cinder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cinder/Cinder/labels{/name}","releases_url":"https://api.github.com/repos/cinder/Cinder/releases{/id}","deployments_url":"https://api.github.com/repos/cinder/Cinder/deployments","created_at":"2010-04-21T19:03:10Z","updated_at":"2017-09-21T19:34:40Z","pushed_at":"2017-09-21T19:57:26Z","git_url":"git://github.com/cinder/Cinder.git","ssh_url":"git@github.com:cinder/Cinder.git","clone_url":"https://github.com/cinder/Cinder.git","svn_url":"https://github.com/cinder/Cinder","homepage":"http://libcinder.org","size":415395,"stargazers_count":3231,"watchers_count":3231,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":741,"mirror_url":null,"open_issues_count":250,"forks":741,"open_issues":250,"watchers":3231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1898"},"html":{"href":"https://github.com/cinder/Cinder/pull/1898"},"issue":{"href":"https://api.github.com/repos/cinder/Cinder/issues/1898"},"comments":{"href":"https://api.github.com/repos/cinder/Cinder/issues/1898/comments"},"review_comments":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1898/comments"},"review_comment":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cinder/Cinder/pulls/1898/commits"},"statuses":{"href":"https://api.github.com/repos/cinder/Cinder/statuses/6b80a0c4356a0e8694c105da9b5aa3466cd18c99"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"richardeakin","id":5132127,"avatar_url":"https://avatars0.githubusercontent.com/u/5132127?v=4","gravatar_id":"","url":"https://api.github.com/users/richardeakin","html_url":"https://github.com/richardeakin","followers_url":"https://api.github.com/users/richardeakin/followers","following_url":"https://api.github.com/users/richardeakin/following{/other_user}","gists_url":"https://api.github.com/users/richardeakin/gists{/gist_id}","starred_url":"https://api.github.com/users/richardeakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardeakin/subscriptions","organizations_url":"https://api.github.com/users/richardeakin/orgs","repos_url":"https://api.github.com/users/richardeakin/repos","events_url":"https://api.github.com/users/richardeakin/events{/privacy}","received_events_url":"https://api.github.com/users/richardeakin/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":8,"deletions":5,"changed_files":1}}
{"actor":{"display_login":"richardeakin"}}