{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments/121932472","pull_request_review_id":44000997,"id":121932472,"diff_hunk":"@@ -20,12 +20,21 @@ config.mk:\n \texit 1\n \n setup.bin: setup.ml\n-\t@ocamlopt.opt -o $@ $< || ocamlopt -o $@ $< || ocamlc -o $@ $<\n-\t@rm -f setup.cmx setup.cmi setup.o setup.cmo\n+\t@ocamlfind ocamlopt -o $@ -linkpkg -package oasis.dynrun setup.ml || ocamlfind ocamlc -o $@ -linkpkg -package oasis.dynrun setup.ml || true\n+\t@rm -f setup.cmi setup.cmo setup.cmx setup.o\n \n setup.data: setup.bin\n \t@./setup.bin -configure $(ENABLE_TESTS) $(ENABLE_XEN) $(ENABLE_XENLIGHT) $(ENABLE_XENGUESTBIN) $(ENABLE_XENTOOLLOG)\n \n+setup.ml: _oasis.in\n+ifeq ($(BISECT_COVERAGE),YES)\n+\trm -f _oasis\n+\tsed -e 's/BuildDepends:/BuildDepends: bisect_ppx,/' _oasis.in >_oasis\n+else\n+\tln -sf _oasis.in _oasis\n+endif\n+\toasis setup -setup-update dynamic","path":"Makefile","position":28,"original_position":28,"commit_id":"7298fc4c4e67f86cbead438ac7e81bf03920309a","original_commit_id":"ce4c893113b1f32c79d059577951fc9961d2ebb1","user":{"login":"edwintorok","id":721894,"avatar_url":"https://avatars2.githubusercontent.com/u/721894?v=3","gravatar_id":"","url":"https://api.github.com/users/edwintorok","html_url":"https://github.com/edwintorok","followers_url":"https://api.github.com/users/edwintorok/followers","following_url":"https://api.github.com/users/edwintorok/following{/other_user}","gists_url":"https://api.github.com/users/edwintorok/gists{/gist_id}","starred_url":"https://api.github.com/users/edwintorok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwintorok/subscriptions","organizations_url":"https://api.github.com/users/edwintorok/orgs","repos_url":"https://api.github.com/users/edwintorok/repos","events_url":"https://api.github.com/users/edwintorok/events{/privacy}","received_events_url":"https://api.github.com/users/edwintorok/received_events","type":"User","site_admin":false},"body":"Thanks, I've pushed a fixup that does that.","created_at":"2017-06-14T12:32:30Z","updated_at":"2017-06-14T12:32:30Z","html_url":"https://github.com/xapi-project/xenopsd/pull/345#discussion_r121932472","pull_request_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/345","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments/121932472"},"html":{"href":"https://github.com/xapi-project/xenopsd/pull/345#discussion_r121932472"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/345"}}},"pull_request":{"url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/345","id":125412317,"html_url":"https://github.com/xapi-project/xenopsd/pull/345","diff_url":"https://github.com/xapi-project/xenopsd/pull/345.diff","patch_url":"https://github.com/xapi-project/xenopsd/pull/345.patch","issue_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/345","number":345,"state":"open","locked":false,"title":"Configure time coverage builds","user":{"login":"edwintorok","id":721894,"avatar_url":"https://avatars2.githubusercontent.com/u/721894?v=3","gravatar_id":"","url":"https://api.github.com/users/edwintorok","html_url":"https://github.com/edwintorok","followers_url":"https://api.github.com/users/edwintorok/followers","following_url":"https://api.github.com/users/edwintorok/following{/other_user}","gists_url":"https://api.github.com/users/edwintorok/gists{/gist_id}","starred_url":"https://api.github.com/users/edwintorok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwintorok/subscriptions","organizations_url":"https://api.github.com/users/edwintorok/orgs","repos_url":"https://api.github.com/users/edwintorok/repos","events_url":"https://api.github.com/users/edwintorok/events{/privacy}","received_events_url":"https://api.github.com/users/edwintorok/received_events","type":"User","site_admin":false},"body":"Do a coverage build similarly to the XAPI PR: https://github.com/xapi-project/xen-api/pull/3067.\r\n\r\nThis doesn't depened on a new version of bisect_ppx, it just simplifies the build system a bit and makes it more like the XAPI one.","created_at":"2017-06-13T16:54:33Z","updated_at":"2017-06-14T12:32:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a6111cbfefed43851ca05efda69fdad061f96e29","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/345/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/345/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/345/comments","statuses_url":"https://api.github.com/repos/xapi-project/xenopsd/statuses/7298fc4c4e67f86cbead438ac7e81bf03920309a","head":{"label":"edwintorok:coverage","ref":"coverage","sha":"7298fc4c4e67f86cbead438ac7e81bf03920309a","user":{"login":"edwintorok","id":721894,"avatar_url":"https://avatars2.githubusercontent.com/u/721894?v=3","gravatar_id":"","url":"https://api.github.com/users/edwintorok","html_url":"https://github.com/edwintorok","followers_url":"https://api.github.com/users/edwintorok/followers","following_url":"https://api.github.com/users/edwintorok/following{/other_user}","gists_url":"https://api.github.com/users/edwintorok/gists{/gist_id}","starred_url":"https://api.github.com/users/edwintorok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwintorok/subscriptions","organizations_url":"https://api.github.com/users/edwintorok/orgs","repos_url":"https://api.github.com/users/edwintorok/repos","events_url":"https://api.github.com/users/edwintorok/events{/privacy}","received_events_url":"https://api.github.com/users/edwintorok/received_events","type":"User","site_admin":false},"repo":{"id":88852402,"name":"xenopsd","full_name":"edwintorok/xenopsd","owner":{"login":"edwintorok","id":721894,"avatar_url":"https://avatars2.githubusercontent.com/u/721894?v=3","gravatar_id":"","url":"https://api.github.com/users/edwintorok","html_url":"https://github.com/edwintorok","followers_url":"https://api.github.com/users/edwintorok/followers","following_url":"https://api.github.com/users/edwintorok/following{/other_user}","gists_url":"https://api.github.com/users/edwintorok/gists{/gist_id}","starred_url":"https://api.github.com/users/edwintorok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edwintorok/subscriptions","organizations_url":"https://api.github.com/users/edwintorok/orgs","repos_url":"https://api.github.com/users/edwintorok/repos","events_url":"https://api.github.com/users/edwintorok/events{/privacy}","received_events_url":"https://api.github.com/users/edwintorok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edwintorok/xenopsd","description":"XCP toolstack domain manager","fork":true,"url":"https://api.github.com/repos/edwintorok/xenopsd","forks_url":"https://api.github.com/repos/edwintorok/xenopsd/forks","keys_url":"https://api.github.com/repos/edwintorok/xenopsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edwintorok/xenopsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edwintorok/xenopsd/teams","hooks_url":"https://api.github.com/repos/edwintorok/xenopsd/hooks","issue_events_url":"https://api.github.com/repos/edwintorok/xenopsd/issues/events{/number}","events_url":"https://api.github.com/repos/edwintorok/xenopsd/events","assignees_url":"https://api.github.com/repos/edwintorok/xenopsd/assignees{/user}","branches_url":"https://api.github.com/repos/edwintorok/xenopsd/branches{/branch}","tags_url":"https://api.github.com/repos/edwintorok/xenopsd/tags","blobs_url":"https://api.github.com/repos/edwintorok/xenopsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edwintorok/xenopsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edwintorok/xenopsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/edwintorok/xenopsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edwintorok/xenopsd/statuses/{sha}","languages_url":"https://api.github.com/repos/edwintorok/xenopsd/languages","stargazers_url":"https://api.github.com/repos/edwintorok/xenopsd/stargazers","contributors_url":"https://api.github.com/repos/edwintorok/xenopsd/contributors","subscribers_url":"https://api.github.com/repos/edwintorok/xenopsd/subscribers","subscription_url":"https://api.github.com/repos/edwintorok/xenopsd/subscription","commits_url":"https://api.github.com/repos/edwintorok/xenopsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/edwintorok/xenopsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/edwintorok/xenopsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/edwintorok/xenopsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/edwintorok/xenopsd/contents/{+path}","compare_url":"https://api.github.com/repos/edwintorok/xenopsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edwintorok/xenopsd/merges","archive_url":"https://api.github.com/repos/edwintorok/xenopsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edwintorok/xenopsd/downloads","issues_url":"https://api.github.com/repos/edwintorok/xenopsd/issues{/number}","pulls_url":"https://api.github.com/repos/edwintorok/xenopsd/pulls{/number}","milestones_url":"https://api.github.com/repos/edwintorok/xenopsd/milestones{/number}","notifications_url":"https://api.github.com/repos/edwintorok/xenopsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edwintorok/xenopsd/labels{/name}","releases_url":"https://api.github.com/repos/edwintorok/xenopsd/releases{/id}","deployments_url":"https://api.github.com/repos/edwintorok/xenopsd/deployments","created_at":"2017-04-20T10:18:25Z","updated_at":"2017-04-20T10:18:27Z","pushed_at":"2017-06-14T12:31:36Z","git_url":"git://github.com/edwintorok/xenopsd.git","ssh_url":"git@github.com:edwintorok/xenopsd.git","clone_url":"https://github.com/edwintorok/xenopsd.git","svn_url":"https://github.com/edwintorok/xenopsd","homepage":null,"size":31921,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:master","ref":"master","sha":"bdefc267944cf1bcac97db84eb28b08d3d1873c2","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars0.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":7563740,"name":"xenopsd","full_name":"xapi-project/xenopsd","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars0.githubusercontent.com/u/317268?v=3","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xenopsd","description":"XCP toolstack domain manager","fork":false,"url":"https://api.github.com/repos/xapi-project/xenopsd","forks_url":"https://api.github.com/repos/xapi-project/xenopsd/forks","keys_url":"https://api.github.com/repos/xapi-project/xenopsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xenopsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xenopsd/teams","hooks_url":"https://api.github.com/repos/xapi-project/xenopsd/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xenopsd/events","assignees_url":"https://api.github.com/repos/xapi-project/xenopsd/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xenopsd/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xenopsd/tags","blobs_url":"https://api.github.com/repos/xapi-project/xenopsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xenopsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xenopsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xenopsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xenopsd/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xenopsd/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xenopsd/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xenopsd/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xenopsd/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xenopsd/subscription","commits_url":"https://api.github.com/repos/xapi-project/xenopsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xenopsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xenopsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xenopsd/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xenopsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xenopsd/merges","archive_url":"https://api.github.com/repos/xapi-project/xenopsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xenopsd/downloads","issues_url":"https://api.github.com/repos/xapi-project/xenopsd/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xenopsd/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xenopsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xenopsd/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xenopsd/releases{/id}","deployments_url":"https://api.github.com/repos/xapi-project/xenopsd/deployments","created_at":"2013-01-11T17:19:31Z","updated_at":"2016-11-07T11:29:04Z","pushed_at":"2017-06-14T12:31:38Z","git_url":"git://github.com/xapi-project/xenopsd.git","ssh_url":"git@github.com:xapi-project/xenopsd.git","clone_url":"https://github.com/xapi-project/xenopsd.git","svn_url":"https://github.com/xapi-project/xenopsd","homepage":null,"size":31864,"stargazers_count":6,"watchers_count":6,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":10,"forks":47,"open_issues":10,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/345"},"html":{"href":"https://github.com/xapi-project/xenopsd/pull/345"},"issue":{"href":"https://api.github.com/repos/xapi-project/xenopsd/issues/345"},"comments":{"href":"https://api.github.com/repos/xapi-project/xenopsd/issues/345/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/345/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/345/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xenopsd/statuses/7298fc4c4e67f86cbead438ac7e81bf03920309a"}}}}
{"actor":{"display_login":"edwintorok"}}