{"action":"created","comment":{"url":"https://api.github.com/repos/gismo/gismo/pulls/comments/156363415","pull_request_review_id":82826964,"id":156363415,"diff_hunk":"@@ -313,7 +318,18 @@ class gsSparseMatrix : public Eigen::SparseMatrix<T,_Options,_Index>\n     }\n \n     void rrefInPlace();\n-        \n+\n+private:\n+    \n+    /*\n+      The inherited setZero() destroys column-nonzeros structure and\n+      can make further computations very slow.  Almost equivalent to\n+      M.setZero() is:\n+      M = gsSparseMatrix(M.rows(), M.cols());\n+\n+      void setZero();","path":"src/gsMatrix/gsSparseMatrix.h","position":41,"original_position":41,"commit_id":"c1696696753ff3ec1ca707421ef8dcf6e7387e37","original_commit_id":"c1696696753ff3ec1ca707421ef8dcf6e7387e37","user":{"login":"filiatra","id":3185717,"avatar_url":"https://avatars3.githubusercontent.com/u/3185717?v=4","gravatar_id":"","url":"https://api.github.com/users/filiatra","html_url":"https://github.com/filiatra","followers_url":"https://api.github.com/users/filiatra/followers","following_url":"https://api.github.com/users/filiatra/following{/other_user}","gists_url":"https://api.github.com/users/filiatra/gists{/gist_id}","starred_url":"https://api.github.com/users/filiatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiatra/subscriptions","organizations_url":"https://api.github.com/users/filiatra/orgs","repos_url":"https://api.github.com/users/filiatra/repos","events_url":"https://api.github.com/users/filiatra/events{/privacy}","received_events_url":"https://api.github.com/users/filiatra/received_events","type":"User","site_admin":false},"body":"This is intended, I don't want to make it private because devel breaks.\r\nHowever we have to increase awareness on this somehow, and maybe later make it private.","created_at":"2017-12-12T13:23:14Z","updated_at":"2017-12-12T13:23:15Z","html_url":"https://github.com/gismo/gismo/pull/64#discussion_r156363415","pull_request_url":"https://api.github.com/repos/gismo/gismo/pulls/64","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/gismo/gismo/pulls/comments/156363415"},"html":{"href":"https://github.com/gismo/gismo/pull/64#discussion_r156363415"},"pull_request":{"href":"https://api.github.com/repos/gismo/gismo/pulls/64"}},"in_reply_to_id":156361784},"pull_request":{"url":"https://api.github.com/repos/gismo/gismo/pulls/64","id":157824486,"html_url":"https://github.com/gismo/gismo/pull/64","diff_url":"https://github.com/gismo/gismo/pull/64.diff","patch_url":"https://github.com/gismo/gismo/pull/64.patch","issue_url":"https://api.github.com/repos/gismo/gismo/issues/64","number":64,"state":"open","locked":false,"title":"add gsSparseMatrix::addTo, and small comment on setZero","user":{"login":"filiatra","id":3185717,"avatar_url":"https://avatars3.githubusercontent.com/u/3185717?v=4","gravatar_id":"","url":"https://api.github.com/users/filiatra","html_url":"https://github.com/filiatra","followers_url":"https://api.github.com/users/filiatra/followers","following_url":"https://api.github.com/users/filiatra/following{/other_user}","gists_url":"https://api.github.com/users/filiatra/gists{/gist_id}","starred_url":"https://api.github.com/users/filiatra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/filiatra/subscriptions","organizations_url":"https://api.github.com/users/filiatra/orgs","repos_url":"https://api.github.com/users/filiatra/repos","events_url":"https://api.github.com/users/filiatra/events{/privacy}","received_events_url":"https://api.github.com/users/filiatra/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-12T13:12:33Z","updated_at":"2017-12-12T13:23:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ca7b6a613ad36b7d3c85e9dff1eeda298957a9c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gismo/gismo/pulls/64/commits","review_comments_url":"https://api.github.com/repos/gismo/gismo/pulls/64/comments","review_comment_url":"https://api.github.com/repos/gismo/gismo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gismo/gismo/issues/64/comments","statuses_url":"https://api.github.com/repos/gismo/gismo/statuses/c1696696753ff3ec1ca707421ef8dcf6e7387e37","head":{"label":"gismo:gsSparseMatrix_addTo","ref":"gsSparseMatrix_addTo","sha":"c1696696753ff3ec1ca707421ef8dcf6e7387e37","user":{"login":"gismo","id":32823466,"avatar_url":"https://avatars2.githubusercontent.com/u/32823466?v=4","gravatar_id":"","url":"https://api.github.com/users/gismo","html_url":"https://github.com/gismo","followers_url":"https://api.github.com/users/gismo/followers","following_url":"https://api.github.com/users/gismo/following{/other_user}","gists_url":"https://api.github.com/users/gismo/gists{/gist_id}","starred_url":"https://api.github.com/users/gismo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gismo/subscriptions","organizations_url":"https://api.github.com/users/gismo/orgs","repos_url":"https://api.github.com/users/gismo/repos","events_url":"https://api.github.com/users/gismo/events{/privacy}","received_events_url":"https://api.github.com/users/gismo/received_events","type":"Organization","site_admin":false},"repo":{"id":35604128,"name":"gismo","full_name":"gismo/gismo","owner":{"login":"gismo","id":32823466,"avatar_url":"https://avatars2.githubusercontent.com/u/32823466?v=4","gravatar_id":"","url":"https://api.github.com/users/gismo","html_url":"https://github.com/gismo","followers_url":"https://api.github.com/users/gismo/followers","following_url":"https://api.github.com/users/gismo/following{/other_user}","gists_url":"https://api.github.com/users/gismo/gists{/gist_id}","starred_url":"https://api.github.com/users/gismo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gismo/subscriptions","organizations_url":"https://api.github.com/users/gismo/orgs","repos_url":"https://api.github.com/users/gismo/repos","events_url":"https://api.github.com/users/gismo/events{/privacy}","received_events_url":"https://api.github.com/users/gismo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gismo/gismo","description":"G+Smo (pronounced gismo or gizmo) is a C++ library for isogeometric analysis (IGA). Geometry plus simulation modules aims at the seamless integration of Computer-aided Design (CAD) and Finite Element Analysis (FEA).","fork":false,"url":"https://api.github.com/repos/gismo/gismo","forks_url":"https://api.github.com/repos/gismo/gismo/forks","keys_url":"https://api.github.com/repos/gismo/gismo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gismo/gismo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gismo/gismo/teams","hooks_url":"https://api.github.com/repos/gismo/gismo/hooks","issue_events_url":"https://api.github.com/repos/gismo/gismo/issues/events{/number}","events_url":"https://api.github.com/repos/gismo/gismo/events","assignees_url":"https://api.github.com/repos/gismo/gismo/assignees{/user}","branches_url":"https://api.github.com/repos/gismo/gismo/branches{/branch}","tags_url":"https://api.github.com/repos/gismo/gismo/tags","blobs_url":"https://api.github.com/repos/gismo/gismo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gismo/gismo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gismo/gismo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gismo/gismo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gismo/gismo/statuses/{sha}","languages_url":"https://api.github.com/repos/gismo/gismo/languages","stargazers_url":"https://api.github.com/repos/gismo/gismo/stargazers","contributors_url":"https://api.github.com/repos/gismo/gismo/contributors","subscribers_url":"https://api.github.com/repos/gismo/gismo/subscribers","subscription_url":"https://api.github.com/repos/gismo/gismo/subscription","commits_url":"https://api.github.com/repos/gismo/gismo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gismo/gismo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gismo/gismo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gismo/gismo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gismo/gismo/contents/{+path}","compare_url":"https://api.github.com/repos/gismo/gismo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gismo/gismo/merges","archive_url":"https://api.github.com/repos/gismo/gismo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gismo/gismo/downloads","issues_url":"https://api.github.com/repos/gismo/gismo/issues{/number}","pulls_url":"https://api.github.com/repos/gismo/gismo/pulls{/number}","milestones_url":"https://api.github.com/repos/gismo/gismo/milestones{/number}","notifications_url":"https://api.github.com/repos/gismo/gismo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gismo/gismo/labels{/name}","releases_url":"https://api.github.com/repos/gismo/gismo/releases{/id}","deployments_url":"https://api.github.com/repos/gismo/gismo/deployments","created_at":"2015-05-14T09:57:52Z","updated_at":"2017-12-11T14:53:23Z","pushed_at":"2017-12-12T13:18:11Z","git_url":"git://github.com/gismo/gismo.git","ssh_url":"git@github.com:gismo/gismo.git","clone_url":"https://github.com/gismo/gismo.git","svn_url":"https://github.com/gismo/gismo","homepage":"http://gs.jku.at/gismo","size":37974,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11,"open_issues":6,"watchers":25,"default_branch":"stable"}},"base":{"label":"gismo:stable","ref":"stable","sha":"19d85e796d58bdb2318655845a4d04f3691fe653","user":{"login":"gismo","id":32823466,"avatar_url":"https://avatars2.githubusercontent.com/u/32823466?v=4","gravatar_id":"","url":"https://api.github.com/users/gismo","html_url":"https://github.com/gismo","followers_url":"https://api.github.com/users/gismo/followers","following_url":"https://api.github.com/users/gismo/following{/other_user}","gists_url":"https://api.github.com/users/gismo/gists{/gist_id}","starred_url":"https://api.github.com/users/gismo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gismo/subscriptions","organizations_url":"https://api.github.com/users/gismo/orgs","repos_url":"https://api.github.com/users/gismo/repos","events_url":"https://api.github.com/users/gismo/events{/privacy}","received_events_url":"https://api.github.com/users/gismo/received_events","type":"Organization","site_admin":false},"repo":{"id":35604128,"name":"gismo","full_name":"gismo/gismo","owner":{"login":"gismo","id":32823466,"avatar_url":"https://avatars2.githubusercontent.com/u/32823466?v=4","gravatar_id":"","url":"https://api.github.com/users/gismo","html_url":"https://github.com/gismo","followers_url":"https://api.github.com/users/gismo/followers","following_url":"https://api.github.com/users/gismo/following{/other_user}","gists_url":"https://api.github.com/users/gismo/gists{/gist_id}","starred_url":"https://api.github.com/users/gismo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gismo/subscriptions","organizations_url":"https://api.github.com/users/gismo/orgs","repos_url":"https://api.github.com/users/gismo/repos","events_url":"https://api.github.com/users/gismo/events{/privacy}","received_events_url":"https://api.github.com/users/gismo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gismo/gismo","description":"G+Smo (pronounced gismo or gizmo) is a C++ library for isogeometric analysis (IGA). Geometry plus simulation modules aims at the seamless integration of Computer-aided Design (CAD) and Finite Element Analysis (FEA).","fork":false,"url":"https://api.github.com/repos/gismo/gismo","forks_url":"https://api.github.com/repos/gismo/gismo/forks","keys_url":"https://api.github.com/repos/gismo/gismo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gismo/gismo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gismo/gismo/teams","hooks_url":"https://api.github.com/repos/gismo/gismo/hooks","issue_events_url":"https://api.github.com/repos/gismo/gismo/issues/events{/number}","events_url":"https://api.github.com/repos/gismo/gismo/events","assignees_url":"https://api.github.com/repos/gismo/gismo/assignees{/user}","branches_url":"https://api.github.com/repos/gismo/gismo/branches{/branch}","tags_url":"https://api.github.com/repos/gismo/gismo/tags","blobs_url":"https://api.github.com/repos/gismo/gismo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gismo/gismo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gismo/gismo/git/refs{/sha}","trees_url":"https://api.github.com/repos/gismo/gismo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gismo/gismo/statuses/{sha}","languages_url":"https://api.github.com/repos/gismo/gismo/languages","stargazers_url":"https://api.github.com/repos/gismo/gismo/stargazers","contributors_url":"https://api.github.com/repos/gismo/gismo/contributors","subscribers_url":"https://api.github.com/repos/gismo/gismo/subscribers","subscription_url":"https://api.github.com/repos/gismo/gismo/subscription","commits_url":"https://api.github.com/repos/gismo/gismo/commits{/sha}","git_commits_url":"https://api.github.com/repos/gismo/gismo/git/commits{/sha}","comments_url":"https://api.github.com/repos/gismo/gismo/comments{/number}","issue_comment_url":"https://api.github.com/repos/gismo/gismo/issues/comments{/number}","contents_url":"https://api.github.com/repos/gismo/gismo/contents/{+path}","compare_url":"https://api.github.com/repos/gismo/gismo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gismo/gismo/merges","archive_url":"https://api.github.com/repos/gismo/gismo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gismo/gismo/downloads","issues_url":"https://api.github.com/repos/gismo/gismo/issues{/number}","pulls_url":"https://api.github.com/repos/gismo/gismo/pulls{/number}","milestones_url":"https://api.github.com/repos/gismo/gismo/milestones{/number}","notifications_url":"https://api.github.com/repos/gismo/gismo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gismo/gismo/labels{/name}","releases_url":"https://api.github.com/repos/gismo/gismo/releases{/id}","deployments_url":"https://api.github.com/repos/gismo/gismo/deployments","created_at":"2015-05-14T09:57:52Z","updated_at":"2017-12-11T14:53:23Z","pushed_at":"2017-12-12T13:18:11Z","git_url":"git://github.com/gismo/gismo.git","ssh_url":"git@github.com:gismo/gismo.git","clone_url":"https://github.com/gismo/gismo.git","svn_url":"https://github.com/gismo/gismo","homepage":"http://gs.jku.at/gismo","size":37974,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":11,"open_issues":6,"watchers":25,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/gismo/gismo/pulls/64"},"html":{"href":"https://github.com/gismo/gismo/pull/64"},"issue":{"href":"https://api.github.com/repos/gismo/gismo/issues/64"},"comments":{"href":"https://api.github.com/repos/gismo/gismo/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/gismo/gismo/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/gismo/gismo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gismo/gismo/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/gismo/gismo/statuses/c1696696753ff3ec1ca707421ef8dcf6e7387e37"}},"author_association":"OWNER"}}
{"actor":{"display_login":"filiatra"}}