{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/comments/110340472","pull_request_review_id":31506452,"id":110340472,"diff_hunk":"@@ -125,6 +127,18 @@ public String getDisplayName() {\n         return r;\n     }\n \n+\n+    @Override\n+    protected void onLoad() {\n+        super.onLoad();\n+        Iterator<MatrixChildParametersAction> i = this.getActions(MatrixChildParametersAction.class).iterator();\n+\n+        while(i.hasNext()) {","path":"src/main/java/hudson/matrix/MatrixRun.java","position":26,"original_position":26,"commit_id":"11761875780b92bb499c5b75ce2dc2293f59101a","original_commit_id":"11761875780b92bb499c5b75ce2dc2293f59101a","user":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars3.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"body":"Why using iterator and not the for each loop?","created_at":"2017-04-07T08:29:23Z","updated_at":"2017-04-07T08:29:44Z","html_url":"https://github.com/jenkinsci/matrix-project-plugin/pull/45#discussion_r110340472","pull_request_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/comments/110340472"},"html":{"href":"https://github.com/jenkinsci/matrix-project-plugin/pull/45#discussion_r110340472"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/45","id":114616546,"html_url":"https://github.com/jenkinsci/matrix-project-plugin/pull/45","diff_url":"https://github.com/jenkinsci/matrix-project-plugin/pull/45.diff","patch_url":"https://github.com/jenkinsci/matrix-project-plugin/pull/45.patch","issue_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/45","number":45,"state":"open","locked":false,"title":"Fix JENKINS-43390.","user":{"login":"lvotypko","id":1032196,"avatar_url":"https://avatars0.githubusercontent.com/u/1032196?v=3","gravatar_id":"","url":"https://api.github.com/users/lvotypko","html_url":"https://github.com/lvotypko","followers_url":"https://api.github.com/users/lvotypko/followers","following_url":"https://api.github.com/users/lvotypko/following{/other_user}","gists_url":"https://api.github.com/users/lvotypko/gists{/gist_id}","starred_url":"https://api.github.com/users/lvotypko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvotypko/subscriptions","organizations_url":"https://api.github.com/users/lvotypko/orgs","repos_url":"https://api.github.com/users/lvotypko/repos","events_url":"https://api.github.com/users/lvotypko/events{/privacy}","received_events_url":"https://api.github.com/users/lvotypko/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-06T14:35:43Z","updated_at":"2017-04-07T08:29:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89f5347ad6b42764440e204a24c3b719edf551b1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/45/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/45/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/45/comments","statuses_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/statuses/11761875780b92bb499c5b75ce2dc2293f59101a","head":{"label":"lvotypko:matrix-configuration-parameters","ref":"matrix-configuration-parameters","sha":"11761875780b92bb499c5b75ce2dc2293f59101a","user":{"login":"lvotypko","id":1032196,"avatar_url":"https://avatars0.githubusercontent.com/u/1032196?v=3","gravatar_id":"","url":"https://api.github.com/users/lvotypko","html_url":"https://github.com/lvotypko","followers_url":"https://api.github.com/users/lvotypko/followers","following_url":"https://api.github.com/users/lvotypko/following{/other_user}","gists_url":"https://api.github.com/users/lvotypko/gists{/gist_id}","starred_url":"https://api.github.com/users/lvotypko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvotypko/subscriptions","organizations_url":"https://api.github.com/users/lvotypko/orgs","repos_url":"https://api.github.com/users/lvotypko/repos","events_url":"https://api.github.com/users/lvotypko/events{/privacy}","received_events_url":"https://api.github.com/users/lvotypko/received_events","type":"User","site_admin":false},"repo":{"id":23962807,"name":"matrix-project-plugin","full_name":"lvotypko/matrix-project-plugin","owner":{"login":"lvotypko","id":1032196,"avatar_url":"https://avatars0.githubusercontent.com/u/1032196?v=3","gravatar_id":"","url":"https://api.github.com/users/lvotypko","html_url":"https://github.com/lvotypko","followers_url":"https://api.github.com/users/lvotypko/followers","following_url":"https://api.github.com/users/lvotypko/following{/other_user}","gists_url":"https://api.github.com/users/lvotypko/gists{/gist_id}","starred_url":"https://api.github.com/users/lvotypko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lvotypko/subscriptions","organizations_url":"https://api.github.com/users/lvotypko/orgs","repos_url":"https://api.github.com/users/lvotypko/repos","events_url":"https://api.github.com/users/lvotypko/events{/privacy}","received_events_url":"https://api.github.com/users/lvotypko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lvotypko/matrix-project-plugin","description":null,"fork":true,"url":"https://api.github.com/repos/lvotypko/matrix-project-plugin","forks_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/forks","keys_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/teams","hooks_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/hooks","issue_events_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/events","assignees_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/tags","blobs_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/languages","stargazers_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/stargazers","contributors_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/contributors","subscribers_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/subscribers","subscription_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/subscription","commits_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/merges","archive_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/downloads","issues_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/labels{/name}","releases_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/lvotypko/matrix-project-plugin/deployments","created_at":"2014-09-12T14:00:10Z","updated_at":"2014-09-12T16:01:34Z","pushed_at":"2017-04-06T14:32:41Z","git_url":"git://github.com/lvotypko/matrix-project-plugin.git","ssh_url":"git@github.com:lvotypko/matrix-project-plugin.git","clone_url":"https://github.com/lvotypko/matrix-project-plugin.git","svn_url":"https://github.com/lvotypko/matrix-project-plugin","homepage":"","size":796,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"2d8aff76fccb1dcdf01c45bb664b5f52df4e1d5a","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars3.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":4489790,"name":"matrix-project-plugin","full_name":"jenkinsci/matrix-project-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars3.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/matrix-project-plugin","description":null,"fork":false,"url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin","forks_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/deployments","created_at":"2012-05-30T01:38:16Z","updated_at":"2017-04-05T14:17:04Z","pushed_at":"2017-04-06T14:35:44Z","git_url":"git://github.com/jenkinsci/matrix-project-plugin.git","ssh_url":"git@github.com:jenkinsci/matrix-project-plugin.git","clone_url":"https://github.com/jenkinsci/matrix-project-plugin.git","svn_url":"https://github.com/jenkinsci/matrix-project-plugin","homepage":"","size":826,"stargazers_count":9,"watchers_count":9,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":8,"forks":48,"open_issues":8,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/45"},"html":{"href":"https://github.com/jenkinsci/matrix-project-plugin/pull/45"},"issue":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/45"},"comments":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/matrix-project-plugin/statuses/11761875780b92bb499c5b75ce2dc2293f59101a"}}}}
{"actor":{"display_login":"olivergondza"}}