{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/159149306","pull_request_review_id":86056066,"id":159149306,"diff_hunk":"@@ -385,6 +386,11 @@ fs.readFile = function(path, options, callback) {\n   if (!nullCheck(path, callback))\n     return;\n \n+  //doing justice between linux and windows for `/` char at the end of file path","path":"lib/fs.js","position":null,"original_position":12,"commit_id":"d43bbb15ce3d5ab7a49c70f25622b4bb110d4717","original_commit_id":"a3e7aab20bbecf08e2f43277c2f6527a4e615817","user":{"login":"Trott","id":718899,"avatar_url":"https://avatars2.githubusercontent.com/u/718899?v=4","gravatar_id":"","url":"https://api.github.com/users/Trott","html_url":"https://github.com/Trott","followers_url":"https://api.github.com/users/Trott/followers","following_url":"https://api.github.com/users/Trott/following{/other_user}","gists_url":"https://api.github.com/users/Trott/gists{/gist_id}","starred_url":"https://api.github.com/users/Trott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Trott/subscriptions","organizations_url":"https://api.github.com/users/Trott/orgs","repos_url":"https://api.github.com/users/Trott/repos","events_url":"https://api.github.com/users/Trott/events{/privacy}","received_events_url":"https://api.github.com/users/Trott/received_events","type":"User","site_admin":false},"body":"I think what @devsnek meant was a space after the comment indicator (`//`) so: `// doing justice...` \r\n\r\nThere are some lint errors you're going to want to correct (mostly around line lengths). These should have been flagged if you ran `make test` or `vcbuild test`. To just run the JS linting (since running the full tests can be time-consuming), you can use `make lint-js` or `vcbuild lint-js`.\r\n\r\nLastly, welcome @timotew and thanks for the pull request!","created_at":"2018-01-01T04:34:21Z","updated_at":"2018-01-01T04:34:21Z","html_url":"https://github.com/nodejs/node/pull/17927#discussion_r159149306","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/17927","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/159149306"},"html":{"href":"https://github.com/nodejs/node/pull/17927#discussion_r159149306"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/17927"}},"in_reply_to_id":159148135},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/17927","id":160632516,"html_url":"https://github.com/nodejs/node/pull/17927","diff_url":"https://github.com/nodejs/node/pull/17927.diff","patch_url":"https://github.com/nodejs/node/pull/17927.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/17927","number":17927,"state":"open","locked":false,"title":" fs: create consistent behavior for fs module across platforms","user":{"login":"timotew","id":12928383,"avatar_url":"https://avatars3.githubusercontent.com/u/12928383?v=4","gravatar_id":"","url":"https://api.github.com/users/timotew","html_url":"https://github.com/timotew","followers_url":"https://api.github.com/users/timotew/followers","following_url":"https://api.github.com/users/timotew/following{/other_user}","gists_url":"https://api.github.com/users/timotew/gists{/gist_id}","starred_url":"https://api.github.com/users/timotew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timotew/subscriptions","organizations_url":"https://api.github.com/users/timotew/orgs","repos_url":"https://api.github.com/users/timotew/repos","events_url":"https://api.github.com/users/timotew/events{/privacy}","received_events_url":"https://api.github.com/users/timotew/received_events","type":"User","site_admin":false},"body":"In Windows, if a file name ends with forward slash `/`, fs interprets it as regular file (like there is no slash at all) and does not throw any errors. In Linux it throws error but not in Windows.\r\n\r\nFixes: https://github.com/nodejs/node/issues/17801\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\nfs","created_at":"2017-12-31T23:08:01Z","updated_at":"2018-01-01T04:34:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c976d617523c93d64492f1ff165ce2fd1527ba3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/17927/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/17927/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/17927/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/d43bbb15ce3d5ab7a49c70f25622b4bb110d4717","head":{"label":"timotew:master","ref":"master","sha":"d43bbb15ce3d5ab7a49c70f25622b4bb110d4717","user":{"login":"timotew","id":12928383,"avatar_url":"https://avatars3.githubusercontent.com/u/12928383?v=4","gravatar_id":"","url":"https://api.github.com/users/timotew","html_url":"https://github.com/timotew","followers_url":"https://api.github.com/users/timotew/followers","following_url":"https://api.github.com/users/timotew/following{/other_user}","gists_url":"https://api.github.com/users/timotew/gists{/gist_id}","starred_url":"https://api.github.com/users/timotew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timotew/subscriptions","organizations_url":"https://api.github.com/users/timotew/orgs","repos_url":"https://api.github.com/users/timotew/repos","events_url":"https://api.github.com/users/timotew/events{/privacy}","received_events_url":"https://api.github.com/users/timotew/received_events","type":"User","site_admin":false},"repo":{"id":115888785,"name":"node","full_name":"timotew/node","owner":{"login":"timotew","id":12928383,"avatar_url":"https://avatars3.githubusercontent.com/u/12928383?v=4","gravatar_id":"","url":"https://api.github.com/users/timotew","html_url":"https://github.com/timotew","followers_url":"https://api.github.com/users/timotew/followers","following_url":"https://api.github.com/users/timotew/following{/other_user}","gists_url":"https://api.github.com/users/timotew/gists{/gist_id}","starred_url":"https://api.github.com/users/timotew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timotew/subscriptions","organizations_url":"https://api.github.com/users/timotew/orgs","repos_url":"https://api.github.com/users/timotew/repos","events_url":"https://api.github.com/users/timotew/events{/privacy}","received_events_url":"https://api.github.com/users/timotew/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timotew/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/timotew/node","forks_url":"https://api.github.com/repos/timotew/node/forks","keys_url":"https://api.github.com/repos/timotew/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timotew/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timotew/node/teams","hooks_url":"https://api.github.com/repos/timotew/node/hooks","issue_events_url":"https://api.github.com/repos/timotew/node/issues/events{/number}","events_url":"https://api.github.com/repos/timotew/node/events","assignees_url":"https://api.github.com/repos/timotew/node/assignees{/user}","branches_url":"https://api.github.com/repos/timotew/node/branches{/branch}","tags_url":"https://api.github.com/repos/timotew/node/tags","blobs_url":"https://api.github.com/repos/timotew/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timotew/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timotew/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/timotew/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timotew/node/statuses/{sha}","languages_url":"https://api.github.com/repos/timotew/node/languages","stargazers_url":"https://api.github.com/repos/timotew/node/stargazers","contributors_url":"https://api.github.com/repos/timotew/node/contributors","subscribers_url":"https://api.github.com/repos/timotew/node/subscribers","subscription_url":"https://api.github.com/repos/timotew/node/subscription","commits_url":"https://api.github.com/repos/timotew/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/timotew/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/timotew/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/timotew/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/timotew/node/contents/{+path}","compare_url":"https://api.github.com/repos/timotew/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timotew/node/merges","archive_url":"https://api.github.com/repos/timotew/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timotew/node/downloads","issues_url":"https://api.github.com/repos/timotew/node/issues{/number}","pulls_url":"https://api.github.com/repos/timotew/node/pulls{/number}","milestones_url":"https://api.github.com/repos/timotew/node/milestones{/number}","notifications_url":"https://api.github.com/repos/timotew/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timotew/node/labels{/name}","releases_url":"https://api.github.com/repos/timotew/node/releases{/id}","deployments_url":"https://api.github.com/repos/timotew/node/deployments","created_at":"2017-12-31T22:46:12Z","updated_at":"2017-12-31T22:46:37Z","pushed_at":"2018-01-01T00:41:45Z","git_url":"git://github.com/timotew/node.git","ssh_url":"git@github.com:timotew/node.git","clone_url":"https://github.com/timotew/node.git","svn_url":"https://github.com/timotew/node","homepage":"https://nodejs.org","size":342794,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"b21e3f0711ca989fe21bd4484b58d03e5693f859","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-01-01T04:21:05Z","pushed_at":"2018-01-01T00:41:47Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":342586,"stargazers_count":43982,"watchers_count":43982,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9203,"mirror_url":null,"archived":false,"open_issues_count":773,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9203,"open_issues":773,"watchers":43982,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/17927"},"html":{"href":"https://github.com/nodejs/node/pull/17927"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/17927"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/17927/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/17927/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/17927/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/d43bbb15ce3d5ab7a49c70f25622b4bb110d4717"}},"author_association":"NONE"}}
{"actor":{"display_login":"Trott"}}