{"action":"created","comment":{"url":"https://api.github.com/repos/darrynten/sage-one-php/pulls/comments/126511231","pull_request_review_id":49001353,"id":126511231,"diff_hunk":"@@ -270,72 +271,17 @@ protected function verifyInject(string $class, callable $whatToCheck)\n     protected function verifyGetAll(string $class, callable $whatToCheck)\n     {\n         $className = $this->getClassName($class);\n-        $data = file_get_contents(__DIR__ . \"/../../mocks/{$className}/GET_{$className}_Get.json\");\n+        $path = sprintf('%s/Get', $className);\n+        $model = $this->setUpRequestMock($class, $path, 'GET',\n+            sprintf('%s/GET_%s_Get.json', $className, $className));","path":"tests/SageOne/Models/BaseModelTest.php","position":15,"original_position":15,"commit_id":"88d19f9609072c0e083f177b470eb9eef678789b","original_commit_id":"88d19f9609072c0e083f177b470eb9eef678789b","user":{"login":"darrynten","id":3657251,"avatar_url":"https://avatars2.githubusercontent.com/u/3657251?v=3","gravatar_id":"","url":"https://api.github.com/users/darrynten","html_url":"https://github.com/darrynten","followers_url":"https://api.github.com/users/darrynten/followers","following_url":"https://api.github.com/users/darrynten/following{/other_user}","gists_url":"https://api.github.com/users/darrynten/gists{/gist_id}","starred_url":"https://api.github.com/users/darrynten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrynten/subscriptions","organizations_url":"https://api.github.com/users/darrynten/orgs","repos_url":"https://api.github.com/users/darrynten/repos","events_url":"https://api.github.com/users/darrynten/events{/privacy}","received_events_url":"https://api.github.com/users/darrynten/received_events","type":"User","site_admin":false},"body":"I think this should be reformatted for readability:\r\n\r\n```php\r\n$model = $this->setUpRequestMock(\r\n    $class,\r\n    $path,\r\n    'GET',\r\n    sprintf(\r\n        '%s/GET_%s_Get.json',\r\n        $className,\r\n        $className\r\n    )\r\n);\r\n```\r\n\r\nand I think the `GET` should be the first parameter as it is more consistent with how you ask or the request (get class at path)","created_at":"2017-07-10T19:13:43Z","updated_at":"2017-07-10T19:54:46Z","html_url":"https://github.com/darrynten/sage-one-php/pull/21#discussion_r126511231","pull_request_url":"https://api.github.com/repos/darrynten/sage-one-php/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/darrynten/sage-one-php/pulls/comments/126511231"},"html":{"href":"https://github.com/darrynten/sage-one-php/pull/21#discussion_r126511231"},"pull_request":{"href":"https://api.github.com/repos/darrynten/sage-one-php/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/darrynten/sage-one-php/pulls/21","id":129653076,"html_url":"https://github.com/darrynten/sage-one-php/pull/21","diff_url":"https://github.com/darrynten/sage-one-php/pull/21.diff","patch_url":"https://github.com/darrynten/sage-one-php/pull/21.patch","issue_url":"https://api.github.com/repos/darrynten/sage-one-php/issues/21","number":21,"state":"open","locked":false,"title":"Account model custom methods","user":{"login":"make-it-git","id":28646072,"avatar_url":"https://avatars1.githubusercontent.com/u/28646072?v=3","gravatar_id":"","url":"https://api.github.com/users/make-it-git","html_url":"https://github.com/make-it-git","followers_url":"https://api.github.com/users/make-it-git/followers","following_url":"https://api.github.com/users/make-it-git/following{/other_user}","gists_url":"https://api.github.com/users/make-it-git/gists{/gist_id}","starred_url":"https://api.github.com/users/make-it-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/make-it-git/subscriptions","organizations_url":"https://api.github.com/users/make-it-git/orgs","repos_url":"https://api.github.com/users/make-it-git/repos","events_url":"https://api.github.com/users/make-it-git/events{/privacy}","received_events_url":"https://api.github.com/users/make-it-git/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\n| Q                 | A\r\n| ----------------- | ---\r\n| Bugfix?           | no\r\n| New feature?      | yes\r\n| Breaking Changes? | no\r\n| Fixed issues      | #\r\n\r\n## The problem\r\n\r\nAdd custom methods to Account. It includes GetAccountsByCategoryId/{id}, GetWithSystemAccounts, GetChartofAccounts\r\n\r\n## How I resolved it\r\n\r\nSimilar to all() and get() methods.\r\n\r\nNotify the following people: @darrynten \r\n","created_at":"2017-07-10T11:04:31Z","updated_at":"2017-07-10T19:54:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63ae28f563e77e742a974a09d289936837ce6e31","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/darrynten/sage-one-php/pulls/21/commits","review_comments_url":"https://api.github.com/repos/darrynten/sage-one-php/pulls/21/comments","review_comment_url":"https://api.github.com/repos/darrynten/sage-one-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/darrynten/sage-one-php/issues/21/comments","statuses_url":"https://api.github.com/repos/darrynten/sage-one-php/statuses/88d19f9609072c0e083f177b470eb9eef678789b","head":{"label":"darrynten:account-model-custom-methods","ref":"account-model-custom-methods","sha":"88d19f9609072c0e083f177b470eb9eef678789b","user":{"login":"darrynten","id":3657251,"avatar_url":"https://avatars2.githubusercontent.com/u/3657251?v=3","gravatar_id":"","url":"https://api.github.com/users/darrynten","html_url":"https://github.com/darrynten","followers_url":"https://api.github.com/users/darrynten/followers","following_url":"https://api.github.com/users/darrynten/following{/other_user}","gists_url":"https://api.github.com/users/darrynten/gists{/gist_id}","starred_url":"https://api.github.com/users/darrynten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrynten/subscriptions","organizations_url":"https://api.github.com/users/darrynten/orgs","repos_url":"https://api.github.com/users/darrynten/repos","events_url":"https://api.github.com/users/darrynten/events{/privacy}","received_events_url":"https://api.github.com/users/darrynten/received_events","type":"User","site_admin":false},"repo":{"id":95722049,"name":"sage-one-php","full_name":"darrynten/sage-one-php","owner":{"login":"darrynten","id":3657251,"avatar_url":"https://avatars2.githubusercontent.com/u/3657251?v=3","gravatar_id":"","url":"https://api.github.com/users/darrynten","html_url":"https://github.com/darrynten","followers_url":"https://api.github.com/users/darrynten/followers","following_url":"https://api.github.com/users/darrynten/following{/other_user}","gists_url":"https://api.github.com/users/darrynten/gists{/gist_id}","starred_url":"https://api.github.com/users/darrynten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrynten/subscriptions","organizations_url":"https://api.github.com/users/darrynten/orgs","repos_url":"https://api.github.com/users/darrynten/repos","events_url":"https://api.github.com/users/darrynten/events{/privacy}","received_events_url":"https://api.github.com/users/darrynten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darrynten/sage-one-php","description":"SageOne PHP Client","fork":false,"url":"https://api.github.com/repos/darrynten/sage-one-php","forks_url":"https://api.github.com/repos/darrynten/sage-one-php/forks","keys_url":"https://api.github.com/repos/darrynten/sage-one-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darrynten/sage-one-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darrynten/sage-one-php/teams","hooks_url":"https://api.github.com/repos/darrynten/sage-one-php/hooks","issue_events_url":"https://api.github.com/repos/darrynten/sage-one-php/issues/events{/number}","events_url":"https://api.github.com/repos/darrynten/sage-one-php/events","assignees_url":"https://api.github.com/repos/darrynten/sage-one-php/assignees{/user}","branches_url":"https://api.github.com/repos/darrynten/sage-one-php/branches{/branch}","tags_url":"https://api.github.com/repos/darrynten/sage-one-php/tags","blobs_url":"https://api.github.com/repos/darrynten/sage-one-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darrynten/sage-one-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darrynten/sage-one-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/darrynten/sage-one-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darrynten/sage-one-php/statuses/{sha}","languages_url":"https://api.github.com/repos/darrynten/sage-one-php/languages","stargazers_url":"https://api.github.com/repos/darrynten/sage-one-php/stargazers","contributors_url":"https://api.github.com/repos/darrynten/sage-one-php/contributors","subscribers_url":"https://api.github.com/repos/darrynten/sage-one-php/subscribers","subscription_url":"https://api.github.com/repos/darrynten/sage-one-php/subscription","commits_url":"https://api.github.com/repos/darrynten/sage-one-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/darrynten/sage-one-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/darrynten/sage-one-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/darrynten/sage-one-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/darrynten/sage-one-php/contents/{+path}","compare_url":"https://api.github.com/repos/darrynten/sage-one-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darrynten/sage-one-php/merges","archive_url":"https://api.github.com/repos/darrynten/sage-one-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darrynten/sage-one-php/downloads","issues_url":"https://api.github.com/repos/darrynten/sage-one-php/issues{/number}","pulls_url":"https://api.github.com/repos/darrynten/sage-one-php/pulls{/number}","milestones_url":"https://api.github.com/repos/darrynten/sage-one-php/milestones{/number}","notifications_url":"https://api.github.com/repos/darrynten/sage-one-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darrynten/sage-one-php/labels{/name}","releases_url":"https://api.github.com/repos/darrynten/sage-one-php/releases{/id}","deployments_url":"https://api.github.com/repos/darrynten/sage-one-php/deployments","created_at":"2017-06-29T00:14:15Z","updated_at":"2017-07-07T14:31:30Z","pushed_at":"2017-07-10T19:03:17Z","git_url":"git://github.com/darrynten/sage-one-php.git","ssh_url":"git@github.com:darrynten/sage-one-php.git","clone_url":"https://github.com/darrynten/sage-one-php.git","svn_url":"https://github.com/darrynten/sage-one-php","homepage":null,"size":200,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"dev"}},"base":{"label":"darrynten:dev","ref":"dev","sha":"b2364b9f7c3b8645d90615dd302abdf5b8dfa5e2","user":{"login":"darrynten","id":3657251,"avatar_url":"https://avatars2.githubusercontent.com/u/3657251?v=3","gravatar_id":"","url":"https://api.github.com/users/darrynten","html_url":"https://github.com/darrynten","followers_url":"https://api.github.com/users/darrynten/followers","following_url":"https://api.github.com/users/darrynten/following{/other_user}","gists_url":"https://api.github.com/users/darrynten/gists{/gist_id}","starred_url":"https://api.github.com/users/darrynten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrynten/subscriptions","organizations_url":"https://api.github.com/users/darrynten/orgs","repos_url":"https://api.github.com/users/darrynten/repos","events_url":"https://api.github.com/users/darrynten/events{/privacy}","received_events_url":"https://api.github.com/users/darrynten/received_events","type":"User","site_admin":false},"repo":{"id":95722049,"name":"sage-one-php","full_name":"darrynten/sage-one-php","owner":{"login":"darrynten","id":3657251,"avatar_url":"https://avatars2.githubusercontent.com/u/3657251?v=3","gravatar_id":"","url":"https://api.github.com/users/darrynten","html_url":"https://github.com/darrynten","followers_url":"https://api.github.com/users/darrynten/followers","following_url":"https://api.github.com/users/darrynten/following{/other_user}","gists_url":"https://api.github.com/users/darrynten/gists{/gist_id}","starred_url":"https://api.github.com/users/darrynten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrynten/subscriptions","organizations_url":"https://api.github.com/users/darrynten/orgs","repos_url":"https://api.github.com/users/darrynten/repos","events_url":"https://api.github.com/users/darrynten/events{/privacy}","received_events_url":"https://api.github.com/users/darrynten/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darrynten/sage-one-php","description":"SageOne PHP Client","fork":false,"url":"https://api.github.com/repos/darrynten/sage-one-php","forks_url":"https://api.github.com/repos/darrynten/sage-one-php/forks","keys_url":"https://api.github.com/repos/darrynten/sage-one-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darrynten/sage-one-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darrynten/sage-one-php/teams","hooks_url":"https://api.github.com/repos/darrynten/sage-one-php/hooks","issue_events_url":"https://api.github.com/repos/darrynten/sage-one-php/issues/events{/number}","events_url":"https://api.github.com/repos/darrynten/sage-one-php/events","assignees_url":"https://api.github.com/repos/darrynten/sage-one-php/assignees{/user}","branches_url":"https://api.github.com/repos/darrynten/sage-one-php/branches{/branch}","tags_url":"https://api.github.com/repos/darrynten/sage-one-php/tags","blobs_url":"https://api.github.com/repos/darrynten/sage-one-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darrynten/sage-one-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darrynten/sage-one-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/darrynten/sage-one-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darrynten/sage-one-php/statuses/{sha}","languages_url":"https://api.github.com/repos/darrynten/sage-one-php/languages","stargazers_url":"https://api.github.com/repos/darrynten/sage-one-php/stargazers","contributors_url":"https://api.github.com/repos/darrynten/sage-one-php/contributors","subscribers_url":"https://api.github.com/repos/darrynten/sage-one-php/subscribers","subscription_url":"https://api.github.com/repos/darrynten/sage-one-php/subscription","commits_url":"https://api.github.com/repos/darrynten/sage-one-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/darrynten/sage-one-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/darrynten/sage-one-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/darrynten/sage-one-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/darrynten/sage-one-php/contents/{+path}","compare_url":"https://api.github.com/repos/darrynten/sage-one-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darrynten/sage-one-php/merges","archive_url":"https://api.github.com/repos/darrynten/sage-one-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darrynten/sage-one-php/downloads","issues_url":"https://api.github.com/repos/darrynten/sage-one-php/issues{/number}","pulls_url":"https://api.github.com/repos/darrynten/sage-one-php/pulls{/number}","milestones_url":"https://api.github.com/repos/darrynten/sage-one-php/milestones{/number}","notifications_url":"https://api.github.com/repos/darrynten/sage-one-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darrynten/sage-one-php/labels{/name}","releases_url":"https://api.github.com/repos/darrynten/sage-one-php/releases{/id}","deployments_url":"https://api.github.com/repos/darrynten/sage-one-php/deployments","created_at":"2017-06-29T00:14:15Z","updated_at":"2017-07-07T14:31:30Z","pushed_at":"2017-07-10T19:03:17Z","git_url":"git://github.com/darrynten/sage-one-php.git","ssh_url":"git@github.com:darrynten/sage-one-php.git","clone_url":"https://github.com/darrynten/sage-one-php.git","svn_url":"https://github.com/darrynten/sage-one-php","homepage":null,"size":200,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/darrynten/sage-one-php/pulls/21"},"html":{"href":"https://github.com/darrynten/sage-one-php/pull/21"},"issue":{"href":"https://api.github.com/repos/darrynten/sage-one-php/issues/21"},"comments":{"href":"https://api.github.com/repos/darrynten/sage-one-php/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/darrynten/sage-one-php/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/darrynten/sage-one-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/darrynten/sage-one-php/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/darrynten/sage-one-php/statuses/88d19f9609072c0e083f177b470eb9eef678789b"}}}}
{"actor":{"display_login":"darrynten"}}