{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56025","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56025/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56025/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56025/events","html_url":"https://github.com/kubernetes/kubernetes/pull/56025","id":275203395,"number":56025,"title":"Enhance kubeadm `bootstrap-token`","user":{"login":"fabriziopandini","id":5013060,"avatar_url":"https://avatars0.githubusercontent.com/u/5013060?v=4","gravatar_id":"","url":"https://api.github.com/users/fabriziopandini","html_url":"https://github.com/fabriziopandini","followers_url":"https://api.github.com/users/fabriziopandini/followers","following_url":"https://api.github.com/users/fabriziopandini/following{/other_user}","gists_url":"https://api.github.com/users/fabriziopandini/gists{/gist_id}","starred_url":"https://api.github.com/users/fabriziopandini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabriziopandini/subscriptions","organizations_url":"https://api.github.com/users/fabriziopandini/orgs","repos_url":"https://api.github.com/users/fabriziopandini/repos","events_url":"https://api.github.com/users/fabriziopandini/events{/privacy}","received_events_url":"https://api.github.com/users/fabriziopandini/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":240247879,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-rebase","name":"needs-rebase","color":"BDBDBD","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars3.githubusercontent.com/u/1787169?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"assignees":[{"login":"dmmcquay","id":1700422,"avatar_url":"https://avatars2.githubusercontent.com/u/1700422?v=4","gravatar_id":"","url":"https://api.github.com/users/dmmcquay","html_url":"https://github.com/dmmcquay","followers_url":"https://api.github.com/users/dmmcquay/followers","following_url":"https://api.github.com/users/dmmcquay/following{/other_user}","gists_url":"https://api.github.com/users/dmmcquay/gists{/gist_id}","starred_url":"https://api.github.com/users/dmmcquay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmmcquay/subscriptions","organizations_url":"https://api.github.com/users/dmmcquay/orgs","repos_url":"https://api.github.com/users/dmmcquay/repos","events_url":"https://api.github.com/users/dmmcquay/events{/privacy}","received_events_url":"https://api.github.com/users/dmmcquay/received_events","type":"User","site_admin":false},{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars3.githubusercontent.com/u/1787169?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-11-19T23:30:09Z","updated_at":"2017-11-19T23:33:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/56025","html_url":"https://github.com/kubernetes/kubernetes/pull/56025","diff_url":"https://github.com/kubernetes/kubernetes/pull/56025.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/56025.patch"},"body":"**What this PR does / why we need it**:\r\nThis PR is part of the effort for improving kubeadm phases, and more specifically improves `bootstrap-token` phase by implementing a behaviour consistent with `kubeadm init`, that is:\r\n- `all` subcommand\r\n- `create` subcommand (with CA pinning stuff and --config) \r\n- `cluster-info` subcommand was modified, removing --config (thus making it consistent with other phases)\r\n- `allow-auto-approve` subcommand was improved, implementing also creation of RBAC rules for certificate rotation (thus making it consistent with `kubeadm init`)\r\n- Reference docs improved\r\n\r\n**Which issue(s) this PR fixes** \r\npart of the effort for [#461](https://github.com/kubernetes/kubeadm/issues/461)\r\npart of the effort for [#454](https://github.com/kubernetes/kubeadm/issues/454)\r\npart of the effort for [#265](https://github.com/kubernetes/kubeadm/issues/265)\r\n\r\n**Special notes for your reviewer**:\r\nCC @luxas\r\n\r\n**Release note**:\r\n```release-note\r\nNONE\r\n```"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/345559718","html_url":"https://github.com/kubernetes/kubernetes/pull/56025#issuecomment-345559718","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/56025","id":345559718,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2017-11-19T23:33:30Z","updated_at":"2017-11-19T23:33:30Z","author_association":"COLLABORATOR","body":"@fabriziopandini: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-node-e2e | be3abca4b97effc11cb1db9ab3a588477eda517c | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/56025/pull-kubernetes-node-e2e/63469/) | `/test pull-kubernetes-node-e2e`\npull-kubernetes-e2e-gce | be3abca4b97effc11cb1db9ab3a588477eda517c | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/56025/pull-kubernetes-e2e-gce/7655/) | `/test pull-kubernetes-e2e-gce`\npull-kubernetes-e2e-gce-device-plugin-gpu | be3abca4b97effc11cb1db9ab3a588477eda517c | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/56025/pull-kubernetes-e2e-gce-device-plugin-gpu/6017/) | `/test pull-kubernetes-e2e-gce-device-plugin-gpu`\npull-kubernetes-bazel-test | be3abca4b97effc11cb1db9ab3a588477eda517c | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/56025/pull-kubernetes-bazel-test/18261/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-e2e-kops-aws | be3abca4b97effc11cb1db9ab3a588477eda517c | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/56025/pull-kubernetes-e2e-kops-aws/61049/) | `/test pull-kubernetes-e2e-kops-aws`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/56025). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/fabriziopandini). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}