{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/146902122","pull_request_review_id":71914000,"id":146902122,"diff_hunk":"@@ -114,7 +114,7 @@ class PartialRowData(object):\n     \"\"\"Representation of partial row in a Google Cloud Bigtable Table.\n \n     These are expected to be updated directly from a\n-    :class:`._generated.bigtable_service_messages_pb2.ReadRowsResponse`\n+   :class:`._generated.bigtable_service_messages_pb2.ReadRowsResponse`","path":"bigtable/google/cloud/bigtable/row_data.py","position":5,"original_position":5,"commit_id":"20c8c2ec57f59141674c32648472e373009d0172","original_commit_id":"20c8c2ec57f59141674c32648472e373009d0172","user":{"login":"garye","id":37807,"avatar_url":"https://avatars1.githubusercontent.com/u/37807?v=4","gravatar_id":"","url":"https://api.github.com/users/garye","html_url":"https://github.com/garye","followers_url":"https://api.github.com/users/garye/followers","following_url":"https://api.github.com/users/garye/following{/other_user}","gists_url":"https://api.github.com/users/garye/gists{/gist_id}","starred_url":"https://api.github.com/users/garye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garye/subscriptions","organizations_url":"https://api.github.com/users/garye/orgs","repos_url":"https://api.github.com/users/garye/repos","events_url":"https://api.github.com/users/garye/events{/privacy}","received_events_url":"https://api.github.com/users/garye/received_events","type":"User","site_admin":false},"body":"yes, looks that way","created_at":"2017-10-25T15:49:55Z","updated_at":"2017-10-25T15:49:56Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4252#discussion_r146902122","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4252","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/146902122"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4252#discussion_r146902122"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4252"}},"in_reply_to_id":146885863},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4252","id":148679759,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4252","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4252.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4252.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/4252","number":4252,"state":"open","locked":false,"title":"Bigtable ReadRows doesn't handle empty string column qualifier","user":{"login":"garye","id":37807,"avatar_url":"https://avatars1.githubusercontent.com/u/37807?v=4","gravatar_id":"","url":"https://api.github.com/users/garye","html_url":"https://github.com/garye","followers_url":"https://api.github.com/users/garye/followers","following_url":"https://api.github.com/users/garye/following{/other_user}","gists_url":"https://api.github.com/users/garye/gists{/gist_id}","starred_url":"https://api.github.com/users/garye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garye/subscriptions","organizations_url":"https://api.github.com/users/garye/orgs","repos_url":"https://api.github.com/users/garye/repos","events_url":"https://api.github.com/users/garye/events{/privacy}","received_events_url":"https://api.github.com/users/garye/received_events","type":"User","site_admin":false},"body":"This problem was reported by a customer. As background, the empty string is a valid column qualifier. A missing qualifier, as opposed to the empty string, means the previously seen qualifier should be applied instead.\r\n\r\nI added a new test case that has a cell with a column qualifier of empty string arriving after a cell with a non-empty qualifier. The code fails to distinguish between a missing qualifier and an empty qualifier and overwrites the empty string with the first qualifier.\r\n\r\nWith no code changes the new test case fails. I attempted to fix the bug in `row_data.py` but this causes other failures. I was hoping someone could pick this up and investigate. \r\n\r\n","created_at":"2017-10-25T14:12:03Z","updated_at":"2017-10-25T15:49:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82fad5f77e27a326eb40ea673cb6553bbaf60166","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lukesneeringer","id":4346,"avatar_url":"https://avatars0.githubusercontent.com/u/4346?v=4","gravatar_id":"","url":"https://api.github.com/users/lukesneeringer","html_url":"https://github.com/lukesneeringer","followers_url":"https://api.github.com/users/lukesneeringer/followers","following_url":"https://api.github.com/users/lukesneeringer/following{/other_user}","gists_url":"https://api.github.com/users/lukesneeringer/gists{/gist_id}","starred_url":"https://api.github.com/users/lukesneeringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukesneeringer/subscriptions","organizations_url":"https://api.github.com/users/lukesneeringer/orgs","repos_url":"https://api.github.com/users/lukesneeringer/repos","events_url":"https://api.github.com/users/lukesneeringer/events{/privacy}","received_events_url":"https://api.github.com/users/lukesneeringer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4252/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4252/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/4252/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/20c8c2ec57f59141674c32648472e373009d0172","head":{"label":"garye:master","ref":"master","sha":"20c8c2ec57f59141674c32648472e373009d0172","user":{"login":"garye","id":37807,"avatar_url":"https://avatars1.githubusercontent.com/u/37807?v=4","gravatar_id":"","url":"https://api.github.com/users/garye","html_url":"https://github.com/garye","followers_url":"https://api.github.com/users/garye/followers","following_url":"https://api.github.com/users/garye/following{/other_user}","gists_url":"https://api.github.com/users/garye/gists{/gist_id}","starred_url":"https://api.github.com/users/garye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garye/subscriptions","organizations_url":"https://api.github.com/users/garye/orgs","repos_url":"https://api.github.com/users/garye/repos","events_url":"https://api.github.com/users/garye/events{/privacy}","received_events_url":"https://api.github.com/users/garye/received_events","type":"User","site_admin":false},"repo":{"id":103182523,"name":"google-cloud-python","full_name":"garye/google-cloud-python","owner":{"login":"garye","id":37807,"avatar_url":"https://avatars1.githubusercontent.com/u/37807?v=4","gravatar_id":"","url":"https://api.github.com/users/garye","html_url":"https://github.com/garye","followers_url":"https://api.github.com/users/garye/followers","following_url":"https://api.github.com/users/garye/following{/other_user}","gists_url":"https://api.github.com/users/garye/gists{/gist_id}","starred_url":"https://api.github.com/users/garye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garye/subscriptions","organizations_url":"https://api.github.com/users/garye/orgs","repos_url":"https://api.github.com/users/garye/repos","events_url":"https://api.github.com/users/garye/events{/privacy}","received_events_url":"https://api.github.com/users/garye/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garye/google-cloud-python","description":"Google Cloud Client Library for Python","fork":true,"url":"https://api.github.com/repos/garye/google-cloud-python","forks_url":"https://api.github.com/repos/garye/google-cloud-python/forks","keys_url":"https://api.github.com/repos/garye/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garye/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garye/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/garye/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/garye/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/garye/google-cloud-python/events","assignees_url":"https://api.github.com/repos/garye/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/garye/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/garye/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/garye/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garye/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garye/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/garye/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garye/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/garye/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/garye/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/garye/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/garye/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/garye/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/garye/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/garye/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/garye/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/garye/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/garye/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/garye/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garye/google-cloud-python/merges","archive_url":"https://api.github.com/repos/garye/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garye/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/garye/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/garye/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/garye/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/garye/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garye/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/garye/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/garye/google-cloud-python/deployments","created_at":"2017-09-11T20:07:11Z","updated_at":"2017-09-11T20:07:15Z","pushed_at":"2017-10-25T14:06:06Z","git_url":"git://github.com/garye/google-cloud-python.git","ssh_url":"git@github.com:garye/google-cloud-python.git","clone_url":"https://github.com/garye/google-cloud-python.git","svn_url":"https://github.com/garye/google-cloud-python","homepage":"https://googlecloudplatform.github.io/google-cloud-python/","size":126398,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"6dbb16c02ba4cdf4624a23b88167465133cb45f1","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"name":"google-cloud-python","full_name":"GoogleCloudPlatform/google-cloud-python","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","description":"Google Cloud Client Library for Python","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/deployments","created_at":"2014-01-28T15:51:47Z","updated_at":"2017-10-25T13:16:30Z","pushed_at":"2017-10-25T15:49:42Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-python.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-python.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-python.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","homepage":"https://googlecloudplatform.github.io/google-cloud-python/","size":131260,"stargazers_count":973,"watchers_count":973,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":466,"mirror_url":null,"archived":false,"open_issues_count":109,"forks":466,"open_issues":109,"watchers":973,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4252"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4252"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/4252"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/4252/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4252/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4252/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/20c8c2ec57f59141674c32648472e373009d0172"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"garye"}}