{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/116113680","pull_request_review_id":37712186,"id":116113680,"diff_hunk":"@@ -188,69 +88,12 @@ public static function alt($string, $alt, $jsSafe = false, $interpretBackSlashes\n \t *\n \t * @return  string  The translated strings or the key if 'script' is true in the array of options\n \t *\n-\t * @since   11.1\n+\t * @since       11.1\n+\t * @deprecated  use the translator object of the application","path":"libraries/joomla/language/text.php","position":153,"original_position":153,"commit_id":"e77ea2b7ff2d44465105f880f733a8bd1cb55513","original_commit_id":"e77ea2b7ff2d44465105f880f733a8bd1cb55513","user":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars1.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"body":"uppercase","created_at":"2017-05-11T22:06:49Z","updated_at":"2017-05-11T22:09:32Z","html_url":"https://github.com/joomla/joomla-cms/pull/15924#discussion_r116113680","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/15924","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/116113680"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/15924#discussion_r116113680"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/15924"}}},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/15924","id":119747692,"html_url":"https://github.com/joomla/joomla-cms/pull/15924","diff_url":"https://github.com/joomla/joomla-cms/pull/15924.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/15924.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/15924","number":15924,"state":"open","locked":false,"title":"Introduce translator in favor of JText","user":{"login":"laoneo","id":251072,"avatar_url":"https://avatars0.githubusercontent.com/u/251072?v=3","gravatar_id":"","url":"https://api.github.com/users/laoneo","html_url":"https://github.com/laoneo","followers_url":"https://api.github.com/users/laoneo/followers","following_url":"https://api.github.com/users/laoneo/following{/other_user}","gists_url":"https://api.github.com/users/laoneo/gists{/gist_id}","starred_url":"https://api.github.com/users/laoneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laoneo/subscriptions","organizations_url":"https://api.github.com/users/laoneo/orgs","repos_url":"https://api.github.com/users/laoneo/repos","events_url":"https://api.github.com/users/laoneo/events{/privacy}","received_events_url":"https://api.github.com/users/laoneo/received_events","type":"User","site_admin":false},"body":"### Summary of Changes\r\nAll over a component are `JText`references. As we start to inject stuff into the MVC layer it would be good to get rid of the static `JText` calls and use a translator object instead.\r\n\r\nThis pr introduces a new class `Joomla\\CMS\\Language\\Translator` which has the same functions and arguments as it's predecessor `JText`. The translator object is accessible on the application and requires a language instance.\r\n\r\nAdditionally `JText`is deprecated in favor of the translator.\r\n\r\n### Testing Instructions\r\nOpen the back end.\r\n\r\n### Expected result\r\nAll should work as expected, the strings do need to be translated.\r\n\r\n### Actual result\r\nNo change.\r\n\r\n### Documentation Changes Required\r\nDocumentation needs to be updated to recommend to use the translator instead of JText.\r\n","created_at":"2017-05-09T20:35:27Z","updated_at":"2017-05-11T22:09:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"228108f24b91430fa8ea4be68729a74e0bfe678a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/15924/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/15924/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/15924/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/e77ea2b7ff2d44465105f880f733a8bd1cb55513","head":{"label":"Digital-Peak:j3/feature/translator","ref":"j3/feature/translator","sha":"e77ea2b7ff2d44465105f880f733a8bd1cb55513","user":{"login":"Digital-Peak","id":4374265,"avatar_url":"https://avatars2.githubusercontent.com/u/4374265?v=3","gravatar_id":"","url":"https://api.github.com/users/Digital-Peak","html_url":"https://github.com/Digital-Peak","followers_url":"https://api.github.com/users/Digital-Peak/followers","following_url":"https://api.github.com/users/Digital-Peak/following{/other_user}","gists_url":"https://api.github.com/users/Digital-Peak/gists{/gist_id}","starred_url":"https://api.github.com/users/Digital-Peak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Digital-Peak/subscriptions","organizations_url":"https://api.github.com/users/Digital-Peak/orgs","repos_url":"https://api.github.com/users/Digital-Peak/repos","events_url":"https://api.github.com/users/Digital-Peak/events{/privacy}","received_events_url":"https://api.github.com/users/Digital-Peak/received_events","type":"Organization","site_admin":false},"repo":{"id":41362268,"name":"joomla-cms","full_name":"Digital-Peak/joomla-cms","owner":{"login":"Digital-Peak","id":4374265,"avatar_url":"https://avatars2.githubusercontent.com/u/4374265?v=3","gravatar_id":"","url":"https://api.github.com/users/Digital-Peak","html_url":"https://github.com/Digital-Peak","followers_url":"https://api.github.com/users/Digital-Peak/followers","following_url":"https://api.github.com/users/Digital-Peak/following{/other_user}","gists_url":"https://api.github.com/users/Digital-Peak/gists{/gist_id}","starred_url":"https://api.github.com/users/Digital-Peak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Digital-Peak/subscriptions","organizations_url":"https://api.github.com/users/Digital-Peak/orgs","repos_url":"https://api.github.com/users/Digital-Peak/repos","events_url":"https://api.github.com/users/Digital-Peak/events{/privacy}","received_events_url":"https://api.github.com/users/Digital-Peak/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Digital-Peak/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/Digital-Peak/joomla-cms","forks_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/forks","keys_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/teams","hooks_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/events","assignees_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/tags","blobs_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/subscription","commits_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/merges","archive_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/downloads","issues_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/Digital-Peak/joomla-cms/deployments","created_at":"2015-08-25T12:34:04Z","updated_at":"2016-02-17T12:01:34Z","pushed_at":"2017-05-11T07:55:09Z","git_url":"git://github.com/Digital-Peak/joomla-cms.git","ssh_url":"git@github.com:Digital-Peak/joomla-cms.git","clone_url":"https://github.com/Digital-Peak/joomla-cms.git","svn_url":"https://github.com/Digital-Peak/joomla-cms","homepage":"http://joomla.org","size":191274,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:3.8-dev","ref":"3.8-dev","sha":"4777a4d16b1a018b39e187817650119754533ff2","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars0.githubusercontent.com/u/751633?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2017-05-11T13:31:25Z","pushed_at":"2017-05-11T18:55:26Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":191054,"stargazers_count":2357,"watchers_count":2357,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2479,"mirror_url":null,"open_issues_count":967,"forks":2479,"open_issues":967,"watchers":2357,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/15924"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/15924"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/15924"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/15924/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/15924/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/15924/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/e77ea2b7ff2d44465105f880f733a8bd1cb55513"}}}}
{"actor":{"display_login":"zero-24"}}