{"action":"created","comment":{"url":"https://api.github.com/repos/apereo/cas/pulls/comments/105945882","pull_request_review_id":26846940,"id":105945882,"diff_hunk":"@@ -138,6 +138,42 @@ the generated identifier of the new service.\n 5463544213\n ```\n \n+## Add x509 support\n+\n+The feature extends REST communication model to non-interactive authentication.\n+This pattern may be of interest in case if internal network architecture hides\n+the CAS server from external users behind firewall or some messaging bus. And\n+allows only trusted Applications to connect the server.\n+\n+<div class=\"alert alert-warning\"><strong>Usage Warning!</strong><p>The x509 feature over REST\n+provides a tremendously convenient target for claiming others identity. The x509 provides\n+a tremendously convenient target for claiming others identity. To leverage this issue network\n+configuration may allow connections to the CAS server only from trusted hosts which in turn\n+have strict security limitations and logging.","path":"docs/cas-server-documentation/protocol/REST-Protocol.md","position":15,"original_position":15,"commit_id":"591d3ed808b452f2570b2462fe2614caa847f077","original_commit_id":"591d3ed808b452f2570b2462fe2614caa847f077","user":{"login":"fedon","id":2691833,"avatar_url":"https://avatars2.githubusercontent.com/u/2691833?v=3","gravatar_id":"","url":"https://api.github.com/users/fedon","html_url":"https://github.com/fedon","followers_url":"https://api.github.com/users/fedon/followers","following_url":"https://api.github.com/users/fedon/following{/other_user}","gists_url":"https://api.github.com/users/fedon/gists{/gist_id}","starred_url":"https://api.github.com/users/fedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedon/subscriptions","organizations_url":"https://api.github.com/users/fedon/orgs","repos_url":"https://api.github.com/users/fedon/repos","events_url":"https://api.github.com/users/fedon/events{/privacy}","received_events_url":"https://api.github.com/users/fedon/received_events","type":"User","site_admin":false},"body":"I have lost </p></div> for warning block. I have already fixed the bug in my clone repo. Should I create one more PR?","created_at":"2017-03-14T15:47:07Z","updated_at":"2017-03-14T15:47:07Z","html_url":"https://github.com/apereo/cas/pull/2452#discussion_r105945882","pull_request_url":"https://api.github.com/repos/apereo/cas/pulls/2452","_links":{"self":{"href":"https://api.github.com/repos/apereo/cas/pulls/comments/105945882"},"html":{"href":"https://github.com/apereo/cas/pull/2452#discussion_r105945882"},"pull_request":{"href":"https://api.github.com/repos/apereo/cas/pulls/2452"}}},"pull_request":{"url":"https://api.github.com/repos/apereo/cas/pulls/2452","id":110407335,"html_url":"https://github.com/apereo/cas/pull/2452","diff_url":"https://github.com/apereo/cas/pull/2452.diff","patch_url":"https://github.com/apereo/cas/pull/2452.patch","issue_url":"https://api.github.com/repos/apereo/cas/issues/2452","number":2452,"state":"closed","locked":false,"title":"New Feature: Support x509 over REST","user":{"login":"fedon","id":2691833,"avatar_url":"https://avatars2.githubusercontent.com/u/2691833?v=3","gravatar_id":"","url":"https://api.github.com/users/fedon","html_url":"https://github.com/fedon","followers_url":"https://api.github.com/users/fedon/followers","following_url":"https://api.github.com/users/fedon/following{/other_user}","gists_url":"https://api.github.com/users/fedon/gists{/gist_id}","starred_url":"https://api.github.com/users/fedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedon/subscriptions","organizations_url":"https://api.github.com/users/fedon/orgs","repos_url":"https://api.github.com/users/fedon/repos","events_url":"https://api.github.com/users/fedon/events{/privacy}","received_events_url":"https://api.github.com/users/fedon/received_events","type":"User","site_admin":false},"body":"Closes #2449\r\n\r\n-    X509CredentialFactory is implemented.\r\n-    to test \"curl --data-urlencode cert@certificate.pem http://cas-server:port/cas/v1/tickets\" --, where certificate.pem is public certificate in ascii format.\r\n-    in general the solution provides serious security hole as authentication is based on public information. So, implemented feature heavily relays on CAS server environment and installation. And it should be included only if is completely understood and security environment is provided outside of CAS server.\r\n-    N/A\r\n","created_at":"2017-03-13T13:49:59Z","updated_at":"2017-03-14T15:47:07Z","closed_at":"2017-03-14T12:05:32Z","merged_at":"2017-03-14T12:05:32Z","merge_commit_sha":"25ea939470edb6f7e39398ddc5b60bd20030f5fa","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/apereo/cas/milestones/46","html_url":"https://github.com/apereo/cas/milestone/46","labels_url":"https://api.github.com/repos/apereo/cas/milestones/46/labels","id":2113633,"number":46,"title":"5.1.0.RC3","description":"Feature release: Release Candidate (Beta)","creator":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars2.githubusercontent.com/u/1205228?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":30,"state":"open","created_at":"2016-11-04T00:13:40Z","updated_at":"2017-03-14T12:55:10Z","due_on":"2017-03-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apereo/cas/pulls/2452/commits","review_comments_url":"https://api.github.com/repos/apereo/cas/pulls/2452/comments","review_comment_url":"https://api.github.com/repos/apereo/cas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apereo/cas/issues/2452/comments","statuses_url":"https://api.github.com/repos/apereo/cas/statuses/591d3ed808b452f2570b2462fe2614caa847f077","head":{"label":"fedon:CAS-2449","ref":"CAS-2449","sha":"591d3ed808b452f2570b2462fe2614caa847f077","user":{"login":"fedon","id":2691833,"avatar_url":"https://avatars2.githubusercontent.com/u/2691833?v=3","gravatar_id":"","url":"https://api.github.com/users/fedon","html_url":"https://github.com/fedon","followers_url":"https://api.github.com/users/fedon/followers","following_url":"https://api.github.com/users/fedon/following{/other_user}","gists_url":"https://api.github.com/users/fedon/gists{/gist_id}","starred_url":"https://api.github.com/users/fedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedon/subscriptions","organizations_url":"https://api.github.com/users/fedon/orgs","repos_url":"https://api.github.com/users/fedon/repos","events_url":"https://api.github.com/users/fedon/events{/privacy}","received_events_url":"https://api.github.com/users/fedon/received_events","type":"User","site_admin":false},"repo":{"id":84567463,"name":"cas","full_name":"fedon/cas","owner":{"login":"fedon","id":2691833,"avatar_url":"https://avatars2.githubusercontent.com/u/2691833?v=3","gravatar_id":"","url":"https://api.github.com/users/fedon","html_url":"https://github.com/fedon","followers_url":"https://api.github.com/users/fedon/followers","following_url":"https://api.github.com/users/fedon/following{/other_user}","gists_url":"https://api.github.com/users/fedon/gists{/gist_id}","starred_url":"https://api.github.com/users/fedon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fedon/subscriptions","organizations_url":"https://api.github.com/users/fedon/orgs","repos_url":"https://api.github.com/users/fedon/repos","events_url":"https://api.github.com/users/fedon/events{/privacy}","received_events_url":"https://api.github.com/users/fedon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fedon/cas","description":"Apereo CAS - Enterprise Single Sign On for all earthlings and beyond.","fork":true,"url":"https://api.github.com/repos/fedon/cas","forks_url":"https://api.github.com/repos/fedon/cas/forks","keys_url":"https://api.github.com/repos/fedon/cas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fedon/cas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fedon/cas/teams","hooks_url":"https://api.github.com/repos/fedon/cas/hooks","issue_events_url":"https://api.github.com/repos/fedon/cas/issues/events{/number}","events_url":"https://api.github.com/repos/fedon/cas/events","assignees_url":"https://api.github.com/repos/fedon/cas/assignees{/user}","branches_url":"https://api.github.com/repos/fedon/cas/branches{/branch}","tags_url":"https://api.github.com/repos/fedon/cas/tags","blobs_url":"https://api.github.com/repos/fedon/cas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fedon/cas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fedon/cas/git/refs{/sha}","trees_url":"https://api.github.com/repos/fedon/cas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fedon/cas/statuses/{sha}","languages_url":"https://api.github.com/repos/fedon/cas/languages","stargazers_url":"https://api.github.com/repos/fedon/cas/stargazers","contributors_url":"https://api.github.com/repos/fedon/cas/contributors","subscribers_url":"https://api.github.com/repos/fedon/cas/subscribers","subscription_url":"https://api.github.com/repos/fedon/cas/subscription","commits_url":"https://api.github.com/repos/fedon/cas/commits{/sha}","git_commits_url":"https://api.github.com/repos/fedon/cas/git/commits{/sha}","comments_url":"https://api.github.com/repos/fedon/cas/comments{/number}","issue_comment_url":"https://api.github.com/repos/fedon/cas/issues/comments{/number}","contents_url":"https://api.github.com/repos/fedon/cas/contents/{+path}","compare_url":"https://api.github.com/repos/fedon/cas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fedon/cas/merges","archive_url":"https://api.github.com/repos/fedon/cas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fedon/cas/downloads","issues_url":"https://api.github.com/repos/fedon/cas/issues{/number}","pulls_url":"https://api.github.com/repos/fedon/cas/pulls{/number}","milestones_url":"https://api.github.com/repos/fedon/cas/milestones{/number}","notifications_url":"https://api.github.com/repos/fedon/cas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fedon/cas/labels{/name}","releases_url":"https://api.github.com/repos/fedon/cas/releases{/id}","deployments_url":"https://api.github.com/repos/fedon/cas/deployments","created_at":"2017-03-10T14:22:52Z","updated_at":"2017-03-10T14:23:10Z","pushed_at":"2017-03-14T15:31:26Z","git_url":"git://github.com/fedon/cas.git","ssh_url":"git@github.com:fedon/cas.git","clone_url":"https://github.com/fedon/cas.git","svn_url":"https://github.com/fedon/cas","homepage":"https://apereo.github.io/cas/","size":1303470,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apereo:master","ref":"master","sha":"3087509b94e1bcb0ca360ce42e2bdae14477c848","user":{"login":"apereo","id":4679233,"avatar_url":"https://avatars0.githubusercontent.com/u/4679233?v=3","gravatar_id":"","url":"https://api.github.com/users/apereo","html_url":"https://github.com/apereo","followers_url":"https://api.github.com/users/apereo/followers","following_url":"https://api.github.com/users/apereo/following{/other_user}","gists_url":"https://api.github.com/users/apereo/gists{/gist_id}","starred_url":"https://api.github.com/users/apereo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apereo/subscriptions","organizations_url":"https://api.github.com/users/apereo/orgs","repos_url":"https://api.github.com/users/apereo/repos","events_url":"https://api.github.com/users/apereo/events{/privacy}","received_events_url":"https://api.github.com/users/apereo/received_events","type":"Organization","site_admin":false},"repo":{"id":2352744,"name":"cas","full_name":"apereo/cas","owner":{"login":"apereo","id":4679233,"avatar_url":"https://avatars0.githubusercontent.com/u/4679233?v=3","gravatar_id":"","url":"https://api.github.com/users/apereo","html_url":"https://github.com/apereo","followers_url":"https://api.github.com/users/apereo/followers","following_url":"https://api.github.com/users/apereo/following{/other_user}","gists_url":"https://api.github.com/users/apereo/gists{/gist_id}","starred_url":"https://api.github.com/users/apereo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apereo/subscriptions","organizations_url":"https://api.github.com/users/apereo/orgs","repos_url":"https://api.github.com/users/apereo/repos","events_url":"https://api.github.com/users/apereo/events{/privacy}","received_events_url":"https://api.github.com/users/apereo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apereo/cas","description":"Apereo CAS - Enterprise Single Sign On for all earthlings and beyond.","fork":false,"url":"https://api.github.com/repos/apereo/cas","forks_url":"https://api.github.com/repos/apereo/cas/forks","keys_url":"https://api.github.com/repos/apereo/cas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apereo/cas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apereo/cas/teams","hooks_url":"https://api.github.com/repos/apereo/cas/hooks","issue_events_url":"https://api.github.com/repos/apereo/cas/issues/events{/number}","events_url":"https://api.github.com/repos/apereo/cas/events","assignees_url":"https://api.github.com/repos/apereo/cas/assignees{/user}","branches_url":"https://api.github.com/repos/apereo/cas/branches{/branch}","tags_url":"https://api.github.com/repos/apereo/cas/tags","blobs_url":"https://api.github.com/repos/apereo/cas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apereo/cas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apereo/cas/git/refs{/sha}","trees_url":"https://api.github.com/repos/apereo/cas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apereo/cas/statuses/{sha}","languages_url":"https://api.github.com/repos/apereo/cas/languages","stargazers_url":"https://api.github.com/repos/apereo/cas/stargazers","contributors_url":"https://api.github.com/repos/apereo/cas/contributors","subscribers_url":"https://api.github.com/repos/apereo/cas/subscribers","subscription_url":"https://api.github.com/repos/apereo/cas/subscription","commits_url":"https://api.github.com/repos/apereo/cas/commits{/sha}","git_commits_url":"https://api.github.com/repos/apereo/cas/git/commits{/sha}","comments_url":"https://api.github.com/repos/apereo/cas/comments{/number}","issue_comment_url":"https://api.github.com/repos/apereo/cas/issues/comments{/number}","contents_url":"https://api.github.com/repos/apereo/cas/contents/{+path}","compare_url":"https://api.github.com/repos/apereo/cas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apereo/cas/merges","archive_url":"https://api.github.com/repos/apereo/cas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apereo/cas/downloads","issues_url":"https://api.github.com/repos/apereo/cas/issues{/number}","pulls_url":"https://api.github.com/repos/apereo/cas/pulls{/number}","milestones_url":"https://api.github.com/repos/apereo/cas/milestones{/number}","notifications_url":"https://api.github.com/repos/apereo/cas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apereo/cas/labels{/name}","releases_url":"https://api.github.com/repos/apereo/cas/releases{/id}","deployments_url":"https://api.github.com/repos/apereo/cas/deployments","created_at":"2011-09-09T01:36:42Z","updated_at":"2017-03-14T09:10:42Z","pushed_at":"2017-03-14T13:26:35Z","git_url":"git://github.com/apereo/cas.git","ssh_url":"git@github.com:apereo/cas.git","clone_url":"https://github.com/apereo/cas.git","svn_url":"https://github.com/apereo/cas","homepage":"https://apereo.github.io/cas/","size":1303592,"stargazers_count":2330,"watchers_count":2330,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1421,"mirror_url":null,"open_issues_count":12,"forks":1421,"open_issues":12,"watchers":2330,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apereo/cas/pulls/2452"},"html":{"href":"https://github.com/apereo/cas/pull/2452"},"issue":{"href":"https://api.github.com/repos/apereo/cas/issues/2452"},"comments":{"href":"https://api.github.com/repos/apereo/cas/issues/2452/comments"},"review_comments":{"href":"https://api.github.com/repos/apereo/cas/pulls/2452/comments"},"review_comment":{"href":"https://api.github.com/repos/apereo/cas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apereo/cas/pulls/2452/commits"},"statuses":{"href":"https://api.github.com/repos/apereo/cas/statuses/591d3ed808b452f2570b2462fe2614caa847f077"}}}}
{"actor":{"display_login":"fedon"}}