{"action":"created","comment":{"url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls/comments/118039997","pull_request_review_id":39796163,"id":118039997,"diff_hunk":"@@ -29,6 +29,7 @@\n import org.springframework.context.annotation.Configuration;\n import org.springframework.context.annotation.Import;\n import org.springframework.jdbc.core.namedparam.NamedParameterJdbcTemplate;\n+import org.springframework.scheduling.annotation.Scheduled;","path":"nakadi-producer-spring-boot-starter/src/main/java/org/zalando/nakadiproducer/NakadiProducerAutoConfiguration.java","position":null,"original_position":4,"commit_id":"5ba13f10fe36192d7cdd0d1c82b6d6440a34bcaf","original_commit_id":"5ba13f10fe36192d7cdd0d1c82b6d6440a34bcaf","user":{"login":"ePaul","id":645859,"avatar_url":"https://avatars2.githubusercontent.com/u/645859?v=3","gravatar_id":"","url":"https://api.github.com/users/ePaul","html_url":"https://github.com/ePaul","followers_url":"https://api.github.com/users/ePaul/followers","following_url":"https://api.github.com/users/ePaul/following{/other_user}","gists_url":"https://api.github.com/users/ePaul/gists{/gist_id}","starred_url":"https://api.github.com/users/ePaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ePaul/subscriptions","organizations_url":"https://api.github.com/users/ePaul/orgs","repos_url":"https://api.github.com/users/ePaul/repos","events_url":"https://api.github.com/users/ePaul/events{/privacy}","received_events_url":"https://api.github.com/users/ePaul/received_events","type":"User","site_admin":false},"body":"I guess this import can now go away?","created_at":"2017-05-23T16:26:08Z","updated_at":"2017-05-23T16:26:08Z","html_url":"https://github.com/zalando-incubator/nakadi-producer-spring-boot-starter/pull/33#discussion_r118039997","pull_request_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls/comments/118039997"},"html":{"href":"https://github.com/zalando-incubator/nakadi-producer-spring-boot-starter/pull/33#discussion_r118039997"},"pull_request":{"href":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls/33","id":121781160,"html_url":"https://github.com/zalando-incubator/nakadi-producer-spring-boot-starter/pull/33","diff_url":"https://github.com/zalando-incubator/nakadi-producer-spring-boot-starter/pull/33.diff","patch_url":"https://github.com/zalando-incubator/nakadi-producer-spring-boot-starter/pull/33.patch","issue_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/issues/33","number":33,"state":"open","locked":false,"title":"#23 Support using the library in a non-springboot project","user":{"login":"BGehrels","id":1008320,"avatar_url":"https://avatars3.githubusercontent.com/u/1008320?v=3","gravatar_id":"","url":"https://api.github.com/users/BGehrels","html_url":"https://github.com/BGehrels","followers_url":"https://api.github.com/users/BGehrels/followers","following_url":"https://api.github.com/users/BGehrels/following{/other_user}","gists_url":"https://api.github.com/users/BGehrels/gists{/gist_id}","starred_url":"https://api.github.com/users/BGehrels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BGehrels/subscriptions","organizations_url":"https://api.github.com/users/BGehrels/orgs","repos_url":"https://api.github.com/users/BGehrels/repos","events_url":"https://api.github.com/users/BGehrels/events{/privacy}","received_events_url":"https://api.github.com/users/BGehrels/received_events","type":"User","site_admin":false},"body":"Splitted the project in three maven modules:\r\n* one core library (`nakadi-producer`) without any spring or third party tool dependency (which contains the core algorithms and a set of interfaces which can be implemented by using projects),\r\n* one spring boot starter (`nakadi-producer-spring-boot-starter`, which adds autoconfiguration, DB setup and access, etc.) and\r\n* a reactor POM which just references both.\r\n\r\nThis will allow to use the core library in non-springboot projects (for #23), but it needs some manual configuration there. We will document this later (in a separate PR) when we have tried it in some internal projects.\r\n\r\nIt will also allow easier testing of the spring-boot-starter in test projects with different dependency configurations (in later PRs).","created_at":"2017-05-22T13:46:35Z","updated_at":"2017-05-23T16:26:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae17a90e35cdf8c4ef2fed44cd774397178723c2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls/33/commits","review_comments_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls/33/comments","review_comment_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/issues/33/comments","statuses_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/statuses/5ba13f10fe36192d7cdd0d1c82b6d6440a34bcaf","head":{"label":"zalando-incubator:fix-docs","ref":"fix-docs","sha":"5ba13f10fe36192d7cdd0d1c82b6d6440a34bcaf","user":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars0.githubusercontent.com/u/18533786?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":90135592,"name":"nakadi-producer-spring-boot-starter","full_name":"zalando-incubator/nakadi-producer-spring-boot-starter","owner":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars0.githubusercontent.com/u/18533786?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-incubator/nakadi-producer-spring-boot-starter","description":"Nakadi event producer as a Spring boot starter","fork":false,"url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter","forks_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/forks","keys_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/teams","hooks_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/hooks","issue_events_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/events","assignees_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/tags","blobs_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/languages","stargazers_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/stargazers","contributors_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/contributors","subscribers_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/subscribers","subscription_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/subscription","commits_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/merges","archive_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/downloads","issues_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/labels{/name}","releases_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/deployments","created_at":"2017-05-03T10:09:49Z","updated_at":"2017-05-10T13:11:35Z","pushed_at":"2017-05-23T15:36:31Z","git_url":"git://github.com/zalando-incubator/nakadi-producer-spring-boot-starter.git","ssh_url":"git@github.com:zalando-incubator/nakadi-producer-spring-boot-starter.git","clone_url":"https://github.com/zalando-incubator/nakadi-producer-spring-boot-starter.git","svn_url":"https://github.com/zalando-incubator/nakadi-producer-spring-boot-starter","homepage":"","size":307,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"zalando-incubator:master","ref":"master","sha":"2f9ce03d0fde28198146beace68384c3c9a23f7d","user":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars0.githubusercontent.com/u/18533786?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":90135592,"name":"nakadi-producer-spring-boot-starter","full_name":"zalando-incubator/nakadi-producer-spring-boot-starter","owner":{"login":"zalando-incubator","id":18533786,"avatar_url":"https://avatars0.githubusercontent.com/u/18533786?v=3","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-incubator/nakadi-producer-spring-boot-starter","description":"Nakadi event producer as a Spring boot starter","fork":false,"url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter","forks_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/forks","keys_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/teams","hooks_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/hooks","issue_events_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/events","assignees_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/tags","blobs_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/languages","stargazers_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/stargazers","contributors_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/contributors","subscribers_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/subscribers","subscription_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/subscription","commits_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/merges","archive_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/downloads","issues_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/labels{/name}","releases_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/deployments","created_at":"2017-05-03T10:09:49Z","updated_at":"2017-05-10T13:11:35Z","pushed_at":"2017-05-23T15:36:31Z","git_url":"git://github.com/zalando-incubator/nakadi-producer-spring-boot-starter.git","ssh_url":"git@github.com:zalando-incubator/nakadi-producer-spring-boot-starter.git","clone_url":"https://github.com/zalando-incubator/nakadi-producer-spring-boot-starter.git","svn_url":"https://github.com/zalando-incubator/nakadi-producer-spring-boot-starter","homepage":"","size":307,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls/33"},"html":{"href":"https://github.com/zalando-incubator/nakadi-producer-spring-boot-starter/pull/33"},"issue":{"href":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/issues/33"},"comments":{"href":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-incubator/nakadi-producer-spring-boot-starter/statuses/5ba13f10fe36192d7cdd0d1c82b6d6440a34bcaf"}}}}
{"actor":{"display_login":"ePaul"}}