{"action":"created","comment":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/110896472","pull_request_review_id":32098409,"id":110896472,"diff_hunk":"@@ -56,38 +56,36 @@\n  * camera partially spoils the effect showing its limits.\n  */\n public class RefractiveReflectiveBlocksNode extends AbstractNode implements FBOManagerSubscriber {\n-    public static final ResourceUrn REFRACTIVE_REFLECTIVE = new ResourceUrn(\"engine:sceneReflectiveRefractive\");\n-    private static final ResourceUrn CHUNK_SHADER = new ResourceUrn(\"engine:prog.chunk\");\n+    public static final ResourceUrn REFRACTIVE_REFLECTIVE_FBO = new ResourceUrn(\"engine:sceneReflectiveRefractive\");\n+    private static final ResourceUrn CHUNK_MATERIAL = new ResourceUrn(\"engine:prog.chunk\");\n \n-    @In\n     private RenderQueuesHelper renderQueues;\n-\n-    @In\n     private WorldRenderer worldRenderer;\n-\n-    @In\n     private DisplayResolutionDependentFBOs displayResolutionDependentFBOs;\n \n     private Camera playerCamera;\n-    private Material chunkShader;\n+    private Material chunkMaterial;\n+\n+    @SuppressWarnings(\"FieldCanBeLocal\")\n     private FBO readOnlyGBufferFbo;\n+    @SuppressWarnings(\"FieldCanBeLocal\")\n     private FBO refractiveReflectiveFbo;\n \n-    /**\n-     * Initialises the node. -Must- be called once after instantiation.\n-     */\n-    @Override\n-    public void initialise() {\n+    public RefractiveReflectiveBlocksNode(Context context) {\n+        renderQueues = context.get(RenderQueuesHelper.class);\n+        worldRenderer = context.get(WorldRenderer.class);","path":"engine/src/main/java/org/terasology/rendering/dag/nodes/RefractiveReflectiveBlocksNode.java","position":45,"original_position":45,"commit_id":"69ec342103c927361490d83210e3d2ec2b0b67f0","original_commit_id":"69ec342103c927361490d83210e3d2ec2b0b67f0","user":{"login":"emanuele3d","id":6934584,"avatar_url":"https://avatars0.githubusercontent.com/u/6934584?v=3","gravatar_id":"","url":"https://api.github.com/users/emanuele3d","html_url":"https://github.com/emanuele3d","followers_url":"https://api.github.com/users/emanuele3d/followers","following_url":"https://api.github.com/users/emanuele3d/following{/other_user}","gists_url":"https://api.github.com/users/emanuele3d/gists{/gist_id}","starred_url":"https://api.github.com/users/emanuele3d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanuele3d/subscriptions","organizations_url":"https://api.github.com/users/emanuele3d/orgs","repos_url":"https://api.github.com/users/emanuele3d/repos","events_url":"https://api.github.com/users/emanuele3d/events{/privacy}","received_events_url":"https://api.github.com/users/emanuele3d/received_events","type":"User","site_admin":false},"body":"This line can go with the playerCamera line below.\r\nThe following line can go closer to the block starting with the requiresFBO line.","created_at":"2017-04-11T13:07:30Z","updated_at":"2017-04-11T13:24:42Z","html_url":"https://github.com/MovingBlocks/Terasology/pull/2892#discussion_r110896472","pull_request_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2892","_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments/110896472"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2892#discussion_r110896472"},"pull_request":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2892"}}},"pull_request":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2892","id":114979682,"html_url":"https://github.com/MovingBlocks/Terasology/pull/2892","diff_url":"https://github.com/MovingBlocks/Terasology/pull/2892.diff","patch_url":"https://github.com/MovingBlocks/Terasology/pull/2892.patch","issue_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2892","number":2892,"state":"open","locked":false,"title":"Remove NodeFactory","user":{"login":"vampcat","id":18019423,"avatar_url":"https://avatars1.githubusercontent.com/u/18019423?v=3","gravatar_id":"","url":"https://api.github.com/users/vampcat","html_url":"https://github.com/vampcat","followers_url":"https://api.github.com/users/vampcat/followers","following_url":"https://api.github.com/users/vampcat/following{/other_user}","gists_url":"https://api.github.com/users/vampcat/gists{/gist_id}","starred_url":"https://api.github.com/users/vampcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vampcat/subscriptions","organizations_url":"https://api.github.com/users/vampcat/orgs","repos_url":"https://api.github.com/users/vampcat/repos","events_url":"https://api.github.com/users/vampcat/events{/privacy}","received_events_url":"https://api.github.com/users/vampcat/received_events","type":"User","site_admin":false},"body":"Yet another Rendering Pipeline Refactoring PR.\r\n\r\nChanges:\r\n- Removes the NodeFactory class (and the corresponding injection used by it) for the creation of Nodes.\r\n- Remves the redundant getMaterial(String) function from EnableMaterial StateChange (replacing it with AbstractNode::getMaterial(ResourceUrn)), making the getMaterial calls more uniform\r\n- Renames variables in Nodes and StateChanges to be more descriptive.","created_at":"2017-04-09T09:37:19Z","updated_at":"2017-04-11T13:24:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aedd297f68912f1d464b7e603e6feb6a2034e17a","assignee":{"login":"vampcat","id":18019423,"avatar_url":"https://avatars1.githubusercontent.com/u/18019423?v=3","gravatar_id":"","url":"https://api.github.com/users/vampcat","html_url":"https://github.com/vampcat","followers_url":"https://api.github.com/users/vampcat/followers","following_url":"https://api.github.com/users/vampcat/following{/other_user}","gists_url":"https://api.github.com/users/vampcat/gists{/gist_id}","starred_url":"https://api.github.com/users/vampcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vampcat/subscriptions","organizations_url":"https://api.github.com/users/vampcat/orgs","repos_url":"https://api.github.com/users/vampcat/repos","events_url":"https://api.github.com/users/vampcat/events{/privacy}","received_events_url":"https://api.github.com/users/vampcat/received_events","type":"User","site_admin":false},"assignees":[{"login":"vampcat","id":18019423,"avatar_url":"https://avatars1.githubusercontent.com/u/18019423?v=3","gravatar_id":"","url":"https://api.github.com/users/vampcat","html_url":"https://github.com/vampcat","followers_url":"https://api.github.com/users/vampcat/followers","following_url":"https://api.github.com/users/vampcat/following{/other_user}","gists_url":"https://api.github.com/users/vampcat/gists{/gist_id}","starred_url":"https://api.github.com/users/vampcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vampcat/subscriptions","organizations_url":"https://api.github.com/users/vampcat/orgs","repos_url":"https://api.github.com/users/vampcat/repos","events_url":"https://api.github.com/users/vampcat/events{/privacy}","received_events_url":"https://api.github.com/users/vampcat/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2892/commits","review_comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2892/comments","review_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2892/comments","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/69ec342103c927361490d83210e3d2ec2b0b67f0","head":{"label":"vampcat:nodeFactoryRemoval","ref":"nodeFactoryRemoval","sha":"69ec342103c927361490d83210e3d2ec2b0b67f0","user":{"login":"vampcat","id":18019423,"avatar_url":"https://avatars1.githubusercontent.com/u/18019423?v=3","gravatar_id":"","url":"https://api.github.com/users/vampcat","html_url":"https://github.com/vampcat","followers_url":"https://api.github.com/users/vampcat/followers","following_url":"https://api.github.com/users/vampcat/following{/other_user}","gists_url":"https://api.github.com/users/vampcat/gists{/gist_id}","starred_url":"https://api.github.com/users/vampcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vampcat/subscriptions","organizations_url":"https://api.github.com/users/vampcat/orgs","repos_url":"https://api.github.com/users/vampcat/repos","events_url":"https://api.github.com/users/vampcat/events{/privacy}","received_events_url":"https://api.github.com/users/vampcat/received_events","type":"User","site_admin":false},"repo":{"id":84166907,"name":"Terasology","full_name":"vampcat/Terasology","owner":{"login":"vampcat","id":18019423,"avatar_url":"https://avatars1.githubusercontent.com/u/18019423?v=3","gravatar_id":"","url":"https://api.github.com/users/vampcat","html_url":"https://github.com/vampcat","followers_url":"https://api.github.com/users/vampcat/followers","following_url":"https://api.github.com/users/vampcat/following{/other_user}","gists_url":"https://api.github.com/users/vampcat/gists{/gist_id}","starred_url":"https://api.github.com/users/vampcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vampcat/subscriptions","organizations_url":"https://api.github.com/users/vampcat/orgs","repos_url":"https://api.github.com/users/vampcat/repos","events_url":"https://api.github.com/users/vampcat/events{/privacy}","received_events_url":"https://api.github.com/users/vampcat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vampcat/Terasology","description":"Terasology - open source voxel world","fork":true,"url":"https://api.github.com/repos/vampcat/Terasology","forks_url":"https://api.github.com/repos/vampcat/Terasology/forks","keys_url":"https://api.github.com/repos/vampcat/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vampcat/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vampcat/Terasology/teams","hooks_url":"https://api.github.com/repos/vampcat/Terasology/hooks","issue_events_url":"https://api.github.com/repos/vampcat/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/vampcat/Terasology/events","assignees_url":"https://api.github.com/repos/vampcat/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/vampcat/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/vampcat/Terasology/tags","blobs_url":"https://api.github.com/repos/vampcat/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vampcat/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vampcat/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/vampcat/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vampcat/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/vampcat/Terasology/languages","stargazers_url":"https://api.github.com/repos/vampcat/Terasology/stargazers","contributors_url":"https://api.github.com/repos/vampcat/Terasology/contributors","subscribers_url":"https://api.github.com/repos/vampcat/Terasology/subscribers","subscription_url":"https://api.github.com/repos/vampcat/Terasology/subscription","commits_url":"https://api.github.com/repos/vampcat/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/vampcat/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/vampcat/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/vampcat/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/vampcat/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/vampcat/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vampcat/Terasology/merges","archive_url":"https://api.github.com/repos/vampcat/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vampcat/Terasology/downloads","issues_url":"https://api.github.com/repos/vampcat/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/vampcat/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/vampcat/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/vampcat/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vampcat/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/vampcat/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/vampcat/Terasology/deployments","created_at":"2017-03-07T07:11:20Z","updated_at":"2017-03-07T07:11:27Z","pushed_at":"2017-04-11T11:32:17Z","git_url":"git://github.com/vampcat/Terasology.git","ssh_url":"git@github.com:vampcat/Terasology.git","clone_url":"https://github.com/vampcat/Terasology.git","svn_url":"https://github.com/vampcat/Terasology","homepage":"http://terasology.org","size":278457,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"MovingBlocks:develop","ref":"develop","sha":"366ab7098d42464e92aa4adb47d8ca035616b835","user":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars2.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"repo":{"id":1438007,"name":"Terasology","full_name":"MovingBlocks/Terasology","owner":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars2.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MovingBlocks/Terasology","description":"Terasology - open source voxel world","fork":false,"url":"https://api.github.com/repos/MovingBlocks/Terasology","forks_url":"https://api.github.com/repos/MovingBlocks/Terasology/forks","keys_url":"https://api.github.com/repos/MovingBlocks/Terasology/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MovingBlocks/Terasology/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MovingBlocks/Terasology/teams","hooks_url":"https://api.github.com/repos/MovingBlocks/Terasology/hooks","issue_events_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/events{/number}","events_url":"https://api.github.com/repos/MovingBlocks/Terasology/events","assignees_url":"https://api.github.com/repos/MovingBlocks/Terasology/assignees{/user}","branches_url":"https://api.github.com/repos/MovingBlocks/Terasology/branches{/branch}","tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/tags","blobs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/refs{/sha}","trees_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/{sha}","languages_url":"https://api.github.com/repos/MovingBlocks/Terasology/languages","stargazers_url":"https://api.github.com/repos/MovingBlocks/Terasology/stargazers","contributors_url":"https://api.github.com/repos/MovingBlocks/Terasology/contributors","subscribers_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscribers","subscription_url":"https://api.github.com/repos/MovingBlocks/Terasology/subscription","commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/commits{/sha}","git_commits_url":"https://api.github.com/repos/MovingBlocks/Terasology/git/commits{/sha}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/comments{/number}","issue_comment_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/comments{/number}","contents_url":"https://api.github.com/repos/MovingBlocks/Terasology/contents/{+path}","compare_url":"https://api.github.com/repos/MovingBlocks/Terasology/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MovingBlocks/Terasology/merges","archive_url":"https://api.github.com/repos/MovingBlocks/Terasology/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MovingBlocks/Terasology/downloads","issues_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues{/number}","pulls_url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls{/number}","milestones_url":"https://api.github.com/repos/MovingBlocks/Terasology/milestones{/number}","notifications_url":"https://api.github.com/repos/MovingBlocks/Terasology/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MovingBlocks/Terasology/labels{/name}","releases_url":"https://api.github.com/repos/MovingBlocks/Terasology/releases{/id}","deployments_url":"https://api.github.com/repos/MovingBlocks/Terasology/deployments","created_at":"2011-03-04T03:49:19Z","updated_at":"2017-04-11T10:24:59Z","pushed_at":"2017-04-11T11:32:20Z","git_url":"git://github.com/MovingBlocks/Terasology.git","ssh_url":"git@github.com:MovingBlocks/Terasology.git","clone_url":"https://github.com/MovingBlocks/Terasology.git","svn_url":"https://github.com/MovingBlocks/Terasology","homepage":"http://terasology.org","size":278289,"stargazers_count":1961,"watchers_count":1961,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":874,"mirror_url":null,"open_issues_count":373,"forks":874,"open_issues":373,"watchers":1961,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2892"},"html":{"href":"https://github.com/MovingBlocks/Terasology/pull/2892"},"issue":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2892"},"comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/issues/2892/comments"},"review_comments":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2892/comments"},"review_comment":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/2892/commits"},"statuses":{"href":"https://api.github.com/repos/MovingBlocks/Terasology/statuses/69ec342103c927361490d83210e3d2ec2b0b67f0"}}}}
{"actor":{"display_login":"emanuele3d"}}