{"action":"created","issue":{"url":"https://api.github.com/repos/xamarin/java.interop/issues/169","repository_url":"https://api.github.com/repos/xamarin/java.interop","labels_url":"https://api.github.com/repos/xamarin/java.interop/issues/169/labels{/name}","comments_url":"https://api.github.com/repos/xamarin/java.interop/issues/169/comments","events_url":"https://api.github.com/repos/xamarin/java.interop/issues/169/events","html_url":"https://github.com/xamarin/java.interop/pull/169","id":240264137,"number":169,"title":"bump cecil to get scope start fix","user":{"login":"radekdoulik","id":4147484,"avatar_url":"https://avatars4.githubusercontent.com/u/4147484?v=4","gravatar_id":"","url":"https://api.github.com/users/radekdoulik","html_url":"https://github.com/radekdoulik","followers_url":"https://api.github.com/users/radekdoulik/followers","following_url":"https://api.github.com/users/radekdoulik/following{/other_user}","gists_url":"https://api.github.com/users/radekdoulik/gists{/gist_id}","starred_url":"https://api.github.com/users/radekdoulik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radekdoulik/subscriptions","organizations_url":"https://api.github.com/users/radekdoulik/orgs","repos_url":"https://api.github.com/users/radekdoulik/repos","events_url":"https://api.github.com/users/radekdoulik/events{/privacy}","received_events_url":"https://api.github.com/users/radekdoulik/received_events","type":"User","site_admin":false},"labels":[{"id":370111797,"url":"https://api.github.com/repos/xamarin/java.interop/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-03T21:01:27Z","updated_at":"2017-07-15T19:11:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xamarin/java.interop/pulls/169","html_url":"https://github.com/xamarin/java.interop/pull/169","diff_url":"https://github.com/xamarin/java.interop/pull/169.diff","patch_url":"https://github.com/xamarin/java.interop/pull/169.patch"},"body":"    commit 82a2fe15984df2b697c42b2fef5ccc17370007e3\r\n    Author: Radek Doulik <rodo@xamarin.com>\r\n    Date:   Mon Jul 3 22:41:43 2017 +0200\r\n\r\n        do not set scope.Start when start_instruction is null\r\n\r\n         - this gets us to the original state how scope start was handled\r\n           before\r\n           https://github.com/jbevain/cecil/commit/7c8e0f767d7b2f652a430e4e26f1d98a20f9e125\r\n\r\n         - fixes #57889\r\n\r\n         - without this change we get excpetion when writing mdb like this:\r\n\r\n            The \"LinkAssemblies\" task failed unexpectedly. [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n            System.NotSupportedException: Specified method is not supported. [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.Cil.InstructionOffset.get_Offset() [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.Mdb.MdbWriter.WriteScope(ScopeDebugInformation scope, MethodDebugInformation info) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.Mdb.MdbWriter.WriteScopes(Collection`1 scopes, MethodDebugInformation info) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.Mdb.MdbWriter.WriteScope(ScopeDebugInformation scope, MethodDebugInformation info) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.Mdb.MdbWriter.WriteScopes(Collection`1 scopes, MethodDebugInformation info) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.Mdb.MdbWriter.WriteRootScope(ScopeDebugInformation scope, MethodDebugInformation info) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.Mdb.MdbWriter.Write(MethodDebugInformation info) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.Cil.CodeWriter.WriteResolvedMethodBody(MethodDefinition method) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.Cil.CodeWriter.WriteMethodBody(MethodDefinition method) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.MetadataBuilder.AddMethod(MethodDefinition method) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.MetadataBuilder.AddMethods(TypeDefinition type) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.MetadataBuilder.AddType(TypeDefinition type) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.MetadataBuilder.AddTypes() [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.MetadataBuilder.BuildTypes() [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.MetadataBuilder.BuildModule() [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.MetadataBuilder.BuildMetadata() [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.ModuleWriter.<>c.b__2_0(MetadataBuilder builder, MetadataReader _) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.ModuleDefinition.Read[TItem,TRet](TItem item, Func`3 read) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.ModuleWriter.BuildMetadata(ModuleDefinition module, MetadataBuilder metadata) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.ModuleWriter.Write(ModuleDefinition module, Disposable`1 stream, WriterParameters parameters) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.ModuleWriter.WriteModule(ModuleDefinition module, Disposable`1 stream, WriterParameters parameters) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Cecil.ModuleDefinition.Write(String fileName, WriterParameters parameters) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Linker.Steps.OutputStep.OutputAssembly(AssemblyDefinition assembly) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               at Mono.Linker.Steps.OutputStep.ProcessAssembly(AssemblyDefinition assembly) [C:\\xms\\xamarin-forms-samples\\Templates\\DataTemplateSelector\\Droid\\Selector.Droid.csproj]\r\n               ..."},"comment":{"url":"https://api.github.com/repos/xamarin/java.interop/issues/comments/315555594","html_url":"https://github.com/xamarin/java.interop/pull/169#issuecomment-315555594","issue_url":"https://api.github.com/repos/xamarin/java.interop/issues/169","id":315555594,"user":{"login":"jonpryor","id":155958,"avatar_url":"https://avatars7.githubusercontent.com/u/155958?v=4","gravatar_id":"","url":"https://api.github.com/users/jonpryor","html_url":"https://github.com/jonpryor","followers_url":"https://api.github.com/users/jonpryor/followers","following_url":"https://api.github.com/users/jonpryor/following{/other_user}","gists_url":"https://api.github.com/users/jonpryor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpryor/subscriptions","organizations_url":"https://api.github.com/users/jonpryor/orgs","repos_url":"https://api.github.com/users/jonpryor/repos","events_url":"https://api.github.com/users/jonpryor/events{/privacy}","received_events_url":"https://api.github.com/users/jonpryor/received_events","type":"User","site_admin":false},"created_at":"2017-07-15T19:11:50Z","updated_at":"2017-07-15T19:11:50Z","body":"After my week of (bad) explorations...\r\n\r\nI don't think we want Cecil to deal with broken mdb's, but that's jbevain's call.\r\n\r\nThe more \"interesting\" thing is that  we shouldn't be asking Cecil to deal with broken mdbs in the first place. Bug #57889 is an exception from the `<LinkAssemblies/>` task, and the `<LinkAssemblies/>` task *should not be loading debug symbols*:\r\n\r\n<https://github.com/xamarin/xamarin-android/blob/4b00475/src/Xamarin.Android.Build.Tasks/Tasks/LinkAssemblies.cs#L88>\r\n\r\nThus, the \"real\" question: Why is the `<LinkAssemblies/>` task loading debug symbols when it's explicitly asking to *not* load debug symbols? If it never loaded the debug symbols, we wouldn't *care* if the debug symbols were corrupted.\r\n\r\nThe problem here is the loading of debug symbols *at all*, not Cecil."}}
{"actor":{"display_login":"jonpryor"}}