{"action":"created","issue":{"url":"https://api.github.com/repos/lede-project/source/issues/1401","repository_url":"https://api.github.com/repos/lede-project/source","labels_url":"https://api.github.com/repos/lede-project/source/issues/1401/labels{/name}","comments_url":"https://api.github.com/repos/lede-project/source/issues/1401/comments","events_url":"https://api.github.com/repos/lede-project/source/issues/1401/events","html_url":"https://github.com/lede-project/source/pull/1401","id":263382811,"number":1401,"title":"ramips: revised reset button gpios for Omnima Mini Linux boards","user":{"login":"omnima","id":1441202,"avatar_url":"https://avatars2.githubusercontent.com/u/1441202?v=4","gravatar_id":"","url":"https://api.github.com/users/omnima","html_url":"https://github.com/omnima","followers_url":"https://api.github.com/users/omnima/followers","following_url":"https://api.github.com/users/omnima/following{/other_user}","gists_url":"https://api.github.com/users/omnima/gists{/gist_id}","starred_url":"https://api.github.com/users/omnima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omnima/subscriptions","organizations_url":"https://api.github.com/users/omnima/orgs","repos_url":"https://api.github.com/users/omnima/repos","events_url":"https://api.github.com/users/omnima/events{/privacy}","received_events_url":"https://api.github.com/users/omnima/received_events","type":"User","site_admin":false},"labels":[{"id":556289239,"url":"https://api.github.com/repos/lede-project/source/labels/needs%20changes","name":"needs changes","color":"D92626","default":false},{"id":556303760,"url":"https://api.github.com/repos/lede-project/source/labels/ramips","name":"ramips","color":"267FD9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-06T09:16:57Z","updated_at":"2017-10-11T07:40:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/lede-project/source/pulls/1401","html_url":"https://github.com/lede-project/source/pull/1401","diff_url":"https://github.com/lede-project/source/pull/1401.diff","patch_url":"https://github.com/lede-project/source/pull/1401.patch"},"body":"Revised Reset button GPIO, also fixed linux,code = <KEY_RESTART> line.\r\nRemoved wps, mode-one and mode-two gpio definitions so that these can be used as general purpose i/o lines."},"comment":{"url":"https://api.github.com/repos/lede-project/source/issues/comments/335713419","html_url":"https://github.com/lede-project/source/pull/1401#issuecomment-335713419","issue_url":"https://api.github.com/repos/lede-project/source/issues/1401","id":335713419,"user":{"login":"mkresin","id":4547948,"avatar_url":"https://avatars0.githubusercontent.com/u/4547948?v=4","gravatar_id":"","url":"https://api.github.com/users/mkresin","html_url":"https://github.com/mkresin","followers_url":"https://api.github.com/users/mkresin/followers","following_url":"https://api.github.com/users/mkresin/following{/other_user}","gists_url":"https://api.github.com/users/mkresin/gists{/gist_id}","starred_url":"https://api.github.com/users/mkresin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkresin/subscriptions","organizations_url":"https://api.github.com/users/mkresin/orgs","repos_url":"https://api.github.com/users/mkresin/repos","events_url":"https://api.github.com/users/mkresin/events{/privacy}","received_events_url":"https://api.github.com/users/mkresin/received_events","type":"User","site_admin":false},"created_at":"2017-10-11T07:40:51Z","updated_at":"2017-10-11T07:40:51Z","author_association":"OWNER","body":"> Adding support for multiple revisions is likely to increase the time needed for LEDE devs to maintain all the variants when including new or revised features for an entire platform so we tried to keep to just one revision in LEDE/OpenWrt so far.\r\n\r\nYeah makes perfect sense to me.\r\n\r\nI'm still a bit concerned about changing the reset gpio for existing boards. But as far as I understand, Omnima does not build off the shelf products, no one runs a plain LEDE on your boards and it is rather that LEDE is used as a framework that needs to be customised anyway.\r\n\r\nIn the end it is up to you to decide what is the best for your boards/customers.\r\n\r\n> We use a company wide github account, but for future PR's can create inidividual logins.\r\n\r\nIt is fine to use a single GItHub account. Just make sure to fix the author setting for your local git client, so that a realname is used in From line + SoB and both are identical. Have a look at the PR [as patch file](https://github.com/lede-project/source/pull/1401.patch) to see what I'm talking about.\r\n\r\nI've merged your PR to [my staging tree](https://git.lede-project.org/?p=lede/mkresin/staging.git;a=summary), squashed the commits into a single one, fixed the author/form and slightly rewrote the commit message.\r\n\r\nPlease ACK the changes or update this PR with the version you would like to see committed."}}
{"actor":{"display_login":"mkresin"}}