{"action":"created","comment":{"url":"https://api.github.com/repos/lyft/envoy/pulls/comments/101399985","pull_request_review_id":22127957,"id":101399985,"diff_hunk":"@@ -6,6 +6,19 @@\n \n namespace Tracing {\n \n+/**\n+ * Transport tracing context.\n+ * It's used to set proper parent/child span relationship on Envoy calls, e.g., ratelimit call.\n+ */\n+struct TransportContext {","path":"include/envoy/tracing/http_tracer.h","position":8,"original_position":8,"commit_id":"db499c6fb349004e43d4aef0fd61d91040ade01d","original_commit_id":"db499c6fb349004e43d4aef0fd61d91040ade01d","user":{"login":"mattklein123","id":6305260,"avatar_url":"https://avatars.githubusercontent.com/u/6305260?v=3","gravatar_id":"","url":"https://api.github.com/users/mattklein123","html_url":"https://github.com/mattklein123","followers_url":"https://api.github.com/users/mattklein123/followers","following_url":"https://api.github.com/users/mattklein123/following{/other_user}","gists_url":"https://api.github.com/users/mattklein123/gists{/gist_id}","starred_url":"https://api.github.com/users/mattklein123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattklein123/subscriptions","organizations_url":"https://api.github.com/users/mattklein123/orgs","repos_url":"https://api.github.com/users/mattklein123/repos","events_url":"https://api.github.com/users/mattklein123/events{/privacy}","received_events_url":"https://api.github.com/users/mattklein123/received_events","type":"User","site_admin":false},"body":"this should go in a header not called http_tracer.h","created_at":"2017-02-15T22:29:15Z","updated_at":"2017-02-15T22:30:42Z","html_url":"https://github.com/lyft/envoy/pull/486#discussion_r101399985","pull_request_url":"https://api.github.com/repos/lyft/envoy/pulls/486","_links":{"self":{"href":"https://api.github.com/repos/lyft/envoy/pulls/comments/101399985"},"html":{"href":"https://github.com/lyft/envoy/pull/486#discussion_r101399985"},"pull_request":{"href":"https://api.github.com/repos/lyft/envoy/pulls/486"}}},"pull_request":{"url":"https://api.github.com/repos/lyft/envoy/pulls/486","id":106242624,"html_url":"https://github.com/lyft/envoy/pull/486","diff_url":"https://github.com/lyft/envoy/pull/486.diff","patch_url":"https://github.com/lyft/envoy/pull/486.patch","issue_url":"https://api.github.com/repos/lyft/envoy/issues/486","number":486,"state":"open","locked":false,"title":"Tracing: allow proper tracing for ratelimit calls from Envoy","user":{"login":"RomanDzhabarov","id":15094284,"avatar_url":"https://avatars.githubusercontent.com/u/15094284?v=3","gravatar_id":"","url":"https://api.github.com/users/RomanDzhabarov","html_url":"https://github.com/RomanDzhabarov","followers_url":"https://api.github.com/users/RomanDzhabarov/followers","following_url":"https://api.github.com/users/RomanDzhabarov/following{/other_user}","gists_url":"https://api.github.com/users/RomanDzhabarov/gists{/gist_id}","starred_url":"https://api.github.com/users/RomanDzhabarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RomanDzhabarov/subscriptions","organizations_url":"https://api.github.com/users/RomanDzhabarov/orgs","repos_url":"https://api.github.com/users/RomanDzhabarov/repos","events_url":"https://api.github.com/users/RomanDzhabarov/events{/privacy}","received_events_url":"https://api.github.com/users/RomanDzhabarov/received_events","type":"User","site_admin":false},"body":"@lyft/network-team \r\n\r\nThis is to propagate x-ot-span-context on calls to ratelimit, so ingress Envoy on ratelimit service can set proper parent for the span.","created_at":"2017-02-15T04:48:27Z","updated_at":"2017-02-15T22:30:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5803b740f650af6bcb6e807996d6c35791f791b1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lyft/envoy/pulls/486/commits","review_comments_url":"https://api.github.com/repos/lyft/envoy/pulls/486/comments","review_comment_url":"https://api.github.com/repos/lyft/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lyft/envoy/issues/486/comments","statuses_url":"https://api.github.com/repos/lyft/envoy/statuses/db499c6fb349004e43d4aef0fd61d91040ade01d","head":{"label":"lyft:rate_limit_header","ref":"rate_limit_header","sha":"db499c6fb349004e43d4aef0fd61d91040ade01d","user":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"lyft/envoy","owner":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/lyft/envoy","forks_url":"https://api.github.com/repos/lyft/envoy/forks","keys_url":"https://api.github.com/repos/lyft/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/envoy/teams","hooks_url":"https://api.github.com/repos/lyft/envoy/hooks","issue_events_url":"https://api.github.com/repos/lyft/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/envoy/events","assignees_url":"https://api.github.com/repos/lyft/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/envoy/tags","blobs_url":"https://api.github.com/repos/lyft/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/envoy/languages","stargazers_url":"https://api.github.com/repos/lyft/envoy/stargazers","contributors_url":"https://api.github.com/repos/lyft/envoy/contributors","subscribers_url":"https://api.github.com/repos/lyft/envoy/subscribers","subscription_url":"https://api.github.com/repos/lyft/envoy/subscription","commits_url":"https://api.github.com/repos/lyft/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/envoy/merges","archive_url":"https://api.github.com/repos/lyft/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/envoy/downloads","issues_url":"https://api.github.com/repos/lyft/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/envoy/labels{/name}","releases_url":"https://api.github.com/repos/lyft/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2017-02-15T21:45:25Z","pushed_at":"2017-02-15T22:10:47Z","git_url":"git://github.com/lyft/envoy.git","ssh_url":"git@github.com:lyft/envoy.git","clone_url":"https://github.com/lyft/envoy.git","svn_url":"https://github.com/lyft/envoy","homepage":"https://lyft.github.io/envoy","size":7273,"stargazers_count":749,"watchers_count":749,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":59,"forks":71,"open_issues":59,"watchers":749,"default_branch":"master"}},"base":{"label":"lyft:master","ref":"master","sha":"3b2c9271cbf518db2649919c9fe457815de888d5","user":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"lyft/envoy","owner":{"login":"lyft","id":4269340,"avatar_url":"https://avatars.githubusercontent.com/u/4269340?v=3","gravatar_id":"","url":"https://api.github.com/users/lyft","html_url":"https://github.com/lyft","followers_url":"https://api.github.com/users/lyft/followers","following_url":"https://api.github.com/users/lyft/following{/other_user}","gists_url":"https://api.github.com/users/lyft/gists{/gist_id}","starred_url":"https://api.github.com/users/lyft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyft/subscriptions","organizations_url":"https://api.github.com/users/lyft/orgs","repos_url":"https://api.github.com/users/lyft/repos","events_url":"https://api.github.com/users/lyft/events{/privacy}","received_events_url":"https://api.github.com/users/lyft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lyft/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/lyft/envoy","forks_url":"https://api.github.com/repos/lyft/envoy/forks","keys_url":"https://api.github.com/repos/lyft/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyft/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyft/envoy/teams","hooks_url":"https://api.github.com/repos/lyft/envoy/hooks","issue_events_url":"https://api.github.com/repos/lyft/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/lyft/envoy/events","assignees_url":"https://api.github.com/repos/lyft/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/lyft/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/lyft/envoy/tags","blobs_url":"https://api.github.com/repos/lyft/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyft/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyft/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyft/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyft/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/lyft/envoy/languages","stargazers_url":"https://api.github.com/repos/lyft/envoy/stargazers","contributors_url":"https://api.github.com/repos/lyft/envoy/contributors","subscribers_url":"https://api.github.com/repos/lyft/envoy/subscribers","subscription_url":"https://api.github.com/repos/lyft/envoy/subscription","commits_url":"https://api.github.com/repos/lyft/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyft/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyft/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyft/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyft/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/lyft/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyft/envoy/merges","archive_url":"https://api.github.com/repos/lyft/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyft/envoy/downloads","issues_url":"https://api.github.com/repos/lyft/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/lyft/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/lyft/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/lyft/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyft/envoy/labels{/name}","releases_url":"https://api.github.com/repos/lyft/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/lyft/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2017-02-15T21:45:25Z","pushed_at":"2017-02-15T22:10:47Z","git_url":"git://github.com/lyft/envoy.git","ssh_url":"git@github.com:lyft/envoy.git","clone_url":"https://github.com/lyft/envoy.git","svn_url":"https://github.com/lyft/envoy","homepage":"https://lyft.github.io/envoy","size":7273,"stargazers_count":749,"watchers_count":749,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":59,"forks":71,"open_issues":59,"watchers":749,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lyft/envoy/pulls/486"},"html":{"href":"https://github.com/lyft/envoy/pull/486"},"issue":{"href":"https://api.github.com/repos/lyft/envoy/issues/486"},"comments":{"href":"https://api.github.com/repos/lyft/envoy/issues/486/comments"},"review_comments":{"href":"https://api.github.com/repos/lyft/envoy/pulls/486/comments"},"review_comment":{"href":"https://api.github.com/repos/lyft/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lyft/envoy/pulls/486/commits"},"statuses":{"href":"https://api.github.com/repos/lyft/envoy/statuses/db499c6fb349004e43d4aef0fd61d91040ade01d"}}}}
{"actor":{"display_login":"mattklein123"}}