{"action":"created","comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/124402280","pull_request_review_id":46687747,"id":124402280,"diff_hunk":"@@ -1,14 +1,16 @@\n <%@ tag description=\"instructorFeedbacks and instructorHome - Feedback Session publish/unpublish button\" %>\n <%@ taglib uri=\"http://java.sun.com/jsp/jstl/core\" prefix=\"c\" %>\n <%@ attribute name=\"publishButton\" type=\"teammates.ui.template.FeedbackSessionPublishButton\" required=\"true\" %>\n-<%@ attribute name=\"buttonType\" required=\"true\" %>\n-<a class=\"btn ${buttonType} btn-tm-actions session-${publishButton.actionNameLowercase}-for-test\"\n-   href=\"${publishButton.actionLink}\"\n-   title=\"${publishButton.tooltipText}\"\n-   data-toggle=\"tooltip\"\n-   data-placement=\"top\"\n-   data-fsname=\"${publishButton.feedbackSessionName}\"\n+<%@ attribute name=\"showTooltip\" type=\"java.lang.Boolean\" required=\"true\" %>\n+<%@ attribute name=\"buttonType\" %>\n+<a href=\"${publishButton.actionLink}\"\n+   class=\"<c:if test=\"${not empty buttonType}\">${buttonType} </c:if>session-${publishButton.actionNameLowercase}-for-test\"\n+   <c:if test=\"${showTooltip}\">\n+     title=\"${publishButton.tooltipText}\"\n+     data-toggle=\"tooltip\"\n+     data-placement=\"top\"\n+   </c:if>\n    data-sending-published-email=\"${publishButton.sendingPublishedEmail}\"\n-   <c:if test=\"${not publishButton.actionAllowed}\">disabled</c:if>>","path":"src/main/webapp/WEB-INF/tags/instructor/feedbacks/feedbackSessionPublishButton.tag","position":21,"original_position":21,"commit_id":"4397867f39c9e5bae20d187ef26c914d8d125362","original_commit_id":"4397867f39c9e5bae20d187ef26c914d8d125362","user":{"login":"amarlearning","id":9383897,"avatar_url":"https://avatars2.githubusercontent.com/u/9383897?v=3","gravatar_id":"","url":"https://api.github.com/users/amarlearning","html_url":"https://github.com/amarlearning","followers_url":"https://api.github.com/users/amarlearning/followers","following_url":"https://api.github.com/users/amarlearning/following{/other_user}","gists_url":"https://api.github.com/users/amarlearning/gists{/gist_id}","starred_url":"https://api.github.com/users/amarlearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarlearning/subscriptions","organizations_url":"https://api.github.com/users/amarlearning/orgs","repos_url":"https://api.github.com/users/amarlearning/repos","events_url":"https://api.github.com/users/amarlearning/events{/privacy}","received_events_url":"https://api.github.com/users/amarlearning/received_events","type":"User","site_admin":false},"body":"Done. Adding the test related to this.","created_at":"2017-06-27T21:34:54Z","updated_at":"2017-06-27T21:34:54Z","html_url":"https://github.com/TEAMMATES/teammates/pull/7312#discussion_r124402280","pull_request_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7312","_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments/124402280"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/7312#discussion_r124402280"},"pull_request":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7312"}}},"pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7312","id":120908479,"html_url":"https://github.com/TEAMMATES/teammates/pull/7312","diff_url":"https://github.com/TEAMMATES/teammates/pull/7312.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/7312.patch","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/7312","number":7312,"state":"open","locked":false,"title":"Instructor: home page: combine 'view results' and 'publish results' buttons #7294","user":{"login":"amarlearning","id":9383897,"avatar_url":"https://avatars2.githubusercontent.com/u/9383897?v=3","gravatar_id":"","url":"https://api.github.com/users/amarlearning","html_url":"https://github.com/amarlearning","followers_url":"https://api.github.com/users/amarlearning/followers","following_url":"https://api.github.com/users/amarlearning/following{/other_user}","gists_url":"https://api.github.com/users/amarlearning/gists{/gist_id}","starred_url":"https://api.github.com/users/amarlearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarlearning/subscriptions","organizations_url":"https://api.github.com/users/amarlearning/orgs","repos_url":"https://api.github.com/users/amarlearning/repos","events_url":"https://api.github.com/users/amarlearning/events{/privacy}","received_events_url":"https://api.github.com/users/amarlearning/received_events","type":"User","site_admin":false},"body":"Fixes #7294\r\n \r\nCombined the two buttons as suggested by @damithc  (similar to the Remind button):\r\n`Results`\r\n`-View`\r\n`-Publish`\r\n![Image](https://cloud.githubusercontent.com/assets/1673303/26024006/2d2f729c-37fb-11e7-809b-aeb82e638e17.png)\r\n\r\nscreenshot of the updated UI\r\n![screenshot from 2017-05-13 22-54-18](https://cloud.githubusercontent.com/assets/9383897/26027722/88ae2b06-3830-11e7-9b07-7b804b43d03f.png)\r\n","created_at":"2017-05-16T19:37:45Z","updated_at":"2017-06-27T21:34:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50d7d925d29a41da636dc574eb0765cf903723ed","assignee":{"login":"leeyimin","id":6365864,"avatar_url":"https://avatars0.githubusercontent.com/u/6365864?v=3","gravatar_id":"","url":"https://api.github.com/users/leeyimin","html_url":"https://github.com/leeyimin","followers_url":"https://api.github.com/users/leeyimin/followers","following_url":"https://api.github.com/users/leeyimin/following{/other_user}","gists_url":"https://api.github.com/users/leeyimin/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyimin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyimin/subscriptions","organizations_url":"https://api.github.com/users/leeyimin/orgs","repos_url":"https://api.github.com/users/leeyimin/repos","events_url":"https://api.github.com/users/leeyimin/events{/privacy}","received_events_url":"https://api.github.com/users/leeyimin/received_events","type":"User","site_admin":false},"assignees":[{"login":"leeyimin","id":6365864,"avatar_url":"https://avatars0.githubusercontent.com/u/6365864?v=3","gravatar_id":"","url":"https://api.github.com/users/leeyimin","html_url":"https://github.com/leeyimin","followers_url":"https://api.github.com/users/leeyimin/followers","following_url":"https://api.github.com/users/leeyimin/following{/other_user}","gists_url":"https://api.github.com/users/leeyimin/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyimin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyimin/subscriptions","organizations_url":"https://api.github.com/users/leeyimin/orgs","repos_url":"https://api.github.com/users/leeyimin/repos","events_url":"https://api.github.com/users/leeyimin/events{/privacy}","received_events_url":"https://api.github.com/users/leeyimin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7312/commits","review_comments_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7312/comments","review_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/7312/comments","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/4397867f39c9e5bae20d187ef26c914d8d125362","head":{"label":"amarlearning:combining-buttons","ref":"combining-buttons","sha":"4397867f39c9e5bae20d187ef26c914d8d125362","user":{"login":"amarlearning","id":9383897,"avatar_url":"https://avatars2.githubusercontent.com/u/9383897?v=3","gravatar_id":"","url":"https://api.github.com/users/amarlearning","html_url":"https://github.com/amarlearning","followers_url":"https://api.github.com/users/amarlearning/followers","following_url":"https://api.github.com/users/amarlearning/following{/other_user}","gists_url":"https://api.github.com/users/amarlearning/gists{/gist_id}","starred_url":"https://api.github.com/users/amarlearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarlearning/subscriptions","organizations_url":"https://api.github.com/users/amarlearning/orgs","repos_url":"https://api.github.com/users/amarlearning/repos","events_url":"https://api.github.com/users/amarlearning/events{/privacy}","received_events_url":"https://api.github.com/users/amarlearning/received_events","type":"User","site_admin":false},"repo":{"id":85325446,"name":"teammates","full_name":"amarlearning/teammates","owner":{"login":"amarlearning","id":9383897,"avatar_url":"https://avatars2.githubusercontent.com/u/9383897?v=3","gravatar_id":"","url":"https://api.github.com/users/amarlearning","html_url":"https://github.com/amarlearning","followers_url":"https://api.github.com/users/amarlearning/followers","following_url":"https://api.github.com/users/amarlearning/following{/other_user}","gists_url":"https://api.github.com/users/amarlearning/gists{/gist_id}","starred_url":"https://api.github.com/users/amarlearning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amarlearning/subscriptions","organizations_url":"https://api.github.com/users/amarlearning/orgs","repos_url":"https://api.github.com/users/amarlearning/repos","events_url":"https://api.github.com/users/amarlearning/events{/privacy}","received_events_url":"https://api.github.com/users/amarlearning/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amarlearning/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":true,"url":"https://api.github.com/repos/amarlearning/teammates","forks_url":"https://api.github.com/repos/amarlearning/teammates/forks","keys_url":"https://api.github.com/repos/amarlearning/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amarlearning/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amarlearning/teammates/teams","hooks_url":"https://api.github.com/repos/amarlearning/teammates/hooks","issue_events_url":"https://api.github.com/repos/amarlearning/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/amarlearning/teammates/events","assignees_url":"https://api.github.com/repos/amarlearning/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/amarlearning/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/amarlearning/teammates/tags","blobs_url":"https://api.github.com/repos/amarlearning/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amarlearning/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amarlearning/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/amarlearning/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amarlearning/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/amarlearning/teammates/languages","stargazers_url":"https://api.github.com/repos/amarlearning/teammates/stargazers","contributors_url":"https://api.github.com/repos/amarlearning/teammates/contributors","subscribers_url":"https://api.github.com/repos/amarlearning/teammates/subscribers","subscription_url":"https://api.github.com/repos/amarlearning/teammates/subscription","commits_url":"https://api.github.com/repos/amarlearning/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/amarlearning/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/amarlearning/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/amarlearning/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/amarlearning/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/amarlearning/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amarlearning/teammates/merges","archive_url":"https://api.github.com/repos/amarlearning/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amarlearning/teammates/downloads","issues_url":"https://api.github.com/repos/amarlearning/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/amarlearning/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/amarlearning/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/amarlearning/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amarlearning/teammates/labels{/name}","releases_url":"https://api.github.com/repos/amarlearning/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/amarlearning/teammates/deployments","created_at":"2017-03-17T15:14:24Z","updated_at":"2017-03-17T15:14:30Z","pushed_at":"2017-06-27T06:00:27Z","git_url":"git://github.com/amarlearning/teammates.git","ssh_url":"git@github.com:amarlearning/teammates.git","clone_url":"https://github.com/amarlearning/teammates.git","svn_url":"https://github.com/amarlearning/teammates","homepage":"http://teammatesv4.appspot.com/","size":187163,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TEAMMATES:master","ref":"master","sha":"ee7f18f3908d06da9ba1ca32964a09d1ebaa58d3","user":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars1.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"repo":{"id":19369035,"name":"teammates","full_name":"TEAMMATES/teammates","owner":{"login":"TEAMMATES","id":7374810,"avatar_url":"https://avatars1.githubusercontent.com/u/7374810?v=3","gravatar_id":"","url":"https://api.github.com/users/TEAMMATES","html_url":"https://github.com/TEAMMATES","followers_url":"https://api.github.com/users/TEAMMATES/followers","following_url":"https://api.github.com/users/TEAMMATES/following{/other_user}","gists_url":"https://api.github.com/users/TEAMMATES/gists{/gist_id}","starred_url":"https://api.github.com/users/TEAMMATES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TEAMMATES/subscriptions","organizations_url":"https://api.github.com/users/TEAMMATES/orgs","repos_url":"https://api.github.com/users/TEAMMATES/repos","events_url":"https://api.github.com/users/TEAMMATES/events{/privacy}","received_events_url":"https://api.github.com/users/TEAMMATES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TEAMMATES/teammates","description":"This is the project website for the TEAMMATES feedback management tool for education","fork":false,"url":"https://api.github.com/repos/TEAMMATES/teammates","forks_url":"https://api.github.com/repos/TEAMMATES/teammates/forks","keys_url":"https://api.github.com/repos/TEAMMATES/teammates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TEAMMATES/teammates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TEAMMATES/teammates/teams","hooks_url":"https://api.github.com/repos/TEAMMATES/teammates/hooks","issue_events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/events{/number}","events_url":"https://api.github.com/repos/TEAMMATES/teammates/events","assignees_url":"https://api.github.com/repos/TEAMMATES/teammates/assignees{/user}","branches_url":"https://api.github.com/repos/TEAMMATES/teammates/branches{/branch}","tags_url":"https://api.github.com/repos/TEAMMATES/teammates/tags","blobs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TEAMMATES/teammates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TEAMMATES/teammates/git/refs{/sha}","trees_url":"https://api.github.com/repos/TEAMMATES/teammates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TEAMMATES/teammates/statuses/{sha}","languages_url":"https://api.github.com/repos/TEAMMATES/teammates/languages","stargazers_url":"https://api.github.com/repos/TEAMMATES/teammates/stargazers","contributors_url":"https://api.github.com/repos/TEAMMATES/teammates/contributors","subscribers_url":"https://api.github.com/repos/TEAMMATES/teammates/subscribers","subscription_url":"https://api.github.com/repos/TEAMMATES/teammates/subscription","commits_url":"https://api.github.com/repos/TEAMMATES/teammates/commits{/sha}","git_commits_url":"https://api.github.com/repos/TEAMMATES/teammates/git/commits{/sha}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/comments{/number}","issue_comment_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments{/number}","contents_url":"https://api.github.com/repos/TEAMMATES/teammates/contents/{+path}","compare_url":"https://api.github.com/repos/TEAMMATES/teammates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TEAMMATES/teammates/merges","archive_url":"https://api.github.com/repos/TEAMMATES/teammates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TEAMMATES/teammates/downloads","issues_url":"https://api.github.com/repos/TEAMMATES/teammates/issues{/number}","pulls_url":"https://api.github.com/repos/TEAMMATES/teammates/pulls{/number}","milestones_url":"https://api.github.com/repos/TEAMMATES/teammates/milestones{/number}","notifications_url":"https://api.github.com/repos/TEAMMATES/teammates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/labels{/name}","releases_url":"https://api.github.com/repos/TEAMMATES/teammates/releases{/id}","deployments_url":"https://api.github.com/repos/TEAMMATES/teammates/deployments","created_at":"2014-05-02T07:43:00Z","updated_at":"2017-06-27T20:33:39Z","pushed_at":"2017-06-27T21:14:35Z","git_url":"git://github.com/TEAMMATES/teammates.git","ssh_url":"git@github.com:TEAMMATES/teammates.git","clone_url":"https://github.com/TEAMMATES/teammates.git","svn_url":"https://github.com/TEAMMATES/teammates","homepage":"https://teammatesv4.appspot.com/","size":188105,"stargazers_count":365,"watchers_count":365,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":836,"mirror_url":null,"open_issues_count":303,"forks":836,"open_issues":303,"watchers":365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7312"},"html":{"href":"https://github.com/TEAMMATES/teammates/pull/7312"},"issue":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/7312"},"comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/issues/7312/comments"},"review_comments":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7312/comments"},"review_comment":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TEAMMATES/teammates/pulls/7312/commits"},"statuses":{"href":"https://api.github.com/repos/TEAMMATES/teammates/statuses/4397867f39c9e5bae20d187ef26c914d8d125362"}}}}
{"actor":{"display_login":"amarlearning"}}