{"action":"created","comment":{"url":"https://api.github.com/repos/Ada-C7/BankAccounts/pulls/comments/103322098","pull_request_review_id":24103331,"id":103322098,"diff_hunk":"@@ -0,0 +1,42 @@\n+require_relative 'account'\n+\n+module Bank\n+  class CheckingAccount< Account\n+    attr_accessor :id, :balance","path":"lib/checking_account.rb","position":5,"original_position":5,"commit_id":"7fd11a9f81ed70ba8e94c53e8b63788d2a5c7e50","original_commit_id":"7fd11a9f81ed70ba8e94c53e8b63788d2a5c7e50","user":{"login":"droberts-ada","id":21064499,"avatar_url":"https://avatars.githubusercontent.com/u/21064499?v=3","gravatar_id":"","url":"https://api.github.com/users/droberts-ada","html_url":"https://github.com/droberts-ada","followers_url":"https://api.github.com/users/droberts-ada/followers","following_url":"https://api.github.com/users/droberts-ada/following{/other_user}","gists_url":"https://api.github.com/users/droberts-ada/gists{/gist_id}","starred_url":"https://api.github.com/users/droberts-ada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droberts-ada/subscriptions","organizations_url":"https://api.github.com/users/droberts-ada/orgs","repos_url":"https://api.github.com/users/droberts-ada/repos","events_url":"https://api.github.com/users/droberts-ada/events{/privacy}","received_events_url":"https://api.github.com/users/droberts-ada/received_events","type":"User","site_admin":false},"body":"Turns out the `attr_accessor` methods are one of the things we get for free via inheritance, so this line is not needed.","created_at":"2017-02-27T21:53:53Z","updated_at":"2017-02-27T21:58:44Z","html_url":"https://github.com/Ada-C7/BankAccounts/pull/45#discussion_r103322098","pull_request_url":"https://api.github.com/repos/Ada-C7/BankAccounts/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/Ada-C7/BankAccounts/pulls/comments/103322098"},"html":{"href":"https://github.com/Ada-C7/BankAccounts/pull/45#discussion_r103322098"},"pull_request":{"href":"https://api.github.com/repos/Ada-C7/BankAccounts/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/Ada-C7/BankAccounts/pulls/45","id":108162709,"html_url":"https://github.com/Ada-C7/BankAccounts/pull/45","diff_url":"https://github.com/Ada-C7/BankAccounts/pull/45.diff","patch_url":"https://github.com/Ada-C7/BankAccounts/pull/45.patch","issue_url":"https://api.github.com/repos/Ada-C7/BankAccounts/issues/45","number":45,"state":"open","locked":false,"title":"Queues - Marisol Lopez - BankAccounts","user":{"login":"marisol-lopez","id":21980315,"avatar_url":"https://avatars.githubusercontent.com/u/21980315?v=3","gravatar_id":"","url":"https://api.github.com/users/marisol-lopez","html_url":"https://github.com/marisol-lopez","followers_url":"https://api.github.com/users/marisol-lopez/followers","following_url":"https://api.github.com/users/marisol-lopez/following{/other_user}","gists_url":"https://api.github.com/users/marisol-lopez/gists{/gist_id}","starred_url":"https://api.github.com/users/marisol-lopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marisol-lopez/subscriptions","organizations_url":"https://api.github.com/users/marisol-lopez/orgs","repos_url":"https://api.github.com/users/marisol-lopez/repos","events_url":"https://api.github.com/users/marisol-lopez/events{/privacy}","received_events_url":"https://api.github.com/users/marisol-lopez/received_events","type":"User","site_admin":false},"body":"# Bank Account\r\nCongratulations! You're submitting your assignment.\r\n\r\n## Comprehension Questions\r\n\r\n|  Question \t|   Answer\t|\r\n|---\t|---\t|\r\n|   Why is it useful to put classes inside modules?  What do you think?\t|   Modules provide  the ability to use the functionality of other classes and methods without having name confliction.\t|\r\n|   What is accomplished with `raise ArgumentError`?  What do you think it's doing?\t|   I think that I'm telling my code to look out for this specific possible error, and then if it happens, it'll let raise the error to alert.\t|\r\n|   Why do you think we made the `.all` & `.find` methods class methods?  Why not instance methods?\t|   Because we'd be able to access the different methods without having to create instances of the class\t|\r\n|   Why does it make sense to use inheritance for the different types of accounts?  | because you can use the functionality of the parent class without having to rewrite all of the code. |  \r\n|   Did the presence of automated tests change the way you thought about the problem? How? | Yes, I think it forced me to be more concise/focused in what I wanted each block of code to accomplish|\r\n","created_at":"2017-02-27T17:27:58Z","updated_at":"2017-02-27T21:58:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adec60c29cabe04970fb638c5b0cfc124d56f522","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ada-C7/BankAccounts/pulls/45/commits","review_comments_url":"https://api.github.com/repos/Ada-C7/BankAccounts/pulls/45/comments","review_comment_url":"https://api.github.com/repos/Ada-C7/BankAccounts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ada-C7/BankAccounts/issues/45/comments","statuses_url":"https://api.github.com/repos/Ada-C7/BankAccounts/statuses/7fd11a9f81ed70ba8e94c53e8b63788d2a5c7e50","head":{"label":"marisol-lopez:master","ref":"master","sha":"7fd11a9f81ed70ba8e94c53e8b63788d2a5c7e50","user":{"login":"marisol-lopez","id":21980315,"avatar_url":"https://avatars.githubusercontent.com/u/21980315?v=3","gravatar_id":"","url":"https://api.github.com/users/marisol-lopez","html_url":"https://github.com/marisol-lopez","followers_url":"https://api.github.com/users/marisol-lopez/followers","following_url":"https://api.github.com/users/marisol-lopez/following{/other_user}","gists_url":"https://api.github.com/users/marisol-lopez/gists{/gist_id}","starred_url":"https://api.github.com/users/marisol-lopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marisol-lopez/subscriptions","organizations_url":"https://api.github.com/users/marisol-lopez/orgs","repos_url":"https://api.github.com/users/marisol-lopez/repos","events_url":"https://api.github.com/users/marisol-lopez/events{/privacy}","received_events_url":"https://api.github.com/users/marisol-lopez/received_events","type":"User","site_admin":false},"repo":{"id":82741383,"name":"BankAccounts","full_name":"marisol-lopez/BankAccounts","owner":{"login":"marisol-lopez","id":21980315,"avatar_url":"https://avatars.githubusercontent.com/u/21980315?v=3","gravatar_id":"","url":"https://api.github.com/users/marisol-lopez","html_url":"https://github.com/marisol-lopez","followers_url":"https://api.github.com/users/marisol-lopez/followers","following_url":"https://api.github.com/users/marisol-lopez/following{/other_user}","gists_url":"https://api.github.com/users/marisol-lopez/gists{/gist_id}","starred_url":"https://api.github.com/users/marisol-lopez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marisol-lopez/subscriptions","organizations_url":"https://api.github.com/users/marisol-lopez/orgs","repos_url":"https://api.github.com/users/marisol-lopez/repos","events_url":"https://api.github.com/users/marisol-lopez/events{/privacy}","received_events_url":"https://api.github.com/users/marisol-lopez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marisol-lopez/BankAccounts","description":null,"fork":true,"url":"https://api.github.com/repos/marisol-lopez/BankAccounts","forks_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/forks","keys_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/teams","hooks_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/hooks","issue_events_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/issues/events{/number}","events_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/events","assignees_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/assignees{/user}","branches_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/branches{/branch}","tags_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/tags","blobs_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/git/refs{/sha}","trees_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/statuses/{sha}","languages_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/languages","stargazers_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/stargazers","contributors_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/contributors","subscribers_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/subscribers","subscription_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/subscription","commits_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/commits{/sha}","git_commits_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/git/commits{/sha}","comments_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/comments{/number}","issue_comment_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/issues/comments{/number}","contents_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/contents/{+path}","compare_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/merges","archive_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/downloads","issues_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/issues{/number}","pulls_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/pulls{/number}","milestones_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/milestones{/number}","notifications_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/labels{/name}","releases_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/releases{/id}","deployments_url":"https://api.github.com/repos/marisol-lopez/BankAccounts/deployments","created_at":"2017-02-22T00:22:10Z","updated_at":"2017-02-22T00:22:12Z","pushed_at":"2017-02-27T16:59:17Z","git_url":"git://github.com/marisol-lopez/BankAccounts.git","ssh_url":"git@github.com:marisol-lopez/BankAccounts.git","clone_url":"https://github.com/marisol-lopez/BankAccounts.git","svn_url":"https://github.com/marisol-lopez/BankAccounts","homepage":null,"size":34,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ada-C7:master","ref":"master","sha":"d7f99da90d7cf45c18a21873456608986bdb916f","user":{"login":"Ada-C7","id":24881334,"avatar_url":"https://avatars.githubusercontent.com/u/24881334?v=3","gravatar_id":"","url":"https://api.github.com/users/Ada-C7","html_url":"https://github.com/Ada-C7","followers_url":"https://api.github.com/users/Ada-C7/followers","following_url":"https://api.github.com/users/Ada-C7/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C7/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C7/subscriptions","organizations_url":"https://api.github.com/users/Ada-C7/orgs","repos_url":"https://api.github.com/users/Ada-C7/repos","events_url":"https://api.github.com/users/Ada-C7/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C7/received_events","type":"Organization","site_admin":false},"repo":{"id":81849636,"name":"BankAccounts","full_name":"Ada-C7/BankAccounts","owner":{"login":"Ada-C7","id":24881334,"avatar_url":"https://avatars.githubusercontent.com/u/24881334?v=3","gravatar_id":"","url":"https://api.github.com/users/Ada-C7","html_url":"https://github.com/Ada-C7","followers_url":"https://api.github.com/users/Ada-C7/followers","following_url":"https://api.github.com/users/Ada-C7/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C7/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C7/subscriptions","organizations_url":"https://api.github.com/users/Ada-C7/orgs","repos_url":"https://api.github.com/users/Ada-C7/repos","events_url":"https://api.github.com/users/Ada-C7/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ada-C7/BankAccounts","description":null,"fork":true,"url":"https://api.github.com/repos/Ada-C7/BankAccounts","forks_url":"https://api.github.com/repos/Ada-C7/BankAccounts/forks","keys_url":"https://api.github.com/repos/Ada-C7/BankAccounts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ada-C7/BankAccounts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ada-C7/BankAccounts/teams","hooks_url":"https://api.github.com/repos/Ada-C7/BankAccounts/hooks","issue_events_url":"https://api.github.com/repos/Ada-C7/BankAccounts/issues/events{/number}","events_url":"https://api.github.com/repos/Ada-C7/BankAccounts/events","assignees_url":"https://api.github.com/repos/Ada-C7/BankAccounts/assignees{/user}","branches_url":"https://api.github.com/repos/Ada-C7/BankAccounts/branches{/branch}","tags_url":"https://api.github.com/repos/Ada-C7/BankAccounts/tags","blobs_url":"https://api.github.com/repos/Ada-C7/BankAccounts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ada-C7/BankAccounts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ada-C7/BankAccounts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ada-C7/BankAccounts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ada-C7/BankAccounts/statuses/{sha}","languages_url":"https://api.github.com/repos/Ada-C7/BankAccounts/languages","stargazers_url":"https://api.github.com/repos/Ada-C7/BankAccounts/stargazers","contributors_url":"https://api.github.com/repos/Ada-C7/BankAccounts/contributors","subscribers_url":"https://api.github.com/repos/Ada-C7/BankAccounts/subscribers","subscription_url":"https://api.github.com/repos/Ada-C7/BankAccounts/subscription","commits_url":"https://api.github.com/repos/Ada-C7/BankAccounts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ada-C7/BankAccounts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ada-C7/BankAccounts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ada-C7/BankAccounts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ada-C7/BankAccounts/contents/{+path}","compare_url":"https://api.github.com/repos/Ada-C7/BankAccounts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ada-C7/BankAccounts/merges","archive_url":"https://api.github.com/repos/Ada-C7/BankAccounts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ada-C7/BankAccounts/downloads","issues_url":"https://api.github.com/repos/Ada-C7/BankAccounts/issues{/number}","pulls_url":"https://api.github.com/repos/Ada-C7/BankAccounts/pulls{/number}","milestones_url":"https://api.github.com/repos/Ada-C7/BankAccounts/milestones{/number}","notifications_url":"https://api.github.com/repos/Ada-C7/BankAccounts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ada-C7/BankAccounts/labels{/name}","releases_url":"https://api.github.com/repos/Ada-C7/BankAccounts/releases{/id}","deployments_url":"https://api.github.com/repos/Ada-C7/BankAccounts/deployments","created_at":"2017-02-13T17:05:15Z","updated_at":"2017-02-15T22:45:38Z","pushed_at":"2017-02-27T21:58:03Z","git_url":"git://github.com/Ada-C7/BankAccounts.git","ssh_url":"git@github.com:Ada-C7/BankAccounts.git","clone_url":"https://github.com/Ada-C7/BankAccounts.git","svn_url":"https://github.com/Ada-C7/BankAccounts","homepage":null,"size":30,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"open_issues_count":47,"forks":51,"open_issues":47,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ada-C7/BankAccounts/pulls/45"},"html":{"href":"https://github.com/Ada-C7/BankAccounts/pull/45"},"issue":{"href":"https://api.github.com/repos/Ada-C7/BankAccounts/issues/45"},"comments":{"href":"https://api.github.com/repos/Ada-C7/BankAccounts/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/Ada-C7/BankAccounts/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/Ada-C7/BankAccounts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ada-C7/BankAccounts/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/Ada-C7/BankAccounts/statuses/7fd11a9f81ed70ba8e94c53e8b63788d2a5c7e50"}}}}
{"actor":{"display_login":"droberts-ada"}}