{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54013","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54013/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54013/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54013/events","html_url":"https://github.com/kubernetes/kubernetes/pull/54013","id":265919258,"number":54013,"title":"ScaleIO - Ability to specify Secret's name and namespace ","user":{"login":"vladimirvivien","id":309126,"avatar_url":"https://avatars0.githubusercontent.com/u/309126?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimirvivien","html_url":"https://github.com/vladimirvivien","followers_url":"https://api.github.com/users/vladimirvivien/followers","following_url":"https://api.github.com/users/vladimirvivien/following{/other_user}","gists_url":"https://api.github.com/users/vladimirvivien/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimirvivien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimirvivien/subscriptions","organizations_url":"https://api.github.com/users/vladimirvivien/orgs","repos_url":"https://api.github.com/users/vladimirvivien/repos","events_url":"https://api.github.com/users/vladimirvivien/events{/privacy}","received_events_url":"https://api.github.com/users/vladimirvivien/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":169428334,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253451057,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"state":"open","locked":false,"assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"assignees":[{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},{"login":"rootfs","id":7062400,"avatar_url":"https://avatars0.githubusercontent.com/u/7062400?v=4","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"milestone":null,"comments":17,"created_at":"2017-10-16T21:16:13Z","updated_at":"2017-10-26T03:15:15Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/54013","html_url":"https://github.com/kubernetes/kubernetes/pull/54013","diff_url":"https://github.com/kubernetes/kubernetes/pull/54013.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/54013.patch"},"body":"**What this PR does / why we need it**:\r\nThis PR is to decouple the ScaleIO secret from the same namespace as that of the StorageClass/PVC/PV that uses it (#53619). Currently, authorized non-admin k8s user, who creates volumes, may end up having unauthorized access to ScaleIO secret information.  This PR introduces secret parameter that allows specification of secret's namespace.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #53619 \r\n\r\n**Release note**:\r\n```release-note\r\nScaleIO persistent volumes now support referencing a secret in a namespace other than the bound persistent volume claim's namespace; StoragePool and ProtectionDomain attributes no longer defaults to values default\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/339538579","html_url":"https://github.com/kubernetes/kubernetes/pull/54013#issuecomment-339538579","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/54013","id":339538579,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars0.githubusercontent.com/u/13653959?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2017-10-26T03:15:15Z","updated_at":"2017-10-26T03:15:15Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/54013#issuecomment-339538469\" title=\"LGTM\">liggitt</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/54013#\" title=\"Author self-approved\">vladimirvivien</a>*\nWe suggest the following additional approver: **smarterclayton**\n\nAssign the PR to them by writing `/assign @smarterclayton` in a comment when ready.\n\nAssociated issue: *53619*\n\nThe full list of commands accepted by this bot can be found [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n\n<details open>\nNeeds approval from an approver in each of these OWNERS Files:\n\n- ~~[api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/api/OWNERS)~~ [liggitt]\n- **[docs/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/docs/OWNERS)**\n- **[federation/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/federation/OWNERS)**\n- ~~[pkg/api/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/api/OWNERS)~~ [liggitt]\n- ~~[pkg/printers/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/printers/OWNERS)~~ [liggitt]\n- **[pkg/volume/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/OWNERS)**\n- ~~[staging/src/k8s.io/api/core/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/core/OWNERS)~~ [liggitt]\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"smarterclayton\"]} -->"}}
{"actor":{"display_login":"k8s-merge-robot"}}