{"action":"created","issue":{"url":"https://api.github.com/repos/devinteske/apple/issues/1","repository_url":"https://api.github.com/repos/devinteske/apple","labels_url":"https://api.github.com/repos/devinteske/apple/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/devinteske/apple/issues/1/comments","events_url":"https://api.github.com/repos/devinteske/apple/issues/1/events","html_url":"https://github.com/devinteske/apple/issues/1","id":32759865,"number":1,"title":"No ability to confirm use of key before signing","user":{"login":"petiepooo","id":1916012,"avatar_url":"https://avatars.githubusercontent.com/u/1916012?v=3","gravatar_id":"","url":"https://api.github.com/users/petiepooo","html_url":"https://github.com/petiepooo","followers_url":"https://api.github.com/users/petiepooo/followers","following_url":"https://api.github.com/users/petiepooo/following{/other_user}","gists_url":"https://api.github.com/users/petiepooo/gists{/gist_id}","starred_url":"https://api.github.com/users/petiepooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petiepooo/subscriptions","organizations_url":"https://api.github.com/users/petiepooo/orgs","repos_url":"https://api.github.com/users/petiepooo/repos","events_url":"https://api.github.com/users/petiepooo/events{/privacy}","received_events_url":"https://api.github.com/users/petiepooo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2014-05-04T02:36:09Z","updated_at":"2017-01-06T07:35:57Z","closed_at":null,"body":"Notification is all well and good, but better yet is confirmation before use (ssh-agent's -c option).  Notification will only tell you when someone other than you has used your key.  Confirmation can stop them in their tracks before another system is compromised using your key.\n\nI've been able to add an ssh-askpass script that has Finder open a dialog, but it's inelegant and messes with application Z-ordering.  Would a patch for this package be the right place to truly integrate (Mac-ify) the confirm each use ssh-agent option?\n"},"comment":{"url":"https://api.github.com/repos/devinteske/apple/issues/comments/270848650","html_url":"https://github.com/devinteske/apple/issues/1#issuecomment-270848650","issue_url":"https://api.github.com/repos/devinteske/apple/issues/1","id":270848650,"user":{"login":"petiepooo","id":1916012,"avatar_url":"https://avatars.githubusercontent.com/u/1916012?v=3","gravatar_id":"","url":"https://api.github.com/users/petiepooo","html_url":"https://github.com/petiepooo","followers_url":"https://api.github.com/users/petiepooo/followers","following_url":"https://api.github.com/users/petiepooo/following{/other_user}","gists_url":"https://api.github.com/users/petiepooo/gists{/gist_id}","starred_url":"https://api.github.com/users/petiepooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petiepooo/subscriptions","organizations_url":"https://api.github.com/users/petiepooo/orgs","repos_url":"https://api.github.com/users/petiepooo/repos","events_url":"https://api.github.com/users/petiepooo/events{/privacy}","received_events_url":"https://api.github.com/users/petiepooo/received_events","type":"User","site_admin":false},"created_at":"2017-01-06T07:35:57Z","updated_at":"2017-01-06T07:35:57Z","body":"Wow.. I'd forgotten about this open issue.  Thanks for keeping the ball in the air!\r\n\r\nSince I submitted this, there have been a few releases of OSX and now macOS.  Shortly after submission, the new OSX version allowed applescript to raise a dialog directly from Terminal.app, so I no longer needed to mess with Z-ordering to bring Finder.app to the foreground just for its ability to raise a dialog.\r\n\r\nI'm still running 10.9 which uses OpenSSH_6.2p2 (I know, I know; company hardware, slow updates, etc.).  That said, [this /usr/libexec/ssh-askpass file](https://gist.github.com/petiepooo/cf5e943b31856b45794ebe79fa497cf8) works well for me.\r\n\r\nThe advantage that may give over using a notification is that, since I'm usually working in Terminal when this is called, the dialog comes up with focus.  I can just hit Enter (or Esc) to dismiss it, and don't need to switch app focus or use the trackpad to hunt down and click a button.  However, it still feels a little like a hack, and the dialog is a bit ugly and unintuitive.\r\n\r\nThere are a couple of sections defining and checking FRAPP (frontmost app).  They're optional, but give me the nice feature of Alex droning out \"SSH Authentication Request\" if ever Terminal isn't active when a confirmation request is triggered. \r\n\r\nThe text box in the dialog is used in other OpenSSH implementations for an actual password, but I've never used its capability on OSX.  In fact, entering something there causes key confirmation to fail.  Making it a simple Allow/Disallow dialog may be an improvement for macs at the expense of strict compatibility with OpenSSH intents.\r\n\r\nA [search for ssh-askpass](https://github.com/search?utf8=%E2%9C%93&q=ssh-askpass) on github turns up several other options of varying complexity and features.  Or, if you come up with a better solution using macOS's native notification subsystem, that could be great.  In fact, it may be possible for you to launch from an ssh-askpass binary rather than needing to patch and recompile ssh-agent.  That would definitely aid in install simplicity, but would require all keys to be added to the agent with the -c option to trigger the call.\r\n\r\nOooh.. I wonder if there's a way to pop up a button in the new MacBook's touch bar... or maybe use the fingerprint sensor for key confirmation.  That would rock!"}}
{"actor":{"display_login":"petiepooo"}}