{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/126968098","pull_request_review_id":49505085,"id":126968098,"diff_hunk":"@@ -68,6 +68,14 @@ via the <<multi-fields>> parameter.\n [float]\n === Settings to prevent mappings explosion\n \n+Defining too many fields in an index or having too many nested documents or too many fields that contain nested","path":"docs/reference/mapping.asciidoc","position":4,"original_position":4,"commit_id":"275ea7fb3dd3bb520ea1a449330c15cacbfabdff","original_commit_id":"275ea7fb3dd3bb520ea1a449330c15cacbfabdff","user":{"login":"matarrese","id":1400984,"avatar_url":"https://avatars0.githubusercontent.com/u/1400984?v=3","gravatar_id":"","url":"https://api.github.com/users/matarrese","html_url":"https://github.com/matarrese","followers_url":"https://api.github.com/users/matarrese/followers","following_url":"https://api.github.com/users/matarrese/following{/other_user}","gists_url":"https://api.github.com/users/matarrese/gists{/gist_id}","starred_url":"https://api.github.com/users/matarrese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matarrese/subscriptions","organizations_url":"https://api.github.com/users/matarrese/orgs","repos_url":"https://api.github.com/users/matarrese/repos","events_url":"https://api.github.com/users/matarrese/events{/privacy}","received_events_url":"https://api.github.com/users/matarrese/received_events","type":"User","site_admin":false},"body":"you are right, jut to be 100% sure, if I nested document introduce new fields, this can be a similar case of Defining too many fields?","created_at":"2017-07-12T14:22:28Z","updated_at":"2017-07-12T14:22:28Z","html_url":"https://github.com/elastic/elasticsearch/pull/25654#discussion_r126968098","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25654","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/126968098"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/25654#discussion_r126968098"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25654"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25654","id":129949526,"html_url":"https://github.com/elastic/elasticsearch/pull/25654","diff_url":"https://github.com/elastic/elasticsearch/pull/25654.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/25654.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/25654","number":25654,"state":"open","locked":false,"title":"explain mapping explosion","user":{"login":"matarrese","id":1400984,"avatar_url":"https://avatars0.githubusercontent.com/u/1400984?v=3","gravatar_id":"","url":"https://api.github.com/users/matarrese","html_url":"https://github.com/matarrese","followers_url":"https://api.github.com/users/matarrese/followers","following_url":"https://api.github.com/users/matarrese/following{/other_user}","gists_url":"https://api.github.com/users/matarrese/gists{/gist_id}","starred_url":"https://api.github.com/users/matarrese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matarrese/subscriptions","organizations_url":"https://api.github.com/users/matarrese/orgs","repos_url":"https://api.github.com/users/matarrese/repos","events_url":"https://api.github.com/users/matarrese/events{/privacy}","received_events_url":"https://api.github.com/users/matarrese/received_events","type":"User","site_admin":false},"body":"Closes #23687","created_at":"2017-07-11T16:18:23Z","updated_at":"2017-07-12T14:22:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f330cc35045659b160fc59d7e696631340d4706","assignee":{"login":"javanna","id":832460,"avatar_url":"https://avatars2.githubusercontent.com/u/832460?v=3","gravatar_id":"","url":"https://api.github.com/users/javanna","html_url":"https://github.com/javanna","followers_url":"https://api.github.com/users/javanna/followers","following_url":"https://api.github.com/users/javanna/following{/other_user}","gists_url":"https://api.github.com/users/javanna/gists{/gist_id}","starred_url":"https://api.github.com/users/javanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javanna/subscriptions","organizations_url":"https://api.github.com/users/javanna/orgs","repos_url":"https://api.github.com/users/javanna/repos","events_url":"https://api.github.com/users/javanna/events{/privacy}","received_events_url":"https://api.github.com/users/javanna/received_events","type":"User","site_admin":false},"assignees":[{"login":"javanna","id":832460,"avatar_url":"https://avatars2.githubusercontent.com/u/832460?v=3","gravatar_id":"","url":"https://api.github.com/users/javanna","html_url":"https://github.com/javanna","followers_url":"https://api.github.com/users/javanna/followers","following_url":"https://api.github.com/users/javanna/following{/other_user}","gists_url":"https://api.github.com/users/javanna/gists{/gist_id}","starred_url":"https://api.github.com/users/javanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javanna/subscriptions","organizations_url":"https://api.github.com/users/javanna/orgs","repos_url":"https://api.github.com/users/javanna/repos","events_url":"https://api.github.com/users/javanna/events{/privacy}","received_events_url":"https://api.github.com/users/javanna/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25654/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25654/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/25654/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/275ea7fb3dd3bb520ea1a449330c15cacbfabdff","head":{"label":"matarrese:explain_mapping_explosion","ref":"explain_mapping_explosion","sha":"275ea7fb3dd3bb520ea1a449330c15cacbfabdff","user":{"login":"matarrese","id":1400984,"avatar_url":"https://avatars0.githubusercontent.com/u/1400984?v=3","gravatar_id":"","url":"https://api.github.com/users/matarrese","html_url":"https://github.com/matarrese","followers_url":"https://api.github.com/users/matarrese/followers","following_url":"https://api.github.com/users/matarrese/following{/other_user}","gists_url":"https://api.github.com/users/matarrese/gists{/gist_id}","starred_url":"https://api.github.com/users/matarrese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matarrese/subscriptions","organizations_url":"https://api.github.com/users/matarrese/orgs","repos_url":"https://api.github.com/users/matarrese/repos","events_url":"https://api.github.com/users/matarrese/events{/privacy}","received_events_url":"https://api.github.com/users/matarrese/received_events","type":"User","site_admin":false},"repo":{"id":95545391,"name":"elasticsearch","full_name":"matarrese/elasticsearch","owner":{"login":"matarrese","id":1400984,"avatar_url":"https://avatars0.githubusercontent.com/u/1400984?v=3","gravatar_id":"","url":"https://api.github.com/users/matarrese","html_url":"https://github.com/matarrese","followers_url":"https://api.github.com/users/matarrese/followers","following_url":"https://api.github.com/users/matarrese/following{/other_user}","gists_url":"https://api.github.com/users/matarrese/gists{/gist_id}","starred_url":"https://api.github.com/users/matarrese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matarrese/subscriptions","organizations_url":"https://api.github.com/users/matarrese/orgs","repos_url":"https://api.github.com/users/matarrese/repos","events_url":"https://api.github.com/users/matarrese/events{/privacy}","received_events_url":"https://api.github.com/users/matarrese/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matarrese/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/matarrese/elasticsearch","forks_url":"https://api.github.com/repos/matarrese/elasticsearch/forks","keys_url":"https://api.github.com/repos/matarrese/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matarrese/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matarrese/elasticsearch/teams","hooks_url":"https://api.github.com/repos/matarrese/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/matarrese/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/matarrese/elasticsearch/events","assignees_url":"https://api.github.com/repos/matarrese/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/matarrese/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/matarrese/elasticsearch/tags","blobs_url":"https://api.github.com/repos/matarrese/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matarrese/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matarrese/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/matarrese/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matarrese/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/matarrese/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/matarrese/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/matarrese/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/matarrese/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/matarrese/elasticsearch/subscription","commits_url":"https://api.github.com/repos/matarrese/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/matarrese/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/matarrese/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/matarrese/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/matarrese/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/matarrese/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matarrese/elasticsearch/merges","archive_url":"https://api.github.com/repos/matarrese/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matarrese/elasticsearch/downloads","issues_url":"https://api.github.com/repos/matarrese/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/matarrese/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/matarrese/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/matarrese/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matarrese/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/matarrese/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/matarrese/elasticsearch/deployments","created_at":"2017-06-27T10:11:41Z","updated_at":"2017-06-27T10:12:19Z","pushed_at":"2017-07-12T12:46:07Z","git_url":"git://github.com/matarrese/elasticsearch.git","ssh_url":"git@github.com:matarrese/elasticsearch.git","clone_url":"https://github.com/matarrese/elasticsearch.git","svn_url":"https://github.com/matarrese/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":355886,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"f9fbce84b646198ba80e66d8fd3898e0afad9797","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars3.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2017-07-12T12:58:56Z","pushed_at":"2017-07-12T14:17:56Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":357473,"stargazers_count":23709,"watchers_count":23709,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8382,"mirror_url":null,"open_issues_count":1290,"forks":8382,"open_issues":1290,"watchers":23709,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25654"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/25654"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/25654"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/25654/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25654/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25654/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/275ea7fb3dd3bb520ea1a449330c15cacbfabdff"}}}}
{"actor":{"display_login":"matarrese"}}