{"action":"created","comment":{"url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/pulls/comments/130573805","pull_request_review_id":53462059,"id":130573805,"diff_hunk":"@@ -25,11 +29,26 @@\n public class ServerTracingAutoConfiguration {\n     private static final Logger log = Logger.getLogger(ServerTracingAutoConfiguration.class.getName());\n \n+    @Autowired(required=false)\n+    @Qualifier(\"opentracing.http.skipPattern\")\n+    private Set<String> skipPatterns;","path":"opentracing-spring-web-autoconfigure/src/main/java/io/opentracing/contrib/spring/web/autoconfig/ServerTracingAutoConfiguration.java","position":19,"original_position":19,"commit_id":"28391c3c8f130382bf55c84a78625b2aedcd83f7","original_commit_id":"28391c3c8f130382bf55c84a78625b2aedcd83f7","user":{"login":"objectiser","id":164562,"avatar_url":"https://avatars3.githubusercontent.com/u/164562?v=4","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"body":"You mean if  `WebTracingConfiguration` is missing? Yes - so would only use this auto-config approach if some other component had not provided their own `WebTracingConfiguration` bean.\r\n\r\nMaybe it would be better remove the `WebTracingConfiguraton` and just do the configuration of the skip pattern (via autowired `SkipPattern` for example) in the `ServerTracingAutoConfiguration.tracingFilter` method?","created_at":"2017-08-01T10:35:36Z","updated_at":"2017-08-01T10:35:36Z","html_url":"https://github.com/opentracing-contrib/java-spring-web/pull/28#discussion_r130573805","pull_request_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/opentracing-contrib/java-spring-web/pulls/comments/130573805"},"html":{"href":"https://github.com/opentracing-contrib/java-spring-web/pull/28#discussion_r130573805"},"pull_request":{"href":"https://api.github.com/repos/opentracing-contrib/java-spring-web/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/pulls/28","id":133275586,"html_url":"https://github.com/opentracing-contrib/java-spring-web/pull/28","diff_url":"https://github.com/opentracing-contrib/java-spring-web/pull/28.diff","patch_url":"https://github.com/opentracing-contrib/java-spring-web/pull/28.patch","issue_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/issues/28","number":28,"state":"open","locked":false,"title":"RFC: Enable skip patterns to be injects from independent components","user":{"login":"objectiser","id":164562,"avatar_url":"https://avatars3.githubusercontent.com/u/164562?v=4","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"body":"Possible mechanism for making the skip pattern configuration more flexible.\r\n\r\nThis approach would enable separate instrumentations (and the app itself) to provide patterns that should be skipped, rather than having one place that needs to have the value defined for all situations.\r\n\r\nFor example, the metrics auto-config (when using prometheus servlet exporter) needs to exclude the `/metrics` (or whatever if defined) endpoint. Similarly, when an app is used in kubernetes or openshift, it may be appropriate to exclude the `/health` endpoint (currently defined as a default, but only relevant when app deployed in container platform).","created_at":"2017-07-31T15:38:07Z","updated_at":"2017-08-01T10:35:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74b1503b4de8e1cfc0166e5de28b8cd49c6c446b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/pulls/28/commits","review_comments_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/pulls/28/comments","review_comment_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/issues/28/comments","statuses_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/statuses/28391c3c8f130382bf55c84a78625b2aedcd83f7","head":{"label":"objectiser:skip","ref":"skip","sha":"28391c3c8f130382bf55c84a78625b2aedcd83f7","user":{"login":"objectiser","id":164562,"avatar_url":"https://avatars3.githubusercontent.com/u/164562?v=4","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"repo":{"id":87786680,"name":"java-spring-web","full_name":"objectiser/java-spring-web","owner":{"login":"objectiser","id":164562,"avatar_url":"https://avatars3.githubusercontent.com/u/164562?v=4","gravatar_id":"","url":"https://api.github.com/users/objectiser","html_url":"https://github.com/objectiser","followers_url":"https://api.github.com/users/objectiser/followers","following_url":"https://api.github.com/users/objectiser/following{/other_user}","gists_url":"https://api.github.com/users/objectiser/gists{/gist_id}","starred_url":"https://api.github.com/users/objectiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objectiser/subscriptions","organizations_url":"https://api.github.com/users/objectiser/orgs","repos_url":"https://api.github.com/users/objectiser/repos","events_url":"https://api.github.com/users/objectiser/events{/privacy}","received_events_url":"https://api.github.com/users/objectiser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/objectiser/java-spring-web","description":"OpenTracing Java Spring Web interceptor instrumentation","fork":true,"url":"https://api.github.com/repos/objectiser/java-spring-web","forks_url":"https://api.github.com/repos/objectiser/java-spring-web/forks","keys_url":"https://api.github.com/repos/objectiser/java-spring-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/objectiser/java-spring-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/objectiser/java-spring-web/teams","hooks_url":"https://api.github.com/repos/objectiser/java-spring-web/hooks","issue_events_url":"https://api.github.com/repos/objectiser/java-spring-web/issues/events{/number}","events_url":"https://api.github.com/repos/objectiser/java-spring-web/events","assignees_url":"https://api.github.com/repos/objectiser/java-spring-web/assignees{/user}","branches_url":"https://api.github.com/repos/objectiser/java-spring-web/branches{/branch}","tags_url":"https://api.github.com/repos/objectiser/java-spring-web/tags","blobs_url":"https://api.github.com/repos/objectiser/java-spring-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/objectiser/java-spring-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/objectiser/java-spring-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/objectiser/java-spring-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/objectiser/java-spring-web/statuses/{sha}","languages_url":"https://api.github.com/repos/objectiser/java-spring-web/languages","stargazers_url":"https://api.github.com/repos/objectiser/java-spring-web/stargazers","contributors_url":"https://api.github.com/repos/objectiser/java-spring-web/contributors","subscribers_url":"https://api.github.com/repos/objectiser/java-spring-web/subscribers","subscription_url":"https://api.github.com/repos/objectiser/java-spring-web/subscription","commits_url":"https://api.github.com/repos/objectiser/java-spring-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/objectiser/java-spring-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/objectiser/java-spring-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/objectiser/java-spring-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/objectiser/java-spring-web/contents/{+path}","compare_url":"https://api.github.com/repos/objectiser/java-spring-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/objectiser/java-spring-web/merges","archive_url":"https://api.github.com/repos/objectiser/java-spring-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/objectiser/java-spring-web/downloads","issues_url":"https://api.github.com/repos/objectiser/java-spring-web/issues{/number}","pulls_url":"https://api.github.com/repos/objectiser/java-spring-web/pulls{/number}","milestones_url":"https://api.github.com/repos/objectiser/java-spring-web/milestones{/number}","notifications_url":"https://api.github.com/repos/objectiser/java-spring-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/objectiser/java-spring-web/labels{/name}","releases_url":"https://api.github.com/repos/objectiser/java-spring-web/releases{/id}","deployments_url":"https://api.github.com/repos/objectiser/java-spring-web/deployments","created_at":"2017-04-10T08:34:46Z","updated_at":"2017-04-10T08:34:48Z","pushed_at":"2017-08-01T08:47:07Z","git_url":"git://github.com/objectiser/java-spring-web.git","ssh_url":"git@github.com:objectiser/java-spring-web.git","clone_url":"https://github.com/objectiser/java-spring-web.git","svn_url":"https://github.com/objectiser/java-spring-web","homepage":"","size":173,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opentracing-contrib:master","ref":"master","sha":"db4accb40f6d3f991af74d713e56502b7da9c977","user":{"login":"opentracing-contrib","id":20525934,"avatar_url":"https://avatars0.githubusercontent.com/u/20525934?v=4","gravatar_id":"","url":"https://api.github.com/users/opentracing-contrib","html_url":"https://github.com/opentracing-contrib","followers_url":"https://api.github.com/users/opentracing-contrib/followers","following_url":"https://api.github.com/users/opentracing-contrib/following{/other_user}","gists_url":"https://api.github.com/users/opentracing-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing-contrib/subscriptions","organizations_url":"https://api.github.com/users/opentracing-contrib/orgs","repos_url":"https://api.github.com/users/opentracing-contrib/repos","events_url":"https://api.github.com/users/opentracing-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing-contrib/received_events","type":"Organization","site_admin":false},"repo":{"id":78768320,"name":"java-spring-web","full_name":"opentracing-contrib/java-spring-web","owner":{"login":"opentracing-contrib","id":20525934,"avatar_url":"https://avatars0.githubusercontent.com/u/20525934?v=4","gravatar_id":"","url":"https://api.github.com/users/opentracing-contrib","html_url":"https://github.com/opentracing-contrib","followers_url":"https://api.github.com/users/opentracing-contrib/followers","following_url":"https://api.github.com/users/opentracing-contrib/following{/other_user}","gists_url":"https://api.github.com/users/opentracing-contrib/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing-contrib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing-contrib/subscriptions","organizations_url":"https://api.github.com/users/opentracing-contrib/orgs","repos_url":"https://api.github.com/users/opentracing-contrib/repos","events_url":"https://api.github.com/users/opentracing-contrib/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing-contrib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentracing-contrib/java-spring-web","description":"OpenTracing Spring Web instrumentation","fork":false,"url":"https://api.github.com/repos/opentracing-contrib/java-spring-web","forks_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/forks","keys_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/teams","hooks_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/hooks","issue_events_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/issues/events{/number}","events_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/events","assignees_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/assignees{/user}","branches_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/branches{/branch}","tags_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/tags","blobs_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/statuses/{sha}","languages_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/languages","stargazers_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/stargazers","contributors_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/contributors","subscribers_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/subscribers","subscription_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/subscription","commits_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/contents/{+path}","compare_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/merges","archive_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/downloads","issues_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/issues{/number}","pulls_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/pulls{/number}","milestones_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/milestones{/number}","notifications_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/labels{/name}","releases_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/releases{/id}","deployments_url":"https://api.github.com/repos/opentracing-contrib/java-spring-web/deployments","created_at":"2017-01-12T17:14:33Z","updated_at":"2017-07-12T03:20:01Z","pushed_at":"2017-08-01T08:47:08Z","git_url":"git://github.com/opentracing-contrib/java-spring-web.git","ssh_url":"git@github.com:opentracing-contrib/java-spring-web.git","clone_url":"https://github.com/opentracing-contrib/java-spring-web.git","svn_url":"https://github.com/opentracing-contrib/java-spring-web","homepage":"","size":153,"stargazers_count":5,"watchers_count":5,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentracing-contrib/java-spring-web/pulls/28"},"html":{"href":"https://github.com/opentracing-contrib/java-spring-web/pull/28"},"issue":{"href":"https://api.github.com/repos/opentracing-contrib/java-spring-web/issues/28"},"comments":{"href":"https://api.github.com/repos/opentracing-contrib/java-spring-web/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/opentracing-contrib/java-spring-web/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/opentracing-contrib/java-spring-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentracing-contrib/java-spring-web/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/opentracing-contrib/java-spring-web/statuses/28391c3c8f130382bf55c84a78625b2aedcd83f7"}}}}
{"actor":{"display_login":"objectiser"}}