{"action":"created","issue":{"url":"https://api.github.com/repos/ucb-bar/chisel3/issues/517","repository_url":"https://api.github.com/repos/ucb-bar/chisel3","labels_url":"https://api.github.com/repos/ucb-bar/chisel3/issues/517/labels{/name}","comments_url":"https://api.github.com/repos/ucb-bar/chisel3/issues/517/comments","events_url":"https://api.github.com/repos/ucb-bar/chisel3/issues/517/events","html_url":"https://github.com/ucb-bar/chisel3/pull/517","id":208588088,"number":517,"title":"Remove check on potentialy empty string for Record names.","user":{"login":"mwachs5","id":17858596,"avatar_url":"https://avatars.githubusercontent.com/u/17858596?v=3","gravatar_id":"","url":"https://api.github.com/users/mwachs5","html_url":"https://github.com/mwachs5","followers_url":"https://api.github.com/users/mwachs5/followers","following_url":"https://api.github.com/users/mwachs5/following{/other_user}","gists_url":"https://api.github.com/users/mwachs5/gists{/gist_id}","starred_url":"https://api.github.com/users/mwachs5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwachs5/subscriptions","organizations_url":"https://api.github.com/users/mwachs5/orgs","repos_url":"https://api.github.com/users/mwachs5/repos","events_url":"https://api.github.com/users/mwachs5/events{/privacy}","received_events_url":"https://api.github.com/users/mwachs5/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-02-17T23:51:41Z","updated_at":"2017-02-22T21:56:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ucb-bar/chisel3/pulls/517","html_url":"https://github.com/ucb-bar/chisel3/pull/517","diff_url":"https://github.com/ucb-bar/chisel3/pull/517.diff","patch_url":"https://github.com/ucb-bar/chisel3/pull/517.patch"},"body":"@terpstra -- apparently I don't have the ability to push to Chisel3. \r\n\r\nThis does what I'd expect, but seems perhaps FIRRTL can't handle numbers as names either.\r\nNote the difference between how a Vec (the uarts) and a Record (the spis) are output to FIRRTL.\r\n\r\n```\r\n    io.uarts[0] <- uart_0.io.port @[UARTPeriphery.scala 36:8]\r\n    io.uarts[1] <- uart_1.io.port @[UARTPeriphery.scala 36:8]\r\n    io.spis.0 <- spi_0.io.port @[SPIPeriphery.scala 32:8]\r\n    io.spis.1 <- spi_1.io.port @[SPIPeriphery.scala 32:8]\r\n...\r\n    uart_pins_0.io.uart <- RocketChipTop.io.uarts[0]\r\n    uart_pins_1.io.uart <- RocketChipTop.io.uarts[1]\r\n    spi_pins_0.io.spi <- RocketChipTop.io.spis.0 \r\n    spi_pins_1.io.spi <- RocketChipTop.io.spis.1 \r\n```\r\n\r\nFIRRTL gives these errors on the SPI lines:\r\n\r\n```\r\nline 265272:12 no viable alternative at input 'io.spis.0'\r\nline 265273:12 no viable alternative at input 'io.spis.1'\r\n...\r\nline 266421:52 no viable alternative at input '0'\r\nline 266422:52 no viable alternative at input '1'\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ucb-bar/chisel3/issues/comments/281817410","html_url":"https://github.com/ucb-bar/chisel3/pull/517#issuecomment-281817410","issue_url":"https://api.github.com/repos/ucb-bar/chisel3/issues/517","id":281817410,"user":{"login":"azidar","id":5377148,"avatar_url":"https://avatars.githubusercontent.com/u/5377148?v=3","gravatar_id":"","url":"https://api.github.com/users/azidar","html_url":"https://github.com/azidar","followers_url":"https://api.github.com/users/azidar/followers","following_url":"https://api.github.com/users/azidar/following{/other_user}","gists_url":"https://api.github.com/users/azidar/gists{/gist_id}","starred_url":"https://api.github.com/users/azidar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azidar/subscriptions","organizations_url":"https://api.github.com/users/azidar/orgs","repos_url":"https://api.github.com/users/azidar/repos","events_url":"https://api.github.com/users/azidar/events{/privacy}","received_events_url":"https://api.github.com/users/azidar/received_events","type":"User","site_admin":false},"created_at":"2017-02-22T21:56:47Z","updated_at":"2017-02-22T21:56:47Z","body":"The original reason for not allowing numbers as bundle fields was so there wasn't a name conflict when expanding a vec versus a bundle. However, since the Uniquify pass in Firrtl solved this, I don't think there is a fundamental issue any longer (as long as the parser can still handle it)."}}
{"actor":{"display_login":"azidar"}}