{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/common/pulls/comments/100758174","pull_request_review_id":21471640,"id":100758174,"diff_hunk":"@@ -88,337 +88,19 @@ public function getProperty($name)\n     }\n \n     /**\n-     * {@inheritDoc}\n-     */\n-    public static function export($argument, $return = false)\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getConstant($name)\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getConstants()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getConstructor()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getDefaultProperties()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getEndLine()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getExtension()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getExtensionName()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getFileName()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getInterfaceNames()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getInterfaces()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getMethods($filter = null)\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getModifiers()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getParentClass()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getProperties($filter = null)\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getShortName()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getStartLine()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getStaticProperties()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getStaticPropertyValue($name, $default = '')\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getTraitAliases()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getTraitNames()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function getTraits()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function hasConstant($name)\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function hasMethod($name)\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function hasProperty($name)\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function implementsInterface($interface)\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function inNamespace()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function isAbstract()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function isCloneable()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function isFinal()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function isInstance($object)\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function isInstantiable()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function isInterface()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function isInternal()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function isIterateable()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function isSubclassOf($class)\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function isTrait()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function isUserDefined()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function newInstance($args)\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function newInstanceArgs(array $args = [])\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n-     */\n-    public function newInstanceWithoutConstructor()\n-    {\n-        throw new ReflectionException('Method not implemented');\n-    }\n-\n-    /**\n-     * {@inheritDoc}\n+     * Prevents calling unsupported methods.\n+     *\n+     * __call() is used so that PHP can change the signature of these methods without breaking this class. For example,\n+     * https://github.com/php/php-src/pull/2363.\n+     *\n+     * @param string $method\n+     * @param array  $args\n+     *\n+     * @return mixed\n+     *\n+     * @throws \\ReflectionException\n      */\n-    public function setStaticPropertyValue($name, $value)\n+    public function __call($name, $arguments)","path":"lib/Doctrine/Common/Reflection/StaticReflectionClass.php","position":346,"original_position":346,"commit_id":"89eafe0875af5d89056f850b11934521d0b0c4b4","original_commit_id":"89eafe0875af5d89056f850b11934521d0b0c4b4","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars.githubusercontent.com/u/154256?v=3","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"body":"This wouldn't be called for public API that is defined on the parent class.","created_at":"2017-02-13T09:59:05Z","updated_at":"2017-02-13T09:59:13Z","html_url":"https://github.com/doctrine/common/pull/775#discussion_r100758174","pull_request_url":"https://api.github.com/repos/doctrine/common/pulls/775","_links":{"self":{"href":"https://api.github.com/repos/doctrine/common/pulls/comments/100758174"},"html":{"href":"https://github.com/doctrine/common/pull/775#discussion_r100758174"},"pull_request":{"href":"https://api.github.com/repos/doctrine/common/pulls/775"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/common/pulls/775","id":105859911,"html_url":"https://github.com/doctrine/common/pull/775","diff_url":"https://github.com/doctrine/common/pull/775.diff","patch_url":"https://github.com/doctrine/common/pull/775.patch","issue_url":"https://api.github.com/repos/doctrine/common/issues/775","number":775,"state":"open","locked":false,"title":"Use __call() to prevent calling unsupported methods on StaticReflectionClass","user":{"login":"alexpott","id":769634,"avatar_url":"https://avatars.githubusercontent.com/u/769634?v=3","gravatar_id":"","url":"https://api.github.com/users/alexpott","html_url":"https://github.com/alexpott","followers_url":"https://api.github.com/users/alexpott/followers","following_url":"https://api.github.com/users/alexpott/following{/other_user}","gists_url":"https://api.github.com/users/alexpott/gists{/gist_id}","starred_url":"https://api.github.com/users/alexpott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexpott/subscriptions","organizations_url":"https://api.github.com/users/alexpott/orgs","repos_url":"https://api.github.com/users/alexpott/repos","events_url":"https://api.github.com/users/alexpott/events{/privacy}","received_events_url":"https://api.github.com/users/alexpott/received_events","type":"User","site_admin":false},"body":"PHP7 recently merged and then reverted https://github.com/php/php-src/pull/2363. This caused problems for StaticReflectionClass because the signature of StaticReflectionClass::newInstance() is changed. The commit remains in PHP's HEAD so at some point this will break.","created_at":"2017-02-13T09:55:06Z","updated_at":"2017-02-13T09:59:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27731ab90a0a4da6a14b33b851b5a2888a548cee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/common/pulls/775/commits","review_comments_url":"https://api.github.com/repos/doctrine/common/pulls/775/comments","review_comment_url":"https://api.github.com/repos/doctrine/common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/common/issues/775/comments","statuses_url":"https://api.github.com/repos/doctrine/common/statuses/89eafe0875af5d89056f850b11934521d0b0c4b4","head":{"label":"alexpott:StaticReflectionClass-forward-compatibility","ref":"StaticReflectionClass-forward-compatibility","sha":"89eafe0875af5d89056f850b11934521d0b0c4b4","user":{"login":"alexpott","id":769634,"avatar_url":"https://avatars.githubusercontent.com/u/769634?v=3","gravatar_id":"","url":"https://api.github.com/users/alexpott","html_url":"https://github.com/alexpott","followers_url":"https://api.github.com/users/alexpott/followers","following_url":"https://api.github.com/users/alexpott/following{/other_user}","gists_url":"https://api.github.com/users/alexpott/gists{/gist_id}","starred_url":"https://api.github.com/users/alexpott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexpott/subscriptions","organizations_url":"https://api.github.com/users/alexpott/orgs","repos_url":"https://api.github.com/users/alexpott/repos","events_url":"https://api.github.com/users/alexpott/events{/privacy}","received_events_url":"https://api.github.com/users/alexpott/received_events","type":"User","site_admin":false},"repo":{"id":34462382,"name":"common","full_name":"alexpott/common","owner":{"login":"alexpott","id":769634,"avatar_url":"https://avatars.githubusercontent.com/u/769634?v=3","gravatar_id":"","url":"https://api.github.com/users/alexpott","html_url":"https://github.com/alexpott","followers_url":"https://api.github.com/users/alexpott/followers","following_url":"https://api.github.com/users/alexpott/following{/other_user}","gists_url":"https://api.github.com/users/alexpott/gists{/gist_id}","starred_url":"https://api.github.com/users/alexpott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexpott/subscriptions","organizations_url":"https://api.github.com/users/alexpott/orgs","repos_url":"https://api.github.com/users/alexpott/repos","events_url":"https://api.github.com/users/alexpott/events{/privacy}","received_events_url":"https://api.github.com/users/alexpott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexpott/common","description":"Doctrine Common","fork":true,"url":"https://api.github.com/repos/alexpott/common","forks_url":"https://api.github.com/repos/alexpott/common/forks","keys_url":"https://api.github.com/repos/alexpott/common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexpott/common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexpott/common/teams","hooks_url":"https://api.github.com/repos/alexpott/common/hooks","issue_events_url":"https://api.github.com/repos/alexpott/common/issues/events{/number}","events_url":"https://api.github.com/repos/alexpott/common/events","assignees_url":"https://api.github.com/repos/alexpott/common/assignees{/user}","branches_url":"https://api.github.com/repos/alexpott/common/branches{/branch}","tags_url":"https://api.github.com/repos/alexpott/common/tags","blobs_url":"https://api.github.com/repos/alexpott/common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexpott/common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexpott/common/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexpott/common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexpott/common/statuses/{sha}","languages_url":"https://api.github.com/repos/alexpott/common/languages","stargazers_url":"https://api.github.com/repos/alexpott/common/stargazers","contributors_url":"https://api.github.com/repos/alexpott/common/contributors","subscribers_url":"https://api.github.com/repos/alexpott/common/subscribers","subscription_url":"https://api.github.com/repos/alexpott/common/subscription","commits_url":"https://api.github.com/repos/alexpott/common/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexpott/common/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexpott/common/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexpott/common/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexpott/common/contents/{+path}","compare_url":"https://api.github.com/repos/alexpott/common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexpott/common/merges","archive_url":"https://api.github.com/repos/alexpott/common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexpott/common/downloads","issues_url":"https://api.github.com/repos/alexpott/common/issues{/number}","pulls_url":"https://api.github.com/repos/alexpott/common/pulls{/number}","milestones_url":"https://api.github.com/repos/alexpott/common/milestones{/number}","notifications_url":"https://api.github.com/repos/alexpott/common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexpott/common/labels{/name}","releases_url":"https://api.github.com/repos/alexpott/common/releases{/id}","deployments_url":"https://api.github.com/repos/alexpott/common/deployments","created_at":"2015-04-23T14:47:15Z","updated_at":"2017-02-13T09:29:30Z","pushed_at":"2017-02-13T09:57:06Z","git_url":"git://github.com/alexpott/common.git","ssh_url":"git@github.com:alexpott/common.git","clone_url":"https://github.com/alexpott/common.git","svn_url":"https://github.com/alexpott/common","homepage":"http://www.doctrine-project.org","size":19562,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"fe32728bfb6bec4209eb7953287f862283ee8a0f","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":677467,"name":"common","full_name":"doctrine/common","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/common","description":"Doctrine Common","fork":false,"url":"https://api.github.com/repos/doctrine/common","forks_url":"https://api.github.com/repos/doctrine/common/forks","keys_url":"https://api.github.com/repos/doctrine/common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/common/teams","hooks_url":"https://api.github.com/repos/doctrine/common/hooks","issue_events_url":"https://api.github.com/repos/doctrine/common/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/common/events","assignees_url":"https://api.github.com/repos/doctrine/common/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/common/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/common/tags","blobs_url":"https://api.github.com/repos/doctrine/common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/common/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/common/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/common/languages","stargazers_url":"https://api.github.com/repos/doctrine/common/stargazers","contributors_url":"https://api.github.com/repos/doctrine/common/contributors","subscribers_url":"https://api.github.com/repos/doctrine/common/subscribers","subscription_url":"https://api.github.com/repos/doctrine/common/subscription","commits_url":"https://api.github.com/repos/doctrine/common/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/common/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/common/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/common/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/common/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/common/merges","archive_url":"https://api.github.com/repos/doctrine/common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/common/downloads","issues_url":"https://api.github.com/repos/doctrine/common/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/common/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/common/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/common/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/common/releases{/id}","deployments_url":"https://api.github.com/repos/doctrine/common/deployments","created_at":"2010-05-20T17:01:56Z","updated_at":"2017-02-03T09:59:34Z","pushed_at":"2017-02-13T09:57:07Z","git_url":"git://github.com/doctrine/common.git","ssh_url":"git@github.com:doctrine/common.git","clone_url":"https://github.com/doctrine/common.git","svn_url":"https://github.com/doctrine/common","homepage":"http://www.doctrine-project.org","size":16526,"stargazers_count":356,"watchers_count":356,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":266,"mirror_url":null,"open_issues_count":73,"forks":266,"open_issues":73,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/common/pulls/775"},"html":{"href":"https://github.com/doctrine/common/pull/775"},"issue":{"href":"https://api.github.com/repos/doctrine/common/issues/775"},"comments":{"href":"https://api.github.com/repos/doctrine/common/issues/775/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/common/pulls/775/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/common/pulls/775/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/common/statuses/89eafe0875af5d89056f850b11934521d0b0c4b4"}}}}
{"actor":{"display_login":"Ocramius"}}