{"action":"created","issue":{"url":"https://api.github.com/repos/neomake/neomake/issues/795","repository_url":"https://api.github.com/repos/neomake/neomake","labels_url":"https://api.github.com/repos/neomake/neomake/issues/795/labels{/name}","comments_url":"https://api.github.com/repos/neomake/neomake/issues/795/comments","events_url":"https://api.github.com/repos/neomake/neomake/issues/795/events","html_url":"https://github.com/neomake/neomake/pull/795","id":190893718,"number":795,"title":"Go: add gometalinter","user":{"login":"bradleyfalzon","id":1834577,"avatar_url":"https://avatars0.githubusercontent.com/u/1834577?v=3","gravatar_id":"","url":"https://api.github.com/users/bradleyfalzon","html_url":"https://github.com/bradleyfalzon","followers_url":"https://api.github.com/users/bradleyfalzon/followers","following_url":"https://api.github.com/users/bradleyfalzon/following{/other_user}","gists_url":"https://api.github.com/users/bradleyfalzon/gists{/gist_id}","starred_url":"https://api.github.com/users/bradleyfalzon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradleyfalzon/subscriptions","organizations_url":"https://api.github.com/users/bradleyfalzon/orgs","repos_url":"https://api.github.com/users/bradleyfalzon/repos","events_url":"https://api.github.com/users/bradleyfalzon/events{/privacy}","received_events_url":"https://api.github.com/users/bradleyfalzon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2016-11-22T02:47:27Z","updated_at":"2017-04-18T21:18:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/neomake/neomake/pulls/795","html_url":"https://github.com/neomake/neomake/pull/795","diff_url":"https://github.com/neomake/neomake/pull/795.diff","patch_url":"https://github.com/neomake/neomake/pull/795.patch"},"body":"Go has a quite a number of static analysis tools outside of the standard compiler, lint and vet checks.\r\n\r\nGometalinter help manage (install and update) and standardise the output of the checks to a single format.\r\n\r\nI've added gometalinter support because a user can then use this intermediate tool to enable or disable various checkers/linters themselves without having to further customise neomake.\r\n\r\nWIP:\r\n\r\n- ~I'd like users to be able to adjust the `args` as they see fit, the ones I've proposed show few false positives and usually refer to issues that really do need to be fixed (or have left dead code around and can be safely removed).~ Fixed in ad531ac7473a732b8a7c39b3e02e2e8b88b026ab\r\n- ~Can users disable the gometalinter if they do not want to use it, even though it is installed?~ Yes they can by doing something like `let g:neomake_go_enabled_makers = ['go', 'golint']`\r\n- ~What happens if gometalinter isn't installed, does neomake handle this gracefully?~ Yes it does\r\n- ~Can someone show me an example commit with a basic test that I could use to help ensure these are tested?~\r\n\r\nCurrently the arguments are just my opinion as to what should \r\n\r\nRelates to #235 which also tried to implement the same functionality."},"comment":{"url":"https://api.github.com/repos/neomake/neomake/issues/comments/294985686","html_url":"https://github.com/neomake/neomake/pull/795#issuecomment-294985686","issue_url":"https://api.github.com/repos/neomake/neomake/issues/795","id":294985686,"user":{"login":"blueyed","id":9766,"avatar_url":"https://avatars2.githubusercontent.com/u/9766?v=3","gravatar_id":"","url":"https://api.github.com/users/blueyed","html_url":"https://github.com/blueyed","followers_url":"https://api.github.com/users/blueyed/followers","following_url":"https://api.github.com/users/blueyed/following{/other_user}","gists_url":"https://api.github.com/users/blueyed/gists{/gist_id}","starred_url":"https://api.github.com/users/blueyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blueyed/subscriptions","organizations_url":"https://api.github.com/users/blueyed/orgs","repos_url":"https://api.github.com/users/blueyed/repos","events_url":"https://api.github.com/users/blueyed/events{/privacy}","received_events_url":"https://api.github.com/users/blueyed/received_events","type":"User","site_admin":false},"created_at":"2017-04-18T21:18:45Z","updated_at":"2017-04-18T21:18:45Z","body":"There was a conflict, so it had to be rebased.\r\nI've squashed it into a single commit, and will merge it once it's green on Travis.\r\nThanks!"}}
{"actor":{"display_login":"blueyed"}}