{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/119843817","pull_request_review_id":41761156,"id":119843817,"diff_hunk":"@@ -80,12 +82,18 @@ import (\n const (\n \tproxyModeUserspace = \"userspace\"\n \tproxyModeIPTables  = \"iptables\"\n+\tproxyModeIPVS      = \"ipvs\"","path":"cmd/kube-proxy/app/server.go","position":20,"original_position":20,"commit_id":"27d1575fb62551256f9a17d9258f64f908a307e0","original_commit_id":"27d1575fb62551256f9a17d9258f64f908a307e0","user":{"login":"hustcat","id":1716915,"avatar_url":"https://avatars3.githubusercontent.com/u/1716915?v=3","gravatar_id":"","url":"https://api.github.com/users/hustcat","html_url":"https://github.com/hustcat","followers_url":"https://api.github.com/users/hustcat/followers","following_url":"https://api.github.com/users/hustcat/following{/other_user}","gists_url":"https://api.github.com/users/hustcat/gists{/gist_id}","starred_url":"https://api.github.com/users/hustcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hustcat/subscriptions","organizations_url":"https://api.github.com/users/hustcat/orgs","repos_url":"https://api.github.com/users/hustcat/repos","events_url":"https://api.github.com/users/hustcat/events{/privacy}","received_events_url":"https://api.github.com/users/hustcat/received_events","type":"User","site_admin":false},"body":"Add this to `--proxy-mode` 's comment?","created_at":"2017-06-02T12:27:26Z","updated_at":"2017-06-02T12:28:52Z","html_url":"https://github.com/kubernetes/kubernetes/pull/46580#discussion_r119843817","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46580","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/119843817"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/46580#discussion_r119843817"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46580"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46580","id":122792517,"html_url":"https://github.com/kubernetes/kubernetes/pull/46580","diff_url":"https://github.com/kubernetes/kubernetes/pull/46580.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/46580.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46580","number":46580,"state":"open","locked":false,"title":"Implement IPVS-based in-cluster service load balancing","user":{"login":"dujun1990","id":28770520,"avatar_url":"https://avatars1.githubusercontent.com/u/28770520?v=3","gravatar_id":"","url":"https://api.github.com/users/dujun1990","html_url":"https://github.com/dujun1990","followers_url":"https://api.github.com/users/dujun1990/followers","following_url":"https://api.github.com/users/dujun1990/following{/other_user}","gists_url":"https://api.github.com/users/dujun1990/gists{/gist_id}","starred_url":"https://api.github.com/users/dujun1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dujun1990/subscriptions","organizations_url":"https://api.github.com/users/dujun1990/orgs","repos_url":"https://api.github.com/users/dujun1990/repos","events_url":"https://api.github.com/users/dujun1990/events{/privacy}","received_events_url":"https://api.github.com/users/dujun1990/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://github.com/kubernetes/community/blob/master/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nImplement IPVS-based in-cluster service load balancing. It can provide some performance enhancement and some other benefitsto kube proxy while comparing iptables and userspace mode. Besides, it also support more sophisticated load balancing algorithms than iptables (least conns, weighted, hash and so on).\r\n\r\n**Which issue this PR fixes**\r\n\r\n#17470 #44063\r\n\r\n**Special notes for your reviewer**:\r\n\r\n* Because of lvs-nat will do masquerading for all traffic, this implementation needs enable `--masquerade` flag of kube-proxy for cross-host communication and will break network policy.\r\n\r\n* Since ipvs proxy share some util functions with iptables proxy, I moved some util functions to `/pkg/proxy/util` and have not let iptables proxy use them yet.\r\n\r\n@thockin @quinton-hoole @kevin-wangzefeng @deepak-vij @haibinxie @dhilipkumars @fisherxu \r\n","created_at":"2017-05-28T11:35:46Z","updated_at":"2017-06-02T12:28:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f2ab3508429fa6b9e360c0bfba30bf4763cd143","assignee":{"login":"jbeda","id":37310,"avatar_url":"https://avatars1.githubusercontent.com/u/37310?v=3","gravatar_id":"","url":"https://api.github.com/users/jbeda","html_url":"https://github.com/jbeda","followers_url":"https://api.github.com/users/jbeda/followers","following_url":"https://api.github.com/users/jbeda/following{/other_user}","gists_url":"https://api.github.com/users/jbeda/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeda/subscriptions","organizations_url":"https://api.github.com/users/jbeda/orgs","repos_url":"https://api.github.com/users/jbeda/repos","events_url":"https://api.github.com/users/jbeda/events{/privacy}","received_events_url":"https://api.github.com/users/jbeda/received_events","type":"User","site_admin":false},"assignees":[{"login":"jbeda","id":37310,"avatar_url":"https://avatars1.githubusercontent.com/u/37310?v=3","gravatar_id":"","url":"https://api.github.com/users/jbeda","html_url":"https://github.com/jbeda","followers_url":"https://api.github.com/users/jbeda/followers","following_url":"https://api.github.com/users/jbeda/following{/other_user}","gists_url":"https://api.github.com/users/jbeda/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeda/subscriptions","organizations_url":"https://api.github.com/users/jbeda/orgs","repos_url":"https://api.github.com/users/jbeda/repos","events_url":"https://api.github.com/users/jbeda/events{/privacy}","received_events_url":"https://api.github.com/users/jbeda/received_events","type":"User","site_admin":false},{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars0.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46580/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46580/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/46580/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/27d1575fb62551256f9a17d9258f64f908a307e0","head":{"label":"Huawei-PaaS:kube-proxy-ipvs-pr","ref":"kube-proxy-ipvs-pr","sha":"27d1575fb62551256f9a17d9258f64f908a307e0","user":{"login":"Huawei-PaaS","id":6876878,"avatar_url":"https://avatars3.githubusercontent.com/u/6876878?v=3","gravatar_id":"","url":"https://api.github.com/users/Huawei-PaaS","html_url":"https://github.com/Huawei-PaaS","followers_url":"https://api.github.com/users/Huawei-PaaS/followers","following_url":"https://api.github.com/users/Huawei-PaaS/following{/other_user}","gists_url":"https://api.github.com/users/Huawei-PaaS/gists{/gist_id}","starred_url":"https://api.github.com/users/Huawei-PaaS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Huawei-PaaS/subscriptions","organizations_url":"https://api.github.com/users/Huawei-PaaS/orgs","repos_url":"https://api.github.com/users/Huawei-PaaS/repos","events_url":"https://api.github.com/users/Huawei-PaaS/events{/privacy}","received_events_url":"https://api.github.com/users/Huawei-PaaS/received_events","type":"Organization","site_admin":false},"repo":{"id":40632995,"name":"kubernetes","full_name":"Huawei-PaaS/kubernetes","owner":{"login":"Huawei-PaaS","id":6876878,"avatar_url":"https://avatars3.githubusercontent.com/u/6876878?v=3","gravatar_id":"","url":"https://api.github.com/users/Huawei-PaaS","html_url":"https://github.com/Huawei-PaaS","followers_url":"https://api.github.com/users/Huawei-PaaS/followers","following_url":"https://api.github.com/users/Huawei-PaaS/following{/other_user}","gists_url":"https://api.github.com/users/Huawei-PaaS/gists{/gist_id}","starred_url":"https://api.github.com/users/Huawei-PaaS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Huawei-PaaS/subscriptions","organizations_url":"https://api.github.com/users/Huawei-PaaS/orgs","repos_url":"https://api.github.com/users/Huawei-PaaS/repos","events_url":"https://api.github.com/users/Huawei-PaaS/events{/privacy}","received_events_url":"https://api.github.com/users/Huawei-PaaS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Huawei-PaaS/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/Huawei-PaaS/kubernetes","forks_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/forks","keys_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/teams","hooks_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/events","assignees_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/tags","blobs_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/languages","stargazers_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/subscription","commits_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/merges","archive_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/downloads","issues_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/Huawei-PaaS/kubernetes/deployments","created_at":"2015-08-13T01:37:46Z","updated_at":"2017-05-16T21:38:17Z","pushed_at":"2017-06-01T18:17:05Z","git_url":"git://github.com/Huawei-PaaS/kubernetes.git","ssh_url":"git@github.com:Huawei-PaaS/kubernetes.git","clone_url":"https://github.com/Huawei-PaaS/kubernetes.git","svn_url":"https://github.com/Huawei-PaaS/kubernetes","homepage":"http://kubernetes.io","size":426000,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":1,"forks":4,"open_issues":1,"watchers":4,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f0962765a7374172625847c84630d3b522ea728f","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-06-02T11:19:04Z","pushed_at":"2017-06-02T12:20:49Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":655356,"stargazers_count":23666,"watchers_count":23666,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8372,"mirror_url":null,"open_issues_count":5246,"forks":8372,"open_issues":5246,"watchers":23666,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46580"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/46580"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/46580"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/46580/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46580/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/46580/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/27d1575fb62551256f9a17d9258f64f908a307e0"}}}}
{"actor":{"display_login":"hustcat"}}