{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/composer/pulls/comments/126112279","pull_request_review_id":48566225,"id":126112279,"diff_hunk":"@@ -55,6 +54,36 @@ class Factory {\n      */\n     constructor(modelManager) {\n         this.modelManager = modelManager;\n+\n+        this.initializeNewObject = (newObject, classDeclaration, clientOptions) => {","path":"packages/composer-common/lib/factory.js","position":13,"original_position":13,"commit_id":"faf65aaddd903777c93882dd5139b8dd10562561","original_commit_id":"faf65aaddd903777c93882dd5139b8dd10562561","user":{"login":"bestbeforetoday","id":4856862,"avatar_url":"https://avatars0.githubusercontent.com/u/4856862?v=3","gravatar_id":"","url":"https://api.github.com/users/bestbeforetoday","html_url":"https://github.com/bestbeforetoday","followers_url":"https://api.github.com/users/bestbeforetoday/followers","following_url":"https://api.github.com/users/bestbeforetoday/following{/other_user}","gists_url":"https://api.github.com/users/bestbeforetoday/gists{/gist_id}","starred_url":"https://api.github.com/users/bestbeforetoday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestbeforetoday/subscriptions","organizations_url":"https://api.github.com/users/bestbeforetoday/orgs","repos_url":"https://api.github.com/users/bestbeforetoday/repos","events_url":"https://api.github.com/users/bestbeforetoday/events{/privacy}","received_events_url":"https://api.github.com/users/bestbeforetoday/received_events","type":"User","site_admin":false},"body":"Your'e right! I was getting confused between private and privileged functions. I've learnt something at least. :)\r\n\r\nSo for functions that we don't want any code (even our own internal code) outside the containing class to call, how should we best indicate that? JSDoc comments? Underscore prefix? Something else?","created_at":"2017-07-07T10:00:41Z","updated_at":"2017-07-07T10:00:41Z","html_url":"https://github.com/hyperledger/composer/pull/1434#discussion_r126112279","pull_request_url":"https://api.github.com/repos/hyperledger/composer/pulls/1434","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/comments/126112279"},"html":{"href":"https://github.com/hyperledger/composer/pull/1434#discussion_r126112279"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/1434"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/composer/pulls/1434","id":128407132,"html_url":"https://github.com/hyperledger/composer/pull/1434","diff_url":"https://github.com/hyperledger/composer/pull/1434.diff","patch_url":"https://github.com/hyperledger/composer/pull/1434.patch","issue_url":"https://api.github.com/repos/hyperledger/composer/issues/1434","number":1434,"state":"open","locked":false,"title":"PR for #796","user":{"login":"bestbeforetoday","id":4856862,"avatar_url":"https://avatars0.githubusercontent.com/u/4856862?v=3","gravatar_id":"","url":"https://api.github.com/users/bestbeforetoday","html_url":"https://github.com/bestbeforetoday","followers_url":"https://api.github.com/users/bestbeforetoday/followers","following_url":"https://api.github.com/users/bestbeforetoday/following{/other_user}","gists_url":"https://api.github.com/users/bestbeforetoday/gists{/gist_id}","starred_url":"https://api.github.com/users/bestbeforetoday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestbeforetoday/subscriptions","organizations_url":"https://api.github.com/users/bestbeforetoday/orgs","repos_url":"https://api.github.com/users/bestbeforetoday/repos","events_url":"https://api.github.com/users/bestbeforetoday/events{/privacy}","received_events_url":"https://api.github.com/users/bestbeforetoday/received_events","type":"User","site_admin":false},"body":"Change composer-common/Factory API so that:\r\n- An _includeOptionalFields_ option controls whether optional fields are included in generated data.\r\n- Array field values are generated with a single element (rather than three) for _sample_ data generation, and with no values for _empty_ data generation.\r\n\r\nAdd _Optional Properties_ checkbox to create new resource and submit transaction dialogs.","created_at":"2017-06-30T16:32:20Z","updated_at":"2017-07-07T10:00:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"459f987c691f1bbdfb8c3021a2351487f3fe81c7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/composer/pulls/1434/commits","review_comments_url":"https://api.github.com/repos/hyperledger/composer/pulls/1434/comments","review_comment_url":"https://api.github.com/repos/hyperledger/composer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/composer/issues/1434/comments","statuses_url":"https://api.github.com/repos/hyperledger/composer/statuses/faf65aaddd903777c93882dd5139b8dd10562561","head":{"label":"bestbeforetoday:issue796","ref":"issue796","sha":"faf65aaddd903777c93882dd5139b8dd10562561","user":{"login":"bestbeforetoday","id":4856862,"avatar_url":"https://avatars0.githubusercontent.com/u/4856862?v=3","gravatar_id":"","url":"https://api.github.com/users/bestbeforetoday","html_url":"https://github.com/bestbeforetoday","followers_url":"https://api.github.com/users/bestbeforetoday/followers","following_url":"https://api.github.com/users/bestbeforetoday/following{/other_user}","gists_url":"https://api.github.com/users/bestbeforetoday/gists{/gist_id}","starred_url":"https://api.github.com/users/bestbeforetoday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestbeforetoday/subscriptions","organizations_url":"https://api.github.com/users/bestbeforetoday/orgs","repos_url":"https://api.github.com/users/bestbeforetoday/repos","events_url":"https://api.github.com/users/bestbeforetoday/events{/privacy}","received_events_url":"https://api.github.com/users/bestbeforetoday/received_events","type":"User","site_admin":false},"repo":{"id":94881424,"name":"composer","full_name":"bestbeforetoday/composer","owner":{"login":"bestbeforetoday","id":4856862,"avatar_url":"https://avatars0.githubusercontent.com/u/4856862?v=3","gravatar_id":"","url":"https://api.github.com/users/bestbeforetoday","html_url":"https://github.com/bestbeforetoday","followers_url":"https://api.github.com/users/bestbeforetoday/followers","following_url":"https://api.github.com/users/bestbeforetoday/following{/other_user}","gists_url":"https://api.github.com/users/bestbeforetoday/gists{/gist_id}","starred_url":"https://api.github.com/users/bestbeforetoday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bestbeforetoday/subscriptions","organizations_url":"https://api.github.com/users/bestbeforetoday/orgs","repos_url":"https://api.github.com/users/bestbeforetoday/repos","events_url":"https://api.github.com/users/bestbeforetoday/events{/privacy}","received_events_url":"https://api.github.com/users/bestbeforetoday/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bestbeforetoday/composer","description":"Composer is a framework for building Blockchain business networks","fork":true,"url":"https://api.github.com/repos/bestbeforetoday/composer","forks_url":"https://api.github.com/repos/bestbeforetoday/composer/forks","keys_url":"https://api.github.com/repos/bestbeforetoday/composer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bestbeforetoday/composer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bestbeforetoday/composer/teams","hooks_url":"https://api.github.com/repos/bestbeforetoday/composer/hooks","issue_events_url":"https://api.github.com/repos/bestbeforetoday/composer/issues/events{/number}","events_url":"https://api.github.com/repos/bestbeforetoday/composer/events","assignees_url":"https://api.github.com/repos/bestbeforetoday/composer/assignees{/user}","branches_url":"https://api.github.com/repos/bestbeforetoday/composer/branches{/branch}","tags_url":"https://api.github.com/repos/bestbeforetoday/composer/tags","blobs_url":"https://api.github.com/repos/bestbeforetoday/composer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bestbeforetoday/composer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bestbeforetoday/composer/git/refs{/sha}","trees_url":"https://api.github.com/repos/bestbeforetoday/composer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bestbeforetoday/composer/statuses/{sha}","languages_url":"https://api.github.com/repos/bestbeforetoday/composer/languages","stargazers_url":"https://api.github.com/repos/bestbeforetoday/composer/stargazers","contributors_url":"https://api.github.com/repos/bestbeforetoday/composer/contributors","subscribers_url":"https://api.github.com/repos/bestbeforetoday/composer/subscribers","subscription_url":"https://api.github.com/repos/bestbeforetoday/composer/subscription","commits_url":"https://api.github.com/repos/bestbeforetoday/composer/commits{/sha}","git_commits_url":"https://api.github.com/repos/bestbeforetoday/composer/git/commits{/sha}","comments_url":"https://api.github.com/repos/bestbeforetoday/composer/comments{/number}","issue_comment_url":"https://api.github.com/repos/bestbeforetoday/composer/issues/comments{/number}","contents_url":"https://api.github.com/repos/bestbeforetoday/composer/contents/{+path}","compare_url":"https://api.github.com/repos/bestbeforetoday/composer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bestbeforetoday/composer/merges","archive_url":"https://api.github.com/repos/bestbeforetoday/composer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bestbeforetoday/composer/downloads","issues_url":"https://api.github.com/repos/bestbeforetoday/composer/issues{/number}","pulls_url":"https://api.github.com/repos/bestbeforetoday/composer/pulls{/number}","milestones_url":"https://api.github.com/repos/bestbeforetoday/composer/milestones{/number}","notifications_url":"https://api.github.com/repos/bestbeforetoday/composer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bestbeforetoday/composer/labels{/name}","releases_url":"https://api.github.com/repos/bestbeforetoday/composer/releases{/id}","deployments_url":"https://api.github.com/repos/bestbeforetoday/composer/deployments","created_at":"2017-06-20T10:55:35Z","updated_at":"2017-06-20T10:55:40Z","pushed_at":"2017-07-06T14:19:18Z","git_url":"git://github.com/bestbeforetoday/composer.git","ssh_url":"git@github.com:bestbeforetoday/composer.git","clone_url":"https://github.com/bestbeforetoday/composer.git","svn_url":"https://github.com/bestbeforetoday/composer","homepage":"https://hyperledger.github.io/composer","size":81571,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"e682b18c22c4a1594d52249e1f443467a19ab39b","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars1.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":80234065,"name":"composer","full_name":"hyperledger/composer","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars1.githubusercontent.com/u/7657900?v=3","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/composer","description":"Composer is a framework for building Blockchain business networks","fork":false,"url":"https://api.github.com/repos/hyperledger/composer","forks_url":"https://api.github.com/repos/hyperledger/composer/forks","keys_url":"https://api.github.com/repos/hyperledger/composer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/composer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/composer/teams","hooks_url":"https://api.github.com/repos/hyperledger/composer/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/composer/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/composer/events","assignees_url":"https://api.github.com/repos/hyperledger/composer/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/composer/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/composer/tags","blobs_url":"https://api.github.com/repos/hyperledger/composer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/composer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/composer/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/composer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/composer/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/composer/languages","stargazers_url":"https://api.github.com/repos/hyperledger/composer/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/composer/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/composer/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/composer/subscription","commits_url":"https://api.github.com/repos/hyperledger/composer/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/composer/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/composer/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/composer/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/composer/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/composer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/composer/merges","archive_url":"https://api.github.com/repos/hyperledger/composer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/composer/downloads","issues_url":"https://api.github.com/repos/hyperledger/composer/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/composer/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/composer/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/composer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/composer/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/composer/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/composer/deployments","created_at":"2017-01-27T18:27:47Z","updated_at":"2017-07-06T23:18:12Z","pushed_at":"2017-07-07T09:22:32Z","git_url":"git://github.com/hyperledger/composer.git","ssh_url":"git@github.com:hyperledger/composer.git","clone_url":"https://github.com/hyperledger/composer.git","svn_url":"https://github.com/hyperledger/composer","homepage":"https://hyperledger.github.io/composer","size":85973,"stargazers_count":137,"watchers_count":137,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":110,"mirror_url":null,"open_issues_count":187,"forks":110,"open_issues":187,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/1434"},"html":{"href":"https://github.com/hyperledger/composer/pull/1434"},"issue":{"href":"https://api.github.com/repos/hyperledger/composer/issues/1434"},"comments":{"href":"https://api.github.com/repos/hyperledger/composer/issues/1434/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/1434/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/composer/pulls/1434/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/composer/statuses/faf65aaddd903777c93882dd5139b8dd10562561"}}}}
{"actor":{"display_login":"bestbeforetoday"}}