{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/ui/pulls/comments/153815519","pull_request_review_id":79862527,"id":153815519,"diff_hunk":"@@ -31,35 +32,66 @@ export function getById(items, id, { idAttr = 'id', childrenAttr = 'children' }\n }\n \n /**\n- * Internal\n+ * Check if an `item` is a leaf element, by checking if it\n+ * has a non empty `childrenAttr`\n+ * @param {Object} item the item wich be checked for children\n+ * @param {String} childrenAttr name of the attributes holding children\n+ * @return {Boolean}\n+ */\n+function isLeafElement(item, childrenAttr) {\n+\treturn item.get(childrenAttr, new List()).size === 0;\n+}\n+\n+/**\n+ * if item match the query it will be concatened into the accumulator\n+ * else the accumulator is returned without modification\n+ * @param {Object} item the item on wich the matchign will happen\n+ * @param {String} currentPosition the element position inside the parsed tree\n+ * @param {String} query the query element used to match\n+ * @param {String} nameAttr the attribute of item on wich should be matched","path":"packages/containers/src/SelectObject/SelectObject.container.js","position":35,"original_position":35,"commit_id":"04fdd25e7be205a3843e1776cec4545e31bbf1e7","original_commit_id":"04fdd25e7be205a3843e1776cec4545e31bbf1e7","user":{"login":"jsomsanith","id":10761073,"avatar_url":"https://avatars2.githubusercontent.com/u/10761073?v=4","gravatar_id":"","url":"https://api.github.com/users/jsomsanith","html_url":"https://github.com/jsomsanith","followers_url":"https://api.github.com/users/jsomsanith/followers","following_url":"https://api.github.com/users/jsomsanith/following{/other_user}","gists_url":"https://api.github.com/users/jsomsanith/gists{/gist_id}","starred_url":"https://api.github.com/users/jsomsanith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsomsanith/subscriptions","organizations_url":"https://api.github.com/users/jsomsanith/orgs","repos_url":"https://api.github.com/users/jsomsanith/repos","events_url":"https://api.github.com/users/jsomsanith/events{/privacy}","received_events_url":"https://api.github.com/users/jsomsanith/received_events","type":"User","site_admin":false},"body":"typo `wich`","created_at":"2017-11-29T15:14:07Z","updated_at":"2017-11-29T15:32:25Z","html_url":"https://github.com/Talend/ui/pull/880#discussion_r153815519","pull_request_url":"https://api.github.com/repos/Talend/ui/pulls/880","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments/153815519"},"html":{"href":"https://github.com/Talend/ui/pull/880#discussion_r153815519"},"pull_request":{"href":"https://api.github.com/repos/Talend/ui/pulls/880"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/ui/pulls/880","id":155030534,"html_url":"https://github.com/Talend/ui/pull/880","diff_url":"https://github.com/Talend/ui/pull/880.diff","patch_url":"https://github.com/Talend/ui/pull/880.patch","issue_url":"https://api.github.com/repos/Talend/ui/issues/880","number":880,"state":"open","locked":false,"title":"feat(SelectObject): display results as ListGroupItem","user":{"login":"jmfrancois","id":19857479,"avatar_url":"https://avatars2.githubusercontent.com/u/19857479?v=4","gravatar_id":"","url":"https://api.github.com/users/jmfrancois","html_url":"https://github.com/jmfrancois","followers_url":"https://api.github.com/users/jmfrancois/followers","following_url":"https://api.github.com/users/jmfrancois/following{/other_user}","gists_url":"https://api.github.com/users/jmfrancois/gists{/gist_id}","starred_url":"https://api.github.com/users/jmfrancois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmfrancois/subscriptions","organizations_url":"https://api.github.com/users/jmfrancois/orgs","repos_url":"https://api.github.com/users/jmfrancois/repos","events_url":"https://api.github.com/users/jmfrancois/events{/privacy}","received_events_url":"https://api.github.com/users/jmfrancois/received_events","type":"User","site_admin":false},"body":"**What is the problem this PR is trying to solve?**\r\n\r\nSearch on tree is not really good. \r\n\r\n**What is the chosen solution to this problem?**\r\n\r\nWhen starting typing in the FilterBar let's switch to list of results\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The PR commit message follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md)\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n- [ ] Related design / discussions / pages (not in jira), if any, are all linked or available in the PR\r\n\r\n\r\n","created_at":"2017-11-28T10:23:04Z","updated_at":"2017-11-29T15:32:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed739f1118b9c5cd3799162dac1ea09ec9295f64","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/ui/pulls/880/commits","review_comments_url":"https://api.github.com/repos/Talend/ui/pulls/880/comments","review_comment_url":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/ui/issues/880/comments","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/04fdd25e7be205a3843e1776cec4545e31bbf1e7","head":{"label":"Talend:components/selectobject/further-enhancement","ref":"components/selectobject/further-enhancement","sha":"04fdd25e7be205a3843e1776cec4545e31bbf1e7","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2017-11-27T10:37:39Z","pushed_at":"2017-11-29T15:25:08Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"git@github.com:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":19951,"stargazers_count":36,"watchers_count":36,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":16,"open_issues":40,"watchers":36,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"7257b6877da6f2086816c5ec42c21c888b2e5e5d","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2017-11-27T10:37:39Z","pushed_at":"2017-11-29T15:25:08Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"git@github.com:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":19951,"stargazers_count":36,"watchers_count":36,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":16,"open_issues":40,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/880"},"html":{"href":"https://github.com/Talend/ui/pull/880"},"issue":{"href":"https://api.github.com/repos/Talend/ui/issues/880"},"comments":{"href":"https://api.github.com/repos/Talend/ui/issues/880/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/ui/pulls/880/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/ui/pulls/880/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/ui/statuses/04fdd25e7be205a3843e1776cec4545e31bbf1e7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jsomsanith"}}