{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/14223","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/14223/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/14223/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/14223/events","html_url":"https://github.com/nodejs/node/pull/14223","id":242790833,"number":14223,"title":"repl: deprecate REPLServer.parseREPLKeyword","user":{"login":"lance","id":15952,"avatar_url":"https://avatars1.githubusercontent.com/u/15952?v=4","gravatar_id":"","url":"https://api.github.com/users/lance","html_url":"https://github.com/lance","followers_url":"https://api.github.com/users/lance/followers","following_url":"https://api.github.com/users/lance/following{/other_user}","gists_url":"https://api.github.com/users/lance/gists{/gist_id}","starred_url":"https://api.github.com/users/lance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lance/subscriptions","organizations_url":"https://api.github.com/users/lance/orgs","repos_url":"https://api.github.com/users/lance/repos","events_url":"https://api.github.com/users/lance/events{/privacy}","received_events_url":"https://api.github.com/users/lance/received_events","type":"User","site_admin":false},"labels":[{"id":155435882,"url":"https://api.github.com/repos/nodejs/node/labels/repl","name":"repl","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2017-07-13T18:30:58Z","updated_at":"2017-08-07T13:12:43Z","closed_at":"2017-08-02T18:43:32Z","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/14223","html_url":"https://github.com/nodejs/node/pull/14223","diff_url":"https://github.com/nodejs/node/pull/14223.diff","patch_url":"https://github.com/nodejs/node/pull/14223.patch"},"body":"This method does not need to be visible to user code. It has been\r\nundocumented since it was introduced which was perhaps v0.8.9, as\r\nfar as I can tell. \r\n\r\nThe motivation for this change is that the method is simply an\r\nimplementation detail of the `REPLServer` behavior, and does\r\nnot need to be exposed to user code.\r\n\r\nThis change adds documentation of the method with a deprecation\r\nwarning as recommended by @jasnell in\r\nhttps://github.com/nodejs/node/issues/7619#issuecomment-236608809.\r\n\r\nRefs: https://github.com/nodejs/node/issues/7619\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\nrepl, doc\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/320659404","html_url":"https://github.com/nodejs/node/pull/14223#issuecomment-320659404","issue_url":"https://api.github.com/repos/nodejs/node/issues/14223","id":320659404,"user":{"login":"addaleax","id":899444,"avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"created_at":"2017-08-07T13:12:43Z","updated_at":"2017-08-07T13:12:43Z","body":"Shouldn’t this have been `semver-major`? I’m labelling as such but I’d like to point out that this should really have gotten another @nodejs/ctc approval according to our rules."}}
{"actor":{"display_login":"addaleax"}}