{"action":"closed","issue":{"url":"https://api.github.com/repos/phetsims/balloons-and-static-electricity/issues/243","repository_url":"https://api.github.com/repos/phetsims/balloons-and-static-electricity","labels_url":"https://api.github.com/repos/phetsims/balloons-and-static-electricity/issues/243/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/balloons-and-static-electricity/issues/243/comments","events_url":"https://api.github.com/repos/phetsims/balloons-and-static-electricity/issues/243/events","html_url":"https://github.com/phetsims/balloons-and-static-electricity/issues/243","id":204468287,"number":243,"title":"sim does its own dt calculation, using milliseconds instead of seconds","user":{"login":"jessegreenberg","id":6396244,"avatar_url":"https://avatars.githubusercontent.com/u/6396244?v=3","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false},"labels":[{"id":39790370,"url":"https://api.github.com/repos/phetsims/balloons-and-static-electricity/labels/dev:code-review","name":"dev:code-review","color":"104E8B","default":false}],"state":"closed","locked":false,"assignee":{"login":"jessegreenberg","id":6396244,"avatar_url":"https://avatars.githubusercontent.com/u/6396244?v=3","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false},"assignees":[{"login":"jessegreenberg","id":6396244,"avatar_url":"https://avatars.githubusercontent.com/u/6396244?v=3","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-02-01T00:50:30Z","updated_at":"2017-02-14T00:19:02Z","closed_at":"2017-02-14T00:19:02Z","body":"Issue moved from phet-io repo https://github.com/phetsims/phet-io/issues/1005 and discovered during instrumentation:\r\n\r\nThe file BalloonsAndStaticElectricty.js contains a step function with the code:\r\n\r\n      var curTime = Date.now();\r\n      var dt = curTime - this.oldTime;\r\n\r\n      this.balloons.forEach( function( balloon ) {\r\n        if ( balloon.isVisibleProperty.get() ) {\r\n          balloon.step( self, dt );\r\n        }\r\n      } );\r\n\r\n      this.oldTime = curTime;\r\n\r\nThe step function is supplied a dt value by the framework, so I have no idea why this is being done. Also, it ends up providing a value that is in milliseconds instead of seconds (as our framework does), so to fix this some work would likely need to be done on the balloon model code."}}
{"actor":{"display_login":"jessegreenberg"}}