{"action":"created","issue":{"url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/177","repository_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware","labels_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/177/labels{/name}","comments_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/177/comments","events_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/177/events","html_url":"https://github.com/pburtchaell/redux-promise-middleware/issues/177","id":262152130,"number":177,"title":"Allow empty separator","user":{"login":"tiagobnobrega","id":3362485,"avatar_url":"https://avatars0.githubusercontent.com/u/3362485?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagobnobrega","html_url":"https://github.com/tiagobnobrega","followers_url":"https://api.github.com/users/tiagobnobrega/followers","following_url":"https://api.github.com/users/tiagobnobrega/following{/other_user}","gists_url":"https://api.github.com/users/tiagobnobrega/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagobnobrega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagobnobrega/subscriptions","organizations_url":"https://api.github.com/users/tiagobnobrega/orgs","repos_url":"https://api.github.com/users/tiagobnobrega/repos","events_url":"https://api.github.com/users/tiagobnobrega/events{/privacy}","received_events_url":"https://api.github.com/users/tiagobnobrega/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-02T16:55:45Z","updated_at":"2017-10-03T11:10:23Z","closed_at":"2017-10-02T20:28:07Z","author_association":"NONE","body":"I'm not sure if it's Bug or a feature request.\r\nI would like the ability to use empty (blank string) as separator. The idea is to disable separator appending. \r\n\r\nHere's the main idea:\r\nI would configure the middleware like this:\r\n\r\n```javascript\r\npromiseMiddleware({\r\n  promiseTypeSeparator:\"\",//do not use separators, we append manually for status success and fail\r\n  promiseTypeSuffixes: ['', '_SUCCESS', '_FAIL']\r\n});\r\n```\r\nThen, when I call \"FETCH_THING\" action. It would dispacth the \"FETCH_THING\" action immediately,  \"FETCH_THING_SUCCESS\" on fulfilled and \"FETCH_THING_FAIL\" on error .\r\n\r\nAs it is now. It would use the default separator \"_\".\r\n\r\nI think it could be acomplished by changing this on promiseMiddleware function:\r\n\r\n```javascript\r\nfunction promiseMiddleware() {\r\n  var config = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {};\r\n\r\nvar promiseTypeSuffixes = config.promiseTypeSuffixes || defaultTypes;\r\n//var promiseTypeSeparator = config.promiseTypeSeparator || '_';\r\nvar promiseTypeSeparator = (config.promiseTypeSeparator ==null ? '_': config.promiseTypeSeparator )\r\n...\r\n```\r\nPS: Code not tested.\r\nEDITED: Ops... Corrected wrong variable.\r\n\r\n "},"comment":{"url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/comments/333810557","html_url":"https://github.com/pburtchaell/redux-promise-middleware/issues/177#issuecomment-333810557","issue_url":"https://api.github.com/repos/pburtchaell/redux-promise-middleware/issues/177","id":333810557,"user":{"login":"tiagobnobrega","id":3362485,"avatar_url":"https://avatars0.githubusercontent.com/u/3362485?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagobnobrega","html_url":"https://github.com/tiagobnobrega","followers_url":"https://api.github.com/users/tiagobnobrega/followers","following_url":"https://api.github.com/users/tiagobnobrega/following{/other_user}","gists_url":"https://api.github.com/users/tiagobnobrega/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagobnobrega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagobnobrega/subscriptions","organizations_url":"https://api.github.com/users/tiagobnobrega/orgs","repos_url":"https://api.github.com/users/tiagobnobrega/repos","events_url":"https://api.github.com/users/tiagobnobrega/events{/privacy}","received_events_url":"https://api.github.com/users/tiagobnobrega/received_events","type":"User","site_admin":false},"created_at":"2017-10-03T11:10:23Z","updated_at":"2017-10-03T11:10:23Z","author_association":"NONE","body":"I get your point... but it also bothers me a little that the original action never gets fired to my reducers. Do you think it could be possible to at least dispatch the original action to the reducers?"}}
{"actor":{"display_login":"tiagobnobrega"}}