{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/comments/110060591","pull_request_review_id":31204889,"id":110060591,"diff_hunk":"@@ -146,11 +161,42 @@ public boolean hasNull() {\n \n   @Override\n   public PartitionFunction getPartitionFunction() {\n-    return null;\n+    return partitionFunction;\n   }\n \n   @Override\n   public List<IntRange> getPartitionRanges() {\n-    return null;\n+    return partitionRanges;\n   }\n+\n+  /**\n+   * For each element in the dictionary for a column\n+   * Checks if the given value lies within one of the partition ranges. If the value is not within\n+   * any of the partition ranges, partitioning is dropped. The effect of that is:\n+   * <ul>\n+   *   <li> Subsequent values will not be checked against partition ranges. </li>\n+   *   <li> Partition information will not be written out to the metadata for this column. </li>\n+   * </ul>\n+   *\n+   */\n+  void checkPartition() {\n+    // Iterate over the dictionary to check the partitioning\n+    final int length = _dictionaryReader.length();\n+    for (int i = 0; ((i < length) && (partitionFunction != null)); i++) {\n+      int partition = partitionFunction.getPartition(_dictionaryReader.get(i));\n+      for (IntRange partitionValue : partitionRanges) {\n+        if (partition < partitionValue.getMinimumInteger() || partition > partitionValue.getMaximumInteger()) {","path":"pinot-core/src/main/java/com/linkedin/pinot/core/realtime/converter/stats/RealtimeColumnStatistics.java","position":76,"original_position":76,"commit_id":"b71cb8a38efc7b3c3f72d3c3f9ba40dceb79539b","original_commit_id":"b71cb8a38efc7b3c3f72d3c3f9ba40dceb79539b","user":{"login":"rven1","id":8718743,"avatar_url":"https://avatars2.githubusercontent.com/u/8718743?v=3","gravatar_id":"","url":"https://api.github.com/users/rven1","html_url":"https://github.com/rven1","followers_url":"https://api.github.com/users/rven1/followers","following_url":"https://api.github.com/users/rven1/following{/other_user}","gists_url":"https://api.github.com/users/rven1/gists{/gist_id}","starred_url":"https://api.github.com/users/rven1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rven1/subscriptions","organizations_url":"https://api.github.com/users/rven1/orgs","repos_url":"https://api.github.com/users/rven1/repos","events_url":"https://api.github.com/users/rven1/events{/privacy}","received_events_url":"https://api.github.com/users/rven1/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2017-04-06T01:01:39Z","updated_at":"2017-04-06T01:01:39Z","html_url":"https://github.com/linkedin/pinot/pull/1230#discussion_r110060591","pull_request_url":"https://api.github.com/repos/linkedin/pinot/pulls/1230","_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments/110060591"},"html":{"href":"https://github.com/linkedin/pinot/pull/1230#discussion_r110060591"},"pull_request":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/1230"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/pinot/pulls/1230","id":113798355,"html_url":"https://github.com/linkedin/pinot/pull/1230","diff_url":"https://github.com/linkedin/pinot/pull/1230.diff","patch_url":"https://github.com/linkedin/pinot/pull/1230.patch","issue_url":"https://api.github.com/repos/linkedin/pinot/issues/1230","number":1230,"state":"open","locked":false,"title":"Add support for partitioners in LLC realtime.","user":{"login":"rven1","id":8718743,"avatar_url":"https://avatars2.githubusercontent.com/u/8718743?v=3","gravatar_id":"","url":"https://api.github.com/users/rven1","html_url":"https://github.com/rven1","followers_url":"https://api.github.com/users/rven1/followers","following_url":"https://api.github.com/users/rven1/following{/other_user}","gists_url":"https://api.github.com/users/rven1/gists{/gist_id}","starred_url":"https://api.github.com/users/rven1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rven1/subscriptions","organizations_url":"https://api.github.com/users/rven1/orgs","repos_url":"https://api.github.com/users/rven1/repos","events_url":"https://api.github.com/users/rven1/events{/privacy}","received_events_url":"https://api.github.com/users/rven1/received_events","type":"User","site_admin":false},"body":null,"created_at":"2017-04-01T23:14:36Z","updated_at":"2017-04-06T01:01:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cfb9abe80db3c408da000051caedf8325b810eb0","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/pinot/pulls/1230/commits","review_comments_url":"https://api.github.com/repos/linkedin/pinot/pulls/1230/comments","review_comment_url":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/pinot/issues/1230/comments","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/b71cb8a38efc7b3c3f72d3c3f9ba40dceb79539b","head":{"label":"linkedin:partition_pruner","ref":"partition_pruner","sha":"b71cb8a38efc7b3c3f72d3c3f9ba40dceb79539b","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars0.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"name":"pinot","full_name":"linkedin/pinot","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars0.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2017-04-05T07:17:50Z","pushed_at":"2017-04-06T00:30:11Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"git@github.com:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":137919,"stargazers_count":1465,"watchers_count":1465,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":101,"forks":257,"open_issues":101,"watchers":1465,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"e923dc9a3a0a7fa2c78dfd77c036050166fcc5ea","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars0.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":19961085,"name":"pinot","full_name":"linkedin/pinot","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars0.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/pinot","description":"A realtime distributed OLAP datastore","fork":false,"url":"https://api.github.com/repos/linkedin/pinot","forks_url":"https://api.github.com/repos/linkedin/pinot/forks","keys_url":"https://api.github.com/repos/linkedin/pinot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/pinot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/pinot/teams","hooks_url":"https://api.github.com/repos/linkedin/pinot/hooks","issue_events_url":"https://api.github.com/repos/linkedin/pinot/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/pinot/events","assignees_url":"https://api.github.com/repos/linkedin/pinot/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/pinot/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/pinot/tags","blobs_url":"https://api.github.com/repos/linkedin/pinot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/pinot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/pinot/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/pinot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/pinot/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/pinot/languages","stargazers_url":"https://api.github.com/repos/linkedin/pinot/stargazers","contributors_url":"https://api.github.com/repos/linkedin/pinot/contributors","subscribers_url":"https://api.github.com/repos/linkedin/pinot/subscribers","subscription_url":"https://api.github.com/repos/linkedin/pinot/subscription","commits_url":"https://api.github.com/repos/linkedin/pinot/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/pinot/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/pinot/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/pinot/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/pinot/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/pinot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/pinot/merges","archive_url":"https://api.github.com/repos/linkedin/pinot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/pinot/downloads","issues_url":"https://api.github.com/repos/linkedin/pinot/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/pinot/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/pinot/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/pinot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/pinot/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/pinot/releases{/id}","deployments_url":"https://api.github.com/repos/linkedin/pinot/deployments","created_at":"2014-05-19T23:27:48Z","updated_at":"2017-04-05T07:17:50Z","pushed_at":"2017-04-06T00:30:11Z","git_url":"git://github.com/linkedin/pinot.git","ssh_url":"git@github.com:linkedin/pinot.git","clone_url":"https://github.com/linkedin/pinot.git","svn_url":"https://github.com/linkedin/pinot","homepage":"https://github.com/linkedin/pinot/wiki","size":137919,"stargazers_count":1465,"watchers_count":1465,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":101,"forks":257,"open_issues":101,"watchers":1465,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/1230"},"html":{"href":"https://github.com/linkedin/pinot/pull/1230"},"issue":{"href":"https://api.github.com/repos/linkedin/pinot/issues/1230"},"comments":{"href":"https://api.github.com/repos/linkedin/pinot/issues/1230/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/1230/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/pinot/pulls/1230/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/pinot/statuses/b71cb8a38efc7b3c3f72d3c3f9ba40dceb79539b"}}}}
{"actor":{"display_login":"rven1"}}