{"push_id":1737686282,"size":304,"distinct_size":304,"ref":"refs/heads/master","head":"54fe60f94a44caf939231bf7fd44669cb91c6b8f","before":"b067fe9846c494e7a8562b6d32675054af5b96fb","commits":[{"sha":"b9eeaef2435b38367080b428af2ef72726b633a2","author":{"name":"Aaron Chiu","email":"5e3fe025e68a1868ae4330ada78cd0369a932718@fb.com"},"message":"make ReactInstanceManager safer threading wise\n\nReviewed By: achen1\n\nDifferential Revision: D4883219\n\nfbshipit-source-id: 45671a6d51357fd51ca824a59f7b200c3df66b89","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/b9eeaef2435b38367080b428af2ef72726b633a2"},{"sha":"035f076594905e18ee7441930b37869fb0c9133a","author":{"name":"Aaron Chiu","email":"5e3fe025e68a1868ae4330ada78cd0369a932718@fb.com"},"message":"move calls that need to be on the UI thread out of setupReactContext()\n\nReviewed By: achen1\n\nDifferential Revision: D4890541\n\nfbshipit-source-id: 7fc87d3341a1cefd474481dcc1b7b6d02d92f445","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/035f076594905e18ee7441930b37869fb0c9133a"},{"sha":"54d8d10a6bb6267c0677d37e6b28c6428720536b","author":{"name":"Pieter De Baets","email":"377831b9cd0f79984db1fb62440ca394156e97b4@fb.com"},"message":"Construct ModuleHolder from ReactModuleInfo\n\nReviewed By: AaaChiuuu\n\nDifferential Revision: D4883331\n\nfbshipit-source-id: c901051d0aa5993142104126bbec5d76bd605e0b","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/54d8d10a6bb6267c0677d37e6b28c6428720536b"},{"sha":"09e7dbc9cbcb2434b8e6cea57cfc6a6dbdc932c1","author":{"name":"Ben Roth","email":"4304fe1542be185818fff34256df4aa6f6dc58fb@gmail.com"},"message":"Protect against fatal YellowBox error when stack frame has no file\n\nSummary:\nMotivation: When viewing a stack trace in YellowBox where one or more of the stack frames has no `file`, JS will encounter the fatal error `null is not an object (evaluating 'file.split')`. This can happen, for example, when running a bundle for which no source maps were generated.\nCloses https://github.com/facebook/react-native/pull/13512\n\nDifferential Revision: D4896480\n\nPulled By: javache\n\nfbshipit-source-id: 202c793a47abb83a4700a5778a92b0b5828b01a3","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/09e7dbc9cbcb2434b8e6cea57cfc6a6dbdc932c1"},{"sha":"a6828f2127ad86cb47e0dff69f5b27ac06ef59d9","author":{"name":"Jean Lauliac","email":"7e54b6bf4c2d61f2bb0f90454ffb09854716e3bb@fb.com"},"message":"packager: remove Cache\n\nSummary: It seems we don't need that one much anymore, as we have a FS-based cache for files, and removing the last callsites doesn't really change perf, as we have to read these files eventually (plus some of these are read from `HasteMap`, that I believe is already dead code).\n\nReviewed By: davidaurelio\n\nDifferential Revision: D4884220\n\nfbshipit-source-id: 4cf59f16a6f0bdf275abe81e9de2f34816866bae","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/a6828f2127ad86cb47e0dff69f5b27ac06ef59d9"},{"sha":"1c53c9b20f83deb943599fe0b40db7620696ad05","author":{"name":"Jean Lauliac","email":"7e54b6bf4c2d61f2bb0f90454ffb09854716e3bb@fb.com"},"message":"packager: Module: remove dead cacheTransformResults option\n\nReviewed By: davidaurelio\n\nDifferential Revision: D4884343\n\nfbshipit-source-id: ae29757690d9b56d6f166bc86573aca9b1b6b65c","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/1c53c9b20f83deb943599fe0b40db7620696ad05"},{"sha":"4ab4df07afb9766fda373138897bbbecb1d2d90d","author":{"name":"Jean Lauliac","email":"7e54b6bf4c2d61f2bb0f90454ffb09854716e3bb@fb.com"},"message":"packager: buck: transform-module: add support for assets\n\nReviewed By: davidaurelio\n\nDifferential Revision: D4868312\n\nfbshipit-source-id: 44d20a5ed73637a9b3f43a99b5c82931f3e15dc6","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/4ab4df07afb9766fda373138897bbbecb1d2d90d"},{"sha":"c6f5717d2b6e32b79010d2504890ca1b098fee63","author":{"name":"Jean Lauliac","email":"7e54b6bf4c2d61f2bb0f90454ffb09854716e3bb@fb.com"},"message":"packager: ResolutionRequest: stronger option typing\n\nReviewed By: cpojer\n\nDifferential Revision: D4906382\n\nfbshipit-source-id: 1696c3e7fe07c84a3a497740dc87a237d9b71d1e","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/c6f5717d2b6e32b79010d2504890ca1b098fee63"},{"sha":"f47ed2b5b990a8160358a38180d856b9324b1be9","author":{"name":"Gabe Levi","email":"74afe5e6f5651d063dedb67b26f7904eea6727d4@fb.com"},"message":"Bump the flow-bin version to ^0.44.2\n\nSummary:\nThere's something wrong with the Linux binary in Flow v0.44.1. It doesn't work. Flow v0.44.2 fixes, however CircleCI may have cached Flow v0.44.1. Putting this PR up in case it's needed.\n\nyarn install\nyarn run flow\nCloses https://github.com/facebook/react-native/pull/13549\n\nDifferential Revision: D4902838\n\nPulled By: gabelevi\n\nfbshipit-source-id: 7f5223f7447dc0387955a94a0945915521a508c4","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/f47ed2b5b990a8160358a38180d856b9324b1be9"},{"sha":"50f0ade13df116dab38f8d6a224aaea9343543c2","author":{"name":"David Aurelio","email":"ff048047600c1f3e891446665b5269773d037402@fb.com"},"message":"`getTransformOptions` can only return promises\n\nSummary: Changes the contract for `getTransformOptions` so that it has to return a promises. That allows call sites to get rid of special logic / wrapping.\n\nReviewed By: jeanlauliac\n\nDifferential Revision: D4905959\n\nfbshipit-source-id: c7d434c0766984e25987de1d769594e7c922d691","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/50f0ade13df116dab38f8d6a224aaea9343543c2"},{"sha":"5e09242e26e58f512af64f68ca4e671372ce6006","author":{"name":"Marc Horowitz","email":"5e85808dffeff32aa7915794d93d1e0510e0c781@fb.com"},"message":"Rename JSCSamplingProfiler to RCTJSCSamplingProfiler\n\nReviewed By: javache\n\nDifferential Revision: D4889427\n\nfbshipit-source-id: 1f74416b858134ec3682b1302021131114763881","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/5e09242e26e58f512af64f68ca4e671372ce6006"},{"sha":"5a5fd32acbeaf3f1b91fc1bc827587d609c9dbb4","author":{"name":"Himanshu Pathak","email":"459b6cb0ebe18ff1c018d18d0dc43f98a8557e02@gmail.com"},"message":"Update Colors.md, removed duplicate colors\n\nSummary:\nremoved duplicate colors\n\nThanks for submitting a PR! Please read these instructions carefully:\n\n- [ ] Explain the **motivation** for making this change.\n- [ ] Provide a **test plan** demonstrating that the code is solid.\n- [ ] Match the **code formatting** of the rest of the codebase.\n- [ ] Target the `master` branch, NOT a \"stable\" branch.\n\nWhat existing problem does the pull request solve?\n\nA good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more.\n\nIf you have added code that should be tested, add tests.\n\nSign the [CLA][2], if you haven't already.\n\nSmall pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.\n\nMake sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests a\nCloses https://github.com/facebook/react-native/pull/13555\n\nDifferential Revision: D4908510\n\nPulled By: javache\n\nfbshipit-source-id: 819a3c2788232bc092cccc071f115853e7caddad","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/5a5fd32acbeaf3f1b91fc1bc827587d609c9dbb4"},{"sha":"cc4648ba8653c0ed6ed6efa1c09127cfcf02c89b","author":{"name":"Sue Ann Ioanis","email":"bd0d059c45206eb0084a3b7819ff9ee41361bc94@gmail.com"},"message":"Omit units from zero values.\n\nSummary:\nIt's recommended to remove units for all zero length values because\nthese units aren't being used and therefore can be safely removed to\nsave bytes.\nCloses https://github.com/facebook/react-native/pull/13518\n\nDifferential Revision: D4905286\n\nPulled By: javache\n\nfbshipit-source-id: 4119eb8034b4b5b864228316c5a450978d4328e9","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/cc4648ba8653c0ed6ed6efa1c09127cfcf02c89b"},{"sha":"e443b7379e7f6076b8e02c9e180f3ac737bdfec0","author":{"name":"Kevin Cooper","email":"e6ef1fde383a24acc90e193dc3beb6f6239046ad@gmail.com"},"message":"More verbose error messages for iOS\n\nSummary:\nOutput the reason for the error when failing to load source code. This was a big help when trying to diagnose https://github.com/facebook/react-native/issues/13299.\n\n~~Unfortunately there still seems to be no way to get the offending line number (because `loadError.userInfo[RCTJSStackTraceKey]` is empty), but this is good enough.~~\n\nBefore:\n\n```\n[warn][tid:com.facebook.react.JavaScript][RCTBatchedBridge.m:510] Failed to execute source code. Unhandled JS Exception: SyntaxError\n```\n\nAfter:\n\n```\n[warn][tid:com.facebook.react.JavaScript][RCTJSCErrorHandling.mm:30] Couldn't get stack trace for http://localhost:8081/index.ios.bundle?platform=ios&dev=true&minify=false:81886\n[warn][tid:com.facebook.react.JavaScript][RCTBatchedBridge.m:510] Failed to execute source code. Unhandled JS Exception: SyntaxError Unexpected keyword 'var'\n```\nCloses https://github.com/facebook/react-native/pull/13561\n\nDifferential Revision: D4908501\n\nPulled By: javache\n\nfbshipit-source-id: a316dc70739b917b3cc690309d0ff37a8bb5d412","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/e443b7379e7f6076b8e02c9e180f3ac737bdfec0"},{"sha":"a5dea8d61297207574d8b0012bbfd82a1206df0b","author":{"name":"Mohamed Habib","email":"bcb21b396ab81d63fa76401754b6dc50410b6650@gmail.com"},"message":"Fixed a typo in open function documentation\n\nSummary:\nThanks for submitting a PR! Please read these instructions carefully:\n\n- [ ] Explain the **motivation** for making this change.\n- [ ] Provide a **test plan** demonstrating that the code is solid.\n- [ ] Match the **code formatting** of the rest of the codebase.\n- [ ] Target the `master` branch, NOT a \"stable\" branch.\n\nWhat existing problem does the pull request solve?\n\nA good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more.\n\nIf you have added code that should be tested, add tests.\n\nSign the [CLA][2], if you haven't already.\n\nSmall pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.\n\nMake sure all **tests pass** on both [Travis][3] and [Circle CI][4]. PRs that break tests are unlikely to be merged.\nCloses https://github.com/facebook/react-native/pull/13556\n\nDifferential Revision: D4908506\n\nPulled By: javache\n\nfbshipit-source-id: 17f6a57e31e68dc79ac9b5303bf56461663d7edd","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/a5dea8d61297207574d8b0012bbfd82a1206df0b"},{"sha":"e7fe3b165bfb7468cfd39383e3648dd3996c65a9","author":{"name":"Marc Horowitz","email":"5e85808dffeff32aa7915794d93d1e0510e0c781@fb.com"},"message":"Explicitly cast to (bool) where needed on objc with folly::dynamic\n\nReviewed By: yfeldblum\n\nDifferential Revision: D4711054\n\nfbshipit-source-id: 00897ca703f0f3a8cddaf170fef53f9851b631af","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/e7fe3b165bfb7468cfd39383e3648dd3996c65a9"},{"sha":"be5a4609e6359b01f8cde540baedd8f9e3716617","author":{"name":"Jonathan Kim","email":"c44f4d897ba9059f34565df8e3f6a2ff0c6cb8bf@tegocover.com"},"message":"Remove immutable-js\n\nSummary:\nImmutable doesn't seem to be used in react-native anymore so I've removed it as a dependency.\n\nEnsure that all tests pass.\nCloses https://github.com/facebook/react-native/pull/13471\n\nDifferential Revision: D4877659\n\nPulled By: javache\n\nfbshipit-source-id: f06996d6d0af73e5bd0108cec75370eec66ca038","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/be5a4609e6359b01f8cde540baedd8f9e3716617"},{"sha":"23e8fcc68c1b873024f326ad53b13ad3ca67ed9e","author":{"name":"Van der Auwermeulen Grégoire","email":"f3f39a6d02f4db9d73de28f9e3b450343e06be3e@gmail.com"},"message":"ListItem JSX tag is not closed when used in SectionList\n\nSummary:\nThanks for submitting a PR! Please read these instructions carefully:\n\n- [ ] Explain the **motivation** for making this change.\n- [ ] Provide a **test plan** demonstrating that the code is solid.\n- [ ] Match the **code formatting** of the rest of the codebase.\n- [ ] Target the `master` branch, NOT a \"stable\" branch.\n\nWhen copy pasting the SectionList, got an error with a non closing JSX tag\nWhat existing problem does the pull request solve?\nClosing the JSX tag in 2 files\nno test required\nA good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI or updates the website. See [What is a Test Plan?][1] to learn more.\n\nIf you have added code that should be tested, add tests.\n\nSign the [CLA][2], if you haven't already.\n\nSmall pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.\nCloses https://github.com/facebook/react-native/pull/13525\n\nDifferential Revision: D4908495\n\nPulled By: javache\n\nfbshipit-source-id: f2dc49c9238d1da8906f7daf144429a57ad725a3","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/23e8fcc68c1b873024f326ad53b13ad3ca67ed9e"},{"sha":"8f2d73d50bf4ce52bdc155db9c9d2da7306eb357","author":{"name":"Ben Alpert","email":"fd584e7b50f4de9ab07be067334cab0917b60e54@fb.com"},"message":"React Native Fiber: Fix errors in children management\n\nReviewed By: bvaughn\n\nDifferential Revision: D4905062\n\nfbshipit-source-id: 43c24e7bcaf06eb4c7385b7022d0f20cf42d6f2f","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/8f2d73d50bf4ce52bdc155db9c9d2da7306eb357"},{"sha":"3fda6a9a2b380a750b72d369f5fb4f11540ad1ef","author":{"name":"Aaron Chiu","email":"5e3fe025e68a1868ae4330ada78cd0369a932718@fb.com"},"message":"clear DraweeControllerBuilder after usage\n\nReviewed By: achen1\n\nDifferential Revision: D4908279\n\nfbshipit-source-id: 8de9930a2160f3201f8b7a8a66415310fa2f41de","distinct":true,"url":"https://api.github.com/repos/ndejesus1227/react-native/commits/3fda6a9a2b380a750b72d369f5fb4f11540ad1ef"}]}
{"actor":{"display_login":"ndejesus1227"}}