{"action":"created","comment":{"url":"https://api.github.com/repos/ornladios/ADIOS2/pulls/comments/140066998","pull_request_review_id":64087073,"id":140066998,"diff_hunk":"@@ -22,7 +23,7 @@ WANZmq::WANZmq(const std::string ipAddress, const std::string port,\n : Transport(\"wan\", \"zmq\", mpiComm, debugMode), m_IPAddress(ipAddress),\n   m_Port(port)\n {\n-\n+    m_Context = zmq_ctx_new();","path":"source/adios2/toolkit/transport/wan/WANZmq.cpp","position":13,"original_position":13,"commit_id":"04a5e5b2d52e99a0adf30e42b993a8caf9797635","original_commit_id":"04a5e5b2d52e99a0adf30e42b993a8caf9797635","user":{"login":"chuckatkins","id":320135,"avatar_url":"https://avatars0.githubusercontent.com/u/320135?v=4","gravatar_id":"","url":"https://api.github.com/users/chuckatkins","html_url":"https://github.com/chuckatkins","followers_url":"https://api.github.com/users/chuckatkins/followers","following_url":"https://api.github.com/users/chuckatkins/following{/other_user}","gists_url":"https://api.github.com/users/chuckatkins/gists{/gist_id}","starred_url":"https://api.github.com/users/chuckatkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chuckatkins/subscriptions","organizations_url":"https://api.github.com/users/chuckatkins/orgs","repos_url":"https://api.github.com/users/chuckatkins/repos","events_url":"https://api.github.com/users/chuckatkins/events{/privacy}","received_events_url":"https://api.github.com/users/chuckatkins/received_events","type":"User","site_admin":false},"body":"Does this need to be checked for validity in case it fails or will it always be guaranteed to succeed?","created_at":"2017-09-20T19:20:16Z","updated_at":"2017-09-20T19:20:16Z","html_url":"https://github.com/ornladios/ADIOS2/pull/270#discussion_r140066998","pull_request_url":"https://api.github.com/repos/ornladios/ADIOS2/pulls/270","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ornladios/ADIOS2/pulls/comments/140066998"},"html":{"href":"https://github.com/ornladios/ADIOS2/pull/270#discussion_r140066998"},"pull_request":{"href":"https://api.github.com/repos/ornladios/ADIOS2/pulls/270"}}},"pull_request":{"url":"https://api.github.com/repos/ornladios/ADIOS2/pulls/270","id":141923539,"html_url":"https://github.com/ornladios/ADIOS2/pull/270","diff_url":"https://github.com/ornladios/ADIOS2/pull/270.diff","patch_url":"https://github.com/ornladios/ADIOS2/pull/270.patch","issue_url":"https://api.github.com/repos/ornladios/ADIOS2/issues/270","number":270,"state":"open","locked":false,"title":"Finished DataMan Transport Manager refactoring but full functionality still pending on Read API","user":{"login":"JasonRuonanWang","id":6581351,"avatar_url":"https://avatars0.githubusercontent.com/u/6581351?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonRuonanWang","html_url":"https://github.com/JasonRuonanWang","followers_url":"https://api.github.com/users/JasonRuonanWang/followers","following_url":"https://api.github.com/users/JasonRuonanWang/following{/other_user}","gists_url":"https://api.github.com/users/JasonRuonanWang/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonRuonanWang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonRuonanWang/subscriptions","organizations_url":"https://api.github.com/users/JasonRuonanWang/orgs","repos_url":"https://api.github.com/users/JasonRuonanWang/repos","events_url":"https://api.github.com/users/JasonRuonanWang/events{/privacy}","received_events_url":"https://api.github.com/users/JasonRuonanWang/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-09-19T18:33:49Z","updated_at":"2017-09-20T19:20:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"baef3220af8974a8a7422d284972e955af4f713b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ornladios/ADIOS2/pulls/270/commits","review_comments_url":"https://api.github.com/repos/ornladios/ADIOS2/pulls/270/comments","review_comment_url":"https://api.github.com/repos/ornladios/ADIOS2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ornladios/ADIOS2/issues/270/comments","statuses_url":"https://api.github.com/repos/ornladios/ADIOS2/statuses/04a5e5b2d52e99a0adf30e42b993a8caf9797635","head":{"label":"JasonRuonanWang:dataman","ref":"dataman","sha":"04a5e5b2d52e99a0adf30e42b993a8caf9797635","user":{"login":"JasonRuonanWang","id":6581351,"avatar_url":"https://avatars0.githubusercontent.com/u/6581351?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonRuonanWang","html_url":"https://github.com/JasonRuonanWang","followers_url":"https://api.github.com/users/JasonRuonanWang/followers","following_url":"https://api.github.com/users/JasonRuonanWang/following{/other_user}","gists_url":"https://api.github.com/users/JasonRuonanWang/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonRuonanWang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonRuonanWang/subscriptions","organizations_url":"https://api.github.com/users/JasonRuonanWang/orgs","repos_url":"https://api.github.com/users/JasonRuonanWang/repos","events_url":"https://api.github.com/users/JasonRuonanWang/events{/privacy}","received_events_url":"https://api.github.com/users/JasonRuonanWang/received_events","type":"User","site_admin":false},"repo":{"id":87348228,"name":"ADIOS2","full_name":"JasonRuonanWang/ADIOS2","owner":{"login":"JasonRuonanWang","id":6581351,"avatar_url":"https://avatars0.githubusercontent.com/u/6581351?v=4","gravatar_id":"","url":"https://api.github.com/users/JasonRuonanWang","html_url":"https://github.com/JasonRuonanWang","followers_url":"https://api.github.com/users/JasonRuonanWang/followers","following_url":"https://api.github.com/users/JasonRuonanWang/following{/other_user}","gists_url":"https://api.github.com/users/JasonRuonanWang/gists{/gist_id}","starred_url":"https://api.github.com/users/JasonRuonanWang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JasonRuonanWang/subscriptions","organizations_url":"https://api.github.com/users/JasonRuonanWang/orgs","repos_url":"https://api.github.com/users/JasonRuonanWang/repos","events_url":"https://api.github.com/users/JasonRuonanWang/events{/privacy}","received_events_url":"https://api.github.com/users/JasonRuonanWang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JasonRuonanWang/ADIOS2","description":"Next generation of ADIOS developed in the Exascale Computing Program","fork":true,"url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2","forks_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/forks","keys_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/teams","hooks_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/hooks","issue_events_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/issues/events{/number}","events_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/events","assignees_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/assignees{/user}","branches_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/branches{/branch}","tags_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/tags","blobs_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/statuses/{sha}","languages_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/languages","stargazers_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/stargazers","contributors_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/contributors","subscribers_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/subscribers","subscription_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/subscription","commits_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/contents/{+path}","compare_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/merges","archive_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/downloads","issues_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/issues{/number}","pulls_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/pulls{/number}","milestones_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/milestones{/number}","notifications_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/labels{/name}","releases_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/releases{/id}","deployments_url":"https://api.github.com/repos/JasonRuonanWang/ADIOS2/deployments","created_at":"2017-04-05T19:25:10Z","updated_at":"2017-04-05T19:25:12Z","pushed_at":"2017-09-20T19:01:10Z","git_url":"git://github.com/JasonRuonanWang/ADIOS2.git","ssh_url":"git@github.com:JasonRuonanWang/ADIOS2.git","clone_url":"https://github.com/JasonRuonanWang/ADIOS2.git","svn_url":"https://github.com/JasonRuonanWang/ADIOS2","homepage":null,"size":4602,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dataman"}},"base":{"label":"ornladios:master","ref":"master","sha":"694567f9d56371219ac55be7def21a19e04c051b","user":{"login":"ornladios","id":3661939,"avatar_url":"https://avatars1.githubusercontent.com/u/3661939?v=4","gravatar_id":"","url":"https://api.github.com/users/ornladios","html_url":"https://github.com/ornladios","followers_url":"https://api.github.com/users/ornladios/followers","following_url":"https://api.github.com/users/ornladios/following{/other_user}","gists_url":"https://api.github.com/users/ornladios/gists{/gist_id}","starred_url":"https://api.github.com/users/ornladios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ornladios/subscriptions","organizations_url":"https://api.github.com/users/ornladios/orgs","repos_url":"https://api.github.com/users/ornladios/repos","events_url":"https://api.github.com/users/ornladios/events{/privacy}","received_events_url":"https://api.github.com/users/ornladios/received_events","type":"Organization","site_admin":false},"repo":{"id":75750830,"name":"ADIOS2","full_name":"ornladios/ADIOS2","owner":{"login":"ornladios","id":3661939,"avatar_url":"https://avatars1.githubusercontent.com/u/3661939?v=4","gravatar_id":"","url":"https://api.github.com/users/ornladios","html_url":"https://github.com/ornladios","followers_url":"https://api.github.com/users/ornladios/followers","following_url":"https://api.github.com/users/ornladios/following{/other_user}","gists_url":"https://api.github.com/users/ornladios/gists{/gist_id}","starred_url":"https://api.github.com/users/ornladios/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ornladios/subscriptions","organizations_url":"https://api.github.com/users/ornladios/orgs","repos_url":"https://api.github.com/users/ornladios/repos","events_url":"https://api.github.com/users/ornladios/events{/privacy}","received_events_url":"https://api.github.com/users/ornladios/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ornladios/ADIOS2","description":"Next generation of ADIOS developed in the Exascale Computing Program","fork":false,"url":"https://api.github.com/repos/ornladios/ADIOS2","forks_url":"https://api.github.com/repos/ornladios/ADIOS2/forks","keys_url":"https://api.github.com/repos/ornladios/ADIOS2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ornladios/ADIOS2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ornladios/ADIOS2/teams","hooks_url":"https://api.github.com/repos/ornladios/ADIOS2/hooks","issue_events_url":"https://api.github.com/repos/ornladios/ADIOS2/issues/events{/number}","events_url":"https://api.github.com/repos/ornladios/ADIOS2/events","assignees_url":"https://api.github.com/repos/ornladios/ADIOS2/assignees{/user}","branches_url":"https://api.github.com/repos/ornladios/ADIOS2/branches{/branch}","tags_url":"https://api.github.com/repos/ornladios/ADIOS2/tags","blobs_url":"https://api.github.com/repos/ornladios/ADIOS2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ornladios/ADIOS2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ornladios/ADIOS2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ornladios/ADIOS2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ornladios/ADIOS2/statuses/{sha}","languages_url":"https://api.github.com/repos/ornladios/ADIOS2/languages","stargazers_url":"https://api.github.com/repos/ornladios/ADIOS2/stargazers","contributors_url":"https://api.github.com/repos/ornladios/ADIOS2/contributors","subscribers_url":"https://api.github.com/repos/ornladios/ADIOS2/subscribers","subscription_url":"https://api.github.com/repos/ornladios/ADIOS2/subscription","commits_url":"https://api.github.com/repos/ornladios/ADIOS2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ornladios/ADIOS2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ornladios/ADIOS2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ornladios/ADIOS2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ornladios/ADIOS2/contents/{+path}","compare_url":"https://api.github.com/repos/ornladios/ADIOS2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ornladios/ADIOS2/merges","archive_url":"https://api.github.com/repos/ornladios/ADIOS2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ornladios/ADIOS2/downloads","issues_url":"https://api.github.com/repos/ornladios/ADIOS2/issues{/number}","pulls_url":"https://api.github.com/repos/ornladios/ADIOS2/pulls{/number}","milestones_url":"https://api.github.com/repos/ornladios/ADIOS2/milestones{/number}","notifications_url":"https://api.github.com/repos/ornladios/ADIOS2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ornladios/ADIOS2/labels{/name}","releases_url":"https://api.github.com/repos/ornladios/ADIOS2/releases{/id}","deployments_url":"https://api.github.com/repos/ornladios/ADIOS2/deployments","created_at":"2016-12-06T16:39:55Z","updated_at":"2017-09-12T15:38:24Z","pushed_at":"2017-09-20T19:01:11Z","git_url":"git://github.com/ornladios/ADIOS2.git","ssh_url":"git@github.com:ornladios/ADIOS2.git","clone_url":"https://github.com/ornladios/ADIOS2.git","svn_url":"https://github.com/ornladios/ADIOS2","homepage":null,"size":4607,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":8,"forks":11,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ornladios/ADIOS2/pulls/270"},"html":{"href":"https://github.com/ornladios/ADIOS2/pull/270"},"issue":{"href":"https://api.github.com/repos/ornladios/ADIOS2/issues/270"},"comments":{"href":"https://api.github.com/repos/ornladios/ADIOS2/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/ornladios/ADIOS2/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/ornladios/ADIOS2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ornladios/ADIOS2/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/ornladios/ADIOS2/statuses/04a5e5b2d52e99a0adf30e42b993a8caf9797635"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"chuckatkins"}}