{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/148892517","pull_request_review_id":74212443,"id":148892517,"diff_hunk":"@@ -556,6 +556,12 @@ class Test__RetryableMutateRowsWorker(unittest.TestCase):\n     INSTANCE_NAME = ('projects/' + PROJECT_ID + '/instances/' + INSTANCE_ID)\n     TABLE_ID = 'table-id'\n \n+    # RPC Status Codes\n+    SUCCESS = 0\n+    RETRYABLE_1 = 4\n+    RETRYABLE_2 = 10\n+    NON_RETRYABLE = 1","path":"bigtable/tests/unit/test_table.py","position":null,"original_position":8,"commit_id":"7a36723bb6a4770d95be422b5c7be51b6b2cd154","original_commit_id":"6f9b30dbe85095dff989886e8bbb071b55bd52ff","user":{"login":"justinseinlin","id":15793428,"avatar_url":"https://avatars1.githubusercontent.com/u/15793428?v=4","gravatar_id":"","url":"https://api.github.com/users/justinseinlin","html_url":"https://github.com/justinseinlin","followers_url":"https://api.github.com/users/justinseinlin/followers","following_url":"https://api.github.com/users/justinseinlin/following{/other_user}","gists_url":"https://api.github.com/users/justinseinlin/gists{/gist_id}","starred_url":"https://api.github.com/users/justinseinlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinseinlin/subscriptions","organizations_url":"https://api.github.com/users/justinseinlin/orgs","repos_url":"https://api.github.com/users/justinseinlin/repos","events_url":"https://api.github.com/users/justinseinlin/events{/privacy}","received_events_url":"https://api.github.com/users/justinseinlin/received_events","type":"User","site_admin":false},"body":"@dhermes @tseaver I noticed that we don't run linter on the test files. Is it just so our CI doesn't take too long (or longer that it already does)?","created_at":"2017-11-03T21:01:31Z","updated_at":"2017-11-03T21:01:31Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4341#discussion_r148892517","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4341","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments/148892517"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4341#discussion_r148892517"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4341"}},"in_reply_to_id":148885600},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4341","id":150619885,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4341","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4341.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4341.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/4341","number":4341,"state":"open","locked":false,"title":"Handle retry=None for mutate_rows, and some refactoring in test","user":{"login":"justinseinlin","id":15793428,"avatar_url":"https://avatars1.githubusercontent.com/u/15793428?v=4","gravatar_id":"","url":"https://api.github.com/users/justinseinlin","html_url":"https://github.com/justinseinlin","followers_url":"https://api.github.com/users/justinseinlin/followers","following_url":"https://api.github.com/users/justinseinlin/following{/other_user}","gists_url":"https://api.github.com/users/justinseinlin/gists{/gist_id}","starred_url":"https://api.github.com/users/justinseinlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinseinlin/subscriptions","organizations_url":"https://api.github.com/users/justinseinlin/orgs","repos_url":"https://api.github.com/users/justinseinlin/repos","events_url":"https://api.github.com/users/justinseinlin/events{/privacy}","received_events_url":"https://api.github.com/users/justinseinlin/received_events","type":"User","site_admin":false},"body":"/cc @dhermes \r\n\r\nAs discussed in https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4333, this change addresses the input retry=None for `mutate_rows`. @jonparrott I made an internal error `_BigtableRetryableError` and have it be used to trigger the retry instead of raising a fake `SerivceUnavailable`. Would like to get your opinion regarding this use.\r\n\r\nAlso factored out test response creation and replaced the magic numbers with constants for RPC Status Code. And removed the extra `the` from the error message.","created_at":"2017-11-03T20:17:55Z","updated_at":"2017-11-03T21:01:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7df297a8d049eeb532177545ff633ccf365315f1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lukesneeringer","id":4346,"avatar_url":"https://avatars0.githubusercontent.com/u/4346?v=4","gravatar_id":"","url":"https://api.github.com/users/lukesneeringer","html_url":"https://github.com/lukesneeringer","followers_url":"https://api.github.com/users/lukesneeringer/followers","following_url":"https://api.github.com/users/lukesneeringer/following{/other_user}","gists_url":"https://api.github.com/users/lukesneeringer/gists{/gist_id}","starred_url":"https://api.github.com/users/lukesneeringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukesneeringer/subscriptions","organizations_url":"https://api.github.com/users/lukesneeringer/orgs","repos_url":"https://api.github.com/users/lukesneeringer/repos","events_url":"https://api.github.com/users/lukesneeringer/events{/privacy}","received_events_url":"https://api.github.com/users/lukesneeringer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4341/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4341/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/4341/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/7a36723bb6a4770d95be422b5c7be51b6b2cd154","head":{"label":"justinseinlin:pr-4333-followup","ref":"pr-4333-followup","sha":"7a36723bb6a4770d95be422b5c7be51b6b2cd154","user":{"login":"justinseinlin","id":15793428,"avatar_url":"https://avatars1.githubusercontent.com/u/15793428?v=4","gravatar_id":"","url":"https://api.github.com/users/justinseinlin","html_url":"https://github.com/justinseinlin","followers_url":"https://api.github.com/users/justinseinlin/followers","following_url":"https://api.github.com/users/justinseinlin/following{/other_user}","gists_url":"https://api.github.com/users/justinseinlin/gists{/gist_id}","starred_url":"https://api.github.com/users/justinseinlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinseinlin/subscriptions","organizations_url":"https://api.github.com/users/justinseinlin/orgs","repos_url":"https://api.github.com/users/justinseinlin/repos","events_url":"https://api.github.com/users/justinseinlin/events{/privacy}","received_events_url":"https://api.github.com/users/justinseinlin/received_events","type":"User","site_admin":false},"repo":{"id":105306646,"name":"google-cloud-python","full_name":"justinseinlin/google-cloud-python","owner":{"login":"justinseinlin","id":15793428,"avatar_url":"https://avatars1.githubusercontent.com/u/15793428?v=4","gravatar_id":"","url":"https://api.github.com/users/justinseinlin","html_url":"https://github.com/justinseinlin","followers_url":"https://api.github.com/users/justinseinlin/followers","following_url":"https://api.github.com/users/justinseinlin/following{/other_user}","gists_url":"https://api.github.com/users/justinseinlin/gists{/gist_id}","starred_url":"https://api.github.com/users/justinseinlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinseinlin/subscriptions","organizations_url":"https://api.github.com/users/justinseinlin/orgs","repos_url":"https://api.github.com/users/justinseinlin/repos","events_url":"https://api.github.com/users/justinseinlin/events{/privacy}","received_events_url":"https://api.github.com/users/justinseinlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/justinseinlin/google-cloud-python","description":"Google Cloud Client Library for Python","fork":true,"url":"https://api.github.com/repos/justinseinlin/google-cloud-python","forks_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/forks","keys_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/events","assignees_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/merges","archive_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/justinseinlin/google-cloud-python/deployments","created_at":"2017-09-29T18:52:21Z","updated_at":"2017-09-29T18:52:26Z","pushed_at":"2017-11-03T20:56:36Z","git_url":"git://github.com/justinseinlin/google-cloud-python.git","ssh_url":"git@github.com:justinseinlin/google-cloud-python.git","clone_url":"https://github.com/justinseinlin/google-cloud-python.git","svn_url":"https://github.com/justinseinlin/google-cloud-python","homepage":"https://googlecloudplatform.github.io/google-cloud-python/","size":128476,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"e12372db34b6202d8c4f6e50d0e8b8c047f30d9d","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"name":"google-cloud-python","full_name":"GoogleCloudPlatform/google-cloud-python","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","description":"Google Cloud Client Library for Python","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/deployments","created_at":"2014-01-28T15:51:47Z","updated_at":"2017-11-02T23:09:15Z","pushed_at":"2017-11-03T20:56:38Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-python.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-python.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-python.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","homepage":"https://googlecloudplatform.github.io/google-cloud-python/","size":137682,"stargazers_count":993,"watchers_count":993,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":472,"mirror_url":null,"archived":false,"open_issues_count":110,"forks":472,"open_issues":110,"watchers":993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4341"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4341"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/4341"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/4341/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4341/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4341/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/7a36723bb6a4770d95be422b5c7be51b6b2cd154"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"justinseinlin"}}