{"action":"created","comment":{"url":"https://api.github.com/repos/Jumpscale/core9/pulls/comments/148210326","pull_request_review_id":73416357,"id":148210326,"diff_hunk":"@@ -386,40 +383,40 @@ def appGetPidsActive(self, appname):\n \n         return pids\n \n-    def getUniqueMachineId(self):\n-        \"\"\"\n-        will look for network interface and return a hash calculated from lowest mac address from all physical nics\n-        \"\"\"\n-        # if unique machine id is set in grid.hrd, then return it\n-        uniquekey = 'node.machineguid'\n-        if j.application.config.jumpscale['system']['grid'].get(\n-                uniquekey, False):\n-            machineguid = j.application.config.jumpscale['system']['grid'].get(\n-                uniquekey)\n-            if machineguid.strip():\n-                return machineguid\n-\n-        nics = j.sal.nettools.getNics()\n-        if j.core.platformtype.myplatform.isWindows:\n-            order = [\"local area\", \"wifi\"]\n-            for item in order:\n-                for nic in nics:\n-                    if nic.lower().find(item) != -1:\n-                        return j.sal.nettools.getMacAddress(nic)\n-        macaddr = []\n-        for nic in nics:\n-            if nic.find(\"lo\") == -1:\n-                nicmac = j.sal.nettools.getMacAddress(nic)\n-                macaddr.append(nicmac.replace(\":\", \"\"))\n-        macaddr.sort()\n-        if len(macaddr) < 1:\n-            raise j.exceptions.RuntimeError(\n-                \"Cannot find macaddress of nics in machine.\")\n+    # def getUniqueMachineId(self):","path":"JumpScale9/core/Application.py","position":101,"original_position":101,"commit_id":"59ead967dec32ea4a197b175830dabc92bc21901","original_commit_id":"59ead967dec32ea4a197b175830dabc92bc21901","user":{"login":"rkhamis","id":8425762,"avatar_url":"https://avatars1.githubusercontent.com/u/8425762?v=4","gravatar_id":"","url":"https://api.github.com/users/rkhamis","html_url":"https://github.com/rkhamis","followers_url":"https://api.github.com/users/rkhamis/followers","following_url":"https://api.github.com/users/rkhamis/following{/other_user}","gists_url":"https://api.github.com/users/rkhamis/gists{/gist_id}","starred_url":"https://api.github.com/users/rkhamis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkhamis/subscriptions","organizations_url":"https://api.github.com/users/rkhamis/orgs","repos_url":"https://api.github.com/users/rkhamis/repos","events_url":"https://api.github.com/users/rkhamis/events{/privacy}","received_events_url":"https://api.github.com/users/rkhamis/received_events","type":"User","site_admin":false},"body":"let's remove","created_at":"2017-11-01T09:06:24Z","updated_at":"2017-11-01T09:08:43Z","html_url":"https://github.com/Jumpscale/core9/pull/83#discussion_r148210326","pull_request_url":"https://api.github.com/repos/Jumpscale/core9/pulls/83","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Jumpscale/core9/pulls/comments/148210326"},"html":{"href":"https://github.com/Jumpscale/core9/pull/83#discussion_r148210326"},"pull_request":{"href":"https://api.github.com/repos/Jumpscale/core9/pulls/83"}},"in_reply_to_id":148204745},"pull_request":{"url":"https://api.github.com/repos/Jumpscale/core9/pulls/83","id":149825396,"html_url":"https://github.com/Jumpscale/core9/pull/83","diff_url":"https://github.com/Jumpscale/core9/pull/83.diff","patch_url":"https://github.com/Jumpscale/core9/pull/83.patch","issue_url":"https://api.github.com/repos/Jumpscale/core9/issues/83","number":83,"state":"open","locked":false,"title":"change configuration info access","user":{"login":"alichaddad","id":24762033,"avatar_url":"https://avatars1.githubusercontent.com/u/24762033?v=4","gravatar_id":"","url":"https://api.github.com/users/alichaddad","html_url":"https://github.com/alichaddad","followers_url":"https://api.github.com/users/alichaddad/followers","following_url":"https://api.github.com/users/alichaddad/following{/other_user}","gists_url":"https://api.github.com/users/alichaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/alichaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alichaddad/subscriptions","organizations_url":"https://api.github.com/users/alichaddad/orgs","repos_url":"https://api.github.com/users/alichaddad/repos","events_url":"https://api.github.com/users/alichaddad/events{/privacy}","received_events_url":"https://api.github.com/users/alichaddad/received_events","type":"User","site_admin":false},"body":"#### Changes proposed in this PR:\r\n\r\n- Adding `j.core.config` for getting configuration from `jumpscale9.toml`\r\n- Removing the usage of `j.application.config` for getting configuration \r\n- All configurable options in `jumpscale9.toml` are under new `config` section\r\n\r\n**Version**: 9.3.0\r\n\r\n","created_at":"2017-10-31T15:47:43Z","updated_at":"2017-11-01T09:08:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2a2517eeb05df7310d4a9cde240ba21e5af59f6","assignee":{"login":"alichaddad","id":24762033,"avatar_url":"https://avatars1.githubusercontent.com/u/24762033?v=4","gravatar_id":"","url":"https://api.github.com/users/alichaddad","html_url":"https://github.com/alichaddad","followers_url":"https://api.github.com/users/alichaddad/followers","following_url":"https://api.github.com/users/alichaddad/following{/other_user}","gists_url":"https://api.github.com/users/alichaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/alichaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alichaddad/subscriptions","organizations_url":"https://api.github.com/users/alichaddad/orgs","repos_url":"https://api.github.com/users/alichaddad/repos","events_url":"https://api.github.com/users/alichaddad/events{/privacy}","received_events_url":"https://api.github.com/users/alichaddad/received_events","type":"User","site_admin":false},"assignees":[{"login":"alichaddad","id":24762033,"avatar_url":"https://avatars1.githubusercontent.com/u/24762033?v=4","gravatar_id":"","url":"https://api.github.com/users/alichaddad","html_url":"https://github.com/alichaddad","followers_url":"https://api.github.com/users/alichaddad/followers","following_url":"https://api.github.com/users/alichaddad/following{/other_user}","gists_url":"https://api.github.com/users/alichaddad/gists{/gist_id}","starred_url":"https://api.github.com/users/alichaddad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alichaddad/subscriptions","organizations_url":"https://api.github.com/users/alichaddad/orgs","repos_url":"https://api.github.com/users/alichaddad/repos","events_url":"https://api.github.com/users/alichaddad/events{/privacy}","received_events_url":"https://api.github.com/users/alichaddad/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Jumpscale/core9/pulls/83/commits","review_comments_url":"https://api.github.com/repos/Jumpscale/core9/pulls/83/comments","review_comment_url":"https://api.github.com/repos/Jumpscale/core9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Jumpscale/core9/issues/83/comments","statuses_url":"https://api.github.com/repos/Jumpscale/core9/statuses/59ead967dec32ea4a197b175830dabc92bc21901","head":{"label":"Jumpscale:state-config","ref":"state-config","sha":"59ead967dec32ea4a197b175830dabc92bc21901","user":{"login":"Jumpscale","id":8423908,"avatar_url":"https://avatars3.githubusercontent.com/u/8423908?v=4","gravatar_id":"","url":"https://api.github.com/users/Jumpscale","html_url":"https://github.com/Jumpscale","followers_url":"https://api.github.com/users/Jumpscale/followers","following_url":"https://api.github.com/users/Jumpscale/following{/other_user}","gists_url":"https://api.github.com/users/Jumpscale/gists{/gist_id}","starred_url":"https://api.github.com/users/Jumpscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jumpscale/subscriptions","organizations_url":"https://api.github.com/users/Jumpscale/orgs","repos_url":"https://api.github.com/users/Jumpscale/repos","events_url":"https://api.github.com/users/Jumpscale/events{/privacy}","received_events_url":"https://api.github.com/users/Jumpscale/received_events","type":"Organization","site_admin":false},"repo":{"id":88135883,"name":"core9","full_name":"Jumpscale/core9","owner":{"login":"Jumpscale","id":8423908,"avatar_url":"https://avatars3.githubusercontent.com/u/8423908?v=4","gravatar_id":"","url":"https://api.github.com/users/Jumpscale","html_url":"https://github.com/Jumpscale","followers_url":"https://api.github.com/users/Jumpscale/followers","following_url":"https://api.github.com/users/Jumpscale/following{/other_user}","gists_url":"https://api.github.com/users/Jumpscale/gists{/gist_id}","starred_url":"https://api.github.com/users/Jumpscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jumpscale/subscriptions","organizations_url":"https://api.github.com/users/Jumpscale/orgs","repos_url":"https://api.github.com/users/Jumpscale/repos","events_url":"https://api.github.com/users/Jumpscale/events{/privacy}","received_events_url":"https://api.github.com/users/Jumpscale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Jumpscale/core9","description":null,"fork":false,"url":"https://api.github.com/repos/Jumpscale/core9","forks_url":"https://api.github.com/repos/Jumpscale/core9/forks","keys_url":"https://api.github.com/repos/Jumpscale/core9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jumpscale/core9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jumpscale/core9/teams","hooks_url":"https://api.github.com/repos/Jumpscale/core9/hooks","issue_events_url":"https://api.github.com/repos/Jumpscale/core9/issues/events{/number}","events_url":"https://api.github.com/repos/Jumpscale/core9/events","assignees_url":"https://api.github.com/repos/Jumpscale/core9/assignees{/user}","branches_url":"https://api.github.com/repos/Jumpscale/core9/branches{/branch}","tags_url":"https://api.github.com/repos/Jumpscale/core9/tags","blobs_url":"https://api.github.com/repos/Jumpscale/core9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jumpscale/core9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jumpscale/core9/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jumpscale/core9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jumpscale/core9/statuses/{sha}","languages_url":"https://api.github.com/repos/Jumpscale/core9/languages","stargazers_url":"https://api.github.com/repos/Jumpscale/core9/stargazers","contributors_url":"https://api.github.com/repos/Jumpscale/core9/contributors","subscribers_url":"https://api.github.com/repos/Jumpscale/core9/subscribers","subscription_url":"https://api.github.com/repos/Jumpscale/core9/subscription","commits_url":"https://api.github.com/repos/Jumpscale/core9/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jumpscale/core9/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jumpscale/core9/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jumpscale/core9/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jumpscale/core9/contents/{+path}","compare_url":"https://api.github.com/repos/Jumpscale/core9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jumpscale/core9/merges","archive_url":"https://api.github.com/repos/Jumpscale/core9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jumpscale/core9/downloads","issues_url":"https://api.github.com/repos/Jumpscale/core9/issues{/number}","pulls_url":"https://api.github.com/repos/Jumpscale/core9/pulls{/number}","milestones_url":"https://api.github.com/repos/Jumpscale/core9/milestones{/number}","notifications_url":"https://api.github.com/repos/Jumpscale/core9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jumpscale/core9/labels{/name}","releases_url":"https://api.github.com/repos/Jumpscale/core9/releases{/id}","deployments_url":"https://api.github.com/repos/Jumpscale/core9/deployments","created_at":"2017-04-13T07:10:54Z","updated_at":"2017-06-07T08:11:30Z","pushed_at":"2017-10-31T15:47:43Z","git_url":"git://github.com/Jumpscale/core9.git","ssh_url":"git@github.com:Jumpscale/core9.git","clone_url":"https://github.com/Jumpscale/core9.git","svn_url":"https://github.com/Jumpscale/core9","homepage":null,"size":1150,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":1,"default_branch":"master"}},"base":{"label":"Jumpscale:9.3.0","ref":"9.3.0","sha":"53e7c1785768f97c2c0c6beb9811e23ec46ad79b","user":{"login":"Jumpscale","id":8423908,"avatar_url":"https://avatars3.githubusercontent.com/u/8423908?v=4","gravatar_id":"","url":"https://api.github.com/users/Jumpscale","html_url":"https://github.com/Jumpscale","followers_url":"https://api.github.com/users/Jumpscale/followers","following_url":"https://api.github.com/users/Jumpscale/following{/other_user}","gists_url":"https://api.github.com/users/Jumpscale/gists{/gist_id}","starred_url":"https://api.github.com/users/Jumpscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jumpscale/subscriptions","organizations_url":"https://api.github.com/users/Jumpscale/orgs","repos_url":"https://api.github.com/users/Jumpscale/repos","events_url":"https://api.github.com/users/Jumpscale/events{/privacy}","received_events_url":"https://api.github.com/users/Jumpscale/received_events","type":"Organization","site_admin":false},"repo":{"id":88135883,"name":"core9","full_name":"Jumpscale/core9","owner":{"login":"Jumpscale","id":8423908,"avatar_url":"https://avatars3.githubusercontent.com/u/8423908?v=4","gravatar_id":"","url":"https://api.github.com/users/Jumpscale","html_url":"https://github.com/Jumpscale","followers_url":"https://api.github.com/users/Jumpscale/followers","following_url":"https://api.github.com/users/Jumpscale/following{/other_user}","gists_url":"https://api.github.com/users/Jumpscale/gists{/gist_id}","starred_url":"https://api.github.com/users/Jumpscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jumpscale/subscriptions","organizations_url":"https://api.github.com/users/Jumpscale/orgs","repos_url":"https://api.github.com/users/Jumpscale/repos","events_url":"https://api.github.com/users/Jumpscale/events{/privacy}","received_events_url":"https://api.github.com/users/Jumpscale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Jumpscale/core9","description":null,"fork":false,"url":"https://api.github.com/repos/Jumpscale/core9","forks_url":"https://api.github.com/repos/Jumpscale/core9/forks","keys_url":"https://api.github.com/repos/Jumpscale/core9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jumpscale/core9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jumpscale/core9/teams","hooks_url":"https://api.github.com/repos/Jumpscale/core9/hooks","issue_events_url":"https://api.github.com/repos/Jumpscale/core9/issues/events{/number}","events_url":"https://api.github.com/repos/Jumpscale/core9/events","assignees_url":"https://api.github.com/repos/Jumpscale/core9/assignees{/user}","branches_url":"https://api.github.com/repos/Jumpscale/core9/branches{/branch}","tags_url":"https://api.github.com/repos/Jumpscale/core9/tags","blobs_url":"https://api.github.com/repos/Jumpscale/core9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jumpscale/core9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jumpscale/core9/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jumpscale/core9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jumpscale/core9/statuses/{sha}","languages_url":"https://api.github.com/repos/Jumpscale/core9/languages","stargazers_url":"https://api.github.com/repos/Jumpscale/core9/stargazers","contributors_url":"https://api.github.com/repos/Jumpscale/core9/contributors","subscribers_url":"https://api.github.com/repos/Jumpscale/core9/subscribers","subscription_url":"https://api.github.com/repos/Jumpscale/core9/subscription","commits_url":"https://api.github.com/repos/Jumpscale/core9/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jumpscale/core9/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jumpscale/core9/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jumpscale/core9/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jumpscale/core9/contents/{+path}","compare_url":"https://api.github.com/repos/Jumpscale/core9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jumpscale/core9/merges","archive_url":"https://api.github.com/repos/Jumpscale/core9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jumpscale/core9/downloads","issues_url":"https://api.github.com/repos/Jumpscale/core9/issues{/number}","pulls_url":"https://api.github.com/repos/Jumpscale/core9/pulls{/number}","milestones_url":"https://api.github.com/repos/Jumpscale/core9/milestones{/number}","notifications_url":"https://api.github.com/repos/Jumpscale/core9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jumpscale/core9/labels{/name}","releases_url":"https://api.github.com/repos/Jumpscale/core9/releases{/id}","deployments_url":"https://api.github.com/repos/Jumpscale/core9/deployments","created_at":"2017-04-13T07:10:54Z","updated_at":"2017-06-07T08:11:30Z","pushed_at":"2017-10-31T15:47:43Z","git_url":"git://github.com/Jumpscale/core9.git","ssh_url":"git@github.com:Jumpscale/core9.git","clone_url":"https://github.com/Jumpscale/core9.git","svn_url":"https://github.com/Jumpscale/core9","homepage":null,"size":1150,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":9,"forks":1,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Jumpscale/core9/pulls/83"},"html":{"href":"https://github.com/Jumpscale/core9/pull/83"},"issue":{"href":"https://api.github.com/repos/Jumpscale/core9/issues/83"},"comments":{"href":"https://api.github.com/repos/Jumpscale/core9/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/Jumpscale/core9/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/Jumpscale/core9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Jumpscale/core9/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/Jumpscale/core9/statuses/59ead967dec32ea4a197b175830dabc92bc21901"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rkhamis"}}