{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/scope/issues/2888","repository_url":"https://api.github.com/repos/weaveworks/scope","labels_url":"https://api.github.com/repos/weaveworks/scope/issues/2888/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/scope/issues/2888/comments","events_url":"https://api.github.com/repos/weaveworks/scope/issues/2888/events","html_url":"https://github.com/weaveworks/scope/pull/2888","id":264732078,"number":2888,"title":"Make Time Travel a modular component","user":{"login":"fbarl","id":1216874,"avatar_url":"https://avatars1.githubusercontent.com/u/1216874?v=4","gravatar_id":"","url":"https://api.github.com/users/fbarl","html_url":"https://github.com/fbarl","followers_url":"https://api.github.com/users/fbarl/followers","following_url":"https://api.github.com/users/fbarl/following{/other_user}","gists_url":"https://api.github.com/users/fbarl/gists{/gist_id}","starred_url":"https://api.github.com/users/fbarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbarl/subscriptions","organizations_url":"https://api.github.com/users/fbarl/orgs","repos_url":"https://api.github.com/users/fbarl/repos","events_url":"https://api.github.com/users/fbarl/events{/privacy}","received_events_url":"https://api.github.com/users/fbarl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"fbarl","id":1216874,"avatar_url":"https://avatars1.githubusercontent.com/u/1216874?v=4","gravatar_id":"","url":"https://api.github.com/users/fbarl","html_url":"https://github.com/fbarl","followers_url":"https://api.github.com/users/fbarl/followers","following_url":"https://api.github.com/users/fbarl/following{/other_user}","gists_url":"https://api.github.com/users/fbarl/gists{/gist_id}","starred_url":"https://api.github.com/users/fbarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbarl/subscriptions","organizations_url":"https://api.github.com/users/fbarl/orgs","repos_url":"https://api.github.com/users/fbarl/repos","events_url":"https://api.github.com/users/fbarl/events{/privacy}","received_events_url":"https://api.github.com/users/fbarl/received_events","type":"User","site_admin":false},"assignees":[{"login":"fbarl","id":1216874,"avatar_url":"https://avatars1.githubusercontent.com/u/1216874?v=4","gravatar_id":"","url":"https://api.github.com/users/fbarl","html_url":"https://github.com/fbarl","followers_url":"https://api.github.com/users/fbarl/followers","following_url":"https://api.github.com/users/fbarl/following{/other_user}","gists_url":"https://api.github.com/users/fbarl/gists{/gist_id}","starred_url":"https://api.github.com/users/fbarl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbarl/subscriptions","organizations_url":"https://api.github.com/users/fbarl/orgs","repos_url":"https://api.github.com/users/fbarl/repos","events_url":"https://api.github.com/users/fbarl/events{/privacy}","received_events_url":"https://api.github.com/users/fbarl/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-10-11T20:52:30Z","updated_at":"2017-10-17T01:37:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/weaveworks/scope/pulls/2888","html_url":"https://github.com/weaveworks/scope/pull/2888","diff_url":"https://github.com/weaveworks/scope/pull/2888.diff","patch_url":"https://github.com/weaveworks/scope/pull/2888.patch"},"body":"Fixes #2893.\r\n\r\n##### Changes\r\n\r\n* Merged multiple Time Travel related components into one `TimeTravelComponent`, which communicates with the world only through forwarded _props_ and is completely isolated from the Scope Redux state.\r\n* Started using `styled-components` library to contain all the Time Travel styles in the component.\r\n* Also contained all the constants - left some helpers spread as they are likely to be transfered into `ui-components` repo separately\r\n* Wrapped the `App` component into the theme the same way it's done in `service-ui` repo, to start using more standardized colorset in Scope (_note:_ I tried doing it in `main.js` and `main.dev.js` files instead, but that wouldn't work with local proxying so `app.js` was naturally my second choice).\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/weaveworks/scope/issues/comments/337091628","html_url":"https://github.com/weaveworks/scope/pull/2888#issuecomment-337091628","issue_url":"https://api.github.com/repos/weaveworks/scope/issues/2888","id":337091628,"user":{"login":"jpellizzari","id":2802257,"avatar_url":"https://avatars1.githubusercontent.com/u/2802257?v=4","gravatar_id":"","url":"https://api.github.com/users/jpellizzari","html_url":"https://github.com/jpellizzari","followers_url":"https://api.github.com/users/jpellizzari/followers","following_url":"https://api.github.com/users/jpellizzari/following{/other_user}","gists_url":"https://api.github.com/users/jpellizzari/gists{/gist_id}","starred_url":"https://api.github.com/users/jpellizzari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpellizzari/subscriptions","organizations_url":"https://api.github.com/users/jpellizzari/orgs","repos_url":"https://api.github.com/users/jpellizzari/repos","events_url":"https://api.github.com/users/jpellizzari/events{/privacy}","received_events_url":"https://api.github.com/users/jpellizzari/received_events","type":"User","site_admin":false},"created_at":"2017-10-17T01:37:19Z","updated_at":"2017-10-17T01:37:19Z","author_association":"CONTRIBUTOR","body":"Still reviewing this one @fbarl I will try to finish up by the end of the day tomorrow (10/17)"}}
{"actor":{"display_login":"jpellizzari"}}