{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/114175283","pull_request_review_id":35620428,"id":114175283,"diff_hunk":"@@ -2029,6 +2030,26 @@ public B routeToRecipients(Consumer<RecipientListRouterSpec> routerConfigurer) {\n \t}\n \n \t/**\n+\t * Populate the {@link ErrorMessageExceptionTypeRouter} with options from the {@link RouterSpec}.\n+\t * Typically used with a Java 8 Lambda expression:\n+\t * <pre class=\"code\">\n+\t * {@code\n+\t *  .routeByError(r -> r\n+\t *      .channelMapping(IllegalArgumentException.class, \"illegalArgumentChannel\")\n+\t *      .subFlowMapping(MessageHandlingException.class, sf ->\n+\t *                                sf.handle(...))\n+\t *    )\n+\t * }\n+\t * </pre>\n+\t * @param routerConfigurer the {@link Consumer} to provide {@link ErrorMessageExceptionTypeRouter} options.\n+\t * @return the current {@link IntegrationFlowDefinition}.\n+\t */\n+\tpublic B routeByError(","path":"spring-integration-core/src/main/java/org/springframework/integration/dsl/IntegrationFlowDefinition.java","position":41,"original_position":41,"commit_id":"8ad830c4014bb3b1519d5f51abc45a33847a7832","original_commit_id":"8ad830c4014bb3b1519d5f51abc45a33847a7832","user":{"login":"garyrussell","id":483832,"avatar_url":"https://avatars0.githubusercontent.com/u/483832?v=3","gravatar_id":"","url":"https://api.github.com/users/garyrussell","html_url":"https://github.com/garyrussell","followers_url":"https://api.github.com/users/garyrussell/followers","following_url":"https://api.github.com/users/garyrussell/following{/other_user}","gists_url":"https://api.github.com/users/garyrussell/gists{/gist_id}","starred_url":"https://api.github.com/users/garyrussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garyrussell/subscriptions","organizations_url":"https://api.github.com/users/garyrussell/orgs","repos_url":"https://api.github.com/users/garyrussell/repos","events_url":"https://api.github.com/users/garyrussell/events{/privacy}","received_events_url":"https://api.github.com/users/garyrussell/received_events","type":"User","site_admin":false},"body":"I agree, but specifically, here (and in the EMTR), we are routing on a `Throwable` payload, not an `ErrorMessage`.","created_at":"2017-05-01T18:46:01Z","updated_at":"2017-05-01T18:46:01Z","html_url":"https://github.com/spring-projects/spring-integration/pull/2136#discussion_r114175283","pull_request_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2136","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments/114175283"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/2136#discussion_r114175283"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2136"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2136","id":117829050,"html_url":"https://github.com/spring-projects/spring-integration/pull/2136","diff_url":"https://github.com/spring-projects/spring-integration/pull/2136.diff","patch_url":"https://github.com/spring-projects/spring-integration/pull/2136.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/2136","number":2136,"state":"open","locked":false,"title":"INT-4265: Add Java DSL .routeByError() EIP-method","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars0.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.spring.io/browse/INT-4265\r\n\r\n* Add `.routeByError()` EIP-method to the `IntegrationFlowDefinition`\r\nbased on the `ErrorMessageExceptionTypeRouter`\r\n* Add missed `dynamicChannelLimit()` option to the `RouterSpec`\r\n* Rework `RouterSpec#RouterMappingProvider` into the `ContextRefreshedEvent`\r\nphase initialization to be sure that dependent `MappingMessageRouterManagement`\r\nis fully initialized before applying mapping conversions","created_at":"2017-04-26T23:11:03Z","updated_at":"2017-05-01T18:46:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f65f788bffdda1f8c42367ad7790541328376239","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2136/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2136/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/2136/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/8ad830c4014bb3b1519d5f51abc45a33847a7832","head":{"label":"artembilan:INT-4265","ref":"INT-4265","sha":"8ad830c4014bb3b1519d5f51abc45a33847a7832","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars0.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"repo":{"id":2686240,"name":"spring-integration","full_name":"artembilan/spring-integration","owner":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars0.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/artembilan/spring-integration","description":null,"fork":true,"url":"https://api.github.com/repos/artembilan/spring-integration","forks_url":"https://api.github.com/repos/artembilan/spring-integration/forks","keys_url":"https://api.github.com/repos/artembilan/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artembilan/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artembilan/spring-integration/teams","hooks_url":"https://api.github.com/repos/artembilan/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/artembilan/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/artembilan/spring-integration/events","assignees_url":"https://api.github.com/repos/artembilan/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/artembilan/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/artembilan/spring-integration/tags","blobs_url":"https://api.github.com/repos/artembilan/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artembilan/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artembilan/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/artembilan/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artembilan/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/artembilan/spring-integration/languages","stargazers_url":"https://api.github.com/repos/artembilan/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/artembilan/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/artembilan/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/artembilan/spring-integration/subscription","commits_url":"https://api.github.com/repos/artembilan/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/artembilan/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/artembilan/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/artembilan/spring-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/artembilan/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/artembilan/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artembilan/spring-integration/merges","archive_url":"https://api.github.com/repos/artembilan/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artembilan/spring-integration/downloads","issues_url":"https://api.github.com/repos/artembilan/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/artembilan/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/artembilan/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/artembilan/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artembilan/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/artembilan/spring-integration/releases{/id}","deployments_url":"https://api.github.com/repos/artembilan/spring-integration/deployments","created_at":"2011-11-01T08:04:04Z","updated_at":"2017-04-01T02:04:46Z","pushed_at":"2017-05-01T17:46:29Z","git_url":"git://github.com/artembilan/spring-integration.git","ssh_url":"git@github.com:artembilan/spring-integration.git","clone_url":"https://github.com/artembilan/spring-integration.git","svn_url":"https://github.com/artembilan/spring-integration","homepage":"","size":43938,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"1557e3de217b31c0df826ecf37c5bf361b4c077f","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars3.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":2090979,"name":"spring-integration","full_name":"spring-projects/spring-integration","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars3.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-integration","description":"Spring Integration provides an extension of the Spring programming model to support the well-known Enterprise Integration Patterns (EIP)","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-integration","forks_url":"https://api.github.com/repos/spring-projects/spring-integration/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-integration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-integration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-integration/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-integration/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-integration/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-integration/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-integration/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-integration/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-integration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-integration/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-integration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-integration/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-integration/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-integration/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-integration/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-integration/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-integration/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-integration/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-integration/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-integration/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-integration/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-integration/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-integration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-integration/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-integration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-integration/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-integration/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-integration/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-integration/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-integration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-integration/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-integration/releases{/id}","deployments_url":"https://api.github.com/repos/spring-projects/spring-integration/deployments","created_at":"2011-07-22T21:47:27Z","updated_at":"2017-04-29T07:24:24Z","pushed_at":"2017-05-01T17:46:20Z","git_url":"git://github.com/spring-projects/spring-integration.git","ssh_url":"git@github.com:spring-projects/spring-integration.git","clone_url":"https://github.com/spring-projects/spring-integration.git","svn_url":"https://github.com/spring-projects/spring-integration","homepage":"http://projects.spring.io/spring-integration/","size":43724,"stargazers_count":596,"watchers_count":596,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":513,"mirror_url":null,"open_issues_count":10,"forks":513,"open_issues":10,"watchers":596,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2136"},"html":{"href":"https://github.com/spring-projects/spring-integration/pull/2136"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/2136"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/issues/2136/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2136/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-integration/pulls/2136/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-integration/statuses/8ad830c4014bb3b1519d5f51abc45a33847a7832"}}}}
{"actor":{"display_login":"garyrussell"}}