{"action":"created","issue":{"url":"https://api.github.com/repos/harvard-lts/fits/issues/48","repository_url":"https://api.github.com/repos/harvard-lts/fits","labels_url":"https://api.github.com/repos/harvard-lts/fits/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/harvard-lts/fits/issues/48/comments","events_url":"https://api.github.com/repos/harvard-lts/fits/issues/48/events","html_url":"https://github.com/harvard-lts/fits/issues/48","id":111936335,"number":48,"title":"ClassLoader problems creating instance of transformerfactory","user":{"login":"nclarkekb","id":2581497,"avatar_url":"https://avatars3.githubusercontent.com/u/2581497?v=4","gravatar_id":"","url":"https://api.github.com/users/nclarkekb","html_url":"https://github.com/nclarkekb","followers_url":"https://api.github.com/users/nclarkekb/followers","following_url":"https://api.github.com/users/nclarkekb/following{/other_user}","gists_url":"https://api.github.com/users/nclarkekb/gists{/gist_id}","starred_url":"https://api.github.com/users/nclarkekb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclarkekb/subscriptions","organizations_url":"https://api.github.com/users/nclarkekb/orgs","repos_url":"https://api.github.com/users/nclarkekb/repos","events_url":"https://api.github.com/users/nclarkekb/events{/privacy}","received_events_url":"https://api.github.com/users/nclarkekb/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2015-10-17T01:20:21Z","updated_at":"2017-11-19T11:08:27Z","closed_at":"2017-11-17T18:29:22Z","author_association":"NONE","body":"ToolBase.java has a classloader problem loading saxon using transformerfactory.\nThis can be fixed by passing the classloader used to load the class itself as the second parameter instead of null.\n\n```\n    tFactory = TransformerFactory.newInstance(\"net.sf.saxon.TransformerFactoryImpl\",null);\n```\n\nshould be\n\n```\n    tFactory = TransformerFactory.newInstance(\"net.sf.saxon.TransformerFactoryImpl\",this.getClass().getClassLoader());\n```\n"},"comment":{"url":"https://api.github.com/repos/harvard-lts/fits/issues/comments/345508498","html_url":"https://github.com/harvard-lts/fits/issues/48#issuecomment-345508498","issue_url":"https://api.github.com/repos/harvard-lts/fits/issues/48","id":345508498,"user":{"login":"nclarkekb","id":2581497,"avatar_url":"https://avatars3.githubusercontent.com/u/2581497?v=4","gravatar_id":"","url":"https://api.github.com/users/nclarkekb","html_url":"https://github.com/nclarkekb","followers_url":"https://api.github.com/users/nclarkekb/followers","following_url":"https://api.github.com/users/nclarkekb/following{/other_user}","gists_url":"https://api.github.com/users/nclarkekb/gists{/gist_id}","starred_url":"https://api.github.com/users/nclarkekb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclarkekb/subscriptions","organizations_url":"https://api.github.com/users/nclarkekb/orgs","repos_url":"https://api.github.com/users/nclarkekb/repos","events_url":"https://api.github.com/users/nclarkekb/events{/privacy}","received_events_url":"https://api.github.com/users/nclarkekb/received_events","type":"User","site_admin":false},"created_at":"2017-11-19T11:08:27Z","updated_at":"2017-11-19T11:08:27Z","author_association":"NONE","body":"If you want to use a custom classloader then passing null to all xml factories will creates major classloader problems. On the other hand the custom classloader added in later fits versions looked fairly alternative so that will probably also cause problems.\r\nJust to be clear I wrapped fits 0.8.x in a custom classloader so it would be completely isolated while being run inside a tomcat webapp. (To isolate its jars from droid, tika, etc.)\r\nIf I actually need to run this in production I will fix those classloader issues and submit a pull request instead."}}
{"actor":{"display_login":"nclarkekb"}}