{"action":"created","comment":{"url":"https://api.github.com/repos/airlift/airlift/pulls/comments/154452685","pull_request_review_id":80625975,"id":154452685,"diff_hunk":"@@ -0,0 +1,41 @@\n+package io.airlift.http.client.jetty;\n+\n+import com.google.common.collect.ImmutableList;\n+import com.google.common.net.InetAddresses;\n+import org.eclipse.jetty.util.Promise;\n+import org.eclipse.jetty.util.SocketAddressResolver;\n+import org.eclipse.jetty.util.thread.Scheduler;\n+\n+import java.net.InetAddress;\n+import java.net.InetSocketAddress;\n+import java.util.List;\n+import java.util.concurrent.Executor;\n+\n+/**\n+ * For IP address literals this SocketAddressResolver implementation does not dispatch the address resolution\n+ * to the executor. Under high load this helps offloading the executor, which may be shared by multiple different\n+ * HTTP clients.\n+ */\n+public class JettyAsyncSocketAddressResolver","path":"http-client/src/main/java/io/airlift/http/client/jetty/JettyAsyncSocketAddressResolver.java","position":19,"original_position":19,"commit_id":"a0cd81b98cc90ff4c1f2efaeba17b922e2b829a3","original_commit_id":"a0cd81b98cc90ff4c1f2efaeba17b922e2b829a3","user":{"login":"electrum","id":9230,"avatar_url":"https://avatars1.githubusercontent.com/u/9230?v=4","gravatar_id":"","url":"https://api.github.com/users/electrum","html_url":"https://github.com/electrum","followers_url":"https://api.github.com/users/electrum/followers","following_url":"https://api.github.com/users/electrum/following{/other_user}","gists_url":"https://api.github.com/users/electrum/gists{/gist_id}","starred_url":"https://api.github.com/users/electrum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electrum/subscriptions","organizations_url":"https://api.github.com/users/electrum/orgs","repos_url":"https://api.github.com/users/electrum/repos","events_url":"https://api.github.com/users/electrum/events{/privacy}","received_events_url":"https://api.github.com/users/electrum/received_events","type":"User","site_admin":false},"body":"This can be package private","created_at":"2017-12-01T21:28:05Z","updated_at":"2017-12-01T21:28:05Z","html_url":"https://github.com/airlift/airlift/pull/582#discussion_r154452685","pull_request_url":"https://api.github.com/repos/airlift/airlift/pulls/582","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/airlift/airlift/pulls/comments/154452685"},"html":{"href":"https://github.com/airlift/airlift/pull/582#discussion_r154452685"},"pull_request":{"href":"https://api.github.com/repos/airlift/airlift/pulls/582"}}},"pull_request":{"url":"https://api.github.com/repos/airlift/airlift/pulls/582","id":155750779,"html_url":"https://github.com/airlift/airlift/pull/582","diff_url":"https://github.com/airlift/airlift/pull/582.diff","patch_url":"https://github.com/airlift/airlift/pull/582.patch","issue_url":"https://api.github.com/repos/airlift/airlift/issues/582","number":582,"state":"open","locked":false,"title":"Add an optimized async Jetty SocketAddressResolver","user":{"login":"nezihyigitbasi","id":1223839,"avatar_url":"https://avatars3.githubusercontent.com/u/1223839?v=4","gravatar_id":"","url":"https://api.github.com/users/nezihyigitbasi","html_url":"https://github.com/nezihyigitbasi","followers_url":"https://api.github.com/users/nezihyigitbasi/followers","following_url":"https://api.github.com/users/nezihyigitbasi/following{/other_user}","gists_url":"https://api.github.com/users/nezihyigitbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/nezihyigitbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nezihyigitbasi/subscriptions","organizations_url":"https://api.github.com/users/nezihyigitbasi/orgs","repos_url":"https://api.github.com/users/nezihyigitbasi/repos","events_url":"https://api.github.com/users/nezihyigitbasi/events{/privacy}","received_events_url":"https://api.github.com/users/nezihyigitbasi/received_events","type":"User","site_admin":false},"body":"When IP address literals are used this new SocketAddressResolver will not dispatch\r\nthe address resolution to the client executor, which will help reduce the load on\r\nthat executor. This especially helps under high load and when the executor is shared\r\nby multiple HTTP clients.","created_at":"2017-11-30T23:58:06Z","updated_at":"2017-12-01T21:28:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61fa033af3d683aaf021375272748f1e8ade89bb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/airlift/airlift/pulls/582/commits","review_comments_url":"https://api.github.com/repos/airlift/airlift/pulls/582/comments","review_comment_url":"https://api.github.com/repos/airlift/airlift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airlift/airlift/issues/582/comments","statuses_url":"https://api.github.com/repos/airlift/airlift/statuses/a0cd81b98cc90ff4c1f2efaeba17b922e2b829a3","head":{"label":"nezihyigitbasi:custom-socket-address-resolver","ref":"custom-socket-address-resolver","sha":"a0cd81b98cc90ff4c1f2efaeba17b922e2b829a3","user":{"login":"nezihyigitbasi","id":1223839,"avatar_url":"https://avatars3.githubusercontent.com/u/1223839?v=4","gravatar_id":"","url":"https://api.github.com/users/nezihyigitbasi","html_url":"https://github.com/nezihyigitbasi","followers_url":"https://api.github.com/users/nezihyigitbasi/followers","following_url":"https://api.github.com/users/nezihyigitbasi/following{/other_user}","gists_url":"https://api.github.com/users/nezihyigitbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/nezihyigitbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nezihyigitbasi/subscriptions","organizations_url":"https://api.github.com/users/nezihyigitbasi/orgs","repos_url":"https://api.github.com/users/nezihyigitbasi/repos","events_url":"https://api.github.com/users/nezihyigitbasi/events{/privacy}","received_events_url":"https://api.github.com/users/nezihyigitbasi/received_events","type":"User","site_admin":false},"repo":{"id":53919402,"name":"airlift","full_name":"nezihyigitbasi/airlift","owner":{"login":"nezihyigitbasi","id":1223839,"avatar_url":"https://avatars3.githubusercontent.com/u/1223839?v=4","gravatar_id":"","url":"https://api.github.com/users/nezihyigitbasi","html_url":"https://github.com/nezihyigitbasi","followers_url":"https://api.github.com/users/nezihyigitbasi/followers","following_url":"https://api.github.com/users/nezihyigitbasi/following{/other_user}","gists_url":"https://api.github.com/users/nezihyigitbasi/gists{/gist_id}","starred_url":"https://api.github.com/users/nezihyigitbasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nezihyigitbasi/subscriptions","organizations_url":"https://api.github.com/users/nezihyigitbasi/orgs","repos_url":"https://api.github.com/users/nezihyigitbasi/repos","events_url":"https://api.github.com/users/nezihyigitbasi/events{/privacy}","received_events_url":"https://api.github.com/users/nezihyigitbasi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nezihyigitbasi/airlift","description":"Airlift framework for building REST services","fork":true,"url":"https://api.github.com/repos/nezihyigitbasi/airlift","forks_url":"https://api.github.com/repos/nezihyigitbasi/airlift/forks","keys_url":"https://api.github.com/repos/nezihyigitbasi/airlift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nezihyigitbasi/airlift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nezihyigitbasi/airlift/teams","hooks_url":"https://api.github.com/repos/nezihyigitbasi/airlift/hooks","issue_events_url":"https://api.github.com/repos/nezihyigitbasi/airlift/issues/events{/number}","events_url":"https://api.github.com/repos/nezihyigitbasi/airlift/events","assignees_url":"https://api.github.com/repos/nezihyigitbasi/airlift/assignees{/user}","branches_url":"https://api.github.com/repos/nezihyigitbasi/airlift/branches{/branch}","tags_url":"https://api.github.com/repos/nezihyigitbasi/airlift/tags","blobs_url":"https://api.github.com/repos/nezihyigitbasi/airlift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nezihyigitbasi/airlift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nezihyigitbasi/airlift/git/refs{/sha}","trees_url":"https://api.github.com/repos/nezihyigitbasi/airlift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nezihyigitbasi/airlift/statuses/{sha}","languages_url":"https://api.github.com/repos/nezihyigitbasi/airlift/languages","stargazers_url":"https://api.github.com/repos/nezihyigitbasi/airlift/stargazers","contributors_url":"https://api.github.com/repos/nezihyigitbasi/airlift/contributors","subscribers_url":"https://api.github.com/repos/nezihyigitbasi/airlift/subscribers","subscription_url":"https://api.github.com/repos/nezihyigitbasi/airlift/subscription","commits_url":"https://api.github.com/repos/nezihyigitbasi/airlift/commits{/sha}","git_commits_url":"https://api.github.com/repos/nezihyigitbasi/airlift/git/commits{/sha}","comments_url":"https://api.github.com/repos/nezihyigitbasi/airlift/comments{/number}","issue_comment_url":"https://api.github.com/repos/nezihyigitbasi/airlift/issues/comments{/number}","contents_url":"https://api.github.com/repos/nezihyigitbasi/airlift/contents/{+path}","compare_url":"https://api.github.com/repos/nezihyigitbasi/airlift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nezihyigitbasi/airlift/merges","archive_url":"https://api.github.com/repos/nezihyigitbasi/airlift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nezihyigitbasi/airlift/downloads","issues_url":"https://api.github.com/repos/nezihyigitbasi/airlift/issues{/number}","pulls_url":"https://api.github.com/repos/nezihyigitbasi/airlift/pulls{/number}","milestones_url":"https://api.github.com/repos/nezihyigitbasi/airlift/milestones{/number}","notifications_url":"https://api.github.com/repos/nezihyigitbasi/airlift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nezihyigitbasi/airlift/labels{/name}","releases_url":"https://api.github.com/repos/nezihyigitbasi/airlift/releases{/id}","deployments_url":"https://api.github.com/repos/nezihyigitbasi/airlift/deployments","created_at":"2016-03-15T06:08:24Z","updated_at":"2016-03-15T06:08:27Z","pushed_at":"2017-11-30T23:57:05Z","git_url":"git://github.com/nezihyigitbasi/airlift.git","ssh_url":"git@github.com:nezihyigitbasi/airlift.git","clone_url":"https://github.com/nezihyigitbasi/airlift.git","svn_url":"https://github.com/nezihyigitbasi/airlift","homepage":"","size":19543,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"airlift:master","ref":"master","sha":"c1ddcde440705091be9fd6e93c7fbdd386f31f02","user":{"login":"airlift","id":1855389,"avatar_url":"https://avatars1.githubusercontent.com/u/1855389?v=4","gravatar_id":"","url":"https://api.github.com/users/airlift","html_url":"https://github.com/airlift","followers_url":"https://api.github.com/users/airlift/followers","following_url":"https://api.github.com/users/airlift/following{/other_user}","gists_url":"https://api.github.com/users/airlift/gists{/gist_id}","starred_url":"https://api.github.com/users/airlift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airlift/subscriptions","organizations_url":"https://api.github.com/users/airlift/orgs","repos_url":"https://api.github.com/users/airlift/repos","events_url":"https://api.github.com/users/airlift/events{/privacy}","received_events_url":"https://api.github.com/users/airlift/received_events","type":"Organization","site_admin":false},"repo":{"id":4681328,"name":"airlift","full_name":"airlift/airlift","owner":{"login":"airlift","id":1855389,"avatar_url":"https://avatars1.githubusercontent.com/u/1855389?v=4","gravatar_id":"","url":"https://api.github.com/users/airlift","html_url":"https://github.com/airlift","followers_url":"https://api.github.com/users/airlift/followers","following_url":"https://api.github.com/users/airlift/following{/other_user}","gists_url":"https://api.github.com/users/airlift/gists{/gist_id}","starred_url":"https://api.github.com/users/airlift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airlift/subscriptions","organizations_url":"https://api.github.com/users/airlift/orgs","repos_url":"https://api.github.com/users/airlift/repos","events_url":"https://api.github.com/users/airlift/events{/privacy}","received_events_url":"https://api.github.com/users/airlift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airlift/airlift","description":"Airlift framework for building REST services","fork":false,"url":"https://api.github.com/repos/airlift/airlift","forks_url":"https://api.github.com/repos/airlift/airlift/forks","keys_url":"https://api.github.com/repos/airlift/airlift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airlift/airlift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airlift/airlift/teams","hooks_url":"https://api.github.com/repos/airlift/airlift/hooks","issue_events_url":"https://api.github.com/repos/airlift/airlift/issues/events{/number}","events_url":"https://api.github.com/repos/airlift/airlift/events","assignees_url":"https://api.github.com/repos/airlift/airlift/assignees{/user}","branches_url":"https://api.github.com/repos/airlift/airlift/branches{/branch}","tags_url":"https://api.github.com/repos/airlift/airlift/tags","blobs_url":"https://api.github.com/repos/airlift/airlift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airlift/airlift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airlift/airlift/git/refs{/sha}","trees_url":"https://api.github.com/repos/airlift/airlift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airlift/airlift/statuses/{sha}","languages_url":"https://api.github.com/repos/airlift/airlift/languages","stargazers_url":"https://api.github.com/repos/airlift/airlift/stargazers","contributors_url":"https://api.github.com/repos/airlift/airlift/contributors","subscribers_url":"https://api.github.com/repos/airlift/airlift/subscribers","subscription_url":"https://api.github.com/repos/airlift/airlift/subscription","commits_url":"https://api.github.com/repos/airlift/airlift/commits{/sha}","git_commits_url":"https://api.github.com/repos/airlift/airlift/git/commits{/sha}","comments_url":"https://api.github.com/repos/airlift/airlift/comments{/number}","issue_comment_url":"https://api.github.com/repos/airlift/airlift/issues/comments{/number}","contents_url":"https://api.github.com/repos/airlift/airlift/contents/{+path}","compare_url":"https://api.github.com/repos/airlift/airlift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airlift/airlift/merges","archive_url":"https://api.github.com/repos/airlift/airlift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airlift/airlift/downloads","issues_url":"https://api.github.com/repos/airlift/airlift/issues{/number}","pulls_url":"https://api.github.com/repos/airlift/airlift/pulls{/number}","milestones_url":"https://api.github.com/repos/airlift/airlift/milestones{/number}","notifications_url":"https://api.github.com/repos/airlift/airlift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airlift/airlift/labels{/name}","releases_url":"https://api.github.com/repos/airlift/airlift/releases{/id}","deployments_url":"https://api.github.com/repos/airlift/airlift/deployments","created_at":"2012-06-16T00:33:13Z","updated_at":"2017-11-10T09:04:39Z","pushed_at":"2017-12-01T21:07:13Z","git_url":"git://github.com/airlift/airlift.git","ssh_url":"git@github.com:airlift/airlift.git","clone_url":"https://github.com/airlift/airlift.git","svn_url":"https://github.com/airlift/airlift","homepage":"","size":27755,"stargazers_count":219,"watchers_count":219,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":120,"open_issues":52,"watchers":219,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airlift/airlift/pulls/582"},"html":{"href":"https://github.com/airlift/airlift/pull/582"},"issue":{"href":"https://api.github.com/repos/airlift/airlift/issues/582"},"comments":{"href":"https://api.github.com/repos/airlift/airlift/issues/582/comments"},"review_comments":{"href":"https://api.github.com/repos/airlift/airlift/pulls/582/comments"},"review_comment":{"href":"https://api.github.com/repos/airlift/airlift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airlift/airlift/pulls/582/commits"},"statuses":{"href":"https://api.github.com/repos/airlift/airlift/statuses/a0cd81b98cc90ff4c1f2efaeba17b922e2b829a3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"electrum"}}