{"action":"created","issue":{"url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/issues/188","repository_url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell","labels_url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/issues/188/labels{/name}","comments_url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/issues/188/comments","events_url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/issues/188/events","html_url":"https://github.com/IfcOpenShell/IfcOpenShell/pull/188","id":209804375,"number":188,"title":"IfcConvert and IfcGeomIterator filtering improvements","user":{"login":"Stinkfist0","id":227876,"avatar_url":"https://avatars1.githubusercontent.com/u/227876?v=3","gravatar_id":"","url":"https://api.github.com/users/Stinkfist0","html_url":"https://github.com/Stinkfist0","followers_url":"https://api.github.com/users/Stinkfist0/followers","following_url":"https://api.github.com/users/Stinkfist0/following{/other_user}","gists_url":"https://api.github.com/users/Stinkfist0/gists{/gist_id}","starred_url":"https://api.github.com/users/Stinkfist0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stinkfist0/subscriptions","organizations_url":"https://api.github.com/users/Stinkfist0/orgs","repos_url":"https://api.github.com/users/Stinkfist0/repos","events_url":"https://api.github.com/users/Stinkfist0/events{/privacy}","received_events_url":"https://api.github.com/users/Stinkfist0/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-02-23T16:02:41Z","updated_at":"2017-03-02T13:12:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/pulls/188","html_url":"https://github.com/IfcOpenShell/IfcOpenShell/pull/188","diff_url":"https://github.com/IfcOpenShell/IfcOpenShell/pull/188.diff","patch_url":"https://github.com/IfcOpenShell/IfcOpenShell/pull/188.patch"},"body":"- possibility to --include and --exclude simultaneously: however, only single --include and --exclude supported for now\r\n- \"outsourced\" filtering from IfcGeomIterator to any possible client code instead, default implementations for old and new filters provided\r\n- filtering by Description and Tag\r\n- `--<include|exclude> --<enties|layers|guids|names> <value1 value2 ...>` syntax changed to `--<include|exclude>=<entities|layers|arg> (<GlobalId|Name|Description|Tag>) <value1 value2 ...>`\r\n- closes #20 \r\n- there's some room for more cleanup and refactoring, will continue the work after the discussed (on IRC) merging of IfcBaseEntity and IfcLateboundEntity happens and after tackling #104 \r\n"},"comment":{"url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/issues/comments/283649840","html_url":"https://github.com/IfcOpenShell/IfcOpenShell/pull/188#issuecomment-283649840","issue_url":"https://api.github.com/repos/IfcOpenShell/IfcOpenShell/issues/188","id":283649840,"user":{"login":"Stinkfist0","id":227876,"avatar_url":"https://avatars1.githubusercontent.com/u/227876?v=3","gravatar_id":"","url":"https://api.github.com/users/Stinkfist0","html_url":"https://github.com/Stinkfist0","followers_url":"https://api.github.com/users/Stinkfist0/followers","following_url":"https://api.github.com/users/Stinkfist0/following{/other_user}","gists_url":"https://api.github.com/users/Stinkfist0/gists{/gist_id}","starred_url":"https://api.github.com/users/Stinkfist0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stinkfist0/subscriptions","organizations_url":"https://api.github.com/users/Stinkfist0/orgs","repos_url":"https://api.github.com/users/Stinkfist0/repos","events_url":"https://api.github.com/users/Stinkfist0/events{/privacy}","received_events_url":"https://api.github.com/users/Stinkfist0/received_events","type":"User","site_admin":false},"created_at":"2017-03-02T13:12:50Z","updated_at":"2017-03-02T13:12:50Z","body":"Oh, and regarding your iterator ideas, those look quite good too, I especially like the look of `for(auto it = model.begin(); it != model.end(); next_matching(filters, it))`, let's discuss these in more detail in  a separate issue."}}
{"actor":{"display_login":"Stinkfist0"}}