{"action":"created","comment":{"url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls/comments/105094034","pull_request_review_id":25956342,"id":105094034,"diff_hunk":"@@ -1,17 +1,22 @@\n # -*- coding: utf-8 -*-\n \"\"\"Module representing the sqlite plugin generator\"\"\"\n+import os\n+\n+from plasoscaffolder.bll.mappings.init_mapping import *\n+from plasoscaffolder.bll.services.file_handler import FileHandler\n from plasoscaffolder.bll.services.sqlite_plugin_helper import *\n \n \n class SqliteGenerator():\n   \"\"\" Generator for SQLite Files \"\"\"\n \n-  def __init__(self, path, name, database, output):\n+  def __init__(self, path: os.path, name: str, database: os.path, output):\n     \"\"\" Constructs the SQLite Generator","path":"src/plasoscaffolder/bll/services/sqlite_generator.py","position":15,"original_position":15,"commit_id":"ad4ed8ab1082142d47a3ea0d6af0165a6bbf3891","original_commit_id":"ad4ed8ab1082142d47a3ea0d6af0165a6bbf3891","user":{"login":"joachimmetz","id":3888750,"avatar_url":"https://avatars1.githubusercontent.com/u/3888750?v=3","gravatar_id":"","url":"https://api.github.com/users/joachimmetz","html_url":"https://github.com/joachimmetz","followers_url":"https://api.github.com/users/joachimmetz/followers","following_url":"https://api.github.com/users/joachimmetz/following{/other_user}","gists_url":"https://api.github.com/users/joachimmetz/gists{/gist_id}","starred_url":"https://api.github.com/users/joachimmetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joachimmetz/subscriptions","organizations_url":"https://api.github.com/users/joachimmetz/orgs","repos_url":"https://api.github.com/users/joachimmetz/repos","events_url":"https://api.github.com/users/joachimmetz/events{/privacy}","received_events_url":"https://api.github.com/users/joachimmetz/received_events","type":"User","site_admin":false},"body":"Contextual: Technically `__init__` is not the constructor but the initializer\r\nhttps://docs.python.org/3/reference/datamodel.html#basic-customization\r\n\r\nHence I would suggest:\r\n```\r\nInitializes a SQLite Generator.\r\n```","created_at":"2017-03-09T06:23:43Z","updated_at":"2017-03-09T06:23:43Z","html_url":"https://github.com/ClaudiaSaxer/PlasoScaffolder/pull/3#discussion_r105094034","pull_request_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls/comments/105094034"},"html":{"href":"https://github.com/ClaudiaSaxer/PlasoScaffolder/pull/3#discussion_r105094034"},"pull_request":{"href":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls/3","id":109725892,"html_url":"https://github.com/ClaudiaSaxer/PlasoScaffolder/pull/3","diff_url":"https://github.com/ClaudiaSaxer/PlasoScaffolder/pull/3.diff","patch_url":"https://github.com/ClaudiaSaxer/PlasoScaffolder/pull/3.patch","issue_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/issues/3","number":3,"state":"open","locked":false,"title":"Templating and Typings","user":{"login":"ClaudiaSaxer","id":2305576,"avatar_url":"https://avatars1.githubusercontent.com/u/2305576?v=3","gravatar_id":"","url":"https://api.github.com/users/ClaudiaSaxer","html_url":"https://github.com/ClaudiaSaxer","followers_url":"https://api.github.com/users/ClaudiaSaxer/followers","following_url":"https://api.github.com/users/ClaudiaSaxer/following{/other_user}","gists_url":"https://api.github.com/users/ClaudiaSaxer/gists{/gist_id}","starred_url":"https://api.github.com/users/ClaudiaSaxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClaudiaSaxer/subscriptions","organizations_url":"https://api.github.com/users/ClaudiaSaxer/orgs","repos_url":"https://api.github.com/users/ClaudiaSaxer/repos","events_url":"https://api.github.com/users/ClaudiaSaxer/events{/privacy}","received_events_url":"https://api.github.com/users/ClaudiaSaxer/received_events","type":"User","site_admin":false},"body":"Would be great if you could have a general look at my code.\r\nThanks","created_at":"2017-03-08T16:03:26Z","updated_at":"2017-03-09T06:23:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b04610ad9b5b84bd23bf6b7a62758aa896f3a649","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls/3/commits","review_comments_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls/3/comments","review_comment_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/issues/3/comments","statuses_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/statuses/ad4ed8ab1082142d47a3ea0d6af0165a6bbf3891","head":{"label":"ClaudiaSaxer:modify","ref":"modify","sha":"ad4ed8ab1082142d47a3ea0d6af0165a6bbf3891","user":{"login":"ClaudiaSaxer","id":2305576,"avatar_url":"https://avatars1.githubusercontent.com/u/2305576?v=3","gravatar_id":"","url":"https://api.github.com/users/ClaudiaSaxer","html_url":"https://github.com/ClaudiaSaxer","followers_url":"https://api.github.com/users/ClaudiaSaxer/followers","following_url":"https://api.github.com/users/ClaudiaSaxer/following{/other_user}","gists_url":"https://api.github.com/users/ClaudiaSaxer/gists{/gist_id}","starred_url":"https://api.github.com/users/ClaudiaSaxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClaudiaSaxer/subscriptions","organizations_url":"https://api.github.com/users/ClaudiaSaxer/orgs","repos_url":"https://api.github.com/users/ClaudiaSaxer/repos","events_url":"https://api.github.com/users/ClaudiaSaxer/events{/privacy}","received_events_url":"https://api.github.com/users/ClaudiaSaxer/received_events","type":"User","site_admin":false},"repo":{"id":82653835,"name":"PlasoScaffolder","full_name":"ClaudiaSaxer/PlasoScaffolder","owner":{"login":"ClaudiaSaxer","id":2305576,"avatar_url":"https://avatars1.githubusercontent.com/u/2305576?v=3","gravatar_id":"","url":"https://api.github.com/users/ClaudiaSaxer","html_url":"https://github.com/ClaudiaSaxer","followers_url":"https://api.github.com/users/ClaudiaSaxer/followers","following_url":"https://api.github.com/users/ClaudiaSaxer/following{/other_user}","gists_url":"https://api.github.com/users/ClaudiaSaxer/gists{/gist_id}","starred_url":"https://api.github.com/users/ClaudiaSaxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClaudiaSaxer/subscriptions","organizations_url":"https://api.github.com/users/ClaudiaSaxer/orgs","repos_url":"https://api.github.com/users/ClaudiaSaxer/repos","events_url":"https://api.github.com/users/ClaudiaSaxer/events{/privacy}","received_events_url":"https://api.github.com/users/ClaudiaSaxer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ClaudiaSaxer/PlasoScaffolder","description":"A SQLite Plugin Scaffolder for Plaso","fork":false,"url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder","forks_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/forks","keys_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/teams","hooks_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/hooks","issue_events_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/issues/events{/number}","events_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/events","assignees_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/assignees{/user}","branches_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/branches{/branch}","tags_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/tags","blobs_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/statuses/{sha}","languages_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/languages","stargazers_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/stargazers","contributors_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/contributors","subscribers_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/subscribers","subscription_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/subscription","commits_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/contents/{+path}","compare_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/merges","archive_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/downloads","issues_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/issues{/number}","pulls_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls{/number}","milestones_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/milestones{/number}","notifications_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/labels{/name}","releases_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/releases{/id}","deployments_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/deployments","created_at":"2017-02-21T08:14:33Z","updated_at":"2017-02-24T10:36:23Z","pushed_at":"2017-03-08T16:06:43Z","git_url":"git://github.com/ClaudiaSaxer/PlasoScaffolder.git","ssh_url":"git@github.com:ClaudiaSaxer/PlasoScaffolder.git","clone_url":"https://github.com/ClaudiaSaxer/PlasoScaffolder.git","svn_url":"https://github.com/ClaudiaSaxer/PlasoScaffolder","homepage":null,"size":292,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"ClaudiaSaxer:master","ref":"master","sha":"829de117261d6c90203fd6834a5383be0d56bca7","user":{"login":"ClaudiaSaxer","id":2305576,"avatar_url":"https://avatars1.githubusercontent.com/u/2305576?v=3","gravatar_id":"","url":"https://api.github.com/users/ClaudiaSaxer","html_url":"https://github.com/ClaudiaSaxer","followers_url":"https://api.github.com/users/ClaudiaSaxer/followers","following_url":"https://api.github.com/users/ClaudiaSaxer/following{/other_user}","gists_url":"https://api.github.com/users/ClaudiaSaxer/gists{/gist_id}","starred_url":"https://api.github.com/users/ClaudiaSaxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClaudiaSaxer/subscriptions","organizations_url":"https://api.github.com/users/ClaudiaSaxer/orgs","repos_url":"https://api.github.com/users/ClaudiaSaxer/repos","events_url":"https://api.github.com/users/ClaudiaSaxer/events{/privacy}","received_events_url":"https://api.github.com/users/ClaudiaSaxer/received_events","type":"User","site_admin":false},"repo":{"id":82653835,"name":"PlasoScaffolder","full_name":"ClaudiaSaxer/PlasoScaffolder","owner":{"login":"ClaudiaSaxer","id":2305576,"avatar_url":"https://avatars1.githubusercontent.com/u/2305576?v=3","gravatar_id":"","url":"https://api.github.com/users/ClaudiaSaxer","html_url":"https://github.com/ClaudiaSaxer","followers_url":"https://api.github.com/users/ClaudiaSaxer/followers","following_url":"https://api.github.com/users/ClaudiaSaxer/following{/other_user}","gists_url":"https://api.github.com/users/ClaudiaSaxer/gists{/gist_id}","starred_url":"https://api.github.com/users/ClaudiaSaxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClaudiaSaxer/subscriptions","organizations_url":"https://api.github.com/users/ClaudiaSaxer/orgs","repos_url":"https://api.github.com/users/ClaudiaSaxer/repos","events_url":"https://api.github.com/users/ClaudiaSaxer/events{/privacy}","received_events_url":"https://api.github.com/users/ClaudiaSaxer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ClaudiaSaxer/PlasoScaffolder","description":"A SQLite Plugin Scaffolder for Plaso","fork":false,"url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder","forks_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/forks","keys_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/teams","hooks_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/hooks","issue_events_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/issues/events{/number}","events_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/events","assignees_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/assignees{/user}","branches_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/branches{/branch}","tags_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/tags","blobs_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/git/refs{/sha}","trees_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/statuses/{sha}","languages_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/languages","stargazers_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/stargazers","contributors_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/contributors","subscribers_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/subscribers","subscription_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/subscription","commits_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/commits{/sha}","git_commits_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/git/commits{/sha}","comments_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/comments{/number}","issue_comment_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/issues/comments{/number}","contents_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/contents/{+path}","compare_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/merges","archive_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/downloads","issues_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/issues{/number}","pulls_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls{/number}","milestones_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/milestones{/number}","notifications_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/labels{/name}","releases_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/releases{/id}","deployments_url":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/deployments","created_at":"2017-02-21T08:14:33Z","updated_at":"2017-02-24T10:36:23Z","pushed_at":"2017-03-08T16:06:43Z","git_url":"git://github.com/ClaudiaSaxer/PlasoScaffolder.git","ssh_url":"git@github.com:ClaudiaSaxer/PlasoScaffolder.git","clone_url":"https://github.com/ClaudiaSaxer/PlasoScaffolder.git","svn_url":"https://github.com/ClaudiaSaxer/PlasoScaffolder","homepage":null,"size":292,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls/3"},"html":{"href":"https://github.com/ClaudiaSaxer/PlasoScaffolder/pull/3"},"issue":{"href":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/issues/3"},"comments":{"href":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/ClaudiaSaxer/PlasoScaffolder/statuses/ad4ed8ab1082142d47a3ea0d6af0165a6bbf3891"}}}}
{"actor":{"display_login":"joachimmetz"}}