{"action":"created","comment":{"url":"https://api.github.com/repos/php/php-src/pulls/comments/110327521","pull_request_review_id":31492895,"id":110327521,"diff_hunk":"@@ -0,0 +1,33 @@\n+--TEST--\n+Test frenchtojd() function : error conditions\n+--CREDITS--\n+edgarsandi - <edgar.r.sandi@gmail.com>\n+--SKIPIF--\n+<?php include 'skipif.inc'; ?>\n+--FILE--\n+<?php\n+var_dump(frenchtojd());\n+var_dump(frenchtojd(\"A\"));\n+var_dump(frenchtojd(\"A\", \"B\"));\n+var_dump(frenchtojd(\"A\", \"B\", \"C\"));\n+var_dump(frenchtojd(1, \"B\", \"C\"));\n+var_dump(frenchtojd(1, 4, \"C\"));","path":"ext/calendar/tests/frenchtojd_error1.phpt","position":14,"original_position":14,"commit_id":"c4eedd36776f9f2f3f11a6b7d251a655749ed75f","original_commit_id":"c4eedd36776f9f2f3f11a6b7d251a655749ed75f","user":{"login":"krakjoe","id":2236138,"avatar_url":"https://avatars1.githubusercontent.com/u/2236138?v=3","gravatar_id":"","url":"https://api.github.com/users/krakjoe","html_url":"https://github.com/krakjoe","followers_url":"https://api.github.com/users/krakjoe/followers","following_url":"https://api.github.com/users/krakjoe/following{/other_user}","gists_url":"https://api.github.com/users/krakjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/krakjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krakjoe/subscriptions","organizations_url":"https://api.github.com/users/krakjoe/orgs","repos_url":"https://api.github.com/users/krakjoe/repos","events_url":"https://api.github.com/users/krakjoe/events{/privacy}","received_events_url":"https://api.github.com/users/krakjoe/received_events","type":"User","site_admin":false},"body":"this is testing zpp, not necessary ...","created_at":"2017-04-07T07:05:43Z","updated_at":"2017-04-07T07:05:43Z","html_url":"https://github.com/php/php-src/pull/2456#discussion_r110327521","pull_request_url":"https://api.github.com/repos/php/php-src/pulls/2456","_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/110327521"},"html":{"href":"https://github.com/php/php-src/pull/2456#discussion_r110327521"},"pull_request":{"href":"https://api.github.com/repos/php/php-src/pulls/2456"}}},"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/2456","id":114741808,"html_url":"https://github.com/php/php-src/pull/2456","diff_url":"https://github.com/php/php-src/pull/2456.diff","patch_url":"https://github.com/php/php-src/pull/2456.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/2456","number":2456,"state":"open","locked":false,"title":"Increase calendar extension coverage tests","user":{"login":"edgarsandi","id":2199147,"avatar_url":"https://avatars1.githubusercontent.com/u/2199147?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarsandi","html_url":"https://github.com/edgarsandi","followers_url":"https://api.github.com/users/edgarsandi/followers","following_url":"https://api.github.com/users/edgarsandi/following{/other_user}","gists_url":"https://api.github.com/users/edgarsandi/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarsandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarsandi/subscriptions","organizations_url":"https://api.github.com/users/edgarsandi/orgs","repos_url":"https://api.github.com/users/edgarsandi/repos","events_url":"https://api.github.com/users/edgarsandi/events{/privacy}","received_events_url":"https://api.github.com/users/edgarsandi/received_events","type":"User","site_admin":false},"body":"The main purpose of this PR is to cover more rows (increasead in more than 60 coveraged rows) in the calendar extension ( `/ext/calendar/`).\r\n\r\nBut to maintain a pattern and coherence in the warning messages, I made some changes (6 lines) in the `ext/calendar/calendar.c`, basically removing the dot located in the middle of message.\r\n\r\nAnd finaly, two phpt file tests of `cal_days_in_month` (a `ext/calendar` function) from `/ext/date/` was moved to `/ext/calendar/`","created_at":"2017-04-07T04:29:12Z","updated_at":"2017-04-07T07:05:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e6268c34662773bbbd9260761f4199d1390e09b","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/2456/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/2456/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php/php-src/issues/2456/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/c4eedd36776f9f2f3f11a6b7d251a655749ed75f","head":{"label":"edgarsandi:increase-calendar-extension-coverage-tests","ref":"increase-calendar-extension-coverage-tests","sha":"c4eedd36776f9f2f3f11a6b7d251a655749ed75f","user":{"login":"edgarsandi","id":2199147,"avatar_url":"https://avatars1.githubusercontent.com/u/2199147?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarsandi","html_url":"https://github.com/edgarsandi","followers_url":"https://api.github.com/users/edgarsandi/followers","following_url":"https://api.github.com/users/edgarsandi/following{/other_user}","gists_url":"https://api.github.com/users/edgarsandi/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarsandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarsandi/subscriptions","organizations_url":"https://api.github.com/users/edgarsandi/orgs","repos_url":"https://api.github.com/users/edgarsandi/repos","events_url":"https://api.github.com/users/edgarsandi/events{/privacy}","received_events_url":"https://api.github.com/users/edgarsandi/received_events","type":"User","site_admin":false},"repo":{"id":38046055,"name":"php-src","full_name":"edgarsandi/php-src","owner":{"login":"edgarsandi","id":2199147,"avatar_url":"https://avatars1.githubusercontent.com/u/2199147?v=3","gravatar_id":"","url":"https://api.github.com/users/edgarsandi","html_url":"https://github.com/edgarsandi","followers_url":"https://api.github.com/users/edgarsandi/followers","following_url":"https://api.github.com/users/edgarsandi/following{/other_user}","gists_url":"https://api.github.com/users/edgarsandi/gists{/gist_id}","starred_url":"https://api.github.com/users/edgarsandi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edgarsandi/subscriptions","organizations_url":"https://api.github.com/users/edgarsandi/orgs","repos_url":"https://api.github.com/users/edgarsandi/repos","events_url":"https://api.github.com/users/edgarsandi/events{/privacy}","received_events_url":"https://api.github.com/users/edgarsandi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/edgarsandi/php-src","description":"The PHP Interpreter","fork":true,"url":"https://api.github.com/repos/edgarsandi/php-src","forks_url":"https://api.github.com/repos/edgarsandi/php-src/forks","keys_url":"https://api.github.com/repos/edgarsandi/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edgarsandi/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edgarsandi/php-src/teams","hooks_url":"https://api.github.com/repos/edgarsandi/php-src/hooks","issue_events_url":"https://api.github.com/repos/edgarsandi/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/edgarsandi/php-src/events","assignees_url":"https://api.github.com/repos/edgarsandi/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/edgarsandi/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/edgarsandi/php-src/tags","blobs_url":"https://api.github.com/repos/edgarsandi/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edgarsandi/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edgarsandi/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/edgarsandi/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edgarsandi/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/edgarsandi/php-src/languages","stargazers_url":"https://api.github.com/repos/edgarsandi/php-src/stargazers","contributors_url":"https://api.github.com/repos/edgarsandi/php-src/contributors","subscribers_url":"https://api.github.com/repos/edgarsandi/php-src/subscribers","subscription_url":"https://api.github.com/repos/edgarsandi/php-src/subscription","commits_url":"https://api.github.com/repos/edgarsandi/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/edgarsandi/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/edgarsandi/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/edgarsandi/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/edgarsandi/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/edgarsandi/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edgarsandi/php-src/merges","archive_url":"https://api.github.com/repos/edgarsandi/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edgarsandi/php-src/downloads","issues_url":"https://api.github.com/repos/edgarsandi/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/edgarsandi/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/edgarsandi/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/edgarsandi/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edgarsandi/php-src/labels{/name}","releases_url":"https://api.github.com/repos/edgarsandi/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/edgarsandi/php-src/deployments","created_at":"2015-06-25T11:41:53Z","updated_at":"2016-01-27T12:10:00Z","pushed_at":"2017-04-07T04:10:18Z","git_url":"git://github.com/edgarsandi/php-src.git","ssh_url":"git@github.com:edgarsandi/php-src.git","clone_url":"https://github.com/edgarsandi/php-src.git","svn_url":"https://github.com/edgarsandi/php-src","homepage":"http://www.php.net","size":281028,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"67136fe77b24e59b185775ec308d81235666aaf9","user":{"login":"php","id":25158,"avatar_url":"https://avatars1.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"name":"php-src","full_name":"php/php-src","owner":{"login":"php","id":25158,"avatar_url":"https://avatars1.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/php/php-src/deployments","created_at":"2011-06-16T01:52:25Z","updated_at":"2017-04-07T06:46:34Z","pushed_at":"2017-04-07T04:29:13Z","git_url":"git://github.com/php/php-src.git","ssh_url":"git@github.com:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":281091,"stargazers_count":11672,"watchers_count":11672,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3934,"mirror_url":null,"open_issues_count":102,"forks":3934,"open_issues":102,"watchers":11672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/2456"},"html":{"href":"https://github.com/php/php-src/pull/2456"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/2456"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/2456/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/2456/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/2456/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/c4eedd36776f9f2f3f11a6b7d251a655749ed75f"}}}}
{"actor":{"display_login":"krakjoe"}}