{"action":"created","comment":{"url":"https://api.github.com/repos/ggravlingen/pytradfri/pulls/comments/147554115","pull_request_review_id":72671427,"id":147554115,"diff_hunk":"@@ -227,3 +228,13 @@ def test_color_device_control():\n     assert light_control.can_set_kelvin\n     assert light_control.min_kelvin == 1667\n     assert light_control.max_kelvin == 25000\n+\n+\n+def test_setters():\n+    cmd = Device(LIGHT_CWS).light_control \\\n+        .set_predefined_color('Warm glow')\n+    assert cmd.data == {'3311': [{'5706': 'efd275'}]}\n+\n+    cmd = Device(LIGHT_CWS).light_control \\\n+        .set_predefined_color('Ggravlingen')\n+    assert hasattr(cmd, data) == False","path":"tests/test_light.py","position":20,"original_position":20,"commit_id":"97c0cfc3520655434a66fa4d6ca81de4bad107e3","original_commit_id":"97c0cfc3520655434a66fa4d6ca81de4bad107e3","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"undefined name 'data'<br>comparison to False should be 'if cond is False:' or 'if not cond:'","created_at":"2017-10-28T13:10:42Z","updated_at":"2017-10-28T13:10:42Z","html_url":"https://github.com/ggravlingen/pytradfri/pull/78#discussion_r147554115","pull_request_url":"https://api.github.com/repos/ggravlingen/pytradfri/pulls/78","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ggravlingen/pytradfri/pulls/comments/147554115"},"html":{"href":"https://github.com/ggravlingen/pytradfri/pull/78#discussion_r147554115"},"pull_request":{"href":"https://api.github.com/repos/ggravlingen/pytradfri/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/ggravlingen/pytradfri/pulls/78","id":149321192,"html_url":"https://github.com/ggravlingen/pytradfri/pull/78","diff_url":"https://github.com/ggravlingen/pytradfri/pull/78.diff","patch_url":"https://github.com/ggravlingen/pytradfri/pull/78.patch","issue_url":"https://api.github.com/repos/ggravlingen/pytradfri/issues/78","number":78,"state":"open","locked":false,"title":"Fixing device.py so that Travis doesn't fail, added test and support for coverall","user":{"login":"ggravlingen","id":21142447,"avatar_url":"https://avatars1.githubusercontent.com/u/21142447?v=4","gravatar_id":"","url":"https://api.github.com/users/ggravlingen","html_url":"https://github.com/ggravlingen","followers_url":"https://api.github.com/users/ggravlingen/followers","following_url":"https://api.github.com/users/ggravlingen/following{/other_user}","gists_url":"https://api.github.com/users/ggravlingen/gists{/gist_id}","starred_url":"https://api.github.com/users/ggravlingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggravlingen/subscriptions","organizations_url":"https://api.github.com/users/ggravlingen/orgs","repos_url":"https://api.github.com/users/ggravlingen/repos","events_url":"https://api.github.com/users/ggravlingen/events{/privacy}","received_events_url":"https://api.github.com/users/ggravlingen/received_events","type":"User","site_admin":false},"body":"In the current prod version of the code, Travis throws an error in device.py (#76). Oddly, the error wasn't there when the affected lines of code was first merged. This is a fix for that error so that Travis can build again.\r\n\r\nI've also added a test for the set_predefined_color-method and support for coverall.","created_at":"2017-10-28T06:19:28Z","updated_at":"2017-10-28T13:10:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4943d380f0136f299c2878a5a3e0b7aef43f98be","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lwis","id":873275,"avatar_url":"https://avatars0.githubusercontent.com/u/873275?v=4","gravatar_id":"","url":"https://api.github.com/users/lwis","html_url":"https://github.com/lwis","followers_url":"https://api.github.com/users/lwis/followers","following_url":"https://api.github.com/users/lwis/following{/other_user}","gists_url":"https://api.github.com/users/lwis/gists{/gist_id}","starred_url":"https://api.github.com/users/lwis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lwis/subscriptions","organizations_url":"https://api.github.com/users/lwis/orgs","repos_url":"https://api.github.com/users/lwis/repos","events_url":"https://api.github.com/users/lwis/events{/privacy}","received_events_url":"https://api.github.com/users/lwis/received_events","type":"User","site_admin":false},{"login":"balloob","id":1444314,"avatar_url":"https://avatars3.githubusercontent.com/u/1444314?v=4","gravatar_id":"","url":"https://api.github.com/users/balloob","html_url":"https://github.com/balloob","followers_url":"https://api.github.com/users/balloob/followers","following_url":"https://api.github.com/users/balloob/following{/other_user}","gists_url":"https://api.github.com/users/balloob/gists{/gist_id}","starred_url":"https://api.github.com/users/balloob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balloob/subscriptions","organizations_url":"https://api.github.com/users/balloob/orgs","repos_url":"https://api.github.com/users/balloob/repos","events_url":"https://api.github.com/users/balloob/events{/privacy}","received_events_url":"https://api.github.com/users/balloob/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ggravlingen/pytradfri/pulls/78/commits","review_comments_url":"https://api.github.com/repos/ggravlingen/pytradfri/pulls/78/comments","review_comment_url":"https://api.github.com/repos/ggravlingen/pytradfri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ggravlingen/pytradfri/issues/78/comments","statuses_url":"https://api.github.com/repos/ggravlingen/pytradfri/statuses/97c0cfc3520655434a66fa4d6ca81de4bad107e3","head":{"label":"ggravlingen:fixdevice","ref":"fixdevice","sha":"97c0cfc3520655434a66fa4d6ca81de4bad107e3","user":{"login":"ggravlingen","id":21142447,"avatar_url":"https://avatars1.githubusercontent.com/u/21142447?v=4","gravatar_id":"","url":"https://api.github.com/users/ggravlingen","html_url":"https://github.com/ggravlingen","followers_url":"https://api.github.com/users/ggravlingen/followers","following_url":"https://api.github.com/users/ggravlingen/following{/other_user}","gists_url":"https://api.github.com/users/ggravlingen/gists{/gist_id}","starred_url":"https://api.github.com/users/ggravlingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggravlingen/subscriptions","organizations_url":"https://api.github.com/users/ggravlingen/orgs","repos_url":"https://api.github.com/users/ggravlingen/repos","events_url":"https://api.github.com/users/ggravlingen/events{/privacy}","received_events_url":"https://api.github.com/users/ggravlingen/received_events","type":"User","site_admin":false},"repo":{"id":87844301,"name":"pytradfri","full_name":"ggravlingen/pytradfri","owner":{"login":"ggravlingen","id":21142447,"avatar_url":"https://avatars1.githubusercontent.com/u/21142447?v=4","gravatar_id":"","url":"https://api.github.com/users/ggravlingen","html_url":"https://github.com/ggravlingen","followers_url":"https://api.github.com/users/ggravlingen/followers","following_url":"https://api.github.com/users/ggravlingen/following{/other_user}","gists_url":"https://api.github.com/users/ggravlingen/gists{/gist_id}","starred_url":"https://api.github.com/users/ggravlingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggravlingen/subscriptions","organizations_url":"https://api.github.com/users/ggravlingen/orgs","repos_url":"https://api.github.com/users/ggravlingen/repos","events_url":"https://api.github.com/users/ggravlingen/events{/privacy}","received_events_url":"https://api.github.com/users/ggravlingen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ggravlingen/pytradfri","description":"Control and observe your IKEA Trådfri (Tradfri) white or RGB light devices from Python. Example script available to quickly get started. Sans-io.","fork":false,"url":"https://api.github.com/repos/ggravlingen/pytradfri","forks_url":"https://api.github.com/repos/ggravlingen/pytradfri/forks","keys_url":"https://api.github.com/repos/ggravlingen/pytradfri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ggravlingen/pytradfri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ggravlingen/pytradfri/teams","hooks_url":"https://api.github.com/repos/ggravlingen/pytradfri/hooks","issue_events_url":"https://api.github.com/repos/ggravlingen/pytradfri/issues/events{/number}","events_url":"https://api.github.com/repos/ggravlingen/pytradfri/events","assignees_url":"https://api.github.com/repos/ggravlingen/pytradfri/assignees{/user}","branches_url":"https://api.github.com/repos/ggravlingen/pytradfri/branches{/branch}","tags_url":"https://api.github.com/repos/ggravlingen/pytradfri/tags","blobs_url":"https://api.github.com/repos/ggravlingen/pytradfri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ggravlingen/pytradfri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ggravlingen/pytradfri/git/refs{/sha}","trees_url":"https://api.github.com/repos/ggravlingen/pytradfri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ggravlingen/pytradfri/statuses/{sha}","languages_url":"https://api.github.com/repos/ggravlingen/pytradfri/languages","stargazers_url":"https://api.github.com/repos/ggravlingen/pytradfri/stargazers","contributors_url":"https://api.github.com/repos/ggravlingen/pytradfri/contributors","subscribers_url":"https://api.github.com/repos/ggravlingen/pytradfri/subscribers","subscription_url":"https://api.github.com/repos/ggravlingen/pytradfri/subscription","commits_url":"https://api.github.com/repos/ggravlingen/pytradfri/commits{/sha}","git_commits_url":"https://api.github.com/repos/ggravlingen/pytradfri/git/commits{/sha}","comments_url":"https://api.github.com/repos/ggravlingen/pytradfri/comments{/number}","issue_comment_url":"https://api.github.com/repos/ggravlingen/pytradfri/issues/comments{/number}","contents_url":"https://api.github.com/repos/ggravlingen/pytradfri/contents/{+path}","compare_url":"https://api.github.com/repos/ggravlingen/pytradfri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ggravlingen/pytradfri/merges","archive_url":"https://api.github.com/repos/ggravlingen/pytradfri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ggravlingen/pytradfri/downloads","issues_url":"https://api.github.com/repos/ggravlingen/pytradfri/issues{/number}","pulls_url":"https://api.github.com/repos/ggravlingen/pytradfri/pulls{/number}","milestones_url":"https://api.github.com/repos/ggravlingen/pytradfri/milestones{/number}","notifications_url":"https://api.github.com/repos/ggravlingen/pytradfri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ggravlingen/pytradfri/labels{/name}","releases_url":"https://api.github.com/repos/ggravlingen/pytradfri/releases{/id}","deployments_url":"https://api.github.com/repos/ggravlingen/pytradfri/deployments","created_at":"2017-04-10T18:30:17Z","updated_at":"2017-10-26T20:39:13Z","pushed_at":"2017-10-28T13:10:37Z","git_url":"git://github.com/ggravlingen/pytradfri.git","ssh_url":"git@github.com:ggravlingen/pytradfri.git","clone_url":"https://github.com/ggravlingen/pytradfri.git","svn_url":"https://github.com/ggravlingen/pytradfri","homepage":"","size":290,"stargazers_count":218,"watchers_count":218,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":7,"forks":33,"open_issues":7,"watchers":218,"default_branch":"master"}},"base":{"label":"ggravlingen:master","ref":"master","sha":"e065d0ff21701c10eed1cc5bdbe74375af3cb74a","user":{"login":"ggravlingen","id":21142447,"avatar_url":"https://avatars1.githubusercontent.com/u/21142447?v=4","gravatar_id":"","url":"https://api.github.com/users/ggravlingen","html_url":"https://github.com/ggravlingen","followers_url":"https://api.github.com/users/ggravlingen/followers","following_url":"https://api.github.com/users/ggravlingen/following{/other_user}","gists_url":"https://api.github.com/users/ggravlingen/gists{/gist_id}","starred_url":"https://api.github.com/users/ggravlingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggravlingen/subscriptions","organizations_url":"https://api.github.com/users/ggravlingen/orgs","repos_url":"https://api.github.com/users/ggravlingen/repos","events_url":"https://api.github.com/users/ggravlingen/events{/privacy}","received_events_url":"https://api.github.com/users/ggravlingen/received_events","type":"User","site_admin":false},"repo":{"id":87844301,"name":"pytradfri","full_name":"ggravlingen/pytradfri","owner":{"login":"ggravlingen","id":21142447,"avatar_url":"https://avatars1.githubusercontent.com/u/21142447?v=4","gravatar_id":"","url":"https://api.github.com/users/ggravlingen","html_url":"https://github.com/ggravlingen","followers_url":"https://api.github.com/users/ggravlingen/followers","following_url":"https://api.github.com/users/ggravlingen/following{/other_user}","gists_url":"https://api.github.com/users/ggravlingen/gists{/gist_id}","starred_url":"https://api.github.com/users/ggravlingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ggravlingen/subscriptions","organizations_url":"https://api.github.com/users/ggravlingen/orgs","repos_url":"https://api.github.com/users/ggravlingen/repos","events_url":"https://api.github.com/users/ggravlingen/events{/privacy}","received_events_url":"https://api.github.com/users/ggravlingen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ggravlingen/pytradfri","description":"Control and observe your IKEA Trådfri (Tradfri) white or RGB light devices from Python. Example script available to quickly get started. Sans-io.","fork":false,"url":"https://api.github.com/repos/ggravlingen/pytradfri","forks_url":"https://api.github.com/repos/ggravlingen/pytradfri/forks","keys_url":"https://api.github.com/repos/ggravlingen/pytradfri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ggravlingen/pytradfri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ggravlingen/pytradfri/teams","hooks_url":"https://api.github.com/repos/ggravlingen/pytradfri/hooks","issue_events_url":"https://api.github.com/repos/ggravlingen/pytradfri/issues/events{/number}","events_url":"https://api.github.com/repos/ggravlingen/pytradfri/events","assignees_url":"https://api.github.com/repos/ggravlingen/pytradfri/assignees{/user}","branches_url":"https://api.github.com/repos/ggravlingen/pytradfri/branches{/branch}","tags_url":"https://api.github.com/repos/ggravlingen/pytradfri/tags","blobs_url":"https://api.github.com/repos/ggravlingen/pytradfri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ggravlingen/pytradfri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ggravlingen/pytradfri/git/refs{/sha}","trees_url":"https://api.github.com/repos/ggravlingen/pytradfri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ggravlingen/pytradfri/statuses/{sha}","languages_url":"https://api.github.com/repos/ggravlingen/pytradfri/languages","stargazers_url":"https://api.github.com/repos/ggravlingen/pytradfri/stargazers","contributors_url":"https://api.github.com/repos/ggravlingen/pytradfri/contributors","subscribers_url":"https://api.github.com/repos/ggravlingen/pytradfri/subscribers","subscription_url":"https://api.github.com/repos/ggravlingen/pytradfri/subscription","commits_url":"https://api.github.com/repos/ggravlingen/pytradfri/commits{/sha}","git_commits_url":"https://api.github.com/repos/ggravlingen/pytradfri/git/commits{/sha}","comments_url":"https://api.github.com/repos/ggravlingen/pytradfri/comments{/number}","issue_comment_url":"https://api.github.com/repos/ggravlingen/pytradfri/issues/comments{/number}","contents_url":"https://api.github.com/repos/ggravlingen/pytradfri/contents/{+path}","compare_url":"https://api.github.com/repos/ggravlingen/pytradfri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ggravlingen/pytradfri/merges","archive_url":"https://api.github.com/repos/ggravlingen/pytradfri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ggravlingen/pytradfri/downloads","issues_url":"https://api.github.com/repos/ggravlingen/pytradfri/issues{/number}","pulls_url":"https://api.github.com/repos/ggravlingen/pytradfri/pulls{/number}","milestones_url":"https://api.github.com/repos/ggravlingen/pytradfri/milestones{/number}","notifications_url":"https://api.github.com/repos/ggravlingen/pytradfri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ggravlingen/pytradfri/labels{/name}","releases_url":"https://api.github.com/repos/ggravlingen/pytradfri/releases{/id}","deployments_url":"https://api.github.com/repos/ggravlingen/pytradfri/deployments","created_at":"2017-04-10T18:30:17Z","updated_at":"2017-10-26T20:39:13Z","pushed_at":"2017-10-28T13:10:37Z","git_url":"git://github.com/ggravlingen/pytradfri.git","ssh_url":"git@github.com:ggravlingen/pytradfri.git","clone_url":"https://github.com/ggravlingen/pytradfri.git","svn_url":"https://github.com/ggravlingen/pytradfri","homepage":"","size":290,"stargazers_count":218,"watchers_count":218,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":7,"forks":33,"open_issues":7,"watchers":218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ggravlingen/pytradfri/pulls/78"},"html":{"href":"https://github.com/ggravlingen/pytradfri/pull/78"},"issue":{"href":"https://api.github.com/repos/ggravlingen/pytradfri/issues/78"},"comments":{"href":"https://api.github.com/repos/ggravlingen/pytradfri/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/ggravlingen/pytradfri/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/ggravlingen/pytradfri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ggravlingen/pytradfri/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/ggravlingen/pytradfri/statuses/97c0cfc3520655434a66fa4d6ca81de4bad107e3"}},"author_association":"OWNER"}}
{"actor":{"display_login":"houndci-bot"}}